27 Jan
2021
27 Jan
'21
9:49 a.m.
@wkampich - it seems that the PR is now removing the
kamctl tool completely from the git repo. I guess you didn't want that.
At the end, you can push changes to lost module as you want, because you are the
developer of the module. Of course, you can do PR whenever you want the review from other
developers. Only for patches/commits to other modules/components is good to have PR.
@miconda removing kamctl from the repo was not the intention ... sometimes it is better
not to do things quickly on the side. The idea of the PR was just to get some feedback
regarding #2606 before pushing changes to lost module. I would agree to remove the PR
rather than merge it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2606#issuecomment-768336527