Re: [sr-dev] registrar - additional features

Hi, made this commit to the pull request. i think it answers all questions, comments appreciated. registrar - match changes add param match_flags bit mask 1 callid 2 received 3 contact add param match_return_flags - bit mask 1 add contact xavp in registered adds or sets into the transaction in reg_fetch_contacts adds to plc structure changes to registered check the match_flags bit mask value and tries to find correspondent field in xavp_cfg matches with the fields found also looks for match_flags, match_return_flags in xavp_cfg to override the params preserves existing behaviour removes reg_callid_avp From: sr-dev [sr-dev-bounces(a)lists.sip-router.org] on behalf of Luis Azedo [luis(a)2600hz.com] Sent: Wednesday, February 18, 2015 4:44 AM To: miconda(a)gmail.com; Kamailio (SER) - Development Mailing List Subject: Re: [sr-dev] registrar - additional features Hi Daniel, thank you for the contribution. see inline From: sr-dev [sr-dev-bounces(a)lists.sip-router.org] on behalf of Daniel-Constantin Mierla [miconda(a)gmail.com] Sent: Wednesday, February 18, 2015 3:51 AM To: Kamailio (SER) - Development Mailing List Subject: Re: [sr-dev] registrar - additional features Hello, some comments inline. On 17/02/15 23:25, Luis Azedo wrote: will this add the xavp only for first valid contact found in location table? Or for all contacts (e.g., when a user is registered with many phones)? A : it will add the xavp for the first contact found since registered function exits on first match. I see that the match on call-id was added by Henning back in 2008, haven't used it. My concern here is about adding too many avps parameters which can endup in loops across the list of avps to see if they are defined or not. I am thinking of having a different implementation that is better in terms of performances and flexibility, like: - extend the registered parameters to take one more as flags - here will be a bitmask of what matching rules to be applied (e.g., 1 - callid matching, 2 - received matching, 4 - contact matching) - add the values for matching as part of xavp_cfg avp (e.g., say xavp_cfg is set to 'reg', then will be $xavp(reg=>match_callid) = "..."; $xavp(reg=>match_received) = "..." ...) Practically the search for the values to be match will be done only if the appropriate flag is set. The avp for matching call id should be removed. In the future, adding another matching rule will be adding a new flag and an inner attribute/value for xavp_cfg. What do you think? A : i like this approach. trying that. I think this can be done also conditionally -- I would add a new parameter to reg_fetch_contacts where we can specify this behaviour as a flag. A : instead of a parameter, we could add a parameter "return_xavp_on_match" (or better naming) that would control the addition of the xavp in registered and reg_fetch_contacts. in reg_fetch_contacts the xavp is returned for each contact (not like in registered). i added it since we are already doing it in the lookup and lookup_to_dset. Thanks for these contributions and let's see if others have other ideas or commends on my proposal to get to a solution that is fair from performance/feature ratio point of view. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com _______________________________________________ sr-dev mailing list sr-dev(a)lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev