3 Jul
2009
3 Jul
'09
1:02 p.m.
On Jul 03, 2009 at 18:45, Daniel-Constantin Mierla <miconda(a)gmail.com> wrote:
On 07/03/2009 06:36 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
from my point of view, all are script variables: avps, references to sip
message parts, etc ... therefore the have to start with same char, and
most of the programming languages use $ for that. It is what was decided
long time ago in openser when pseudo-variables were introduced in core. whose confusion?
like the discussion on lookup_domain function revealed, it is confusing
that the same prefix ($ char) is used for two different things.
From my point of view the only things that are close to
variables are
the avps and the script vars. All the others are in fact hidden
function
calls and should be syntactically different.
Basically, there are classes of script variables, some accepting dynamic
names (like avps $avp(...), headers $hdr(...), private $var(...) and
shared variables $sht(...) a.s.o.).
I do not see reason for a special character for certain classes, like
avp or select. It is much much clearer to have:
$avp(name)
$sel(name)
We should use $ only for variables (like any other script language out
there). This doesn't mean avps though. The avps should be accessed in
some other distinct way. avps are both slow and they consume memory, so
their use as script vars should be discouraged.
rather than:
$name for avps
@name for selects
&name, %name etc. for what so ever variable class
I would use '$' only for fast script vars (that should be declared at
the beginning of the script and would be typed), and some function like
construct for the other (e.g. $var=sel("from.uri")).
Andrei