[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: regpv fix (PR #4166)

@lyatanski commented on this pull request.

@@ -440,7 +451,15 @@ int pv_fetch_contacts(

return -1; }

- ptr = 0; //r->contacts;TODO + rpp->impi.s = (char *)pkg_malloc(r->private_identity.len * sizeof(char)); + if(rpp->impi.s == NULL) { + LM_ERR("no mem for impi\n"); + return -1;

yes, I have done it using AOR as example. I'm not sure if it is going to be a problem as in the config script we should have `reg_free_contacts("caller");` and even in failure case it should free the memory.

Anyway, if you recommend to use `goto error;` instead, I have no objections and I'll change it in both places. Please confirm.