27 Jan
2021
27 Jan
'21
12:31 p.m.
@wkampich regarding the code implementation - i looked
also briefly into it. You took over some code from the enum module. If this is done copy
and paste way, i.e. the same code in the enum module, we should probably think about
moving this to the core. If you modified the code in different places, then probably the
copyright notice of the original module needs to be added as well to your code.
Close this PR, as discussed in previous comments.
@henningw There are indeed some functions copied from enum, perhaps it is good idea to
have common NAPTR lookup utilities in the core.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2606#issuecomment-768448863