sr-dev

sr-dev@lists.kamailio.org

12 participants
44199 discussions

git:master:944b1062: htable: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 944b1062bc7660d86048ab6a769183e40181f07a URL: https://github.com/kamailio/kamailio/commit/944b1062bc7660d86048ab6a769183e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 htable: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/944b1062bc7660d86048ab6a769183e… Patch: https://github.com/kamailio/kamailio/commit/944b1062bc7660d86048ab6a769183e… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 090474b189b..48f9e1c7724 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -341,7 +341,6 @@ static void destroy(void) } } } - ht_destroy(); } /**

1 month, 3 weeks

git:master:5f8f4fad: presence: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5f8f4fade15e9b2950f503b2ec5bb49a326a4fc0 URL: https://github.com/kamailio/kamailio/commit/5f8f4fade15e9b2950f503b2ec5bb49… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 presence: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/presence/presence.c --- Diff: https://github.com/kamailio/kamailio/commit/5f8f4fade15e9b2950f503b2ec5bb49… Patch: https://github.com/kamailio/kamailio/commit/5f8f4fade15e9b2950f503b2ec5bb49… --- diff --git a/src/modules/presence/presence.c b/src/modules/presence/presence.c index 9e1b6288d88..4f1c1380e2c 100644 --- a/src/modules/presence/presence.c +++ b/src/modules/presence/presence.c @@ -635,26 +635,6 @@ static void destroy(void) } else timer_db_update(0, 0); } - - if(subs_htable) { - destroy_shtable(subs_htable, shtable_size); - } - - if(pres_htable) { - destroy_phtable(); - } - - if(pa_db && pa_dbf.close) { - pa_dbf.close(pa_db); - } - - if(pres_notifier_id != NULL) { - shm_free(pres_notifier_id); - } - - destroy_evlist(); - - ps_ptable_destroy(); } static int fixup_presence(void **param, int param_no)

1 month, 3 weeks

git:master:4347f147: pua: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4347f1470057ba8a3c7cf8f179a814163c38d34e URL: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 pua: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/pua/pua.c --- Diff: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141… Patch: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141… --- diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index 9b174dcdb6e..515abe0dc4c 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -296,21 +296,13 @@ static int child_init(int rank) static void destroy(void) { - if(puacb_list) - destroy_puacb_list(); - /* if dbmode is PUA_DB_ONLY, then HashT will be NULL * so db_update and destroy_htable won't get called */ if(pua_db && HashT) db_update(0, 0); - if(HashT) - destroy_htable(); - if(pua_db) pua_dbf.close(pua_db); - if(pua_evlist) - destroy_pua_evlist(); return; }

1 month, 3 weeks

git:master:e409ad5b: dialog: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e409ad5bc13b23ec171d9b66f937cd75731099c3 URL: https://github.com/kamailio/kamailio/commit/e409ad5bc13b23ec171d9b66f937cd7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 dialog: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/e409ad5bc13b23ec171d9b66f937cd7… Patch: https://github.com/kamailio/kamailio/commit/e409ad5bc13b23ec171d9b66f937cd7… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 80dee60c75b..772beb0fe0b 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -856,14 +856,6 @@ static void mod_destroy(void) dialog_update_db(0, 0); destroy_dlg_db(); } - dlg_bridge_destroy_hdrs(); - /* no DB interaction from now on */ - dlg_db_mode = DB_MODE_NONE; - destroy_dlg_table(); - destroy_dlg_timer(); - destroy_dlg_callbacks(DLGCB_CREATED | DLGCB_LOADED); - destroy_dlg_handlers(); - destroy_dlg_profiles(); }

1 month, 3 weeks

git:master:d4e3f7f1: tm: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d4e3f7f125cea1f8874b858324a804e6b743bb1c URL: https://github.com/kamailio/kamailio/commit/d4e3f7f125cea1f8874b858324a804e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 tm: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/tm/t_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/d4e3f7f125cea1f8874b858324a804e… Patch: https://github.com/kamailio/kamailio/commit/d4e3f7f125cea1f8874b858324a804e… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index 68f56567e91..b19f2758aef 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -87,23 +87,6 @@ int send_pr_buffer(struct retr_buf *rb, void *buf, int len void tm_shutdown() { - - LM_DBG("start\n"); - -#ifdef USE_DNS_FAILOVER - if(failover_reply_codes) - shm_free(failover_reply_codes); - if(failover_reply_codes_cnt) - shm_free(failover_reply_codes_cnt); -#endif - /* destroy the hash table */ - LM_DBG("emptying hash table\n"); - free_hash_table(); - LM_DBG("removing semaphores\n"); - lock_cleanup(); - LM_DBG("destroying tmcb lists\n"); - destroy_tmcb_lists(); - free_tm_stats(); LM_DBG("done\n"); }

1 month, 3 weeks

git:master:d56b7ee4: usrloc: remove destroy of internal structures on mod-destroy callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d56b7ee42fffe9635bb0fde8427c9ec447a0f771 URL: https://github.com/kamailio/kamailio/commit/d56b7ee42fffe9635bb0fde8427c9ec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-20T12:08:54+01:00 usrloc: remove destroy of internal structures on mod-destroy callback - it is safer and faster to be removed at once by core or OS when application context is destroyed --- Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d56b7ee42fffe9635bb0fde8427c9ec… Patch: https://github.com/kamailio/kamailio/commit/d56b7ee42fffe9635bb0fde8427c9ec… --- diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c index b3fe462a1d5..932c0fd5f1d 100644 --- a/src/modules/usrloc/usrloc_mod.c +++ b/src/modules/usrloc/usrloc_mod.c @@ -561,13 +561,7 @@ static void destroy(void) if(synchronize_all_udomains(0, 1) != 0) { LM_ERR("flushing cache failed\n"); } - ul_dbf.close(ul_dbh); } - - free_all_udomains(); - - /* free callbacks list */ - destroy_ulcb_list(); } /*! \brief

1 month, 3 weeks

git:master:fbfe3442: xcap_server: reformat exported structures

by Victor Seva

Module: kamailio Branch: master Commit: fbfe344247bf30cad43c47fe6fc35afda1b7a796 URL: https://github.com/kamailio/kamailio/commit/fbfe344247bf30cad43c47fe6fc35af… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-11-20T11:56:45+01:00 xcap_server: reformat exported structures --- Modified: src/modules/xcap_server/xcap_server.c --- Diff: https://github.com/kamailio/kamailio/commit/fbfe344247bf30cad43c47fe6fc35af… Patch: https://github.com/kamailio/kamailio/commit/fbfe344247bf30cad43c47fe6fc35af… --- diff --git a/src/modules/xcap_server/xcap_server.c b/src/modules/xcap_server/xcap_server.c index 75267575fdc..6feef732117 100644 --- a/src/modules/xcap_server/xcap_server.c +++ b/src/modules/xcap_server/xcap_server.c @@ -106,42 +106,45 @@ db_func_t xcaps_dbf; /** SL API structure */ sl_api_t slb; +/* clang-format off */ static pv_export_t mod_pvs[] = { - {{"xcapuri", sizeof("xcapuri") - 1}, PVT_OTHER, pv_get_xcap_uri, - pv_set_xcap_uri, pv_parse_xcap_uri_name, 0, 0, 0}, - {{0, 0}, 0, 0, 0, 0, 0, 0, 0}}; - -static param_export_t params[] = {{"db_url", PARAM_STR, &xcaps_db_url}, - {"xcap_table", PARAM_STR, &xcaps_db_table}, - {"xcap_root", PARAM_STR, &xcaps_root}, - {"buf_size", PARAM_INT, &xcaps_buf.len}, - {"xml_ns", PARAM_STRING | PARAM_USE_FUNC, (void *)xcaps_xpath_ns_param}, - {"directory_scheme", PARAM_INT, &xcaps_directory_scheme}, - {"directory_hostname", PARAM_STR, &xcaps_directory_hostname}, - {0, 0, 0}}; - -static cmd_export_t cmds[] = {{"xcaps_put", (cmd_function)w_xcaps_put, 3, - fixup_xcaps_put, 0, REQUEST_ROUTE}, - {"xcaps_get", (cmd_function)w_xcaps_get, 2, fixup_xcaps_put, 0, - REQUEST_ROUTE}, - {"xcaps_del", (cmd_function)w_xcaps_del, 2, fixup_xcaps_put, 0, - REQUEST_ROUTE}, - {0, 0, 0, 0, 0, 0}}; + {{"xcapuri", sizeof("xcapuri") - 1}, PVT_OTHER, pv_get_xcap_uri, + pv_set_xcap_uri, pv_parse_xcap_uri_name, 0, 0, 0}, + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; + +static param_export_t params[] = { + {"db_url", PARAM_STR, &xcaps_db_url}, + {"xcap_table", PARAM_STR, &xcaps_db_table}, + {"xcap_root", PARAM_STR, &xcaps_root}, + {"buf_size", PARAM_INT, &xcaps_buf.len}, + {"xml_ns", PARAM_STRING | PARAM_USE_FUNC, (void *)xcaps_xpath_ns_param}, + {"directory_scheme", PARAM_INT, &xcaps_directory_scheme}, + {"directory_hostname", PARAM_STR, &xcaps_directory_hostname}, + {0, 0, 0} +}; +static cmd_export_t cmds[] = { + {"xcaps_put", (cmd_function)w_xcaps_put, 3, fixup_xcaps_put, 0, REQUEST_ROUTE}, + {"xcaps_get", (cmd_function)w_xcaps_get, 2, fixup_xcaps_put, 0, REQUEST_ROUTE}, + {"xcaps_del", (cmd_function)w_xcaps_del, 2, fixup_xcaps_put, 0, REQUEST_ROUTE}, + {0, 0, 0, 0, 0, 0} +}; /** module exports */ struct module_exports exports = { - "xcap_server", /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* exported functions */ - params, /* exported parameters */ - 0, /* exported rpc functions */ - mod_pvs, /* exported pseudo-variables */ - 0, /* response handling function */ - mod_init, /* module initialization function */ - child_init, /* per-child init function */ - destroy /* destroy function */ + "xcap_server", /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* exported functions */ + params, /* exported parameters */ + 0, /* exported rpc functions */ + mod_pvs, /* exported pseudo-variables */ + 0, /* response handling function */ + mod_init, /* module initialization function */ + child_init, /* per-child init function */ + destroy /* destroy function */ }; +/* clang-format on */ /** * init module function

1 month, 3 weeks

git:master:43091a5f: xcap_server: add fixup_free* to exported functions

by Victor Seva

Module: kamailio Branch: master Commit: 43091a5ff118e777f8bf52d4aed69435f97993ea URL: https://github.com/kamailio/kamailio/commit/43091a5ff118e777f8bf52d4aed6943… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-11-20T12:04:27+01:00 xcap_server: add fixup_free* to exported functions --- Modified: src/modules/xcap_server/xcap_server.c --- Diff: https://github.com/kamailio/kamailio/commit/43091a5ff118e777f8bf52d4aed6943… Patch: https://github.com/kamailio/kamailio/commit/43091a5ff118e777f8bf52d4aed6943… --- diff --git a/src/modules/xcap_server/xcap_server.c b/src/modules/xcap_server/xcap_server.c index 6feef732117..31d3771ec3d 100644 --- a/src/modules/xcap_server/xcap_server.c +++ b/src/modules/xcap_server/xcap_server.c @@ -64,6 +64,7 @@ static int w_xcaps_put(sip_msg_t *msg, char *puri, char *ppath, char *pbody); static int w_xcaps_get(sip_msg_t *msg, char *puri, char *ppath); static int w_xcaps_del(sip_msg_t *msg, char *puri, char *ppath); static int fixup_xcaps_put(void **param, int param_no); +static int fixup_free_xcaps_put(void **param, int param_no); static int check_preconditions(sip_msg_t *msg, str etag_hdr); static int check_match_header(str body, str *etag); @@ -125,9 +126,9 @@ static param_export_t params[] = { }; static cmd_export_t cmds[] = { - {"xcaps_put", (cmd_function)w_xcaps_put, 3, fixup_xcaps_put, 0, REQUEST_ROUTE}, - {"xcaps_get", (cmd_function)w_xcaps_get, 2, fixup_xcaps_put, 0, REQUEST_ROUTE}, - {"xcaps_del", (cmd_function)w_xcaps_del, 2, fixup_xcaps_put, 0, REQUEST_ROUTE}, + {"xcaps_put", (cmd_function)w_xcaps_put, 3, fixup_xcaps_put, fixup_free_xcaps_put, REQUEST_ROUTE}, + {"xcaps_get", (cmd_function)w_xcaps_get, 2, fixup_xcaps_put, fixup_free_xcaps_put, REQUEST_ROUTE}, + {"xcaps_del", (cmd_function)w_xcaps_del, 2, fixup_xcaps_put, fixup_free_xcaps_put, REQUEST_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -1495,6 +1496,21 @@ static int fixup_xcaps_put(void **param, int param_no) return 0; } +/** + * + */ +static int fixup_free_xcaps_put(void **param, int param_no) +{ + if(param_no == 1) { + return fixup_free_spve_null(param, 1); + } else if(param_no == 2) { + return fixup_free_spve_null(param, 1); + } else if(param_no == 3) { + pv_elem_free_all((pv_elem_t *)*param); + } + return 0; +} + static int check_preconditions(sip_msg_t *msg, str etag_hdr) { struct hdr_field *hdr = msg->headers;

1 month, 3 weeks

git:master:81b0b9b3: xhttp: add fixup_free* to exported functions

by Victor Seva

Module: kamailio Branch: master Commit: 81b0b9b35f639ab13774bdc30ff549a57d3cfbb5 URL: https://github.com/kamailio/kamailio/commit/81b0b9b35f639ab13774bdc30ff549a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-11-20T11:51:51+01:00 xhttp: add fixup_free* to exported functions --- Modified: src/modules/xhttp/xhttp_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/81b0b9b35f639ab13774bdc30ff549a… Patch: https://github.com/kamailio/kamailio/commit/81b0b9b35f639ab13774bdc30ff549a… --- diff --git a/src/modules/xhttp/xhttp_mod.c b/src/modules/xhttp/xhttp_mod.c index af27baffa41..9640de136cc 100644 --- a/src/modules/xhttp/xhttp_mod.c +++ b/src/modules/xhttp/xhttp_mod.c @@ -55,7 +55,7 @@ static int w_xhttp_send_reply( static int mod_init(void); static int fixup_xhttp_reply(void **param, int param_no); - +static int fixup_free_xhttp_reply(void **param, int param_no); static int pv_get_huri(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); static int xhttp_route_no = DEFAULT_RT; @@ -94,7 +94,7 @@ static param_export_t params[] = { static cmd_export_t cmds[] = { {"xhttp_reply", (cmd_function)w_xhttp_send_reply, - 4, fixup_xhttp_reply, 0, REQUEST_ROUTE}, + 4, fixup_xhttp_reply, fixup_free_xhttp_reply, REQUEST_ROUTE}, {"bind_xhttp", (cmd_function)bind_xhttp, 0, 0, 0, ANY_ROUTE}, {0, 0, 0, 0, 0} @@ -506,6 +506,23 @@ static int fixup_xhttp_reply(void **param, int param_no) return 0; } +/** + * + */ +static int fixup_free_xhttp_reply(void **param, int param_no) +{ + if(param_no == 1) { + return fixup_free_igp_null(param, 1); + } else if(param_no == 2) { + return fixup_free_spve_null(param, 1); + } else if(param_no == 3) { + return fixup_free_spve_null(param, 1); + } else if(param_no == 4) { + return fixup_free_spve_null(param, 1); + } + return 0; +} + /** * */

1 month, 3 weeks

git:master:96ac7b46: xhttp_pi: reformat exported structures

by Victor Seva

Module: kamailio Branch: master Commit: 96ac7b469bda367e63824d441d784916181075f6 URL: https://github.com/kamailio/kamailio/commit/96ac7b469bda367e63824d441d78491… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-11-20T11:45:36+01:00 xhttp_pi: reformat exported structures --- Modified: src/modules/xhttp_pi/xhttp_pi.c --- Diff: https://github.com/kamailio/kamailio/commit/96ac7b469bda367e63824d441d78491… Patch: https://github.com/kamailio/kamailio/commit/96ac7b469bda367e63824d441d78491… --- diff --git a/src/modules/xhttp_pi/xhttp_pi.c b/src/modules/xhttp_pi/xhttp_pi.c index af55bf70153..a8eaec8cabd 100644 --- a/src/modules/xhttp_pi/xhttp_pi.c +++ b/src/modules/xhttp_pi/xhttp_pi.c @@ -87,31 +87,34 @@ str filename = STR_NULL; int buf_size = 0; char error_buf[ERROR_REASON_BUF_LEN]; +/* clang-format off */ static cmd_export_t cmds[] = { - {"dispatch_xhttp_pi", (cmd_function)xhttp_pi_dispatch, 0, 0, 0, - REQUEST_ROUTE | EVENT_ROUTE}, - {0, 0, 0, 0, 0, 0}}; + {"dispatch_xhttp_pi", (cmd_function)xhttp_pi_dispatch, 0, 0, 0, REQUEST_ROUTE | EVENT_ROUTE}, + {0, 0, 0, 0, 0, 0} +}; -static param_export_t params[] = {{"xhttp_pi_root", PARAM_STR, &xhttp_pi_root}, - {"xhttp_pi_buf_size", PARAM_INT, &buf_size}, - {"framework", PARAM_STR, &filename}, {0, 0, 0}}; +static param_export_t params[] = { + {"xhttp_pi_root", PARAM_STR, &xhttp_pi_root}, + {"xhttp_pi_buf_size", PARAM_INT, &buf_size}, + {"framework", PARAM_STR, &filename}, {0, 0, 0} +}; static rpc_export_t rpc_methods[]; /** module exports */ struct module_exports exports = { - "xhttp_pi", /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* cmd (cfg function) exports */ - params, /* param exports */ - 0, /* RPC method exports */ - 0, /* pv exports */ - 0, /* response handling function */ - mod_init, /* module init function */ - 0, /* per-child init function */ - destroy /* module destroy function */ + "xhttp_pi", /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* cmd (cfg function) exports */ + params, /* param exports */ + 0, /* RPC method exports */ + 0, /* pv exports */ + 0, /* response handling function */ + mod_init, /* module init function */ + 0, /* per-child init function */ + destroy /* module destroy function */ }; - +/* clang-format on */ /** Implementation of pi_fault function required by the management API. *

1 month, 3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev