sr-dev

sr-dev@lists.kamailio.org

17 participants
44126 discussions

by Henning Westerholt

Hi, several kamailio modules need various string utility functions in the core, e.g.: - shm_strdup, pkg_strdup - str_strcmp, str_casecmp In the kamailio core we implemented this in the ut.h file. Does the SER core already provide similiar functions? If not i can move the implementation code from kamailio to this file, if this place is appropriate. Henning

16 years

Meeting at 25C3 in Berlin

by Henning Westerholt

Hello all, i'll be present this year at the 25th Chaos Communication Congress in Berlin [1], December 27th to 30th, 2008. So if some people here also participate in this event, and want to meet for some hacking sessions and discussions around the Kamailio/ sip-router project please drop me a personal mail. Regards, Henning [1] http://events.ccc.de/congress/2008/

16 years

git:andrei/script_vars: script: ser, kamailio and max compat mode support

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/script_vars Commit: f69ff7d9697349bf767f355be93eb15cdeab4e60 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f69ff7d… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sat Nov 29 17:12:16 2008 +0100 script: ser, kamailio and max compat mode support - script mode can be switched between ser compatible, kamailio compatible and max compatibility (compatible with both as much as possible), using #!SER, #!KAMAILIO or #!ALL on the first line (#!OPENSER and #!MAXCOMPAT are also allowed) --- NEWS | 18 +++++++++++++++- cfg.lex | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++---- sr_compat.c | 43 ++++++++++++++++++++++++++++++++++++++++ sr_compat.h | 44 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 162 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index f9c0867..03852ee 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,24 @@ -Release notes for SIP Express Router (ser) +Release notes for SIP Router (sr) *********************************************** $Id$ +sip-router changes + +core: + - support for dual module interfaces: ser and kamailio +config script changes: + - script mode can be switched between ser compatible, kamailio compatible + and max compatibility (compatible with both as much as possible), using + #!SER + #!KAMAILIO + #!OPENSER + #!ALL + #!MAXCOMPAT + where #!KAMAILIO is equivalent with #!OPENSER and #!ALL with #!MAXCOMPAT + - support for kamailio style pvars + + 2.1.0 changes diff --git a/cfg.lex b/cfg.lex index b196c32..c4f5a14 100644 --- a/cfg.lex +++ b/cfg.lex @@ -89,6 +89,7 @@ #include "usr_avp.h" #include "select.h" #include "cfg.tab.h" + #include "sr_compat.h" /* states */ #define INITIAL_S 0 @@ -99,6 +100,7 @@ #define SELECT_S 5 #define AVP_PVAR_S 6 /* avp or pvar */ #define PVAR_P_S 7 /* pvar: $(...) or $foo(...)*/ + #define PVARID_S 8 /* $foo.bar...*/ #define STR_BUF_ALLOC_UNIT 128 struct str_buf{ @@ -124,7 +126,12 @@ %} /* start conditions */ -%x STRING1 STRING2 COMMENT COMMENT_LN ATTR SELECT AVP_PVAR PVAR_P +%x STRING1 STRING2 COMMENT COMMENT_LN ATTR SELECT AVP_PVAR PVAR_P PVARID + +/* config script types : #!SER or #!KAMAILIO or #!MAX_COMPAT */ +SER_CFG SER +KAMAILIO_CFG KAMAILIO|OPENSER +MAXCOMPAT_CFG MAXCOMPAT|ALL /* action keywords */ FORWARD forward @@ -761,8 +768,22 @@ EAT_ABLE [\ \t\b\r] return ID; } -<INITIAL>{VAR_MARK}{LPAREN} { state = PVAR_P_S; BEGIN(PVAR_P); p_nest=1; - yymore();} +<INITIAL>{VAR_MARK}{LPAREN} { + switch(sr_cfg_compat){ + case SR_COMPAT_SER: + state=ATTR_S; BEGIN(ATTR); + yyless(1); + count(); + return ATTR_MARK; + break; + case SR_COMPAT_KAMAILIO: + case SR_COMPAT_MAX: + default: + state = PVAR_P_S; BEGIN(PVAR_P); + p_nest=1; yymore(); + break; + } + } /* eat everything between 2 () and return PVAR token and a string containing everything (including $ and ()) */ <PVAR_P>{RPAREN} { p_nest--; @@ -779,14 +800,38 @@ EAT_ABLE [\ \t\b\r] } <PVAR_P>. { yymore(); } +<PVARID>{ID}|'.' {yymore(); } +<PVARID>{LPAREN} { state = PVAR_P_S; BEGIN(PVAR_P); + p_nest=1; yymore(); } +<PVARID>. { count(); state=INITIAL_S; BEGIN(INITIAL); + return PVAR; + } -<INITIAL>{VAR_MARK} { state=AVP_PVAR_S; BEGIN(AVP_PVAR); yymore(); } + +<INITIAL>{VAR_MARK} { + switch(sr_cfg_compat){ + case SR_COMPAT_SER: + count(); + state=ATTR_S; BEGIN(ATTR); + return ATTR_MARK; + break; + case SR_COMPAT_KAMAILIO: + state=PVARID_S; BEGIN(PVARID); + yymore(); + break; + case SR_COMPAT_MAX: + default: + state=AVP_PVAR_S; BEGIN(AVP_PVAR); + yymore(); + break; + } + } /* avp prefix detected -> go to avp mode */ <AVP_PVAR>{AVP_PREF} | <AVP_PVAR>{ID}{LBRACK} { state = ATTR_S; BEGIN(ATTR); yyless(1); return ATTR_MARK; } <AVP_PVAR>{ID}{LPAREN} { state = PVAR_P_S; BEGIN(PVAR_P); yymore(); } -<AVP_PVAR>{ID} { count(); addstr(&s_buf, yytext, yyleng); +<AVP_PVAR>{ID} { count(); addstr(&s_buf, yytext, yyleng); yylval.strval=s_buf.s; memset(&s_buf, 0, sizeof(s_buf)); state = INITIAL_S; @@ -882,6 +927,12 @@ EAT_ABLE [\ \t\b\r] } <COMMENT>.|{EAT_ABLE}|{CR} { count(); }; +<INITIAL>{COM_LINE}!{SER_CFG}{CR} { count(); + sr_cfg_compat=SR_COMPAT_SER;} +<INITIAL>{COM_LINE}!{KAMAILIO_CFG}{CR} { count(); + sr_cfg_compat=SR_COMPAT_KAMAILIO;} +<INITIAL>{COM_LINE}!{MAXCOMPAT_CFG}{CR} { count(); + sr_cfg_compat=SR_COMPAT_MAX;} <INITIAL>{COM_LINE}.*{CR} { count(); } <INITIAL>{ID} { count(); addstr(&s_buf, yytext, yyleng); @@ -916,6 +967,8 @@ EAT_ABLE [\ \t\b\r] " while parsing" " avp name\n"); break; + case PVARID_S: + p_nest=0; case PVAR_P_S: LOG(L_CRIT, "ERROR: unexpected EOF" " while parsing pvar name" diff --git a/sr_compat.c b/sr_compat.c new file mode 100644 index 0000000..79660ab --- /dev/null +++ b/sr_compat.c @@ -0,0 +1,43 @@ +/* + * $Id$ + * + * Copyright (C) 2008 iptelorg GmbH + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + */ +/** + * @file + * @brief ser/kamailio/openser compatibility macros & vars. + */ +/* + * History: + * -------- + * 2008-11-29 initial version (andrei) + */ + + +#include "sr_compat.h" + +#ifdef SR_SER +#define SR_DEFAULT_COMPAT SR_COMPAT_SER +#elif defined SR_KAMAILIO || defined SR_OPENSER +#define SR_DEFAULT_COMPAT SR_COMPAT_KAMAILIO +#elif defined SR_ALL || defined SR_MAX_COMPAT +#define SR_DEFAULT_COMPAT SR_COMPAT_MAX +#else +/* default */ +#define SR_DEFAULT_COMPAT SR_COMPAT_MAX +#endif + +int sr_compat=SR_DEFAULT_COMPAT; +int sr_cfg_compat=SR_DEFAULT_COMPAT; diff --git a/sr_compat.h b/sr_compat.h new file mode 100644 index 0000000..ba46bde --- /dev/null +++ b/sr_compat.h @@ -0,0 +1,44 @@ +/* + * $Id$ + * + * Copyright (C) 2008 iptelorg GmbH + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + */ +/** + * @file + * @brief ser/kamailio/openser compatibility macros & vars. + */ +/* + * History: + * -------- + * 2008-11-29 initial version (andrei) + */ + + +#ifndef _sr_compat_h +#define _sr_compat_h + +/** max compat mode: support as many features as possible from all xSERs */ +#define SR_COMPAT_MAX 0 +/** maximum compatibility mode with ser */ +#define SR_COMPAT_SER 1 +/** maximum compatibility mode with kamailio/openser */ +#define SR_COMPAT_KAMAILIO 2 +#define SR_COMPAT_OPENSER 2 + + +extern int sr_compat; +extern int sr_cfg_compat; + +#endif /* _sr_compat_h */

16 years

git:andrei/script_vars: script: basic support for parsing pvar names

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/script_vars Commit: 26a886bcdcd5901e87d2b1f1984de457eb9fb4d2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=26a886b… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Nov 28 20:24:04 2008 +0100 script: basic support for parsing pvar names - parse pvar names and try to guess on ambiguous pvar/avps identifiers (e.g.: $foo) --- cfg.lex | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++------------ cfg.y | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 122 insertions(+), 15 deletions(-) diff --git a/cfg.lex b/cfg.lex index 5af02db..56c51e5 100644 --- a/cfg.lex +++ b/cfg.lex @@ -75,6 +75,7 @@ * 2007-11-28 added TCP_OPT_{FD_CACHE, DEFER_ACCEPT, DELAYED_ACK, SYNCNT, * LINGER2, KEEPALIVE, KEEPIDLE, KEEPINTVL, KEEPCNT} (andrei) * 2008-01-24 added CFG_DESCRIPTION used by cfg_var (Miklos) + * 2008-11-28 added support for kamailio pvars and avp/pvar guessing (andrei) */ @@ -94,8 +95,10 @@ #define COMMENT_S 1 #define COMMENT_LN_S 2 #define STRING_S 3 - #define ATTR_S 4 - #define SELECT_S 5 + #define ATTR_S 4 /* avp/attr */ + #define SELECT_S 5 + #define AVP_PVAR_S 6 /* avp or pvar */ + #define PVAR_P_S 7 /* pvar: $(...) or $foo(...)*/ #define STR_BUF_ALLOC_UNIT 128 struct str_buf{ @@ -106,6 +109,7 @@ static int comment_nest=0; + static int p_nest=0; static int state=0, old_state=0, old_initial=0; static struct str_buf s_buf; int line=1; @@ -120,7 +124,7 @@ %} /* start conditions */ -%x STRING1 STRING2 COMMENT COMMENT_LN ATTR SELECT +%x STRING1 STRING2 COMMENT COMMENT_LN ATTR SELECT AVP_PVAR PVAR_P /* action keywords */ FORWARD forward @@ -219,7 +223,8 @@ PLUS "+" MINUS "-" /* Attribute specification */ -ATTR_MARK "$"|"%" +ATTR_MARK "%" +VAR_MARK "$" SELECT_MARK "@" ATTR_FROM "f" ATTR_TO "t" @@ -231,6 +236,9 @@ ATTR_FROMDOMAIN "fd" ATTR_TODOMAIN "td" ATTR_GLOBAL "g" +/* avp prefix */ +AVP_PREF (([ft][rud]?)|g)\. + /* config vars. */ DEBUG debug FORK fork @@ -729,7 +737,8 @@ EAT_ABLE [\ \t\b\r] <SELECT>{BINNUMBER} { count(); yylval.intval=(int)strtol(yytext, 0, 2); return NUMBER; } -<INITIAL>{ATTR_MARK} { count(); state = ATTR_S; BEGIN(ATTR); return ATTR_MARK; } +<INITIAL>{ATTR_MARK} { count(); state = ATTR_S; BEGIN(ATTR); + return ATTR_MARK; } <ATTR>{ATTR_FROM} { count(); return ATTR_FROM; } <ATTR>{ATTR_TO} { count(); return ATTR_TO; } <ATTR>{ATTR_FROMURI} { count(); return ATTR_FROMURI; } @@ -742,15 +751,48 @@ EAT_ABLE [\ \t\b\r] <ATTR>{DOT} { count(); return DOT; } <ATTR>{LBRACK} { count(); return LBRACK; } <ATTR>{RBRACK} { count(); return RBRACK; } -<ATTR>{STAR} { count(); return STAR; } -<ATTR>{DECNUMBER} { count(); yylval.intval=atoi(yytext);return NUMBER; } -<ATTR>{ID} { count(); addstr(&s_buf, yytext, yyleng); - yylval.strval=s_buf.s; - memset(&s_buf, 0, sizeof(s_buf)); - state = INITIAL_S; - BEGIN(INITIAL); - return ID; - } +<ATTR>{STAR} { count(); return STAR; } +<ATTR>{DECNUMBER} { count(); yylval.intval=atoi(yytext);return NUMBER; } +<ATTR>{ID} { count(); addstr(&s_buf, yytext, yyleng); + yylval.strval=s_buf.s; + memset(&s_buf, 0, sizeof(s_buf)); + state = INITIAL_S; + BEGIN(INITIAL); + return ID; + } + +<INITIAL>{VAR_MARK}{LPAREN} { state = PVAR_P_S; BEGIN(PVAR_P); p_nest=1; + yymore();} + /* eat everything between 2 () and return PVAR token and a string + containing everything (including $ and ()) */ +<PVAR_P>{RPAREN} { p_nest--; + if (p_nest==0){ + count(); + addstr(&s_buf, yytext, yyleng); + yylval.strval=s_buf.s; + memset(&s_buf, 0, sizeof(s_buf)); + state=INITIAL_S; + BEGIN(INITIAL); + return PVAR; + } + yymore(); + } +<PVAR_P>. { yymore(); } + + +<INITIAL>{VAR_MARK} { state=AVP_PVAR_S; BEGIN(AVP_PVAR); yymore(); } + /* avp prefix detected -> go to avp mode */ +<AVP_PVAR>{AVP_PREF} | +<AVP_PVAR>{ID}{LBRACK} { state = ATTR_S; BEGIN(ATTR); yyless(1); + return ATTR_MARK; } +<AVP_PVAR>{ID}{LPAREN} { state = PVAR_P_S; BEGIN(PVAR_P); yymore(); } +<AVP_PVAR>{ID} { count(); addstr(&s_buf, yytext, yyleng); + yylval.strval=s_buf.s; + memset(&s_buf, 0, sizeof(s_buf)); + state = INITIAL_S; + BEGIN(INITIAL); + return AVP_OR_PVAR; + } <INITIAL>{IPV6ADDR} { count(); yylval.strval=yytext; return IPV6ADDR; } <INITIAL>{DECNUMBER} { count(); yylval.intval=atoi(yytext);return NUMBER; } diff --git a/cfg.y b/cfg.y index 5adc111..228d909 100644 --- a/cfg.y +++ b/cfg.y @@ -185,8 +185,17 @@ static struct ip_addr* ip_tmp; static struct avp_spec* s_attr; static select_t sel; static select_t* sel_ptr; +static pv_spec_t* pv_spec; static struct action *mod_func_action; +static struct avp_pvar_spec{ + int type; + union{ + struct avp_spec avp; + pv_spec_t pv; + }u; +} *apv_spec; + static void warn(char* s); static struct socket_id* mk_listen_id(char*, int, int); static struct name_lst* mk_name_lst(char* name, int flags); @@ -207,6 +216,8 @@ static void free_socket_id_lst(struct socket_id* i); struct socket_id* sockid; struct name_lst* name_l; struct avp_spec* attr; + struct pv_spec_t* pvar; + struct avp_pvar_spec* avp_pvar_s; select_t* select; } @@ -426,6 +437,7 @@ static void free_socket_id_lst(struct socket_id* i); %token ATTR_GLOBAL %token ADDEQ + %token STUN_REFRESH_INTERVAL %token STUN_ALLOW_STUN %token STUN_ALLOW_FP @@ -452,6 +464,9 @@ static void free_socket_id_lst(struct socket_id* i); %token <strval> ID %token <strval> STRING %token <strval> IPV6ADDR +%token <strval> PVAR +/* not clear yet if this is an avp or pvar */ +%token <strval> AVP_OR_PVAR /* other */ %token COMMA @@ -492,6 +507,8 @@ static void free_socket_id_lst(struct socket_id* i); %type <attr> attr_id_val %type <attr> attr_id_any %type <attr> attr_id_any_str +%type <pvar> pvar +%type <avp_pvar_s> avp_pvar /* %type <intval> class_id */ %type <intval> assign_op %type <select> select_id @@ -1954,7 +1971,7 @@ attr_id_any_str: s.len = strlen(s.s); if (parse_avp_name(&s, &type, &avp_spec->name, &idx)) { yyerror("error when parsing AVP"); - pkg_free(avp_spec); + pkg_free(avp_spec); YYABORT; } avp_spec->type = type; @@ -1962,6 +1979,52 @@ attr_id_any_str: $$ = avp_spec; } ; + +pvar: PVAR { + pv_spec=pkg_malloc(sizeof(*pv_spec)); + if (!pv_spec) { + yyerror("Not enough memory"); + YYABORT; + } + s.s=$1; s.len=strlen(s.s); + if (pv_parse_spec(&s, pv_spec)==0){ + yyerror("unknown script pseudo variable"); + pkg_free(pv_spec); + YYABORT; + } + $$=pv_spec; + BUG("parsed pvar \"%.*s\"\n", s.len, s.s); + } + ; + +avp_pvar: AVP_OR_PVAR { + apv=pkg_malloc(sizeof(*apv)); + if (!apv) { + yyerror("Not enough memory"); + YYABORT; + } + s.s=$1; s.len=strlen(s.s); + if (pv_parse_spec(&s, &apv_spec->u.pv)==0){ + /* not a pvar, try avps */ + /* TODO: test if in ser or k mode */ + if (parse_avp_name(&s, &type, &apv_spec->u.avp.name, &idx)) { + yyerror("error when parsing AVP"); + pkg_free(apv_spec); + YYABORT; + } + apv_spec->u.avp.type = type; + apv_spec->u.avp.index = idx; + apv_spec.type=APV_AVP_T; + }else{ + apv_spec.type=APV_PVAR_T; + } + $$ = apv_spec; + BUG("parsed ambigous avp/pvar \"%.*s\" to %d\n", s.len, s.s, + apv_spec.type); + } + ; + + /* assign_op: ADDEQ { $$ = ADD_T; } @@ -1979,6 +2042,8 @@ assign_action: | attr_id_ass assign_op select_id { $$=mk_action($2, 2, AVP_ST, (void*)$1, SELECT_ST, (void*)$3); } | attr_id_ass assign_op LPAREN exp RPAREN { $$ = mk_action($2, 2, AVP_ST, $1, EXPR_ST, $4); } ; + + avpflag_oper: SETAVPFLAG { $$ = 1; } | RESETAVPFLAG { $$ = 0; }

16 years

git:andrei/script_vars: script: more error messages on EOF

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/script_vars Commit: ea6f7be1772436d182335086847fe6a0e5908d4e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ea6f7be… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sat Nov 29 15:58:14 2008 +0100 script: more error messages on EOF --- cfg.lex | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/cfg.lex b/cfg.lex index 56c51e5..b196c32 100644 --- a/cfg.lex +++ b/cfg.lex @@ -911,6 +911,21 @@ EAT_ABLE [\ \t\b\r] LOG(L_CRIT, "ERROR: unexpected EOF:" "comment line open\n"); break; + case ATTR_S: + LOG(L_CRIT, "ERROR: unexpected EOF" + " while parsing" + " avp name\n"); + break; + case PVAR_P_S: + LOG(L_CRIT, "ERROR: unexpected EOF" + " while parsing pvar name" + " (%d paranthesis open)\n", + p_nest); + break; + case AVP_PVAR_S: + LOG(L_CRIT, "ERROR: unexpected EOF" + " while parsing" + " avp or pvar name\n"); } return 0; }

16 years

git:henning/trie_mods: Merge commit 'origin/henning/trie'

by Henning Westerholt

Module: sip-router Branch: henning/trie_mods Commit: ecaca6b8fc03cdc0a0668175719dcba5ae3fe280 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ecaca6b… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Nov 27 14:00:30 2008 +0100 Merge commit 'origin/henning/trie' * commit 'origin/henning/trie': add trie to library directory add SHM_MEM_ERROR and PKG_MEM_ERROR logging macros to mem.h ---

16 years

append_branch() inside modules

by Daniel-Constantin Mierla

Hello, there are couple of modules that change the R-URI and automatically call append_branch() if the execution takes place in failure_route, other modules don't. Perhaps we should get to a coherent behavior, if not for existing code, then for the future. Probably the most flexible, better in my opinion, is to let script writer to call append_branch() in config -- once done, it is no way now to revert. A new branch should be automatically done only if it is a specific operation, e.g., location lookup with more than one record. What do you think? Cheers, Daniel PS. this blending of the ser-kamailio sources gives me ideas to do some cleanup as I review the code ... especially after midnight ... -- Daniel-Constantin Mierla http://www.asipto.com

16 years

git:daniel/pv: - list of PVs types syncronized with Kamailio

by Daniel-Constantin Mierla

Module: sip-router Branch: daniel/pv Commit: e7745e9a2a37a56ea71ec72eb8fbbdfc837f0dcb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7745e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 28 00:13:47 2008 +0200 - list of PVs types syncronized with Kamailio --- pvar.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/pvar.h b/pvar.h index 811ea34..e8482f5 100644 --- a/pvar.h +++ b/pvar.h @@ -72,7 +72,11 @@ enum _pv_type { PVT_NONE=0, PVT_EMPTY, PVT_NULL, - PVT_MARKER, PVT_AVP, PVT_COLOR, + PVT_MARKER, PVT_AVP, PVT_HDR, + PVT_RURI, PVT_RURI_USERNAME, PVT_RURI_DOMAIN, + PVT_DSTURI, PVT_COLOR, PVT_BRANCH, + PVT_FROM, PVT_TO, PVT_OURI, + PVT_SCRIPTVAR, PVT_MSG_BODY, PVT_OTHER, PVT_EXTRA /* keep it last */ };

16 years

git:andrei/fixups: avp: comments fix

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/fixups Commit: 70346b5ba3cf7e2c28f61ab8bf7f8d37abec800e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=70346b5… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Nov 27 13:55:24 2008 +0100 avp: comments fix - parse_avp_indent comments: 'g' it's an avp "class" and not a "track" Reported-by: Jan Janak, jan at iptel.org --- usr_avp.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/usr_avp.c b/usr_avp.c index eea9894..b5c8455 100644 --- a/usr_avp.c +++ b/usr_avp.c @@ -854,10 +854,10 @@ int parse_avp_name( str *name, int *type, int_str *avp_name, int *index) * <id> = ascii string w/o '[', ']', '.' and '/' * <name> = <id> | '/' regex '/' * (Note: regex use is deprecated) - * <track> = 'f' | 't' | 'g' - * (from, to or global) - * <class> = 'r' | 'u' | 'd' - * (uri, user or domain) + * <track> = 'f' | 't' + * (from or to) + * <class> = 'r' | 'u' | 'd' | 'g' + * (uri, user, domain or global) * <index> = <number> | '-' <number> | '' * (the avp index, if missing it means AVP_INDEX_ALL, but * it's use is deprecated)

16 years

static buffers

by Daniel-Constantin Mierla

Hello, There seem to be many places where static buffers are used for building strings. It is clear they are used just for usage inside some functions, with no need to keep the value for usage somewhere else. Would defining a global static buffer to be used for such cases make sense? The access to the pointer and size can be given via functions. There could be couple of such buffers to be used in the cases one function need concurrent access to more than one ... opinions? It will reduce memory space reserved and used... Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

16 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev