Hello,
there are couple of modules that change the R-URI and automatically call
append_branch() if the execution takes place in failure_route, other
modules don't.
Perhaps we should get to a coherent behavior, if not for existing code,
then for the future. Probably the most flexible, better in my opinion,
is to let script writer to call append_branch() in config -- once done,
it is no way now to revert. A new branch should be automatically done
only if it is a specific operation, e.g., location lookup with more than
one record.
What do you think?
Cheers,
Daniel
PS. this blending of the ser-kamailio sources gives me ideas to do some
cleanup as I review the code ... especially after midnight ...
--
Daniel-Constantin Mierla
http://www.asipto.com
Hello,
There seem to be many places where static buffers are used for building
strings. It is clear they are used just for usage inside some functions,
with no need to keep the value for usage somewhere else.
Would defining a global static buffer to be used for such cases make
sense? The access to the pointer and size can be given via functions.
There could be couple of such buffers to be used in the cases one
function need concurrent access to more than one ... opinions? It will
reduce memory space reserved and used...
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://www.asipto.com
It's highly recommended to use git versions >= 1.5.6 (e.g. 1.5.6.1,
1.6.0.4 a.s.o) if you use/do git merge.
Older versions do not support the merge.log options or git merge --log
and _will_ not generate merge summaries in the merge commit messages
(which are very nice to have).
If you have an older version and you don't want to upgrade try setting
merge.summary (git config merge.summary true).
Andrei