sr-dev

sr-dev@lists.kamailio.org

12 participants
44183 discussions

git:andrei/type_conversion: core expr eval: various fixes

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/type_conversion Commit: e9249a149a3dca35c8f7f0b3c1f72343cd1a9c30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e9249a1… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Apr 29 13:55:01 2009 +0200 core expr eval: various fixes - fix pvars type evaluated to STRING almost always (when they had PV_VAL_STR). - fix undefined not properly propagated for avps (typo) which caused some comparsion to behave in unexpected way (e.g. $undef_avp != $undef_avp was true). - fix <undef>+something (used to produce an error, now is equivalent to "" + something). --- rvalue.c | 23 +++++++++++++---------- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/rvalue.c b/rvalue.c index 9a74cda..55456a1 100644 --- a/rvalue.c +++ b/rvalue.c @@ -314,18 +314,18 @@ inline static enum rval_type rval_get_btype(struct run_act_ctx* h, } memset(pv, 0, sizeof(tmp_pval)); if (likely(pv_get_spec_value(msg, &rv->v.pvs, pv)==0)){ - if (pv->flags & PV_VAL_STR){ + if (pv->flags & PV_TYPE_INT){ if (likely(val_cache!=0)) - val_cache->val_type=RV_STR; + val_cache->val_type=RV_INT; else pv_value_destroy(pv); - return RV_STR; - }else if (pv->flags & PV_TYPE_INT){ + return RV_INT; + }else if (pv->flags & PV_VAL_STR){ if (likely(val_cache!=0)) - val_cache->val_type=RV_INT; + val_cache->val_type=RV_STR; else pv_value_destroy(pv); - return RV_INT; + return RV_STR; }else{ pv_value_destroy(pv); if (likely(val_cache!=0)) @@ -339,7 +339,7 @@ inline static enum rval_type rval_get_btype(struct run_act_ctx* h, } break; case RV_AVP: - if (likely(val_cache && val_cache==RV_CACHE_EMPTY)){ + if (likely(val_cache && val_cache->cache_type==RV_CACHE_EMPTY)){ ptype=&val_cache->val_type; avpv=&val_cache->c.avp_val; val_cache->cache_type=RV_CACHE_AVP; @@ -718,6 +718,11 @@ int rve_check_type(enum rval_type* type, struct rval_expr* rve, } break; case RVE_NONE_OP: + default: + BUG("unexpected rve op %d\n", rve->op); + if (bad_rve) *bad_rve=rve; + if (bad_t) *bad_t=RV_NONE; + if (exp_t) *exp_t=RV_STR; break; } return 0; @@ -2041,6 +2046,7 @@ struct rvalue* rval_expr_eval(struct run_act_ctx* h, struct sip_msg* msg, } break; case RV_STR: + case RV_NONE: rv2=rval_expr_eval(h, msg, rve->right.rve); if (unlikely(rv2==0)){ ERR("rval expression evaluation failed\n"); @@ -2051,9 +2057,6 @@ struct rvalue* rval_expr_eval(struct run_act_ctx* h, struct sip_msg* msg, break; default: BUG("rv unsupported basic type %d\n", type); - case RV_NONE: - rval_cache_clean(&c1); - goto error; } rval_cache_clean(&c1); break;

15 years, 8 months

git:master: pv: update for getbflagsval

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 52d3321b989c95c4f9f10693e1f77a5d18a58f18 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=52d3321… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 19:22:23 2009 +0200 pv: update for getbflagsval --- modules_k/pv/pv_core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/pv/pv_core.c b/modules_k/pv/pv_core.c index ead4e78..0203920 100644 --- a/modules_k/pv/pv_core.c +++ b/modules_k/pv/pv_core.c @@ -483,7 +483,7 @@ int pv_get_bflags(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { flag_t flags; - if (getbflags(&flags, 0) < 0) { + if (getbflagsval(0, &flags) < 0) { ERR("pv_get_bflags: Error while obtainig values of branch flags\n"); return -1; } @@ -498,7 +498,7 @@ int pv_get_hexbflags(struct sip_msg *msg, pv_param_t *param, if(res==NULL) return -1; - if (getbflags(&flags, 0) < 0) { + if (getbflagsval(0, &flags) < 0) { ERR("pv_get_hexbflags: Error while obtaining values of branch flags\n"); return -1; }

15 years, 8 months

git:master: registrar: update for getblagsval

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: fd4baa2b0cc91d215f9460ea91d369fb0febc344 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fd4baa2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 19:22:41 2009 +0200 registrar: update for getblagsval --- modules_k/registrar/save.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/registrar/save.c b/modules_k/registrar/save.c index 6f7b747..13e0b49 100644 --- a/modules_k/registrar/save.c +++ b/modules_k/registrar/save.c @@ -278,7 +278,7 @@ static inline ucontact_info_t* pack_ci( struct sip_msg* _m, contact_t* _c, /* set flags */ ci.flags = _f; - getbflags(&ci.flags, 0); + getbflagsval(0, &ci.flags); /* get received */ if (path_received.len && path_received.s) {

15 years, 8 months

git:master: kex: added km_append_branch

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8cf72b2de1ca86cafe7203433ff411e837d26dfa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8cf72b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 19:23:23 2009 +0200 kex: added km_append_branch - K compatible append_branch() function --- modules_k/kex/kex_mod.c | 5 +++ modules_k/kex/km_core.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++ modules_k/kex/km_core.h | 30 +++++++++++++++++++++ 3 files changed, 102 insertions(+), 0 deletions(-) diff --git a/modules_k/kex/kex_mod.c b/modules_k/kex/kex_mod.c index e4960c0..9baa48d 100644 --- a/modules_k/kex/kex_mod.c +++ b/modules_k/kex/kex_mod.c @@ -31,6 +31,7 @@ #include "../../mod_fix.h" #include "flags.h" +#include "km_core.h" #include "mi_core.h" #include "core_stats.h" @@ -63,6 +64,10 @@ static cmd_export_t cmds[]={ 0, ANY_ROUTE }, {"isbflagset", (cmd_function)w_isbflagset, 2,fixup_igp_igp, 0, ANY_ROUTE }, + {"km_append_branch", (cmd_function)w_km_append_branch, 0, 0, + 0, REQUEST_ROUTE | FAILURE_ROUTE }, + {"km_append_branch", (cmd_function)w_km_append_branch, 1, fixup_spve_null, + 0, REQUEST_ROUTE | FAILURE_ROUTE }, {0,0,0,0,0,0} }; diff --git a/modules_k/kex/km_core.c b/modules_k/kex/km_core.c new file mode 100644 index 0000000..beebb35 --- /dev/null +++ b/modules_k/kex/km_core.c @@ -0,0 +1,67 @@ +/** + * $Id$ + * + * Copyright (C) 2009 + * + * This file is part of SIP-Router.org, a free SIP server. + * + * SIP-Router is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <stdio.h> +#include <string.h> +#include <stdlib.h> + +#include "../../dprint.h" +#include "../../dset.h" +#include "../../flags.h" +#include "../../mod_fix.h" +#include "km_core.h" + +int w_km_append_branch(struct sip_msg *msg, char *uri, str *sq) +{ + str suri; + int ret; + int q = Q_UNSPECIFIED; + flag_t branch_flags = 0; + + getbflagsval(0, &branch_flags); + if (uri==NULL) { + ret = km_append_branch(msg, 0, &msg->dst_uri, &msg->path_vec, + q, branch_flags, msg->force_send_socket); + /* reset all branch info */ + msg->force_send_socket = 0; + setbflagsval(0, 0); + if(msg->dst_uri.s!=0) + pkg_free(msg->dst_uri.s); + msg->dst_uri.s = 0; + msg->dst_uri.len = 0; + if(msg->path_vec.s!=0) + pkg_free(msg->path_vec.s); + msg->path_vec.s = 0; + msg->path_vec.len = 0; + } else { + if(fixup_get_svalue(msg, (gparam_p)uri, &suri)!=0) + { + LM_ERR("cannot get the URI parameter\n"); + return -1; + } + ret = km_append_branch(msg, &suri, &msg->dst_uri, + &msg->path_vec, q, branch_flags, + msg->force_send_socket); + } + return ret; +} + diff --git a/modules_k/kex/km_core.h b/modules_k/kex/km_core.h new file mode 100644 index 0000000..a668c71 --- /dev/null +++ b/modules_k/kex/km_core.h @@ -0,0 +1,30 @@ +/** + * $Id$ + * + * Copyright (C) 2009 + * + * This file is part of SIP-Router.org, a free SIP server. + * + * SIP-Router is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef _KEX_CORE_H_ +#define _KEX_CORE_H_ + +#include "../../sr_module.h" + +int w_km_append_branch(struct sip_msg *msg, char *uri, str *s2); + +#endif

15 years, 8 months

git:master: core: wrapper to return branch iterator position

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 764bac17b074714c651d71654c6e7276a58ca5e4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=764bac1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 20:38:09 2009 +0200 core: wrapper to return branch iterator position --- dset.c | 4 ++++ dset.h | 4 ++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/dset.c b/dset.c index 9409557..1770a3c 100644 --- a/dset.c +++ b/dset.c @@ -155,6 +155,10 @@ void init_branch_iterator(void) branch_iterator = 0; } +int get_branch_iterator(void) +{ + return branch_iterator; +} /* * Return the next branch from the dset diff --git a/dset.h b/dset.h index adba10e..175e0c3 100644 --- a/dset.h +++ b/dset.h @@ -53,6 +53,10 @@ int km_append_branch(struct sip_msg* msg, str* uri, str* dst_uri, str* path, */ void init_branch_iterator(void); +/* + * Return branch iterator position + */ +int get_branch_iterator(void); /* * Get the next branch in the current transaction

15 years, 8 months

git:master: tm: handling of branch flags

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cd9460b0d8023c43348bce58fe38ef3ce9a686cc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd9460b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 20:40:26 2009 +0200 tm: handling of branch flags - save/restore branch upon execution of tm specific routes --- modules/tm/h_table.h | 3 +++ modules/tm/t_fwd.c | 9 +++++++++ modules/tm/t_reply.c | 9 +++++++-- modules/tm/t_reply.h | 2 +- modules/tm/t_suspend.c | 4 +++- 5 files changed, 23 insertions(+), 4 deletions(-) diff --git a/modules/tm/h_table.h b/modules/tm/h_table.h index 37aecc9..d38e3d6 100644 --- a/modules/tm/h_table.h +++ b/modules/tm/h_table.h @@ -70,6 +70,7 @@ #include "../../md5utils.h" #include "../../usr_avp.h" #include "../../timer.h" +#include "../../flags.h" #include "../../atomic_ops.h" #include "../../hash_func.h" #include "config.h" @@ -85,6 +86,7 @@ struct entry; struct cell; struct timer; struct retr_buf; +struct ua_client; #include "../../mem/shm_mem.h" #include "lock.h" @@ -224,6 +226,7 @@ typedef struct ua_client /* internal flags per tm uac */ unsigned int flags; #endif + flag_t branch_flags; #ifdef WITH_AS_SUPPORT /** * Resent for every rcvd 2xx reply. diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index 9344e6f..46ddbfb 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -450,6 +450,7 @@ int add_uac( struct cell *t, struct sip_msg *request, str *uri, str* next_hop, else if(len==2) t->uac[branch].flags = TM_UAC_FLAG_RR|TM_UAC_FLAG_R2; #endif + getbflagsval(0, &t->uac[branch].branch_flags); membar_write(); /* to allow lockless ops (e.g. which_cancel()) we want to be sure everything above is fully written before updating branches no. */ @@ -1005,6 +1006,8 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , int lock_replies; str dst_uri; struct socket_info* si, *backup_si; + flag_t backup_bflags = 0; + flag_t bflags = 0; /* make -Wall happy */ @@ -1028,6 +1031,8 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , } backup_si = p_msg->force_send_socket; + getbflagsval(0, &backup_bflags); + /* if no more specific error code is known, use this */ lowest_ret=E_UNSPEC; /* branches added */ @@ -1072,6 +1077,9 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , while((current_uri.s=next_branch( &current_uri.len, &q, &dst_uri.s, &dst_uri.len, &si))) { try_new++; p_msg->force_send_socket = si; + getbflagsval(get_branch_iterator(), &bflags); + setbflagsval(0, bflags); + branch_ret=add_uac( t, p_msg, &current_uri, (dst_uri.len) ? (&dst_uri) : &current_uri, proxy, proto); @@ -1088,6 +1096,7 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , clear_branches(); p_msg->force_send_socket = backup_si; + setbflagsval(0, backup_bflags); /* don't forget to clear all branches processed so far */ diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 5cb731f..e51142c 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -730,7 +730,7 @@ void faked_env( struct cell *t,struct sip_msg *msg) int fake_req(struct sip_msg *faked_req, - struct sip_msg *shmem_msg, int extra_flags) + struct sip_msg *shmem_msg, int extra_flags, struct ua_client *uac) { /* on_negative_reply faked msg now copied from shmem msg (as opposed * to zero-ing) -- more "read-only" actions (exec in particular) will @@ -771,6 +771,8 @@ int fake_req(struct sip_msg *faked_req, faked_req->dst_uri.len); faked_req->dst_uri.s[faked_req->dst_uri.len]=0; } + if(uac) setbflagsval(0, uac->branch_flags); + else setbflagsval(0, 0); return 1; error00: @@ -836,7 +838,7 @@ int run_failure_handlers(struct cell *t, struct sip_msg *rpl, return 1; } - if (!fake_req(&faked_req, shmem_msg, extra_flags)) { + if (!fake_req(&faked_req, shmem_msg, extra_flags, &t->uac[picked_branch])) { LOG(L_ERR, "ERROR: run_failure_handlers: fake_req failed\n"); return 0; } @@ -1953,10 +1955,13 @@ int reply_received( struct sip_msg *p_msg ) backup_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, &t->user_avps_to ); backup_domain_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, &t->domain_avps_from ); backup_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, &t->domain_avps_to ); + setbflagsval(0, uac->branch_flags); if (run_top_route(onreply_rt.rlist[t->on_reply], p_msg)<0) LOG(L_ERR, "ERROR: on_reply processing failed\n"); /* transfer current message context back to t */ if (t->uas.request) t->uas.request->flags=p_msg->flags; + getbflagsval(0, &uac->branch_flags); + /* restore original avp list */ set_avp_list( AVP_TRACK_FROM | AVP_CLASS_URI, backup_uri_from ); set_avp_list( AVP_TRACK_TO | AVP_CLASS_URI, backup_uri_to ); diff --git a/modules/tm/t_reply.h b/modules/tm/t_reply.h index 65b4498..c385697 100644 --- a/modules/tm/t_reply.h +++ b/modules/tm/t_reply.h @@ -160,7 +160,7 @@ void rpc_reply(rpc_t* rpc, void* c); void faked_env( struct cell *t,struct sip_msg *msg); int fake_req(struct sip_msg *faked_req, - struct sip_msg *shmem_msg, int extra_flags); + struct sip_msg *shmem_msg, int extra_flags, struct ua_client *uac); void free_faked_req(struct sip_msg *faked_req, struct cell *t); diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index 1c0b729..c1dc1b1 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -109,6 +109,7 @@ int t_continue(unsigned int hash_index, unsigned int label, struct cell *t; struct sip_msg faked_req; int branch; + struct ua_client *uac =NULL; if (t_lookup_ident(&t, hash_index, label) < 0) { LOG(L_ERR, "ERROR: t_continue: transaction not found\n"); @@ -136,13 +137,14 @@ int t_continue(unsigned int hash_index, unsigned int label, * a failure rute => deadlock, because both * of them need the reply lock to be held. */ t->uac[branch].last_received=500; + uac = &t->uac[branch]; } /* else Not a huge problem, fr timer will fire, but CANCEL will not be sent. last_received will be set to 408. */ /* fake the request and the environment, like in failure_route */ - if (!fake_req(&faked_req, t->uas.request, 0 /* extra flags */)) { + if (!fake_req(&faked_req, t->uas.request, 0 /* extra flags */, uac)) { LOG(L_ERR, "ERROR: t_continue: fake_req failed\n"); UNLOCK_REPLIES(t); return -1;

15 years, 8 months

git:master: core: renamed getbflsgs to getblagsval

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: d02a166db83db71b587cd1252db0b4d4954e8c93 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d02a166… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 19:21:04 2009 +0200 core: renamed getbflsgs to getblagsval - match the template of counterpart setblagsval - swapped the parameters --- dset.c | 2 +- dset.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dset.c b/dset.c index cbc636b..9409557 100644 --- a/dset.c +++ b/dset.c @@ -126,7 +126,7 @@ int resetbflag(unsigned int branch, flag_t flag) } -int getbflags(flag_t* res, unsigned int branch) +int getbflagsval(unsigned int branch, flag_t* res) { flag_t* flags; if (res == NULL) return -1; diff --git a/dset.h b/dset.h index e350238..adba10e 100644 --- a/dset.h +++ b/dset.h @@ -126,11 +126,11 @@ int isbflagset(unsigned int branch, flag_t flag); * * This function returns the value of all branch flags * combined in a single variable. - * @param res A pointer to a variable to store the result * @param branch Number of the branch (0 for the main Request-URI branch) + * @param res A pointer to a variable to store the result * @return 1 on success, -1 on failure */ -int getbflags(flag_t* res, unsigned int branch); +int getbflagsval(unsigned int branch, flag_t* res); /** * Set the value of all branch flags at once for a given branch.

15 years, 8 months

git:andrei/type_conversion: core expr eval: minor ==/!= optimization

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/type_conversion Commit: 04ff69818798e2330587c4109a69d8974908b158 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=04ff698… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Apr 28 17:49:54 2009 +0200 core expr eval: minor ==/!= optimization - replace the generic RVE_EQ_OP/RVE_DIFF_OP with the type specific version (RVE_IEQ_OP/RVE_STREQ_OP...), if the type is known. --- rvalue.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/rvalue.c b/rvalue.c index 36c6ef4..7e82503 100644 --- a/rvalue.c +++ b/rvalue.c @@ -2341,10 +2341,10 @@ static int rve_op_is_commutative(enum rval_expr_op op, enum rval_type type) case RVE_GTE_OP: case RVE_LT_OP: case RVE_LTE_OP: - case RVE_EQ_OP: + case RVE_CONCAT_OP: return 0; case RVE_DIFF_OP: - case RVE_CONCAT_OP: + case RVE_EQ_OP: #if !defined(UNDEF_EQ_ALWAYS_FALSE) && !defined(UNDEF_EQ_UNDEF_TRUE) return 1; #else @@ -2838,6 +2838,25 @@ static int rve_optimize(struct rval_expr* rve) rve->fpos.e_line, rve->fpos.e_col); } } + /* e1 EQ_OP e2 -> change op if we know e1 basic type + e1 DIFF_OP e2 -> change op if we know e2 basic type */ + if (rve->op==RVE_EQ_OP || rve->op==RVE_DIFF_OP){ + l_type=rve_guess_type(rve->left.rve); + if (l_type==RV_INT){ + rve->op=(rve->op==RVE_EQ_OP)?RVE_IEQ_OP:RVE_IDIFF_OP; + DBG("FIXUP RVE (%d,%d-%d,%d): changed ==/!= into interger" + " ==/!=\n", + rve->fpos.s_line, rve->fpos.s_col, + rve->fpos.e_line, rve->fpos.e_col); + }else if (l_type==RV_STR){ + rve->op=RVE_CONCAT_OP; + rve->op=(rve->op==RVE_EQ_OP)?RVE_STREQ_OP:RVE_STRDIFF_OP; + DBG("FIXUP RVE (%d,%d-%d,%d): changed ==/!= into string" + " ==/!=\n", + rve->fpos.s_line, rve->fpos.s_col, + rve->fpos.e_line, rve->fpos.e_col); + } + } /* $v * 0 => 0; $v * 1 => $v (for *, /, &, |, &&, ||, +, -) */ if (rve_opt_01(rve, type)==1){

15 years, 8 months

git:andrei/type_conversion: core expr eval: fix assoc., commut and 0 adding for +, ==

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/type_conversion Commit: 3c8fc182ae386713f15e6a0362924e72b257c31e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c8fc18… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Apr 28 18:34:03 2009 +0200 core expr eval: fix assoc., commut and 0 adding for +, == - fix associativity for the generic plus: because of the non-fixed argument types (can work with strings integers or both in the same type), RVE_PLUS_OP is associative _only_ if the operand types match. Non-assoc. example: "a" + 1 + "2" (can be "a12" or "a3"). Instead of adding extra checks for the same type, rely on the optimizer having already replaced RVE_PLUS_OP with RVE_IPLUS_OP or RVE_CONCAT_OP => RVE_PLUS_OP will be used only when the operands types are mixed or cannot be determined (e.g. AVP), or when script optimizations are turned off (-O0). - fix commutativity for the generic plus. Similar to the above. Non-commut. example: 1 + "2" == 3, but "2" + 1 == "21". - fix commutativity for the generic == and !=. Non. commut. example: 0 == "" , but "" != 0. Similar fix as above, relying on the optimizer and the type specific operators: RVE_IEQ_OP, RVE_IDIFF_OP, RVE_STREQ_OP and RVE_STRDIFF_OP. - fix $v + 0 / 0 + $v -> $v optimizations. Because of the generic plus and recent changes that allow int + str, even if the result is an int (left side operant is integer), 0 + $v can be different from $v. E.g.: 0+"1" == 1, which is different from "1". --- rvalue.c | 37 +++++++++++++++++++++++++++---------- 1 files changed, 27 insertions(+), 10 deletions(-) diff --git a/rvalue.c b/rvalue.c index 7e82503..9a74cda 100644 --- a/rvalue.c +++ b/rvalue.c @@ -2281,6 +2281,9 @@ static int rve_op_is_assoc(enum rval_expr_op op) case RVE_MINUS_OP: return 0; case RVE_PLUS_OP: + /* the generic plus is not assoc, e.g. + "a" + 1 + "2" => "a12" in one case and "a3" in the other */ + return 0; case RVE_IPLUS_OP: case RVE_CONCAT_OP: case RVE_MUL_OP: @@ -2308,7 +2311,7 @@ static int rve_op_is_assoc(enum rval_expr_op op) /** returns true if the operator is commutative. */ -static int rve_op_is_commutative(enum rval_expr_op op, enum rval_type type) +static int rve_op_is_commutative(enum rval_expr_op op) { switch(op){ case RVE_NONE_OP: @@ -2325,7 +2328,10 @@ static int rve_op_is_commutative(enum rval_expr_op op, enum rval_type type) case RVE_MINUS_OP: return 0; case RVE_PLUS_OP: - return type==RV_INT; /* commutative only for INT*/ + /* non commut. when diff. type + (e.g 1 + "2" != "2" + 1 ) => non commut. in general + (specific same type versions are covered by IPLUS & CONCAT) */ + return 0; case RVE_IPLUS_OP: case RVE_MUL_OP: case RVE_BAND_OP: @@ -2345,11 +2351,11 @@ static int rve_op_is_commutative(enum rval_expr_op op, enum rval_type type) return 0; case RVE_DIFF_OP: case RVE_EQ_OP: -#if !defined(UNDEF_EQ_ALWAYS_FALSE) && !defined(UNDEF_EQ_UNDEF_TRUE) - return 1; -#else + /* non. commut. in general, only for same type e.g.: + "" == 0 diff. 0 == "" ( "" == "0" and 0 == 0) + same type versions are covered by IEQ, IDIFF, STREQ, STRDIFF + */ return 0 /* asymmetrical undef handling */; -#endif } return 0; } @@ -2658,8 +2664,19 @@ static int rve_opt_01(struct rval_expr* rve, enum rval_type rve_type) case RVE_PLUS_OP: case RVE_IPLUS_OP: /* we must make sure that this is an int PLUS - (because "foo"+0 is valid => "foo0") */ - if ((i==0) && ((op==RVE_IPLUS_OP)||(rve_type==RV_INT))){ + (because "foo"+0 is valid => "foo0") + Even if overall type is RV_INT, it's still not safe + to optimize a generic PLUS: 0 + $v is not always equivalent + to $v (e.g. 0+"1" ==1 != "1") => optimize only if + IPLUS (always safe since it converts to int first) or + if generic PLUS and result is integer (rve_type) and + expression is of the form $v+ct (and not ct+$v). + TODO: dropping PLUS_OP all together and relying on the + optimizer replacing safe PLUS_OP with IPLUS_OP or CONCAT_OP + will simplify things. + */ + if ((i==0) && ((op==RVE_IPLUS_OP)|| + (rve_type==RV_INT && ct_rve==rve->right.rve))){ /* $v + 0 -> $v * 0 + $v -> $v */ rve_destroy(ct_rve); @@ -2908,7 +2925,7 @@ static int rve_optimize(struct rval_expr* rve) trv->v.s.len, trv->v.s.s, rve->op); ret=1; }else if (rve_is_constant(rve->left.rve->left.rve) && - rve_op_is_commutative(rve->op, type)){ + rve_op_is_commutative(rve->op)){ /* op(op(a, $v), b) => op(op(a, b), $v) */ /* rv= op(a, b) */ tmp_rve.op=rve->op; @@ -2950,7 +2967,7 @@ static int rve_optimize(struct rval_expr* rve) if ((rve->op==rve->right.rve->op) && rve_op_is_assoc(rve->op)){ /* op(a, op(...)) */ if (rve_is_constant(rve->right.rve->right.rve) && - rve_op_is_commutative(rve->op, type)){ + rve_op_is_commutative(rve->op)){ /* op(a, op($v, b)) => op(op(a, b), $v) */ /* rv= op(a, b) */ tmp_rve.op=rve->op;

15 years, 8 months

git:andrei/type_conversion: core: new script operators: eq, ne, ieq, ine

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/type_conversion Commit: 298512a2b79ff3bd9405a63c5d05030b5ec21de3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=298512a… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Apr 28 19:48:11 2009 +0200 core: new script operators: eq, ne, ieq, ine Added operators for: - string == and string != : eq, ne - integer == and integer!= : ieq, ine They are almost equivalent to == or !=, but they force the conversion of their operands (eq to string and ieq to int), allowing among other things better type checking on startup and more optimizations. Non equiv. examples: 0 == "" (true) is not equivalent to 0 eq "" (false: it evaluates to "0" eq ""). "a" ieq "b" (true: (int)"a" is 0 and (int)"b" is 0) is not equivalent to "a" == "b" (false). Note: the names are not final, they are mostly for testing. Future releases might replace ==/!= with ieq/ine and use eq/ne for strings. --- cfg.lex | 8 ++++++++ cfg.y | 8 +++++++- 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/cfg.lex b/cfg.lex index b1f9c55..768f3e9 100644 --- a/cfg.lex +++ b/cfg.lex @@ -248,6 +248,10 @@ MINUS "-" STRLEN "strlen" STREMPTY "strempty" DEFINED "defined" +STREQ eq +INTEQ ieq +STRDIFF ne +INTDIFF ine /* Attribute specification */ ATTR_MARK "%" @@ -772,6 +776,10 @@ EAT_ABLE [\ \t\b\r] <INITIAL>{STRLEN} { count(); return STRLEN; } <INITIAL>{STREMPTY} { count(); return STREMPTY; } <INITIAL>{DEFINED} { count(); return DEFINED; } +<INITIAL>{STREQ} { count(); return STREQ; } +<INITIAL>{INTEQ} { count(); return INTEQ; } +<INITIAL>{STRDIFF} { count(); return STRDIFF; } +<INITIAL>{INTDIFF} { count(); return INTDIFF; } <INITIAL>{SELECT_MARK} { count(); state = SELECT_S; BEGIN(SELECT); return SELECT_MARK; } <SELECT>{ID} { count(); addstr(&s_buf, yytext, yyleng); diff --git a/cfg.y b/cfg.y index a281052..df3056d 100644 --- a/cfg.y +++ b/cfg.y @@ -484,7 +484,7 @@ static int case_check_default(struct case_stms* stms); %left LOG_AND %left BIN_OR %left BIN_AND -%left EQUAL_T DIFF MATCH +%left EQUAL_T DIFF MATCH INTEQ INTDIFF STREQ STRDIFF %left GT LT GTE LTE %left PLUS MINUS %left STAR SLASH @@ -1580,6 +1580,8 @@ exp: rval_expr equalop: EQUAL_T {$$=EQUAL_OP; } | DIFF {$$=DIFF_OP; } + | STREQ {$$=EQUAL_OP; } /* for expr. elems equiv. to EQUAL_T*/ + | STRDIFF {$$=DIFF_OP; } /* for expr. elems. equiv. to DIFF */ ; cmpop: GT {$$=GT_OP; } @@ -1597,6 +1599,10 @@ strop: rve_equalop: EQUAL_T {$$=RVE_EQ_OP; } | DIFF {$$=RVE_DIFF_OP; } + | INTEQ {$$=RVE_IEQ_OP; } + | INTDIFF {$$=RVE_IDIFF_OP; } + | STREQ {$$=RVE_STREQ_OP; } + | STRDIFF {$$=RVE_STRDIFF_OP; } ; rve_cmpop: GT {$$=RVE_GT_OP; }

15 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev