sr-dev

sr-dev@lists.kamailio.org

15 participants
42808 discussions

git:andrei/switch: script parsing: C style switch() & case support

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/switch Commit: a29a8b6ddba24b8e71faaf78e7426aa7f85c19b5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a29a8b6… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Feb 4 20:44:26 2009 +0100 script parsing: C style switch() & case support - support for parsing C style switch() & case, e.g.: switch($var){ case 1: log(1, "1\n"); break; case 2: case 3: default: log(1, "default\n"); } (note: this is different from kamailio/openser switch()) --- cfg.lex | 7 +++ cfg.y | 122 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- route_struct.h | 8 +++- switch.h | 60 +++++++++++++++++++++++++++ 4 files changed, 194 insertions(+), 3 deletions(-) diff --git a/cfg.lex b/cfg.lex index fc9eecb..13767b1 100644 --- a/cfg.lex +++ b/cfg.lex @@ -187,6 +187,9 @@ ELSE "else" SET_ADV_ADDRESS "set_advertised_address" SET_ADV_PORT "set_advertised_port" FORCE_SEND_SOCKET "force_send_socket" +SWITCH "switch" +CASE "case" +DEFAULT "default" /*ACTION LVALUES*/ URIHOST "uri:host" @@ -495,6 +498,10 @@ EAT_ABLE [\ \t\b\r] return SET_ADV_PORT; } <INITIAL>{FORCE_SEND_SOCKET} { count(); yylval.strval=yytext; return FORCE_SEND_SOCKET; } +<INITIAL>{SWITCH} { count(); yylval.strval=yytext; return SWITCH; } +<INITIAL>{CASE} { count(); yylval.strval=yytext; return CASE; } +<INITIAL>{DEFAULT} { count(); yylval.strval=yytext; return DEFAULT; } + <INITIAL>{URIHOST} { count(); yylval.strval=yytext; return URIHOST; } <INITIAL>{URIPORT} { count(); yylval.strval=yytext; return URIPORT; } diff --git a/cfg.y b/cfg.y index 63c9eb4..431054d 100644 --- a/cfg.y +++ b/cfg.y @@ -93,6 +93,7 @@ * lval=rval_expr, where lval=avp|pvar (andrei) * 2007-12-06 expression are now evaluated in terms of rvalues; * NUMBER is now always positive; cleanup (andrei) + * 2009-01-26 case/switch() support (andrei) */ %{ @@ -109,6 +110,7 @@ #include "route_struct.h" #include "globals.h" #include "route.h" +#include "switch.h" #include "dprint.h" #include "sr_module.h" #include "modparam.h" @@ -211,6 +213,8 @@ static struct socket_id* mk_listen_id2(struct name_lst*, int, int); static void free_name_lst(struct name_lst* lst); static void free_socket_id_lst(struct socket_id* i); +static struct case_stms* mk_case_stm(struct rval_expr* ct, struct action* a); + %} %union { @@ -219,6 +223,7 @@ static void free_socket_id_lst(struct socket_id* i); char* strval; struct expr* expr; struct action* action; + struct case_stms* case_stms; struct net* ipnet; struct ip_addr* ipaddr; struct socket_id* sockid; @@ -272,6 +277,9 @@ static void free_socket_id_lst(struct socket_id* i); %token SET_ADV_ADDRESS %token SET_ADV_PORT %token FORCE_SEND_SOCKET +%token SWITCH +%token CASE +%token DEFAULT %token URIHOST %token URIPORT %token MAX_LEN @@ -493,6 +501,8 @@ static void free_socket_id_lst(struct socket_id* i); %type <intval> intno eint_op eint_op_onsend %type <intval> eip_op eip_op_onsend %type <action> action actions cmd fcmd if_cmd stm /*exp_stm*/ assign_action +%type <action> switch_cmd +%type <case_stms> single_case case_stms %type <ipaddr> ipv4 ipv6 ipv6addr ip %type <ipnet> ipnet %type <strval> host @@ -514,7 +524,7 @@ static void free_socket_id_lst(struct socket_id* i); %type <attr> attr_id_any_str %type <pvar> pvar %type <lval> lval -%type <rv_expr> rval rval_expr +%type <rv_expr> rval rval_expr ct_rval %type <lval> avp_pvar /* %type <intval> class_id */ %type <intval> assign_op @@ -1762,6 +1772,7 @@ actions: action: fcmd SEMICOLON {$$=$1;} | if_cmd {$$=$1;} + | switch_cmd {$$=$1;} | assign_action SEMICOLON {$$=$1;} | SEMICOLON /* null action */ {$$=0;} | fcmd error { $$=0; yyerror("bad command: missing ';'?"); } @@ -1770,6 +1781,98 @@ if_cmd: IF exp stm { $$=mk_action( IF_T, 3, EXPR_ST, $2, ACTIONS_ST, $3, NOSUBTYPE, 0); } | IF exp stm ELSE stm { $$=mk_action( IF_T, 3, EXPR_ST, $2, ACTIONS_ST, $3, ACTIONS_ST, $5); } ; + +ct_rval: rval_expr { + $$=0; + if (!rve_is_constant($1)){ + yyerror("constant expected"); + }else if (!rve_check_type((enum rval_type*)&i_tmp, $1, 0, 0 ,0)){ + yyerror("invalid expression (bad type)"); + }else if (i_tmp!=RV_INT){ + yyerror("invalid expression type, int expected\n"); + }else + $$=$1; + } +; +single_case: + CASE ct_rval COLON actions { + $$=0; + if ($2==0) yyerror ("bad case label"); + else if (($$=mk_case_stm($2, $4))==0){ + yyerror("internal error: memory allocation failure"); + YYABORT; + } + } + | CASE ct_rval COLON { + $$=0; + if ($2==0) yyerror ("bad case label"); + else if (($$=mk_case_stm($2, 0))==0){ + yyerror("internal error: memory allocation failure"); + YYABORT; + } + } + | DEFAULT COLON actions { + if (($$=mk_case_stm(0, $3))==0){ + yyerror("internal error: memory allocation failure"); + YYABORT; + } + } + | DEFAULT COLON { + if (($$=mk_case_stm(0, 0))==0){ + yyerror("internal error: memory allocation failure"); + YYABORT; + } + } + | CASE error { $$=0; yyerror("bad case label"); } + | CASE ct_rval COLON error { $$=0; yyerror ("bad case body"); } +; +case_stms: + case_stms single_case { + $$=$1; + if ($2==0) yyerror ("bad case"); + if ($$){ + *($$->append)=$2; + if (*($$->append)!=0) + $$->append=&((*($$->append))->next); + } + } + | single_case { + $$=$1; + if ($1==0) yyerror ("bad case"); + else $$->append=&($$->next); + } +; +switch_cmd: + SWITCH rval_expr LBRACE case_stms RBRACE { + $$=0; + if ($2==0) yyerror("bad expression in switch(...)"); + else if ($4==0) yyerror ("bad switch body"); + else{ + $$=mk_action(SWITCH_T, 2, RVE_ST, $2, CASE_ST, $4); + if ($$==0) { + yyerror("internal error"); + YYABORT; + } + } + } + | SWITCH rval_expr LBRACE RBRACE { + $$=0; + warn("empty switch()"); + if ($2==0) yyerror("bad expression in switch(...)"); + else{ + /* it might have sideffects, so leave it for the optimizer */ + $$=mk_action(SWITCH_T, 2, RVE_ST, $2, CASE_ST, 0); + if ($$==0) { + yyerror("internal error"); + YYABORT; + } + } + } + | SWITCH error { $$=0; yyerror ("bad expression in switch(...)"); } + | SWITCH rval_expr LBRACE error RBRACE + {$$=0; yyerror ("bad switch body"); } +; + /* class_id: LBRACK ATTR_USER RBRACK { $$ = AVP_CLASS_USER; } | LBRACK ATTR_DOMAIN RBRACK { $$ = AVP_CLASS_DOMAIN; } @@ -2763,6 +2866,23 @@ static void free_socket_id_lst(struct socket_id* lst) } } + +static struct case_stms* mk_case_stm(struct rval_expr* ct, struct action* a) +{ + struct case_stms* s; + s=pkg_malloc(sizeof(*s)); + if (s==0) { + LOG(L_CRIT,"ERROR: cfg. parser: out of memory.\n"); + } else { + memset(s, 0, sizeof(*s)); + s->ct_rve=ct; + s->actions=a; + s->next=0; + s->append=0; + } + return s; +} + /* int main(int argc, char ** argv) { diff --git a/route_struct.h b/route_struct.h index 76aac25..e87b2d0 100644 --- a/route_struct.h +++ b/route_struct.h @@ -70,7 +70,9 @@ enum { METHOD_O=1, URI_O, FROM_URI_O, TO_URI_O, SRCIP_O, SRCPORT_O, enum { FORWARD_T=1, SEND_T, DROP_T, LOG_T, ERROR_T, ROUTE_T, EXEC_T, SET_HOST_T, SET_HOSTPORT_T, SET_USER_T, SET_USERPASS_T, SET_PORT_T, SET_URI_T, SET_HOSTPORTTRANS_T, - IF_T, MODULE_T, MODULE3_T, MODULE4_T, MODULE5_T, MODULE6_T, MODULEX_T, + IF_T, SWITCH_T /* only until fixup*/, + BLOCK_T, EVAL_T, SWITCH_JT_T, SWITCH_COND_T, + MODULE_T, MODULE3_T, MODULE4_T, MODULE5_T, MODULE6_T, MODULEX_T, SETFLAG_T, RESETFLAG_T, ISFLAGSET_T , AVPFLAG_OPER_T, LEN_GT_T, PREFIX_T, STRIP_T,STRIP_TAIL_T, @@ -96,7 +98,9 @@ enum { NOSUBTYPE=0, STRING_ST, NET_ST, NUMBER_ST, IP_ST, RE_ST, PROXY_ST, MYSELF_ST, STR_ST, SOCKID_ST, SOCKETINFO_ST, ACTION_ST, AVP_ST, SELECT_ST, PVAR_ST, LVAL_ST, RVE_ST, - RETCODE_ST}; + RETCODE_ST, CASE_ST, + BLOCK_ST, JUMPTABLE_ST, CONDTABLE_ST +}; /* run flags */ #define EXIT_R_F 1 diff --git a/switch.h b/switch.h new file mode 100644 index 0000000..4c9f78b --- /dev/null +++ b/switch.h @@ -0,0 +1,60 @@ +/* + * $Id$ + * + * Copyright (C) 2009 iptelorg GmbH + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + */ +/* + * /home/andrei/sr.git/switch.h + */ +/* + * History: + * -------- + * 2009-02-02 initial version (andrei) +*/ + +#ifndef __switch_h +#define __switch_h + +#include "route_struct.h" + +struct case_stms{ + struct rval_expr* ct_rve; + struct action* actions; + struct case_stms* next; + struct case_stms** append; + int int_label; + int is_default; +}; + + +struct switch_cond_table{ + int n; /**< size */ + int* cond; /**< int labels array */ + struct action** jump; /**< jump points array */ + struct action* def; /**< default jump */ +}; + + +struct switch_jmp_table{ + int first; /**< first int label in the jump table */ + int last; /**< last int label in the jump table */ + struct action** tbl; /**< jmp table [v-first] iff first<=v<=last */ + struct switch_cond_table rest; /**< normal cond. table for the rest */ +}; + + +#endif /*__switch_h*/ + +/* vi: set ts=4 sw=4 tw=79:ai:cindent: */

15 years, 3 months

git:andrei/switch: expr engine: minor additions

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/switch Commit: 2d6686519542ee12bedbe085500ed3cd6f87f280 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2d66865… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Feb 4 19:20:53 2009 +0100 expr engine: minor additions - added rve_has_side_effects(), preliminary version (for now is equivalent with !rve_is_constant()) - exported rve_destroy() --- rvalue.c | 11 +++++++++++ rvalue.h | 4 ++++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/rvalue.c b/rvalue.c index 9e020ef..4c7472d 100644 --- a/rvalue.c +++ b/rvalue.c @@ -452,6 +452,17 @@ int rve_is_constant(struct rval_expr* rve) +/** returns true if the expression has side-effects. + * @return 1 for possible side-effects, 0 for no side-effects + * TODO: add better checks + */ +int rve_has_side_effects(struct rval_expr* rve) +{ + return !rve_is_constant(rve); +} + + + /** returns true if operator is unary (takes only 1 arg). * @return 0 or 1 on */ diff --git a/rvalue.h b/rvalue.h index a694c0d..88fd6f2 100644 --- a/rvalue.h +++ b/rvalue.h @@ -188,6 +188,8 @@ int rval_expr_eval_rvint( struct run_act_ctx* h, struct sip_msg* msg, enum rval_type rve_guess_type(struct rval_expr* rve); /** returns true if expression is constant. */ int rve_is_constant(struct rval_expr* rve); +/** returns true if the expression can have side-effect */ +int rve_has_side_effects(struct rval_expr* rve); /** returns 1 if expression is valid (type-wise).*/ int rve_check_type(enum rval_type* type, struct rval_expr* rve, struct rval_expr** bad_rve, enum rval_type* bad_type, @@ -206,6 +208,8 @@ struct rval_expr* mk_rval_expr1(enum rval_expr_op op, struct rval_expr* rve1, struct rval_expr* mk_rval_expr2(enum rval_expr_op op, struct rval_expr* rve1, struct rval_expr* rve2, struct cfg_pos* pos); +/** destroys a pkg_malloc'ed rve. */ +void rve_destroy(struct rval_expr* rve); /** fix a rval_expr. */ int fix_rval_expr(void** p);

15 years, 3 months

git:andrei/switch: script engine: switch() fixup and optimizations

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/switch Commit: 4221104f5cb3f60866d13ceedf05f00c62c0160f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4221104… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Feb 4 20:48:04 2009 +0100 script engine: switch() fixup and optimizations - optimize/transform switch() statements into: - jump tables (if small enough) - condition tables - simple blocks (optimization when the expression in switch() is constant) - only a condition evaluator (when the switch body is empty, but the switch expression has side-effect and hence cannot be optimized away) --- route.c | 25 ++++- switch.c | 374 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 398 insertions(+), 1 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=422…

15 years, 3 months

FOSDEM Meeting - Feb 7, 2009, 19:30, Le Mess

by Daniel-Constantin Mierla

Hello, the place for the social networking event at FOSDEM 2009 has been selected: Le Mess http://www2.resto.be/mess/home-en.htm Louis Schmidtlaan - Av. Louis Schmidt 1 1040 BRUXELLES (ETTERBEEK) It is in walking distance from FOSDEM site. More details at: http://www.kamailio.org/mos/view/News/NewsItem/FOSDEM-2009---Social-Network… If you haven't confirmed your participation, you can still join, subject of available free places in the restaurant. See you Saturday! Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

15 years, 3 months

FOSDEM 2009 - Kamailio (OpenSER)/SIP-Router Social Networking Event

by Daniel-Constantin Mierla

Hello, a bunch of us will be at FOSDEM 2009: http://fosdem.org/2009/ Therefore is the opportunity for first Social Networking Event in 2009. Everyone interested in Kamailio (OpenSER), SIP Router, SER, SIP and not only are invited to join -- participation is free, everybody pays for its expenses. The event is very likely to be a dinner on Saturday evening, Feb 7, 2009. So far, from Kamailio (OpenSER) community you can meet there: - Henning Westerholt - http://www.kamailio.org/mos/view/Management/ - Elena-Ramona Modroiu - http://www.kamailio.org/mos/view/Management/ - Daniel-Constantin Mierla - http://www.kamailio.org/mos/view/Management/ - Dan Bogos - http://itsyscom.com/ In order to know properly the size of the place we need, please drop me an email if you intend to attend. People knowing Brussels are welcome to suggest a nice place to meet (good beer and food are a must). Looking forward to meeting you in Brussels. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

15 years, 3 months

Any usable release up to now?

by Anto

Dear All, I wanted to seriously use OpenSER last September, but I dropped it after I read all the disputes. And for some reasons, I don't want to use SER or OpenSIPS. It looks to me that this SIP Router project is more promising especially for long run. Now to the question. It looks to me there is no useable release of SIP Router up to now. Is that right? If so, when could we have the merged release of Kamailio and SER? Kind regards, Anto

15 years, 4 months

compare uri and aor

by Daniel-Constantin Mierla

Hello, this should be valueable for sip-router.org as well. I have introduced in siputils module of Kamailio functions to compare SIP URI and AoR in a more RFC manner, related to: https://sourceforge.net/tracker/index.php?func=detail&aid=2047019&group_id=… Now, for URI it does comparison of: - username - password - hostname - port For AoR, it does: - username - hostname - port (if port is missing, it assumes 5060 -- for URI comparison this is not used, conform to RFC3261) The questions are: - shall the comparison for URI be extended to follow full RFC? could get complex when taking URI headers in account -- haven't seen many, but the RFC allow them. Where to stop then the rules for comparing the URI? - for AoR, I am not sure if port should be considered, but when running multiple instances on different ports, it may make the difference? What do you think? Has SER now dedicated functions to match AoRs and URIs? Cheers, Daniel

15 years, 4 months

git:master: Merge commit 'origin/daniel/pv'

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 7f8d719463e954604ffba935b1f82ada2b07850e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7f8d719… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Dec 19 14:57:57 2008 +0100 Merge commit 'origin/daniel/pv' * commit 'origin/daniel/pv': fix add/lookup pv name fix pv&t lookup due to signness pv api updates - list of PVs types syncronized with Kamailio Conflicts: pvapi.c ---

15 years, 5 months

git:master: Merge commit 'origin/andrei/script_vars'

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 2cd96a356359eb75022f1f6ea7c9dfbbcd9323aa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2cd96a3… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Dec 19 14:32:32 2008 +0100 Merge commit 'origin/andrei/script_vars' * commit 'origin/andrei/script_vars': (30 commits) script parsing: helper function updated & moved script engine: different operators for int and str + script engine: keep file pos. info when optimizing script engine: optimize op($v, ct) where ct=0 or 1 script engine: optimize $v - ct script engine: pvar & avp fixes script: fix pvar parsing script parsing: better expression error reporting script parsing: expression type checking on startup script engine: rve_check_type() extended pvars: silent version for pv_parse_spec script parsing: better error reporting script parsing: fix line/column counting in strings script parsing: support for breaking strings script engine: more rvalue optimizations script engine: better debugging info core: new command line option (debugging) script engine: rvalue fixes & cleanup script engine: expression optimizations script parsing: fixed wrong operators in expr. ... ---

15 years, 5 months

git:master: script engine: minor fix

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 75fc3dbf97269b6bdb1c36f9f81276cdba4f359a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=75fc3db… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Dec 19 14:40:52 2008 +0100 script engine: minor fix - warning fixes and minor rval_expr_eval_rvint() fix --- rvalue.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/rvalue.c b/rvalue.c index 6471e85..9e020ef 100644 --- a/rvalue.c +++ b/rvalue.c @@ -1449,6 +1449,7 @@ int rval_expr_eval_rvint( struct run_act_ctx* h, rv1=0; rv2=0; + ret=-1; switch(rve->op){ case RVE_RVAL_OP: rv1=&rve->left.rval; @@ -1506,7 +1507,7 @@ int rval_expr_eval_rvint( struct run_act_ctx* h, rval_cache_clean(&c1); goto error; } - int_intop2(res_i, rve->op, i, j); + ret=int_intop2(res_i, rve->op, i, j); *res_rv=0; }else{ rv2=rval_expr_eval(h, msg, rve->right.rve); @@ -1559,6 +1560,7 @@ struct rvalue* rval_expr_eval(struct run_act_ctx* h, struct sip_msg* msg, rv1=0; rv2=0; + ret=0; switch(rve->op){ case RVE_RVAL_OP: rv_ref(&rve->left.rval);

15 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev