sr-dev

sr-dev@lists.kamailio.org

13 participants
44200 discussions

git:master: nathelper (k): fix for flag 'l'

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: d4796d9a04562e3bc9d45acd68393eb418828e98 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d4796d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 2 11:44:58 2009 +0200 nathelper (k): fix for flag 'l' - fix SF: #2814137 - handle re-invite with force_rtp_proxy("l"); - patch by Marcus Hunger --- modules_k/nathelper/nathelper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nathelper.c b/modules_k/nathelper/nathelper.c index b9c59a6..01ae520 100644 --- a/modules_k/nathelper/nathelper.c +++ b/modules_k/nathelper/nathelper.c @@ -2608,7 +2608,7 @@ force_rtp_proxy(struct sip_msg* msg, char* str1, char* str2, int offer) if (to_tag.len == 0) return -1; create = 0; - if (swap != 0) { + if (swap != 0 || (msg->first_line.type == SIP_REPLY && offer != 0)) { tmp = from_tag; from_tag = to_tag; to_tag = tmp;

15 years, 6 months

git:master: nathelper(k): fix for very long payload-type

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8c97cfc35fcaf17f67810f98725bb636601bb38b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8c97cfc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 2 11:47:29 2009 +0200 nathelper(k): fix for very long payload-type - fix SF: #2813924: publishing very long payload-type to the rtp-proxy overflows a buffer - patch by Marcus Hunger --- modules_k/nathelper/nathelper.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nathelper.c b/modules_k/nathelper/nathelper.c index 01ae520..8c71ef9 100644 --- a/modules_k/nathelper/nathelper.c +++ b/modules_k/nathelper/nathelper.c @@ -2779,7 +2779,9 @@ force_rtp_proxy(struct sip_msg* msg, char* str1, char* str2, int offer) * a comma-separated list. */ for (cp = payload_types.s; - cp < payload_types.s + payload_types.len; cp++) { + (cp < payload_types.s + payload_types.len) && + (cp1 - (char *)v[1].iov_base < sizeof(opts) - 1); + cp++) { if (isdigit(*cp)) { *cp1 = *cp; cp1++;

15 years, 6 months

git:master: avpops: merge avpops modules

by Klaus Darilion

Module: sip-router Branch: master Commit: 90d2ba0236c7cb4a72ba074fbec7a86a89024e37 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=90d2ba0… Author: Klaus Darilion <klaus.mailinglists(a)pernau.at> Committer: Klaus Darilion <klaus.mailinglists(a)pernau.at> Date: Thu Jul 2 11:35:22 2009 +0200 avpops: merge avpops modules - delete ser's avpops module (does not compile anyway) - use K's avpops module as common avpops module - Note: probably many of the avpops commands are not needed anymore as AVPs can be used directly in config script --- {modules_k => modules}/avpops/Makefile | 0 {modules_k => modules}/avpops/README | 0 {modules_k => modules}/avpops/avpops.c | 0 {modules_k => modules}/avpops/avpops_db.c | 0 {modules_k => modules}/avpops/avpops_db.h | 0 {modules_k => modules}/avpops/avpops_impl.c | 0 {modules_k => modules}/avpops/avpops_impl.h | 0 {modules_k => modules}/avpops/avpops_parse.c | 0 {modules_k => modules}/avpops/avpops_parse.h | 0 {modules_k => modules}/avpops/doc/Makefile | 0 {modules_k => modules}/avpops/doc/avpops.xml | 0 {modules_k => modules}/avpops/doc/avpops_admin.xml | 0 modules_s/avpops/Makefile | 17 - modules_s/avpops/README | 489 --------- modules_s/avpops/avpops.c | 853 -------------- modules_s/avpops/avpops_db.c | 319 ------ modules_s/avpops/avpops_db.h | 75 -- modules_s/avpops/avpops_impl.c | 1158 -------------------- modules_s/avpops/avpops_impl.h | 132 --- modules_s/avpops/avpops_parse.c | 587 ---------- modules_s/avpops/avpops_parse.h | 56 - modules_s/avpops/doc/Makefile | 4 - modules_s/avpops/doc/avpops.xml | 72 -- modules_s/avpops/doc/faq.xml | 81 -- modules_s/avpops/doc/functions.xml | 371 ------- modules_s/avpops/doc/params.xml | 222 ---- modules_s/avpops/ser-avpops.cfg | 24 - 27 files changed, 0 insertions(+), 4460 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=90d…

15 years, 6 months

[ openser-Bugs-2814137 ] force_rtp_proxy bug

by SourceForge.net

Bugs item #2814137, was opened at 2009-06-29 20:29 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Marcus Hunger (marcushunger) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: force_rtp_proxy bug Initial Comment: force_rtp_proxy seems to handle re-invite wrong, resulting in one-way-audio. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-02 12:33 Message: Patch applied to 1.5. Thanks. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2009-07-01 12:14 Message: sdp is in invite and 200 ok. the thing is, nearly the same config still worked in 1.2-branch, but after an upgrade to 1.4 it stopped. it happens always, no matter if the callee or caller does the reinvite. the following trace shows what happens. the rtpproxy-port in invite and reply is 41324. they must differ as they are used for different media-streams. 217.10.1.1 - sip-proxy & rtpproxy 172.20.21.2 - sip-proxy doing rtpproxy_* stuff 217.10.66.165 - uac 217.10.1.2 - uas U 217.10.1.1:5060 -> 172.20.21.2:5060 INVITE sip:3993942p0@217.10.1.2 SIP/2.0. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. Route: <sip:172.20.21.2;lr=on>. CSeq: 4 INVITE. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. Contact: <sip:3993942e1@217.10.66.165:61020>. Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, INFO, MESSAGE, SUBSCRIBE, NOTIFY, PRACK, UPDATE, REFER. User-Agent: PolycomSoundPointIP-SPIP_650-UA/2.1.2.0078. Supported: 100rel,replaces. Allow-Events: talk,hold,conference. Max-Forwards: 69. Content-Type: application/sdp. Content-Length: 297. X-hint: rr-enforced. X-nathint: nat. . v=0. o=- 1246290867 1246290869 IN IP4 192.168.234.24. s=Polycom IP Phone. c=IN IP4 192.168.234.24. t=0 0. m=audio 2262 RTP/AVP 9 0 8 18 101. a=sendrecv. a=rtpmap:9 G722/8000. a=rtpmap:0 PCMU/8000. a=rtpmap:8 PCMA/8000. a=rtpmap:18 G729/8000. a=rtpmap:101 telephone-event/8000. a=direction:active. # U 172.20.21.2:5060 -> 217.10.1.1:5060 SIP/2.0 100 Giving a try. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. CSeq: 4 INVITE. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. Content-Length: 0. . # U 172.20.21.2:5060 -> 217.10.1.2:5060 INVITE sip:3993942p0@217.10.1.2 SIP/2.0. Via: SIP/2.0/UDP 172.20.21.2;branch=z9hG4bKe2fc.9dcfa89.0. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. CSeq: 4 INVITE. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. Contact: <sip:3993942e1@217.10.66.165:61020>. Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, INFO, MESSAGE, SUBSCRIBE, NOTIFY, PRACK, UPDATE, REFER. User-Agent: PolycomSoundPointIP-SPIP_650-UA/2.1.2.0078. Supported: 100rel,replaces. Allow-Events: talk,hold,conference. Max-Forwards: 68. Content-Type: application/sdp. Content-Length: 315. X-hint: rr-enforced. X-nathint: nat. . v=0. o=- 1246290867 1246290869 IN IP4 192.168.234.24. s=Polycom IP Phone. c=IN IP4 217.10.1.1. t=0 0. m=audio 41324 RTP/AVP 9 0 8 18 101. a=sendrecv. a=rtpmap:9 G722/8000. a=rtpmap:0 PCMU/8000. a=rtpmap:8 PCMA/8000. a=rtpmap:18 G729/8000. a=rtpmap:101 telephone-event/8000. a=direction:active. a=nortpproxy:yes. # U 217.10.1.2:5060 -> 172.20.21.2:5060 SIP/2.0 100 Trying. Via: SIP/2.0/UDP 172.20.21.2;branch=z9hG4bKe2fc.9dcfa89.0;received=172.20.21.2. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. CSeq: 4 INVITE. Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY. Supported: replaces, timer. Contact: <sip:3993942p0@217.10.1.2>. Content-Length: 0. . # U 217.10.1.2:5060 -> 172.20.21.2:5060 SIP/2.0 200 OK. Via: SIP/2.0/UDP 172.20.21.2;branch=z9hG4bKe2fc.9dcfa89.0;received=172.20.21.2. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. CSeq: 4 INVITE. Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY. Supported: replaces, timer. Contact: <sip:3993942p0@217.10.1.2>. Content-Type: application/sdp. Content-Length: 329. . v=0. o=root 647471219 647471221 IN IP4 217.10.1.2. s=sipgate VoIP GW. c=IN IP4 217.10.1.2. t=0 0. m=audio 17732 RTP/AVP 8 0 18 101. a=rtpmap:8 PCMA/8000. a=rtpmap:0 PCMU/8000. a=rtpmap:18 G729/8000. a=fmtp:18 annexb=no. a=rtpmap:101 telephone-event/8000. a=fmtp:101 0-16. a=silenceSupp:off - - - -. a=ptime:20. a=sendrecv. ## U 172.20.21.2:5060 -> 217.10.1.1:5060 SIP/2.0 200 OK. Via: SIP/2.0/UDP 217.10.1.1:5060;branch=z9hG4bK78fccbad7757B75A. Via: SIP/2.0/UDP 192.168.234.24;rport=61020;received=217.10.66.165;branch=z9hG4bK78fccbad7757B75A. From: "Erika" <sip:3993942e1@sipgate.de>;tag=D6DBB0FD-C198C6EA. To: <sip:10@sipgate.de;user=phone>;tag=as3804b1ae. Call-ID: e521bbee-f129e0af-f6e95884(a)192.168.234.24. CSeq: 4 INVITE. Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY. Supported: replaces, timer. Contact: <sip:3993942p0@217.10.1.2>. Content-Type: application/sdp. Content-Length: 347. . v=0. o=root 647471219 647471221 IN IP4 217.10.1.2. s=sipgate VoIP GW. c=IN IP4 217.10.1.1. t=0 0. m=audio 41324 RTP/AVP 8 0 18 101. a=rtpmap:8 PCMA/8000. a=rtpmap:0 PCMU/8000. a=rtpmap:18 G729/8000. a=fmtp:18 annexb=no. a=rtpmap:101 telephone-event/8000. a=fmtp:101 0-16. a=silenceSupp:off - - - -. a=ptime:20. a=sendrecv. a=nortpproxy:yes. ---------------------------------------------------------------------- Comment By: Klaus Darilion (klaus_darilion) Date: 2009-07-01 09:53 Message: do you have a SIP trace? Is it maybe related to late offer (SDP in 200 OK and ACK)? Does the bug happens always or only if the reINVITE is sent by the callee? ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-06-30 16:15 Message: in detail, the sdp is rewritten with the wrong port for this direction of the session. it's the same as the answer's which does not work. to build the query for the rtp-proxy from- and to-tag the have to be reversed in this case. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2009-06-30 12:45 Message: happens when i handle a reinvite with rtpproxy_offer("l") ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-06-29 21:19 Message: When is this happening? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_…

15 years, 6 months

SF.net SVN: openser:[5891] branches/1.5/modules/nathelper/nathelper.c

by Daniel-Constantin Mierla

Revision: 5891 http://openser.svn.sourceforge.net/openser/?rev=5891&view=rev Author: miconda Date: 2009-07-02 09:32:45 +0000 (Thu, 02 Jul 2009) Log Message: ----------- - fix #2814137 - handle re-invite with force_rtp_proxy("l"); - patch by Marcus Hunger Modified Paths: -------------- branches/1.5/modules/nathelper/nathelper.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 6 months

[ openser-Bugs-2813924 ] nathelper crash

by SourceForge.net

Bugs item #2813924, was opened at 2009-06-29 14:55 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2813924&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Marcus Hunger (marcushunger) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: nathelper crash Initial Comment: publishing very long payload-type to the rtp-proxy overflows a buffer. see nathelper.c +2758. v[1].iov_len must be smaller than sizeof(opts) ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-02 12:01 Message: Thanks! Committed to 1.5. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2009-06-30 12:41 Message: ah, sorry, you're right. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-06-30 12:06 Message: Did you meant '&&' operator instead of ',' in for condition? Otherwise: warning: left-hand operand of comma expression has no effect ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2813924&group_…

15 years, 6 months

SF.net SVN: openser:[5890] branches/1.5/modules/nathelper/nathelper.c

by Daniel-Constantin Mierla

Revision: 5890 http://openser.svn.sourceforge.net/openser/?rev=5890&view=rev Author: miconda Date: 2009-07-02 09:00:06 +0000 (Thu, 02 Jul 2009) Log Message: ----------- - fix #2813924: publishing very long payload-type to the rtp-proxy overflows a buffer - patch by Marcus Hunger Modified Paths: -------------- branches/1.5/modules/nathelper/nathelper.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 6 months

git:master: according to Di-Shi are K's and ser' s osp module more or less the same, whereas Kamailio' s osp module should be more up2date than ser's module. Thus, ser' s osp module will be removed and K' s osp module will be used as common OSP module.

by Klaus Darilion

Module: sip-router Branch: master Commit: 6bdbd8e2ab1ec15695cc156ff74f20af799a947b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6bdbd8e… Author: Klaus Darilion <klaus.mailinglists(a)pernau.at> Committer: Klaus Darilion <klaus.mailinglists(a)pernau.at> Date: Thu Jul 2 10:34:13 2009 +0200 according to Di-Shi are K's and ser's osp module more or less the same, whereas Kamailio's osp module should be more up2date than ser's module. Thus, ser's osp module will be removed and K's osp module will be used as common OSP module. --- {modules_k => modules}/osp/Makefile | 0 {modules_k => modules}/osp/README | 0 {modules_k => modules}/osp/RELEASE-NOTES.txt | 0 {modules_k => modules}/osp/destination.c | 0 {modules_k => modules}/osp/destination.h | 0 {modules_k => modules}/osp/doc/Makefile | 0 {modules_k => modules}/osp/doc/osp.xml | 0 {modules_k => modules}/osp/doc/osp_admin.xml | 0 {modules_k => modules}/osp/doc/osp_devel.xml | 0 {modules_k => modules}/osp/etc/cacert_0.pem | 0 {modules_k => modules}/osp/etc/localcert.pem | 0 {modules_k => modules}/osp/etc/pkey.pem | 0 .../osp/etc/sample-osp-openser.cfg | 0 {modules_k => modules}/osp/globals.c | 0 {modules_k => modules}/osp/orig_transaction.c | 0 {modules_k => modules}/osp/orig_transaction.h | 0 {modules_k => modules}/osp/osp_mod.c | 0 {modules_k => modules}/osp/osp_mod.h | 0 {modules_k => modules}/osp/osptoolkit.c | 0 {modules_k => modules}/osp/osptoolkit.h | 0 {modules_k => modules}/osp/provider.c | 0 {modules_k => modules}/osp/provider.h | 0 {modules_k => modules}/osp/sipheader.c | 0 {modules_k => modules}/osp/sipheader.h | 0 {modules_k => modules}/osp/term_transaction.c | 0 {modules_k => modules}/osp/term_transaction.h | 0 {modules_k => modules}/osp/tm.c | 0 {modules_k => modules}/osp/tm.h | 0 {modules_k => modules}/osp/usage.c | 0 {modules_k => modules}/osp/usage.h | 0 modules_s/osp/Makefile | 51 -- modules_s/osp/README | 564 --------------- modules_s/osp/RELEASE-NOTES.txt | 62 -- modules_s/osp/destination.c | 473 ------------- modules_s/osp/destination.h | 84 --- modules_s/osp/doc/Makefile | 4 - modules_s/osp/doc/osp.xml | 54 -- modules_s/osp/doc/osp_devel.xml | 20 - modules_s/osp/doc/osp_faq.xml | 50 -- modules_s/osp/doc/osp_user.xml | 369 ---------- modules_s/osp/etc/cacert_0.pem | 10 - modules_s/osp/etc/localcert.pem | 10 - modules_s/osp/etc/pkey.pem | 9 - modules_s/osp/etc/sample-osp-ser.cfg | 463 ------------- modules_s/osp/globals.c | 69 -- modules_s/osp/orig_transaction.c | 545 --------------- modules_s/osp/orig_transaction.h | 49 -- modules_s/osp/osp_mod.c | 307 --------- modules_s/osp/osp_mod.h | 64 -- modules_s/osp/osptoolkit.c | 193 ------ modules_s/osp/osptoolkit.h | 65 -- modules_s/osp/provider.c | 142 ---- modules_s/osp/provider.h | 43 -- modules_s/osp/sipheader.c | 725 -------------------- modules_s/osp/sipheader.h | 60 -- modules_s/osp/term_transaction.c | 203 ------ modules_s/osp/term_transaction.h | 45 -- modules_s/osp/tm.c | 158 ----- modules_s/osp/tm.h | 47 -- modules_s/osp/usage.c | 627 ----------------- modules_s/osp/usage.h | 64 -- 61 files changed, 0 insertions(+), 5629 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=6bd…

15 years, 6 months

build problems: ser's osp module

by Klaus Darilion

Hi! in ser's osp module Makefile these condition should be adopted to search in /usr/lib too: LIBS=$(shell if [ -f /usr/local/lib/libosptk.a ]; then echo "-losptk" ; else echo "-losp" ; fi) Or make it like K's osp module: use always -losptk btw: shouldn't be the module rather identical in ser and K? Maybe someone from the transnexus can handle this? regards klaus

15 years, 6 months

exit vs drop

by Daniel-Constantin Mierla

Hello, in kamailio there is a difference between exit and drop, while in ser is basically the same (exit functionality). For kamailio, in request and failure route they are the same, stop processing of the actions. But in branch route and reply route drop does a bit more: drop current processed branch respectively reply, so they are not forwarded. Addition of this functionality will affect core and tm. Any comments regarding this? i can create the patch for it, if nobody sees issues. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com/

15 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev