sr-dev

sr-dev@lists.kamailio.org

13 participants
44202 discussions

[ openser-Bugs-2817317 ] Kamailio crash completly when receiving empty Record-Route

by SourceForge.net

Bugs item #2817317, was opened at 2009-07-06 08:46 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2817317&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Kamailio crash completly when receiving empty Record-Route Initial Comment: Hello! I found a serious bug: Our Kamailio 1.5.1 crashes, when it receives an empty Record-Route-Field. In my situation a SNOM-M3 with Firmware 2.2 produces this bug. I attached a File where you can see the INVITE which produces the cash. The field "Record-Route" contains only a space. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-06 08:54 Message: I forgot: I am using the following modules: loadmodule "/usr/local/lib/kamailio/modules/pv.so" loadmodule "/usr/local/lib/kamailio/modules/sl.so" loadmodule "/usr/local/lib/kamailio/modules/tm.so" loadmodule "/usr/local/lib/kamailio/modules/rr.so" loadmodule "/usr/local/lib/kamailio/modules/db_mysql.so" loadmodule "/usr/local/lib/kamailio/modules/maxfwd.so" loadmodule "/usr/local/lib/kamailio/modules/usrloc.so" loadmodule "/usr/local/lib/kamailio/modules/registrar.so" loadmodule "/usr/local/lib/kamailio/modules/auth.so" loadmodule "/usr/local/lib/kamailio/modules/auth_db.so" loadmodule "/usr/local/lib/kamailio/modules/siputils.so" loadmodule "/usr/local/lib/kamailio/modules/uri_db.so" loadmodule "/usr/local/lib/kamailio/modules/acc.so" loadmodule "/usr/local/lib/kamailio/modules/textops.so" loadmodule "/usr/local/lib/kamailio/modules/avpops.so" loadmodule "/usr/local/lib/kamailio/modules/xlog.so" loadmodule "/usr/local/lib/kamailio/modules/uac.so" loadmodule "/usr/local/lib/kamailio/modules/alias_db.so" loadmodule "/usr/local/lib/kamailio/modules/dialog.so" loadmodule "/usr/local/lib/kamailio/modules/nathelper.so" If you need more information please post what you need. Thank you! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2817317&group_…

15 years, 6 months

[ openser-Bugs-2817317 ] Kamailio crash completly when receiving empty Record-Route

by SourceForge.net

Bugs item #2817317, was opened at 2009-07-06 08:46 Message generated for change (Tracker Item Submitted) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2817317&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Kamailio crash completly when receiving empty Record-Route Initial Comment: Hello! I found a serious bug: Our Kamailio 1.5.1 crashes, when it receives an empty Record-Route-Field. In my situation a SNOM-M3 with Firmware 2.2 produces this bug. I attached a File where you can see the INVITE which produces the cash. The field "Record-Route" contains only a space. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2817317&group_…

15 years, 6 months

git:master: scripts/mysql: updated 'gw' and 'lcr' table definitions

by Juha Heinanen

Module: sip-router Branch: master Commit: 2d14c2a6cf212743b49ed07e76241ea5d3186c55 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2d14c2a… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sun Jul 5 10:55:48 2009 +0300 scripts/mysql: updated 'gw' and 'lcr' table definitions - Updated 'gw' and 'lcr' MySQL table definitions. - No idea if a schema exists somewhere where sr tables are auto-generated. - The tables are assumed to have versions 10 and 3, respectively although there is no 'version' table in sr database. --- scripts/mysql/my_create.sql | 38 +++++++++++++++++++------------------- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/scripts/mysql/my_create.sql b/scripts/mysql/my_create.sql index 45f38e7..fc27798 100644 --- a/scripts/mysql/my_create.sql +++ b/scripts/mysql/my_create.sql @@ -204,31 +204,31 @@ CREATE TABLE phonebook ( ); CREATE TABLE gw ( + id INT(10) UNSIGNED AUTO_INCREMENT PRIMARY KEY NOT NULL, + lcr_id SMALLINT UNSIGNED NOT NULL DEFAULT 1, gw_name VARCHAR(128) NOT NULL, - ip_addr INT UNSIGNED NOT NULL, + grp_id INT UNSIGNED NOT NULL, + ip_addr VARCHAR(15) NOT NULL, + hostname VARCHAR(64), port SMALLINT UNSIGNED, uri_scheme TINYINT UNSIGNED, - transport SMALLINT UNSIGNED, - prefix VARCHAR(16) NOT NULL, - grp_id INT NOT NULL, - UNIQUE KEY gw_idx1 (gw_name), - KEY gw_idx2 (grp_id) -); - -CREATE TABLE gw_grp ( - grp_id INT AUTO_INCREMENT NOT NULL, - grp_name VARCHAR(64) NOT NULL, - UNIQUE KEY gwgrp_idx (grp_id) + transport TINYINT UNSIGNED, + strip TINYINT UNSIGNED, + tag VARCHAR(16) DEFAULT NULL, + weight INT UNSIGNED, + flags INT UNSIGNED DEFAULT 0 NOT NULL, + defunct INT UNSIGNED DEFAULT NULL, + CONSTRAINT lcr_id_gw_name_idx UNIQUE (lcr_id, gw_name) ); CREATE TABLE lcr ( - prefix VARCHAR(16) NOT NULL, - from_uri VARCHAR(255) NOT NULL DEFAULT '%', - grp_id INT, - priority INT, - KEY lcr_idx1 (prefix), - KEY lcr_idx2 (from_uri), - KEY lcr_idx3 (grp_id) + id INT(10) UNSIGNED AUTO_INCREMENT PRIMARY KEY NOT NULL, + lcr_id SMALLINT UNSIGNED NOT NULL DEFAULT 1, + prefix VARCHAR(16) DEFAULT NULL, + from_uri VARCHAR(64) DEFAULT NULL, + grp_id INT UNSIGNED NOT NULL, + priority TINYINT UNSIGNED NOT NULL, + INDEX lcr_id_idx (lcr_id) ); CREATE TABLE grp (

15 years, 6 months

git:master: modules/lcr: added 'defunct' column to 'gw' table

by Juha Heinanen

Module: sip-router Branch: master Commit: cd18b51a0676abcd0732acb25495b322bb76df40 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd18b51… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sun Jul 5 10:52:47 2009 +0300 modules/lcr: added 'defunct' column to 'gw' table - Added 'defunct' column to 'gw' table that can be used to defunct a gateway until the given time. --- modules/lcr/README | 232 ++++++++++++++++++++++------------------- modules/lcr/doc/lcr_admin.xml | 27 +++++- modules/lcr/lcr_mod.c | 47 ++++++--- 3 files changed, 181 insertions(+), 125 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=cd1…

15 years, 6 months

xmlrpc module requires s sl module

by jh＠tutpro.com

i tried to play with s xmlrpc module, but got this erroe message on startup: Jul 4 15:33:33 localhost /usr/sbin/sip-router[8664]: ERROR: xmlrpc [xmlrpc.c:1989]: This module requires sl module i do have k sl module loaded, because i use function send_reply that does not exist in s version of the module. also, i use stats provided dby k sl module. is it possible to change xmlrpc module so that it accepts either s or k version of sl module? -- juha

15 years, 6 months

git:master: * modules_s/xmlrpc: allow use of k ls module api

by Juha Heinanen

Module: sip-router Branch: master Commit: f90164d0f430ab891f29e82125a56eddc3cf319a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f90164d… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sat Jul 4 22:36:41 2009 +0300 * modules_s/xmlrpc: allow use of k ls module api - Added Makefile #define for choosing between s and k sl API. --- modules_s/xmlrpc/Makefile | 8 +++++++- modules_s/xmlrpc/xmlrpc.c | 29 +++++++++++++++++++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/modules_s/xmlrpc/Makefile b/modules_s/xmlrpc/Makefile index f0d76c2..93651a6 100644 --- a/modules_s/xmlrpc/Makefile +++ b/modules_s/xmlrpc/Makefile @@ -3,6 +3,9 @@ # # WARNING: do not run this directly, it should be run by the master Makefile +# Set to true if you want to use K sl module API +USE_K_SL_API=false + include ../../Makefile.defs auto_gen= NAME=xmlrpc.so @@ -11,5 +14,8 @@ LIBS +=-lxml2 DEFS+=-DSER_MOD_INTERFACE -include ../../Makefile.modules +ifeq ($(USE_K_SL_API),true) +DEFS+=-DUSE_K_SL_API +endif +include ../../Makefile.modules diff --git a/modules_s/xmlrpc/xmlrpc.c b/modules_s/xmlrpc/xmlrpc.c index f97bf89..6b90298 100644 --- a/modules_s/xmlrpc/xmlrpc.c +++ b/modules_s/xmlrpc/xmlrpc.c @@ -55,7 +55,11 @@ #include "../../msg_translator.h" #include "../../select.h" #include "../../receive.h" /* needed by process_rpc / receive_msg() */ +#ifdef USE_K_SL_API +#include "../../modules_k/sl/sl_api.h" +#else #include "../sl/sl.h" +#endif #include "../../nonsip_hooks.h" #include "../../action.h" /* run_actions */ #include "../../script_cb.h" /* exec_*_script_cb */ @@ -378,7 +382,11 @@ static char* xmlrpc_route=0; /* default is the main route */ /** Reference to the sl (stateless replies) module of SER The sl module of SER * is needed so that the xmlrpc SER module can send replies back to clients */ +#ifdef USE_K_SL_API +struct sl_binds sl; +#else sl_api_t sl; +#endif static int xmlrpc_route_no=DEFAULT_RT; @@ -725,10 +733,20 @@ static int send_reply(sip_msg_t* msg, str* body) return -1; } +#ifdef USE_K_SL_API + str s; + s.s = "OK"; + s.len = 2; + if (sl.send_reply(msg, 200, &s) == -1) { + ERR("Error while sending reply\n"); + return -1; + } +#else if (sl.reply(msg, 200, "OK") == -1) { ERR("Error while sending reply\n"); return -1; } +#endif return 0; } @@ -1961,7 +1979,6 @@ select_row_t xmlrpc_sel[] = { static int mod_init(void) { - bind_sl_t bind_sl; struct nonsip_hook nsh; int route_no; @@ -1984,12 +2001,20 @@ static int mod_init(void) * We will need sl_send_reply from stateless * module for sending replies */ - bind_sl = (bind_sl_t)find_export("bind_sl", 0, 0); +#ifdef USE_K_SL_API + if (load_sl_api(&sl)!=0) { + ERR("This module requires sl module\n"); + return -1; + } +#else + bind_sl_t bind_sl; + bind_sl = (bind_sl_t)find_export("bind_sl", 0, 0); if (!bind_sl) { ERR("This module requires sl module\n"); return -1; } if (bind_sl(&sl) < 0) return -1; +#endif func_param.send = (rpc_send_f)rpc_send; func_param.fault = (rpc_fault_f)rpc_fault;

15 years, 6 months

git:master: tm: fix cloning parsed uri for to/from headers

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: d9d008e34130f2e85e3df78580e589f98f8c447a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d9d008e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jul 4 21:10:36 2009 +0200 tm: fix cloning parsed uri for to/from headers - parsed structure was not cloned - several fields in struct uri were not cloned --- modules/tm/sip_msg.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/modules/tm/sip_msg.c b/modules/tm/sip_msg.c index 6b31eb0..65c2ac8 100644 --- a/modules/tm/sip_msg.c +++ b/modules/tm/sip_msg.c @@ -288,6 +288,24 @@ static void uri_trans(char *new_buf, char *org_buf, struct sip_uri *uri) uri->port.s=translate_pointer(new_buf,org_buf,uri->port.s); uri->params.s=translate_pointer(new_buf,org_buf,uri->params.s); uri->headers.s=translate_pointer(new_buf,org_buf,uri->headers.s); + /* parameters */ + uri->transport.s=translate_pointer(new_buf,org_buf,uri->transport.s); + uri->ttl.s=translate_pointer(new_buf,org_buf,uri->ttl.s); + uri->user_param.s=translate_pointer(new_buf,org_buf,uri->user_param.s); + uri->maddr.s=translate_pointer(new_buf,org_buf,uri->maddr.s); + uri->method.s=translate_pointer(new_buf,org_buf,uri->method.s); + uri->lr.s=translate_pointer(new_buf,org_buf,uri->lr.s); + uri->r2.s=translate_pointer(new_buf,org_buf,uri->r2.s); + /* values */ + uri->transport_val.s + =translate_pointer(new_buf,org_buf,uri->transport_val.s); + uri->ttl_val.s=translate_pointer(new_buf,org_buf,uri->ttl_val.s); + uri->user_param_val.s + =translate_pointer(new_buf,org_buf,uri->user_param_val.s); + uri->maddr_val.s=translate_pointer(new_buf,org_buf,uri->maddr_val.s); + uri->method_val.s=translate_pointer(new_buf,org_buf,uri->method_val.s); + uri->lr_val.s=translate_pointer(new_buf,org_buf,uri->lr_val.s); + uri->r2_val.s=translate_pointer(new_buf,org_buf,uri->r2_val.s); } @@ -685,6 +703,10 @@ struct sip_msg* sip_msg_cloner( struct sip_msg *org_msg, int *sip_msg_len ) ((struct to_body*)new_hdr->parsed)->tag_value.s = translate_pointer( new_msg->buf , org_msg->buf , ((struct to_body*)hdr->parsed)->tag_value.s ); + if ( (((struct to_body*)new_hdr->parsed)->parsed_uri.user.s) + || (((struct to_body*)new_hdr->parsed)->parsed_uri.host.s) ) + uri_trans(new_msg->buf, org_msg->buf, + &((struct to_body*)new_hdr->parsed)->parsed_uri); /*to params*/ to_prm = ((struct to_body*)(hdr->parsed))->param_lst; for(;to_prm;to_prm=to_prm->next) {

15 years, 6 months

lookup_domain does not accept pvar $var as argument

by jh＠tutpro.com

at one point in my script i need to make this kind of domain_lookup: xlog("L_INFO", "looking for domain $var(from_uri_domain)\n"); lookup_domain("$fd", "$var(from_uri_domain)"); looks like second argument is not understood. because i get into syslog Jul 4 20:29:41 localhost /usr/sbin/sip-router[26491]: INFO: looking for domain test.fi Jul 4 20:29:41 localhost /usr/sbin/sip-router[26491]: ERROR: domain [domain_mod.c:531]: Cannot get domain name to lookup the latter line comes, when i changed in lookup_domain this DBG to ERR: if (get_str_fparam(&domain, msg, (fparam_t*)fp) != 0) { ERR("Cannot get domain name to lookup\n"); return -1; } i cannot replace $var(from_uri_domain) with a select. so is this it? should i go back to the original plan and add attribute support to k's domain module? -- juha

15 years, 6 months

git:master: modules_s/xmlrpc: fixed typo in name of module parameter

by Juha Heinanen

Module: sip-router Branch: master Commit: f717262c67a45419d457989cf408fd81264ba900 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f717262… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sat Jul 4 15:17:58 2009 +0300 modules_s/xmlrpc: fixed typo in name of module parameter - enable_instrospection => enable_introspection. --- modules_s/xmlrpc/xmlrpc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_s/xmlrpc/xmlrpc.c b/modules_s/xmlrpc/xmlrpc.c index 4ca7ab2..f97bf89 100644 --- a/modules_s/xmlrpc/xmlrpc.c +++ b/modules_s/xmlrpc/xmlrpc.c @@ -397,7 +397,7 @@ static cmd_export_t cmds[] = { * Exported parameters */ static param_export_t params[] = { - {"enable_instrospection", PARAM_INT, &enable_introspection}, + {"enable_introspection", PARAM_INT, &enable_introspection}, {"route", PARAM_STRING, &xmlrpc_route}, {0, 0, 0} };

15 years, 6 months

wrong warning message during config check

by jh＠tutpro.com

line if (is_local("@ruri.host")) { in branch_route block that caused "Command cannot be used in the block" parse error, also caused warning: 0(4462) WARNING: tm [tm.c:503]: WARNING: on_sl_reply("stateless_reply"): empty/non existing route when i changed the above line to if (1) { both the parse error and the warning disappeared. looks like syntax checking got somehow confused and produced warning on something that was ok. -- juha

15 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev