sr-dev

sr-dev@lists.kamailio.org

13 participants
44202 discussions

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Comment added) made by ibc_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- >Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-10 14:37 Message: Imagine that the UAC uses "Require: 100rel" instead of "Supported". The header cannot be removed or the call won't take place. A proxy shouldn't play to be god :) ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 13:56 Message: > and PRACK/200 ok in the dialog. But I think, the best solution, set and PRACK/200 are not ok in the dialog. But I think, the best solution, set ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 13:55 Message: Hi miconda, much better remove_hf("Supported:") from INVITE request; :-) and PRACK/200 ok in the dialog. But I think, the best solution, set loc_seq +100. P.S. don't forget about UPDATE method. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-10 13:48 Message: quick fix: reply pracks on server, with sl_send_reply() as they just get into config?!?! ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-10 12:59 Message: This is a good example of why a proxy shouldn't try to behave as a B2BUA XD ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 10:50 Message: oops: Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3 PRACK) - <---- 200 OK ( Cseq: 1 INVITE) - ---------- timeout dialog ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Comment added) made by baron76 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- >Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 13:56 Message: > and PRACK/200 ok in the dialog. But I think, the best solution, set and PRACK/200 are not ok in the dialog. But I think, the best solution, set ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 13:55 Message: Hi miconda, much better remove_hf("Supported:") from INVITE request; :-) and PRACK/200 ok in the dialog. But I think, the best solution, set loc_seq +100. P.S. don't forget about UPDATE method. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-10 13:48 Message: quick fix: reply pracks on server, with sl_send_reply() as they just get into config?!?! ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-10 12:59 Message: This is a good example of why a proxy shouldn't try to behave as a B2BUA XD ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 10:50 Message: oops: Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3 PRACK) - <---- 200 OK ( Cseq: 1 INVITE) - ---------- timeout dialog ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Comment added) made by baron76 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- >Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 13:55 Message: Hi miconda, much better remove_hf("Supported:") from INVITE request; :-) and PRACK/200 ok in the dialog. But I think, the best solution, set loc_seq +100. P.S. don't forget about UPDATE method. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-10 13:48 Message: quick fix: reply pracks on server, with sl_send_reply() as they just get into config?!?! ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-10 12:59 Message: This is a good example of why a proxy shouldn't try to behave as a B2BUA XD ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 10:50 Message: oops: Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3 PRACK) - <---- 200 OK ( Cseq: 1 INVITE) - ---------- timeout dialog ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 11:47 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-07-10 14:48 Message: quick fix: reply pracks on server, with sl_send_reply() as they just get into config?!?! ---------------------------------------------------------------------- Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2009-07-10 13:59 Message: This is a good example of why a proxy shouldn't try to behave as a B2BUA XD ---------------------------------------------------------------------- Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 11:50 Message: oops: Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3 PRACK) - <---- 200 OK ( Cseq: 1 INVITE) - ---------- timeout dialog ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Tracker Item Submitted) made by baron76 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

git:master: siptrace: module facelift

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 94393b2da7e7922458653d8fa7f413a673383de1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=94393b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:18:42 2009 +0200 siptrace: module facelift - better structured traced data - more modularity to avoid duplicity --- modules_k/siptrace/siptrace.c | 1079 +++++++++++++++-------------------------- 1 files changed, 403 insertions(+), 676 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=943…

15 years, 6 months

git:master: siptrace: removed trailing whitespaces

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cd0ce113e857289f2b0e964a43abfa57ac3be707 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd0ce11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:23:58 2009 +0200 siptrace: removed trailing whitespaces - makes git happy, avoiding warning messages --- modules_k/siptrace/siptrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/siptrace/siptrace.c b/modules_k/siptrace/siptrace.c index cfd5245..a9044b8 100644 --- a/modules_k/siptrace/siptrace.c +++ b/modules_k/siptrace/siptrace.c @@ -1097,8 +1097,8 @@ static struct mi_root* sip_trace_mi(struct mi_root* cmd_tree, void* param ) *trace_on_flag = 1; return init_mi_tree( 200, MI_SSTR(MI_OK)); } else if ( node->value.len==3 && (node->value.s[0]=='o' - || node->value.s[0]=='O') - && (node->value.s[1]=='f'|| node->value.s[1]=='F') + || node->value.s[0]=='O') + && (node->value.s[1]=='f'|| node->value.s[1]=='F') && (node->value.s[2]=='f'|| node->value.s[2]=='F')) { *trace_on_flag = 0; return init_mi_tree( 200, MI_SSTR(MI_OK));

15 years, 6 months

git:master: tm: enabbled TMCB_ONSEND

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: bce53e2a14c07203e5914fdb41ca887765a28799 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bce53e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:17:54 2009 +0200 tm: enabbled TMCB_ONSEND - used by siptrace module --- modules/tm/t_hooks.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/modules/tm/t_hooks.h b/modules/tm/t_hooks.h index 998ace1..d593a67 100644 --- a/modules/tm/t_hooks.h +++ b/modules/tm/t_hooks.h @@ -48,9 +48,7 @@ /* if defined support for ONSEND callbacks will be added and * the tmcb_params structure will get some additional members */ -/* #define TMCB_ONSEND -*/ #ifdef TMCB_ONSEND #include "../../ip_addr.h" /* dest_info */ #endif

15 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev