Juha,
There is the parameter restart_fr_on_each_reply, its documentation says:
Setting it to 0 is especially useful when dealing with bad UAs that
continuously retransmit 180s, not allowing the transaction to timeout
(and thus making impossible the implementation of certain services,
like automatic voicemail after x seconds).
The parameter is enabled by default. Shouldn't we disable this when we
do serial forking with t_next_contacts. To guarantee that UAs
retransmitting 180s do not prevent serial forking from happening?
-- Jan
Juha,
Function t_loads contacts in tm/t_serial.c encodes the Request-URI and
all branches of the SIP message into an AVP. At the end the function
calls clear_branches to remove all branches from the SIP request, so
that a subsequent call to t_next_contacts can only restore those with
highest q number.
I am wondering if calling clear_branches is enough. Shouldn't the
function also call reset_dst_uri to reset the value of the dst_uri
(which is now also stored in the AVP), and perhaps also clear the send
socket, the branch flags and the path vector for the Request-URI?
All these values are encoded into the AVP, but they are only cleared
for additional branches (in clear_branches), but not for the
Request-URI "branch".
I also considered doing that in clear_branches, but then I realized
that this function is called from other places and modules and it
could break them.
Any thoughts on this? How thorough should t_load_contacts be when it
resets variables whose values are stored in the AVP?
-- Jan
Juha,
I wrote a very simple sip-router script to test serial forking based
on q values with t_load_contacts and t_next_contacts. I noticed that
when I use t_next_contacts before the transaction exists, it uses the
value of fr_inv_timer_next even for the first branch.
Is this itendended behavior? Shouldn't the function use the value of
fr_inv_timer for the first branch and then fr_inv_timer_next for
subsequent branches?
This is where fr_inv_timer_next is set for the first branch:
http://git.sip-router.org/cgi-bin/gitweb.cgi?p=kamailio;a=blob;f=modules/tm…
-- Jan
i didn't get any answer to my question about this commit.
it looks to me that there is now two versions of sip-router core. i
thought that the agreement was that there is only one core and that all
commits to core are done to sr_3.0 branch.
can someone explain to me what is going on? am i missing something?
why this commit could not use done to sr_3.0 perhaps #ifdef kamailio or
something like that so that there would be only one core?
-- juha
Hi, sorry for this off-topic.
I'm starting with Git (yeah!) and creating a repository in my server to manage
various projects.
I'm learning about Git and access control (users, permissions, authorization
per repository and so).
How is this stuff implemented in SR Git repository? does it use Gitosis? If
not, how is managed the permissions?
Thanks for any tip.
--
Iñaki Baz Castillo <ibc(a)aliax.net>
Module: sip-router
Branch: master
Commit: b90ac7da0de80d2ce997fc9586976b80e9aee788
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b90ac7d…
Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Date: Thu Oct 15 20:06:29 2009 +0200
mi_rpc: Revert Changing mi_rpc licence
Revert commit cbfe9a14fdb05e8212ba4a0b24472f5239850a77
(changing mi_rpc_mod.c licence), at Daniel's request.
---
modules/mi_rpc/mi_rpc_mod.c | 36 ++++++++++--------------------------
1 files changed, 10 insertions(+), 26 deletions(-)
diff --git a/modules/mi_rpc/mi_rpc_mod.c b/modules/mi_rpc/mi_rpc_mod.c
index de9db37..b678f25 100644
--- a/modules/mi_rpc/mi_rpc_mod.c
+++ b/modules/mi_rpc/mi_rpc_mod.c
@@ -5,35 +5,19 @@
*
* Copyright (C) 2009 Daniel-Constantin Mierla (asipto.com).
*
- * This file is part of SIP-router, a free SIP server.
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
*
- * SIP-router is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- * SIP-router is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
-
- */
-
-/*!
- * \file
- * \brief Management interface :: RPC support
- * \ingroup mi_rpc
- */
-
-/*!
- * \defgroup mi_rpc Management interface :: RPC support
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
-
#include <stdlib.h>
#include <string.h>
#include <unistd.h>