sr-dev

sr-dev@lists.kamailio.org

15 participants
44239 discussions

git:kamailio_3.0: print the cfg file in fixup error message

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: 33bfc5aeeaa55c93842635bb41da30745673854b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=33bfc5a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 15 14:32:40 2009 +0100 print the cfg file in fixup error message - line is not enough when include_file is used --- route.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/route.c b/route.c index 8887c8a..1aeb529 100644 --- a/route.c +++ b/route.c @@ -1022,7 +1022,8 @@ int fix_actions(struct action* a) return 0; error: - LM_ERR("fixing failed (code=%d) at cfg line %d\n", ret, t->cline); + LM_ERR("fixing failed (code=%d) at cfg:%s:%d\n", ret, + (t->cfile)?t->cfile:"", t->cline); return ret; }

15 years, 2 months

git:kamailio_3.0: uac(k): use type to detect www/proxy_authenticate hdrs

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: c92e49f3eb145c3767e996d21717d20613a899d5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c92e49f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 15 12:52:36 2009 +0100 uac(k): use type to detect www/proxy_authenticate hdrs - reported by Mangust (mangust2), SF.net #2897594 --- modules_k/uac/auth.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules_k/uac/auth.c b/modules_k/uac/auth.c index ba0e3fc..78f51d5 100644 --- a/modules_k/uac/auth.c +++ b/modules_k/uac/auth.c @@ -232,9 +232,9 @@ static inline struct hdr_field *get_autenticate_hdr(struct sip_msg *rpl, } for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { - if ( hdr->type!=HDR_OTHER_T ) - continue; - if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) + if((rpl_code==WWW_AUTH_CODE && hdr->type==HDR_WWW_AUTHENTICATE_T) + || (rpl_code==PROXY_AUTH_CODE + && hdr->type==HDR_PROXY_AUTHENTICATE_T)) return hdr; }

15 years, 2 months

git:kamailio_3.0: print line for fixing action error

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: 208e5c3d910885efc83acab4f06b66b27685332c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=208e5c3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 15 12:51:27 2009 +0100 print line for fixing action error - reported by Juha Heinanen --- route.c | 109 ++++++++++++++++++++++++++++++++++++++++---------------------- 1 files changed, 70 insertions(+), 39 deletions(-) diff --git a/route.c b/route.c index 8d6f2c6..8887c8a 100644 --- a/route.c +++ b/route.c @@ -657,7 +657,8 @@ int fix_actions(struct action* a) if (tmp==0){ LOG(L_CRIT, "ERROR: fix_actions:" "memory allocation failure\n"); - return E_OUT_OF_MEM; + ret = E_OUT_OF_MEM; + goto error; } t->val[0].type=STRING_ST; t->val[0].u.string=tmp; @@ -666,7 +667,7 @@ int fix_actions(struct action* a) s.s = t->val[0].u.string; s.len = strlen(s.s); p=add_proxy(&s, t->val[1].u.number, 0); /* FIXME proto*/ - if (p==0) return E_BAD_ADDRESS; + if (p==0) { ret =E_BAD_ADDRESS; goto error; } t->val[0].u.data=p; t->val[0].type=PROXY_ST; break; @@ -676,7 +677,8 @@ int fix_actions(struct action* a) LOG(L_CRIT, "BUG: fix_actions: invalid type" "%d (should be string or number)\n", t->type); - return E_BUG; + ret = E_BUG; + goto error; } break; case IF_T: @@ -684,19 +686,22 @@ int fix_actions(struct action* a) LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for if (should be rval expr)\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; }else if( (t->val[1].type!=ACTIONS_ST) && (t->val[1].type!=NOSUBTYPE) ){ LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for if() {...} (should be action)\n", t->val[1].type); - return E_BUG; + ret = E_BUG; + goto error; }else if( (t->val[2].type!=ACTIONS_ST) && (t->val[2].type!=NOSUBTYPE) ){ LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for if() {} else{...}(should be action)\n", t->val[2].type); - return E_BUG; + ret = E_BUG; + goto error; } rve=(struct rval_expr*)t->val[0].u.data; if (rve){ @@ -715,7 +720,8 @@ int fix_actions(struct action* a) LOG(L_ERR, "fix_actions: invalid expression " "(%d,%d): type mismatch?", rve->fpos.s_line, rve->fpos.s_col); - return E_UNSPEC; + ret = E_UNSPEC; + goto error; } /* it's not an error anymore to have non-int in an if, only a script warning (to allow backward compat. stuff @@ -728,16 +734,16 @@ int fix_actions(struct action* a) } */ if ((ret=fix_rval_expr((void**)&rve))<0) - return ret; + goto error; } if ( (t->val[1].type==ACTIONS_ST)&&(t->val[1].u.data) ){ if ((ret=fix_actions((struct action*)t->val[1].u.data))<0) - return ret; + goto error; } if ( (t->val[2].type==ACTIONS_ST)&&(t->val[2].u.data) ){ if ((ret=fix_actions((struct action*)t->val[2].u.data)) <0) - return ret; + goto error; } break; case SWITCH_T: @@ -745,35 +751,40 @@ int fix_actions(struct action* a) LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for switch() (should be expr)\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; }else if (t->val[1].type!=CASE_ST){ LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for switch(...){...}(should be case)\n", t->val[1].type); - return E_BUG; + ret = E_BUG; + goto error; } if (t->val[0].u.data){ if ((ret=fix_rval_expr(&t->val[0].u.data))<0) - return ret; + goto error; }else{ LOG(L_CRIT, "BUG: fix_actions: null switch()" " expression\n"); - return E_BUG; + ret = E_BUG; + goto error; } if ((ret=fix_switch(t))<0) - return ret; + goto error; break; case WHILE_T: if (t->val[0].type!=RVE_ST){ LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for while() (should be expr)\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; }else if (t->val[1].type!=ACTIONS_ST){ LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for while(...){...}(should be action)\n", t->val[1].type); - return E_BUG; + ret = E_BUG; + goto error; } rve=(struct rval_expr*)t->val[0].u.data; if (rve){ @@ -792,24 +803,27 @@ int fix_actions(struct action* a) LOG(L_ERR, "fix_actions: invalid expression " "(%d,%d): type mismatch?", rve->fpos.s_line, rve->fpos.s_col); - return E_UNSPEC; + ret = E_UNSPEC; + goto error; } if (rve_type!=RV_INT && rve_type!=RV_NONE){ LOG(L_ERR, "fix_actions: invalid expression (%d,%d):" " bad type, integer expected\n", rve->fpos.s_line, rve->fpos.s_col); - return E_UNSPEC; + ret = E_UNSPEC; + goto error; } if ((ret=fix_rval_expr((void**)&rve))<0) - return ret; + goto error; }else{ LOG(L_CRIT, "BUG: fix_actions: null while()" " expression\n"); - return E_BUG; + ret = E_BUG; + goto error; } if ( t->val[1].u.data && ((ret= fix_actions((struct action*)t->val[1].u.data))<0)){ - return ret; + goto error; } break; case DROP_T: @@ -833,20 +847,23 @@ int fix_actions(struct action* a) LOG(L_ERR, "fix_actions: invalid expression " "(%d,%d): type mismatch?", rve->fpos.s_line, rve->fpos.s_col); - return E_UNSPEC; + ret = E_UNSPEC; + goto error; } if (rve_type!=RV_INT && rve_type!=RV_NONE){ LOG(L_ERR, "fix_actions: invalid expression (%d,%d):" " bad type, integer expected\n", rve->fpos.s_line, rve->fpos.s_col); - return E_UNSPEC; + ret = E_UNSPEC; + goto error; } if ((ret=fix_rval_expr((void**)&rve))<0) - return ret; + goto error; }else{ LOG(L_CRIT, "BUG: fix_actions: null drop/return" " expression\n"); - return E_BUG; + ret = E_BUG; + goto error; } break; case ASSIGN_T: @@ -854,12 +871,14 @@ int fix_actions(struct action* a) if (t->val[0].type !=LVAL_ST) { LOG(L_CRIT, "BUG: fix_actions: Invalid left side of" " assignment\n"); - return E_BUG; + ret = E_BUG; + goto error; } if (t->val[1].type !=RVE_ST) { LOG(L_CRIT, "BUG: fix_actions: Invalid right side of" " assignment (%d)\n", t->val[1].type); - return E_BUG; + ret = E_BUG; + goto error; } lval=t->val[0].u.data; if (lval->type==LV_AVP){ @@ -867,16 +886,18 @@ int fix_actions(struct action* a) LOG(L_ERR, "ERROR: You cannot change domain" " attributes from the script, they are" " read-only\n"); - return E_BUG; + ret = E_BUG; + goto error; } else if (lval->lv.avps.type & AVP_CLASS_GLOBAL) { LOG(L_ERR, "ERROR: You cannot change global" " attributes from the script, they are" "read-only\n"); - return E_BUG; + ret = E_BUG; + goto error; } } if ((ret=fix_rval_expr(&t->val[1].u.data))<0) - return ret; + goto error; break; case MODULE_T: @@ -891,7 +912,7 @@ int fix_actions(struct action* a) if (t->val[1].u.number==0) { ret = cmd->c.fixup(0, 0); if (ret < 0) - return ret; + goto error; } /* type cast NUMBER to STRING, old modules may expect * all STRING params during fixup */ @@ -904,7 +925,8 @@ int fix_actions(struct action* a) if (!t->val[i+2].u.string) { LOG(L_CRIT, "ERROR: cannot translate NUMBER" " to STRING\n"); - return E_OUT_OF_MEM; + ret = E_OUT_OF_MEM; + goto error; } strcpy(t->val[i+2].u.string, buf); t->val[i+2].type = STRING_ST; @@ -917,7 +939,7 @@ int fix_actions(struct action* a) if (t->val[i+2].u.data != p) t->val[i+2].type = MODFIXUP_ST; if (ret < 0) - return ret; + goto error; } } break; @@ -926,7 +948,8 @@ int fix_actions(struct action* a) LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for force_send_socket\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; } he=resolvehost( ((struct socket_id*)t->val[0].u.data)->addr_lst->name @@ -935,7 +958,8 @@ int fix_actions(struct action* a) LOG(L_ERR, "ERROR: fix_actions: force_send_socket:" " could not resolve %s\n", ((struct socket_id*)t->val[0].u.data)->addr_lst->name); - return E_BAD_ADDRESS; + ret = E_BAD_ADDRESS; + goto error; } hostent2ip_addr(&ip, he, 0); si=find_si(&ip, ((struct socket_id*)t->val[0].u.data)->port, @@ -945,7 +969,8 @@ int fix_actions(struct action* a) " argument: %s:%d (ser doesn't listen on it)\n", ((struct socket_id*)t->val[0].u.data)->addr_lst->name, ((struct socket_id*)t->val[0].u.data)->port); - return E_BAD_ADDRESS; + ret = E_BAD_ADDRESS; + goto error; } t->val[0].u.data=si; t->val[0].type=SOCKETINFO_ST; @@ -955,7 +980,8 @@ int fix_actions(struct action* a) LOG(L_CRIT, "BUG: fix_actions: invalid subtype" "%d for udp_mtu_try_proto\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; } switch(t->val[0].u.number){ case PROTO_UDP: @@ -980,7 +1006,8 @@ int fix_actions(struct action* a) if (t->val[0].type!=STRING_ST){ BUG("invalid subtype%d for append_branch_t\n", t->val[0].type); - return E_BUG; + ret = E_BUG; + goto error; } s.s=t->val[0].u.string; s.len=(s.s)?strlen(s.s):0; @@ -993,6 +1020,10 @@ int fix_actions(struct action* a) } } return 0; + +error: + LM_ERR("fixing failed (code=%d) at cfg line %d\n", ret, t->cline); + return ret; }

15 years, 2 months

why new tcp connection?

by jh＠tutpro.com

i started to test the latest sr_3.0 that includes andrei's tcp/socket related changes. twinkle is registered over tcp to sr using source port 59056 destination port 5060. in contact uri twinkle has put port 5074 (i need to configure some fixed port there). when another ua calls twinkle and i see this in syslog: Nov 6 07:16:21 localhost /usr/sbin/sip-proxy[30133]: INFO: Routing first INVITE to <sip:jh_test_fi@192.98.101.10:5074;transport=tcp> and <<null>> Nov 6 07:16:21 localhost /usr/sbin/sip-proxy[30133]: INFO: <core> [tcp_main.c:1928]: tcp_send: quick connect for 0xb54f3e60 when i look wireshark output, i see that sr has created a new tcp connection to twinkle at port 5074 even when there is already is one, but not to that port. is this twinkle's fault, i.e., should it put in contact uri port 59056 instead? or should sr figure out that twinkle in fact is behind the tcp connection it created when it registered itself no matter what the port in contact uri is? -- juha

15 years, 2 months

[ openser-Bugs-2897594 ] uac_auth does't work in 3.0

by SourceForge.net

Bugs item #2897594, was opened at 2009-11-14 09:14 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mangust (mangust2) Assigned to: Nobody/Anonymous (nobody) Summary: uac_auth does't work in 3.0 Initial Comment: in file modules_k/uac/auth.c line 235: for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { // -->> if ( hdr->type!=HDR_OTHER_T) // -->> continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; } commented out line prevent from recognizing authentication field causing error. Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:244]: reply has no auth hdr (WWW-Authenticate) Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:419]: failed to extract authenticate hdr maybe because authentication now not HDR_OTHER_T but HDR_WWW_AUTHENTICATE_T /* WWW-Authenticate header field */, HDR_PROXY_AUTHENTICATE_T /* Proxy-Authenticate header field */, according to: http://www.asipto.com/pub/kamailio-devel-guide/ for a moment i just comment it out will also try: if ( hdr->type!=HDR_WWW_AUTHENTICATE_T && hdr->type!=HDR_PROXY_AUTHENTICATE_T ) continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-11-15 06:18 Message: Your patch seems ok, I will double check and fix. Thanks! ---------------------------------------------------------------------- Comment By: Mangust (mangust2) Date: 2009-11-14 09:26 Message: A! it happen because before in v1.5 ./parser/hf.h /** * SIP Header types. * if you add a new type: * - make sure it's not greater than 63 * - make sure you add the corresponding flag to the hdr_flags_t defs below * - update clean_hdr_field (in hf.c) * - update sip_msg_cloner (modules/tm/sip_msg.c) * - update parse_headers (msg_parser.c) */ enum _hdr_types_t { HDR_ERROR_T = -1 /**< Error while parsing */, HDR_OTHER_T = 0 /**< Some other header field */, HDR_VIA_T = 1 /**< Via header field */, HDR_VIA1_T = 1 /**< First Via header field */, HDR_VIA2_T = 2 /**< only used as flag */, HDR_TO_T /**< To header field */, HDR_FROM_T /**< From header field */, HDR_CSEQ_T /**< CSeq header field */, HDR_CALLID_T /**< Call-Id header field */, HDR_CONTACT_T /**< Contact header field */, HDR_MAXFORWARDS_T /**< MaxForwards header field */, HDR_ROUTE_T /**< Route header field */, HDR_RECORDROUTE_T /**< Record-Route header field */, HDR_PATH_T /**< Path header fiels */, HDR_CONTENTTYPE_T /**< Content-Type header field */, HDR_CONTENTLENGTH_T /**< Content-Length header field */, HDR_AUTHORIZATION_T /**< Authorization header field */, HDR_EXPIRES_T /**< Expires header field */, HDR_PROXYAUTH_T /**< Proxy-Authorization hdr field */, HDR_SUPPORTED_T /**< Supported header field */, HDR_PROXYREQUIRE_T /**< Proxy-Require header field */, HDR_UNSUPPORTED_T /**< Unsupported header field */, HDR_ALLOW_T /**< Allow header field */, HDR_EVENT_T /**< Event header field */, HDR_ACCEPT_T /**< Accept header field */, HDR_ACCEPTLANGUAGE_T /**< Accept-Language header field */, HDR_ORGANIZATION_T /**< Organization header field */, HDR_PRIORITY_T /**< Priority header field */, HDR_SUBJECT_T /**< Subject header field */, HDR_USERAGENT_T /**< User-Agent header field */, HDR_ACCEPTDISPOSITION_T /**< Accept-Disposition hdr field */, HDR_CONTENTDISPOSITION_T /**< Content-Disposition hdr field */, HDR_DIVERSION_T /**< Diversion header field */, HDR_RPID_T /**< Remote-Party-ID header field */, HDR_REFER_TO_T /**< Refer-To header fiels */, HDR_SESSION_EXPIRES_T /**< Session-Expires header field */, HDR_MIN_SE_T /**< Min-SE header field */, HDR_PPI_T /**< P-Preferred-Identity header field */, HDR_PAI_T /**< P-Asserted-Identity header field */, HDR_PRIVACY_T /**< Privacy header field */, HDR_RETRY_AFTER_T /**< Retry-After header field */, HDR_EOH_T /**< Some other header field */ }; Was NO HDR_WWW_AUTHENTICATE_T or HDR_PROXY_AUTHENTICATE_T so authenticate header was matching HDR_OTHER_T ---------------------------------------------------------------------- Comment By: Mangust (mangust2) Date: 2009-11-14 09:20 Message: yes, this work as well: for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { if ( hdr->type!=HDR_WWW_AUTHENTICATE_T && hdr->type!=HDR_PROXY_AUTHENTICATE_T ) continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_…

15 years, 2 months

[ openser-Bugs-2897872 ] default config for 3.0 BUG

by SourceForge.net

Bugs item #2897872, was opened at 2009-11-15 05:21 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897872&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: packaging Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Mangust (mangust2) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: default config for 3.0 BUG Initial Comment: Hi, In default config. just after a loode_route check, call to route(1). there is no such route. Correct is route(RELAY). Because it renamed in new config. Was struggling 40 minutes. Fix it please ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-11-15 06:17 Message: Should be fixed now on GIT. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897872&group_…

15 years, 2 months

git:kamailio_3.0: route(1) changed to route(RELAY)

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: 99d434e5c2ff2771a5e6c486630e859d5bcc6c5f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=99d434e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 15 05:12:51 2009 +0100 route(1) changed to route(RELAY) - reported by Mangust (mangust2), SF.net #2897872 --- etc/kamailio.cfg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index dc73c20..77727d1 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -278,7 +278,7 @@ route{ setflag(1); # do accounting ... setflag(3); # ... even if the transaction fails } - route(1); + route(RELAY); } else { if (is_method("SUBSCRIBE") && uri == myself) { # in-dialog subscribe requests

15 years, 2 months

[ openser-Bugs-2897872 ] default config for 3.0 BUG

by SourceForge.net

Bugs item #2897872, was opened at 2009-11-15 06:21 Message generated for change (Tracker Item Submitted) made by mangust2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897872&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: packaging Group: ver devel Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mangust (mangust2) Assigned to: Nobody/Anonymous (nobody) Summary: default config for 3.0 BUG Initial Comment: Hi, In default config. just after a loode_route check, call to route(1). there is no such route. Correct is route(RELAY). Because it renamed in new config. Was struggling 40 minutes. Fix it please ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897872&group_…

15 years, 2 months

[ openser-Bugs-2897594 ] uac_auth does't work in 3.0

by SourceForge.net

Bugs item #2897594, was opened at 2009-11-14 10:14 Message generated for change (Comment added) made by mangust2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mangust (mangust2) Assigned to: Nobody/Anonymous (nobody) Summary: uac_auth does't work in 3.0 Initial Comment: in file modules_k/uac/auth.c line 235: for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { // -->> if ( hdr->type!=HDR_OTHER_T) // -->> continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; } commented out line prevent from recognizing authentication field causing error. Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:244]: reply has no auth hdr (WWW-Authenticate) Nov 14 04:02:28 v /usr/local/sbin/kamailio[24361]: ERROR: uac [auth.c:419]: failed to extract authenticate hdr maybe because authentication now not HDR_OTHER_T but HDR_WWW_AUTHENTICATE_T /* WWW-Authenticate header field */, HDR_PROXY_AUTHENTICATE_T /* Proxy-Authenticate header field */, according to: http://www.asipto.com/pub/kamailio-devel-guide/ for a moment i just comment it out will also try: if ( hdr->type!=HDR_WWW_AUTHENTICATE_T && hdr->type!=HDR_PROXY_AUTHENTICATE_T ) continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; ---------------------------------------------------------------------- >Comment By: Mangust (mangust2) Date: 2009-11-14 10:26 Message: A! it happen because before in v1.5 ./parser/hf.h /** * SIP Header types. * if you add a new type: * - make sure it's not greater than 63 * - make sure you add the corresponding flag to the hdr_flags_t defs below * - update clean_hdr_field (in hf.c) * - update sip_msg_cloner (modules/tm/sip_msg.c) * - update parse_headers (msg_parser.c) */ enum _hdr_types_t { HDR_ERROR_T = -1 /**< Error while parsing */, HDR_OTHER_T = 0 /**< Some other header field */, HDR_VIA_T = 1 /**< Via header field */, HDR_VIA1_T = 1 /**< First Via header field */, HDR_VIA2_T = 2 /**< only used as flag */, HDR_TO_T /**< To header field */, HDR_FROM_T /**< From header field */, HDR_CSEQ_T /**< CSeq header field */, HDR_CALLID_T /**< Call-Id header field */, HDR_CONTACT_T /**< Contact header field */, HDR_MAXFORWARDS_T /**< MaxForwards header field */, HDR_ROUTE_T /**< Route header field */, HDR_RECORDROUTE_T /**< Record-Route header field */, HDR_PATH_T /**< Path header fiels */, HDR_CONTENTTYPE_T /**< Content-Type header field */, HDR_CONTENTLENGTH_T /**< Content-Length header field */, HDR_AUTHORIZATION_T /**< Authorization header field */, HDR_EXPIRES_T /**< Expires header field */, HDR_PROXYAUTH_T /**< Proxy-Authorization hdr field */, HDR_SUPPORTED_T /**< Supported header field */, HDR_PROXYREQUIRE_T /**< Proxy-Require header field */, HDR_UNSUPPORTED_T /**< Unsupported header field */, HDR_ALLOW_T /**< Allow header field */, HDR_EVENT_T /**< Event header field */, HDR_ACCEPT_T /**< Accept header field */, HDR_ACCEPTLANGUAGE_T /**< Accept-Language header field */, HDR_ORGANIZATION_T /**< Organization header field */, HDR_PRIORITY_T /**< Priority header field */, HDR_SUBJECT_T /**< Subject header field */, HDR_USERAGENT_T /**< User-Agent header field */, HDR_ACCEPTDISPOSITION_T /**< Accept-Disposition hdr field */, HDR_CONTENTDISPOSITION_T /**< Content-Disposition hdr field */, HDR_DIVERSION_T /**< Diversion header field */, HDR_RPID_T /**< Remote-Party-ID header field */, HDR_REFER_TO_T /**< Refer-To header fiels */, HDR_SESSION_EXPIRES_T /**< Session-Expires header field */, HDR_MIN_SE_T /**< Min-SE header field */, HDR_PPI_T /**< P-Preferred-Identity header field */, HDR_PAI_T /**< P-Asserted-Identity header field */, HDR_PRIVACY_T /**< Privacy header field */, HDR_RETRY_AFTER_T /**< Retry-After header field */, HDR_EOH_T /**< Some other header field */ }; Was NO HDR_WWW_AUTHENTICATE_T or HDR_PROXY_AUTHENTICATE_T so authenticate header was matching HDR_OTHER_T ---------------------------------------------------------------------- Comment By: Mangust (mangust2) Date: 2009-11-14 10:20 Message: yes, this work as well: for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { if ( hdr->type!=HDR_WWW_AUTHENTICATE_T && hdr->type!=HDR_PROXY_AUTHENTICATE_T ) continue; if (cmp_hdrname_str(&hdr->name, &hdr_name)==0) return hdr; } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2897594&group_…

15 years, 2 months

[ openser-Bugs-2897594 ] uac_auth does't work in 3.0

by SourceForge.net

15 years, 2 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev