sr-dev

sr-dev@lists.kamailio.org

44307 discussions

git:sr_3.0: utils/sercmd: Fixed getopt() missing param

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: ac80f11893ab223f5464a23d1ea5635e959e41ee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ac80f11… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jan 21 17:32:42 2010 +0200 utils/sercmd: Fixed getopt() missing param Getopt was missing the -U param (cherry picked from commit 7c701df1be3d71afe49e7d017a90fa10c081b790) --- utils/sercmd/sercmd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/sercmd/sercmd.c b/utils/sercmd/sercmd.c index ada5ff6..1f1a721 100644 --- a/utils/sercmd/sercmd.c +++ b/utils/sercmd/sercmd.c @@ -1885,7 +1885,7 @@ int main(int argc, char** argv) port_no=0; sock_type=UNIXS_SOCK; opterr=0; - while((c=getopt(argc, argv, "Vhs:D:R:vf:"))!=-1){ + while((c=getopt(argc, argv, "UVhs:D:R:vf:"))!=-1){ switch(c){ case 'V': printf("version: %s\n", version);

14 years, 10 months

[ openser-Patches-2970838 ] Patch to dispatcher since API change

by SourceForge.net

Patches item #2970838, was opened at 2010-03-15 22:21 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2970838&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Stephen () >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Patch to dispatcher since API change Initial Comment: Update of dispatcher.c to include the api change ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 21:07 Message: Patch applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2970838&group_…

14 years, 10 months

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827

by SourceForge.net

Patches item #2961414, was opened at 2010-03-01 20:20 Message generated for change (Settings changed) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 21:05 Message: Patch applied. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-02 11:51 Message: i retried this with vanilla-kamailio 1.5.4 downloaded from kamailio.org and it crashs. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 21:11 Message: so there's already a fix? i tried this on 1.5.4, and it crashed. maybe i made a mistake merging it to my branch. i am going to check this tomorrow. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 20:51 Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:22 Message: sorry, i was not logged in while posting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

14 years, 10 months

git:sr_3.0: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: sr_3.0 Commit: e7d3e36a5fa22d54c3ed54726c6818c7ce9dab1f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7d3e36… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 (cherry picked from commit fb4f98a341322904a92c6f12396f5795a3275c08) --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 10 months

git:kamailio_3.0: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: 682ef1b6104ec62e4ec60eefa404c9403f6645c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=682ef1b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 (cherry picked from commit fb4f98a341322904a92c6f12396f5795a3275c08) --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 10 months

git:master: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: fb4f98a341322904a92c6f12396f5795a3275c08 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fb4f98a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 10 months

SF.net SVN: openser:[5995] branches/1.5/modules/nathelper/nhelpr_funcs.c

by Daniel-Constantin Mierla

Revision: 5995 http://openser.svn.sourceforge.net/openser/?rev=5995&view=rev Author: miconda Date: 2010-03-17 18:57:52 +0000 (Wed, 17 Mar 2010) Log Message: ----------- - safety check for content-lenght - patch by Marcus Hunger, SF #2961414 Modified Paths: -------------- branches/1.5/modules/nathelper/nhelpr_funcs.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 10 months

[ openser-Bugs-2963040 ] allow_source_address_group() not matching correctly

by SourceForge.net

Bugs item #2963040, was opened at 2010-03-04 04:04 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: allow_source_address_group() not matching correctly Initial Comment: IP address subnet matching does not work properly when using the allow_source_address_group() function from the Permissions module. The problem comes from /modules_k/permissions/hash.c:568 in function find_group_in_subnet_table(). subnet = ip_addr << table[i].mask; should be subnet = htonl(ntohl(ip_addr) >> table[i].mask); Here is a git diff to fix it: diff --git a/modules_k/permissions/hash.c b/modules_k/permissions/hash.c index 7358225..7917d5a 100644 --- a/modules_k/permissions/hash.c +++ b/modules_k/permissions/hash.c @@ -565,7 +565,7 @@ int find_group_in_subnet_table(struct subnet* table, i = 0; while (i < count) { - subnet = ip_addr << table[i].mask; + subnet = htonl(ntohl(ip_addr) >> table[i].mask); //ip_addr << table[i].mask; if ((table[i].subnet == subnet) && ((table[i].port == port) || (table[i].port == 0))) return table[i].grp; ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:41 Message: Patch was applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_…

14 years, 10 months

git:kamailio_3.0: * modules_k/permissions: subnet matching fix ( credits to anonymous)

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: ccef7b8729d0beb6ac2c55b7f68bab5a8650c546 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ccef7b8… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Mar 4 09:09:22 2010 +0200 * modules_k/permissions: subnet matching fix (credits to anonymous) (cherry picked from commit f5a29762b6155209721ba0dfc3f30b4a9764c191) --- modules_k/permissions/hash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/permissions/hash.c b/modules_k/permissions/hash.c index 7358225..5c5c7a6 100644 --- a/modules_k/permissions/hash.c +++ b/modules_k/permissions/hash.c @@ -565,7 +565,7 @@ int find_group_in_subnet_table(struct subnet* table, i = 0; while (i < count) { - subnet = ip_addr << table[i].mask; + subnet = htonl(ntohl(ip_addr) >> table[i].mask); if ((table[i].subnet == subnet) && ((table[i].port == port) || (table[i].port == 0))) return table[i].grp;

14 years, 10 months

[ openser-Bugs-2947231 ] Makefile doesn't install mysql related stuff

by SourceForge.net

Bugs item #2947231, was opened at 2010-02-07 03:42 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: tools >Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: veganimado (veganimado) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Makefile doesn't install mysql related stuff Initial Comment: Hi, after compiling with make group_include="standard mysql" all "make install" doesn't install some mysql related file, e.g. the directory /lib/kamailio/kamctl/mysql is missing. Best regards, Victor ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:27 Message: Previous comment shows the way to get mysql scripts installed. It is not a bug, but how makefile works. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-02-07 16:21 Message: do you install from tarball or git? Here is a git step by step turorial: http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.0.x-from-git kamctl mysql files are installed together with db_mysql if the flavour is kamailio. This is default on kamailio_3.0 branch, but for devel, one has to do: make FLAVOUR=kamailio cfg then: make all; make install ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_…

14 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev