Is there any particular reason for why we always fetch docbook style
sheets over HTTP when running "make README" ?
I can tell you that it doesn't work well with lousy connections. The
result is an empty README file - just a few blank lines.
Maybe we should consider storing the versions we use in the docbook
directory.
/O
Module: sip-router
Branch: master
Commit: e06a69d625d4c1293fceef13f9eca22e14662f9f
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e06a69d…
Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Date: Mon Oct 12 15:10:55 2009 +0300
If the user parameter is "<null>" (e.g a empty username in the request URI), do not copy this value to the rewritten uri.
This is the case of a REGISTER request. Added statements that the parameters to the actually_rewrite func may not be null.
---
modules/carrierroute/cr_func.c | 31 +++++++++++++++++++++----------
1 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/modules/carrierroute/cr_func.c b/modules/carrierroute/cr_func.c
index 5f4abb5..e4e6d71 100644
--- a/modules/carrierroute/cr_func.c
+++ b/modules/carrierroute/cr_func.c
@@ -267,11 +267,10 @@ static struct route_rule * get_rule_by_hash(const struct route_flags * rf,
/**
* does the work for rewrite_on_rule, writes the new URI into dest
*
- * @param rs the route rule used for rewriting
- * @param dest the returned new destination URI
- * @param msg the sip message
- * @param user the localpart of the uri to be rewritten
- * @param descavp the name of the AVP where the description is stored
+ * @param rs the route rule used for rewriting, not NULL
+ * @param dest the returned new destination URI, not NULL
+ * @param msg the sip message, not NULL
+ * @param user the localpart of the uri to be rewritten, not NULL
*
* @return 0 on success, -1 on failure
*
@@ -284,11 +283,23 @@ static int actually_rewrite(const struct route_rule *rs, str *dest,
int_str avp_val;
int strip = 0;
+ str l_user = *user;
+
strip = (rs->strip > user->len ? user->len : rs->strip);
strip = (strip < 0 ? 0 : strip);
- len = rs->local_prefix.len + user->len + rs->local_suffix.len +
- AT_SIGN.len + rs->host.len - strip;
+ if ( strcmp(user->s, "<null>") == 0 || user->len == 0)
+ {
+ l_user.s = NULL;
+ l_user.len = 0;
+ len = rs->host.len;
+ strip = 0;
+ }
+ else{
+ len = rs->local_prefix.len + l_user.len + rs->local_suffix.len +
+ AT_SIGN.len + rs->host.len - strip;
+ }
+
if (msg->parsed_uri.type == SIPS_URI_T) {
len += SIPS_URI.len;
} else {
@@ -309,11 +320,11 @@ static int actually_rewrite(const struct route_rule *rs, str *dest,
memcpy(p, SIP_URI.s, SIP_URI.len);
p += SIP_URI.len;
}
- if (user->len) {
+ if (l_user.len) {
memcpy(p, rs->local_prefix.s, rs->local_prefix.len);
p += rs->local_prefix.len;
- memcpy(p, user->s + strip, user->len - strip);
- p += user->len - strip;
+ memcpy(p, l_user.s + strip, l_user.len - strip);
+ p += l_user.len - strip;
memcpy(p, rs->local_suffix.s, rs->local_suffix.len);
p += rs->local_suffix.len;
memcpy(p, AT_SIGN.s, AT_SIGN.len);
looks like sr parser/parse_event.c has the same bug that i found in
opensips although the implementations are different.
after statement
end = skip_token(tmp.s, tmp.len);
end points to next char after event string.
then end is assigned to tmp.s
tmp.s = end;
and after that if statement compares this next char to ';':
if (tmp.s[0] == ';') {
which looks wrong to me, because that char can be anything if event does
not have any params.
perhaps someone else can recheck if i'm right or wrong.
-- juha
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Anonymous user ()
Attached to Project - sip-router
Summary - ycckgrbg
Task Type - Improvement
Category - tcp
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Critical
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - izrnsdtc http://cvgksuzd.com jsqbvodl nnefuqxi [URL=http://styynjnv.com]rhsnsyzz[/URL] <a href="http://maivmndq.com">gvcpvnuc</a>
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=19
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A user has added themself to the list of users assigned to this task.
FS#19 - ycckgrbg
User who did this - Anonymous user ()
http://sip-router.org/tracker/index.php?do=details&task_id=19
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.