sr-dev

sr-dev@lists.kamailio.org

12 participants
44183 discussions

git:master:b993b824: ims_registrar_pcscf: init and check vb variable

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b993b824447f30c9533b6ebd90ab74c19ea001bb URL: https://github.com/kamailio/kamailio/commit/b993b824447f30c9533b6ebd90ab74c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T10:56:12+01:00 ims_registrar_pcscf: init and check vb variable --- Modified: src/modules/ims_registrar_pcscf/service_routes.c --- Diff: https://github.com/kamailio/kamailio/commit/b993b824447f30c9533b6ebd90ab74c… Patch: https://github.com/kamailio/kamailio/commit/b993b824447f30c9533b6ebd90ab74c… --- diff --git a/src/modules/ims_registrar_pcscf/service_routes.c b/src/modules/ims_registrar_pcscf/service_routes.c index 26b31ad6f1e..c04db041e0c 100644 --- a/src/modules/ims_registrar_pcscf/service_routes.c +++ b/src/modules/ims_registrar_pcscf/service_routes.c @@ -228,7 +228,7 @@ pcontact_t *getContactP(struct sip_msg *_m, udomain_t *_d, pcontact_info_t search_ci; str received_host = {0, 0}; char srcip[50]; - struct via_body *vb; + struct via_body *vb = NULL; unsigned short port, proto; str host; sip_uri_t contact_uri; @@ -274,7 +274,7 @@ pcontact_t *getContactP(struct sip_msg *_m, udomain_t *_d, "[%d://%.*s:%d]\n", proto, host.len, host.s, port); - if(trust_bottom_via) { + if(trust_bottom_via && vb) { if(vb->received != NULL && vb->received->value.len > 0) { received_host = vb->received->value; } else { @@ -285,7 +285,7 @@ pcontact_t *getContactP(struct sip_msg *_m, udomain_t *_d, received_host.s = srcip; } unsigned short received_port = 0; - if(trust_bottom_via) { + if(trust_bottom_via && vb) { if(vb->rport != NULL && vb->rport->value.len > 0) { received_port = atoi(vb->rport->value.s); } else { @@ -298,7 +298,7 @@ pcontact_t *getContactP(struct sip_msg *_m, udomain_t *_d, received_port = 5060; } char received_proto = 0; - if(trust_bottom_via && vb->proto) { + if(trust_bottom_via && vb && vb->proto) { received_proto = vb->proto; } else { received_proto = _m->rcv.proto;

1 month, 1 week

git:master:eab6682e: keepalive: use memcpy for coping data

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: eab6682e4d8bebaf97f85c55b0863ad435e1d133 URL: https://github.com/kamailio/kamailio/commit/eab6682e4d8bebaf97f85c55b0863ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T10:39:44+01:00 keepalive: use memcpy for coping data --- Modified: src/modules/keepalive/keepalive_core.c --- Diff: https://github.com/kamailio/kamailio/commit/eab6682e4d8bebaf97f85c55b0863ad… Patch: https://github.com/kamailio/kamailio/commit/eab6682e4d8bebaf97f85c55b0863ad… --- diff --git a/src/modules/keepalive/keepalive_core.c b/src/modules/keepalive/keepalive_core.c index b1b3581cb34..4c8a186b660 100644 --- a/src/modules/keepalive/keepalive_core.c +++ b/src/modules/keepalive/keepalive_core.c @@ -210,9 +210,10 @@ int ka_str_copy(str *src, str *dest, char *prefix) return -1; } - if(prefix) - strncpy(dest->s, prefix, lp); - strncpy(dest->s + lp, src->s, src->len); + if(prefix) { + memcpy(dest->s, prefix, lp); + } + memcpy(dest->s + lp, src->s, src->len); dest->s[src->len + lp] = '\0'; dest->len = src->len + lp;

1 month, 1 week

git:master:c2ff02b6: core: modparam - use memcpy for data cloning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c2ff02b6d07c0f84dcbe5d0d47de3f12ed791e3a URL: https://github.com/kamailio/kamailio/commit/c2ff02b6d07c0f84dcbe5d0d47de3f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T10:35:19+01:00 core: modparam - use memcpy for data cloning --- Modified: src/core/modparam.c --- Diff: https://github.com/kamailio/kamailio/commit/c2ff02b6d07c0f84dcbe5d0d47de3f1… Patch: https://github.com/kamailio/kamailio/commit/c2ff02b6d07c0f84dcbe5d0d47de3f1… --- diff --git a/src/core/modparam.c b/src/core/modparam.c index b48d9e82442..a166cc50706 100644 --- a/src/core/modparam.c +++ b/src/core/modparam.c @@ -151,7 +151,7 @@ int set_mod_param_regex(char *regex, char *name, modparam_t type, void *val) pkg_free(reg); return -1; } - strncpy(*((char **)ptr), (char *)val2, len_param); + memcpy(*((char **)ptr), (char *)val2, len_param); (*((char **)ptr))[len_param] = '\0'; break;

1 month, 1 week

git:master:92698848: core: removed unnecessary use of strlen

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 926988487358e1ae3ba79ca999629c452e2d32df URL: https://github.com/kamailio/kamailio/commit/926988487358e1ae3ba79ca999629c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T10:36:47+01:00 core: removed unnecessary use of strlen --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/926988487358e1ae3ba79ca999629c4… Patch: https://github.com/kamailio/kamailio/commit/926988487358e1ae3ba79ca999629c4… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 5db20255874..afd67173a5d 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -512,7 +512,7 @@ int ksr_locate_module(char *mod_path, char **new_path) len++; } path[len] = 0; - strncat(path, mod_path, strlen(mod_path)); + strcat(path, mod_path); if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path);

1 month, 1 week

git:master:78f272da: async: fixed typo in log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 78f272da156ff7796dd84697bbf04522b7a08009 URL: https://github.com/kamailio/kamailio/commit/78f272da156ff7796dd84697bbf0452… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T08:33:41+01:00 async: fixed typo in log message --- Modified: src/modules/async/async_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/78f272da156ff7796dd84697bbf0452… Patch: https://github.com/kamailio/kamailio/commit/78f272da156ff7796dd84697bbf0452… --- diff --git a/src/modules/async/async_mod.c b/src/modules/async/async_mod.c index 504efa28125..722eb0cdbf9 100644 --- a/src/modules/async/async_mod.c +++ b/src/modules/async/async_mod.c @@ -130,7 +130,7 @@ static int mod_init(void) { /* init faked sip msg */ if(faked_msg_init() < 0) { - LM_ERR("failed to iit local sip msg\n"); + LM_ERR("failed to init local sip msg\n"); return -1; }

1 month, 1 week

git:master:2fccae6c: modules: readme files regenerated - async ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 2fccae6cf901edf8b9515636b348246297a06131 URL: https://github.com/kamailio/kamailio/commit/2fccae6cf901edf8b9515636b348246… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-11-28T08:31:10+01:00 modules: readme files regenerated - async ... [skip ci] --- Modified: src/modules/async/README --- Diff: https://github.com/kamailio/kamailio/commit/2fccae6cf901edf8b9515636b348246… Patch: https://github.com/kamailio/kamailio/commit/2fccae6cf901edf8b9515636b348246…

1 month, 1 week

git:master:97c9aca6: async: docs for mode parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 97c9aca6d2e7300b295c5cc7f9cd405d563d31b2 URL: https://github.com/kamailio/kamailio/commit/97c9aca6d2e7300b295c5cc7f9cd405… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T08:22:15+01:00 async: docs for mode parameter --- Modified: src/modules/async/doc/async_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/97c9aca6d2e7300b295c5cc7f9cd405… Patch: https://github.com/kamailio/kamailio/commit/97c9aca6d2e7300b295c5cc7f9cd405… --- diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml index f11e28540ed..4bfa5da48e7 100644 --- a/src/modules/async/doc/async_admin.xml +++ b/src/modules/async/doc/async_admin.xml @@ -129,6 +129,27 @@ modparam("async", "ms_timer", 10) ... modparam("async", "return", 1) ... +</programlisting> + </example> + </section> + <section id="async.p.mode"> + <title><varname>mode</varname> (int)</title> + <para> + Control if the module should bind (0) to tm or not (1). It may not + be needed to use tm functions (e.g., when needing async_tkv_emit() + only). + </para> + <para> + <emphasis> + Default value is 0 (bind to tm module). + </emphasis> + </para> + <example> + <title>Set <varname>mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("async", "mode", 1) +... </programlisting> </example> </section>

1 month, 1 week

git:master:21d48531: async: added parameter mode

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 21d4853139523920810a9d73916f3435a5a73d70 URL: https://github.com/kamailio/kamailio/commit/21d4853139523920810a9d73916f343… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-28T08:16:11+01:00 async: added parameter mode - control if binding to tm should be done or not --- Modified: src/modules/async/async_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/21d4853139523920810a9d73916f343… Patch: https://github.com/kamailio/kamailio/commit/21d4853139523920810a9d73916f343… --- diff --git a/src/modules/async/async_mod.c b/src/modules/async/async_mod.c index 5353082359f..504efa28125 100644 --- a/src/modules/async/async_mod.c +++ b/src/modules/async/async_mod.c @@ -43,6 +43,7 @@ MODULE_VERSION static int async_workers = 1; static int async_ms_timer = 0; static int async_return = 0; +static int async_mode = 0; static int mod_init(void); static int child_init(int); @@ -97,6 +98,7 @@ static param_export_t params[]={ {"workers", PARAM_INT, &async_workers}, {"ms_timer", PARAM_INT, &async_ms_timer}, {"return", PARAM_INT, &async_return}, + {"mode", PARAM_INT, &async_mode}, {0, 0, 0} }; @@ -132,13 +134,18 @@ static int mod_init(void) return -1; } - if(load_tm_api(&tmb) == -1) { - LM_ERR("cannot load the TM-functions. Missing TM module?\n"); - return -1; + if(async_mode == 0) { + if(load_tm_api(&tmb) == -1) { + LM_ERR("cannot load the TM-functions. Missing TM module?\n"); + return -1; + } + } else { + memset(&tmb, 0, sizeof(struct tm_binds)); } - if(async_workers <= 0) + if(async_workers <= 0) { return 0; + } if(async_init_timer_list() < 0) { LM_ERR("cannot initialize internal structure\n"); @@ -173,8 +180,9 @@ static int child_init(int rank) if(rank != PROC_MAIN) return 0; - if(async_workers <= 0) + if(async_workers <= 0) { return 0; + } for(i = 0; i < async_workers; i++) { if(fork_basic_timer(PROC_TIMER, "ASYNC MOD TIMER", 1 /*socks flag*/,

1 month, 1 week

git:master:b003a718: corez: set sndinfo attributes for corex_sip_reply_out()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b003a7184a02da5fd6dfe27def8d928d363e36ce URL: https://github.com/kamailio/kamailio/commit/b003a7184a02da5fd6dfe27def8d928… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-27T15:36:33+01:00 corez: set sndinfo attributes for corex_sip_reply_out() --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b003a7184a02da5fd6dfe27def8d928… Patch: https://github.com/kamailio/kamailio/commit/b003a7184a02da5fd6dfe27def8d928… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index 115e50f8a03..9f22b445ece 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -1453,6 +1453,16 @@ static int corex_sip_reply_out(sr_event_param_t *evp) str evname = str_init("corex:reply-out"); memset(&sndinfo, 0, sizeof(onsend_info_t)); + sndinfo.dst = evp->dst; + if(evp->rpl != NULL) { + sndinfo.msg = evp->rpl; + sndinfo.buf = evp->rpl->buf; + sndinfo.len = evp->rpl->len; + } else { + sndinfo.msg = evp->req; + sndinfo.buf = evp->req->buf; + sndinfo.len = evp->req->len; + } if(corex_evrt_reply_out_no >= 0 || corex_evcb_reply_out.len > 0) { run_onsend_evroute(&sndinfo, corex_evrt_reply_out_no,

1 month, 1 week

git:master:13f77911: core: parameter to set async_tkv_evcb

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 13f77911ebf5c5b53c9793727a9c5b4f1f0865fe URL: https://github.com/kamailio/kamailio/commit/13f77911ebf5c5b53c9793727a9c5b4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-27T12:20:05+01:00 core: parameter to set async_tkv_evcb - name of event route or kemi callback for tkv processing --- Modified: src/core/async_task.c Modified: src/core/async_task.h Modified: src/core/cfg.lex Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/13f77911ebf5c5b53c9793727a9c5b4… Patch: https://github.com/kamailio/kamailio/commit/13f77911ebf5c5b53c9793727a9c5b4…

1 month, 1 week

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev