sr-dev

sr-dev@lists.kamailio.org

44307 discussions

git:andrei/tcp_tls_changes: tcp: force eof after read if write side hangup

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/tcp_tls_changes Commit: 28e313250503d6f8d06ebab15c8421c40e7f0fe4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=28e3132… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sun Jun 20 19:40:55 2010 +0200 tcp: force eof after read if write side hangup Even if POLLRDHUP is not supported, but we detected a write side close (POLLHUP) or an error (POLLERR) or such an event was previously detected by tcp_main (F_CONN_EOF_SEEN), force connection closing after reading all the data in the socket buffer. In this case we can close() after the first short read and we save an extra system call (a read() that returns 0). --- tcp_read.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcp_read.c b/tcp_read.c index 4881844..2d42cb9 100644 --- a/tcp_read.c +++ b/tcp_read.c @@ -1011,13 +1011,13 @@ repeat_1st_read: con, con->id, atomic_get(&con->refcnt)); goto read_error; } + read_flags=(( #ifdef POLLRDHUP - read_flags=(((events & POLLRDHUP) | + (events & POLLRDHUP) | +#endif /* POLLRDHUP */ + (events & (POLLHUP|POLLERR)) | (con->flags & (F_CONN_EOF_SEEN|F_CONN_FORCE_EOF))) && !(events & POLLPRI))? RD_CONN_FORCE_EOF: 0; -#else /* POLLRDHUP */ - read_flags=0; -#endif /* POLLRDHUP */ #ifdef USE_TLS repeat_read: #endif /* USE_TLS */

14 years, 7 months

git:andrei/tcp_tls_changes: tls: fix tls_send out-of-mem on new connection

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/tcp_tls_changes Commit: a412c0fdc88e96abac79175c479a0c952a966a8c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a412c0f… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Jun 21 00:20:13 2010 +0200 tls: fix tls_send out-of-mem on new connection If trying to init a new connection, don't try to set the BIOs before exiting (the connection is NULL). --- modules/tls/tls_server.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index 7bdde99..b402c97 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -580,16 +580,19 @@ static int tls_generic_send(int fd, struct tcp_connection *c, err_src = "TLS write:"; lock_get(&c->write_lock); if (unlikely(tls_fix_connection(c) < 0)) { + /* c->extra_data might be null => exit immediately */ ERR("tls_fix_connection failed\n"); - goto error; + lock_release(&c->write_lock); + *resp = CONN_ERROR; + return -1; } tls_c = (struct tls_extra_data*)c->extra_data; ssl = tls_c->ssl; /* clear text already queued (WANTS_READ) queue directly*/ if (unlikely(tls_write_wants_read(tls_c))) { if (unlikely(tls_ct_wq_add(&tls_c->ct_wq, buf+offs, len -offs) < 0)) { - ERR("ct write buffer full (%d bytes)\n", - tls_c->ct_wq?tls_c->ct_wq->queued:0); + ERR("ct write buffer full for %p (%d bytes)\n", + c, tls_c->ct_wq?tls_c->ct_wq->queued:0); goto error_wq_full; } goto end;

14 years, 7 months

[ openser-Bugs-3018979 ] SIP UA can't receive 500(Internal Server Error)

by SourceForge.net

Bugs item #3018979, was opened at 2010-06-21 12:08 Message generated for change (Comment added) made by klaus_darilion You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018979&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: xhu xhu (xhujohnson) Assigned to: Nobody/Anonymous (nobody) Summary: SIP UA can't receive 500(Internal Server Error) Initial Comment: SIP UA can't receive 500(Internal Server Error) after sending the REGISTER request with the equal CSeq header field value to the last value of CSeq or lower than the number. The details can be seen as follows: 1 Test topology: NUT(REG && PX) UA11 UA12 DNS | | | | IP : 3ffe:501:ffff:50::50 3ffe:501:ffff:1::1 3ffe:501:ffff:2::2 3ffe:501:ffff:4::1 aor-uri : ss.under.test.com UA11(a)under.test.com UA12(a)under.test.com contact-uri : UA11(a)node.under.test.com UA12(a)node11.under.test.com 2 tcpdump file can be seen in "SIP Registrar- REGISTER request with the equal CSeq value to or lower than the last value of CSeq" attachment 3 openser configuration file can be seen in "openser.cfg" attachment ---------------------------------------------------------------------- >Comment By: Klaus Darilion (klaus_darilion) Date: 2010-06-21 13:07 Message: As far as I know there are some CSeq checks. But I think there is a short time intervall were the same CSeq is allowed to handle retransmissions. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018979&group_…

14 years, 7 months

[ openser-Bugs-3018975 ] SIPv6 UA can't receive a 423 (Interval Too Brief) response

by SourceForge.net

Bugs item #3018975, was opened at 2010-06-21 11:55 Message generated for change (Comment added) made by klaus_darilion You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018975&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None >Status: Closed >Resolution: Wont Fix Priority: 5 Private: No Submitted By: xhu xhu (xhujohnson) Assigned to: Nobody/Anonymous (nobody) Summary: SIPv6 UA can't receive a 423 (Interval Too Brief) response Initial Comment: SIPv6 UA can't receive a 423 (Interval Too Brief) response from openser-1.3.4-12.fc13.i686 SIPv6 Registrar Server when expiration of a REGISTER request is less than a registrar-configured minimum.The details can be seen as follows. Is it a bug or can be resolved by modifying configuration file? 1 Test topology: NUT(REG && PX) UA11 UA12 DNS | | | | IP : 3ffe:501:ffff:50::50 3ffe:501:ffff:1::1 3ffe:501:ffff:2::2 3ffe:501:ffff:4::1 aor-uri : ss.under.test.com UA11(a)under.test.com UA12(a)under.test.com contact-uri : UA11(a)node.under.test.com UA12(a)node11.under.test.com 2 the tcpdump file can be seen in "SIP Registrar- Expiration of REGISTER request less than a registrar-configured minimum" attachment 3 openser-1.3.4-12 configuration file can be seen in openser.cfg attachment. I have added the following block into the openser.cfg " modparam("registrar", "default_expires", 3600) modparam("registrar", "min_expires", 60) " ---------------------------------------------------------------------- >Comment By: Klaus Darilion (klaus_darilion) Date: 2010-06-21 13:04 Message: Hi! 1. Openser 1.3 is rather old and not supported anymore. Anyway, the behavior has not changed in newer versions. 2. Openser/Kamailio/sip-router does not have an implicit mechanism to send 423 - it uses a different approach. It just overrides the user-provided expires value and set a different one. Take a look at the 200 OK response - the Contact header has a different expire value (660) then the requested one (30). 3. if you really need 423, you have to script it. e.g. in Kamilio 3.0 Syntax: if ($hdr[Expires] < 3600) { append_to_reply("Min-Expires: 3600\r\n"); sl_send_reply("423","Intervall to short"); exit; } 4. For such discussions please use the kamailio mailing list ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018975&group_…

14 years, 7 months

[ openser-Bugs-3018979 ] SIP UA can't receive 500(Internal Server Error)

by SourceForge.net

Bugs item #3018979, was opened at 2010-06-21 18:08 Message generated for change (Tracker Item Submitted) made by xhujohnson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018979&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: xhu xhu (xhujohnson) Assigned to: Nobody/Anonymous (nobody) Summary: SIP UA can't receive 500(Internal Server Error) Initial Comment: SIP UA can't receive 500(Internal Server Error) after sending the REGISTER request with the equal CSeq header field value to the last value of CSeq or lower than the number. The details can be seen as follows: 1 Test topology: NUT(REG && PX) UA11 UA12 DNS | | | | IP : 3ffe:501:ffff:50::50 3ffe:501:ffff:1::1 3ffe:501:ffff:2::2 3ffe:501:ffff:4::1 aor-uri : ss.under.test.com UA11(a)under.test.com UA12(a)under.test.com contact-uri : UA11(a)node.under.test.com UA12(a)node11.under.test.com 2 tcpdump file can be seen in "SIP Registrar- REGISTER request with the equal CSeq value to or lower than the last value of CSeq" attachment 3 openser configuration file can be seen in "openser.cfg" attachment ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018979&group_…

14 years, 7 months

[ openser-Bugs-3018975 ] SIPv6 UA can't receive a 423 (Interval Too Brief) response

by SourceForge.net

Bugs item #3018975, was opened at 2010-06-21 17:55 Message generated for change (Tracker Item Submitted) made by xhujohnson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018975&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: xhu xhu (xhujohnson) Assigned to: Nobody/Anonymous (nobody) Summary: SIPv6 UA can't receive a 423 (Interval Too Brief) response Initial Comment: SIPv6 UA can't receive a 423 (Interval Too Brief) response from openser-1.3.4-12.fc13.i686 SIPv6 Registrar Server when expiration of a REGISTER request is less than a registrar-configured minimum.The details can be seen as follows. Is it a bug or can be resolved by modifying configuration file? 1 Test topology: NUT(REG && PX) UA11 UA12 DNS | | | | IP : 3ffe:501:ffff:50::50 3ffe:501:ffff:1::1 3ffe:501:ffff:2::2 3ffe:501:ffff:4::1 aor-uri : ss.under.test.com UA11(a)under.test.com UA12(a)under.test.com contact-uri : UA11(a)node.under.test.com UA12(a)node11.under.test.com 2 the tcpdump file can be seen in "SIP Registrar- Expiration of REGISTER request less than a registrar-configured minimum" attachment 3 openser-1.3.4-12 configuration file can be seen in openser.cfg attachment. I have added the following block into the openser.cfg " modparam("registrar", "default_expires", 3600) modparam("registrar", "min_expires", 60) " ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=3018975&group_…

14 years, 7 months

bug in topoh mudule ?

by jerome.marchet＠orange-ftgroup.com

14 years, 7 months

[tracker] Comment added: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#77 - presence_xml with db_postgres User who did this - Andrey A Berekelya (bandry) ---------- Yes. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77#comment88 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 7 months

[tracker] Comment added: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#77 - presence_xml with db_postgres User who did this - Klaus Darilion (klaus3000) ---------- Aha. So the problem is when reading BLOB from DB, not when storing BLOB to DB, correct? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77#comment87 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 7 months

git:master: modules/mediaproxy: Fix SDP mangling for unsupported streams.

by Juha Heinanen

Module: sip-router Branch: master Commit: 5f78020b2d7ba364becf5e5c8b6f5105f560011c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5f78020… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sun Jun 20 16:21:12 2010 +0300 modules/mediaproxy: Fix SDP mangling for unsupported streams. - Credits to Saul Ibarra. --- modules/mediaproxy/mediaproxy.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/modules/mediaproxy/mediaproxy.c b/modules/mediaproxy/mediaproxy.c index 67a0c72..855fb7d 100644 --- a/modules/mediaproxy/mediaproxy.c +++ b/modules/mediaproxy/mediaproxy.c @@ -1733,7 +1733,7 @@ use_media_proxy(struct sip_msg *msg, char *dialog_id, ice_candidate_data *ice_da } } - for (i=0, j=1; i<session.stream_count && j<len; i++) { + for (i=0, j=1; i<session.stream_count; i++) { stream = session.streams[i]; if (stream.transport != TSupported) { if (!stream.local_ip && removed_session_ip) { @@ -1748,6 +1748,10 @@ use_media_proxy(struct sip_msg *msg, char *dialog_id, ice_candidate_data *ice_da continue; } + if (j >= len) { + break; + } + if (!isnullport(stream.port)) { if (!replace_element(msg, &stream.port, &tokens[j])) { LM_ERR("failed to replace port in media stream number %d\n", i+1);

14 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev