sr-dev

sr-dev@lists.kamailio.org

44307 discussions

[tracker] Comment added: patch to add method masking to xlog function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#81 - patch to add method masking to xlog function User who did this - Daniel-Constantin Mierla (miconda) ---------- I am not the owner of the module, anyway anyone is welcome to comment, plus that this is one change that impacts every config :-) . Why you don't add a new function xlogf() - the function that will evaluate built-in filters before printing. In the future someone might desire other type of filters. Also, just a suggestion, I saw you added dedicated rpc function to change the filters - while this is fine, there is now the cfg parameter framework which seems to be built for such cases (changing core/module parameters at runtime with smallest impact). I think Marius converted some parameters of registrar(k) module. Maybe you check this option and see if is more appropriate here as well. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=81#comment101 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 6 months

[tracker] Comment added: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#77 - presence_xml with db_postgres User who did this - Daniel-Constantin Mierla (miconda) ---------- I think as well that len should be kept untouched (shouldn't include the '\0'). Also AVPs with str value are 0-terminated, but the len does not reflect it. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77#comment100 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 6 months

[tracker] Comment added: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#77 - presence_xml with db_postgres User who did this - Andrey A Berekelya (bandry) ---------- I am a bit mistaken. To work properly you must remove the patch line: VAL_BLOB(_v).len++; It should work correctly with null results. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77#comment99 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 6 months

git:kamailio_3.0: Revert "db_postgres(old API) FS#77: fix BLOBs with postgres"

by Henning Westerholt

Module: sip-router Branch: kamailio_3.0 Commit: c3964dbca625de202db16ae6a4f9ea91128ccb48 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c3964db… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Jul 26 19:02:04 2010 +0200 Revert "db_postgres(old API) FS#77: fix BLOBs with postgres" This reverts commit a6141a32738b8610c70ba7e0a88c0d79561cb7a6. --- modules/db_postgres/km_val.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/db_postgres/km_val.c b/modules/db_postgres/km_val.c index 9faa5b5..cb3fe9f 100644 --- a/modules/db_postgres/km_val.c +++ b/modules/db_postgres/km_val.c @@ -72,18 +72,16 @@ int db_postgres_str2val(const db_type_t _t, db_val_t* _v, const char* _s, const LM_ERR("PQunescapeBytea failed\n"); return -7; } - VAL_BLOB(_v).s = pkg_malloc(VAL_BLOB(_v).len + 1); + VAL_BLOB(_v).s = pkg_malloc(VAL_BLOB(_v).len); if (VAL_BLOB(_v).s == NULL) { LM_ERR("no private memory left\n"); PQfreemem(tmp_s); return -8; } - LM_DBG("allocate %d bytes memory for BLOB at %p", VAL_BLOB(_v).len + 1, VAL_BLOB(_v).s); + LM_DBG("allocate %d bytes memory for BLOB at %p", VAL_BLOB(_v).len, VAL_BLOB(_v).s); memcpy(VAL_BLOB(_v).s, tmp_s, VAL_BLOB(_v).len); PQfreemem(tmp_s); - VAL_BLOB(_v).s[VAL_BLOB(_v).len] = '\0'; - VAL_BLOB(_v).len++; VAL_TYPE(_v) = DB1_BLOB; VAL_FREE(_v) = 1;

14 years, 6 months

git:master: Revert "db_postgres(old API) FS#77: fix BLOBs with postgres"

by Henning Westerholt

Module: sip-router Branch: master Commit: 537dd99065f82f674fba8a5132b9cafb8735f6c9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=537dd99… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Jul 26 19:01:06 2010 +0200 Revert "db_postgres(old API) FS#77: fix BLOBs with postgres" This reverts commit 2e56720769913c55cacc83fe3a31f44f072e7590. --- modules/db_postgres/km_val.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/db_postgres/km_val.c b/modules/db_postgres/km_val.c index 9faa5b5..cb3fe9f 100644 --- a/modules/db_postgres/km_val.c +++ b/modules/db_postgres/km_val.c @@ -72,18 +72,16 @@ int db_postgres_str2val(const db_type_t _t, db_val_t* _v, const char* _s, const LM_ERR("PQunescapeBytea failed\n"); return -7; } - VAL_BLOB(_v).s = pkg_malloc(VAL_BLOB(_v).len + 1); + VAL_BLOB(_v).s = pkg_malloc(VAL_BLOB(_v).len); if (VAL_BLOB(_v).s == NULL) { LM_ERR("no private memory left\n"); PQfreemem(tmp_s); return -8; } - LM_DBG("allocate %d bytes memory for BLOB at %p", VAL_BLOB(_v).len + 1, VAL_BLOB(_v).s); + LM_DBG("allocate %d bytes memory for BLOB at %p", VAL_BLOB(_v).len, VAL_BLOB(_v).s); memcpy(VAL_BLOB(_v).s, tmp_s, VAL_BLOB(_v).len); PQfreemem(tmp_s); - VAL_BLOB(_v).s[VAL_BLOB(_v).len] = '\0'; - VAL_BLOB(_v).len++; VAL_TYPE(_v) = DB1_BLOB; VAL_FREE(_v) = 1;

14 years, 6 months

SF.net SVN: openser:[6024] branches/1.5/modules/db_postgres/val.c

by Henning Westerholt

Revision: 6024 http://openser.svn.sourceforge.net/openser/?rev=6024&view=rev Author: henningw Date: 2010-07-26 16:59:13 +0000 (Mon, 26 Jul 2010) Log Message: ----------- * revert r6013, because the caused regressions Modified Paths: -------------- branches/1.5/modules/db_postgres/val.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

[tracker] Task reopened: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been re-opened: FS#77 - presence_xml with db_postgres User who did this - Henning Westerholt (henningw) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 6 months

[tracker] Task closed: Major regression in db_postgres with FS#77 patch

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#80 - Major regression in db_postgres with FS#77 patch User who did this - Henning Westerholt (henningw) Reason for closing: Fixed Additional comments about closing: Ok, i finished the investigation. I tried to do some workaround to restore the <null> AVP behaviour. But the other issue, the adding of a \0 byte to every returned BLOB query is even nastier. This don't happen with mysql: append_to_reply and a test entry: [postgres] X-TEST=[abc.]. [mysql] X-TEST=[abc]. So i'll revert the patch from #FS77 for now. For the presence issue we probably need to come up with another fix. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=80 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 6 months

git:master: modules_k/presence and modules_k/rls Fixed parse_to() usage

by Marius Zbihlei

Module: sip-router Branch: master Commit: 957e2eb50879dbddb1f9a53e04609cfc0c67a178 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=957e2eb… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Jul 26 17:39:18 2010 +0300 modules_k/presence and modules_k/rls Fixed parse_to() usage In case of error parse_to returns a pointer to the last parsed character. This is not a strict error check, as several other modules provide a relaxed way of parsing To header (the uri is still parseable even if the TO headers are not). --- modules_k/presence/subscribe.c | 3 ++- modules_k/rls/subscribe.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules_k/presence/subscribe.c b/modules_k/presence/subscribe.c index 55e0271..c6f4aa2 100644 --- a/modules_k/presence/subscribe.c +++ b/modules_k/presence/subscribe.c @@ -798,7 +798,8 @@ int extract_sdialog_info(subs_t* subs,struct sip_msg* msg, int mexp, else { memset( &TO , 0, sizeof(TO) ); - if( !parse_to(msg->to->body.s,msg->to->body.s + msg->to->body.len + 1, &TO)) + parse_to(msg->to->body.s,msg->to->body.s + msg->to->body.len + 1, &TO); + if( TO.uri.len <= 0 ) { LM_DBG("'To' header NOT parsed\n"); goto error; diff --git a/modules_k/rls/subscribe.c b/modules_k/rls/subscribe.c index eae3bf7..783cf87 100644 --- a/modules_k/rls/subscribe.c +++ b/modules_k/rls/subscribe.c @@ -407,7 +407,8 @@ int rls_handle_subscribe(struct sip_msg* msg, char* s1, char* s2) else { memset( &TO , 0, sizeof(TO) ); - if( !parse_to(msg->to->body.s,msg->to->body.s+msg->to->body.len+1,&TO)); + parse_to(msg->to->body.s,msg->to->body.s+msg->to->body.len+1,&TO); + if( TO.uri.len <= 0 ) { LM_DBG("'To' header NOT parsed\n"); goto error;

14 years, 6 months

git:kamailio_3.0: modules_k/presence and modules_k/rls Fixed parse_to() usage

by Marius Zbihlei

Module: sip-router Branch: kamailio_3.0 Commit: 53c179bb3042bb767c43cd1a87a2cb8ab0ea92b7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=53c179b… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Jul 26 17:39:18 2010 +0300 modules_k/presence and modules_k/rls Fixed parse_to() usage In case of error parse_to returns a pointer to the last parsed character. This is not a strict error check, as several other modules provide a relaxed way of parsing To header (the uri is still parseable even if the TO headers are not). --- modules_k/presence/subscribe.c | 3 ++- modules_k/rls/subscribe.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules_k/presence/subscribe.c b/modules_k/presence/subscribe.c index 6ea70ae..607d0f2 100644 --- a/modules_k/presence/subscribe.c +++ b/modules_k/presence/subscribe.c @@ -802,7 +802,8 @@ int extract_sdialog_info(subs_t* subs,struct sip_msg* msg, int mexp, else { memset( &TO , 0, sizeof(TO) ); - if( !parse_to(msg->to->body.s,msg->to->body.s + msg->to->body.len + 1, &TO)) + parse_to(msg->to->body.s,msg->to->body.s + msg->to->body.len + 1, &TO); + if( TO.uri.len <= 0 ) { LM_DBG("'To' header NOT parsed\n"); goto error; diff --git a/modules_k/rls/subscribe.c b/modules_k/rls/subscribe.c index bdf311f..608e6e5 100644 --- a/modules_k/rls/subscribe.c +++ b/modules_k/rls/subscribe.c @@ -407,7 +407,8 @@ int rls_handle_subscribe(struct sip_msg* msg, char* s1, char* s2) else { memset( &TO , 0, sizeof(TO) ); - if( !parse_to(msg->to->body.s,msg->to->body.s+msg->to->body.len+1,&TO)); + parse_to(msg->to->body.s,msg->to->body.s+msg->to->body.len+1,&TO); + if( TO.uri.len <= 0 ) { LM_DBG("'To' header NOT parsed\n"); goto error;

14 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev