sr-dev

sr-dev@lists.kamailio.org

44307 discussions

git:master: modules/tm: Fixed memory leak related to several tm function exports

by Marius Zbihlei

Module: sip-router Branch: master Commit: 2ae7c6779188e053aa6d1cbd891c428ccc2b63fa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2ae7c67… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Aug 2 17:26:20 2010 +0300 modules/tm: Fixed memory leak related to several tm function exports Mk_proxy() call allocates a new proxy_t* structure. The free_proxy() call does not free this structure, it frees only the content. Another pkg_free is necessary in this case. --- modules/tm/tm.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/modules/tm/tm.c b/modules/tm/tm.c index 8f2d136..a7edc62 100644 --- a/modules/tm/tm.c +++ b/modules/tm/tm.c @@ -1189,6 +1189,7 @@ inline static int w_t_forward_nonack_to( struct sip_msg *p_msg , if (proxy) { r = _w_t_forward_nonack(p_msg, proxy, proxy->proto); free_proxy(proxy); + pkg_free(proxy); } return r; } @@ -1441,6 +1442,7 @@ inline static int w_t_relay_to_avp( struct sip_msg *p_msg , if (proxy) { r = _w_t_relay_to(p_msg, proxy, PROTO_NONE); free_proxy(proxy); + pkg_free(proxy); } return r; } @@ -1475,6 +1477,7 @@ inline static int w_t_replicate_uri(struct sip_msg *msg , r = t_replicate(msg, proxy, proxy->proto); free_proxy(proxy); + pkg_free(proxy); return r; } @@ -1532,8 +1535,9 @@ inline static int w_t_replicate_to( struct sip_msg *p_msg , int r = -1; proxy = t_protoaddr2proxy(proto_par, addr_par); if (proxy) { - r = t_replicate(p_msg, proxy, proxy->proto); + r = t_replicate(p_msg, proxy, proxy->proto); free_proxy(proxy); + pkg_free(proxy); } return r; }

14 years, 6 months

git:master: presence(k): set properly db updated flag

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b31c53abf1c3bafafb59d3fa6456135f1da6e6c9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b31c53a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 23:26:35 2010 +0200 presence(k): set properly db updated flag - patch by Marius-Ovidiu Bucur --- modules_k/presence/hash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/presence/hash.c b/modules_k/presence/hash.c index 874fe03..bc31b87 100644 --- a/modules_k/presence/hash.c +++ b/modules_k/presence/hash.c @@ -261,7 +261,7 @@ int insert_shtable(shtable_t htable,unsigned int hash_code, subs_t* subs) } new_rec->expires+= (int)time(NULL); - if(fallback2db==0) + if(fallback2db!=0) new_rec->db_flag= INSERTDB_FLAG; else new_rec->db_flag= NO_UPDATEDB_FLAG;

14 years, 6 months

git:master: presence_dialoginfo(k): don't exeed array size in error case

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 48f3159cdcc9ef06114a6d8f853687dc1338a8f0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=48f3159… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 23:29:43 2010 +0200 presence_dialoginfo(k): don't exeed array size in error case - error handling could get to the size of array as index, resulting in out of bounds operation - patch by Marius-Ovidiu Bucur --- modules_k/presence_dialoginfo/notify_body.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/presence_dialoginfo/notify_body.c b/modules_k/presence_dialoginfo/notify_body.c index 965cef0..efa3b45 100644 --- a/modules_k/presence_dialoginfo/notify_body.c +++ b/modules_k/presence_dialoginfo/notify_body.c @@ -264,7 +264,7 @@ str* agregate_xmls(str* pres_user, str* pres_domain, str** body_array, int n) error: if(xml_array!=NULL) { - for(i=0; i<=j; i++) + for(i=0; i<j; i++) { if(xml_array[i]!=NULL) xmlFreeDoc( xml_array[i]);

14 years, 6 months

git:master: pua(k): use the outbound proxy on updates

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f39cb1976978f0860d41a05ed181e45e14c88c58 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f39cb19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:25:52 2010 +0200 pua(k): use the outbound proxy on updates - patch by Alex Hermann, SF#3035780 --- modules_k/pua/pua.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/pua/pua.c b/modules_k/pua/pua.c index 3706200..bf73187 100644 --- a/modules_k/pua/pua.c +++ b/modules_k/pua/pua.c @@ -667,7 +667,7 @@ int update_pua(ua_pres_t* p, unsigned int hash_code) p->pres_uri, /* Request-URI */ p->pres_uri, /* To */ p->pres_uri, /* From */ - 0 /* Outbound proxy*/ + &outbound_proxy /* Outbound proxy*/ ); if(result< 0) {

14 years, 6 months

[ openser-Patches-3035780 ] Let pua use the configured outboudn proxy in all cases

by SourceForge.net

Patches item #3035780, was opened at 2010-07-28 10:07 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035780&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Alex Hermann (axlh) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Let pua use the configured outboudn proxy in all cases Initial Comment: pua wasn't using the outbound proxy on updates ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 21:28 Message: Thanks! Patch committed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035780&group_…

14 years, 6 months

SF.net SVN: openser:[6038] branches/1.5/modules/pua/pua.c

by Daniel-Constantin Mierla

Revision: 6038 http://openser.svn.sourceforge.net/openser/?rev=6038&view=rev Author: miconda Date: 2010-07-30 18:27:51 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - use the outbound proxy on updates - patch by Alex Hermann, SF#3035780 Modified Paths: -------------- branches/1.5/modules/pua/pua.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

[ openser-Patches-3035382 ] Fix transformation tobody.params

by SourceForge.net

Patches item #3035382, was opened at 2010-07-27 19:11 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Alex Hermann (axlh) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Fix transformation tobody.params Initial Comment: The transofrmation tobody.params can't handle quoted parameters well. If the last parameter is quoted, the output of the transofrmation is truncated by 2 characters.. Attached patch fixes this. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-30 21:21 Message: Thanks! Patches committed on git master branch and 1.5 for now. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2010-07-28 09:42 Message: Well, not a good start :( I split the patch into 2 parts. Part 1: Fix a off-by-one bug in parsing quoted parameters. The parameter value is shortened by 1 character. Part 2: Fix the tobody.params tranformation when the last paremeter has a quoted value. I found another solution: Just assume the parameter list ends on the end of the header line that gets pushed to the parser. Seems to work just as well, and prevents adjusting the rest of the code (tm). ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-27 23:25 Message: I reverted the commit on 1.5 branch - it was incomplete as the compilation got broken. Also, there should not be any commit on the trunk branch, the devel version is now on GIT repository hosted at git.sip-router.org. The bug tracker in use is as well by sip-router.org: http://sip-router.org/tracker Back to issue, apart of breaking the compilation, it could be a solution to store the hook for start of parameters and the length, but I didn't understand why you changed the len of quoted value. Moreover, there are other places that needs to be updated when the to_body structure is updated with new attributes storing pointers, like cloning for TM transactions. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_…

14 years, 6 months

SF.net SVN: openser:[6037] branches/1.5/modules/pv/pv_trans.c

by Daniel-Constantin Mierla

Revision: 6037 http://openser.svn.sourceforge.net/openser/?rev=6037&view=rev Author: miconda Date: 2010-07-30 18:20:27 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - fixed tobody.params transformation - len was wrong when having quoted parameters - patch by Alex Hermann, closes SF#3035382 Modified Paths: -------------- branches/1.5/modules/pv/pv_trans.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

SF.net SVN: openser:[6036] branches/1.5/parser/parse_to.c

by Daniel-Constantin Mierla

Revision: 6036 http://openser.svn.sourceforge.net/openser/?rev=6036&view=rev Author: miconda Date: 2010-07-30 18:18:33 +0000 (Fri, 30 Jul 2010) Log Message: ----------- - fix off-by-one bug for quoted parameter values in parse_to - patch by Alex Hermann, SF#3035382 Modified Paths: -------------- branches/1.5/parser/parse_to.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

git:master: core: fix parsing quoted paramers in To header

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8593bc83c748835c6132eaa678064a2466316ae7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8593bc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:07:45 2010 +0200 core: fix parsing quoted paramers in To header - fix off-by-one bug for quoted parameter values in parse_to - patch by Alex Hermann, SF#3035382 --- parser/parse_to.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/parser/parse_to.c b/parser/parse_to.c index 8dbaacf..8bfdca7 100644 --- a/parser/parse_to.c +++ b/parser/parse_to.c @@ -241,7 +241,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, status = PARA_VALUE_QUOTED; break; case PARA_VALUE_QUOTED: - param->value.len=tmp-param->value.s-1 ; + param->value.len=tmp-param->value.s; add_param( param , to_b ); status = E_PARA_VALUE; break;

14 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev