sr-dev

sr-dev@lists.kamailio.org

16 participants
45365 discussions

[tracker] Comment added: bug in dialplan or core re.c
by sip-router 22 Feb '11

22 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#115 - bug in dialplan or core re.c User who did this - Juha Heinanen (jh) ---------- i have made the tests with latest 3.1 from git. here is what happens with subst_exp ^(.+:)\+358(.+) and input uri sip:+35892345674@test.fi using various repl_exps: - if repl_exp is \1\2, i get what is expected, i.e., both \1 and \2 are replaced and consumed: Feb 22 09:40:39 sip /usr/sbin/sip-proxy[7323]: INFO: uri <sip:92345674@test.fi> - if repl_exp is \1X\2, \1 is replaced but not consumed and i get: Feb 22 09:42:48 sip /usr/sbin/sip-proxy[7484]: INFO: uri <sip:\1X92345674@test.fi> - if repl_exp is \1X\2Y, i get Feb 22 09:44:50 sip /usr/sbin/sip-proxy[7642]: INFO: uri <sip:\1X92345674@test.fiY> i.e., \2 is correctly replaced and consumed, but again \1 is replaced, but not consumed. -- juha ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=115#comment165 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: proper return code for pvar assignment
by Daniel-Constantin Mierla 22 Feb '11

22 Feb '11

Module: sip-router Branch: master Commit: 1f698797ec4def503630563c06f5aef4a7b40871 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1f69879… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Feb 21 23:15:29 2011 +0100 core: proper return code for pvar assignment - in some case the value of the right expression was returned instead of proper >=0 for success cases - reported by Juha Heinannen --- lvalue.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lvalue.c b/lvalue.c index e13e1a5..5d433f2 100644 --- a/lvalue.c +++ b/lvalue.c @@ -290,7 +290,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, break in expr*/ } else pval.ri=0; - ret=pval.ri; + ret=!(!pval.ri); break; case RV_BEXPR: /* logic/boolean expr. */ pval.flags=PV_TYPE_INT|PV_VAL_INT; @@ -301,7 +301,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, WARN("error in expression\n"); pval.ri=0; /* expr. is treated as false */ } - ret=pval.ri; + ret=!(!pval.ri); break; case RV_SEL: pval.flags=PV_VAL_STR; @@ -315,7 +315,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, break; } } - ret=(pval.rs.len)>0; + ret=(pval.rs.len>0); break; case RV_AVP: r_avp = search_avp_by_index(rv->v.avps.type, rv->v.avps.name,

2 1

[tracker] Task closed: assignment statement emits bogus error message in sr 3.1
by sip-router 21 Feb '11

21 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#114 - assignment statement emits bogus error message in sr 3.1 User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: There was an inconsistency in returning code from a helper function used to assign the values for PVs, pretty harmless, but resulted in this error message -- revealed because I added the log message to spot failed assignments. Should be fixed now on git, try it and if still present, reopen the task. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=114 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: assignment statement emits bogus error message in sr 3.1
by sip-router 21 Feb '11

21 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#114 - assignment statement emits bogus error message in sr 3.1 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=114 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.1: core: proper return code for pvar assignment
by Daniel-Constantin Mierla 21 Feb '11

21 Feb '11

Module: sip-router Branch: 3.1 Commit: 4ace86df07c55eb66f902fda3f37d198346bfb4a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4ace86d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Feb 21 23:15:29 2011 +0100 core: proper return code for pvar assignment - in some case the value of the right expression was returned instead of proper >=0 for success cases - reported by Juha Heinannen (cherry picked from commit 1f698797ec4def503630563c06f5aef4a7b40871) --- lvalue.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lvalue.c b/lvalue.c index e13e1a5..5d433f2 100644 --- a/lvalue.c +++ b/lvalue.c @@ -290,7 +290,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, break in expr*/ } else pval.ri=0; - ret=pval.ri; + ret=!(!pval.ri); break; case RV_BEXPR: /* logic/boolean expr. */ pval.flags=PV_TYPE_INT|PV_VAL_INT; @@ -301,7 +301,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, WARN("error in expression\n"); pval.ri=0; /* expr. is treated as false */ } - ret=pval.ri; + ret=!(!pval.ri); break; case RV_SEL: pval.flags=PV_VAL_STR; @@ -315,7 +315,7 @@ inline static int lval_pvar_assign(struct run_act_ctx* h, struct sip_msg* msg, break; } } - ret=(pval.rs.len)>0; + ret=(pval.rs.len>0); break; case RV_AVP: r_avp = search_avp_by_index(rv->v.avps.type, rv->v.avps.name,

1 0

[tracker] Comment added: bug in dialplan or core re.c
by sip-router 21 Feb '11

21 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#115 - bug in dialplan or core re.c User who did this - Daniel-Constantin Mierla (miconda) ---------- What version are you running? Is it only \1 appearing there, or also \2? There was a fix in 3.1 for variable substitutions, but I haven't seen this one at all so far... ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=115#comment164 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: assignment statement emits bogus error message in sr 3.1
by sip-router 21 Feb '11

21 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#114 - assignment statement emits bogus error message in sr 3.1 User who did this - Daniel-Constantin Mierla (miconda) ---------- OK, then it might be something I introduced while I added back the printing of line for failed assignments. I will double check it. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=114#comment163 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Employment Proposition. OVERVIEW.
by serdev＠iptel.org 21 Feb '11

21 Feb '11

Spam detection software, running on the system "mail.iptel.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Flexible Shifts! Great Pay! Terrific Opportunity for a professional individual ready to move ahead in a great career. As a Representative/Admin Assistant/Admin Representative for our well-known, stable construction Company. [...] Content analysis details: (18.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.3 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [178.93.56.220 listed in zen.spamhaus.org] 1.6 URIBL_WS_SURBL Contains an URL listed in the WS SURBL blocklist [URIs: resume-eur.com] 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: resume-eur.com] 3.6 HELO_DYNAMIC_IPADDR2 Relay HELO'd using suspicious hostname (IP addr 2) 3.2 FH_HELO_EQ_D_D_D_D Helo is d-d-d-d 0.7 TVD_RCVD_IP TVD_RCVD_IP 1.4 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [178.93.56.220 listed in bb.barracudacentral.org] 0.0 HTML_MESSAGE BODY: HTML included in message 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5462] 0.7 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 1.0 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 T_URIBL_BLACK_OVERLAP T_URIBL_BLACK_OVERLAP The original message was not completely plain text, and may be unsafe to open with some email clients; in particular, it may contain a virus, or confirm that your address can receive spam. If you wish to view it, it may be safer to save it to a file and open it with an editor.

1 0

NEWVacancies
by nils＠iptel.org 21 Feb '11

21 Feb '11

Spam detection software, running on the system "mail.iptel.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Flexible Shifts! Great Pay! Terrific Opportunity for a professional individual ready to move ahead in a great career. As a Representative/Admin Assistant/Admin Representative for our well-known, stable construction Company. [...] Content analysis details: (11.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [193.107.244.196 listed in zen.spamhaus.org] 1.6 URIBL_WS_SURBL Contains an URL listed in the WS SURBL blocklist [URIs: resume-eur.com] 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: resume-eur.com] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [193.107.244.196 listed in psbl.surriel.com] 1.3 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see <http://www.spamcop.net/bl.shtml?193.107.244.196>] 0.0 HTML_MESSAGE BODY: HTML included in message 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5880] 0.7 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 1.4 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [193.107.244.196 listed in bb.barracudacentral.org] 0.0 T_URIBL_BLACK_OVERLAP T_URIBL_BLACK_OVERLAP 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS The original message was not completely plain text, and may be unsafe to open with some email clients; in particular, it may contain a virus, or confirm that your address can receive spam. If you wish to view it, it may be safer to save it to a file and open it with an editor.

1 0

[tracker] Task opened: bug in dialplan or core re.c
by sip-router 21 Feb '11

21 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - bug in dialplan or core re.c Task Type - Bug Report Category - Module Status - New Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - dialplan table record subst_exp/repl_exp ^(.+:)\+358(.+)/\1X\2 results as sip:\1X92345670@test.fi;user=phone when applied to sip:+35892345670@test.fi;user=phone this is wrong, because \1 should not be in the result. looks like the bug is in core re.c or in dialplan modules's use of re.c. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=115 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev