sr-dev

sr-dev@lists.kamailio.org

44307 discussions

db_postgres/sqlops support of no return values

by Alex Balashov

Is it difficult to make db_postgres and/or sqlops support no values returned - i.e. a void result set? Recent versions of Postgres allow stored procedures to return 'void'. I like to call these a lot, but unfortunately sqlops or the database layer does not like that. So, I have to either write wrappers or make the procedures return things like a boolean 't' just to fix this. -- Alex Balashov - Principal Evariste Systems LLC 1170 Peachtree Street 12th Floor, Suite 1200 Atlanta, GA 30309 Tel: +1-678-954-0670 Fax: +1-404-961-1892 Web: http://www.evaristesys.com/

14 years, 4 months

git:3.1: sl: init register_cb in SL API

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 97decac9266dcd1d839bafb2680a14a1c95ea560 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=97decac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 11 17:05:19 2010 +0200 sl: init register_cb in SL API - used by siptrace, discovered while investigating issue reported by MÉSZÁROS Mihály (cherry picked from commit dd135dbf86d899e96fa8ecad5a6f66ca3b2ca5da) --- modules/sl/sl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/sl/sl.c b/modules/sl/sl.c index 4af524b..2ca7592 100644 --- a/modules/sl/sl.c +++ b/modules/sl/sl.c @@ -362,6 +362,7 @@ static int bind_sl(sl_api_t* api) api->dreply = sl_send_reply_dlg; api->freply = send_reply; api->get_reply_totag = get_reply_totag; + api->register_cb = sl_register_callback; return 0; }

14 years, 4 months

git:3.1: siptrace: print error message if trace flag is invalid

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: b349f8591c305fb64afebbb89cfdd64e06d89f8d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b349f85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 11 17:06:36 2010 +0200 siptrace: print error message if trace flag is invalid (cherry picked from commit 69092c2f26a34c398c020a1b47eba64cfb5423b8) --- modules_k/siptrace/siptrace.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/modules_k/siptrace/siptrace.c b/modules_k/siptrace/siptrace.c index 343beb6..d0d1789 100644 --- a/modules_k/siptrace/siptrace.c +++ b/modules_k/siptrace/siptrace.c @@ -254,7 +254,10 @@ static int mod_init(void) trace_local_ip.len = strlen(trace_local_ip.s); if (trace_flag<0 || trace_flag>(int)MAX_FLAG) + { + LM_ERR("invalid trace flag %d\n", trace_flag); return -1; + } trace_flag = 1<<trace_flag; /* Find a database module */

14 years, 4 months

about matrix module

by Juha Heinanen

i was searching for a module that could be used to implement lookup of a string value based on two other strings. matrix module would otherwise be ok, but i would need to have at least two matrixes. so a matrix_name column would need to be added to matrix table and matrix name argument to matrix function. also, i'm worried about the linked list implementation and would prefer a hash table based one: first look for the first index from a hash table, which would then point to the hash table of the second index. use of dialplan module is another alternative. it would require giving a numerical index to each first string value, which could then be used as dpid. second string values would then be stored in match_exp column in rows of that that dpid and the value would in attrs column. third alternative is htable module, i.e., use table_name::first_string::second_string as keyname and put string value in key_value column. in fact, that sounds like the best fit for the problem. i would be interested to learn, why matrix module was developed in the first place. why is is better suited for the job than htable module? and if there are good reasons, why matrix module is better for its intended job than htable module, is there interest in developing matrix module further along the lines i described in above? -- juha

14 years, 4 months

git:master: modules_k/rtpproxy: remove obsolete force_rtp_proxy and swap flag

by Ovidiu Sas

Module: sip-router Branch: master Commit: bf155292ef19658638892b20a5894a3c6b37db32 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bf15529… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Fri Oct 8 11:41:24 2010 -0400 modules_k/rtpproxy: remove obsolete force_rtp_proxy and swap flag --- modules_k/rtpproxy/README | 197 +++++++++++------------------ modules_k/rtpproxy/doc/rtpproxy.xml | 2 +- modules_k/rtpproxy/doc/rtpproxy_admin.xml | 101 +++------------ modules_k/rtpproxy/rtpproxy.c | 92 +------------- 4 files changed, 101 insertions(+), 291 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=bf1…

14 years, 4 months

git:master: sl: init register_cb in SL API

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: dd135dbf86d899e96fa8ecad5a6f66ca3b2ca5da URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dd135db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 11 17:05:19 2010 +0200 sl: init register_cb in SL API - used by siptrace, discovered while investigating issue reported by MÉSZÁROS Mihály --- modules/sl/sl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/sl/sl.c b/modules/sl/sl.c index 4af524b..2ca7592 100644 --- a/modules/sl/sl.c +++ b/modules/sl/sl.c @@ -362,6 +362,7 @@ static int bind_sl(sl_api_t* api) api->dreply = sl_send_reply_dlg; api->freply = send_reply; api->get_reply_totag = get_reply_totag; + api->register_cb = sl_register_callback; return 0; }

14 years, 4 months

git:master: siptrace: print error message if trace flag is invalid

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 69092c2f26a34c398c020a1b47eba64cfb5423b8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=69092c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 11 17:06:36 2010 +0200 siptrace: print error message if trace flag is invalid --- modules_k/siptrace/siptrace.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/modules_k/siptrace/siptrace.c b/modules_k/siptrace/siptrace.c index 343beb6..d0d1789 100644 --- a/modules_k/siptrace/siptrace.c +++ b/modules_k/siptrace/siptrace.c @@ -254,7 +254,10 @@ static int mod_init(void) trace_local_ip.len = strlen(trace_local_ip.s); if (trace_flag<0 || trace_flag>(int)MAX_FLAG) + { + LM_ERR("invalid trace flag %d\n", trace_flag); return -1; + } trace_flag = 1<<trace_flag; /* Find a database module */

14 years, 4 months

git:master: mqueue: free items removed because of exceeding queue size

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 115d33ede1736f7bf8dd151af5e6ca64a23433e9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=115d33e… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Mon Oct 11 15:27:37 2010 +0200 mqueue: free items removed because of exceeding queue size --- modules/mqueue/mqueue_api.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/mqueue/mqueue_api.c b/modules/mqueue/mqueue_api.c index 6007ef0..b6b72ef 100644 --- a/modules/mqueue/mqueue_api.c +++ b/modules/mqueue/mqueue_api.c @@ -343,6 +343,7 @@ int mq_item_add(str *qname, str *key, str *val) mh->ilast = NULL; else mh->ifirst->prev = NULL; + shm_free(mi); } lock_release(&mh->lock); return 0;

14 years, 4 months

git:master: mqueue: return false if queue is empty

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: e6fa8ae004f5d487e1c64471bf282931e4b9e901 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e6fa8ae… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Mon Oct 11 12:20:24 2010 +0200 mqueue: return false if queue is empty - return code -2 - reported by Alex Balashov --- modules/mqueue/README | 11 +++++++---- modules/mqueue/doc/mqueue_admin.xml | 8 ++++++-- modules/mqueue/mqueue_api.c | 22 +++++++++++++--------- modules/mqueue/mqueue_mod.c | 7 +++++-- 4 files changed, 31 insertions(+), 17 deletions(-) diff --git a/modules/mqueue/README b/modules/mqueue/README index 4c439a4..f876b2a 100644 --- a/modules/mqueue/README +++ b/modules/mqueue/README @@ -10,7 +10,7 @@ Elena-Ramona Modroiu <ramona(a)asipto.com> - Copyright � 2010 Elena-Ramona Modroiu (asipto.com) + Copyright © 2010 Elena-Ramona Modroiu (asipto.com) __________________________________________________________________ Table of Contents @@ -94,7 +94,7 @@ Chapter 1. Admin Guide Definition of memory queue - Default value is "none". + Default value is “none”. Value must be a list of parameters: attr=value;... The attribute 'name' is mandatory, defining the name of the queue. Optional attribute 'size' @@ -128,8 +128,11 @@ mq_add("myq", "$rU", "call from $fU"); 4.2. mq_fetch(queue) - Take oldest item from que and fill $mqk(queue) and $mqv(queue) pseudo - variables. Return true on success. + Take oldest item from queue and fill $mqk(queue) and $mqv(queue) pseudo + variables. + + Return: true on success (1); false on failure (-1) or no item fetched + (-2). Example 1.3. mq_fetch usage ... diff --git a/modules/mqueue/doc/mqueue_admin.xml b/modules/mqueue/doc/mqueue_admin.xml index e02ca38..d1b924a 100644 --- a/modules/mqueue/doc/mqueue_admin.xml +++ b/modules/mqueue/doc/mqueue_admin.xml @@ -118,8 +118,12 @@ mq_add("myq", "$rU", "call from $fU"); <function moreinfo="none">mq_fetch(queue)</function> </title> <para> - Take oldest item from que and fill $mqk(queue) and $mqv(queue) pseudo - variables. Return true on success. + Take oldest item from queue and fill $mqk(queue) and + $mqv(queue) pseudo variables. + </para> + <para> + Return: true on success (1); false on failure (-1) or + no item fetched (-2). </para> <example> <title><function>mq_fetch</function> usage</title> diff --git a/modules/mqueue/mqueue_api.c b/modules/mqueue/mqueue_api.c index f75f23a..6007ef0 100644 --- a/modules/mqueue/mqueue_api.c +++ b/modules/mqueue/mqueue_api.c @@ -254,17 +254,21 @@ int mq_head_fetch(str *name) return -1; lock_get(&mh->lock); - if(mh->ifirst!=NULL) + if(mh->ifirst==NULL) { - mp->item = mh->ifirst; - mh->ifirst = mh->ifirst->next; - if(mh->ifirst==NULL) { - mh->ilast = NULL; - } else { - mh->ifirst->prev = NULL; - } - mh->csize--; + /* empty queue */ + lock_release(&mh->lock); + return -2; + } + + mp->item = mh->ifirst; + mh->ifirst = mh->ifirst->next; + if(mh->ifirst==NULL) { + mh->ilast = NULL; + } else { + mh->ifirst->prev = NULL; } + mh->csize--; lock_release(&mh->lock); return 0; diff --git a/modules/mqueue/mqueue_mod.c b/modules/mqueue/mqueue_mod.c index 922f02e..5a74f58 100644 --- a/modules/mqueue/mqueue_mod.c +++ b/modules/mqueue/mqueue_mod.c @@ -109,8 +109,11 @@ static void mod_destroy(void) static int w_mq_fetch(struct sip_msg* msg, char* mq, char* str2) { - if(mq_head_fetch((str*)mq)<0) - return -1; + int ret; + + ret = mq_head_fetch((str*)mq); + if(ret<0) + return ret; return 1; }

14 years, 4 months

git:master: modules_k/userblacklist : extended userblacklist module so also alphanumerical matches are possible

by Marius Zbihlei

Module: sip-router Branch: master Commit: 2f8f8e58a922adec440d47592d1ca24dbf05f29c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2f8f8e5… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Oct 11 12:45:57 2010 +0300 modules_k/userblacklist : extended userblacklist module so also alphanumerical matches are possible Also updated doc and test. --- modules_k/userblacklist/README | 42 ++++++++++++++----- modules_k/userblacklist/db.c | 12 ++++-- .../userblacklist/doc/userblacklist_admin.xml | 25 ++++++++++++ modules_k/userblacklist/userblacklist.c | 20 +++++---- test/unit/25.sh | 14 +++++- 5 files changed, 86 insertions(+), 27 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=2f8…

14 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev