sr-dev

sr-dev@lists.kamailio.org

44307 discussions

[tracker] Task changed: warn about implicit type conversions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#93 - warn about implicit type conversions User who did this: Juha Heinanen (jh) Task Type: Bug Report -> Improvement More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=93 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

[tracker] Task opened: warn about implicit type conversions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - warn about implicit type conversions Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - add core parameter, such as "implicit_type_conversion_warnings", that, if set, causes a warning to be printed to syslog when implicit type conversion happens during script execution. useful for detecting config bugs. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=93 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

[tracker] Assignee added: warn about implicit type conversions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#93 - warn about implicit type conversions User who did this - Juha Heinanen (jh) http://sip-router.org/tracker/index.php?do=details&task_id=93 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

[tracker] Task closed: is_int() function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#92 - is_int() function User who did this - Juha Heinanen (jh) Reason for closing: Implemented More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=92 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

[tracker] User took ownership: is_int() function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Juha Heinanen has taken ownership of the following task: FS#92 - is_int() function More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=92 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

git:master: modules/utils: added is_int() function

by Juha Heinanen

Module: sip-router Branch: master Commit: c437c250b34ad052ffd9fa289e1480bdc04f8585 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c437c25… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sat Oct 16 16:42:44 2010 +0300 modules/utils: added is_int() function - added is_int() function that checks if its pvar argument contains integer value. better place would be core, but that is out of my reach. --- modules/utils/README | 52 +++++++++++++++++++++++++------------ modules/utils/doc/utils_admin.xml | 22 +++++++++++++++ modules/utils/functions.c | 18 +++++++++++++ modules/utils/functions.h | 5 +++ modules/utils/utils.c | 2 + 5 files changed, 82 insertions(+), 17 deletions(-) diff --git a/modules/utils/README b/modules/utils/README index d818238..aaf7d35 100644 --- a/modules/utils/README +++ b/modules/utils/README @@ -4,7 +4,7 @@ Juha Heinanen TutPro Inc. - Copyright � 2008 Juha Heinanen + Copyright © 2008-2009 Juha Heinanen __________________________________________________________________ Table of Contents @@ -28,6 +28,7 @@ Juha Heinanen 4.1. http_query(url, result) 4.2. xcap_auth_status(watcher_uri, presentity_uri) + 4.3. is_int(pvar) 5. MI Commands @@ -46,10 +47,11 @@ Juha Heinanen 1.4. Set xcap_table parameter 1.5. http_query() usage 1.6. xcap_auth_status() usage - 1.7. forward_list usage - 1.8. forward_switch usage - 1.9. forward_filter usage - 1.10. forward_proxy usage + 1.7. is_int() usage + 1.8. forward_list usage + 1.9. forward_switch usage + 1.10. forward_filter usage + 1.11. forward_proxy usage Chapter 1. Admin Guide @@ -72,6 +74,7 @@ Chapter 1. Admin Guide 4.1. http_query(url, result) 4.2. xcap_auth_status(watcher_uri, presentity_uri) + 4.3. is_int(pvar) 5. MI Commands @@ -98,7 +101,7 @@ Chapter 1. Admin Guide deactivated. Function xcap_auth_status can be used to check from presence server - database, if watcher is authorized to subscribe event "presence" of + database, if watcher is authorized to subscribe event “presence” of presentity. 2. Dependencies @@ -109,7 +112,7 @@ Chapter 1. Admin Guide 2.1. Kamailio Modules The following modules must be loaded before this module: - * None. + * a database module if xcap_auth_status function is enabled. 2.2. External Libraries or Applications @@ -128,7 +131,7 @@ Chapter 1. Admin Guide Defines in seconds how long Kamailio waits response from HTTP server. - Default value is "4". + Default value is null, i.e., xcap_auth_status function is disabled. Example 1.1. Set http_query_timeout parameter ... @@ -139,7 +142,7 @@ modparam("utils", "http_query_timeout", 2) Defines if the forwarding callback should be installed. - Default value is "0". + Default value is “0”. Example 1.2. Set forward_active parameter ... @@ -162,7 +165,7 @@ modparam("utils", "pres_db_url", "mysql://foo:secret@localhost/pres") Defines name of xcap table in presence server database. - Default value is "xcap". + Default value is “xcap”. Example 1.4. Set xcap_table parameter ... @@ -173,14 +176,15 @@ modparam("utils", "xcap_table", "pres_xcap") 4.1. http_query(url, result) 4.2. xcap_auth_status(watcher_uri, presentity_uri) + 4.3. is_int(pvar) 4.1. http_query(url, result) - Sends HTTP GET request according to URL given in "url" parameter, which + Sends HTTP GET request according to URL given in “url” parameter, which is a string that may contain pseudo variables. If HTTP server returns a class 2xx or 3xx reply, first line of reply's - body (if any) is stored in "result" parameter, which must be a writable + body (if any) is stored in “result” parameter, which must be a writable pseudo variable. Function returns reply code of HTTP reply or -1 if something went @@ -202,7 +206,7 @@ switch ($retcode) { 4.2. xcap_auth_status(watcher_uri, presentity_uri) Function checks from presence server database if watcher is authorized - to subscribe event "presence" of presentity. Sphere checking is not + to subscribe event “presence” of presentity. Sphere checking is not included. Both watcher_uri and presentity_uri are pseudo variables. Function @@ -225,6 +229,20 @@ if (method=="MESSAGE") { } ... +4.3. is_int(pvar) + + Function checks if pvar argument contains integer value and returns 1 + if it does and -1 otherwise. + + Function can be used from all kinds of routes. + + Example 1.7. is_int() usage +... +if (is_int("$var(foo)")) { + xlog("L_INFO", "variable foo contains integer value\n"); +} +... + 5. MI Commands 5.1. forward_list @@ -238,7 +256,7 @@ if (method=="MESSAGE") { No parameters. - Example 1.7. forward_list usage + Example 1.8. forward_list usage ... kamctl fifo forward_list id switch filter proxy @@ -251,7 +269,7 @@ id switch filter proxy The syntax of this configuration string is described in 1.6. (switch_setting_list). - Example 1.8. forward_switch usage + Example 1.9. forward_switch usage ... kamctl fifo sp_forward_switch 0=on ... @@ -270,7 +288,7 @@ kamctl fifo sp_forward_switch 0=on The syntax of this configuration string is described in 1.6. (filter_setting_list). - Example 1.9. forward_filter usage + Example 1.10. forward_filter usage ... kamctl fifo sp_forward_filter 0=REGISTER:INVITE ... @@ -283,7 +301,7 @@ kamctl fifo sp_forward_filter 0=REGISTER:INVITE switch). The syntax of this configuration string is described in 1.6. (proxy_setting_list). - Example 1.10. forward_proxy usage + Example 1.11. forward_proxy usage ... kamctl fifo sp_forward_proxy 0=host-c.domain-c:5060 ... diff --git a/modules/utils/doc/utils_admin.xml b/modules/utils/doc/utils_admin.xml index f683f51..23527d0 100644 --- a/modules/utils/doc/utils_admin.xml +++ b/modules/utils/doc/utils_admin.xml @@ -229,6 +229,28 @@ if (method=="MESSAGE") { </programlisting> </example> </section> + <section> + <title> + <function moreinfo="none">is_int(pvar)</function> + </title> + <para> + Function checks if pvar argument contains integer value + and returns 1 if it does and -1 otherwise. + </para> + <para> + Function can be used from all kinds of routes. + </para> + <example> + <title><function>is_int()</function> usage</title> + <programlisting format="linespecific"> +... +if (is_int("$var(foo)")) { + xlog("L_INFO", "variable foo contains integer value\n"); +} +... + </programlisting> + </example> + </section> </section> <section> diff --git a/modules/utils/functions.c b/modules/utils/functions.c index aadfdd5..878073a 100644 --- a/modules/utils/functions.c +++ b/modules/utils/functions.c @@ -139,3 +139,21 @@ int http_query(struct sip_msg* _m, char* _url, char* _dst) return stat; } + + +/* + * Checks if pvar argument contains int value + */ +int is_int(struct sip_msg* _m, char* _pvar, char* _s2) +{ + pv_spec_t *pvar_sp; + pv_value_t pv_val; + + pvar_sp = (pv_spec_t *)_pvar; + + if (pvar_sp && (pv_get_spec_value(_m, pvar_sp, &pv_val) == 0)) { + return (pv_val.flags & PV_VAL_INT)?1:-1; + } + + return -1; +} diff --git a/modules/utils/functions.h b/modules/utils/functions.h index 5e666f9..df34211 100644 --- a/modules/utils/functions.h +++ b/modules/utils/functions.h @@ -42,4 +42,9 @@ int http_query(struct sip_msg* _m, char* _page, char* _params, char* _dst); +/* + * Checks if pvar argument contains int value + */ +int is_int(struct sip_msg* _m, char* _pvar, char* _s2); + #endif /* UTILS_FUNCTIONS_H */ diff --git a/modules/utils/utils.c b/modules/utils/utils.c index 86f71ea..b5fa5b1 100644 --- a/modules/utils/utils.c +++ b/modules/utils/utils.c @@ -101,6 +101,8 @@ static cmd_export_t cmds[] = { REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE}, {"xcap_auth_status", (cmd_function)xcap_auth_status, 2, fixup_pvar_pvar, fixup_free_pvar_pvar, REQUEST_ROUTE}, + {"is_int", (cmd_function)is_int, 1, fixup_pvar_null, fixup_free_pvar_null, + REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE}, {0, 0, 0, 0, 0, 0} };

14 years, 3 months

call for assistance

by Meftah Tayeb

hi folk, could you join irc irc.freenode.net #switchfin to start porting SR to BF? not exactly porting but integrating if you get there we will organise a conf call hosted by me i could provide SIP and evean PSTN access thank you -- Meftah Tayeb inum: +883510001288000 mobile: +213660347746

14 years, 3 months

[tracker] Task opened: is_int() function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - is_int() function Task Type - Feature Request Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - implement is_int(arg) function that returns 1 if value of pseudo variable argument is integer and -1 if not. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=92 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 4 months

[tracker] Assignee added: is_int() function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#92 - is_int() function User who did this - Juha Heinanen (jh) http://sip-router.org/tracker/index.php?do=details&task_id=92 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 4 months

git:master: auth: minor log messages, comments and sanity fixes

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: d34a464ba0c17f2189a20a72e95b314339ea6937 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d34a464… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Oct 15 11:47:51 2010 +0200 auth: minor log messages, comments and sanity fixes - use sizeof(nc_t) when initializing a nonce count tracking entry (do not assume nc_t is char). This does not affect existing code. - removed a debugging ERR message - various minor comment fixes --- modules/auth/nc.c | 4 ++-- modules/auth/nid.h | 4 ++-- modules/auth/nonce.c | 2 -- modules/auth/nonce.h | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/modules/auth/nc.c b/modules/auth/nc.c index f2fc05c..671ef55 100644 --- a/modules/auth/nc.c +++ b/modules/auth/nc.c @@ -162,7 +162,7 @@ void destroy_nonce_count() * nc array corresponding to p. * WARNING: the result is an index in the nc_array converted to nc_t * (unsigned char by default), to get the index of the unsigned int in which - * nc is packed, call + * nc is packed, call get_nc_array_uint_idx(get_nc_array_raw_idx(i,p))). */ #define get_nc_array_raw_idx(i,p) \ (((i)&nc_partition_mask)+((p)<<nc_partition_k)) @@ -204,7 +204,7 @@ nid_t nc_new(nid_t id, unsigned char p) do{ v=atomic_get_int(&nc_array[i]); /* new_value = old_int with the corresponding byte or short zeroed*/ - new_v=v & ~(((1<<(sizeof(nc_t)*8))-1)<< (r*8)); + new_v=v & ~(((1<<(sizeof(nc_t)*8))-1)<< (r*sizeof(nc_t)*8)); }while(atomic_cmpxchg_int((int*)&nc_array[i], v, new_v)!=v); return id; } diff --git a/modules/auth/nid.h b/modules/auth/nid.h index 837372a..995f37c 100644 --- a/modules/auth/nid.h +++ b/modules/auth/nid.h @@ -47,8 +47,8 @@ extern unsigned nid_pool_no; /* number of index pools */ * array locations it should be a number prime with the array size and * bigger then the cacheline. Since this is used also for onetime nonces * => NID_INC/8 > CACHELINE - * This number also limit the maximum pool/partition size, since the - * id overlfow checks check if crt_id - nonce_id >= partition_size*NID_INC + * This number also limits the maximum pool/partition size, since the + * id overflow check checks if crt_id - nonce_id >= partition_size*NID_INC * => maximum partition size is (nid_t)(-1)/NID_INC*/ #define NID_INC 257 diff --git a/modules/auth/nonce.c b/modules/auth/nonce.c index 369a41d..72c156a 100644 --- a/modules/auth/nonce.c +++ b/modules/auth/nonce.c @@ -406,8 +406,6 @@ int check_nonce(auth_body_t* auth, str* secret1, str* secret2, auth->digest.nc.len){ if (str2int(&auth->digest.nc, &nc)!=0){ /* error, bad nc */ - ERR("FIXME:check_nonce: bad nc value %.*s\n", - auth->digest.nc.len, auth->digest.nc.s); return 5; /* invalid nc */ } switch(nc_check_val(n_id, pf & NF_POOL_NO_MASK, nc)){ diff --git a/modules/auth/nonce.h b/modules/auth/nonce.h index 5dd85bf..2201b49 100644 --- a/modules/auth/nonce.h +++ b/modules/auth/nonce.h @@ -134,7 +134,7 @@ union bin_nonce{ /* maximum nonce length in binary form (not converted to base64/hex): * expires_t | since_t | MD5(expires_t | since_t | s1) | \ - * MD5(info(auth_extra_checks, s2) => 4 + 4 + 16 + 16 = 40 bytes + * MD5(info(auth_extra_checks, s2)) => 4 + 4 + 16 + 16 = 40 bytes * or if nc_enabled: * expires_t | since_t | MD5...| MD5... | nonce_id | flag+pool_no(1 byte) * => 4 + 4 + 16 + 16 + 4 + 1 = 45 bytes

14 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev