Hello,
I am using letsencrypt cert and key and do not want to restart kamailio every 3 months to load new ones.
I know that there is: kamcmd tls.reload method but it has an error for me.
error: 500 - Error while fixing TLS configuration (consult server log)
I am checking the logs and see:
kamailio[3865480]: INFO: tls [tls_domain.c:345]: ksr_tls_fill_missing(): TLSs<default>: tls_method=3
kamailio[3865480]: INFO: tls [tls_domain.c:357]: ksr_tls_fill_missing(): TLSs<default>: certificate='/etc/kamailio/certs/my_cert.crt'
kamailio[3865480]: INFO: tls [tls_domain.c:364]: ksr_tls_fill_missing(): TLSs<default>: ca_list='(null)'
kamailio[3865480]: INFO: tls [tls_domain.c:371]: ksr_tls_fill_missing(): TLSs<default>: ca_path='(null)'
kamailio[3865480]: INFO: tls [tls_domain.c:378]: ksr_tls_fill_missing(): TLSs<default>: crl='(null)'
kamailio[3865480]: INFO: tls [tls_domain.c:382]: ksr_tls_fill_missing(): TLSs<default>: require_certificate=0
kamailio[3865480]: INFO: tls [tls_domain.c:390]: ksr_tls_fill_missing(): TLSs<default>: cipher_list='(null)'
kamailio[3865480]: INFO: tls [tls_domain.c:397]: ksr_tls_fill_missing(): TLSs<default>: private_key='/etc/kamailio/certs/private.key'
kamailio[3865480]: INFO: tls [tls_domain.c:401]: ksr_tls_fill_missing(): TLSs<default>: verify_certificate=0
kamailio[3865480]: INFO: tls [tls_domain.c:406]: ksr_tls_fill_missing(): TLSs<default>: verify_depth=9
kamailio[3865480]: INFO: tls [tls_domain.c:410]: ksr_tls_fill_missing(): TLSs<default>: verify_client=0
kamailio[3865480]: NOTICE: tls [tls_domain.c:1168]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ...
kamailio[3865480]: ERROR: tls [tls_domain.c:590]: load_cert(): TLSs<default>: Unable to load certificate file '/etc/kamailio/certs/my_cert.crt'
kamailio[3865480]: ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:03000072:digital envelope routines::decode error (sni: unknown)
kamailio[3865480]: ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:0A00018F:SSL routines::ee key too small (sni: unknown)
Any advice ?
It's interesting that there are not any TLS errors in case I restart kamailio. I can make TLS calls without problems.
deb 12.5
version: kamailio 5.7.4 (x86_64/linux)
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4033
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4033(a)github.com>
Module: kamailio
Branch: master
Commit: 8e398b8675079e1baac7c7575e70283175cdebe2
URL: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-12-09T19:04:25+01:00
lib/srdb1: new and free connection callbacks expect one parameter
- new connection is executetd with a database id and free connection
with a pool con
- compiler warnings:
src/lib/srdb1/db.c:322:23: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
322 | con = new_connection(id);
src/lib/srdb1/db.c:361:18: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
361 | free_connection(con);
---
Modified: src/lib/srdb1/db.c
Modified: src/lib/srdb1/db.h
---
Diff: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283…
Patch: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283…
---
diff --git a/src/lib/srdb1/db.c b/src/lib/srdb1/db.c
index b13d87c692b..77dea84df52 100644
--- a/src/lib/srdb1/db.c
+++ b/src/lib/srdb1/db.c
@@ -270,7 +270,7 @@ int db_bind_mod(const str *mod, db_func_t *mydbf)
* Initialize database module
* \note No function should be called before this
*/
-db1_con_t *db_do_init(const str *url, void *(*new_connection)())
+db1_con_t *db_do_init(const str *url, void *(*new_connection)(struct db_id *))
{
return db_do_init2(url, *new_connection, DB_POOLING_PERMITTED);
}
@@ -280,8 +280,8 @@ db1_con_t *db_do_init(const str *url, void *(*new_connection)())
* Initialize database module
* \note No function should be called before this
*/
-db1_con_t *db_do_init2(
- const str *url, void *(*new_connection)(), db_pooling_t pooling)
+db1_con_t *db_do_init2(const str *url, void *(*new_connection)(struct db_id *),
+ db_pooling_t pooling)
{
struct db_id *id;
void *con;
@@ -347,7 +347,7 @@ db1_con_t *db_do_init2(
* Shut down database module
* \note No function should be called after this
*/
-void db_do_close(db1_con_t *_h, void (*free_connection)())
+void db_do_close(db1_con_t *_h, void (*free_connection)(struct pool_con *))
{
struct pool_con *con;
diff --git a/src/lib/srdb1/db.h b/src/lib/srdb1/db.h
index 248647ecd07..a9538f6b9ca 100644
--- a/src/lib/srdb1/db.h
+++ b/src/lib/srdb1/db.h
@@ -48,6 +48,8 @@
#include "db_cap.h"
#include "db_con.h"
#include "db_row.h"
+#include "db_id.h"
+#include "db_pool.h"
#include "db_pooling.h"
#include "db_locking.h"
@@ -464,7 +466,7 @@ int db_bind_mod(const str *mod, db_func_t *dbf);
* \return returns a pointer to the db1_con_t representing the connection if it was
successful, otherwise 0 is returned.
*/
-db1_con_t *db_do_init(const str *url, void *(*new_connection)());
+db1_con_t *db_do_init(const str *url, void *(*new_connection)(struct db_id *));
/**
@@ -478,8 +480,8 @@ db1_con_t *db_do_init(const str *url, void *(*new_connection)());
* \return returns a pointer to the db1_con_t representing the connection if it was
successful, otherwise 0 is returned.
*/
-db1_con_t *db_do_init2(
- const str *url, void *(*new_connection)(), db_pooling_t pooling);
+db1_con_t *db_do_init2(const str *url, void *(*new_connection)(struct db_id *),
+ db_pooling_t pooling);
/**
@@ -490,7 +492,7 @@ db1_con_t *db_do_init2(
* \param _h database connection handle
* \param (*free_connection) Pointer to the db specific free_connection method
*/
-void db_do_close(db1_con_t *_h, void (*free_connection)());
+void db_do_close(db1_con_t *_h, void (*free_connection)(struct pool_con *));
/**
Hello,
we should consider an online devel meeting sometime soon to summarize
what was done at (and still needs to be done after) devel meeting in
Dusseldorf and plan a bit the targets for next major release 6.0.
If considered useful, I propose Dec 9, 2024 (Monday) at 15:00UTC (16:00
Berlin/Paris/Madrid/Rome), but we can also look for other dates as well.
Topics to be discussed can be added at:
-
https://github.com/kamailio/kamailio-wiki/blob/main/docs/devel/irc-meetings…
Pull requests can be made by users without git access.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Python's C interface contract states that C code must *either* raise an exception and return NULL, *or* return a Python object.
Doing both will raise a `SystemError` exception which obscures the original problem. It may also cause a memory leak.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4044
-- Commit Summary --
* app_python3: fix exception handling
-- File Changes --
M src/modules/app_python3/apy_kemi.c (4)
M src/modules/app_python3s/apy3s_kemi.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4044.patchhttps://github.com/kamailio/kamailio/pull/4044.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4044
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4044(a)github.com>
Module: kamailio
Branch: master
Commit: ba0c570ca95bff06c8ce04779371567d88a4e9f8
URL: https://github.com/kamailio/kamailio/commit/ba0c570ca95bff06c8ce04779371567…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-12-09T09:46:10+01:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/ba0c570ca95bff06c8ce04779371567…
Patch: https://github.com/kamailio/kamailio/commit/ba0c570ca95bff06c8ce04779371567…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 06ee1beb53b..12a030cc19d 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1294,16 +1294,17 @@ Note
See also: t_set_fr(), fr_timer.
- In Kamailio compatibility mode (defined by #!KAMAILIO), the value of
- the parameter must be the name of an AVP in pseudo-variable format:
- $avp(name). In SER compatibility mode it must be just AVP name.
+ In Kamailio compatibility mode (defined by #!KAMAILIO, which is
+ default), the value of the parameter must be the name of an AVP in
+ pseudo-variable format: $avp(name). In SER compatibility mode (defined
+ by #!SER) it must be just AVP name.
Example 1.28. Set fr_timer_avp parameter
...
-# Kamailio mode
-modparam("tm", "fr_timer_avp", "$avp(i:708)")
-# Old SER mode
-modparam("tm", "fr_timer_avp", "i:708")
+# default Kamailio compatibility mode
+modparam("tm", "fr_timer_avp", "$avp(frtimer)")
+# old SER compatibility mode
+modparam("tm", "fr_timer_avp", "frtimer")
...
3.28. fr_inv_timer_avp (string)
@@ -1328,15 +1329,16 @@ Note
See also: t_set_fr(), fr_inv_timer.
- In Kamailio compatibility mode (defined by #!KAMAILIO), the value of
- the parameter must be the name of an AVP in pseudo-variable format:
- $avp(name). In SER compatibility mode it must by just AVP name.
+ In Kamailio compatibility mode (defined by #!KAMAILIO, which is
+ default), the value of the parameter must be the name of an AVP in
+ pseudo-variable format: $avp(name). In SER compatibility mode (defined
+ by #!SER) it must by just AVP name.
Example 1.29. Set fr_inv_timer_avp parameter
...
-# Kamailio mode
+# Kamailio compatibility mode
modparam("tm", "fr_inv_timer_avp", "$avp(my_fr_inv_timer)")
-# Old SER mode
+# old SER compatibility mode
modparam("tm", "fr_inv_timer_avp", "my_fr_inv_timer")
...