sr-dev

sr-dev@lists.kamailio.org

4 participants
44158 discussions

git:master:21bdc234: cmake: Fix double $ typo. Fixes building with ninja

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 21bdc234e219db83e085b055d4f81cb3ff63193d URL: https://github.com/kamailio/kamailio/commit/21bdc234e219db83e085b055d4f81cb… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2024-12-12T11:20:35Z cmake: Fix double $ typo. Fixes building with ninja --- Modified: utils/kamctl/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/21bdc234e219db83e085b055d4f81cb… Patch: https://github.com/kamailio/kamailio/commit/21bdc234e219db83e085b055d4f81cb… --- diff --git a/utils/kamctl/CMakeLists.txt b/utils/kamctl/CMakeLists.txt index a927c1ee627..e651bb88c8b 100644 --- a/utils/kamctl/CMakeLists.txt +++ b/utils/kamctl/CMakeLists.txt @@ -11,7 +11,7 @@ message(STATUS "Temporary kamctl.{db} files in : ${KAMCTL_TMP_DIR}") file(MAKE_DIRECTORY ${KAMCTL_TMP_DIR}) set(BIN_DIR "${CMAKE_INSTALL_FULL_SBINDIR}") -set(LIB_DIR "$${CMAKE_INSTALL_FULL_LIBDIR}/${MAIN_NAME}/kamctl") +set(LIB_DIR "${CMAKE_INSTALL_FULL_LIBDIR}/${MAIN_NAME}/kamctl") set(CFG_DIR "${CMAKE_INSTALL_FULL_SYSCONFDIR}/${MAIN_NAME}") set(SHARE_DIR "${CMAKE_INSTALL_FULL_DATADIR}/${MAIN_NAME}")

3 weeks, 3 days

git:master:170ddcca: cmake: Add option to not use git to gather commit info

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 170ddcca96b3ee11f4daed1592f0cee9c753db2b URL: https://github.com/kamailio/kamailio/commit/170ddcca96b3ee11f4daed1592f0cee… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2024-12-12T11:19:48Z cmake: Add option to not use git to gather commit info --- Modified: src/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/170ddcca96b3ee11f4daed1592f0cee… Patch: https://github.com/kamailio/kamailio/commit/170ddcca96b3ee11f4daed1592f0cee… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 30f80f0db32..2b02f33098f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -24,9 +24,13 @@ include(${CMAKE_SOURCE_DIR}/cmake/defs.cmake) # ----------------------- # The following produces core/autover.h Find Git +option(USE_GIT "Use git to get commit information" ON) find_package(Git QUIET) -if(GIT_FOUND AND EXISTS "${PROJECT_SOURCE_DIR}/.git") +if(USE_GIT + AND GIT_FOUND + AND EXISTS "${PROJECT_SOURCE_DIR}/.git" +) execute_process( COMMAND ${GIT_EXECUTABLE} rev-parse --verify --short=6 HEAD WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}

3 weeks, 3 days

git:master:ac74fd01: cmake: Generete parser files in build folder

by Xenofon Karamanos

Module: kamailio Branch: master Commit: ac74fd01fade29b433eb45966a0ed5e222614318 URL: https://github.com/kamailio/kamailio/commit/ac74fd01fade29b433eb45966a0ed5e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2024-12-12T11:19:48Z cmake: Generete parser files in build folder --- Modified: src/CMakeLists.txt Modified: src/core/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/ac74fd01fade29b433eb45966a0ed5e… Patch: https://github.com/kamailio/kamailio/commit/ac74fd01fade29b433eb45966a0ed5e… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 867f7508f26..30f80f0db32 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -70,8 +70,9 @@ if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.20) cmake_policy(SET CMP0118 NEW) else() set_source_files_properties( - ${CMAKE_SOURCE_DIR}/src/core/lex.yy.c ${CMAKE_SOURCE_DIR}/src/core/cfg.tab.c - ${CMAKE_SOURCE_DIR}/src/core/cfg.tab.h PROPERTIES GENERATED TRUE + ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c + ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c + ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.h PROPERTIES GENERATED TRUE ) endif() # ----------------------- @@ -98,9 +99,11 @@ add_subdirectory(modules) # from their own CMakeLists.txt # Module subdiretory does not contribute to the Kamailio executable. target_sources( - kamailio PRIVATE ${kamailio_SRC_FILES} ${CMAKE_SOURCE_DIR}/src/core/lex.yy.c - ${CMAKE_SOURCE_DIR}/src/core/cfg.tab.c + kamailio + PRIVATE ${kamailio_SRC_FILES} ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c + ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c ) +target_include_directories(kamailio PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/core) # Debuggng the sources of kamailio executable. # get_property( diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index e72cca6fa61..cbda772884a 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -20,19 +20,19 @@ find_package(BISON REQUIRED) # Generate lex.yy.c from cfg.lex add_custom_command( - OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/lex.yy.c - COMMAND ${FLEX_EXECUTABLE} -o ${CMAKE_CURRENT_SOURCE_DIR}/lex.yy.c + OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lex.yy.c + COMMAND ${FLEX_EXECUTABLE} -o ${CMAKE_CURRENT_BINARY_DIR}/lex.yy.c ${CMAKE_CURRENT_SOURCE_DIR}/cfg.lex DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/cfg.lex - ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.h + ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.h COMMENT "Generating lex.yy.c from cfg.lex" ) # Generate cfg.tab.c and cfg.tab.h from cfg.y add_custom_command( - OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.c - ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.h - COMMAND ${BISON_EXECUTABLE} -d -b cfg -o ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.c + OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.c + ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.h + COMMAND ${BISON_EXECUTABLE} -d -b cfg -o ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.c ${CMAKE_CURRENT_SOURCE_DIR}/cfg.y DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/cfg.y COMMENT "Generating cfg.tab.c and cfg.tab.h from cfg.y" @@ -41,9 +41,9 @@ add_custom_command( # Add custom target for generating the 3 source files mentioned above add_custom_target( GenerateParser ALL - DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/lex.yy.c - ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.c - ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.h + DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/lex.yy.c + ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.c + ${CMAKE_CURRENT_BINARY_DIR}/cfg.tab.h COMMENT "Generating parser source files" )

3 weeks, 3 days

git:master:a557b186: pre-commit: cmake-format and cmake-lint hooks [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: a557b186fed55d6a0fdba78f0e59a634df569ff9 URL: https://github.com/kamailio/kamailio/commit/a557b186fed55d6a0fdba78f0e59a63… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-12-12T11:21:16+01:00 pre-commit: cmake-format and cmake-lint hooks [skip ci] --- Modified: .pre-commit-config.yaml --- Diff: https://github.com/kamailio/kamailio/commit/a557b186fed55d6a0fdba78f0e59a63… Patch: https://github.com/kamailio/kamailio/commit/a557b186fed55d6a0fdba78f0e59a63… --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7e8b8a8860a..7892175df39 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -11,4 +11,9 @@ repos: - repo: https://github.com/pre-commit/mirrors-clang-format rev: v15.0.7 hooks: - - id: clang-format + - id: clang-format + - repo: https://github.com/cheshirekow/cmake-format-precommit + rev: v0.6.13 + hooks: + - id: cmake-format + - id: cmake-lint

3 weeks, 3 days

[kamailio/kamailio] dispatcher module usage on kamailio 5.8.4 generate kamailio crash (Issue #4061)

by pgravet

### Description kamailio crash with signal 6 ### Troubleshooting #### Reproduction After each couple of dispatcher ping interval. #### Debugging Data No core dump file. #### Log Messages Dec 6 17:47:24 frnappcoe3router2 /usr/sbin/kamailio[1618]: INFO: ctl [io_listener.c:211]: io_listen_loop(): using epoll_lt as the io watch method (auto detected) Dec 6 17:47:34 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:frnappcoe3sfl05.orange-voicemail.net:5060> Dec 6 17:47:34 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:cs1-tool-misc.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:frnappcoe3sfl05.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:cs1-tool-misc.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1608]: CRITICAL: <core> [core/mem/q_malloc.c:555]: qm_free(): BUG: freeing already freed pointer (0x7f178fa8a700), called from core: core/xavp.c: xavp_free(81), first free core: core/xavp.c: xavp_new_value(117) - ignoring Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1608]: CRITICAL: <core> [core/mem/q_malloc.c:136]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f178fa8a560 (address 0x7f178fa8a5a0) end overwritten (0, f00000000000)! Memory allocator was called from core: core/xavp.c:81. Fragment marked by (null):2882400237. Exec from core/mem/q_malloc.c:546. Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: ALERT: <core> [main.c:805]: handle_sigs(): child process 1608 exited by a signal 6 Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: ALERT: <core> [main.c:809]: handle_sigs(): core was not generated Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: INFO: <core> [main.c:832]: handle_sigs(): terminating due to SIGCHLD #### SIP Traffic ### Possible Solutions ### Additional Information [root@frnappcoe3router2 ~]# kamailio -v version: kamailio 5.8.4 (x86_64/linux) f1d83d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f1d83d compiled on 13:59:57 Nov 12 2024 with gcc 8.5.0 kamailio.cfg loadmodule "dispatcher.so" modparam("dispatcher", "list_file", DISPATCHER_FILE) modparam("dispatcher", "ds_probing_mode", 1) modparam("dispatcher", "ds_probing_threshold",3) modparam("dispatcher", "flags", 3) modparam("dispatcher", "ds_ping_from", "sip:siprouter@unisys.com") modparam("dispatcher", "xavp_dst", "_dsdst_") modparam("dispatcher", "xavp_ctx", "_dsctx_") modparam("dispatcher", "ds_hash_size", 8) modparam("dispatcher", "ds_ping_interval", 10) modparam("dispatcher", "ds_ping_reply_codes", "class=2;class=3") * **Operating System**: RHEL8.8 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4061 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4061(a)github.com>

3 weeks, 3 days

git:master:f385148f: core: use one strlen for mod_path

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f385148ff68e2125a2111d9c506022519f17d1c9 URL: https://github.com/kamailio/kamailio/commit/f385148ff68e2125a2111d9c5060225… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-12T10:22:27+01:00 core: use one strlen for mod_path --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/f385148ff68e2125a2111d9c5060225… Patch: https://github.com/kamailio/kamailio/commit/f385148ff68e2125a2111d9c5060225… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 6d50f294389..f19a2d3812b 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -410,12 +410,14 @@ int ksr_locate_module(char *mod_path, char **new_path) int mdir_len; int path_type; int len; + int mod_path_len; *new_path = NULL; + mod_path_len = strlen(mod_path); path = mod_path; path_type = 0; modfile.s = path; - modfile.len = strlen(mod_path); + modfile.len = mod_path_len; modname.s = modfile.s; if(modfile.len > 3 && strcmp(modfile.s + modfile.len - 3, ".so") == 0) { path_type = 1; @@ -502,7 +504,7 @@ int ksr_locate_module(char *mod_path, char **new_path) if(path == 0) { /* try path <MODS_DIR>/mod_path - K compat */ path = (char *)pkg_malloc( - mdir_len + 1 /* "/" */ + strlen(mod_path) + 1); + mdir_len + 1 /* "/" */ + mod_path_len + 1); if(path == 0) { PKG_MEM_ERROR; goto error; @@ -513,8 +515,8 @@ int ksr_locate_module(char *mod_path, char **new_path) path[len] = '/'; len++; } - path[len] = 0; - strcat(path, mod_path); + memcpy(path + len, mod_path, mod_path_len); + path[len + mod_path_len] = 0; if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path);

3 weeks, 3 days

[kamailio/kamailio] segfault on t_next_contacts after adding additional contacts to $xavp(tm_contacts) (Issue #4063)

by Benoît Panizzon

### Description Goal: Build a destination set from multiple contacts gathered from multiple registered AoR. Situation: assumptions, observations: * lookup() returns success there are registered contacts for each AoR. * All contacts have same q value. * lookup() can only be called for one AoR, there is no way to call it for multiple AoR. * If lookup() is called multiple times, only the destination set gathered by the last invocation is preserved, all other ones are overwritten. * t_load_contacts() transfers the destination set into the $xavp(tm_contacts) but like lookup() initializes that So I am trying to find a way to store/collate all destination sets into one and parallel fork a call to all contacts from multiple AoR. Idea: Stack all contacts in $xavp(contact_stack) with the same structure as $xavp(tm_contacts) and append it to tm_contacts. xavp_rm("contact_stack"); # Make sure this is not defined. We are in a loop setting $var(lookupuri) to (sip:315996608@3cx-pbx.imp.ch and sip:315996608-1@157.161.4.181) { lookup("location", "$var(lookupuri)"); t_load_contacts(0); # Now $xavp(tm_contacts) is populated $xavp(contact_stack) = $xavp(tm_contacts); # Store contact set } xavp_rm("tm_contacts"); # Re Initialize tm_contacts to empty $xavp(tm_contacts) = $xavp(contact_stack); # Restore tm_contacts from stacked set. xlog("L_INFO", "$cfg(route): COUNT: $cnt($xavp(tm_contacts))\n"); # Make sure, the count matches what we expect. xlog("L_INFO", "$cfg(route): Before t_next_contacts\n"); t_next_contacts(); # Load destination set => CRASH! xlog("L_INFO", "$cfg(route): After t_next_contacts\n"); Log (some more infos logged I omitted in the example above) ``` Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Auth_aor_user[0] = 315996608 Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Sigprofile[0] = local Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Lookupuri[0] = sip:315996608@3cx-pbx.imp.ch Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: LOOKUP sip:315996608@3cx-pbx.imp.ch SUCCESS!!!! Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Auth_aor_user[1] = 315996608-1 Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Sigprofile[1] = local Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Lookupuri[1] = sip:315996608-1@157.161.4.181 Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: LOOKUP sip:315996608-1@157.161.4.181 SUCCESS!!!! Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: ADD to tm_contacts Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: COUNT: 4 Dec 10 16:18:05 dev-cpereg01 kamailio[3964710]: INFO: [1 0618269314 128182546-3942836285-478214563(a)prt-cbl-sbc1.imp.ch 2 INVITE]<script>: LOCATION: Before t_next_contacts Dec 10 16:18:05 dev-cpereg01 kernel: [13747450.274883] traps: kamailio[3964710] general protection fault ip:55bc00e61f2b sp:7ffce62d7520 error:0 in kamailio[55bc00ba5000+457000] ``` #### Reproduction Code above with: version: kamailio 5.7.6 (x86_64/linux) from official kamailio repository on ubuntu jammy. #### Debugging Data If required, I can try to enable coredumps. #### Log Messages Shown above #### SIP Traffic Probably not needed. ### Possible Solutions None yet. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4063 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4063(a)github.com>

3 weeks, 3 days

git:master:3eb9e1d3: tm: check the type of contacts xavp value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3eb9e1d34988ebeba9d4526da8f4d804846a7316 URL: https://github.com/kamailio/kamailio/commit/3eb9e1d34988ebeba9d4526da8f4d80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-12T09:18:17+01:00 tm: check the type of contacts xavp value - GH #4063 --- Modified: src/modules/tm/t_serial.c --- Diff: https://github.com/kamailio/kamailio/commit/3eb9e1d34988ebeba9d4526da8f4d80… Patch: https://github.com/kamailio/kamailio/commit/3eb9e1d34988ebeba9d4526da8f4d80… --- diff --git a/src/modules/tm/t_serial.c b/src/modules/tm/t_serial.c index 4697455413b..7566f2b4ac6 100644 --- a/src/modules/tm/t_serial.c +++ b/src/modules/tm/t_serial.c @@ -643,6 +643,11 @@ int ki_t_next_contacts(struct sip_msg *msg) LM_DBG("no contacts in contacts_avp - we are done!\n"); return -2; } + if(xavp_list->val.type != SR_XTYPE_XAVP) { + LM_ERR("invalid value type (%d) for contacts xavp\n", + xavp_list->val.type); + return -3; + } xavp = xavp_list;

3 weeks, 3 days

[kamailio/kamailio] The future of internal libraries (Issue #4041)

by Daniel-Constantin Mierla

Considering that it hasn't been much activity around the internal libraries for long time, I was wondering if it still makes sense to keep them like they are or merge them in the core. Recently, during the devel meeting, I relocated a couple of them to the archive. The `lib/binrpc` (and `print`) can have the same fate, being not actually used. The srdb1 is very common and I guess it is very rare the case when a deployment is used without a module not depending on it (e.g., even if dispatcher is used with a list file, the code is still linked to this library). The `trie` library is small and `ims` is actually a set of getter functions for message attribtues/headers. The `srdb2` is not used much, but I think the right approach for it is to change the modules using it to `libsrdb1` and get rid of it completely sometime in the future. Till then the code is not big and can reside as part of the core. The benefits I see are in simplifying the build system (current makefiles and hopefully soon-to-be-merged the one based on cmake), reducing also the time to compute compile and link dependencies; getting rid of packaging complexity (same library may be needed by different modules, which, when packaged separately, the library has to be in a 3rd package, or have dependency of the other module's package -- probably now the libs are shipped with the core package). The code for libs can stay at the same location, so source code for modules doesn't need to be updated, just that they are compiled with the core, removing internal libs from makefiles. Thinking that we go for 6.0.x, clarifying the plans for this component and cleaning it, if decided so, should fit well in such version number jump. Opinions? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4041 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4041(a)github.com>

3 weeks, 3 days

[kamailio/kamailio] fedora 40: make[2]: --libs8: No such file or directory (Issue #4025)

by sergey-safarov

### Description During source compilation on Fedora 40 I see an error ``` [2024-11-15T10:13:57.497Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb2' [2024-11-15T10:13:57.502Z] make[3]: 'libsrdb2.so.1.0' is up to date. [2024-11-15T10:13:57.502Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb2' [2024-11-15T10:13:57.504Z] LD (gcc) [M uid_uri_db.so] uid_uri_db.so [2024-11-15T10:13:57.535Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:57.569Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:57.590Z] CC (gcc) [M dialplan.so] dialplan.o [2024-11-15T10:13:58.005Z] CC (gcc) [M dialplan.so] dp_db.o [2024-11-15T10:13:58.331Z] CC (gcc) [M dialplan.so] dp_repl.o [2024-11-15T10:13:58.742Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:13:58.748Z] make[3]: 'libsrdb1.so.1.0' is up to date. [2024-11-15T10:13:58.748Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:13:58.749Z] LD (gcc) [M dialplan.so] dialplan.so [2024-11-15T10:13:58.776Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:58.808Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:58.837Z] CC (gcc) [M lcr.so] hash.o [2024-11-15T10:13:58.984Z] CC (gcc) [M lcr.so] lcr_mod.o [2024-11-15T10:14:00.389Z] CC (gcc) [M lcr.so] lcr_rpc.o [2024-11-15T10:14:00.518Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:14:00.528Z] make[3]: 'libsrdb1.so.1.0' is up to date. [2024-11-15T10:14:00.528Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:14:00.529Z] LD (gcc) [M lcr.so] lcr.so [2024-11-15T10:14:00.564Z] make[2]: --libs8: No such file or directory [2024-11-15T10:14:00.592Z] make[2]: --libs8: No such file or directory [2024-11-15T10:14:00.623Z] CC (gcc) [M regex.so] regex_mod.o [2024-11-15T10:14:00.952Z] LD (gcc) [M regex.so] regex.so [2024-11-15T10:14:00.997Z] CC (gcc) [M app_jsdt.so] app_jsdt_api.o [2024-11-15T10:14:01.437Z] CC (gcc) [M app_jsdt.so] app_jsdt_kemi_export.o [2024-11-15T10:14:02.089Z] CC (gcc) [M app_jsdt.so] app_jsdt_mod.o [2024-11-15T10:14:02.389Z] CC (gcc) [M app_jsdt.so] duk_module_node.o [2024-11-15T10:14:02.470Z] CC (gcc) [M app_jsdt.so] duktape.o ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4025 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4025(a)github.com>

3 weeks, 3 days

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev