sr-dev

sr-dev@lists.kamailio.org

13 participants
44206 discussions

by ale5kamailio

test posting issue -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3918 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3918(a)github.com>

6 months

git:master:f2a7a3c0: dispatcher: remove unnecessary comparisons for unsigned

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 URL: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 dispatcher: remove unnecessary comparisons for unsigned --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Patch: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index ecd0f3a0c9d..d36141bbafd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -408,13 +408,13 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) str2int(&pit->body, &dest->attrs.ocrate); } } - if(dest->attrs.ocmax < 0 || dest->attrs.ocmax > 100) { + if(dest->attrs.ocmax > 100) { dest->attrs.ocmax = 100; } - if(dest->attrs.ocmin < 0 || dest->attrs.ocmin > 100) { + if(dest->attrs.ocmin > 100) { dest->attrs.ocmin = 0; } - if(dest->attrs.ocrate <= 0 || dest->attrs.ocrate > 100) { + if(dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; } if(dest->attrs.ocrate < dest->attrs.ocmin) {

6 months

git:master:d5076b55: evrexec: remove unnecessary safety exit loop

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d5076b557728b3f9d80df391ae71e2eab2c896dc URL: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 evrexec: remove unnecessary safety exit loop --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Patch: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 3fb99535a0a..7df75654aa0 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -325,10 +325,6 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) } memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } - /* avoid exiting the process */ - while(1) { - sleep(3600); - } } /**

6 months

git:master:f92fe42d: nghttp2: free the addr info on listen failure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f92fe42dc6c8d3d5b79cf6543b387501a41c09b3 URL: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-15T08:24:59+02:00 nghttp2: free the addr info on listen failure --- Modified: src/modules/nghttp2/nghttp2_server.c --- Diff: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Patch: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… --- diff --git a/src/modules/nghttp2/nghttp2_server.c b/src/modules/nghttp2/nghttp2_server.c index 6f5faf02ad6..ba0290bc4ac 100644 --- a/src/modules/nghttp2/nghttp2_server.c +++ b/src/modules/nghttp2/nghttp2_server.c @@ -793,11 +793,11 @@ static void start_listen(struct event_base *evbase, app_context *app_ctx) (int)rp->ai_addrlen); if(listener) { freeaddrinfo(res); - return; } } LM_ERR("Could not start listener"); + freeaddrinfo(res); } static void initialize_app_context(

6 months

[kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Diameter requests could contain Application-Ids in multiple AVPs. This fix iterates through them, instead of giving up if the first one does not match. This solves some issues when peers don't always declare support for vendor-specific/non-specific application ids, so routing should be easier. Also fixed: - auth state machine being too verbose on regular messages being received or sent while in the Open state - add Destination-Host from auth state to requests (next-hop immediate routing) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3914 -- Commit Summary -- * cdp: improved routing and removed useless warning/errors in authstatemachine -- File Changes -- M src/modules/cdp/authstatemachine.c (42) M src/modules/cdp/routing.c (176) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3914.patch https://github.com/kamailio/kamailio/pull/3914.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3914(a)github.com>

6 months

git:master:0da3eb3f: cdp: improved routing and removed useless warning/errors in authstatemachine

by Dragos Vingarzan

Module: kamailio Branch: master Commit: 0da3eb3f94c087b272ebbe19c42fd933146482f8 URL: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-14T11:46:17+02:00 cdp: improved routing and removed useless warning/errors in authstatemachine --- Modified: src/modules/cdp/authstatemachine.c Modified: src/modules/cdp/routing.c --- Diff: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Patch: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93…

6 months

[kamailio/kamailio] Outdated OpenSIPS Sources in Kamailio Project Lack Security Fixes (CVE-2023-28098) (Issue #3911)

by Garnik Khroyan

### Description The master branch of the Kamailio project contains unpatched sources from OpenSIPS, in which [CVE-2023-28098](https://github.com/OpenSIPS/opensips/security/advisories/GH… was reported. The function `parse_param_name()` from `kamailio/src/core/parser/digest/param_parser.c` does not include security patches and updates available in newer versions of OpenSIPS. The fix for CVE can be found in this commit: [OpenSIPS Commit dd9141b6](https://github.com/OpenSIPS/opensips/commit/dd9141b6f67d7df4072f3… ### Possible Solutions I strongly recommend updating the sources from OpenSIPS to the latest version available. ### Report Origin The bug is detected by a tool developed at [CAST](https://castech.am/). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3911(a)github.com>

6 months

[kamailio/kamailio] lib/ims: added cscf_get_host_from_requri (PR #3912)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  On Mobile-Terminating, if the P-Called-Party-ID header is missing, getting the host (should also be an IP) from the Request-URI can help the P-CSCF when doing AAR for QoS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3912 -- Commit Summary -- * lib/ims: added cscf_get_host_from_requri -- File Changes -- M src/lib/ims/ims_getters.c (15) M src/lib/ims/ims_getters.h (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3912.patch https://github.com/kamailio/kamailio/pull/3912.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3912 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3912(a)github.com>

6 months

git:master:70fd2717: lib/ims: added cscf_get_host_from_requri

by Dragos Vingarzan

Module: kamailio Branch: master Commit: 70fd27174952fe6a67f01fca4fdc941b9fdc045a URL: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-12T13:27:21+02:00 lib/ims: added cscf_get_host_from_requri --- Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h --- Diff: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Patch: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index cf2f618d0de..35dbdca405f 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -539,6 +539,21 @@ str cscf_get_contact_from_requri(struct sip_msg *msg) return pu; } +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg) +{ + if(msg->first_line.type != SIP_REQUEST || parse_sip_msg_uri(msg) < 0 + || msg->parsed_uri.type == TEL_URI_T) { + str empty = {0}; + return empty; + } + return msg->parsed_uri.host; +} + + /** * Finds if the message contains the orig parameter in the first Route header * @param msg - the SIP message diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 77a55a6695b..03ad4bef82b 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -206,6 +206,12 @@ str cscf_get_public_identity_from_requri(struct sip_msg *msg); */ str cscf_get_contact_from_requri(struct sip_msg *msg); +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg); + /** * Looks for the Call-ID header * @param msg - the sip message

6 months

git:master:fc8bee5b: pua: use long for time value diff operation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fc8bee5b87e95e43bda2635e65457b2025eab6f9 URL: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T12:05:40+02:00 pua: use long for time value diff operation --- Modified: src/modules/pua/pua.c --- Diff: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Patch: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… --- diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index e57183427f3..a53bfd83963 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -1121,9 +1121,10 @@ static ua_pres_t *build_uppubl_cbparam(ua_pres_t *p) publ.pres_uri = p->pres_uri; publ.content_type = p->content_type; publ.id = p->id; - publ.expires = (p->desired_expires == 0) - ? -1 - : p->desired_expires - (int)time(NULL); + publ.expires = + (int)((p->desired_expires == 0) + ? -1 + : ((long)p->desired_expires - (long)time(NULL))); publ.flag = UPDATE_TYPE; publ.source_flag = p->flag; publ.event = p->event;

6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev