- sr-dev - kamailio.org

git:master:d104324e: kafka: add modparam metadata_timeout
by Daniel-Constantin Mierla 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: d104324ec86190d8ce0886f11fea9b131f46a877 URL: https://github.com/kamailio/kamailio/commit/d104324ec86190d8ce0886f11fea9b1… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T10:01:10+02:00 kafka: add modparam metadata_timeout --- Modified: src/modules/kafka/kafka_mod.c Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/d104324ec86190d8ce0886f11fea9b1… Patch: https://github.com/kamailio/kamailio/commit/d104324ec86190d8ce0886f11fea9b1… --- diff --git a/src/modules/kafka/kafka_mod.c b/src/modules/kafka/kafka_mod.c index 89f3fcd3c42..43504c7b7cc 100644 --- a/src/modules/kafka/kafka_mod.c +++ b/src/modules/kafka/kafka_mod.c @@ -67,6 +67,7 @@ static int w_kafka_send_key( int child_init_ok = 0; int init_without_kafka = 0; int log_without_overflow = 0; +int metadata_timeout = 2000; char *brokers_param = NULL; /**< List of brokers. */ static int kafka_conf_param(modparam_t type, void *val); static int kafka_topic_param(modparam_t type, void *val); @@ -88,7 +89,8 @@ static param_export_t params[] = {{"brokers", PARAM_STRING, &brokers_param}, (void *)kafka_conf_param}, {"topic", PARAM_STRING | USE_FUNC_PARAM, (void *)kafka_topic_param}, {"init_without_kafka", PARAM_INT, &init_without_kafka}, - {"log_without_overflow", PARAM_INT, &log_without_overflow}, {0, 0, 0}}; + {"log_without_overflow", PARAM_INT, &log_without_overflow}, + {"metadata_timeout", PARAM_INT, &metadata_timeout}, {0, 0, 0}}; /** * \brief Kafka :: Module interface diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index 68014b8b4fb..ed406385e5e 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -39,6 +39,7 @@ extern int child_init_ok; extern int init_without_kafka; extern int log_without_overflow; +extern int metadata_timeout; /** * \brief data type for a configuration property. @@ -730,11 +731,6 @@ static int kfk_topic_list_configure() return 0; } -/* -1 means RD_POLL_INFINITE */ -/* 100000 means 100 seconds */ -#define METADATA_TIMEOUT \ - 100000 /**< Timeout when asking for metadata in milliseconds. */ - /** * \brief check that a topic exists in cluster. * @@ -756,7 +752,7 @@ static int kfk_topic_exist(str *topic_name) /* Get metadata for all topics. */ rd_kafka_resp_err_t res; - res = rd_kafka_metadata(rk, 1, NULL, &metadatap, METADATA_TIMEOUT); + res = rd_kafka_metadata(rk, 1, NULL, &metadatap, metadata_timeout); if(res != RD_KAFKA_RESP_ERR_NO_ERROR) { LM_ERR("Failed to get metadata: %s\n", rd_kafka_err2str(res)); goto error;

1 0

git:master:a544b14e: kafka: add modparam log_without_overflow
by Daniel-Constantin Mierla 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: a544b14e0bdc331820a505517a52477879734e7c URL: https://github.com/kamailio/kamailio/commit/a544b14e0bdc331820a505517a52477… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T10:01:10+02:00 kafka: add modparam log_without_overflow --- Modified: src/modules/kafka/kafka_mod.c Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/a544b14e0bdc331820a505517a52477… Patch: https://github.com/kamailio/kamailio/commit/a544b14e0bdc331820a505517a52477… --- diff --git a/src/modules/kafka/kafka_mod.c b/src/modules/kafka/kafka_mod.c index e88bd37384b..89f3fcd3c42 100644 --- a/src/modules/kafka/kafka_mod.c +++ b/src/modules/kafka/kafka_mod.c @@ -66,6 +66,7 @@ static int w_kafka_send_key( */ int child_init_ok = 0; int init_without_kafka = 0; +int log_without_overflow = 0; char *brokers_param = NULL; /**< List of brokers. */ static int kafka_conf_param(modparam_t type, void *val); static int kafka_topic_param(modparam_t type, void *val); @@ -86,7 +87,8 @@ static param_export_t params[] = {{"brokers", PARAM_STRING, &brokers_param}, {"configuration", PARAM_STRING | USE_FUNC_PARAM, (void *)kafka_conf_param}, {"topic", PARAM_STRING | USE_FUNC_PARAM, (void *)kafka_topic_param}, - {"init_without_kafka", PARAM_INT, &init_without_kafka}, {0, 0, 0}}; + {"init_without_kafka", PARAM_INT, &init_without_kafka}, + {"log_without_overflow", PARAM_INT, &log_without_overflow}, {0, 0, 0}}; /** * \brief Kafka :: Module interface diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index 76a5fea75d9..68014b8b4fb 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -38,6 +38,7 @@ extern int child_init_ok; extern int init_without_kafka; +extern int log_without_overflow; /** * \brief data type for a configuration property. @@ -124,6 +125,12 @@ static void kfk_logger( const rd_kafka_t *rk, int level, const char *fac, const char *buf) { + if(log_without_overflow && strstr(buf, "Connection refused") != NULL) { + // libkafka will keep retrying to connect if kafka server is down + // FIX: ignore these types of errors not to get overflowed + return; + } + switch(level) { case LOG_EMERG: LM_NPRL("RDKAFKA fac: %s : %s : %s\n", fac, @@ -190,8 +197,14 @@ static void kfk_msg_delivered( kfk_stats_add(topic_name, rkmessage->err); if(rkmessage->err) { - LM_ERR("RDKAFKA Message delivery failed: %s\n", - rd_kafka_err2str(rkmessage->err)); + if(log_without_overflow) { + // libkafka will log all undelivered msgs as ERR + // FIX: ignore these types of errors not to get overflowed; check stats instead + ; + } else { + LM_ERR("RDKAFKA Message delivery failed: %s\n", + rd_kafka_err2str(rkmessage->err)); + } } else { LM_DBG("RDKAFKA Message delivered (%zd bytes, offset %" PRId64 ", " "partition %" PRId32 "): %.*s\n", @@ -865,7 +878,11 @@ int kfk_message_send(str *topic_name, str *message, str *key) NULL) == -1) { rd_kafka_resp_err_t err = rd_kafka_last_error(); - LM_ERR("Error sending message: %s\n", rd_kafka_err2str(err)); + if(!log_without_overflow) { + LM_ERR("Error sending message: %s\n", rd_kafka_err2str(err)); + } else { + return 0; + } return -1; }

1 0

git:master:741bb148: kafka: add modparam init_without_kafka
by Daniel-Constantin Mierla 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: 741bb148ddf4311679cfa6e379fa8bdbc8fac5e5 URL: https://github.com/kamailio/kamailio/commit/741bb148ddf4311679cfa6e379fa8bd… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T10:01:10+02:00 kafka: add modparam init_without_kafka --- Modified: src/modules/kafka/kafka_mod.c Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/741bb148ddf4311679cfa6e379fa8bd… Patch: https://github.com/kamailio/kamailio/commit/741bb148ddf4311679cfa6e379fa8bd… --- diff --git a/src/modules/kafka/kafka_mod.c b/src/modules/kafka/kafka_mod.c index 26369d6ca31..e88bd37384b 100644 --- a/src/modules/kafka/kafka_mod.c +++ b/src/modules/kafka/kafka_mod.c @@ -64,6 +64,8 @@ static int w_kafka_send_key( /* * Variables and functions to deal with module parameters. */ +int child_init_ok = 0; +int init_without_kafka = 0; char *brokers_param = NULL; /**< List of brokers. */ static int kafka_conf_param(modparam_t type, void *val); static int kafka_topic_param(modparam_t type, void *val); @@ -84,7 +86,7 @@ static param_export_t params[] = {{"brokers", PARAM_STRING, &brokers_param}, {"configuration", PARAM_STRING | USE_FUNC_PARAM, (void *)kafka_conf_param}, {"topic", PARAM_STRING | USE_FUNC_PARAM, (void *)kafka_topic_param}, - {0, 0, 0}}; + {"init_without_kafka", PARAM_INT, &init_without_kafka}, {0, 0, 0}}; /** * \brief Kafka :: Module interface @@ -125,9 +127,15 @@ static int child_init(int rank) if(rank == PROC_INIT || rank == PROC_TCP_MAIN) return 0; + child_init_ok = 1; if(kfk_init(brokers_param)) { - LM_ERR("Failed to initialize Kafka\n"); - return -1; + child_init_ok = 0; + if(init_without_kafka) { + LM_ERR("Failed to initialize Kafka - continue\n"); + } else { + LM_ERR("Failed to initialize Kafka\n"); + return -1; + } } return 0; } diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index c6dc8398da2..76a5fea75d9 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -36,6 +36,9 @@ #include "../../core/mem/shm_mem.h" #include "../../core/locking.h" +extern int child_init_ok; +extern int init_without_kafka; + /** * \brief data type for a configuration property. */ @@ -587,7 +590,9 @@ static int kfk_topic_configure(kfk_topic_t *ktopic) } int topic_found = kfk_topic_exist(ktopic->topic_name); - if(topic_found == -1) { + if(init_without_kafka) { + ; + } else if(topic_found == -1) { LM_ERR("Failed to search for topic %.*s in cluster\n", ktopic->topic_name->len, ktopic->topic_name->s); goto error; @@ -828,6 +833,12 @@ int kfk_message_send(str *topic_name, str *message, str *key) /* Get topic from name. */ rd_kafka_topic_t *rkt = kfk_topic_get(topic_name); + if(!child_init_ok) { + LM_ERR("kafka module is unusable: child init NOT ok! Skip sending " + "message, message lost!"); + return -1; + } + if(!rkt) { LM_ERR("Topic not found: %.*s\n", topic_name->len, topic_name->s); return -1;

1 0

[kamailio/kamailio] topos_redis : show redis error for post mortem analysis (PR #3965)
by ThomasSevestre 18 Sep '24

18 Sep '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Small log improvement, in order to make easier to find the origin of redis errors. Log sample : ``` WARNING: topos_redis [topos_redis_storage.c:834]: tps_redis_load_branch(): invalid redis result type: 6 WARNING: topos [tps_storage.c:626]: tps_storage_record(): no local address - do record routing for all initial requests ERROR: topos [tps_storage.c:637]: tps_storage_record(): failed to store ``` The root cause is probaly in redis error message and it whould be nice to log it You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3965 -- Commit Summary -- * topos_redis : show redis error for post mortem analysis -- File Changes -- M src/modules/topos_redis/topos_redis_storage.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3965.patch https://github.com/kamailio/kamailio/pull/3965.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3965 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3965(a)github.com>

2 3

git:master:72889e94: topos_redis : show redis error for post mortem analysis
by Daniel-Constantin Mierla 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: 72889e945041b6475a43c371aa4e20e99f5d1240 URL: https://github.com/kamailio/kamailio/commit/72889e945041b6475a43c371aa4e20e… Author: Thomas <1258170+ThomasSevestre(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T09:57:55+02:00 topos_redis : show redis error for post mortem analysis --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/72889e945041b6475a43c371aa4e20e… Patch: https://github.com/kamailio/kamailio/commit/72889e945041b6475a43c371aa4e20e… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 8009d8a006d..dd4ce1b7674 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -677,6 +677,9 @@ int tps_redis_load_initial_method_branch( if(rrpl->type != REDIS_REPLY_ARRAY) { LM_WARN("invalid redis result type: %d\n", rrpl->type); + if(rrpl->type == REDIS_REPLY_ERROR) { + LM_ERR("Redis error:%s\n", rrpl->str); + } freeReplyObject(rrpl); return -1; } @@ -832,6 +835,9 @@ int tps_redis_load_branch( if(rrpl->type != REDIS_REPLY_ARRAY) { LM_WARN("invalid redis result type: %d\n", rrpl->type); + if(rrpl->type == REDIS_REPLY_ERROR) { + LM_ERR("Redis error:%s\n", rrpl->str); + } freeReplyObject(rrpl); return -1; } @@ -1037,6 +1043,9 @@ int tps_redis_load_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) if(rrpl->type != REDIS_REPLY_ARRAY) { LM_WARN("invalid redis result type: %d\n", rrpl->type); + if(rrpl->type == REDIS_REPLY_ERROR) { + LM_ERR("Redis error:%s\n", rrpl->str); + } freeReplyObject(rrpl); return -1; }

1 0

git:master:abaf42a7: core: use advertise port only when set for via header
by Daniel-Constantin Mierla 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: abaf42a735b00af8cbfec90888d2ef3397e5040d URL: https://github.com/kamailio/kamailio/commit/abaf42a735b00af8cbfec90888d2ef3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T09:52:32+02:00 core: use advertise port only when set for via header --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/abaf42a735b00af8cbfec90888d2ef3… Patch: https://github.com/kamailio/kamailio/commit/abaf42a735b00af8cbfec90888d2ef3… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 4f88150e11b..f74e4ce3258 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2940,12 +2940,17 @@ char *via_builder(unsigned int *len, sip_msg_t *msg, } } if(port_str == NULL) { - if(hp && hp->port->len) + if(hp && hp->port->len) { port_str = hp->port; - else if(send_sock->useinfo.port_no > 0) - port_str = &(send_sock->useinfo.port_no_str); - else - port_str = &(send_sock->port_no_str); + } else if(send_sock->useinfo.name.len > 0) { + if(send_sock->useinfo.port_no > 0) { + port_str = &(send_sock->useinfo.port_no_str); + } + } else { + if(send_sock->port_no != SIP_PORT) { + port_str = &(send_sock->port_no_str); + } + } } proto = PROTO_NONE; if(msg && (msg->msg_flags & FL_USE_XAVP_VIA_FIELDS) @@ -2989,7 +2994,7 @@ char *via_builder(unsigned int *len, sip_msg_t *msg, via_prefix_len = MY_VIA_LEN + (proto == PROTO_SCTP); max_len = via_prefix_len + address_str->len /* space in MY_VIA */ + 2 /* just in case it is a v6 address ... [ ] */ - + 1 /*':'*/ + port_str->len + + 1 /*':'*/ + (port_str ? port_str->len : 0) + (branch ? (MY_BRANCH_LEN + branch->len) : 0) + (extra_params ? extra_params->len : 0) + comp_len + comp_name_len + CRLF_LEN + 1; @@ -3074,8 +3079,7 @@ char *via_builder(unsigned int *len, sip_msg_t *msg, } memcpy(line_buf + via_prefix_len + extra_len, address_str->s, address_str->len); - if((send_sock->port_no != SIP_PORT) - || (port_str != &send_sock->port_no_str)) { + if(port_str != NULL && port_str->len > 0) { line_buf[via_len] = ':'; via_len++; memcpy(line_buf + via_len, port_str->s, port_str->len);

1 0

git:master:d9ae203c: pkg/kamailio/deb: remove geoip package
by Victor Seva 18 Sep '24

18 Sep '24

Module: kamailio Branch: master Commit: d9ae203c637f53725556fea0ba82f7ae014ee508 URL: https://github.com/kamailio/kamailio/commit/d9ae203c637f53725556fea0ba82f7a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-18T08:54:01+02:00 pkg/kamailio/deb: remove geoip package related #3886 --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/bullseye/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jammy/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/noble/control Modified: pkg/kamailio/deb/noble/rules Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/d9ae203c637f53725556fea0ba82f7a… Patch: https://github.com/kamailio/kamailio/commit/d9ae203c637f53725556fea0ba82f7a…

1 0

[kamailio/kamailio] Pseudo-variables are erroneous for tm.cancel function. (Issue #3977)
by JuanPascual2 17 Sep '24

17 Sep '24

Hello Following the correction of issue #383, pseudo-variables are erroneous for tm.cancel function. The pseudo variables in “tm:local-request” correspond to the INVITE equest and not to the CANCEL request. Example: $rm = INVITE BR Juan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3977 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3977(a)github.com>

1 2

git:master:1d2b4d5e: core: relocate core rpc, cfg locks and shutdown var initialization
by Daniel-Constantin Mierla 17 Sep '24

17 Sep '24

Module: kamailio Branch: master Commit: 1d2b4d5ed6cd31c5cd6d6a60d80b86a1f66fac79 URL: https://github.com/kamailio/kamailio/commit/1d2b4d5ed6cd31c5cd6d6a60d80b86a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-17T10:16:25+02:00 core: relocate core rpc, cfg locks and shutdown var initialization - done now after shm initialization, shm being used for rpc reload delta, the locks need also shm --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/1d2b4d5ed6cd31c5cd6d6a60d80b86a… Patch: https://github.com/kamailio/kamailio/commit/1d2b4d5ed6cd31c5cd6d6a60d80b86a… --- diff --git a/src/main.c b/src/main.c index 993181c7326..c91908baed6 100644 --- a/src/main.c +++ b/src/main.c @@ -2761,17 +2761,17 @@ int main(int argc, char **argv) listen_field_count = 0; /* split listen arguments */ tbuf = pkg_char_dup(optarg); - if (tbuf == NULL) { + if(tbuf == NULL) { fprintf(stderr, "error during processing -l parameter\n"); } tbuf_tmp = tbuf; - while ((p = strsep(&tbuf, "/")) != NULL && listen_field_count < 3) { + while((p = strsep(&tbuf, "/")) != NULL + && listen_field_count < 3) { listen_fields[listen_field_count++] = p; } /* empty advertise only allowed with a name field */ - if (listen_field_count == 2 && strlen(listen_fields[1]) <= 0) { - fprintf(stderr, - "listen value with invalid advertise: %s\n", + if(listen_field_count == 2 && strlen(listen_fields[1]) <= 0) { + fprintf(stderr, "listen value with invalid advertise: %s\n", optarg); pkg_free(tbuf_tmp); goto error; @@ -2779,9 +2779,10 @@ int main(int argc, char **argv) ahost = NULL; aport = 0; aproto = PROTO_NONE; - if (listen_field_count > 1 && strlen(listen_fields[1]) > 0) { + if(listen_field_count > 1 && strlen(listen_fields[1]) > 0) { /* advertise not empty */ - if(parse_phostport(listen_fields[1], &ahost, &tmp_len, &aport, &aproto) + if(parse_phostport(listen_fields[1], &ahost, &tmp_len, + &aport, &aproto) < 0) { fprintf(stderr, "listen value with invalid advertise: %s\n", @@ -2794,9 +2795,9 @@ int main(int argc, char **argv) } } /* socket name */ - if (listen_field_count == 3 && listen_fields[2] != NULL) { - if (strlen(listen_fields[2]) > 0) { - socket_name=listen_fields[2]; + if(listen_field_count == 3 && listen_fields[2] != NULL) { + if(strlen(listen_fields[2]) > 0) { + socket_name = listen_fields[2]; } else { fprintf(stderr, "listen value with invalid socket name: %s\n", @@ -2817,8 +2818,8 @@ int main(int argc, char **argv) goto error; } /* add a new addr. to our address list */ - if(add_listen_advertise_iface_name(n_lst->name, n_lst->next, port, - proto, aproto, ahost, aport, socket_name, + if(add_listen_advertise_iface_name(n_lst->name, n_lst->next, + port, proto, aproto, ahost, aport, socket_name, n_lst->flags) != 0) { fprintf(stderr, "failed to add new listen address: %s\n", @@ -2962,14 +2963,6 @@ int main(int argc, char **argv) if(pv_reinit_buffer() < 0) goto error; - if(register_core_rpcs() != 0) - goto error; - - if(ksr_route_locks_set_init() < 0) - goto error; - - ksr_shutdown_phase_init(); - /* init lookup for core event routes */ sr_core_ert_init(); @@ -3127,6 +3120,15 @@ int main(int argc, char **argv) goto error; pkg_print_manager(); shm_print_manager(); + + if(register_core_rpcs() != 0) + goto error; + + if(ksr_route_locks_set_init() < 0) + goto error; + + ksr_shutdown_phase_init(); + if(init_atomic_ops() == -1) goto error; if(init_basex() != 0) {

1 0

[kamailio/kamailio] app_jsdt: add support for loong64 arch (Issue #3976)
by Victor Seva 16 Sep '24

16 Sep '24

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060901 It has a patch like: ``` diff -ruN kamailio-5.7.3-bk/src/modules/app_jsdt/duk_config.h kamailio-5.7.3/src/modules/app_jsdt/duk_config.h --- kamailio-5.7.3-bk/src/modules/app_jsdt/duk_config.h 2023-11-17 19:30:23.000000000 +0800 +++ kamailio-5.7.3/src/modules/app_jsdt/duk_config.h 2024-01-16 17:22:10.659716319 +0800 @@ -304,6 +304,10 @@ #endif #endif /* __riscv */ +#if defined(__loongarch64) +#define DUK_F_LOONGARCH64 +#endif + /* SuperH */ #if defined(__sh__) || defined(__sh1__) || defined(__SH1__) \ || defined(__sh2__) || defined(__SH2__) || defined(__sh3__) \ @@ -979,6 +983,11 @@ /* SPARC byte order varies so rely on autodetection. */ #undef DUK_USE_PACKED_TVAL #define DUK_F_PACKED_TVAL_PROVIDED +#elif defined(DUK_F_LOONGARCH64) +#define DUK_USE_ARCH_STRING "loongarch64" +#define DUK_USE_BYTEORDER 1 +#define DUK_USE_PACKED_TVAL +#define DUK_F_PACKED_TVAL_PROVIDED #elif defined(DUK_F_RISCV32) /* --- RISC-V 32-bit --- */ #define DUK_USE_ARCH_STRING "riscv32" ``` I imagine that is coming from https://github.com/svaarala/duktape/commit/1dcb1c23429208de8d6693dec55f2cbf… merged upstream -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3976 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3976(a)github.com>

1 1

git:master:5746db1c: app_jsdt: add support for loong64
by Victor Seva 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 5746db1c5a99eaeaf7f97d520232f014548c912d URL: https://github.com/kamailio/kamailio/commit/5746db1c5a99eaeaf7f97d520232f01… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-16T19:39:09+02:00 app_jsdt: add support for loong64 From: liuxiang <liuxiang(a)loongson.cn> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060901 fixes #3976 --- Modified: src/modules/app_jsdt/duk_config.h --- Diff: https://github.com/kamailio/kamailio/commit/5746db1c5a99eaeaf7f97d520232f01… Patch: https://github.com/kamailio/kamailio/commit/5746db1c5a99eaeaf7f97d520232f01… --- diff --git a/src/modules/app_jsdt/duk_config.h b/src/modules/app_jsdt/duk_config.h index 690f7019912..331d778684b 100644 --- a/src/modules/app_jsdt/duk_config.h +++ b/src/modules/app_jsdt/duk_config.h @@ -304,6 +304,11 @@ #endif #endif /* __riscv */ +/* LOONGARCH64, https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html */ +#if defined(__loongarch64) +#define DUK_F_LOONGARCH64 +#endif + /* SuperH */ #if defined(__sh__) || defined(__sh1__) || defined(__SH1__) \ || defined(__sh2__) || defined(__SH2__) || defined(__sh3__) \ @@ -979,6 +984,11 @@ /* SPARC byte order varies so rely on autodetection. */ #undef DUK_USE_PACKED_TVAL #define DUK_F_PACKED_TVAL_PROVIDED +#elif defined(DUK_F_LOONGARCH64) +#define DUK_USE_ARCH_STRING "loongarch64" +#define DUK_USE_BYTEORDER 1 +#undef DUK_USE_PACKED_TVAL +#define DUK_F_PACKED_TVAL_PROVIDED #elif defined(DUK_F_RISCV32) /* --- RISC-V 32-bit --- */ #define DUK_USE_ARCH_STRING "riscv32"

1 0

git:master:99710daa: core: proper condition for bind_ipv6_link_local modes
by Daniel-Constantin Mierla 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 99710daa8b05a0a37ef3bb35e2ffd723908037f4 URL: https://github.com/kamailio/kamailio/commit/99710daa8b05a0a37ef3bb35e2ffd72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-16T15:28:14+02:00 core: proper condition for bind_ipv6_link_local modes --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/99710daa8b05a0a37ef3bb35e2ffd72… Patch: https://github.com/kamailio/kamailio/commit/99710daa8b05a0a37ef3bb35e2ffd72… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index ae1c9ec4b0b..8bb77351230 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -1001,7 +1001,7 @@ assign_stm: | IPV6_HEX_STYLE error { yyerror("string value expected"); } | BIND_IPV6_LINK_LOCAL EQUAL NUMBER { sr_bind_ipv6_link_local = $3; - if(sr_bind_ipv6_link_local && (KSR_IPV6_LINK_LOCAL_BIND|KSR_IPV6_LINK_LOCAL_SKIP)) { + if(!(sr_bind_ipv6_link_local && (KSR_IPV6_LINK_LOCAL_BIND|KSR_IPV6_LINK_LOCAL_SKIP))) { yyerror("incompatible modes set"); } }

1 0

[kamailio/kamailio] tm: Emit request event when tm.cancel is called (PR #3962)
by Xenofon Karamanos 16 Sep '24

16 Sep '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3831 #### Description  The `tm` currently does not trigger the `tm:local-request` event for CANCEL requests that are created by the tm.cancel RPC function. This pull request adds support for triggering the tm:local-request event for CANCEL requests. According to [docs](https://www.kamailio.org/docs/modules/devel/modules/tm#tm.e.local-req… an event `tm:local-request` should be created for every request that is originates from kamailio and creates a transaction. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3962 -- Commit Summary -- * tm: Emit request event when cancel is called -- File Changes -- M src/modules/tm/t_cancel.c (62) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3962.patch https://github.com/kamailio/kamailio/pull/3962.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3962 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3962(a)github.com>

3 7

git:master:faca8e7a: tm: Emit request event when cancel is called
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: faca8e7a20255d90a4786fd4043005ead9dfc5df URL: https://github.com/kamailio/kamailio/commit/faca8e7a20255d90a4786fd4043005e… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T15:21:51+02:00 tm: Emit request event when cancel is called --- Modified: src/modules/tm/t_cancel.c --- Diff: https://github.com/kamailio/kamailio/commit/faca8e7a20255d90a4786fd4043005e… Patch: https://github.com/kamailio/kamailio/commit/faca8e7a20255d90a4786fd4043005e… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index 68dae04fbc8..03e919f6abe 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -29,6 +29,7 @@ #include "t_funcs.h" #include "../../core/dprint.h" #include "../../core/ut.h" +#include "../../core/kemi.h" #include "t_reply.h" #include "t_cancel.h" #include "t_msgbuilder.h" @@ -36,6 +37,8 @@ #include "t_hooks.h" +extern str tm_event_callback; + typedef struct cancel_reason_map { int code; @@ -86,6 +89,11 @@ void prepare_to_cancel( int i; int branches_no; branch_bm_t mask; + int rt, backup_rt; + struct run_act_ctx ctx; + sip_msg_t msg; + sr_kemi_eng_t *keng = NULL; + str evname = str_init("tm:local-request"); *cancel_bm = 0; branches_no = t->nr_of_outgoings; @@ -95,6 +103,49 @@ void prepare_to_cancel( *cancel_bm |= ((mask & (1 << i)) && prepare_cancel_branch(t, i, 1)) << i; } + + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, "tm:local-request"); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + return; + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + return; + } + } + + /* Check if msg is null */ + if(build_sip_msg_from_buf( + &msg, t->uac->request.buffer, t->uac->request.buffer_len, 0) + < 0) { + LM_ERR("fail to parse msg\n"); + return; + } + + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } + } + } + set_route_type(backup_rt); + free_sip_msg(&msg); }

1 0

git:master:45a93b46: sst: small white space change in docs after dialog flag removal (commit 7e139951dc)
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 45a93b46f0845867fdc1fd07a798eda6a9480816 URL: https://github.com/kamailio/kamailio/commit/45a93b46f0845867fdc1fd07a798eda… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T11:45:11Z sst: small white space change in docs after dialog flag removal (commit 7e139951dc) --- Modified: src/modules/sst/doc/sst_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/45a93b46f0845867fdc1fd07a798eda… Patch: https://github.com/kamailio/kamailio/commit/45a93b46f0845867fdc1fd07a798eda… --- diff --git a/src/modules/sst/doc/sst_admin.xml b/src/modules/sst/doc/sst_admin.xml index 751dd3a2f49..6b44916ab78 100644 --- a/src/modules/sst/doc/sst_admin.xml +++ b/src/modules/sst/doc/sst_admin.xml @@ -54,7 +54,7 @@ All of this happens with a properly configured dialog and sst module. You need to call the dlg_manage() function and set the sst flag at the time any INVITE sip message is seen. - There is no &kamailioconfig; script function call required to + There is no &kamailioconfig; script function call required to set the dialog expire timeout value. See the <quote>dialog module</quote> users guide for more information. @@ -312,7 +312,7 @@ modparam("sst", "sst_flag", 6) route { ... if (method=="INVITE") { - dlg_manage(); # Track the dialog + dlg_manage(); # Track the dialog setflag(6); # set the sst flag } ...

1 0

[kamailio/kamailio] Dialog flag (PR #3961)
by Xenofon Karamanos 16 Sep '24

16 Sep '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2593 #### Description  This PR removes the `dlg_flag` from the dialog module and recommends `dlg_manage()` instead in the docs. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3961 -- Commit Summary -- * dialog: Drop support for dlg_flag parameter * dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead. -- File Changes -- M src/modules/dialog/dialog.c (13) M src/modules/dialog/dlg_handlers.c (22) M src/modules/dialog/dlg_handlers.h (3) M src/modules/dialog/doc/dialog_admin.xml (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3961.patch https://github.com/kamailio/kamailio/pull/3961.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3961 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3961(a)github.com>

4 13

git:master:30a362bd: nat_traversal: Remove dlg_flag and update docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 30a362bd5d91205135721bf8bce129e41cef9651 URL: https://github.com/kamailio/kamailio/commit/30a362bd5d91205135721bf8bce129e… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 nat_traversal: Remove dlg_flag and update docs --- Modified: src/modules/nat_traversal/doc/nat_traversal_admin.xml Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/30a362bd5d91205135721bf8bce129e… Patch: https://github.com/kamailio/kamailio/commit/30a362bd5d91205135721bf8bce129e…

1 0

git:master:60a5ea45: mediaproxy: Remove dlg_flag and update docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 60a5ea45c5cc18b7074330da52ed1944cfbf3fbb URL: https://github.com/kamailio/kamailio/commit/60a5ea45c5cc18b7074330da52ed194… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 mediaproxy: Remove dlg_flag and update docs --- Modified: src/modules/mediaproxy/doc/mediaproxy_admin.xml Modified: src/modules/mediaproxy/mediaproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/60a5ea45c5cc18b7074330da52ed194… Patch: https://github.com/kamailio/kamailio/commit/60a5ea45c5cc18b7074330da52ed194… --- diff --git a/src/modules/mediaproxy/doc/mediaproxy_admin.xml b/src/modules/mediaproxy/doc/mediaproxy_admin.xml index d89207b33a3..c75ed86e629 100644 --- a/src/modules/mediaproxy/doc/mediaproxy_admin.xml +++ b/src/modules/mediaproxy/doc/mediaproxy_admin.xml @@ -349,7 +349,6 @@ modparam("mediaproxy", "ice_candidate_avp", "$avp(ice_candidate)") called internally on dialog callbacks, so for this function to work, the dialog module must be loaded and configured. </para> - <para> This function is an advanced mechanism to use a media relay without having to manually call a function on each message that @@ -371,6 +370,11 @@ modparam("mediaproxy", "ice_candidate_avp", "$avp(ice_candidate)") This function can be used from REQUEST_ROUTE. </para> + <note> + The <emphasis>dlg_manage()</emphasis> function must be called + in the configuration file before using this function. + </note> + <example> <title>Using the <function>engage_media_proxy</function> function</title> <programlisting format="linespecific"> @@ -378,6 +382,7 @@ modparam("mediaproxy", "ice_candidate_avp", "$avp(ice_candidate)") if (method==INVITE && !has_totag()) { # We can also use a specific media relay if we need to #$avp(media_relay) = "1.2.3.4"; + dlg_manage() engage_media_proxy(); } ... @@ -466,4 +471,3 @@ if (method==BYE) { </section> </chapter> - diff --git a/src/modules/mediaproxy/mediaproxy.c b/src/modules/mediaproxy/mediaproxy.c index 7b4e301bdc7..c7ccd901a1d 100644 --- a/src/modules/mediaproxy/mediaproxy.c +++ b/src/modules/mediaproxy/mediaproxy.c @@ -207,7 +207,6 @@ static MediaproxySocket mediaproxy_socket = { struct dlg_binds dlg_api; Bool have_dlg_api = False; -static int dialog_flag = -1; // The AVP where the caller signaling IP is stored (if defined) static AVP_Param signaling_ip_avp = {str_init(SIGNALING_IP_AVP_SPEC), {0}, 0}; @@ -1996,7 +1995,6 @@ static int EngageMediaProxy(struct sip_msg *msg) return -1; } msg->msg_flags |= FL_USE_MEDIA_PROXY; - setflag(msg, dialog_flag); // have the dialog module trace this dialog return 1; } @@ -2049,9 +2047,6 @@ static int w_EndMediaSession(struct sip_msg *msg, char *p1, char *p2) static int mod_init(void) { pv_spec_t avp_spec; - int *param; - modparam_t type; - // initialize the signaling_ip_avp structure if(!signaling_ip_avp.spec.s || signaling_ip_avp.spec.len <= 0) { LM_WARN("missing/empty signaling_ip_avp parameter. will use " @@ -2130,21 +2125,6 @@ static int mod_init(void) if(load_dlg_api(&dlg_api) == 0) { have_dlg_api = True; - // load dlg_flag and default_timeout parameters from the dialog module - param = find_param_export( - find_module_by_name("dialog"), "dlg_flag", INT_PARAM, &type); - if(!param) { - LM_CRIT("cannot find dlg_flag parameter in the dialog module\n"); - return -1; - } - - if(type != INT_PARAM) { - LM_CRIT("dlg_flag parameter found but with wrong type: %d\n", type); - return -1; - } - - dialog_flag = *param; - // register dialog creation callback if(dlg_api.register_dlgcb( NULL, DLGCB_CREATED, __dialog_created, NULL, NULL)

1 0

git:master:013c3f1c: cnxcc: Remove dlg_flag and update docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 013c3f1cc52d4ae2c68496cddf0f1122ffc079e1 URL: https://github.com/kamailio/kamailio/commit/013c3f1cc52d4ae2c68496cddf0f112… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 cnxcc: Remove dlg_flag and update docs --- Modified: src/modules/cnxcc/cnxcc_mod.c Modified: src/modules/cnxcc/cnxcc_mod.h Modified: src/modules/cnxcc/doc/cnxcc_admin.xml Modified: src/modules/cnxcc/example/kamailio-cnxcc.cfg --- Diff: https://github.com/kamailio/kamailio/commit/013c3f1cc52d4ae2c68496cddf0f112… Patch: https://github.com/kamailio/kamailio/commit/013c3f1cc52d4ae2c68496cddf0f112…

1 0

git:master:5115ea20: call_control: Remove dlg_flag and update docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 5115ea20322ef32d581c1dd8f581dfd780a5094c URL: https://github.com/kamailio/kamailio/commit/5115ea20322ef32d581c1dd8f581dfd… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 call_control: Remove dlg_flag and update docs --- Modified: src/modules/call_control/call_control.c Modified: src/modules/call_control/doc/call_control_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5115ea20322ef32d581c1dd8f581dfd… Patch: https://github.com/kamailio/kamailio/commit/5115ea20322ef32d581c1dd8f581dfd… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index f1614b04254..41b36eeedd6 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -146,7 +146,6 @@ static AVP_Param sip_application_avp = { struct dlg_binds dlg_api; -static int dialog_flag = -1; AVP_List *cc_init_avps = NULL, *cc_start_avps = NULL, *cc_stop_avps = NULL; @@ -1080,7 +1079,6 @@ static int ki_call_control(sip_msg_t *msg) if(result == 1) { // A call with a time limit that will be traced by callcontrol msg->msg_flags |= FL_USE_CALL_CONTROL; - setflag(msg, dialog_flag); // have the dialog module trace this dialog } return result; @@ -1171,20 +1169,6 @@ static int mod_init(void) return -1; } - // load dlg_flag and default_timeout parameters from the dialog module - param = find_param_export( - find_module_by_name("dialog"), "dlg_flag", INT_PARAM, &type); - if(!param) { - LOG(L_CRIT, "cannot find dlg_flag parameter in the dialog module\n"); - return -1; - } - if(type != INT_PARAM) { - LOG(L_CRIT, "dlg_flag parameter found but with wrong type: %d\n", type); - return -1; - } - - dialog_flag = *param; - // register dialog creation callback if(dlg_api.register_dlgcb(NULL, DLGCB_CREATED, __dialog_created, NULL, NULL) != 0) { diff --git a/src/modules/call_control/doc/call_control_admin.xml b/src/modules/call_control/doc/call_control_admin.xml index f673413ed0b..01d56ebe0d4 100644 --- a/src/modules/call_control/doc/call_control_admin.xml +++ b/src/modules/call_control/doc/call_control_admin.xml @@ -410,6 +410,10 @@ route { This function can be used from REQUEST_ROUTE. </para> + <note> + The <emphasis>dlg_manage()</emphasis> (dialog module) function must be called in the configuration file before using this function. + </note> + <example> <title>Using the <function>call_control</function> function</title> <programlisting format="linespecific"> @@ -424,6 +428,7 @@ if (is_avp_set("$avp(i:805)")) { if (method==INVITE && !has_totag() && is_domain_local("$avp(s:billing_party_domain)")) { + dlg_manage(); call_control(); switch ($retcode) { case 2: @@ -460,4 +465,3 @@ t_relay(); </section> </chapter> -

1 0

git:master:7e139951: sst: Remove dlg_flag docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 7e139951dc925f60bdd37ce699b38188cb223888 URL: https://github.com/kamailio/kamailio/commit/7e139951dc925f60bdd37ce699b3818… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 sst: Remove dlg_flag docs --- Modified: src/modules/sst/doc/sst_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7e139951dc925f60bdd37ce699b3818… Patch: https://github.com/kamailio/kamailio/commit/7e139951dc925f60bdd37ce699b3818… --- diff --git a/src/modules/sst/doc/sst_admin.xml b/src/modules/sst/doc/sst_admin.xml index 9c905f9e3c0..751dd3a2f49 100644 --- a/src/modules/sst/doc/sst_admin.xml +++ b/src/modules/sst/doc/sst_admin.xml @@ -50,12 +50,15 @@ request the use of session timers if the UAC does not request it.</para> - <para>All of this happens with a properly configured dialog - and sst module and setting the dialog flag and the sst flag at - the time any INVITE sip message is seen. There is no - &kamailioconfig; script function call required to set the dialog - expire timeout value. See the <quote>dialog module</quote> users guide for - more information.</para> + <para> + All of this happens with a properly configured dialog and sst + module. You need to call the dlg_manage() function and set the + sst flag at the time any INVITE sip message is seen. + There is no &kamailioconfig; script function call required to + set the dialog expire timeout value. + See the <quote>dialog module</quote> users guide for + more information. + </para> <para>The <quote>sstCheckMin()</quote> script function can be used to verify that the Session-expires / MIN-SE header field values are not too @@ -287,9 +290,9 @@ modparam("sst", "reject_to_small", 0) need to tell the sst module which flag value you are assigning to sst.</para> - <para>In most cases whenever you set the dialog flag - you will want to set the sst flag. If the dialog flag - is not set and the sst flag is set, it will not have + <para>In most cases whenever you call dlg_manage() function + you will want to set the sst flag. If the dialog is not tracked + and the sst flag is set, it will not have any effect.</para> <para><emphasis>This parameter must be set or the module will @@ -304,13 +307,12 @@ modparam("sst", "reject_to_small", 0) <title>Set <varname>sst_flag</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("dialog", "dlg_flag", 5) modparam("sst", "sst_flag", 6) ... route { ... if (method=="INVITE") { - setflag(5); # set the dialog flag + dlg_manage(); # Track the dialog setflag(6); # set the sst flag } ... @@ -353,7 +355,6 @@ route { ... modparam("dialog", "timeout_avp", "$avp(i:4242)") -modparam("dialog", "dlg_flag", 5) ... modparam("sst", "sst_flag", 6) modparam("sst", "timeout_avp", "$avp(i:4242)") @@ -367,7 +368,7 @@ route { exit; } # track the session timers via the dialog module - setflag(5); + dlg_manage(); setflag(6); } } @@ -381,7 +382,7 @@ route { exit; } # track the session timers via the dialog module - setflag(5); + dlg_manage(); setflag(6); } } @@ -407,4 +408,3 @@ route { <para>Just load the module and remember to set the timeout_avp and sst_flag values.</para> </section> </chapter> -

1 0

git:master:435fa668: pua_dialoginfo: Remove dlg_flag docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 435fa668e1709df8c3025961fa7a38224483914e URL: https://github.com/kamailio/kamailio/commit/435fa668e1709df8c3025961fa7a382… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 pua_dialoginfo: Remove dlg_flag docs --- Modified: src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/435fa668e1709df8c3025961fa7a382… Patch: https://github.com/kamailio/kamailio/commit/435fa668e1709df8c3025961fa7a382… --- diff --git a/src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml b/src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml index 6093c3516b6..ac5d3ba41d3 100644 --- a/src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml +++ b/src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml @@ -165,8 +165,8 @@ <para>This module is directly coupled with the dialog module. Thus, if the module is loaded, it is automatically active for all calls tracked by the dialog module. Thus, make sure that you activate the dialog module for a certain call if you want dialog-state - to be PUBLISHED. This means, the dlg_flag of the dialog module must be configured - and the respective flag must be set during call processing. + to be PUBLISHED. This means, use the <emphasis>dlg_manage()</emphasis> function of the dialog + module to have it tracked. </para> </section> <section>

1 0

git:master:f612c958: qos: Remove dlg_flag docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: f612c9583072eb22dc477c11d000541ab8b944ad URL: https://github.com/kamailio/kamailio/commit/f612c9583072eb22dc477c11d000541… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 qos: Remove dlg_flag docs --- Modified: src/modules/qos/doc/qos_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f612c9583072eb22dc477c11d000541… Patch: https://github.com/kamailio/kamailio/commit/f612c9583072eb22dc477c11d000541… --- diff --git a/src/modules/qos/doc/qos_admin.xml b/src/modules/qos/doc/qos_admin.xml index 38d33a99f00..908ab5d5f84 100644 --- a/src/modules/qos/doc/qos_admin.xml +++ b/src/modules/qos/doc/qos_admin.xml @@ -32,12 +32,10 @@ </para> <para> - All of this happens with a properly configured dialog - and qos module and setting the dialog flag and the qos flag at - the time any INVITE SIP message is seen. There is no - config script function call required to set the SDP session - tracking mechanism. See the dialog module users guide for - more information. + All of this happens with a properly configured dialog and qos + module. You need to call the dlg_manage() function and set the + qos flag at the time any INVITE sip message is seen. + See the <quote>dialog module</quote> users guide for information. </para> <para> @@ -126,9 +124,9 @@ before you can do that, you need to tell the qos module which flag value you are assigning to qos.</para> - <para>In most cases when ever you set the dialog flag - you will want to set the qos flag. If the dialog flag - is not set and the qos flag is set, it will not have + <para>In most cases when ever you call dlg_manage() function + you will want to set the qos flag. If the dialog is not tracked + and the qos flag is set, it will not have any effect.</para> <para><emphasis>This parameter must be set or the module will @@ -143,13 +141,12 @@ <title>Set <varname>qos_flag</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("dialog", "dlg_flag", 5) modparam("qos", "qos_flag", 7) ... route { ... if (method=="INVITE") { - setflag(5); # set the dialog flag + dlg_manage(); # Track the dialog setflag(7); # Set the qos flag } ... @@ -182,4 +179,3 @@ route { </para> </section> </chapter> -

1 0

git:master:fbe3aede: acc: Remove dlg_flag docs
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: fbe3aedee492ceb23ef53c967f1fe256a94d876f URL: https://github.com/kamailio/kamailio/commit/fbe3aedee492ceb23ef53c967f1fe25… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 acc: Remove dlg_flag docs --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fbe3aedee492ceb23ef53c967f1fe25… Patch: https://github.com/kamailio/kamailio/commit/fbe3aedee492ceb23ef53c967f1fe25… --- diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index 37a1365627e..493ae6323f3 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -327,7 +327,7 @@ if (uri=~"sip:+40") /* calls to Romania */ { <para> The dialog module needs to be engaged on the dialogs that should be accounted, that they will be tracked by the server. This is usally done by calling the function - <emphasis>dlg_manage()</emphasis> or setting the <emphasis>dlg_flag</emphasis>. + <emphasis>dlg_manage()</emphasis>. Refer to the documentation of the dialog module for more information. </para> @@ -1611,4 +1611,3 @@ acc_db_request("$var(code) $avp(reason)", "acc"); </section> </section> </chapter> -

1 0

git:master:81f96617: dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead.
by Henning Westerholt 16 Sep '24

16 Sep '24

Module: kamailio Branch: master Commit: 81f966174275b715608f50aae606d40a791dd67c URL: https://github.com/kamailio/kamailio/commit/81f966174275b715608f50aae606d40… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-16T13:39:06+02:00 dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead. --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/81f966174275b715608f50aae606d40… Patch: https://github.com/kamailio/kamailio/commit/81f966174275b715608f50aae606d40… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 07116e70a63..d1547b367a6 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -46,9 +46,8 @@ <title>How it works</title> <para> To create the dialog associated with an initial INVITE request, execute - the function <quote>dlg_manage()</quote> or set the flag specified by - parameter <quote>dlg_flag</quote> (<xref linkend="dialog.p.flag"/>) - before creating the corresponding transaction. + the function <quote>dlg_manage()</quote> before creating the + corresponding transaction. </para> <para> The dialog is automatically destroyed when a <quote>BYE</quote> is @@ -253,28 +252,17 @@ modparam("dialog", "rr_param", "xyz") <section id="dialog.p.flag"> <title><varname>dlg_flag</varname> (integer)</title> <para> - Flag to be used for marking if a dialog should be constructed for the - current request (this makes sense only for initial requests). - </para> - <para> - Note: it is not needed to set this parameter and its corresponding flag + Note: This flag has beed deprecated and not used anyymore. + it is not needed to set this parameter and its corresponding flag for initial request in case the <quote>dlg_manage()</quote> function - is used. In other words, using <quote>dlg_manage()</quote> alone is - enough. + is used. + In other words, use <quote>dlg_manage()</quote>. </para> <para> <emphasis> Default value is <quote>none</quote>. </emphasis> </para> - <example> - <title>Set <varname>dlg_flag</varname> parameter</title> - <programlisting format="linespecific"> -... -modparam("dialog", "dlg_flag", 4) -... -</programlisting> - </example> </section> <section id="dialog.p.timeout_avp">

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev