- sr-dev - kamailio.org

git:master:eeb17678: kazoo: fix deprecation warning
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: eeb17678d77548073a59b54c0a08ebdb48b25fa2 URL: https://github.com/kamailio/kamailio/commit/eeb17678d77548073a59b54c0a08ebd… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T14:31:29+02:00 kazoo: fix deprecation warning fixes #3466 From https://github.com/alanxz/rabbitmq-c/blob/c3e4176659aac7d0e497da90a46c08c63… > * \deprecated Since v0.13.0 this is a no-op. OpenSSL automatically manages > * library initialization and uninitialization. > Warning: kz_amqp.c:857:3: warning: 'amqp_set_initialize_ssl_library' is deprecated [-Wdeprecated-declarations] > amqp_set_initialize_ssl_library(1); > ^ > /usr/include/rabbitmq-c/ssl_socket.h:249:1: note: 'amqp_set_initialize_ssl_library' has been explicitly marked deprecated here > AMQP_DEPRECATED_EXPORT > ^ > /usr/include/rabbitmq-c/export.h:29:46: note: expanded from macro 'AMQP_DEPRECATED_EXPORT' > # define AMQP_DEPRECATED_EXPORT AMQP_EXPORT AMQP_DEPRECATED > ^ > /usr/include/rabbitmq-c/export.h:25:43: note: expanded from macro 'AMQP_DEPRECATED' > # define AMQP_DEPRECATED __attribute__ ((__deprecated__)) > ^ > 1 warning generated. --- Modified: src/modules/kazoo/kz_amqp.c --- Diff: https://github.com/kamailio/kamailio/commit/eeb17678d77548073a59b54c0a08ebd… Patch: https://github.com/kamailio/kamailio/commit/eeb17678d77548073a59b54c0a08ebd… --- diff --git a/src/modules/kazoo/kz_amqp.c b/src/modules/kazoo/kz_amqp.c index ed696116514..d702990e8b8 100644 --- a/src/modules/kazoo/kz_amqp.c +++ b/src/modules/kazoo/kz_amqp.c @@ -846,17 +846,17 @@ void kz_amqp_channel_close(kz_amqp_conn_ptr rmq, amqp_channel_t channel) kz_amqp_error("closing channel", amqp_channel_close(rmq->conn, channel, AMQP_REPLY_SUCCESS)); } - +#if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 13 int kz_ssl_initialized = 0; - +#endif int kz_amqp_connection_open_ssl(kz_amqp_conn_ptr rmq) { - +#if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 13 if(!kz_ssl_initialized) { kz_ssl_initialized = 1; amqp_set_initialize_ssl_library(1); } - +#endif if(!(rmq->conn = amqp_new_connection())) { LM_ERR("Failed to create new AMQP connection\n"); goto error;

1 0

git:master:a2f7147d: rabbitmq: remove deprecation warning
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: a2f7147dded679d025a902aa12beb048ee714c32 URL: https://github.com/kamailio/kamailio/commit/a2f7147dded679d025a902aa12beb04… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T14:17:34+02:00 rabbitmq: remove deprecation warning From https://github.com/alanxz/rabbitmq-c/blob/c3e4176659aac7d0e497da90a46c08c63… > * \deprecated Since v0.13.0 this is a no-op. OpenSSL automatically manages > * library initialization and uninitialization. > Warning: rabbitmq.c:574:3: warning: 'amqp_set_initialize_ssl_library' is deprecated [-Wdeprecated-declarations] > amqp_set_initialize_ssl_library(1); > ^ > /usr/include/rabbitmq-c/ssl_socket.h:249:1: note: 'amqp_set_initialize_ssl_library' has been explicitly marked deprecated here > AMQP_DEPRECATED_EXPORT > ^ > /usr/include/rabbitmq-c/export.h:29:46: note: expanded from macro 'AMQP_DEPRECATED_EXPORT' > # define AMQP_DEPRECATED_EXPORT AMQP_EXPORT AMQP_DEPRECATED > ^ > /usr/include/rabbitmq-c/export.h:25:43: note: expanded from macro 'AMQP_DEPRECATED' > # define AMQP_DEPRECATED __attribute__ ((__deprecated__)) > ^ > 1 warning generated. --- Modified: src/modules/rabbitmq/rabbitmq.c --- Diff: https://github.com/kamailio/kamailio/commit/a2f7147dded679d025a902aa12beb04… Patch: https://github.com/kamailio/kamailio/commit/a2f7147dded679d025a902aa12beb04… --- diff --git a/src/modules/rabbitmq/rabbitmq.c b/src/modules/rabbitmq/rabbitmq.c index 9b57e7a834c..709055dc9ab 100644 --- a/src/modules/rabbitmq/rabbitmq.c +++ b/src/modules/rabbitmq/rabbitmq.c @@ -87,7 +87,9 @@ static int max_reconnect_attempts = 1; static int timeout_sec = 1; static int timeout_usec = 0; static int direct_reply_to = 0; +#if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 13 static int amqp_ssl_init_called = 0; +#endif /* module helper functions */ static int rabbitmq_connect(amqp_connection_state_t *conn); @@ -569,12 +571,14 @@ static int rabbitmq_connect(amqp_connection_state_t *conn) int log_ret; // amqp_rpc_reply_t reply; +#if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 13 // amqp_ssl_init_called should only be called once if(amqp_info.ssl && !amqp_ssl_init_called) { amqp_set_initialize_ssl_library(1); amqp_ssl_init_called = 1; LM_DBG("AMQP SSL library initialized\n"); } +#endif // establish a new connection to RabbitMQ server *conn = amqp_new_connection();

1 0

git:master:35a87c98: ims_usrloc_pcscf: fix warning deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 35a87c98f4e84b65f82376dfb57050f43d0f355f URL: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:26:32+02:00 ims_usrloc_pcscf: fix warning deprecated-non-prototype > In file included from usrloc_db.c:12: > Warning: ./usrloc_db.h:131:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int use_location_pcscf_table(); > ^ > usrloc_db.c:113:5: note: conflicting prototype is here > int use_location_pcscf_table(str *domain) > ^ > 1 warning generated. --- Modified: src/modules/ims_usrloc_pcscf/usrloc_db.h --- Diff: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… Patch: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… --- diff --git a/src/modules/ims_usrloc_pcscf/usrloc_db.h b/src/modules/ims_usrloc_pcscf/usrloc_db.h index 3c50c153b4e..688387b1b2d 100644 --- a/src/modules/ims_usrloc_pcscf/usrloc_db.h +++ b/src/modules/ims_usrloc_pcscf/usrloc_db.h @@ -128,7 +128,7 @@ typedef struct reusable_buffer int data_len; } t_reusable_buffer; -int use_location_pcscf_table(); +int use_location_pcscf_table(str *domain); void destroy_db(); int init_db(const str *db_url, int db_update_period, int fetch_num_rows); int connect_db(const str *db_url);

1 0

git:master:7dcc8405: ims_usrloc_pcscf: fix warnings deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 7dcc8405ccec19132d27516426137e35e464d4ad URL: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:23:08+02:00 ims_usrloc_pcscf: fix warnings deprecated-non-prototype > In file included from pcontact.c:46: > Warning: ./pcontact.h:63:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int new_pcontact( > ^ > pcontact.c:166:5: note: conflicting prototype is here > int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, > ^ > 1 warning generated. > Warning: udomain.c:232:17: warning: passing arguments to 'new_pcontact' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > if(new_pcontact(_d->name, _contact, _ci, _c) < 0) { > ^ > 1 warning generated. --- Modified: src/modules/ims_usrloc_pcscf/pcontact.c Modified: src/modules/ims_usrloc_pcscf/pcontact.h Modified: src/modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… Patch: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… --- diff --git a/src/modules/ims_usrloc_pcscf/pcontact.c b/src/modules/ims_usrloc_pcscf/pcontact.c index 76e061fe529..a885cd285e7 100644 --- a/src/modules/ims_usrloc_pcscf/pcontact.c +++ b/src/modules/ims_usrloc_pcscf/pcontact.c @@ -192,7 +192,7 @@ int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, memcpy(p, _contact->s, _contact->len); p += _contact->len; (*_c)->aor.len = _contact->len; - (*_c)->domain = (str *)_d; + (*_c)->domain = _d->name; if(parse_uri((*_c)->aor.s, (*_c)->aor.len, &sip_uri) != 0) { LM_ERR("unable to determine contact host from uri [%.*s\n", diff --git a/src/modules/ims_usrloc_pcscf/pcontact.h b/src/modules/ims_usrloc_pcscf/pcontact.h index f1c130f4470..6f45d5aace2 100644 --- a/src/modules/ims_usrloc_pcscf/pcontact.h +++ b/src/modules/ims_usrloc_pcscf/pcontact.h @@ -60,8 +60,8 @@ void insert_ppublic(struct pcontact *_c, ppublic_t *_p); int new_ppublic(str *public_identity, int is_default, ppublic_t **_p); void free_ppublic(ppublic_t *_p); -int new_pcontact( - /*str* _dom, str* public_identity, int reg_state, int barring, ims_subscription** s, str* ccf1, str* ccf2, str* ecf1, str* ecf2, impurecord_t** _r*/); +int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, + struct pcontact **_c); void free_pcontact(pcontact_t *_c); void print_pcontact(FILE *_f, pcontact_t *_r); ppublic_t *mem_insert_ppublic( diff --git a/src/modules/ims_usrloc_pcscf/udomain.c b/src/modules/ims_usrloc_pcscf/udomain.c index 248684cb00b..27158128d13 100644 --- a/src/modules/ims_usrloc_pcscf/udomain.c +++ b/src/modules/ims_usrloc_pcscf/udomain.c @@ -229,7 +229,7 @@ int mem_insert_pcontact(struct udomain *_d, str *_contact, { int sl; - if(new_pcontact(_d->name, _contact, _ci, _c) < 0) { + if(new_pcontact(_d, _contact, _ci, _c) < 0) { LM_ERR("creating pcontact failed\n"); return -1; }

1 0

git:master:f49012d1: cdp: fix warning deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: f49012d15a06b27875cf6bca211ad953968b5217 URL: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:10:57+02:00 cdp: fix warning deprecated-non-prototype > Warning: peerstatemachine.c:120:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:182:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:395:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:400:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:420:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:462:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:467:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > 7 warnings generated. --- Modified: src/modules/cdp/peerstatemachine.c --- Diff: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… Patch: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… --- diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c index 97edb129549..2571e5df252 100644 --- a/src/modules/cdp/peerstatemachine.c +++ b/src/modules/cdp/peerstatemachine.c @@ -117,7 +117,7 @@ int sm_process( R_Disc(p); p->state = Closed; } - log_peer_list(L_INFO); + log_peer_list(); break; case Stop: /* just ignore this state */ @@ -134,7 +134,7 @@ int sm_process( case I_Rcv_Conn_Ack: p->state = Wait_I_CEA; I_Snd_CER(p); - if (p->state == Closed) + if(p->state == Closed) sm_process(p, Start, 0, 1, 0); break; case I_Rcv_Conn_NAck: @@ -179,7 +179,7 @@ int sm_process( Cleanup(p, p->I_sock); p->state = Closed; } - log_peer_list(L_INFO); + log_peer_list(); break; case R_Conn_CER: if(p->r_cer) @@ -392,12 +392,12 @@ int sm_process( Snd_DPA(p, msg, AAA_SUCCESS, p->R_sock); R_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case R_Peer_Disc: R_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case R_Rcv_CER: result_code = Process_CER(p, msg); @@ -417,7 +417,7 @@ int sm_process( /*R_Disc(p);p.state = Closed;*/ p->state = R_Open; /* Or maybe I should disconnect it?*/ } - log_peer_list(L_INFO); + log_peer_list(); break; default: LM_ERR("sm_process(): In state %s invalid event %s\n", @@ -459,12 +459,12 @@ int sm_process( Snd_DPA(p, msg, 2001, p->I_sock); I_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case I_Peer_Disc: I_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case I_Rcv_CER: result_code = Process_CER(p, msg); @@ -669,13 +669,13 @@ void I_Snd_CER(peer *p) if((ret = getsockname(p->I_sock, &(addr_u.addr), &addrlen)) == -1) { LM_ERR("I_Snd_CER(): Error on finding local host address > %s\n", strerror(errno)); - Cleanup(p,p->I_sock); + Cleanup(p, p->I_sock); p->state = Closed; AAAFreeMessage(&cer); return; } - if (ret != -1) { + if(ret != -1) { switch(addr_u.addr.sa_family) { case AF_INET: set_2bytes(x, 1);

1 0

git:master:03e49d4e: presence: fix warning conflicting prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 03e49d4e1d806f39ee6aadaedd183a6578108d96 URL: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:07:37+02:00 presence: fix warning conflicting prototype > Warning: presence_dmq.c:38:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int pres_dmq_send_all_presentities(); > ^ > presence_dmq.c:487:5: note: conflicting prototype is here > int pres_dmq_send_all_presentities(dmq_node_t *dmq_node) > ^ > 1 warning generated. --- Modified: src/modules/presence/presence_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… Patch: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… --- diff --git a/src/modules/presence/presence_dmq.c b/src/modules/presence/presence_dmq.c index 97c6f5831b5..2e26187383f 100644 --- a/src/modules/presence/presence_dmq.c +++ b/src/modules/presence/presence_dmq.c @@ -35,7 +35,7 @@ dmq_api_t pres_dmqb; dmq_peer_t *pres_dmq_peer = NULL; dmq_resp_cback_t pres_dmq_resp_callback = {&pres_dmq_resp_callback_f, 0}; -int pres_dmq_send_all_presentities(); +int pres_dmq_send_all_presentities(dmq_node_t *dmq_node); int pres_dmq_request_sync(); /**

1 0

git:master:b0e16a57: call_control: fix warning unused variable
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: b0e16a57eab4d4d4113054aa2b79452da82dd7c9 URL: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:20+02:00 call_control: fix warning unused variable > Warning: call_control.c:1098:7: warning: unused variable 'param' [-Wunused-variable] > int *param; > ^ > Warning: call_control.c:1099:13: warning: unused variable 'type' [-Wunused-variable] > modparam_t type; > ^ > 2 warnings generated. --- Modified: src/modules/call_control/call_control.c --- Diff: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Patch: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index 41b36eeedd6..a635f107324 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -1095,9 +1095,6 @@ static int CallControl(struct sip_msg *msg, char *str1, char *str2) static int mod_init(void) { pv_spec_t avp_spec; - int *param; - modparam_t type; - // initialize the canonical_uri_avp structure if(canonical_uri_avp.spec.s == NULL || canonical_uri_avp.spec.len <= 0) {

1 0

git:master:ce4107a6: tm: fix warning uninitialized variable
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: ce4107a6f654a4bc4462efb90f3cc5e8c73bf9ed URL: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 tm: fix warning uninitialized variable > Warning: t_fwd.c:1919:46: warning: variable 'port' is uninitialized when used here [-Wuninitialized] > ret = forward_request_uac(p_msg, &host, port, &dst); > ^~~~ > t_fwd.c:1843:21: note: initialize the variable 'port' to silence this warning > unsigned short port; > ^ > = 0 > 1 warning generated. --- Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Patch: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… --- diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 9568b6adb1b..23e61ae818b 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1840,7 +1840,7 @@ int t_forward_cancel(struct sip_msg *p_msg, struct proxy_l *proxy, int proto, int new_tran; struct dest_info dst; str host; - unsigned short port; + unsigned short port = 0; short comp; t = 0;

1 0

git:master:9475837b: core/rand: fix -Wdeprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 9475837b209c91366e8bb40416552b02c13aaf3a URL: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 core/rand: fix -Wdeprecated-non-prototype > Warning: core/rand/isaac/rand.c:28:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void isaac(ctx) randctx *ctx; > ^ > Warning: core/rand/isaac/rand.c:81:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void randinit(ctx, flag) randctx *ctx; --- Modified: src/core/rand/isaac/rand.c --- Diff: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Patch: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… --- diff --git a/src/core/rand/isaac/rand.c b/src/core/rand/isaac/rand.c index eb917fdd34f..52d44d5eb6d 100644 --- a/src/core/rand/isaac/rand.c +++ b/src/core/rand/isaac/rand.c @@ -25,7 +25,7 @@ rand.c: By Bob Jenkins. My random number generator, ISAAC. Public Domain. *(r++) = b = ind(mm, y >> RANDSIZL) + x; \ } -void isaac(ctx) randctx *ctx; +void isaac(randctx *ctx) { register ub4 a, b, x, y, *m, *mm, *m2, *r, *mend; mm = ctx->randmem; @@ -78,8 +78,7 @@ void isaac(ctx) randctx *ctx; } /* if (flag==TRUE), then use the contents of randrsl[] to initialize mm[]. */ -void randinit(ctx, flag) randctx *ctx; -word flag; +void randinit(randctx *ctx, word flag) { word i; ub4 a, b, c, d, e, f, g, h;

1 0

[kamailio/kamailio] <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8) (Issue #3971)
by 87LuckyMan321 08 Oct '24

08 Oct '24

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8), called from core: core/xavp.c: xavp_free_unsafe(100), first free core: core/xavp.c: xavp_new_value(116) - ignoring #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.6.4 (x86_64/linux) 0a4d88 (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3971 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3971(a)github.com>

2 3

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)
by Oded Arbel 07 Oct '24

07 Oct '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

6 22

[kamailio/kamailio] IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql (orig. from misc/examples/ims/icscf.sql) (PR #3876)
by markusmonka 03 Oct '24

03 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3876 -- Commit Summary -- * IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql -- File Changes -- A utils/kamctl/mysql/ims-icscf.sql (94) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3876 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3876(a)github.com>

4 8

[kamailio/kamailio] relay to voip provider / sip trunk / path? (Issue #3990)
by gentoosys 02 Oct '24

02 Oct '24

hi. I am using https://github.com/havfo/WEBRTC-to-SIP to have a web sipcaller. it uses kamailio + rtpengine + web sipcaller (jssip) right now it is working using internal account and can call to another sip. But I need to use websipcaller to call to voip provider. I tried to register on my voip provider, and use just outbound websocket proxy, but it not working giving 401 the config I am using is https://github.com/havfo/WEBRTC-to-SIP/blob/master/etc/kamailio/kamailio.cfg Please help adopt it to relay anything to external sip provider. I don't know what I need, relay, sip trunk or path module. kamailio configs are very hard for me to understand. So I need it just as websocket proxy to my voip provider, that doesn't support websocket. thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3990 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3990(a)github.com>

2 3

[kamailio/kamailio] dialog: Remove dlg_flag docs (PR #3975)
by Bastian Triller 02 Oct '24

02 Oct '24

Related to #3961   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3975 -- Commit Summary -- * dialog: Remove dlg_flag docs -- File Changes -- M src/modules/dialog/dlg_handlers.c (2) M src/modules/dialog/doc/dialog_admin.xml (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3975.patch https://github.com/kamailio/kamailio/pull/3975.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3975 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3975(a)github.com>

2 4

git:master:66fe6eb7: dialog: Remove dlg_flag docs
by Xenofon Karamanos 02 Oct '24

02 Oct '24

Module: kamailio Branch: master Commit: 66fe6eb71e58a02222d1a2fb00f9a0cdb863134c URL: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-10-02T10:49:05Z dialog: Remove dlg_flag docs Related to #3961 --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… Patch: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 7e48116a2b9..ee14ef14ca3 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -101,10 +101,10 @@ int dlg_set_tm_waitack(tm_cell_t *t, dlg_cell_t *dlg); /*! * \brief Initialize the dialog handlers * \param rr_param_p added record-route parameter - * \param dlg_flag_p dialog flag * \param timeout_avp_p AVP for timeout setting * \param default_timeout_p default timeout * \param seq_match_mode_p matching mode + * \param keep_proxy_rr_p keep proxy's record-route mode */ void init_dlg_handlers(char *rr_param_p, pv_spec_t *timeout_avp_p, int default_timeout_p, int seq_match_mode_p, int keep_proxy_rr_p)

1 0

[kamailio/kamailio] KSR.dispatcher.ds_is_from_list is returning always true (Issue #3988)
by iliesh 01 Oct '24

01 Oct '24

### Description I'm trying to check if the incoming message is from the dispatcher hosts using KEMI function ds_is_from_list from a lua script: ``` if KSR.dispatcher.ds_is_from_list("-1", "2") then KSR.info("Dispatcher List \n"); return "list" end ``` I'm getting always true if when the source IP of the request is from a different network: ``` /usr/local/sbin/kamcmd dispatcher.list { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:127.0.0.1:5060 FLAGS: AX PRIORITY: 0 LATENCY: { AVG: 0 STD: 0 EST: 0 MAX: 0 TIMEOUT: 0 } } } } } } ``` SIP Request: ``` [info] [sipexer.go:1578] main.SIPExerDialogLoop(): local socket address: 172.16.22.12:45379 (udp) [info] [sipexer.go:1579] main.SIPExerDialogLoop(): local via address: 172.16.22.12:45379 [info] [sipexer.go:1580] main.SIPExerDialogLoop(): sending to udp 192.168.1.1:5060: [[--- OPTIONS sip:192.168.1.1:5060 SIP/2.0 Via: SIP/2.0/UDP 172.16.22.12:45379;rport;branch=z9hG4bKSG.70e3db71-1902-40aa-898b-ba582eefb784 From: <sip:alice@localhost>;tag=4f0ad3f3-1008-49dd-8177-7913ab12cf38 To: <sip:bob@localhost> Call-ID: 4f538d14-e8e4-495b-818a-c595f4457585 CSeq: 977235 OPTIONS Date: Tue, 01 Oct 2024 10:51:14 IST User-Agent: SIPExer v1.1.0 Max-Forwards: 10 Content-Length: 0 ``` Works ok when I'm using this function from the default configuration file: ``` if (ds_is_from_list("-1", "2")) { xlogl("L_INFO","Dispatcher List\n"); exit; } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) ab3530-dirty ``` * **Operating System**: ``` 5.14.0-508.el9.x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3988 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3988(a)github.com>

2 2

git:master:7acfe772: core: socket info - do not use interface index as internal array index
by Daniel-Constantin Mierla 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: 7acfe7723b4772ca45ce31ae98bf3d0b6948f50a URL: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-30T15:43:42+02:00 core: socket info - do not use interface index as internal array index - there are cases when the interface number is high, even if there are only a few real network interfaces, which can result in inability to listen on them --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… Patch: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index c8782bc0b3f..4142ab17dce 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1494,6 +1494,7 @@ static int build_iface_list(void) char name[MAX_IF_LEN]; int is_link_local = 0; int num = 0; + int ifidx = 0; if(ifaces == NULL) { if((ifaces = (struct idxlist *)pkg_malloc( @@ -1621,31 +1622,42 @@ static int build_iface_list(void) } } - if(index >= MAX_IFACE_NO) { - LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", - index, num); - pkg_free(entry); - continue; + for(ifidx = 0; ifidx < MAX_IFACE_NO; ifidx++) { + if(ifaces[ifidx].index == index) { + /* interface with same index already found */ + break; + } + } + if(ifidx == MAX_IFACE_NO) { + if(num == MAX_IFACE_NO) { + LM_ERR("too many interfaces: %d (n: %d) - skipping\n", + index, num); + pkg_free(entry); + goto done; + } + ifidx = num; + num++; } - num++; - if(strlen(ifaces[index].name) == 0 && strlen(name) > 0) { - memcpy(ifaces[index].name, name, MAX_IF_LEN - 1); - ifaces[index].name[MAX_IF_LEN - 1] = '\0'; + if(strlen(ifaces[ifidx].name) == 0 && strlen(name) > 0) { + memcpy(ifaces[ifidx].name, name, MAX_IF_LEN - 1); + ifaces[ifidx].name[MAX_IF_LEN - 1] = '\0'; } - ifaces[index].index = index; + ifaces[ifidx].index = index; - if(ifaces[index].addresses == 0) - ifaces[index].addresses = entry; + if(ifaces[ifidx].addresses == 0) + ifaces[ifidx].addresses = entry; else { - for(tmp = ifaces[index].addresses; tmp->next; + for(tmp = ifaces[ifidx].addresses; tmp->next; tmp = tmp->next) /*empty*/ ; tmp->next = entry; } } } + +done: if(nl_sock > 0) close(nl_sock); /* the socket should be closed so we can bind again */

1 0

git:master:566eec1f: pkg/kamailio/deb: version set 6.0.0~dev3 [skip ci]
by Victor Seva 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: 566eec1f6a035479619f6970c5386d501d5fce23 URL: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-30T13:59:43+02:00 pkg/kamailio/deb: version set 6.0.0~dev3 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5… Patch: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5…

1 0

git:master:b7dcbc37: core: socket info - relocate check for index to get more debugging details
by Daniel-Constantin Mierla 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: b7dcbc37aceaefecf9a0f7367526a331d42269ea URL: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-30T12:55:23+02:00 core: socket info - relocate check for index to get more debugging details --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… Patch: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 281defecffc..c8782bc0b3f 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1555,12 +1555,6 @@ static int build_iface_list(void) rtl = IFA_PAYLOAD(nlp); index = ifi->ifa_index; - num++; - if(index >= MAX_IFACE_NO) { - LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", - index, num); - continue; - } entry = (struct idx *)pkg_malloc(sizeof(struct idx)); if(entry == 0) { @@ -1627,6 +1621,14 @@ static int build_iface_list(void) } } + if(index >= MAX_IFACE_NO) { + LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", + index, num); + pkg_free(entry); + continue; + } + num++; + if(strlen(ifaces[index].name) == 0 && strlen(name) > 0) { memcpy(ifaces[index].name, name, MAX_IF_LEN - 1); ifaces[index].name[MAX_IF_LEN - 1] = '\0';

1 0

[kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)
by JuanPascual2 30 Sep '24

30 Sep '24

Hello The tm.t_uac_start function generates a “tm:local-request” event. But the tm.cancel function doesn't generete “tm:local-request” event. Is it possible to activate a parameter in the TM or TMX module to generate the event? Thanks Juan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3831(a)github.com>

4 12

git:master:ccc10692: tm: move local-request event route to the right location to access CANCEL
by Xenofon Karamanos 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: ccc106922802213253f03f181d10fe83aa93da94 URL: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-09-30T10:56:15+03:00 tm: move local-request event route to the right location to access CANCEL --- Modified: src/modules/tm/t_cancel.c --- Diff: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… Patch: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index 03e919f6abe..753b261111e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -89,11 +89,6 @@ void prepare_to_cancel( int i; int branches_no; branch_bm_t mask; - int rt, backup_rt; - struct run_act_ctx ctx; - sip_msg_t msg; - sr_kemi_eng_t *keng = NULL; - str evname = str_init("tm:local-request"); *cancel_bm = 0; branches_no = t->nr_of_outgoings; @@ -103,49 +98,6 @@ void prepare_to_cancel( *cancel_bm |= ((mask & (1 << i)) && prepare_cancel_branch(t, i, 1)) << i; } - - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, "tm:local-request"); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - return; - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); - return; - } - } - - /* Check if msg is null */ - if(build_sip_msg_from_buf( - &msg, t->uac->request.buffer, t->uac->request.buffer_len, 0) - < 0) { - LM_ERR("fail to parse msg\n"); - return; - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { - - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); - } - } - } - set_route_type(backup_rt); - free_sip_msg(&msg); } @@ -262,6 +214,11 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, struct cancel_info tmp_cd; void *pcbuf; int reply_status; + int rt, backup_rt; + struct run_act_ctx ctx; + sip_msg_t msg; + sr_kemi_eng_t *keng = NULL; + str evname = str_init("tm:local-request"); crb = &t->uac[branch].local_cancel; irb = &t->uac[branch].request; @@ -378,6 +335,46 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, crb->buffer_len = len; LM_DBG("sending cancel...\n"); + + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } + } + + // /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } + + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_ALERT("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } + } + } + set_route_type(backup_rt); + free_sip_msg(&msg); + if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) run_trans_callbacks_with_buf(

1 0

[kamailio/kamailio] t_relay failed when a user has several locations but some of them are stale (Issue #3985)
by Corey 27 Sep '24

27 Sep '24

### Description I followed the page 18~23 of this slide [20-Federico.Cabiddu-Kamailio-In-A-Mobile-World](https://www.kamailio.org/ev… to implement suspension & push notification, it worked well on mobile devices. However, callee might have several location records on some occasions, for instance, they forcibly quit the app or kill the browser, meaning they don't de-register, the location hasn't expired and still exists, but it is stale and unreachable, this makes `t_relay` failed (return code is -2 and didn't trigger failure_route) since Kamailio `lookup` the stale location rather than the new one as they get push notification, below are some part of logs. ``` ERROR: tm [t_fwd.c:484]: prepare_new_uac(): could not build request ERROR: tm [t_fwd.c:1764]: t_forward_nonack(): failure to add branches ERROR: <script>: not t_relay by INVITE -2 ERROR: <script>: check status code is 100 ``` The rest of Kamailio code triggers `sl_reply_error`, caller gets 500 and terminates. ### Expected behavior When callee has several locations, even if some of them are stale, callee should not terminate the call and should find a valid location to ring the target. #### Actual observed behavior Caller finds invalid locations and gets 500 error msg. #### Debugging Data What I have tried 1. Run `suspend` when `t_relay` failed. ``` if (!t_relay()) { revert_uri(); route(SUSPEND); } ``` It doesn't work since `t_continue` still tries to recover the call with the stale location. 2. Run `append_branch` before `t_relay`. ``` if (!lookup("location")) { send_replay("100", "Trying"); route(SUSPEND); } else { append_branch($tu); t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; xdbg("stored transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); } ``` This version of caller won't get 500 and terminate, but callee cannot finds the resumed call. 3. Use `t_load_contacts` and `t_next_contact`. ``` t_load_contacts(); while (t_next_contacts()) { xlog ("==== $ru\n"); } ``` t_next_contacts always return -2 (nothing to do), but I can see the new location via command `kamctl ul show`. #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3985 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3985(a)github.com>

2 4

[kamailio/kamailio] siptrace: handle trace_to_database param at runtime (PR #3877)
by Gustavo Almeida 27 Sep '24

27 Sep '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This change allows to enable/disable the insertion of SIP traces into the DB at runtime (i know we could do this with `siptrace.status`, but this is a different case). This feature is strictly important if you start `Kamailio` with `trace_to_database` parameter disabled, and you want to enable it later and at runtime. Nowadays, if you try to start `Kamailio` with `trace_to_database` enabled, but without a connection to the DB, the service won't start (`child_init` logic). In this type of situation, it makes sense to start `Kamailio` disabling the `trace_to_database` parameter, and when the DB is ok, at runtime, we enable `trace_to_database` parameter. This prevents the need to restart the service, and also we can start `Kamailio` without problems, if DB of SIP Traces is NOK at that time. My PR may need some improvements, especially on the enable side, so feel free to make any changes to improve that. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3877 -- Commit Summary -- * siptrace: handle trace_to_database param at runtime -- File Changes -- M src/modules/siptrace/siptrace.c (100) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3877.patch https://github.com/kamailio/kamailio/pull/3877.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3877 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3877(a)github.com>

4 14

[kamailio/kamailio] core: add support for custom log function (PR #3902)
by Nirv.Ana 26 Sep '24

26 Sep '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Allow Kamailio modules to register their log function so that all Kamailio log messages (coming from core and other modules) are logged uniformly in the format defined by the custom log function. To enable the custom log format feature, Kamailio must be compiled with the `CUSTOM_LOG_FMT` flag. Then the module that wishes to modify the log format has to call `km_custom_log_func_set` during the initialization to supply a custom log formatting function (see `km_default_custom_log_func` as an example). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3902 -- Commit Summary -- * core: add support for custom log function -- File Changes -- M src/core/dprint.c (19) M src/core/dprint.h (47) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3902.patch https://github.com/kamailio/kamailio/pull/3902.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3902 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3902(a)github.com>

4 19

smpp router project
by tarikogut＠gmail.com 25 Sep '24

25 Sep '24

hello i want development about smpp to sip module do you have any documentation ?

3 7

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev