- sr-dev - kamailio.org

git:master:a4f0ee5d: topos: deal with BYE without contact header for mode 1
by Daniel-Constantin Mierla 28 Oct '24

28 Oct '24

Module: kamailio Branch: master Commit: a4f0ee5da93ad64d449c7a95ecad2f3d70aeb975 URL: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-28T06:33:28+01:00 topos: deal with BYE without contact header for mode 1 --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Patch: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index e87232285f6..b0658da36a1 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -297,33 +297,40 @@ int tps_storage_fill_contact( /* extract the contact address */ if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { - LM_WARN("bad sip message or missing Contact hdr\n"); - return -1; - } - if(parse_contact(msg->contact) < 0 - || ((contact_body_t *)msg->contact->parsed)->contacts - == NULL - || ((contact_body_t *)msg->contact->parsed) - ->contacts->next - != NULL) { - LM_ERR("bad Contact header\n"); - return -1; + if(get_cseq(msg)->method_id != METHOD_BYE) { + LM_WARN("bad sip message or missing Contact header\n"); + return -1; + } else { + LM_DBG("BYE with no contact - skipping it\n"); + } } - if(parse_uri(((contact_body_t *)msg->contact->parsed) - ->contacts->uri.s, - ((contact_body_t *)msg->contact->parsed) - ->contacts->uri.len, - &curi) - < 0) { - LM_ERR("failed to parse the contact uri\n"); - return -1; - } - if(curi.user.len > 0) { - memcpy(td->cp, curi.user.s, curi.user.len); - td->cp += curi.user.len; - cuser_len = curi.user.len; - } else { - LM_DBG("no contact user - skipping it\n"); + if(msg->contact != NULL) { + if(parse_contact(msg->contact) < 0 + || ((contact_body_t *)msg->contact->parsed) + ->contacts + == NULL + || ((contact_body_t *)msg->contact->parsed) + ->contacts->next + != NULL) { + LM_ERR("bad Contact header\n"); + return -1; + } + if(parse_uri(((contact_body_t *)msg->contact->parsed) + ->contacts->uri.s, + ((contact_body_t *)msg->contact->parsed) + ->contacts->uri.len, + &curi) + < 0) { + LM_ERR("failed to parse the contact uri\n"); + return -1; + } + if(curi.user.len > 0) { + memcpy(td->cp, curi.user.s, curi.user.len); + td->cp += curi.user.len; + cuser_len = curi.user.len; + } else { + LM_DBG("no contact user - skipping it\n"); + } } } else { /* extract the ruri */

1 0

git:master:d10257fb: core: parser sdp - check len gor extracting fmtp
by Daniel-Constantin Mierla 26 Oct '24

26 Oct '24

Module: kamailio Branch: master Commit: d10257fbfdbb3e3e73c0fe60a224585822bdd7b3 URL: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:46:01+02:00 core: parser sdp - check len gor extracting fmtp --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Patch: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index fe5b464e473..0e61fe5ca5d 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -218,8 +218,12 @@ int extract_fmtp(str *body, str *fmtp_payload, str *fmtp_string) char *cp, *cp1; int len; + if(body->len <= 7) { + return -1; + } if(strncasecmp(body->s, "a=fmtp:", 7) != 0) { - /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", body->len, body->s); */ + /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", + * body->len, body->s); */ return -1; }

1 0

git:master:3e5f8dec: dispatcher: debug messages for checking active destinations
by Daniel-Constantin Mierla 26 Oct '24

26 Oct '24

Module: kamailio Branch: master Commit: 3e5f8deced0cb05710e631601e9098505f1d230a URL: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:40:07+02:00 dispatcher: debug messages for checking active destinations --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Patch: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index f17963cc3bf..83bb7636206 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3945,11 +3945,15 @@ int ds_is_active_uri(sip_msg_t *msg, int group, str *uri) for(j = 0; j < list->nr; j++) { if(!ds_skip_dst(list->dlist[j].flags)) { if(uri == NULL || uri->s == NULL || uri->len <= 0) { + LM_DBG("one destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } if((list->dlist[j].uri.len == uri->len) && (memcmp(list->dlist[j].uri.s, uri->s, uri->len) == 0)) { + LM_DBG("destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } }

1 0

[kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)
by uv-2722 24 Oct '24

24 Oct '24

### Description Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get the following errors during installation. ### Troubleshooting #### Reproduction Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl support. Then install kamailio 5.8.1 from source with db_redis module  #### Log Messages  ``` 37.77 CC (gcc) [M db_redis.so] db_redis_mod.o 37.85 CC (gcc) [M db_redis.so] redis_connection.o 37.90 redis_connection.c: In function 'db_redis_connect': 37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did you mean 'redisContext'? 37.90 129 | redisSSLContext *ssl = NULL; 37.90 | ^~~~~~~~~~~~~~~ 37.90 | redisContext 37.90 redis_connection.c:166:17: warning: implicit declaration of function 'redisInitOpenSSL' [-Wimplicit-function-declaration] 37.90 166 | redisInitOpenSSL(); 37.90 | ^~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:23: warning: implicit declaration of function 'redisCreateSSLContext' [-Wimplicit-function-declaration] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^~~~~~~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^ 37.91 redis_connection.c:196:17: warning: implicit declaration of function 'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? [-Wimplicit-function-declaration] 37.91 196 | redisClusterSetOptionEnableSSL(con->con, ssl); 37.91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37.91 | redisClusterSetOptionMaxRetry 37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1 37.93 make[1]: *** [Makefile:508: modules] Error 1 37.93 make[1]: Leaving directory '/root/build/kamailio/src' 37.93 make: *** [Makefile:34: all] Error 2 ``` ### Additional Information * **Kamailio Version**: ``` Kamailio 5.8.1 ``` * **Operating System**:  ``` Debian 12 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3893 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3893(a)github.com>

4 8

git:master:a6b924be: topos: extended error log message
by Daniel-Constantin Mierla 23 Oct '24

23 Oct '24

Module: kamailio Branch: master Commit: a6b924be7fd7d4ce6a92ad5a0247077b09a29474 URL: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: extended error log message - ensure headers are parsed for storage record --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Patch: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 1fe7319b926..e87232285f6 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,10 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(parse_headers(msg, HDR_EOH_F, 0) == -1) { + return -1; + } + if(get_cseq(msg)->method_id == METHOD_ACK) { if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { /* ACK with no Contact - nothing to store */ @@ -649,7 +653,8 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) return 0; error: - LM_ERR("failed to store\n"); + LM_ERR("failed to store (dlg: %d dir: %d metid: %d)\n", dialog, dir, + get_cseq(msg)->method_id); return ret; }

1 0

git:master:824e8131: topos: catch ACK without contact that needs no storage updates
by Daniel-Constantin Mierla 23 Oct '24

23 Oct '24

Module: kamailio Branch: master Commit: 824e81319b60054feb81c37b3a8be80523f8c95d URL: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: catch ACK without contact that needs no storage updates --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Patch: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 946092c04f9..1fe7319b926 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,12 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(get_cseq(msg)->method_id == METHOD_ACK) { + if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { + /* ACK with no Contact - nothing to store */ + return 0; + } + } if(_tps_context_value.len > 0) { sx = &_tps_context_value; } else if(_tps_context_param.len > 0) {

1 0

[kamailio/kamailio] nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! (Issue #4005)
by Md. Mostafijur Rahman 22 Oct '24

22 Oct '24

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### Log Messages  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.3.9 ``` * **Operating System**:  ``` Centos7 & Debian 12 both have same issue ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4005 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4005(a)github.com>

2 4

[kamailio/kamailio] [JWT Module] Failed to decode JWT value (Issue #4003)
by Lyuboslav Alexandrov 22 Oct '24

22 Oct '24

### Description  Tried to verify a dubious JWT, but I get a token decoding error. I tried different variations of the key, such as `.pem`, `.key` extensions, `PKCS1`, `PKCS8` formats, reading the key from a variable or file. ### Troubleshooting #### Reproduction  Have the following Kamailio config: ``` loadmodule "jwt.so" ... modparam("jwt", "key_mode", 0) .... $var(authorization_header_value) = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiYmQ1NzlhZTYyZjg2ODE5N2I5OTk1YTFkOWM4NGZkOGFiNWIyYWI4Nzk5YzM0OWVmYjBkNjg1NWFiNDcwYWUzOTYyMzFmYzc5NjIxZDQxODciLCJpYXQiOjE3MjkxODU3MTguNjQxMjI1LCJuYmYiOjE3MjkxODU3MTguNjQxMjI"; $var(jwt_verification) = jwt_verify("/etc/kamailio/oauth_pub.pem", "RS256", "sub='$fU'", "$var(authorization_header_value)" ); ... ``` oauth_pub.pem: ``` -----BEGIN PUBLIC KEY----- MIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA5mfAgdn7JaiRS2Bsov4S zTlGLSe2wxbdUxIreTcqs88PmWOBtuSeQg5tU3CRnPtsuuRJrlUniV5g56YAHrnt Qe8meu877iTrcJB6Cii3n+d7SgwCfjMvaFBR+mdGsidAyGBpRhoPrH7SD6CRpBLr Mxylcgqw4uH/0HdF+B8P5motUQz/tul/UKsq1nvC2AOOzFel1IsUah8dQuxzMx+P RYcsngJam8TkGr6QidTXc2rD4lEoCD1s/huGUq55bc19J3yRliN2j8cO9j1bGTsp GYEVtA3PiH/73BZTa3FHbhRYqhvjYacC8eWBFhwThC9CgPyOXrq4L7p9tJAlNwmd dQHhIzZ9vugQuhfnuUTb0/r2tjpsSPL7etgJdxtZ4Xh9aBEpYn//RAgu5Dkauc2S XF+uLWwBptFTM3SNppDPMdjRkYakWjVP2pgBGMmrINFb8RQAPEJzD1gVt0fYCxaY jiazbSc9FPfSbFENHq+r8D7OivpiW0q9+tSZbYmAFzZekoUAoboQThSdRcOy9tFz 196xfg4dOyxkRGGHstz28qBv340ppjnHQd+RZOvbr8s2zEIxGiOpfX8CuLur/nKl Ld3qtzg0caqDz6nsYK+95rExnbtU+gFcHnwtMdk3R8X6lVHzDeTjO2Nk4Zo023zo qFH/rRyJBOp98fQPOpx5qncCAwEAAQ== -----END PUBLIC KEY----- ``` #### Debugging Data  #### Log Messages  ``` [jwt_mod.c:501]: ki_jwt_verify_key(): failed to decode jwt value ``` #### SIP Traffic  ### Possible Solutions  I've wrote a C++ program using `libjwt` to make sure the issue is not neither my key, nor `libjwt`. And they aren't. Here is the program: ```cpp #include <iostream> #include <string> #include <jwt.h> static const char jwt_test[] = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiZDY2NDQ4MTdhYWRhNTQ1MDI1YmUwZmU1M2I1ZmFhYTdkZGI3NTY5NTBiMDYxMzk5MzFmNTQ1ZjhkMmE4N2ZhYjU0ODgzNjJhZGNiMWQ5ZTkiLCJpYXQiOjE3MjkyMjg5NjIuMzg5MDI3LCJuYmYiOjE3MjkyMjg5NjIuMzg5MDMzLCJleHAiOjE3MjkyNzIxNjIuMzc5MTg3LCJzdWIiOiIxNDQ0ODEiLCJzY29wZXMiOltdLCJ1c2VyIjp7ImlkIjoxNDQ0ODEsImFjY291bnRfaWQiOjEyOTMyNn0sIm1veHRyYS10b2tlbiI6Ik1WUXpNekZVTU1hdlFET2hNVlNabEdRZ1ptQUNPRmNGU1JKZEVGNGZTQTFFRWxJLVVCMTRkREZVTVZkbFkxY0xjaHhrWkhrU1pnVjVERUppQ0dKSEJWZGxYQTFMQmwwYUF4MUdHbHdkX0RmbHhORGRNMXMzOXlabjhMMEV5USIsImRldmljZSI6eyJpZCI6ImY4MzI0NDkyLWJiYjQtNGJiNC04ZWQxLWZlMTM1OWQwOTNlNSIsInR5cGUiOiJ3ZWIiLCJ2ZXJzaW9uIjoiMS43LjAifX0.E_6jsC7yxPZgHRry55J0oOBzw25tvlfnWRBqSwLVFeAtavkVrYGmH9BGaByaAhebKNijy2WUg1X8Ug0N9Z9cc3P8u2wDSlvlzTNrxnPqdxMrKtP5wiIbImXboobFqKXLRmbor_9I7r0lBlX-e0xSis-PTaBqH40hDYPj0rR5cqnrszSkEMd2jFdiLL5BoF0pqysvrXA631KKA9oHGzAivib_GOddHeUOAVs7-hMVdnDqgrzZ6lDYkQndutrHpwILZWz09ngJBbRh_mN_cE4dDxghgeSotXADT-h5DlokV8ChkgkmHh6m4gU2lvnb7aY9dbCp9R44T1Rpz1P_HhPQ27p1Sgin40Oc2abBwDePw_chl0ajJHuhJCiK7YHbcmzcv3dZ-igVMYpMqhGIlyyuAHCSrKFVFLhodA1xlyCmMqJfFPOZ6DdKzbAQDWPN2xsCMy7WkGT5KmBQR5wWJRIRbTj4OUWo6iUrQdNyjB0F1RKqkuZlz414Hj0tkS5GlS1rfxOtS4yc2m_ERGomSmpDgoq2zpA5o3oJJWXqA7TzT8X_9Up5DkVQCMGW6Z2OT9Sr8hNjIXB1qgYiiZtNf9_b4bma5JEwVvR2-qcZ92V6owFTYx78smdyOgAaMlBQ_9AM6kARz4ZnC3Mz2feJT2qKLP-z9senqIB8k_xNx2lbU2w"; static unsigned char key[16384]; static size_t key_len; static void read_key(const char *key_file) { FILE *fp = fopen(key_file, "r"); int ret = 0; fp = fopen(key_file, "r"); key_len = fread(key, 1, sizeof(key), fp); fclose(fp); key[key_len] = '\0'; } int main() { jwt_t *jwt = NULL; int ret = 0; read_key("oauth_pub.pem"); ret = jwt_decode(&jwt, jwt_test, key, key_len); printf("Decoding exit status: %d\n", ret); printf("User ID: %s\n", jwt_get_grant(jwt, "sub")); return 0; } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) 3fa5f4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 3fa5f4 compiled on 10:39:56 Jun 12 2024 with gcc 8.5.0 ``` * **Operating System**:  ``` Rocky Linux 8.10 (Green Obsidian) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4003 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4003(a)github.com>

2 3

git:master:c67d8fa0: lrkproxy: use core str comparison functions and macros
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c67d8fa0b1015d73b34430f6f8a6afe22ca10cbe URL: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 lrkproxy: use core str comparison functions and macros --- Modified: src/modules/lrkproxy/lrkproxy_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Patch: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… --- diff --git a/src/modules/lrkproxy/lrkproxy_hash.c b/src/modules/lrkproxy/lrkproxy_hash.c index dc0b365eed6..7daeb6596b1 100644 --- a/src/modules/lrkproxy/lrkproxy_hash.c +++ b/src/modules/lrkproxy/lrkproxy_hash.c @@ -34,24 +34,6 @@ static void lrkproxy_hash_table_free_row_lock(gen_lock_t *row_lock); static struct lrkproxy_hash_table *lrkproxy_hash_table; -/* get from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* get from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* get from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -321,8 +303,8 @@ int lrkproxy_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(lrkproxy_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -403,13 +385,13 @@ int lrkproxy_hash_table_remove(str callid, str viabranch, enum lrk_operation op) viabranch.len, viabranch.s, entry->viabranch.len, entry->viabranch.s); // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE) - || str_equal(entry->callid, callid)) { - // if ((str_equal(entry->callid, callid) && str_equal(entry->viabranch, viabranch)) || - // (str_equal(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { + || STR_EQ(entry->callid, callid)) { + // if ((STR_EQ(entry->callid, callid) && STR_EQ(entry->viabranch, viabranch)) || + // (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry // set pointers; exclude entry @@ -496,10 +478,10 @@ struct lrkproxy_hash_entry *lrkproxy_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0) - || str_equal(entry->callid, callid)) { + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0) + || STR_EQ(entry->callid, callid)) { // node = entry->node; // unlock

1 0

git:master:9ee18988: pipelimit: use core str comparison functions
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 9ee189883549faffb21d3ae113dafd7ad95757af URL: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 pipelimit: use core str comparison functions --- Modified: src/modules/pipelimit/pl_ht.h --- Diff: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Patch: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… --- diff --git a/src/modules/pipelimit/pl_ht.h b/src/modules/pipelimit/pl_ht.h index 8ee6568ea69..86eab1092dc 100644 --- a/src/modules/pipelimit/pl_ht.h +++ b/src/modules/pipelimit/pl_ht.h @@ -98,16 +98,6 @@ typedef struct str_map extern str_map_t algo_names[]; -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - /** * converts a mapped str to an int * \return 0 if found, -1 otherwise @@ -115,7 +105,7 @@ static inline int str_i_cmp(const str *a, const str *b) static inline int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_i_cmp(&map->str, key)) { + if(!str_strcasecmp(&map->str, key)) { *ret = map->id; return 0; }

1 0

git:master:c44a3499: ratelimit: use core str comparison functions
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c44a349964081d397ab9efa3504737bf369f8cf5 URL: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 ratelimit: use core str comparison functions --- Modified: src/modules/ratelimit/ratelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Patch: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… --- diff --git a/src/modules/ratelimit/ratelimit.c b/src/modules/ratelimit/ratelimit.c index 5cac92464db..295102bd08e 100644 --- a/src/modules/ratelimit/ratelimit.c +++ b/src/modules/ratelimit/ratelimit.c @@ -60,9 +60,6 @@ MODULE_VERSION #define RXL(m, str, i) (int)((m)[i].rm_eo - (m)[i].rm_so) #define RXS(m, str, i) (str) + (m)[i].rm_so -static inline int str_cmp(const str *a, const str *b); -static inline int str_i_cmp(const str *a, const str *b); - typedef struct str_map { str str; @@ -256,7 +253,7 @@ struct module_exports exports = { static int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_cmp(&map->str, key)) { + if(!str_strcmp(&map->str, key)) { *ret = map->id; return 0; } @@ -704,16 +701,6 @@ static void destroy(void) } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - str queue_other = str_init("*"); /** @@ -727,10 +714,10 @@ static int find_queue(struct sip_msg *msg, str *method, int *queue) *queue = -1; for(i = 0; i < *nqueues; i++) - if(!str_i_cmp(queues[i].method, method)) { + if(!str_strcasecmp(queues[i].method, method)) { *queue = i; return 0; - } else if(!str_i_cmp(queues[i].method, &queue_other)) { + } else if(!str_strcasecmp(queues[i].method, &queue_other)) { *queue = i; }

1 0

git:master:ef9fa6fb: rtpengine: use core str comparison functions and macros
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: ef9fa6fb34859890afef70fc3803de360979e213 URL: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:34+02:00 rtpengine: use core str comparison functions and macros --- Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Patch: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e31feb3ceeb..e04bb5e9fb3 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -859,11 +859,6 @@ static int bind_force_send_ip(int sock_idx) return 0; } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - static inline int str_eq(const str *p, const char *q) { int l = strlen(q); @@ -963,7 +958,7 @@ struct rtpp_node *get_rtpp_node(struct rtpp_set *rtpp_list, str *url) lock_get(rtpp_list->rset_lock); rtpp_node = rtpp_list->rn_first; while(rtpp_node) { - if(str_cmp(&rtpp_node->rn_url, url) == 0) { + if(str_strcmp(&rtpp_node->rn_url, url) == 0) { lock_release(rtpp_list->rset_lock); return rtpp_node; } @@ -4247,7 +4242,7 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, if(!bencode_dictionary_get_str(tag_dict, "label", &check)) continue; LM_DBG("rtpengine: XXX got label %.*s\n", check.len, check.s); - if(str_cmp(&check, &label)) + if(str_strcmp(&check, &label)) continue; LM_DBG("rtpengine: XXX label match\n"); medias = @@ -5800,4 +5795,4 @@ static int bind_rtpengine(rtpengine_api_t *api) api->rtpengine_delete = ki_rtpengine_delete; return 0; -} \ No newline at end of file +} diff --git a/src/modules/rtpengine/rtpengine_hash.c b/src/modules/rtpengine/rtpengine_hash.c index de6dbc9d5ed..2c7f8f2f0ba 100644 --- a/src/modules/rtpengine/rtpengine_hash.c +++ b/src/modules/rtpengine/rtpengine_hash.c @@ -11,24 +11,6 @@ static void rtpengine_hash_table_free_row_lock(gen_lock_t *row_lock); static struct rtpengine_hash_table *rtpengine_hash_table; -/* from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -254,8 +236,8 @@ int rtpengine_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(rtpengine_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -324,9 +306,9 @@ int rtpengine_hash_table_remove( while(entry) { // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry last_entry->next = entry->next; @@ -407,9 +389,9 @@ struct rtpp_node *rtpengine_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { node = entry->node;

1 0

[kamailio/kamailio] rtpengine: use core STR_EQ macro (PR #4004)
by Victor Seva 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description don't reinvent the wheel and just use core macro You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4004 -- Commit Summary -- * rtpengine: use core STR_EQ macro -- File Changes -- M src/modules/rtpengine/rtpengine.c (11) M src/modules/rtpengine/rtpengine_hash.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4004.patch https://github.com/kamailio/kamailio/pull/4004.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4004 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4004(a)github.com>

1 2

[kamailio/kamailio] [WIP] ims_registrar_scscf: fixing em_max_expires (PR #3989)
by Dragos Vingarzan 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case of Emergency-Registrations the S-CSCF was wrongly setting the expires of the `;sos` contacts to `em_min_expires` if they were above `em_max_expires`. Other smaller related fixes: - Fixed also another typo in the config params definition. - Added some code to more easily make sense of which attributes of a struct are set with what. - Added conditions to respect the parameter documentation which indicate that if set to 0, the expires conditions won't be used. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3989 -- Commit Summary -- * ims_registrar_scscf: fixing em_max_expires -- File Changes -- M src/modules/ims_registrar_scscf/config.c (26) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2) M src/modules/ims_registrar_scscf/save.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3989.patch https://github.com/kamailio/kamailio/pull/3989.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3989 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3989(a)github.com>

1 7

git:master:3f38206d: ims_registrar_scscf: fixing em_max_expires
by Dragos Vingarzan 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 3f38206d88af0fae4c64ee3072eb78ea68f813cb URL: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <dragos(a)neatpath.net> Date: 2024-10-22T16:21:49+02:00 ims_registrar_scscf: fixing em_max_expires --- Modified: src/modules/ims_registrar_scscf/config.c Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c Modified: src/modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… Patch: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… --- diff --git a/src/modules/ims_registrar_scscf/config.c b/src/modules/ims_registrar_scscf/config.c index a01b4185f79..e4a2b5b5a14 100644 --- a/src/modules/ims_registrar_scscf/config.c +++ b/src/modules/ims_registrar_scscf/config.c @@ -31,19 +31,19 @@ #include "config.h" struct cfg_group_registrar default_registrar_cfg = { - 3600, /* default_expires */ - 0, /* default_expires_range */ - 60, /* min_expires */ - 0, /* max_expires */ - 3600, /* emergency contact default expires */ - 60, /* emergency contact max expires */ - 0, /* emergency contact min expires */ - 0, /* max_contacts */ - 0, /* retry_after */ - 0, /* case_sensitive */ - Q_UNSPECIFIED, /* default_q */ - 1, /* append_branches */ - "" /* realm_pref */ + .default_expires = 3600, /* default_expires */ + .default_expires_range = 0, /* default_expires_range */ + .min_expires = 60, /* min_expires */ + .max_expires = 600000, /* max_expires */ + .em_default_expires = 1800, /* emergency contact default expires */ + .em_max_expires = 3600, /* emergency contact max expires */ + .em_min_expires = 0, /* emergency contact min expires */ + .max_contacts = 0, /* max_contacts */ + .retry_after = 0, /* retry_after */ + .case_sensitive = 0, /* case_sensitive */ + .default_q = Q_UNSPECIFIED, /* default_q */ + .append_branches = 1, /* append_branches */ + .realm_pref = "" /* realm_pref */ }; void *registrar_cfg = &default_registrar_cfg; diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c index 08260dcb0a3..9c0b5c534e3 100644 --- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c +++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c @@ -284,7 +284,7 @@ static param_export_t params[] = { {"max_expires", INT_PARAM, &default_registrar_cfg.max_expires}, {"em_default_expires", INT_PARAM, &default_registrar_cfg.em_default_expires}, - {"em_min_expires", INT_PARAM, &default_registrar_cfg.em_max_expires}, + {"em_max_expires", INT_PARAM, &default_registrar_cfg.em_max_expires}, {"em_min_expires", INT_PARAM, &default_registrar_cfg.em_min_expires}, {"default_q", INT_PARAM, &default_registrar_cfg.default_q}, diff --git a/src/modules/ims_registrar_scscf/save.c b/src/modules/ims_registrar_scscf/save.c index cf3bea78277..8c67b62c241 100644 --- a/src/modules/ims_registrar_scscf/save.c +++ b/src/modules/ims_registrar_scscf/save.c @@ -125,20 +125,24 @@ static inline int calc_contact_expires( : default_registrar_cfg.default_expires; goto end; } - if(!sos_reg && r < default_registrar_cfg.min_expires) { + if(!sos_reg && r < default_registrar_cfg.min_expires + && default_registrar_cfg.min_expires != 0) { r = default_registrar_cfg.min_expires; goto end; } - if(sos_reg && r < default_registrar_cfg.em_min_expires) { + if(sos_reg && r < default_registrar_cfg.em_min_expires + && default_registrar_cfg.em_min_expires != 0) { r = default_registrar_cfg.em_min_expires; goto end; } - if(!sos_reg && r > default_registrar_cfg.max_expires) { + if(!sos_reg && r > default_registrar_cfg.max_expires + && default_registrar_cfg.max_expires != 0) { r = default_registrar_cfg.max_expires; goto end; } - if(sos_reg && r > default_registrar_cfg.em_max_expires) { - r = default_registrar_cfg.em_min_expires; + if(sos_reg && r > default_registrar_cfg.em_max_expires + && default_registrar_cfg.em_max_expires != 0) { + r = default_registrar_cfg.em_max_expires; goto end; } end:

1 0

[kamailio/kamailio] Add ims_icscf module db tables schema (PR #3991)
by Xenofon Karamanos 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3876 #### Description  This PR add the schemas for the table needed for the module ims-icscf You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3991 -- Commit Summary -- * Add ims_icscf db schema -- File Changes -- A src/lib/srdb1/schema/kamailio-ims_icscf.xml (14) A src/lib/srdb1/schema/nds_trusted_domains.xml (41) A src/lib/srdb1/schema/s_cscf.xml (49) A src/lib/srdb1/schema/s_cscf_capabilities.xml (58) M utils/kamctl/kamdbctl.base (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3991.patch https://github.com/kamailio/kamailio/pull/3991.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3991 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3991(a)github.com>

2 3

git:master:a0941254: db_schema: Create new table definitions
by Henning Westerholt 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: a094125433122313c2e02dfc0e9ad5d3a5beaa50 URL: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-10-22T12:59:03+02:00 db_schema: Create new table definitions --- Added: utils/kamctl/db_berkeley/kamailio/nds_trusted_domains Added: utils/kamctl/db_berkeley/kamailio/s_cscf Added: utils/kamctl/db_berkeley/kamailio/s_cscf_capabilities Added: utils/kamctl/db_redis/kamailio/nds_trusted_domains Added: utils/kamctl/db_redis/kamailio/s_cscf Added: utils/kamctl/db_redis/kamailio/s_cscf_capabilities Added: utils/kamctl/db_sqlite/ims_icscf-create.sql Added: utils/kamctl/dbtext/kamailio/nds_trusted_domains Added: utils/kamctl/dbtext/kamailio/s_cscf Added: utils/kamctl/dbtext/kamailio/s_cscf_capabilities Added: utils/kamctl/mongodb/kamailio/nds_trusted_domains.json Added: utils/kamctl/mongodb/kamailio/s_cscf.json Added: utils/kamctl/mongodb/kamailio/s_cscf_capabilities.json Added: utils/kamctl/mysql/ims_icscf-create.sql Added: utils/kamctl/oracle/ims_icscf-create.sql Added: utils/kamctl/postgres/ims_icscf-create.sql Added: utils/kamctl/xhttp_pi/ims_icscf-mod Added: utils/kamctl/xhttp_pi/ims_icscf-table Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mongodb/kamailio/version-create.mongo Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d… Patch: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d…

1 0

git:master:e2ea7279: db_schema: Add ims_icscf db schema
by Henning Westerholt 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: e2ea727988828a9683ef112637e25ee4d58032f7 URL: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-10-22T12:59:03+02:00 db_schema: Add ims_icscf db schema --- Added: src/lib/srdb1/schema/kamailio-ims_icscf.xml Added: src/lib/srdb1/schema/nds_trusted_domains.xml Added: src/lib/srdb1/schema/s_cscf.xml Added: src/lib/srdb1/schema/s_cscf_capabilities.xml Modified: utils/kamctl/kamdbctl.base --- Diff: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee… Patch: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee…

1 0

git:master:c823f413: core: parser sdp - check length for rtpmap extract
by Daniel-Constantin Mierla 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c823f41350ab9186a323707e9be32e31922bec17 URL: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-22T07:41:08+02:00 core: parser sdp - check length for rtpmap extract --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… Patch: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a74f78abb84..fe5b464e473 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -151,6 +151,9 @@ int extract_rtpmap(str *body, str *rtpmap_payload, str *rtpmap_encoding, char *cp, *cp1; int len; + if(body->len <= 9) { + return -1; + } if(strncasecmp(body->s, "a=rtpmap:", 9) != 0) { /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", * body->len, body->s); */

1 0

git:master:0cbb2eb0: jwt: print decode result in error log message
by Daniel-Constantin Mierla 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5 URL: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-22T07:34:29+02:00 jwt: print decode result in error log message --- Modified: src/modules/jwt/jwt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Patch: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… --- diff --git a/src/modules/jwt/jwt_mod.c b/src/modules/jwt/jwt_mod.c index 0efb793c47f..af3d42f79c5 100644 --- a/src/modules/jwt/jwt_mod.c +++ b/src/modules/jwt/jwt_mod.c @@ -498,7 +498,7 @@ static int ki_jwt_verify_key( ret = jwt_decode( &jwt, jwtval->s, (unsigned char *)kdata.s, (size_t)kdata.len); if(ret != 0 || jwt == NULL) { - LM_ERR("failed to decode jwt value\n"); + LM_ERR("failed to decode jwt value (ret: %d jwt: %p)\n", ret, jwt); goto error; } if(jwt_validate(jwt, jwt_valid) != 0) {

1 0

git:master:6b7894d6: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 21 Oct '24

21 Oct '24

Module: kamailio Branch: master Commit: 6b7894d66ca65ca99b5987ddc35a7f28c7a88949 URL: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-21T15:01:11+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Patch: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 6b1d875d77e..4658b7a3f35 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -674,15 +674,15 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) to all rtpengines, else no rtpengine will be queried until its rtpengine_disable_tout timeout passes. - Default value is ��1�� (enabled). + Default value is ��0�� (disabled). Can be set at runtime, e.g.: $ kamcmd cfg.set_now_int rtpengine aggressive_redetectio -n 0 +n 1 Example 1.3. Set aggressive_redetection parameter ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... 4.4. rtpengine_tout_ms (integer)

1 0

[kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)
by Stefan Mititelu 21 Oct '24

21 Oct '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #3297 #### Description  The setup is a kamailio with no available rtpengine. (e.g. has a list with rtpengine urls but those are not reachable) Recently had a crash similar to #3297, but in an outdated kamailio version (5.5.7). Tried to reproduce this in 5.5.7 and 5.8.3 but could not crash any of them. However I managed to get the logs similar to ones right before the crash happened: ``` 2024-10-04T17:39:58.026206+03:00 kamailio[450237]: ERROR: {1 1 INVITE 203-450290(a)192.168.100.93} <core> [core/action.c:1595]: run_actions(): alert - action [corefunc (16)] cfg [/home/stefan/kamailio.cfg:625] took too long [29310906 us] ``` ...directly related to how much rtpengine_manage() function took to execute. So routing of SIP is delayed by that ammount. Tracked this in code, down to where this lock is get, when "aggressive_redetection" modparam is enabled: https://github.com/kamailio/kamailio/blob/66fe6eb71e58a02222d1a2fb00f9a0cdb… I will double check that part of the code, since I don't think a lock get is necessary. It only updates a value inside a node, inside the list of nodes, but not changes the list links at all. (this in another PR) For now I propose to disable this aggressive_redetection mechanism by default. Since it delays the SIP routing logic when no rtpengines available (and in some cases lead to crashes in transaction module). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3992 -- Commit Summary -- * rtpengine: disable aggressive redetection by default -- File Changes -- M src/modules/rtpengine/config.c (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3992.patch https://github.com/kamailio/kamailio/pull/3992.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3992(a)github.com>

3 4

git:master:b1aae565: rtpengine: disable aggressive redetection by default (#3992)
by GitHub 21 Oct '24

21 Oct '24

Module: kamailio Branch: master Commit: b1aae5658e84453ce5849a627832efbbb6c20117 URL: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: GitHub <noreply(a)github.com> Date: 2024-10-21T08:53:39-04:00 rtpengine: disable aggressive redetection by default (#3992) --- Modified: src/modules/rtpengine/config.c Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Patch: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… --- diff --git a/src/modules/rtpengine/config.c b/src/modules/rtpengine/config.c index 7ea1a0d68e9..ba2bd5c5747 100644 --- a/src/modules/rtpengine/config.c +++ b/src/modules/rtpengine/config.c @@ -32,7 +32,7 @@ struct cfg_group_rtpengine default_rtpengine_cfg = { 60, /* default disable timeout in seconds */ - 1, /* default aggressive_redetection enabled */ + 0, /* default aggressive_redetection disabled */ 1000, /* default wait timeout in milliseconds */ MAX_RTPP_TRIED_NODES, 5, /* rtprengine retries */ }; diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index f898aa32979..b443fbc0290 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -219,20 +219,20 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) </para> <para> <emphasis> - Default value is <quote>1</quote> (enabled). + Default value is <quote>0</quote> (disabled). </emphasis> </para> <para> Can be set at runtime, e.g.: <programlisting> - $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 0 + $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 1 </programlisting> </para> <example> <title>Set <varname>aggressive_redetection</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... </programlisting> </example>

1 0

[kamailio/kamailio] app_python3s: initial support for free-threading Python (PR #3987)
by space88man 19 Oct '24

19 Oct '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description - Enable `app_python3s` module to build with Free Threading CPython builds - Can be gated with `-DKSR_PYTHON_DISABLE_FREETHREADING` - If Python is a non-free-threading build this change has no effect You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3987 -- Commit Summary -- * app_python3s: initial support for free-threading Python -- File Changes -- M src/modules/app_python3s/apy3s_kemi.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3987.patch https://github.com/kamailio/kamailio/pull/3987.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3987 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3987(a)github.com>

3 17

git:master:62b4ee4a: app_python3s: refactor GIL and thread state handling
by S-P Chan 19 Oct '24

19 Oct '24

Module: kamailio Branch: master Commit: 62b4ee4a0d0b62b35c8bdf67e5daf9cbe9a28499 URL: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: refactor GIL and thread state handling * incorrectly using PyGILState_XXX functions; these functions are for threads launched by Python unaware libraries * if the KEMI script used Python threading these threads would be blocked after returning to the Kamailio event loop as the GIL was not released Fix is to use Py_BLOCK|UNBLOCK_THREADS macros --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Patch: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev