@sergey-safarov: do not use such commit messages when pushing to the repository, write meaningful details in the commit message.
When merging, squash but still be sure such "random characters" or messages like "WIP 1" (seen in another commit by you) are not in the final commit message. The commit messages go in the release files (ie,. ChangeLog) and makes it look really like a not good development process.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/26982449b7dabe0413258a7602d8810…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/26982449b7dabe0413258a7602d88107c8f7e7d9/160433191(a)github.com>
Module: kamailio
Branch: master
Commit: 8ab50bf8a7894e68909c5a81505f5b09e4345802
URL: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-06-20T08:16:03+02:00
dispatcher: docs for ds_mark_addr()
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0…
Patch: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 5c36b3ff9f9..126ad986724 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1786,6 +1786,27 @@ failure_route[tryagain] {
...
}
...
+</programlisting>
+ </example>
+ </section>
+ <section id="dispatcher.f.ds_mark_addr">
+ <title>
+ <function moreinfo="none">ds_mark_addr(state, setid, uri)</function>
+ </title>
+ <para>
+ Set the state to the target specified by setid and uri. The parameter
+ state can have same value as for ds_mark_dst(). All parameters can
+ contain variables.
+ </para>
+ <para>
+ This function can be used from ANY_ROUTE.
+ </para>
+ <example>
+ <title><function>ds_mark_addr</function> usage</title>
+ <programlisting format="linespecific">
+...
+ ds_mark_addr("ip", "1", "sip:127.0.0.1:5080"); # set to inactive and probing
+...
</programlisting>
</example>
</section>
Module: kamailio
Branch: master
Commit: 1f9b9f1305da708461f392e979352464b9c4ee73
URL: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2025-06-19T20:31:10+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246…
Patch: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 32726636469..eecd8bb5f95 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1235,10 +1235,13 @@ modparam("dispatcher", "ds_interval_mode", 7200)
congestion ms.
See also the description of the 'rweight' attribute in the
'Special Attributes' section.
- + “12” - dispatch to all destination in setid at once (parallel
+ + “12” - dispatch to all destinations in setid at once (parallel
forking). Note that the XAVPs are no longer set with the
values of the destination records, no re-routing making sense
- in this case.
+ in this case. A side effect is that marking the one
+ destination as inactive is not possible if the transaction
+ fails (which means that all branches failed, or in other
+ words, all the destinations were not answering the call).
+ “13” - latency optimized dispatching
- The algorithm will load balance using round-robin
prioritizing the gateways with the highest priority.
Module: kamailio
Branch: master
Commit: 1b62f165d541cf88fe37778f0e23232e45e86b3d
URL: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-06-19T20:19:38+02:00
dispatcher: docs - more details about using algorithm 12
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232…
Patch: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index 3a6c26b41b7..5c36b3ff9f9 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1413,10 +1413,13 @@ modparam("dispatcher", "ds_interval_mode", 7200)
</listitem>
<listitem>
<para>
- <quote>12</quote> - dispatch to all destination in setid at
+ <quote>12</quote> - dispatch to all destinations in setid at
once (parallel forking). Note that the XAVPs are no longer set
with the values of the destination records, no re-routing
- making sense in this case.
+ making sense in this case. A side effect is that marking the
+ one destination as inactive is not possible if the transaction fails
+ (which means that all branches failed, or in other words, all the
+ destinations were not answering the call).
</para>
</listitem>
<listitem>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
I have run in to an issue when sending diameter requests using the ims_diameter_server
module. Shared memory keeps increasing and are not being freed until restart of kamailio.
This leads to all shared memory is being used and no more are able to be allocated.
This only happens when the request is sent synchronously. When sent asynchronously shared
memory is being freed as far as I can see.
Following functions have been used for sending requests.
diameter_request([peer], appid, commandcode, message)
diameter_request_async([peer], appid, commandcode, message)
### Troubleshooting
Sent a bunch of diameter requests and verified that shared memory for the following functions are not freed.
do_receive(600):
AAATranslateMessage(500):
AAACreateAVP(137):
#### Reproduction
It's possible to reproduce by sending sync diameter request and verify shared memory.
Example of diameter request block
```
route[CHECK_LOCATION] {
diameter_request("hss.ims.test.local", "16777217", "306",
"[ " +
"{ \"avpCode\":260, \"vendorId\":0, \"Flags\":64,
\"list\":[ { \"avpCode\":266, \"vendorId\":0,
\"Flags\":64, \"int32\":10415 }, { \"avpCode\":258,
\"vendorId\":0, \"Flags\":64, \"int32\":16777217 } ] },
" +
"{ \"avpCode\":277, \"vendorId\":0, \"Flags\":64,
\"int32\":1 }, " +
"{ \"avpCode\":283, \"vendorId\":0, \"Flags\":64,
\"string\":\"ims.test.local\"}, " +
"{ \"avpCode\":706, \"vendorId\":10415,
\"Flags\":192, \"int32\":0 }, " +
"{ \"avpCode\":700, \"vendorId\":10415,
\"Flags\":192, \"list\": [ { \"avpCode\":601,
\"vendorId\":10415, \"Flags\":192,
\"string\":\"tel:" + $fU + "\" }]}, " +
"{ \"avpCode\":707, \"vendorId\":10415,
\"Flags\":192, \"int32\":0 }, " +
"{ \"avpCode\":703, \"vendorId\":10415,
\"Flags\":192, \"int32\":14 } ]");
xlog("L_INFO", "Sent Diameter request");
}
```
Stats
cdp:replies_received = 343310
shmem:fragments = 142
shmem:free_size = 1221489992
shmem:max_used_size = 948242168
shmem:real_used_size = 925993656
shmem:total_size = 2147483648
shmem:used_size = 558205656
kamcmd mod.stats cdp shm
do_receive(600): 256245808
AAATranslateMessage(500): 64420712
AAACreateAVP(137): 218100320
Total: 538774000
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.4 (x86_64/linux) dc393e
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: dc393e
compiled on 13:56:27 Feb 27 2024 with gcc 8.5.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Linux bmatkamas1 4.18.0-553.16.1.el8_10.x86_64 #1 SMP Thu Aug 1 04:16:12 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux release 8.10 (Ootpa)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4116
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4116(a)github.com>
ChristianBergerSipgate created an issue (kamailio/kamailio#4281)
### Description
The rtpengine module uses a `cookie` field in the Protocol controlling rtpengines. This field needs to be unique, and is derived from the `server_id` field set in the Kamailio, the `pid` as well as the value of a variable `myseqn`.
In many conditions, this is random enough. However particularly when using docker, the `pid` will be identical across servers, reducing the randomness and causing collisions.
### Expected behavior
The 34 bytes of the cookie should be as unique as possible.
#### Actual observed behavior
We get collisions many times per day, as different kamailio instances randomly choose the same value.
### Possible Solutions
1. Set `myseqn` to a random value during module load.
2. Add an additional random value to the `gencookie` function.
3. Use `%x` instead of `%d` to squeeze more entropy into the 33 characters available, and perhaps use fixed length fields.
The problem probably also exists in the following other modules:
1. rtpproxy
2. lrkproxy
We are not using those modules so we have not yet experienced collisions here.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4281
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4281(a)github.com>
Module: kamailio
Branch: master
Commit: 300da5c5a166be6724ebe14be29ac97d029c535f
URL: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2025-06-18T10:34:52Z
core: improve random number generator initialization
- move seeding of cryptographic randomness generator for system randomness to the specific generator
- improve seeding of children random number generators by using individual initialized secure generators
- don't add predictable values like system time or process pid to the seed values of children generators
---
Modified: src/core/pt.c
Modified: src/core/rand/cryptorand.c
Modified: src/core/rand/cryptorand.h
Modified: src/core/rand/fortuna/fortuna.c
Modified: src/core/rand/fortuna/fortuna.h
Modified: src/core/rand/fortuna/random.c
Modified: src/core/rand/fortuna/random.h
Modified: src/main.c
---
Diff: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97…
Patch: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97…
### Description
We are using Kamailio 5.7.4 on Debian 12 (from http://deb.kamailio.org/kamailio57) with rtpengine as an Edgeproxy for our clients. The instance terminates SIP/TLS (with Cliencertificates) and forwards the SIP Traffic to internal systems.
After some days we are getting errors like this
`tls_complete_init(): tls: ssl bug #1491 workaround: not enough memory for safe operation: shm=7318616 threshold1=8912896`
First we thought Kamailio just doesnt have enough memory, so we doubled it..
But after some days the Logmessage (and Userissues) occured again.
So we monitored the shmmem statistics and found that used and max_used are constantly growing til it reaches the limit.
As i mentioned we are using client-certificates and so we are also using the CRL feature.
We do have a systemd-timer which fetches the CRL every hour and runs 'kamcmd tls.reload' when finished.
Our tls.cfg looks like this:
```
[server:default]
method = TLSv1.2+
private_key = /etc/letsencrypt/live/hostname.de/privkey.pem
certificate = /etc/letsencrypt/live/hostname.de/fullchain.pem
ca_list = /etc/kamailio/ca_list.pem
ca_path = /etc/kamailio/ca_list.pem
crl = /etc/kamailio/combined.crl.pem
verify_certificate = yes
require_certificate = yes
[client:default]
verify_certificate = yes
require_certificate = yes
```
After testing a bit we found that every time tls.reload is executed Kamailio consumes a bit more memory which eventually leads to all the memory being consumed which leads to issues for our users.
See following example:
```
[0][root@edgar-dev:~]# while true ; do /usr/sbin/kamcmd tls.reload ; /usr/sbin/kamcmd core.shmmem ; sleep 1 ; done
Ok. TLS configuration reloaded.
{
total: 268435456
free: 223001520
used: 41352552
real_used: 45433936
max_used: 45445968
fragments: 73
}
Ok. TLS configuration reloaded.
{
total: 268435456
free: 222377960
used: 41975592
real_used: 46057496
max_used: 46069232
fragments: 78
}
Ok. TLS configuration reloaded.
{
total: 268435456
free: 221748664
used: 42604992
real_used: 46686792
max_used: 46698080
fragments: 77
}
Ok. TLS configuration reloaded.
{
total: 268435456
free: 221110832
used: 43242408
real_used: 47324624
max_used: 47335608
fragments: 81
}
^C
[130][root@edgar-dev:~]#
```
### Troubleshooting
#### Reproduction
Everytime tls.reload is called the memory consumptions grows..
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data!
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
If you let me know what would be interesting for tracking this down, i am happy to provide logs/debugging data!
```
#### SIP Traffic
SIP doesnt seem to be relevant here
### Possible Solutions
Calling tls.reload less often or restart kamailio before memory is consumed ;)
### Additional Information
```
version: kamailio 5.7.4 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 12.2.0
```
* **Operating System**:
```
* Debian GNU/Linux 12 (bookworm)
* Linux edgar-dev 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3823
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3823(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3831 and #4249
#### Description
<!-- Describe your changes in detail -->
This PR intoduces a flag for the tm cancel logic. The flag denotes that the cancel request is locally generated and an event of `local_request` should be emmited.
Updated also the modules and functions that used tm bindings to adopt for this change.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4286
-- Commit Summary --
* tm: Generate local_request for CANCEL only if locally initiated
* dialog: Update to use new tm FLAG for CANCEL
* rtp_media_server: Update to use new tm FLAG for CANCEL
* tmx: Update to use new tm FLAG for CANCEL
-- File Changes --
M src/modules/dialog/dlg_req_within.c (2)
M src/modules/rtp_media_server/rtp_media_server.c (2)
M src/modules/tm/t_cancel.c (69)
M src/modules/tm/t_cancel.h (2)
M src/modules/tmx/tmx_mod.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4286.patchhttps://github.com/kamailio/kamailio/pull/4286.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4286
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4286(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Fix a spelling mistake
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4288
-- Commit Summary --
* dlgs: Fix spelling mistake
-- File Changes --
M src/modules/dlgs/dlgs_records.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4288.patchhttps://github.com/kamailio/kamailio/pull/4288.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4288
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4288(a)github.com>