<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x ] Commit message has the format required by CONTRIBUTING guide
- [x ] Commits are split per component (core, individual modules, libs, utils, ...)
- [x ] Each component has a single commit (if not, squash them into one commit)
- [x ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Added the possibility to specify an alternative file different from the default: `kamailio.cfg`, when starting `kamailio`, using the `kamctl` tool.
This makes it possible to start `kamailio` by passing a startup file located in a specific folder (via `ETCDIR` env variable) and with a specific name, instead of using the default name: `kamailio.cfg`.
Several local tests have been performed and it has been verified that it is now possible to perform the basic start/stop/restart operations of `kamailio` via `kamctl`, considering the use of a startup file other than the default: `kamailio.cfg`.
Example of `.kamctlrc` used:
```sh
ETCDIR="/etc/my-component/confs"
RPCFIFOPATH="/run/my-component/my-component_rpc.fifo"
PID_FILE="/run/my-component/my-component.pid"
STARTUP_CONFIG_FILE="starter.cfg"
STARTOPTIONS="-m 512 -M 64 -u user -g group"
```
Tested on `CentOS Linux release 7.9.2009 (Core)`.
I think this change will be interesting for many users.
Thanks
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3387
-- Commit Summary --
* utils/kamctl: allow the definition of a specific startup file at start process
-- File Changes --
M utils/kamctl/kamctl (8)
M utils/kamctl/kamctlrc (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3387.patchhttps://github.com/kamailio/kamailio/pull/3387.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3387
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3387(a)github.com>
Hello,
I'm interested in retrieving the reception time, in the UDP buffer, of the SIP packets handled by Kamailio.
I see there is a "struct timeval tval" in "struct sip_msg", but this is the timestamp of reading the packet by Kamailio, so not what I'm looking for.
According to the kernel documentation, this could be achieved using SO_TIMESTAMPNS on the socket:
https://www.kernel.org/doc/Documentation/networking/timestamping.txt
Do you think adding this feature to Kamailio could be useful ?
To implement this we would need, I think:
- Only buid this if SO_TIMESTAMPNS is supported (Linux >= 2.6.22)
- Add a configuration to enable / disable this feature
- Set the SO_TIMESTAMPNS flag when creating the socket
- Add a field in "struct sip_msg" to store the new timestamp
- When receiving a packet, read the ancillary data, extract the SO_TIMESTAMPNS information and store the timestamp in "struct sip_msg"
- Provide a new PV to make this accessible from Kamailio script
What do you think ?
Regards,
Nicolas.
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
Hello,
Kamailio SIP Server v5.5.6 stable release is out.
This is a maintenance release of the stable branch 5.5 that
includes fixes since the release of v5.5.5. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.5.x. Deployments running previous v5.5.x
versions are strongly recommended to be upgraded to v5.5.6.
Note that 5.5 is the second last stable branch, still officially maintained
by Kamailio development team. The latest stable branch is 5.6, with
v5.6.4 being release out of it.
For more details about version 5.5.6 (including links and guidelines to
download the tarball or from GIT repository), visit:
* https://www.kamailio.org/w/2023/03/kamailio-v5-5-6-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com
Kamailio Advanced Training - Online - March 27-30, 2023 - www.asipto.com
Hello,
I am considering to release Kamailio v5.5.6 soon, branch on branch 5.5,
likely on Thursday or Wednesday next week (Mar 2/3, 2023). This is the
usual heads up notification to see if anyone is aware of issues not yet
reported to bug tracker and if yes, do it as soon as possible to give
them a chance to be fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com
Kamailio Advanced Training - Online - March 27-30, 2023 - www.asipto.com
Small typo here
`codec-accept=opus`
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/e8c294f33f8b867b0f67d78c14b7327…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/e8c294f33f8b867b0f67d78c14b7327dc22dd726/102410069(a)github.com>
Module: kamailio
Branch: master
Commit: bd497411f2e8e9ee6bd7e47d838add607019e761
URL: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-03-01T13:31:12+01:00
rtpengine: spell fixes in the comments
---
Modified: src/modules/rtpengine/bencode.h
Modified: src/modules/rtpengine/rtpengine.c
Modified: src/modules/rtpengine/rtpengine_funcs.c
---
Diff: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6…
Patch: https://github.com/kamailio/kamailio/commit/bd497411f2e8e9ee6bd7e47d838add6…
---
diff --git a/src/modules/rtpengine/bencode.h b/src/modules/rtpengine/bencode.h
index f2efb742cc..df7fa8be66 100644
--- a/src/modules/rtpengine/bencode.h
+++ b/src/modules/rtpengine/bencode.h
@@ -220,7 +220,7 @@ struct iovec *bencode_iovec(bencode_item_t *root, int *cnt, unsigned int head, u
/* Similar to bencode_iovec(), but instead returns the encoded document as a null-terminated string.
* Memory for the string is allocated from the same bencode_buffer_t object as the "root" object
- * was allocated from. If "len" is a non-NULL pointer, the length of the genrated string is returned
+ * was allocated from. If "len" is a non-NULL pointer, the length of the generated string is returned
* in *len. This is important if the encoded document contains binary data, in which case null
* termination cannot be trusted. The returned string is freed when the corresponding
* bencode_buffer_t object is destroyed. */
diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c
index 46640a5d3d..d0199ec04f 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -1147,8 +1147,8 @@ int add_rtpengine_socks(struct rtpp_set *rtpp_list, char *rtpengine,
}
-/* 0 - succes
- * -1 - erorr
+/* 0 - success
+ * -1 - error
* */
static int rtpengine_add_rtpengine_set(char * rtp_proxies, unsigned int weight, int disabled, unsigned int ticks)
{
diff --git a/src/modules/rtpengine/rtpengine_funcs.c b/src/modules/rtpengine/rtpengine_funcs.c
index 598af6360e..4863ec662c 100644
--- a/src/modules/rtpengine/rtpengine_funcs.c
+++ b/src/modules/rtpengine/rtpengine_funcs.c
@@ -178,8 +178,8 @@ int extract_body(struct sip_msg *msg, str *body )
/*
* Better use the content-len value - no need of any explicit
- * parcing as get_body() parsed all headers and Conten-Length
- * body header is automaticaly parsed when found.
+ * parsing as get_body() parsed all headers and Content-Length
+ * body header is automatically parsed when found.
*/
if (msg->content_length==0) {
LM_ERR("failed to get the content length in message\n");
### Description
Using kamcmd to obtain statistics of SIP replies, for large values (exceeding 4 bytes) :
Example :
```
kamcmd> sl.stats
{
(...)
302: -1294967293
}
```
The variable is an unsigned long, it can store values up to 2^64-1.
But RPC command **sl.stats** does not support this.
### Possible Solutions
I think the fix is simple, we should just replace "d" by "j" when using "rpc->struct_add"
(function "rpc_stats" in file src/modules/sl/sl_stats.c).
E.g. :
```
rpc->struct_add(st, "jjjj",
"300", total.err[RT_300],
"301", total.err[RT_301],
"302", total.err[RT_302],
"3xx", total.err[RT_3xx]);
```
I found a commit that did something similar with the shared memory stats :
https://github.com/kamailio/kamailio/commit/f619cae55ffeb4596da852d9ed75773…
### Additional Information
Kamailio 5.6.4
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3386
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3386(a)github.com>
We have loaded the tls.so module in the kamailio.cfg file and the kamailio process is up and running, however we are not sure whether the TLS module is loaded properly or not.
Here are a few configuration details.
#!ifdef WITH_TLS
loadmodule "tls.so"
#!endif
#!ifdef WITH_TLS
enable_tls=yes
#!endif
#!ifdef WITH_TLS
## ----- tls params -----
modparam("tls", "config", "/etc/kamailio/tls.cfg")
#!endif
$kamailio -v
version: kamailio 5.5.3 (x86_64/linux) d31ff9-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: d31ff9 -dirty
compiled on 10:08:08 May 24 2022 with gcc 8.5.0
# openssl version
OpenSSL 1.1.1k FIPS 25 Mar 2021
# ldd /usr/lib64/kamailio/modules/tls.so
linux-vdso.so.1 (0x00007ffc0cbf2000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f2c3bcc1000)
libm.so.6 => /lib64/libm.so.6 (0x00007f2c3b93f000)
libssl.so.1.1 => /lib64/libssl.so.1.1 (0x00007f2c3b6ab000)
libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x00007f2c3b1c2000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f2c3afa2000)
libc.so.6 => /lib64/libc.so.6 (0x00007f2c3abdd000)
/lib64/ld-linux-x86-64.so.2 (0x00007f2c3c170000)
libz.so.1 => /lib64/libz.so.1 (0x00007f2c3a9c5000)
When we try to check tls rpc cli's it shows command not found
# kamcmd [tls.info](http://tls.info/)
error: 500 - command [tls.info](http://tls.info/) not found
# kamcmd tls.reload
error: 500 - command tls.reload not found
We have compiled the kamailio-5.5.3 version using the kamailio.spec file.
kamailio-tls-5.5.3-5.el8.x86_64 rpm installed to load the tls.so module.
Operating System : Red Hat Enterprise Linux release 8.6 (Ootpa)
Please suggest to me anything we have missed to configure or compilation wise.
Also suggest to me how to verify the tls module and configuration is fine or not.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3385
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3385(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Commands for get/set described in documentation are not working giving 500 errors in a case if key value is integer value. If attach s: to key name it all work as expected (as was advised in [the mailing list](https://www.mail-archive.com/sr-users@lists.kamailio.org/msg16436.htm… by Fred Posner)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3383
-- Commit Summary --
* doc/htable: adding examples in a case of key value is an integer
-- File Changes --
M src/modules/htable/doc/htable_admin.xml (42)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3383.patchhttps://github.com/kamailio/kamailio/pull/3383.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3383
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3383(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Commands for get/set described in documentation are not working giving 500 errors. If attach `s:` to key name it all work as expected (as was advised in [the mailing list](https://www.mail-archive.com/sr-users@lists.kamailio.org/msg16436.htm… by Fred Posner)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3382
-- Commit Summary --
* doc/htable: fix documentation for rpc commands
-- File Changes --
M src/modules/htable/doc/htable_admin.xml (51)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3382.patchhttps://github.com/kamailio/kamailio/pull/3382.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3382
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3382(a)github.com>