- sr-dev - kamailio.org

[kamailio/kamailio] Fix python threading setup for threads_mode = 1 (Issue #4213)
by space88man 22 Apr '25

22 Apr '25

space88man created an issue (kamailio/kamailio#4213) ### Description During GIL refactoring as part of enablement of free-threading in Python: - app_python3s 62b4ee4 - app_python3 0ffe157 an incorrect storage specifier was used to save PyThreadState. This result in deadlock in the KEMI modules This issue is a placeholder for the correct threading fix for `threads_mode = 1` Note that `threads_mode = 0` (the default) is the original threading model ### Reference See gh #4153 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4213 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4213(a)github.com>

1 2

git:6.0:be2fae40: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: be2fae4075fc23582356e416e1bdbb475d837eda URL: https://github.com/kamailio/kamailio/commit/be2fae4075fc23582356e416e1bdbb4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-22T02:01:20+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/app_python3/README Modified: src/modules/app_python3s/README --- Diff: https://github.com/kamailio/kamailio/commit/be2fae4075fc23582356e416e1bdbb4… Patch: https://github.com/kamailio/kamailio/commit/be2fae4075fc23582356e416e1bdbb4… --- diff --git a/src/modules/app_python3/README b/src/modules/app_python3/README index 5a012417df5..98d7c3725bc 100644 --- a/src/modules/app_python3/README +++ b/src/modules/app_python3/README @@ -177,6 +177,10 @@ modparam("app_python3", "child_init_method", "my_child_init") If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). + If set to 1, Python threading Thread objects created in the KEMI script + will be scheduled. Otherwise, additional Python threads will not be + scheduled (no release of GIL). + Default value is “0”. Example 1.4. Set threads_mode parameter diff --git a/src/modules/app_python3s/README b/src/modules/app_python3s/README index af38af3e8e0..cf79c7fed56 100644 --- a/src/modules/app_python3s/README +++ b/src/modules/app_python3s/README @@ -174,6 +174,10 @@ def ksr_script_child_init(): If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). + If set to 1, Python threading Thread objects created in the KEMI script + will be scheduled. Otherwise, additional Python threads will not be + scheduled (no release of GIL). + Default value is “0”. Example 1.4. Set threads_mode parameter

1 0

git:master:570db90c: modules: readme files regenerated - app_python3 ... [skip ci]
by Kamailio Dev 22 Apr '25

22 Apr '25

Module: kamailio Branch: master Commit: 570db90ccacbe02419fdc9d7c4b8b115f6fb1540 URL: https://github.com/kamailio/kamailio/commit/570db90ccacbe02419fdc9d7c4b8b11… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-22T02:01:10+02:00 modules: readme files regenerated - app_python3 ... [skip ci] --- Modified: src/modules/app_python3/README Modified: src/modules/app_python3s/README --- Diff: https://github.com/kamailio/kamailio/commit/570db90ccacbe02419fdc9d7c4b8b11… Patch: https://github.com/kamailio/kamailio/commit/570db90ccacbe02419fdc9d7c4b8b11… --- diff --git a/src/modules/app_python3/README b/src/modules/app_python3/README index 5a012417df5..98d7c3725bc 100644 --- a/src/modules/app_python3/README +++ b/src/modules/app_python3/README @@ -177,6 +177,10 @@ modparam("app_python3", "child_init_method", "my_child_init") If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). + If set to 1, Python threading Thread objects created in the KEMI script + will be scheduled. Otherwise, additional Python threads will not be + scheduled (no release of GIL). + Default value is “0”. Example 1.4. Set threads_mode parameter diff --git a/src/modules/app_python3s/README b/src/modules/app_python3s/README index af38af3e8e0..cf79c7fed56 100644 --- a/src/modules/app_python3s/README +++ b/src/modules/app_python3s/README @@ -174,6 +174,10 @@ def ksr_script_child_init(): If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). + If set to 1, Python threading Thread objects created in the KEMI script + will be scheduled. Otherwise, additional Python threads will not be + scheduled (no release of GIL). + Default value is “0”. Example 1.4. Set threads_mode parameter

1 0

git:6.0:265e0f78: app_python3s: update docs for threads_mode parameter
by S-P Chan 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: 265e0f78bd0ecf34c0356ad4ffe8a9d9cf4a9594 URL: https://github.com/kamailio/kamailio/commit/265e0f78bd0ecf34c0356ad4ffe8a9d… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:59:01+08:00 app_python3s: update docs for threads_mode parameter (cherry picked from commit fcedbd7099a15e09d1dd21c933f3ebfe3c55f5c5) --- Modified: src/modules/app_python3s/doc/app_python3s_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/265e0f78bd0ecf34c0356ad4ffe8a9d… Patch: https://github.com/kamailio/kamailio/commit/265e0f78bd0ecf34c0356ad4ffe8a9d… --- diff --git a/src/modules/app_python3s/doc/app_python3s_admin.xml b/src/modules/app_python3s/doc/app_python3s_admin.xml index 8381dda274f..bb9e86c8c5c 100644 --- a/src/modules/app_python3s/doc/app_python3s_admin.xml +++ b/src/modules/app_python3s/doc/app_python3s_admin.xml @@ -160,6 +160,10 @@ def ksr_script_child_init(): v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:6.0:5406da9c: app_python3: update docs for threads_mode parameter
by S-P Chan 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: 5406da9cf265f6dc80beeb9bea642bf8dd87be32 URL: https://github.com/kamailio/kamailio/commit/5406da9cf265f6dc80beeb9bea642bf… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:58:43+08:00 app_python3: update docs for threads_mode parameter (cherry picked from commit 168d289ebd6daadf58199f4461ef7cd30dc7442a) --- Modified: src/modules/app_python3/doc/app_python3_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5406da9cf265f6dc80beeb9bea642bf… Patch: https://github.com/kamailio/kamailio/commit/5406da9cf265f6dc80beeb9bea642bf… --- diff --git a/src/modules/app_python3/doc/app_python3_admin.xml b/src/modules/app_python3/doc/app_python3_admin.xml index 87b97f0824d..20eeae6ffce 100644 --- a/src/modules/app_python3/doc/app_python3_admin.xml +++ b/src/modules/app_python3/doc/app_python3_admin.xml @@ -168,6 +168,10 @@ modparam("app_python3", "child_init_method", "my_child_init") v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:6.0:9e8e6efc: app_python3s: fix threads_mode = 1
by S-P Chan 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: 9e8e6efc812795498d6d540c9f4afcae30965e35 URL: https://github.com/kamailio/kamailio/commit/9e8e6efc812795498d6d540c9f4afca… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:58:18+08:00 app_python3s: fix threads_mode = 1 - fixes gh #4153 - commit 62b4ee4: incorrect use of thread-local storage to save python thread state (cherry picked from commit 779cb229ba9a693ac241f4b359c596c0ed46bb7b) --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/9e8e6efc812795498d6d540c9f4afca… Patch: https://github.com/kamailio/kamailio/commit/9e8e6efc812795498d6d540c9f4afca… --- diff --git a/src/modules/app_python3s/app_python3s_mod.c b/src/modules/app_python3s/app_python3s_mod.c index a99154366ad..876bd3c2a20 100644 --- a/src/modules/app_python3s/app_python3s_mod.c +++ b/src/modules/app_python3s/app_python3s_mod.c @@ -60,7 +60,7 @@ int _apy3s_process_rank = 0; int _ksr_apy3s_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; static int apy3s_script_init_exec(PyObject *pModule, str *fname, int *vparam); diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index c25ccfdc91a..48ee1c46b67 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -52,7 +52,7 @@ extern str _sr_python_load_file; extern int _apy3s_process_rank; extern int _ksr_apy3s_threads_mode; -extern __thread PyThreadState *_save; +extern PyThreadState *_save; int apy_reload_script(void); @@ -69,8 +69,6 @@ sr_apy_env_t *sr_apy_env_get() /** * */ -extern __thread PyThreadState *_save; - int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) { PyObject *pFunc, *pArgs, *pValue;

1 0

git:6.0:24b095d8: app_python3: fix threads_mode = 1
by S-P Chan 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: 24b095d86ae3288dac2e703dc865f9b43a7c40c6 URL: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:57:46+08:00 app_python3: fix threads_mode = 1 - fixes gh #4153 - commit 0ffe157: incorrect use of thread-local storage to save python thread state (cherry picked from commit 9c746b26bf7ecb4922f445318de7756d21e0d041) --- Modified: src/modules/app_python3/app_python3_mod.c Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… Patch: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… --- diff --git a/src/modules/app_python3/app_python3_mod.c b/src/modules/app_python3/app_python3_mod.c index 7436d528f26..a25a0e354af 100644 --- a/src/modules/app_python3/app_python3_mod.c +++ b/src/modules/app_python3/app_python3_mod.c @@ -59,7 +59,7 @@ int _apy_process_rank = 0; int _ksr_apy3_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; /* clang-format off */ /** module parameters */ diff --git a/src/modules/app_python3/python_exec.c b/src/modules/app_python3/python_exec.c index 3c62265abf6..d4c0f519d1c 100644 --- a/src/modules/app_python3/python_exec.c +++ b/src/modules/app_python3/python_exec.c @@ -49,7 +49,7 @@ sr_apy_env_t *sr_apy_env_get() return &_sr_apy_env; } -extern __thread PyThreadState *_save; +extern PyThreadState *_save; extern int _ksr_apy3_threads_mode; #define LOCK_RELEASE \

1 0

git:master:fcedbd70: app_python3s: update docs for threads_mode parameter
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: fcedbd7099a15e09d1dd21c933f3ebfe3c55f5c5 URL: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3s: update docs for threads_mode parameter --- Modified: src/modules/app_python3s/doc/app_python3s_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… Patch: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… --- diff --git a/src/modules/app_python3s/doc/app_python3s_admin.xml b/src/modules/app_python3s/doc/app_python3s_admin.xml index 8381dda274f..bb9e86c8c5c 100644 --- a/src/modules/app_python3s/doc/app_python3s_admin.xml +++ b/src/modules/app_python3s/doc/app_python3s_admin.xml @@ -160,6 +160,10 @@ def ksr_script_child_init(): v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:master:168d289e: app_python3: update docs for threads_mode parameter
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 168d289ebd6daadf58199f4461ef7cd30dc7442a URL: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3: update docs for threads_mode parameter --- Modified: src/modules/app_python3/doc/app_python3_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… Patch: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… --- diff --git a/src/modules/app_python3/doc/app_python3_admin.xml b/src/modules/app_python3/doc/app_python3_admin.xml index 87b97f0824d..20eeae6ffce 100644 --- a/src/modules/app_python3/doc/app_python3_admin.xml +++ b/src/modules/app_python3/doc/app_python3_admin.xml @@ -168,6 +168,10 @@ modparam("app_python3", "child_init_method", "my_child_init") v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:master:779cb229: app_python3s: fix threads_mode = 1
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 779cb229ba9a693ac241f4b359c596c0ed46bb7b URL: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3s: fix threads_mode = 1 - fixes gh #4153 - commit 62b4ee4: incorrect use of thread-local storage to save python thread state --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… Patch: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… --- diff --git a/src/modules/app_python3s/app_python3s_mod.c b/src/modules/app_python3s/app_python3s_mod.c index a99154366ad..876bd3c2a20 100644 --- a/src/modules/app_python3s/app_python3s_mod.c +++ b/src/modules/app_python3s/app_python3s_mod.c @@ -60,7 +60,7 @@ int _apy3s_process_rank = 0; int _ksr_apy3s_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; static int apy3s_script_init_exec(PyObject *pModule, str *fname, int *vparam); diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index c25ccfdc91a..48ee1c46b67 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -52,7 +52,7 @@ extern str _sr_python_load_file; extern int _apy3s_process_rank; extern int _ksr_apy3s_threads_mode; -extern __thread PyThreadState *_save; +extern PyThreadState *_save; int apy_reload_script(void); @@ -69,8 +69,6 @@ sr_apy_env_t *sr_apy_env_get() /** * */ -extern __thread PyThreadState *_save; - int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) { PyObject *pFunc, *pArgs, *pValue;

1 0

git:master:9c746b26: app_python3: fix threads_mode = 1
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 9c746b26bf7ecb4922f445318de7756d21e0d041 URL: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3: fix threads_mode = 1 - fixes gh #4153 - commit 0ffe157: incorrect use of thread-local storage to save python thread state --- Modified: src/modules/app_python3/app_python3_mod.c Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… Patch: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… --- diff --git a/src/modules/app_python3/app_python3_mod.c b/src/modules/app_python3/app_python3_mod.c index 7436d528f26..a25a0e354af 100644 --- a/src/modules/app_python3/app_python3_mod.c +++ b/src/modules/app_python3/app_python3_mod.c @@ -59,7 +59,7 @@ int _apy_process_rank = 0; int _ksr_apy3_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; /* clang-format off */ /** module parameters */ diff --git a/src/modules/app_python3/python_exec.c b/src/modules/app_python3/python_exec.c index 3c62265abf6..d4c0f519d1c 100644 --- a/src/modules/app_python3/python_exec.c +++ b/src/modules/app_python3/python_exec.c @@ -49,7 +49,7 @@ sr_apy_env_t *sr_apy_env_get() return &_sr_apy_env; } -extern __thread PyThreadState *_save; +extern PyThreadState *_save; extern int _ksr_apy3_threads_mode; #define LOCK_RELEASE \

1 0

git:master:47aa53eb: cdp: free in case of errors inside load_certificates()
by Daniel-Constantin Mierla 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 47aa53ebd55eba4b36c38329f8619d9f7d20c076 URL: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-21T08:24:18+02:00 cdp: free in case of errors inside load_certificates() --- Modified: src/modules/cdp/cdp_tls.c --- Diff: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… Patch: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… --- diff --git a/src/modules/cdp/cdp_tls.c b/src/modules/cdp/cdp_tls.c index a3cfdfa9252..f2c7c7b8b63 100644 --- a/src/modules/cdp/cdp_tls.c +++ b/src/modules/cdp/cdp_tls.c @@ -149,16 +149,20 @@ int load_certificates(SSL_CTX *ctx, str *cert, str *key) } if(pkg_str_dup(&key_fixed, key) < 0) { LM_ERR("Failed to copy key parameter\n"); + pkg_free(cert_fixed.s); return -1; } if(!SSL_CTX_use_certificate_chain_file(ctx, cert_fixed.s)) { LM_ERR("Unable to load certificate file\n"); TLS_LM_ERR("load_cert:", ctx); + pkg_free(key_fixed.s); + pkg_free(cert_fixed.s); return -1; } if(SSL_CTX_use_PrivateKey_file(ctx, key_fixed.s, SSL_FILETYPE_PEM) <= 0) { LM_ERR("Unable to load private key file\n"); TLS_LM_ERR("load_private_key:", ctx); + pkg_free(key_fixed.s); return -1; } if(!SSL_CTX_check_private_key(ctx)) {

1 0

git:master:5aee159c: prefix_route: more debug messages
by Daniel-Constantin Mierla 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 5aee159c2881aff29a2973073e1dd6c5c61bfdb9 URL: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-20T09:15:59+02:00 prefix_route: more debug messages - GH #4218 --- Modified: src/modules/prefix_route/prefix_route.c --- Diff: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… Patch: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… --- diff --git a/src/modules/prefix_route/prefix_route.c b/src/modules/prefix_route/prefix_route.c index 686962089b5..92059cd5497 100644 --- a/src/modules/prefix_route/prefix_route.c +++ b/src/modules/prefix_route/prefix_route.c @@ -262,16 +262,20 @@ static int ki_prefix_route(sip_msg_t *msg, str *ruser) int err; int route; + LM_DBG("trying to run route block for [%.*s]\n", ruser->len, ruser->s); route = tree_route_get(ruser); - if(route <= 0) + if(route <= 0) { + LM_DBG("route block for [%.*s] not found\n", ruser->len, ruser->s); return -1; + } /* If match send to route[x] */ init_run_actions_ctx(&ra_ctx); err = run_actions(&ra_ctx, main_rt.rlist[route], msg); if(err < 0) { - LM_ERR("run_actions failed (%d)\n", err); + LM_ERR("run actions failed (%d) for [%.*s]\n", err, ruser->len, + ruser->s); return -1; }

1 0

[kamailio/kamailio] Error when sending NOTIFYs in the presence of disconnected websocket watchers (Issue #4118)
by Flavio Grossi 20 Apr '25

20 Apr '25

### Description if multiple sip websocket clients are subscribed to some UA and one of the watchers suddenly disappears (e.g. the web page is reloaded), then no NOTIFY is ever sent after issuing a `pres_refresh_watchers()`. The following error is logged: ``` WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found ERROR: tm [t_msgbuilder.c:1423]: assemble_via(): via building failed ERROR: tm [t_msgbuilder.c:1614]: build_uac_req(): error while assembling Via ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message ERROR: presence [notify.c:1734]: send_notify_request(): in function tm t_request_within() ERROR: presence [notify.c:1829]: notify(): sending Notify not successful ERROR: presence [notify.c:1585]: query_db_notify(): Could not send notify for [event]=dialog ERROR: presence [presence.c:739]: pres_refresh_watchers(): sending Notify requests ``` ### Troubleshooting when the client disconnects, the old watcher is not removed from the active_watchers table, instead it coexists with the new one, but the stale connection causes the error above when sending the notify, and then all of the following watchers (even the valid ones) are skipped too. Looking at the logs, the valid watchers are not notified because the while loop [here](https://github.com/kamailio/kamailio/blob/b96bc11a54f11ec688429c057bf… is skipped because of the `goto done` line in case of errors, which happens because it fails to build the via header for the message relevant to the stale websocket connection. By breaking out of the while loop, the remaining subs in the `subs_array` are skipped. #### Reproduction Just subscribe to a sip client using a websocket-based phone, then abruptly disconnect it (e.g. by reloading the web page) and then issue a `pres_refresh_watchers()` to make it generate a notify. #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions I tried to use the "websocket:closed" route to purge stale connections, but to my knowledge there are no APIs to clean invalid watchers. A possible solution could be to automatically remove the watchers on disconnection and maybe skip the invalid ones without exiting from the refresh loop ### Additional Information kamailio 5.8.2 * **Operating System**: Rocky Linux 9 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4118 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4118(a)github.com>

4 5

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)
by Dmitry Sinina 20 Apr '25

20 Apr '25

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

3 10

[kamailio/kamailio] cfgutils.unlock [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 (Issue #4216)
by space88man 19 Apr '25

19 Apr '25

space88man created an issue (kamailio/kamailio#4216) ### Description Use cfgengine python and KSR.cfgutils.unlock ### Troubleshooting #### Reproduction In cfgengine python call ``` KSR.cfgutils.lock("something") # do some work KSR.cfgutils.unlock("something") ``` #### Debugging Data n/a #### Log Messages ```ERROR: app_python3 [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 17:27:30 Mar 29 2025 with gcc 8.5.0 ``` * **Operating System**: ``` AlmaLinux 9.5 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4216 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4216(a)github.com>

2 2

git:master:204839ec: cfgutils: kemi export try/un/lock_key2() functions
by Daniel-Constantin Mierla 19 Apr '25

19 Apr '25

Module: kamailio Branch: master Commit: 204839ec9aeb0f31425732dd0a2e8e256481dae5 URL: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-19T09:25:19+02:00 cfgutils: kemi export try/un/lock_key2() functions - different kemi functions cannot be exported with same name, even if they have different number of parameters - GH #4216 --- Modified: src/modules/cfgutils/cfgutils.c --- Diff: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… Patch: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… --- diff --git a/src/modules/cfgutils/cfgutils.c b/src/modules/cfgutils/cfgutils.c index fd0a5e5b2b3..2d3809e670c 100644 --- a/src/modules/cfgutils/cfgutils.c +++ b/src/modules/cfgutils/cfgutils.c @@ -1050,7 +1050,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("lock"), + { str_init("cfgutils"), str_init("lock_key2"), SR_KEMIP_INT, cfg_lock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } @@ -1060,7 +1060,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("unlock"), + { str_init("cfgutils"), str_init("unlock_key2"), SR_KEMIP_INT, cfg_unlock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } @@ -1070,7 +1070,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("trylock"), + { str_init("cfgutils"), str_init("trylock_key2"), SR_KEMIP_INT, cfg_trylock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }

1 0

git:master:cb915a51: core: use ULL constant to induce value size
by Daniel-Constantin Mierla 19 Apr '25

19 Apr '25

Module: kamailio Branch: master Commit: cb915a518106c49c2d71308396feee9ba5149e39 URL: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-19T09:21:19+02:00 core: use ULL constant to induce value size --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… Patch: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 09749bcee11..7cbe6153824 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1030,7 +1030,7 @@ int check_freq_interval(tmrec_t *_trp, ac_tm_t *_atp) ? REC_MATCH : REC_NOMATCH; case FREQ_MONTHLY: - _t0 = (_atp->t.tm_year - _trp->ts.tm_year) * 12 + _atp->t.tm_mon + _t0 = 12ULL * (_atp->t.tm_year - _trp->ts.tm_year) + _atp->t.tm_mon - _trp->ts.tm_mon; return (_t0 % _trp->interval == 0) ? REC_MATCH : REC_NOMATCH; case FREQ_YEARLY:

1 0

[kamailio/kamailio] path: add_path_received() appends transport=ws instead of transport=wss (Issue #4168)
by Christian Berger 19 Apr '25

19 Apr '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4168) We think we have found a potential bug in the path module. When we call `add_path_received()` we get the following for WSS connections: `Path: <sip:217.10.77.242;lr;received=sip:217.10.69.93:42612%3Btransport%3Dws>` We think there should be a `transport%3Dwss` appended instead of ws. We have looked a bit into the code and think that this is caused by the following definition: ``` in modules/path/path.c const static char *proto_strings[] = { [PROTO_TCP] = "%3Btransport%3Dtcp", [PROTO_TLS] = "%3Btransport%3Dtls", [PROTO_SCTP] = "%3Btransport%3Dsctp", [PROTO_WS] = "%3Btransport%3Dws", [PROTO_WSS] = "%3Btransport%3Dws", }; ``` We think that on the last line, it should read ` [PROTO_WSS] = "%3Btransport%3Dwss",` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4168 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4168(a)github.com>

5 5

git:master:e9c519ad: textops: simplify return code when removing via param
by Daniel-Constantin Mierla 18 Apr '25

18 Apr '25

Module: kamailio Branch: master Commit: e9c519ad4d49b8c74069577edb84ce02a5e63ee0 URL: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-18T10:21:00+02:00 textops: simplify return code when removing via param --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… Patch: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index db1929e0127..aee46a301a6 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -5037,7 +5037,7 @@ static int ki_via_param_rm(sip_msg_t *msg, str *name, int idx) } } } - return (ret == 0) ? -1 : ret; + return -1; } /**

1 0

git:master:2b331d95: microhttpd: warning on failing to add content-type
by Daniel-Constantin Mierla 18 Apr '25

18 Apr '25

Module: kamailio Branch: master Commit: 2b331d95ae62eb0000a289e1bdb668ee7bc572cb URL: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-18T10:21:00+02:00 microhttpd: warning on failing to add content-type --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… Patch: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index 7bd8d304644..ff486ac7dd6 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -373,7 +373,10 @@ static int ksr_mhttpd_send_reply( return -1; } if(sctype->len > 0) { - MHD_add_response_header(response, "Content-Type", sctype->s); + if(MHD_add_response_header(response, "Content-Type", sctype->s) + == MHD_NO) { + LM_WARN("failed to add Content-Type header\n"); + } } ret = MHD_queue_response( _ksr_mhttpd_ctx.connection, (unsigned int)rcode, response);

1 0

Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,bullseye #2965
by kamailio＠sipwise.com 18 Apr '25

18 Apr '25

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> Changes: ------------------------------------------ [...truncated 67.07 KiB...] I: new cache content 'libicu67_67.1-7_amd64.deb' added I: new cache content 'libltdl7_2.4.6-15_amd64.deb' added I: new cache content 'dwz_0.13+20210201-1_amd64.deb' added I: new cache content 'libmaxminddb0_1.5.2-1_amd64.deb' added I: new cache content 'ruby_1%3a2.7+2_amd64.deb' added I: new cache content 'sgml-data_2.0.11+nmu1_all.deb' added I: new cache content 'autopoint_0.21-4_all.deb' added I: new cache content 'libcap-dev_1%3a2.44-1+deb11u1_amd64.deb' added I: new cache content 'libgnutls-openssl27_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'libncurses6_6.2+20201114-2+deb11u2_amd64.deb' added I: new cache content 'libjson-c-dev_0.15-2+deb11u1_amd64.deb' added I: new cache content 'ruby-net-telnet_0.1.1-2_all.deb' added I: new cache content 'python3-dev_3.9.2-3_amd64.deb' added I: new cache content 'libprotobuf-dev_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libpsl5_0.21.0-1.2_amd64.deb' added I: new cache content 'libpython3.9-minimal_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libphonenumber8_8.12.16-4_amd64.deb' added I: new cache content 'python3.9-minimal_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libjs-jquery_3.5.1+dfsg+~3.5.5-7_all.deb' added I: new cache content 'libsecsipid1_1.1.1~git20210601.d388d64-1+b2_amd64.deb' added I: new cache content 'mariadb-common_1%3a10.5.28-0+deb11u1_all.deb' added I: new cache content 'icu-devtools_67.1-7_amd64.deb' added I: new cache content 'libboost-system1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libelf1_0.183-1_amd64.deb' added I: new cache content 'libevent-core-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'libmnl0_1.0.4-3_amd64.deb' added I: new cache content 'libjs-underscore_1.9.1~dfsg-3_all.deb' added I: new cache content 'libreadline-dev_8.1-1_amd64.deb' added I: new cache content 'ruby-dev_1%3a2.7+2_amd64.deb' added I: new cache content 'libradcli4_1.2.11-1+b2_amd64.deb' added I: new cache content 'pkg-config_0.29.2-1_amd64.deb' added I: new cache content 'libpython2.7_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libsigsegv2_2.13-1_amd64.deb' added I: new cache content 'm4_1.4.18-5_amd64.deb' added I: new cache content 'libmongoc-dev_1.17.6-1_amd64.deb' added I: new cache content 'libsqlite3-dev_3.34.1-3+deb11u1_amd64.deb' added I: new cache content 'python3-lib2to3_3.9.2-1_all.deb' added I: new cache content 'libreadline8_8.1-1_amd64.deb' added I: new cache content 'python2_2.7.18-3_amd64.deb' added I: new cache content 'default-libmysqlclient-dev_1.0.7_amd64.deb' added I: new cache content 'libmariadb-dev-compat_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'librdkafka-dev_1.6.0-1_amd64.deb' added I: new cache content 'libuv1-dev_1.40.0-2+deb11u1_amd64.deb' added I: new cache content 'libprotobuf23_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libjs-sphinxdoc_3.4.3-2_all.deb' added I: new cache content 'libcap2_1%3a2.44-1+deb11u1_amd64.deb' added I: new cache content 'libboost-atomic1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libpython3-dev_3.9.2-3_amd64.deb' added I: new cache content 'docbook-xml_4.5-9_all.deb' added I: new cache content 'ruby-power-assert_1.1.7-2_all.deb' added I: new cache content 'libjansson4_2.13.1-1.1_amd64.deb' added I: new cache content 'libudev-dev_247.3-7+deb11u6_amd64.deb' added I: new cache content 'libedit2_3.1-20191231-2+b1_amd64.deb' added I: new cache content 'libpci3_1%3a3.7.0-5_amd64.deb' added I: new cache content 'automake_1%3a1.16.3-2_all.deb' added I: new cache content 'flex_2.6.4-8_amd64.deb' added I: new cache content 'libdebhelper-perl_13.3.4_all.deb' added I: new cache content 'libldap2-dev_2.4.57+dfsg-3+deb11u1_amd64.deb' added I: new cache content 'libpq-dev_13.20-0+deb11u1_amd64.deb' added I: new cache content 'libsub-override-perl_0.09-2_all.deb' added I: new cache content 'libmemcached11_1.0.18-4.2_amd64.deb' added I: new cache content 'libruby2.7_2.7.4-1+deb11u5_amd64.deb' added I: new cache content 'libsnappy-dev_1.1.8-1_amd64.deb' added I: new cache content 'libpcre2-posix2_10.36-2+deb11u1_amd64.deb' added I: new cache content 'python-is-python2_2.7.18-9_all.deb' added I: new cache content 'odbcinst1debian2_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libbson-dev_1.17.6-1_amd64.deb' added I: new cache content 'libjansson-dev_2.13.1-1.1_amd64.deb' added I: new cache content 'libgmpxx4ldbl_2%3a6.2.1+dfsg-1+deb11u1_amd64.deb' added I: new cache content 'libsnmp-dev_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libmongocrypt0_1.1.0-1_amd64.deb' added I: new cache content 'libboost-serialization1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libzstd-dev_1.4.8+dfsg-2.1_amd64.deb' added I: new cache content 'libsnmp40_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libsctp-dev_1.0.18+dfsg-1_amd64.deb' added I: new cache content 'libhashkit-dev_1.0.18-4.2_amd64.deb' added I: new cache content 'libboost-date-time1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'xml-core_0.18+nmu1_all.deb' added I: new cache content 'libxml2-dev_2.9.10+dfsg-6.7+deb11u6_amd64.deb' added I: new cache content 'python3.9-dev_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libmpdec3_2.5.1-1_amd64.deb' added I: new cache content 'libmosquitto-dev_2.0.11-1+deb11u2_amd64.deb' added I: new cache content 'libsasl2-2_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'libboost-system1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libperl-dev_5.32.1-4+deb11u4_amd64.deb' added I: new cache content 'ruby-rubygems_3.2.5-2_all.deb' added I: new cache content 'libxml2_2.9.10+dfsg-6.7+deb11u6_amd64.deb' added I: new cache content 'libevent-extra-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'ruby-minitest_5.13.0-1_all.deb' added I: new cache content 'libwrap0-dev_7.6.q-31_amd64.deb' added I: new cache content 'librabbitmq-dev_0.10.0-1+deb11u1_amd64.deb' added I: new cache content 'libexpat1_2.2.10-2+deb11u6_amd64.deb' added I: new cache content 'python2-dev_2.7.18-3_amd64.deb' added I: new cache content 'libboost-date-time1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'librdkafka++1_1.6.0-1_amd64.deb' added I: new cache content 'bsdextrautils_2.36.1-8+deb11u2_amd64.deb' added I: new cache content 'libmongocrypt-dev_1.1.0-1_amd64.deb' added I: new cache content 'python3-distutils_3.9.2-1_all.deb' added I: new cache content 'libcurl4_7.74.0-1.3+deb11u14_amd64.deb' added I: new cache content 'libyaml-0-2_0.2.2-1_amd64.deb' added I: new cache content 'libpython2.7-dev_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'rake_13.0.3-1_all.deb' added I: new cache content 'libunbound8_1.13.1-1+deb11u4_amd64.deb' added I: new cache content 'libboost-thread-dev_1.74.0.3_amd64.deb' added I: new cache content 'erlang-base_1%3a23.2.6+dfsg-1+deb11u1_amd64.deb' added I: new cache content 'libgnutls-dane0_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'libtasn1-6-dev_4.16.0-2+deb11u2_amd64.deb' added I: new cache content 'libprocps8_2%3a3.3.17-5_amd64.deb' added I: new cache content 'libtool_2.4.6-15_all.deb' added I: new cache content 'libpython3.9-stdlib_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'python2.7_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libgnutlsxx28_3.7.1-5+deb11u7_amd64.deb' added I: new cache content 'debhelper_13.3.4_all.deb' added I: new cache content 'libarchive-zip-perl_1.68-1_all.deb' added I: new cache content 'libnetsnmptrapd40_5.9+dfsg-4+deb11u1_amd64.deb' added I: new cache content 'libwebsockets-dev_4.0.20-2_amd64.deb' added I: new cache content 'libunistring-dev_0.9.10-4_amd64.deb' added I: new cache content 'bison_2%3a3.7.5+dfsg-1_amd64.deb' added I: new cache content 'libpython3.9_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libevent-dev_2.1.12-stable-1_amd64.deb' added I: new cache content 'libpcre2-32-0_10.36-2+deb11u1_amd64.deb' added I: new cache content 'libmagic1_1%3a5.39-3+deb11u1_amd64.deb' added I: new cache content 'libwebsockets16_4.0.20-2_amd64.deb' added I: new cache content 'libphonenumber-dev_8.12.16-4_amd64.deb' added I: new cache content 'libdb5.3-dev_5.3.28+dfsg1-0.8_amd64.deb' added I: new cache content 'libpython3.9-dev_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'libprotobuf-lite23_3.12.4-1+deb11u1_amd64.deb' added I: new cache content 'libevent-openssl-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'libsasl2-dev_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'libdb-dev_5.3.1+nmu1_amd64.deb' added I: new cache content 'liblua5.1-0_5.1.5-8.1+b3_amd64.deb' added I: new cache content 'libhiredis-dev_0.14.1-1_amd64.deb' added I: new cache content 'libsctp1_1.0.18+dfsg-1_amd64.deb' added I: new cache content 'libmaxminddb-dev_1.5.2-1_amd64.deb' added I: new cache content 'python2-minimal_2.7.18-3_amd64.deb' added I: new cache content 'libbrotli1_1.0.9-2+b2_amd64.deb' added I: new cache content 'libnghttp2-14_1.43.0-1+deb11u2_amd64.deb' added I: new cache content 'libssl-dev_1.1.1w-0+deb11u2_amd64.deb' added I: new cache content 'libhashkit2_1.0.18-4.2_amd64.deb' added I: new cache content 'libsensors-dev_1%3a3.6.0-7_amd64.deb' added I: new cache content 'libmariadb3_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'libidn2-dev_2.3.0-5_amd64.deb' added I: new cache content 'man-db_2.9.4-2_amd64.deb' added I: new cache content 'media-types_4.0.0_all.deb' added I: new cache content 'libboost-chrono1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'po-debconf_1.0.21+nmu1_all.deb' added I: new cache content 'mailcap_3.69_all.deb' added I: new cache content 'libpython2.7-minimal_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'libboost-thread1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'dh-autoreconf_20_all.deb' added I: new cache content 'openssl_1.1.1w-0+deb11u2_amd64.deb' added I: new cache content 'libboost1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libboost-serialization1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'groff-base_1.22.4-6_amd64.deb' added I: new cache content 'libsecsipid-dev_1.1.1~git20210601.d388d64-1+b2_amd64.deb' added I: new cache content 'libexpat1-dev_2.2.10-2+deb11u6_amd64.deb' added I: new cache content 'python3.9_3.9.2-1+deb11u3_amd64.deb' added I: new cache content 'uuid-dev_2.36.1-8+deb11u2_amd64.deb' added I: new cache content 'unixodbc-dev_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libuchardet0_0.0.7-1_amd64.deb' added I: new cache content 'libmosquitto1_2.0.11-1+deb11u2_amd64.deb' added I: new cache content 'libsasl2-modules-db_2.1.27+dfsg-2.1+deb11u1_amd64.deb' added I: new cache content 'ca-certificates_20210119_all.deb' added I: new cache content 'libuv1_1.40.0-2+deb11u1_amd64.deb' added I: new cache content 'python3-minimal_3.9.2-3_amd64.deb' added I: new cache content 'pci.ids_0.0~2021.02.08-1_all.deb' added I: new cache content 'libpcre2-dev_10.36-2+deb11u1_amd64.deb' added I: new cache content 'libev-dev_1%3a4.33-1_amd64.deb' added I: new cache content 'libjson-c5_0.15-2+deb11u1_amd64.deb' added I: new cache content 'libsensors-config_1%3a3.6.0-7_all.deb' added I: new cache content 'gettext-base_0.21-4_amd64.deb' added I: new cache content 'ruby-xmlrpc_0.3.0-2_all.deb' added I: new cache content 'autoconf_2.69-14_all.deb' added I: new cache content 'librabbitmq4_0.10.0-1+deb11u1_amd64.deb' added I: new cache content 'libpq5_13.20-0+deb11u1_amd64.deb' added I: new cache content 'libboost-chrono1.74.0_1.74.0-9_amd64.deb' added I: new cache content 'libbson-1.0-0_1.17.6-1_amd64.deb' added I: new cache content 'mysql-common_5.8+1.0.7_all.deb' added I: new cache content 'libgeocoding8_8.12.16-4_amd64.deb' added I: new cache content 'libevent-2.1-7_2.1.12-stable-1_amd64.deb' added I: new cache content 'mime-support_3.66_all.deb' added I: new cache content 'libboost-thread1.74-dev_1.74.0-9_amd64.deb' added I: new cache content 'libmariadb-dev_1%3a10.5.28-0+deb11u1_amd64.deb' added I: new cache content 'libpython2.7-stdlib_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'python3_3.9.2-3_amd64.deb' added I: new cache content 'ruby2.7_2.7.4-1+deb11u5_amd64.deb' added I: new cache content 'libpython2-dev_2.7.18-3_amd64.deb' added I: new cache content 'libev4_1%3a4.33-1_amd64.deb' added I: new cache content 'odbcinst_2.3.6-0.1+b1_amd64.deb' added I: new cache content 'libmicrohttpd12_0.9.72-2+deb11u1_amd64.deb' added I: new cache content 'libmnl-dev_1.0.4-3_amd64.deb' added I: new cache content 'file_1%3a5.39-3+deb11u1_amd64.deb' added I: new cache content 'libcurl4-openssl-dev_7.74.0-1.3+deb11u14_amd64.deb' added I: new cache content 'libmd0_1.0.3-3_amd64.deb' added I: new cache content 'erlang-dev_1%3a23.2.6+dfsg-1+deb11u1_amd64.deb' added I: new cache content 'libmemcached-dev_1.0.18-4.2_amd64.deb' added I: new cache content 'dh-strip-nondeterminism_1.12.0-1_all.deb' added I: new cache content 'libsnmp-base_5.9+dfsg-4+deb11u1_all.deb' added I: new cache content 'libmicrohttpd-dev_0.9.72-2+deb11u1_amd64.deb' added I: new cache content 'libfile-stripnondeterminism-perl_1.12.0-1_all.deb' added I: new cache content 'rubygems-integration_1.18_all.deb' added I: new cache content 'libhiredis0.14_0.14.1-1_amd64.deb' added I: new cache content 'libsnappy1v5_1.1.8-1_amd64.deb' added I: new cache content 'libpipeline1_1.5.3-1_amd64.deb' added I: new cache content 'libradcli-dev_1.2.11-1+b2_amd64.deb' added I: new cache content 'libicu-dev_67.1-7_amd64.deb' added I: new cache content 'libpci-dev_1%3a3.7.0-5_amd64.deb' added I: new cache content 'python2.7-minimal_2.7.18-8+deb11u1_amd64.deb' added I: new cache content 'librtmp1_2.4+20151223.gitfa8646d.1-2+b2_amd64.deb' added I: unmounting /tmp/apt-jdg_dBk7sT filesystem I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: Cleaning COW directory I: forking: rm -rf /var/cache/pbuilder/build/cow.15128 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /run/lock/bullseye-amd64.building.14780 + '[' -r /run/lock/bullseye-amd64.update.14780 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…'> + '[' -n /tmp/tmp.j4umIU8CoL ']' + rm -rf /tmp/tmp.j4umIU8CoL + '[' -n /tmp/apt-jdg_dBk7sT ']' + sudo rm -rf /tmp/apt-jdg_dBk7sT + '[' -n 405 ']' ++ sed -e 's/^\([0-9]*\).*/\1/' + SECONDS=12 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Wed Apr 16 01:05:37 UTC 2025 [running 12 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Wed Apr 16 01:05:37 UTC 2025 [running 12 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

1 1

[kamailio/kamailio] dispatcher: fix sock overwrite by ping_socket (PR #4217)
by Michael Furmur 17 Apr '25

17 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description fixes bug when `ping_socket` for destination overwrites `dp->sock` which is used for normal (not probing OPTIONS) requests You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4217 -- Commit Summary -- * dispatcher: fix sock overwrite by ping_socket -- File Changes -- M src/modules/dispatcher/dispatch.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4217.patch https://github.com/kamailio/kamailio/pull/4217.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4217 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4217(a)github.com>

2 3

git:master:586802db: dispatcher: fix sock overwrite by ping_socket
by Henning Westerholt 17 Apr '25

17 Apr '25

Module: kamailio Branch: master Commit: 586802dbf0bc6a0e5fc50c4404fff1bda9a82add URL: https://github.com/kamailio/kamailio/commit/586802dbf0bc6a0e5fc50c4404fff1b… Author: Michael Furmur <furmur(a)pm.me> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-04-17T21:03:59+02:00 dispatcher: fix sock overwrite by ping_socket fixes bug when 'ping_socket' for destination overwrites dp->sock which is used for normal (not probing OPTIONS) requests --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/586802dbf0bc6a0e5fc50c4404fff1b… Patch: https://github.com/kamailio/kamailio/commit/586802dbf0bc6a0e5fc50c4404fff1b… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 77c9dd92e20..a49e5638cd3 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -669,8 +669,7 @@ ds_dest_t *pack_dest(str iuri, int flags, int priority, str *attrs, int dload) goto err; } STR_ZTOV(dp->attrs.ping_socket.s[dp->attrs.ping_socket.len], c); - dp->sock = grep_sock_info(&host, (unsigned short)port, proto); - if(dp->sock == 0) { + if(grep_sock_info(&host, (unsigned short)port, proto) == 0) { LM_ERR("non-local socket <%.*s>\n", dp->attrs.ping_socket.len, dp->attrs.ping_socket.s); goto err;

1 0

[kamailio/kamailio] clean_sa(): Error sending delete SAs command via netlink socket: Invalid argument (#2707)
by openspring 16 Apr '25

16 Apr '25

### Description  #### Log Messages  ``` 0(117561) DEBUG: <core> [core/route_struct.c:128]: mk_action(): ACTION type5, i/count 0/1: type 1(1)/ data 0x7f8583620ef0 0(117561) DEBUG: <core> [core/route_struct.c:128]: mk_action(): ACTION type16, i/count 0/3: type 22(16)/ data 0x7f8583621ad8 0(117561) DEBUG: <core> [core/route_struct.c:128]: mk_action(): ACTION type16, i/count 1/3: type 8(8)/ data 0x7f8583620fd8 0(117561) DEBUG: <core> [core/route_struct.c:128]: mk_action(): ACTION type16, i/count 2/3: type 0(0)/ data 0x7f8500000000 0(117561) DEBUG: <core> [core/route.c:129]: route_add(): mapping routing block (0xb914c0)[MT_indialog_reply] to 6 ERROR: bad config file (1 errors) 0(117561) DEBUG: <core> [core/sr_module.c:765]: destroy_modules(): starting modules destroy phase 0(117561) DEBUG: debugger [debugger_api.c:1267]: dbg_destroy_mod_levels(): Destroyed _dbg_mod_table, size 32 0(117561) ERROR: ims_ipsec_pcscf [ipsec.c:567]: clean_sa(): Error sending delete SAs command via netlink socket: Invalid argument 0(117561) WARNING: ims_ipsec_pcscf [cmd.c:998]: ipsec_cleanall(): Error cleaning IPSec Security associations during startup. 0(117561) ERROR: ims_ipsec_pcscf [ipsec.c:609]: clean_policy(): Error sending delete policies command via netlink socket: Invalid argument 0(117561) WARNING: ims_ipsec_pcscf [cmd.c:1002]: ipsec_cleanall(): Error cleaning IPSec Policies during startup. 0(117561) ERROR: ims_ipsec_pcscf [ims_ipsec_pcscf_mod.c:309]: mod_destroy(): Error destroying spi generator 0(117561) ERROR: ims_ipsec_pcscf [ims_ipsec_pcscf_mod.c:313]: mod_destroy(): Error destroying port generator 0(117561) DEBUG: tm [t_funcs.c:84]: tm_shutdown(): start 0(117561) DEBUG: tm [t_funcs.c:87]: tm_shutdown(): emptying hash table 0(117561) DEBUG: tm [t_funcs.c:89]: tm_shutdown(): removing semaphores 0(117561) DEBUG: tm [t_funcs.c:91]: tm_shutdown(): destroying tmcb lists 0(117561) DEBUG: tm [t_funcs.c:94]: tm_shutdown(): done 0(117561) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized 0(117561) DEBUG: <core> [core/mem/shm.c:289]: shm_destroy_manager(): destroying memory manager: q_malloc 0(117561) DEBUG: <core> [core/mem/q_malloc.c:1185]: qm_shm_lock_destroy(): destroying the shared memory lock 0(117561) DEBUG: <core> [core/mem/pkg.c:98]: pkg_destroy_manager(): destroying memory manager: q_malloc ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.4 (x86_64/linux) 8d6c2b flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 8d6c2b compiled on 22:26:30 Apr 11 2021 with gcc 4.8.5 ``` * **Operating System**:  ``` NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-7" CENTOS_MANTISBT_PROJECT_VERSION="7" REDHAT_SUPPORT_PRODUCT="centos" REDHAT_SUPPORT_PRODUCT_VERSION="7" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2707

5 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev