- sr-dev - kamailio.org

git:master:4d045954: imc: docs for imc_room_active() function
by Daniel-Constantin Mierla 12 Jul '23

12 Jul '23

Module: kamailio Branch: master Commit: 4d0459545ada92786d3d7ee1f9aeefd82c8527e7 URL: https://github.com/kamailio/kamailio/commit/4d0459545ada92786d3d7ee1f9aeefd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-12T09:06:49+02:00 imc: docs for imc_room_active() function --- Modified: src/modules/imc/doc/imc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4d0459545ada92786d3d7ee1f9aeefd… Patch: https://github.com/kamailio/kamailio/commit/4d0459545ada92786d3d7ee1f9aeefd… --- diff --git a/src/modules/imc/doc/imc_admin.xml b/src/modules/imc/doc/imc_admin.xml index 853176eaa6d..1b485ac77ca 100644 --- a/src/modules/imc/doc/imc_admin.xml +++ b/src/modules/imc/doc/imc_admin.xml @@ -309,6 +309,29 @@ if(is_method("MESSAGE) exit; } ... +</programlisting> + </example> + </section> + <section> + <title id="imc.p.imc_room_active"> + <function moreinfo="none">imc_room_active(room)</function> + </title> + <para> + Return 1 (true) if the room is active, -1 (false) if the room is not + found. The parameter is the SIP URI to identify the room, it can contain + variables. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title>Usage of <varname>imc_room_active()</varname> function</title> + <programlisting format="linespecific"> +... + if(imc_room_active("sip:chat-sip@$fd")) { + ... + } +... </programlisting> </example> </section>

1 0

git:master:874351c0: imc: reformat initialized structures
by Daniel-Constantin Mierla 12 Jul '23

12 Jul '23

Module: kamailio Branch: master Commit: 874351c0d4bc4e8fce5dd9f3ca617e8c3b61ef89 URL: https://github.com/kamailio/kamailio/commit/874351c0d4bc4e8fce5dd9f3ca617e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-12T08:28:41+02:00 imc: reformat initialized structures --- Modified: src/modules/imc/imc.c --- Diff: https://github.com/kamailio/kamailio/commit/874351c0d4bc4e8fce5dd9f3ca617e8… Patch: https://github.com/kamailio/kamailio/commit/874351c0d4bc4e8fce5dd9f3ca617e8… --- diff --git a/src/modules/imc/imc.c b/src/modules/imc/imc.c index b15e42aba2f..4364609a10b 100644 --- a/src/modules/imc/imc.c +++ b/src/modules/imc/imc.c @@ -100,45 +100,53 @@ struct tm_binds tmb; /** TM callback function */ void inv_callback(struct cell *t, int type, struct tmcb_params *ps); +/* clang-format off */ static cmd_export_t cmds[] = { - {"imc_manager", (cmd_function)w_imc_manager, 0, 0, 0, REQUEST_ROUTE}, - {0, 0, 0, 0, 0, 0}}; - + {"imc_manager", (cmd_function)w_imc_manager, 0, 0, 0, REQUEST_ROUTE}, + {0, 0, 0, 0, 0, 0} +}; -static param_export_t params[] = {{"db_url", PARAM_STR, &db_url}, - {"db_mode", INT_PARAM, &db_mode}, - {"hash_size", INT_PARAM, &imc_hash_size}, - {"imc_cmd_start_char", PARAM_STR, &imc_cmd_start_str}, - {"rooms_table", PARAM_STR, &rooms_table}, - {"members_table", PARAM_STR, &members_table}, - {"outbound_proxy", PARAM_STR, &outbound_proxy}, - {"extra_hdrs", PARAM_STR, &extra_hdrs}, - {"create_on_join", INT_PARAM, &imc_create_on_join}, - {"check_on_create", INT_PARAM, &imc_check_on_create}, {0, 0, 0}}; +static param_export_t params[] = { + {"db_url", PARAM_STR, &db_url}, + {"db_mode", INT_PARAM, &db_mode}, + {"hash_size", INT_PARAM, &imc_hash_size}, + {"imc_cmd_start_char", PARAM_STR, &imc_cmd_start_str}, + {"rooms_table", PARAM_STR, &rooms_table}, + {"members_table", PARAM_STR, &members_table}, + {"outbound_proxy", PARAM_STR, &outbound_proxy}, + {"extra_hdrs", PARAM_STR, &extra_hdrs}, + {"create_on_join", INT_PARAM, &imc_create_on_join}, + {"check_on_create", INT_PARAM, &imc_check_on_create}, + {0, 0, 0} +}; #ifdef STATISTICS #include "../../core/counters.h" stat_var *imc_active_rooms; -stat_export_t imc_stats[] = {{"active_rooms", 0, &imc_active_rooms}, {0, 0, 0}}; +stat_export_t imc_stats[] = { + {"active_rooms", 0, &imc_active_rooms}, + {0, 0, 0} +}; #endif /** module exports */ struct module_exports exports = { - "imc", /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* exported commands */ - params, /* exported parameters */ - 0, /* exported rpc functions */ - 0, /* exported pseudo-variables */ - 0, /* response handling function */ - mod_init, /* module init function */ - child_init, /* child init function */ - destroy /* module destroy function */ + "imc", /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* exported commands */ + params, /* exported parameters */ + 0, /* exported rpc functions */ + 0, /* exported pseudo-variables */ + 0, /* response handling function */ + mod_init, /* module init function */ + child_init, /* child init function */ + destroy /* module destroy function */ }; +/* clang-format on */ static int mod_init(void) { @@ -601,10 +609,13 @@ static const char *imc_rpc_list_rooms_doc[2] = {"List imc rooms.", 0}; static const char *imc_rpc_list_members_doc[2] = { "List members in an imc room.", 0}; -rpc_export_t imc_rpc[] = {{"imc.list_rooms", imc_rpc_list_rooms, - imc_rpc_list_rooms_doc, RET_ARRAY}, - {"imc.list_members", imc_rpc_list_members, imc_rpc_list_members_doc, 0}, - {0, 0, 0, 0}}; +/* clang-format off */ +rpc_export_t imc_rpc[] = { + {"imc.list_rooms", imc_rpc_list_rooms, imc_rpc_list_rooms_doc, RET_ARRAY}, + {"imc.list_members", imc_rpc_list_members, imc_rpc_list_members_doc, 0}, + {0, 0, 0, 0} +}; +/* clang-format on */ static int imc_rpc_init(void) {

1 0

git:master:ce3b1656: imc: added function to check if a room is active
by Daniel-Constantin Mierla 12 Jul '23

12 Jul '23

Module: kamailio Branch: master Commit: ce3b16565a3375c4fcdabb39bfbd0c814f402da9 URL: https://github.com/kamailio/kamailio/commit/ce3b16565a3375c4fcdabb39bfbd0c8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-12T09:00:56+02:00 imc: added function to check if a room is active --- Modified: src/modules/imc/imc.c --- Diff: https://github.com/kamailio/kamailio/commit/ce3b16565a3375c4fcdabb39bfbd0c8… Patch: https://github.com/kamailio/kamailio/commit/ce3b16565a3375c4fcdabb39bfbd0c8… --- diff --git a/src/modules/imc/imc.c b/src/modules/imc/imc.c index 4364609a10b..c5b65cb95d7 100644 --- a/src/modules/imc/imc.c +++ b/src/modules/imc/imc.c @@ -43,6 +43,7 @@ #include "../../core/hashes.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" +#include "../../core/mod_fix.h" #include "../../core/kemi.h" #include "../../modules/tm/tm_load.h" @@ -89,6 +90,7 @@ static int mod_init(void); static int child_init(int); static int w_imc_manager(struct sip_msg *, char *, char *); +static int w_imc_room_active(sip_msg_t *, char *, char *); static int imc_rpc_init(void); @@ -103,6 +105,8 @@ void inv_callback(struct cell *t, int type, struct tmcb_params *ps); /* clang-format off */ static cmd_export_t cmds[] = { {"imc_manager", (cmd_function)w_imc_manager, 0, 0, 0, REQUEST_ROUTE}, + {"imc_room_active", (cmd_function)w_imc_room_active, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -430,11 +434,51 @@ static int ki_imc_manager(struct sip_msg *msg) return ret; } +/** + * + */ static int w_imc_manager(struct sip_msg *msg, char *str1, char *str2) { return ki_imc_manager(msg); } +/** + * + */ +static int ki_imc_room_active(sip_msg_t *msg, str *room) +{ + sip_uri_t puri; + imc_room_t *rm; + + if(parse_uri(room->s, room->len, &puri) != 0) { + LM_ERR("failed to parse room uri [%.*s]\n", room->len, room->s); + return -1; + } + + rm = imc_get_room(&puri.user, &puri.host); + + if(rm != NULL) { + imc_release_room(rm); + return 1; + } + return -1; +} + +/** + * + */ +static int w_imc_room_active(sip_msg_t *msg, char *proom, char *str2) +{ + str room = STR_NULL; + + if(fixup_get_svalue(msg, (gparam_t*)proom, &room) != 0) { + LM_ERR("invalid room parameter"); + return -1; + } + + return ki_imc_room_active(msg, &room); +} + /** * destroy module */ @@ -636,6 +680,11 @@ static sr_kemi_t sr_kemi_imc_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("imc"), str_init("imc_room_active"), + SR_KEMIP_INT, ki_imc_room_active, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:5da9ba4c: modules: readme files regenerated - msilo ... [skip ci]
by Kamailio Dev 11 Jul '23

11 Jul '23

Module: kamailio Branch: master Commit: 5da9ba4c12161ac864022b1624faef6c16777b4f URL: https://github.com/kamailio/kamailio/commit/5da9ba4c12161ac864022b1624faef6… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-07-11T18:32:06+02:00 modules: readme files regenerated - msilo ... [skip ci] --- Modified: src/modules/msilo/README --- Diff: https://github.com/kamailio/kamailio/commit/5da9ba4c12161ac864022b1624faef6… Patch: https://github.com/kamailio/kamailio/commit/5da9ba4c12161ac864022b1624faef6…

1 0

git:master:917b608f: msilo: docs for use_mode parameter
by Daniel-Constantin Mierla 11 Jul '23

11 Jul '23

Module: kamailio Branch: master Commit: 917b608f958e9a7a68388d8b53630cdf9cb2f3b1 URL: https://github.com/kamailio/kamailio/commit/917b608f958e9a7a68388d8b53630cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-11T18:22:06+02:00 msilo: docs for use_mode parameter --- Modified: src/modules/msilo/doc/msilo_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/917b608f958e9a7a68388d8b53630cd… Patch: https://github.com/kamailio/kamailio/commit/917b608f958e9a7a68388d8b53630cd… --- diff --git a/src/modules/msilo/doc/msilo_admin.xml b/src/modules/msilo/doc/msilo_admin.xml index 1c4a0d0e06d..f9623891411 100644 --- a/src/modules/msilo/doc/msilo_admin.xml +++ b/src/modules/msilo/doc/msilo_admin.xml @@ -726,6 +726,27 @@ m_store(...); </example> </section> + <section id="msilo.p.use_mode"> + <title><varname>use_mode</varname> (int)</title> + <para> + If set to 1, the call-id header of incoming MESSAGE is stored and reused + later for delivery MESSAGE. + </para> + <para> + <emphasis> + Default value is <quote>0</quote>. + </emphasis> + </para> + <example> + <title>Set the <quote>use_mode</quote> parameter</title> + <programlisting format="linespecific"> +... +modparam("msilo", "use_mode", 1) +... +</programlisting> + </example> + </section> + </section> <section>

1 0

git:master:38514a77: msilo: docs for parms to set column names for callid and status
by Daniel-Constantin Mierla 11 Jul '23

11 Jul '23

Module: kamailio Branch: master Commit: 38514a77aea446e36ba5ce2db32d0c4ae57571ed URL: https://github.com/kamailio/kamailio/commit/38514a77aea446e36ba5ce2db32d0c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-11T18:22:06+02:00 msilo: docs for parms to set column names for callid and status --- Modified: src/modules/msilo/doc/msilo_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/38514a77aea446e36ba5ce2db32d0c4… Patch: https://github.com/kamailio/kamailio/commit/38514a77aea446e36ba5ce2db32d0c4… --- diff --git a/src/modules/msilo/doc/msilo_admin.xml b/src/modules/msilo/doc/msilo_admin.xml index 189ee5ee9e6..1c4a0d0e06d 100644 --- a/src/modules/msilo/doc/msilo_admin.xml +++ b/src/modules/msilo/doc/msilo_admin.xml @@ -297,6 +297,36 @@ modparam("msilo", "sc_snd_time", "send_reminder_time") ... modparam("msilo", "sc_stored_hdrs", "extra_headers") ... +</programlisting> + </example> + </section> + <section id="msilo.p.sc_callid"> + <title><varname>sc_callid</varname> (string)</title> + <para> + The name of the column in silo table, storing callid. + </para> + <para>Default value is <quote>callid</quote>.</para> + <example> + <title>Set the <quote>sc_callid</quote> parameter</title> + <programlisting format="linespecific"> +... +modparam("msilo", "sc_callid", "call_id") +... +</programlisting> + </example> + </section> + <section id="msilo.p.sc_status"> + <title><varname>sc_callid</varname> (string)</title> + <para> + The name of the column in silo table, storing status. + </para> + <para>Default value is <quote>status</quote>.</para> + <example> + <title>Set the <quote>sc_status</quote> parameter</title> + <programlisting format="linespecific"> +... +modparam("msilo", "sc_status", "st") +... </programlisting> </example> </section>

1 0

git:master:8ada99e8: msilo: option to store call-id and reuse it on delivery
by Daniel-Constantin Mierla 11 Jul '23

11 Jul '23

Module: kamailio Branch: master Commit: 8ada99e8c686db639ee73a6584816c3fe0096b6d URL: https://github.com/kamailio/kamailio/commit/8ada99e8c686db639ee73a6584816c3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-11T18:22:06+02:00 msilo: option to store call-id and reuse it on delivery --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/8ada99e8c686db639ee73a6584816c3… Patch: https://github.com/kamailio/kamailio/commit/8ada99e8c686db639ee73a6584816c3…

1 0

git:master:cdd6b960: msilo: exppose callid and status columns as params to match db schema
by Daniel-Constantin Mierla 11 Jul '23

11 Jul '23

Module: kamailio Branch: master Commit: cdd6b960f4cfea2fa8a2f5f79750568d8c49d89f URL: https://github.com/kamailio/kamailio/commit/cdd6b960f4cfea2fa8a2f5f79750568… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-11T18:22:06+02:00 msilo: exppose callid and status columns as params to match db schema --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/cdd6b960f4cfea2fa8a2f5f79750568… Patch: https://github.com/kamailio/kamailio/commit/cdd6b960f4cfea2fa8a2f5f79750568… --- diff --git a/src/modules/msilo/msilo.c b/src/modules/msilo/msilo.c index e086148907a..b231fe2c13c 100644 --- a/src/modules/msilo/msilo.c +++ b/src/modules/msilo/msilo.c @@ -53,7 +53,7 @@ #include "api.h" #define MAX_DEL_KEYS 1 -#define NR_KEYS 11 +#define NR_KEYS 13 static str sc_mid = str_init("id"); /* 0 */ static str sc_from = str_init("src_addr"); /* 1 */ @@ -66,6 +66,8 @@ static str sc_exp_time = str_init("exp_time"); /* 7 */ static str sc_inc_time = str_init("inc_time"); /* 8 */ static str sc_snd_time = str_init("snd_time"); /* 9 */ static str sc_stored_hdrs = str_init("extra_hdrs"); /* 10 */ +static str sc_callid = str_init("callid"); /* 11 */ +static str sc_status = str_init("status"); /* 12 */ #define SET_STR_VAL(_str, _res, _r, _c) \ if(RES_ROWS(_res)[_r].values[_c].nul == 0) { \ @@ -213,6 +215,8 @@ static param_export_t params[] = { {"sc_inc_time", PARAM_STR, &sc_inc_time}, {"sc_snd_time", PARAM_STR, &sc_snd_time}, {"sc_stored_hdrs", PARAM_STR, &sc_stored_hdrs}, + {"sc_callid", PARAM_STR, &sc_callid}, + {"sc_status", PARAM_STR, &sc_status}, {"snd_time_avp", PARAM_STR, &ms_snd_time_avp_param}, {"extra_hdrs_avp", PARAM_STR, &ms_extra_hdrs_avp_param}, {"add_date", INT_PARAM, &ms_add_date},

1 0

[kamailio/kamailio] NATS Module not working (Issue #3253)
by iliesh 10 Jul '23

10 Jul '23

### Description Trying to get NATS module working but Kamailio is refusing to start. ``` Sep 27 23:08:27 server kernel: kamailio[338880]: segfault at 70 ip 00007fe97b06f1cc sp 00007fff72d158f0 error 4 in libuv.so.1.0.0[7fe97b066000+1f000] Sep 27 23:08:27 server kernel: Code: 5a 85 ff ff b8 ea ff ff ff c3 0f 1f 40 00 f3 0f 1e fa 8b 4e 30 83 f9 ff 0f 84 80 00 00 00 48 83 ec 08 85 c9 0f 88 90 00 00 00 <3b> 4f 70 73 45 f7 d2 21 56 28 48 8d 4e 18 48 89 f0 48 8b 76 18 75 Sep 27 23:08:27 server systemd[1]: Started Process Core Dump (PID 338886/UID 0). ``` #### Log Messages In the log message I'm getting the following error: ``` INFO: nats [nats_mod.c:437]: nats_init_connection(): adding server [nats://192.168.1.1:4222] [1] ERROR: nats [nats_mod.c:456]: nats_init_connection(): could not create nats options [System Error] ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (version: kamailio 5.6.1 (x86_64/linux) 34e6dd) ``` NATS Server version: ``` nats-server: v2.9.0 ``` libnats version: ``` libnats.so.3.4.0 ``` * **Operating System**: ``` CentOS Stream 9 5.14.0-163.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 8 13:52:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ``` * **Module Configuration**: ``` loadmodule "nats.so" modparam("nats", "nats_url", "nats://192.168.1.1:4222") ``` There is no issue at the network/firewall level as by using telnet I'm able to connect to the NATS server successfully. What is weird is that with tcpdump I can't see even attempts to connect to the NATS server. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3253 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3253(a)github.com>

5 31

[kamailio/kamailio] RFC8599 (Issue #3508)
by Sterlin11 10 Jul '23

10 Jul '23

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3508 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3508(a)github.com>

2 2

Kamailio - VoNR support
by Sivanesh Kumar K 10 Jul '23

10 Jul '23

Hi team, I was tested with Volte by using kamailio sip server . I want to know its supporting VoNR for 5G voice call . For my understanding VoNR requires kamailio IMS to use SBI interface, it's not implemented in kamailio IMS. Please correct me if I am wrong ? If not implemented means , any pipeline in feature. Regards, Sivaneshkumar K Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain proprietary confidential or privileged information or otherwise be protected by law. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please notify the sender and destroy all copies and the original message.

2 1

git:master:7ca151a0: modules: readme files regenerated - msilo ... [skip ci]
by Kamailio Dev 10 Jul '23

10 Jul '23

Module: kamailio Branch: master Commit: 7ca151a0479e4971980f4bbbc10cbd8f7deea1b6 URL: https://github.com/kamailio/kamailio/commit/7ca151a0479e4971980f4bbbc10cbd8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-07-10T11:01:31+02:00 modules: readme files regenerated - msilo ... [skip ci] --- Modified: src/modules/msilo/README --- Diff: https://github.com/kamailio/kamailio/commit/7ca151a0479e4971980f4bbbc10cbd8… Patch: https://github.com/kamailio/kamailio/commit/7ca151a0479e4971980f4bbbc10cbd8… --- diff --git a/src/modules/msilo/README b/src/modules/msilo/README index 987c9504ebd..046a57ca068 100644 --- a/src/modules/msilo/README +++ b/src/modules/msilo/README @@ -70,7 +70,8 @@ Juha Heinanen 4. Functions 4.1. m_store([owner]) - 4.2. m_dump([owner]) + 4.2. m_store_addrs(owner, srcaddr, dstaddr) + 4.3. m_dump([owner]) 5. Statistics @@ -118,8 +119,9 @@ Juha Heinanen 1.30. Set the ��extra_hdrs_avp�� parameter 1.31. Set the ��skip_notification_flag�� parameter 1.32. m_store usage - 1.33. m_dump usage - 1.34. Kamailio config script - sample msilo usage + 1.33. m_store_addrs usage + 1.34. m_dump usage + 1.35. Kamailio config script - sample msilo usage Chapter 1. Admin Guide @@ -168,7 +170,8 @@ Chapter 1. Admin Guide 4. Functions 4.1. m_store([owner]) - 4.2. m_dump([owner]) + 4.2. m_store_addrs(owner, srcaddr, dstaddr) + 4.3. m_dump([owner]) 5. Statistics @@ -655,7 +658,8 @@ m_store(...); 4. Functions 4.1. m_store([owner]) - 4.2. m_dump([owner]) + 4.2. m_store_addrs(owner, srcaddr, dstaddr) + 4.3. m_dump([owner]) 4.1. m_store([owner]) @@ -679,7 +683,28 @@ m_store(); m_store("$tu"); ... -4.2. m_dump([owner]) +4.2. m_store_addrs(owner, srcaddr, dstaddr) + + Similar to m_store(), but instead of getting source user address from + From-URI and destination user address from To_URI, this function allows + to give them via parameters. + + Meaning of the parameters is as follows: + * owner - is a string that must contain a SIP URI in whose inbox the + message will be stored. It can have any pseudo variable. + * srcaddr - is a string that must contain a SIP URI corresponding to + From user. It can have any pseudo variable. + * dstaddr - is a string that must contain a SIP URI correspinding to + To user. It can have any pseudo variable. + + This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + + Example 1.33. m_store_addrs usage +... +m_store_addrs("sip:$rU@a.com", "sip:$fU@a.com", "sip:$tU@a.com"); +... + +4.3. m_dump([owner]) The method sends stored messages for the SIP user that has registered to the contact address in the registration. The method should be called @@ -693,7 +718,7 @@ m_store("$tu"); This function can be used from REQUEST_ROUTE. - Example 1.33. m_dump usage + Example 1.34. m_dump usage ... m_dump(); m_dump("$fu"); @@ -735,7 +760,7 @@ m_dump("$fu"); Next picture displays a sample usage of msilo. - Example 1.34. Kamailio config script - sample msilo usage + Example 1.35. Kamailio config script - sample msilo usage ... # # MSILO usage example

1 0

git:master:3542608f: msilo: new function to allow specifying src/dst addresses
by Daniel-Constantin Mierla 10 Jul '23

10 Jul '23

Module: kamailio Branch: master Commit: 3542608f89dba934d943c3de8b66e178c0cecdc5 URL: https://github.com/kamailio/kamailio/commit/3542608f89dba934d943c3de8b66e17… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-10T10:42:15+02:00 msilo: new function to allow specifying src/dst addresses --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/3542608f89dba934d943c3de8b66e17… Patch: https://github.com/kamailio/kamailio/commit/3542608f89dba934d943c3de8b66e17…

1 0

git:master:8da60f5a: msilo: docs for m_store_addrs()
by Daniel-Constantin Mierla 10 Jul '23

10 Jul '23

Module: kamailio Branch: master Commit: 8da60f5a0a55fa2d5bb084b8215b96ec4c032161 URL: https://github.com/kamailio/kamailio/commit/8da60f5a0a55fa2d5bb084b8215b96e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-10T10:48:46+02:00 msilo: docs for m_store_addrs() --- Modified: src/modules/msilo/doc/msilo_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8da60f5a0a55fa2d5bb084b8215b96e… Patch: https://github.com/kamailio/kamailio/commit/8da60f5a0a55fa2d5bb084b8215b96e… --- diff --git a/src/modules/msilo/doc/msilo_admin.xml b/src/modules/msilo/doc/msilo_admin.xml index abd3e45bbff..189ee5ee9e6 100644 --- a/src/modules/msilo/doc/msilo_admin.xml +++ b/src/modules/msilo/doc/msilo_admin.xml @@ -731,6 +731,49 @@ m_store(...); m_store(); m_store("$tu"); ... +</programlisting> + </example> + </section> + <section id="msilo.f.m_store_addrs"> + <title><function moreinfo="none">m_store_addrs(owner, srcaddr, dstaddr)</function></title> + <para> + Similar to m_store(), but instead of getting source user address from + From-URI and destination user address from To_URI, this function allows + to give them via parameters. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>owner</emphasis> - is a string that must contain + a SIP URI in whose inbox the message will be stored. It can have + any pseudo variable. + </para> + </listitem> + <listitem> + <para> + <emphasis>srcaddr</emphasis> - is a string that must contain + a SIP URI corresponding to From user. It can have + any pseudo variable. + </para> + </listitem> + <listitem> + <para> + <emphasis>dstaddr</emphasis> - is a string that must contain + a SIP URI correspinding to To user. It can have + any pseudo variable. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + </para> + <example> + <title><function>m_store_addrs</function> usage</title> + <programlisting format="linespecific"> +... +m_store_addrs("sip:$rU@a.com", "sip:$fU@a.com", "sip:$tU@a.com"); +... </programlisting> </example> </section>

1 0

git:master:b1356efd: registrar: increase max size for user and domain building aor
by Daniel-Constantin Mierla 10 Jul '23

10 Jul '23

Module: kamailio Branch: master Commit: b1356efd61e56eaa3426d8e2e813ea6730b4f2c9 URL: https://github.com/kamailio/kamailio/commit/b1356efd61e56eaa3426d8e2e813ea6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-10T09:41:15+02:00 registrar: increase max size for user and domain building aor - renamed max aor lenght define to match the user and domain style --- Modified: src/modules/registrar/common.c Modified: src/modules/registrar/registrar.h --- Diff: https://github.com/kamailio/kamailio/commit/b1356efd61e56eaa3426d8e2e813ea6… Patch: https://github.com/kamailio/kamailio/commit/b1356efd61e56eaa3426d8e2e813ea6… --- diff --git a/src/modules/registrar/common.c b/src/modules/registrar/common.c index 9e619190644..6142d277d36 100644 --- a/src/modules/registrar/common.c +++ b/src/modules/registrar/common.c @@ -34,14 +34,14 @@ #include "common.h" #include "config.h" -#define MAX_AOR_LEN 256 +#define AOR_MAX_SIZE 512 /*! \brief * Extract Address of Record */ int extract_aor(str *_uri, str *_a, sip_uri_t *_pu) { - static char aor_buf[MAX_AOR_LEN]; + static char aor_buf[AOR_MAX_SIZE]; str tmp; sip_uri_t turi; sip_uri_t *puri; @@ -49,7 +49,7 @@ int extract_aor(str *_uri, str *_a, sip_uri_t *_pu) str *uri; str realm_prefix = {0}; - memset(aor_buf, 0, MAX_AOR_LEN); + memset(aor_buf, 0, AOR_MAX_SIZE); uri = _uri; if(_pu != NULL) @@ -63,7 +63,7 @@ int extract_aor(str *_uri, str *_a, sip_uri_t *_pu) return -1; } - if((puri->user.len + puri->host.len + 1) > MAX_AOR_LEN + if((puri->user.len + puri->host.len + 2) > AOR_MAX_SIZE || puri->user.len > USERNAME_MAX_SIZE || puri->host.len > DOMAIN_MAX_SIZE) { rerrno = R_AOR_LEN; diff --git a/src/modules/registrar/registrar.h b/src/modules/registrar/registrar.h index 68b00671f0e..bd28b5bd8fd 100644 --- a/src/modules/registrar/registrar.h +++ b/src/modules/registrar/registrar.h @@ -42,8 +42,8 @@ extern int contact_max_size; /* configurable using module parameter "contact_max_size" instead of compile time constant */ #define RECEIVED_MAX_SIZE 255 -#define USERNAME_MAX_SIZE 64 -#define DOMAIN_MAX_SIZE 128 +#define USERNAME_MAX_SIZE 248 +#define DOMAIN_MAX_SIZE 248 #define CALLID_MAX_SIZE 255 #define PATH_MODE_STRICT 2

1 0

git:master:7827013c: msilo: reformat exports structures for better alignment
by Daniel-Constantin Mierla 10 Jul '23

10 Jul '23

Module: kamailio Branch: master Commit: 7827013c50121b5d085dc3352b44aad940460513 URL: https://github.com/kamailio/kamailio/commit/7827013c50121b5d085dc3352b44aad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-10T10:15:49+02:00 msilo: reformat exports structures for better alignment --- Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/7827013c50121b5d085dc3352b44aad… Patch: https://github.com/kamailio/kamailio/commit/7827013c50121b5d085dc3352b44aad…

1 0

tracing, zipkin
by Sergey Safarov 10 Jul '23

10 Jul '23

When used different application servers like: 1) kamailio; 2) freeswitch; 3) crm Required correlate logs and events between all daemons. For such purposes can be used tracing (OpenTelementry, Zipkin). An example for Envoy tracking can look like POST /api/v2/spans HTTP/1.1 host: zipkin content-type: application/json x-envoy-internal: true x-forwarded-for: 217.12.247.98 x-envoy-expected-rq-timeout-ms: 5000 transfer-encoding: chunked 2ad [{"tags":{"upstream_cluster":"dynamic_forward_proxy_cluster","component":"proxy","response_flags":"DC","peer.address":"127.0.0.1","http.method":"CONNECT","http.protocol":"HTTP/1.1","downstream_cluster":"-","user_agent":"curl/7.85.0","request_size":"842","guid:x-request-id":"0456e862-4cf7-9ee2-b280-e6f59965a70d"," upstream_cluster.name ":"dynamic_forward_proxy_cluster","http.status_code":"200","response_size":"3750"},"name":" ifconfig.net:443 ","annotations":[{"timestamp":1688924085239932,"value":"ss"}],"kind":"SERVER","localEndpoint":{"port":0,"ipv4":"217.12.247.98"},"timestamp":1688924084352715,"shared":true,"traceId":"67480febdcdd48dc","duration":886997,"id":"67480febdcdd48dc"}] 0 HTTP/1.1 202 Accepted content-length: 0 server: Armeria/1.17.2 date: Sun, 9 Jul 2023 17:34:47 GMT where json body looks like [ { "tags": { "upstream_cluster": "dynamic_forward_proxy_cluster", "component": "proxy", "response_flags": "DC", "peer.address": "127.0.0.1", "http.method": "CONNECT", "http.protocol": "HTTP/1.1", "downstream_cluster": "-", "user_agent": "curl/7.85.0", "request_size": "842", "guid:x-request-id": "0456e862-4cf7-9ee2-b280-e6f59965a70d", "upstream_cluster.name": "dynamic_forward_proxy_cluster", "http.status_code": "200", "response_size": "3750" }, "name": "ifconfig.net:443", "annotations": [ { "timestamp": 1688924085239932, "value": "ss" } ], "kind": "SERVER", "localEndpoint": { "port": 0, "ipv4": "217.12.247.98" }, "timestamp": 1688924084352715, "shared": true, "traceId": "67480febdcdd48dc", "duration": 886997, "id": "67480febdcdd48dc" } ] I looking to create a task for the team developer to develop a module like "tracing_zipkin". This module should allow trace transactions and dialogs 1. request and response timing; 2. dialog start-stop events; 3. business logic like call hold/unhold, media added//removed (video, text, message, audio), request multipart content raw or filtered. I will appreciate it if you share your thoughts about how JSON POST should look. Sergey Safarov

2 2

[kamailio/kamailio] tlsa + OpenSSL 3.0.5: multiple unpredictable shm corruption (Issue #3222)
by space88man 08 Jul '23

08 Jul '23

### Description * kamailio 5.6.1 on AlmaLinux 9 and OpenSSL 3.0.5 * Used tlsa to separate the OS version of OpenSSL (which is 3.0.1). The same issue happens with the OS version of OpenSSL * Generating TLS client traffic * The issue will occur at about 25 conn/sec * Multiple unpredicatable types of shm corruption ### Troubleshooting * No issue with tlsa + OpenSSL 1.1.1q; the module can sustain 50 conn/sec up to 500 persistent connections. #### Reproduction 1. Used kamailio configuration from the outbound module documentation; i.e., configure kamailio as a TLS edge proxy. To isolate the registrar is another kamailio system 1. Use a SIP load tester to generate REGISTER traffic(Expires: 600) ; at the end of the REGISTER, keep the connection alive and reREGISTER at 300 secs. 1. Generate traffic at > 25 conn/sec (with < 25 conn/sec the test usually succeeds) #### Debugging Data BT in comments below #### Log Messages #### SIP Traffic ### Possible Solutions ### Additional Information 5.6.1 * **Operating System**: AlmaLinux 9, with (OS) OpenSSL 3.0.1. I used tlsa + OpenSSL 3.0.5 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3222 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3222(a)github.com>

4 16

[kamailio/kamailio] Kamailio Random Crash Alert - 5.4.7 (Issue #3186)
by hardikpatel89 07 Jul '23

07 Jul '23

### Description -- Hello Team, We are using Kamailio 5.4.7 and we found there is a random crash. We have observed the core logs and we noticed it is due to some of the RPC events. We have noticed it has been crashed from the "ctl handler" process. -- #### Debugging Data -- Core dump files are attached. [core-7519.txt](https://github.com/kamailio/kamailio/files/9099633/core-7519… [core-17582.txt](https://github.com/kamailio/kamailio/files/9099634/core-175… [core-7519.txt](https://github.com/kamailio/kamailio/files/9099638/core-7519… [core-17582.txt](https://github.com/kamailio/kamailio/files/9099639/core-175… -- ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.7 (x86_64/linux) a19fe1 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a19fe1 compiled on 02:56:57 Feb 16 2022 with gcc 8.3.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3186 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3186(a)github.com>

3 5

git:master:883f6b77: kex: safety checks when iterating stats list
by Daniel-Constantin Mierla 07 Jul '23

07 Jul '23

Module: kamailio Branch: master Commit: 883f6b77211a76b35a9df570a8ddbbc344b05472 URL: https://github.com/kamailio/kamailio/commit/883f6b77211a76b35a9df570a8ddbbc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-07-07T09:27:18+02:00 kex: safety checks when iterating stats list - GH #3186 --- Modified: src/modules/kex/mod_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/883f6b77211a76b35a9df570a8ddbbc… Patch: https://github.com/kamailio/kamailio/commit/883f6b77211a76b35a9df570a8ddbbc… --- diff --git a/src/modules/kex/mod_stats.c b/src/modules/kex/mod_stats.c index 65cce371eee..272c5fb3397 100644 --- a/src/modules/kex/mod_stats.c +++ b/src/modules/kex/mod_stats.c @@ -85,14 +85,14 @@ static int rpc_mod_is_printed_one(mem_counter *stats, mem_counter *current) { mem_counter *iter; - if(stats == NULL || current == NULL) { + if(stats == NULL || current == NULL || current->mname == NULL) { LM_ERR("invalid parameter\n"); return 1; } iter = stats; while(iter && iter != current) { - if(strcmp(iter->mname, current->mname) == 0) { + if(iter->mname != NULL && strcmp(iter->mname, current->mname) == 0) { return 1; } iter = iter->next;

1 0

[kamailio/kamailio] Segmentation fault on kamailio 5.7.0 (Issue #3259)
by admin-toneca 07 Jul '23

07 Jul '23

I have seen a segmentation fault on a kamailio 5.7.0 ``` Core was generated by `/usr/local/sbin/kamailio -P /run/kamailio/kamailio.pid -f /usr/local/etc/kamailio/kamailio.cfg -m 512 -M 12 --atexit=no'. Stack trace of thread 221186: #0 0x00007fbc28ffb97d n/a (libc.so.6 + 0x19d97d) #1 0x00007fbc28ed4db1 n/a (libc.so.6 + 0x76db1) #2 0x00007fbc28f7c16a n/a (libc.so.6 + 0x11e16a) #3 0x00007fbc28f7c64a syslog (libc.so.6 + 0x11e64a) #4 0x000056472e67feeb qm_debug_check_frag (kamailio + 0x358eeb) #5 0x000056472e684788 qm_free (kamailio + 0x35d788) #6 0x000056472e69054e qm_shm_free (kamailio + 0x36954e) #7 0x00007fbc24832698 ser_free (tls.so + 0x34698) #8 0x00007fbc277028e6 ERR_pop_to_mark (libcrypto.so.3 + 0x16d8e6) #9 0x00007fbc2765119e asn1_d2i_read_bio (libcrypto.so.3 + 0xbc19e) #10 0x00007fbc277fd137 n/a (libcrypto.so.3 + 0x268137) #11 0x00007fbc277ede9d n/a (libcrypto.so.3 + 0x258e9d) #12 0x00007fbc276fe62b n/a (libcrypto.so.3 + 0x16962b) #13 0x00007fbc277ef718 n/a (libcrypto.so.3 + 0x25a718) #14 0x00007fbc276fe62b n/a (libcrypto.so.3 + 0x16962b) #15 0x00007fbc276fe901 OSSL_DECODER_from_bio (libcrypto.so.3 + 0x169901) #16 0x00007fbc276fec2e OSSL_DECODER_from_data (libcrypto.so.3 + 0x169c2e) #17 0x00007fbc277d45d4 n/a (libcrypto.so.3 + 0x23f5d4) #18 0x00007fbc27663b3b n/a (libcrypto.so.3 + 0xceb3b) #19 0x00007fbc27665388 n/a (libcrypto.so.3 + 0xd0388) #20 0x00007fbc27663cb9 n/a (libcrypto.so.3 + 0xcecb9) #21 0x00007fbc27665388 n/a (libcrypto.so.3 + 0xd0388) #22 0x00007fbc27663cb9 n/a (libcrypto.so.3 + 0xcecb9) #23 0x00007fbc27664433 ASN1_item_d2i_ex (libcrypto.so.3 + 0xcf433) #24 0x00007fbc27a44f14 n/a (libssl.so.3 + 0x6df14) #25 0x00007fbc27a3aa05 n/a (libssl.so.3 + 0x63a05) #26 0x00007fbc27a3c608 n/a (libssl.so.3 + 0x65608) #27 0x00007fbc2485b216 tls_accept (tls.so + 0x5d216) #28 0x00007fbc2486686d tls_h_read_f (tls.so + 0x6886d) #29 0x000056472e6289f3 tcp_read_headers (kamailio + 0x3019f3) #30 0x000056472e631c9d tcp_read_req (kamailio + 0x30ac9d) #31 0x000056472e638c23 handle_io (kamailio + 0x311c23) #32 0x000056472e622d70 io_wait_loop_epoll (kamailio + 0x2fbd70) #33 0x000056472e63a760 tcp_receive_loop (kamailio + 0x313760) #34 0x000056472e616dde tcp_init_children (kamailio + 0x2efdde) #35 0x000056472e36565c main_loop (kamailio + 0x3e65c) #36 0x000056472e3705b0 main (kamailio + 0x495b0) #37 0x00007fbc28e87d90 n/a (libc.so.6 + 0x29d90) #38 0x00007fbc28e87e40 __libc_start_main (libc.so.6 + 0x29e40) #39 0x000056472e351805 _start (kamailio + 0x2a805) #0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:74 No locals. #1 0x00007fbc28ed4db1 in __vfprintf_internal (s=s@entry=0x56472ec58a00, format=format@entry=0x56472e8246e0 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", ap=ap@entry=0x7fff8baf6450, mode_flags=mode_flags@entry=0) at ./stdio-common/vfprintf-internal.c:1517 len = <optimized out> ptrptr = 0x20 signed_number = <optimized out> step0_jumps = {0, 2488, 2400, 1600, 1512, 2624, 1408, 2728, 2976, 1864, 2888, 608, 528, 2224, 2016, 1968, 2352, 2240, 2376, -880, 48, -96, 1776, 1688, 272, -392, -876, -960, -956, 3088, 688} space = <optimized out> is_short = <optimized out> use_outdigits = <optimized out> step1_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 1864, 2888, 608, 528, 2224, 2016, 1968, 2352, 2240, 2376, -880, 48, -96, 1776, 1688, 272, -392, -876, -960, -956, 0, 688} group = <optimized out> prec = -1 step2_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2888, 608, 528, 2224, 2016, 1968, 2352, 2240, 2376, -880, 48, -96, 1776, 1688, 272, -392, -876, -960, -956, 0, 688} string = 0x6e6f73616e615020 <error: Cannot access memory at address 0x6e6f73616e615020> left = <optimized out> is_long_double = <optimized out> width = <optimized out> step3a_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2544, 0, 0, 0, 2016, 1968, 2352, 2240, 2376, 0, 0, 0, 0, 1688, 0, 0, 0, 0, 0, 0, 688} alt = <optimized out> showsign = <optimized out> is_long = <optimized out> is_char = <optimized out> pad = <optimized out> step3b_jumps = {0 <repeats 11 times>, 528, 0, 0, 2016, 1968, 2352, 2240, 2376, -880, 48, -96, 1776, 1688, 272, -392, -876, 0, 0, 0, 688} step4_jumps = {0 <repeats 14 times>, 2016, 1968, 2352, 2240, 2376, -880, 48, -96, 1776, 1688, 272, -392, -876, 0, 0, 0, 688} is_negative = <optimized out> number = <optimized out> base = <optimized out> the_arg = {pa_wchar = 89781848 L'\x559f658', pa_int = 89781848, pa_long_int = 140445520361048, pa_long_long_int = 140445520361048, pa_u_int = 89781848, pa_u_long_int = 140445520361048, pa_u_long_long_int = 140445520361048, pa_double = 6.9389306722691122e-310, pa_long_double = <invalid float value>, pa_float128 = 1.67756396290316875220685842695669771e-4932, pa_string = 0x7fbc0559f658 "\355\357ͫ", pa_wstring = 0x7fbc0559f658 L"\xabcdefed", pa_pointer = 0x7fbc0559f658, pa_user = 0x7fbc0559f658} spec = 115 's' _cleanup_start_doit = <optimized out> _buffer = {__routine = 0x7fff8baf5f10, __arg = 0x56472ec58a00, __canceltype = 89781560, __prev = 0x7fbc047fe000} _cleanup_routine = <optimized out> thousands_sep = 0x0 grouping = 0xffffffffffffffff <error: Cannot access memory at address 0xffffffffffffffff> done = 238 f = 0x56472e824767 "s:%lu. Exec from %s:%u.\n" lead_str_end = 0x56472e8246e0 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n" end_of_spec = <optimized out> work_buffer = "`\355\177\004\274\177\000\000`\355\177\004\274\177\000\000P\241\207$\274\177\000\000(Xh.C\001\000\000\220\271\207$\274\177\000\000T\241\207$\274\177\000\000p\365Y\005\274\177\000\000\000\340\177\004\274\177\000\000\220\271\207$\274\177\000\000T\241\207$\274\177\000\000\000\366Y\005\274\177\000\000\000\340\177\004\274\177\000\000(\000\000\000\000\000\000\000\070\365Y\005\274\177\000\000\200\001\000\000\000\000\000\000\000\340\177\004\274\177\000\000\260\364Y\005\274\177\000\000\310\365Y\005\274\177\000\000\360\000\000\000\000\000\000\000\000\340\177\004\274\177\000\000\070\365Y\005\274\177\000\000X\366Y\005\274\177\000\000\001\000\000\000\000\000\000\000\310v\203\004\274\177\000\000\001\000\000\000\000\000\000\000"... workend = 0x7fff8baf62e8 "" ap_save = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7fff8baf6530, reg_save_area = 0x7fff8baf6470}} nspecs_done = 10 save_errno = 0 readonly_format = 0 do_longlong_number = <optimized out> __result = <optimized out> #2 0x00007fbc28f7c16a in __vsyslog_internal (pri=<optimized out>, fmt=0x56472e8246e0 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", ap=0x7fff8baf6450, mode_flags=0) at ./misc/syslog.c:229 __clframe = {__cancel_routine = <optimized out>, __cancel_arg = <synthetic pointer>, __do_it = 1, __cancel_type = <optimized out>} now_tm = {tm_sec = 51, tm_min = 27, tm_hour = 0, tm_mday = 9, tm_mon = 9, tm_year = 122, tm_wday = 0, tm_yday = 281, tm_isdst = 0, tm_gmtoff = 0, tm_zone = 0x56472ec59350 "UTC"} now = 1665275271 fd = <optimized out> --Type <RET> for more, q to quit, c to continue without paging-- f = 0x56472ec58a00 buf = 0x0 bufsize = 0 msgoff = 21 saved_errno = <optimized out> failbuf = "\000\340\177\004\274\177\000\000\030\027r\005\274\177\000\000\220M^\005\274\177\000\000\000\340\177\004\274" clarg = {buf = 0x0, oldaction = <optimized out>} #3 0x00007fbc28f7c64a in __syslog (pri=<optimized out>, fmt=<optimized out>) at ./misc/syslog.c:109 ap = {{gp_offset = 48, fp_offset = 48, overflow_arg_area = 0x7fff8baf6570, reg_save_area = 0x7fff8baf6470}} #4 0x000056472e67feeb in qm_debug_check_frag (qm=0x7fbc047fe000, f=0x7fbc0562dfe8, file=0x7fbc2487a154 "tls: tls_init.c", line=323, efile=0x56472e824559 "core/mem/q_malloc.c", eline=511) at core/mem/q_malloc.c:123 __llevel = -3 p = 0x56472e824554 __func__ = "qm_debug_check_frag" #5 0x000056472e684788 in qm_free (qmp=0x7fbc047fe000, p=0x7fbc0562e020, file=0x7fbc2487a154 "tls: tls_init.c", func=0x7fbc2487b990 <__func__.0> "ser_free", line=323, mname=0x7fbc2487a150 "tls") at core/mem/q_malloc.c:511 qm = 0x7fbc047fe000 f = 0x7fbc0562dfe8 size = 1016 next = 0x7fbc0562e1e8 prev = 0x7fbc0562e0f8 __func__ = "qm_free" #6 0x000056472e69054e in qm_shm_free (qmp=0x7fbc047fe000, p=0x7fbc0562e020, file=0x7fbc2487a154 "tls: tls_init.c", func=0x7fbc2487b990 <__func__.0> "ser_free", line=323, mname=0x7fbc2487a150 "tls") at core/mem/q_malloc.c:1350 No locals. #7 0x00007fbc24832698 in ser_free (ptr=0x7fbc0562e020, fname=0x7fbc278ce6e5 "../crypto/err/err_local.h", fline=86) at tls_init.c:323 __func__ = "ser_free" #8 0x00007fbc277028e6 in ERR_pop_to_mark () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #9 0x00007fbc2765119e in asn1_d2i_read_bio () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #10 0x00007fbc277fd137 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #11 0x00007fbc277ede9d in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #12 0x00007fbc276fe62b in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #13 0x00007fbc277ef718 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #14 0x00007fbc276fe62b in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #15 0x00007fbc276fe901 in OSSL_DECODER_from_bio () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #16 0x00007fbc276fec2e in OSSL_DECODER_from_data () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #17 0x00007fbc277d45d4 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #18 0x00007fbc27663b3b in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #19 0x00007fbc27665388 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #20 0x00007fbc27663cb9 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #21 0x00007fbc27665388 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #22 0x00007fbc27663cb9 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #23 0x00007fbc27664433 in ASN1_item_d2i_ex () from /lib/x86_64-linux-gnu/libcrypto.so.3 No symbol table info available. #24 0x00007fbc27a44f14 in ?? () from /lib/x86_64-linux-gnu/libssl.so.3 No symbol table info available. #25 0x00007fbc27a3aa05 in ?? () from /lib/x86_64-linux-gnu/libssl.so.3 No symbol table info available. #26 0x00007fbc27a3c608 in ?? () from /lib/x86_64-linux-gnu/libssl.so.3 No symbol table info available. --Type <RET> for more, q to quit, c to continue without paging-- #27 0x00007fbc2485b216 in tls_accept (c=0x7fbc056d3ef0, error=0x7fff8baf7994) at tls_server.c:468 ret = -1951434416 ssl = 0x7fbc056d82f8 cert = 0x7fbc056d2388 tls_c = 0x7fbc056d1fa0 tls_log = 612737204 __func__ = "tls_accept" pkey = 0x0 #28 0x00007fbc2486686d in tls_h_read_f (c=0x7fbc056d3ef0, flags=0x7fff8bb17e9c) at tls_server.c:1173 r = 0x7fbc056d4018 bytes_free = 16383 bytes_read = 1713 read_size = 16383 ssl_error = 0 ssl_read = 0 ssl = 0x7fbc056d82f8 rd_buf = "\026\003\003\004\071\v\000\004\065\000\004\062\000\004/0\202\004+0\202\003\023\240\003\002\001\002\002\t\000\267\207\251\066\225\277\372\335\060\r\006\t*\206H\206\367\r\001\001\v\005\000\060\201\217\061\v0\t\006\003U\004\006\023\002JP1\020\060\016\006\003U\004\b\f\aFukuoka1-0+\006\003U\004\n\f$ Panasonic System Networks co., Ltd.1?0=\006\003U\004\003\f6SIP Phone Client Authentication Self CA Certificate V2"... wr_buf = "\025\003\003\000\002\002\060\000-\003\003\210z\357o\213$\017\235\231\334~\207\233\365\026\261\307~lV\214A\277\337DOWNGRD\001\000\000=\000\000\005\377\001\000\001\000\026\003\003\026\035\v\000\026\031\000\026\026\000\006\070\060\202\006\064\060\202\005\034\240\003\002\001\002\002\020&~b\352RT\000\227\236Dq\264RL\271\304\060\r\006\t*\206H\206\367\r\001\001\v\005\000\060\201\217\061\v0\t\006\003U\004\006\023\002GB1\033\060\031\006\003U\004\b\023\022Greater Manchester1\020\060\016\006\003U\004\a\023\aSalford1\030\060\026\006\003U\004\n\023\017Sectigo Lim"... rd = {buf = 0x7fff8baf7af0 "\026\003\003\004\071\v", pos = 1086, used = 1713, size = 65536} wr = {buf = 0x7fff8bb07af0 "\025\003\003", pos = 0, used = 0, size = 65536} tls_c = 0x7fbc056d1fa0 enc_rd_buf = 0x0 n = 0 flush_flags = 0 err_src = 0x7fbc248839b0 "TLS read:" ip_buf = "10.20.0.100", '\000' <repeats 52 times> x = 0 tls_dbg = 0 __func__ = "tls_h_read_f" #29 0x000056472e6289f3 in tcp_read_headers (c=0x7fbc056d3ef0, read_flags=0x7fff8bb17e9c) at core/tcp_read.c:441 bytes = -1 remaining = 0 p = 0x7fbc054ebd60 "\002" r = 0x7fbc056d4018 mc = 2638013693 body_len = 50944 mfline = 0x7fbc054ec0e8 "REGISTER sip:voip.isip.ca:443 SIP/2.0\r\nv: SIP/2.0/TLS 89.28.64.156:52319;rport;branch=z9hG4bKPjr.w8BMId-6xgyjA5coZyVJeC2QNp6cni;alias\r\nMax-Forwards: 70\r\nf: <sip:1217264@voip.isip.ca>;tag=Dt75LCcpfD8Oe"... mtransid = {s = 0xffff00000000 <error: Cannot access memory at address 0xffff00000000>, len = 0} __func__ = "tcp_read_headers" #30 0x000056472e631c9d in tcp_read_req (con=0x7fbc056d3ef0, bytes_read=0x7fff8bb17e94, read_flags=0x7fff8bb17e9c) at core/tcp_read.c:1469 bytes = -1 total_bytes = 0 resp = 1 size = 2 req = 0x7fbc056d4018 dst = {send_sock = 0x7fff8bb17e10, to = {s = {sa_family = 27615, sa_data = "E.\001\000\000\000\300}\261\213\377\177\000"}, sin = {sin_family = 27615, sin_port = 11845, sin_addr = {s_addr = 1}, sin_zero = "\300}\261\213\377\177\000"}, sin6 = {sin6_family = 27615, sin6_port = 11845, sin6_flowinfo = 1, sin6_addr = {__in6_u = {__u6_addr8 = "\300}\261\213\377\177\000\000\030\000\000\000Q\000\000", __u6_addr16 = { 32192, 35761, 32767, 0, 24, 0, 81, 0}, __u6_addr32 = {2343665088, 32767, 24, 81}}}, sin6_scope_id = 4294967294}, sas = {ss_family = 27615, __ss_padding = "E.\001\000\000\000\300}\261\213\377\177\000\000\030\000\000\000Q\000\000\000\376\377\377\377\377\377\377\377\210\256p\005\274\177\000\000 \260p\005\274\177\000\000(a){\221.GV\000\000p~\261\213\001 \000\000\340\204I(\274\177\000\000\320}\261\213\001\000\000\000\020\200\203\004Q\000\000\000\001\000\000\000\000\000\000\000H\275N\005\274\177\000\000\340~\261\213\377\177\000\000\b\000\000\000\000\000\000", __ss_align = 140445521849992}}, id = -2, send_flags = {f = 65535, blst_imask = 65535}, proto = 36 '$', proto_pad0 = 0 '\000', proto_pad1 = 0} c = 46 '.' ret = 778163298 __func__ = "tcp_read_req" #31 0x000056472e638c23 in handle_io (fm=0x7fbc284984e0, events=1, idx=-1) at core/tcp_read.c:1855 ret = -1 n = 0 read_flags = RD_CONN_SHORT_READ --Type <RET> for more, q to quit, c to continue without paging-- con = 0x7fbc056d3ef0 s = 36 resp = -2 t = 359788347 ee = 0x0 __func__ = "handle_io" #32 0x000056472e622d70 in io_wait_loop_epoll (h=0x56472e917980 <io_w>, t=2, repeat=0) at core/io_wait.h:1070 n = 1 r = 0 fm = 0x7fbc284984e0 revents = 1 __func__ = "io_wait_loop_epoll" #33 0x000056472e63a760 in tcp_receive_loop (unix_sock=81) at core/tcp_read.c:1976 __func__ = "tcp_receive_loop" #34 0x000056472e616dde in tcp_init_children (woneinit=0x7fff8bb18288) at core/tcp_main.c:5236 r = 0 i = 7 reader_fd_1 = 81 pid = 0 si_desc = "tcp receiver (generic)\000\000\317jZ.GV\000\000`\202\261\213\377\177\000\000\036Xd.\000\000\000\000\340\345.(\000\000\000\000\253\066\200.GV\000\000\250\000\261\213\377\177\000\000\f\332v.GV\000\000\000\000\000\000\000\000\000\000\020\200\203\004\274\177\000\000\067\000\000\000\000\000\000\000\320\066\302\004\001\000\000\000P\202\261\213\377\177\000\000\036\334v.GV\000" si = 0x0 __func__ = "tcp_init_children" #35 0x000056472e36565c in main_loop () at main.c:1851 i = 8 pid = 221167 si = 0x0 si_desc = "udp receiver child=7 sock=10.20.20.100:5060\000\063.124.220.146:5080)\000X7\211.GV\000\000\210`{.GV\000\000\000\000\000\000\000\000\000\000s\314|.GV\000\000\067\000\000\000\000\000\000\000\260\305\367(\274\177\000\000 \204\261\213\377\177\000\000z\271Q.GV\000" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #36 0x000056472e3705b0 in main (argc=10, argv=0x7fff8bb18998) at main.c:3085 cfg_stream = 0x56472eb33380 c = -1 r = 0 tmp = 0x7fff8bb18e39 "" tmp_len = 0 port = 0 proto = 0 ahost = 0x0 aport = 0 options = 0x56472e7b9278 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3559158303 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x7fff8bb18998 p = 0x7fff8bb18910 "" st = {st_dev = 26, st_ino = 85318, st_nlink = 2, st_mode = 16888, st_uid = 114, st_gid = 121, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1665275250, tv_nsec = 283708644}, st_mtim = {tv_sec = 1665275250, tv_nsec = 283708644}, st_ctim = {tv_sec = 1665275250, tv_nsec = 283708644}, __glibc_reserved = {0, 0, 0}} tbuf = "@\003\000\000@\003\000\000@\003\000\000@\003\000\000@\003\000\000@\003\000\000@\003\000\000@\003", '\000' <repeats 50 times>, "\377\000\000\000\377\000\000\000\000\000\377\000\000\000\000\377", '/' <repeats 16 times>, "\230\r", '\000' <repeats 14 times>, "`", '\000' <repeats 15 times>, "\001", '\000' <repeats 145 times>... option_index = 12 long_options = {{name = 0x56472e7bb6b6 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x56472e7b6521 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x56472e7bb6bb "alias", has_arg = 1, flag = 0x0, val = 1024}, { name = 0x56472e7bb6c1 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x56472e7bb6c7 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x56472e7bb6d0 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, { name = 0x56472e7bb6da "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x56472e7bb6e4 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x56472e7bb6ef "modparam", has_arg = 1, flag = 0x0, val = 1030}, { name = 0x56472e7bb6f8 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x56472e7bb703 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x56472e7bb709 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, { name = 0x56472e7bb713 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x56472e7bb71a "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) (gdb) info locals No locals. (gdb) list 69 in ../sysdeps/x86_64/multiarch/strlen-avx2.S (gdb) ``` ### Additional Information * version: kamailio 5.7.0-dev0 (x86_64/linux) da0178 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: da0178 compiled on 19:15:18 Aug 9 2022 with gcc 11.2.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 22.04.1 LTS Release: 22.04 Codename: jammy Linux kamailio-prod 5.15.0-1019-aws #23-Ubuntu SMP Wed Aug 17 18:33:13 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3259 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3259(a)github.com>

4 7

git:5.7:44130062: ims_qos: check and log for NULL sessionId
by Stefan Mititelu 05 Jul '23

05 Jul '23

Module: kamailio Branch: 5.7 Commit: 44130062640ccbbc7e796cc748d432fe3382c328 URL: https://github.com/kamailio/kamailio/commit/44130062640ccbbc7e796cc748d432f… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2023-07-05T13:56:26+03:00 ims_qos: check and log for NULL sessionId (cherry picked from commit 1b291315b43da1148cee5f3821ddbe49b0c86b7f) --- Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/44130062640ccbbc7e796cc748d432f… Patch: https://github.com/kamailio/kamailio/commit/44130062640ccbbc7e796cc748d432f… --- diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 1c376c98008..0f7373915a1 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -149,6 +149,11 @@ void async_aar_callback(int is_timeout, void *param, AAAMessage *aaa, long elaps LM_DBG("Success, received code: [%i] from PCRF for AAR request\n", cdp_result); counter_inc(ims_qos_cnts_h.successful_media_aars); + if(!aaa->sessionId) { + LM_ERR("NULL AAA sessionId from PCRF!\n"); + goto error; + } + LM_DBG("Auth session ID [%.*s]", aaa->sessionId->data.len, aaa->sessionId->data.s); if(!data->aar_update) { @@ -286,6 +291,12 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e create_return_code(result); goto done; } + + if(!aaa->sessionId) { + LM_ERR("NULL AAA sessionId from PCRF!\n"); + goto error; + } + //need to set Rx auth data to say this session has been successfully opened //This is used elsewhere to prevent acting on termination events when the session has not been opened //getting auth session

1 0

git:5.6:5154f209: ims_qos: check and log for NULL sessionId
by Stefan Mititelu 05 Jul '23

05 Jul '23

Module: kamailio Branch: 5.6 Commit: 5154f20964e08d2853bbf96afdeecceac8fe7650 URL: https://github.com/kamailio/kamailio/commit/5154f20964e08d2853bbf96afdeecce… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2023-07-05T13:54:29+03:00 ims_qos: check and log for NULL sessionId (cherry picked from commit 1b291315b43da1148cee5f3821ddbe49b0c86b7f) --- Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/5154f20964e08d2853bbf96afdeecce… Patch: https://github.com/kamailio/kamailio/commit/5154f20964e08d2853bbf96afdeecce… --- diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index dbc2aebaeb6..287df6d9894 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -149,6 +149,11 @@ void async_aar_callback(int is_timeout, void *param, AAAMessage *aaa, long elaps LM_DBG("Success, received code: [%i] from PCRF for AAR request\n", cdp_result); counter_inc(ims_qos_cnts_h.successful_media_aars); + if(!aaa->sessionId) { + LM_ERR("NULL AAA sessionId from PCRF!\n"); + goto error; + } + LM_DBG("Auth session ID [%.*s]", aaa->sessionId->data.len, aaa->sessionId->data.s); if(!data->aar_update) { @@ -286,6 +291,12 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e create_return_code(result); goto done; } + + if(!aaa->sessionId) { + LM_ERR("NULL AAA sessionId from PCRF!\n"); + goto error; + } + //need to set Rx auth data to say this session has been successfully opened //This is used elsewhere to prevent acting on termination events when the session has not been opened //getting auth session

1 0

git:master:498e9f72: ims_qos: remove not needed function name prefix from log message (related to GH #3503)
by Henning Westerholt 05 Jul '23

05 Jul '23

Module: kamailio Branch: master Commit: 498e9f7276459b3f3963544527d9bd2ae5d36e40 URL: https://github.com/kamailio/kamailio/commit/498e9f7276459b3f3963544527d9bd2… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-07-05T10:08:57Z ims_qos: remove not needed function name prefix from log message (related to GH #3503) --- Modified: src/modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/498e9f7276459b3f3963544527d9bd2… Patch: https://github.com/kamailio/kamailio/commit/498e9f7276459b3f3963544527d9bd2… --- diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 8c0fc4e937d..f19e51814ef 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -153,7 +153,7 @@ void async_aar_callback( counter_inc(ims_qos_cnts_h.successful_media_aars); if(!aaa->sessionId) { - LM_ERR("async_aar_callback: NULL AAA sessionId from PCRF!\n"); + LM_ERR("NULL AAA sessionId from PCRF!\n"); goto error; } @@ -316,7 +316,7 @@ void async_aar_reg_callback( } if(!aaa->sessionId) { - LM_ERR("async_aar_reg_callback: NULL AAA sessionId from PCRF!\n"); + LM_ERR("NULL AAA sessionId from PCRF!\n"); goto error; }

1 0

[kamailio/kamailio] ims_qos: check and log for NULL sessionId (PR #3503)
by Stefan Mititelu 05 Jul '23

05 Jul '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Check for NULL sessionId from PCRF, which can lead to kamailio crash. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3503 -- Commit Summary -- * ims_qos: check and log for NULL sessionId -- File Changes -- M src/modules/ims_qos/rx_aar.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3503.patch https://github.com/kamailio/kamailio/pull/3503.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3503 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3503(a)github.com>

3 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev