- sr-dev - kamailio.org

git:master:a5bc1c03: core: mem - qm memory manager updated to align to 16
by Daniel-Constantin Mierla 10 Nov '23

10 Nov '23

Module: kamailio Branch: master Commit: a5bc1c03968b797ac03d5b648ad3b417dfee265d URL: https://github.com/kamailio/kamailio/commit/a5bc1c03968b797ac03d5b648ad3b41… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T20:33:31+01:00 core: mem - qm memory manager updated to align to 16 - same as malloc() on linux 64b - https://www.gnu.org/software/libc/manual/html_node/Aligned-Memory-Blocks.ht… - some libraries (e.g., libwolfssl) expect such alignement for specific optimizations - done even for 32b, expected rather low overhead in average, not expected many chunks under 16 bytes versus those over --- Modified: src/core/mem/q_malloc.c Modified: src/core/mem/q_malloc.h --- Diff: https://github.com/kamailio/kamailio/commit/a5bc1c03968b797ac03d5b648ad3b41… Patch: https://github.com/kamailio/kamailio/commit/a5bc1c03968b797ac03d5b648ad3b41…

1 0

git:master:7bdd7fb4: dialog: use memcpy to fill profile uid
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 7bdd7fb4aa666b5f56ae3e554770126ad5b68c2e URL: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T15:32:39+01:00 dialog: use memcpy to fill profile uid --- Modified: src/modules/dialog/dlg_profile.c --- Diff: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… Patch: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… --- diff --git a/src/modules/dialog/dlg_profile.c b/src/modules/dialog/dlg_profile.c index fd605d000c9..5dd3b372d49 100644 --- a/src/modules/dialog/dlg_profile.c +++ b/src/modules/dialog/dlg_profile.c @@ -603,7 +603,9 @@ int set_dlg_profile( } sruid_next_safe(&_dlg_profile_sruid); if(_dlg_profile_sruid.uid.len < SRUID_SIZE) { - strcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s); + memcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s, + _dlg_profile_sruid.uid.len); + linker->hash_linker.puid[_dlg_profile_sruid.uid.len] = '\0'; linker->hash_linker.puid_len = _dlg_profile_sruid.uid.len; } else { LM_ERR("sruid size is too large\n"); @@ -951,7 +953,7 @@ int dlg_set_timeout_by_profile( unsigned int h_id; unsigned int h_entry; struct dlg_map_list *next; - } * map_head, *map_scan, *map_scan_next; + } *map_head, *map_scan, *map_scan_next; map_head = NULL;

1 0

git:master:36806bea: imc: coverted some static global str variables to macros
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 36806bea261f7a29dc1d2a8aedac837a06043968 URL: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T14:54:13+01:00 imc: coverted some static global str variables to macros --- Modified: src/modules/imc/imc_cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837… Patch: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837…

1 0

git:master:9b01012b: core: use string building functions with explicit lenght
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 9b01012b5fab43ca3b1ddc7d7493b0edc69cdceb URL: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T10:44:00+01:00 core: use string building functions with explicit lenght --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… Patch: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 1b7ea7332d2..9660afce320 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -326,8 +326,7 @@ static int register_module(module_exports_t *e, char *path, void *handle) LM_ERR("too long module name: %s\n", mod->exports.name); goto error; } - strcpy(defmod, "MOD_"); - strcat(defmod, mod->exports.name); + snprintf(defmod, 64, "MOD_%s", mod->exports.name); pp_define_set_type(KSR_PPDEF_DEFINE); if(pp_define(strlen(defmod), defmod) < 0) { LM_ERR("unable to set cfg define for module: %s\n", mod->exports.name); @@ -402,6 +401,7 @@ int ksr_locate_module(char *mod_path, char **new_path) { struct stat stat_buf; str modname; + str modfile; char *mdir; char *nxt_mdir; char *path; @@ -412,11 +412,14 @@ int ksr_locate_module(char *mod_path, char **new_path) *new_path = NULL; path = mod_path; path_type = 0; - modname.s = path; - modname.len = strlen(mod_path); - if(modname.len > 3 && strcmp(modname.s + modname.len - 3, ".so") == 0) { + modfile.s = path; + modfile.len = strlen(mod_path); + modname.s = modfile.s; + if(modfile.len > 3 && strcmp(modfile.s + modfile.len - 3, ".so") == 0) { path_type = 1; - modname.len -= 3; + modname.len = modfile.len - 3; + } else { + modname.len = modfile.len; } if(!strchr(path, '/')) path_type |= 2; @@ -445,9 +448,12 @@ int ksr_locate_module(char *mod_path, char **new_path) len++; } path[len] = 0; - strcat(path, modname.s); - if(!(path_type & 1)) + if(path_type & 1) { + strncat(path, modfile.s, modfile.len); + } else { + strncat(path, modname.s, modname.len); strcat(path, ".so"); + } if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path); @@ -470,9 +476,12 @@ int ksr_locate_module(char *mod_path, char **new_path) path[len] = 0; strncat(path, modname.s, modname.len); strcat(path, "/"); - strcat(path, modname.s); - if(!(path_type & 1)) + if(path_type & 1) { + strncat(path, modfile.s, modfile.len); + } else { + strncat(path, modname.s, modname.len); strcat(path, ".so"); + } if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path);

1 0

git:master:af86d0e2: modules: readme files regenerated - ims_charging ... [skip ci]
by The Root 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: af86d0e27b9a66cff392fd5e462901864bc3dc18 URL: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: The Root <root(a)kamailio.org> Date: 2023-11-09T09:31:21+01:00 modules: readme files regenerated - ims_charging ... [skip ci] --- Modified: src/modules/ims_charging/README --- Diff: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018… Patch: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018…

1 0

git:master:8269b719: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 8269b719775ce704eade4a832ae8abb56af08841 URL: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-09T09:32:21+01:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… Patch: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index b4e71c7eafa..96693dcd018 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -463,8 +463,8 @@ Chapter 1. Admin Guide would specify the weight 2 for this server, for example. The selection of the set is done from script prior using - rtpengine_delete(), rtpengine_offer() or rtpengine_answer() functions - - see the set_rtpengine_set() function. + rtpengine_delete(), rtpengine_offer(), rtpengine_answer() or + rtpengine_manage() functions - see the set_rtpengine_set() function. Another way to select the set is to define setid_avp module parameter and assign setid to the defined avp before calling rtpengine_offer() or @@ -2150,7 +2150,6 @@ modparam("rtpengine", "dtmf_events_sock", "127.0.0.1:2223") sends it back to the module to be placed back into the SIP message. This is useful if you have a set of RTP proxies that the caller must use, and another distinct set of RTP proxies that the callee must use. - This is supported by all rtpengine commands except rtpengine_manage(). This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, BRANCH_ROUTE.

1 0

git:master:aab0e4a3: rtpengine: remove mistaken statement for set_rtpengine_set() about rtpengine_manage()
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: aab0e4a3b86f309f8a0333d20f632fec1158af9f URL: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T09:27:07+01:00 rtpengine: remove mistaken statement for set_rtpengine_set() about rtpengine_manage() --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… Patch: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index cc1dc3025bf..1e394453493 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -52,8 +52,8 @@ </para> <para> The selection of the set is done from script prior using - rtpengine_delete(), rtpengine_offer() or rtpengine_answer() - functions - see the set_rtpengine_set() function. + rtpengine_delete(), rtpengine_offer(), rtpengine_answer() or + rtpengine_manage() functions - see the set_rtpengine_set() function. </para> <para> Another way to select the set is to define setid_avp @@ -2328,10 +2328,10 @@ modparam("rtpengine", "wsapi", "lwsc") <section id="rtpengine.p.dtmf_events_sock" xreflabel="dtmf_events_sock"> <title><varname>dtmf_events_sock</varname> (string)</title> <para> - Definition of IPv4/IPv6 UDP socket used to receive dtmf events from RTPEngine. + Definition of IPv4/IPv6 UDP socket used to receive dtmf events from RTPEngine. </para> <para> - DTMF events coming from RTPEngine will trigger rtpengine:dtmf-event route. + DTMF events coming from RTPEngine will trigger rtpengine:dtmf-event route. </para> <para> <emphasis> @@ -2374,8 +2374,7 @@ modparam("rtpengine", "dtmf_events_sock", "127.0.0.1:2223") another time and sends it back to the module to be placed back into the &sip; message. This is useful if you have a set of &rtp; proxies that the caller must use, and another distinct set of &rtp; proxies that the - callee must use. This is supported by all rtpengine commands except - rtpengine_manage(). + callee must use. </para> <para> This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, @@ -2519,7 +2518,7 @@ rtpengine_offer(); of ignoring endpoint addresses in the &sdp; body. </para></listitem> <listitem><para> - <emphasis>received-from=IP</emphasis> - Configure the SIP-source-address IP + <emphasis>received-from=IP</emphasis> - Configure the SIP-source-address IP explicitly, which will be useful when two kamailio is cascaded where first kamailio is handling NAT and second kamailio RTPEngine. </para></listitem>

1 0

git:master:12dcdd36: devcontainer: use prebuild image [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 12dcdd3664bbb990cd749872bea3744bb7eff315 URL: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T23:33:38+01:00 devcontainer: use prebuild image [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… Patch: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 7ab1083ed00..2a0413eae4d 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,6 +4,7 @@ */ "name": "Debian", "build": { + "cacheFrom": "ghcr.io/kamailio/kamailio-master-devcontainer", "context": "../pkg/kamailio/deb", "dockerfile": "Dockerfile" },

1 0

git:master:721bfc88: devcontainer: add github-cli
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 721bfc880a7c01b1792e5770a26fc7d5fe4faa42 URL: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:46:07+01:00 devcontainer: add github-cli --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Patch: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index bc6019c6877..7ab1083ed00 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -10,7 +10,8 @@ // Features to add to the dev container. More info: https://containers.dev/features. "features": { - "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {} + "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {}, + "ghcr.io/devcontainers/features/github-cli:1": {} }, // Use 'forwardPorts' to make a list of ports inside the container available locally.

1 0

git:master:38585ea2: github: prebuild devcontainer image
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 38585ea29773543d9c2fe3559005487511ac90ce URL: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:45:54+01:00 github: prebuild devcontainer image --- Added: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Patch: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml new file mode 100644 index 00000000000..3321b4feec4 --- /dev/null +++ b/.github/workflows/devcontainer.yaml @@ -0,0 +1,56 @@ + +--- +name: build devcontainer image +'on': + push: + branches: + - master + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +env: + DIST: bookworm + +jobs: + build: + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 2 + + - name: print latest_commit + run: echo ${{ github.sha }} + + - name: Get changed files + id: changed-files + uses: tj-actions/changed-files@v40 + with: + since_last_remote_commit: true + + - name: changes in relevant files + id: changed-files-builder + uses: tj-actions/changed-files@v40 + with: + files: | + .devcontainer/** + pkg/kamailio/deb/${{ env.DIST }}/** + + - name: Login to GitHub Container Registry + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.repository_owner }} + password: ${{ secrets.GITHUB_TOKEN }} + + - name: Pre-build dev container image + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: devcontainers/ci(a)v0.3 + with: + imageName: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + cacheFrom: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + push: always

1 0

git:master:9b4fe94d: devcontainer: add gitlens extension [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 9b4fe94d71c25e9ac3a43a5010a5dece7adaf14c URL: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:57:11+01:00 devcontainer: add gitlens extension [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Patch: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index a0f156e25bb..bc6019c6877 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -25,6 +25,7 @@ "extensions": [ "ms-vscode.cpptools-extension-pack", "GitHub.vscode-github-actions", + "eamodio.gitlens", "xaver.clang-format" ] }

1 0

git:master:6aa940f7: dialplan: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 6aa940f7acbc565545ae9199b288d16a50bafcab URL: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:53:53+01:00 dialplan: reformat exported structures more human friendly revert to the format it had before 01d0d1de2c8 --- Modified: src/modules/dialplan/dialplan.c --- Diff: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… Patch: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index 235158513f9..43aa6cd5a1b 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -96,47 +96,53 @@ int dp_append_branch = 1; int dp_reload_delta = 5; static time_t *dp_rpc_reload_time = NULL; +/* clang-format off */ +static param_export_t mod_params[]={ + { "db_url", PARAM_STR, &dp_db_url }, + { "table_name", PARAM_STR, &dp_table_name }, + { "dpid_col", PARAM_STR, &dpid_column }, + { "pr_col", PARAM_STR, &pr_column }, + { "match_op_col", PARAM_STR, &match_op_column }, + { "match_exp_col", PARAM_STR, &match_exp_column }, + { "match_len_col", PARAM_STR, &match_len_column }, + { "subst_exp_col", PARAM_STR, &subst_exp_column }, + { "repl_exp_col", PARAM_STR, &repl_exp_column }, + { "attrs_col", PARAM_STR, &attrs_column }, + { "attrs_pvar", PARAM_STR, &dp_attr_pvar_s }, + { "fetch_rows", PARAM_INT, &dp_fetch_rows }, + { "match_dynamic", PARAM_INT, &dp_match_dynamic }, + { "append_branch", PARAM_INT, &dp_append_branch }, + { "reload_delta", PARAM_INT, &dp_reload_delta }, + {0,0,0} +}; -static param_export_t mod_params[] = {{"db_url", PARAM_STR, &dp_db_url}, - {"table_name", PARAM_STR, &dp_table_name}, - {"dpid_col", PARAM_STR, &dpid_column}, - {"pr_col", PARAM_STR, &pr_column}, - {"match_op_col", PARAM_STR, &match_op_column}, - {"match_exp_col", PARAM_STR, &match_exp_column}, - {"match_len_col", PARAM_STR, &match_len_column}, - {"subst_exp_col", PARAM_STR, &subst_exp_column}, - {"repl_exp_col", PARAM_STR, &repl_exp_column}, - {"attrs_col", PARAM_STR, &attrs_column}, - {"attrs_pvar", PARAM_STR, &dp_attr_pvar_s}, - {"fetch_rows", PARAM_INT, &dp_fetch_rows}, - {"match_dynamic", PARAM_INT, &dp_match_dynamic}, - {"append_branch", PARAM_INT, &dp_append_branch}, - {"reload_delta", PARAM_INT, &dp_reload_delta}, {0, 0, 0}}; - -static cmd_export_t cmds[] = {{"dp_translate", (cmd_function)dp_translate_f, 2, - dp_trans_fixup, 0, ANY_ROUTE}, - {"dp_translate", (cmd_function)dp_translate_f, 1, dp_trans_fixup, 0, - ANY_ROUTE}, - {"dp_reload", (cmd_function)dp_reload_f, 0, 0, 0, ANY_ROUTE}, - {"dp_match", (cmd_function)w_dp_match, 2, fixup_igp_spve, - fixup_free_igp_spve, ANY_ROUTE}, - {"dp_replace", (cmd_function)w_dp_replace, 3, dp_replace_fixup, - dp_replace_fixup_free, ANY_ROUTE}, - {0, 0, 0, 0, 0, 0}}; - -struct module_exports exports = { - "dialplan", /* module's name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* exported functions */ - mod_params, /* param exports */ - 0, /* exported RPC functions */ - 0, /* exported pseudo-variables */ - 0, /* reply processing function */ - mod_init, /* module initialization function */ - child_init, /* per-child init function */ - mod_destroy /* module destroy function */ +static cmd_export_t cmds[]={ + {"dp_translate",(cmd_function)dp_translate_f, 2, dp_trans_fixup, 0, + ANY_ROUTE}, + {"dp_translate",(cmd_function)dp_translate_f, 1, dp_trans_fixup, 0, + ANY_ROUTE}, + {"dp_reload",(cmd_function)dp_reload_f, 0, 0, 0, + ANY_ROUTE}, + {"dp_match",(cmd_function)w_dp_match, 2, fixup_igp_spve, + fixup_free_igp_spve, ANY_ROUTE}, + {"dp_replace",(cmd_function)w_dp_replace, 3, dp_replace_fixup, + dp_replace_fixup_free, ANY_ROUTE}, + {0,0,0,0,0,0} }; +struct module_exports exports= { + "dialplan", /* module's name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* exported functions */ + mod_params, /* param exports */ + 0, /* exported RPC functions */ + 0, /* exported pseudo-variables */ + 0, /* reply processing function */ + mod_init, /* module initialization function */ + child_init, /* per-child init function */ + mod_destroy /* module destroy function */ +}; +/* clang-format on */ static int mod_init(void) {

1 0

git:master:4642a12c: debugger: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 4642a12c109939f71f91ba7807ded1491e241e26 URL: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:03:49+01:00 debugger: reformat exported structures more human friendly revert to the format it had before 656e147c470 --- Modified: src/modules/debugger/debugger_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14… Patch: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14…

1 0

git:master:f0cf082e: dialog: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: f0cf082effe6a0fd8893299e49a519d90bfc6151 URL: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T19:58:47+01:00 dialog: reformat exported structures more human friendly revert to the format it had before 783a416f1a5 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d… Patch: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d…

1 0

git:master:a62d7118: core: utils/srjson - use snprintf() for silenting analyzers
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: a62d7118a2f86a82fd080ed4a89a0833e8c4d1a2 URL: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-08T18:44:58+01:00 core: utils/srjson - use snprintf() for silenting analyzers --- Modified: src/core/utils/srjson.c --- Diff: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… Patch: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… --- diff --git a/src/core/utils/srjson.c b/src/core/utils/srjson.c index 76ef80a1555..5960932f545 100644 --- a/src/core/utils/srjson.c +++ b/src/core/utils/srjson.c @@ -205,20 +205,20 @@ static char *print_number(srjson_doc_t *doc, srjson_t *item) int i = (int)d; if(fabs(((double)i) - d) <= DBL_EPSILON && d <= INT_MAX && d >= INT_MIN) { str = (char *)doc->malloc_fn(21); /* 2^64+1 can be - * represented in 21 - * chars. */ + * represented in 20+1 + * chars (including 0-termination). */ if(str) - sprintf(str, "%d", i); + snprintf(str, 21, "%d", i); } else { str = (char *)doc->malloc_fn(64); /* This is a nice * tradeoff. */ if(str) { if(fabs(floor(d) - d) <= DBL_EPSILON) - sprintf(str, "%.0f", d); + snprintf(str, 21, "%.0f", d); else if(fabs(d) < 1.0e-6 || fabs(d) > 1.0e9) - sprintf(str, "%e", d); + snprintf(str, 21, "%e", d); else - sprintf(str, "%f", d); + snprintf(str, 21, "%f", d); } } return str; @@ -384,7 +384,7 @@ static char *print_string_ptr(srjson_doc_t *doc, const char *str) *ptr2++ = 't'; break; default: - sprintf(ptr2, "u%04x", token); + snprintf(ptr2, 6, "u%04x", token); ptr2 += 5; break; /* escape and print */ }

1 0

Github actions for opened issues and pull requests
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Hello, likely everyone on sr-dev likely noticed the rather large amount of github-actions notifications related to opened issues and pull requests, they happened because of trying to automatise/optimize tasks related to them and somehow keep both reporters and interested developers aware of items ageing. Enabling that action to see how it goes with it triggered rather large amount of notifications, because it worked also on existing items, not only on the future ones. Anyhow, if there is notification that an item is getting too old and nobody has interest on it, then it may be closed after a while, right now is 6 weeks notice of inactivity, plus 2 weeks to react on it -- these values can adjusted of course base on feedback. If there is interest in the item, simply the label stale can be removed. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services

2 2

git:master:8f84f668: topos: update headers for stateless cancel and non-2xx ack
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 8f84f6681570d5eb1018e6fe45f280173451bf62 URL: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-08T11:06:53+01:00 topos: update headers for stateless cancel and non-2xx ack --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… Patch: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 740f87b067f..0e697e8580e 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -1114,9 +1114,14 @@ int tps_request_sent(sip_msg_t *msg, int dialog, int local) if(tps_get_xuuid(msg, &xuuid) < 0) { LM_DBG("no x-uuid header - local message only - Call-ID mask if " "downstream \n"); - /* ACK and CANCEL go downstream so Call-ID mask required */ if(get_cseq(msg)->method_id == METHOD_ACK || get_cseq(msg)->method_id == METHOD_CANCEL) { + /* cover stateless forwarding */ + tps_remove_headers(msg, HDR_RECORDROUTE_T); + tps_remove_headers(msg, HDR_CONTACT_T); + tps_remove_headers(msg, HDR_VIA_T); + tps_reinsert_via(msg, &mtsd, &mtsd.x_via1); + /* ACK and CANCEL go downstream so Call-ID mask required */ tps_mask_callid(msg); } return 0;

1 0

git:master:e1c151fd: github: decrease operations-per-run [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: e1c151fdcb1da37f2cf2ffd76f364ec025a8d6e6 URL: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T09:50:03+01:00 github: decrease operations-per-run [skip ci] --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… Patch: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index 142f63c2e1f..063df358c62 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -19,5 +19,5 @@ jobs: days-before-close: 14 exempt-issue-labels: bug remove-stale-when-updated: true - operations-per-run: 1000 + operations-per-run: 500 ascending: true

1 0

[kamailio/kamailio] Warnings compiling app_java module (#1984)
by Jaigongon 08 Nov '23

08 Nov '23

### Description I recently downloaded kamailio 5.2.3 and tried to install it for investigation purposes. I was trying to include app_java module in order to execute some brief java apps in kamailio. But then I get the same issue wen I compile and when I run kamailio Thank you for all the help you can give me ### Troubleshooting I get the same bunch of warnings everytime I try to make all java_msgobj.c: In function ‘fill_sipmsg_object’: java_msgobj.c:83:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->id); ^~~~~~~~~~~~~~ java_msgobj.c:83:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:96:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->pid); ^~~~~~~~~~~~~~ java_msgobj.c:96:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:110:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:110:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:127:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:127:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:142:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:142:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:156:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->len); ^~~~~~~~~~~~~~ java_msgobj.c:156:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:172:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:172:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:189:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:189:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:205:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->parsed_orig_ruri_ok); ^~~~~~~~~~~~~~ java_msgobj.c:205:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:222:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:222:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:237:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->add_to_branch_len); ^~~~~~~~~~~~~~ java_msgobj.c:237:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:251:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->hash_index); ^~~~~~~~~~~~~~ java_msgobj.c:251:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:265:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->msg_flags); ^~~~~~~~~~~~~~ java_msgobj.c:265:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:286:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:286:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:306:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:306:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ CC (gcc) [M app_java.so] java_support.o CC (gcc) [M app_java.so] java_iface.o java_iface.c: In function ‘java_exec’: java_iface.c:205:53: warning: passing argument 2 of ‘(*_aj_env)->NewLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:205:53: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:205:18: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method); ^ java_iface.c:208:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:208:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:216:40: warning: passing argument 2 of ‘(*_aj_env)->MonitorEnter’ from incompatible pointer type [-Wincompatible-pointer-types] if((*_aj_env)->MonitorEnter(_aj_env, invk_method_ref) != JNI_OK) { ^~~~~~~~~~~~~~~ java_iface.c:216:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:234:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:234:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:235:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:235:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:258:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:258:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:259:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:259:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:266:39: warning: passing argument 2 of ‘(*_aj_env)->MonitorExit’ from incompatible pointer type [-Wincompatible-pointer-types] if((*_aj_env)->MonitorExit(_aj_env, invk_method_ref) != JNI_OK) { ^~~~~~~~~~~~~~~ java_iface.c:266:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:272:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:272:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:273:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:273:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ CC (gcc) [M app_java.so] java_native_methods.o java_native_methods.c: In function ‘Java_org_siprouter_SipMsg_ParseSipMsg’: java_native_methods.c:484:9: warning: return from incompatible pointer type [-Wincompatible-pointer-types] return fill_sipmsg_object(jenv, _aj_msg); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CC (gcc) [M app_java.so] app_java_mod.o app_java_mod.c: In function ‘child_init’: app_java_mod.c:236:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, child_init_id); ^~~~~~~~~~~~~ app_java_mod.c:236:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ #### Reproduction 1. Download 5.2.3 2. in /usr/local/src/kamailio-5.2.3/ 2.1 make include_modules="app_java" cfg 2.2 make all 2.3 make install 3 kamailo -e -E -ddd #### Debugging Data 0(18169) ERROR: <core> [core/sr_module.c:498]: load_module(): could not open module </usr/local/lib64/kamailio/modules/app_java.so>: libjvm.so: cannot open shared object file: No such file or directory 0(18169) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 300, column 12-24: failed to load module 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 306, column 46: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 307, column 55: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 308, column 60: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 309, column 41: Can't set module parameter 0(18169) ERROR: <core> [core/cfg.y:3370]: yyparse(): cfg. parser: failed to find command java_method_exec (params 2) 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 483, column 37: unknown command, missing loadmodule? ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 * **Operating System**: Ubuntu 18.04 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1984

2 3

git:master:4564ba26: github: increase operations-per-run [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 4564ba265a0e3fee45103553dc959b044272094b URL: https://github.com/kamailio/kamailio/commit/4564ba265a0e3fee45103553dc959b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T09:17:27+01:00 github: increase operations-per-run [skip ci] --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/4564ba265a0e3fee45103553dc959b0… Patch: https://github.com/kamailio/kamailio/commit/4564ba265a0e3fee45103553dc959b0… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index 6f43e90b575..142f63c2e1f 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -19,4 +19,5 @@ jobs: days-before-close: 14 exempt-issue-labels: bug remove-stale-when-updated: true + operations-per-run: 1000 ascending: true

1 0

git:master:d6335767: github: allow execute issue_management from panel [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: d6335767223f7841a448689e4f54a6f7709e2cc8 URL: https://github.com/kamailio/kamailio/commit/d6335767223f7841a448689e4f54a6f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T08:52:11+01:00 github: allow execute issue_management from panel [skip ci] * change order since we are hitting operations-per-run > https://github.com/marketplace/actions/close-stale-issues#ascending --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/d6335767223f7841a448689e4f54a6f… Patch: https://github.com/kamailio/kamailio/commit/d6335767223f7841a448689e4f54a6f… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index d99a934cdfd..6f43e90b575 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -2,6 +2,8 @@ name: 'Close stale issues and PRs' on: schedule: - cron: '30 2 * * *' + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: permissions: issues: write pull-requests: write @@ -17,3 +19,4 @@ jobs: days-before-close: 14 exempt-issue-labels: bug remove-stale-when-updated: true + ascending: true

1 0

git:master:ba76a0f1: .devcontainer: add github-actions extension [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: ba76a0f115f17f65bccc59d59ffc798a7109393c URL: https://github.com/kamailio/kamailio/commit/ba76a0f115f17f65bccc59d59ffc798… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T08:52:02+01:00 .devcontainer: add github-actions extension [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/ba76a0f115f17f65bccc59d59ffc798… Patch: https://github.com/kamailio/kamailio/commit/ba76a0f115f17f65bccc59d59ffc798… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 98d103801ea..a0f156e25bb 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -24,6 +24,7 @@ "settings": {}, "extensions": [ "ms-vscode.cpptools-extension-pack", + "GitHub.vscode-github-actions", "xaver.clang-format" ] }

1 0

[kamailio/kamailio] ndb_redis: cannot evaluate mathematical expression in array subscript $redis(r=>value[EXPR]) (Issue #3526)
by Alex Balashov 08 Nov '23

08 Nov '23

Running `5.7.1:441300`, trying to loop through the results of an `HGETALL` operation in Redis: ``` 127.0.0.1:6379[1]> keys * 1) "customer_params:14045551212:1.1.1.1" 127.0.0.1:6379[1]> hgetall customer_params:14045551212:1.1.1.1 1) "auth_ha1" 2) "9febe8cf72c6bd063b8978cded892e4bb" ``` This means that the returned type will be `$redisd(rpl_arr)` and a loop is required. For any given key value `$redis(r=>value[x])`, the value is in the next array slot, at `$redis(r=>value[x + 1])`. With that in mind, I tried this loop: ``` $var(i) = 0; while($var(i) < $redis(r=>size)) { $var(key) = $redis(r=>value[$var(i)]); switch($var(key)) { case "auth_ha1": $var(auth_ha1) = $redis(r=>value[$var(i)+1]); break; } $var(i) = $var(i) + 1; } ``` However, this ends up storing the key value ("auth_ha1") in `$var(auth_ha1)`. I also tried `$(var(i){s.int}) + 1` for the subscript value. To get the actual next-slot value, the expression evaluation has to be externalised into an intermediate variable: ``` while($var(i) < $redis(r=>size)) { $var(key) = $redis(r=>value[$var(i)]); # For some reason, Kamailio cannot evaluate an addition expression inside this subscript: $redis(r=>value[EXPR]) $var(idx) = $var(i) + 1; switch($var(key)) { case "auth_ha1": $var(auth_ha1) = $redis(r=>value[$var(idx)]); break; } $var(i) = $var(i) + 1; } ``` This works, and yields `9febe8cf72c6bd063b8978cded892e4bb`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3526 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3526(a)github.com>

3 4

git:master:ca613b49: github: close-stale-issues
by Victor Seva 07 Nov '23

07 Nov '23

Module: kamailio Branch: master Commit: ca613b491412a7ebb6f3d59956a8cbbde1cb725a URL: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-07T23:24:45+01:00 github: close-stale-issues As discussed at Kamailio developers meeting 2023 --- Added: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb… Patch: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml new file mode 100644 index 00000000000..d99a934cdfd --- /dev/null +++ b/.github/workflows/issue_management.yml @@ -0,0 +1,19 @@ +name: 'Close stale issues and PRs' +on: + schedule: + - cron: '30 2 * * *' +permissions: + issues: write + pull-requests: write +jobs: + stale: + runs-on: ubuntu-latest + steps: + - uses: actions/stale@v8 + with: + stale-issue-message: 'This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.' + stale-pr-message: 'This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.' + days-before-stale: 42 + days-before-close: 14 + exempt-issue-labels: bug + remove-stale-when-updated: true

1 0

git:master:4587d46d: core: set atexit to default to no
by Daniel-Constantin Mierla 07 Nov '23

07 Nov '23

Module: kamailio Branch: master Commit: 4587d46d06fe4fe1d7c754b46b0f68910cbca633 URL: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-07T17:19:44+01:00 core: set atexit to default to no --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689… Patch: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689… --- diff --git a/src/main.c b/src/main.c index e299db3b319..8c3e34e5bc7 100644 --- a/src/main.c +++ b/src/main.c @@ -167,7 +167,7 @@ Options:\n\ --atexit=val Control atexit callbacks execution from external libraries\n\ which may access destroyed shm memory causing crash on shutdown.\n\ Can be y[es] or 1 to enable atexit callbacks, n[o] or 0 to disable,\n\ - default is yes.\n\ + default is no.\n\ -A define Add config pre-processor define (e.g., -A WITH_AUTH,\n\ -A 'FLT_ACC=1', -A 'DEFVAL=\"str-val\"')\n\ -b nr Maximum OS UDP receive buffer size which will not be exceeded by\n\ @@ -546,7 +546,7 @@ char *sr_memmng_shm = NULL; static int *_sr_instance_started = NULL; int ksr_cfg_print_mode = 0; -int ksr_atexit_mode = 1; +int ksr_atexit_mode = 0; int ksr_wait_worker1_mode = 0; int ksr_wait_worker1_time = 4000000;

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev