- sr-dev - kamailio.org

[kamailio/kamailio] kamailio.pid does not exist -- Kamailio start failed (Issue #4243)
by nochnoi82 16 May '25

16 May '25

nochnoi82 created an issue (kamailio/kamailio#4243) Greetings folks. Need your help or conclusion. Debian 12 Kamailio 6.0.1 (Open source installed) Init script and systemd script were applied. kamctl start (/usr/local/sbin) ERROR: PID file /var/run/kamailio.pid does not exist -- Kamailio start failed kamailio start (/usr/local/sbin) error: 'start' is not a supported argument error: stopping kamailio ... sudo journalctl -xeu kamailio ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: YES) May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: usrloc [dlist.c:848]: register_udomain(): failed to open database connection May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: registrar [registrar.c:773]: domain_fixup(): failed to register domain May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:750 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:753 Kamailio acts as proxy server only. What did i miss? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4243 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4243(a)github.com>

3 4

git:master:57ec3497: pv: added $tts variable
by Daniel-Constantin Mierla 15 May '25

15 May '25

Module: kamailio Branch: master Commit: 57ec3497c5a584850bd2883d6a6e8fd0535e11d7 URL: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-15T12:10:30+02:00 pv: added $tts variable - return to-tag state: 0 - if not set; 1 - if set --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Patch: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 81781303049..89f5d5c2a14 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -398,6 +398,8 @@ static pv_export_t mod_pvs[] = { pv_init_iname, 5}, {{"tt", (sizeof("tt") - 1)}, /* */ PVT_OTHER, pv_get_to_attr, 0, 0, 0, pv_init_iname, 4}, + {{"tts", (sizeof("tts") - 1)}, /* */ + PVT_OTHER, pv_get_totagstate, 0, 0, 0, 0, 0}, {{"tu", (sizeof("tu") - 1)}, /* */ PVT_TO, pv_get_to_attr, pv_set_to_uri, 0, 0, pv_init_iname, 1}, {{"to", (sizeof("to") - 1)}, /* */ diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 56d96b20d75..a1064738bba 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -509,6 +509,27 @@ int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_xto_attr(msg, param, res, get_to(msg), 0); } +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + if(msg == NULL) + return pv_get_uintval(msg, param, res, 0); + + if(msg->to == NULL && parse_headers(msg, HDR_TO_F, 0) == -1) { + LM_ERR("cannot parse To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + if(msg->to == NULL || get_to(msg) == NULL) { + LM_DBG("no To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + + if(get_to(msg)->tag_value.s != NULL && get_to(msg)->tag_value.len > 0) { + return pv_get_uintval(msg, param, res, 1); + } + + return pv_get_uintval(msg, param, res, 0); +} + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { if(msg == NULL) diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 16b14bf31cd..1341c9ba0f0 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -77,6 +77,8 @@ int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_cseq(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

[kamailio/kamailio] rtpengine: select node with weight=0 if no other nodes online (Issue #4180)
by sergey-safarov 13 May '25

13 May '25

sergey-safarov created an issue (kamailio/kamailio#4180) ### Description I have installed two `rtpengine` instances and want to use them as an `active backup`. I want to use `backup` only when `active` is unavailable. Closest settings for this rtpengine node `weight` and want to use settings like ``` MariaDB [kamailio]> select * from rtpengine; +----+-------+---------------------------------+--------+----------+---------------------+ | id | setid | url | weight | disabled | stamp | +----+-------+---------------------------------+--------+----------+---------------------+ | 1 | 0 | udp6:[2005:84c0:bf:11::20]:2223 | 1 | 0 | 1900-01-01 00:00:01 | | 2 | 0 | udp6:[2005:84c0:bf:11::21]:2223 | 0 | 0 | 1900-01-01 00:00:01 | +----+-------+---------------------------------+--------+----------+---------------------+ ``` But in case `weight=0` node is not selected and handled as disabled. It will be fine do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. ### Expected behavior Do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. #### Actual observed behavior The node is not selected and handled as disabled when `weight=0`. #### Log Messages ``` rtpengine [rtpengine.c:3430]: rtpp_test(): rtpengine instance <udp6:[2005:84c0:bf:11::21]:2223> found, support for it enabled rtpengine [rtpengine.c:3883]: select_rtpp_node(): rtpengine failed to select new for calllen=27 callid=1-10824@2005:84c0:bf:11::22 rtpengine [rtpengine.c:3183]: rtpp_function_call(): no available proxies ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4180 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4180(a)github.com>

3 3

[kamailio/kamailio] WSS-connections show up as <null> in $tls_version and $tls_cypher_info (Issue #4167)
by Christian Berger 12 May '25

12 May '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4167) Hi, we have found a potential bug. The pseudo variables return null for WSS connections. Example config: `xlog("L_INFO", "<mainLogic> REGISTER: TLS or WSS detected: fU=$fU tls_version=$tls_version tls_cipher_info=$tls_cipher_info ua=$ua\n");` Log output: `Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 310, "function": "get_version", "message": "TLS connection not found in select_version\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 201, "function": "get_cipher", "message": "TLS connection not found in select_cipher\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "xlog", "file": "xlog.c", "line": 278, "function": "", "message": "<mainLogic> REGISTER: TLS or WSS detected: fU=1125411e0 tls_version=<null> tls_cipher_info=<null> ua=webphone\n" }` As you can see both tls_version and tls_cipher_info return <null> even though the underlying connection is via WSS. We have looked into it, and it seems like `get_cur_connection` in `modules/tls/tls_select.c` only checks for TLS, but not WSS. ``` struct tcp_connection *get_cur_connection(struct sip_msg *msg) { struct tcp_connection *c; if(_tls_pv_con != 0) return _tls_pv_con; if(msg->rcv.proto != PROTO_TLS) { ERR("Transport protocol is not TLS (bug in config)\n"); return 0; } c = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, cfg_get(tls, tls_cfg, con_lifetime)); if(c && c->type != PROTO_TLS) { ERR("Connection found but is not TLS\n"); tcpconn_put(c); return 0; } return c; } ``` We think that checking for `PROTO_WSS` might solve the issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4167 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4167(a)github.com>

4 5

[kamailio/kamailio] dispatcher: OPTIONS check does not triggered after new target added (Issue #4212)
by sergey-safarov 12 May '25

12 May '25

sergey-safarov created an issue (kamailio/kamailio#4212) ### Description When I add a new dispatcher target using the kamcmd command, then kamailio does not start send OPTIONS. #### Reproduction Need to start Kamailio with config file ``` listen=eth0 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/dev/null") route{ xerr("TEST $ci\n"); drop; } ``` And then execute comands ``` kamcmd dispatcher.add 1 "sip:sip.telnyx.com:5060;transport=tcp" 8 kamcmd dispatcher.list ``` After the last command expected output ``` { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:sip.telnyx.com:5060;transport=tcp FLAGS: AP PRIORITY: 0 } } } } } ``` As you can see, the target has `AP` flags, which means the target is active and probing enabled. But no OPTIONS messages were sent. #### Log Messages Here is kamailio debug output for during kamcmd execitions and some time after ``` 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 68 12(94363) DEBUG: <core> [core/dns_cache.c:533]: _dns_hash_find(): (sip.telnyx.com(14), 1), h=507 12(94363) DEBUG: <core> [core/resolve.c:1021]: get_record(): skipping 0 NS (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/resolve.c:1035]: get_record(): parsing 0 ARs (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/dns_cache.c:1699]: dns_get_related(): (0x7fce63a32000 (sip.telnyx.com, 1), 1, *(nil)) (0) 12(94363) DEBUG: <core> [core/dns_cache.c:1702]: dns_get_related(): record not alone: 0x7fce63a32000 - type: 1 12(94363) DEBUG: <core> [core/dns_cache.c:748]: dns_cache_add_unsafe(): adding sip.telnyx.com(14) 1 (flags=0) at 507 12(94363) DEBUG: dispatcher [dispatch.c:768]: add_dest2list(): dest [1/1] <sip:sip.telnyx.com:5060;transport=tcp> 12(94363) DEBUG: dispatcher [dispatch.c:258]: ds_log_dst_cb(): dst>> 1 sip:sip.telnyx.com:5060;transport=tcp 8 0 (,0,0,0) 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 68 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 25 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 25 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 14.2.1 ``` * **Operating System**:  ``` root@nout:~# cat /etc/os-release NAME="Fedora Linux" VERSION="41 (Workstation Edition)" RELEASE_TYPE=stable ID=fedora VERSION_ID=41 VERSION_CODENAME="" PLATFORM_ID="platform:f41" PRETTY_NAME="Fedora Linux 41 (Workstation Edition)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:41" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=41 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=41 SUPPORT_END=2025-12-15 VARIANT="Workstation Edition" VARIANT_ID=workstation ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4212 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4212(a)github.com>

3 8

[kamailio/kamailio] Improve and document cdp module list_peers output (Issue #4226)
by Henning Westerholt 12 May '25

12 May '25

henningw created an issue (kamailio/kamailio#4226) Improve and document cdp module list_peers output Example output: reg03:~$ sudo kamcmd cdp.list_peers { Realm: YYY.com Identity: 212.XX.XX.3 Accept unknown peers: 0 Connect timeout: 5 Transaction timeout: 5 Default auth session timeout: 3600 Queue length: 32 Workers: 8 Peer count: 3 Peers: { FQDN: 212.XX.XX.1 Details: { State: R_Open Disabled: False Last used: 1745907094 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.2 Details: { State: R_Open Disabled: False Last used: -1406883582 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.3 Details: { State: R_Open Disabled: False Last used: 1745907095 Applications: { appid:vendorid: 4:10415 } } } } 1. Add list_peers command to module XML docs 2. Document State meaning (e.g. what means R_Open etc..) 3. Check/ probably cast time_t value to not output negative numbers -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4226 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4226(a)github.com>

1 2

Analysis regarding performance regressions OpenSSL 3.0/3.x
by Henning Westerholt 11 May '25

11 May '25

Hello, If somebody is using Kamailio in a larger environment with TLS, this new technical analysis and performance report from haproxy could be interesting: https://www.haproxy.com/blog/state-of-ssl-stacks The bottom-line - OpenSSL 3.0 will show serious performance regressions for larger TLS services with higher performance requirements. OpenSSL 3.1 and newer versions are a bit better, but still much slower in key operations. You should consider using the tls_wolfssl module or stay on OpenSSL 1.1.1. For the medium- to long-term we probably should observe how other OpenSSL libraries are developing and act accordingly for the tls modules. The haproxy project recommends besides using wolfssl also the aws-lc library. The situation regarding OpenSSL 3.x seems to be not easily fixable, as these regressions are caused from internal design decisions. Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

1 0

git:master:fdce48b0: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 11 May '25

11 May '25

Module: kamailio Branch: master Commit: fdce48b007d0bede3b1b18cc9249f8351a8ce220 URL: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-11T16:01:10+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Patch: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83…

1 0

git:master:57316690: pv: docs for the new xavp/i rm all functions
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: 57316690e96f8c458e9f83af7e102bfa816bf2cf URL: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: docs for the new xavp/i rm all functions --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Patch: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… --- diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml index 6a06bb717de..0d962a81ca5 100644 --- a/src/modules/pv/doc/pv_admin.xml +++ b/src/modules/pv/doc/pv_admin.xml @@ -726,6 +726,29 @@ xavi_child_sets("WhatEver", "FoO", "Count: $var(n)"); ... xavp_rm("x"); # same result as: $xavp(x) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavp_rm_all"> + <title> + <function moreinfo="none">xavp_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavp(rname). + </para> + <para> + The parameter has to be the name of XAVP in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavp_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavp_rm_all("x"); ... </programlisting> </example> @@ -750,6 +773,29 @@ xavp_rm("x"); ... xavi_rm("WhatEver"); # same result as: $xavi(whatever) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavi_rm_all"> + <title> + <function moreinfo="none">xavi_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavi(rname). + </para> + <para> + The parameter has to be the name of XAVI in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavi_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavi_rm_all("WhatEver"); ... </programlisting> </example>

1 0

git:master:acf3f1eb: pv: added functions to remove all root xavp/xavi items
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: acf3f1ebeebec1540d0e93a80c8df54fee939610 URL: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: added functions to remove all root xavp/xavi items --- Modified: src/modules/pv/pv.c --- Diff: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Patch: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index d5f21ebba65..81781303049 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -507,6 +507,7 @@ static int w_xavp_child_seti( static int w_xavp_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavp_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavp_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_sbranch_set_ruri(sip_msg_t *msg, char p1, char *p2); static int w_sbranch_append(sip_msg_t *msg, char p1, char *p2); @@ -519,6 +520,7 @@ static int w_xavi_child_seti( static int w_xavi_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavi_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_xavp_lshift(sip_msg_t *msg, char *pxname, char *pidx); @@ -577,6 +579,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavp_rm", (cmd_function)w_xavp_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavp_rm_all", (cmd_function)w_xavp_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavp_child_rm", (cmd_function)w_xavp_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavi_child_seti", (cmd_function)w_xavi_child_seti, 3, @@ -585,6 +589,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavi_rm", (cmd_function)w_xavi_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavi_rm_all", (cmd_function)w_xavi_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavi_child_rm", (cmd_function)w_xavi_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavp_lshift", (cmd_function)w_xavp_lshift, 2, @@ -1645,6 +1651,56 @@ static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2) return w_xav_rm(msg, prname, p2, 1); } +/** + * + */ +static int ki_xav_rm_all(sip_msg_t *msg, str *rname, int _case) +{ + int ret; + if(_case) { + ret = xavi_rm_by_name(rname, 1, NULL); + } else { + ret = xavp_rm_by_name(rname, 1, NULL); + } + + return (ret == 0) ? 1 : ret; +} + +static int ki_xavp_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 0); +} + +static int ki_xavi_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 1); +} + +/** + * + */ +static int w_xav_rm_all(sip_msg_t *msg, char *prname, char *p2, int _case) +{ + str rname; + + if(fixup_get_svalue(msg, (gparam_t *)prname, &rname) < 0) { + LM_ERR("failed to get root xavp name\n"); + return -1; + } + + return ki_xav_rm_all(msg, &rname, _case); +} + +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 0); +} + +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 1); +} + /** * */ @@ -3041,6 +3097,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavp_rm_all"), + SR_KEMIP_INT, ki_xavp_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavp_is_null"), SR_KEMIP_INT, ki_xavp_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, @@ -3196,6 +3257,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavi_rm_all"), + SR_KEMIP_INT, ki_xavi_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavi_is_null"), SR_KEMIP_INT, ki_xavi_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git:master:35733d16: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 10 May '25

10 May '25

Module: kamailio Branch: master Commit: 35733d163829e6c9ffd5a5391da872ecf46f4fa1 URL: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-10T13:16:11+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Patch: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 6bfa6e44d81..be626d40c7c 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -2211,6 +2211,7 @@ kamcmd dlg.list_ctx greater comparison; 'lt' - match using integer lesser comparison. Integer comparison can be used only with 'start_ts' key. * mval - matching value. + * limit (optional) - limit of matched dialogs. RPC Command Format: ...

1 0

git:master:c66d9f72: dialog: add missing documentation for optional limit parameter for list_match
by Henning Westerholt 10 May '25

10 May '25

Module: kamailio Branch: master Commit: c66d9f7298aa1d76d1905b3388e3e55023baa5ae URL: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-10T11:07:56Z dialog: add missing documentation for optional limit parameter for list_match --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Patch: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 4a522cd553e..2653f159ea4 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -2848,6 +2848,9 @@ dlg_set_state("early"); <listitem><para> <emphasis>mval</emphasis> - matching value. </para></listitem> + <listitem><para> + <emphasis>limit</emphasis> (optional) - limit of matched dialogs. + </para></listitem> </itemizedlist> <para>RPC Command Format:</para> <programlisting format="linespecific">

1 0

git:master:1f5afd30: app_jsdt: use snprintf() to build path instead of strcat()
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 1f5afd3044dd399a7a8b03430c9d2b899d044b5a URL: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T10:08:21+02:00 app_jsdt: use snprintf() to build path instead of strcat() --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Patch: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index 93383860379..53464f3ced5 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -459,7 +459,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) DIR *directory = NULL; struct dirent *dir_entry = NULL; size_t size_to_allocate = 0; - char full_path_to_file[255] = {0}; + char full_path_to_file[512] = {0}; size_t name_len = 0; directory = opendir(_sr_jsdt_load_dir.s); @@ -474,9 +474,8 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) name_len = strlen(dir_entry->d_name); if(name_len >= 3 && strcmp(dir_entry->d_name + name_len - 3, ".js") == 0) { - strcpy(full_path_to_file, _sr_jsdt_load_dir.s); - strcat(full_path_to_file, "/"); - strcat(full_path_to_file, dir_entry->d_name); + snprintf(full_path_to_file, 512, "%s/%s", _sr_jsdt_load_dir.s, + dir_entry->d_name); LM_DBG("loading js script file: %s from folder %.*s\n", dir_entry->d_name, _sr_jsdt_load_dir.len,

1 0

git:master:03c93484: app_jsdt: initialize allocated buffer
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 03c93484901928700d282a1684e4b6e4eaeed6c4 URL: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T09:59:25+02:00 app_jsdt: initialize allocated buffer --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Patch: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index b11d66aa519..93383860379 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -496,6 +496,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) full_buffer = (char *)malloc(size_to_allocate); if(full_buffer) { + memset(full_buffer, 0, size_to_allocate); buf = full_buffer; allocated_len = size_to_allocate; }

1 0

[kamailio/kamailio] rtpengine: improve compatibility of rtpengine per call leg stats parsing (PR #4233)
by tsearle 08 May '25

08 May '25

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [*] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [*] PR should be backported to stable branches - [*] Tested changes locally - [*] Related to issue #4232 #### Description not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4233 -- Commit Summary -- * rtpengine: improve compatibility of rtpengine per call leg stats parsing -- File Changes -- M src/modules/rtpengine/rtpengine.c (19) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4233.patch https://github.com/kamailio/kamailio/pull/4233.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4233 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4233(a)github.com>

3 8

git:5.8:9fb936b7: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 5.8 Commit: 9fb936b75dd7a06ac8b9a012b03b7c85ca7884ab URL: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:41:50+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) (cherry picked from commit e3b1220b375b48f16ae361cfe592e8c1bd8e7649) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Patch: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 561384df566..81456c4faea 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4052,7 +4052,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4107,9 +4108,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:6.0:e3b1220b: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 6.0 Commit: e3b1220b375b48f16ae361cfe592e8c1bd8e7649 URL: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:40:06+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Patch: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

[kamailio/kamailio] rtpengine: improve compatibility of per-leg statistics parsing (Issue #4232)
by tsearle 07 May '25

07 May '25

tsearle created an issue (kamailio/kamailio#4232) ### Description For getting A and B leg QoS stats, Kamailio expects there to be a SSRC key inside the Stream object. However some versions of rtpengine (tested with mr13.3.1.1) do not send this key. Looking at the master version of rtpengine, I see this key has been added to correspond to ingress SSRCs[0]. This patch adds a checking ingress SSRCs[0] as a fallback if SSRC ### Troubleshooting #### Reproduction use kamailio 6.0.1 and rtpengine mr13.3.1.1 using baresip as the calling and called party the following in the kamailio.cfg ``` modparam("rtpengine", "mos_A_label_pv", "$avp(mos_A_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_A_pv", "$avp(mos_min_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_A_pv", "$avp(mos_min_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_A_pv", "$avp(mos_min_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_A_pv", "$avp(mos_min_roundtrip_A)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_A_pv", "$avp(mos_max_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_A_pv", "$avp(mos_max_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_A_pv", "$avp(mos_max_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_A_pv", "$avp(mos_max_roundtrip_A)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_A_pv", "$avp(mos_average_mos_A)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_A_pv", "$avp(mos_average_packetloss_A)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_A_pv", "$avp(mos_average_jitter_A)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_A_pv", "$avp(mos_average_roundtrip_A)") modparam("rtpengine", "mos_B_label_pv", "$avp(mos_B_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_B_pv", "$avp(mos_min_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_B_pv", "$avp(mos_min_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_B_pv", "$avp(mos_min_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_B_pv", "$avp(mos_min_roundtrip_B)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_B_pv", "$avp(mos_max_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_B_pv", "$avp(mos_max_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_B_pv", "$avp(mos_max_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_B_pv", "$avp(mos_max_roundtrip_B)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_B_pv", "$avp(mos_average_mos_B)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_B_pv", "$avp(mos_average_packetloss_B)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_B_pv", "$avp(mos_average_jitter_B)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_B_pv", "$avp(mos_average_roundtrip_B)") ``` #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages ``` May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 3684, "function": "rtpp_function_call", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine hash table remove entry for callen=16 callid=3df537fef966eb1a viabranch=" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Aleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Bleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4232 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4232(a)github.com>

2 2

git:master:992ee3df: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Richard Fuchs 07 May '25

07 May '25

Module: kamailio Branch: master Commit: 992ee3df02148a940c255b8be7eb9d8e63465834 URL: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2025-05-07T09:06:19-04:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Patch: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:master:f2a60cfa: pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci]
by Victor Seva 06 May '25

06 May '25

Module: kamailio Branch: master Commit: f2a60cfac4cf3a5a6d84e24f7845ab4faeacf45e URL: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-06T15:39:08+02:00 pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Patch: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4…

1 0

git:master:4405af93: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4405af938ec72c0482e85abb3abea7853c5a22bb URL: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T14:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README --- Diff: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Patch: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78…

1 0

git:master:2e20c74f: app_jsdt: doc - fix section tags for loaddir
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 2e20c74fb03f2442cde5f3f69989a0ed914f542c URL: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:38:02+02:00 app_jsdt: doc - fix section tags for loaddir --- Modified: src/modules/app_jsdt/doc/app_jsdt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Patch: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… --- diff --git a/src/modules/app_jsdt/doc/app_jsdt_admin.xml b/src/modules/app_jsdt/doc/app_jsdt_admin.xml index 6d139c29428..bbf2148b9b4 100644 --- a/src/modules/app_jsdt/doc/app_jsdt_admin.xml +++ b/src/modules/app_jsdt/doc/app_jsdt_admin.xml @@ -107,35 +107,31 @@ modparam("app_jsdt", "load", "/usr/local/etc/kamailio/js/myscript.js") </programlisting> </example> </section> - <section> - <title>Parameters</title> - <section id="app_jsdt.p.loaddir"> - <title> - <varname>loaddir</varname> (str) - </title> - <para> - Set the path to the folder containing JavaScript files to be loaded at startup. All - .js files in the folder will be loaded and combined into a single javascript script. - Then you can use jsdt_run(function, params) to execute a function from the - script at runtime. If you use it for KEMI configuration, - then it has to include the required functions. - </para> - <para> - <emphasis> - Default value is <quote>null</quote>. - </emphasis> - </para> - <example> - <title> - Set <varname>loaddir</varname> parameter - </title> - <programlisting format="linespecific"> - ... - modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") - ... - </programlisting> - </example> - </section> + <section id="app_jsdt.p.loaddir"> + <title><varname>loaddir</varname> (str)</title> + <para> + Set the path to the folder containing JavaScript files to be loaded at startup. All + .js files in the folder will be loaded and combined into a single javascript script. + Then you can use jsdt_run(function, params) to execute a function from the + script at runtime. If you use it for KEMI configuration, + then it has to include the required functions. + </para> + <para> + <emphasis> + Default value is <quote>null</quote>. + </emphasis> + </para> + <example> + <title> + Set <varname>loaddir</varname> parameter + </title> + <programlisting format="linespecific"> +... +modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") +... +</programlisting> + </example> + </section> <section id="app_jsdt.p.mode"> <title><varname>mode</varname> (int)</title> <para> @@ -328,4 +324,3 @@ request_route { </programlisting> </section> </chapter> -

1 0

git:master:7fa8b166: Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 7fa8b166bfc813270d19a30351326a94a9187852 URL: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:34:06+02:00 Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1 --- Modified: CMakeLists.txt Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Patch: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 36451562d6f..6d68b5da980 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ project( ) # Set the version number -set(EXTRAVERSION "-dev0") +set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}") message(STATUS "PROJECT_VERSION: ${PROJECT_VERSION}") diff --git a/src/Makefile.defs b/src/Makefile.defs index 7656029123e..6ff7eeddb51 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 6 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -dev0 +EXTRAVERSION = -dev1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

[kamailio/kamailio] cdp: restructure locking order to prevent rare deadlock (PR #4191)
by Morten Tryfoss 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description We've been running the ims_charging module in production for quite some time, without any issues. A couple of days ago the whole instance freezed, but I was able to get a dump before the stuck processes before restarting. The traffic volume has gradually increased over time, so it's likely related to that. I then did a summary of the different types of stuck processes. Which locks they're holding, and what they're waiting for: ``` holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8cde in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:108 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7fe6e4a5ba30) at peermanager.c:259 #3 0x00007fe70ebb64b7 in get_first_connected_route (cdp_session=0x7fe6e5cc5350, r=0x7fe6e4a5ba30, app_id=4, vendor_id=10415) at routing.c:115 #4 0x00007fe70ebb9a37 in get_routing_peer (cdp_session=0x7fe6e5cc5350, m=0x7fe6e5447ab0) at routing.c:293 #5 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5447ab0, callback_f=0x7fe707a9e323 <resume_on_initial_ccr>, callback_param=0x7fe6e5297110) at diameter_comm.c:139 #6 0x00007fe707a9d3e0 in Ro_Send_CCR (msg=0x7fe70f011100, dlg=0x7fe6e5c571f0, dir=0, reservation_units=30, incoming_trunk_id=0x7ffe50efb060, outgoing_trunk_id=0x7ffe50efb050, pani=0x7ffe50efaee0, action=0x7fe70efa4730, tindex=10484, tlabel=677172593) at ims_ro.c:1511 #7 0x00007fe707a8285d in ki_ro_ccr (msg=0x7fe70f011100, s_route_name=0x7ffe50efb080, s_direction=0x7ffe50efb070, reservation_units=30, s_incoming_trunk_id=0x7ffe50efb060, s_outgoing_trunk_id=0x7ffe50efb050) at ims_charging_mod.c:742 #8 0x00007fe707a7bf01 in w_ro_ccr (msg=0x7fe70f011100, c_route_name=0x7fe70ef8b8d0 "\220\311\371\016\347\177", c_direction=0x7fe70ef8b980 "p\240\371\016\347\177", reservation_units=30, c_incoming_trunk_id=0x7fe70ef8ba30 "p\241\371\016\347\177", c_outgoing_trunk_id=0x7fe70ef8bae0 "\360\241\371\016\347\177") at ims_charging_mod.c:507 #9 0x00000000004858d8 in do_action (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1144 #10 0x00000000004928d6 in run_actions (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1618 #11 0x0000000000492f52 in run_actions_safe (h=0x7ffe50eff1e0, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1681 #12 0x0000000000450156 in rval_get_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, i=0x7ffe50efbec8, rv=0x7fe70ef9c1d8, cache=0x0) at core/rvalue.c:973 #13 0x0000000000454d24 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efbec8, rve=0x7fe70ef9c1d0) at core/rvalue.c:1854 #14 0x0000000000454d52 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efc448, rve=0x7fe70ef9b920) at core/rvalue.c:1864 #15 0x00000000004850ce in do_action (h=0x7ffe50eff1e0, a=0x7fe70ef9b070, msg=0x7fe70f011100) at core/action.c:1097 -- holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:121 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7ffe50efab90) at peermanager.c:259 #3 0x00007fe70ebb8e89 in get_routing_peer (cdp_session=0x7fe6e5ab6910, m=0x7fe6e5435be0) at routing.c:252 #4 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5435be0, callback_f=0x7fe707a95edc <resume_on_termination_ccr>, callback_param=0x0) at diameter_comm.c:139 #5 0x00007fe707a95b02 in send_ccr_stop_with_param (ro_session=0x7fe6e5ab65e0, code=0, reason=0x7ffe50efb060) at ims_ro.c:1181 #6 0x00007fe707a72ff7 in dlg_terminated (dlg=0x7fe6e623d7a0, type=64, termcode=0, reason=0x7fe707ab72b3 "normal call clearing", _params=0x7fe707f67280 <params>) at dialog.c:249 #7 0x00007fe707a6a729 in dlg_callback_received (dlg=0x7fe6e623d7a0, type=64, _params=0x7fe707f67280 <params>) at dialog.c:25 #8 0x00007fe707d341b9 in run_dlg_callbacks (type=64, dlg=0x7fe6e623d7a0, req=0x7fe70f011100, rpl=0x0, dir=1, dlg_data=0x0) at dlg_cb.c:271 #9 0x00007fe707cf4db4 in dlg_terminated (req=0x7fe70f011100, dlg=0x7fe6e623d7a0, dir=1) at dlg_handlers.c:413 #10 0x00007fe707cfddeb in dlg_onroute (req=0x7fe70f011100, route_params=0x7ffe50efb6d0, param=0x0) at dlg_handlers.c:1097 #11 0x00007fe70ad285f6 in run_rr_callbacks (req=0x7fe70f011100, rr_param=0x7ffe50efb7c0) at rr_cb.c:96 #12 0x00007fe70ad3ae92 in after_loose (_m=0x7fe70f011100, preloaded=0) at loose.c:1021 #13 0x00007fe70ad3b5ce in loose_route_mode (_m=0x7fe70f011100, _mode=0) at loose.c:1056 #14 0x00007fe70ad3f74f in w_loose_route (msg=0x7fe70f011100, p1=0x0, p2=0x0) at rr_mod.c:273 #15 0x00000000004855ff in do_action (h=0x7ffe50efc390, a=0x7fe70efe0d40, msg=0x7fe70f011100) at core/action.c:1121 -- holding lock: lock_get(peer_list_lock); waiting for lock: lock_get(p->lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5cbd0) at ../../core/futexlock.h:121 #2 0x00007fe70ebab0ae in peer_timer (now=1742807320, ptr=0x0) at peermanager.c:286 #3 0x00007fe70ebd0f39 in timer_loop () at timer.c:116 #4 0x00007fe70ebd21b2 in timer_process (returns=0) at timer.c:216 #5 0x00007fe70eb8ccf8 in diameter_peer_start (blocking=0) at diameter_peer.c:350 #6 0x00007fe70eb7cbb2 in cdp_child_init (rank=0) at cdp_mod.c:272 -- holding lock: lock_get(p->lock) waiting for lock: AAASessionsLock #1 0x00007fe70ebf2597 in futex_get (lock=0x7fe6e4a5d490) at ../../core/futexlock.h:108 #2 0x00007fe70ebf26f1 in AAASessionsLock (hash=0) at session.c:79 #3 0x00007fe70ebf5e6e in cdp_get_session (id=...) at session.c:316 #4 0x00007fe70eba6892 in Snd_Message (p=0x7fe6e4a5c880, msg=0x7fe6e63998d0) at peerstatemachine.c:1237 #5 0x00007fe70eba003e in sm_process (p=0x7fe6e4a5c880, event=Send_Message, msg=0x7fe6e63998d0, peer_locked=0, sock=0) at peerstatemachine.c:429 #6 0x00007fe70ebcbdc6 in AAASendMessage (message=0x7fe6e63998d0, callback_f=0x7fe707a8f208 <resume_on_interim_ccr>, callback_param=0x7fe6e6190a90) at diameter_comm.c:166 #7 0x00007fe707a8edb3 in send_ccr_interim (ro_session=0x7fe6e5399160, used=60, reserve=30) at ims_ro.c:847 #8 0x00007fe707a68bd6 in ro_session_ontimeout (tl=0x7fe6e5399200) at ro_timer.c:513 #9 0x00007fe707a63078 in ro_timer_routine (ticks=114862426, attr=0x0) at ro_timer.c:279 #10 0x00000000004fd33e in compat_old_handler (ti=1837798827, tl=0x7fe6e4cf6260, data=0x7fe6e4cf6260) at core/timer.c:980 #11 0x00000000004fde7a in slow_timer_main () at core/timer.c:1103 #12 0x000000000042e4e7 in main_loop () at main.c:1911 #13 0x000000000043876c in main (argc=10, argv=0x7ffe50f001c8) at main.c:3236 ``` In `get_first_connected_route()` in `routing.c` of the cdp module there are two places `get_peer_by_fqdn()` are called. One of them has an unlock/relock of the session list before and after (and a comment about holding two locks at a time), while the other doesn't. I'm currently testing two version of this. The first by just doing the some relock for the other `get_peer_by_fqdn()`, but this PR got an approach for maybe fixing more latent issues. `sm_process()` also got some strange handling by `Rcv_Process()` after the peer lock is released, which seems to be about the same thing. My deadlock is for the `Snd_Message()` equivalent. I've now removed this queueing behaviour, and instead doing a re-lock of the peer to (hopefully) have the same locking order as the other operations. The problem with this thing is how rare it occurs. Just wanted to share my findings for others with more knowledge to the cdp module for comments, suggestions and hopefully some extra testing. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4191 -- Commit Summary -- * cdp: restructure locking order to prevent rare deadlock -- File Changes -- M src/modules/cdp/peerstatemachine.c (25) M src/modules/cdp/routing.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4191.patch https://github.com/kamailio/kamailio/pull/4191.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4191 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4191(a)github.com>

4 13

git:master:12bfe206: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 12bfe206daa6b9c2e8aa73e0d0da416d6593fd4e URL: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T13:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README Modified: src/modules/cdp/README Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Patch: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev