- sr-dev - kamailio.org

[kamailio/kamailio] error on module (Issue #3704)
by faratell 09 Jan '24

09 Jan '24

Hello. I am trying to install Kamailio branch devel for using Volte on open5gs. when compiled have this error: gcrypt_mod.c:36:10: fatal error: gcrypt.h: No such file or directory 36 | #include <gcrypt.h> | ^~~~~~~~~~ compilation terminated. make[2]: *** [../../Makefile.rules:100: gcrypt_mod.o] Error 1 make[2]: Leaving directory '/usr/local/src/kamailio-devel/kamailio/src/modules/gcrypt' make[1]: *** [Makefile:508: modules] Error 1 make[1]: Leaving directory '/usr/local/src/kamailio-devel/kamailio/src' make: *** [Makefile:34: all] Error 2 I have installed the dependencies of crypt : libcrypto and libssl-dev. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3704 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3704(a)github.com>

2 2

git:master:587c3e33: modules: readme files regenerated - gcrypt ... [skip ci]
by Kamailio Dev 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: 587c3e337c3cbabed1373b9308065d59392a370d URL: https://github.com/kamailio/kamailio/commit/587c3e337c3cbabed1373b9308065d5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-09T12:17:06+01:00 modules: readme files regenerated - gcrypt ... [skip ci] --- Modified: src/modules/gcrypt/README --- Diff: https://github.com/kamailio/kamailio/commit/587c3e337c3cbabed1373b9308065d5… Patch: https://github.com/kamailio/kamailio/commit/587c3e337c3cbabed1373b9308065d5… --- diff --git a/src/modules/gcrypt/README b/src/modules/gcrypt/README index 7c4826b849b..3d7f9af4226 100644 --- a/src/modules/gcrypt/README +++ b/src/modules/gcrypt/README @@ -26,7 +26,8 @@ Daniel-Constantin Mierla 3. Parameters 3.1. init_vector (str) - 3.2. register_callid (int) + 3.2. aes_mode (int) + 3.3. register_callid (int) 4. Functions @@ -36,9 +37,10 @@ Daniel-Constantin Mierla List of Examples 1.1. Set init_vector parameter - 1.2. Set register_callid parameter - 1.3. gcrypt_aes_encrypt usage - 1.4. gcrypt_aes_decrypt usage + 1.2. Set aes_mode parameter + 1.3. Set register_callid parameter + 1.4. gcrypt_aes_encrypt usage + 1.5. gcrypt_aes_decrypt usage Chapter 1. Admin Guide @@ -53,7 +55,8 @@ Chapter 1. Admin Guide 3. Parameters 3.1. init_vector (str) - 3.2. register_callid (int) + 3.2. aes_mode (int) + 3.3. register_callid (int) 4. Functions @@ -85,7 +88,8 @@ Chapter 1. Admin Guide 3. Parameters 3.1. init_vector (str) - 3.2. register_callid (int) + 3.2. aes_mode (int) + 3.3. register_callid (int) 3.1. init_vector (str) @@ -99,7 +103,19 @@ Chapter 1. Admin Guide modparam("gcrypt", "init_vector", "abcdefghijklmnop") ... -3.2. register_callid (int) +3.2. aes_mode (int) + + Set it to 1 in order to do AES CBC encryption mode. By default, it does + AES ECB mode. + + Default value is 0. + + Example 1.2. Set aes_mode parameter +... +modparam("gcrypt", "aes_mode", 1) +... + +3.3. register_callid (int) Set it to 1 in order to register a callback to core for generation of callid values for requests generated by Kamailio tm module. @@ -111,7 +127,7 @@ modparam("gcrypt", "init_vector", "abcdefghijklmnop") Default value is 0. - Example 1.2. Set register_callid parameter + Example 1.3. Set register_callid parameter ... modparam("gcrypt", "register_callid", 1) ... @@ -130,7 +146,7 @@ modparam("gcrypt", "register_callid", 1) This function can be used from ANY_ROUTE. - Example 1.3. gcrypt_aes_encrypt usage + Example 1.4. gcrypt_aes_encrypt usage ... gcrypt_aes_encrypt("$rb", "my-secret-key", "$var(encrypted)"); ... @@ -144,7 +160,7 @@ gcrypt_aes_encrypt("$rb", "my-secret-key", "$var(encrypted)"); This function can be used from ANY_ROUTE. - Example 1.4. gcrypt_aes_decrypt usage + Example 1.5. gcrypt_aes_decrypt usage ... gcrypt_aes_decrypt("$var(encrypted)", "my-secret-key", "$var(text)"); ...

1 0

git:master:33a0eeb4: gcrypt: docs for aes_mode parameters
by Daniel-Constantin Mierla 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: 33a0eeb40cb6be28c7921ccb61dcede1ebce4bad URL: https://github.com/kamailio/kamailio/commit/33a0eeb40cb6be28c7921ccb61dcede… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-09T12:00:41+01:00 gcrypt: docs for aes_mode parameters --- Modified: src/modules/gcrypt/doc/gcrypt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/33a0eeb40cb6be28c7921ccb61dcede… Patch: https://github.com/kamailio/kamailio/commit/33a0eeb40cb6be28c7921ccb61dcede… --- diff --git a/src/modules/gcrypt/doc/gcrypt_admin.xml b/src/modules/gcrypt/doc/gcrypt_admin.xml index b88781425cf..533ec5c80f9 100644 --- a/src/modules/gcrypt/doc/gcrypt_admin.xml +++ b/src/modules/gcrypt/doc/gcrypt_admin.xml @@ -75,6 +75,27 @@ modparam("gcrypt", "init_vector", "abcdefghijklmnop") </programlisting> </example> </section> + <section id="gcrypt.p.aes_mode"> + <title><varname>aes_mode</varname> (int)</title> + <para> + Set it to 1 in order to do AES CBC encryption mode. By default, + it does AES ECB mode. + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>aes_mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("gcrypt", "aes_mode", 1) +... +</programlisting> + </example> + </section> + <section id="gcrypt.p.register_callid"> <title><varname>register_callid</varname> (int)</title> <para>

1 0

git:master:2024253f: gcrypt: added aes_mode parameter
by Daniel-Constantin Mierla 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: 2024253fac4c4fda48f2b0c5b9a1f9717294aa22 URL: https://github.com/kamailio/kamailio/commit/2024253fac4c4fda48f2b0c5b9a1f97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-09T11:56:50+01:00 gcrypt: added aes_mode parameter - specify AES encryption mode: - 0: ECB (GCRY_CIPHER_MODE_ECB) - default - 1: CBC (GCRY_CIPHER_MODE_CBC) --- Modified: src/modules/gcrypt/gcrypt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2024253fac4c4fda48f2b0c5b9a1f97… Patch: https://github.com/kamailio/kamailio/commit/2024253fac4c4fda48f2b0c5b9a1f97… --- diff --git a/src/modules/gcrypt/gcrypt_mod.c b/src/modules/gcrypt/gcrypt_mod.c index 1554154d9cc..8a5550139c8 100644 --- a/src/modules/gcrypt/gcrypt_mod.c +++ b/src/modules/gcrypt/gcrypt_mod.c @@ -53,6 +53,8 @@ static int fixup_gcrypt_aes_decrypt(void **param, int param_no); /* init vector value */ static str _gcrypt_init_vector = str_init("SIP/2.0 is RFC3261"); static int _gcrypt_register_callid = 0; +static int _gcrypt_aes_mode_param = 0; +static int _gcrypt_aes_mode = GCRY_CIPHER_MODE_ECB; /* clang-format off */ static cmd_export_t cmds[] = { @@ -66,6 +68,7 @@ static cmd_export_t cmds[] = { static param_export_t params[] = { {"init_vector", PARAM_STR, &_gcrypt_init_vector}, {"register_callid", PARAM_INT, &_gcrypt_register_callid}, + {"aes_mode", PARAM_INT, &_gcrypt_aes_mode_param}, {0, 0, 0} }; @@ -100,6 +103,9 @@ static int mod_init(void) } LM_DBG("registered crypto callid callback\n"); } + if(_gcrypt_aes_mode_param == 1) { + _gcrypt_aes_mode = GCRY_CIPHER_MODE_CBC; + } return 0; } @@ -140,7 +146,7 @@ static int ki_gcrypt_aes_encrypt_helper( gcry_ret = gcry_cipher_open(&cipher_hd, // gcry_cipher_hd_t *hd GCRY_CIPHER_AES256, // int algo - GCRY_CIPHER_MODE_ECB, // int mode + _gcrypt_aes_mode, // int mode 0); // unsigned int flags if(gcry_ret) { LM_ERR("gcry cipher open failed: %s/%s\n", gcry_strsource(gcry_ret), @@ -306,7 +312,7 @@ static int ki_gcrypt_aes_decrypt_helper( gcry_ret = gcry_cipher_open(&cipher_hd, // gcry_cipher_hd_t *hd GCRY_CIPHER_AES256, // int algo - GCRY_CIPHER_MODE_ECB, // int mode + _gcrypt_aes_mode, // int mode 0); // unsigned int flags if(gcry_ret) { LM_ERR("gcry cipher open failed: %s/%s\n", gcry_strsource(gcry_ret),

1 0

git:master:977e4f3e: modules: readme files regenerated - gcrypt ... [skip ci]
by Kamailio Dev 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: 977e4f3e4d2a002f8aed55035c4ab6c3ee9ea1b8 URL: https://github.com/kamailio/kamailio/commit/977e4f3e4d2a002f8aed55035c4ab6c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-09T11:02:08+01:00 modules: readme files regenerated - gcrypt ... [skip ci] --- Modified: src/modules/gcrypt/README --- Diff: https://github.com/kamailio/kamailio/commit/977e4f3e4d2a002f8aed55035c4ab6c… Patch: https://github.com/kamailio/kamailio/commit/977e4f3e4d2a002f8aed55035c4ab6c… --- diff --git a/src/modules/gcrypt/README b/src/modules/gcrypt/README index f836521537c..7c4826b849b 100644 --- a/src/modules/gcrypt/README +++ b/src/modules/gcrypt/README @@ -26,6 +26,7 @@ Daniel-Constantin Mierla 3. Parameters 3.1. init_vector (str) + 3.2. register_callid (int) 4. Functions @@ -35,8 +36,9 @@ Daniel-Constantin Mierla List of Examples 1.1. Set init_vector parameter - 1.2. gcrypt_aes_encrypt usage - 1.3. gcrypt_aes_decrypt usage + 1.2. Set register_callid parameter + 1.3. gcrypt_aes_encrypt usage + 1.4. gcrypt_aes_decrypt usage Chapter 1. Admin Guide @@ -51,6 +53,7 @@ Chapter 1. Admin Guide 3. Parameters 3.1. init_vector (str) + 3.2. register_callid (int) 4. Functions @@ -82,6 +85,7 @@ Chapter 1. Admin Guide 3. Parameters 3.1. init_vector (str) + 3.2. register_callid (int) 3.1. init_vector (str) @@ -92,7 +96,24 @@ Chapter 1. Admin Guide Example 1.1. Set init_vector parameter ... -modparam("crypto", "init_vector", "abcdefghijklmnop") +modparam("gcrypt", "init_vector", "abcdefghijklmnop") +... + +3.2. register_callid (int) + + Set it to 1 in order to register a callback to core for generation of + callid values for requests generated by Kamailio tm module. + + This callid generator uses libcrypt random and hashing functions for + generating RFC 4122 version 4 UUID with high quality entropy. It is + useful when wanting to have new callids that cannot be predicted from + previous values. + + Default value is 0. + + Example 1.2. Set register_callid parameter +... +modparam("gcrypt", "register_callid", 1) ... 4. Functions @@ -109,7 +130,7 @@ modparam("crypto", "init_vector", "abcdefghijklmnop") This function can be used from ANY_ROUTE. - Example 1.2. gcrypt_aes_encrypt usage + Example 1.3. gcrypt_aes_encrypt usage ... gcrypt_aes_encrypt("$rb", "my-secret-key", "$var(encrypted)"); ... @@ -123,7 +144,7 @@ gcrypt_aes_encrypt("$rb", "my-secret-key", "$var(encrypted)"); This function can be used from ANY_ROUTE. - Example 1.3. gcrypt_aes_decrypt usage + Example 1.4. gcrypt_aes_decrypt usage ... gcrypt_aes_decrypt("$var(encrypted)", "my-secret-key", "$var(text)"); ...

1 0

git:master:4d969662: gcrypt: docs for register_callid parameter
by Daniel-Constantin Mierla 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: 4d96966272761816d16b40dc68adf3b24e79fbaf URL: https://github.com/kamailio/kamailio/commit/4d96966272761816d16b40dc68adf3b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-09T10:52:24+01:00 gcrypt: docs for register_callid parameter --- Modified: src/modules/gcrypt/doc/gcrypt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4d96966272761816d16b40dc68adf3b… Patch: https://github.com/kamailio/kamailio/commit/4d96966272761816d16b40dc68adf3b… --- diff --git a/src/modules/gcrypt/doc/gcrypt_admin.xml b/src/modules/gcrypt/doc/gcrypt_admin.xml index 523364318d5..b88781425cf 100644 --- a/src/modules/gcrypt/doc/gcrypt_admin.xml +++ b/src/modules/gcrypt/doc/gcrypt_admin.xml @@ -70,7 +70,33 @@ <title>Set <varname>init_vector</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("crypto", "init_vector", "abcdefghijklmnop") +modparam("gcrypt", "init_vector", "abcdefghijklmnop") +... +</programlisting> + </example> + </section> + <section id="gcrypt.p.register_callid"> + <title><varname>register_callid</varname> (int)</title> + <para> + Set it to 1 in order to register a callback to core for generation + of callid values for requests generated by &kamailio; tm module. + </para> + <para> + This callid generator uses libcrypt random and hashing functions + for generating RFC 4122 version 4 UUID with high quality entropy. + It is useful when wanting to have new callids that cannot be + predicted from previous values. + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>register_callid</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("gcrypt", "register_callid", 1) ... </programlisting> </example>

1 0

git:master:fae3632a: gcrypt: added functions to generate random call-id in uuid format
by Daniel-Constantin Mierla 09 Jan '24

09 Jan '24

Module: kamailio Branch: master Commit: fae3632a224cde753c2a6e3d1d2a72b6e9aa9ceb URL: https://github.com/kamailio/kamailio/commit/fae3632a224cde753c2a6e3d1d2a72b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-09T10:49:48+01:00 gcrypt: added functions to generate random call-id in uuid format - alternative to the option offered by crypto module --- Added: src/modules/gcrypt/gcrypt_uuid.c Added: src/modules/gcrypt/gcrypt_uuid.h Modified: src/modules/gcrypt/gcrypt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fae3632a224cde753c2a6e3d1d2a72b… Patch: https://github.com/kamailio/kamailio/commit/fae3632a224cde753c2a6e3d1d2a72b…

1 0

[kamailio/kamailio] error on make cdp module (Issue #3701)
by faratell 09 Jan '24

09 Jan '24

Hello. I have tried to install VoLTE Setup with Kamailio IMS on Ubuntu 22.04. but I face two errors: 1) IPsec-tools packages not supported for Ubuntu 22.04. 2) when I tried to compile Kamailio the cdp modules were not compiled and showed this error: make[2]: Entering directory '/usr/local/src/kamailio/src/modules/cdp' Makefile.defs defs skipped gcc -shared -Wl,-O2 -Wl,-E -pthread -rdynamic -ldl -Wl,-Bsymbolic-functions acceptor.o acctstatemachine.o api_process.o authstatemachine.o cdp_functions.o cdp_load.o cdp_mod.o cdp_rpc.o cdp_stats.o common.o config.o configparser.o diameter_avp.o diameter_comm.o diameter_msg.o diameter_peer.o globals.o peer.o peermanager.o peerstatemachine.o receiver.o routing.o session.o tcp_accept.o timer.o transaction.o worker.o -lxml2 -lrt -lpthread -o cdp.so /usr/bin/ld: cdp_mod.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: multiple definition of `dp_first_pid'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: first defined here /usr/bin/ld: cdp_mod.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: multiple definition of `pid_list'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: first defined here /usr/bin/ld: cdp_mod.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: multiple definition of `pid_list_lock'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: first defined here /usr/bin/ld: diameter_peer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: multiple definition of `dp_first_pid'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: first defined here /usr/bin/ld: diameter_peer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: multiple definition of `pid_list'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: first defined here /usr/bin/ld: diameter_peer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: multiple definition of `pid_list_lock'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: first defined here /usr/bin/ld: receiver.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: multiple definition of `dp_first_pid'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: first defined here /usr/bin/ld: receiver.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: multiple definition of `pid_list'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: first defined here /usr/bin/ld: receiver.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: multiple definition of `pid_list_lock'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: first defined here /usr/bin/ld: timer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: multiple definition of `dp_first_pid'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: first defined here /usr/bin/ld: timer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: multiple definition of `pid_list'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: first defined here /usr/bin/ld: timer.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: multiple definition of `pid_list_lock'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: first defined here /usr/bin/ld: worker.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: multiple definition of `dp_first_pid'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:68: first defined here /usr/bin/ld: worker.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: multiple definition of `pid_list'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:70: first defined here /usr/bin/ld: worker.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: multiple definition of `pid_list_lock'; acceptor.o:/usr/local/src/kamailio/src/modules/cdp/diameter_peer.h:71: first defined here collect2: error: ld returned 1 exit status make[2]: *** [../../Makefile.rules:191: cdp.so] Error 1 make[2]: Leaving directory '/usr/local/src/kamailio/src/modules/cdp' make[1]: *** [Makefile:511: modules] Error 1 make[1]: Leaving directory '/usr/local/src/kamailio/src' make: *** [Makefile:34: all] Error 2 How can I solve it? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3701 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3701(a)github.com>

4 9

[kamailio/kamailio] sigabrt on kamailio 5.5.6 (Issue #3593)
by descartin 09 Jan '24

09 Jan '24

version: kamailio 5.5.6 (x86_64/linux) 21a9bc Operating System: Debian GNU/Linux 11 (bullseye) Kernel: Linux 5.10.0-22-amd64 we see this core it has repeated some times in different days ``` (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x00007fde2329f537 in __GI_abort () at abort.c:79 #2 0x000055d5fab45995 in sig_alarm_abort (signo=14) at main.c:699 #3 <signal handler called> #4 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:37 #5 0x00007fde1c80a015 in futex_get (lock=0x7fdd9f9c9ca4) at ../../core/mem/../futexlock.h:108 #6 0x00007fde1c80c526 in destroy_linkers (linker=0x0) at dlg_profile.c:275 #7 0x00007fde1c7f87b3 in destroy_dlg (dlg=0x7fddad479ea0) at dlg_hash.c:377 #8 0x00007fde1c7f8ca0 in destroy_dlg_table () at dlg_hash.c:438 #9 0x00007fde1c790286 in mod_destroy () at dialog.c:809 #10 0x000055d5fad76dd8 in destroy_modules () at core/sr_module.c:842 #11 0x000055d5fab440e2 in cleanup (show_status=1) at main.c:575 #12 0x000055d5fab45d45 in shutdown_children (sig=15, show_status=1) at main.c:718 #13 0x000055d5fab49129 in handle_sigs () at main.c:816 #14 0x000055d5fab56959 in main_loop () at main.c:1903 #15 0x000055d5fab602e9 in main (argc=15, argv=0x7ffd9451bbb8) at main.c:3061 (gdb) bt full #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 set = {__val = {8192, 0 <repeats 15 times>}} pid = <optimized out> tid = <optimized out> ret = <optimized out> #1 0x00007fde2329f537 in __GI_abort () at abort.c:79 save_stage = 1 act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0}, sa_mask = {__val = {0 <repeats 16 times>}}, sa_flags = 0, sa_restorer = 0x55d5faf6b088} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x000055d5fab45995 in sig_alarm_abort (signo=14) at main.c:699 __func__ = "sig_alarm_abort" #3 <signal handler called> No locals. #4 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:37 No locals. #5 0x00007fde1c80a015 in futex_get (lock=0x7fdd9f9c9ca4) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #6 0x00007fde1c80c526 in destroy_linkers (linker=0x0) at dlg_profile.c:275 p_entry = 0x7fdd9f9c9d88 l = 0x7fddd2aca430 lh = 0x55d5faf81a03 __func__ = "destroy_linkers" #7 0x00007fde1c7f87b3 in destroy_dlg (dlg=0x7fddad479ea0) at dlg_hash.c:377 ret = 1 var = 0x7fde1c719a44 <mod_destroy+859> --Type <RET> for more, q to quit, c to continue without paging-- __func__ = "destroy_dlg" #8 0x00007fde1c7f8ca0 in destroy_dlg_table () at dlg_hash.c:438 dlg = 0x0 l_dlg = 0x7fddad479ea0 i = 0 __func__ = "destroy_dlg_table" #9 0x00007fde1c790286 in mod_destroy () at dialog.c:809 No locals. #10 0x000055d5fad76dd8 in destroy_modules () at core/sr_module.c:842 t = 0x7fde1f328018 foo = 0x7fde1f327838 __func__ = "destroy_modules" #11 0x000055d5fab440e2 in cleanup (show_status=1) at main.c:575 memlog = 0 __func__ = "cleanup" #12 0x000055d5fab45d45 in shutdown_children (sig=15, show_status=1) at main.c:718 __func__ = "shutdown_children" #13 0x000055d5fab49129 in handle_sigs () at main.c:816 chld = 0 chld_status = 139 any_chld_stopped = 1 memlog = 0 __func__ = "handle_sigs" #14 0x000055d5fab56959 in main_loop () at main.c:1903 i = 14 pid = 3845341 --Type <RET> for more, q to quit, c to continue without paging-- si = 0x0 si_desc = "udp receiver child=13 sock=87.237.87.28:5060\000\000\000\000\300\272Q\224\375\177\000\000\000\000\000\000\000\000\000\000\003\032\370\372\325U\000\000-\000\000\000\000\000\000\000\200\003\062\037\336\177\000\000F\034\067#\336\177\000\000\060\000\000\000\060\000\000\000x\266Q\224\375\177\000\000\220\265Q\224\375\177\000\000\000\230\026︾\314\"" nrprocs = 14 woneinit = 1 __func__ = "main_loop" #15 0x000055d5fab602e9 in main (argc=15, argv=0x7ffd9451bbb8) at main.c:3061 cfg_stream = 0x55d5fbd3f2e0 c = -1 r = 0 tmp = 0x7ffd9451ce7c "" tmp_len = 832 port = 832 proto = 832 ahost = 0x0 aport = 0 options = 0x55d5faf6e0b8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 4110196155 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x98000000980 p = 0xc2 <error: Cannot access memory at address 0xc2> st = {st_dev = 23, st_ino = 946, st_nlink = 2, st_mode = 16832, st_uid = 0, st_gid = 998, __pad0 = 0, st_rdev = 0, st_size = 140, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1696021490, tv_nsec = 675255852}, --Type <RET> for more, q to quit, c to continue without paging-- st_mtim = {tv_sec = 1696418622, tv_nsec = 168794592}, st_ctim = {tv_sec = 1696418622, tv_nsec = 168794592}, __glibc_reserved = {0, 0, 0}} tbuf = "P\267Q\224\375\177\000\000\310e)#\336\177\000\000\020\204]#\336\177\000\000\000\000\000\000\000\000\000\000зQ\224\375\177\000\000\000\000\000\000\000\000\000\000зQ\224\375\177", '\000' <repeats 18 times>, "`g^#\336\177\000\000\350$a#\336\177\000\000\204i^#\336\177\000\000\060d^#\336\177\000\000H\020a#\336\177\000\000\000`^#\336\177\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000@\"(#\336\177", '\000' <repeats 66 times>... option_index = 0 long_options = {{name = 0x55d5faf70526 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x55d5faf6b51c "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x55d5faf7052b "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x55d5faf70531 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x55d5faf70537 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x55d5faf70540 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x55d5faf7054a "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x55d5faf70554 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x55d5faf7055f "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x55d5faf70568 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x55d5faf70573 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x55d5faf70579 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x55d5faf70583 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) ``` could it be related to any type of message that is making the kamailio crush? thanks a lot and regards david -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3593 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3593(a)github.com>

4 7

[kamailio/kamailio] janssonrpcc: No failover to lower prio server (Issue #3378)
by Alex Hermann 09 Jan '24

09 Jan '24

### Description I have 2 jsonrpc servers configured with different prio's. For testing, I have the servers configured to always delay the response to any request by more than the module's timout setting. The (initial) request is sent to the first server. As this one times out, I would expect a retry to go to the second servers, but instead, all retries are sent to the same server. The backup server is never contacted. This makes the whole "prio" system seem a bit useless.  ### Troubleshooting #### Reproduction ``` modparam("janssonrpcc", "server", "conn=test;addr=pc1;port=8081;priority=5;weight=10") modparam("janssonrpcc", "server", "conn=test;addr=pc1;port=8082;priority=5;weight=10") ``` ``` janssonrpc_request("test", "Test.Timeout", '[ { "Timout": 1000} ]', "route=JSONRPC_RESPONSE;retry=10;timeout=1000"); ```  #### Log Messages No useful logs are produced. I verified the described behavior on the jsonrpc server.  ``` 2023-02-23T16:59:34.585346+01:00 pc1 proxy1[340870]: INFO: janssonrpcc [janssonrpc_connect.c:361]: bev_connect(): Connecting to server pc1:8081 for conn rating. 2023-02-23T16:59:34.585420+01:00 pc1 proxy1[340870]: INFO: janssonrpcc [janssonrpc_connect.c:361]: bev_connect(): Connecting to server pc1:8082 for conn rating. 2023-02-23T16:59:34.585446+01:00 pc1 proxy1[340870]: INFO: janssonrpcc [janssonrpc_connect.c:290]: bev_connect_cb(): Connected to host pc1:8081 2023-02-23T16:59:34.585462+01:00 pc1 proxy1[340870]: INFO: janssonrpcc [janssonrpc_connect.c:290]: bev_connect_cb(): Connected to host pc1:8082 2023-02-23T17:05:10.903398+01:00 pc1 proxy1[340870]: WARNING: janssonrpcc [janssonrpc_request.c:247]: schedule_retry(): Number of retries exceeded. Failing request. ``` ### Possible Solutions  Retry in combination with a timeout and prio's is a bit tricky. When do what? Just retrying on the first prio makes the lower prio servers completely useless, while going to the next prio on every retry skips possibly useful high-prio servers and may exhaust the number of candidate servers very fast. Best solution IMHO would be to first try every server in the highest prio, before going to the next prio. Do not do (exponential) backoff between these steps. If there are still retries remaining after that, wrap around to the highest prio with the exponentional backoff delay. With the above, failover considers all servers and failover between servers is fast while not overloading a single server. BTW. If I configure multiple servers per prio, it seems to randomly select one of them for every (re)try. It never selects one form the next prio. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3378 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3378(a)github.com>

4 10

git:5.7:1eb1d50e: outbound: build, fix missing argument name
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: 1eb1d50e676fe8f81521c209f37ffe907fa9cf94 URL: https://github.com/kamailio/kamailio/commit/1eb1d50e676fe8f81521c209f37ffe9… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 outbound: build, fix missing argument name (cherry-pick from 4708f537d7f5d28123b48cd89474a4931dd698ad) --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1eb1d50e676fe8f81521c209f37ffe9… Patch: https://github.com/kamailio/kamailio/commit/1eb1d50e676fe8f81521c209f37ffe9… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index a797eb8132e..32f10f6cdb9 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -75,7 +75,7 @@ struct module_exports exports = { destroy /* destroy function */ }; -static void *mod_init_openssl(void *) { +static void *mod_init_openssl(void *arg) { if(flow_token_secret.s) { assert(ob_key.len == SHA_DIGEST_LENGTH); LM_DBG("flow_token_secret mod param set. use persistent ob_key");

1 0

git:5.7:fe096868: outbound: OpenSSL 1.1.1 thread-local, init libssl in thread
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: fe0968687d5ee7918f6a18591623fcb1b5fe2004 URL: https://github.com/kamailio/kamailio/commit/fe0968687d5ee7918f6a18591623fcb… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 outbound: OpenSSL 1.1.1 thread-local, init libssl in thread (cherry-pick from 689de2736f5c92f11860e5854ccd95c84239f032) --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fe0968687d5ee7918f6a18591623fcb… Patch: https://github.com/kamailio/kamailio/commit/fe0968687d5ee7918f6a18591623fcb… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index 00c0a66f73b..a797eb8132e 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -110,7 +110,7 @@ static int mod_init(void) } ob_key.len = OB_KEY_LEN; -#if OPENSSL_VERSION_NUMBER < 0x030000000L +#if OPENSSL_VERSION_NUMBER < 0x010101000L mod_init_openssl(NULL); #else pthread_t tid;

1 0

git:5.7:31e42aad: outbound: OpenSSL 3.x thread-local, init libssl in thread
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: 31e42aade0a42aac8a128a4af3f37edb23bb3ab8 URL: https://github.com/kamailio/kamailio/commit/31e42aade0a42aac8a128a4af3f37ed… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 outbound: OpenSSL 3.x thread-local, init libssl in thread (cherry-pick from 4742c8131aba878c4fc954e42b656b9d4bafdd24) --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/31e42aade0a42aac8a128a4af3f37ed… Patch: https://github.com/kamailio/kamailio/commit/31e42aade0a42aac8a128a4af3f37ed… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index 4e408e22356..00c0a66f73b 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -75,6 +75,23 @@ struct module_exports exports = { destroy /* destroy function */ }; +static void *mod_init_openssl(void *) { + if(flow_token_secret.s) { + assert(ob_key.len == SHA_DIGEST_LENGTH); + LM_DBG("flow_token_secret mod param set. use persistent ob_key"); + SHA1((const unsigned char *)flow_token_secret.s, flow_token_secret.len, + (unsigned char *)ob_key.s); + } else { + if(RAND_bytes((unsigned char *)ob_key.s, ob_key.len) == 0) { + LM_ERR("unable to get %d cryptographically strong pseudo-" + "random bytes\n", + ob_key.len); + } + } + + return NULL; +} + static int mod_init(void) { if(ob_force_flag != -1 && !flag_in_range(ob_force_flag)) { @@ -93,18 +110,14 @@ static int mod_init(void) } ob_key.len = OB_KEY_LEN; - if(flow_token_secret.s) { - assert(ob_key.len == SHA_DIGEST_LENGTH); - LM_DBG("flow_token_secret mod param set. use persistent ob_key"); - SHA1((const unsigned char *)flow_token_secret.s, flow_token_secret.len, - (unsigned char *)ob_key.s); - } else { - if(RAND_bytes((unsigned char *)ob_key.s, ob_key.len) == 0) { - LM_ERR("unable to get %d cryptographically strong pseudo-" - "random bytes\n", - ob_key.len); - } - } +#if OPENSSL_VERSION_NUMBER < 0x030000000L + mod_init_openssl(NULL); +#else + pthread_t tid; + void *retval; + pthread_create(&tid, NULL, mod_init_openssl, NULL); + pthread_join(tid, &retval); +#endif if(cfg_declare("outbound", outbound_cfg_def, &default_outbound_cfg, cfg_sizeof(outbound), &outbound_cfg)) {

1 0

git:5.7:7060ad2b: tls: OpenSSL 3.x/1.1.1 thread-local, clean-up dead code and preprocessor blocks
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: 7060ad2b0ebf90288be9d8d7e9d789ccbb3aebdc URL: https://github.com/kamailio/kamailio/commit/7060ad2b0ebf90288be9d8d7e9d789c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 tls: OpenSSL 3.x/1.1.1 thread-local, clean-up dead code and preprocessor blocks (cherry-pick from 798cc26908395d2ba21015684ad6f0ac4f012b2e) --- Modified: src/modules/tls/tls_init.c Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7060ad2b0ebf90288be9d8d7e9d789c… Patch: https://github.com/kamailio/kamailio/commit/7060ad2b0ebf90288be9d8d7e9d789c… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 58289c626c4..65f5ae72c65 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -783,12 +783,7 @@ int tls_h_mod_pre_init_f(void) LM_DBG("preparing tls env for modules initialization\n"); #if OPENSSL_VERSION_NUMBER >= 0x010100000L && !defined(LIBRESSL_VERSION_NUMBER) LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n"); -#if OPENSSL_VERSION_NUMBER >= 0x030000000L - // skip init for 3.x -#elif OPENSSL_VERSION_NUMBER >= 0x010101000L - //not needed on Linux - //OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); -#else +#if OPENSSL_VERSION_NUMBER < 0x010100000L OPENSSL_init_ssl(0, NULL); #endif #else diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 03874edabba..7cad1b046e4 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -438,20 +438,9 @@ static int mod_child(int rank) if(tls_disable || (tls_domains_cfg == 0)) return 0; - /* fix tls config only from the main proc/PROC_INIT., when we know - * the exact process number and before any other process starts*/ - if(rank == PROC_INIT) { -#if OPENSSL_VERSION_NUMBER >= 0x010101000L \ - && OPENSSL_VERSION_NUMBER < 0x030000000L - if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) { - // not needed on Linux: OPENSSL_fork_prepare(); - } -#endif - } - #if OPENSSL_VERSION_NUMBER >= 0x010101000L /* - * OpenSSL 3.x: create shared SSL_CTX* in worker to avoid init of + * OpenSSL 3.x/1.1.1: create shared SSL_CTX* in worker to avoid init of * libssl in rank 0(thread#1) */ if(rank == PROC_SIPINIT) { @@ -471,22 +460,6 @@ static int mod_child(int rank) return 0; } -#if OPENSSL_VERSION_NUMBER >= 0x010101000L \ - && OPENSSL_VERSION_NUMBER < 0x030000000L - if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) { - if(rank == PROC_POSTCHILDINIT) { - /* - * this is called after forking of all child processes - */ - // not needed on Linux: OPENSSL_fork_parent(); - return 0; - } - if(!_ksr_is_main) { - // not needed on Linux: OPENSSL_fork_child(); - } - } -#endif - #ifndef OPENSSL_NO_ENGINE /* * after the child is fork()ed we go through the TLS domains @@ -514,6 +487,11 @@ static void mod_destroy(void) * => nothing to do here */ } +/* + * GH #3695: OpenSSL 1.1.1: it is no longer necessary to replace RAND + * - early init in rank 0 causes workers to inherit public_drbg/private_drbg + * which are not thread-safe + */ int ksr_rand_engine_param(modparam_t type, void *val) { @@ -690,12 +668,10 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) register_tls_hooks(&tls_h); -#if OPENSSL_VERSION_NUMBER >= 0x10100000L \ - && OPENSSL_VERSION_NUMBER < 0x030000000L - LM_DBG("setting cryptorand random engine\n"); - // RAND_set_rand_method(RAND_ksr_cryptorand_method()); -#endif - + /* + * GH #3695: OpenSSL 1.1.1 historical note: it is no longer + * needed to replace RAND with cryptorand + */ sr_kemi_modules_add(sr_kemi_tls_exports); return 0;

1 0

git:5.7:e73b07e9: tls: thread-local, revert 1a9b0b6361 as double-layer locking is redundant
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: e73b07e9835ba5f0b89065616d8cd6390898d700 URL: https://github.com/kamailio/kamailio/commit/e73b07e9835ba5f0b89065616d8cd63… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 tls: thread-local, revert 1a9b0b6361 as double-layer locking is redundant - the 2nd lock was put in place as defensive programming for shm contention - GH #3695: the underlying issue is early init of thread-locals (cherry-pick from 1c70775530b1a3a905e8a983610cb0d092b0d240) --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/e73b07e9835ba5f0b89065616d8cd63… Patch: https://github.com/kamailio/kamailio/commit/e73b07e9835ba5f0b89065616d8cd63… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 2d5a9e19420..58289c626c4 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -259,9 +259,6 @@ static void *ser_malloc(size_t size, const char *file, int line) static ticks_t st = 0; #endif - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); - #ifdef RAND_NULL_MALLOC /* start random null returns only after * NULL_GRACE_PERIOD from first call */ @@ -289,8 +286,6 @@ static void *ser_malloc(size_t size, const char *file, int line) size, file, line, bt_buf); } #endif - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); return p; } @@ -304,9 +299,6 @@ static void *ser_realloc(void *ptr, size_t size, const char *file, int line) static ticks_t st = 0; #endif - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); - #ifdef RAND_NULL_MALLOC /* start random null returns only after * NULL_GRACE_PERIOD from first call */ @@ -335,21 +327,14 @@ static void *ser_realloc(void *ptr, size_t size, const char *file, int line) } #endif - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); - return p; } static void ser_free(void *ptr, const char *fname, int fline) { - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); if(ptr) { shm_free(ptr); } - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); } #endif /* LIBRESSL_VERSION_NUMBER */ @@ -363,11 +348,7 @@ static void *ser_malloc(size_t size) { void *p; - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); p = shm_malloc(size); - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); return p; } @@ -375,22 +356,14 @@ static void *ser_malloc(size_t size) static void *ser_realloc(void *ptr, size_t size) { void *p; - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); p = shm_realloc(ptr, size); - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); return p; } #else static void *ser_malloc(size_t size, const char *fname, int fline) { void *p; - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); p = shm_malloc(size); - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); return p; } @@ -398,11 +371,7 @@ static void *ser_malloc(size_t size, const char *fname, int fline) static void *ser_realloc(void *ptr, size_t size, const char *fname, int fline) { void *p; - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); p = shm_realloc(ptr, size); - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); return p; } #endif @@ -419,24 +388,16 @@ static void ser_free(void *ptr) * As shm_free() aborts on null pointers, we have to check for null pointer * here in the wrapper function. */ - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); if(ptr) { shm_free(ptr); } - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); } #else static void ser_free(void *ptr, const char *fname, int fline) { - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_lock(ksr_tls_lock_shm); if(ptr) { shm_free(ptr); } - if(ksr_tls_init_mode & TLS_MODE_PTHREAD_LOCK_SHM) - pthread_mutex_unlock(ksr_tls_lock_shm); } #endif

1 0

git:5.7:c011f518: tls: OpenSSL 1.1.1 thread-local, init libssl in thread
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: c011f518b083fc2f7da3a08a2c1a306c6122b04c URL: https://github.com/kamailio/kamailio/commit/c011f518b083fc2f7da3a08a2c1a306… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 tls: OpenSSL 1.1.1 thread-local, init libssl in thread - no need for RAND workaround; default is OpenSSL 1.1.1 RAND - linux/pthreads will handle forking (cherry-pick from 7b531cfe038fae5e3414ac74c4e076c10e32b86c) --- Modified: src/modules/tls/tls_init.c Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/c011f518b083fc2f7da3a08a2c1a306… Patch: https://github.com/kamailio/kamailio/commit/c011f518b083fc2f7da3a08a2c1a306… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 872fdb206dc..2d5a9e19420 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -825,7 +825,8 @@ int tls_h_mod_pre_init_f(void) #if OPENSSL_VERSION_NUMBER >= 0x030000000L // skip init for 3.x #elif OPENSSL_VERSION_NUMBER >= 0x010101000L - OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); + //not needed on Linux + //OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); #else OPENSSL_init_ssl(0, NULL); #endif @@ -833,7 +834,7 @@ int tls_h_mod_pre_init_f(void) LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n"); SSL_library_init(); #endif -#if OPENSSL_VERSION_NUMBER < 0x030000000L +#if OPENSSL_VERSION_NUMBER < 0x010101000L SSL_load_error_strings(); #endif diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 1e74ba0e309..03874edabba 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -440,8 +440,16 @@ static int mod_child(int rank) /* fix tls config only from the main proc/PROC_INIT., when we know * the exact process number and before any other process starts*/ + if(rank == PROC_INIT) { +#if OPENSSL_VERSION_NUMBER >= 0x010101000L \ + && OPENSSL_VERSION_NUMBER < 0x030000000L + if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) { + // not needed on Linux: OPENSSL_fork_prepare(); + } +#endif + } -#if OPENSSL_VERSION_NUMBER >= 0x030000000L +#if OPENSSL_VERSION_NUMBER >= 0x010101000L /* * OpenSSL 3.x: create shared SSL_CTX* in worker to avoid init of * libssl in rank 0(thread#1) @@ -460,12 +468,6 @@ static int mod_child(int rank) < 0) return -1; } -#if OPENSSL_VERSION_NUMBER >= 0x010101000L \ - && OPENSSL_VERSION_NUMBER < 0x030000000L - if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) { - OPENSSL_fork_prepare(); - } -#endif return 0; } @@ -476,11 +478,11 @@ static int mod_child(int rank) /* * this is called after forking of all child processes */ - OPENSSL_fork_parent(); + // not needed on Linux: OPENSSL_fork_parent(); return 0; } if(!_ksr_is_main) { - OPENSSL_fork_child(); + // not needed on Linux: OPENSSL_fork_child(); } } #endif @@ -691,7 +693,7 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) #if OPENSSL_VERSION_NUMBER >= 0x10100000L \ && OPENSSL_VERSION_NUMBER < 0x030000000L LM_DBG("setting cryptorand random engine\n"); - RAND_set_rand_method(RAND_ksr_cryptorand_method()); + // RAND_set_rand_method(RAND_ksr_cryptorand_method()); #endif sr_kemi_modules_add(sr_kemi_tls_exports);

1 0

git:5.7:90ea4120: tls: fix compilation with OpenSSL <= 1.1.1
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: 90ea4120c04cb70f858f417309ee4fab71a070e7 URL: https://github.com/kamailio/kamailio/commit/90ea4120c04cb70f858f417309ee4fa… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:18:55+08:00 tls: fix compilation with OpenSSL <= 1.1.1 (cherry-pick from 7111687e1107261bcdd7a9f8cc90959754c93272) --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/90ea4120c04cb70f858f417309ee4fa… Patch: https://github.com/kamailio/kamailio/commit/90ea4120c04cb70f858f417309ee4fa… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 0bc12d31b4a..872fdb206dc 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -769,6 +769,7 @@ int tls_pre_init(void) * tls mod pre-init function * - executed before any mod_init() */ +#if OPENSSL_VERSION_NUMBER >= 0x030000000L long tls_h_mod_randctx(void *) { do { OSSL_LIB_CTX *osslglobal = NULL; @@ -806,6 +807,7 @@ long tls_h_mod_randctx(void *) { return 0L; } +#endif int tls_h_mod_pre_init_f(void) {

1 0

git:5.7:ed2d7035: tls: OpenSSL 3.x thread-local, init libssl in thread or PROC_SIPINIT
by Richard Chan 09 Jan '24

09 Jan '24

Module: kamailio Branch: 5.7 Commit: ed2d70359723458089dd8a62fe1e37a60dd83869 URL: https://github.com/kamailio/kamailio/commit/ed2d70359723458089dd8a62fe1e37a… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Richard Chan <richard(a)treeboxsolutions.com> Date: 2024-01-09T10:12:59+08:00 tls: OpenSSL 3.x thread-local, init libssl in thread or PROC_SIPINIT - avoid initialising ERR_STATE in rank 0(thread#1) (cherry-pick from e49a60e1052c6c1dcebe7f78f2ac970338eabe2e) --- Modified: src/modules/tls/tls_init.c Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ed2d70359723458089dd8a62fe1e37a… Patch: https://github.com/kamailio/kamailio/commit/ed2d70359723458089dd8a62fe1e37a… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 57be9cad814..0bc12d31b4a 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -769,6 +769,44 @@ int tls_pre_init(void) * tls mod pre-init function * - executed before any mod_init() */ +long tls_h_mod_randctx(void *) { + do { + OSSL_LIB_CTX *osslglobal = NULL; + EVP_RAND_CTX *randctx = NULL; + + LM_DBG("enabling locking for rand ctx\n"); + + osslglobal = OSSL_LIB_CTX_get0_global_default(); + if(osslglobal == NULL) { + LM_ERR("failed to get lib ssl global ctx\n"); + return -1L; + } + + randctx = RAND_get0_primary(osslglobal); + if(randctx == NULL) { + LM_ERR("primary rand ctx is null\n"); + return -1L; + } + EVP_RAND_enable_locking(randctx); + + randctx = RAND_get0_public(osslglobal); + if(randctx == NULL) { + LM_ERR("public rand ctx is null\n"); + return -1L; + } + EVP_RAND_enable_locking(randctx); + + randctx = RAND_get0_private(osslglobal); + if(randctx == NULL) { + LM_ERR("private rand ctx is null\n"); + return -1L; + } + EVP_RAND_enable_locking(randctx); + } while(0); + + return 0L; +} + int tls_h_mod_pre_init_f(void) { if(tls_mod_preinitialized == 1) { @@ -782,7 +820,9 @@ int tls_h_mod_pre_init_f(void) LM_DBG("preparing tls env for modules initialization\n"); #if OPENSSL_VERSION_NUMBER >= 0x010100000L && !defined(LIBRESSL_VERSION_NUMBER) LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n"); -#if OPENSSL_VERSION_NUMBER >= 0x010101000L +#if OPENSSL_VERSION_NUMBER >= 0x030000000L + // skip init for 3.x +#elif OPENSSL_VERSION_NUMBER >= 0x010101000L OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); #else OPENSSL_init_ssl(0, NULL); @@ -791,42 +831,17 @@ int tls_h_mod_pre_init_f(void) LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n"); SSL_library_init(); #endif +#if OPENSSL_VERSION_NUMBER < 0x030000000L SSL_load_error_strings(); +#endif #if OPENSSL_VERSION_NUMBER >= 0x030000000L - do { - OSSL_LIB_CTX *osslglobal = NULL; - EVP_RAND_CTX *randctx = NULL; - - LM_DBG("enabling locking for rand ctx\n"); - - osslglobal = OSSL_LIB_CTX_get0_global_default(); - if(osslglobal == NULL) { - LM_ERR("failed to get lib ssl global ctx\n"); - return -1; - } - - randctx = RAND_get0_primary(osslglobal); - if(randctx == NULL) { - LM_ERR("primary rand ctx is null\n"); - return -1; - } - EVP_RAND_enable_locking(randctx); - - randctx = RAND_get0_public(osslglobal); - if(randctx == NULL) { - LM_ERR("public rand ctx is null\n"); - return -1; - } - EVP_RAND_enable_locking(randctx); - - randctx = RAND_get0_private(osslglobal); - if(randctx == NULL) { - LM_ERR("private rand ctx is null\n"); - return -1; - } - EVP_RAND_enable_locking(randctx); - } while(0); + pthread_t tid; + long rl; + pthread_create(&tid, NULL, (void *(*)(void *))tls_h_mod_randctx, NULL); + pthread_join(tid, (void **)&rl); + if ((int)rl) + return (int)rl; #endif tls_mod_preinitialized = 1; diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 3a047769ca4..1e74ba0e309 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -440,7 +440,16 @@ static int mod_child(int rank) /* fix tls config only from the main proc/PROC_INIT., when we know * the exact process number and before any other process starts*/ - if(rank == PROC_INIT) { + +#if OPENSSL_VERSION_NUMBER >= 0x030000000L + /* + * OpenSSL 3.x: create shared SSL_CTX* in worker to avoid init of + * libssl in rank 0(thread#1) + */ + if(rank == PROC_SIPINIT) { +#else + if(rank == PROC_INIT) { +#endif if(cfg_get(tls, tls_cfg, config_file).s) { if(tls_fix_domains_cfg( *tls_domains_cfg, &srv_defaults, &cli_defaults)

1 0

git:master:db8dd08b: Makefile.groups: added group for gcrypt module
by Daniel-Constantin Mierla 08 Jan '24

08 Jan '24

Module: kamailio Branch: master Commit: db8dd08b5506ac40314b70386b9ea83b509e17b1 URL: https://github.com/kamailio/kamailio/commit/db8dd08b5506ac40314b70386b9ea83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-08T20:21:02+01:00 Makefile.groups: added group for gcrypt module --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/db8dd08b5506ac40314b70386b9ea83… Patch: https://github.com/kamailio/kamailio/commit/db8dd08b5506ac40314b70386b9ea83… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index d730a7eb51b..df1fde094af 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -235,6 +235,9 @@ mod_list_ruxc=ruxc # - modules depending on microhttpd library mod_list_microhttpd=microhttpd +# - modules depending on libgcrypt library +mod_list_gcrypt=gcrypt + # - modules depending on secsipid library mod_list_secsipid=secsipid secsipid_proc @@ -285,6 +288,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_tlsa) \ $(mod_list_tls_wolfssl) \ $(mod_list_microhttpd) \ + $(mod_list_gcrypt) \ $(mod_list_rtp_media_server) @@ -538,6 +542,9 @@ module_group_kruxc=$(mod_list_ruxc) # K microhttpd module module_group_kmicrohttpd=$(mod_list_microhttpd) +# K gcrypt module +module_group_kgcrypt=$(mod_list_gcrypt) + # K secsipid modules module_group_ksecsipid=$(mod_list_secsipid)

1 0

git:master:4df92312: parser/contact: Change addition order to the end of list
by Henning Westerholt 08 Jan '24

08 Jan '24

Module: kamailio Branch: master Commit: 4df92312166d8aad700007ef0898d0a7c6ba40b7 URL: https://github.com/kamailio/kamailio/commit/4df92312166d8aad700007ef0898d0a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-08T15:55:43+01:00 parser/contact: Change addition order to the end of list - Contacts are now added at the end of the list. - hfl(Contact)[index] is now returning in the correct order. --- Modified: src/core/parser/contact/contact.c --- Diff: https://github.com/kamailio/kamailio/commit/4df92312166d8aad700007ef0898d0a… Patch: https://github.com/kamailio/kamailio/commit/4df92312166d8aad700007ef0898d0a… --- diff --git a/src/core/parser/contact/contact.c b/src/core/parser/contact/contact.c index 3c66a2082b0..dd522a6cd3c 100644 --- a/src/core/parser/contact/contact.c +++ b/src/core/parser/contact/contact.c @@ -208,6 +208,18 @@ static inline int skip_name(str *_s) return -1; } +static inline void contact_append(contact_t **head, contact_t *node) +{ + contact_t *ptr = *head; + if(*head == NULL) { + *head = node; + return; + } + while(ptr->next != NULL) { + ptr = ptr->next; + } + ptr->next = node; +} /* * Parse contacts in a Contact HF @@ -298,8 +310,7 @@ int parse_contacts(str *_s, contact_t **_c) _s->len--; trim_leading(_s); - c->next = *_c; - *_c = c; + contact_append(_c, c); c = NULL; if(_s->len == 0) { @@ -318,8 +329,8 @@ int parse_contacts(str *_s, contact_t **_c) ok: c->len = _s->s - c->name.s; - c->next = *_c; - *_c = c; + contact_append(_c, c); + c = NULL; return 0; }

1 0

[kamailio/kamailio] parser/contact: Change addition order to the end of list (PR #3698)
by Xenofon Karamanos 08 Jan '24

08 Jan '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3653 #### Description  - Contacts are now added at the end of the list. - hfl(Contact)[index] is now returning in the correct order. Currently, if a sip message contains multiple Contacts or just 2, let's say ``` Contact: <sip:bob0@example.com>;expires=3600,<sip:bob1@example.com>;expires=3600,<sip:bob2@example.com>;expires=3600 Contact: <sip:bob3@example.com>;expires=3600,<sip:bob4@example.com>;expires=3600,<sip:bob5@example.com>;expires=3600 ``` contacts are stored in the reversed order, ie bob2, bob1,bob0 and bob5,bob4,bob3. This can be seen with a simple config file such as: ``` #kamailio.cfg ... request_route { ... xlog("L_INFO", "Contact headers: $hfl(Contact)\n"); xlog("L_INFO", "Contact headers 0: $(hfl(Contact)[0])\n"); xlog("L_INFO", "Contact headers 1: $(hfl(Contact)[1])\n"); xlog("L_INFO", "Contact headers 2: $(hfl(Contact)[2])\n"); xlog("L_INFO", "Contact headers 3: $(hfl(Contact)[3])\n"); xlog("L_INFO", "Contact headers 4: $(hfl(Contact)[4])\n"); xlog("L_INFO", "Contact headers 5: $(hfl(Contact)[5])\n"); xlog("L_INFO", "Contact headers 6: $(hfl(Contact)[6])\n"); xlog("L_INFO", "Contact headers 7: $(hfl(Contact)[7])\n"); xlog("L_INFO", "Contact headers -1: $(hfl(Contact)[-1])\n"); xlog("L_INFO", "Contact headers -2: $(hfl(Contact)[-2])\n"); xlog("L_INFO", "Contact headers -3: $(hfl(Contact)[-3])\n"); xlog("L_INFO", "Contact headers -4: $(hfl(Contact)[-4])\n"); xlog("L_INFO", "Contact headers -5: $(hfl(Contact)[-5])\n"); xlog("L_INFO", "Contact headers -6: $(hfl(Contact)[-6])\n"); ``` that prints in the log all the contacts reversed: ``` Contact headers: <sip:bob2@example.com>;expires=3600 Contact headers 0: <sip:bob2@example.com>;expires=3600 Contact headers 1: <sip:bob1@example.com>;expires=3600 Contact headers 2: <sip:bob0@example.com>;expires=3600 Contact headers 3: <sip:bob5@example.com>;expires=3600 Contact headers 4: <sip:bob4@example.com>;expires=3600 Contact headers 5: <sip:bob3@example.com>;expires=3600 Contact headers 6: <null> Contact headers 7: <null> Contact headers -1: <sip:bob3@example.com>;expires=3600 Contact headers -2: <sip:bob4@example.com>;expires=3600 Contact headers -3: <sip:bob5@example.com>;expires=3600 Contact headers -4: <sip:bob0@example.com>;expires=3600 Contact headers -5: <sip:bob1@example.com>;expires=3600 Contact headers -6: <sip:bob2@example.com>;expires=3600 ``` This PR fixes and produces: ``` Contact headers: <sip:bob0@example.com>;expires=3600 Contact headers 0: <sip:bob0@example.com>;expires=3600 Contact headers 1: <sip:bob1@example.com>;expires=3600 Contact headers 2: <sip:bob2@example.com>;expires=3600 Contact headers 3: <sip:bob3@example.com>;expires=3600 Contact headers 4: <sip:bob4@example.com>;expires=3600 Contact headers 5: <sip:bob5@example.com>;expires=3600 Contact headers 6: <null> Contact headers 7: <null> Contact headers -1: <null> Contact headers -2: <sip:bob5@example.com>;expires=3600 Contact headers -3: <sip:bob4@example.com>;expires=3600 Contact headers -4: <sip:bob3@example.com>;expires=3600 Contact headers -5: <sip:bob2@example.com>;expires=3600 Contact headers -6: <sip:bob1@example.com>;expires=3600 ``` The `contact headers -1: <null>` if fixed via #3697. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3698 -- Commit Summary -- * parser/contact: Change addition order to the end of list -- File Changes -- M src/core/parser/contact/contact.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3698.patch https://github.com/kamailio/kamailio/pull/3698.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3698 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3698(a)github.com>

3 8

[kamailio/kamailio] pv: hfl(name)[N] for negative index bug (Issue #3653)
by Xenofon Karamanos 08 Jan '24

08 Jan '24

### Description I am working on extending $hfl and $hflc to support some more headers. During some experimentation, I stumbled into some weird behavior regarding $(hfl(Route)[-1]) and negative indexing of $hfl pseudo-variable (also for Via, Contact). Per the [docs ](https://www.kamailio.org/wikidocs/cookbooks/devel/pseudovariables/#hflname-header-field-with-list-of-bodies ): -1 index should print the last header found and so on (as stated by $hdr $hfl). Right now, -1 produces null, and from -2 and onwards it prints correctly from the last one to the first one. ### Troubleshooting #### Reproduction ``` #kamailio.cfg ... request_route { xlog("L_INFO", "Route headers hdr: $hdr(Route)\n"); xlog("L_INFO", "Route headers hfl: $hfl(Route)\n"); xlog("L_INFO", "Route headers count: $hflc(Route)\n"); xlog("L_INFO", "Route headers 0: $(hfl(Route)[0])\n"); xlog("L_INFO", "Route headers 1: $(hfl(Route)[1])\n"); xlog("L_INFO", "Route headers 4: $(hfl(Route)[4])\n"); xlog("L_INFO", "Route headers -1: $(hfl(Route)[-1])\n"); xlog("L_INFO", "Route headers -2: $(hfl(Route)[-2])\n"); xlog("L_INFO", "Route headers -3: $(hfl(Route)[-3])\n"); ... } ``` Seng a SIP message containing Route (but also applicable for VIA, Contact headers): ``` OPTIONS_MSG_2CONTACTS="OPTIONS sip:example.com SIP/2.0 Via: SIP/2.0/UDP 192.168.1.100:5060;branch=z9hG4bK123456789 Max-Forwards: 70 From: <sip:bob@example.com>;tag=123456789 To: <sip:alice@example.com> Call-ID: 987654321(a)192.168.1.100 CSeq: 1 OPTIONS Contact: <sip:bob@example.com>;expires=3600,<sip:bob2@example.com>;expires=3600,<sip:bob3@example.com>;expires=3600 Route: <sip:server1.example.com;lr;ftag=1234>, <sip:server2.example.com;lr;ftag=5678>, <sip:server3.example.com;lr;ftag=9012> Route: <sip:server4.example.com;lr;ftag=1234>, <sip:server5.example.com;lr;ftag=5678> Content-Length: 0 " echo -e "$OPTIONS_MSG_2CONTACTS" | nc -u localhost 5060 ``` See logs for logging details. #### Log Messages  ``` INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers hdr: <sip:server1.example.com;lr;ftag=1234>, <sip:server2.example.com;lr;ftag=5678>, <sip:server3.example.com;lr;ftag=9012> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers hfl: <sip:server1.example.com;lr;ftag=1234> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers count: 5 INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers 0: <sip:server1.example.com;lr;ftag=1234> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers 1: <sip:server2.example.com;lr;ftag=5678> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers 4: <sip:server5.example.com;lr;ftag=5678> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers -1: <null> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers -2: <sip:server5.example.com;lr;ftag=5678> INFO: {1 1 OPTIONS 987654321(a)192.168.1.100} <script>: Route headers -3: <sip:server4.example.com;lr;ftag=1234> ``` ### Possible Solutions  In https://github.com/kamailio/kamailio/blob/e59c4415707f0995a0d5315b5601ae518…, the count should start at 0 ie. ``` n=0; // not n=1; ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3653 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3653(a)github.com>

2 2

[kamailio/kamailio] libbcg729-dev dependency of dpkg-checkbuilddeps can not install on ubuntu 18.04 (Issue #3703)
by faratell 08 Jan '24

08 Jan '24

Hello to all. I have tried to install VoLTE Setup with Kamailio IMS on Ubuntu 18.04 from https://open5gs.org/open5gs/docs/tutorial/02-VoLTE-setup/ in step 16, Install RTPEngine, dpkg-checkbuilddeps have dependencies: libbcg729-dev, which is not in the repository of ubuntu 18.04 to install. How can install it? dpkg-checkbuilddeps: error: Unmet build dependencies: libbcg729-dev sudo apt install libbcg729-dev Reading package lists... Done Building dependency tree Reading state information... Done E: Unable to locate package libbcg729-dev -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3703 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3703(a)github.com>

2 2

git:master:b3ed254a: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 08 Jan '24

08 Jan '24

Module: kamailio Branch: master Commit: b3ed254a85bd9528342d07c87791ee00f5d70622 URL: https://github.com/kamailio/kamailio/commit/b3ed254a85bd9528342d07c87791ee0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-08T12:31:30+01:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/b3ed254a85bd9528342d07c87791ee0… Patch: https://github.com/kamailio/kamailio/commit/b3ed254a85bd9528342d07c87791ee0… --- diff --git a/src/modules/siputils/README b/src/modules/siputils/README index 7c888199788..5ca3d55ce80 100644 --- a/src/modules/siputils/README +++ b/src/modules/siputils/README @@ -103,7 +103,8 @@ Gabriel Vasile 4.37. contact_param_decode(pname) 4.38. contact_param_decode_uri(pname) 4.39. contact_param_rm(pname) - 4.40. hdr_date_check(tdiff) + 4.40. contact_param_check(pname) + 4.41. hdr_date_check(tdiff) 5. Exported pseudo-variables @@ -163,7 +164,8 @@ Gabriel Vasile 1.46. contact_param_decode usage 1.47. contact_param_decode_ruri usage 1.48. contact_param_rm usage - 1.49. hdr_date_check usage + 1.49. contact_param_check usage + 1.50. hdr_date_check usage Chapter 1. Admin Guide @@ -228,7 +230,8 @@ Chapter 1. Admin Guide 4.37. contact_param_decode(pname) 4.38. contact_param_decode_uri(pname) 4.39. contact_param_rm(pname) - 4.40. hdr_date_check(tdiff) + 4.40. contact_param_check(pname) + 4.41. hdr_date_check(tdiff) 5. Exported pseudo-variables @@ -442,7 +445,8 @@ modparam("siputils", "e164_max_len", 20) 4.37. contact_param_decode(pname) 4.38. contact_param_decode_uri(pname) 4.39. contact_param_rm(pname) - 4.40. hdr_date_check(tdiff) + 4.40. contact_param_check(pname) + 4.41. hdr_date_check(tdiff) 4.1. options_reply() @@ -1129,7 +1133,24 @@ if (is_method("REGISTER") and src_ip == 1.2.3.4) { } ... -4.40. hdr_date_check(tdiff) +4.40. contact_param_check(pname) + + This function returns true (1) if the URI inside the Contact header + contains the parameter with the name 'pname'. Otherwise it returns + false (-1). + + Meaning of the parameters is as follows: + * pname - name of the URI parameter. + + This function can be used from ANY_ROUTE. + + Example 1.49. contact_param_check usage +... +if (contact_param_check("myparam")) { +} +... + +4.41. hdr_date_check(tdiff) Returns true if sip message has Date header and its value is lower than 'NOW() - tdiff'. @@ -1140,7 +1161,7 @@ if (is_method("REGISTER") and src_ip == 1.2.3.4) { This function can be used from ANY_ROUTE. - Example 1.49. hdr_date_check usage + Example 1.50. hdr_date_check usage ... if (!hdr_date_check("10")) { sl_send_reply("403", "Outdated date");

1 0

git:master:257cfe9b: siputils: docs for contact_param_check() function
by Daniel-Constantin Mierla 08 Jan '24

08 Jan '24

Module: kamailio Branch: master Commit: 257cfe9be9327054fb381a48df9605444ea8e6fd URL: https://github.com/kamailio/kamailio/commit/257cfe9be9327054fb381a48df96054… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-08T12:25:32+01:00 siputils: docs for contact_param_check() function --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/257cfe9be9327054fb381a48df96054… Patch: https://github.com/kamailio/kamailio/commit/257cfe9be9327054fb381a48df96054… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index d2197b1c3f4..ad30a1a9f6e 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -1372,6 +1372,35 @@ if (is_method("REGISTER") and src_ip == 1.2.3.4) { contact_param_rm("myparam"); } ... +</programlisting> + </example> + </section> + <section id="siputils.f.contact_param_check"> + <title> + <function moreinfo="none">contact_param_check(pname)</function> + </title> + <para> + This function returns true (1) if the URI inside the Contact + header contains the parameter with the name 'pname'. Otherwise it + returns false (-1). + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para><emphasis>pname</emphasis> - name of the URI parameter. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>contact_param_check</function> usage</title> + <programlisting format="linespecific"> +... +if (contact_param_check("myparam")) { +} +... </programlisting> </example> </section>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev