- sr-dev - kamailio.org

[kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)
by pwakano 16 Jan '24

16 Jan '24

### Description  The dmq_usrloc module is not replicating the extra attributes saved in the xavp for the contact. So remote nodes don't receive these values, being unable to access it properly. It is expected that the attributes are replicated as well. #### Reproduction  Setup two nodes using the dmq_usrloc and usrloc in db_mode=0. When receiving a REGISTER, before saving the contact add some attribute in the xavp_contact. In a subsequent message to this contact (e.g.: INVITE) use a lookup() or registered() and try to access the desired xavp_contact attribute. If the request is received in the local node (which received the original REGISTER), the attribute will be valid, but if the request is received in the remote node, the attribute is empty. #### Log Messages  ``` May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: registrar [save.c:410]: pack_ci(): generated ruid is: uloc-5cee2114-5abe-2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:73]: ucontact_xavp_store(): trying to clone per contact xavps May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:697]: xavp_clone_level_nodata(): cloned root xavp [ulattrs] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:721]: xavp_clone_level_nodata(): cloned inner xavp [cluster_node] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:1701]: update_ucontact(): exists callback for type= UL_CONTACT_UPDATE May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f51b624d418, callback type 2/15, id 1 entered May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:776]: dmq_ul_cb_contact(): Callback from usrloc with type=2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:427]: init_usrloc_dmq_recv(): Initializing usrloc_dmq_recv for pid (23230) May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:785]: dmq_ul_cb_contact(): Replicating local update to other nodes... May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:746]: usrloc_dmq_send_contact(): sending serialized data {"action":1,"aor":"345671002","ruid":"uloc-5cee20df-5953-1","c":"sip:345671002@172.28.128.200:5060;rinstance=38e53fed7e84e081;transport=UDP","received":"","path":"<sip:172.28.128.102:5060;received=sip:172.28.128.200:5060;lr>","callid":"NOeeFh1Bh5JR0eJG8DENkg..","user_agent":"Z 3.15.40006 rv2.8.20","instance":"","expires":1559110577,"cseq":12,"flags":0,"cflags":3072,"q":-1,"last_modified":1559109977,"methods":4294967295,"reg_id":0,"server_id":0} May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:315]: usrloc_dmq_send(): sending dmq broadcast... ``` ### Possible Solutions  Only workaround seems to use usrloc with db_mode=3 and then not use the dmq_usrloc, having the usrloc with attributes info shared via the DB.... ### Additional Information Kamailio 5.2.2 installed from the repo. ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # cat /etc/centos-release CentOS Linux release 7.3.1611 (Core) # uname -a Linux kamailio-2 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968

3 7

git:master:167d8af9: core: snexpr - rename some inner blocks variables
by Daniel-Constantin Mierla 16 Jan '24

16 Jan '24

Module: kamailio Branch: master Commit: 167d8af9ff1c55804a66cc948670ab1d3069e063 URL: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:03:02+01:00 core: snexpr - rename some inner blocks variables --- Modified: src/core/utils/snexpr.h --- Diff: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… Patch: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… --- diff --git a/src/core/utils/snexpr.h b/src/core/utils/snexpr.h index cdfe55c45d8..5b159a256e3 100644 --- a/src/core/utils/snexpr.h +++ b/src/core/utils/snexpr.h @@ -1254,10 +1254,10 @@ extern "C" sne_vec_free(&arg.args); goto cleanup; /* first argument is not a variable */ } - struct snexpr_var *v; - for(v = vars->head; v; v = v->next) { - if(v == u->param.var.vref) { - struct macro m = {v->name, arg.args}; + struct snexpr_var *v1; + for(v1 = vars->head; v1; v1 = v1->next) { + if(v1 == u->param.var.vref) { + struct macro m = {v1->name, arg.args}; sne_vec_push(&macros, m); break; } @@ -1284,9 +1284,9 @@ extern "C" char varname[14]; snprintf(varname, sizeof(varname) - 1, "$%d", (j + 1)); - struct snexpr_var *v = snexpr_var_find( + struct snexpr_var *v1 = snexpr_var_find( vars, varname, strlen(varname)); - struct snexpr ev = snexpr_varref(v); + struct snexpr ev = snexpr_varref(v1); struct snexpr assign = snexpr_binary(SNE_OP_ASSIGN, ev, sne_vec_nth(&arg.args, j)); @@ -1409,10 +1409,10 @@ extern "C" cleanup: sne_vec_foreach(&macros, m, i) { - struct snexpr e; - sne_vec_foreach(&m.body, e, j) + struct snexpr e1; + sne_vec_foreach(&m.body, e1, j) { - snexpr_destroy_args(&e); + snexpr_destroy_args(&e1); } sne_vec_free(&m.body); }

1 0

git:master:6ebe3b61: ss7ops: rename local variable that hides the function parameter
by Daniel-Constantin Mierla 16 Jan '24

16 Jan '24

Module: kamailio Branch: master Commit: 6ebe3b612d60e02854c7b88cd241615b50666b00 URL: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:03:02+01:00 ss7ops: rename local variable that hides the function parameter --- Modified: src/modules/ss7ops/isup_parsed.c --- Diff: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… Patch: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… --- diff --git a/src/modules/ss7ops/isup_parsed.c b/src/modules/ss7ops/isup_parsed.c index 5ebc2d7f348..75a132435f8 100644 --- a/src/modules/ss7ops/isup_parsed.c +++ b/src/modules/ss7ops/isup_parsed.c @@ -1067,7 +1067,7 @@ static int do_parse( while(opt_left > 0) { uint8_t ie = opt_data[0]; - size_t len; + size_t len1; opt_data += 1; opt_left -= 1; @@ -1078,20 +1078,20 @@ static int do_parse( LM_ERR("ISUP no space for len %zu\n", opt_left); return -1; } - len = opt_data[0]; + len1 = opt_data[0]; opt_left -= 1; opt_data += 1; - if(opt_left < len) { + if(opt_left < len1) { LM_ERR("ISUP no space optional data %zu vs. %zu\n", opt_left, - len); + len1); return -1; } - visitor(ie, opt_data, len, ptr); + visitor(ie, opt_data, len1, ptr); - opt_data += len; - opt_left -= len; + opt_data += len1; + opt_left -= len1; } }

1 0

auto build failure
by Henning Westerholt 16 Jan '24

16 Jan '24

Hello, the kamailio auto build is failing, I noticed after my last commit. But it seems to be related to some docker issue: [...] Starting job container /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 login ghcr.io -u henningw --password-stdin /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Warning: Docker pull failed with exit code 1, back off 1.515 seconds before retry. /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Warning: Docker pull failed with exit code 1, back off 1.58 seconds before retry. /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Error: Docker pull failed with exit code 1 Is this an issue from the github infrastructure or some issue in our scripts? Cheers, Henning

2 2

git:5.7:d411c6ea: dialog: don't send the BYE if dialog is in deleted state (#3714)
by Federico Cabiddu 16 Jan '24

16 Jan '24

Module: kamailio Branch: 5.7 Commit: d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f URL: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2024-01-16T09:51:14+01:00 dialog: don't send the BYE if dialog is in deleted state (#3714) (cherry picked from commit 695f155f3a127f0bbe220a6b44a0fc3887e1e4be) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… Patch: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index aab22da3c64..fb5f2e51e32 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -383,6 +383,14 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) dlg_iuid_t *iuid = NULL; str lhdrs; + /* dialog is already in deleted state, nothing to do */ + if(cell->state == DLG_STATE_DELETED) { + LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " + "not sent.\n", + cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); + return 0; + } + /* Send Cancel or final response for non-confirmed dialogs */ if(cell->state != DLG_STATE_CONFIRMED_NA && cell->state != DLG_STATE_CONFIRMED) {

1 0

[kamailio/kamailio] dialog: don't send the BYE if dialog is in deleted state (PR #3714)
by Federico Cabiddu 16 Jan '24

16 Jan '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We've recently been exeperiencing a core dump in dialog module. The core dump was caused by trying to terminate via rpc command a dialog that had just been terminated by one of the parties sending a BYE. That's because send_bye threats a deleted dialog as a non confimed one (https://github.com/kamailio/kamailio/blob/404b47791678c4eaccd4cfc7a83e0bb97…) and tries then to access a transaction that does not exist anymore (https://github.com/kamailio/kamailio/blob/404b47791678c4eaccd4cfc7a83e0bb97…) and crashes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3714 -- Commit Summary -- * dialog: don't send the BYE if dialog is in deleted state -- File Changes -- M src/modules/dialog/dlg_req_within.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3714.patch https://github.com/kamailio/kamailio/pull/3714.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3714 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3714(a)github.com>

2 2

git:master:695f155f: dialog: don't send the BYE if dialog is in deleted state (#3714)
by GitHub 16 Jan '24

16 Jan '24

Module: kamailio Branch: master Commit: 695f155f3a127f0bbe220a6b44a0fc3887e1e4be URL: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-01-16T09:42:27+01:00 dialog: don't send the BYE if dialog is in deleted state (#3714) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3… Patch: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index aab22da3c64..fb5f2e51e32 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -383,6 +383,14 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) dlg_iuid_t *iuid = NULL; str lhdrs; + /* dialog is already in deleted state, nothing to do */ + if(cell->state == DLG_STATE_DELETED) { + LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " + "not sent.\n", + cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); + return 0; + } + /* Send Cancel or final response for non-confirmed dialogs */ if(cell->state != DLG_STATE_CONFIRMED_NA && cell->state != DLG_STATE_CONFIRMED) {

1 0

git:5.7:b6796b11: tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule
by S-P Chan 16 Jan '24

16 Jan '24

Module: kamailio Branch: 5.7 Commit: b6796b110adbe4dec7ac1acb1d7d70bdc58bf1c2 URL: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70b… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-16T16:37:47+08:00 tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70b… Patch: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70b… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 730076023a9..5ef95d697b6 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -30,7 +30,7 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: --prefix=$(CURDIR)/$(WOLFSSL_PREFIX) \ --exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX); \ fi; - @$(MAKE) -C $(WOLFSSL_SRC) prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install + @$(MAKE) -C $(WOLFSSL_SRC) DESTDIR= prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install $(NAME): $(WOLFSSL_PREFIX)/lib/libwolfssl.a

1 0

git:master:7e5843e2: tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule
by S-P Chan 16 Jan '24

16 Jan '24

Module: kamailio Branch: master Commit: 7e5843e28dc4e331f434381defeb4cef43c5298f URL: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4ce… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-16T16:36:57+08:00 tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4ce… Patch: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4ce… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 1a6254ea7b2..dda5ad4779e 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -37,7 +37,7 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: --prefix=$(CURDIR)/$(WOLFSSL_PREFIX) \ --exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX); \ fi; - @$(MAKE) -C $(WOLFSSL_SRC) prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install + @$(MAKE) -C $(WOLFSSL_SRC) DESTDIR= prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install $(NAME): $(WOLFSSL_PREFIX)/lib/libwolfssl.a

1 0

git:master:4df93942: github: add default registry credentials [skip ci]
by Victor Seva 16 Jan '24

16 Jan '24

Module: kamailio Branch: master Commit: 4df939428555f8c4fde67f7b8638809aca56c9f2 URL: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-16T09:34:38+01:00 github: add default registry credentials [skip ci] > https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-gith… --- Modified: .github/workflows/main.yml Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809… Patch: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809… --- diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8f1d028cda8..86b05df1822 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,6 +13,9 @@ jobs: contents: read # to fetch code (actions/checkout) container: image: ghcr.io/kamailio/pkg-kamailio-docker:${{ github.ref_name }}-${{ matrix.distribution }} + credentials: + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} volumes: - ${{ github.workspace }}:/code env: diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index a2fc539ddfc..cda04d04389 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -22,6 +22,9 @@ jobs: contents: read # to fetch code (actions/checkout) container: image: ghcr.io/kamailio/pkg-kamailio-docker:master-${{ matrix.distribution }} + credentials: + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} volumes: - ${{ github.workspace }}:/code env:

1 0

git:5.7:d5ebc271: tls_wolfssl: update to v5.6.6-stable
by S-P Chan 16 Jan '24

16 Jan '24

Module: kamailio Branch: 5.7 Commit: d5ebc2716992c2480c604555511511ce043bead7 URL: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c604555511511c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-16T16:13:55+08:00 tls_wolfssl: update to v5.6.6-stable --- Modified: misc/external/wolfssl/wolfssl --- Diff: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c604555511511c… Patch: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c604555511511c… --- diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl index 3b3c175af0e..66596ad9e1d 160000 --- a/misc/external/wolfssl/wolfssl +++ b/misc/external/wolfssl/wolfssl @@ -1 +1 @@ -Subproject commit 3b3c175af0e993ffaae251871421e206cc41963f +Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e

1 0

[kamailio/kamailio] ims_usrloc_pcscf: udomain.c get_pcontact_from_cache() name check blocks SIP SUBSCRIBE for some UE's (Issue #3646)
by jbipre2 16 Jan '24

16 Jan '24

### Description We have various commercial UE's connecting over an Amarisoft Callbox Classic eNB with Open5GS core network. This issue concerns different UE behaviour. Name checking code introduced between Kamailio v5.6.4 and v5.7.1 (udomain.c lines 580 to 599) leads to rejection of the SUBSCRIBE request from a Huawei UE (user-agent: IM-client/OMA1.0 HW-Rto/V1.0). SUBSCRIBE requests from a OnePlus UE (user-agent: OnePlus_KB2003_RPIA.201005.001) are accepted. We assume that the behaviour of the commercial-off-the-shelf UE's complies with the 3GPP standards; but we do not know to what extent. The following code, however, caused our Huawei UE's to lose VoLTE capability, after updating the Kamailio IMS from v5.6.4 to v5.7.1. ``` 580 if ((contact_info->aor.len>0) && (needle_uri.user.len != 0)){ 581 if ((needle_uri.user.len != c->contact_user.len) || 582 (memcmp(needle_uri.user.s, c->contact_user.s, needle_uri.user.len) != 0)) { 583 LM_ERR("user name does not match - no match here...\n"); 584 LM_DBG("found pcontact username [%d]: [%.*s]\n", i, c->contact_user.len, c->contact_user.s); 585 LM_DBG("incoming contact username: [%.*s]\n", needle_uri.user.len, needle_uri.user.s); 586 c = c->next; 587 continue; 588 } 589 if ((contact_info->aor.len >= 4) && (memcmp(contact_info->aor.s, c->aor.s, 4) != 0)) { // do not mix up sip- and tel-URIs. 590 LM_ERR("scheme does not match - no match here...\n"); 591 LM_DBG("found pcontact scheme [%d]: [%.*s]\n", i, 4, c->aor.s); 592 LM_DBG("incoming contact scheme: [%.*s]\n", 4, contact_info->aor.s); 593 c = c->next; 594 continue; 595 } 596 } 597 else{ 598 LM_DBG("No user name present - abort user name check\n"); 599 } ``` The above code also does not consider the reverse_search flag (uses c=c->next instead of c = reverse_search? c->prev : c->next), so if reverse_search is set, the code's behaviour may be incorrect. In the following pcap file, the Huawei's SIP REGISTER process starts at packet 2, 200 OK arriving in packet 41, with the P-Associated-URI <sip:51194@ims.mnc001.mcc001.3gppnetwork.org>. This UE sends SUBSCRIBE (packet 47) incorporating a new Contact: <sip:51194@10.46.0.6:31896>, presumably derived from the P-Associated-URI; but receives "403 Forbidden - You must register first with a S-CSCF". The Oneplus sends SIP REGISTER at packet 56, receiving 200 OK at packet 83 with P-Associated-URI <sip:51196@ims.mnc001.mcc001.3gppnetwork.org>. But this UE's SUBSCRIBE (packet 84) incorporates the same Contact used in the REGISTER request: <sip:c57d4262-e59d-4530-a0f4-b4faaa2fb1c6@10.46.0.8:5060>, and 200 OK arrives at packet 92. [v571-pcscf-name-check-fail.zip](https://github.com/kamailio/kamailio/files/… #### Debugging Data None acquired #### Log Messages  NB: log messages acquired prior to above pcap. The following extract shows failed name check (udomain.c lines 580 - 599) for username 51194, while 001010000051194 was registered: ``` Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_registrar_pcscf [service_routes.c:210]: getContactP(): This is a request - using first via to find contact Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_registrar_pcscf [service_routes.c:218]: getContactP(): searching for contact with host:port:proto contact [1://10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:459]: get_pcontact_from_cache(): Searching for contact with AOR [sip:51194@10.46.0.6:31894] in P-CSCF usrloc based on VIA [1://10.46.0.6:31894] Received [1://10.46.0.6:31409], Search flag is 0, reverse_search 0 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:469]: get_pcontact_from_cache(): Have an AOR to search for Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:474]: get_pcontact_from_cache(): checking for rinstance Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [usrloc.c:157]: get_aor_hash(): Returning hash: [1746035570] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:509]: get_pcontact_from_cache(): get_pcontact slot is [370] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:513]: get_pcontact_from_cache(): comparing contact with aorhash [1746035570], aor [sip:001010000051194@10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:514]: get_pcontact_from_cache(): contact host [10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:515]: get_pcontact_from_cache(): contact received [2:10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:522]: get_pcontact_from_cache(): mached a record by aorhash: 1746035570 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:513]: get_pcontact_from_cache(): comparing contact with aorhash [1746035570], aor [sip:001010000051194@10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:514]: get_pcontact_from_cache(): contact host [10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:515]: get_pcontact_from_cache(): contact received [2:10.46.0.6:31409] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:522]: get_pcontact_from_cache(): mached a record by aorhash: 1746035570 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:541]: get_pcontact_from_cache(): matched contact ip address and port Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:569]: get_pcontact_from_cache(): found contact with URI [sip:001010000051194@10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: ERROR: ims_usrloc_pcscf [udomain.c:583]: get_pcontact_from_cache(): user name does not match - no match here... Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:584]: get_pcontact_from_cache(): found pcontact username [1]: [001010000051194] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:585]: get_pcontact_from_cache(): incoming contact username: [51194] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:643]: get_pcontact_from_cache(): contact not found in memory Jul 18 12:15:31 corsa03 p-cscf[58090]: INFO: ims_registrar_pcscf [service_routes.c:277]: getContactP(): Contact not found based on Contact-header, trying IP/Port/Proto Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:459]: get_pcontact_from_cache(): Searching for contact with AOR [sip:51194@10.46.0.6:31894] in P-CSCF usrloc based on VIA [1://10.46.0.6:31894] Received [1://10.46.0.6:31409], Search flag is 1, reverse_search 0 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:469]: get_pcontact_from_cache(): Have an AOR to search for Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:474]: get_pcontact_from_cache(): checking for rinstance Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [usrloc.c:157]: get_aor_hash(): Returning hash: [1746035570] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:509]: get_pcontact_from_cache(): get_pcontact slot is [370] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:513]: get_pcontact_from_cache(): comparing contact with aorhash [1746035570], aor [sip:001010000051194@10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:514]: get_pcontact_from_cache(): contact host [10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:515]: get_pcontact_from_cache(): contact received [2:10.46.0.6:5060] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:522]: get_pcontact_from_cache(): mached a record by aorhash: 1746035570 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:546]: get_pcontact_from_cache(): continuing to match on received details Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:513]: get_pcontact_from_cache(): comparing contact with aorhash [1746035570], aor [sip:001010000051194@10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:514]: get_pcontact_from_cache(): contact host [10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:515]: get_pcontact_from_cache(): contact received [2:10.46.0.6:31409] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:522]: get_pcontact_from_cache(): mached a record by aorhash: 1746035570 Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:546]: get_pcontact_from_cache(): continuing to match on received details Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:569]: get_pcontact_from_cache(): found contact with URI [sip:001010000051194@10.46.0.6:31894] Jul 18 12:15:31 corsa03 p-cscf[58090]: ERROR: ims_usrloc_pcscf [udomain.c:583]: get_pcontact_from_cache(): user name does not match - no match here... Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:584]: get_pcontact_from_cache(): found pcontact username [1]: [001010000051194] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:585]: get_pcontact_from_cache(): incoming contact username: [51194] Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_usrloc_pcscf [udomain.c:643]: get_pcontact_from_cache(): contact not found in memory Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_registrar_pcscf [service_routes.c:282]: getContactP(): No entry in usrloc for 10.46.0.6:31409 (Proto 1) found! Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: ims_registrar_pcscf [service_routes.c:319]: getContactP(): Asserted identity not set Jul 18 12:15:31 corsa03 p-cscf[58090]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[MO] c=[/etc/kamailio/pcscf/route/mo.cfg] l=16 a=26 n=send_reply Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: sl [sl.c:310]: send_reply(): reply in stateless mode (sl) Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: <core> [core/receive.c:126]: sip_check_fline(): first line indicates a SIP reply Jul 18 12:15:31 corsa03 p-cscf[58090]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[MO] c=[/etc/kamailio/pcscf/route/mo.cfg] l=17 a=2 n=exit Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: <core> [core/receive.c:528]: receive_msg(): request-route executed in: 4219 usec Jul 18 12:15:31 corsa03 p-cscf[58090]: DEBUG: <core> [core/usr_avp.c:637]: destroy_avp_list(): destroying list 0x7f043587bfc0 ``` ### Possible Solutions Commenting out udomain.c lines 580-599 allowed both UE's to complete their SUBSCRIBE's, and make VoLTE calls. In the following pcap, the Oneplus REGISTER's and SUBSCRIBE's over packets 1 to 37; the Huawei process occurs from packets 45 to 98. [v571-pcscf-name-check-skipped.zip](https://github.com/kamailio/kamailio/fil… ### Additional Information ``` version: kamailio 5.7.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown ``` * **Operating System**:  ``` Linux corsa03 6.5.?-gentoo-x86_64 #2 SMP PREEMPT_DYNAMIC <not recorded> CEST 2023 x86_64 AMD EPYC 7513 32-Core Processor AuthenticAMD GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3646 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3646(a)github.com>

2 2

[kamailio/kamailio] tls: (historical) root cause analysis of per-worker SSL_CTX during OpenSSL 1.1.1 integration (Issue #3709)
by space88man 16 Jan '24

16 Jan '24

### Description During OpenSSL 1.1.1 integration it was necessary to use per-worker SSL_CTX —instantiated in `tls/tls_mod.c`. This is still required for OpenSSL 3.x integration. This is a retrospective root cause analysis of why this duplicated SSL_CTX is needed. #### Reproduction 1. Instead of creating repeating SSL_CTX (one-per-worker) have all workers use a single SSL_CTX 2. Observation: intermittent connection failures 3. Observation: if `tls` is using only EC keys, the connections will succeed #### Root Cause Analysis OpenSSL RSA BN operations are multi-threaded ready (can be used in single-process multi-threaded applications). However the BN operations depend crucially on each thread reporting different `pthread_self()` values. At runtime `pthread_self()` values can be reused and are only different for all running threads in a single process. When rank 0 forks the worker processes their `pthread_self()` values will overlap. This will result in invalid BN computations and lead to failure of RSA connections. In a sense the workers perform “identify theft”. There is no mechanism in pthreads to reset the thread ids; they are opaque handles. In contrast, OpenSSL ECDSA operations do not invoke `pthread_self()` and do not require unique thread IDs. Notes - no action is required; this is purely a historical note - I have added a code comment: https://github.com/kamailio/kamailio/commit/29007ada5bc9e07ede3cdbce285f04d… - I will leave this issue up for a few days knowledge sharing -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3709 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3709(a)github.com>

2 3

[kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
by Xenofon Karamanos 15 Jan '24

15 Jan '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR fixes the issue in https://github.com/kamailio/kamailio/issues/1968. Any feedback is welcome. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3679 -- Commit Summary -- * dmq_usrloc: Transfer attributes * usrloc: Modify destroy order and contact xavp -- File Changes -- M src/modules/dmq_usrloc/usrloc_sync.c (132) M src/modules/usrloc/ucontact.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3679.patch https://github.com/kamailio/kamailio/pull/3679.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3679(a)github.com>

3 14

git:master:404b4779: usrloc: synchronize attributes from DMQ (GH #3679)
by Henning Westerholt 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: 404b47791678c4eaccd4cfc7a83e0bb97a29b5d3 URL: https://github.com/kamailio/kamailio/commit/404b47791678c4eaccd4cfc7a83e0bb… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-15T17:22:06Z usrloc: synchronize attributes from DMQ (GH #3679) - make ucontact_xavp_store static and add some comments - change order of xavp operations in ucontact_xavp_store to not overwrite DMQ xavp - add logic to receive xavp information from DMQ and save it in the contact --- Modified: src/modules/usrloc/ucontact.c --- Diff: https://github.com/kamailio/kamailio/commit/404b47791678c4eaccd4cfc7a83e0bb… Patch: https://github.com/kamailio/kamailio/commit/404b47791678c4eaccd4cfc7a83e0bb… --- diff --git a/src/modules/usrloc/ucontact.c b/src/modules/usrloc/ucontact.c index fbb16e4b88d..f95fe987d75 100644 --- a/src/modules/usrloc/ucontact.c +++ b/src/modules/usrloc/ucontact.c @@ -50,10 +50,10 @@ void ul_set_xavp_contact_clone(int v) } /*! - * \brief Store xavp list per contact + * \brief Store xavp list per contact from core, update existing contact as well * \param _c contact structure */ -void ucontact_xavp_store(ucontact_t *_c) +static void ucontact_xavp_store(ucontact_t *_c) { sr_xavp_t *xavp; if(_c == NULL) @@ -62,12 +62,15 @@ void ucontact_xavp_store(ucontact_t *_c) return; if(ul_xavp_contact_name.s == NULL) return; - /* remove old list if it is set -- update case */ - if(_c->xavp) - xavp_destroy_list(&_c->xavp); + /* XAVP from core */ xavp = xavp_get(&ul_xavp_contact_name, NULL); - if(xavp == NULL) + if(xavp == NULL) { return; + } + /* remove old xavp if it is set -- update case */ + if(_c->xavp) { + xavp_destroy_list(&_c->xavp); + } /* clone the xavp found in core */ LM_DBG("trying to clone per contact xavps\n"); _c->xavp = xavp_clone_level_nodata(xavp); @@ -124,6 +127,15 @@ ucontact_t *new_ucontact( if(shm_str_dup(&c->instance, &_ci->instance) < 0) goto error; } + /* we got a xavp from e.g. DMQ */ + if(_ci->xavp) { + /* destroy the existing contact xavp */ + if(c->xavp) { + xavp_destroy_list(&c->xavp); + } + /* clone the DMQ xavp because it will be destroyed */ + c->xavp = xavp_clone_level_nodata(_ci->xavp); + } c->domain = _dom; c->aor = _aor; @@ -141,6 +153,8 @@ ucontact_t *new_ucontact( c->tcpconn_id = _ci->tcpconn_id; c->server_id = _ci->server_id; c->keepalive = (_ci->cflags & ul_nat_bflag) ? 1 : 0; + + /* Use core xavp if set, otherwise does nothing */ ucontact_xavp_store(c); @@ -317,6 +331,16 @@ int mem_update_ucontact(ucontact_t *_c, ucontact_info_t *_ci) _c->path.len = 0; } + /* we got a xavp from e.g. DMQ */ + if(_ci->xavp) { + /* destroy the existing contact xavp */ + if(_c->xavp) { + xavp_destroy_list(&_c->xavp); + } + /* clone the DMQ xavp because it will be destroyed */ + _c->xavp = xavp_clone_level_nodata(_ci->xavp); + } + /* Use core xavp if set, otherwise does nothing */ ucontact_xavp_store(_c); _c->sock = _ci->sock;

1 0

git:master:d2eb6a9f: dmq_usrloc: DMQ also copies and sends attributes related to contacts (GH #3679)
by Henning Westerholt 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: d2eb6a9f324a2077d0f4422621aa4d125c72c880 URL: https://github.com/kamailio/kamailio/commit/d2eb6a9f324a2077d0f4422621aa4d1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-15T17:21:39Z dmq_usrloc: DMQ also copies and sends attributes related to contacts (GH #3679) --- Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/d2eb6a9f324a2077d0f4422621aa4d1… Patch: https://github.com/kamailio/kamailio/commit/d2eb6a9f324a2077d0f4422621aa4d1…

1 0

git:master:aa67092e: github: fix cleanup matrix definition [skip ci]
by Victor Seva 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: aa67092e6ea7d8581e11970993607511771c1be6 URL: https://github.com/kamailio/kamailio/commit/aa67092e6ea7d8581e1197099360751… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-15T15:23:55+01:00 github: fix cleanup matrix definition [skip ci] --- Modified: .github/workflows/cleanup.yml --- Diff: https://github.com/kamailio/kamailio/commit/aa67092e6ea7d8581e1197099360751… Patch: https://github.com/kamailio/kamailio/commit/aa67092e6ea7d8581e1197099360751… --- diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml index 6488a7b4bcd..47818602368 100644 --- a/.github/workflows/cleanup.yml +++ b/.github/workflows/cleanup.yml @@ -12,12 +12,11 @@ jobs: packages: write strategy: matrix: - include: - image_name: - - kamailio - - kamailio-ci - - kamailio-master-devcontainer - - pkg-kamailio-docker + image_name: + - kamailio + - kamailio-ci + - kamailio-master-devcontainer + - pkg-kamailio-docker steps: - name: Delete untagged images uses: camargo/delete-untagged-action@v1

1 0

[kamailio/kamailio] Run failed at startup: cleanup packages - master (f3b4f2f)
by kamailio-sync 15 Jan '24

15 Jan '24

[kamailio/kamailio] cleanup packages workflow run Repository: kamailio/kamailio Workflow: cleanup packages Duration: 1.0 second Finished: 2024-01-15 14:22:19 UTC View results: https://github.com/kamailio/kamailio/actions/runs/7530184334 Jobs: -- You are receiving this because you are subscribed to this thread. Manage your GitHub Actions notifications: https://github.com/settings/notifications

1 0

git:master:f3b4f2fe: github: add all packages images to cleanup
by Victor Seva 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: f3b4f2fe2b88a06cdc49ba473e4b3fc3fbbfd8bf URL: https://github.com/kamailio/kamailio/commit/f3b4f2fe2b88a06cdc49ba473e4b3fc… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-15T15:21:06+01:00 github: add all packages images to cleanup --- Modified: .github/workflows/cleanup.yml --- Diff: https://github.com/kamailio/kamailio/commit/f3b4f2fe2b88a06cdc49ba473e4b3fc… Patch: https://github.com/kamailio/kamailio/commit/f3b4f2fe2b88a06cdc49ba473e4b3fc… --- diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml index 37d8e9fe2e5..6488a7b4bcd 100644 --- a/.github/workflows/cleanup.yml +++ b/.github/workflows/cleanup.yml @@ -5,18 +5,22 @@ on: - cron: '0 5 * * *' # Allows you to run this workflow manually from the Actions tab workflow_dispatch: - -env: - IMAGE_NAME: kamailio-ci - jobs: x86_64: runs-on: ubuntu-latest permissions: packages: write + strategy: + matrix: + include: + image_name: + - kamailio + - kamailio-ci + - kamailio-master-devcontainer + - pkg-kamailio-docker steps: - name: Delete untagged images uses: camargo/delete-untagged-action@v1 with: github-token: ${{ secrets.CLEAN_PACKAGES }} - package-name: ${{ env.IMAGE_NAME }} + package-name: ${{ matrix.image_name }}

1 0

git:master:cb520baa: github: use CLEAN_PACKAGES secret at cleanup workflow
by Victor Seva 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: cb520baa9349f86fc104e2c1eed633ea59157b1b URL: https://github.com/kamailio/kamailio/commit/cb520baa9349f86fc104e2c1eed633e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-15T15:03:15+01:00 github: use CLEAN_PACKAGES secret at cleanup workflow kamailio-sync PAT with delete:packages permissions as described > https://github.com/camargo/delete-untagged-action --- Modified: .github/workflows/cleanup.yml --- Diff: https://github.com/kamailio/kamailio/commit/cb520baa9349f86fc104e2c1eed633e… Patch: https://github.com/kamailio/kamailio/commit/cb520baa9349f86fc104e2c1eed633e… --- diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml index bea47fa30dc..37d8e9fe2e5 100644 --- a/.github/workflows/cleanup.yml +++ b/.github/workflows/cleanup.yml @@ -18,5 +18,5 @@ jobs: - name: Delete untagged images uses: camargo/delete-untagged-action@v1 with: - github-token: ${{ secrets.GITHUB_TOKEN }} + github-token: ${{ secrets.CLEAN_PACKAGES }} package-name: ${{ env.IMAGE_NAME }}

1 0

git:5.7:44915522: outbound: update to OpenSSL 3 API
by S-P Chan 15 Jan '24

15 Jan '24

Module: kamailio Branch: 5.7 Commit: 449155221586294d716e760fbabbd4e101ad1be2 URL: https://github.com/kamailio/kamailio/commit/449155221586294d716e760fbabbd4e… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-15T21:34:46+08:00 outbound: update to OpenSSL 3 API (cherry-pick from fe5c7125c66e37d2db032a63328ad713738a4b0c) --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/449155221586294d716e760fbabbd4e… Patch: https://github.com/kamailio/kamailio/commit/449155221586294d716e760fbabbd4e… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index 32f10f6cdb9..e2e3a86a73b 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -79,8 +79,13 @@ static void *mod_init_openssl(void *arg) { if(flow_token_secret.s) { assert(ob_key.len == SHA_DIGEST_LENGTH); LM_DBG("flow_token_secret mod param set. use persistent ob_key"); +#if OPENSSL_VERSION_NUMBER < 0x030000000L SHA1((const unsigned char *)flow_token_secret.s, flow_token_secret.len, (unsigned char *)ob_key.s); +#else + EVP_Q_digest(NULL, "SHA1", NULL, flow_token_secret.s, + flow_token_secret.len, (unsigned char *)ob_key.s, NULL); +#endif } else { if(RAND_bytes((unsigned char *)ob_key.s, ob_key.len) == 0) { LM_ERR("unable to get %d cryptographically strong pseudo-"

1 0

git:master:fe5c7125: outbound: update to OpenSSL 3 API
by S-P Chan 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: fe5c7125c66e37d2db032a63328ad713738a4b0c URL: https://github.com/kamailio/kamailio/commit/fe5c7125c66e37d2db032a63328ad71… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-15T21:32:53+08:00 outbound: update to OpenSSL 3 API --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fe5c7125c66e37d2db032a63328ad71… Patch: https://github.com/kamailio/kamailio/commit/fe5c7125c66e37d2db032a63328ad71… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index 32f10f6cdb9..e2e3a86a73b 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -79,8 +79,13 @@ static void *mod_init_openssl(void *arg) { if(flow_token_secret.s) { assert(ob_key.len == SHA_DIGEST_LENGTH); LM_DBG("flow_token_secret mod param set. use persistent ob_key"); +#if OPENSSL_VERSION_NUMBER < 0x030000000L SHA1((const unsigned char *)flow_token_secret.s, flow_token_secret.len, (unsigned char *)ob_key.s); +#else + EVP_Q_digest(NULL, "SHA1", NULL, flow_token_secret.s, + flow_token_secret.len, (unsigned char *)ob_key.s, NULL); +#endif } else { if(RAND_bytes((unsigned char *)ob_key.s, ob_key.len) == 0) { LM_ERR("unable to get %d cryptographically strong pseudo-"

1 0

git:master:47303fc3: Makefile.defs: remove unused define WITH_XAVP, its not used anymore from the code
by Henning Westerholt 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: 47303fc34d4795edc7b58569fb97e7b0532b0367 URL: https://github.com/kamailio/kamailio/commit/47303fc34d4795edc7b58569fb97e7b… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-15T12:07:16Z Makefile.defs: remove unused define WITH_XAVP, its not used anymore from the code --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/47303fc34d4795edc7b58569fb97e7b… Patch: https://github.com/kamailio/kamailio/commit/47303fc34d4795edc7b58569fb97e7b… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 7a4b7418670..b088bcfffe2 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -727,7 +727,6 @@ C_DEFS+= -DSHM_MMAP \ -DUSE_DNS_FAILOVER \ -DUSE_DST_BLOCKLIST \ -DUSE_NAPTR \ - -DWITH_XAVP \ #-DUSE_DNS_CACHE_STATS \ #-DUSE_DST_BLOCKLIST_STATS \ #-DDNS_WATCHDOG_SUPPORT \

1 0

git:master:555530c7: doc/tutorial: remove unused define WITH_XAVP, its not used anymore from the code
by Henning Westerholt 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: 555530c70f8f7034046e0b81f4a8469ed76bb405 URL: https://github.com/kamailio/kamailio/commit/555530c70f8f7034046e0b81f4a8469… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-15T12:06:54Z doc/tutorial: remove unused define WITH_XAVP, its not used anymore from the code --- Modified: doc/tutorials/cfg_list/Makefile Modified: doc/tutorials/counter_list/Makefile Modified: doc/tutorials/rpc_list/Makefile Modified: doc/tutorials/select_list/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/555530c70f8f7034046e0b81f4a8469… Patch: https://github.com/kamailio/kamailio/commit/555530c70f8f7034046e0b81f4a8469… --- diff --git a/doc/tutorials/cfg_list/Makefile b/doc/tutorials/cfg_list/Makefile index cda24264d1c..66aa377d50d 100644 --- a/doc/tutorials/cfg_list/Makefile +++ b/doc/tutorials/cfg_list/Makefile @@ -72,7 +72,7 @@ c_defs=-DNAME='\"kamailio\"' -DVERSION='\"5.1.0-dev3\"' -DARCH='\"x86_64\"' \ -DRUN_DIR='\"/run/kamailio/\"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP \ -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES \ -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR \ - -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ + -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS \ -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT \ -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 \ diff --git a/doc/tutorials/counter_list/Makefile b/doc/tutorials/counter_list/Makefile index 0ef48b23602..7cef0f72103 100644 --- a/doc/tutorials/counter_list/Makefile +++ b/doc/tutorials/counter_list/Makefile @@ -66,7 +66,7 @@ c_defs=-DNAME='\"kamailio\"' -DVERSION='\"5.1.0-dev3\"' -DARCH='\"x86_64\"' \ -DRUN_DIR='\"/run/kamailio/\"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP \ -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES \ -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR \ - -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ + -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS \ -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT \ -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 \ diff --git a/doc/tutorials/rpc_list/Makefile b/doc/tutorials/rpc_list/Makefile index ac838ef7dcd..c620793f858 100644 --- a/doc/tutorials/rpc_list/Makefile +++ b/doc/tutorials/rpc_list/Makefile @@ -139,7 +139,7 @@ c_defsX=-DNAME='\"kamailio\"' -DVERSION='\"5.1.0-dev3\"' -DARCH='\"x86_64\"' \ -DRUN_DIR='\"/run/kamailio/\"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP \ -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES \ -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR \ - -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ + -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS \ -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT \ -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 \ diff --git a/doc/tutorials/select_list/Makefile b/doc/tutorials/select_list/Makefile index 50be57d3a8a..5f3a3282291 100644 --- a/doc/tutorials/select_list/Makefile +++ b/doc/tutorials/select_list/Makefile @@ -68,7 +68,7 @@ c_defs=-DNAME='\"kamailio\"' -DVERSION='\"5.1.0-dev3\"' -DARCH='\"x86_64\"' \ -DRUN_DIR='\"/run/kamailio/\"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP \ -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES \ -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR \ - -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ + -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC \ -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS \ -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT \ -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 \

1 0

git:master:6f962070: docs/scripts: remove unused define WITH_XAVP, its not used anymore from the code
by Henning Westerholt 15 Jan '24

15 Jan '24

Module: kamailio Branch: master Commit: 6f9620704c661151415ad723e5f0b31f34b70c1d URL: https://github.com/kamailio/kamailio/commit/6f9620704c661151415ad723e5f0b31… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-01-15T12:06:25Z docs/scripts: remove unused define WITH_XAVP, its not used anymore from the code --- Modified: doc/scripts/cdefs2doc/dump_cfg_defs.pl Modified: doc/scripts/cdefs2doc/dump_counters.pl Modified: doc/scripts/cdefs2doc/dump_rpcs.pl Modified: doc/scripts/cdefs2doc/dump_selects.pl --- Diff: https://github.com/kamailio/kamailio/commit/6f9620704c661151415ad723e5f0b31… Patch: https://github.com/kamailio/kamailio/commit/6f9620704c661151415ad723e5f0b31…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev