Hii,I am trying to use pstn_route module for the first time, and i want to route the invite to specific pstn server based on its prefix.I have loaded the module & setup the DB, and it's giving error saying route name (from DB) is not defined after adding the a prefix into DB table., and there were no errors when DB table is empty.Not sure how to defined it, or i dont know what did i miss. Please help.
#### CONFIG ##########loadmodule "prefix_route.so"modparam("prefix_route", "db_url", "…
[View More]mysql://xxxxx:xxxxx@localhost/kamailioDB")modparam("prefix_route", "db_table", "new_prefix_route")
#PSTN Routing table contains if (!prefix_route("+44")) { xlog("L_INFO", "+44 prefix didnt match with prefix_route DB\n"); }
########## DB####MariaDB [kamailio]> select * from new_prefix_route;Empty set (0.00 sec)
MariaDB [kamailio]> exit;##########
Kamailio looks good untill here, no errors..
# Now i have added a prefix into sql DBINSERT INTO new_prefix_route VALUES ("+44", "10.10.1.1:5060", "route for this prefix");###########Error log after adding a prefix into new_prefix_route table & restart of kamailio
0(5802) CRITICAL: prefix_route [prefix_route.c:72]: add_route(): route name '10.10.1.1:5060' is not defined 0(5802) NOTICE: prefix_route [prefix_route.c:170]: pr_db_load(): Total prefix routes loaded: 1 0(5802) ERROR: prefix_route [prefix_route.c:174]: pr_db_load(): error flushing tree 0(5802) CRITICAL: prefix_route [prefix_route.c:212]: mod_init(): db load failed
I have tried a "name" instead of IP (though i dont know how to convert that "name" into a IP:Port), But i am still getting same error using "name" instead of IP:port @ route field in DB.
Please help.
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This feature was made half year ago. We would like to have inside location record address of the host where kamailio is installed. However when we installed it behind NAT we got private address in this field.
This feature introduces possibility to set a socket string which will be written into location record. It could be public address instead address on which the register request was received. The default value is NULL and it works as usual. The feature was installed on our production servers in April and since that time it works well. I would like to propose this feature to others, because it could be useful.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2498
-- Commit Summary --
* registrar: added new parameter sock_addr
-- File Changes --
M src/modules/registrar/doc/registrar_admin.xml (25)
M src/modules/registrar/registrar.c (2)
M src/modules/registrar/registrar.h (1)
M src/modules/registrar/save.c (39)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2498.patchhttps://github.com/kamailio/kamailio/pull/2498.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2498
[View Less]
Module: kamailio
Branch: master
Commit: b495a00c9a6fb2e073e7bd2a2b394facc9d76ea5
URL: https://github.com/kamailio/kamailio/commit/b495a00c9a6fb2e073e7bd2a2b394fa…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-14T11:34:03+02:00
registrar: docs updated to reflect sock_mode parameter
---
Modified: src/modules/registrar/doc/registrar_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]b495a00c9a6fb2e073e7bd2a2b394fa…
Patch: https://github.com/kamailio/kamailio/commit/b495a00c9a6fb2e073e7bd2a2b394fa…
---
diff --git a/src/modules/registrar/doc/registrar_admin.xml b/src/modules/registrar/doc/registrar_admin.xml
index 52559a638f..4fb1e8a5e8 100644
--- a/src/modules/registrar/doc/registrar_admin.xml
+++ b/src/modules/registrar/doc/registrar_admin.xml
@@ -535,26 +535,27 @@ modparam("registrar", "sock_hdr_name", "Sock-Info")
</example>
</section>
- <section id="registrar.p.use_advertised_address">
- <title><varname>use_advertised_address</varname> (integer)</title>
+ <section id="registrar.p.sock_mode">
+ <title><varname>sock_mode</varname> (integer)</title>
<para>
- This parameter can be used to override value written into socket field when contact is saved.
- If set to 1, advertised address will be written instead local listen socket.
+ If set to 1, the server stores the advertised address in socket field,
+ instead of bind address.
</para>
<para>
- This could be useful when kamailio is installed behind NAT and it is necessary to store its public IP
- instead socket on which the register request was received.
+ This could be useful when kamailio is installed behind NAT and it is
+ necessary to store its public IP instead socket on which the register
+ request was received.
</para>
<para>
<emphasis>
- Default value is 0 (disabled).
+ Default value is 0 (store bind address).
</emphasis>
</para>
<example>
- <title>Set <varname>use_advertised_address</varname> parameter</title>
+ <title>Set <varname>sock_mode</varname> parameter</title>
<programlisting format="linespecific">
...
-modparam("registrar", "use_advertised_address", 1)
+modparam("registrar", "sock_mode", 1)
...
</programlisting>
</example>
[View Less]
Module: kamailio
Branch: master
Commit: e3ec71b45181c2413b4aba4e2ea5e1b371a6da56
URL: https://github.com/kamailio/kamailio/commit/e3ec71b45181c2413b4aba4e2ea5e1b…
Author: Konstantin <piligrim_pk(a)mail.ru>
Committer: GitHub <noreply(a)github.com>
Date: 2020-10-14T11:22:20+02:00
registrar: added option to store advertised address in socket field (#2498)
* registrar: added new parameter sock_addr
- override socket address on which the register request was received
- default is …
[View More]NULL - store local socket address
- usefull when kamailio is behind NAT and it is necessary to store public instead private address
* registrar: replaced dynamically allocated var with static var
Made refactoring of proposed solution.
* registrar: socket field in location db will be initialized by advertise address from listen parameter
According to code review recommendations I changed my solution - removed new config file parameter and
use advertise address from listen parameter to initialized received socket which is written to
location db inside registration record.
* registrar: added additional check socket bind_address for null
* registrar: introduced config parameter to enable/disable socket advertised address feature
---
Modified: src/modules/registrar/doc/registrar_admin.xml
Modified: src/modules/registrar/registrar.c
Modified: src/modules/registrar/registrar.h
Modified: src/modules/registrar/save.c
---
Diff: https://github.com/kamailio/kamailio/commit/e3ec71b45181c2413b4aba4e2ea5e1b…
Patch: https://github.com/kamailio/kamailio/commit/e3ec71b45181c2413b4aba4e2ea5e1b…
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [*] Commit message has the format required by CONTRIBUTING guide
- [*] Commits are split per component (core, individual modules, libs, utils, ...)
- [*] Each component has a single commit (if not, squash them into one commit)
- [*] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [*] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [*] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR adds crypto_hmac_sha256() function that can be used for JWT (JSON Web Token) authentication.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2505
-- Commit Summary --
* crypto: add crypto_hmac_sha256() function
-- File Changes --
M src/modules/crypto/crypto_mod.c (115)
M src/modules/crypto/doc/crypto_admin.xml (24)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2505.patchhttps://github.com/kamailio/kamailio/pull/2505.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2505
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2500
-- Commit Summary --
* Make the FLAGS declaration slightly clearer
-- File Changes --
M etc/kamailio.cfg (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2500.patchhttps://github.com/kamailio/kamailio/pull/2500.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2500
[View Less]
Module: kamailio
Branch: master
Commit: 531eaea43e9a086aa7d1797ce3fa710691c1880b
URL: https://github.com/kamailio/kamailio/commit/531eaea43e9a086aa7d1797ce3fa710…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-13T15:46:25+02:00
modules: readme files regenerated - pike ... [skip ci]
---
Modified: src/modules/pike/README
---
Diff: https://github.com/kamailio/kamailio/commit/531eaea43e9a086aa7d1797ce3fa710……
[View More]Patch: https://github.com/kamailio/kamailio/commit/531eaea43e9a086aa7d1797ce3fa710…
---
diff --git a/src/modules/pike/README b/src/modules/pike/README
index beea746f45..761ae10822 100644
--- a/src/modules/pike/README
+++ b/src/modules/pike/README
@@ -31,6 +31,7 @@ Bogdan-Andrei Iancu
4. Functions
4.1. pike_check_req()
+ 4.2. pike_check_ip(ipaddr)
5. RPC Commands
@@ -50,6 +51,7 @@ Bogdan-Andrei Iancu
1.3. Set remove_latency parameter
1.4. Set pike_log_level parameter
1.5. pike_check_req usage
+ 1.6. pike_check_ip usage
2.1. Using pike.top
3.1. Tree of IP addresses
@@ -73,6 +75,7 @@ Chapter 1. Admin Guide
4. Functions
4.1. pike_check_req()
+ 4.2. pike_check_ip(ipaddr)
5. RPC Commands
@@ -175,6 +178,7 @@ modparam("pike", "pike_log_level", -1)
4. Functions
4.1. pike_check_req()
+ 4.2. pike_check_ip(ipaddr)
4.1. pike_check_req()
@@ -191,13 +195,30 @@ Warning
* -2 (false) - IP is detected as a new source of flooding - first
time detection
- This function can be used from REQUEST_ROUTE.
+ This function can be used from REQUEST_ROUTE|ONREPLY_ROUTE.
Example 1.5. pike_check_req usage
...
if (!pike_check_req()) { exit; };
...
+4.2. pike_check_ip(ipaddr)
+
+ Process the IP address parameter and return false if it was exceeding
+ the blocking limit. The return codes are the same from
+ pike_check_req().
+
+ The parameter can contain variables.
+
+ This function can be used from REQUEST_ROUTE|ONREPLY_ROUTE.
+
+ Example 1.6. pike_check_ip usage
+...
+if (!pike_check_ip("1.2.3.4")) { exit; };
+...
+if (!pike_check_ip("$si")) { exit; };
+...
+
5. RPC Commands
5.1. pike.top
[View Less]
How about adding source addr param to pike_check_req()?
Motivation is that main proxy may be front-ended by another proxy that
passes the real source addr to the main proxy in a header.
-- Juha
Module: kamailio
Branch: master
Commit: 8a0c8f1b4c6da364d527fd8e1bc305332825b50e
URL: https://github.com/kamailio/kamailio/commit/8a0c8f1b4c6da364d527fd8e1bc3053…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-13T15:34:42+02:00
pike: docs for pike_check_ip()
---
Modified: src/modules/pike/doc/pike_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/8a0c8f1b4c6da364d527fd8e1bc3053……
[View More]Patch: https://github.com/kamailio/kamailio/commit/8a0c8f1b4c6da364d527fd8e1bc3053…
---
diff --git a/src/modules/pike/doc/pike_admin.xml b/src/modules/pike/doc/pike_admin.xml
index 1963373d9d..612765843f 100644
--- a/src/modules/pike/doc/pike_admin.xml
+++ b/src/modules/pike/doc/pike_admin.xml
@@ -193,7 +193,7 @@ modparam("pike", "pike_log_level", -1)
</itemizedlist>
</para>
<para>
- This function can be used from REQUEST_ROUTE.
+ This function can be used from REQUEST_ROUTE|ONREPLY_ROUTE.
</para>
<example>
<title><function>pike_check_req</function> usage</title>
@@ -204,6 +204,32 @@ if (!pike_check_req()) { exit; };
</programlisting>
</example>
</section>
+ <section id="pike.f.pike_check_ip">
+ <title>
+ <function moreinfo="none">pike_check_ip(ipaddr)</function>
+ </title>
+ <para>
+ Process the IP address parameter and return false if it was exceeding
+ the blocking limit. The return codes are the same from pike_check_req().
+ </para>
+ <para>
+ The parameter can contain variables.
+ </para>
+ <para>
+ This function can be used from REQUEST_ROUTE|ONREPLY_ROUTE.
+ </para>
+ <example>
+ <title><function>pike_check_ip</function> usage</title>
+ <programlisting format="linespecific">
+...
+if (!pike_check_ip("1.2.3.4")) { exit; };
+...
+if (!pike_check_ip("$si")) { exit; };
+...
+</programlisting>
+ </example>
+ </section>
+
</section>
<section>
[View Less]
Hii
Please help me to get the a value from SIP INVITE header reached to kamailio like INVITE sip:+341930203454@sub.domain.com;myid=+34@sub.domain.com SIP/2.0 and i want to save the myid value +34 into a variable, without the domain name.
$var(uri) = $sel(ruri);
xavp_params_explode("$(var(uri){s.unbracket})", "uri");
xlog("L_INFO", "$var(uri) Received converted to $xavp(uri=>myid[0])\n");
I tried above and it prints +34(a)sub.…
[View More]domain.com But i want to just save +34 into a variable to further check the prefix based routing from the database.
1) Could you please help how to get it or If there is any alternate/single line approach to get this value?
2) $var & $xavp are process-local variables, and they cant be shared with other calls? Right
3) What is the best module to route calls based their prefix ? pstn_route or dynamic routing or any suggestions?
Please help, thanks in advance.
[View Less]
### Description
We have segfault in Kamailio v5.3.1 installed on Debain 9.x 64 bit occured while kamailio was shutting down while our script tryed to get metrics using kamcmd utility at the same time.
### Troubleshooting
No troubleshooting was done, since it happened on a production server. We simply restarted the server.
#### Reproduction
The problem periodically happens on production servers in runtime. Kamailio crashes when one of our scripts tried getting statistics about websocket …
[View More]and tls modules using kamcmd. As I see in core dump, shared memory was already freed when rpc_mod_print called in the child process.
#### Debugging Data
```
GNU gdb (Debian 7.12-6) 7.12.0.20161007-git
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /var/lib/ums/sbin/kamailio...done.
[New LWP 17075]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/var/lib/ums/sbin/kamailio -m 2048 -M 12 -P /var/run/kamailio/kamailio.pid -f /'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 __strcmp_sse2_unaligned ()
at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:32
#0 __strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:32
#1 0x00007fcae1ef62f5 in rpc_mod_print (rpc=0x7fcae180b540 <binrpc_callbacks>, ctx=0x7ffe7a6f7808, mname=0x1edd0c9 "websocket", stats=0x1ef8310, flag=2) at mod_stats.c:117
#2 0x00007fcae1ef60eb in rpc_mod_print_one (rpc=0x7fcae180b540 <binrpc_callbacks>, ctx=0x7ffe7a6f7808, mname=0x1edd0c9 "websocket", pkg_stats=0x1ef69d0, shm_stats=0x1ef8310, flag=2) at mod_stats.c:159
#3 0x00007fcae1ef5ee1 in rpc_mod_mem_stats_mode (rpc=0x7fcae180b540 <binrpc_callbacks>, ctx=0x7ffe7a6f7808, fmode=0) at mod_stats.c:239
#4 0x00007fcae1ef584f in rpc_mod_mem_stats (rpc=0x7fcae180b540 <binrpc_callbacks>, ctx=0x7ffe7a6f7808) at mod_stats.c:251
#5 0x00007fcae15dac80 in process_rpc_req (buf=0x1edd0b4 "\241\003\035\020\333Qg\221\nmod.stats", size=36, bytes_needed=0x7ffe7a6f7c50, sh=0x7ffe7a6f7bc0, saved_state=0x1eed0b8) at binrpc_run.c:678
#6 0x00007fcae15c872f in handle_stream_read (s_c=0x1edd080, idx=-1) at io_listener.c:511
#7 0x00007fcae15c4121 in handle_io (fm=0x7fcb65600cb0, events=1, idx=-1) at io_listener.c:706
#8 0x00007fcae15c293a in io_wait_loop_epoll (h=0x7fcae180b348 <io_h>, t=10, repeat=0) at ./../../core/io_wait.h:1062
#9 0x00007fcae15b662c in io_listen_loop (fd_no=2, cs_lst=0x1df1940) at io_listener.c:281
#10 0x00007fcae15ec72c in mod_child (rank=0) at ctl.c:338
#11 0x0000000000638c14 in init_mod_child (m=0x7fcb6547f4b0, rank=0) at core/sr_module.c:780
#12 0x000000000063862d in init_mod_child (m=0x7fcb6547fb78, rank=0) at core/sr_module.c:776
#13 0x000000000063862d in init_mod_child (m=0x7fcb65480018, rank=0) at core/sr_module.c:776
#14 0x000000000063862d in init_mod_child (m=0x7fcb65480528, rank=0) at core/sr_module.c:776
#15 0x000000000063862d in init_mod_child (m=0x7fcb654809c8, rank=0) at core/sr_module.c:776
#16 0x000000000063862d in init_mod_child (m=0x7fcb65481140, rank=0) at core/sr_module.c:776
#17 0x000000000063862d in init_mod_child (m=0x7fcb654817b0, rank=0) at core/sr_module.c:776
#18 0x000000000063862d in init_mod_child (m=0x7fcb65481c38, rank=0) at core/sr_module.c:776
#19 0x00000000006385b2 in init_child (rank=0) at core/sr_module.c:825
#20 0x000000000043140c in main_loop () at main.c:1753
#21 0x000000000043df6f in main (argc=9, argv=0x7ffe7a6fbf88) at main.c:2802
```
#### Log Messages
No any useful logs available.
#### SIP Traffic
No SIP traffic available.
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **This is a sequence of commands that python script runs every 10 seconds:**
```
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 stats.get_statistics websocket:
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 stats.get_statistics tcp:
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 stats.get_statistics shmem:
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 mod.stats tls pkg
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 mod.stats tls shm
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 mod.stats websocket pkg
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 mod.stats websocket shm
/var/lib/ums/sbin/kamcmd -s tcp:localhost:2048 mod.stats core shm
```
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.3.1 (x86_64/linux) 283e46
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 283e46
compiled on 14:23:37 Jul 28 2020 with clang 9.0
```
* **Operating System**:
```
Linux devhpbx005-1.vx 4.9.0-12-amd64 #1 SMP Debian 4.9.210-1 (2020-01-20) x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2460
[View Less]
### Description
I am experimenting with fuzzing on Kamailio SIP. A malformed INVITE (with a long tag) crashes the server, raised by qm_debug_check_frag().
### Troubleshooting
The error message:
```
qm_debug_check_frag(): BUG: qm: fragm. 0x7ffff03642e8 (address 0x7ffff0364320) end overwritten (9191919191919191, 9191919191919191)! Memory allocator was called from tm: t_reply.c:2410. Fragment marked by tm: t_msgbuilder.c:327. Exec from core/mem/q_malloc.c:511.
```
Output from GDB:
```
(gdb) …
[View More]watch *0x7ffff0364320
Hardware watchpoint 1: *0x7ffff0364320
(gdb) run -f kamailio-basic.cfg -L src/modules -Y runtime_dir/ -n 1 -D -E
Starting program: /home/rnatella/workdir-sip/kamailio/src/kamailio -f kamailio-basic.cfg -L src/modules -Y runtime_dir/ -n 1 -D -E
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0(29450) INFO: <core> [core/sctp_core.c:75]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module
Listening on
udp: 127.0.0.1 [127.0.0.1]:5060
Aliases:
WARNING: no fork mode
0(29450) INFO: rr [./../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded
0(29450) INFO: rr [rr_mod.c:185]: mod_init(): outbound module not available
0(29450) INFO: <core> [main.c:2841]: main(): processes (at least): 4 - shm size: 67108864 - pkg size: 8388608
0(29450) INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
0(29450) INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
0(29450) ERROR: {1 2 INVITE 1-670(a)127.0.0.1} <core> [core/parser/parse_rr.c:78]: do_parse_rr_body(): Failed parsing name-addr (<sip:127.0"0tttttttttttttttttttttttttttK-670-1-7)
0(29450) ERROR: {1 2 INVITE 1-670(a)127.0.0.1} <core> [core/parser/parse_rr.c:140]: do_parse_rr_body(): Failed parsing rr header body [<sip:127.0"0tttttttttttttttttttttttttttK-670-1-7]
0(29450) ERROR: {1 2 INVITE 1-670(a)127.0.0.1} rr [loose.c:468]: find_rem_target(): failed to parse last Route HF
0(29450) ERROR: {1 2 INVITE 1-670(a)127.0.0.1} rr [loose.c:700]: after_strict(): searching for last Route URI failed
Hardware watchpoint 1: *0x7ffff0364320
Old value = <unreadable>
New value = 4932352
__memmove_sse2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:316
316 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file or directory.
(gdb) bt
#0 __memmove_sse2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:316
#1 0x00007ffff602e4ff in build_local_reparse (Trans=<optimized out>, branch=<optimized out>, len=<optimized out>, method=<optimized out>,
method_len=<optimized out>, to=<optimized out>, reason=<optimized out>) at t_msgbuilder.c:336
#2 0x00007ffff607eaff in build_ack (rpl=<optimized out>, trans=<optimized out>, branch=0, ret_len=<optimized out>) at t_reply.c:360
#3 reply_received (p_msg=<optimized out>) at t_reply.c:2398
#4 0x00000000005a0af3 in do_forward_reply (msg=0x7ffff68eed28, mode=<optimized out>) at core/forward.c:757
#5 0x0000000000688cae in receive_msg (buf=<optimized out>, len=<optimized out>, rcv_info=<optimized out>) at core/receive.c:509
#6 0x00000000004a6b39 in udp_rcv_loop () at core/udp_server.c:543
#7 0x000000000042c938 in main_loop () at main.c:1480
#8 0x000000000043c574 in main (argc=<optimized out>, argv=<optimized out>) at main.c:2863
(gdb) frame \
Quit
(gdb) frame
No symbol "frame" in current context.
(gdb) frame frame 1
No symbol "frame" in current context.
(gdb) frame 1
#1 0x00007ffff602e4ff in build_local_reparse (Trans=<optimized out>, branch=<optimized out>, len=<optimized out>, method=<optimized out>,
method_len=<optimized out>, to=<optimized out>, reason=<optimized out>) at t_msgbuilder.c:336
336 append_str(d, method, method_len);
(gdb) print d
$1 = 0x7ffff0364320 ""
(gdb) c
Continuing.
Hardware watchpoint 1: *0x7ffff0364320
Old value = 4932352
New value = 4932417
__memmove_sse2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:317
317 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file or directory.
(gdb) bt
#0 __memmove_sse2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:317
#1 0x00007ffff602e4ff in build_local_reparse (Trans=<optimized out>, branch=<optimized out>, len=<optimized out>, method=<optimized out>,
method_len=<optimized out>, to=<optimized out>, reason=<optimized out>) at t_msgbuilder.c:336
#2 0x00007ffff607eaff in build_ack (rpl=<optimized out>, trans=<optimized out>, branch=0, ret_len=<optimized out>) at t_reply.c:360
#3 reply_received (p_msg=<optimized out>) at t_reply.c:2398
#4 0x00000000005a0af3 in do_forward_reply (msg=0x7ffff68eed28, mode=<optimized out>) at core/forward.c:757
#5 0x0000000000688cae in receive_msg (buf=<optimized out>, len=<optimized out>, rcv_info=<optimized out>) at core/receive.c:509
#6 0x00000000004a6b39 in udp_rcv_loop () at core/udp_server.c:543
#7 0x000000000042c938 in main_loop () at main.c:1480
#8 0x000000000043c574 in main (argc=<optimized out>, argv=<optimized out>) at main.c:2863
(gdb) c
Continuing.
Hardware watchpoint 1: *0x7ffff0364320
Old value = 4932417
New value = 541803329
0x00007ffff602e504 in build_local_reparse (Trans=<optimized out>, branch=<optimized out>, len=<optimized out>, method=<optimized out>,
method_len=<optimized out>, to=<optimized out>, reason=<optimized out>) at t_msgbuilder.c:337
337 *d = ' ';
(gdb) bt
#0 0x00007ffff602e504 in build_local_reparse (Trans=<optimized out>, branch=<optimized out>, len=<optimized out>, method=<optimized out>,
method_len=<optimized out>, to=<optimized out>, reason=<optimized out>) at t_msgbuilder.c:337
#1 0x00007ffff607eaff in build_ack (rpl=<optimized out>, trans=<optimized out>, branch=0, ret_len=<optimized out>) at t_reply.c:360
#2 reply_received (p_msg=<optimized out>) at t_reply.c:2398
#3 0x00000000005a0af3 in do_forward_reply (msg=0x7ffff68eed28, mode=<optimized out>) at core/forward.c:757
#4 0x0000000000688cae in receive_msg (buf=<optimized out>, len=<optimized out>, rcv_info=<optimized out>) at core/receive.c:509
#5 0x00000000004a6b39 in udp_rcv_loop () at core/udp_server.c:543
#6 0x000000000042c938 in main_loop () at main.c:1480
#7 0x000000000043c574 in main (argc=<optimized out>, argv=<optimized out>) at main.c:2863
(gdb) c
Continuing.
0(29450) CRITICAL: {2 2 INVITE 1-670(a)127.0.0.1} <core> [core/mem/q_malloc.c:138]: qm_debug_check_frag(): BUG: qm: fragm. 0x7ffff03642e8 (address 0x7ffff0364320) end overwritten (9191919191919191, 9191919191919191)! Memory allocator was called from tm: t_reply.c:2410. Fragment marked by tm: t_msgbuilder.c:327. Exec from core/mem/q_malloc.c:511.
Program received signal SIGSEGV, Segmentation fault.
0x000000000082f45f in qm_status (qmp=<optimized out>) at core/mem/q_malloc.c:902
902 f!=&(qm->free_hash[h].head); f=f->u.nxt_free, i++, j++){
```
#### Reproduction
I am running the server with a basic configuration (attached kamailio-basic.cfg), using the command:
```
./src/kamailio -f kamailio-basic.cfg -L src/modules -Y runtime_dir/ -n 1 -D -E
```
[kamailio-basic.cfg.txt](https://github.com/kamailio/kamailio/files/5354439/…
On the same machine, I am sending the malformed message (also attached):
```
cat sip-crash.txt | nc -4u -w1 localhost 5060
```
[sip-crash.txt](https://github.com/kamailio/kamailio/files/5354468/sip-crash…
You can find more information about my fuzzing setup at: [](https://github.com/rnatella/aflnet-kamailio-sip)
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
See previous section
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
See previous section
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
See previos section
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.5.0-dev2 (x86_64/linux) 6049a1-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 6049a1 -dirty
compiled on 10:12:13 Oct 9 2020 with /home/rnatella/aflnet/afl-clang-fast 6.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Ubuntu 18.04.2 LTS
Linux dockertest1 4.15.0-109-generic #110-Ubuntu SMP Tue Jun 23 02:39:32 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2503
[View Less]
### Description
<!--
DID Trunk ----> Kamailio (UAC) ---> Asterisk
Call comes from DID Trunk and UAC module is used as per some fixed mapping in DB so we use that user to make call Asterisk through UAC as shown below.
```
$var(original_ru) = $rU;
if (uac_reg_request_to("$avp(auser)", 1)) {
$var(status) = uac_reg_status("$rU");
$rU = $var(original_ru) ;
t_on_failure("REMOTE_AUTH");
}
failure_route[REMOTE_AUTH] {
if (t_check_status("401|407")) {
xlogl("L_INFO", " …
[View More]Remote asked for authentication");
t_drop_replies();
# - remove preloaded route headers
remove_hf("Route");
record_route();
$avp(authed) = 1;
# Drop replies so that they are not sent back to the UAC
uac_auth();
route(RELAY);
}
}
```
in all this activity Contact Header also replaced by UAC_AUTH so Replies from Asterisk reaches to Kamailio but does not relay back to DID Trunk.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2504
[View Less]
Module: kamailio
Branch: 5.3
Commit: 83f562f0f0f2336e3cd26e54b5f337621775a6df
URL: https://github.com/kamailio/kamailio/commit/83f562f0f0f2336e3cd26e54b5f3376…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-12T10:46:32+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/nathelper/README
Modified: src/modules/phonenum/README
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/83f562f0f0f2336e3cd26e54b5f3376…
Patch: https://github.com/kamailio/kamailio/commit/83f562f0f0f2336e3cd26e54b5f3376…
---
diff --git a/src/modules/nathelper/README b/src/modules/nathelper/README
index 27d1e1c654..97b373eff3 100644
--- a/src/modules/nathelper/README
+++ b/src/modules/nathelper/README
@@ -521,16 +521,19 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
* flags - the value may be a bitwise OR of the following flags:
+ 0x01 - adds “a=direction:active” SDP line;
+ 0x02 - rewrite media IP address (c=) with source address of
- the message or the provided IP address (the provide IP address
- take precedence over the source address).
+ the message or the provided IP address. (a=rtpc) param will be
+ rewritten if exists. (the provided IP address take precedence
+ over the source address).
+ 0x04 - adds “a=nortpproxy:yes” SDP line;
+ 0x08 - rewrite IP from origin description (o=) with source
- address of the message or the provided IP address (the provide
- IP address take precedence over the source address).
+ address of the message or the provided IP address. (a=rtpc)
+ param will be rewritten if exists. (the provided IP address
+ take precedence over the source address).
* ip_address - IP to be used for rewriting SDP. If not specified, the
received signalling IP will be used. The parameter allows
pseudo-variables usage. NOTE: For the IP to be used, you need to
- use 0x02 or 0x08 flags, otherwise it will have no effect.
+ use 0x02 or 0x08 flags, otherwise it will have no effect. Must be
+ IPv4 address family.
This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE,
FAILURE_ROUTE, BRANCH_ROUTE.
diff --git a/src/modules/phonenum/README b/src/modules/phonenum/README
index ebe872869b..096a3efa4b 100644
--- a/src/modules/phonenum/README
+++ b/src/modules/phonenum/README
@@ -161,6 +161,13 @@ if(phonenum_match("1-484-555-8888", "src")) {
letter, e.g: "DE", "US", "ES"). The function has to be called before
accessing a key via: $phn(pvc=>key).
+ Note from libphonenumber library docs: country name code is the region
+ that is expected the number to be from. It is only used if the number
+ being parsed is not written in international format. The country code
+ for the number in this case would be stored as that of the region
+ supplied. If the number is guaranteed to start with a '+' followed by
+ the country calling code, then region 'ZZ'.
+
The parameters can be static strings or strings with variables.
It can be used from ANY_ROUTE.
[View Less]
Module: kamailio
Branch: 5.3
Commit: 432bc89a963a1e71a107e6f73d103a6bbae02833
URL: https://github.com/kamailio/kamailio/commit/432bc89a963a1e71a107e6f73d103a6…
Author: Arsen Semenov <arsperger(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-12T10:32:20+02:00
nathelper: docs - updated notes for fix_nated_sdp. few typos fixed [skip ci]
(cherry picked from commit 64579fee33d0a82a583b75184f78fcb7c9df2d82)
(cherry picked from commit …
[View More]d5393ffd76cc37e98365d7b945454e0215d9f82f)
---
Modified: src/modules/nathelper/doc/nathelper_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/432bc89a963a1e71a107e6f73d103a6…
Patch: https://github.com/kamailio/kamailio/commit/432bc89a963a1e71a107e6f73d103a6…
---
diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml
index 64defce296..ee94853beb 100644
--- a/src/modules/nathelper/doc/nathelper_admin.xml
+++ b/src/modules/nathelper/doc/nathelper_admin.xml
@@ -562,7 +562,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x02</emphasis> - rewrite media
&ip; address (c=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
<listitem>
@@ -572,7 +572,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x08</emphasis> - rewrite IP from
origin description (o=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
</itemizedlist>
@@ -582,7 +582,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
If not specified, the received signalling IP will be used. The
parameter allows pseudo-variables usage. NOTE: For the IP to be
used, you need to use 0x02 or 0x08 flags, otherwise it will have
- no effect.
+ no effect. Must be IPv4 address family.
</para>
</listitem>
</itemizedlist>
[View Less]
Module: kamailio
Branch: 5.3
Commit: 1eecbb239cce980cebd9e3853cc4e06fb5dd2da9
URL: https://github.com/kamailio/kamailio/commit/1eecbb239cce980cebd9e3853cc4e06…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-12T10:31:55+02:00
phonenum: note about the role of country code name for phonenum_match_cn()
(cherry picked from commit dfd6c3966ed70d111a9196076bc29767c395d814)
(cherry picked from commit …
[View More]755867b920e4e0d17a4bdf447a0d59a06875f8e1)
---
Modified: src/modules/phonenum/doc/phonenum_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/1eecbb239cce980cebd9e3853cc4e06…
Patch: https://github.com/kamailio/kamailio/commit/1eecbb239cce980cebd9e3853cc4e06…
---
diff --git a/src/modules/phonenum/doc/phonenum_admin.xml b/src/modules/phonenum/doc/phonenum_admin.xml
index d30c2026ee..f3a3e98ede 100644
--- a/src/modules/phonenum/doc/phonenum_admin.xml
+++ b/src/modules/phonenum/doc/phonenum_admin.xml
@@ -156,6 +156,14 @@ if(phonenum_match("1-484-555-8888", "src")) {
(two letter, e.g: "DE", "US", "ES"). The function has to be called
before accessing a key via: $phn(pvc=>key).
</para>
+ <para>
+ Note from libphonenumber library docs: country name code is the region
+ that is expected the number to be from. It is only used if the number
+ being parsed is not written in international format. The country code
+ for the number in this case would be stored as that of the region
+ supplied. If the number is guaranteed to start with a '+' followed
+ by the country calling code, then region 'ZZ'.
+ </para>
<para>
The parameters can be static strings or strings with variables.
</para>
[View Less]
### Description
Would be very handy to have all information from the KA function (KA-Roundtrip and Last-Keepalive values) in the DB location table as well in two separate columns.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2501
Module: kamailio
Branch: 5.4
Commit: d5393ffd76cc37e98365d7b945454e0215d9f82f
URL: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0…
Author: Arsen Semenov <arsperger(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-12T10:13:11+02:00
nathelper: docs - updated notes for fix_nated_sdp. few typos fixed [skip ci]
(cherry picked from commit 64579fee33d0a82a583b75184f78fcb7c9df2d82)
---
Modified: src/modules/nathelper/doc/…
[View More]nathelper_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0…
Patch: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0…
---
diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml
index c73baf21a4..6bf4783337 100644
--- a/src/modules/nathelper/doc/nathelper_admin.xml
+++ b/src/modules/nathelper/doc/nathelper_admin.xml
@@ -562,7 +562,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x02</emphasis> - rewrite media
&ip; address (c=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
<listitem>
@@ -572,7 +572,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x08</emphasis> - rewrite IP from
origin description (o=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
</itemizedlist>
@@ -582,7 +582,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
If not specified, the received signalling IP will be used. The
parameter allows pseudo-variables usage. NOTE: For the IP to be
used, you need to use 0x02 or 0x08 flags, otherwise it will have
- no effect.
+ no effect. Must be IPv4 address family.
</para>
</listitem>
</itemizedlist>
[View Less]
Module: kamailio
Branch: 5.4
Commit: 755867b920e4e0d17a4bdf447a0d59a06875f8e1
URL: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-12T10:11:45+02:00
phonenum: note about the role of country code name for phonenum_match_cn()
(cherry picked from commit dfd6c3966ed70d111a9196076bc29767c395d814)
---
Modified: src/modules/…
[View More]phonenum/doc/phonenum_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a…
Patch: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a…
---
diff --git a/src/modules/phonenum/doc/phonenum_admin.xml b/src/modules/phonenum/doc/phonenum_admin.xml
index d30c2026ee..f3a3e98ede 100644
--- a/src/modules/phonenum/doc/phonenum_admin.xml
+++ b/src/modules/phonenum/doc/phonenum_admin.xml
@@ -156,6 +156,14 @@ if(phonenum_match("1-484-555-8888", "src")) {
(two letter, e.g: "DE", "US", "ES"). The function has to be called
before accessing a key via: $phn(pvc=>key).
</para>
+ <para>
+ Note from libphonenumber library docs: country name code is the region
+ that is expected the number to be from. It is only used if the number
+ being parsed is not written in international format. The country code
+ for the number in this case would be stored as that of the region
+ supplied. If the number is guaranteed to start with a '+' followed
+ by the country calling code, then region 'ZZ'.
+ </para>
<para>
The parameters can be static strings or strings with variables.
</para>
[View Less]
Module: kamailio
Branch: 5.4
Commit: 26fb90fd6ffdb239fa6c2779f281fae78f90c5ef
URL: https://github.com/kamailio/kamailio/commit/26fb90fd6ffdb239fa6c2779f281fae…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-12T10:07:23+02:00
topos: docs - more details about what SIP traffic is handled
(cherry picked from commit 878971f2c0bc32233b6f18728f9b88537b3d19e8)
---
Modified: src/modules/topos/doc/topos_admin.…
[View More]xml
---
Diff: https://github.com/kamailio/kamailio/commit/26fb90fd6ffdb239fa6c2779f281fae…
Patch: https://github.com/kamailio/kamailio/commit/26fb90fd6ffdb239fa6c2779f281fae…
---
diff --git a/src/modules/topos/doc/topos_admin.xml b/src/modules/topos/doc/topos_admin.xml
index 8b3e2a0515..fa4f97b4d6 100644
--- a/src/modules/topos/doc/topos_admin.xml
+++ b/src/modules/topos/doc/topos_admin.xml
@@ -16,20 +16,23 @@
<section>
<title>Overview</title>
<para>
- This module offers topology hiding by stripping the SIP routing
- headers that show topology details.
+ This module offers topology hiding for INVITE-based dialogs, by stripping
+ the SIP routing headers that show topology details .
The script interpreter gets the SIP messages with full content,
so all existing functionality is preserved.
</para>
<para>
The module is transparent for the configuration writer. It only needs to be
- loaded (tune the parameters if needed).
+ loaded (tune the module parameters if needed).
</para>
<para>
It also works for SIP MESSAGE or other requests that do not create
- a call dialog -- record_route() must be used for them as well, the
+ a dialog -- record_route() must be used for them as well, the
headers are not going to be in the messages sent to the network, they
are needed to know local addresses used to communicate with each side.
+ At this moment it is not designed to work for presence (SUBSCRIBE-based)
+ dialogs. The REGISTER and PUBLISH requests are skipped from processing
+ by this module, expected to be terminated on a local SIP server.
</para>
</section>
<section>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev…
[View More]Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Extract media stats per leg from RTPengine but in spite of labels being present in RTPengine logs the values are not extracted in their respective PV's
Note : the overall average, max and min values appear fine
### Troubleshooting
Opened Kamailio in debug mode and saw that labels are being set , yet appearing as null
Snipets
```
tagsd8:91e08b04d3:tag8:91e08b045:label6:caller7:createdi1590686836e16:in dialogue with13:tKtpK3BHjFavK6:mediasld5:indexi1e4:type5:audio8:protocol8:RTP/AVPF7
..
looking for label '<null>'
```
Full logs below in the "Log Messages" section
#### Reproduction
Using Lua on Kamailio v5.2.1
1. Add labels in RTPengine offer , ensuring the traffic is AVPF
```
local rtpengine_codecs_flag = " codec-strip-all codec-offer-PCMA codec-offer-pcma "
local rtpengine_offer_flag = "ICE=remove RTP/AVPF full-rtcp-attribute direction=external direction=external replace-origin replace-session-connection record-call=yes " .. rtpengine_codecs_flag .. " label=caller "
local rtpengine_answer_flag = "ICE=remove RTP/AVPF full-rtcp-attribute direction=external direction=external replace-origin replace-session-connection record-call=yes label=callee "
```
2. set the mos label
```
KSR.pv.sets("$avp(mos_A_label)", "caller");
```
3. Make call and do RTPengine offer and answer like usual
```
KSR.rtpengine.rtpengine_offer(rtpengine_offer_flag)
...
KSR.rtpengine.rtpengine_answer(rtpengine_answer_flag)
```
3. On BYE , do rtpengihne delete
```
KSR.rtpengine.rtpengine_delete0()
```
4. gather PV values for legs
```
KSR.log("info", "mos_A_label " .. KSR.pv.getvn("$avp(mos_A_label)", 1) .. "\n ")
KSR.log("info", "mos_average_packetloss_A " .. KSR.pv.getvn("$avp(mos_average_packetloss_A)", 0) .. "\n ")
KSR.log("info", "mos_average_jitter_A " .. KSR.pv.getvn("$avp(mos_average_jitter_A)", 0) .. "\n ")
KSR.log("info", "mos_average_roundtrip_A " .. KSR.pv.getvn("$avp(mos_average_roundtrip_A)", 0) .. "\n ")
KSR.log("info", "mos_average_A " .. KSR.pv.getvn("$avp(mos_average_A)", 0) .. "\n ")
```
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
Log from kamailio from BYE untill printing overall average mos score
```
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): >>> delete RTPengine
4(11084) DEBUG: rtpengine [rtpengine.c:2912]: select_rtpp_node_old(): rtpengine hash table lookup find node=udp:192.168.1.109:2222 for calllen=49 callid=103103ZjIzOGM1MWRlYjQxZDhjYWQ4YTlhN2I3ODg0YWNmN2I viabranch=
4(11084) DEBUG: rtpengine [rtpengine.c:2452]: rtpp_function_call(): proxy reply: d7:createdi1590686836e10:created_usi219955e11:last signali1590686836e4:SSRCd10:2899397750d11:average MOSd3:MOSi43e15:round-trip timei14365e6:jitteri0e11:packet lossi0e7:samplesi3ee10:lowest MOSd3:MOSi43e15:round-trip timei12630e6:jitteri1e11:packet lossi0e11:reported ati1590686846ee11:highest MOSd3:MOSi44e15:round-trip timei7559e6:jitteri0e11:packet lossi0e11:reported ati1590686849ee15:MOS progressiond8:intervali0e7:entriesld3:MOSi43e15:round-trip timei12630e6:jitteri1e11:packet lossi0e11:reported ati1590686846eed3:MOSi44e15:round-trip timei7559e6:jitteri0e11:packet lossi0e11:reported ati1590686849eed3:MOSi43e15:round-trip timei22908e6:jitteri0e11:packet lossi0e11:reported ati1590686855eeeee10:3469957276d11:average MOSd3:MOSi43e15:round-trip timei17045e6:jitteri0e11:packet lossi0e7:samplesi5ee10:lowest MOSd3:MOSi43e15:round-trip timei10048e6:jitteri0e11:packet lossi0e11:reported ati1590686844ee11:highest MOSd3:MOSi44e15:round-trip timei7134e6:jitteri0e11:packet lossi0e11:reported ati1590686848ee15:MOS progressiond8:intervali1e7:entriesld3:MOSi43e15:round-trip timei10048e6:jitteri0e11:packet lossi0e11:reported ati1590686844eed3:MOSi44e15:round-trip timei7134e6:jitteri0e11:packet lossi0e11:reported ati1590686848eed3:MOSi43e15:round-trip timei22738e6:jitteri0e11:packet lossi0e11:reported ati1590686852eed3:MOSi43e15:round-trip timei22566e6:jitteri0e11:packet lossi0e11:reported ati1590686853eed3:MOSi43e15:round-trip timei22739e6:jitteri0e11:packet lossi0e11:reported ati1590686854eeeeee4:tagsd8:91e08b04d3:tag8:91e08b045:label6:caller7:createdi1590686836e16:in dialogue with13:tKtpK3BHjFavK6:mediasld5:indexi1e4:type5:audio8:protocol8:RTP/AVPF7:streamsld10:local porti31052e8:endpointd6:family4:IPv47:address13:192.168.1.1084:porti58004ee19:advertised endpointd6:family4:IPv47:address13:192.168.1.1084:porti58004ee11:last packeti1590686855e5:flagsl3:RTP6:filled9:confirmed10:kernelized17:no kernel supporte4:SSRCi2899397750e5:statsd7:packetsi928e5:bytesi157696e6:errorsi12eeed10:local porti31053e8:endpointd6:family4:IPv47:address13:192.168.1.1084:porti58005ee19:advertised endpointd6:family4:IPv47:address13:192.168.1.1084:porti58005ee11:last packeti1590686855e5:flagsl4:RTCP6:filled9:confirmed10:kernelized17:no kernel supporte4:SSRCi2899397750e5:statsd7:packetsi5e5:bytesi400e6:errorsi0eeee5:flagsl11:initialized4:send4:recveeee13:tKtpK3BHjFavKd3:tag13:tKtpK3BHjFavK5:label6:callee7:createdi1590686836e16:in dialogue with8:91e08b046:mediasld5:indexi1e4:type5:audio8:protocol8:RTP/AVPF7:streamsld10:local porti31044e8:endpointd6:family4:IPv47:address13:192.168.1.1094:porti27984ee19:advertised endpointd6:family4:IPv47:address13:192.168.1.1094:porti27984ee11:last packeti1590686855e5:flagsl3:RTP6:filled9:confirmed10:kernelized17:no kernel support3:ICEe4:SSRCi3469957276e5:statsd7:packetsi653e5:bytesi112316e6:errorsi0eeed10:local porti31045e8:endpointd6:family4:IPv47:address13:192.168.1.1094:porti27985ee19:advertised endpointd6:family4:IPv47:address13:192.168.1.1094:porti27985ee11:last packeti1590686854e5:flagsl4:RTCP6:filled9:confirmed10:kernelized17:no kernel support3:ICEe4:SSRCi3469957276e5:statsd7:packetsi6e5:bytesi652e6:errorsi0eeee5:flagsl11:initialized4:send4:recv3:ICE15:ICE controllingeeeee6:totalsd3:RTPd7:packetsi1581e5:bytesi270012e6:errorsi12ee4:RTCPd7:packetsi11e5:bytesi1052e6:errorsi0eee6:result2:oke
4(11084) DEBUG: rtpengine [rtpengine.c:2536]: rtpp_function_call(): rtpengine hash table remove entry for callen=49 callid=103103ZjIzOGM1MWRlYjQxZDhjYWQ4YTlhN2I3ODg0YWNmN2I viabranch=
4(11084) DEBUG: rtpengine [rtpengine.c:3129]: parse_call_stats_1(): rtpengine: looking for label '<null>'
4(11084) DEBUG: rtpengine [rtpengine.c:3135]: parse_call_stats_1(): rtpengine: XXX got tags
4(11084) DEBUG: rtpengine [rtpengine.c:3138]: parse_call_stats_1(): rtpengine: XXX got tag
4(11084) DEBUG: rtpengine [rtpengine.c:3143]: parse_call_stats_1(): rtpengine: XXX got label caller
4(11084) DEBUG: rtpengine [rtpengine.c:3138]: parse_call_stats_1(): rtpengine: XXX got tag
4(11084) DEBUG: rtpengine [rtpengine.c:3143]: parse_call_stats_1(): rtpengine: XXX got label callee
4(11084) DEBUG: rtpengine [rtpengine.c:3129]: parse_call_stats_1(): rtpengine: looking for label '<null>'
4(11084) DEBUG: rtpengine [rtpengine.c:3135]: parse_call_stats_1(): rtpengine: XXX got tags
4(11084) DEBUG: rtpengine [rtpengine.c:3138]: parse_call_stats_1(): rtpengine: XXX got tag
4(11084) DEBUG: rtpengine [rtpengine.c:3143]: parse_call_stats_1(): rtpengine: XXX got label caller
4(11084) DEBUG: rtpengine [rtpengine.c:3138]: parse_call_stats_1(): rtpengine: XXX got tag
4(11084) DEBUG: rtpengine [rtpengine.c:3143]: parse_call_stats_1(): rtpengine: XXX got label callee
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_average)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_average)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos average 4.3
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos average 4.3
```
Logs from the same trace printing A leg values as nill , I'm using get getvn
such as
```
KSR.log("info", "mos_average_B " .. KSR.pv.getvn("$avp(mos_average_B)", 0) .. "\n ")
```
the traces thus show all values as 0
```
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos_A_label 1
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_average_packetloss_A)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_average_packetloss_A)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos_average_packetloss_A 0
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos_average_packetloss_A 0
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_average_jitter_A)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_average_jitter_A)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos_average_jitter_A 0
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos_average_jitter_A 0
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_average_roundtrip_A)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_average_roundtrip_A)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos_average_roundtrip_A 0
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos_average_roundtrip_A 0
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_average_A)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_average_A)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos_average_A 0
4(11084) INFO: <core> [core/kemi.c:143]: sr_kemi_core_log(): mos_average_A 0
4(11084) DEBUG: app_lua [app_lua_sr.c:1024]: lua_sr_pv_get_valx(): pv set: $avp(mos_B_label)
4(11084) DEBUG: <core> [core/pvapi.c:395]: pv_cache_lookup(): pvar [$avp(mos_B_label)] found in cache
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: log is str: info
4(11084) DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: log is str: mos_B_label 1
```
All IPs are local network so I didn't bother masking them
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
I did manage to extract the leg A values by first commenting out pase_call stats for overall and leg B
```
//parse_call_stats_1(&global_mos_stats, dict, msg);
parse_call_stats_1(&side_A_mos_stats, dict, msg);
//parse_call_stats_1(&side_B_mos_stats, dict, msg);
```
and then commenting out the check between the label and well another label , which is where I figured it was breaking the loop
```
//if (str_cmp(&check, &label))
// continue;
```
I understand this isn't an acceptable approach and I looking forward to learning whether this really is a bug or a bad setting on my end
Initially though it an RTPengine issue and raised a bug there too
https://github.com/sipwise/rtpengine/issues/947
pretty sure it isn't an RTPenginhe issue now .
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio -v
version: kamailio 5.2.1 (x86_64/linux) b71938-dirty
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: b71938 -dirty
compiled on 13:06:02 May 28 2020 with gcc 7.5.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Linux altanai-Inspiron-15-5578 4.15.0-62-generic #69-Ubuntu SMP Wed Sep 4 20:55:53 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2340
[View Less]
Module: kamailio
Branch: 5.4
Commit: 83f242845a8b2759d8eec0559154cfd62cf89278
URL: https://github.com/kamailio/kamailio/commit/83f242845a8b2759d8eec0559154cfd…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-09T22:30:32+02:00
core: tcp - helper function to send data over ws/wss connection
(cherry picked from commit 5e107824d684cdf30514b033e7f600862123ece5)
---
Modified: src/core/tcp_main.c
Modified: …
[View More]src/core/tcp_server.h
---
Diff: https://github.com/kamailio/kamailio/commit/83f242845a8b2759d8eec0559154cfd…
Patch: https://github.com/kamailio/kamailio/commit/83f242845a8b2759d8eec0559154cfd…
---
diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index f19f75a588..84fec376a3 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -95,6 +95,7 @@
#include "tcp_info.h"
#include "tcp_options.h"
#include "ut.h"
+#include "events.h"
#include "cfg/cfg_struct.h"
#include <fcntl.h> /* must be included after io_wait.h if SIGIO_RT is used */
@@ -5135,4 +5136,88 @@ void tcp_get_info(struct tcp_gen_info *ti)
#endif /* TCP_ASYNC */
}
+
+/* finds an ws/wss tcpconn & sends on it
+ * uses the dst members to, proto (ws/wss) and id and tries to send
+ * returns: number of bytes written (>=0) on success
+ * <0 on error */
+int wss_send(dest_info_t* dst, const char* buf, unsigned len)
+{
+ int port;
+ struct ip_addr ip;
+ union sockaddr_union* from = NULL;
+ union sockaddr_union local_addr;
+ struct tcp_connection *con = NULL;
+ struct ws_event_info wsev;
+ sr_event_param_t evp = {0};
+ int ret;
+
+ if (unlikely((dst->proto == PROTO_WS
+#ifdef USE_TLS
+ || dst->proto == PROTO_WSS
#endif
+ ) && sr_event_enabled(SREV_TCP_WS_FRAME_OUT))) {
+ if (unlikely(dst->send_flags.f & SND_F_FORCE_SOCKET
+ && dst->send_sock)) {
+
+ local_addr = dst->send_sock->su;
+#ifdef SO_REUSEPORT
+ if (cfg_get(tcp, tcp_cfg, reuse_port)) {
+ LM_DBG("sending to: %s, force_socket=%d, send_sock=%p\n",
+ su2a(&dst->to,sizeof(struct sockaddr_in)),
+ (dst->send_flags.f & SND_F_FORCE_SOCKET),
+ dst->send_sock);
+
+ su_setport(&local_addr, dst->send_sock->port_no);
+ }
+ else
+ su_setport(&local_addr, 0); /* any local port will do */
+#else
+ su_setport(&local_addr, 0); /* any local port will do */
+#endif
+ from = &local_addr;
+ }
+
+ port = su_getport(&dst->to);
+ if (likely(port)) {
+ su2ip_addr(&ip, &dst->to);
+ if(tcp_connection_match==TCPCONN_MATCH_STRICT) {
+ con = tcpconn_lookup(dst->id, &ip, port, from,
+ (dst->send_sock)?dst->send_sock->port_no:0, 0);
+ } else {
+ con = tcpconn_get(dst->id, &ip, port, from, 0);
+ }
+ }
+ else if (likely(dst->id))
+ con = tcpconn_get(dst->id, 0, 0, 0, 0);
+ else {
+ LM_CRIT("null_id & to\n");
+ goto error;
+ }
+
+ if (con == NULL) {
+ LM_WARN("TCP/TLS connection for WebSocket could not be found\n");
+ goto error;
+ }
+
+ memset(&wsev, 0, sizeof(ws_event_info_t));
+ wsev.type = SREV_TCP_WS_FRAME_OUT;
+ wsev.buf = (char*)buf;
+ wsev.len = len;
+ wsev.id = con->id;
+ evp.data = (void *)&wsev;
+ ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp);
+ tcpconn_put(con);
+ goto done;
+ } else {
+ LM_CRIT("used with invalid proto %d\n", dst->proto);
+ goto error;
+ }
+
+done:
+ return ret;
+error:
+ return -1;
+}
+
+#endif /* USE_TCP */
diff --git a/src/core/tcp_server.h b/src/core/tcp_server.h
index 0566c500dc..dac25bb152 100644
--- a/src/core/tcp_server.h
+++ b/src/core/tcp_server.h
@@ -13,8 +13,8 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
@@ -33,7 +33,7 @@ int tcp_send(struct dest_info* dst, union sockaddr_union* from,
int tcpconn_add_alias(int id, int port, int proto);
-
+int wss_send(dest_info_t* dst, const char* buf, unsigned len);
#endif
[View Less]
### Description
Monitoring extensions by using KA function from the usrloc module it's not working for ws contacts
#### Log Messages
```
Oct 8 16:51:20 devsrv devsrv[31562]: ERROR: usrloc [ul_keepalive.c:277]: ul_ka_send(): unknown proto [5] for sending keepalive
Oct 8 16:51:50 devsrv devsrv[31562]: DEBUG: usrloc [ul_keepalive.c:112]: ul_ka_urecord(): keepalive for aor: 101
Oct 8 16:51:50 devsrv devsrv[31562]: DEBUG: usrloc [ul_keepalive.c:236]: ul_ka_urecord(): keepalive request (len: …
[View More]323) [[#012OPTIONS sip:gehtfehm@eg4avcve63ua.invalid;transport=ws SIP/2.0#015#012Via: SIP/2.0/WS 192.168.0.11:443;branch=z9hG4bKx.4.1.0#015#012From: <sip:options@webrtc-gw.company.net>;tag=uloc-c-5f7f3503-7b52-1-9abde102-5f7f3596-44823-4.1#015#012To: <sip:101@webrtc-gw.company.net>#015#012Call-ID: ksrulka-4.1#015#012CSeq: 80 OPTIONS#015#012Content-Length: 0#015#012#015#012]]
Oct 8 16:51:50 devsrv devsrv[31562]: ERROR: usrloc [ul_keepalive.c:277]: ul_ka_send(): unknown proto [5] for sending keepalive
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.4.1 (x86_64/linux) a6cb74
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2502
[View Less]
Module: kamailio
Branch: master
Commit: 5e107824d684cdf30514b033e7f600862123ece5
URL: https://github.com/kamailio/kamailio/commit/5e107824d684cdf30514b033e7f6008…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-09T07:52:29+02:00
core: tcp - helper function to send data over ws/wss connection
---
Modified: src/core/tcp_main.c
Modified: src/core/tcp_server.h
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/5e107824d684cdf30514b033e7f6008…
Patch: https://github.com/kamailio/kamailio/commit/5e107824d684cdf30514b033e7f6008…
---
diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index f19f75a588..84fec376a3 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -95,6 +95,7 @@
#include "tcp_info.h"
#include "tcp_options.h"
#include "ut.h"
+#include "events.h"
#include "cfg/cfg_struct.h"
#include <fcntl.h> /* must be included after io_wait.h if SIGIO_RT is used */
@@ -5135,4 +5136,88 @@ void tcp_get_info(struct tcp_gen_info *ti)
#endif /* TCP_ASYNC */
}
+
+/* finds an ws/wss tcpconn & sends on it
+ * uses the dst members to, proto (ws/wss) and id and tries to send
+ * returns: number of bytes written (>=0) on success
+ * <0 on error */
+int wss_send(dest_info_t* dst, const char* buf, unsigned len)
+{
+ int port;
+ struct ip_addr ip;
+ union sockaddr_union* from = NULL;
+ union sockaddr_union local_addr;
+ struct tcp_connection *con = NULL;
+ struct ws_event_info wsev;
+ sr_event_param_t evp = {0};
+ int ret;
+
+ if (unlikely((dst->proto == PROTO_WS
+#ifdef USE_TLS
+ || dst->proto == PROTO_WSS
#endif
+ ) && sr_event_enabled(SREV_TCP_WS_FRAME_OUT))) {
+ if (unlikely(dst->send_flags.f & SND_F_FORCE_SOCKET
+ && dst->send_sock)) {
+
+ local_addr = dst->send_sock->su;
+#ifdef SO_REUSEPORT
+ if (cfg_get(tcp, tcp_cfg, reuse_port)) {
+ LM_DBG("sending to: %s, force_socket=%d, send_sock=%p\n",
+ su2a(&dst->to,sizeof(struct sockaddr_in)),
+ (dst->send_flags.f & SND_F_FORCE_SOCKET),
+ dst->send_sock);
+
+ su_setport(&local_addr, dst->send_sock->port_no);
+ }
+ else
+ su_setport(&local_addr, 0); /* any local port will do */
+#else
+ su_setport(&local_addr, 0); /* any local port will do */
+#endif
+ from = &local_addr;
+ }
+
+ port = su_getport(&dst->to);
+ if (likely(port)) {
+ su2ip_addr(&ip, &dst->to);
+ if(tcp_connection_match==TCPCONN_MATCH_STRICT) {
+ con = tcpconn_lookup(dst->id, &ip, port, from,
+ (dst->send_sock)?dst->send_sock->port_no:0, 0);
+ } else {
+ con = tcpconn_get(dst->id, &ip, port, from, 0);
+ }
+ }
+ else if (likely(dst->id))
+ con = tcpconn_get(dst->id, 0, 0, 0, 0);
+ else {
+ LM_CRIT("null_id & to\n");
+ goto error;
+ }
+
+ if (con == NULL) {
+ LM_WARN("TCP/TLS connection for WebSocket could not be found\n");
+ goto error;
+ }
+
+ memset(&wsev, 0, sizeof(ws_event_info_t));
+ wsev.type = SREV_TCP_WS_FRAME_OUT;
+ wsev.buf = (char*)buf;
+ wsev.len = len;
+ wsev.id = con->id;
+ evp.data = (void *)&wsev;
+ ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp);
+ tcpconn_put(con);
+ goto done;
+ } else {
+ LM_CRIT("used with invalid proto %d\n", dst->proto);
+ goto error;
+ }
+
+done:
+ return ret;
+error:
+ return -1;
+}
+
+#endif /* USE_TCP */
diff --git a/src/core/tcp_server.h b/src/core/tcp_server.h
index 0566c500dc..dac25bb152 100644
--- a/src/core/tcp_server.h
+++ b/src/core/tcp_server.h
@@ -13,8 +13,8 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
@@ -33,7 +33,7 @@ int tcp_send(struct dest_info* dst, union sockaddr_union* from,
int tcpconn_add_alias(int id, int port, int proto);
-
+int wss_send(dest_info_t* dst, const char* buf, unsigned len);
#endif
[View Less]
break large function
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main …
[View More]components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Each component has a single commit (if not, squash them into one commit)
#### Type Of Change
- [x] refactoring (non-breaking change which adds new functionality)
#### Description
This large function `ds_manage_routes` is quite large and the intent of every code block is becoming hard to read and assess.
In order to avoid mixing refactoring with behavioral modifications I thought it was best to make a separate MR.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2499
-- Commit Summary --
* dispatcher: ds_manage_routes refactoring
-- File Changes --
M src/modules/dispatcher/dispatch.c (111)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2499.patchhttps://github.com/kamailio/kamailio/pull/2499.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2499
[View Less]
Module: kamailio
Branch: master
Commit: 3f9210fc23840560c8fe33ef26b537aa32cbe6df
URL: https://github.com/kamailio/kamailio/commit/3f9210fc23840560c8fe33ef26b537a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-08T07:48:28+02:00
CONTRIBUTING.md: more content related to commit message format
---
Modified: .github/CONTRIBUTING.md
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]3f9210fc23840560c8fe33ef26b537a…
Patch: https://github.com/kamailio/kamailio/commit/3f9210fc23840560c8fe33ef26b537a…
---
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 9289eec2de..dac53f6d61 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -104,8 +104,15 @@ by the commit, for example:
* `modname`: support for foo rfc extension
* `usrloc`: support for gruu rfc extension
* `lib`: srutils - critical bug fix for abc case
+ * `etc`: kamailio.cfg - added core reply route block
+ * `misc`: examples/kemi lua - added debug callback function
* `kamctl`: added support for management of module xyz
+It is acceptable to use slightly different formats, like `etc/kamailio.cfg: ...`
+instead of `etc: kamailio.cfg - ...` or `modules/usrloc: ...` instead of
+`usrloc: ...`, the important aspect is to indicate the component where the
+changes were done.
+
At the end of the first line some CI flags can be added. Available at this
moment:
@@ -164,7 +171,7 @@ dialplan: basic safety for concurrent rpc reload
#### Commit Message Examples ####
- * change to usrloc module from modules
+ * changes to usrloc module from modules
```
usrloc: fixed name conflict
@@ -173,7 +180,7 @@ usrloc: fixed name conflict
with the usr_avp.h version
```
- * change to core
+ * changes to core
```
core: loadpath can now use a list of directories
@@ -183,6 +190,15 @@ core: loadpath can now use a list of directories
First match wins (e.g. for loadmodule "textops" if
modules/textops.so or modules/textops/textops.so exists, it will
be loaded and the search will stop).
+```
+
+ * changes to `etc/kamailio.cfg` file
+
+```
+etc: kamailio.cfg - set load_backends to 1 for permissions module
+
+- the config uses only address table
+
```
#### See Also ####
[View Less]
Module: kamailio
Branch: master
Commit: f78bc10dfc4b39ed3d5967b884202cb29cf834b8
URL: https://github.com/kamailio/kamailio/commit/f78bc10dfc4b39ed3d5967b884202cb…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-07T17:34:51+02:00
sqlops: docs for results_maxsize modparam
---
Modified: src/modules/sqlops/doc/sqlops_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]f78bc10dfc4b39ed3d5967b884202cb…
Patch: https://github.com/kamailio/kamailio/commit/f78bc10dfc4b39ed3d5967b884202cb…
---
diff --git a/src/modules/sqlops/doc/sqlops_admin.xml b/src/modules/sqlops/doc/sqlops_admin.xml
index 671fe79858..ef7756b9a5 100644
--- a/src/modules/sqlops/doc/sqlops_admin.xml
+++ b/src/modules/sqlops/doc/sqlops_admin.xml
@@ -212,6 +212,32 @@ modparam("sqlops", "tr_buf_size", 4096)
...
modparam("sqlops", "connect_mode", 1)
...
+</programlisting>
+ </example>
+ </section>
+ <section id="sqlops.results_maxsize">
+ <title><varname>results_maxsize</varname> (int)</title>
+ <para>
+ Set the upper limit of how many result containers are going to be
+ defined.
+ </para>
+ <para>
+ Note that a result container can be used for different SQL queries, it
+ is not required to have result container per SQL query. Use different
+ containers when the result records are needed at the same time (e.g.,
+ compare a field from one result with a field from another result).
+ </para>
+ <para>
+ <emphasis>
+ Default value is 32.
+ </emphasis>
+ </para>
+ <example>
+ <title>Set <varname>results_maxsize</varname> parameter</title>
+ <programlisting format="linespecific">
+...
+modparam("sqlops", "results_maxsize", 4096)
+...
</programlisting>
</example>
</section>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2430
-- Commit Summary --
* xhttp_prom: optional disabling of metrics deletion
-- File Changes --
M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (3)
M src/modules/xhttp_prom/prom_metric.c (12)
M src/modules/xhttp_prom/xhttp_prom.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2430.patchhttps://github.com/kamailio/kamailio/pull/2430.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2430
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Type Of Change
- [x] New feature (non-breaking change which adds new functionality)
#### Description
Add a configuration setting to preset latency estimator in dispatcher
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2492
-- Commit Summary --
* dispatcher: add an attribute to preset the
-- File Changes --
M src/modules/dispatcher/dispatch.c (27)
M src/modules/dispatcher/dispatch.h (2)
M src/modules/dispatcher/doc/dispatcher_admin.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2492.patchhttps://github.com/kamailio/kamailio/pull/2492.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2492
[View Less]
Module: kamailio
Branch: master
Commit: e8ce5cff74c3d53df361e42746bb4a7c1f8b6214
URL: https://github.com/kamailio/kamailio/commit/e8ce5cff74c3d53df361e42746bb4a7…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-06T22:31:12+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]e8ce5cff74c3d53df361e42746bb4a7…
Patch: https://github.com/kamailio/kamailio/commit/e8ce5cff74c3d53df361e42746bb4a7…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index a30d001f66..2d07fe7669 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -762,7 +762,8 @@ modparam("dispatcher", "ds_probing_mode", 1)
3.26. ds_ping_latency_stats (int)
- Enable latency measurement when pinging nodes
+ Enable latency measurement when pinging nodes The estimator can be
+ initialized at startup and reload using the attribute latency.
* If set to 0, disable latency measurement.
* If set to 1, enable latency measurement.
@@ -776,6 +777,9 @@ DEST: {
URI: sip:1.2.3.4
FLAGS: AX
PRIORITY: 9
+ ATTRS: {
+ BODY: latency=24
+ }
LATENCY: {
AVG: 24.250000 # weighted moving average for the last few weeks
STD: 1.035000 # standard deviation of AVG
@@ -1695,6 +1699,7 @@ kamctl rpc dispatcher.hash 4 bob server.com
overwrites the general ds_ping_from parameter.
* 'obproxy' - SIP URI of outbound proxy to be used when sending
pings. It overwrites the general ds_outbound_proxy parameter.
+ * 'latency' - latency_stats initialization in ms.
6.1.2. File Format
[View Less]
Module: kamailio
Branch: master
Commit: 48d0953b5fd1f6fed97ce6b016f05860b25cd97f
URL: https://github.com/kamailio/kamailio/commit/48d0953b5fd1f6fed97ce6b016f0586…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-06T12:58:01+02:00
core: parser - wrapper function to parse str header name
---
Modified: src/core/parser/parse_hname2.c
Modified: src/core/parser/parse_hname2.h
---
Diff: https://github.com/…
[View More]kamailio/kamailio/commit/48d0953b5fd1f6fed97ce6b016f0586…
Patch: https://github.com/kamailio/kamailio/commit/48d0953b5fd1f6fed97ce6b016f0586…
---
diff --git a/src/core/parser/parse_hname2.c b/src/core/parser/parse_hname2.c
index 598008214a..ab56fa4ea5 100644
--- a/src/core/parser/parse_hname2.c
+++ b/src/core/parser/parse_hname2.c
@@ -309,3 +309,9 @@ char* parse_hname2_short(char* const begin, const char* const end, struct hdr_fi
{
return parse_sip_header_name(begin, end, hdr, 0);
}
+
+char* parse_hname2_str (str* const hbuf, hdr_field_t* const hdr)
+{
+ return parse_sip_header_name(hbuf->s, hbuf->s + hbuf->len, hdr, 1);
+}
+
diff --git a/src/core/parser/parse_hname2.h b/src/core/parser/parse_hname2.h
index 9eef0bb53e..2c864857d6 100644
--- a/src/core/parser/parse_hname2.h
+++ b/src/core/parser/parse_hname2.h
@@ -15,13 +15,13 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
/*! \file
- * \brief Parser :: Fast 32-bit Header Field Name Parser
+ * \brief Parser :: Fast Header Field Name Parser
*
* \ingroup parser
*/
@@ -37,6 +37,7 @@
*/
char* parse_hname2(char* const begin, const char* const end, struct hdr_field* const hdr);
char* parse_hname2_short(char* const begin, const char* const end, struct hdr_field* const hdr);
+char* parse_hname2_str (str* const hbuf, hdr_field_t* const hdr);
int ksr_hname_init_index(void);
int ksr_hname_init_config(void);
[View Less]
Module: kamailio
Branch: master
Commit: d07b6c0d70795317920a6a0544bd83aca1fd0da3
URL: https://github.com/kamailio/kamailio/commit/d07b6c0d70795317920a6a0544bd83a…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-06T12:01:18+02:00
modules: readme files regenerated - nathelper ... [skip ci]
---
Modified: src/modules/nathelper/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]d07b6c0d70795317920a6a0544bd83a…
Patch: https://github.com/kamailio/kamailio/commit/d07b6c0d70795317920a6a0544bd83a…
---
diff --git a/src/modules/nathelper/README b/src/modules/nathelper/README
index 7398c702a5..79e43b73a7 100644
--- a/src/modules/nathelper/README
+++ b/src/modules/nathelper/README
@@ -525,16 +525,19 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
* flags - the value may be a bitwise OR of the following flags:
+ 0x01 - adds “a=direction:active” SDP line;
+ 0x02 - rewrite media IP address (c=) with source address of
- the message or the provided IP address (the provide IP address
- take precedence over the source address).
+ the message or the provided IP address. (a=rtpc) param will be
+ rewritten if exists. (the provided IP address take precedence
+ over the source address).
+ 0x04 - adds “a=nortpproxy:yes” SDP line;
+ 0x08 - rewrite IP from origin description (o=) with source
- address of the message or the provided IP address (the provide
- IP address take precedence over the source address).
+ address of the message or the provided IP address. (a=rtpc)
+ param will be rewritten if exists. (the provided IP address
+ take precedence over the source address).
* ip_address - IP to be used for rewriting SDP. If not specified, the
received signalling IP will be used. The parameter allows
pseudo-variables usage. NOTE: For the IP to be used, you need to
- use 0x02 or 0x08 flags, otherwise it will have no effect.
+ use 0x02 or 0x08 flags, otherwise it will have no effect. Must be
+ IPv4 address family.
This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE,
FAILURE_ROUTE, BRANCH_ROUTE.
[View Less]
- GH #2459
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x]…
[View More] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2459
#### Description
fix_nated_sdp() function with flags 0x02 and 0x08 and an IP address as argument (or without one) does modify the media line and the connection line. In addition it will modify IP address in "a=rtcp" parameter (rfc3605) in case if there is one. If a=rtcp param is not found the function doesn't return -1, but prints a DBG message and continues to execute (changing c= or o= lines)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2497
-- Commit Summary --
* nathelper: fix_nated_sdp added support for a=rtcp param RFC3605
-- File Changes --
M src/modules/nathelper/nathelper.c (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2497.patchhttps://github.com/kamailio/kamailio/pull/2497.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2497
[View Less]
Module: kamailio
Branch: master
Commit: 64579fee33d0a82a583b75184f78fcb7c9df2d82
URL: https://github.com/kamailio/kamailio/commit/64579fee33d0a82a583b75184f78fcb…
Author: Arsen Semenov <arsperger(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-06T11:51:24+02:00
nathelper: docs - updated notes for fix_nated_sdp. few typos fixed [skip ci]
---
Modified: src/modules/nathelper/doc/nathelper_admin.xml
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/64579fee33d0a82a583b75184f78fcb…
Patch: https://github.com/kamailio/kamailio/commit/64579fee33d0a82a583b75184f78fcb…
---
diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml
index c73baf21a4..6bf4783337 100644
--- a/src/modules/nathelper/doc/nathelper_admin.xml
+++ b/src/modules/nathelper/doc/nathelper_admin.xml
@@ -562,7 +562,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x02</emphasis> - rewrite media
&ip; address (c=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
<listitem>
@@ -572,7 +572,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
<listitem>
<para><emphasis>0x08</emphasis> - rewrite IP from
origin description (o=) with source address of the message
- or the provided IP address (the provide IP address take
+ or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take
precedence over the source address).</para>
</listitem>
</itemizedlist>
@@ -582,7 +582,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();};
If not specified, the received signalling IP will be used. The
parameter allows pseudo-variables usage. NOTE: For the IP to be
used, you need to use 0x02 or 0x08 flags, otherwise it will have
- no effect.
+ no effect. Must be IPv4 address family.
</para>
</listitem>
</itemizedlist>
[View Less]
Hello,
one question about a planned extension in the DMQ module. Right now the module supports only one server in the notification_address parameter. It is possible to set multi_notify to 1, and then the module will resolve the one sip URI over DNS to multiple servers, thought.
There is interest in extending the module to support multiple notification_address servers natively without using DNS. I see two options right now:
1. Separate the multiple servers, with ";", e.g. modparam("dmq", "…
[View More]notification_address", "sip:server1;sip:server2"). If only one server in the param, use the existing logic.
2. Use multiple notification_servers parameter calls, e.g. modparam("dmq", "notification_address") - modparam("dmq", "notification_address", "sip:server2<sip:server1;sip:server2>"). If only one param statement, use the existing logic.
As the module already has support to use a notification server list internally, the change should be small in both cases.
I think option 1) is the better way, as its already done in other modules like this to support multiple server scenarios.
Any comments or objections about this extension?
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>
[View Less]
Hi gang,
As of today, rtpengine adds support for HTTP and WebSocket interfaces
(as well as HTTPS and WSS). Currently supported operations are accessing
the CLI commands provided by the `rtpengine-ctl` CLI tool, and accessing
the "NG" control protocol. These are both 1-to-1 mappings on top of the
existing interfaces, just with a different transport protocol on top,
which doesn't make for a pretty RESTful interface, but should otherwise
be perfectly usable. It can also be further extended …
[View More]if necessary, with
some additional operations already planned. There's a bit more detail at
https://github.com/sipwise/rtpengine#httpwebsocket-support
The "NG" protocol support in particular should be interesting to those
who keep having problems with the UDP transport of the existing
protocol, due to packet loss or MTU issues or otherwise. This makes it
possible to switch the transport protocol to HTTP or WS while retaining
full compatibility with the existing control protocol. This isn't
currently implemented in the Kamailio module for rtpengine, but if
someone feels like giving it a shot, then by all means feel free. It may
also be of interest to those who want to control rtpengine from JS etc
for example.
Cheers
Richard
[View Less]
K master has recently crashed several times on Debian 10. Could this have
something to do with openssl libs?
-- Juha
Oct 5 08:32:21 lohi systemd[1]: Stopping LSB: Start/stop OpenSIPg SIP Proxy...
Oct 5 08:32:21 lohi sip-proxy[19922]: Stopping sip-proxy
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30820]: NOTICE: <core> [main.c:735]: handle_sigs(): Thank you for flying sip-proxy!!!
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30860]: INFO: <core> [main.c:857]: sig_usr(): signal 15 …
[View More]received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30859]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30858]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30857]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30853]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30856]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30850]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30854]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30834]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30847]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30852]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30849]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30851]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30841]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30830]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30848]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30846]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30836]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30827]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30844]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30845]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30833]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30842]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30839]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30829]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30822]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30840]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30838]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30826]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30837]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30824]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30835]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30823]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30832]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30831]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30828]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30843]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30825]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30821]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30855]: INFO: <core> [main.c:857]: sig_usr(): signal 15 received
Oct 5 08:32:21 lohi /usr/bin/sip-proxy[30820]: INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized
Oct 5 08:32:21 lohi kernel: [176646.851504] sip-proxy[30820]: segfault at 7f84196c7730 ip 00007f8421adce26 sp 00007ffde899c0f0 error 4 in libcrypto.so.1.1[7f84219d8000+19e000]
Oct 5 08:32:21 lohi kernel: [176646.851513] Code: 1f 44 00 00 c7 05 9a d9 15 00 01 00 00 00 c7 05 8c d9 15 00 01 00 00 00 c3 66 66 2e 0f 1f 84 00 00 00 00 00 48 85 ff 74 5b 53 <8b> 0f 48 89 fb 85 c9 75 29 8b 53 04 85 d2 75 2e 8b 43 08 85 c0 75
(gdb) where
#0 0x00007f8421adce26 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#1 0x00007f8421add12f in OPENSSL_cleanup () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#2 0x00007f8423a87d8c in __run_exit_handlers (status=0, listp=0x7f8423c09718 <__exit_funcs>,
run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
#3 0x00007f8423a87eba in __GI_exit (status=<optimized out>) at exit.c:139
#4 0x000055d40be7bb61 in handle_sigs () at main.c:738
#5 0x000055d40be88966 in main_loop () at main.c:1817
#6 0x000055d40be91e32 in main (argc=17, argv=0x7ffde899c948) at main.c:2861
[View Less]
Hi Christoph,
I'd say with the usual process. Create a pull request to integrate your developed enhancements to the module. In case of questions or different implementation options ask/discuss before on sr-dev list.
If you do not want to develop it by yourself, you can create a feature request, or you can also approach one of the companies that offer Kamailio services.
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.…
[View More]com/>
From: Valentin Christoph <Christoph.Valentin(a)kontron.com>
Sent: Saturday, October 3, 2020 5:41 PM
To: Henning Westerholt <hw(a)skalatan.de>; Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org>
Cc: Onic Roman <Roman.Onic(a)kontron.com>; Friedrich Peter <Peter.Friedrich(a)kontron.com>
Subject: RE: xcap_client: storage of document in local DB
Hello Henning,
Thank you. I will try to workaround these shortcomings.
If it turns out I need some new feature(s) from the xcap_client, then what would be the recommended proceeding?
Kr
Christoph
-------- Ursprüngliche Nachricht --------
Von: Henning Westerholt <hw(a)skalatan.de<mailto:hw@skalatan.de>>
Datum: 03.10.20 15:04 (GMT+01:00)
An: "Kamailio (SER) - Users Mailing List" <sr-users(a)lists.kamailio.org<mailto:sr-users@lists.kamailio.org>>
Cc: Onic Roman <Roman.Onic(a)kontron.com<mailto:Roman.Onic@kontron.com>>, Friedrich Peter <Peter.Friedrich(a)kontron.com<mailto:Peter.Friedrich@kontron.com>>, Valentin Christoph <Christoph.Valentin(a)kontron.com<mailto:Christoph.Valentin@kontron.com>>
Betreff: RE: xcap_client: storage of document in local DB
Hello Christoph,
this is the API from the code:
typedef struct xcap_api {
xcap_nodeSel_init_t int_node_sel;
xcap_nodeSel_add_step_t add_step;
xcap_nodeSel_add_terminal_t add_terminal;
xcap_nodeSel_free_t free_node_sel;
xcapGetNewDoc_t getNewDoc;
register_xcapcb_t register_xcb;
}xcap_api_t;
So the get_elem seems to be not implemented. About the other question, it seems to not call the delete API from the database layer either.
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fskalatan.…>
Kamailio services - https://gilawa.com<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgilawa.co…>
From: sr-users <sr-users-bounces(a)lists.kamailio.org<mailto:sr-users-bounces@lists.kamailio.org>> On Behalf Of Valentin Christoph
Sent: Saturday, October 3, 2020 2:36 PM
To: sr-users(a)lists.kamailio.org<mailto:sr-users@lists.kamailio.org>
Cc: Onic Roman <Roman.Onic(a)kontron.com<mailto:Roman.Onic@kontron.com>>; Friedrich Peter <Peter.Friedrich(a)kontron.com<mailto:Peter.Friedrich@kontron.com>>
Subject: [SR-Users] xcap_client: storage of document in local DB
Hi all,
Does anybody know, when the xcap_client deletes a registered document from the database? Is it possible to deregister a document?
Are you sure, the documented get_elem API function is actually implemented?
All the best
Christoph
[View Less]
Module: kamailio
Branch: master
Commit: 9b6243d20a4dd27e44c6f7bada757226c6f4aa63
URL: https://github.com/kamailio/kamailio/commit/9b6243d20a4dd27e44c6f7bada75722…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-02T21:46:11+02:00
modules: readme files regenerated - phonenum ... [skip ci]
---
Modified: src/modules/phonenum/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]9b6243d20a4dd27e44c6f7bada75722…
Patch: https://github.com/kamailio/kamailio/commit/9b6243d20a4dd27e44c6f7bada75722…
---
diff --git a/src/modules/phonenum/README b/src/modules/phonenum/README
index ebe872869b..096a3efa4b 100644
--- a/src/modules/phonenum/README
+++ b/src/modules/phonenum/README
@@ -161,6 +161,13 @@ if(phonenum_match("1-484-555-8888", "src")) {
letter, e.g: "DE", "US", "ES"). The function has to be called before
accessing a key via: $phn(pvc=>key).
+ Note from libphonenumber library docs: country name code is the region
+ that is expected the number to be from. It is only used if the number
+ being parsed is not written in international format. The country code
+ for the number in this case would be stored as that of the region
+ supplied. If the number is guaranteed to start with a '+' followed by
+ the country calling code, then region 'ZZ'.
+
The parameters can be static strings or strings with variables.
It can be used from ANY_ROUTE.
[View Less]
### Description
Parsing a number using `phonenum_match_cn()` doesn't honor the country code filter.
#### Reproduction
I have the following in code:
```
if (phonenum_match_cn("$fU", "PA", "src")) {
if($phn(src=>valid)==1) {
xlog("L_NOTICE", "Caller is type: (V=$phn(src=>valid) | N=$phn(src=>number) | NN=$phn(src=>normalized) | CC=$phn(src=>cctel) | ISO=$phn(src=>ccname) | T=$phn(src=>ltype) | D=$phn(src=>ndesc))\n");
return;
…
[View More]}
}
```
Using `+15162085XXX` as an example, I'm getting the following when passing that snippet of code:
```
Oct 1 19:31:11 sbc01 sbc[17850]: NOTICE: {1 102 INVITE 05d2e55e06832c71060e69b630cd5c6d(a)A.B.C.D} <script>: Caller is type: (V=1 | N=+15162085XXX | NN=+15162085XXX | CC=1 | ISO=US | T=fixed-line-or-mobile | D=New York)
```
I would expect this case to return `$phn(src=>valid)=0`
### Additional Information
* **Kamailio version**:
```
version: kamailio 5.4.1 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 6.3.0
```
* **Operating System**:
```
Distributor ID: Debian
Description: Debian GNU/Linux 9.13 (stretch)
Release: 9.13
Codename: stretch
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2495
[View Less]
Module: kamailio
Branch: master
Commit: dfd6c3966ed70d111a9196076bc29767c395d814
URL: https://github.com/kamailio/kamailio/commit/dfd6c3966ed70d111a9196076bc2976…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T21:38:16+02:00
phonenum: note about the role of country code name for phonenum_match_cn()
---
Modified: src/modules/phonenum/doc/phonenum_admin.xml
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/dfd6c3966ed70d111a9196076bc2976…
Patch: https://github.com/kamailio/kamailio/commit/dfd6c3966ed70d111a9196076bc2976…
---
diff --git a/src/modules/phonenum/doc/phonenum_admin.xml b/src/modules/phonenum/doc/phonenum_admin.xml
index d30c2026ee..f3a3e98ede 100644
--- a/src/modules/phonenum/doc/phonenum_admin.xml
+++ b/src/modules/phonenum/doc/phonenum_admin.xml
@@ -156,6 +156,14 @@ if(phonenum_match("1-484-555-8888", "src")) {
(two letter, e.g: "DE", "US", "ES"). The function has to be called
before accessing a key via: $phn(pvc=>key).
</para>
+ <para>
+ Note from libphonenumber library docs: country name code is the region
+ that is expected the number to be from. It is only used if the number
+ being parsed is not written in international format. The country code
+ for the number in this case would be stored as that of the region
+ supplied. If the number is guaranteed to start with a '+' followed
+ by the country calling code, then region 'ZZ'.
+ </para>
<para>
The parameters can be static strings or strings with variables.
</para>
[View Less]
Hello,
Kamailio SIP Server v5.2.8 stable release is out.
This is a maintenance release of the old stable branch (5.2), that includes fixes since the release of v5.2.7. There are no change to database schema or configuration language structure that you have to do on previous installations of v5.2.x. Unless major regressions are discovered after the release, this will be the last release of the 5.2 stable branch. The current stable branches 5.3 and 5.4 will continue to be maintained.
…
[View More]Deployments running previous v5.2.x versions are strongly recommended to be upgraded to v5.2.8.
For more details about version 5.2.8 (including links and guidelines to download the tar file or from GIT repository), visit:
https://www.kamailio.org/w/2020/10/kamailio-5-2-8-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>
[View Less]
Module: kamailio
Branch: 5.3
Commit: 513d8132869b4eac320b9f20a2a46779073db434
URL: https://github.com/kamailio/kamailio/commit/513d8132869b4eac320b9f20a2a4677…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2020-10-02T18:16:36+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/ims_charging/README
Modified: src/modules/sqlops/README
Modified: src/modules/topos/README
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/513d8132869b4eac320b9f20a2a4677…
Patch: https://github.com/kamailio/kamailio/commit/513d8132869b4eac320b9f20a2a4677…
---
diff --git a/src/modules/ims_charging/README b/src/modules/ims_charging/README
index 5c9fa52558..b4668674da 100644
--- a/src/modules/ims_charging/README
+++ b/src/modules/ims_charging/README
@@ -571,7 +571,7 @@ modparam("ims_charging", "destination_host", "ocs.kamailio-ims.org")
Destination realm to be used in Diameter messages to charging-server.
- Default value is "ims.smilecoms.com".
+ Default value is "".
Example 1.16. destination_realmparameter usage
...
diff --git a/src/modules/sqlops/README b/src/modules/sqlops/README
index 7d68e3b63b..b2c74a2fb9 100644
--- a/src/modules/sqlops/README
+++ b/src/modules/sqlops/README
@@ -211,6 +211,8 @@ modparam("sqlops", "connect_mode", 1)
* -1 - error in parameters or query execution
* 1 - query successful, at least one row in resultset (for SELECTs)
* 2 - query successful, no rows returned
+ 3 - query successful, at least one row returned, but result
+ parameter was not given
4.1. sql_query(connection, query[, result])
diff --git a/src/modules/topos/README b/src/modules/topos/README
index fd4108765c..ab4020931c 100644
--- a/src/modules/topos/README
+++ b/src/modules/topos/README
@@ -86,17 +86,21 @@ Chapter 1. Admin Guide
1. Overview
- This module offers topology hiding by stripping the SIP routing headers
- that show topology details. The script interpreter gets the SIP
- messages with full content, so all existing functionality is preserved.
+ This module offers topology hiding for INVITE-based dialogs, by
+ stripping the SIP routing headers that show topology details . The
+ script interpreter gets the SIP messages with full content, so all
+ existing functionality is preserved.
The module is transparent for the configuration writer. It only needs
- to be loaded (tune the parameters if needed).
+ to be loaded (tune the module parameters if needed).
It also works for SIP MESSAGE or other requests that do not create a
- call dialog -- record_route() must be used for them as well, the
- headers are not going to be in the messages sent to the network, they
- are needed to know local addresses used to communicate with each side.
+ dialog -- record_route() must be used for them as well, the headers are
+ not going to be in the messages sent to the network, they are needed to
+ know local addresses used to communicate with each side. At this moment
+ it is not designed to work for presence (SUBSCRIBE-based) dialogs. The
+ REGISTER and PUBLISH requests are skipped from processing by this
+ module, expected to be terminated on a local SIP server.
2. Dependencies
[View Less]
- URL: https://github.com/kamailio/kamailio/commit/c6d6c76f37f1bba607a67f5b38ee0b2…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:20:13Z
dialog: fix error in debug logging, properly log both sockets
(cherry picked from commit 6b27844460e0de475d9546db122ff1ba9d9be6d8)
- URL: https://github.com/kamailio/kamailio/commit/3382a6a13d3e072b834af4a4edbde73…
Author: Torrey Searle <tsearle(a)voxbone.com>
Date: 2020-10-02T15:21:22Z
tools/kemi: add support for …
[View More]invoking function pointers
also add a flag to allow generated version of code to be compatible
with older versions of python3
(cherry picked from commit 773ecfc9ceec5bbbe6c7f5fd72399baacfd74c0a)
- URL: https://github.com/kamailio/kamailio/commit/e7a390388fe640d46efc640e97a87f0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:24:06Z
evapi: free addr info in case of bind error
(cherry picked from commit 41db985ebfcb691f2e20e689a83379e382ef6c03)
- URL: https://github.com/kamailio/kamailio/commit/7640e7c38df8c213210487f9379cd76…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:27:55Z
pua: docs - fixed missing comma in example
- picked from #2371
(cherry picked from commit 9adccda325d258fe539b54ec67d4389d3a2fc72c)
- URL: https://github.com/kamailio/kamailio/commit/96e406c046d625995e5887a065a6a8c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:28:54Z
siputils: docs - added section ids for parameters
(cherry picked from commit ec0b1d31f1d667abdcd7cce7fbfff110583e271c)
- URL: https://github.com/kamailio/kamailio/commit/d054df58128e23516f526e4eab4a3d6…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:29:18Z
ims_charging: fix error in destination_realm default vaulue
(cherry picked from commit f679c118a589c80cb84954fb46271adef596e049)
- URL: https://github.com/kamailio/kamailio/commit/35132a64f4a60df23e03a8be1e68197…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:31:23Z
ims_charging: bugfix for destination_host parameter, implementation was incomplete
(cherry picked from commit f5e44252c39c7695cb66893035a0581a65a72f91)
- URL: https://github.com/kamailio/kamailio/commit/d2377eea2798561128bfb299f7f01d6…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:31:45Z
ims_charging: add missing change for ccr.c (related to previous commit f5e44252c39c7695cb)
(cherry picked from commit 4cb61cc35a695e2636007f6518a63ed8e508b67f)
- URL: https://github.com/kamailio/kamailio/commit/4b7cd8149d1588efbd94bc6f30a9864…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:32:42Z
ims_charging: bugfix for tel URIs, need the same logic in stop as in start requests
(cherry picked from commit c3efb3b3331936a30f387e9f3c8c435d4d64f0bb)
- URL: https://github.com/kamailio/kamailio/commit/78cc2c04fc43f44619f311b0d10ac10…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:36:10Z
ims_charging: fix wrong default User-Equipment-Info-Type AVP format
- fix User-Equipment-Info-Type AVP format
According to the RFC 8506 it should be like this: The 48-bit Media Access
Control (MAC) address is formatted as described in Section 3.21 of [RFC3580]
- use strlen instead of sizeof
(cherry picked from commit 1a8f54147063560f6016634152b17293394b8497)
(cherry picked from commit d51a3c4393b345b783adccf8a0e960274e11afb2)
- URL: https://github.com/kamailio/kamailio/commit/3195b85910e3e834ae03e59d20e411b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:37:22Z
misc/examples: kemi lua - added debug callback function
- commented - can be enabled to track the execution trace of the lua
script
(cherry picked from commit 491a8327933cb4471260fdd09ff93296a7a0ccfd)
- URL: https://github.com/kamailio/kamailio/commit/83a357f8d6a3a8a0e2b6de6ac742383…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:41:08Z
tls: docs - fixed typo
- GH #2410
(cherry picked from commit a12064696ac37cadf954a89b58daa1e05e182180)
- URL: https://github.com/kamailio/kamailio/commit/b3b06a9c0329f01f8c9351cc56a146e…
Author: Sergey Safarov <s.safarov(a)gmail.com>
Date: 2020-10-02T15:41:16Z
pkg/kamailio/obs: spec formating
(cherry picked from commit 56bb276b4e5c00843244d555e7c5221e3f2a6203)
- URL: https://github.com/kamailio/kamailio/commit/12e310f3757fd2e194267977579e5d3…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:42:25Z
dialog: print old state on dlg timeout
(cherry picked from commit 06b7e416756e1711edef6db683cef35824f4b2a5)
- URL: https://github.com/kamailio/kamailio/commit/f82bdb7fadd02368133b4813cdba515…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:42:57Z
xcap_server: check before going to the end of the buffer
- use marcros to set and restore char for ending 0
(cherry picked from commit 6ce5c0bdf136ecffd7917f2d60093e1b2c49fa54)
- URL: https://github.com/kamailio/kamailio/commit/8ac4f388f835ef182bf1d05d4555025…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:43:18Z
db_text: free pointer in case of error
(cherry picked from commit bddf16db74ea779bb01805fc2cbabfdaf8f4d62b)
- URL: https://github.com/kamailio/kamailio/commit/36a3c1f47f54e58f41ed5b302bd4bce…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:43:35Z
Makefile.defs: get clang version only from --version output
- the full version with stderr output included has a different first
line on MacOS, making head -n 1 not extract the version number line
(cherry picked from commit bff689cfedca70149e17b6ec3584ca9ecab71418)
- URL: https://github.com/kamailio/kamailio/commit/92ddff8921ef0b035d1d785e87f3f44…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:44:08Z
Makefile.defs: map gcc v10.x to 9.0+ options
- detect properly the 10.x gcc version number, GH #2425
(cherry picked from commit 79e7738027a40affa4c7f606bf55a3ad0fe31bc4)
- URL: https://github.com/kamailio/kamailio/commit/814fcce6c46671b84bf67d6db7317a0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:45:50Z
pike: docs - section for pike.list rpc command
(cherry picked from commit 720e929a87c6d3ee29c316ca63886c7142320f43)
- URL: https://github.com/kamailio/kamailio/commit/72bf4a6c9e768d2ab1c2d9eb4c80c6e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:46:13Z
topoh: check if via param has the expected prefix, otherwise skip
- GH #2437
(cherry picked from commit 046126b4a90090bf5b8f9b517ba5218793e6b973)
- URL: https://github.com/kamailio/kamailio/commit/3d4bcb4a386bc9387053779e1f692eb…
Author: Dmitry <dmitry.wagin(a)ya.ru>
Date: 2020-10-02T15:47:32Z
Makefile.defs: Fixed libs option for FreeBSD
(cherry picked from commit f490c4e0f5888963a01fa99fe94a464d44223199)
- URL: https://github.com/kamailio/kamailio/commit/b046d031006627eec4acfd9dd8fbf05…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:48:29Z
log_custom: print to stderror if sending log message fails
- help troubleshooting while avoiding looping to same function in case
the log engine is set to log custom module
(cherry picked from commit f16d046f6330f897b374d9bb7dab3b2ce8eab3a7)
- URL: https://github.com/kamailio/kamailio/commit/f8b67668b35008f86435a5e3d9f2ae6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:48:47Z
topoh: remove the Via cookie when skipping topoh via event route
- event route is now executed with parsed sip message to be sent out
- GH #2437
(cherry picked from commit 06a1d20fdcae42c8f2130c547c6c6cf5fb6dce26)
- URL: https://github.com/kamailio/kamailio/commit/1d0f0bcee0f51d62a506935924f3316…
Author: Juha Heinanen <jh(a)tutpro.com>
Date: 2020-10-02T15:50:22Z
sqlops module: added one more sql query function return value to README
(cherry picked from commit d93de03c10eb7b88024d7eb9ba85200601cf6c7a)
- URL: https://github.com/kamailio/kamailio/commit/3ce17b3ba01104ebd0789f25ff950e1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:50:38Z
usrloc: get_udomain() - safety checks for location table name parameter
(cherry picked from commit 29dde9fea1eb21b4bb484286f7443dd32f611bd2)
- URL: https://github.com/kamailio/kamailio/commit/7755d876d0f300daf9563b57793a17e…
Author: Federico Cabiddu <federico.cabiddu(a)gmail.com>
Date: 2020-10-02T15:53:16Z
httpa_asyc_client: set curl memory callbacks in module initialization
(cherry picked from commit 66fea7c615e01b200b334d5255c90911cfb360fe)
- URL: https://github.com/kamailio/kamailio/commit/e01b3652c9112b98d037fc4dbc54fe8…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:53:54Z
msrp: proper parsing ipv6 host part in uri
- enclose ipv6 address in square brackets for msrp pv
- related to #2472
(cherry picked from commit 1cda029885dd89e2ec46fe28a0d6f656aad19e7a)
- URL: https://github.com/kamailio/kamailio/commit/773f6f48b3c638fd812edebe5303d70…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:56:43Z
docs: add matrix channel information to normal and github READMEs
(cherry picked from commit 3c19ca90327d92be69cdce482e66991147db9083)
- URL: https://github.com/kamailio/kamailio/commit/35df241a87766f4a7ccdbea25731355…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:58:09Z
dispatcher: sync on updating last used fields
(cherry picked from commit e307432e5f34a2093544e9ff703ea205169e4088)
- URL: https://github.com/kamailio/kamailio/commit/aac6c00202aeebe8a13e9d33ca96277…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:58:48Z
topos: docs - more details about what SIP traffic is handled
(cherry picked from commit 878971f2c0bc32233b6f18728f9b88537b3d19e8)
- URL: https://github.com/kamailio/kamailio/commit/0d0085cfe871208af4a4f7f4a4c4ea0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:59:02Z
lib/srdb1: db_use_table() more suggestive error messages
(cherry picked from commit 57d33a2d76219ae3d1eb503044dadaeddc7e06fd)
- URL: https://github.com/kamailio/kamailio/commit/8988b12dee467bfd5ba1a6d3aaef13a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:59:40Z
tmx: safety check of expected route blocks for using $T_*() variables
- related to GH #2479
(cherry picked from commit 2e7710e292a649c6c57e46d5994d3b2cf3815865)
- URL: https://github.com/kamailio/kamailio/commit/7f37dfe943e49625afcd51ca8de3214…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T16:00:27Z
usrloc: use unsigned int for rpc output for the fields having this type
(cherry picked from commit b754b9f68bee0b58b4ae00b7f0764c2bf711d14c)
- URL: https://github.com/kamailio/kamailio/commit/ac95ed9c1a24dbedf4e197a02580880…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2020-10-02T16:01:12Z
ndb_redis: set message level to debug on exec
* logging error makes no sense here since there's going
to be a reconnection afterwards
> ERROR: ndb_redis [redis_client.c:903]: redisc_exec_argv(): Redis error: Server closed the connection
(cherry picked from commit a9c331d70dbed6827874aa99296203ac5a9d5c7b)
- URL: https://github.com/kamailio/kamailio/commit/61c88b527d9f58154a5a884fab1bcd5…
Author: Julien Chavanton <jchavanton(a)gmail.com>
Date: 2020-10-02T16:01:46Z
dispatcher: fix an error in initialisation /
training of the latency estimator
(cherry picked from commit b728cb30810ef44b821a93335cdd34f954f2029c)
- URL: https://github.com/kamailio/kamailio/commit/5a034b5b5a1e45e2c91ccf70db0b8b2…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T16:04:55Z
rr: reset param buffer for r-r advertised address
- GH #2486
(cherry picked from commit 8dfc0f6ef0ddc4bf2d73d21124caa289d4b8ce07)
[View Less]
- URL: https://github.com/kamailio/kamailio/commit/0a159176f14024224604f88da3a78c2…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:20:22Z
dialog: fix error in debug logging, properly log both sockets
(cherry picked from commit 6b27844460e0de475d9546db122ff1ba9d9be6d8)
- URL: https://github.com/kamailio/kamailio/commit/469e0895cc8af8b9215cf6e1672860d…
Author: Torrey Searle <tsearle(a)voxbone.com>
Date: 2020-10-02T15:21:18Z
tools/kemi: add support for …
[View More]invoking function pointers
also add a flag to allow generated version of code to be compatible
with older versions of python3
(cherry picked from commit 773ecfc9ceec5bbbe6c7f5fd72399baacfd74c0a)
- URL: https://github.com/kamailio/kamailio/commit/4a56a8b780744d9ba35a94afbd5226b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:24:20Z
evapi: free addr info in case of bind error
(cherry picked from commit 41db985ebfcb691f2e20e689a83379e382ef6c03)
- URL: https://github.com/kamailio/kamailio/commit/939a97859d6e32346ef4c001eaff227…
Author: Emmanuel Schmidbauer <eschmidbauer(a)gmail.com>
Date: 2020-10-02T15:26:50Z
mohqueue: use t_newtran() if transaction does not exist
(cherry picked from commit 6b708e937d161101adc91a4de5a527bf190b55c0)
- URL: https://github.com/kamailio/kamailio/commit/50ce889a9556c169276e14df2a66fe6…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:29:30Z
ims_charging: fix error in destination_realm default vaulue
(cherry picked from commit f679c118a589c80cb84954fb46271adef596e049)
- URL: https://github.com/kamailio/kamailio/commit/c888cc7de7a3509c7ce0c2d2378236e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:37:18Z
misc/examples: kemi lua - added debug callback function
- commented - can be enabled to track the execution trace of the lua
script
(cherry picked from commit 491a8327933cb4471260fdd09ff93296a7a0ccfd)
- URL: https://github.com/kamailio/kamailio/commit/288d760f8f11e4028ccd56f4941a19e…
Author: lazedo <luis.azedo(a)factorlusitano.com>
Date: 2020-10-02T15:39:26Z
websocket: emit core event on close
(cherry picked from commit 16914788ba49b69aaabc8e75ca9b5d95dce6b825)
- URL: https://github.com/kamailio/kamailio/commit/684eb554a969800ea892502720a15a1…
Author: Juha Heinanen <jh(a)tutpro.com>
Date: 2020-10-02T15:50:14Z
sqlops module: added one more sql query function return value to README
(cherry picked from commit d93de03c10eb7b88024d7eb9ba85200601cf6c7a)
- URL: https://github.com/kamailio/kamailio/commit/b213cf8f2bab6015dcc9ea01f835e24…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:53:50Z
msrp: proper parsing ipv6 host part in uri
- enclose ipv6 address in square brackets for msrp pv
- related to #2472
(cherry picked from commit 1cda029885dd89e2ec46fe28a0d6f656aad19e7a)
- URL: https://github.com/kamailio/kamailio/commit/f014dd7fc45743685723c02aaad96dd…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:55:13Z
kex: use mutex to sync the mod mem stats rpc commands
- related to GH #2433
(cherry picked from commit 761eb0616fea2a859a2c0abb652b22feb6f59859)
- URL: https://github.com/kamailio/kamailio/commit/866783ab976295cc0eb3e5278bd6446…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:56:39Z
docs: add matrix channel information to normal and github READMEs
(cherry picked from commit 3c19ca90327d92be69cdce482e66991147db9083)
- URL: https://github.com/kamailio/kamailio/commit/f42cebc8cff141e40a04c5c15a1e3cb…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:57:35Z
dispatcher: sync on updating last used fields
(cherry picked from commit e307432e5f34a2093544e9ff703ea205169e4088)
- URL: https://github.com/kamailio/kamailio/commit/afd52699ad2289e1b003e3b65e91a41…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:58:44Z
topos: docs - more details about what SIP traffic is handled
(cherry picked from commit 878971f2c0bc32233b6f18728f9b88537b3d19e8)
- URL: https://github.com/kamailio/kamailio/commit/c75bf4451d6dd090963e6b16d5ec821…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:59:17Z
lib/srdb1: db_use_table() more suggestive error messages
(cherry picked from commit 57d33a2d76219ae3d1eb503044dadaeddc7e06fd)
- URL: https://github.com/kamailio/kamailio/commit/90af4f0b572636bfdd3a99c28c66153…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T15:59:27Z
tmx: safety check of expected route blocks for using $T_*() variables
- related to GH #2479
(cherry picked from commit 2e7710e292a649c6c57e46d5994d3b2cf3815865)
- URL: https://github.com/kamailio/kamailio/commit/bc452ca5c13c592c1387192baac0970…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T16:00:16Z
usrloc: use unsigned int for rpc output for the fields having this type
(cherry picked from commit b754b9f68bee0b58b4ae00b7f0764c2bf711d14c)
- URL: https://github.com/kamailio/kamailio/commit/faec948f619325a47053d46c55b0acb…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-10-02T16:00:44Z
imc: jump over printing error log messages when list commands are ok
- reported by GH #2481
(cherry picked from commit 92cfb5e8d291706889c926892397e663e2d93b05)
- URL: https://github.com/kamailio/kamailio/commit/081fb695ca8d50c0d61c33aa3d82530…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2020-10-02T16:01:02Z
ndb_redis: set message level to debug on exec
* logging error makes no sense here since there's going
to be a reconnection afterwards
> ERROR: ndb_redis [redis_client.c:903]: redisc_exec_argv(): Redis error: Server closed the connection
(cherry picked from commit a9c331d70dbed6827874aa99296203ac5a9d5c7b)
- URL: https://github.com/kamailio/kamailio/commit/d7fcb51c8d5a871fdd27e2d1918bfde…
Author: Julien Chavanton <jchavanton(a)gmail.com>
Date: 2020-10-02T16:01:30Z
dispatcher: fix an error in initialisation /
training of the latency estimator
(cherry picked from commit b728cb30810ef44b821a93335cdd34f954f2029c)
- URL: https://github.com/kamailio/kamailio/commit/c27c0e3dcd0171ab62ea2ce7f3ca03d…
Author: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T16:12:20Z
Revert "kex: use mutex to sync the mod mem stats rpc commands"
This reverts commit f014dd7fc45743685723c02aaad96ddd35e10536.
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Remove consecutive ocurrences of 'the' across the repo
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2491
-- Commit Summary --
* Fix typos: Remove consecutive occurrences of 'the'
-- File Changes --
M README.md (2)
M src/lib/srdb1/schema/carrierfailureroute.xml (2)
M src/modules/app_jsdt/duktape.c (4)
M src/modules/avp/avp.xml (2)
M src/modules/carrierroute/README (2)
M src/modules/carrierroute/doc/carrierroute_db.xml (2)
M src/modules/counters/counters.c (4)
M src/modules/cplc/README (4)
M src/modules/db_mongodb/README (2)
M src/modules/db_mongodb/doc/db_mongodb_admin.xml (2)
M src/modules/drouting/README (2)
M src/modules/drouting/doc/drouting_admin.xml (2)
M src/modules/ims_qos/rx_aar.c (2)
M src/modules/sca/NOTES (2)
M src/modules/tm/README (2)
M src/modules/tm/doc/functions.xml (2)
M src/modules/tm/t_reply.c (2)
M src/modules/websocket/README (2)
M src/modules/xmpp/README (2)
M src/modules/xmpp/doc/xmpp_admin.xml (2)
M test/travis/README.md (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2491.patchhttps://github.com/kamailio/kamailio/pull/2491.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2491
[View Less]
Module: kamailio
Branch: 5.4
Commit: 27f28271981e46ea9abec97392ab3232264c742f
URL: https://github.com/kamailio/kamailio/commit/27f28271981e46ea9abec97392ab323…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on xmpp module: Consecutives 'the'
---
Modified: src/modules/xmpp/doc/xmpp_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/27f28271981e46ea9abec97392ab323…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/27f28271981e46ea9abec97392ab323…
---
diff --git a/src/modules/xmpp/doc/xmpp_admin.xml b/src/modules/xmpp/doc/xmpp_admin.xml
index ab201c5a84..129acbc423 100644
--- a/src/modules/xmpp/doc/xmpp_admin.xml
+++ b/src/modules/xmpp/doc/xmpp_admin.xml
@@ -230,7 +230,7 @@
<para>
The domain of the SIP-to-XMPP gateway - it has to be in DNS or SIP UA has to
use outbound proxy to SIP-to-XMPP gateway IP address. It has to be used
- as domain in the the destination address of the messages sent by SIP users
+ as domain in the destination address of the messages sent by SIP users
to XMPP users:
"sip:username<![CDATA[<]]>delim<![CDATA[>]]>jabber_server@gateway_domain".
</para>
[View Less]
Module: kamailio
Branch: 5.4
Commit: bcd8f50929ac25d4eabe7b5886d22dd61c4872e7
URL: https://github.com/kamailio/kamailio/commit/bcd8f50929ac25d4eabe7b5886d22dd…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on main README.md: Consecutives 'the'
---
Modified: README.md
---
Diff: https://github.com/kamailio/kamailio/commit/bcd8f50929ac25d4eabe7b5886d22dd…
Patch: https://github.com/…
[View More]kamailio/kamailio/commit/bcd8f50929ac25d4eabe7b5886d22dd…
---
diff --git a/README.md b/README.md
index 8005030775..85a4b70789 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ Kamailio development was started back in 2001 by [Fraunhofer Fokus](https://www.
Fraunhofer Fokus is no longer actively involved in the evolution of the project. Kamailio is now developed and managed by its world wide community. Fokus still uses Kamailio in its research projects (such as OpenIMSCore) and it is hosting events related to the project, such as developer meetings or the Kamailio World Conference.
-For more information about Kamailio, see the the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
+For more information about Kamailio, see the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
## Contributions
[View Less]
Module: kamailio
Branch: 5.4
Commit: 3910066feabbfbe2f2f653b9b4af5d7d14285911
URL: https://github.com/kamailio/kamailio/commit/3910066feabbfbe2f2f653b9b4af5d7…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on sca module NOTES
---
Modified: src/modules/sca/NOTES
---
Diff: https://github.com/kamailio/kamailio/commit/3910066feabbfbe2f2f653b9b4af5d7…
Patch: https://github.com/kamailio/…
[View More]kamailio/commit/3910066feabbfbe2f2f653b9b4af5d7…
---
diff --git a/src/modules/sca/NOTES b/src/modules/sca/NOTES
index b5c9ebaf5a..fa8ab926f6 100644
--- a/src/modules/sca/NOTES
+++ b/src/modules/sca/NOTES
@@ -113,7 +113,7 @@ Revisiting possibility of using TMCB_ tm module hooks.
* Register a pv in the module, set it to a known value in the
TMCB_E2EACK_IN callback, have the script check the value of the
pv, and invoke an exported sca_update function if the pv is set
- the the known value.
+ to the known value.
Pros: fits sip-router script-based logic model well, does not
rely on a timer (eliminates races).
[View Less]
Module: kamailio
Branch: 5.4
Commit: 2b4f7960ae740175fa4bd37fc2d93868fc52ac95
URL: https://github.com/kamailio/kamailio/commit/2b4f7960ae740175fa4bd37fc2d9386…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on tm module: Consecutives 'the'
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/2b4f7960ae740175fa4bd37fc2d9386…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/2b4f7960ae740175fa4bd37fc2d9386…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index acfc590ffd..f9c9837fb2 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -668,7 +668,7 @@ route {
<function>t_reset_max_lifetime()</function>
</title>
<para>
- Resets the the maximum lifetime for the current INVITE or non-INVITE
+ Resets the maximum lifetime for the current INVITE or non-INVITE
transaction to the default value (set using the tm module parameter
<varname>max_inv_lifetime</varname> or
<varname>max_noninv_lifetime</varname>).
[View Less]
Module: kamailio
Branch: 5.4
Commit: a8f66e8d3104ac35bb99023777a5363d700b3855
URL: https://github.com/kamailio/kamailio/commit/a8f66e8d3104ac35bb99023777a5363…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on db_mongodb module: Consecutives 'the'
---
Modified: src/modules/db_mongodb/doc/db_mongodb_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]a8f66e8d3104ac35bb99023777a5363…
Patch: https://github.com/kamailio/kamailio/commit/a8f66e8d3104ac35bb99023777a5363…
---
diff --git a/src/modules/db_mongodb/doc/db_mongodb_admin.xml b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
index a7723bec58..00cf7a59e6 100644
--- a/src/modules/db_mongodb/doc/db_mongodb_admin.xml
+++ b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
@@ -96,7 +96,7 @@
<section>
<title>Usage</title>
<para>
- Load the module and set the the DB URL for specific modules to:
+ Load the module and set the DB URL for specific modules to:
mongodb://username:password@host:port/database. Username, password
and port are optional.
</para>
[View Less]
Module: kamailio
Branch: 5.4
Commit: d26bf214e7050c051fa6db9477fd7650ad873509
URL: https://github.com/kamailio/kamailio/commit/d26bf214e7050c051fa6db9477fd765…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on drouting module: Consecutives 'the'
---
Modified: src/modules/drouting/doc/drouting_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]d26bf214e7050c051fa6db9477fd765…
Patch: https://github.com/kamailio/kamailio/commit/d26bf214e7050c051fa6db9477fd765…
---
diff --git a/src/modules/drouting/doc/drouting_admin.xml b/src/modules/drouting/doc/drouting_admin.xml
index facb72b31d..323c183a98 100644
--- a/src/modules/drouting/doc/drouting_admin.xml
+++ b/src/modules/drouting/doc/drouting_admin.xml
@@ -18,7 +18,7 @@
<title>Introduction</title>
<para>Dynamic Routing is a module for selecting (based on multiple
- criteria) the the best gateway/destination to be used for delivering a
+ criteria) the best gateway/destination to be used for delivering a
certain call. Least Cost Routing (LCR) is a special case of dynamic
routing - when the rules are ordered based on costs. Dynamic Routing
comes with many features regarding routing rule selection:
[View Less]
Module: kamailio
Branch: 5.4
Commit: 13e6f48fe794455b673e73181397d6d6f8d355c6
URL: https://github.com/kamailio/kamailio/commit/13e6f48fe794455b673e73181397d6d…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:05Z
Fix typo on ims_qos module: Consecutives 'the'
---
Modified: src/modules/ims_qos/rx_aar.c
---
Diff: https://github.com/kamailio/kamailio/commit/13e6f48fe794455b673e73181397d6d…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/13e6f48fe794455b673e73181397d6d…
---
diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c
index b1e8df51b8..d9f242f43b 100644
--- a/src/modules/ims_qos/rx_aar.c
+++ b/src/modules/ims_qos/rx_aar.c
@@ -276,7 +276,7 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e
if (cdp_result >= 2000 && cdp_result < 3000) {
counter_inc(ims_qos_cnts_h.successful_registration_aars);
if (is_rereg) {
- LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the the subscription was successful\n");
+ LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the subscription was successful\n");
result = CSCF_RETURN_TRUE;
create_return_code(result);
goto done;
[View Less]
Module: kamailio
Branch: 5.4
Commit: 02f470f64d57d27b3035b9f8884d539916a8ca02
URL: https://github.com/kamailio/kamailio/commit/02f470f64d57d27b3035b9f8884d539…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on carrierroute module: Consecutives 'the'
---
Modified: src/modules/carrierroute/doc/carrierroute_db.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]02f470f64d57d27b3035b9f8884d539…
Patch: https://github.com/kamailio/kamailio/commit/02f470f64d57d27b3035b9f8884d539…
---
diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml b/src/modules/carrierroute/doc/carrierroute_db.xml
index cc88b19887..f755d08a40 100644
--- a/src/modules/carrierroute/doc/carrierroute_db.xml
+++ b/src/modules/carrierroute/doc/carrierroute_db.xml
@@ -273,7 +273,7 @@ modparam("carrierroute", "carrierfailureroute_domain_col", "domain")
</section>
<section>
<title><varname>carrierfailureroute_scan_prefix_col</varname> (string)</title>
- <para>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <para>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of
[View Less]
Module: kamailio
Branch: 5.4
Commit: fe70897c15c8236fc226d2a05822f98e385ea083
URL: https://github.com/kamailio/kamailio/commit/fe70897c15c8236fc226d2a05822f98…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on cplc module: Consecutives 'the'
---
Modified: src/modules/cplc/doc/cplc_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/fe70897c15c8236fc226d2a05822f98…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/fe70897c15c8236fc226d2a05822f98…
---
diff --git a/src/modules/cplc/doc/cplc_admin.xml b/src/modules/cplc/doc/cplc_admin.xml
index 0c9f15b62e..d83b9271a8 100644
--- a/src/modules/cplc/doc/cplc_admin.xml
+++ b/src/modules/cplc/doc/cplc_admin.xml
@@ -175,7 +175,7 @@ modparam("cpl-c","domain_column","domain")
<title><varname>cpl_xml_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the XML version of the cpl script.
+ XML version of the cpl script.
</para>
<para>
<emphasis>
@@ -195,7 +195,7 @@ modparam("cpl-c","cpl_xml_column","cpl_xml")
<title><varname>cpl_bin_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the binary version of the cpl script (compiled version).
+ binary version of the cpl script (compiled version).
</para>
<para>
<emphasis>
[View Less]
Module: kamailio
Branch: 5.4
Commit: 408efc005320d055c16cce9a518954692eb75187
URL: https://github.com/kamailio/kamailio/commit/408efc005320d055c16cce9a5189546…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on app_jsdt module: Consecutives 'the'
---
Modified: src/modules/app_jsdt/duktape.c
---
Diff: https://github.com/kamailio/kamailio/commit/408efc005320d055c16cce9a5189546…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/408efc005320d055c16cce9a5189546…
---
diff --git a/src/modules/app_jsdt/duktape.c b/src/modules/app_jsdt/duktape.c
index 366883c533..9e05804065 100644
--- a/src/modules/app_jsdt/duktape.c
+++ b/src/modules/app_jsdt/duktape.c
@@ -20026,7 +20026,7 @@ DUK_EXTERNAL void *duk_require_buffer(duk_hthread *thr, duk_idx_t idx, duk_size_
}
/* Get the active buffer data area for a plain buffer or a buffer object.
- * Return NULL if the the value is not a buffer. Note that a buffer may
+ * Return NULL if the value is not a buffer. Note that a buffer may
* have a NULL data pointer when its size is zero, the optional 'out_isbuffer'
* argument allows caller to detect this reliably.
*/
@@ -56844,7 +56844,7 @@ DUK_INTERNAL duk_uint_fast32_t duk_hobject_pc2line_query(duk_hthread *thr, duk_i
* duk_tval copies is not problematic with respect to side effects;
* care must be taken when holding and using argument duk_tval pointers.
*
- * - If a finalizer is executed, it may operate on the the same object
+ * - If a finalizer is executed, it may operate on the same object
* we're currently dealing with. For instance, the finalizer might
* delete a certain property which has already been looked up and
* confirmed to exist. Ideally finalizers would be disabled if GC
[View Less]
Module: kamailio
Branch: 5.4
Commit: ab5a57b1291316b4be57ade1219200db8222ac87
URL: https://github.com/kamailio/kamailio/commit/ab5a57b1291316b4be57ade1219200d…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on avp module: Consecutives 'the'
---
Modified: src/modules/avp/avp.xml
---
Diff: https://github.com/kamailio/kamailio/commit/ab5a57b1291316b4be57ade1219200d…
Patch: https://…
[View More]github.com/kamailio/kamailio/commit/ab5a57b1291316b4be57ade1219200d…
---
diff --git a/src/modules/avp/avp.xml b/src/modules/avp/avp.xml
index 93fdea7fc6..fa47e88cb2 100644
--- a/src/modules/avp/avp.xml
+++ b/src/modules/avp/avp.xml
@@ -168,7 +168,7 @@
<para>
The <function>attr_equals()</function> function checks whether
the attribute identified by the argument <symbol>attribute</symbol>
- exists and its value is identical the the value given by the
+ exists and its value is identical the value given by the
argument <symbol>value</symbol>. If so, it returns
<literal>true</literal> and <literal>false</literal> otherwise.
</para>
[View Less]
Module: kamailio
Branch: 5.4
Commit: 5aff688af40e87c32e43c7c6d5abca60fbb22595
URL: https://github.com/kamailio/kamailio/commit/5aff688af40e87c32e43c7c6d5abca6…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:52:04Z
Fix typo on srdb1 lib: Consecutive 'the'
---
Modified: src/lib/srdb1/schema/carrierfailureroute.xml
---
Diff: https://github.com/kamailio/kamailio/commit/5aff688af40e87c32e43c7c6d5abca6……
[View More]Patch: https://github.com/kamailio/kamailio/commit/5aff688af40e87c32e43c7c6d5abca6…
---
diff --git a/src/lib/srdb1/schema/carrierfailureroute.xml b/src/lib/srdb1/schema/carrierfailureroute.xml
index 2de707c59f..58a05e7865 100644
--- a/src/lib/srdb1/schema/carrierfailureroute.xml
+++ b/src/lib/srdb1/schema/carrierfailureroute.xml
@@ -59,7 +59,7 @@
<type>string</type>
<size>&user_len;</size>
<default/>
- <description>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <description>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of <quote></quote>
[View Less]
Module: kamailio
Branch: 5.3
Commit: 97f029b9f14ac21af5ca8421aca9bc10ae557882
URL: https://github.com/kamailio/kamailio/commit/97f029b9f14ac21af5ca8421aca9bc1…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on xmpp module: Consecutives 'the'
---
Modified: src/modules/xmpp/doc/xmpp_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/97f029b9f14ac21af5ca8421aca9bc1…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/97f029b9f14ac21af5ca8421aca9bc1…
---
diff --git a/src/modules/xmpp/doc/xmpp_admin.xml b/src/modules/xmpp/doc/xmpp_admin.xml
index ab201c5a84..129acbc423 100644
--- a/src/modules/xmpp/doc/xmpp_admin.xml
+++ b/src/modules/xmpp/doc/xmpp_admin.xml
@@ -230,7 +230,7 @@
<para>
The domain of the SIP-to-XMPP gateway - it has to be in DNS or SIP UA has to
use outbound proxy to SIP-to-XMPP gateway IP address. It has to be used
- as domain in the the destination address of the messages sent by SIP users
+ as domain in the destination address of the messages sent by SIP users
to XMPP users:
"sip:username<![CDATA[<]]>delim<![CDATA[>]]>jabber_server@gateway_domain".
</para>
[View Less]
Module: kamailio
Branch: 5.3
Commit: 3d8f2cdcbf30a497351b36c3d9e5f7ac7f876e01
URL: https://github.com/kamailio/kamailio/commit/3d8f2cdcbf30a497351b36c3d9e5f7a…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on main README.md: Consecutives 'the'
---
Modified: README.md
---
Diff: https://github.com/kamailio/kamailio/commit/3d8f2cdcbf30a497351b36c3d9e5f7a…
Patch: https://github.com/…
[View More]kamailio/kamailio/commit/3d8f2cdcbf30a497351b36c3d9e5f7a…
---
diff --git a/README.md b/README.md
index 8005030775..85a4b70789 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ Kamailio development was started back in 2001 by [Fraunhofer Fokus](https://www.
Fraunhofer Fokus is no longer actively involved in the evolution of the project. Kamailio is now developed and managed by its world wide community. Fokus still uses Kamailio in its research projects (such as OpenIMSCore) and it is hosting events related to the project, such as developer meetings or the Kamailio World Conference.
-For more information about Kamailio, see the the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
+For more information about Kamailio, see the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
## Contributions
[View Less]
Module: kamailio
Branch: 5.3
Commit: cc022ce161047237a412a1c349af0f96fd4b4c52
URL: https://github.com/kamailio/kamailio/commit/cc022ce161047237a412a1c349af0f9…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on tm module: Consecutives 'the'
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/cc022ce161047237a412a1c349af0f9…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/cc022ce161047237a412a1c349af0f9…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 489147afd1..5ba8526c6e 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -668,7 +668,7 @@ route {
<function>t_reset_max_lifetime()</function>
</title>
<para>
- Resets the the maximum lifetime for the current INVITE or non-INVITE
+ Resets the maximum lifetime for the current INVITE or non-INVITE
transaction to the default value (set using the tm module parameter
<varname>max_inv_lifetime</varname> or
<varname>max_noninv_lifetime</varname>).
[View Less]
Module: kamailio
Branch: 5.3
Commit: e153c88caefdc15e0883f0d41ea395589d8fa7c4
URL: https://github.com/kamailio/kamailio/commit/e153c88caefdc15e0883f0d41ea3955…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on drouting module: Consecutives 'the'
---
Modified: src/modules/drouting/doc/drouting_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]e153c88caefdc15e0883f0d41ea3955…
Patch: https://github.com/kamailio/kamailio/commit/e153c88caefdc15e0883f0d41ea3955…
---
diff --git a/src/modules/drouting/doc/drouting_admin.xml b/src/modules/drouting/doc/drouting_admin.xml
index facb72b31d..323c183a98 100644
--- a/src/modules/drouting/doc/drouting_admin.xml
+++ b/src/modules/drouting/doc/drouting_admin.xml
@@ -18,7 +18,7 @@
<title>Introduction</title>
<para>Dynamic Routing is a module for selecting (based on multiple
- criteria) the the best gateway/destination to be used for delivering a
+ criteria) the best gateway/destination to be used for delivering a
certain call. Least Cost Routing (LCR) is a special case of dynamic
routing - when the rules are ordered based on costs. Dynamic Routing
comes with many features regarding routing rule selection:
[View Less]
Module: kamailio
Branch: 5.3
Commit: 7046b14fa36495790d3ad42e336b5b2a26fbca34
URL: https://github.com/kamailio/kamailio/commit/7046b14fa36495790d3ad42e336b5b2…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on ims_qos module: Consecutives 'the'
---
Modified: src/modules/ims_qos/rx_aar.c
---
Diff: https://github.com/kamailio/kamailio/commit/7046b14fa36495790d3ad42e336b5b2…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/7046b14fa36495790d3ad42e336b5b2…
---
diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c
index b1e8df51b8..d9f242f43b 100644
--- a/src/modules/ims_qos/rx_aar.c
+++ b/src/modules/ims_qos/rx_aar.c
@@ -276,7 +276,7 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e
if (cdp_result >= 2000 && cdp_result < 3000) {
counter_inc(ims_qos_cnts_h.successful_registration_aars);
if (is_rereg) {
- LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the the subscription was successful\n");
+ LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the subscription was successful\n");
result = CSCF_RETURN_TRUE;
create_return_code(result);
goto done;
[View Less]
Module: kamailio
Branch: 5.3
Commit: ce6c55fae057681a0b3c486cf5bc3e80edd0c275
URL: https://github.com/kamailio/kamailio/commit/ce6c55fae057681a0b3c486cf5bc3e8…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on sca module NOTES
---
Modified: src/modules/sca/NOTES
---
Diff: https://github.com/kamailio/kamailio/commit/ce6c55fae057681a0b3c486cf5bc3e8…
Patch: https://github.com/kamailio/…
[View More]kamailio/commit/ce6c55fae057681a0b3c486cf5bc3e8…
---
diff --git a/src/modules/sca/NOTES b/src/modules/sca/NOTES
index b5c9ebaf5a..fa8ab926f6 100644
--- a/src/modules/sca/NOTES
+++ b/src/modules/sca/NOTES
@@ -113,7 +113,7 @@ Revisiting possibility of using TMCB_ tm module hooks.
* Register a pv in the module, set it to a known value in the
TMCB_E2EACK_IN callback, have the script check the value of the
pv, and invoke an exported sca_update function if the pv is set
- the the known value.
+ to the known value.
Pros: fits sip-router script-based logic model well, does not
rely on a timer (eliminates races).
[View Less]
Module: kamailio
Branch: 5.3
Commit: bd9a926bf443e4993e7f8043760b188860c8ca24
URL: https://github.com/kamailio/kamailio/commit/bd9a926bf443e4993e7f8043760b188…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on cplc module: Consecutives 'the'
---
Modified: src/modules/cplc/doc/cplc_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/bd9a926bf443e4993e7f8043760b188…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/bd9a926bf443e4993e7f8043760b188…
---
diff --git a/src/modules/cplc/doc/cplc_admin.xml b/src/modules/cplc/doc/cplc_admin.xml
index 0c9f15b62e..d83b9271a8 100644
--- a/src/modules/cplc/doc/cplc_admin.xml
+++ b/src/modules/cplc/doc/cplc_admin.xml
@@ -175,7 +175,7 @@ modparam("cpl-c","domain_column","domain")
<title><varname>cpl_xml_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the XML version of the cpl script.
+ XML version of the cpl script.
</para>
<para>
<emphasis>
@@ -195,7 +195,7 @@ modparam("cpl-c","cpl_xml_column","cpl_xml")
<title><varname>cpl_bin_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the binary version of the cpl script (compiled version).
+ binary version of the cpl script (compiled version).
</para>
<para>
<emphasis>
[View Less]
Module: kamailio
Branch: 5.3
Commit: 1045c0b5f0c48deaf5590734688e01e50a3cc069
URL: https://github.com/kamailio/kamailio/commit/1045c0b5f0c48deaf5590734688e01e…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:46Z
Fix typo on db_mongodb module: Consecutives 'the'
---
Modified: src/modules/db_mongodb/doc/db_mongodb_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]1045c0b5f0c48deaf5590734688e01e…
Patch: https://github.com/kamailio/kamailio/commit/1045c0b5f0c48deaf5590734688e01e…
---
diff --git a/src/modules/db_mongodb/doc/db_mongodb_admin.xml b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
index a7723bec58..00cf7a59e6 100644
--- a/src/modules/db_mongodb/doc/db_mongodb_admin.xml
+++ b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
@@ -96,7 +96,7 @@
<section>
<title>Usage</title>
<para>
- Load the module and set the the DB URL for specific modules to:
+ Load the module and set the DB URL for specific modules to:
mongodb://username:password@host:port/database. Username, password
and port are optional.
</para>
[View Less]
Module: kamailio
Branch: 5.3
Commit: d306cf12f13b40724181b31d070a47522cab8d2d
URL: https://github.com/kamailio/kamailio/commit/d306cf12f13b40724181b31d070a475…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:45Z
Fix typo on carrierroute module: Consecutives 'the'
---
Modified: src/modules/carrierroute/doc/carrierroute_db.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]d306cf12f13b40724181b31d070a475…
Patch: https://github.com/kamailio/kamailio/commit/d306cf12f13b40724181b31d070a475…
---
diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml b/src/modules/carrierroute/doc/carrierroute_db.xml
index cc88b19887..f755d08a40 100644
--- a/src/modules/carrierroute/doc/carrierroute_db.xml
+++ b/src/modules/carrierroute/doc/carrierroute_db.xml
@@ -273,7 +273,7 @@ modparam("carrierroute", "carrierfailureroute_domain_col", "domain")
</section>
<section>
<title><varname>carrierfailureroute_scan_prefix_col</varname> (string)</title>
- <para>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <para>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of
[View Less]
Module: kamailio
Branch: 5.3
Commit: 77b0e31eecb842de24ee18d31f3e7d0c655ecde2
URL: https://github.com/kamailio/kamailio/commit/77b0e31eecb842de24ee18d31f3e7d0…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:45Z
Fix typo on avp module: Consecutives 'the'
---
Modified: src/modules/avp/avp.xml
---
Diff: https://github.com/kamailio/kamailio/commit/77b0e31eecb842de24ee18d31f3e7d0…
Patch: https://…
[View More]github.com/kamailio/kamailio/commit/77b0e31eecb842de24ee18d31f3e7d0…
---
diff --git a/src/modules/avp/avp.xml b/src/modules/avp/avp.xml
index 93fdea7fc6..fa47e88cb2 100644
--- a/src/modules/avp/avp.xml
+++ b/src/modules/avp/avp.xml
@@ -168,7 +168,7 @@
<para>
The <function>attr_equals()</function> function checks whether
the attribute identified by the argument <symbol>attribute</symbol>
- exists and its value is identical the the value given by the
+ exists and its value is identical the value given by the
argument <symbol>value</symbol>. If so, it returns
<literal>true</literal> and <literal>false</literal> otherwise.
</para>
[View Less]
Module: kamailio
Branch: 5.3
Commit: cd7681634d9d9262609559a713aa7732ec50c957
URL: https://github.com/kamailio/kamailio/commit/cd7681634d9d9262609559a713aa773…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:45Z
Fix typo on srdb1 lib: Consecutive 'the'
---
Modified: src/lib/srdb1/schema/carrierfailureroute.xml
---
Diff: https://github.com/kamailio/kamailio/commit/cd7681634d9d9262609559a713aa773……
[View More]Patch: https://github.com/kamailio/kamailio/commit/cd7681634d9d9262609559a713aa773…
---
diff --git a/src/lib/srdb1/schema/carrierfailureroute.xml b/src/lib/srdb1/schema/carrierfailureroute.xml
index 2de707c59f..58a05e7865 100644
--- a/src/lib/srdb1/schema/carrierfailureroute.xml
+++ b/src/lib/srdb1/schema/carrierfailureroute.xml
@@ -59,7 +59,7 @@
<type>string</type>
<size>&user_len;</size>
<default/>
- <description>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <description>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of <quote></quote>
[View Less]
Module: kamailio
Branch: 5.3
Commit: e10b3040730181ddb7ae3d4dd7353e62260f83f4
URL: https://github.com/kamailio/kamailio/commit/e10b3040730181ddb7ae3d4dd7353e6…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:51:45Z
Fix typo on app_jsdt module: Consecutives 'the'
---
Modified: src/modules/app_jsdt/duktape.c
---
Diff: https://github.com/kamailio/kamailio/commit/e10b3040730181ddb7ae3d4dd7353e6…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/e10b3040730181ddb7ae3d4dd7353e6…
---
diff --git a/src/modules/app_jsdt/duktape.c b/src/modules/app_jsdt/duktape.c
index c3781f766f..81363cec7a 100644
--- a/src/modules/app_jsdt/duktape.c
+++ b/src/modules/app_jsdt/duktape.c
@@ -19523,7 +19523,7 @@ DUK_EXTERNAL void *duk_require_buffer(duk_hthread *thr, duk_idx_t idx, duk_size_
}
/* Get the active buffer data area for a plain buffer or a buffer object.
- * Return NULL if the the value is not a buffer. Note that a buffer may
+ * Return NULL if the value is not a buffer. Note that a buffer may
* have a NULL data pointer when its size is zero, the optional 'out_isbuffer'
* argument allows caller to detect this reliably.
*/
@@ -54271,7 +54271,7 @@ DUK_INTERNAL duk_uint_fast32_t duk_hobject_pc2line_query(duk_hthread *thr, duk_i
* duk_tval copies is not problematic with respect to side effects;
* care must be taken when holding and using argument duk_tval pointers.
*
- * - If a finalizer is executed, it may operate on the the same object
+ * - If a finalizer is executed, it may operate on the same object
* we're currently dealing with. For instance, the finalizer might
* delete a certain property which has already been looked up and
* confirmed to exist. Ideally finalizers would be disabled if GC
[View Less]
Module: kamailio
Branch: 5.2
Commit: 587d741736d5dc32f5a81633e0e02cead120e330
URL: https://github.com/kamailio/kamailio/commit/587d741736d5dc32f5a81633e0e02ce…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on xmpp module: Consecutives 'the'
---
Modified: src/modules/xmpp/doc/xmpp_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/587d741736d5dc32f5a81633e0e02ce…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/587d741736d5dc32f5a81633e0e02ce…
---
diff --git a/src/modules/xmpp/doc/xmpp_admin.xml b/src/modules/xmpp/doc/xmpp_admin.xml
index ab201c5a84..129acbc423 100644
--- a/src/modules/xmpp/doc/xmpp_admin.xml
+++ b/src/modules/xmpp/doc/xmpp_admin.xml
@@ -230,7 +230,7 @@
<para>
The domain of the SIP-to-XMPP gateway - it has to be in DNS or SIP UA has to
use outbound proxy to SIP-to-XMPP gateway IP address. It has to be used
- as domain in the the destination address of the messages sent by SIP users
+ as domain in the destination address of the messages sent by SIP users
to XMPP users:
"sip:username<![CDATA[<]]>delim<![CDATA[>]]>jabber_server@gateway_domain".
</para>
[View Less]
Module: kamailio
Branch: 5.2
Commit: 695035e2fc0ddc02da3818697785a7cc25d5e286
URL: https://github.com/kamailio/kamailio/commit/695035e2fc0ddc02da3818697785a7c…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on main README.md: Consecutives 'the'
---
Modified: README.md
---
Diff: https://github.com/kamailio/kamailio/commit/695035e2fc0ddc02da3818697785a7c…
Patch: https://github.com/…
[View More]kamailio/kamailio/commit/695035e2fc0ddc02da3818697785a7c…
---
diff --git a/README.md b/README.md
index 8005030775..85a4b70789 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ Kamailio development was started back in 2001 by [Fraunhofer Fokus](https://www.
Fraunhofer Fokus is no longer actively involved in the evolution of the project. Kamailio is now developed and managed by its world wide community. Fokus still uses Kamailio in its research projects (such as OpenIMSCore) and it is hosting events related to the project, such as developer meetings or the Kamailio World Conference.
-For more information about Kamailio, see the the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
+For more information about Kamailio, see the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
## Contributions
[View Less]
Module: kamailio
Branch: 5.2
Commit: e1d455c15fcbb4a1c710bd6aa84bba2a96a11046
URL: https://github.com/kamailio/kamailio/commit/e1d455c15fcbb4a1c710bd6aa84bba2…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on sca module NOTES
---
Modified: src/modules/sca/NOTES
---
Diff: https://github.com/kamailio/kamailio/commit/e1d455c15fcbb4a1c710bd6aa84bba2…
Patch: https://github.com/kamailio/…
[View More]kamailio/commit/e1d455c15fcbb4a1c710bd6aa84bba2…
---
diff --git a/src/modules/sca/NOTES b/src/modules/sca/NOTES
index b5c9ebaf5a..fa8ab926f6 100644
--- a/src/modules/sca/NOTES
+++ b/src/modules/sca/NOTES
@@ -113,7 +113,7 @@ Revisiting possibility of using TMCB_ tm module hooks.
* Register a pv in the module, set it to a known value in the
TMCB_E2EACK_IN callback, have the script check the value of the
pv, and invoke an exported sca_update function if the pv is set
- the the known value.
+ to the known value.
Pros: fits sip-router script-based logic model well, does not
rely on a timer (eliminates races).
[View Less]
Module: kamailio
Branch: 5.2
Commit: b66d8631a62ca08e92bc6b274515843d6749a7c6
URL: https://github.com/kamailio/kamailio/commit/b66d8631a62ca08e92bc6b274515843…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on tm module: Consecutives 'the'
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/b66d8631a62ca08e92bc6b274515843…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/b66d8631a62ca08e92bc6b274515843…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index a36c6200f5..d3c47d5d34 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -668,7 +668,7 @@ route {
<function>t_reset_max_lifetime()</function>
</title>
<para>
- Resets the the maximum lifetime for the current INVITE or non-INVITE
+ Resets the maximum lifetime for the current INVITE or non-INVITE
transaction to the default value (set using the tm module parameter
<varname>max_inv_lifetime</varname> or
<varname>max_noninv_lifetime</varname>).
[View Less]
Module: kamailio
Branch: 5.2
Commit: d44995a6c87cacc94dab13ded043bd4a4ba8dac5
URL: https://github.com/kamailio/kamailio/commit/d44995a6c87cacc94dab13ded043bd4…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on drouting module: Consecutives 'the'
---
Modified: src/modules/drouting/doc/drouting_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]d44995a6c87cacc94dab13ded043bd4…
Patch: https://github.com/kamailio/kamailio/commit/d44995a6c87cacc94dab13ded043bd4…
---
diff --git a/src/modules/drouting/doc/drouting_admin.xml b/src/modules/drouting/doc/drouting_admin.xml
index 46fab8b551..c2dc2e6a83 100644
--- a/src/modules/drouting/doc/drouting_admin.xml
+++ b/src/modules/drouting/doc/drouting_admin.xml
@@ -18,7 +18,7 @@
<title>Introduction</title>
<para>Dynamic Routing is a module for selecting (based on multiple
- criteria) the the best gateway/destination to be used for delivering a
+ criteria) the best gateway/destination to be used for delivering a
certain call. Least Cost Routing (LCR) is a special case of dynamic
routing - when the rules are ordered based on costs. Dynamic Routing
comes with many features regarding routing rule selection:
[View Less]
Module: kamailio
Branch: 5.2
Commit: 59eac533086ace33582021edf19c0da2f993550a
URL: https://github.com/kamailio/kamailio/commit/59eac533086ace33582021edf19c0da…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on ims_qos module: Consecutives 'the'
---
Modified: src/modules/ims_qos/rx_aar.c
---
Diff: https://github.com/kamailio/kamailio/commit/59eac533086ace33582021edf19c0da…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/59eac533086ace33582021edf19c0da…
---
diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c
index b1e8df51b8..d9f242f43b 100644
--- a/src/modules/ims_qos/rx_aar.c
+++ b/src/modules/ims_qos/rx_aar.c
@@ -276,7 +276,7 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e
if (cdp_result >= 2000 && cdp_result < 3000) {
counter_inc(ims_qos_cnts_h.successful_registration_aars);
if (is_rereg) {
- LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the the subscription was successful\n");
+ LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the subscription was successful\n");
result = CSCF_RETURN_TRUE;
create_return_code(result);
goto done;
[View Less]
Module: kamailio
Branch: 5.2
Commit: 1a99608e4d9bb9312737dcdf214af732a7f4eb51
URL: https://github.com/kamailio/kamailio/commit/1a99608e4d9bb9312737dcdf214af73…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on cplc module: Consecutives 'the'
---
Modified: src/modules/cplc/doc/cplc_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/1a99608e4d9bb9312737dcdf214af73…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/1a99608e4d9bb9312737dcdf214af73…
---
diff --git a/src/modules/cplc/doc/cplc_admin.xml b/src/modules/cplc/doc/cplc_admin.xml
index 0c9f15b62e..d83b9271a8 100644
--- a/src/modules/cplc/doc/cplc_admin.xml
+++ b/src/modules/cplc/doc/cplc_admin.xml
@@ -175,7 +175,7 @@ modparam("cpl-c","domain_column","domain")
<title><varname>cpl_xml_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the XML version of the cpl script.
+ XML version of the cpl script.
</para>
<para>
<emphasis>
@@ -195,7 +195,7 @@ modparam("cpl-c","cpl_xml_column","cpl_xml")
<title><varname>cpl_bin_column</varname> (string)</title>
<para>
Indicates the name of the column used for storing the
- the binary version of the cpl script (compiled version).
+ binary version of the cpl script (compiled version).
</para>
<para>
<emphasis>
[View Less]
Module: kamailio
Branch: 5.2
Commit: c106c6d265e4b79748fd3532e77a1f9f10f18da3
URL: https://github.com/kamailio/kamailio/commit/c106c6d265e4b79748fd3532e77a1f9…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on db_mongodb module: Consecutives 'the'
---
Modified: src/modules/db_mongodb/doc/db_mongodb_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]c106c6d265e4b79748fd3532e77a1f9…
Patch: https://github.com/kamailio/kamailio/commit/c106c6d265e4b79748fd3532e77a1f9…
---
diff --git a/src/modules/db_mongodb/doc/db_mongodb_admin.xml b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
index a7723bec58..00cf7a59e6 100644
--- a/src/modules/db_mongodb/doc/db_mongodb_admin.xml
+++ b/src/modules/db_mongodb/doc/db_mongodb_admin.xml
@@ -96,7 +96,7 @@
<section>
<title>Usage</title>
<para>
- Load the module and set the the DB URL for specific modules to:
+ Load the module and set the DB URL for specific modules to:
mongodb://username:password@host:port/database. Username, password
and port are optional.
</para>
[View Less]
Module: kamailio
Branch: 5.2
Commit: 27da1adf9d64486b5ae6e8e980be82e048a9b582
URL: https://github.com/kamailio/kamailio/commit/27da1adf9d64486b5ae6e8e980be82e…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:38Z
Fix typo on avp module: Consecutives 'the'
---
Modified: src/modules/avp/avp.xml
---
Diff: https://github.com/kamailio/kamailio/commit/27da1adf9d64486b5ae6e8e980be82e…
Patch: https://…
[View More]github.com/kamailio/kamailio/commit/27da1adf9d64486b5ae6e8e980be82e…
---
diff --git a/src/modules/avp/avp.xml b/src/modules/avp/avp.xml
index 93fdea7fc6..fa47e88cb2 100644
--- a/src/modules/avp/avp.xml
+++ b/src/modules/avp/avp.xml
@@ -168,7 +168,7 @@
<para>
The <function>attr_equals()</function> function checks whether
the attribute identified by the argument <symbol>attribute</symbol>
- exists and its value is identical the the value given by the
+ exists and its value is identical the value given by the
argument <symbol>value</symbol>. If so, it returns
<literal>true</literal> and <literal>false</literal> otherwise.
</para>
[View Less]
Module: kamailio
Branch: 5.2
Commit: 42ea1f522de1b545f72e4cfeeaa1da2949f1b3e7
URL: https://github.com/kamailio/kamailio/commit/42ea1f522de1b545f72e4cfeeaa1da2…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:39Z
Fix typo on carrierroute module: Consecutives 'the'
---
Modified: src/modules/carrierroute/doc/carrierroute_db.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]42ea1f522de1b545f72e4cfeeaa1da2…
Patch: https://github.com/kamailio/kamailio/commit/42ea1f522de1b545f72e4cfeeaa1da2…
---
diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml b/src/modules/carrierroute/doc/carrierroute_db.xml
index 2bd82d6c99..808a5456c8 100644
--- a/src/modules/carrierroute/doc/carrierroute_db.xml
+++ b/src/modules/carrierroute/doc/carrierroute_db.xml
@@ -273,7 +273,7 @@ modparam("carrierroute", "carrierfailureroute_domain_col", "domain")
</section>
<section>
<title><varname>carrierfailureroute_scan_prefix_col</varname> (string)</title>
- <para>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <para>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of
[View Less]
Module: kamailio
Branch: 5.2
Commit: 6b6b2c1223537042d24457b9ca82e25407208608
URL: https://github.com/kamailio/kamailio/commit/6b6b2c1223537042d24457b9ca82e25…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:38Z
Fix typo on app_jsdt module: Consecutives 'the'
---
Modified: src/modules/app_jsdt/duktape.c
---
Diff: https://github.com/kamailio/kamailio/commit/6b6b2c1223537042d24457b9ca82e25…
Patch: …
[View More]https://github.com/kamailio/kamailio/commit/6b6b2c1223537042d24457b9ca82e25…
---
diff --git a/src/modules/app_jsdt/duktape.c b/src/modules/app_jsdt/duktape.c
index c3781f766f..81363cec7a 100644
--- a/src/modules/app_jsdt/duktape.c
+++ b/src/modules/app_jsdt/duktape.c
@@ -19523,7 +19523,7 @@ DUK_EXTERNAL void *duk_require_buffer(duk_hthread *thr, duk_idx_t idx, duk_size_
}
/* Get the active buffer data area for a plain buffer or a buffer object.
- * Return NULL if the the value is not a buffer. Note that a buffer may
+ * Return NULL if the value is not a buffer. Note that a buffer may
* have a NULL data pointer when its size is zero, the optional 'out_isbuffer'
* argument allows caller to detect this reliably.
*/
@@ -54271,7 +54271,7 @@ DUK_INTERNAL duk_uint_fast32_t duk_hobject_pc2line_query(duk_hthread *thr, duk_i
* duk_tval copies is not problematic with respect to side effects;
* care must be taken when holding and using argument duk_tval pointers.
*
- * - If a finalizer is executed, it may operate on the the same object
+ * - If a finalizer is executed, it may operate on the same object
* we're currently dealing with. For instance, the finalizer might
* delete a certain property which has already been looked up and
* confirmed to exist. Ideally finalizers would be disabled if GC
[View Less]
Module: kamailio
Branch: 5.2
Commit: 36a329cc8fef72da4f3a893079fccf8a97296547
URL: https://github.com/kamailio/kamailio/commit/36a329cc8fef72da4f3a893079fccf8…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T13:50:38Z
Fix typo on srdb1 lib: Consecutive 'the'
---
Modified: src/lib/srdb1/schema/carrierfailureroute.xml
---
Diff: https://github.com/kamailio/kamailio/commit/36a329cc8fef72da4f3a893079fccf8……
[View More]Patch: https://github.com/kamailio/kamailio/commit/36a329cc8fef72da4f3a893079fccf8…
---
diff --git a/src/lib/srdb1/schema/carrierfailureroute.xml b/src/lib/srdb1/schema/carrierfailureroute.xml
index 2de707c59f..58a05e7865 100644
--- a/src/lib/srdb1/schema/carrierfailureroute.xml
+++ b/src/lib/srdb1/schema/carrierfailureroute.xml
@@ -59,7 +59,7 @@
<type>string</type>
<size>&user_len;</size>
<default/>
- <description>Name of column contains the the scan prefixes. Scan prefixes define the matching
+ <description>Name of column contains the scan prefixes. Scan prefixes define the matching
portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is
49721913740, it matches 49721, because the longest match is taken. If no prefix matches,
the number is not failure routed. To prevent this, an empty prefix value of <quote></quote>
[View Less]
Module: kamailio
Branch: master
Commit: 86a9e0437ae3366cd45fa9334ae2a9d6cde44a27
URL: https://github.com/kamailio/kamailio/commit/86a9e0437ae3366cd45fa9334ae2a9d…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:48:22+02:00
Fix typo on main README.md: Consecutives 'the'
---
Modified: README.md
---
Diff: https://github.com/kamailio/kamailio/commit/86a9e0437ae3366cd45fa9334ae2a9d…
Patch: https://github.…
[View More]com/kamailio/kamailio/commit/86a9e0437ae3366cd45fa9334ae2a9d…
---
diff --git a/README.md b/README.md
index f160311182..6649dc692c 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ Kamailio development was started back in 2001 by [Fraunhofer Fokus](https://www.
Fraunhofer Fokus is no longer actively involved in the evolution of the project. Kamailio is now developed and managed by its world wide community. Fokus still uses Kamailio in its research projects (such as OpenIMSCore) and it is hosting events related to the project, such as developer meetings or the Kamailio World Conference.
-For more information about Kamailio, see the the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
+For more information about Kamailio, see the [website of the project](https://www.kamailio.org), where you can find pointers to documentation, the project wiki and much more.
## Contributions
[View Less]
Module: kamailio
Branch: master
Commit: 62a31d3b28147f2e96d1caa38807a38028e08155
URL: https://github.com/kamailio/kamailio/commit/62a31d3b28147f2e96d1caa38807a38…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:48:22+02:00
Fix typo on xmpp module: Consecutives 'the'
---
Modified: src/modules/xmpp/doc/xmpp_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/62a31d3b28147f2e96d1caa38807a38……
[View More]
Patch: https://github.com/kamailio/kamailio/commit/62a31d3b28147f2e96d1caa38807a38…
---
diff --git a/src/modules/xmpp/doc/xmpp_admin.xml b/src/modules/xmpp/doc/xmpp_admin.xml
index ab201c5a84..129acbc423 100644
--- a/src/modules/xmpp/doc/xmpp_admin.xml
+++ b/src/modules/xmpp/doc/xmpp_admin.xml
@@ -230,7 +230,7 @@
<para>
The domain of the SIP-to-XMPP gateway - it has to be in DNS or SIP UA has to
use outbound proxy to SIP-to-XMPP gateway IP address. It has to be used
- as domain in the the destination address of the messages sent by SIP users
+ as domain in the destination address of the messages sent by SIP users
to XMPP users:
"sip:username<![CDATA[<]]>delim<![CDATA[>]]>jabber_server@gateway_domain".
</para>
[View Less]
Module: kamailio
Branch: master
Commit: 39ef519bdeba10fabc1880d7d570b6b8a5604aec
URL: https://github.com/kamailio/kamailio/commit/39ef519bdeba10fabc1880d7d570b6b…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:48:22+02:00
Fix typo on ims_qos module: Consecutives 'the'
---
Modified: src/modules/ims_qos/rx_aar.c
---
Diff: https://github.com/kamailio/kamailio/commit/39ef519bdeba10fabc1880d7d570b6b……
[View More]Patch: https://github.com/kamailio/kamailio/commit/39ef519bdeba10fabc1880d7d570b6b…
---
diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c
index 987b5c22bd..97d3d7a49d 100644
--- a/src/modules/ims_qos/rx_aar.c
+++ b/src/modules/ims_qos/rx_aar.c
@@ -276,7 +276,7 @@ void async_aar_reg_callback(int is_timeout, void *param, AAAMessage *aaa, long e
if (cdp_result >= 2000 && cdp_result < 3000) {
counter_inc(ims_qos_cnts_h.successful_registration_aars);
if (is_rereg) {
- LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the the subscription was successful\n");
+ LM_DBG("this is a re-registration, therefore we don't need to do anything except know that the subscription was successful\n");
result = CSCF_RETURN_TRUE;
create_return_code(result);
goto done;
[View Less]
Module: kamailio
Branch: master
Commit: b5fd3731ac12b90c6861d0e7813f3bf40e9d5e6d
URL: https://github.com/kamailio/kamailio/commit/b5fd3731ac12b90c6861d0e7813f3bf…
Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2020-10-02T15:48:22+02:00
Fix typo on sca module NOTES
---
Modified: src/modules/sca/NOTES
---
Diff: https://github.com/kamailio/kamailio/commit/b5fd3731ac12b90c6861d0e7813f3bf…
Patch: https://github.com/…
[View More]kamailio/kamailio/commit/b5fd3731ac12b90c6861d0e7813f3bf…
---
diff --git a/src/modules/sca/NOTES b/src/modules/sca/NOTES
index b5c9ebaf5a..fa8ab926f6 100644
--- a/src/modules/sca/NOTES
+++ b/src/modules/sca/NOTES
@@ -113,7 +113,7 @@ Revisiting possibility of using TMCB_ tm module hooks.
* Register a pv in the module, set it to a known value in the
TMCB_E2EACK_IN callback, have the script check the value of the
pv, and invoke an exported sca_update function if the pv is set
- the the known value.
+ to the known value.
Pros: fits sip-router script-based logic model well, does not
rely on a timer (eliminates races).
[View Less]