- sr-dev - kamailio.org

git:6.0:a9e55374: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 20 Jun '25

20 Jun '25

Module: kamailio Branch: 6.0 Commit: a9e553746d7853e5229a54a5b54a8448374171dd URL: https://github.com/kamailio/kamailio/commit/a9e553746d7853e5229a54a5b54a844… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-20T10:01:20+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/cdp/README Modified: src/modules/dialog/README Modified: src/modules/jansson/README Modified: src/modules/jwt/README Modified: src/modules/stirshaken/README Modified: src/modules/tm/README Modified: src/modules/userblocklist/README --- Diff: https://github.com/kamailio/kamailio/commit/a9e553746d7853e5229a54a5b54a844… Patch: https://github.com/kamailio/kamailio/commit/a9e553746d7853e5229a54a5b54a844…

1 0

git: new commits in branch 6.0
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

- URL: https://github.com/kamailio/kamailio/commit/c99eba2aa980b2c9a2769a6ddc6e168… Author: Mathias Schneuwly <mathias.schneuwly(a)ruag.ch> Date: 2025-06-20T08:43:24+02:00 core: Include parameter skip_record in dns_cache_print_entry Extend the return value of dns_cache_print_entry with the parameter `rr_skip_record` for NAPTR records. The parameter `rr_skip_record` indicates, whether the NAPTR record is skipped due to issues reaching the destinations. Once a NAPTR record is marked as skipped, it will no longer be used. Reported by schneuwlym #4174 (cherry picked from commit 1f4e6795502626865d10c83b3880e2985eb94787) - URL: https://github.com/kamailio/kamailio/commit/9f8f0ebdd69de961a8e67245067a81d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:02:09+02:00 snmpstats: mibs/KAMAILIO-MIB relocated DEFVAL after DESCRIPTION - follow better the definition specs - some tools complain otherwise (cherry picked from commit eff0a5d9b39b371c2fdea0378a1f52002cba1e7f) - URL: https://github.com/kamailio/kamailio/commit/5fd7f980d6cbcc21b669d445887e768… Author: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-20T09:05:28+02:00 tm: Update docs of fr_timer to match the implementation - Use description found in https://sip-router.org/wiki/ref_manual/timers (cherry picked from commit 1195252256858dc4419c179e5b72541018f5feab) - URL: https://github.com/kamailio/kamailio/commit/4262016921e015153bfb61d47d33e99… Author: ngash <ngash(a)west.com> Date: 2025-06-20T09:05:56+02:00 uac: fix memory corruption from shared tp being freed by another transaction - Shared memory corruption resulting in multiple process core dumps. Triggered by an outbound REGISTER receiving 401 for all requests which resulted in the shared tp being released in uac_resend_tm_callback whilst the current transaction was put on timer and also used after release and then re-released. In order to avoid sharing the tp I changed the code in uac_send_tm_callback to clone the existing tp. Also added a sanity check for null as tp could be released prior to a dereference of tp->event (cherry picked from commit d529b511b1ce722ceccf29dc006e92d45f1f340e) - URL: https://github.com/kamailio/kamailio/commit/8bde7892f40349beb10953da23f0737… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:06:38+02:00 microhttpd: return on malloc failure (cherry picked from commit cdf0eda22f91f0d237e0ae0a9fc3ad292934fae1) - URL: https://github.com/kamailio/kamailio/commit/a8d291951b225415538d07208b8fb08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:06:46+02:00 lost: condition only on str pointer to free it - cover empty strings (cherry picked from commit 6b1008610861be62bd1b5f419f2cdd9bd2b23ffc) - URL: https://github.com/kamailio/kamailio/commit/9b6fa2f9ee13b64edf90ab0e8233975… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:06:56+02:00 lost: keep pointer to original geo value - triming can lose the start pointer and free is going to fail - init more local variables (cherry picked from commit f390a654ee9d2c2059669e0209926096c978ff11) - URL: https://github.com/kamailio/kamailio/commit/d8ffd03c81833ec33c532c79ef57b92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:07:03+02:00 lost: simplified lost_free_string() - removed unnecessary memset() for lost_copy_string() (cherry picked from commit 28efc7610d08ee0177b8b252316ba53686bf83bf) - URL: https://github.com/kamailio/kamailio/commit/b4030094f1dedcc7977ab49be66fbea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:07:11+02:00 lost: simplify freeing local variables on error - the helper function has conditions inside (cherry picked from commit 9f24f1109d6d491750c6feb19a9a6d0bcb674f90) - URL: https://github.com/kamailio/kamailio/commit/304ac169061d785e098b03bf3c49809… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:07:18+02:00 nat_traversal: check result for searching port in contact uri (cherry picked from commit 91e9cba3d4e22851275167510b6d8a71bd9e11a1) - URL: https://github.com/kamailio/kamailio/commit/039c877b8846043db9cef6a8024e68d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:07:39+02:00 microhttpd: warning on failing to add content-type (cherry picked from commit 2b331d95ae62eb0000a289e1bdb668ee7bc572cb) - URL: https://github.com/kamailio/kamailio/commit/2ee3ce3efac5dd600cb74a427a63a3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:07:53+02:00 textops: simplify return code when removing via param (cherry picked from commit e9c519ad4d49b8c74069577edb84ce02a5e63ee0) - URL: https://github.com/kamailio/kamailio/commit/7c3475af29df1e5a7f2fe25a84d7450… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:08:31+02:00 core: use ULL constant to induce value size (cherry picked from commit cb915a518106c49c2d71308396feee9ba5149e39) - URL: https://github.com/kamailio/kamailio/commit/58a7e25ffcbca6b681c3d581e8322ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:08:44+02:00 cfgutils: kemi export try/un/lock_key2() functions - different kemi functions cannot be exported with same name, even if they have different number of parameters - GH #4216 (cherry picked from commit 204839ec9aeb0f31425732dd0a2e8e256481dae5) - URL: https://github.com/kamailio/kamailio/commit/0b39a7359b8d7470168279e4ad1dd21… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:08:53+02:00 prefix_route: more debug messages - GH #4218 (cherry picked from commit 5aee159c2881aff29a2973073e1dd6c5c61bfdb9) - URL: https://github.com/kamailio/kamailio/commit/544866d63dcca50e47233ab878112f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:09:13+02:00 cdp: free in case of errors inside load_certificates() (cherry picked from commit 47aa53ebd55eba4b36c38329f8619d9f7d20c076) - URL: https://github.com/kamailio/kamailio/commit/6da6f0e25a902ad89ea293b7fddd8cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:09:27+02:00 ims_isc: free allocated route in case of error (cherry picked from commit 76a72a0092272d0f0ca7cf3df22ad6d05a79e782) - URL: https://github.com/kamailio/kamailio/commit/705aa5bdb4e1412b8ee5c7a54031dd0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:09:36+02:00 jsonrpcs: reworked closing tcp socket (cherry picked from commit d965b9242b313cb19f75baac12786d202a9987eb) - URL: https://github.com/kamailio/kamailio/commit/17f763a892e62387d945dd3c94a9189… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:09:54+02:00 sca: free in case of parse headers error (cherry picked from commit 6d658fe6c1af84368d093942356cf2b116ff17e5) - URL: https://github.com/kamailio/kamailio/commit/a18ea51273139bbc14efafe899aecfc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:10:06+02:00 misc/examples/ims/pcscf: location renamed to pcscf_location - GH #4177 - table has different name to avoid conflict with usrloc - pre-commit whitespaces fixes (cherry picked from commit dc269b336c863940514e538bc71a0ef3eb5961ff) - URL: https://github.com/kamailio/kamailio/commit/a4c3c463d5658f91012a9ecb55eb834… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:10:23+02:00 kamctl: version set to 6.0.0 (cherry picked from commit d54641a86656b782e3c8901c1c3ba6556248a4f5) - URL: https://github.com/kamailio/kamailio/commit/9f09bb8b029f6f64dba64ed7b81d1e9… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:10:29+02:00 kamdbclt: version set to 6.0.0 - spell fix (cherry picked from commit 607d713acfaadbb3b60ec1ba25c6eec101810c95) - URL: https://github.com/kamailio/kamailio/commit/d53bb2348099619669d080511d8c2b9… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:10:37+02:00 kamctl: spell fixes (cherry picked from commit 92917b5d3e69798ddb64c8cc40d3c4aa77f9659c) - URL: https://github.com/kamailio/kamailio/commit/99ac7b807fb6aad46087897b89da7d2… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:10:45+02:00 doc: spell fixes - mainly setup(n) <-> set(v) up distinction (cherry picked from commit c876f3f753cd48184bc1f11d6354a66cd7e6ccd3) - URL: https://github.com/kamailio/kamailio/commit/c01d4339ae199a5cbfb7c579d013f14… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:10:53+02:00 core: spell fixes - mainly setup(n) <-> set(v) up distinction (cherry picked from commit 7dbb45a1a8d4a98f439054ace33f041f1758bd96) - URL: https://github.com/kamailio/kamailio/commit/0b87a5492792741f6f9d2d3d95713c6… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:11:03+02:00 pkg/kamailio/deb: spell fixes - mainly setup(n) <-> set(v) up distinction (cherry picked from commit cb55765834b24da779d381531d1bc70c56deee3f) - URL: https://github.com/kamailio/kamailio/commit/0bddbd8c1525d73ad990d5cf97f332f… Author: Paul Donald <newtwen+github(a)gmail.com> Date: 2025-06-20T09:11:11+02:00 lib/srdb1: spell fixes - mainly setup(n) <-> set(v) up distinction (cherry picked from commit eefee7f917795bd4e6ffd049fbdfc0ebd166ab96) - URL: https://github.com/kamailio/kamailio/commit/5a9526f03b23bcc86f3983c5135e1c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:12:03+02:00 lost: clean allocated memory also for length 0 (cherry picked from commit c8217350f44a9ab897e3acdffbce1eb2a57fe1a2) - URL: https://github.com/kamailio/kamailio/commit/7e2ed561c12c172d9f3d6ce1c7f13d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:12:12+02:00 lib/ims: free before return on not finding the token (cherry picked from commit e0adeaa22ec64444773d75b0ef04fce19b44ef2b) - URL: https://github.com/kamailio/kamailio/commit/cafa2e0d74ae6ca1a27ee6aa604ddfa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:12:21+02:00 smsops: use global buffer for getting pv sms body (cherry picked from commit 4a20f89185d82515e1ac55f8cf12eec332723fc0) - URL: https://github.com/kamailio/kamailio/commit/2f05a38a11a80fe2f2617e8c219cc60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:12:49+02:00 core: utils/tmrec - decrement month for bymonth matching - struct tm uses 0-11, comparing with 1-12 in the date format - GH #4214 (cherry picked from commit 8f1a8c50ff230a1fffdd6b376f172cabe9fe60e3) - URL: https://github.com/kamailio/kamailio/commit/4c96282bdf3445d4fc8f4bbeac7ebdc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:13:54+02:00 core: utils/tmrec - reworked bymonth matching for negative indexes - GH #4214 (cherry picked from commit 2081b3aac394223b68b849fbac2a9e5ac4392334) - URL: https://github.com/kamailio/kamailio/commit/6e4100e11f49c02a9e319aa2ab269e5… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-20T09:15:01+02:00 secfilter: add missing RPC del_wl command Related #4089 (cherry picked from commit dca075fec723fa9d1d64997d6d5c0a992780c83c) - URL: https://github.com/kamailio/kamailio/commit/a1a65348974d7847af6637dedf31d92… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-20T09:15:07+02:00 secfilter: add RPC del_* commands [skip ci] Related #4089 (cherry picked from commit e87326297a30f2adeaa4936da4e1e30fa5a81dc8) - URL: https://github.com/kamailio/kamailio/commit/8ffc7f1e971e94e18facc000bf99084… Author: pepelux <pepeluxx(a)gmail.com> Date: 2025-06-20T09:15:34+02:00 secfilter: fix table of contents index points [skip ci] (cherry picked from commit 4ade5f53c1f7f6eb7357b0561b67928e39a91b9f) - URL: https://github.com/kamailio/kamailio/commit/ce23c88d710d38c785a328949695b8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:15:49+02:00 pv_headers: proper pointer comparison for returned value (cherry picked from commit c2f36a2c4f83b0ea077722ae6cc2fcecfb3616c1) - URL: https://github.com/kamailio/kamailio/commit/e85f97cee22fcc234c1918687ff38b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:15:59+02:00 drouting: rework expression to prevent value overflow (cherry picked from commit eee4431447789b2fc614144064dd61b97570e8bf) - URL: https://github.com/kamailio/kamailio/commit/9828b565e8646ab5ecebc128efb08a0… Author: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-06-20T09:16:31+02:00 core: sdp - update start pointer only after len adjustment - len is adjusted first by the amount of chars consumed so far - start pointer is adjusted to start new search (cherry picked from commit c9fbf6f46898dbb2a8413a1c9d824a56241f2288) - URL: https://github.com/kamailio/kamailio/commit/c8952f7e75b022d6319fd57acbc905c… Author: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-20T09:16:43+02:00 core: docs - Update type identifiers that can be used in the RPC API - format as well (cherry picked from commit 9a8ab3199488f02bd01e39bb6e13ef192321b37c) - URL: https://github.com/kamailio/kamailio/commit/ff2a85e9021bb1991156ad0ad912d7a… Author: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-20T09:16:55+02:00 cdp: Cast time_t and use 'L' (long long) identifier in rpc function. (cherry picked from commit 4e94572059d46b6bdd6726abfd52cb59793f5b03) - URL: https://github.com/kamailio/kamailio/commit/c941b9aa680618b5a72e8adf1e5e77f… Author: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-20T09:17:19+02:00 cdp: docs: Add missing list_peers function - Fix some typos - Remove unused section 7.2 (cherry picked from commit 11275ccb94cdddfec49191eaf80b2bc2f083c284) - URL: https://github.com/kamailio/kamailio/commit/877ed19b937aafc4fcdcb39f3dd07fe… Author: FelipeCuadra <f.cuadra(a)zaleos.net> Date: 2025-06-20T09:18:14+02:00 stirshaken: removed repeated x509 certification path check - removed a second check of the x509 certificate path from the module, since it is already done earlier in the library and updated documentation (cherry picked from commit f007736ba18f5cc2114ffdd1e6df2b9b03808fe7) - URL: https://github.com/kamailio/kamailio/commit/3884d9d3661ca17d5eeb8f731bdff66… Author: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-20T09:18:53+02:00 dialog: add missing documentation for optional limit parameter for list_match (cherry picked from commit c66d9f7298aa1d76d1905b3388e3e55023baa5ae) - URL: https://github.com/kamailio/kamailio/commit/656256019c08727c352d62f35303c5f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:19:33+02:00 pv_headers: compare the pvh_set_xavi() result with NULL (cherry picked from commit 87cfa9f3c5ae337dceb78654beb6fe4b00587993) - URL: https://github.com/kamailio/kamailio/commit/6974217dfd37a0097b4e27e2cb69929… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:19:41+02:00 tls: removed unnecessary code (cherry picked from commit 73dc08affb9d0a7a3f9ab83c24e01bada8958b2d) - URL: https://github.com/kamailio/kamailio/commit/7fa5f5d94d81b7517b71963c4de475f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:20:54+02:00 carrierroute: check pointer and length for str value (cherry picked from commit 423f46e6a68e241ef03f59f863ecf6dee92c07db) - URL: https://github.com/kamailio/kamailio/commit/761770e87b8f27bd8aa5dd46c23fa6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:21:00+02:00 pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag (cherry picked from commit 46548193144c0b8ab0bf2e3ecdfd7feb79bc3b2f) - URL: https://github.com/kamailio/kamailio/commit/b00a05bf7b0483d16b722b41e240720… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:21:11+02:00 dialog: check for message struct before accessing the fields - for build_dlg_t_early() (cherry picked from commit 5c38b53b902949fa48c3bc60288514cd7c555d5b) - URL: https://github.com/kamailio/kamailio/commit/36004e22f8a61becf75cb6b8e424190… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:21:25+02:00 pv_headers: set value after checking if src is set (cherry picked from commit 25daa0445ebc611cda3e47fd34aefc74494550d7) - URL: https://github.com/kamailio/kamailio/commit/ac74e0fae054e264fe8d64063fef477… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:30:54+02:00 ims_ipsec_pcscf: jump to error for clean up (cherry picked from commit f0291728b7fb623faf1d4de0f3152e782a6782ae) - URL: https://github.com/kamailio/kamailio/commit/d39f318b36cd468826887289651f87d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:31:33+02:00 core: helper functions to get/set msg env lists (cherry picked from commit 54a330bb707fb6b4943ba26356891696681a02e7) - URL: https://github.com/kamailio/kamailio/commit/0f9266684005a3c4f4748d72b8e8d54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:31:40+02:00 jansson: docs - added missing semicolon in the example (cherry picked from commit 7fed8f52391aaef43d5cb672f4821d50d4855830) - URL: https://github.com/kamailio/kamailio/commit/ffe19fc22151f63c310f71650a50c35… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:31:48+02:00 core: implement pop of lists from msg env (cherry picked from commit 465fda0f790e44e5484b2ef41363fb23fece3f41) - URL: https://github.com/kamailio/kamailio/commit/ff735b36117c13608d45c80749372e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:31:55+02:00 siptrace: reset x/avp lists after event route - GH #4258 (cherry picked from commit 5ee87b7905d931931dece44ec591d8e6bcf567e2) - URL: https://github.com/kamailio/kamailio/commit/14664939b8e7c054ac73af228a57b94… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:32:04+02:00 siptrace: reset x/avp lists after event route (cherry picked from commit 0195e86084ffbe5333310fc4206f4a6d01662a85) - URL: https://github.com/kamailio/kamailio/commit/980975e95219da00acdbde91343ff8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:32:12+02:00 userblocklist: docs - small typo (cherry picked from commit 81357b548b6e0cdf464361c2b1742d797f0d7e95) - URL: https://github.com/kamailio/kamailio/commit/e5d101f2385b20b98cb7f2e27a8c8ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:32:22+02:00 core: print default path to runtime dir on internals output (cherry picked from commit 730d6872054cb6218684d5e48af341c7c2749233) - URL: https://github.com/kamailio/kamailio/commit/082a07138b7b920cfda8ce52b4b611d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:32:57+02:00 tm: add defines for dlg cseq is_self field - DLG_SEQ_VALINIT (should be initialized), DLG_SEQ_VALSET (is set, but can be updated for requests within dialog), DLG_SEQ_VALNEW (is set, and ready to be used as new cseq number in generated request) (cherry picked from commit 73c8316bf89703156f241886554919339ac270d0) - URL: https://github.com/kamailio/kamailio/commit/39685ace68f52a0b5e96dc9b6e42479… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:33:04+02:00 dialog: use defined tockens for is_set field of local cseq structure for keepalives (cherry picked from commit 2492b92e49cfcd5f6828007b6a289b3f881dba69) - URL: https://github.com/kamailio/kamailio/commit/fa614b1cb8c638292e399fe4350b212… Author: Benjamin Tietz <tietz(a)sipgate.de> Date: 2025-06-20T09:34:09+02:00 tls: add WSS to RPC funtions - tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> (cherry picked from commit 9581e5b332bff8e61ed65c6ddd340a472cb1d93c) - URL: https://github.com/kamailio/kamailio/commit/0e9f67faef8408befffa3bf39580efc… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-20T09:34:33+02:00 core: tcp_send_timeout applied for outbound connections (cherry picked from commit 9105398413b4f9fab410482d9ebf5d82b6c3fb0a) - URL: https://github.com/kamailio/kamailio/commit/fd054f531e400653a1f13f3379257b7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:34:46+02:00 core: keep a stack of msg env data - GH #4258 (cherry picked from commit c10c1d7f0214105c01a300b4a69c58219e4c970a) - URL: https://github.com/kamailio/kamailio/commit/506f4fa7a8bb6768bd4f2ddf2bd419d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:34:54+02:00 siptrace: use the msg env data stack (cherry picked from commit f3a6f2ed539a4a0f287ba0bfee89bd44d2f1a781) - URL: https://github.com/kamailio/kamailio/commit/ebef3ae7185862339f6751bf4798802… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:35:02+02:00 sipdump: use the msg env data stack (cherry picked from commit 10c6f973b0f2334c6b2790d61efa1fc3ac282a01) - URL: https://github.com/kamailio/kamailio/commit/644669d61667b8bc4e484c80c12a8cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:35:11+02:00 core: destroy the x/avp lists on msg env data pop (cherry picked from commit 418a1017a58e87a9fe9085f75183bcbfba3f9022) - URL: https://github.com/kamailio/kamailio/commit/91182d61d5df9fefcb71893eaa71757… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:35:20+02:00 core: sdp - check if space is found for extracting session version (cherry picked from commit cdcb570e46101703f4963863c705345c7a3420ac) - URL: https://github.com/kamailio/kamailio/commit/b920a95701c4109089045d9bd9e2395… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:35:34+02:00 core: srapi - prototype function names set back for msg env push/pop (cherry picked from commit ec5ab51a7ba1c2a94515b8f28c546c9d7cf58b90) - URL: https://github.com/kamailio/kamailio/commit/b0089e25607d8724a1f5f3f0effa95e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:36:16+02:00 dispatcher: rename varaiable about strictest match with common prefix - init values (cherry picked from commit dfb5ef6f9d670a9ee2de223eac0a665f9e5cab71) - URL: https://github.com/kamailio/kamailio/commit/9ba402d3508034ef3111942b8f594cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:36:25+02:00 dispatcher: rework MIXSOCKPRPORT (16) matching mode - GH #4236 (cherry picked from commit 28cd81c9ad7a64ee8953ba9438756b88740b7820) - URL: https://github.com/kamailio/kamailio/commit/ab88793011826693e259699ea9fe1a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:36:36+02:00 htable: return true for sht_setxi() - GH #4283 (cherry picked from commit 9ded810b2dfe527db8d8be409fe1f34b002f3325) - URL: https://github.com/kamailio/kamailio/commit/7a4362f646cfa029c31e7a447beac15… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:36:52+02:00 core: parser - count diversion header body len based on last param - take in consideratio quoted param values (cherry picked from commit f789f6a5fa4d651ad3bcb657cb2a1dc765de6460) - URL: https://github.com/kamailio/kamailio/commit/c31ea2270f5b3ef43bb324f63b86c1f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:37:01+02:00 jwt: added to the notes about libjwt versions - module is not compatible with the new libjwt3 (cherry picked from commit 36c466bce5a57df72806a0915361612c32cc838e) - URL: https://github.com/kamailio/kamailio/commit/24e9e573eaa0e85abd4285103528d1e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:37:11+02:00 core: tcp - log message on message processing timeout made debug (cherry picked from commit 2af2c80fde4e82614846af9d817ab2bffa2d954d) - URL: https://github.com/kamailio/kamailio/commit/b3555bb2e5d4ea0ffa80c5f98dd0988… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:37:22+02:00 core: reformat structure with core pv exports (cherry picked from commit 076d9549a28295392c9a8ca0ce079f2a59ed4f1e) - URL: https://github.com/kamailio/kamailio/commit/8926a88d9011f0ec08b8e97f0858489… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:47:37+02:00 Revert "secfilter: fix table of contents index points [skip ci]" This reverts commit 8ffc7f1e971e94e18facc000bf99084f69b1f400. - URL: https://github.com/kamailio/kamailio/commit/7990d4bf35f7b79a74315ed775401d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:47:53+02:00 Revert "secfilter: add RPC del_* commands [skip ci]" This reverts commit a1a65348974d7847af6637dedf31d926cd09cffd. - URL: https://github.com/kamailio/kamailio/commit/265a2b6b7173944d38acf3e93a85ef2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:48:11+02:00 Revert "secfilter: add missing RPC del_wl command" This reverts commit 6e4100e11f49c02a9e319aa2ab269e5476fa3b9e.

1 0

git:master:d26fb80c: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: d26fb80c0e022287769c52aef91b269c2d59e787 URL: https://github.com/kamailio/kamailio/commit/d26fb80c0e022287769c52aef91b269… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-20T09:31:09+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/d26fb80c0e022287769c52aef91b269… Patch: https://github.com/kamailio/kamailio/commit/d26fb80c0e022287769c52aef91b269…

1 0

git:master:0f688caa: rtpengine: list undocumented params
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: 0f688caa76cbbaf7fc3ca4551a879fc77e961f9f URL: https://github.com/kamailio/kamailio/commit/0f688caa76cbbaf7fc3ca4551a879fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T09:29:12+02:00 rtpengine: list undocumented params --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0f688caa76cbbaf7fc3ca4551a879fc… Patch: https://github.com/kamailio/kamailio/commit/0f688caa76cbbaf7fc3ca4551a879fc… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index 5db8b68fd19..500cd0fb59d 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -2449,6 +2449,48 @@ modparam("rtpengine", "enable_dmq", 1) </example> </section> +<section id="rtpengine.p.dtmf_event_source_label"> + <title><varname>dtmf_event_source_label</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.dtmf_event_tags"> + <title><varname>dtmf_event_tags</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.dtmf_event_type"> + <title><varname>dtmf_event_type</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.dtmf_event_source_ip"> + <title><varname>dtmf_event_source_ip</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.dtmf_event_duration"> + <title><varname>dtmf_event_duration</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.dtmf_event_volume"> + <title><varname>dtmf_event_volume</varname> (str)</title> + <para> + </para> +</section> + +<section id="rtpengine.p.event_callback"> + <title><varname>event_callback</varname> (str)</title> + <para> + </para> +</section> + <section> <title>Functions</title> <section id="rtpengine.f.set_rtpengine_set">

1 0

git:master:2786c2fb: kex: formatted exported structures for stats and rpc
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: 2786c2fb3def1e4bc7d7e1f6ec001e4eb59a9ea9 URL: https://github.com/kamailio/kamailio/commit/2786c2fb3def1e4bc7d7e1f6ec001e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T08:58:53+02:00 kex: formatted exported structures for stats and rpc --- Modified: src/modules/kex/core_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/2786c2fb3def1e4bc7d7e1f6ec001e4… Patch: https://github.com/kamailio/kamailio/commit/2786c2fb3def1e4bc7d7e1f6ec001e4…

1 0

Re: [kamailio/kamailio] aaaa (2698244)
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

@sergey-safarov: do not use such commit messages when pushing to the repository, write meaningful details in the commit message. When merging, squash but still be sure such "random characters" or messages like "WIP 1" (seen in another commit by you) are not in the final commit message. The commit messages go in the release files (ie,. ChangeLog) and makes it look really like a not good development process. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/26982449b7dabe0413258a7602d8810… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/26982449b7dabe0413258a7602d88107c8f7e7d9/160433191(a)github.com>

1 0

git:master:b3a17751: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: b3a177515af96fe4cc4c0408d93cfb651c6031bb URL: https://github.com/kamailio/kamailio/commit/b3a177515af96fe4cc4c0408d93cfb6… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-20T08:31:10+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/b3a177515af96fe4cc4c0408d93cfb6… Patch: https://github.com/kamailio/kamailio/commit/b3a177515af96fe4cc4c0408d93cfb6…

1 0

git:master:8ab50bf8: dispatcher: docs for ds_mark_addr()
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: 8ab50bf8a7894e68909c5a81505f5b09e4345802 URL: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T08:16:03+02:00 dispatcher: docs for ds_mark_addr() --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0… Patch: https://github.com/kamailio/kamailio/commit/8ab50bf8a7894e68909c5a81505f5b0… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 5c36b3ff9f9..126ad986724 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1786,6 +1786,27 @@ failure_route[tryagain] { ... } ... +</programlisting> + </example> + </section> + <section id="dispatcher.f.ds_mark_addr"> + <title> + <function moreinfo="none">ds_mark_addr(state, setid, uri)</function> + </title> + <para> + Set the state to the target specified by setid and uri. The parameter + state can have same value as for ds_mark_dst(). All parameters can + contain variables. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>ds_mark_addr</function> usage</title> + <programlisting format="linespecific"> +... + ds_mark_addr("ip", "1", "sip:127.0.0.1:5080"); # set to inactive and probing +... </programlisting> </example> </section>

1 0

git:master:d85e63e7: dispatcher: added ds_mark_addr(state, group, uri)
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: d85e63e7c5fb422151ba0d8a08b47cedc4929d8d URL: https://github.com/kamailio/kamailio/commit/d85e63e7c5fb422151ba0d8a08b47ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T08:11:46+02:00 dispatcher: added ds_mark_addr(state, group, uri) - set the state of a target by group and address --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/d85e63e7c5fb422151ba0d8a08b47ce… Patch: https://github.com/kamailio/kamailio/commit/d85e63e7c5fb422151ba0d8a08b47ce…

1 0

git:master:62b18cdf: core: mod fixup - helper function for s-i-s parameters
by Daniel-Constantin Mierla 20 Jun '25

20 Jun '25

Module: kamailio Branch: master Commit: 62b18cdfb62721304e5f82fd71063303cff06641 URL: https://github.com/kamailio/kamailio/commit/62b18cdfb62721304e5f82fd7106330… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-20T08:11:46+02:00 core: mod fixup - helper function for s-i-s parameters --- Modified: src/core/mod_fix.c Modified: src/core/mod_fix.h --- Diff: https://github.com/kamailio/kamailio/commit/62b18cdfb62721304e5f82fd7106330… Patch: https://github.com/kamailio/kamailio/commit/62b18cdfb62721304e5f82fd7106330… --- diff --git a/src/core/mod_fix.c b/src/core/mod_fix.c index 767c6a45a82..900c982e3c1 100644 --- a/src/core/mod_fix.c +++ b/src/core/mod_fix.c @@ -930,6 +930,40 @@ int fixup_free_ssi(void **param, int param_no) } } +/** + * + */ +int fixup_sis(void **param, int param_no) +{ + switch(param_no) { + case 1: + return fixup_spve_null(param, 1); + case 2: + return fixup_igp_null(param, 1); + case 3: + return fixup_spve_null(param, 1); + default: + return E_UNSPEC; + } +} + +/** + * + */ +int fixup_free_sis(void **param, int param_no) +{ + switch(param_no) { + case 1: + return fixup_free_spve_null(param, 1); + case 2: + return fixup_free_igp_null(param, 1); + case 3: + return fixup_free_spve_null(param, 1); + default: + return E_UNSPEC; + } +} + /** * */ diff --git a/src/core/mod_fix.h b/src/core/mod_fix.h index 6ec0280ac70..f0e6f0e47f4 100644 --- a/src/core/mod_fix.h +++ b/src/core/mod_fix.h @@ -178,6 +178,9 @@ int fixup_free_ssi(void **param, int param_no); int fixup_sii(void **param, int param_no); int fixup_free_sii(void **param, int param_no); +int fixup_sis(void **param, int param_no); +int fixup_free_sis(void **param, int param_no); + int fixup_sssi(void **param, int param_no); int fixup_free_sssi(void **param, int param_no);

1 0

git:master:1f9b9f13: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 19 Jun '25

19 Jun '25

Module: kamailio Branch: master Commit: 1f9b9f1305da708461f392e979352464b9c4ee73 URL: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-19T20:31:10+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246… Patch: https://github.com/kamailio/kamailio/commit/1f9b9f1305da708461f392e97935246… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 32726636469..eecd8bb5f95 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -1235,10 +1235,13 @@ modparam("dispatcher", "ds_interval_mode", 7200) congestion ms. See also the description of the 'rweight' attribute in the 'Special Attributes' section. - + “12” - dispatch to all destination in setid at once (parallel + + “12” - dispatch to all destinations in setid at once (parallel forking). Note that the XAVPs are no longer set with the values of the destination records, no re-routing making sense - in this case. + in this case. A side effect is that marking the one + destination as inactive is not possible if the transaction + fails (which means that all branches failed, or in other + words, all the destinations were not answering the call). + “13” - latency optimized dispatching - The algorithm will load balance using round-robin prioritizing the gateways with the highest priority.

1 0

git:master:91133002: core: pv - added $defs(name) return defined value as string between double quotes
by Daniel-Constantin Mierla 19 Jun '25

19 Jun '25

Module: kamailio Branch: master Commit: 91133002b6a36a3d1a8c983bfdecf3f9ac9e4b85 URL: https://github.com/kamailio/kamailio/commit/91133002b6a36a3d1a8c983bfdecf3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-19T20:28:39+02:00 core: pv - added $defs(name) return defined value as string between double quotes - if not already enclosed in single or double quotes --- Modified: src/core/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/91133002b6a36a3d1a8c983bfdecf3f… Patch: https://github.com/kamailio/kamailio/commit/91133002b6a36a3d1a8c983bfdecf3f… --- diff --git a/src/core/pv_core.c b/src/core/pv_core.c index f577c4ba3a9..214d78891c6 100644 --- a/src/core/pv_core.c +++ b/src/core/pv_core.c @@ -212,6 +212,51 @@ static int pv_get_defv(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } +static int pv_parse_defs_name(pv_spec_p sp, str *in) +{ + if(in == NULL || in->s == NULL || sp == NULL) { + LM_ERR("INVALID DEF NAME\n"); + return -1; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = AVP_NAME_STR; + sp->pvp.pvn.u.isname.name.s = *in; + return 0; +} + +static int pv_get_defs(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + str *val = NULL; + str ret = STR_NULL; + + val = pp_define_get( + param->pvn.u.isname.name.s.len, param->pvn.u.isname.name.s.s); + + if(!val) { + return pv_get_null(msg, param, res); + } + + if(val->len < 2) { + return pv_get_strval(msg, param, res, val); + } + if((val->s[0] == '"' && val->s[val->len - 1] == '"') + || (val->s[0] == '\'' && val->s[val->len - 1] == '\'')) { + return pv_get_strval(msg, param, res, val); + } + + ret.s = pv_get_buffer(); + ret.len = pv_get_buffer_size(); + if(ret.len + 3 < val->len) { + return pv_get_null(msg, param, res); + } + ret.s[0] = '"'; + memcpy(ret.s + 1, val->s, val->len); + ret.len = val->len + 2; + ret.s[ret.len - 1] = '"'; + ret.s[ret.len] = '\0'; + return pv_get_strval(msg, param, res, &ret); +} + /* clang-format off */ /** * @@ -231,6 +276,8 @@ static pv_export_t core_pvs[] = { 0, 0, 0}, {STR_STATIC_INIT("defv"), PVT_OTHER, pv_get_defv, 0, pv_parse_defv_name, 0, 0, 0}, + {STR_STATIC_INIT("defs"), PVT_OTHER, pv_get_defs, 0, pv_parse_defs_name, + 0, 0, 0}, {{0, 0}, 0, 0, 0, 0, 0, 0, 0} };

1 0

git:master:1b62f165: dispatcher: docs - more details about using algorithm 12
by Daniel-Constantin Mierla 19 Jun '25

19 Jun '25

Module: kamailio Branch: master Commit: 1b62f165d541cf88fe37778f0e23232e45e86b3d URL: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-19T20:19:38+02:00 dispatcher: docs - more details about using algorithm 12 --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232… Patch: https://github.com/kamailio/kamailio/commit/1b62f165d541cf88fe37778f0e23232… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 3a6c26b41b7..5c36b3ff9f9 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1413,10 +1413,13 @@ modparam("dispatcher", "ds_interval_mode", 7200) </listitem> <listitem> <para> - <quote>12</quote> - dispatch to all destination in setid at + <quote>12</quote> - dispatch to all destinations in setid at once (parallel forking). Note that the XAVPs are no longer set with the values of the destination records, no re-routing - making sense in this case. + making sense in this case. A side effect is that marking the + one destination as inactive is not possible if the transaction fails + (which means that all branches failed, or in other words, all the + destinations were not answering the call). </para> </listitem> <listitem>

1 0

[kamailio/kamailio] ims_diameter_server not freeing shared memory (Issue #4116)
by MGrimby 19 Jun '25

19 Jun '25

### Description I have run in to an issue when sending diameter requests using the ims_diameter_server module. Shared memory keeps increasing and are not being freed until restart of kamailio. This leads to all shared memory is being used and no more are able to be allocated. This only happens when the request is sent synchronously. When sent asynchronously shared memory is being freed as far as I can see. Following functions have been used for sending requests. diameter_request([peer], appid, commandcode, message) diameter_request_async([peer], appid, commandcode, message) ### Troubleshooting Sent a bunch of diameter requests and verified that shared memory for the following functions are not freed. do_receive(600): AAATranslateMessage(500): AAACreateAVP(137): #### Reproduction It's possible to reproduce by sending sync diameter request and verify shared memory. Example of diameter request block ``` route[CHECK_LOCATION] { diameter_request("hss.ims.test.local", "16777217", "306", "[ " + "{ \"avpCode\":260, \"vendorId\":0, \"Flags\":64, \"list\":[ { \"avpCode\":266, \"vendorId\":0, \"Flags\":64, \"int32\":10415 }, { \"avpCode\":258, \"vendorId\":0, \"Flags\":64, \"int32\":16777217 } ] }, " + "{ \"avpCode\":277, \"vendorId\":0, \"Flags\":64, \"int32\":1 }, " + "{ \"avpCode\":283, \"vendorId\":0, \"Flags\":64, \"string\":\"ims.test.local\"}, " + "{ \"avpCode\":706, \"vendorId\":10415, \"Flags\":192, \"int32\":0 }, " + "{ \"avpCode\":700, \"vendorId\":10415, \"Flags\":192, \"list\": [ { \"avpCode\":601, \"vendorId\":10415, \"Flags\":192, \"string\":\"tel:" + $fU + "\" }]}, " + "{ \"avpCode\":707, \"vendorId\":10415, \"Flags\":192, \"int32\":0 }, " + "{ \"avpCode\":703, \"vendorId\":10415, \"Flags\":192, \"int32\":14 } ]"); xlog("L_INFO", "Sent Diameter request"); } ``` Stats cdp:replies_received = 343310 shmem:fragments = 142 shmem:free_size = 1221489992 shmem:max_used_size = 948242168 shmem:real_used_size = 925993656 shmem:total_size = 2147483648 shmem:used_size = 558205656 kamcmd mod.stats cdp shm do_receive(600): 256245808 AAATranslateMessage(500): 64420712 AAACreateAVP(137): 218100320 Total: 538774000 #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) dc393e flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: dc393e compiled on 13:56:27 Feb 27 2024 with gcc 8.5.0 ``` * **Operating System**:  ``` Linux bmatkamas1 4.18.0-553.16.1.el8_10.x86_64 #1 SMP Thu Aug 1 04:16:12 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux release 8.10 (Ootpa) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4116 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4116(a)github.com>

4 6

[kamailio/kamailio] rtpengine: make myseqn more random (Issue #4281)
by Christian Berger 18 Jun '25

18 Jun '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4281) ### Description The rtpengine module uses a `cookie` field in the Protocol controlling rtpengines. This field needs to be unique, and is derived from the `server_id` field set in the Kamailio, the `pid` as well as the value of a variable `myseqn`. In many conditions, this is random enough. However particularly when using docker, the `pid` will be identical across servers, reducing the randomness and causing collisions. ### Expected behavior The 34 bytes of the cookie should be as unique as possible. #### Actual observed behavior We get collisions many times per day, as different kamailio instances randomly choose the same value. ### Possible Solutions 1. Set `myseqn` to a random value during module load. 2. Add an additional random value to the `gencookie` function. 3. Use `%x` instead of `%d` to squeeze more entropy into the 33 characters available, and perhaps use fixed length fields. The problem probably also exists in the following other modules: 1. rtpproxy 2. lrkproxy We are not using those modules so we have not yet experienced collisions here. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4281 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4281(a)github.com>

2 5

git:master:4935196e: lrkproxy: improve randomness of cookie by using PNRG and random sequence numbers
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 4935196ee8ce1d99e77c614aaa0131a1972580ed URL: https://github.com/kamailio/kamailio/commit/4935196ee8ce1d99e77c614aaa0131a… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T11:10:02Z lrkproxy: improve randomness of cookie by using PNRG and random sequence numbers --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/4935196ee8ce1d99e77c614aaa0131a… Patch: https://github.com/kamailio/kamailio/commit/4935196ee8ce1d99e77c614aaa0131a… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index bc0a83f4e23..ef6a347105b 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -77,6 +77,7 @@ #include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "lrkproxy.h" #include "lrkproxy_hash.h" @@ -158,7 +159,6 @@ static void mod_destroy(void); static int lrkproxy_disable_tout = 60; static int lrkproxy_retr = 5; static int lrkproxy_tout = 1; -static pid_t mypid; static unsigned int myseqn = 0; //static str nolrkproxy_str = str_init("a=nolrkproxy:yes"); //static str extra_id_pv_param = {NULL, 0}; @@ -668,9 +668,10 @@ static int child_init(int rank) return 0; } - /* Iterate known LRK proxies - create sockets */ - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + /* Iterate known RTP proxies - create sockets */ lrkp_socks = (int *)pkg_malloc(sizeof(int) * lrkp_no); if(lrkp_socks == NULL) { LM_ERR("no more pkg memory\n"); @@ -791,7 +792,7 @@ static char *gencookie(void) { static char cook[34]; - sprintf(cook, "%d_%u ", (int)mypid, myseqn); + sprintf(cook, "%d_%u ", fastrand(), myseqn); myseqn++; return cook; }

1 0

git:master:04686c40: rtpproxy: improve randomness of cookie by using PNRG and random sequence numbers
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 04686c40d380e16e55c359cbc6bfc28f644a4c0b URL: https://github.com/kamailio/kamailio/commit/04686c40d380e16e55c359cbc6bfc28… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T11:09:38Z rtpproxy: improve randomness of cookie by using PNRG and random sequence numbers --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/04686c40d380e16e55c359cbc6bfc28… Patch: https://github.com/kamailio/kamailio/commit/04686c40d380e16e55c359cbc6bfc28… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 2057cdfba5d..02641ce2ce3 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -76,6 +76,7 @@ #include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "rtpproxy.h" #include "rtpproxy_funcs.h" @@ -153,7 +154,6 @@ static int pv_get_rtppstat_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int rtpproxy_disable_tout = 60; static int rtpproxy_retr = 5; static int rtpproxy_tout = 1; -static pid_t mypid; static unsigned int myseqn = 0; static str nortpproxy_str = str_init("a=nortpproxy:yes"); static str extra_id_pv_param = {NULL, 0}; @@ -788,9 +788,10 @@ static int child_init(int rank) return 0; } - /* Iterate known RTP proxies - create sockets */ - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + /* Iterate known RTP proxies - create sockets */ rtpp_socks = (int *)pkg_malloc(sizeof(int) * rtpp_no); if(rtpp_socks == NULL) { LM_ERR("no more pkg memory\n"); @@ -1206,7 +1207,7 @@ static char *gencookie(void) { static char cook[34]; - sprintf(cook, "%d_%u ", (int)mypid, myseqn); + sprintf(cook, "%u_%u ", fastrand(), myseqn); myseqn++; return cook; }

1 0

git:master:33b80fcc: rtpengine: improve randomness of cookie by using PNRG and random sequence numbers
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 33b80fcc4d84f955b29bd65bccee9ef2a62e7000 URL: https://github.com/kamailio/kamailio/commit/33b80fcc4d84f955b29bd65bccee9ef… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T11:08:12Z rtpengine: improve randomness of cookie by using PNRG and random sequence numbers --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/33b80fcc4d84f955b29bd65bccee9ef… Patch: https://github.com/kamailio/kamailio/commit/33b80fcc4d84f955b29bd65bccee9ef… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 292843302fe..e7d6cf9d5b9 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -83,6 +83,7 @@ #include "../../core/char_msg_val.h" #include "../../core/utils/srjson.h" #include "../../core/cfg/cfg_struct.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "../../modules/crypto/api.h" #include "../../modules/lwsc/api.h" @@ -327,7 +328,7 @@ static void parse_call_stats(bencode_item_t *, struct sip_msg *); static int control_cmd_tos = -1; static int rtpengine_allow_op = 0; static struct rtpp_node **queried_nodes_ptr = NULL; -static pid_t mypid; + static unsigned int myseqn = 0; static str extra_id_pv_param = {NULL, 0}; static char *setid_avp_param = NULL; @@ -3028,6 +3029,8 @@ static int mos_label_stats_parse(struct minmax_mos_label_stats *mmls) static int child_init(int rank) { + pid_t mypid = 0; + if(!rtpp_set_list) return 0; @@ -3038,7 +3041,7 @@ static int child_init(int rank) if(rank == PROC_MAIN) { if(rtpengine_dtmf_event_sock.len > 0) { - LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid); + LM_DBG("Register RTPENGINE DTMF WORKER %d\n", getpid()); /* fork worker process */ mypid = fork_process(PROC_RPC, "RTPENGINE DTMF WORKER", 1); if(mypid < 0) { @@ -3060,7 +3063,9 @@ static int child_init(int rank) return 0; } - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + LM_ERR("myseqn %u\n", myseqn); // vector of pointers to queried nodes queried_nodes_ptr = (struct rtpp_node **)pkg_malloc( @@ -3171,7 +3176,7 @@ static char *gencookie(void) { static char cook[34]; - snprintf(cook, 34, "%d_%d_%u ", server_id, (int)mypid, myseqn); + snprintf(cook, 34, "%d_%u_%u ", server_id, fastrand(), myseqn); myseqn++; return cook; }

1 0

git:master:300da5c5: core: improve random number generator initialization
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 300da5c5a166be6724ebe14be29ac97d029c535f URL: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T10:34:52Z core: improve random number generator initialization - move seeding of cryptographic randomness generator for system randomness to the specific generator - improve seeding of children random number generators by using individual initialized secure generators - don't add predictable values like system time or process pid to the seed values of children generators --- Modified: src/core/pt.c Modified: src/core/rand/cryptorand.c Modified: src/core/rand/cryptorand.h Modified: src/core/rand/fortuna/fortuna.c Modified: src/core/rand/fortuna/fortuna.h Modified: src/core/rand/fortuna/random.c Modified: src/core/rand/fortuna/random.h Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97… Patch: https://github.com/kamailio/kamailio/commit/300da5c5a166be6724ebe14be29ac97…

1 0

[kamailio/kamailio] tm: Emit event only when CANCEL request is locally generated (PR #4286)
by Xenofon Karamanos 18 Jun '25

18 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3831 and #4249 #### Description  This PR intoduces a flag for the tm cancel logic. The flag denotes that the cancel request is locally generated and an event of `local_request` should be emmited. Updated also the modules and functions that used tm bindings to adopt for this change. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4286 -- Commit Summary -- * tm: Generate local_request for CANCEL only if locally initiated * dialog: Update to use new tm FLAG for CANCEL * rtp_media_server: Update to use new tm FLAG for CANCEL * tmx: Update to use new tm FLAG for CANCEL -- File Changes -- M src/modules/dialog/dlg_req_within.c (2) M src/modules/rtp_media_server/rtp_media_server.c (2) M src/modules/tm/t_cancel.c (69) M src/modules/tm/t_cancel.h (2) M src/modules/tmx/tmx_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4286.patch https://github.com/kamailio/kamailio/pull/4286.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4286 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4286(a)github.com>

3 3

[kamailio/kamailio] dlgs: Fix spelling mistake (PR #4288)
by Xenofon Karamanos 18 Jun '25

18 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix a spelling mistake You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4288 -- Commit Summary -- * dlgs: Fix spelling mistake -- File Changes -- M src/modules/dlgs/dlgs_records.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4288.patch https://github.com/kamailio/kamailio/pull/4288.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4288 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4288(a)github.com>

3 5

git:5.8:ae4342ad: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 5.8 Commit: ae4342ad20a0e98681f83f1874294869d930e99d URL: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:44:43Z dlgs: Fix spelling mistake (cherry picked from commit 994d4dfa9cd284f63092543400a5ed82b746a758) --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… Patch: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:6.0:c0e60449: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: c0e60449ae0d35fd9e753d0da92c98c03e2a4494 URL: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:41:37Z dlgs: Fix spelling mistake (cherry picked from commit 994d4dfa9cd284f63092543400a5ed82b746a758) --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… Patch: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:6.0:0637ca7e: tmx: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 0637ca7e0b7795c33ab9f230c0eee65d6ea80e8d URL: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:40:39Z tmx: Update to use new tm FLAG for CANCEL (cherry picked from commit caad49279e6db7e85e3f2b84276f9defb0aa4eef) --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… Patch: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index aae6547834d..4e1e7c78289 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -333,7 +333,7 @@ static int t_cancel_branches_helper(sip_msg_t *msg, int n) LM_DBG("canceling %d/%d\n", n, (int)cancel_data.cancel_bitmap); if(cancel_data.cancel_bitmap == 0) return -1; - _tmx_tmb.cancel_uacs(t, &cancel_data, 0); + _tmx_tmb.cancel_uacs(t, &cancel_data, F_CANCEL_LOCAL); return 1; } @@ -408,7 +408,7 @@ static int ki_t_cancel_callid_reason( cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); + _tmx_tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); //_tmx_tmb.unref_cell(trans); _tmx_tmb.t_sett(bkt, bkb);

1 0

git:6.0:c3160efc: rtp_media_server: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: c3160efc9b4af01d8e2997fdc6cb168838f76ba9 URL: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:41Z rtp_media_server: Update to use new tm FLAG for CANCEL (cherry picked from commit fc5f804ad92593f74110a9392d63384e04fed218) --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… Patch: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 720c4afd900..21abb7fb836 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -1024,7 +1024,7 @@ static int rms_sip_cancel(struct sip_msg *msg, str *callid_s, str *cseq_s) cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - tmb.cancel_uacs(trans, &cancel_data, 0); + tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); tmb.t_sett(bkt, bkb); if(!tmb.t_reply(msg, 202, "cancelling")) {

1 0

git:6.0:5d82b77a: dialog: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 5d82b77ad9852d8d584edef97ec11e16879a1fd6 URL: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:33Z dialog: Update to use new tm FLAG for CANCEL (cherry picked from commit 9740f5ea7ee0b9827cf3e113bc1c458f72b8cbf7) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… Patch: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 773ae788e3b..57c2df5475e 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -407,7 +407,7 @@ static inline int send_bye( LM_DBG("\"%d %.*s\" sent to caller\n", bye_early_code, bye_early_reason.len, bye_early_reason.s); } else { - d_tmb.cancel_all_uacs(cell->t, 0); + d_tmb.cancel_all_uacs(cell->t, F_CANCEL_LOCAL); LM_DBG("CANCEL sent to callee(s)\n"); } return 0;

1 0

git:6.0:835a3b60: tm: Generate local_request for CANCEL only if locally initiated
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 835a3b60607db381b3941b308f00c0469fcaf021 URL: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:21Z tm: Generate local_request for CANCEL only if locally initiated - Introduce new flag F_CANCEL_LOCAL (cherry picked from commit 49ffcebdf6cbf8ce2e4e2e55d9197b906f74ff95) --- Modified: src/modules/tm/t_cancel.c Modified: src/modules/tm/t_cancel.h --- Diff: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… Patch: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index d4f1be0eaca..e3114c70d0e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -338,44 +338,47 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, LM_DBG("sending cancel...\n"); - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, evname.s); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); + if(flags & F_CANCEL_LOCAL) { + /* Call event */ + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } } - } - // /* Check if msg is null */ - if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { - LM_ERR("fail to parse msg\n"); - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - LM_DBG("tm:local-request found [%d]\n", rt); - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { + /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_DBG("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } } } + set_route_type(backup_rt); + free_sip_msg(&msg); } - set_route_type(backup_rt); - free_sip_msg(&msg); if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) @@ -429,7 +432,7 @@ void rpc_cancel(rpc_t *rpc, void *c) prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); /* tell tm to cancel the call */ DBG("Now calling cancel_uacs\n"); - i = cancel_uacs(trans, &cancel_data, 0); /* don't fake 487s, + i = cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); /* don't fake 487s, just wait for timeout */ /* t_lookup_callid REF`d the transaction for us, we must UNREF here! */ diff --git a/src/modules/tm/t_cancel.h b/src/modules/tm/t_cancel.h index b80a6dba77b..d5042edd97d 100644 --- a/src/modules/tm/t_cancel.h +++ b/src/modules/tm/t_cancel.h @@ -65,6 +65,8 @@ and F_CANCE_B_KILL take precedence */ #define F_CANCEL_UNREF 16 /* unref the trans after canceling */ +#define F_CANCEL_LOCAL 32 /* cancel is locally generated */ + void prepare_to_cancel(struct cell *t, branch_bm_t *cancel_bm, branch_bm_t s); int cancel_uacs(struct cell *t, struct cancel_info *cancel_data, int flags);

1 0

[kamailio/kamailio] cmake format options and naming styles (Issue #4075)
by Daniel-Constantin Mierla 18 Jun '25

18 Jun '25

Discussion to define cmake format options and coding/naming styles. It is better to define most of them now to have coherency in the future. Started from the discussion on #4066. Comment with what you would like to have, describing when useful why your proposal is a good/better option. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4075 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4075(a)github.com>

5 12

git:master:994d4dfa: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 994d4dfa9cd284f63092543400a5ed82b746a758 URL: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-06-18T11:11:26+03:00 dlgs: Fix spelling mistake --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… Patch: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:master:caad4927: tmx: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: caad49279e6db7e85e3f2b84276f9defb0aa4eef URL: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 tmx: Update to use new tm FLAG for CANCEL --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… Patch: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index aae6547834d..4e1e7c78289 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -333,7 +333,7 @@ static int t_cancel_branches_helper(sip_msg_t *msg, int n) LM_DBG("canceling %d/%d\n", n, (int)cancel_data.cancel_bitmap); if(cancel_data.cancel_bitmap == 0) return -1; - _tmx_tmb.cancel_uacs(t, &cancel_data, 0); + _tmx_tmb.cancel_uacs(t, &cancel_data, F_CANCEL_LOCAL); return 1; } @@ -408,7 +408,7 @@ static int ki_t_cancel_callid_reason( cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); + _tmx_tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); //_tmx_tmb.unref_cell(trans); _tmx_tmb.t_sett(bkt, bkb);

1 0

git:master:fc5f804a: rtp_media_server: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: fc5f804ad92593f74110a9392d63384e04fed218 URL: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 rtp_media_server: Update to use new tm FLAG for CANCEL --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… Patch: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 720c4afd900..21abb7fb836 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -1024,7 +1024,7 @@ static int rms_sip_cancel(struct sip_msg *msg, str *callid_s, str *cseq_s) cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - tmb.cancel_uacs(trans, &cancel_data, 0); + tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); tmb.t_sett(bkt, bkb); if(!tmb.t_reply(msg, 202, "cancelling")) {

1 0

git:master:9740f5ea: dialog: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 9740f5ea7ee0b9827cf3e113bc1c458f72b8cbf7 URL: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 dialog: Update to use new tm FLAG for CANCEL --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… Patch: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 48494bef428..1e7c71c17f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -407,7 +407,7 @@ static inline int send_bye( LM_DBG("\"%d %.*s\" sent to caller\n", bye_early_code, bye_early_reason.len, bye_early_reason.s); } else { - d_tmb.cancel_all_uacs(cell->t, 0); + d_tmb.cancel_all_uacs(cell->t, F_CANCEL_LOCAL); LM_DBG("CANCEL sent to callee(s)\n"); } return 0;

1 0

git:master:49ffcebd: tm: Generate local_request for CANCEL only if locally initiated
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 49ffcebdf6cbf8ce2e4e2e55d9197b906f74ff95 URL: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 tm: Generate local_request for CANCEL only if locally initiated - Introduce new flag F_CANCEL_LOCAL --- Modified: src/modules/tm/t_cancel.c Modified: src/modules/tm/t_cancel.h --- Diff: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… Patch: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index d4f1be0eaca..e3114c70d0e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -338,44 +338,47 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, LM_DBG("sending cancel...\n"); - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, evname.s); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); + if(flags & F_CANCEL_LOCAL) { + /* Call event */ + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } } - } - // /* Check if msg is null */ - if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { - LM_ERR("fail to parse msg\n"); - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - LM_DBG("tm:local-request found [%d]\n", rt); - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { + /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_DBG("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } } } + set_route_type(backup_rt); + free_sip_msg(&msg); } - set_route_type(backup_rt); - free_sip_msg(&msg); if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) @@ -429,7 +432,7 @@ void rpc_cancel(rpc_t *rpc, void *c) prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); /* tell tm to cancel the call */ DBG("Now calling cancel_uacs\n"); - i = cancel_uacs(trans, &cancel_data, 0); /* don't fake 487s, + i = cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); /* don't fake 487s, just wait for timeout */ /* t_lookup_callid REF`d the transaction for us, we must UNREF here! */ diff --git a/src/modules/tm/t_cancel.h b/src/modules/tm/t_cancel.h index b80a6dba77b..d5042edd97d 100644 --- a/src/modules/tm/t_cancel.h +++ b/src/modules/tm/t_cancel.h @@ -65,6 +65,8 @@ and F_CANCE_B_KILL take precedence */ #define F_CANCEL_UNREF 16 /* unref the trans after canceling */ +#define F_CANCEL_LOCAL 32 /* cancel is locally generated */ + void prepare_to_cancel(struct cell *t, branch_bm_t *cancel_bm, branch_bm_t s); int cancel_uacs(struct cell *t, struct cancel_info *cancel_data, int flags);

1 0

git:master:7dc92ed5: modules: readme files regenerated - rr ... [skip ci]
by Kamailio Dev 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 7dc92ed5a45e004cc1dc6898a9027d265e220721 URL: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-17T22:16:09+02:00 modules: readme files regenerated - rr ... [skip ci] --- Modified: src/modules/rr/README --- Diff: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… Patch: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… --- diff --git a/src/modules/rr/README b/src/modules/rr/README index 0fc41c9767a..1919d7a6e84 100644 --- a/src/modules/rr/README +++ b/src/modules/rr/README @@ -466,13 +466,16 @@ if(!loose_route_preloaded()) { 5.3. loose_route_mode(vmode) - The function is similar to `loose_route()`, but it does only loose - routing processing if vmode==1, skipping the testing of r-uri==myself - for performing strict routing. If vmode==0, it behaves like - loose_route(). + The function is similar to `loose_route()`, but it accepts route mode + bitmask as vmode parameter. - It is a convenient function to use with application servers that set - the Contact URI to SIP server address. + If bit one is set, then do only loose routing processing, skipping the + testing of r-uri==myself for performing strict routing. If not, behave + like loose_route(). If bit two is set, then skip flow tokens + processing. + + First bit is convenient to use with application servers that set the + Contact URI to SIP server address. This function can be used from REQUEST_ROUTE.

1 0

[kamailio/kamailio] rr: add force_lr_no_outbound_flag param (PR #4280)
by Michael Furmur 17 Jun '25

17 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description `loose_route()` in `rr` checks request src ip/port against ip/port in flow tokens to detect direction and decide whether to apply flow tokens routing: ``` static inline int process_outbound(struct sip_msg *_m, str flow_token) { ... } else if(!ip_addr_cmp(&rcv->src_ip, &_m->rcv.src_ip) || rcv->src_port != _m->rcv.src_port) { LM_DBG("\"incoming\" request found. Using flow-token for " "routing\n"); ... ``` there are cases when remote UA changes ip/port for in-dialog messages and this approach does not work. incoming message has route set with flow tokens and src ip/port different from ones in the flow tokens. as a result, `loose_route()` routes message back to the client using flow tokens instead of using the normal part of the Route headers as expected. new `force_lr_no_outbound_flag` allows to control flow tokens usage in the `loose_route()` when we know direction based on the some high level config logic (for example: by the result of `ds_is_from_list()` call) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4280 -- Commit Summary -- * rr: add force_lr_no_outbound_flag param -- File Changes -- M src/modules/rr/doc/rr_admin.xml (17) M src/modules/rr/loose.c (6) M src/modules/rr/rr_mod.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4280.patch https://github.com/kamailio/kamailio/pull/4280.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4280 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4280(a)github.com>

2 5

git:master:eef8d69b: rr: loose_route_mode: add vmode bit 2 to skip outbound
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: eef8d69bc88bac394d7134ab9f591cdea3b4914b URL: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T22:02:15+02:00 rr: loose_route_mode: add vmode bit 2 to skip outbound --- Modified: src/modules/rr/doc/rr_admin.xml Modified: src/modules/rr/loose.c Modified: src/modules/rr/rr_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… Patch: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… --- diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml index 4801b845dfb..4a2921fce32 100644 --- a/src/modules/rr/doc/rr_admin.xml +++ b/src/modules/rr/doc/rr_admin.xml @@ -446,11 +446,16 @@ if(!loose_route_preloaded()) { <section id="rr.f.loose_route_mode"> <title><function moreinfo="none">loose_route_mode(vmode)</function></title> - <para>The function is similar to `loose_route()`, but it does only - loose routing processing if vmode==1, skipping the testing of r-uri==myself - for performing strict routing. If vmode==0, it behaves like loose_route(). + <para>The function is similar to `loose_route()`, + but it accepts route mode bitmask as <emphasis>vmode</emphasis> parameter. </para> - <para>It is a convenient function to use with application servers that + <para> + If bit one is set, then do only loose routing processing, skipping the testing of r-uri==myself + for performing strict routing. If not, behave like loose_route(). + If bit two is set, then skip flow tokens processing. + </para> + <para> + First bit is convenient to use with application servers that set the Contact URI to SIP server address. </para> <para>This function can be used from REQUEST_ROUTE.</para> diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index 23378147903..443f90b17f4 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -854,7 +854,7 @@ static inline void rr_do_force_send_socket( * \param preloaded do we have a preloaded route set * \return -1 on failure, 1 on success */ -static inline int after_loose(struct sip_msg *_m, int preloaded) +static inline int after_loose(struct sip_msg *_m, int _mode, int preloaded) { struct hdr_field *hdr; struct sip_uri puri; @@ -890,9 +890,11 @@ static inline int after_loose(struct sip_msg *_m, int preloaded) routed_msg_id.msgid = _m->id; routed_msg_id.pid = _m->pid; - if((use_ob = process_outbound(_m, puri.user)) < 0) { - LM_INFO("failed to process outbound flow-token\n"); - return RR_FLOW_TOKEN_BROKEN; + if(!(_mode & RR_LR_MODE_SKIP_OUTBOUND)) { + if((use_ob = process_outbound(_m, puri.user)) < 0) { + LM_INFO("failed to process outbound flow-token\n"); + return RR_FLOW_TOKEN_BROKEN; + } } if(rr_force_send_socket && !use_ob) { @@ -1050,12 +1052,12 @@ int loose_route_mode(sip_msg_t *_m, int _mode) if(ret < 0) { return -1; } else if(ret == 1) { - return after_loose(_m, 1); + return after_loose(_m, _mode, 1); } else { - if((_mode == 0) && (is_myself(&_m->parsed_uri))) { + if((!(_mode & RR_LR_MODE_LOOSE_ONLY)) && (is_myself(&_m->parsed_uri))) { return after_strict(_m); } else { - return after_loose(_m, 0); + return after_loose(_m, _mode, 0); } } } diff --git a/src/modules/rr/rr_mod.h b/src/modules/rr/rr_mod.h index 829e912e499..a411625824c 100644 --- a/src/modules/rr/rr_mod.h +++ b/src/modules/rr/rr_mod.h @@ -36,6 +36,11 @@ extern str i_user; #endif +/*! bit to force loose mode in loose_route_mode() */ +#define RR_LR_MODE_LOOSE_ONLY 1 +/*! bit to skip outbound processing in after_loose() */ +#define RR_LR_MODE_SKIP_OUTBOUND 2 + /*! should request's from-tag is appended to record-route */ extern int append_fromtag; /*! insert two record-route header instead of one */

1 0

git:master:72699b5d: core: added $defv(name) variable
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 72699b5d85bc1ca8b487749798ed8e93622d1686 URL: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T19:42:24+02:00 core: added $defv(name) variable - return the unquoted value of the define 'name' - unquotes in both cases of single and double quotes - if no quotes enclose the defined value, then the value is returned as it is --- Modified: src/core/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… Patch: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… --- diff --git a/src/core/pv_core.c b/src/core/pv_core.c index 87bf4cc91d3..f577c4ba3a9 100644 --- a/src/core/pv_core.c +++ b/src/core/pv_core.c @@ -28,6 +28,7 @@ #include "pv_core.h" #include "pvar.h" +#include "pvapi.h" #include "ppcfg.h" #include "str.h" #include "mem/pkg.h" @@ -168,6 +169,49 @@ static int pv_get_defn(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } +static int pv_parse_defv_name(pv_spec_p sp, str *in) +{ + if(in == NULL || in->s == NULL || sp == NULL) { + LM_ERR("INVALID DEF NAME\n"); + return -1; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = AVP_NAME_STR; + sp->pvp.pvn.u.isname.name.s = *in; + return 0; +} + +static int pv_get_defv(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + str *val = NULL; + str ret = STR_NULL; + + val = pp_define_get( + param->pvn.u.isname.name.s.len, param->pvn.u.isname.name.s.s); + + if(!val) { + return pv_get_null(msg, param, res); + } + + if(val->len < 2) { + return pv_get_strval(msg, param, res, val); + } + if((val->s[0] == '"' && val->s[val->len - 1] == '"') + || (val->s[0] == '\'' && val->s[val->len - 1] == '\'')) { + ret.s = pv_get_buffer(); + ret.len = pv_get_buffer_size(); + if(ret.len < val->len) { + return pv_get_null(msg, param, res); + } + memcpy(ret.s, val->s + 1, val->len - 2); + ret.len = val->len - 2; + ret.s[ret.len] = '\0'; + return pv_get_strval(msg, param, res, &ret); + } else { + return pv_get_strval(msg, param, res, val); + } +} + /* clang-format off */ /** * @@ -185,6 +229,8 @@ static pv_export_t core_pvs[] = { 0, 0}, {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, 0, 0, 0}, + {STR_STATIC_INIT("defv"), PVT_OTHER, pv_get_defv, 0, pv_parse_defv_name, + 0, 0, 0}, {{0, 0}, 0, 0, 0, 0, 0, 0, 0} };

1 0

git:master:076d9549: core: reformat structure with core pv exports
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 076d9549a28295392c9a8ca0ce079f2a59ed4f1e URL: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T19:23:13+02:00 core: reformat structure with core pv exports --- Modified: src/core/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… Patch: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… --- diff --git a/src/core/pv_core.c b/src/core/pv_core.c index c889f7572b7..87bf4cc91d3 100644 --- a/src/core/pv_core.c +++ b/src/core/pv_core.c @@ -168,24 +168,27 @@ static int pv_get_defn(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } +/* clang-format off */ /** * */ static pv_export_t core_pvs[] = { - /* return code, various synonims */ - {STR_STATIC_INIT("?"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("rc"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("retcode"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("env"), PVT_OTHER, pv_get_env, 0, pv_parse_env_name, 0, - 0, 0}, - {STR_STATIC_INIT("envn"), PVT_OTHER, pv_get_envn, 0, pv_parse_envn_name, - 0, 0, 0}, - {STR_STATIC_INIT("def"), PVT_OTHER, pv_get_def, 0, pv_parse_def_name, 0, - 0, 0}, - {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, - 0, 0, 0}, - - {{0, 0}, 0, 0, 0, 0, 0, 0, 0}}; + /* return code, various synonims */ + {STR_STATIC_INIT("?"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("rc"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("retcode"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("env"), PVT_OTHER, pv_get_env, 0, pv_parse_env_name, 0, + 0, 0}, + {STR_STATIC_INIT("envn"), PVT_OTHER, pv_get_envn, 0, pv_parse_envn_name, + 0, 0, 0}, + {STR_STATIC_INIT("def"), PVT_OTHER, pv_get_def, 0, pv_parse_def_name, 0, + 0, 0}, + {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, + 0, 0, 0}, + + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; +/* clang-format on */ /** * register built-in core pvars.

1 0

[kamailio/kamailio] [outbound] use_outbound_register logs empty Contact for unREGISTER with `Contact: *` (Issue #4242)
by George Diamantopoulos 17 Jun '25

17 Jun '25

gedia created an issue (kamailio/kamailio#4242)  ### Description This is definitely not high priority, just a nuisance when auditing logs for actionable events. The following is logged (see Log Messages section below) on edge proxies when the outbound module is loaded and the REGISTER contains: ``` Contact: * Expires: 0 ``` AFAIK this is legit when a UAC asks that all their contacts be removed from the location database. ### Troubleshooting #### Reproduction Force a UAC to send an unREGISTER towards an outbound-capable kamailio edge proxy. #### Log Messages ``` outbound [outbound_mod.c:325]: use_outbound_register(): empty Contact: ``` #### SIP Traffic  See description ### Possible Solutions  I'm not sure what the best approach would be here, but I'm thinking one of the following: * Either handle this case gracefully (contact is * in REGISTER with Expires=0), without logging anything, unless there's some misbehaviour here by the UAC I'm not aware of regarding outbound and unREGISTER behaviour * Or, log this in a more verbose level (e.g. debug), when contact parsing fails due to it being set to '*' ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**:  ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye Linux lbpub0-tis0-cn1 5.10.0-21-amd64 #1 SMP Debian 5.10.162-1 (2023-01-21) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4242 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4242(a)github.com>

3 4

[kamailio/kamailio] outbound: Use outbound if Register contains Contacts:* and Expires:0 (PR #4279)
by Xenofon Karamanos 17 Jun '25

17 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4242 #### Description  This PR fixes the invalid case of empy Contact. Contact:* and expires:0 is valid and should be handled accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4279 -- Commit Summary -- * outbound: Use outbound if Register contains Contacts:* and Expires:0 -- File Changes -- M src/modules/outbound/outbound_mod.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4279.patch https://github.com/kamailio/kamailio/pull/4279.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4279 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4279(a)github.com>

3 2

git:master:b4516591: outbound: Use outbound if Register contains Contacts:* and Expires:0
by Henning Westerholt 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: b45165919ea2ab0f361a6e0a94c71e10739cd573 URL: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-17T09:09:49+02:00 outbound: Use outbound if Register contains Contacts:* and Expires:0 --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… Patch: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index a5f17e4ef99..1524b9b4417 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -38,6 +38,7 @@ #include "../../core/sr_module.h" #include "../../core/counters.h" #include "../../core/parser/contact/parse_contact.h" +#include "../../core/parser/parse_expires.h" #include "../../core/parser/parse_rr.h" #include "../../core/parser/parse_uri.h" #include "../../core/parser/parse_supported.h" @@ -324,6 +325,14 @@ static int use_outbound_register(struct sip_msg *msg) LM_ERR("parsing Contact: header body\n"); return 0; } + + if(((contact_body_t *)msg->contact->parsed)->star + && ((exp_body_t *)msg->expires->parsed)->val == 0) { + LM_DBG("found REGISTER with * in Contact: header body and Expires " + ": 0 - outbound used\n"); + return 1; + } + contact = ((contact_body_t *)msg->contact->parsed)->contacts; if(!contact) { LM_ERR("empty Contact:\n");

1 0

[kamailio/kamailio] dispatcher: ds_is_from_list() with mode flag 16 provides only exact matches (Issue #4236)
by Gianluca Merlo 16 Jun '25

16 Jun '25

giangi created an issue (kamailio/kamailio#4236) ### Description The mode flag value 16 (int) in `ds_is_from_list()` is supposed to provide a "best matching" candidate, however it does not seem to recognize anything other than exact matches. ### Troubleshooting #### Reproduction With the following `dispatcher.list` ``` # setid(int) destination(sip uri) flags(int,opt) priority(int,opt) attributes(str,opt) 1 sip:127.1.2.3:5060 1 sip:127.1.2.3:5060;transport=tcp ``` The following invocations result in a match ``` ds_is_from_list("-1", "16", "sip:127.1.2.3:5060"); ds_is_from_list("-1", "16", "sip:127.1.2.3:5060;transport=tcp"); ``` while others, e.g. some with some mismatching ports, but a valid address, fail to match ``` ds_is_from_list("-1", "16", "sip:127.1.2.3:12345"); ds_is_from_list("-1", "16", "sip:127.1.2.3:12345;transport=tcp"); ``` ### Possible Solutions The code of `ds_is_addr_from_set()` from `src/modules/dispatcher/dispatch.c` has some suspicious `continue` while evaluating the "strictness score" of nodes and deciding upon the best match. If I am not mistaken they may cause the code that updates the `ds_strictest_node` to never get executed, thus not providing any match at all. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: Debian 12 "bookworm" -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4236 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4236(a)github.com>

2 3

[kamailio/kamailio] execution in event_route takes too much time (Issue #4285)
by Sergii 16 Jun '25

16 Jun '25

Serg1289 created an issue (kamailio/kamailio#4285) In case of event below, script execution takes too much time (40 sec): _event_route[dispatcher:dst-down] { exec_msg("/bin/bash -c '/usr/local/etc/kamailio/ipassign.sh &'"); }_ In case I run this script from shell it takes ~2 sec. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4285 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4285(a)github.com>

2 3

[kamailio/kamailio] TOPOS removes via header when calling drop in event_route[topos:msg-outgoing] (Issue #4157)
by Brandon Armstead 16 Jun '25

16 Jun '25

CrazyTux created an issue (kamailio/kamailio#4157) ### TOPOS removes via header ``` event_route[topos:msg-outgoing] { # Feature Flag is enabled ** problem occurs here ** if($sht(feature_flags=>kamailio-disable-internal-topos) == "true") { if(ds_is_from_list(KAM_SET_ID, 3, "sip:$sndto(ip):5060")) { drop; } } } ``` ### Troubleshooting - verified via exists in original 200 OK REPLY from Freeswitch - checked wire and verified via header is missing when forwarding 200 OK onward to next kamailio (B) node from Kamailio (A) #### Reproduction Call drop in event route `topos:msg-outgoing` - call flow: Freeswitch -> Kamailio A -> Kamailio B -> UAC - place incoming call into kamailio - put call on hold / reinvite #### Debugging Data ``` Disabling topos entirely via header is correctly sent from A -> B. ``` #### Log Messages (Kamailio B) ``` 2025-02-25T00:19:08.545447+00:00 /usr/sbin/kamailio[3959021]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:09.045917+00:00 /usr/sbin/kamailio[3959037]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:10.046936+00:00 /usr/sbin/kamailio[3958995]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:12.048099+00:00 /usr/sbin/kamailio[3959003]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply ``` #### SIP Traffic `reinvite B -> A:` ``` INVITE sip:mod_sofia@54.245.XX.XX:5060 SIP/2.0 Record-Route: <sip:35.161.XX.XX:5060;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.7e62> Record-Route: <sip:35.161.XX.XX:7443;transport=ws;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.7e62> Via: SIP/2.0/UDP 35.161.XX.XX:5060;branch=z9hG4bK16be.085d2f3d83e8d939f7f1d3fbc4a5ff09.0 Via: SIP/2.0/WSS 74jssm3ooc66.invalid;received=209.160.251.114;branch=z9hG4bK3968143 To: <sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS From: <sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q CSeq: 1 INVITE Call-ID: 995df181-4eae-40ae-8225-427ce8252250 Max-Forwards: 69 Allow: ACK,BYE,CANCEL,INFO,INVITE,MESSAGE,NOTIFY,OPTIONS,PRACK,REFER,REGISTER,SUBSCRIBE Contact: <sip:tu0r7r7u@74jssm3ooc66.invalid;transport=ws> Supported: outbound User-Agent: WebPhone/3.1740423483.87 Content-Type: application/sdp Content-Length: 1538 Route: <sip:34.213.XX.XX:5060;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.1142>,<sip:34.213.XX.XX;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.1142> P-SR-XUID: atpsh-7cde-67bcbccd-3c68ef-1 v=0 o=- 4757376688759011024 3 IN IP4 127.0.0.1 s=- t=0 0 a=group:BUNDLE 0 a=extmap-allow-mixed a=msid-semantic: WMS 35a33e17-dd80-46fa-afe9-72fdd03d4e41 m=audio 32999 UDP/TLS/RTP/SAVPF 0 102 101 103 63 9 8 13 c=IN IP4 209.160.251.114 a=rtcp:9 IN IP4 0.0.0.0 a=candidate:2845667355 1 udp 2122260223 10.82.226.218 54425 typ host generation 0 network-id 1 network-cost 10 a=candidate:1750280017 1 udp 1686052607 209.160.251.114 32999 typ srflx raddr 10.82.226.218 rport 54425 generation 0 network-id 1 network-cost 10 a=ice-ufrag:Eb9h a=ice-pwd:nQdfpsILiUI+YKSQT3eZy52x a=ice-options:trickle a=fingerprint:sha-256 BA:68:25:D5:66:70:A9:17:38:18:74:0A:B3:C2:3E:F9:3A:A0:7C:5F:18:0F:EB:B7:93:28:86:56:62:23:DF:E5 a=setup:actpass a=mid:0 a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time a=extmap:3 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01 a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid a=sendonly a=msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41 57910219-943b-4687-9511-b9a9d0a1ea6f a=rtcp-mux a=rtcp-rsize a=rtpmap:0 PCMU/8000 a=rtpmap:102 opus/48000/2 a=fmtp:102 minptime=10;useinbandfec=1 a=rtpmap:101 telephone-event/8000 a=rtpmap:103 telephone-event/48000 a=rtpmap:63 red/48000/2 a=fmtp:63 102/102 a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:13 CN/8000 a=ssrc:2604971680 cname:YEcJO5XrSKZor1jY a=ssrc:2604971680 msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41 57910219-943b-4687-9511-b9a9d0a1ea6f ``` `200 OK Freeswitch -> A` ``` SIP/2.0 200 OK v:SIP/2.0/UDP 34.213.XX.XX:5060;branch=z9hG4bK16be.86ee5e1d4190783bd6a79bd21110d190.0 f:<sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q t:<sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS i:995df181-4eae-40ae-8225-427ce8252250 CSeq:1 INVITE m:<sip:mod_sofia@54.245.XX.XX:5060> Accept:application/sdp Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE k:timer,path,replaces x:90;refresher=uas c:application/sdp Content-Disposition:session l:284 v=0 o=FreeSWITCH 1740424963 1740424965 IN IP4 54.245.XX.XX s=FreeSWITCH c=IN IP4 54.245.XX.XX t=0 0 m=audio 17776 RTP/AVP 0 101 a=rtpmap:0 PCMU/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=recvonly a=ptime:20 a=rtcp-mux a=rtcp:17776 IN IP4 54.245.XX.XX ``` `200 OK A -> B` ``` SIP/2.0 200 OK f:<sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q t:<sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS i:995df181-4eae-40ae-8225-427ce8252250 CSeq:1 INVITE m:<sip:mod_sofia@54.245.XX.XX:5060> Accept:application/sdp Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE k:timer,path,replaces x:90;refresher=uas c:application/sdp Content-Disposition:session l:315 v=0 o=FreeSWITCH 1740424963 1740424965 IN IP4 34.211.XX.XX s=FreeSWITCH c=IN IP4 34.211.XX.XX t=0 0 m=audio 20374 RTP/AVP 0 101 a=mid:0 a=rtpmap:0 PCMU/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=recvonly a=rtcp:20374 a=rtcp-mux a=ptime:20 a=ice-options:trickle a=end-of-candidates ``` ### Possible Solutions TBD ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` <img width="629" alt="Image" src="https://github.com/user-attachments/assets/fc46f76e-7a6f-431f-a00e-84fbbece…" /> * **Operating System**: ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye ``` I can provide PCAP as well if required. Let me know if additional information is required. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4157 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4157(a)github.com>

4 10

[kamailio/kamailio] tcp_timer_check_connections() logs on CRITICAL and is not caught by event_route[tcp:timeout] (Issue #3995)
by Fritjof Höst 13 Jun '25

13 Jun '25

### Description Hi! We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it. ```jsx /usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing ``` It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue. Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL? I’d also expect it to be caught by ``` event_route[tcp:timeout] { xlog("L_INFO","connection $conid timeouts (unanswered keepalives)"); } ``` given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`. ### Troubleshooting We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this. ### Additional Information * **Kamailio Version** - 5.8.3 * **Operating System**: Debian 12 AMI from the AWS Marketplace. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3995 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3995(a)github.com>

6 12

git:master:2af2c80f: core: tcp - log message on message processing timeout made debug
by Daniel-Constantin Mierla 13 Jun '25

13 Jun '25

Module: kamailio Branch: master Commit: 2af2c80fde4e82614846af9d817ab2bffa2d954d URL: https://github.com/kamailio/kamailio/commit/2af2c80fde4e82614846af9d817ab2b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-13T09:51:13+02:00 core: tcp - log message on message processing timeout made debug --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/2af2c80fde4e82614846af9d817ab2b… Patch: https://github.com/kamailio/kamailio/commit/2af2c80fde4e82614846af9d817ab2b… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 369bfb1f159..277ae960091 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -5589,9 +5589,9 @@ void tcp_timer_check_connections(unsigned int ticks, void *param) if(n > 0) { for(i = 0; i < n; i++) { if((con = tcpconn_get(tcpidlist[i], 0, 0, 0, 0))) { - LM_CRIT("message processing timeout on connection id: %d " - "(state: %d) - " - "closing\n", + LM_DBG("message processing timeout on connection id: %d " + "(state: %d) - " + "closing\n", tcpidlist[i], con->state); mcmd[0] = (long)con; mcmd[1] = CONN_EOF;

1 0

git:master:7f68f5bf: modules: readme files regenerated - jwt ... [skip ci]
by Kamailio Dev 13 Jun '25

13 Jun '25

Module: kamailio Branch: master Commit: 7f68f5bfaf931f4e0eb4625a1eefaf330309c879 URL: https://github.com/kamailio/kamailio/commit/7f68f5bfaf931f4e0eb4625a1eefaf3… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-13T09:31:10+02:00 modules: readme files regenerated - jwt ... [skip ci] --- Modified: src/modules/jwt/README --- Diff: https://github.com/kamailio/kamailio/commit/7f68f5bfaf931f4e0eb4625a1eefaf3… Patch: https://github.com/kamailio/kamailio/commit/7f68f5bfaf931f4e0eb4625a1eefaf3… --- diff --git a/src/modules/jwt/README b/src/modules/jwt/README index 7101d714c9c..03ef468df9a 100644 --- a/src/modules/jwt/README +++ b/src/modules/jwt/README @@ -75,7 +75,8 @@ Chapter 1. Admin Guide Kamailio configuration file. It relies on libjwt (at least v1.12.0) library - (https://github.com/benmcollins/libjwt). + (https://github.com/benmcollins/libjwt), but it is not working with the + new libjwt3. 2. Dependencies @@ -91,7 +92,7 @@ Chapter 1. Admin Guide The following libraries or applications must be installed before running Kamailio with this module loaded: - * libjwt - minimum version 1.12.0. + * libjwt - minimum version 1.12.0, but less than libjwt 3.0. 3. Parameters

1 0

git:master:36c466bc: jwt: added to the notes about libjwt versions
by Daniel-Constantin Mierla 13 Jun '25

13 Jun '25

Module: kamailio Branch: master Commit: 36c466bce5a57df72806a0915361612c32cc838e URL: https://github.com/kamailio/kamailio/commit/36c466bce5a57df72806a0915361612… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-13T09:26:17+02:00 jwt: added to the notes about libjwt versions - module is not compatible with the new libjwt3 --- Modified: src/modules/jwt/doc/jwt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/36c466bce5a57df72806a0915361612… Patch: https://github.com/kamailio/kamailio/commit/36c466bce5a57df72806a0915361612… --- diff --git a/src/modules/jwt/doc/jwt_admin.xml b/src/modules/jwt/doc/jwt_admin.xml index 5389bb61f30..4aecc4d0a8b 100644 --- a/src/modules/jwt/doc/jwt_admin.xml +++ b/src/modules/jwt/doc/jwt_admin.xml @@ -20,7 +20,8 @@ in &kamailio; configuration file. </para> <para> - It relies on libjwt (at least v1.12.0) library (https://github.com/benmcollins/libjwt). + It relies on libjwt (at least v1.12.0) library (https://github.com/benmcollins/libjwt), + but it is not working with the new libjwt3. </para> </section> @@ -47,7 +48,8 @@ <itemizedlist> <listitem> <para> - <emphasis>libjwt</emphasis> - minimum version 1.12.0. + <emphasis>libjwt</emphasis> - minimum version 1.12.0, but less + than libjwt 3.0. </para> </listitem> </itemizedlist>

1 0

[kamailio/kamailio] sht_setxi() exits script (stops message processing). (Issue #4283)
by Ben Kaufman 12 Jun '25

12 Jun '25

whosgonna created an issue (kamailio/kamailio#4283) ### Description Using function `sht_setxi()` causes the script to exit and stop processing messages. Using the example from the documention: ``` #!KAMAILIO loadmodule "pv" loadmodule "ctl" loadmodule "htable" loadmodule "xlog" modparam("htable", "htable", "ha=>size=4"); request_route { xnotice("Request received [$ru]\n"); ## this prints sht_setxi("ha", "test", "100", "10"); ## exactly as documented xnotice("log line after sht_setxi()\n"); ## This does not print. } ``` ### Troubleshooting As shown above. Note that the similar function `sht_setxs()` (for setting string values) works as expected. #### Reproduction Trivial to reproduce. #### SIP Traffic Tested from localhost with `sipsak -s sip:127.0.0.1`, but any message seems to do this. ### Possible Solutions I believe that the issue is in [`/src/modules/htable/htable.c`](/src/modules/htable/htable.c) within function `static int ki_ht_setxi()` where the return is `0` (last line in the function). I'm guessing it should return `1`, like ``static int ki_ht_setxs()` (sting function equivilent) ### Additional Information Tested in 6.0.1 and 5.8.5 ``` version: kamailio 6.0.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` ``` ``` * **Operating System**:  ``` version: kamailio 5.8.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 19:38:35 Jan 30 2025 with gcc 14.2.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4283 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4283(a)github.com>

2 2

git:master:f789f6a5: core: parser - count diversion header body len based on last param
by Daniel-Constantin Mierla 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: f789f6a5fa4d651ad3bcb657cb2a1dc765de6460 URL: https://github.com/kamailio/kamailio/commit/f789f6a5fa4d651ad3bcb657cb2a1dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-12T17:43:20+02:00 core: parser - count diversion header body len based on last param - take in consideratio quoted param values --- Modified: src/core/parser/parse_diversion.c --- Diff: https://github.com/kamailio/kamailio/commit/f789f6a5fa4d651ad3bcb657cb2a1dc… Patch: https://github.com/kamailio/kamailio/commit/f789f6a5fa4d651ad3bcb657cb2a1dc… --- diff --git a/src/core/parser/parse_diversion.c b/src/core/parser/parse_diversion.c index 1b5d70a5f80..098ae19afa6 100644 --- a/src/core/parser/parse_diversion.c +++ b/src/core/parser/parse_diversion.c @@ -52,10 +52,10 @@ int parse_diversion_body(char *buf, int len, diversion_body_t **body) { static to_body_t uri_b[NUM_DIVERSION_BODIES]; /* Temporary storage */ int num_uri = 0; - int body_len = 0; char *tmp; int i; to_param_t *params; + to_param_t *lparam; memset(uri_b, 0, NUM_DIVERSION_BODIES * sizeof(to_body_t)); @@ -66,17 +66,27 @@ int parse_diversion_body(char *buf, int len, diversion_body_t **body) } /* id.body should contain all info including uri and params */ - body_len = uri_b[num_uri].body.len; - /* Loop over all params */ params = uri_b[num_uri].param_lst; + lparam = NULL; while(params) { - body_len += - params->name.len + params->value.len + 2; // 2 for '=' and ';' + lparam = params; params = params->next; } - uri_b[num_uri].body.len = body_len; + if(lparam) { + if(lparam->value.len > 0) { + uri_b[num_uri].body.len = + lparam->value.s + lparam->value.len - uri_b[num_uri].body.s; + if(*(lparam->value.s - 1) == '"' + || *(lparam->value.s - 1) == '\'') { + uri_b[num_uri].body.len++; + } + } else { + uri_b[num_uri].body.len = + lparam->name.s + lparam->name.len - uri_b[num_uri].body.s; + } + } num_uri++; while(*tmp == ',' && (num_uri < NUM_DIVERSION_BODIES)) { @@ -132,17 +142,25 @@ int parse_diversion_body(char *buf, int len, diversion_body_t **body) } /* id.body should contain all info including uri and params */ - body_len = uri_b[num_uri].body.len; - /* Loop over all params */ params = uri_b[num_uri].param_lst; while(params) { - body_len += params->name.len + params->value.len - + 2; /* 2 for '=' and ';' */ + lparam = params; params = params->next; } - - uri_b[num_uri].body.len = body_len; + if(lparam) { + if(lparam->value.len > 0) { + uri_b[num_uri].body.len = lparam->value.s + lparam->value.len + - uri_b[num_uri].body.s; + if(*(lparam->value.s - 1) == '"' + || *(lparam->value.s - 1) == '\'') { + uri_b[num_uri].body.len++; + } + } else { + uri_b[num_uri].body.len = lparam->name.s + lparam->name.len + - uri_b[num_uri].body.s; + } + } num_uri++; }

1 0

git:master:9ded810b: htable: return true for sht_setxi()
by Daniel-Constantin Mierla 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: 9ded810b2dfe527db8d8be409fe1f34b002f3325 URL: https://github.com/kamailio/kamailio/commit/9ded810b2dfe527db8d8be409fe1f34… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-12T17:43:20+02:00 htable: return true for sht_setxi() - GH #4283 --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/9ded810b2dfe527db8d8be409fe1f34… Patch: https://github.com/kamailio/kamailio/commit/9ded810b2dfe527db8d8be409fe1f34… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index d458e83141a..63c0b4ced02 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -1406,7 +1406,7 @@ static int ki_ht_setxi( return -1; } - return 0; + return 1; } /**

1 0

[kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)
by Fred Posner 12 Jun '25

12 Jun '25

### Introduction First, I apologize for the lack of detail here. I am unable to get a core dump and as a production box, I was unable to run in debug mode. ### Description Using Kamailio 5.8.4 on Debian 12, every 60-80 minutes, the software would crash, blaming tls_wolfssl, such as: ``` 2024-12-16T14:58:27.554497+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[9084]: CRITICAL: <core> [core/mem/q_malloc.c:535]: qm_free(): BUG: bad pointer 0x1 (out of memory block!) called from tls_wolfssl: tls_init.c: ser_free(240) - ignoring 2024-12-16T14:58:27.554555+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[9084]: CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f3440ba7560 (address 0x7f3440ba75a0) beginning overwritten (23)! Memory allocator was called from tls_wolfssl: tls_init.c:240. Fragment marked by :29. Exec from core/mem/q_malloc.c:546. 2024-12-16T14:58:27.616558+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[9089]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 103 2024-12-16T14:58:27.617684+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[8992]: ALERT: <core> [main.c:805]: handle_sigs(): child process 9084 exited by a signal 6 2024-12-16T14:58:27.618339+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[8992]: ALERT: <core> [main.c:809]: handle_sigs(): core was not generated 2024-12-16T14:58:27.618477+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[8992]: INFO: <core> [main.c:832]: handle_sigs(): terminating due to SIGCHLD 2024-12-16T14:58:27.618589+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[9088]: INFO: <core> [main.c:888]: sig_usr(): signal 15 received ``` ``` 2024-12-16T14:57:52.029277+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21605]: CRITICAL: <core> [core/mem/q_malloc.c:535]: qm_free(): BUG: bad pointer 0x1 (out of memory block!) called from tls_wolfssl: tls_init.c: ser_free(240) - ignoring 2024-12-16T14:57:52.029347+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21605]: CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f085996b500 (address 0x7f085996b540) beginning overwritten (0)! Memory allocator was called from tls_wolfssl: tls_init.c:240. Fragment marked by (null):0. Exec from core/mem/q_malloc.c:546. 2024-12-16T14:57:52.048597+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21611]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 101 2024-12-16T14:57:52.048921+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21512]: ALERT: <core> [main.c:805]: handle_sigs(): child process 21605 exited by a signal 6 2024-12-16T14:57:52.048953+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21512]: ALERT: <core> [main.c:809]: handle_sigs(): core was not generated 2024-12-16T14:57:52.048975+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21512]: INFO: <core> [main.c:832]: handle_sigs(): terminating due to SIGCHLD 2024-12-16T14:57:52.048997+00:00 ip-172-16-0-73 /usr/local/sbin/kamailio[21609]: INFO: <core> [main.c:888]: sig_usr(): signal 15 received ``` ``` 2024-12-16T16:21:35.967576+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[10591]: CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f442778d110 (address 0x7f442778d150) beginning overwritten (0)! Memory allocator was called from tls_wolfssl: tls_init.c:240. Fragment marked by (null):0. Exec from core/mem/q_malloc.c:546. ``` ``` 2024-12-16T13:31:55.995222+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[7602]: CRITICAL: <core> [core/mem/q_malloc.c:555]: qm_free(): BUG: freeing already freed pointer (0x7f8e55830a70), called from tls_wolfssl: tls_init.c: ser_free(240), first free tls_wolfssl: tls_init.c: ser_malloc(228) - ignoring 2024-12-16T13:32:40.093954+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[7603]: CRITICAL: <core> [core/mem/q_malloc.c:535]: qm_free(): BUG: bad pointer 0x7a100000000 (out of memory block!) called from tls_wolfssl: tls_init.c: ser_free(240) - ignoring 2024-12-16T13:32:40.094047+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[7603]: CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f8e55762720 (address 0x7f8e55762760) beginning overwritten (0)! Memory allocator was called from tls_wolfssl: tls_init.c:240. Fragment marked by (null):0. Exec from core/mem/q_malloc.c:546. 2024-12-16T13:32:40.260913+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[7504]: CRITICAL: <core> [core/mem/q_malloc.c:555]: qm_free(): BUG: freeing already freed pointer (0x7f8e55761a70), called from core: core/tcp_main.c: _tcpconn_free(1666), first free tls_wolfssl: tls_init.c: ser_free(240) - ignoring 2024-12-16T13:32:40.263520+00:00 ip-172-16-0-52 /usr/local/sbin/kamailio[7504]: CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f8e55762720 (address 0x7f8e55762760) beginning overwritten (0)! Memory allocator was called from tls_wolfssl: tls_init.c:240. Fragment marked by (null):0. Exec from core/mem/q_malloc.c:546. ``` The system was handling ~900 TLS registrations with ~2700 presence SUBSCRIBE events. **Running the same config with `tls.so` does not result in crash.** ### Additional Information * **Kamailio Version** - 5.8.4 ``` version: kamailio 5.8.4 (x86_64/linux) 598105-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 598105 -dirty compiled on 04:31:34 Dec 16 2024 with gcc 12.2.0 ``` * **Operating System**: ``` Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm Linux ip-172-16-0-52 6.1.0-28-cloud-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.119-1 (2024-11-22) x86_64 GNU/Linux ``` * TCP Settings ``` children=16 disable_tcp=no tcp_connection_lifetime=3605 tcp_accept_no_cl=yes tcp_max_connections=8192 tcp_defer_accept=yes tcp_accept_unique=0 tcp_connection_lifetime=3605 tcp_connection_match=1 tcp_connect_timeout=10 tcp_crlf_ping=yes tcp_linger2=1 tcp_keepalive=yes tcp_reuse_port=yes tcp_keepidle=20 tcp_keepintvl=15 tcp_rd_buf_size=65536 tcp_msg_data_timeout=40 tcp_msg_read_timeout=40 tcp_check_timer=20 tls_threads_mode=2 tls_max_connections=8192 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4074 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4074(a)github.com>

3 6

git:master:de4e3677: github: refactored alpine docker image generation
by Sergey Safarov 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: de4e36779ec0d01e4ba749318677e29472de5b55 URL: https://github.com/kamailio/kamailio/commit/de4e36779ec0d01e4ba749318677e29… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-12T11:13:32+03:00 github: refactored alpine docker image generation - GH #4241 --- Modified: .github/workflows/alpine.yml --- Diff: https://github.com/kamailio/kamailio/commit/de4e36779ec0d01e4ba749318677e29… Patch: https://github.com/kamailio/kamailio/commit/de4e36779ec0d01e4ba749318677e29…

1 0

git:master:9ddd70a4: pkg/kamailio: updated alpine build rules
by Sergey Safarov 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: 9ddd70a45168c618a3ef2356689890daee8c8415 URL: https://github.com/kamailio/kamailio/commit/9ddd70a45168c618a3ef2356689890d… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-12T11:13:28+03:00 pkg/kamailio: updated alpine build rules --- Modified: pkg/kamailio/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/9ddd70a45168c618a3ef2356689890d… Patch: https://github.com/kamailio/kamailio/commit/9ddd70a45168c618a3ef2356689890d… --- diff --git a/pkg/kamailio/Makefile b/pkg/kamailio/Makefile index ce2e3ae7327..6f1a18ec3c6 100644 --- a/pkg/kamailio/Makefile +++ b/pkg/kamailio/Makefile @@ -32,8 +32,8 @@ apk: sed -e "s/^_gitcommit=.*/_gitcommit=${GIT_TAG}/" \ -e "s/^pkgver=.*/pkgver=${APK_VERSION}/" \ -i alpine/APKBUILD - cd alpine && abuild snapshot - @echo \"abuild\" cannot be started from Makefile please start manually \"cd alpine \&\& abuild -r\" + abuild -C alpine snapshot + @echo \"abuild\" cannot be started from Makefile please start manually \"abuild -C alpine -r\" # build source rpm package .PHONY: src.rpm

1 0

git:master:56028960: pkg/docker: submodule update
by Sergey Safarov 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: 560289608494d2c16d52ce2855f99b651a08e924 URL: https://github.com/kamailio/kamailio/commit/560289608494d2c16d52ce2855f99b6… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-12T11:13:23+03:00 pkg/docker: submodule update --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/560289608494d2c16d52ce2855f99b6… Patch: https://github.com/kamailio/kamailio/commit/560289608494d2c16d52ce2855f99b6… --- diff --git a/pkg/docker b/pkg/docker index cf48a82c5f9..75be900d83b 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit cf48a82c5f9df67813d14e6619cc9a41ec9a683b +Subproject commit 75be900d83bb70b3ec77443fdbb309b9ef1a6d80

1 0

git:master:aa7b2460: pkg/kamailio: for dispatcher work required working DNS resolution daemon
by Sergey Safarov 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: aa7b2460ff0d8085ddc8ae9232a9fea0fe0db5f8 URL: https://github.com/kamailio/kamailio/commit/aa7b2460ff0d8085ddc8ae9232a9fea… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-12T11:13:13+03:00 pkg/kamailio: for dispatcher work required working DNS resolution daemon --- Modified: pkg/kamailio/obs/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/aa7b2460ff0d8085ddc8ae9232a9fea… Patch: https://github.com/kamailio/kamailio/commit/aa7b2460ff0d8085ddc8ae9232a9fea… --- diff --git a/pkg/kamailio/obs/kamailio.service b/pkg/kamailio/obs/kamailio.service index 0c4fbc49caf..0a527056f91 100644 --- a/pkg/kamailio/obs/kamailio.service +++ b/pkg/kamailio/obs/kamailio.service @@ -1,8 +1,8 @@ [Unit] Description=Kamailio - the Open Source SIP Server Documentation=man:kamailio(8) -Wants=network-online.target -After=network-online.target +Wants=network-online.target nss-lookup.target +After=network-online.target nss-lookup.target [Service] Type=simple

1 0

git:master:28cd81c9: dispatcher: rework MIXSOCKPRPORT (16) matching mode
by Daniel-Constantin Mierla 12 Jun '25

12 Jun '25

Module: kamailio Branch: master Commit: 28cd81c9ad7a64ee8953ba9438756b88740b7820 URL: https://github.com/kamailio/kamailio/commit/28cd81c9ad7a64ee8953ba9438756b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-12T08:15:34+02:00 dispatcher: rework MIXSOCKPRPORT (16) matching mode - GH #4236 --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/28cd81c9ad7a64ee8953ba9438756b8… Patch: https://github.com/kamailio/kamailio/commit/28cd81c9ad7a64ee8953ba9438756b8… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 370aac8f4e2..3f0c1ab857f 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3827,30 +3827,31 @@ int ds_is_addr_from_set(sip_msg_t *_m, struct ip_addr *pipaddr, if(mode & DS_MATCH_MIXSOCKPRPORT) { node_strictness = DS_MATCHED_ADDR; if(node->dlist[j].port) { - if(tport != node->dlist[j].port) - continue; - else + if(tport == node->dlist[j].port) { node_strictness |= DS_MATCHED_PORT; + } } if(node->dlist[j].proto) { - if(tproto != node->dlist[j].proto) - continue; - else + if(tproto == node->dlist[j].proto) { node_strictness |= DS_MATCHED_PROTO; + } } if(node->dlist[j].sock) { - if(node->dlist[j].sock != _m->rcv.bind_address) - continue; - else + if(node->dlist[j].sock == _m->rcv.bind_address) { node_strictness |= DS_MATCHED_SOCK; + } } if(node_strictness == (DS_MATCHED_ADDR | DS_MATCHED_PORT | DS_MATCHED_PROTO - | DS_MATCHED_SOCK)) + | DS_MATCHED_SOCK)) { + ds_strictest_match = node_strictness; + ds_strictest_node = node; + ds_strictest_idx = j; return ds_set_vars(_m, node, j, export_set_pv); + } if(ds_strictest_match < node_strictness) { ds_strictest_match = node_strictness;

1 0

git:master:dfb5ef6f: dispatcher: rename varaiable about strictest match with common prefix
by Daniel-Constantin Mierla 11 Jun '25

11 Jun '25

Module: kamailio Branch: master Commit: dfb5ef6f9d670a9ee2de223eac0a665f9e5cab71 URL: https://github.com/kamailio/kamailio/commit/dfb5ef6f9d670a9ee2de223eac0a665… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-11T19:56:57+02:00 dispatcher: rename varaiable about strictest match with common prefix - init values --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/dfb5ef6f9d670a9ee2de223eac0a665… Patch: https://github.com/kamailio/kamailio/commit/dfb5ef6f9d670a9ee2de223eac0a665… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index cf0a75a09dd..370aac8f4e2 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -137,8 +137,8 @@ static int *ds_crt_idx = NULL; static int *ds_next_idx = NULL; static ds_set_t *ds_strictest_node = NULL; -static int ds_strictest_idx; -static int ds_strictness; +static int ds_strictest_idx = 0; +static int ds_strictest_match = 0; #define _ds_list (ds_lists[*ds_crt_idx]) #define _ds_list_nr (*ds_list_nr) @@ -3852,8 +3852,8 @@ int ds_is_addr_from_set(sip_msg_t *_m, struct ip_addr *pipaddr, | DS_MATCHED_SOCK)) return ds_set_vars(_m, node, j, export_set_pv); - if(ds_strictness < node_strictness) { - ds_strictness = node_strictness; + if(ds_strictest_match < node_strictness) { + ds_strictest_match = node_strictness; ds_strictest_node = node; ds_strictest_idx = j; } @@ -3948,7 +3948,7 @@ int ds_is_addr_from_list(sip_msg_t *_m, int group, str *uri, int mode) if(mode & DS_MATCH_MIXSOCKPRPORT) { - ds_strictness = 0; + ds_strictest_match = 0; ds_strictest_node = NULL; }

1 0

[kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)
by tsearle 11 Jun '25

11 Jun '25

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [*] PR should be backported to stable branches - [*] Tested changes locally - [*] Related to issue #4249 #### Description When sending an INVITE using t_uac_send, the transaction layer automatically generates ACK on final response. However this ack doesn't invoke the tm:local-request callback. This patch adds this functionality You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4250 -- Commit Summary -- * tm: invoke tm:local-request on generated ACK messages -- File Changes -- M src/modules/tm/uac.c (127) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4250.patch https://github.com/kamailio/kamailio/pull/4250.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4250 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4250(a)github.com>

4 25

[kamailio/kamailio] xhttp module generates an error sip parsing error log (Issue #4237)
by tianhao98 11 Jun '25

11 Jun '25

tianhao98 created an issue (kamailio/kamailio#4237) ### Description I used the xhttp module to add a fake Via header to handle HTTP requests in Kamailio. But it will produce the following error ``` 104(113) ERROR: <core> [core/parser/parse_uri.c:1417]: _parse_ruri(): bad uri </metrics> 104(113) ERROR: <core> [core/parser/parse_uri.c:1455]: parse_orig_ruri(): parse orig ruri failed 104(113) ERROR: pv [pv_core.c:355]: pv_get_ouri_attr(): failed to parse the R-URI ``` ### Troubleshooting #### Debugging Data Set up a Kamailio server with the xhttp module enabled. ``` loadmodule "xhttp.so" ``` #### Log Messages ``` 104(113) ERROR: <core> [core/parser/parse_uri.c:1417]: _parse_ruri(): bad uri </metrics> 104(113) ERROR: <core> [core/parser/parse_uri.c:1455]: parse_orig_ruri(): parse orig ruri failed 104(113) ERROR: pv [pv_core.c:355]: pv_get_ouri_attr(): failed to parse the R-URI ``` #### SIP Traffic N/A — this is a pure HTTP request triggering the SIP parser. ### Additional Information ``` root@kamailio-60-bot-67d564c54c-xj97x:/# kamailio -V version: kamailio 6.0.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**: ``` root@kamailio-60-bot-67d564c54c-xj97x:/# uname -a Linux kamailio-60-bot-67d564c54c-xj97x 5.4.119-19.0009.28 #1 SMP Thu May 18 10:37:10 CST 2023 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4237 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4237(a)github.com>

4 5

[kamailio/kamailio] memory leak in avp cleanup (Issue #4257)
by sergey-safarov 11 Jun '25

11 Jun '25

sergey-safarov created an issue (kamailio/kamailio#4257) ### Description We found a memory leak in the AVP cleanup ### Troubleshooting #### Reproduction To reproduce, you need to start Kaamilio 5.8 branch with the config ``` listen=127.0.0.1:5060 tcp_send_timeout=3 loadmodule "xlog.so" loadmodule "kex.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "tm.so" loadmodule "siptrace.so" modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_on", 1) modparam("siptrace", "trace_mode", 1) modparam("siptrace", "trace_init_mode", 1) loadmodule "permissions.so" modparam("permissions", "address_file", "address.list") modparam("permissions", "peer_tag_avp", "$avp(s:tag)") modparam("permissions", "peer_tag_mode", 0) modparam("permissions", "load_backends", 1) modparam("permissions", "reload_delta", 1) loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/tmp/dispatcher.list") modparam("dispatcher", "ds_ping_from", "sip:proxy@aggregator.nga911.com") modparam("dispatcher", "ds_ping_interval", 3) modparam("dispatcher", "ds_probing_mode", 1) route{ drop; } event_route[siptrace:msg] { if (allow_address("1", "$siptrace(src_hostip)", "0")) { xerr("SIP message from $siptrace(src_hostip)\n"); } } ``` Also need to create `address.list` with content ``` # address file - records to match with allow_address(...) and variants # * file format details # - comments start with # and go to end of line # - each line corresponds to a record with following attributes: # # (groupid,int) (address,str) (netmask,int,o), (port,int,o) (tag,str,o) # # * description of the tokens used to describe line format # - int: expected integer value # - str: expected string value # - o: optional field 1 127.0.0.0 16 0 tag ``` and `/tmp/dispatcher.list` with content ``` 1 sip:sip.telnyx.com:5060;transport=tcp 8 ``` When kamailio started required to execute a command ``` kamcmd mod.stats core shm| grep avp ``` This will produce output like ``` create_avp(178): 1360 init_avps(92): 16 init_avps(91): 16 ``` Where `create_avp` is constantly increasing -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4257 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4257(a)github.com>

4 5

[kamailio/kamailio] dispatcher: fixed memory leak when avp is indirectly used (PR #4258)
by Ivanuschak Nikolay 11 Jun '25

11 Jun '25

#### Pre-Submission Checklist    - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x ] Tested changes locally - [x ] Related to issue #4257 #### Description When the dispatcher module sends ping requests then these requests are executed in a dedicated process, which handles timers and called `slow timer`. If during this ping request AVP variables are allocated, then these vars are allocated within `slow timer` process and this memory is never released and continiously accumulates in/by this process. This change makes AVP vars being reset for every iteration of the `dispatcher` timer procedure (`ds_check_timer` function). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4258 -- Commit Summary -- * dispatcher: fixed memory leak when avp is indirectly used -- File Changes -- M src/modules/dispatcher/dispatch.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4258.patch https://github.com/kamailio/kamailio/pull/4258.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4258 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4258(a)github.com>

3 10

[kamailio/kamailio] tcp_send_timeout does not apply for outbound connections (Issue #4187)
by Oleg Vedeneev 11 Jun '25

11 Jun '25

ovedeneev created an issue (kamailio/kamailio#4187) ### Description [tcp_send_timeout](https://www.kamailio.org/wikidocs/cookbooks/5.8.x/core/#t… option does not apply for outbound connections. #### Reproduction 1. Establish TCP OPTIONS between Kamailio and target node. 2. On target node block incoming traffic from Kamailio node using iptables. 3. Notice on Kamailio node that TCP retransmission packets don't follow tcp_send_timeout settings, instead they fall back to kernel's net.ipv4.tcp_retries2 settings. ### Additional Information * **Kamailio Version** ``` # kamailio -V version: kamailio 5.8.2 (aarch64/linux) 446039 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 446039 compiled on 14:32:09 Nov 14 2024 with gcc 8.5.0 ``` * **Operating System**: ``` Linux xxx 4.18.0-553.6.1.el8.aarch64 #1 SMP Thu May 30 04:10:32 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4187 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4187(a)github.com>

4 5

git:master:4de32708: lib/srdb1: align schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e
by Victor Seva 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 4de3270830c08641e3bc3e5858513244083b106e URL: https://github.com/kamailio/kamailio/commit/4de3270830c08641e3bc3e585851324… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-10T16:25:54+02:00 lib/srdb1: align schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e --- Modified: src/lib/srdb1/schema/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/4de3270830c08641e3bc3e585851324… Patch: https://github.com/kamailio/kamailio/commit/4de3270830c08641e3bc3e585851324… --- diff --git a/src/lib/srdb1/schema/Makefile b/src/lib/srdb1/schema/Makefile index b76b485e402..77529d56e91 100644 --- a/src/lib/srdb1/schema/Makefile +++ b/src/lib/srdb1/schema/Makefile @@ -105,7 +105,7 @@ mysql: XML_CATALOG_FILES=$(CATALOG) $(XSLTPROC) $(XSLTPROC_FLAGS) \ --stringparam dir "$(SCHEME)/mysql" \ --stringparam prefix "$$FILE-" \ - --stringparam db "mysql" \ + --stringparam db "db_mysql" \ $(MYSQL_XSL) kamailio-"$$FILE".xml ; \ done @@ -118,7 +118,7 @@ postgres: XML_CATALOG_FILES=$(CATALOG) $(XSLTPROC) $(XSLTPROC_FLAGS) \ --stringparam dir "$(SCHEME)/postgres" \ --stringparam prefix "$$FILE-" \ - --stringparam db "postgres" \ + --stringparam db "db_postgres" \ $(POSTGRES_XSL) kamailio-"$$FILE".xml ; \ done @@ -131,7 +131,7 @@ oracle: XML_CATALOG_FILES=$(CATALOG) $(XSLTPROC) $(XSLTPROC_FLAGS) \ --stringparam dir "$(SCHEME)/oracle" \ --stringparam prefix "$$FILE-" \ - --stringparam db "oracle" \ + --stringparam db "db_oracle" \ $(ORACLE_XSL) kamailio-"$$FILE".xml ; \ done @@ -144,7 +144,7 @@ dbtext: XML_CATALOG_FILES=$(CATALOG) $(XSLTPROC) $(XSLTPROC_FLAGS) \ --stringparam dir "$(SCHEME)/dbtext/kamailio" \ --stringparam prefix "" \ - --stringparam db "dbtext" \ + --stringparam db "db_text" \ $(DBTEXT_XSL) kamailio-"$$FILE".xml ; \ done TMPFILE=`mktemp -t kamailio-test.XXXXXXXXXX` @@ -208,7 +208,7 @@ mongodb: XML_CATALOG_FILES=$(CATALOG) $(XSLTPROC) $(XSLTPROC_FLAGS) \ --stringparam dir "$(SCHEME)/mongodb/kamailio" \ --stringparam prefix "" \ - --stringparam db "mongodb" \ + --stringparam db "db_mongodb" \ $(MONGODB_XSL) kamailio-"$$FILE".xml ; \ done @# small hack to create the version table entries, this is here easier as with XSL

1 0

git:master:4b3bb981: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 4b3bb981e1e7d7677da2bb287a8781a2f151f398 URL: https://github.com/kamailio/kamailio/commit/4b3bb981e1e7d7677da2bb287a8781a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-10T16:01:09+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/4b3bb981e1e7d7677da2bb287a8781a… Patch: https://github.com/kamailio/kamailio/commit/4b3bb981e1e7d7677da2bb287a8781a…

1 0

[kamailio/kamailio] rtpengine: fix formatting of subscribe/unsubscribe examples (PR #4278)
by tsearle 10 Jun '25

10 Jun '25

introduce proper code indentation in examples   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4278 -- Commit Summary -- * rtpengine: fix formatting of subscribe/unsubscribe examples -- File Changes -- M src/modules/rtpengine/doc/rtpengine_admin.xml (153) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4278.patch https://github.com/kamailio/kamailio/pull/4278.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4278 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4278(a)github.com>

1 1

git:master:5166a426: rtpengine: fix formatting of subscribe/unsubscribe examples
by tsearle 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 5166a42633f797d55c9b4072b31a8b69b2387866 URL: https://github.com/kamailio/kamailio/commit/5166a42633f797d55c9b4072b31a8b6… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: tsearle <tsearle(a)gmail.com> Date: 2025-06-10T15:51:06+02:00 rtpengine: fix formatting of subscribe/unsubscribe examples introduce proper code indentation in examples --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5166a42633f797d55c9b4072b31a8b6… Patch: https://github.com/kamailio/kamailio/commit/5166a42633f797d55c9b4072b31a8b6…

1 0

git:master:a0a92fa6: modules: readme files regenerated - pdb ... [skip ci]
by Kamailio Dev 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: a0a92fa6e829bdc2ef8f1e537cf9209ada32ef0b URL: https://github.com/kamailio/kamailio/commit/a0a92fa6e829bdc2ef8f1e537cf9209… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-10T15:16:10+02:00 modules: readme files regenerated - pdb ... [skip ci] --- Modified: src/modules/pdb/README --- Diff: https://github.com/kamailio/kamailio/commit/a0a92fa6e829bdc2ef8f1e537cf9209… Patch: https://github.com/kamailio/kamailio/commit/a0a92fa6e829bdc2ef8f1e537cf9209… --- diff --git a/src/modules/pdb/README b/src/modules/pdb/README index 0c2ec72e122..d5c1c1fa16a 100644 --- a/src/modules/pdb/README +++ b/src/modules/pdb/README @@ -38,7 +38,7 @@ Muhammad Shahzad Shafi 4. Functions - 4.1. pdb_query (string query, string dstavp) + 4.1. pdb_query (string query, string dstpv) 5. RPC Commands @@ -76,7 +76,7 @@ Chapter 1. Admin Guide 4. Functions - 4.1. pdb_query (string query, string dstavp) + 4.1. pdb_query (string query, string dstpv) 5. RPC Commands @@ -163,24 +163,24 @@ modparam("pdb", "ll_info", 3) 4. Functions - 4.1. pdb_query (string query, string dstavp) + 4.1. pdb_query (string query, string dstpv) -4.1. pdb_query (string query, string dstavp) +4.1. pdb_query (string query, string dstpv) Sends the query string to all configured servers and stores the answer - in dstavp. If it takes more than the configured timeout, false is - returned. Pseudo-variables or AVPs can be used for the query string. - The answer must consist of the null terminated query string followed by - a two byte integer value in network byte order. The integer value will - be stored in the given AVP. + in dstvp. If it takes more than the configured timeout, false is + returned. In addition to a string, any pseudo-variable can be used as + query. The answer must consist of the null terminated query string + followed by a two byte integer value in network byte order. The integer + value will be stored in the given pseudo-variable dstvp. Example 1.4. pdb_query usage ... # query external service for routing information -if (!pdb_query("$rU", "$avp(i:82)")) - $avp(i:82) = 0; # default routing +if (!pdb_query("$rU", "$avp(routing)")) + $avp(routing) = 0; # default routing } -cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); +cr_route("$avp(routing)", "$rd", "$rU", "$rU", "call_id"); ... 5. RPC Commands

1 0

git:master:ae133c07: pdb: remove AVP references completely, add some doxygen notes for helper function
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: ae133c0765c01827b172f2c3e38e2d33d5cdcd6b URL: https://github.com/kamailio/kamailio/commit/ae133c0765c01827b172f2c3e38e2d3… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T13:14:55Z pdb: remove AVP references completely, add some doxygen notes for helper function --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/ae133c0765c01827b172f2c3e38e2d3… Patch: https://github.com/kamailio/kamailio/commit/ae133c0765c01827b172f2c3e38e2d3… --- diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 1add3e1a075..eb6731d4ce7 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -216,7 +216,7 @@ int ki_pdb_query(sip_msg_t *_msg, str *number, str *dstvar) * * @param _msg the current SIP message * @param _number the phone number to query - * @param _dstavp the name of the AVP where to store the result + * @param _dstvar the name of the pv where to store the result * * @return 1 on success, -1 on failure */ @@ -234,7 +234,13 @@ int pdb_query(sip_msg_t *_msg, str *_number, str *_dstvar) /*! - * \return 1 if query for the number succeeded and the avp with the corresponding carrier id was set, + * Helper function for queries + * + * @param _msg the current SIP message + * @param number the phone number to query + * @param dstvar the name of the pv where to store the result + * + * @return 1 if query for the number succeeded and the pv with the corresponding carrier id was set, * -1 otherwise */ int ki_pdb_query_helper(sip_msg_t *_msg, str *number, pv_spec_t *dvar) @@ -495,7 +501,7 @@ int pdb_query_fixup(void **arg, int arg_no) return -1; } } else if(arg_no == 2) { - /* destination avp name */ + /* destination pv name */ if(fixup_pvar_null(arg, 1) != 0) { LM_ERR("cannot fixup parameter %d\n", arg_no); return -1;

1 0

git:master:7be5b4c9: pdb: remove AVP references completely in docs, improve example
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 7be5b4c96561430c6d5ec528dcceb5ffba56f7c6 URL: https://github.com/kamailio/kamailio/commit/7be5b4c96561430c6d5ec528dcceb5f… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T13:14:34Z pdb: remove AVP references completely in docs, improve example --- Modified: src/modules/pdb/doc/pdb_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7be5b4c96561430c6d5ec528dcceb5f… Patch: https://github.com/kamailio/kamailio/commit/7be5b4c96561430c6d5ec528dcceb5f… --- diff --git a/src/modules/pdb/doc/pdb_admin.xml b/src/modules/pdb/doc/pdb_admin.xml index f638a29ed32..797fd510d82 100644 --- a/src/modules/pdb/doc/pdb_admin.xml +++ b/src/modules/pdb/doc/pdb_admin.xml @@ -124,27 +124,27 @@ modparam("pdb", "ll_info", 3) <title>Functions</title> <section> <title> - <function moreinfo="none">pdb_query (string query, string dstavp)</function> + <function moreinfo="none">pdb_query (string query, string dstpv)</function> </title> <para> Sends the query string to all configured servers and stores the answer in - dstavp. If it takes more than the configured timeout, false is returned. + dstvp. If it takes more than the configured timeout, false is returned. In addition to a string, any pseudo-variable can be used as query. The answer must consist of the null terminated query string followed by a two byte integer value in network byte order. The integer value will - be stored in the given pseudo-variable dstavp. + be stored in the given pseudo-variable dstvp. </para> <example> <title><function>pdb_query</function> usage</title> <programlisting format="linespecific"> ... # query external service for routing information -if (!pdb_query("$rU", "$avp(i:82)")) - $avp(i:82) = 0; # default routing +if (!pdb_query("$rU", "$avp(routing)")) + $avp(routing) = 0; # default routing } -cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); +cr_route("$avp(routing)", "$rd", "$rU", "$rU", "call_id"); ... </programlisting> </example>

1 0

[kamailio/kamailio] pdb: added KEMI support for PDB module (PR #4265)
by Muhammad Shahzad Shafi 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Added support for KEMI API in PDB module. Here is example usage in KEMI Python. ``` if not (KSR.pdb.pdb_query(KSR.pv.gete("$var(pdb_user)"), "$avp(carrier_id)") > 0): KSR.err(F"""[{HERE()}]: PDB query failed for user '{KSR.pv.get("$var(pdb_user)")}' \n""") else: KSR.info(F""" PDB query return carrier_id = '{KSR.pv.getw("$avp(carrier_id)")}' \n""") ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4265 -- Commit Summary -- * pdb: added KEMI support for PDB module -- File Changes -- M src/modules/pdb/pdb.c (339) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4265.patch https://github.com/kamailio/kamailio/pull/4265.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4265 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4265(a)github.com>

3 5

git:master:5897af3d: pdb: updated documentation
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 5897af3dd46cb1167dc1493c83c79fb57ad7d6d0 URL: https://github.com/kamailio/kamailio/commit/5897af3dd46cb1167dc1493c83c79fb… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T15:05:56+02:00 pdb: updated documentation --- Modified: src/modules/pdb/doc/pdb_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5897af3dd46cb1167dc1493c83c79fb… Patch: https://github.com/kamailio/kamailio/commit/5897af3dd46cb1167dc1493c83c79fb… --- diff --git a/src/modules/pdb/doc/pdb_admin.xml b/src/modules/pdb/doc/pdb_admin.xml index 50fb4190dae..f638a29ed32 100644 --- a/src/modules/pdb/doc/pdb_admin.xml +++ b/src/modules/pdb/doc/pdb_admin.xml @@ -130,11 +130,11 @@ modparam("pdb", "ll_info", 3) Sends the query string to all configured servers and stores the answer in dstavp. If it takes more than the configured timeout, false is returned. - Pseudo-variables or AVPs can be used for the query string. + In addition to a string, any pseudo-variable can be used as query. The answer must consist of the null terminated query string followed by a two byte integer value in network byte order. The integer value will - be stored in the given AVP. + be stored in the given pseudo-variable dstavp. </para> <example> <title><function>pdb_query</function> usage</title>

1 0

git:master:09db09e4: pdb: removed unused multiparam_t struct
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 09db09e44015d5294c21f1d433d9bae8835900ce URL: https://github.com/kamailio/kamailio/commit/09db09e44015d5294c21f1d433d9bae… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T15:05:56+02:00 pdb: removed unused multiparam_t struct --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/09db09e44015d5294c21f1d433d9bae… Patch: https://github.com/kamailio/kamailio/commit/09db09e44015d5294c21f1d433d9bae… --- diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 47c76b0e75c..1add3e1a075 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -57,33 +57,6 @@ static uint16_t *global_id = NULL; ksr_loglevels_t _ksr_loglevels_pdb = KSR_LOGLEVELS_DEFAULTS; -/*! - * Generic parameter that holds a string, an int or a pseudo-variable - * @todo replace this with gparam_t - */ -struct multiparam_t -{ - enum - { - MP_INT, - MP_STR, - MP_AVP, - MP_PVE, - } type; - union - { - int n; - str s; - struct - { - avp_flags_t flags; - avp_name_t name; - } a; - pv_elem_t *p; - } u; -}; - - /* ---- exported commands: */ int pdb_query(sip_msg_t *_msg, str *_number, str *_dstvar);

1 0

git:master:5d6d8f22: pdb: added KEMI support for PDB module
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 5d6d8f22bff4c72020cddc0f5046cdc8b3e2bdf4 URL: https://github.com/kamailio/kamailio/commit/5d6d8f22bff4c72020cddc0f5046cdc… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T15:05:56+02:00 pdb: added KEMI support for PDB module --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/5d6d8f22bff4c72020cddc0f5046cdc… Patch: https://github.com/kamailio/kamailio/commit/5d6d8f22bff4c72020cddc0f5046cdc…

1 0

git:master:97926f20: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 97926f2017f8c837b472e25d52d722012484fc87 URL: https://github.com/kamailio/kamailio/commit/97926f2017f8c837b472e25d52d7220… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-10T15:01:09+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/97926f2017f8c837b472e25d52d7220… Patch: https://github.com/kamailio/kamailio/commit/97926f2017f8c837b472e25d52d7220…

1 0

[kamailio/kamailio] expose subscripe request/answer commands in rtpengine module (Issue #4273)
by tsearle 10 Jun '25

10 Jun '25

tsearle created an issue (kamailio/kamailio#4273) ### Description For forking media and sip rec flows the following rtpengine commands need to be exposed * subscribe reqeust * subscribe answer * unsubscribe currently these commands are only exposed for internal api use. This patch exposes these commands in both kemi and the kamailio scripting language ### Possible Solutions merge the corresponding pr ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (aarch64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0``` * **Operating System**: ``` Linux dev-ew1-blue-app-208 6.1.0-37-cloud-arm64 #1 SMP Debian 6.1.140-1 (2025-05-22) aarch64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4273 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4273(a)github.com>

1 1

[kamailio/kamailio] rtpengine: add support for commands needed for siprec (PR #4274)
by tsearle 10 Jun '25

10 Jun '25

add rtpengine_subscribe_request rtpengine_subscribe_answer and rtpengine_unsubscribe methods to both th cfg and kemi interfaces #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4273 #### Description new kemi and cfg script commands added. existing internal api modifed in a backwards compatible way (though no means of testing this) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4274 -- Commit Summary -- * rtpengine: add support for commands needed for siprec -- File Changes -- M src/modules/rtpengine/rtpengine.c (542) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4274.patch https://github.com/kamailio/kamailio/pull/4274.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4274 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4274(a)github.com>

2 15

git:master:301b319d: rtpengine: add documentation for new siprec methods
by tsearle 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 301b319db73ab32a3d7833e31e46573f0548bd42 URL: https://github.com/kamailio/kamailio/commit/301b319db73ab32a3d7833e31e46573… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: tsearle <tsearle(a)gmail.com> Date: 2025-06-10T14:50:14+02:00 rtpengine: add documentation for new siprec methods --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/301b319db73ab32a3d7833e31e46573… Patch: https://github.com/kamailio/kamailio/commit/301b319db73ab32a3d7833e31e46573…

1 0

git:master:3dae7700: rtpengine: add support for commands needed for siprec
by tsearle 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3dae7700474bfc33d397bb40e0d5192437af04f0 URL: https://github.com/kamailio/kamailio/commit/3dae7700474bfc33d397bb40e0d5192… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: tsearle <tsearle(a)gmail.com> Date: 2025-06-10T14:50:14+02:00 rtpengine: add support for commands needed for siprec add rtpengine_subscribe_request rtpengine_subscribe_answer and rtpengine_unsubscribe methods to both th cfg and kemi interfaces --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/3dae7700474bfc33d397bb40e0d5192… Patch: https://github.com/kamailio/kamailio/commit/3dae7700474bfc33d397bb40e0d5192…

1 0

git:6.0:7bbf2cc6: tm: fix compile warning in uac.c
by Torrey Searle 10 Jun '25

10 Jun '25

Module: kamailio Branch: 6.0 Commit: 7bbf2cc6f2ee947c33d1b6a2495ba210f43b663c URL: https://github.com/kamailio/kamailio/commit/7bbf2cc6f2ee947c33d1b6a2495ba21… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-06-10T14:48:24+02:00 tm: fix compile warning in uac.c fix compile warning introduced by #4250 --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/7bbf2cc6f2ee947c33d1b6a2495ba21… Patch: https://github.com/kamailio/kamailio/commit/7bbf2cc6f2ee947c33d1b6a2495ba21… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index c66955ee671..2d3ffc8af33 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -900,7 +900,7 @@ struct retr_buf *local_ack_rb(sip_msg_t *rpl_2xx, struct cell *trans, #ifdef WITH_EVENT_LOCAL_REQUEST dlg = (dlg_t *)shm_malloc(sizeof(dlg_t)); if(dlg == 0) { - SHM_MEM_ERROR_FMT("required (%u)\n", sizeof(dlg_t)); + SHM_MEM_ERROR_FMT("required (%lu)\n", sizeof(dlg_t)); return NULL; } memset(dlg, 0, sizeof(dlg_t));

1 0

[kamailio/kamailio] tm: fix compile warning in uac.c (PR #4277)
by tsearle 10 Jun '25

10 Jun '25

fix compile warning introduced by #4250   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4277 -- Commit Summary -- * tm: fix compile warning in uac.c -- File Changes -- M src/modules/tm/uac.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4277.patch https://github.com/kamailio/kamailio/pull/4277.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4277 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4277(a)github.com>

2 3

git:master:b4b2f9fc: tm: fix compile warning in uac.c
by Henning Westerholt 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: b4b2f9fc712e079ba0bb2401ca8b2643faf0fa37 URL: https://github.com/kamailio/kamailio/commit/b4b2f9fc712e079ba0bb2401ca8b264… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-10T14:47:00+02:00 tm: fix compile warning in uac.c fix compile warning introduced by #4250 --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/b4b2f9fc712e079ba0bb2401ca8b264… Patch: https://github.com/kamailio/kamailio/commit/b4b2f9fc712e079ba0bb2401ca8b264… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index fab08de1a60..ed31dc5a118 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -906,7 +906,7 @@ struct retr_buf *local_ack_rb(sip_msg_t *rpl_2xx, struct cell *trans, #ifdef WITH_EVENT_LOCAL_REQUEST dlg = (dlg_t *)shm_malloc(sizeof(dlg_t)); if(dlg == 0) { - SHM_MEM_ERROR_FMT("required (%u)\n", sizeof(dlg_t)); + SHM_MEM_ERROR_FMT("required (%lu)\n", sizeof(dlg_t)); return NULL; } memset(dlg, 0, sizeof(dlg_t));

1 0

git:6.0:c020f76b: tm: invoke tm:local-request on generated ACK messages (#4250)
by Torrey Searle 10 Jun '25

10 Jun '25

Module: kamailio Branch: 6.0 Commit: c020f76b231d554545e14ed1f4e543b942ea769b URL: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b… Author: tsearle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-06-10T14:06:40+02:00 tm: invoke tm:local-request on generated ACK messages (#4250) --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b… Patch: https://github.com/kamailio/kamailio/commit/c020f76b231d554545e14ed1f4e543b…

1 0

git:master:58057e9c: lib/srdb1: fix schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e
by Victor Seva 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 58057e9c78971ee215b508f912e94f79bc57f247 URL: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-10T13:52:34+02:00 lib/srdb1: fix schema Makefile after e0dd39618fae2004cd1ab44758ca323376935e2e > diff --git a/doc/stylesheets/dbschema_k/xsl/mongodb.xsl b/doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/mongodb.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/mysql.xsl b/doc/stylesheets/dbschema_k/xsl/db_mysql.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/mysql.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_mysql.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/oracle.xsl b/doc/stylesheets/dbschema_k/xsl/db_oracle.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/oracle.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_oracle.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/postgres.xsl b/doc/stylesheets/dbschema_k/xsl/db_postgres.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/postgres.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_postgres.xsl > diff --git a/doc/stylesheets/dbschema_k/xsl/dbtext.xsl b/doc/stylesheets/dbschema_k/xsl/db_text.xsl > similarity index 100% > rename from doc/stylesheets/dbschema_k/xsl/dbtext.xsl > rename to doc/stylesheets/dbschema_k/xsl/db_text.xsl --- Modified: src/lib/srdb1/schema/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… Patch: https://github.com/kamailio/kamailio/commit/58057e9c78971ee215b508f912e94f7… --- diff --git a/src/lib/srdb1/schema/Makefile b/src/lib/srdb1/schema/Makefile index b057387c703..b76b485e402 100644 --- a/src/lib/srdb1/schema/Makefile +++ b/src/lib/srdb1/schema/Makefile @@ -17,13 +17,13 @@ PI_FRAMEWORK_TABLE_XSL = $(STYLESHEETS)/pi_framework_table.xsl PI_FRAMEWORK_MOD_XSL = $(STYLESHEETS)/pi_framework_mod.xsl # Stylesheet used to generate MySQL database schema -MYSQL_XSL = $(STYLESHEETS)/mysql.xsl +MYSQL_XSL = $(STYLESHEETS)/db_mysql.xsl # Stylesheet used to generate Postgres database schema -POSTGRES_XSL = $(STYLESHEETS)/postgres.xsl +POSTGRES_XSL = $(STYLESHEETS)/db_postgres.xsl # Stylesheet used to generate dbtext database schema -DBTEXT_XSL = $(STYLESHEETS)/dbtext.xsl +DBTEXT_XSL = $(STYLESHEETS)/db_text.xsl # Stylesheet used to generate berkeley database schema DB_BERKELEY_XSL = $(STYLESHEETS)/db_berkeley.xsl @@ -32,10 +32,10 @@ DB_BERKELEY_XSL = $(STYLESHEETS)/db_berkeley.xsl DB_SQLITE_XSL = $(STYLESHEETS)/db_sqlite.xsl # Stylesheet used to generate oracle database schema -ORACLE_XSL = $(STYLESHEETS)/oracle.xsl +ORACLE_XSL = $(STYLESHEETS)/db_oracle.xsl # Stylesheet used to generate mongodb database schema -MONGODB_XSL = $(STYLESHEETS)/mongodb.xsl +MONGODB_XSL = $(STYLESHEETS)/db_mongodb.xsl # Stylesheet used to generate Redis database schema DB_REDIS_XSL = $(STYLESHEETS)/db_redis.xsl

1 0

[kamailio/kamailio] invoke tm:local-request on locally generated ACKs (Issue #4249)
by tsearle 10 Jun '25

10 Jun '25

tsearle created an issue (kamailio/kamailio#4249) ### Description I'm trying to make a SIP Rec callflow using t_uac_send to Generate the INVITE and BYE. This automatically generates the ACK in response to the 200 OK. I want to be able to use tm:local-request to do 2 things. * Add a Contact header to the ACK * Save Route/Callid/CSeq etc so I can generate an in-dialog bye afterwards. ### Expected behavior tm:local-request gets called so I can save the relevant headers & modify the outgoing ack #### Actual observed behavior tm:local-request does not get called ### Possible Solutions the associated PR adds this functionality ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (aarch64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 06:24:22 May 22 2025 with gcc 12.2.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4249 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4249(a)github.com>

1 1

git:master:3f5b8841: tm: invoke tm:local-request on generated ACK messages (#4250)
by GitHub 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3f5b8841bc8eda730568891571cc41b551e291d9 URL: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b… Author: tsearle <torrey.searle(a)wavecrest.com> Committer: GitHub <noreply(a)github.com> Date: 2025-06-10T13:05:06+02:00 tm: invoke tm:local-request on generated ACK messages (#4250) --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b… Patch: https://github.com/kamailio/kamailio/commit/3f5b8841bc8eda730568891571cc41b…

1 0

git:6.0:53f721cf: rtpengine: Add check for skipping pings on manually disabled nodes.
by Xenofon Karamanos 10 Jun '25

10 Jun '25

Module: kamailio Branch: 6.0 Commit: 53f721cf7169e163ceab5113ca3296683b88921e URL: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-10T10:39:31Z rtpengine: Add check for skipping pings on manually disabled nodes. - Add debug log when trying to ping a node. (cherry picked from commit 3202dc9d8e26620fe642e474e5cf8632ab6bc3a7) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… Patch: https://github.com/kamailio/kamailio/commit/53f721cf7169e163ceab5113ca32966… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 2401ad09cbd..36f93dd35aa 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1744,6 +1744,7 @@ static int rtpp_test_ping(struct rtpp_node *node) char *cp; int ret; + LM_DBG("Sending ping to node %.*s\n", node->rn_url.len, node->rn_url.s); if(bencode_buffer_init(&bencbuf)) { return -1; } @@ -3777,7 +3778,7 @@ static void rtpengine_ping_check_timer(unsigned int ticks, void *param) for(crt_rtpp = rtpp_list->rn_first; crt_rtpp != NULL; crt_rtpp = crt_rtpp->rn_next) { - if(!crt_rtpp->rn_displayed) { + if(!crt_rtpp->rn_displayed || crt_rtpp->rn_disabled) { continue; }

1 0

git:master:ec5ab51a: core: srapi - prototype function names set back for msg env push/pop
by Daniel-Constantin Mierla 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: ec5ab51a7ba1c2a94515b8f28c546c9d7cf58b90 URL: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-10T11:57:38+02:00 core: srapi - prototype function names set back for msg env push/pop --- Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… Patch: https://github.com/kamailio/kamailio/commit/ec5ab51a7ba1c2a94515b8f28c546c9… --- diff --git a/src/core/srapi.h b/src/core/srapi.h index 0a1593fe93a..0081624b7be 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -69,8 +69,8 @@ typedef struct ksr_msg_env_links sr_xavp_t **xavis; } ksr_msg_env_links_t; -int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); -int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); +int ksr_msg_env_push(ksr_msg_env_links_t *menv); +int ksr_msg_env_pop(ksr_msg_env_links_t *menv); int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv); #endif

1 0

[kamailio/kamailio] rtpengine: Add check for skipping pings on manually disabled nodes. (PR #4248)
by Xenofon Karamanos 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4247  - Add debug log when trying to ping a node. Do not ping manually disabled nodes! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4248 -- Commit Summary -- * rtpengine: Add check for skipping pings on manually disabled nodes. -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4248.patch https://github.com/kamailio/kamailio/pull/4248.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4248 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4248(a)github.com>

2 4

git:master:3202dc9d: rtpengine: Add check for skipping pings on manually disabled nodes.
by Xenofon Karamanos 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3202dc9d8e26620fe642e474e5cf8632ab6bc3a7 URL: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-06-10T12:28:01+03:00 rtpengine: Add check for skipping pings on manually disabled nodes. - Add debug log when trying to ping a node. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Patch: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 828eca4e7a2..f813bd45579 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1955,6 +1955,7 @@ static int rtpp_test_ping(struct rtpp_node *node) char *cp; int ret; + LM_DBG("Sending ping to node %.*s\n", node->rn_url.len, node->rn_url.s); if(bencode_buffer_init(&bencbuf)) { return -1; } @@ -4078,7 +4079,7 @@ static void rtpengine_ping_check_timer(unsigned int ticks, void *param) for(crt_rtpp = rtpp_list->rn_first; crt_rtpp != NULL; crt_rtpp = crt_rtpp->rn_next) { - if(!crt_rtpp->rn_displayed) { + if(!crt_rtpp->rn_displayed || crt_rtpp->rn_disabled) { continue; }

1 0

[kamailio/kamailio] presence: preserve etag uniqueness when marking presentity for removal (PR #4275)
by Alessio Garzi 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description When the `presence` module attempts to clean up records in the `presentity` table, it replaces the `etag` with a static, hardcoded string: ``` "*#-OFFLINE-#*" ``` However, the `presentity` table enforces a uniqueness constraint on the following combination of fields: ``` MariaDB [kamailio]> show create table presentity; | presentity | CREATE TABLE `presentity` ( ... UNIQUE KEY `presentity_idx` (`username`,`domain`,`event`,`etag`), ``` This approach breaks the uniqueness of etag, which is intended to differentiate records , especially in cases such as parallel calls, or when using kamailio as a forking proxy. Instead of overwriting the etag with the static offline marker, this patch appends the marker to the existing etag value. This ensures the offline flag is retained while preserving the uniqueness of the etag. The deletion query was also updated accordingly: it now identifies offline records using a LIKE '%*#-OFFLINE-#*' clause. Based on testing, the duplicate key errors no longer occur, and the cleanup logic now behaves as expected. This patch improves the reliability of presentity cleanup without requiring schema or index changes. Please consider merging into master. Thanks! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4275 -- Commit Summary -- * presence: preserve etag uniqueness when marking presentity for removal -- File Changes -- M src/modules/presence/presentity.c (90) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4275.patch https://github.com/kamailio/kamailio/pull/4275.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4275 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4275(a)github.com>

3 10

git:master:cdcb570e: core: sdp - check if space is found for extracting session version
by Daniel-Constantin Mierla 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: cdcb570e46101703f4963863c705345c7a3420ac URL: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-10T08:21:44+02:00 core: sdp - check if space is found for extracting session version --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Patch: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 0d18d787242..60613ff8264 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -734,7 +734,7 @@ int extract_sess_version(str *oline, str *sess_version) i++; } while((cp < oline->s + oline->len) && i < 3); - if(cp >= oline->s + oline->len) { + if(cp == NULL || cp0 == NULL || cp >= oline->s + oline->len) { LM_ERR("broken o= line - version field not found\n"); return -1; }

1 0

git:master:418a1017: core: destroy the x/avp lists on msg env data pop
by Daniel-Constantin Mierla 09 Jun '25

09 Jun '25

Module: kamailio Branch: master Commit: 418a1017a58e87a9fe9085f75183bcbfba3f9022 URL: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-09T08:45:31+02:00 core: destroy the x/avp lists on msg env data pop --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… Patch: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 31eb2808835..3be80b4d075 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -79,6 +79,27 @@ sr_cfgenv_t *sr_cfgenv_get(void) static ksr_msg_env_data_t _ksr_msg_env_stack[KSR_MSG_ENV_STACK_SIZE]; static int _ksr_msg_env_stack_idx = 0; +/** + * + */ +int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv) +{ + if(denv == NULL) { + return -1; + } + destroy_avp_list(&denv->avps_uri_from); + destroy_avp_list(&denv->avps_uri_to); + destroy_avp_list(&denv->avps_user_from); + destroy_avp_list(&denv->avps_user_to); + destroy_avp_list(&denv->avps_domain_from); + destroy_avp_list(&denv->avps_domain_to); + xavp_destroy_list(&denv->xavps); + xavp_destroy_list(&denv->xavus); + xavp_destroy_list(&denv->xavis); + + return 0; +} + /** * */ @@ -127,8 +148,8 @@ int ksr_msg_env_pop(ksr_msg_env_links_t *menv) return -1; } - /* current msg x/avp lists are expected to be cleaned up - * - just replace and pop */ + ksr_msg_env_data_destroy(&_ksr_msg_env_stack[_ksr_msg_env_stack_idx - 1]); + set_route_type(menv->route_type); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); diff --git a/src/core/srapi.h b/src/core/srapi.h index d4c64c1976a..0a1593fe93a 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -71,5 +71,6 @@ typedef struct ksr_msg_env_links int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); +int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv); #endif

1 0

git:master:10c6f973: sipdump: use the msg env data stack
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: 10c6f973b0f2334c6b2790d61efa1fc3ac282a01 URL: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 sipdump: use the msg env data stack --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… Patch: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index e199d1cefc9..6dd3af751af 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -293,7 +293,7 @@ int sipdump_event_route(sipdump_data_t *sdi) sr_kemi_eng_t *keng = NULL; str evname = str_init("sipdump:msg"); sip_msg_t *fmsg = NULL; - ksr_msg_env_t menv = {0}; + ksr_msg_env_links_t menv = {0}; ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE);

1 0

git:master:f3a6f2ed: siptrace: use the msg env data stack
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: f3a6f2ed539a4a0f287ba0bfee89bd44d2f1a781 URL: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 siptrace: use the msg env data stack --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… Patch: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 3c27e20fe87..79d1756a979 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2227,7 +2227,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) sr_kemi_eng_t *keng = NULL; str evname = str_init("siptrace:msg"); sip_msg_t msg; - ksr_msg_env_t menv = {0}; + ksr_msg_env_links_t menv = {0}; if(_siptrace_evrt_msg_idx < 0 && _siptrace_evcb_msg.len <= 0) { return 0;

1 0

git:master:c10c1d7f: core: keep a stack of msg env data
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: c10c1d7f0214105c01a300b4a69c58219e4c970a URL: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 core: keep a stack of msg env data - GH #4258 --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… Patch: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index a16acf97d21..31eb2808835 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -75,29 +75,60 @@ sr_cfgenv_t *sr_cfgenv_get(void) /** * */ -void ksr_msg_env_push(ksr_msg_env_t *menv) +#define KSR_MSG_ENV_STACK_SIZE 8 +static ksr_msg_env_data_t _ksr_msg_env_stack[KSR_MSG_ENV_STACK_SIZE]; +static int _ksr_msg_env_stack_idx = 0; + +/** + * + */ +int ksr_msg_env_push(ksr_msg_env_links_t *oenv) { - menv->route_type = get_route_type(); - - menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); - menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); - menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); - menv->avps_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, NULL); - menv->avps_domain_from = - set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, NULL); - menv->avps_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, NULL); - menv->xavps = xavp_set_list(NULL); - menv->xavus = xavu_set_list(NULL); - menv->xavis = xavi_set_list(NULL); - - return; + ksr_msg_env_data_t *senv = NULL; + + if(_ksr_msg_env_stack_idx >= KSR_MSG_ENV_STACK_SIZE) { + LM_ERR("msg env stack size exceeded\n"); + return -1; + } + senv = &_ksr_msg_env_stack[_ksr_msg_env_stack_idx]; + memset(&_ksr_msg_env_stack[_ksr_msg_env_stack_idx], 0, + sizeof(ksr_msg_env_data_t)); + + oenv->route_type = get_route_type(); + + oenv->avps_uri_from = + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &senv->avps_uri_from); + oenv->avps_uri_to = + set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &senv->avps_uri_to); + oenv->avps_user_from = set_avp_list( + AVP_TRACK_FROM | AVP_CLASS_USER, &senv->avps_user_from); + oenv->avps_user_to = + set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, &senv->avps_user_to); + oenv->avps_domain_from = set_avp_list( + AVP_TRACK_FROM | AVP_CLASS_DOMAIN, &senv->avps_domain_from); + oenv->avps_domain_to = set_avp_list( + AVP_TRACK_TO | AVP_CLASS_DOMAIN, &senv->avps_domain_to); + oenv->xavps = xavp_set_list(&senv->xavps); + oenv->xavus = xavu_set_list(&senv->xavus); + oenv->xavis = xavi_set_list(&senv->xavis); + + _ksr_msg_env_stack_idx++; + + return 0; } /** * */ -void ksr_msg_env_pop(ksr_msg_env_t *menv) +int ksr_msg_env_pop(ksr_msg_env_links_t *menv) { + if(_ksr_msg_env_stack_idx <= 0) { + LM_ERR("invalid msg env stack index\n"); + return -1; + } + + /* current msg x/avp lists are expected to be cleaned up + * - just replace and pop */ set_route_type(menv->route_type); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); @@ -110,5 +141,7 @@ void ksr_msg_env_pop(ksr_msg_env_t *menv) xavu_set_list(menv->xavus); xavi_set_list(menv->xavis); - return; + _ksr_msg_env_stack_idx--; + + return 0; } diff --git a/src/core/srapi.h b/src/core/srapi.h index b573493a62b..d4c64c1976a 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -41,7 +41,21 @@ typedef struct sr_cfgenv void sr_cfgenv_init(void); sr_cfgenv_t *sr_cfgenv_get(void); -typedef struct ksr_msg_env +typedef struct ksr_msg_env_data +{ + int route_type; + avp_list_t avps_user_from; + avp_list_t avps_user_to; + avp_list_t avps_domain_from; + avp_list_t avps_domain_to; + avp_list_t avps_uri_from; + avp_list_t avps_uri_to; + sr_xavp_t *xavps; + sr_xavp_t *xavus; + sr_xavp_t *xavis; +} ksr_msg_env_data_t; + +typedef struct ksr_msg_env_links { int route_type; avp_list_t *avps_user_from; @@ -53,9 +67,9 @@ typedef struct ksr_msg_env sr_xavp_t **xavps; sr_xavp_t **xavus; sr_xavp_t **xavis; -} ksr_msg_env_t; +} ksr_msg_env_links_t; -void ksr_msg_env_push(ksr_msg_env_t *menv); -void ksr_msg_env_pop(ksr_msg_env_t *menv); +int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); +int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); #endif

1 0

git:master:3379d66b: uac: added ftag and ttag fields for $uac_req(...)
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: 3379d66b082ed866235d354c96171b964fd2d708 URL: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 uac: added ftag and ttag fields for $uac_req(...) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… Patch: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index ea3595ca755..2513a6989d0 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -63,8 +63,12 @@ typedef struct _uac_send_info str s_ruri; char b_turi[MAX_URI_SIZE]; str s_turi; + char b_ttag[128]; + str s_ttag; char b_furi[MAX_URI_SIZE]; str s_furi; + char b_ftag[128]; + str s_ftag; char b_callid[128]; str s_callid; char b_hdrs[MAX_UACH_SIZE]; @@ -99,7 +103,9 @@ void uac_send_info_copy(uac_send_info_t *src, uac_send_info_t *dst) dst->s_method.s = dst->b_method; dst->s_ruri.s = dst->b_ruri; dst->s_turi.s = dst->b_turi; + dst->s_ttag.s = dst->b_ttag; dst->s_furi.s = dst->b_furi; + dst->s_ftag.s = dst->b_ftag; dst->s_hdrs.s = dst->b_hdrs; dst->s_body.s = dst->b_body; dst->s_ouri.s = dst->b_ouri; @@ -193,6 +199,15 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, _uac_req.fr_timeout); case 20: return pv_get_uintval(msg, param, res, _uac_req.fr_inv_timeout); + case 21: + if(_uac_req.s_ftag.len <= 0) + return pv_get_null(msg, param, res); + return pv_get_strval(msg, param, res, &_uac_req.s_ftag); + case 22: + if(_uac_req.s_ttag.len <= 0) + return pv_get_null(msg, param, res); + return pv_get_strval(msg, param, res, &_uac_req.s_ttag); + default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -217,7 +232,9 @@ int pv_set_uac_req( _uac_req.flags = 0; _uac_req.s_ruri.len = 0; _uac_req.s_furi.len = 0; + _uac_req.s_ftag.len = 0; _uac_req.s_turi.len = 0; + _uac_req.s_ttag.len = 0; _uac_req.s_ouri.len = 0; _uac_req.s_hdrs.len = 0; _uac_req.s_body.len = 0; @@ -228,6 +245,8 @@ int pv_set_uac_req( _uac_req.evtype = 0; _uac_req.evcode = 0; _uac_req.cseqno = 0; + _uac_req.fr_timeout = 0; + _uac_req.fr_inv_timeout = 0; _uac_req.s_evparam.len = 0; } break; @@ -512,6 +531,40 @@ int pv_set_uac_req( } _uac_req.fr_inv_timeout = tval->ri; break; + case 21: + if(tval == NULL) { + _uac_req.s_ftag.len = 0; + return 0; + } + if(!(tval->flags & PV_VAL_STR)) { + LM_ERR("Invalid value type\n"); + return -1; + } + if(tval->rs.len >= 128) { + LM_ERR("Value size too big\n"); + return -1; + } + memcpy(_uac_req.s_ftag.s, tval->rs.s, tval->rs.len); + _uac_req.s_ftag.s[tval->rs.len] = '\0'; + _uac_req.s_ftag.len = tval->rs.len; + break; + case 22: + if(tval == NULL) { + _uac_req.s_ttag.len = 0; + return 0; + } + if(!(tval->flags & PV_VAL_STR)) { + LM_ERR("Invalid value type\n"); + return -1; + } + if(tval->rs.len >= 128) { + LM_ERR("Value size too big\n"); + return -1; + } + memcpy(_uac_req.s_ttag.s, tval->rs.s, tval->rs.len); + _uac_req.s_ttag.s[tval->rs.len] = '\0'; + _uac_req.s_ttag.len = tval->rs.len; + break; } return 0; } @@ -533,8 +586,12 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 1; else if(strncmp(in->s, "turi", 4) == 0) sp->pvp.pvn.u.isname.name.n = 2; + else if(strncmp(in->s, "ttag", 4) == 0) + sp->pvp.pvn.u.isname.name.n = 22; else if(strncmp(in->s, "furi", 4) == 0) sp->pvp.pvn.u.isname.name.n = 3; + else if(strncmp(in->s, "ftag", 4) == 0) + sp->pvp.pvn.u.isname.name.n = 21; else if(strncmp(in->s, "hdrs", 4) == 0) sp->pvp.pvn.u.isname.name.n = 4; else if(strncmp(in->s, "body", 4) == 0) @@ -612,7 +669,9 @@ void uac_req_init(void) memset(&_uac_req, 0, sizeof(struct _uac_send_info)); _uac_req.s_ruri.s = _uac_req.b_ruri; _uac_req.s_furi.s = _uac_req.b_furi; + _uac_req.s_ftag.s = _uac_req.b_ftag; _uac_req.s_turi.s = _uac_req.b_turi; + _uac_req.s_ttag.s = _uac_req.b_ttag; _uac_req.s_ouri.s = _uac_req.b_ouri; _uac_req.s_hdrs.s = _uac_req.b_hdrs; _uac_req.s_body.s = _uac_req.b_body;

1 0

[kamailio/kamailio] core: tcp_send_timeout applied for outbound connections (PR #4234)
by sergey-safarov 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4187 #### Description core: tcp_send_timeout applied for outbound connections You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4234 -- Commit Summary -- * core: tcp_send_timeout applied for outbound connections -- File Changes -- M src/core/tcp_main.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4234.patch https://github.com/kamailio/kamailio/pull/4234.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4234 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4234(a)github.com>

3 8

git:master:91053984: core: tcp_send_timeout applied for outbound connections
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9105398413b4f9fab410482d9ebf5d82b6c3fb0a URL: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T16:08:44+02:00 core: tcp_send_timeout applied for outbound connections --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… Patch: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 604102dcef6..369bfb1f159 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -352,6 +352,17 @@ static int init_sock_opt(int s, int af) } } #endif +#ifdef HAVE_TCP_USER_TIMEOUT + if((optval = TICKS_TO_S(cfg_get(tcp, tcp_cfg, send_timeout)))) { + optval *= 1000; + if(setsockopt(s, IPPROTO_TCP, TCP_USER_TIMEOUT, &optval, sizeof(optval)) + < 0) { + LM_WARN("failed to set TCP_USER_TIMEOUT: %s\n", strerror(errno)); + } else { + LM_DBG("Set TCP_USER_TIMEOUT=%d ms\n", optval); + } + } +#endif #ifdef HAVE_TCP_QUICKACK if(cfg_get(tcp, tcp_cfg, delayed_ack)) { optval = 0; /* reset quick ack => delayed ack */

1 0

git:master:128ccdc6: modules: readme files regenerated - file_out ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 128ccdc6330232fd810bd0a35b325e44d5bdf98d URL: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T15:46:10+02:00 modules: readme files regenerated - file_out ... [skip ci] --- Modified: src/modules/file_out/README --- Diff: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… Patch: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… --- diff --git a/src/modules/file_out/README b/src/modules/file_out/README index 89ca58147c1..0fcbf640251 100644 --- a/src/modules/file_out/README +++ b/src/modules/file_out/README @@ -23,6 +23,7 @@ Xenofon Karamanos 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 4. Functions @@ -35,7 +36,8 @@ Xenofon Karamanos 1.1. Set base_folder parameter 1.2. Set file parameter 1.3. Set worker_usleep parameter - 1.4. file_out usage + 1.4. Set timer_interval parameter + 1.5. file_out usage Chapter 1. Admin Guide @@ -52,6 +54,7 @@ Chapter 1. Admin Guide 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 4. Functions @@ -98,6 +101,7 @@ Chapter 1. Admin Guide 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 3.1. base_folder (string) @@ -146,6 +150,18 @@ modparam("file_out", "file", "name=accounting;extension=.txt") modparam("file_out", "worker_usleep", "1000") ... +3.4. timer_interval (int) + + The time in seconds which timer will trigger for rotating the files. + Make sure that this value is lower than the interval of the files. + + Default value is “10” (10 s). + + Example 1.4. Set timer_interval parameter +... +modparam("file_out", "timer_interval", "60") +... + 4. Functions 4.1. file_out(filename, string) @@ -157,7 +173,7 @@ modparam("file_out", "worker_usleep", "1000") string to be written to the file. Filename is the name of the file defined in the configuration file as name=filename. - Example 1.4. file_out usage + Example 1.5. file_out usage ... modparam("file_out", "file", "name=accounting;interval=200") modparam("file_out", "file", "name=missed_calls;extension=.json;interval=300")

1 0

[kamailio/kamailio] file_out: Add rotation timer (PR #4263)
by Xenofon Karamanos 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR introduces a new modparam `timer_interval` to denote the frequency where files are checked for rotation. Also some improvements regarding memory managments and defaults options. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4263 -- Commit Summary -- * file_out: Consistent check * file_out: Memory allocation and copy when used. * file_out: Add debug function * file_out: Add file properties init function * file_out: Rotate files based on timer * file_out: Add require_rotation for better file handling * file_out: Fix missing evaluated PVs * file_out/docs: Add timer_interval doc -- File Changes -- M src/modules/file_out/doc/file_out_admin.xml (23) M src/modules/file_out/file_out.c (193) M src/modules/file_out/types.c (79) M src/modules/file_out/types.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4263.patch https://github.com/kamailio/kamailio/pull/4263.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4263 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4263(a)github.com>

3 3

git:master:92484d73: file_out: docs: Add timer_interval doc
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 92484d73b136a95a46e118af6b46b566f5df1875 URL: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: docs: Add timer_interval doc --- Modified: src/modules/file_out/doc/file_out_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… Patch: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… --- diff --git a/src/modules/file_out/doc/file_out_admin.xml b/src/modules/file_out/doc/file_out_admin.xml index ce02069ae83..83b84b6abc6 100644 --- a/src/modules/file_out/doc/file_out_admin.xml +++ b/src/modules/file_out/doc/file_out_admin.xml @@ -190,6 +190,29 @@ modparam("file_out", "worker_usleep", "1000") </example> </section> + <section> + <title> + <varname>timer_interval</varname> (int)</title> + <para> + The time in seconds which timer will trigger for rotating the files. + <emphasis> + Make sure that this value is lower than the interval of the files. + </emphasis> + </para> + <para> + <emphasis> + Default value is <quote>10</quote> (10 s). + </emphasis> + </para> + <example> + <title>Set <varname>timer_interval</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("file_out", "timer_interval", "60") +... + </programlisting> + </example> + </section> </section> <section>

1 0

git:master:9b5ad5d1: file_out: Fix missing evaluated PVs
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9b5ad5d1d814bc9ba4c41dc02bac4362268ec37f URL: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Fix missing evaluated PVs --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… Patch: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index ce43c1f3a32..6ec2a950119 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -548,6 +548,7 @@ static int fo_init_file(const int index) LM_ERR("Couldn't open file %s\n", strerror(errno)); return -1; } + return 1; } @@ -643,12 +644,8 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) return -1; } - fo_prefix_str.s = fo_prefix_buf; - fo_prefix_str.len = buf_size; - if(pv_printf(msg, fo_files[file_index].fo_prefix_pvs, fo_prefix_str.s, - &fo_prefix_str.len) - == 0 - && fo_prefix_str.len > 0) { + if(pv_printf_s(msg, fo_files[file_index].fo_prefix_pvs, &fo_prefix_str) + == 0) { fo_prefix_val.s = fo_prefix_str.s; fo_prefix_val.len = fo_prefix_str.len; }

1 0

git:master:59a23249: file_out: Add require_rotation for better file handling
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 59a23249c9ddf64119d6129123b3c610de66d6f3 URL: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add require_rotation for better file handling --- Modified: src/modules/file_out/file_out.c Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61… Patch: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61…

1 0

git:master:a841fd25: file_out: Rotate files based on timer
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: a841fd2539ed8c13184face4fdf6215a917162cc URL: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Rotate files based on timer --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215… Patch: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215…

1 0

git:master:ca72b648: file_out: Add file properties init function
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: ca72b6487fbed30be4ca83f7864c2ac1a29c647e URL: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add file properties init function --- Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… Patch: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… --- diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 1b5ffc4c6cb..9c2056ef59e 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -121,6 +121,41 @@ void fo_free_queue(fo_queue_t *q) shm_free(q); } +int fo_file_properties_init(fo_file_properties_t *fp) +{ + if(fp == NULL) { + return -1; + } + + /* Malloc member for each element required */ + fp->fo_base_filename.s = (char *)shm_malloc(FO_MAX_PATH_LEN * sizeof(char)); + if(fp->fo_base_filename.s == NULL) { + LM_ERR("Failed to allocate memory for base filename\n"); + return -1; + } + fp->fo_extension.s = (char *)shm_malloc(10 * sizeof(char)); + if(fp->fo_extension.s == NULL) { + LM_ERR("Failed to allocate memory for extension\n"); + return -1; + } + + fp->fo_prefix.s = (char *)shm_malloc(4096 * sizeof(char)); + if(fp->fo_prefix.s == NULL) { + LM_ERR("Failed to allocate memory for prefix\n"); + return -1; + } + fp->fo_stored_timestamp = time(NULL); + fp->fo_interval_seconds = 0; + + fp->fo_prefix_pvs = (pv_elem_t *)shm_malloc(sizeof(pv_elem_t)); + if(fp->fo_prefix_pvs == NULL) { + LM_ERR("Failed to allocate memory for prefix pvs\n"); + return -1; + } + + return 1; +} + int fo_file_properties_destroy(fo_file_properties_t *fp) { if(fp == NULL) { diff --git a/src/modules/file_out/types.h b/src/modules/file_out/types.h index 940c6f7476b..27d3884ffc9 100644 --- a/src/modules/file_out/types.h +++ b/src/modules/file_out/types.h @@ -27,6 +27,7 @@ #include "../../core/pvar.h" #define FO_MAX_FILES 10 /* Maximum number of files */ +#define FO_MAX_PATH_LEN 2048 typedef struct log_message { @@ -65,6 +66,7 @@ typedef struct fo_file_properties FILE *fo_file_output; } fo_file_properties_t; +int fo_file_properties_init(fo_file_properties_t *fp); int fo_file_properties_destroy(fo_file_properties_t *fp); int fo_file_properties_print(const fo_file_properties_t file_prop);

1 0

git:master:60086f11: file_out: Add debug function
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 60086f1108ac199d4db4453c2c14865e2e16022c URL: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add debug function --- Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… Patch: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… --- diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 5b9a62112f4..1b5ffc4c6cb 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -140,3 +140,13 @@ int fo_file_properties_destroy(fo_file_properties_t *fp) } return 1; } + +int fo_file_properties_print(const fo_file_properties_t file_prop) +{ + LM_DBG("Base filename: %s\n", file_prop.fo_base_filename.s); + LM_DBG("Prefix: %s\n", file_prop.fo_prefix.s); + LM_DBG("Extension: %s\n", file_prop.fo_extension.s); + LM_DBG("Interval: %d\n", file_prop.fo_interval_seconds); + LM_DBG("Stored timestamp: %ld\n", file_prop.fo_stored_timestamp); + return 1; +} diff --git a/src/modules/file_out/types.h b/src/modules/file_out/types.h index 6140e4ff111..940c6f7476b 100644 --- a/src/modules/file_out/types.h +++ b/src/modules/file_out/types.h @@ -66,5 +66,6 @@ typedef struct fo_file_properties } fo_file_properties_t; int fo_file_properties_destroy(fo_file_properties_t *fp); +int fo_file_properties_print(const fo_file_properties_t file_prop); #endif

1 0

git:master:c4521d05: file_out: Memory allocation and copy when used.
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: c4521d05cb90773e6a50747a4dc1f069617d7843 URL: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Memory allocation and copy when used. --- Modified: src/modules/file_out/file_out.c Modified: src/modules/file_out/types.c --- Diff: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… Patch: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 7a275d59022..ecd8298a874 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -589,9 +589,31 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) fo_prefix_val.len = fo_prefix_str.len; } + /* Allocate memory */ + logMessage.prefix = (str *)shm_malloc(sizeof(str)); + if(logMessage.prefix == NULL) { + SHM_MEM_ERROR; + return -1; + } + + logMessage.message = (str *)shm_malloc(sizeof(str)); + if(logMessage.message == NULL) { + SHM_MEM_ERROR; + return -1; + } + + /* Copy the value */ + if(shm_str_dup(logMessage.prefix, &fo_prefix_val) < 0) { + LM_ERR("Failed to copy prefix\n"); + return -1; + } + + if(shm_str_dup(logMessage.message, &value) < 0) { + LM_ERR("Failed to copy message\n"); + return -1; + } + /* Add the logging string to the global gueue */ - logMessage.prefix = &fo_prefix_val; - logMessage.message = &value; logMessage.dest_file = file_index; fo_enqueue(fo_queue, logMessage); diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 0ae9bc7b063..5b9a62112f4 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -37,36 +37,6 @@ static fo_node_t *fo_new_node(fo_log_message_t data) int fo_enqueue(fo_queue_t *q, fo_log_message_t data) { - /* - Copy the contents of data.message - */ - str *message_copy = 0; - str *prefix_copy = 0; - /* - * Allocate memory for the message and prefix - */ - message_copy = (str *)shm_malloc(sizeof(str)); - if(message_copy == 0) { - SHM_MEM_ERROR; - return -1; - } - if(shm_str_dup(message_copy, data.message) < 0) { - LM_ERR("Failed to duplicate message\n"); - return -1; - } - data.message = message_copy; - - prefix_copy = (str *)shm_malloc(sizeof(str)); - if(prefix_copy == 0) { - SHM_MEM_ERROR; - return -1; - } - if(shm_str_dup(prefix_copy, data.prefix) < 0) { - LM_ERR("Failed to duplicate prefix\n"); - return -1; - } - data.prefix = prefix_copy; - fo_node_t *temp = fo_new_node(data); lock_get(&(q->lock));

1 0

git:master:b8373b9a: file_out: Consistent check
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: b8373b9aeeb9d4d4b0b56f6f4de3a358bd224daf URL: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Consistent check --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… Patch: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 149059e0e68..7a275d59022 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -206,7 +206,7 @@ static void destroy(void) } } - if(fo_prefix_buf) { + if(fo_prefix_buf != NULL) { pkg_free(fo_prefix_buf); }

1 0

[kamailio/kamailio] permanently disabled rtpengine nodes in a set are not permanently disabled anymore after commits: (e183a3e25c, 3823479733) (Issue #4247)
by Nuno M Reis ＠talkdesk 06 Jun '25

06 Jun '25

nmreistd created an issue (kamailio/kamailio#4247)  ### Description rtpengine module is now trying to ping previous permanently disabled nodes after commits: ``` * e183a3e25c rtpengine: Re-enable down servers (but not disabled ones) * 3823479733 rtpengine: Add timer to ping rtpengine ``` ### Troubleshooting #### Reproduction Just create a set of nodes and also set at least one to be permanently disabled. After that do RPC `rtpengine.reload` or equivelent and after a `rtpengine.show all` and `disabled: 1(permanent)` will never show as before the aforementioned additions. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` Tested between `kamailio 5.8.2` and `6.0.1` ``` * **Operating System**:  ``` debian bookworm ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4247 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4247(a)github.com>

3 4

[kamailio/kamailio] Missing two way audio when using Yealink. Kamilio + rtpengine + freeswitch/fusionpbx (Issue #4270)
by jaspreet-eltropy 06 Jun '25

06 Jun '25

jaspreet-eltropy created an issue (kamailio/kamailio#4270) **I’m running into an issue when using Yealink SIP phones in a setup involving Kamailio + RTPengine + FreeSWITCH/Fusionpbx.** **Setup Overview:** SIP Proxy: Kamailio (handling NAT traversal, registration, and routing) Media Relay: RTPengine (with replace-origin, replace-session-connection, media-address, and other options) Media Server: FreeSWITCH (handles RTP/audio and call logic) Phone: Yealink T54w Series (but likely affects other models too) Transport: UDP (with force_rport() and NAT detection routes in place) Environment: Mixed NAT/public IPs with STUN/TURN enabled on WebRTC clients(SIP.js) (where applicable) Problem Description: When a call is placed from/to a Yealink phone, the call signaling works fine (INVITE, 200 OK, ACK are all seen correctly), but there is no audio or sometimes one-way audio. This only happens with Yealink; other SIP clients (Zoiper, Linphone, SIP.js etc.) work fine with the same setup. From packet captures and Kamailio logs, I can see the following: RTPengine receives the call and processes it. The rtpengine_manage() is called with these flags: May 30 05:38:13 ip-10-7-37-179 /usr/local/sbin/kamailio[62354]: INFO: <script>: BRIDGING: TRYING TO BRIDGE udp sip:5555@192.168.1.10:12561;transport=TCP May 30 05:38:13 ip-10-7-37-179 /usr/local/sbin/kamailio[62354]: INFO: <script>: NATMANAGE branch_id:0 ruri: sip:5555@192.168.1.10:12561;transport=TCP, method:INVITE, status:<null>, extra_id: z9hG4bKcSBpr6vNyyepe0, rtpengine_manage: replace-origin replace-session-connection media-address=52.24.225.81 trust-address via-branch=extra The Yealink phone sends SDP with correct IPs, but it doesn’t receive RTP (confirmed via tcpdump). Interestingly, if I bypass RTPengine + kamilio (media goes directly to/from FreeSWITCH), audio works. What I’ve Tried: Enabling/disabling trust-address and via-branch options. Using set_contact_alias() for REGISTER/NATed clients. Ensured that Contact header aliasing is applied. Verified that Yealink NAT settings are configured correctly. Using force_rport() and fix_nated_register() in Kamailio. Ensured RTP ports are open and media_address in RTPengine is set correctly. My Questions: Is there a known compatibility issue with Yealink phones and RTPengine in relayed mode? Does Yealink require specific NAT handling rules that differ from softphones? Are there any recommended rtpengine_manage() flags or Kamailio routing practices specifically for Yealink endpoints? Any suggestions to debug further — SIP traces seem clean, but RTP is not received by the Yealink. Sample Logs (Kamailio): NATMANAGE branch_id:0 ruri: <null>, method:INVITE, status:100, extra_id: z9hG4bK4b1.ffbb20e21cff840bb08800b46398f55b.00, rtpengine_manage: replace-origin replace-session-connection media-address=52.24.225.81 trust-address via-branch=extra Yealink SIP Config: NAT Traversal: Enabled (STUN) Keep-Alive: 30s UDP port: 5060 SIP registration: works Audio: not working when RTPengine is in the path Any help or suggestions would be greatly appreciated. Let me know if logs or traces are needed. ``` -[ RECORD 1 ]-+---------------------------------------------------------------------- id | 3259 ruid | uloc-683943f5-f3a0-1 username | 5555 domain | contact | sip:5555@192.168.1.10:12561;transport=TCP received | sip:182.77.49.201:12561;transport=tcp path | expires | 2025-05-30 05:44:04 q | -1 callid | [2_689921921@192.168.1.10](mailto:2_689921921@192.168.1.10) cseq | 6 last_modified | 2025-05-30 05:42:04 flags | 0 cflags | 64 user_agent | Yealink SIP-T54W 96.86.0.75 socket | tcp:10.7.37.179:5060 methods | 16383 instance | reg_id | 0 server_id | 0 connection_id | 4 keepalive | 1 partition | 28 ``` Thanks in advance -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4270 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4270(a)github.com>

3 5

git:master:a1449f0d: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: a1449f0d160fa0911fb6cad588e4c41a9dc5d147 URL: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T15:16:09+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README Modified: src/modules/pua_reginfo/README --- Diff: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41… Patch: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41…

1 0

[kamailio/kamailio] wip: pua_reginfo: add helper to disable publishing for current message (PR #4253)
by Matteo 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4252 #### Description This PR adds a new helper `reginfo_disable_publish` to `pua_reginfo` module which disabled the publishing for the current message, which is useful to control when to actually send it or not (eg in DMQ replication scenarios). The helper is "negative" (it *disables* not enables) on purpose in order to mantain backward compatibility to current behaviour. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4253 -- Commit Summary -- * pua_reginfo: add helper to disable publishing for current message -- File Changes -- M src/modules/pua_reginfo/pua_reginfo.c (4) M src/modules/pua_reginfo/pua_reginfo.h (4) M src/modules/pua_reginfo/usrloc_cb.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4253.patch https://github.com/kamailio/kamailio/pull/4253.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4253 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4253(a)github.com>

3 8

git:master:708dd175: pua_reginfo: add helper to disable publishing for current message
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 708dd1753483240c82c5796e11686db40544d145 URL: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… Author: Matteo Brancaleoni <matteo.brancaleoni(a)voismart.it> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:14:48+02:00 pua_reginfo: add helper to disable publishing for current message --- Modified: src/modules/pua_reginfo/doc/pua_reginfo_admin.xml Modified: src/modules/pua_reginfo/pua_reginfo.c Modified: src/modules/pua_reginfo/pua_reginfo.h Modified: src/modules/pua_reginfo/usrloc_cb.c --- Diff: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… Patch: https://github.com/kamailio/kamailio/commit/708dd1753483240c82c5796e11686db… --- diff --git a/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml b/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml index 9e2da526c8e..8229377adb4 100644 --- a/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml +++ b/src/modules/pua_reginfo/doc/pua_reginfo_admin.xml @@ -234,6 +234,33 @@ reply_route[1] { if (t_check_status("200")) reginfo_subscribe("$ru"); } +... + </programlisting> + </example> + </section> + <section id="pua_reginfo.f.reginfo_disable_publish"> + <title> + <function moreinfo="none">reginfo_disable_publish()</function> + </title> + <para> + This function disables sending the PUBLISH request in the registrar + callback invocation, for the current message only. + </para> + + <example> + <title><function>reginfo_disable_publish</function> usage</title> + <programlisting format="linespecific"> +... +if(is_method("REGISTER")) { + if (dmq_is_from_node()) + # coming from a DMQ node, just save without triggering PUBLISH + # which may be replicated differently, like with presence DMQ support + reginfo_disable_publish(); + save("location"); + } else { + # coming from end point - authenticate, save contact, etc... + } +} ... </programlisting> </example> diff --git a/src/modules/pua_reginfo/pua_reginfo.c b/src/modules/pua_reginfo/pua_reginfo.c index 6a0b91170ea..573b6efc15d 100644 --- a/src/modules/pua_reginfo/pua_reginfo.c +++ b/src/modules/pua_reginfo/pua_reginfo.c @@ -46,6 +46,8 @@ str server_address = {NULL, 0}; int publish_reginfo = 1; +int reginfo_disable_publish = 0; /* Disables publish for current message */ + sruid_t _reginfo_sruid; int reginfo_use_domain = 0; @@ -65,6 +67,8 @@ static cmd_export_t cmds[] = { fixup_subscribe, 0, REQUEST_ROUTE | ONREPLY_ROUTE}, {"reginfo_handle_notify", (cmd_function)reginfo_handle_notify, 1, domain_fixup, 0, REQUEST_ROUTE}, + {"reginfo_disable_publish", (cmd_function)w_reginfo_disable_publish, 0, + 0, 0, REQUEST_ROUTE}, {0, 0, 0, 0, 0, 0} }; diff --git a/src/modules/pua_reginfo/pua_reginfo.h b/src/modules/pua_reginfo/pua_reginfo.h index 6ffaa6ba516..70fd42a1cb5 100644 --- a/src/modules/pua_reginfo/pua_reginfo.h +++ b/src/modules/pua_reginfo/pua_reginfo.h @@ -37,5 +37,9 @@ extern usrloc_api_t ul; /*!< Structure containing pointers to usrloc functions*/ extern pua_api_t pua; /*!< Structure containing pointers to PUA functions*/ extern int reginfo_use_domain; +extern int reginfo_disable_publish; + +int w_reginfo_disable_publish(sip_msg_t *, char *, char *); +int ki_reginfo_disable_publish(sip_msg_t *); #endif diff --git a/src/modules/pua_reginfo/usrloc_cb.c b/src/modules/pua_reginfo/usrloc_cb.c index 5cc1377b9de..8bc5a7884bd 100644 --- a/src/modules/pua_reginfo/usrloc_cb.c +++ b/src/modules/pua_reginfo/usrloc_cb.c @@ -53,6 +53,18 @@ Call-ID: 9ad9f89f-164d-bb86-1072-52e7e9eb5025. static int _pua_reginfo_self_op = 0; +#define BUF_LEN 256 +int ki_reginfo_disable_publish(sip_msg_t *msg) +{ + reginfo_disable_publish = 1; + return 1; +} + +int w_reginfo_disable_publish(struct sip_msg *msg, char *s1, char *s2) +{ + return ki_reginfo_disable_publish(msg); +} + void pua_reginfo_update_self_op(int v) { _pua_reginfo_self_op = v; @@ -266,6 +278,15 @@ void reginfo_usrloc_cb(ucontact_t *c, int type, void *param) return; } + if(reginfo_disable_publish == 1) { + LM_DBG("Not publishing due to reginfo_disable_publish for aor: %.*s " + "(%d)\n", + c->aor->len, c->aor->s, type); + + reginfo_disable_publish = 0; + return; + } + content_type.s = "application/reginfo+xml"; content_type.len = 23;

1 0

[kamailio/kamailio] tls: add WSS to RPC funtions (PR #4262)
by Benjamin 06 Jun '25

06 Jun '25

- tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> #### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4167 #### Description WSS connection is not shown in tls.list RPC command like all other TLS connections. Also tls_kill does not handle WSS connections. This is related to the issue 4167. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4262 -- Commit Summary -- * tls: add WSS to RPC funtions -- File Changes -- M src/modules/tls/tls_rpc.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4262.patch https://github.com/kamailio/kamailio/pull/4262.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4262 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4262(a)github.com>

2 2

git:master:9581e5b3: tls: add WSS to RPC funtions
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9581e5b332bff8e61ed65c6ddd340a472cb1d93c URL: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… Author: Benjamin Tietz <tietz(a)sipgate.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:10:58+02:00 tls: add WSS to RPC funtions - tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> --- Modified: src/modules/tls/tls_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… Patch: https://github.com/kamailio/kamailio/commit/9581e5b332bff8e61ed65c6ddd340a4… --- diff --git a/src/modules/tls/tls_rpc.c b/src/modules/tls/tls_rpc.c index b707a3063f1..ef621407781 100644 --- a/src/modules/tls/tls_rpc.c +++ b/src/modules/tls/tls_rpc.c @@ -118,7 +118,7 @@ static void tls_list(rpc_t *rpc, void *c) TCPCONN_LOCK; for(i = 0; i < TCP_ID_HASH_SIZE; i++) { for(con = tcpconn_id_hash[i]; con; con = con->id_next) { - if(con->rcv.proto != PROTO_TLS) + if(con->rcv.proto != PROTO_TLS && con->rcv.proto != PROTO_WSS) continue; tls_d = con->extra_data; rpc->add(c, "{", &handle); @@ -276,7 +276,7 @@ static void tls_kill(rpc_t *rpc, void *c) TCPCONN_LOCK; for(i = 0; i < TCP_ID_HASH_SIZE; i++) { for(con = tcpconn_id_hash[i]; con; con = con->id_next) { - if(con->rcv.proto != PROTO_TLS) + if(con->rcv.proto != PROTO_TLS && con->rcv.proto != PROTO_WSS) continue; if(con->id == kill_id) { con->state = -2;

1 0

git:master:d7156079: dispatcher: docs for ds_ping_fr_timer modparam
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: d71560794239668a9488ef2aca8330307779a6c8 URL: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T15:00:45+02:00 dispatcher: docs for ds_ping_fr_timer modparam --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… Patch: https://github.com/kamailio/kamailio/commit/d71560794239668a9488ef2aca83303… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 37194e4973e..3a6c26b41b7 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -577,6 +577,28 @@ modparam("dispatcher", "ds_ping_interval", 30) </example> </section> + + <section id="dispatcher.p.ds_ping_fr_timer"> + <title><varname>ds_ping_fr_timer</varname> (int)</title> + <para> + If greater than 0, its value is used to set the "fr_timer" value for + the local transactions created to send out the OPTIONS pings. + </para> + <para> + <emphasis> + Default value is <quote>0</quote> (not set). + </emphasis> + </para> + <example> + <title>Set the <quote>ds_ping_fr_timer</quote> parameter</title> +<programlisting format="linespecific"> +... +modparam("dispatcher", "ds_ping_fr_timer", 10) +... +</programlisting> + </example> + </section> + <section id="dispatcher.p.ds_probing_threshold"> <title><varname>ds_probing_threshold</varname> (int)</title> <para>

1 0

git:master:df0e36fb: dispatcher: new modparam ds_ping_fr_timeout
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: df0e36fbb0dc1139acd6c5d92dc3f986cca73af2 URL: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:55:02+02:00 dispatcher: new modparam ds_ping_fr_timeout - ability to set the transaction fr_timeout value for the OPTIONS pings requests --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… Patch: https://github.com/kamailio/kamailio/commit/df0e36fbb0dc1139acd6c5d92dc3f98… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a90daa2abfa..cf0a75a09dd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -118,6 +118,7 @@ static int *_ds_ping_active = NULL; extern int ds_force_dst; extern str ds_event_callback; extern int ds_ping_latency_stats; +extern int ds_ping_fr_timeout; extern int ds_retain_latency_stats; extern float ds_latency_estimator_alpha; extern int ds_attrs_none; @@ -4175,6 +4176,9 @@ void ds_ping_set(ds_set_t *node) && ds_default_socket.len > 0) { uac_r.ssock = &ds_default_socket; } + if(ds_ping_fr_timeout > 0) { + uac_r.fr_timeout = (unsigned int)ds_ping_fr_timeout; + } /* Overwrite default ping From URI with attribute */ if(node->dlist[j].attrs.ping_from.s != NULL diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 1d6acaaede5..84c65a6019e 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -103,6 +103,7 @@ str ds_ping_method = str_init("OPTIONS"); str ds_ping_from = str_init("sip:dispatcher@localhost"); static int ds_ping_interval = 0; int ds_ping_latency_stats = 0; +int ds_ping_fr_timeout = 0; int ds_retain_latency_stats = 0; int ds_latency_estimator_alpha_i = 900; float ds_latency_estimator_alpha = 0.9f; @@ -301,6 +302,7 @@ static param_export_t params[]={ {"ds_ping_method", PARAM_STR, &ds_ping_method}, {"ds_ping_from", PARAM_STR, &ds_ping_from}, {"ds_ping_interval", PARAM_INT, &ds_ping_interval}, + {"ds_ping_fr_timeout", PARAM_INT, &ds_ping_fr_timeout}, {"ds_ping_latency_stats", PARAM_INT, &ds_ping_latency_stats}, {"ds_retain_latency_stats", PARAM_INT, &ds_retain_latency_stats}, {"ds_latency_estimator_alpha", PARAM_INT, &ds_latency_estimator_alpha_i},

1 0

git:master:98bcd014: uac: fields for $uac_req() to set fr_timeout, fr_inv_timeout
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 98bcd01471744eaaa142c388782a5c91c99a78f7 URL: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:28:12+02:00 uac: fields for $uac_req() to set fr_timeout, fr_inv_timeout --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… Patch: https://github.com/kamailio/kamailio/commit/98bcd01471744eaaa142c388782a5c9… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index f8a77b6a6b4..ea3595ca755 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -82,6 +82,8 @@ typedef struct _uac_send_info char b_evparam[MAX_UACD_SIZE]; str s_evparam; unsigned int cseqno; + unsigned int fr_timeout; + unsigned int fr_inv_timeout; unsigned int evroute; unsigned int evcode; unsigned int evtype; @@ -187,6 +189,10 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, _uac_req.flags); case 18: return pv_get_uintval(msg, param, res, _uac_req.cseqno); + case 19: + return pv_get_uintval(msg, param, res, _uac_req.fr_timeout); + case 20: + return pv_get_uintval(msg, param, res, _uac_req.fr_inv_timeout); default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -484,6 +490,28 @@ int pv_set_uac_req( } _uac_req.cseqno = tval->ri; break; + case 19: + if(tval == NULL) { + _uac_req.fr_timeout = 0; + return 0; + } + if(!(tval->flags & PV_VAL_INT)) { + LM_ERR("Invalid value type\n"); + return -1; + } + _uac_req.fr_timeout = tval->ri; + break; + case 20: + if(tval == NULL) { + _uac_req.fr_inv_timeout = 0; + return 0; + } + if(!(tval->flags & PV_VAL_INT)) { + LM_ERR("Invalid value type\n"); + return -1; + } + _uac_req.fr_inv_timeout = tval->ri; + break; } return 0; } @@ -550,6 +578,16 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) else goto error; break; + case 10: + if(strncmp(in->s, "fr_timeout", 10) == 0) + sp->pvp.pvn.u.isname.name.n = 19; + else + goto error; + case 14: + if(strncmp(in->s, "fr_inv_timeout", 14) == 0) + sp->pvp.pvn.u.isname.name.n = 20; + else + goto error; default: goto error; } @@ -803,6 +841,8 @@ void uac_send_tm_callback(struct cell *t, int type, struct tmcb_params *ps) uac_r.ssock = (tp->s_sock.len <= 0) ? NULL : &tp->s_sock; uac_r.dialog = &tmdlg; uac_r.cb_flags = TMCB_LOCAL_COMPLETED | TMCB_DESTROY; + uac_r.fr_timeout = tp->fr_timeout; + uac_r.fr_inv_timeout = tp->fr_inv_timeout; if(tp->evroute != 0) { /* Callback function */ uac_r.cb = uac_resend_tm_callback; @@ -861,6 +901,9 @@ int uac_req_send(void) uac_r.ssock = &uac_default_socket; } + uac_r.fr_timeout = _uac_req.fr_timeout; + uac_r.fr_inv_timeout = _uac_req.fr_inv_timeout; + if((_uac_req.s_auser.len > 0 && _uac_req.s_apasswd.len > 0) || (_uac_req.evroute > 0)) { tp = uac_send_info_clone(&_uac_req);

1 0

git:master:d0bfcac2: uac: added fr_timeout and fr_inv_timeout to uac_req_t struct
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: d0bfcac231ae67d683ff1c7ace2cebfdca33e0b4 URL: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T14:28:12+02:00 uac: added fr_timeout and fr_inv_timeout to uac_req_t struct - can be used to set the timeouts for the locally generated requests via the intermodule API functions --- Modified: src/modules/tm/uac.c Modified: src/modules/tm/uac.h --- Diff: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… Patch: https://github.com/kamailio/kamailio/commit/d0bfcac231ae67d683ff1c7ace2cebf… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index 26748f4570c..2dfb218724f 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -517,8 +517,12 @@ static inline int t_uac_prepare( * we can't call init_new_t() because we don't have a sip msg * => we'll ignore t_set_fr() or avp timer value and will use directly the * module params fr_inv_timer and fr_timer -- andrei */ - new_cell->fr_timeout = cfg_get(tm, tm_cfg, fr_timeout); - new_cell->fr_inv_timeout = cfg_get(tm, tm_cfg, fr_inv_timeout); + new_cell->fr_timeout = (uac_r->fr_timeout > 0) + ? uac_r->fr_timeout + : cfg_get(tm, tm_cfg, fr_timeout); + new_cell->fr_inv_timeout = (uac_r->fr_inv_timeout > 0) + ? uac_r->fr_inv_timeout + : cfg_get(tm, tm_cfg, fr_inv_timeout); new_cell->end_of_life = get_ticks_raw() + lifetime; /* same as above for retransmission intervals */ new_cell->rt_t1_timeout_ms = cfg_get(tm, tm_cfg, rt_t1_timeout_ms); diff --git a/src/modules/tm/uac.h b/src/modules/tm/uac.h index 00dc32d2a5b..f35cf9f70ac 100644 --- a/src/modules/tm/uac.h +++ b/src/modules/tm/uac.h @@ -55,6 +55,8 @@ typedef struct uac_req void *cbp; str *callid; unsigned int cseqno; + unsigned int fr_timeout; + unsigned int fr_inv_timeout; } uac_req_t; /* macro for setting the values of uac_req_t struct */

1 0

git:master:7de2b9b7: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 7de2b9b7625d9cb856944627a3a5d7c167006dc6 URL: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T12:46:10+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c… Patch: https://github.com/kamailio/kamailio/commit/7de2b9b7625d9cb856944627a3a5d7c…

1 0

git:master:98cbb5cd: rtpengine: hash table dmq replication
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 98cbb5cdf169578c75f60f4f12c2e9e4dadeed3e URL: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e… Author: vlitvinov <litvvitya92(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T12:43:33+02:00 rtpengine: hash table dmq replication --- Added: src/modules/rtpengine/rtpengine_dmq.c Added: src/modules/rtpengine/rtpengine_dmq.h Modified: src/modules/rtpengine/doc/rtpengine_admin.xml Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine.h Modified: src/modules/rtpengine/rtpengine_db.c --- Diff: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e… Patch: https://github.com/kamailio/kamailio/commit/98cbb5cdf169578c75f60f4f12c2e9e…

1 0

git:master:2492b92e: dialog: use defined tockens for is_set field of local cseq structure for keepalives
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 2492b92e49cfcd5f6828007b6a289b3f881dba69 URL: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:15:02+02:00 dialog: use defined tockens for is_set field of local cseq structure for keepalives --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Patch: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 52e492d2074..48494bef428 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -790,10 +790,11 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) * - dialog is ended on timeout (408) or C/L does not exist (481) */ if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; + di->loc_seq.is_set = DLG_SEQ_VALSET; } else { di->loc_seq.value = 0; + di->loc_seq.is_set = DLG_SEQ_VALNEW; } - di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:73c8316b: tm: add defines for dlg cseq is_self field
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 73c8316bf89703156f241886554919339ac270d0 URL: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:08:12+02:00 tm: add defines for dlg cseq is_self field - DLG_SEQ_VALINIT (should be initialized), DLG_SEQ_VALSET (is set, but can be updated for requests within dialog), DLG_SEQ_VALNEW (is set, and ready to be used as new cseq number in generated request) --- Modified: src/modules/tm/dlg.c Modified: src/modules/tm/dlg.h Modified: src/modules/tm/rpc_uac.c Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Patch: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… --- diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c index b99065a94c2..6c97db622af 100644 --- a/src/modules/tm/dlg.c +++ b/src/modules/tm/dlg.c @@ -357,7 +357,7 @@ int new_dlg_uac(str *_cid, str *_ltag, unsigned int _lseq, str *_luri, /* Make a copy of local sequence (usually CSeq) */ res->loc_seq.value = _lseq; /* And mark it as set */ - res->loc_seq.is_set = 1; + res->loc_seq.is_set = DLG_SEQ_VALSET; *_d = res; @@ -979,7 +979,7 @@ static inline int request2dlg(struct sip_msg *_m, dlg_t *_d) if(get_cseq_value(_m, &_d->rem_seq.value) < 0) goto err3; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; if(get_dlg_uri(_m->from, &_d->rem_uri) < 0) goto err3; @@ -1149,7 +1149,7 @@ int dlg_request_uas( /* Neither out of order nor retransmission -> update */ _d->rem_seq.value = cseq; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; /* We will als update remote target URI if the message * is target refresher diff --git a/src/modules/tm/dlg.h b/src/modules/tm/dlg.h index 732ba970bc0..ff37bc4bd9a 100644 --- a/src/modules/tm/dlg.h +++ b/src/modules/tm/dlg.h @@ -52,6 +52,10 @@ #endif /* DIALOG_CALLBACKS */ +#define DLG_SEQ_VALINIT 0 +#define DLG_SEQ_VALSET 1 +#define DLG_SEQ_VALNEW 2 + /* * Dialog sequence */ diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 285f3c7e9eb..3cd99a4d9c6 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -757,7 +757,7 @@ static void rpc_t_uac(rpc_t *rpc, void *c, int reply_wait, int cbflags) dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; @@ -1077,7 +1077,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket, dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index a9a327745ec..26748f4570c 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -451,11 +451,11 @@ static inline int t_uac_prepare( /* if err's returned, the message is incorrect */ goto error3; - if(!uac_r->dialog->loc_seq.is_set) { + if(uac_r->dialog->loc_seq.is_set == DLG_SEQ_VALINIT) { /* this is the first request in the dialog, set cseq to default value now - Miklos */ uac_r->dialog->loc_seq.value = DEFAULT_CSEQ; - uac_r->dialog->loc_seq.is_set = 1; + uac_r->dialog->loc_seq.is_set = DLG_SEQ_VALSET; } /* build cell sets X/AVP lists to new transaction structure @@ -677,7 +677,9 @@ int prepare_req_within(uac_req_t *uac_r, struct retr_buf **dst_req) goto send; if((uac_r->method->len == 6) && (!memcmp("CANCEL", uac_r->method->s, 6))) goto send; - uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + if(uac_r->dialog->loc_seq.is_set != DLG_SEQ_VALNEW) { + uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + } send: ret = t_uac_prepare(uac_r, dst_req, 0);

1 0

[kamailio/kamailio] Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module with high concurrency (Issue #4209)
by Henning Westerholt 06 Jun '25

06 Jun '25

henningw created an issue (kamailio/kamailio#4209) Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module. ### Environment: The systems are using 32 Kamailio worker processes for the relevant network interface, Its also using Prometheus counter increment operations more than 30 times in the cfg during INVITE processing. The Kamailio uses otherwise no database or other IO related services. Kamailio version 5.8.3, but no relevant changes in the xhttp_prom module could be found. ### Quick summary of the findings: Multiple systems showed frequent hangs in their Kamailio servers on a customer setup. It happens usually after a few hours that all Kamailio processes gets blocked, and no more traffic can be processed on the respective system. I have analysed three stack traces of the Kamailio on one of the system that showed the behaviour. Two without problems and one that was created from during a period where the server had problems. ### Details: Here some details of the stack traces from a problematic case. The relevant processes are from PID 494551 to 494582. The majority of all of these processes are blocked in paths related to the Prometheus module (PID 494551 to 494576): #### PID 494551: ``` #1 0x00007fc69ea5f053 in futex_get (lock=0x7fc4a147acd0) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #2 0x00007fc69ea70f99 in prom_counter_inc (s_name=0x7fffe339ffa0, number=1, l1=0x7fffe339ff90, l2=0x0, l3=0x0) at prom_metric.c:1154 p = 0x6b __func__ = "prom_counter_inc" […] #14 0x00000000005ab179 in receive_msg (buf=0x9f47e0 <buf> "INVITE [sip:+1YYYYYYY737@10.XXX.XXX107](sip:+1YYYYYYYYYY737@10.XXX.XX.107) SIP/2.0\r\nRecord-Route: [sip:10.1XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3](sip:10.XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3)\r\nRecord-Route: [sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F](sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F)\r\nRecord-R"..., len=2819, rcv_info=0x7fffe33a28d0) at core/receive.c:518 ``` Most of the worker processes are in the same state as shown above. Some of the processes are also working in other Prometheus related operations: #### PID 494554: ``` #0 prom_metric_timeout_delete (p_m=0x7fc49ea102f0) at prom_metric.c:646 current = 0x7fc4a2810fd0 ts = 1744143945433 __func__ = "prom_metric_timeout_delete" l = 0x7fc4abffc808 #1 0x00007fc69ea676ce in prom_metric_list_timeout_delete () at prom_metric.c:668 p = 0x7fc49ea102f0 ``` ### Problem hypothesis: My hypothesis is that the hang is caused from lock contention around the Prometheus module. The relevant code uses only one lock, and this together with the extensive usage of the increment counters probably causes this issues under high load. The majority of the worker processed are occupied in the Prometheus path and are not working on SIP packets. This will cause of course an increase of the UDP queue and the described problems. In order to test this hypothesis we removed temporarily the Prometheus logic in the kamailio cfg and see if the issue still persists. The issue did not showed up again after two days of testing, when before it was observed after a few hours. ### Possible solutions: The Prometheus module probably needs some improvements to support better high-load and concurrency situations. On common approach is to split the locks, e.g. using a per process lock array and then combining the individual values in a second pass when read from outside. Alternatively the xhttp_prom module should be used only carefully in situations with a high concurrency setup. I have the full backtrace available, if helpful just let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4209 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4209(a)github.com>

2 2

Kamailio Deployment in AWS
by gcampos＠momenta.network 05 Jun '25

05 Jun '25

Hi community, I'm not sure if anyone has ever tried that before, but I'm trying to run Kamailio in AWS with RTPengine. I successfully installed both Kamailio and RTPengine on my EC2 instance and I'm able to make my devices register to it. However, when I make a call from one of my devices, the call is muted. As I analyze my kamailio.cfg file, I see that the "route[NATMANAGE]" is likely the cause of the mute call. I think that none of the conditions below are met, therefore, the flags are not set. Because of that, the last condition is met, thus triggering the "return" and exiting from the route[NATMANAGE] prematurely without even reaching the section where I define the RTPengine modifications. Not only that, but if I remove/comment out the "return", then the RTPengine is triggered, but there call doesn't connect. I wonder why this is happening and if there's any known workaround. # RTP relaying management and signaling updates for NAT traversal route[NATMANAGE] { xlog("L_INFO", "NATMANAGE path was followed\n"); #!ifdef WITH_NAT xlog("L_INFO", "WITH_NAT Triggered\n"); if (is_request()) { xlog("L_INFO", "is_request path was followed\n"); if (has_totag()) { xlog("L_INFO", "has_totag path was followed\n"); if (check_route_param("nat=yes")) { xlog("L_INFO", "nat=yes param detected, setting FLB_NATB\n"); setbflag(FLB_NATB); } } if (nat_uac_test("3")) { xlog("L_INFO", "nat_uac_test(3) matched, setting FLT_NATS + FLB_NATB\n"); setflag(FLT_NATS); setbflag(FLB_NATB); } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) { xlog("L_INFO", "No NAT flags set, skipping NAT handling\n"); return; } #!ifdef WITH_RTPENGINE xlog("L_INFO", "WITH_RTPENGINE Path followed\n"); if (has_body("application/sdp")) { if (is_method("INVITE")) { xlog("L_INFO", "IS_METHOD_INVITE Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } else if (is_reply()) { xlog("L_INFO", "IS_Reply Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; }

3 2

git:5.8:6c71d5e7: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 5.8 Commit: 6c71d5e7364e169373a38d899793c78ae4f93835 URL: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T14:46:57+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) (cherry picked from commit 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Patch: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a22e64cb1e6..02f72d77521 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:6.0:a37a57c2: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: a37a57c2b4db73b4963d3af5e733ea8fe5c5833d URL: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:10:49+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog (cherry picked from commit 43e64af9bade5fedf34e847f662b97ce94c041bc) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Patch: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6349e88c1f8..773ae788e3b 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:43e64af9: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 43e64af9bade5fedf34e847f662b97ce94c041bc URL: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:07:59+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Patch: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6467b32b349..52e492d2074 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:b293f206: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: b293f20620c3396130f6409ddf30b69499bb482f URL: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:15+02:00 dialog: set cseq is_set for keepalive (cherry picked from commit b5d4c20172bdcaf0e63b15b4e23d205125398a42) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Patch: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..6349e88c1f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -784,10 +784,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:21c944e4: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b URL: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:03+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Patch: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:master:b5d4c201: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: b5d4c20172bdcaf0e63b15b4e23d205125398a42 URL: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 dialog: set cseq is_set for keepalive --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Patch: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 9ffd65e9526..6467b32b349 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -789,10 +789,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:730d6872: core: print default path to runtime dir on internals output
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 730d6872054cb6218684d5e48af341c7c2749233 URL: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 core: print default path to runtime dir on internals output --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Patch: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… --- diff --git a/src/main.c b/src/main.c index 95588200ba9..b0ec7fcb0d9 100644 --- a/src/main.c +++ b/src/main.c @@ -288,6 +288,7 @@ void print_internals(void) printf(" Version: %s\n", full_version); printf(" Default config: %s\n", CFG_FILE); printf(" Default paths to modules: %s\n", MODS_DIR); + printf(" Default path to runtime dir: %s\n", RUN_DIR); printf(" Compile flags: %s\n", ver_flags); printf(" MAX_RECV_BUFFER_SIZE=%d\n", MAX_RECV_BUFFER_SIZE); printf(" MAX_SEND_BUFFER_SIZE=%d\n", MAX_SEND_BUFFER_SIZE);

1 0

[kamailio/kamailio] Replace ip address of source (Issue #4272)
by nochnoi82 04 Jun '25

04 Jun '25

nochnoi82 created an issue (kamailio/kamailio#4272) Hello to everyone. I deployed Kamailio on Debian system. Install was successfull. I have the task to use Kamailio as proxy between Avaya PBX and Videoconference System. Outgoing calls only from IPPhone ----- Avaya PBX ---sip----> Kamailio -----sip----> Video System-IVR IVR number is 3000. Avaya Prefix for routing to Kamailio is 1234. When we dial number 12343000 the call goes to Video system with Header "TO" 12343000@ip_of_PBXAvaya and call drops. How to replace ip-address of Avaya to ip-address of Video_System? What to add in kamailio.cfg? ip video_system - *.*.60.3 ip avaya *.*.20.10 My route config ####### Routing Logic ######## /* Main SIP request routing logic * - processing of any incoming SIP request starts with this route * - note: this is the same as route { ... } */ request_route { # per request initial checks route(REQINIT); # NAT detection route(NATDETECT); # CANCEL processing if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } exit; } # handle retransmissions if (!is_method("ACK")) { if(t_precheck_trans()) { t_check_trans(); exit; } t_check_trans(); } # handle requests within SIP dialogs route(WITHINDLG); ### only initial requests (no To tag) # authentication route(AUTH); # record routing for dialog forming requests (in case they are routed) # - remove preloaded route headers remove_hf("Route"); if (is_method("INVITE|SUBSCRIBE")) { record_route(); } # account only INVITEs if (is_method("INVITE")) { setflag(FLT_ACC); # do accounting } if ($rU==$null) { sl_send_reply("484", "Address Incomplete"); exit; } $du = "sip:*.*.60.3:5060"; route(RELAY); exit; } # Wrapper for relaying requests route[RELAY] { # enable additional event routes for forwarded requests # - serial forking, RTP relaying handling, a.s.o. if (is_method("INVITE|BYE|SUBSCRIBE|UPDATE")) { if(!t_is_set("branch_route")) t_on_branch("MANAGE_BRANCH"); } if (is_method("INVITE|SUBSCRIBE|UPDATE")) { if(!t_is_set("onreply_route")) t_on_reply("MANAGE_REPLY"); } if (is_method("INVITE")) { if(!t_is_set("failure_route")) t_on_failure("MANAGE_FAILURE"); } if (!t_relay()) { sl_reply_error(); } exit; } # Per SIP request initial checks route[REQINIT] { # no connect for sending replies set_reply_no_connect(); # enforce symmetric signaling # - send back replies to the source address of request force_rport(); #!ifdef WITH_ANTIFLOOD # flood detection from same IP and traffic ban for a while # be sure you exclude checking trusted peers, such as pstn gateways # - local host excluded (e.g., loop to self) if(src_ip!=myself) { if($sht(ipban=>$si)!=$null) { # ip is already blocked xdbg("request from blocked IP - $rm from $fu (IP:$si:$sp)\n"); exit; } if (!pike_check_req()) { xlog("L_ALERT","ALERT: pike blocking $rm from $fu (IP:$si:$sp)\n"); $sht(ipban=>$si) = 1; exit; } } #!endif if($ua =~ "friendly|scanner|sipcli|sipvicious|VaxSIPUserAgent|pplsip") { # silent drop for scanners - uncomment next line if want to reply # sl_send_reply("200", "OK"); exit; } if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } if(is_method("OPTIONS") && uri==myself && $rU==$null) { sl_send_reply("200","Keepalive"); exit; } if(!sanity_check("17895", "7")) { xlog("Malformed SIP request from $si:$sp\n"); exit; } } # Handle requests within SIP dialogs route[WITHINDLG] { if (!has_totag()) return; # sequential request withing a dialog should # take the path determined by record-routing if (loose_route()) { route(DLGURI); if (is_method("BYE")) { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } else if ( is_method("ACK") ) { # ACK is forwarded statelessly route(NATMANAGE); } else if ( is_method("NOTIFY") ) { # Add Record-Route for in-dialog NOTIFY as per RFC 6665. record_route(); } route(RELAY); exit; } if (is_method("SUBSCRIBE") && uri == myself) { # in-dialog subscribe requests route(PRESENCE); exit; } if ( is_method("ACK") ) { if ( t_check_trans() ) { # no loose-route, but stateful ACK; # must be an ACK after a 487 # or e.g. 404 from upstream server route(RELAY); exit; } else { # ACK without matching transaction ... ignore and discard exit; } } sl_send_reply("404","Not here"); exit; } # Handle SIP registrations route[REGISTRAR] { if (!is_method("REGISTER")) return; if(isflagset(FLT_NATS)) { setbflag(FLB_NATB); #!ifdef WITH_NATSIPPING # do SIP NAT pinging setbflag(FLB_NATSIPPING); #!endif } if (!save("location")) { sl_reply_error(); } exit; } # User location service route[LOCATION] { #!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") { if(sd_lookup("speed_dial")) { route(SIPOUT); } } #!endif #!ifdef WITH_ALIASDB # search in DB-based aliases if(alias_db_lookup("dbaliases")) { route(SIPOUT); } #!endif $avp(oexten) = $rU; if (!lookup("location")) { $var(rc) = $rc; route(TOVOICEMAIL); t_newtran(); switch ($var(rc)) { case -1: case -3: send_reply("404", "Not Found"); exit; case -2: send_reply("405", "Method Not Allowed"); exit; } } # when routing via usrloc, log the missed calls also if (is_method("INVITE")) { setflag(FLT_ACCMISSED); } route(RELAY); exit; } # Presence server processing route[PRESENCE] { if(!is_method("PUBLISH|SUBSCRIBE")) return; if(is_method("SUBSCRIBE") && $hdr(Event)=="message-summary") { route(TOVOICEMAIL); # returns here if no voicemail server is configured sl_send_reply("404", "No voicemail service"); exit; } #!ifdef WITH_PRESENCE #!ifdef WITH_MSGREBUILD # apply changes in case the request headers or body were modified msg_apply_changes(); #!endif if (!t_newtran()) { sl_reply_error(); exit; } if(is_method("PUBLISH")) { handle_publish(); t_release(); } else if(is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } exit; #!endif # if presence enabled, this part will not be executed if (is_method("PUBLISH") || $rU==$null) { sl_send_reply("404", "Not here"); exit; } return; } # IP authorization and user authentication route[AUTH] { #!ifdef WITH_AUTH #!ifdef WITH_IPAUTH if((!is_method("REGISTER")) && allow_source_address()) { # source IP allowed return; } #!endif if (is_method("REGISTER") || from_uri==myself) { # authenticate requests if (!auth_check("$fd", "subscriber", "1")) { auth_challenge("$fd", "0"); exit; } # user authenticated - remove auth header if(!is_method("REGISTER|PUBLISH")) consume_credentials(); } # if caller is not local subscriber, then check if it calls # a local destination, otherwise deny, not an open relay here if (from_uri!=myself && uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!else # authentication not enabled - do not relay at all to foreign networks if(uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!endif return; } # Caller NAT detection route[NATDETECT] { #!ifdef WITH_NAT if (nat_uac_test("19")) { if (is_method("REGISTER")) { fix_nated_register(); } else { if(is_first_hop()) { set_contact_alias(); } } setflag(FLT_NATS); } #!endif return; } # RTPProxy control and signaling updates for NAT traversal route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { if(has_totag()) { if(check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) return; #!ifdef WITH_RTPENGINE if(nat_uac_test("8")) { rtpengine_manage("SIP-source-address replace-origin replace-session-connection"); } else { rtpengine_manage("replace-origin replace-session-connection"); } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; } # URI update for dialog requests route[DLGURI] { #!ifdef WITH_NAT if(!isdsturiset()) { handle_ruri_alias(); } #!endif return; } # Routing to foreign domains route[SIPOUT] { if (uri==myself) return; append_hf("P-Hint: outbound\r\n"); route(RELAY); exit; } # PSTN GW routing route[PSTN] { #!ifdef WITH_PSTN # check if PSTN GW IP is defined if (strempty($sel(cfg_get.pstn.gw_ip))) { xlog("SCRIPT: PSTN routing enabled but pstn.gw_ip not defined\n"); return; } # route to PSTN dialed numbers starting with '+' or '00' # (international format) # - update the condition to match your dialing rules for PSTN routing if(!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) return; # only local users allowed to call if(from_uri!=myself) { sl_send_reply("403", "Not Allowed"); exit; } # normalize target number for pstn gateway # - convert leading 00 to + if (starts_with("$rU", "00")) { strip(2); prefix("+"); } if (strempty($sel(cfg_get.pstn.gw_port))) { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip); } else { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip) + ":" + $sel(cfg_get.pstn.gw_port); } route(RELAY); exit; #!endif return; } # JSONRPC over HTTP(S) routing #!ifdef WITH_JSONRPC event_route[xhttp:request] { set_reply_close(); set_reply_no_connect(); if(src_ip!=127.0.0.1) { xhttp_reply("403", "Forbidden", "text/html", "<html><body>Not allowed from $si</body></html>"); exit; } if ($hu =~ "^/RPC") { jsonrpc_dispatch(); exit; } xhttp_reply("200", "OK", "text/html", "<html><body>Wrong URL $hu</body></html>"); exit; } #!endif # Routing to voicemail server route[TOVOICEMAIL] { #!ifdef WITH_VOICEMAIL if(!is_method("INVITE|SUBSCRIBE")) return; # check if VoiceMail server IP is defined if (strempty($sel(cfg_get.voicemail.srv_ip))) { xlog("SCRIPT: VoiceMail routing enabled but IP not defined\n"); return; } if(is_method("INVITE")) { if($avp(oexten)==$null) return; $ru = "sip:" + $avp(oexten) + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } else { if($rU==$null) return; $ru = "sip:" + $rU + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } route(RELAY); exit; #!endif return; } # Manage outgoing branches branch_route[MANAGE_BRANCH] { xdbg("new branch [$T_branch_idx] to $ru\n"); route(NATMANAGE); return; } # Manage incoming replies reply_route { if(!sanity_check("17604", "6")) { xlog("Malformed SIP response from $si:$sp\n"); drop; } return; } # Manage incoming replies in transaction context onreply_route[MANAGE_REPLY] { xdbg("incoming reply\n"); if(status=~"[12][0-9][0-9]") { route(NATMANAGE); } return; } # Manage failure routing cases failure_route[MANAGE_FAILURE] { route(NATMANAGE); if (t_is_canceled()) exit; #!ifdef WITH_BLOCK3XX # block call redirect based on 3xx replies. if (t_check_status("3[0-9][0-9]")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_BLOCK401407 # block call redirect based on 401, 407 replies. if (t_check_status("401|407")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_VOICEMAIL # serial forking # - route to voicemail on busy or no answer (timeout) if (t_check_status("486|408")) { $du = $null; route(TOVOICEMAIL); exit; } #!endif return; -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4272 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4272(a)github.com>

2 2

git:master:0ab44e99: modules: readme files regenerated - userblocklist ... [skip ci]
by Kamailio Dev 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0ab44e999c81a25dc826f23e724cf699ce894beb URL: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-04T08:01:09+02:00 modules: readme files regenerated - userblocklist ... [skip ci] --- Modified: src/modules/userblocklist/README --- Diff: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Patch: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… --- diff --git a/src/modules/userblocklist/README b/src/modules/userblocklist/README index 9aabcb73d19..4cff231c495 100644 --- a/src/modules/userblocklist/README +++ b/src/modules/userblocklist/README @@ -154,9 +154,9 @@ Chapter 1. Admin Guide blocklisted or not. An additional functionality that this module provides is the ability to - handle global blocklists. This lists are loaded on startup into memory, - thus providing a better performance than the userblocklist case. These - global blocklists are useful to allow only calls to certain + handle global blocklists. These lists are loaded on startup into + memory, thus providing a better performance than the userblocklist + case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers. They could also be used to prevent the blocklisting of important numbers, as allowlisting is supported too. This is useful for example

1 0

git:master:81357b54: userblocklist: docs - small typo
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 81357b548b6e0cdf464361c2b1742d797f0d7e95 URL: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 userblocklist: docs - small typo --- Modified: src/modules/userblocklist/doc/userblocklist_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Patch: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… --- diff --git a/src/modules/userblocklist/doc/userblocklist_admin.xml b/src/modules/userblocklist/doc/userblocklist_admin.xml index db8efd86896..0a64d648ea1 100644 --- a/src/modules/userblocklist/doc/userblocklist_admin.xml +++ b/src/modules/userblocklist/doc/userblocklist_admin.xml @@ -20,7 +20,7 @@ </para> <para> An additional functionality that this module provides is the ability - to handle global blocklists. This lists are loaded on startup into + to handle global blocklists. These lists are loaded on startup into memory, thus providing a better performance than the userblocklist case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers.

1 0

git:master:0195e860: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0195e86084ffbe5333310fc4206f4a6d01662a85 URL: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 siptrace: reset x/avp lists after event route --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Patch: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index cdac1a32ccf..e199d1cefc9 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -40,6 +40,8 @@ #include "../../core/mod_fix.h" #include "../../core/fmsg.h" #include "../../core/events.h" +#include "../../core/srapi.h" +#include "../../core/receive.h" #include "../../core/kemi.h" #include "sipdump_write.h" @@ -286,14 +288,14 @@ static sipdump_data_t *sipdump_event_data = NULL; */ int sipdump_event_route(sipdump_data_t *sdi) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("sipdump:msg"); sip_msg_t *fmsg = NULL; + ksr_msg_env_t menv = {0}; - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); fmsg = faked_msg_next(); @@ -312,7 +314,8 @@ int sipdump_event_route(sipdump_data_t *sdi) } } sipdump_event_data = NULL; - set_route_type(backup_rt); + ksr_msg_env_reset(); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

[kamailio/kamailio] Cannot connect using MySQL option group name in DBURL (Issue #4271)
by dynax60 03 Jun '25

03 Jun '25

dynax60 created an issue (kamailio/kamailio#4271) Hi all! ```bash [root@kamailio kamailio]# cat /etc/rocky-release Rocky Linux release 9.5 (Blue Onyx) [root@kamailio kamailio]# sestatus SELinux status: disabled [root@kamailio kamailio]# kamailio -v version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 11.5.0 ``` I am trying to use the mysql option group name `kamailio` to connect to MySQL: ``` #!ifdef WITH_MYSQL #!trydef DBURL "mysql://[kamailio]/kamailio" #!endif ``` My /etc/my.cnf file: ``` # # This group is read both both by the client and the server # use it for options that affect everything # [client-server] # # include all files from the config directory # !includedir /etc/my.cnf.d/ ``` /etc/my.cnf.d/kamailio.cnf: ``` [kamailio] socket=/var/lib/mysql/mysql.sock user = kamailio password = ... default-character-set = utf8 ``` Let's check the group name and permissions (for test purposes): ```bash [root@kamailio kamailio]# usermod -s /bin/sh kamailio [root@kamailio kamailio]# su - kamailio -c 'my_print_defaults -c /etc/my.cnf kamailio' --socket=/var/lib/mysql/mysql.sock --user=kamailio --password=... --default-character-set=utf8 ``` The cuts from log file: ``` May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): auth_db May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_auth_s> in module auth [/usr/lib64/kamailio/modules/auth.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): presence May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:301]: mod_init(): db_url=mysql://[kamailio]/kamailio (len=27 addr=0x7f6002ba6f00) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/utils/sruid.c:127]: sruid_init(): root for sruid is [pres-683a04b4-1c59-] (0 / 19) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:345]: mod_init(): server_address parameter not set in configuration file May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_sl> in module sl [/usr/lib64/kamailio/modules/sl.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <load_tm> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_newtran> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_tcp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_udp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_forward_nonack> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_release> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:322]: db_do_init2(): connection 0x7f6002c25500 not found in pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: db_mysql [km_my_con.c:121]: db_mysql_new_connection(): opening connection: mysql://xxxx:xxxx@/kamailio May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: NO) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: presence [presence.c:417]: mod_init(): Connection to database failed May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [core/sr_module.c:1040]: init_mod(): Error while initializing module presence (/usr/lib64/kamailio/modules/presence.so) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:875]: destroy_modules(): starting modules destroy phase ``` Strange things happens if I place [kamailio] configuration into /etc/my.cnf - everything works like a charm! What could be wrong? How to check by other means? The problem is exactly that kamailio can't read the configuration in the external file /etc/my.cnf.d/kamailio.cnf -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4271 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4271(a)github.com>

3 4

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 01 Jun '25

01 Jun '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

4 6

[kamailio/kamailio] Possibly adjusting the SDP parser to be more lenient towards scenarios where a stream is being removed/rejected and connection-information "c=" is only available per media (no session-wide "c=") and the removed/rejected stream omits all fields (Issue #3982)
by thomas414 31 May '25

31 May '25

### Description I encountered an issue with a specific device that is receiving a T.38 fax. The call gets established towards the device normally with inband media, then the device requests T.38 media and tries to remove the audio media via sending port 0 in the ReInvite SDP. Also it sends connection-information only on the media level and there is no "c=" on the session level. Reading through the related RFCs and the kamailio code and discussing this on the mailing list, we came to the conclusion that kamailio is doing everything correct as per RFC. Though we were wondering if it would be possible to adjust the parser to be not as strict as it is right now, and allow a missing "c=" line on the media-level if the stream is removed/rejected via port 0, since i see no sense in requiring connection information. Of course we are also in contact with the vendor to hopefully adjust on their side. Here are the related RFCs: 1. RFC8866 5.7 `A session description MUST contain either at least one "c=" line in each media description or a single "c=" line at the session level. It MAY contain a single session-level "c=" line and additional media-level "c=" line(s) per-media-description, in which case the media-level values override the session-level settings for the respective media.` 2. RFC3264 8.2 `Existing media streams are removed by creating a new SDP with the port number for that stream set to zero. The stream description MAY omit all attributes present previously, and MAY list just a single media format.` At first i was especially confused by the RFC3264 8.2 part, since it seemed correct what the device is sending, but if you read carefully and keep the wording for SDP in mind only attributes ("a=") MAY be omitted. So a "c=" line should still be in the SDP for the removed media if it's not included on the session-level. Or do you see this differently? ### Expected behavior Kamailio allows and parses the SDP when there is no session-wide "c=", a media stream is being removed via port zero and there is no "c=" for this media stream and only the remaining media streams include a "c=" line. #### Actual observed behavior Kamailio throws an error when trying to parse the SDP. #### Log Messages ``` <core> [core/parser/sdp/sdp.c:523]: parse_sdp_session(): can't find media IP in the message ``` #### SIP Traffic ``` v=0 o=xmserver 1726638425 1726638427 IN IP4 169.254.1.1 s=xmserver t=0 0 m=audio 0 RTP/AVP 8 m=image 56002 udptl t38 c=IN IP4 169.254.1.1 a=sendrecv a=T38FaxVersion:0 a=T38MaxBitRate:14400 a=T38FaxFillBitRemoval:0 a=T38FaxTranscodingMMR:0 a=T38FaxTranscodingJBIG:0 a=T38FaxRateManagement:transferredTCF a=T38FaxMaxBuffer:200 a=T38FaxMaxDatagram:72 a=T38FaxUdpEC:t38UDPRedundancy ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Debian 12 Linux hostname 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3982 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3982(a)github.com>

3 5

[kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)
by schoberw 31 May '25

31 May '25

### Description In some situations the other side UA must reply with an inactive media stream. E.g. if video was added but not supported by the other side. The UAS then must answer with an m=video 0 RTP/.. line. It seams that the video section must contain a c= line with an IP address for rtpengine to function. If there is no c line (no IP address) the SDP body cannot be parsed and thus no RTP proxy is invoked. ### Troubleshooting Not easy to reproduce since the answer must bei "wrong". Is it correct to reply an SDP body (media = video) like this? ``` m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 ``` Maybe not (but Audiocodes SBC lates LTS version does it) - so we are dependent on other side now that this service works. #### Reproduction reInvite with Video to a UA that has no video Support (e.g. Bria -> Snom). Drop the c line in the video part with some textops in 200 OK (just to reproduce of course). A -> B, connect the call A -> + video, B has no video support A presses hold #### Log Messages Incoming 200 OK after doing hold with an inactive video: ``` v=0 o=root 436040161 309284577 IN IP4 1.2.3.5 s=call t=0 0 m=audio 14200 RTP/AVPF 9 8 126 c=IN IP4 1.2.3.5 a=ptime:20 a=recvonly a=mid:0 a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: ERROR: <core> [core/parser/sdp/sdp.c:490]: parse_sdp_session(): can't find media IP in the message Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: INFO: <script>: >>> Sending Reply: 200 OK (1.2.3.4:443 -> 100.108.48.38:65251) ``` Compare to working SDP parsing: ``` a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVP 96 c=IN IP4 1.2.3.5 a=inactive a=mid:1 Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ONREPLY_ROUTE[FORWARD] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ROUTE[RTPP_REPLY] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Remove inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Answer to WebRTC client: 200 - qijpuibkv6ufhnd282ks Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: >>> Sending Reply: 200 OK (91.237.65.14:443 -> 80.108.48.38:65388) ``` ### Possible Solutions Tried to fix in script: ``` if(sdp_with_media("video")) xlog("L_INFO", "> $rs with video"); if(sdp_with_active_media("video")) xlog("L_INFO", "> $rs with active video"); if(!sdp_with_active_media("video")) xlog("L_INFO", "> $rs with inactive video"); if(sdp_with_media("video") && !sdp_with_active_media("video")) { # try fix for RMT#60189 xlog("L_INFO", "> Remove inactive video"); sdp_remove_media("video"); msg_apply_changes(); # needed? } ``` But since sdpops cannot parse it cannot remove the buggy media, too. See the log: non of the xlog is logging. If there is inactive media the c line is not mandatory. The parser should accept this by adding a default IP of 0.0.0.0, if needed Doing tricks with textops is not a easy nor performant solution to accept this wrong SDP from other parties. ### Additional Information ``` version: kamailio 5.6.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: Debian Bullseye -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3406 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3406(a)github.com>

3 5

[kamailio/kamailio] dispatcher: weight documentation and workaround for limitations (PR #4158)
by Christian Berger 31 May '25

31 May '25

- describe limitation of weight parameter - describe a potential workaround against those limitations  #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We had problems understanding the weight parameter of the dispatcher module and wrote a little workaround against the problems we have found. This workaround in the configuration file improves behavior for setups with many dispatcher targets at the cost of more CPU load. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4158 -- Commit Summary -- * dispatcher: weight documentation and workaround for limitations -- File Changes -- M src/modules/dispatcher/doc/dispatcher_admin.xml (28) A src/modules/dispatcher/doc/weights.cfg (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4158.patch https://github.com/kamailio/kamailio/pull/4158.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4158 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4158(a)github.com>

4 4

[kamailio/kamailio] kafka_send in event_route not work (Issue #4198)
by wangduanduan 31 May '25

31 May '25

wangduanduan created an issue (kamailio/kamailio#4198)  ### Description kafka_send in event_route like tcp:timeout, tcp:closed not work ``` event_route[tcp:closed] { if (kafka_send("my_topic", "tcp:closed")) { xlog("L_INFO", "send success tcp:closed"); } } event_route[tcp:timeout] { if (kafka_send("my_topic", "tcp:timeout")) { xlog("L_INFO", "send success tcp:timeout"); } } ``` in log, its show "send success tcp:closed", "send success tcp:timeout", but in kafka web ui, in the **my_topic**, can't find the "tcp:closed" or " tcp:timeout" message. --- but if the kafka_send in onreply_route, message will be send ok, in the kafka web ui, the "some_route" can be find. ``` onreplay_route[some_route]{ if (kafka_send("my_topic", "some_routet")) { xlog("L_INFO", "send success some_routet"); } } ```  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic i use tcpdump to capture the traffic between kamailio and kafka. - when use kafka_send in event_route, no packages captured.  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**: centos7  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4198(a)github.com>

5 10

git:master:218de360: modules: readme files regenerated - jansson ... [skip ci]
by Kamailio Dev 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 218de360f439c3ef203f4403b5d06cd7ecca19df URL: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-30T12:31:11+02:00 modules: readme files regenerated - jansson ... [skip ci] --- Modified: src/modules/jansson/README --- Diff: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Patch: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… --- diff --git a/src/modules/jansson/README b/src/modules/jansson/README index 550c9d62a8d..47a091b8ca6 100644 --- a/src/modules/jansson/README +++ b/src/modules/jansson/README @@ -134,7 +134,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... 3.2. jansson_pv_get(key/path, srcvar, dst)

1 0

git:master:5ee87b79: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 5ee87b7905d931931dece44ec591d8e6bcf567e2 URL: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:23:19+02:00 siptrace: reset x/avp lists after event route - GH #4258 --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Patch: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 6e6ffcaf237..3c27e20fe87 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -41,6 +41,7 @@ #include "../../core/ip_addr.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" +#include "../../core/receive.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" #include "../../lib/srdb1/db.h" @@ -54,6 +55,7 @@ #include "../../core/str.h" #include "../../core/onsend.h" #include "../../core/events.h" +#include "../../core/srapi.h" #include "../../core/kemi.h" #include "siptrace_data.h" @@ -2220,12 +2222,12 @@ static siptrace_data_t *siptrace_event_data = NULL; static int siptrace_exec_evcb_msg(siptrace_data_t *sto) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("siptrace:msg"); sip_msg_t msg; + ksr_msg_env_t menv = {0}; if(_siptrace_evrt_msg_idx < 0 && _siptrace_evcb_msg.len <= 0) { return 0; @@ -2248,7 +2250,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) return -1; } - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); @@ -2267,8 +2269,9 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) } siptrace_event_data = NULL; + ksr_msg_env_reset(); free_sip_msg(&msg); - set_route_type(backup_rt); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

git:master:465fda0f: core: implement pop of lists from msg env
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 465fda0f790e44e5484b2ef41363fb23fece3f41 URL: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:07:46+02:00 core: implement pop of lists from msg env --- Modified: src/core/srapi.c --- Diff: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Patch: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 8d7bd1ca620..a16acf97d21 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -79,7 +79,6 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) { menv->route_type = get_route_type(); - /* make available the avp list from transaction */ menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); @@ -100,5 +99,16 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) void ksr_msg_env_pop(ksr_msg_env_t *menv) { set_route_type(menv->route_type); + + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, menv->avps_uri_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, menv->avps_user_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, menv->avps_user_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, menv->avps_domain_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, menv->avps_domain_to); + xavp_set_list(menv->xavps); + xavu_set_list(menv->xavus); + xavi_set_list(menv->xavis); + return; }

1 0

git:master:7fed8f52: jansson: docs - added missing semicolon in the example
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 7fed8f52391aaef43d5cb672f4821d50d4855830 URL: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T11:53:06+02:00 jansson: docs - added missing semicolon in the example --- Modified: src/modules/jansson/doc/jansson_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Patch: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… --- diff --git a/src/modules/jansson/doc/jansson_admin.xml b/src/modules/jansson/doc/jansson_admin.xml index daa5e9ea51e..71ffa92bff9 100644 --- a/src/modules/jansson/doc/jansson_admin.xml +++ b/src/modules/jansson/doc/jansson_admin.xml @@ -94,7 +94,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... </programlisting> </example> @@ -313,4 +313,3 @@ xlog("foo.foz is $var(foofoz)"); </section> </section> </chapter> -

1 0

[kamailio/kamailio] Sca in cluster/load balancer (Issue #4267)
by Maurotb 29 May '25

29 May '25

Maurotb created an issue (kamailio/kamailio#4267) We have two kamailio in load balancing, mysql is in cluster mode. We need to use sca, but kamailio db cluster is not supported (i need to specify connection string to sql not cluster name) and if phone1 is registered on kamailio1 and phone2 on kamailio2, sca not work. It is possibile to implement cluster? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4267 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4267(a)github.com>

2 2

[kamailio/kamailio] Disable IPSec in P-CSCF (Issue #4269)
by navjyoty 29 May '25

29 May '25

navjyoty created an issue (kamailio/kamailio#4269) I'm working on a custom IMS deployment using the pcscf module in Kamailio. For our setup, we do not want Kamailio to handle IPsec or generate Security-Server headers in 401/407 responses. Is there a clean way to disable IPsec functionality entirely in the pcscf module? Specifically, I would like to: Prevent the module from requiring IPsec setup during UE registration Avoid any modification of SIP messages related to IPsec (e.g., removing Security-Verify, Security-Client, or Security-Server headers) Use only TLS or UDP without IPsec involvement Has anyone achieved this via configuration or by disabling specific features? Any guidance or examples would be greatly appreciated. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4269 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4269(a)github.com>

2 2

git:master:54a330bb: core: helper functions to get/set msg env lists
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: 54a330bb707fb6b4943ba26356891696681a02e7 URL: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:47+02:00 core: helper functions to get/set msg env lists --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Patch: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 99fbf49d8a9..8d7bd1ca620 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -19,7 +19,9 @@ #include <stdio.h> #include <stdlib.h> + #include "dprint.h" +#include "route.h" #include "srapi.h" @@ -69,3 +71,34 @@ sr_cfgenv_t *sr_cfgenv_get(void) { return &_sr_cfgenv; } + +/** + * + */ +void ksr_msg_env_push(ksr_msg_env_t *menv) +{ + menv->route_type = get_route_type(); + + /* make available the avp list from transaction */ + menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); + menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); + menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); + menv->avps_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, NULL); + menv->avps_domain_from = + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, NULL); + menv->avps_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, NULL); + menv->xavps = xavp_set_list(NULL); + menv->xavus = xavu_set_list(NULL); + menv->xavis = xavi_set_list(NULL); + + return; +} + +/** + * + */ +void ksr_msg_env_pop(ksr_msg_env_t *menv) +{ + set_route_type(menv->route_type); + return; +} diff --git a/src/core/srapi.h b/src/core/srapi.h index 1f5f8e7d36b..b573493a62b 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -20,6 +20,8 @@ #define __SRAPI_H__ #include "str.h" +#include "usr_avp.h" +#include "xavp.h" #include "parser/msg_parser.h" typedef void (*sr_generate_callid_f)(str *); @@ -39,4 +41,21 @@ typedef struct sr_cfgenv void sr_cfgenv_init(void); sr_cfgenv_t *sr_cfgenv_get(void); +typedef struct ksr_msg_env +{ + int route_type; + avp_list_t *avps_user_from; + avp_list_t *avps_user_to; + avp_list_t *avps_domain_from; + avp_list_t *avps_domain_to; + avp_list_t *avps_uri_from; + avp_list_t *avps_uri_to; + sr_xavp_t **xavps; + sr_xavp_t **xavus; + sr_xavp_t **xavis; +} ksr_msg_env_t; + +void ksr_msg_env_push(ksr_msg_env_t *menv); +void ksr_msg_env_pop(ksr_msg_env_t *menv); + #endif

1 0

git:master:f0291728: ims_ipsec_pcscf: jump to error for clean up
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: f0291728b7fb623faf1d4de0f3152e782a6782ae URL: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:46+02:00 ims_ipsec_pcscf: jump to error for clean up --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Patch: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index e15de4e2de8..4672a45906a 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -272,7 +272,7 @@ static int fill_contact( if((srcip = pkg_malloc(50)) == NULL) { LM_ERR("Error allocating memory for source IP address\n"); - return -1; + goto error; } memcpy(srcip, alias_s.s, ci->received_host.len);

1 0

[kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)
by sergey-safarov 28 May '25

28 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description As a local IP address for TCP sending operation the Kamailio service is taking the same network_interface/IP_address, which is used by the service for TCP listening. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3925 -- Commit Summary -- * core: local TCP socket is bound on listening address -- File Changes -- M src/core/tcp_main.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3925.patch https://github.com/kamailio/kamailio/pull/3925.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3925 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3925(a)github.com>

5 16

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

Same -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142745(a)github.com>

1 0

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

@sergey-safarov I look a bit on this commit and some comments i can give are: 1) The config files of these modules are already installed by default when they are included to be built. No need for extra step. 2) These *-cfg components are no longer available after the refactoring to use build groups instead. Can you maybe confirm that? I expect that it silently does nothing instead of complaining... -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142732(a)github.com>

1 0

git:master:6ccf41b3: modules: readme files regenerated - pdb ... [skip ci]
by Kamailio Dev 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 6ccf41b3e2c27b9f790aa9cc881eeca1054cb20c URL: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-27T16:01:09+02:00 modules: readme files regenerated - pdb ... [skip ci] --- Modified: src/modules/pdb/README --- Diff: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Patch: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… --- diff --git a/src/modules/pdb/README b/src/modules/pdb/README index 52ebab2e8ae..0c2ec72e122 100644 --- a/src/modules/pdb/README +++ b/src/modules/pdb/README @@ -12,6 +12,11 @@ Pawel Kuzak 1&1 Internet AG <pawel.kuzak(a)1und1.de> +Muhammad Shahzad Shafi + + 1&1 Internet AG + <muhammad.shafi(a)1und1.de> + Copyright © 2009 1&1 Internet AG __________________________________________________________________ @@ -38,8 +43,9 @@ Pawel Kuzak 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate List of Examples @@ -48,8 +54,9 @@ Pawel Kuzak 1.3. Set ll_info parameter 1.4. pdb_query usage 1.5. pdb.status usage - 1.6. pdb.activate usage - 1.7. pdb.deactivate usage + 1.6. pdb.timeout usage + 1.7. pdb.activate usage + 1.8. pdb.deactivate usage Chapter 1. Admin Guide @@ -74,8 +81,9 @@ Chapter 1. Admin Guide 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 1. Overview @@ -178,8 +186,9 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 5.1. pdb.status @@ -191,22 +200,35 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); kamcmd pdb.status ... -5.2. pdb.activate +5.2. pdb.timeout + + Prints the current PDB query timeout value. This can also be used to + set the PDB query timeout. + + Example 1.6. pdb.timeout usage +... +# get the PDB query timeout +kamcmd pdb.timeout +# set the PDB query timeout to 10ms +kamcmd pdb.timeout 10 +... + +5.3. pdb.activate Activates the module. This is the default after loading the module. - Example 1.6. pdb.activate usage + Example 1.7. pdb.activate usage ... kamcmd pdb.activate ... -5.3. pdb.deactivate +5.4. pdb.deactivate Deactivates the module. No more queries are performed until it is activated again. As long as the module is deactivated, the pdb_query function will return -1. - Example 1.7. pdb.deactivate usage + Example 1.8. pdb.deactivate usage ... kamcmd pdb.deactivate ...

1 0

[kamailio/kamailio] PDB: new RPC command to get/set the PDB query timeout value (PR #4261)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4261 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * Merge branch 'kamailio:master' into master -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4261.patch https://github.com/kamailio/kamailio/pull/4261.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4261 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4261(a)github.com>

2 5

git:master:db903613: pdb: add documentation for new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: db903613a10ae93ce0b8ff93835486953df4437e URL: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add documentation for new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/doc/pdb.xml Modified: src/modules/pdb/doc/pdb_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Patch: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… --- diff --git a/src/modules/pdb/doc/pdb.xml b/src/modules/pdb/doc/pdb.xml index 835353ca359..686cf6ab0be 100644 --- a/src/modules/pdb/doc/pdb.xml +++ b/src/modules/pdb/doc/pdb.xml @@ -24,6 +24,12 @@ <affiliation><orgname>1&1 Internet AG</orgname></affiliation> <email>pawel.kuzak(a)1und1.de</email> </editor> + <editor> + <firstname>Muhammad Shahzad</firstname> + <surname>Shafi</surname> + <affiliation><orgname>1&1 Internet AG</orgname></affiliation> + <email>muhammad.shafi(a)1und1.de</email> + </editor> </authorgroup> <copyright> <year>2009</year> diff --git a/src/modules/pdb/doc/pdb_admin.xml b/src/modules/pdb/doc/pdb_admin.xml index 19b00bd99d8..50fb4190dae 100644 --- a/src/modules/pdb/doc/pdb_admin.xml +++ b/src/modules/pdb/doc/pdb_admin.xml @@ -163,6 +163,24 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); <programlisting format="linespecific"> ... &kamcmd; pdb.status +... + </programlisting> + </example> + </section> + <section id="pdb.r.timeout"> + <title>pdb.timeout</title> + <para> + Prints the current PDB query timeout value. + This can also be used to set the PDB query timeout. + </para> + <example> + <title><function>pdb.timeout</function> usage</title> + <programlisting format="linespecific"> +... +# get the PDB query timeout +&kamcmd; pdb.timeout +# set the PDB query timeout to 10ms +&kamcmd; pdb.timeout 10 ... </programlisting> </example>

1 0

git:master:e2ab3174: pdb: add new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: e2ab3174fb8f013e0a536c0cd5b049f3e2015eec URL: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Patch: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… --- diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 492fa99ec09..77806e49df6 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -27,6 +27,8 @@ #include "../../core/sr_module.h" +#include "../../core/cfg/cfg.h" +#include "../../core/cfg/cfg_ctx.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" #include "../../core/rpc_lookup.h" @@ -806,6 +808,36 @@ static void pdb_rpc_status(rpc_t *rpc, void *ctx) (*active) ? "active" : "inactive"); } +static void pdb_rpc_timeout(rpc_t *rpc, void *ctx) +{ + void *vh; + int new_val = -1; + int old_val = cfg_get(pdb, pdb_cfg, timeout); + + str gname = str_init("pdb"); + str vname = str_init("timeout"); + + if(rpc->add(ctx, "{", &vh) < 0) { + rpc->fault(ctx, 500, "Server error"); + return; + } + + if(rpc->scan(ctx, "*d", &new_val) < 1) { + if(rpc->struct_add(vh, "d", "timeout", old_val) < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + } + return; + } + + if(rpc->struct_add(vh, "dd", "old_timeout", old_val, "new_timeout", new_val) + < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + return; + } + + cfg_set_now_int(ctx, &gname, NULL, &vname, new_val); +} + static void pdb_rpc_activate(rpc_t *rpc, void *ctx) { if(active == NULL) { @@ -826,11 +858,14 @@ static void pdb_rpc_deactivate(rpc_t *rpc, void *ctx) static const char *pdb_rpc_status_doc[2] = {"Get the pdb status.", 0}; +static const char *pdb_rpc_timeout_doc[2] = {"Set the pdb_query timeout.", 0}; + static const char *pdb_rpc_activate_doc[2] = {"Activate pdb.", 0}; static const char *pdb_rpc_deactivate_doc[2] = {"Deactivate pdb.", 0}; rpc_export_t pdb_rpc[] = {{"pdb.status", pdb_rpc_status, pdb_rpc_status_doc, 0}, + {"pdb.timeout", pdb_rpc_timeout, pdb_rpc_timeout_doc, 0}, {"pdb.activate", pdb_rpc_activate, pdb_rpc_activate_doc, 0}, {"pdb.deactivate", pdb_rpc_deactivate, pdb_rpc_deactivate_doc, 0}, {0, 0, 0, 0}};

1 0

[kamailio/kamailio] tls: add WSS to RPC funtions (PR #4259)
by Benjamin 27 May '25

27 May '25

- tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> #### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4167 #### Description WSS connection is not shown in tls.list RPC command like all other TLS connections. Also tls_kill does not handle WSS connections. This is related to the issue 4167. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4259 -- Commit Summary -- * http_client: add information about parameter loading * http_client: docs - typos from previous commit * tls: add WSS to RPC funtions -- File Changes -- M src/modules/http_client/doc/http_client_admin.xml (7) M src/modules/tls/tls_rpc.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4259.patch https://github.com/kamailio/kamailio/pull/4259.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4259 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4259(a)github.com>

1 5

git:master:0039c50e: permissions: don't allow reloads in the middle of ongoind reload
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 0039c50e83916c647a2ee38e6be2c39ad17adfcc URL: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T14:06:20+02:00 permissions: don't allow reloads in the middle of ongoind reload --- Modified: src/modules/permissions/rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Patch: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… --- diff --git a/src/modules/permissions/rpc.c b/src/modules/permissions/rpc.c index 6519c6343c0..7646ee0672e 100644 --- a/src/modules/permissions/rpc.c +++ b/src/modules/permissions/rpc.c @@ -45,7 +45,8 @@ int rpc_check_reload(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "ongoing reload"); return -1; } - *perm_rpc_reload_time = time(NULL); + // we are reloading, don't allow new reloads + *perm_rpc_reload_time = time(NULL) + 86400; return 0; } @@ -61,10 +62,13 @@ void rpc_trusted_reload(rpc_t *rpc, void *c) if(reload_trusted_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; } @@ -101,10 +105,13 @@ void rpc_address_reload(rpc_t *rpc, void *c) if(reload_address_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; }

1 0

git:5.8:02edb040: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 5.8 Commit: 02edb0408d907fa2a9031faf40bca899dbfcf050 URL: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:53+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) (cherry picked from commit 14de4b1101f62c3463e5f05836e8618a3b0db96b) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Patch: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 9e212f01e2c..c460cccdb36 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -625,9 +625,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -659,18 +656,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -701,6 +700,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -733,6 +735,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

git:6.0:14de4b11: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 6.0 Commit: 14de4b1101f62c3463e5f05836e8618a3b0db96b URL: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:14+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Patch: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] sca: reserve subscription.rr.s separately since it could be updated (PR #4251)
by Victor Seva 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description sca was generating a crash since it is trying to shm_free a part of a bigger block at: https://github.com/kamailio/kamailio/blob/master/src/modules/sca/sca_subscr… So, let's reserve memory that field separately. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4251 -- Commit Summary -- * sca: reserve subscription.rr.s separately since it could be updated -- File Changes -- M src/modules/sca/sca_subscribe.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4251.patch https://github.com/kamailio/kamailio/pull/4251.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4251 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4251(a)github.com>

1 1

git:master:fd04bcc1: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: fd04bcc152dd6ef88fbb819b0b77aee7ca817878 URL: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:41:23+02:00 sca: reserve subscription.rr.s separately since it could be updated --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Patch: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] PDB: new RPC command to view/change PDB query timeout value (PR #4260)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4260 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * pdb: add new code contributor credits -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4260.patch https://github.com/kamailio/kamailio/pull/4260.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4260 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4260(a)github.com>

1 3

[kamailio/kamailio] PDB: add RPC command to get and set PDB query timeout (PR #4254)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4254 -- Commit Summary -- * pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout -- File Changes -- M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4254(a)github.com>

3 8

[kamailio/kamailio] Adding kemi exports for play_dtmf event_callback and dlg_req_within functions (PR #4245)
by ggontariu 27 May '25

27 May '25

- [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added missing kemi exports for RTP Engine module play_dtmf event_callback functions and Dialog module dlg_req_within function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4245 -- Commit Summary -- * Add support for playing DTMF tones in RTP engine module using Kemi * Add support for KEMI callbacks in RTP engine events * Add `ki_dlg_req_within4` handling for dialog requests -- File Changes -- M src/modules/dialog/dialog.c (24) M src/modules/rtpengine/rtpengine.c (215) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4245.patch https://github.com/kamailio/kamailio/pull/4245.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4245 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4245(a)github.com>

2 17

git:master:472dbb59: dialog: Kemi export dlg_req_within
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 472dbb59006207629e9724b7d7155719cb653969 URL: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 dialog: Kemi export dlg_req_within --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Patch: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4539d1657e2..36af6f54404 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -2615,6 +2615,27 @@ static int ki_dlg_var_is_null(sip_msg_t *msg, str *name) return -1; } +/** + * + */ +static int ki_dlg_req_within4(struct sip_msg *msg, str *side, str *method, + str *content_type, str *content) +{ + int n = 0; + if(side && side->len > 0) { + if(side->len == 6 && strncasecmp(side->s, "caller", 6) == 0) { + n = 1; + } else if(side->len == 6 && strncasecmp(side->s, "callee", 6) == 0) { + n = 2; + } else { + return -1; + } + } + + return ki_dlg_req_with_headers_and_content( + msg, n, method, NULL, content_type, content); +} + /** * */ @@ -2780,6 +2801,11 @@ static sr_kemi_t sr_kemi_dialog_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("dialog"), str_init("dlg_req_within4"), + SR_KEMIP_INT, ki_dlg_req_within4, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:c52bf0aa: rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: c52bf0aaa4ad2bc53ede2eeb5df0d8a9bff0e140 URL: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Patch: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a…

1 0

git:master:25daa044: pv_headers: set value after checking if src is set
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 25daa0445ebc611cda3e47fd34aefc74494550d7 URL: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:59:16+02:00 pv_headers: set value after checking if src is set --- Modified: src/modules/pv_headers/pvh_str.c --- Diff: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Patch: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… --- diff --git a/src/modules/pv_headers/pvh_str.c b/src/modules/pv_headers/pvh_str.c index 28908a37069..1916f93e002 100644 --- a/src/modules/pv_headers/pvh_str.c +++ b/src/modules/pv_headers/pvh_str.c @@ -50,11 +50,12 @@ int pvh_str_free(str *s) int pvh_str_copy(str *dst, str *src, unsigned int max_size) { - unsigned int src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; + unsigned int src_len = 0; if(src == NULL || dst == NULL || src->len <= 0) return -1; + src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; memset(dst->s, 0, dst->len); memcpy(dst->s, src->s, src_len); dst->s[src_len] = '\0';

1 0

git:master:df8e3895: secfilter: remove unnecessary check on clean up
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: df8e38958a3fa0a2e356bec727bb8d7ce19bec43 URL: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:58:17+02:00 secfilter: remove unnecessary check on clean up --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… Patch: https://github.com/kamailio/kamailio/commit/df8e38958a3fa0a2e356bec727bb8d7… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index 1c0138b0193..24884b231c9 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -185,9 +185,9 @@ int secf_append_rule(int action, int type, str *value) /** * @brief Removes entries from a whitelist or blacklist based on action, type, and value. * - * The function validates the action and type, locates the relevant list, and iterates - * through its nodes to find and remove all matches for the given value. If matches are found, - * the corresponding memory is freed, and the list pointers are updated. Logs are generated + * The function validates the action and type, locates the relevant list, and iterates + * through its nodes to find and remove all matches for the given value. If matches are found, + * the corresponding memory is freed, and the list pointers are updated. Logs are generated * for each removal and at the end of the process to summarize the result. * @param action: Specifies the target list (0 = blacklist, 1 = whitelist, 2 = destination blacklist). * @param type: Indicates the type of rule to be removed (e.g., domain, IP, user, etc.). @@ -358,10 +358,8 @@ int secf_load_db(void) lock_release(&(*secf_data)->lock); clean: - if(db_res) { - if(db_funcs.free_result(db_handle, db_res) < 0) { - LM_DBG("Failed to free the result\n"); - } + if(db_funcs.free_result(db_handle, db_res) < 0) { + LM_DBG("Failed to free the result\n"); } db_funcs.close(db_handle); return res;

1 0

git:master:5c38b53b: dialog: check for message struct before accessing the fields
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 5c38b53b902949fa48c3bc60288514cd7c555d5b URL: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:24:49+02:00 dialog: check for message struct before accessing the fields - for build_dlg_t_early() --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… Patch: https://github.com/kamailio/kamailio/commit/5c38b53b902949fa48c3bc60288514c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..9ffd65e9526 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -494,7 +494,12 @@ dlg_t *build_dlg_t_early( goto error; } - if(msg == NULL || msg->first_line.type != SIP_REPLY) { + if(msg == NULL) { + LM_ERR("no sip message\n"); + goto error; + } + + if(msg->first_line.type != SIP_REPLY) { if(!cell->t) { LM_ERR("no transaction associated\n"); goto error;

1 0

git:master:46548193: pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 46548193144c0b8ab0bf2e3ecdfd7feb79bc3b2f URL: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:16:55+02:00 pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Patch: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index 26883cc27ad..09d25a67ea3 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -381,12 +381,9 @@ static void __dialog_sendpublish( uri = callee_entity_when_publish_disabled; } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_get(&dlginfo->lock); refresh_pubruri_avps(dlginfo, &uri); } @@ -584,12 +581,9 @@ static void __dialog_sendpublish( } } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_release(&dlginfo->lock); } }

1 0

git:master:423f46e6: carrierroute: check pointer and length for str value
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 423f46e6a68e241ef03f59f863ecf6dee92c07db URL: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T18:58:59+02:00 carrierroute: check pointer and length for str value --- Modified: src/modules/carrierroute/cr_rpc_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Patch: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… --- diff --git a/src/modules/carrierroute/cr_rpc_helper.c b/src/modules/carrierroute/cr_rpc_helper.c index fa1537151df..5077875bce5 100644 --- a/src/modules/carrierroute/cr_rpc_helper.c +++ b/src/modules/carrierroute/cr_rpc_helper.c @@ -107,7 +107,7 @@ static int update_route_data_recursor( if(rr->host.s) { shm_free(rr->host.s); } - if(opts->new_host.len) { + if(opts->new_host.s && opts->new_host.len) { if((rr->host.s = shm_malloc(opts->new_host.len + 1)) == NULL) { SHM_MEM_ERROR; @@ -132,12 +132,10 @@ static int update_route_data_recursor( FIFO_ERR(E_RESET); return -1; } - if(opts->new_host.len > 0) { + if(opts->new_host.s && opts->new_host.len > 0) { LM_INFO("deactivating host %.*s\n", rr->host.len, rr->host.s); - if(opts->new_host.s - && (strcmp(opts->new_host.s, rr->host.s) - == 0)) { + if(strcmp(opts->new_host.s, rr->host.s) == 0) { LM_ERR("Backup host the same as initial host " "%.*s", rr->host.len, rr->host.s);

1 0

[kamailio/kamailio] cmake: do not packaged (Issue #4255)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4255) ### Description I now make testing `cmake` packaging and see this error ``` RPM build errors: Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/* ``` ### Troubleshooting #### Reproduction I use this module list for build https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam… @xkaraman could you look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4255 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4255(a)github.com>

2 6

git:master:9a1b9d08: pkg/kamailio: switched RPM packaging to use cmake
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 9a1b9d08a112745663f37f0dfcbe86a741486da3 URL: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T18:47:42+03:00 pkg/kamailio: switched RPM packaging to use cmake --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Patch: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a…

1 0

git:master:57bd37c5: cmake: dbschema Coorect install folder of pi_framework
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 57bd37c54390fdb70520834b0c2eb29fbb79510e URL: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T13:34:50Z cmake: dbschema Coorect install folder of pi_framework --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Patch: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index dcd7bb0645b..a45e7e85470 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -59,6 +59,8 @@ function(add_db_target db_name xsl_file) set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") + elseif(db_name STREQUAL "pi_framework_table" OR db_name STREQUAL "pi_framework_mod") + set(install_folder "xhttp_pi") else() set(install_folder "${db_name}") endif() @@ -101,7 +103,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 1 1 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -110,7 +111,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 2 10 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -130,7 +130,8 @@ function(add_db_target db_name xsl_file) # message(WARNING "group name is ${group_name}") # Before installing, ensure the target is built `dbschema_${db_name}` # install as previously done in makefile folder. see naming above - # TODO: when tools adopt to new folder structure, remove the install_folder variable + # TODO: when tools adopt to new folder structure, replace the install_folder variable + # with ${db_name_folder} install( DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/

1 0

git:master:c7fcdfdb: cmake: Add some check for finding group name if using non K-variants of group names
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c7fcdfdb13aeec9aeae726a9cc1ccaeda557e7bb URL: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add some check for finding group name if using non K-variants of group names --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Patch: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index a41560f17fc..c629ee49f93 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -764,6 +764,20 @@ function(find_group_name module) "" PARENT_SCOPE ) + # This was need due to the dbschema.cmake + # If one select one of these option as group + # we want the group name to match instead of the actual group it belongs to + if(MODULE_GROUP_NAME STREQUAL "ALL" + OR MODULE_GROUP_NAME STREQUAL "DEFAULT" + OR MODULE_GROUP_NAME STREQUAL "STANDARD" + OR MODULE_GROUP_NAME STREQUAL "COMMON" + ) + set(group_name + "${MODULE_GROUP_NAME}" + PARENT_SCOPE + ) + return() + endif() # message(WARNING "groups to search in" ${MODULE_GROUP_PACKAGE_GROUPS}) # Get all variable names in the current CMake context foreach(group IN LISTS MODULE_GROUP_PACKAGE_GROUPS) @@ -776,6 +790,8 @@ function(find_group_name module) "${group}" PARENT_SCOPE ) + return() endif() endforeach() + message((STATUS "module ${module} not found in any group")) endfunction()

1 0

git:master:0fb18272: cmake: Add missing package KSTANDARD
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 0fb182720428b276793899debb210279a0b5ec97 URL: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add missing package KSTANDARD - When `ALL_PACKAGED` is used, KSTANDARD should be built as well, but not KMINI which is a subset of it. - Fix RTP_MEDIA group name --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Patch: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 90c47413d22..a41560f17fc 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -688,6 +688,7 @@ set(MODULE_GROUP_KRTP_MEDIA_SERVER ${MOD_LIST_RTP_MEDIA_SERVER}) set(STATIC_MODULES "") set(MODULE_GROUP_PACKAGE_GROUPS + KSTANDARD KPCRE KMYSQL KPOSTGRES @@ -748,7 +749,7 @@ set(MODULE_GROUP_PACKAGE_GROUPS KNGHTTP2 KGCRYPT KSECSIPID - KRT_MEDIA_SERVER + KRTP_MEDIA_SERVER ) # Add group names to available group and provide "ALL_PACKAGED" as well

1 0

5.7.7 release, tag and docker build
by Henning Westerholt 23 May '25

23 May '25

Hello, I have noticed that the git tag for release 5.7.7 was missing, I've just set it. The 5.7.7-bullseye docker image is also missing from https://github.com/kamailio/kamailio-docker/pkgs/container/kamailio Not sure if this is done automatically, if not - please can somebody please trigger the workflow to create it? Thank you, Henning

2 3

git:master:2ec8ddba: cmake: Move prefix/suffix calculation back.
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 2ec8ddba5eeaeea1c7292d1aa56ed90dc834341e URL: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T10:56:50Z cmake: Move prefix/suffix calculation back. - Prefix depends on each table name.. - Fix postgress with correct install folder..... --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Patch: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index 17528d83ed0..dcd7bb0645b 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -50,26 +50,13 @@ function(add_db_target db_name xsl_file) # For consistency, we are now using the new names. # For compatibility with tools, we are still using the old names for install folder - # Determine the prefix/suffix - if(db_name STREQUAL "db_berkeley" - OR db_name STREQUAL "db_redis" - OR db_name STREQUAL "db_text" - OR db_name STREQUAL "db_mongodb" - ) - set(prefix '') - set(folder_suffix "${MAIN_NAME}") - else() - set(prefix "${table}-") - set(folder_suffix '') - endif() - # install folder based on db_name if(db_name STREQUAL "db_mongodb") set(install_folder "mongodb") elseif(db_name STREQUAL "db_mysql") set(install_folder "mysql") elseif(db_name STREQUAL "db_postgres") - set(install_folder "mysql") + set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") else() @@ -79,6 +66,19 @@ function(add_db_target db_name xsl_file) # Loop through each table and add a command for xsltproc foreach(table ${EXTRACTED_TABLES}) + # Determine the prefix/suffix + if(db_name STREQUAL "db_berkeley" + OR db_name STREQUAL "db_redis" + OR db_name STREQUAL "db_text" + OR db_name STREQUAL "db_mongodb" + ) + set(prefix '') + set(folder_suffix "${MAIN_NAME}") + else() + set(prefix "${table}-") + set(folder_suffix '') + endif() + # Stringparam db is the db_* module name add_custom_command( TARGET dbschema_${db_name}

1 0

git:master:c2fc8090: pkg/kamailio: use radcli on RHEL based dist [skip ci]
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c2fc809059e0c70aa4324f5727666989ee8aff05 URL: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T11:04:14+03:00 pkg/kamailio: use radcli on RHEL based dist [skip ci] --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… Patch: https://github.com/kamailio/kamailio/commit/c2fc809059e0c70aa4324f572766698… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index d31f8c84d9b..094171caaeb 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -746,8 +746,8 @@ Summary: RADIUS modules for Kamailio Group: %{PKGGROUP} Requires: kamailio = %ver %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} -Requires: freeradius-client -BuildRequires: freeradius-client-devel +Requires: radcli +BuildRequires: radcli-devel %else Requires: radiusclient-ng BuildRequires: radiusclient-ng-devel @@ -1072,7 +1072,7 @@ rm -f misc/examples/pkg/sipcapture.cfg %build %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 -export FREERADIUS=1 +export RADCLI=1 %endif make cfg prefix=/usr \ basedir=%{buildroot} \ @@ -1084,7 +1084,7 @@ make make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ jabber ndb_cassandra osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \ @@ -1192,7 +1192,7 @@ make install make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ iptrtpproxy jabber osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \

1 0

git:master:701d07df: pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 701d07df14d0d66125ff0ff3adec3ce424929472 URL: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T10:46:18+03:00 pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce… Patch: https://github.com/kamailio/kamailio/commit/701d07df14d0d66125ff0ff3adec3ce…

1 0

git:master:a7c4d400: pkg/kamailio: sipcapture remove
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: a7c4d4003dced50b3f6cbc7c9c6235e6bf894334 URL: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T10:18:56+03:00 pkg/kamailio: sipcapture remove --- Modified: pkg/kamailio/obs/kamailio.spec Removed: pkg/kamailio/obs/sipcapture.service Removed: pkg/kamailio/obs/sipcapture.sysconfig Removed: pkg/kamailio/obs/sipcapture.tmpfiles --- Diff: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e… Patch: https://github.com/kamailio/kamailio/commit/a7c4d4003dced50b3f6cbc7c9c6235e…

1 0

Kamailio v5.7.7 Released
by Daniel-Constantin Mierla 21 May '25

21 May '25

Hello, Kamailio SIP Server v5.7.7 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.6. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.7. Note that 5.7 is now the third last stable branch, v5.7.7 being the last planned released in 5.7.x series. The latest two stable branch are 5.8 and 6.0, with v6.0.1 being released a while ago. For more details about version 5.7.7 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2025/05/kamailio-v5-7-7-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 0

git:5.7:b228816f: ChangeLog: content updated for v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: b228816f36f7963f1448c0f5a9fa2c5f434271d6 URL: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T09:36:47+02:00 ChangeLog: content updated for v5.7.7 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5… Patch: https://github.com/kamailio/kamailio/commit/b228816f36f7963f1448c0f5a9fa2c5…

1 0

git:5.7:690a4160: Makefile.defs: version set to 5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: 690a41609bb6308834527f5081a19e20bd63e0ca URL: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T09:10:42+02:00 Makefile.defs: version set to 5.7.7 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… Patch: https://github.com/kamailio/kamailio/commit/690a41609bb6308834527f5081a19e2… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index c598d6cb02c..a91846e5c19 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 7 -SUBLEVEL = 6 +SUBLEVEL = 7 EXTRAVERSION = # memory manager switcher

1 0

git:5.7:ebb630f9: pkg: deb specs updated for v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: ebb630f9c7ff6e67209b8dbb67da69403b979661 URL: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T08:55:54+02:00 pkg: deb specs updated for v5.7.7 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694… Patch: https://github.com/kamailio/kamailio/commit/ebb630f9c7ff6e67209b8dbb67da694…

1 0

git:5.7:951e5360: pkg: version set to 5.7.7 for rpms and alpine specs
by Daniel-Constantin Mierla 21 May '25

21 May '25

Module: kamailio Branch: 5.7 Commit: 951e53600f17bf4b05f414b1dbfe8f8853cb0a70 URL: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-21T08:48:18+02:00 pkg: version set to 5.7.7 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… Patch: https://github.com/kamailio/kamailio/commit/951e53600f17bf4b05f414b1dbfe8f8… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index c9a6b828707..e84d3a0bed3 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.7.6 +pkgver=5.7.7 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 7e15f95fdc8..c0f4b3e7eba 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.7.6 +%define ver 5.7.7 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.7.7
by Daniel-Constantin Mierla 21 May '25

21 May '25

Hello, I am considering to release Kamailio v5.7.7 (out of branch 5.7) on Wednesday, May 21, 2025, as the last one from the 5.7.x series, to mark the end of support for it. Currently 5.8.x and 6.0.x are the latest two maintained branches. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

git:master:cdf9a471: cmake: Refactor packaging setup and improve installation paths
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: cdf9a4716db3762b172df059d7366983216fd48c URL: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:09:40Z cmake: Refactor packaging setup and improve installation paths - Moved packaging configuration to a new deb-packaging.cmake file for better organization. - Updated installation paths in CMakeLists to use DESTDIR for flexibility. - Enhanced group handling for module packaging, allowing for "ALL_PACKAGED" option. --- Added: cmake/deb-packaging.cmake Modified: CMakeLists.txt Modified: cmake/groups.cmake Modified: src/CMakeLists.txt Modified: src/modules/CMakeLists.txt Modified: utils/kamctl/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698… Patch: https://github.com/kamailio/kamailio/commit/cdf9a4716db3762b172df059d736698…

1 0

git:master:201a2bde: cmake: snmpstats Remove warning message
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 201a2bdee6a8b78787908b296824cd282b78eef5 URL: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:08:35Z cmake: snmpstats Remove warning message --- Modified: src/modules/snmpstats/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… Patch: https://github.com/kamailio/kamailio/commit/201a2bdee6a8b78787908b296824cd2… --- diff --git a/src/modules/snmpstats/CMakeLists.txt b/src/modules/snmpstats/CMakeLists.txt index fead0651f33..3c5f2428242 100644 --- a/src/modules/snmpstats/CMakeLists.txt +++ b/src/modules/snmpstats/CMakeLists.txt @@ -8,7 +8,6 @@ find_package(NETSNMP REQUIRED) # TODO: Compiles fine but need to do some more verifcation target_link_libraries(${module_name} PRIVATE NETSNMP::NETSNMP) -message(WARNING "group_name is: ${group_name}") install( DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/mibs DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp

1 0

git:master:e0dd3961: cmake: Fix dbschema generation to match older makefile structure
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: e0dd39618fae2004cd1ab44758ca323376935e2e URL: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:08:35Z cmake: Fix dbschema generation to match older makefile structure --- Added: cmake/dbschema-version-postprocess.sh Added: doc/stylesheets/dbschema_k/xsl/db_mongodb.xsl Added: doc/stylesheets/dbschema_k/xsl/db_mysql.xsl Added: doc/stylesheets/dbschema_k/xsl/db_oracle.xsl Added: doc/stylesheets/dbschema_k/xsl/db_postgres.xsl Added: doc/stylesheets/dbschema_k/xsl/db_text.xsl Modified: CMakeLists.txt Modified: cmake/dbschema.cmake Modified: doc/stylesheets/dbschema_k/xsl/common.xsl Modified: doc/stylesheets/dbschema_k/xsl/pi_framework_table.xsl Modified: src/CMakeLists.txt Modified: src/lib/srdb1/schema/version.xml Removed: doc/stylesheets/dbschema_k/xsl/dbtext.xsl Removed: doc/stylesheets/dbschema_k/xsl/mongodb.xsl Removed: doc/stylesheets/dbschema_k/xsl/mysql.xsl Removed: doc/stylesheets/dbschema_k/xsl/oracle.xsl Removed: doc/stylesheets/dbschema_k/xsl/postgres.xsl --- Diff: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323… Patch: https://github.com/kamailio/kamailio/commit/e0dd39618fae2004cd1ab44758ca323…

1 0

git:master:ccad04cc: cmake: Fix dbschema generation with group names
by Xenofon Karamanos 20 May '25

20 May '25

Module: kamailio Branch: master Commit: ccad04cc13b1c5695aded8ee02181f10c8ed7d11 URL: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-20T15:06:11Z cmake: Fix dbschema generation with group names - Add function to find group of module - Some targets and destinations folders have changed due to changing to more consistency naming. - dbschema_{db_module_name) targets - stringparam db set to module name --- Modified: cmake/dbschema.cmake Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1… Patch: https://github.com/kamailio/kamailio/commit/ccad04cc13b1c5695aded8ee02181f1…

1 0

[kamailio/kamailio] MAR callback is not executed after a MAR request is sent (ims _auth module) (Issue #4205)
by Amin Nazari 20 May '25

20 May '25

amnapa created an issue (kamailio/kamailio#4205) ### Description Using sCSCF sample found [here](https://github.com/kamailio/kamailio/blob/master/misc/examples/ims/sc…, after calling ims_www_challenge in REGISTER route block and sending a Diameter MAR request, the control is never passed to REG_MAR_REPLY route block and debug messages within REG_MAR_REPLY are not logged. This is not the case with REG_SAR_REPLY and PRE_REG_SAR_REPLY, those blocks are executed as expected. ``` ###################################################################### # Route for handling Registrations: ###################################################################### route[REGISTER] { xlog("ALGORITHM IS [$aa] and User-Agent is [$ua]\n"); $var(alg) = $aa; if ($aa == $null) { $var(alg) = "MD5"; #force to MD5 for zoiper.... non-ims } #!ifdef WITH_AUTH if (!ims_www_authenticate("$td")) { #!else if (($var(alg) == "MD5") && (!ims_www_authenticate("$td"))) { #!endif if ($? == -2) { send_reply("403", "Authentication Failed"); exit; } else if ($? == -3) { send_reply("400", "Bad Request"); exit; } else if ($? == -9) { xlog("L_DBG", "Authentication re-sync requested\n"); ims_www_resync_auth("REG_RESYNC_REPLY", "$td"); exit; } else { #user has not been authenticated. Lets send a challenge via 401 Unauthorized xlog("L_DBG", "About to challenge! auth_ims\n"); ims_www_challenge("REG_MAR_REPLY", "$td", "$var(alg)"); exit; } } else { xlog("L_DBG", "Auth succeeded\n"); # We need to check if this user is registered or not if (!impu_registered("location")) { xlog("L_ERR", "Not REGISTERED\n"); save("PRE_REG_SAR_REPLY", "location"); exit; } else { isc_match_filter_reg("1", "location"); save("REG_SAR_REPLY", "location"); exit; } } } route[REG_MAR_REPLY] { #this is async so to know status we have to check the reply avp xlog("L_DBG", "maa_return code is $avp(s:maa_return_code)\n"); switch ($avp(s:maa_return_code)){ case 1: #success xlog("L_DBG", "MAR success - 401/407 response sent from module\n"); break; case -1: #failure xlog("L_ERR", "MAR failure - error response sent from module\n"); break; case -2: #error xlog("L_ERR", "MAR error - sending error response now\n"); send_reply("500", "MAR failed"); break; default: xlog("L_ERR", "Unknown return code from MAR, value is [$avp(s:maa_return_code)]\n"); send_reply("500", "Unknown response code from MAR"); break; } exit; } ``` ### Troubleshooting #### Reproduction  #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages ``` ERROR: *** cfgtrace:request_route=[REGISTER] c=[/usr/local/etc/kamailio/kamailio.cfg] l=712 a=27 n=ims_www_challenge DEBUG: ims_auth [authorize.c:290]: challenge(): Looking for route block [REG_MAR_REPLY] INFO: ims_auth [cxdx_mar.c:76]: create_return_code(): created AVP successfully : [maa_return_code] - [-2] DEBUG: ims_auth [authorize.c:314]: challenge(): Need to challenge for realm [ims.mnc072.mcc432.3gppnetwork.org] DEBUG: ims_auth [authorize.c:321]: challenge(): Checking if REGISTER is authorized for realm [ims.mnc072.mcc432.3gppnetwork.org]... DEBUG: ims_auth [authorize.c:1446]: get_auth_userdata(): Searching auth_userdata for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [authorize.c:1455]: get_auth_userdata(): Found auth_userdata DEBUG: ims_auth [authorize.c:1061]: get_auth_vector(): looping through AV status is 3 and were looking for 0 DEBUG: tm [t_lookup.c:1343]: t_newtran(): msg (0x7f8d3f410cb0) id=1/11 global id=1/11 T start=(nil) DEBUG: tm [t_lookup.c:498]: t_lookup_request(): start searching: hash=21555, isACK=0 DEBUG: tm [t_lookup.c:456]: matching_3261(): RFC3261 transaction matching failed - via branch [z9hG4bK3345.d6f2aff0d9192c2647aca3baea62cf94.1] DEBUG: tm [t_lookup.c:681]: t_lookup_request(): no transaction found DEBUG: tm [t_hooks.c:337]: run_reqin_callbacks_internal(): trans=0x7f8d2bff4520, callback type 1, id 0 entered DEBUG: ims_auth [authorize.c:457]: challenge(): Suspending SIP TM transaction DEBUG: ims_auth [authorize.c:1526]: multimedia_auth_request(): Sending MAR DEBUG: ims_auth [cxdx_mar.c:572]: cxdx_send_mar(): Successfully sent async diameter DEBUG: tm [t_lookup.c:1628]: t_lookup_ident_filter(): transaction found INFO: ims_auth [cxdx_avp.c:134]: cxdx_get_avp(): cxdx_get_experimental_result_code: Failed finding avp (avp_code = 297, vendor_id = 0) DEBUG: ims_auth [authorize.c:1557]: pack_challenge(): setting QOP str used is [, qop="auth"] DEBUG: ims_auth [authorize.c:1559]: pack_challenge(): QOP str used is [, qop="auth"] DEBUG: tm [t_reply.c:1660]: cleanup_uac_timers(): RETR/FR timers reset DEBUG: tm [t_reply.c:595]: _reply_light(): reply sent out. buf=0x7f8d3f4120b8: SIP/2.0 401 Unauthor..., shmem=0x7f8d2bff9288: SIP/2.0 401 Unauthor DEBUG: tm [t_reply.c:606]: _reply_light(): finished DEBUG: ims_auth [authorize.c:1446]: get_auth_userdata(): Searching auth_userdata for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [authorize.c:1455]: get_auth_userdata(): Found auth_userdata DEBUG: ims_auth [authorize.c:1679]: add_auth_vector(): Adding auth_vector (status 1) for IMPU sip:bob@ims.mnc072.mcc432.3gppnetwork.org / IMPI bob(a)ims.mnc072.mcc432.3gppnetwork.org (Hash 295) DEBUG: ims_auth [cxdx_mar.c:483]: async_cdp_callback(): DBG:UAR Async CDP callback: ... Done resuming transaction INFO: ims_auth [cxdx_mar.c:76]: create_return_code(): created AVP successfully : [maa_return_code] - [1] DEBUG: ims_auth [cxdx_mar.c:495]: async_cdp_callback(): Destroying current transaction prevented! DEBUG: tm [t_lookup.c:1620]: t_lookup_ident_filter(): transaction in terminated phase - skipping ERROR: tm [t_suspend.c:196]: t_continue_helper(): active transaction not found DEBUG: ims_auth [cxdx_mar.c:84]: free_saved_transaction_data(): Freeing saved transaction data: async ``` #### SIP Traffic ``` (paste your sip traffic here) ``` ### Possible Solutions The issue is related to ims_auth module, in [cxdx_mar.c ](https://github.com/kamailio/kamailio/blob/master/src/modules/ims_auth/cxdx_mar.c). within async_cdp_callback function, if I replace: ``` tmb.t_continue(data->tindex, data->tlabel, data->act); ```` with the following: ``` tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); ``` the issue will be fixed and the control will be passed to REG_MAR_REPLY route block. In fact, in ims_registrar_scscf module, in [cxdx_sar.c ](https://github.com/kamailio/kamailio/blob/master/src/modules/ims_registrar_scscf/cxdx_sar.c) file, the t_continue_skip_timer is called instead of t_continue, if I replace it with t_continue the same issue happens for SAR callbacks. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/linux) c858ce-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c858ce -dirty compiled on 10:33:37 Apr 5 2025 with gcc 11.4.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 22.04.5 LTS Release: 22.04 Codename: jammy Linux kuber-worker 5.15.0-133-generic #144-Ubuntu SMP Fri Feb 7 20:47:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4205 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4205(a)github.com>

2 3

TSILO With Multiple Devices Over WebSocket
by bhavikpatel14388＠gmail.com 20 May '25

20 May '25

Hello, I am using exact same logic for which is define in this documentation and single device its working fine. https://www.kamailio.org/events/2015-KamailioWorld/Day2/20-Federico.Cabiddu… But seems like if multiple registration with same extension, like if extension 102 logged in mobile as well web. If web device registered and mobile is not registered with wss, then the Current transaction is not going to suspend due to its consider like there is only one location entry on location table.so only one Invite send to web and mobile its going to send notification but never get Invite, even it is going to register using push notification. So below LOCATION function should be called and sending invite to registered extension and should be waiting for Other device as well. But in my case its consider like only one device is there and transaction is not suspending. Could you check and suggest me which part of code need to improve to so i can make it working with registered device with parallel forking for adding new branch. Here is my code. modparam("registrar", "max_contacts", 10) modparam("registrar", "append_branches", 1) modparam("registrar", "use_path", 1) modparam("registrar", "path_mode", 1) loadmodule "tsilo.so" modparam("tsilo", "use_domain", 1) modparam("htable", "htable", "vtp=>size=100;autoexpire=30;") # append branches or resume the transaction route[PUSHJOIN] { $var(hjoin) = 0; lock("$tU"); $var(hjoin) = $sht(vtp=>join::$tU); $var(hstored) = $sht(vtp=>stored::$tU); $sht(vtp=>join::$tU) = $null; unlock("$tU"); if ($var(hjoin)==0) { if ($var(hstored)) ts_append("location", "$tU"); return; } $var(id_index) = $(var(hjoin){s.select,0,:}{s.int}); $var(id_label) = $(var(hjoin){s.select,1,:}{s.int}); t_continue("$var(id_index)", "$var(id_label)", "INVRESUME"); } # lookup and relay after resuming transaction route[INVRESUME] { lookup("location"); xlog("L_INFO","[RESUME] rm=$rm ru=$ru du=$du \n"); t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; $sht(vtp=>id_index::$tu) = $null; $sht(vtp=>id_label::$tu) = $null; xlog("L_INFO","stored transaction [$T(id_index):$T(id_label)] $fU => $rU\n"); } route[SUSPEND] { if ( !t_suspend() ) { xlog("L_ERROR","[SUSPEND] failed suspending trasaction [$T(id_index):$T(id_label)]\n"); send_reply("501", "Suspending error"); exit; } xlog("L_INFO","[SUSPEND] suspended transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); $sht(vtp=>join::$rU) = "" + $T(id_index) + ":" + $T(id_label); xlog("L_INFO","htable key value [$sht(vtp=>join::$rU)]\n"); } route[SENDPUSH] { $avp(platform) = $hdr(X-pn-platform); $var(headers) = "Content-Type: application/json\r\nAuthorization: Bearer 55466cc-c789-4a48-39c8-219ebaa1512f"; $var(body) = "{\"user\": \"" + $rU + "\", " + "\"platform\": \"" + $avp(platform) + "\"}"; http_client_query("https://handlepush.xxx.com/v2/phone/call/send_notification_kamalio", "$var(body)", "$var(headers)", "$var(res)"); } # User location service route[LOCATION] { if (!lookup("location")) { send_reply("100", "Trying"); xlog("L_INFO","SUSPENDING TRANASACTION $fU => $rU\n"); route(SUSPEND); } else { t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; xlog("L_INFO","stored transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); } route(SENDPUSH); exit; } if (is_method("REGISTER") || from_uri==myself) { xlog("L_INFO", "SAVING TO LOCATIONS $si:$sp\n"); if (!save("location")) { sl_reply_error(); } route(PUSHJOIN); exit; } Can you help me to understand why parallel forking not working in this case ? Thanks

3 8

[kamailio/kamailio] ims_dialog: missing srdb1 schema definition (Issue #4100)
by Victor Seva 20 May '25

20 May '25

there's no ``kamailio-ims_dialog.xml`` at ``src/lib/srdb1/schema`` but there's a manual file created at ``utils/kamctl/mysql/ims_dialog-create.sql`` Same thing for: - ``utils/kamctl/mysql/ims_charging-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_pcscf-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_scscf-create.sql`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4100 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4100(a)github.com>

3 10

git:master:068ace09: modules: readme files regenerated - textops ... [skip ci]
by Kamailio Dev 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 068ace09409ef1f03bf6d617b315579cfe2a46f6 URL: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-20T09:31:10+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579… Patch: https://github.com/kamailio/kamailio/commit/068ace09409ef1f03bf6d617b315579…

1 0

git:master:0cb4dd32: dialog: split w_dlg_req_with_headers_and_content() for kemi usage
by Daniel-Constantin Mierla 20 May '25

20 May '25

Module: kamailio Branch: master Commit: 0cb4dd3282ec12cdaefca491f9ed43acd0f21bdd URL: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-20T09:25:09+02:00 dialog: split w_dlg_req_with_headers_and_content() for kemi usage - PR #4245 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… Patch: https://github.com/kamailio/kamailio/commit/0cb4dd3282ec12cdaefca491f9ed43a… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 382941c9925..4539d1657e2 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1363,19 +1363,57 @@ static int fixup_dlg_req_with_headers_and_content(void **param, int param_no) return 0; } +static int ki_dlg_req_with_headers_and_content(struct sip_msg *msg, int nside, + str *smethod, str *sheaders, str *scontent_type, str *scontent) +{ + dlg_cell_t *dlg = NULL; + + dlg = dlg_get_ctx_dialog(); + if(dlg == NULL) + return -1; + + if(nside == 1) { + if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } else if(nside == 2) { + if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } else { + if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, smethod, sheaders, + scontent_type, scontent) + != 0) + goto error; + goto done; + } + +done: + dlg_release(dlg); + return 1; + +error: + dlg_release(dlg); + return -1; +} + static int w_dlg_req_with_headers_and_content(struct sip_msg *msg, char *side, char *method, char *headers, char *content_type, char *content) { - dlg_cell_t *dlg = NULL; int n; str str_method = {0, 0}; str str_headers = {0, 0}; str str_content_type = {0, 0}; str str_content = {0, 0}; - dlg = dlg_get_ctx_dialog(); - if(dlg == NULL) - return -1; if(fixup_get_svalue(msg, (gparam_p)method, &str_method) != 0) { LM_ERR("unable to get Method\n"); @@ -1417,36 +1455,11 @@ static int w_dlg_req_with_headers_and_content(struct sip_msg *msg, char *side, } n = (int)(long)side; - if(n == 1) { - if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } else if(n == 2) { - if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } else { - if(dlg_request_within(msg, dlg, DLG_CALLER_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - if(dlg_request_within(msg, dlg, DLG_CALLEE_LEG, &str_method, - &str_headers, &str_content_type, &str_content) - != 0) - goto error; - goto done; - } -done: - dlg_release(dlg); - return 1; + return ki_dlg_req_with_headers_and_content( + msg, n, &str_method, &str_headers, &str_content_type, &str_content); error: - dlg_release(dlg); return -1; }

1 0

git:master:c1e81dfa: textops: docs for str_all_in()
by Daniel-Constantin Mierla 20 May '25

20 May '25

Module: kamailio Branch: master Commit: c1e81dfa915f5c52da83cf02cbecdcf881eb057c URL: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-20T09:17:00+02:00 textops: docs for str_all_in() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… Patch: https://github.com/kamailio/kamailio/commit/c1e81dfa915f5c52da83cf02cbecdcf… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 86f02b97336..9560eb6d663 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1955,6 +1955,29 @@ if (str_any_in("$hdr(X-Hdr)", ";',:")) { </example> </section> + <section id="textops.f.str_all_in"> + <title> + <function moreinfo="none">str_all_in(txt, clist)</function> + </title> + <para> + Return 1 (true) if all character in "clist" are found inside "txt". + Both paramters can contain variables. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>str_all_in</function> usage</title> + <programlisting format="linespecific"> +... +if (str_all_in("$hdr(X-Hdr)", ".;-")) { + # do interesting stuff here +} +... +</programlisting> + </example> + </section> + <section id="textops.f.set_body_multipart"> <title> <function moreinfo="none">set_body_multipart([txt, content_type][, boundary])</function>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev