After the transaction was suspended, 1st user registered, got INVITE message, there is 2nd user wakes up and send REGISTER.
Kamailio check if transaction suspended (for 2nd user, it is not suspended anymore), and checks if there is stored transaction.
So, for 2nd user we have stored transaction, then it should append new branch. ts_append failed.
if ($var(suspended) == 0) {
if ($var(stored)) {
# no suspended INVITE (i.e. there was at least one
…
[View More] # registered contact for target) and 'stored' set
# (i.e. ongoing transaction) -> this newly just
# registered contact needs alerting.
ts_append("location", "sip:$avp(extension)@LOCALVIRTUALIP");
xinfo("appending branches for sip:$avp(extension)@LOCALVIRTUALIP, result $rc");
} else {
xinfo("no suspended transactions for $tu");
}
return;
}
Mar 10 21:07:11 stage-webrtc-kama-01 /usr/sbin/kamailio[4067482]: INFO: [t3jutj5k1na4eir1o8pvk9 REGISTER WAKE_SUSPENDED:1:1339] <script>: -----------122583d4102d400d8565c6f48d217b8d
Mar 10 21:07:11 stage-webrtc-kama-01 /usr/sbin/kamailio[4067482]: INFO: [t3jutj5k1na4eir1o8pvk9 REGISTER WAKE_SUSPENDED:1:1348] <script>: var(suspended)=0, tsilo=>suspended::122583d4102d400d8565c6f48d217b8d
Mar 10 21:07:11 stage-webrtc-kama-01 /usr/sbin/kamailio[4067482]: INFO: [t3jutj5k1na4eir1o8pvk9 REGISTER WAKE_SUSPENDED:1:1349] <script>: var(stored)=1, tsilo=>stored::122583d4102d400d8565c6f48d217b8d
Mar 10 21:07:11 stage-webrtc-kama-01 /usr/sbin/kamailio[4067482]: ERROR: [t3jutj5k1na4eir1o8pvk9 REGISTER WAKE_SUSPENDED:1:1357] tsilo [ts_append.c:152]: ts_append_to(): transaction 11743:1310842517: error updating dset (-1)
Mar 10 21:07:11 stage-webrtc-kama-01 /usr/sbin/kamailio[4067482]: INFO: [t3jutj5k1na4eir1o8pvk9 REGISTER WAKE_SUSPENDED:1:1359] <script>: appending branches for sip:1000@10.160.201.190, result 1
At this moment we have active transaction
`{
cell: 0x7f313d43cda8
tindex: 11743
tlabel: 1310842517
method: INVITE
from: From: "9988" <sip:9988@10.156.0.6>;tag=as081c0936
to: To: <sip:1000@10.160.201.190:5070>
callid: Call-ID: 66d9dace125df36915783fb379f4e3dd@10.156.0.6:5060
cseq: CSeq: 102
uas_request: yes
tflags: 69
outgoings: 3
ref_count: 1
lifetime: 5402832
}
`
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3782
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3782(a)github.com>
[View Less]
### Description
Event routes that are executed without a real SIP message available use the default "fake SIP message". The fake message has a source IPv4 address of 1.0.0.127 which belongs to CloudFlare (1.0.0.0/24).. and this led us to believe that traffic is coming from CF but could not find the messages on tcpdumps or HEP exports. Had a bit of a wild goose chase there trying to find the source. I believe the original intention has been to use 127.0.0.1 loopback address but the bytes are …
[View More]reversed at:
https://github.com/kamailio/kamailio/blob/master/src/core/fmsg.c#L78
It would be best to change this address to well ANYTHING that doesn't imply CloudFlare is pinging you 😂
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3817
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3817(a)github.com>
[View Less]
kemi_mock.py can now optionally consume documentation information generated by the vscode-kamailio-hover project
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with &#…
[View More]39;git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3818
-- Commit Summary --
* tools/kemi: add dockstrings to the mocking
-- File Changes --
M misc/tools/kemi/python_mock/README.md (15)
M misc/tools/kemi/python_mock/kemi_mock.py (31)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3818.patchhttps://github.com/kamailio/kamailio/pull/3818.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3818
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3818(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
When inserting into the database the AOR is split at the @ sign and if there is no @ sign in the AOR only the domain part is filled and the user part is left empty.
But for deleting this is not done and the query failed to be executed and the AOR is not deleted. This PR add this behaviour of only comparing against the domain part if the AOR doesn't contain a @ sign.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3815
-- Commit Summary --
* usrloc: check on db delete the return value of memchr
-- File Changes --
M src/modules/usrloc/urecord.c (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3815.patchhttps://github.com/kamailio/kamailio/pull/3815.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3815
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3815(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 49276a1f43b1a3bf4a8d681888df964000360c79
URL: https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964…
Author: Rick Barenthin <rick(a)ng-voice.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2024-04-20T06:35:51+02:00
usrloc: check on db delete the return value of memchr
When inserting into the database the AOR is split at the @ sign and
if there is no @ sign in the AOR only the domain part is filled and the
…
[View More]user part is left empty.
But for deleting this is not done and the query failed to be executed
and the AOR is not deleted. This PR add this behaviour of only comparing against the
domain part if the AOR doesn't contain a @ sign.
---
Modified: src/modules/usrloc/urecord.c
---
Diff: https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964…
Patch: https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964…
---
diff --git a/src/modules/usrloc/urecord.c b/src/modules/usrloc/urecord.c
index e027affc8aa..3c394a24a10 100644
--- a/src/modules/usrloc/urecord.c
+++ b/src/modules/usrloc/urecord.c
@@ -491,13 +491,17 @@ int db_delete_urecord(urecord_t *_r)
vals[0].val.str_val.len = _r->aor.len;
if(ul_use_domain) {
- dom = memchr(_r->aor.s, '@', _r->aor.len);
- vals[0].val.str_val.len = dom - _r->aor.s;
-
vals[1].type = DB1_STR;
vals[1].nul = 0;
- vals[1].val.str_val.s = dom + 1;
- vals[1].val.str_val.len = _r->aor.s + _r->aor.len - dom - 1;
+ dom = memchr(_r->aor.s, '@', _r->aor.len);
+ if(dom == 0) {
+ vals[0].val.str_val.len = 0;
+ vals[1].val.str_val = _r->aor;
+ } else {
+ vals[0].val.str_val.len = dom - _r->aor.s;
+ vals[1].val.str_val.s = dom + 1;
+ vals[1].val.str_val.len = _r->aor.s + _r->aor.len - dom - 1;
+ }
}
if(ul_dbf.use_table(ul_dbh, _r->domain) < 0) {
[View Less]
I want kamailio use User-Agent header, not Server head
My setup is as follows: kamailio.cfg
server_signature=no
user_agent_header="User-Agent: carrierroute-kam"
the result is :
SIP/2.0 100 trying -- your call is important to us
Via: SIP/2.0/UDP xxx
From: xxxxxxtag=N856ZmNXa4S6D
To: xxx
Call-ID: 5ab0
CSeq: 82194 INVITE
Content-Length: 0
**not have User-Agent header**
please help me,How to make it appear the User-Agent field? thank you
version: kamailio 5.7.0 (x86_64/linux) f1e91d
--
…
[View More]Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3816
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3816(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 0a28a93c6e060081267dc686e342d45ef03358e7
URL: https://github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2024-04-16T14:42:20+02:00
tcp_main: Update comment docs
---
Modified: src/core/tcp_main.c
---
Diff: https://github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45…
Patch: https:…
[View More]//github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45…
---
diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index 0ea1b541ea6..e3323736cc0 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -1697,8 +1697,8 @@ void tcpconn_rm(struct tcp_connection *c)
/* finds a connection, if id=0 uses the ip addr, port, local_ip and local port
* (host byte order) and tries to find the connection that matches all of
- * them. Wild cards can be used for local_ip and local_port (a 0 filled
- * ip address and/or a 0 local port).
+ * them. Wild cards can be used for local_ip, local_port and proto (a 0 filled
+ * ip address and/or a 0 local port and/or PROTO_NONE).
* WARNING: unprotected (locks) use tcpconn_get unless you really
* know what you are doing */
struct tcp_connection *_tcpconn_find(int id, struct ip_addr *ip, int port,
@@ -1754,7 +1754,7 @@ struct tcp_connection *_tcpconn_find(int id, struct ip_addr *ip, int port,
/**
- * find if a tcp connection exits by id or remote+local address/port
+ * find if a tcp connection exits by id or remote+local address/port and protocol
* - return: 1 if found; 0 if not found
*/
int tcpconn_exists(int conn_id, ip_addr_t *peer_ip, int peer_port,
@@ -1774,6 +1774,7 @@ int tcpconn_exists(int conn_id, ip_addr_t *peer_ip, int peer_port,
/* TCP connection find with locks and timeout
* - local_addr contains the desired local ip:port. If null any local address
* will be used. IN*ADDR_ANY or 0 port are wild cards.
+ * - proto is the protocol to match (PROTO_NONE for any)
* - try_local_port makes the search use it first, instead of port from local_addr
* If found, the connection's reference counter will be incremented, you might
* want to decrement it after use.
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
We noticed that configuration option tcp_accept_iplimit was included in newer kamailio versions (most notably 5.7.4), and it was a breaking change for us. Added sample configuration value in /etc/kamailio.cfg file - already tested in our production deployment.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3792
-- Commit Summary --
* tcp/docs: Added tcp_accept_iplimit config sample
-- File Changes --
M etc/kamailio.cfg (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3792.patchhttps://github.com/kamailio/kamailio/pull/3792.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3792
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3792(a)github.com>
[View Less]
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual …
[View More]modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3777
#### Description
<!-- Describe your changes in detail -->
- freed request.s after sending request to websocket in send_rtpp_command method.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3813
-- Commit Summary --
* rtpengine: fix pkg mem leak in send_rtpp_command()
-- File Changes --
M src/modules/rtpengine/rtpengine.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3813.patchhttps://github.com/kamailio/kamailio/pull/3813.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3813(a)github.com>
[View Less]
Hello,
there is some planned work on the data center infrastructure hosting
kamailio.org server that is going to affect briefly the web server (web
site, wiki) and the mailing lists.
The downtime is expected to be 10-15 minutes around 1:00am Western
Europe time (CEST / GMT+2), but if it takes longer or repeats, be
patient for a while.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development …
[View More]Services -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
[View Less]
### Description
Hello. Probably I'm doing something wrong but I can't get rid of **received** parameter in the **Via** header in responses from kamailio by websocket transport.
According [RFC 7118](https://datatracker.ietf.org/doc/rfc7118/):
``
When a SIP WebSocket Server receives a request, it MAY decide not
to add a "received" parameter to the top Via header. Therefore,
SIP WebSocket Clients MUST accept responses without such a
parameter in the top Via header …
[View More]regardless of whether the **Via**
"sent-by" field contains a domain name.
``
### Expected behavior
For responses to websocket transport have a way to not add **received** parameter in **Via** header
#### Actual observed behavior
Responses to OPTION or REGISTER methods trough websocket got **received** containing IP we want to not show to the end users.
### Possible Solutions
maybe add a param in **tm** module or something
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.2.1 (x86_64/linux)
```
and
```
kamailio 5.6.1 (x86_64/linux) b36a13
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3515
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3515(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 94b9cd5d5ffafde86fbcbede2d9a018fc616b6b1
URL: https://github.com/kamailio/kamailio/commit/94b9cd5d5ffafde86fbcbede2d9a018…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-04-15T11:01:29+02:00
modules: readme files regenerated - cfgutils ... [skip ci]
---
Modified: src/modules/cfgutils/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]94b9cd5d5ffafde86fbcbede2d9a018…
Patch: https://github.com/kamailio/kamailio/commit/94b9cd5d5ffafde86fbcbede2d9a018…
---
diff --git a/src/modules/cfgutils/README b/src/modules/cfgutils/README
index b7c8075fad9..cb6251b6719 100644
--- a/src/modules/cfgutils/README
+++ b/src/modules/cfgutils/README
@@ -65,9 +65,9 @@ Daniel-Constantin Mierla
4.12. set_gflag(flag)
4.13. reset_gflag(flag)
4.14. is_gflag(flag)
- 4.15. lock(key)
- 4.16. trylock(key)
- 4.17. unlock(key)
+ 4.15. lock(key [, key2])
+ 4.16. trylock(key [, key2])
+ 4.17. unlock(key [, key2])
4.18. check_route_exists(route)
4.19. route_if_exists(route)
4.20. core_hash(string1, string2, size)
@@ -154,9 +154,9 @@ Chapter 1. Admin Guide
4.12. set_gflag(flag)
4.13. reset_gflag(flag)
4.14. is_gflag(flag)
- 4.15. lock(key)
- 4.16. trylock(key)
- 4.17. unlock(key)
+ 4.15. lock(key [, key2])
+ 4.16. trylock(key [, key2])
+ 4.17. unlock(key [, key2])
4.18. check_route_exists(route)
4.19. route_if_exists(route)
4.20. core_hash(string1, string2, size)
@@ -304,9 +304,9 @@ modparam("cfgutils", "lock_set_size", 4)
4.12. set_gflag(flag)
4.13. reset_gflag(flag)
4.14. is_gflag(flag)
- 4.15. lock(key)
- 4.16. trylock(key)
- 4.17. unlock(key)
+ 4.15. lock(key [, key2])
+ 4.16. trylock(key [, key2])
+ 4.17. unlock(key [, key2])
4.18. check_route_exists(route)
4.19. route_if_exists(route)
4.20. core_hash(string1, string2, size)
@@ -506,16 +506,18 @@ if(is_gflag("4"))
};
...
-4.15. lock(key)
+4.15. lock(key [, key2])
Lock the key. Can be used to synchronize operations in config file, a
- hash id is computed over the key and appropriate lock is set in the
+ hash id is computed over the keys and appropriate lock is set in the
lock array controlled by parameter "lock_set_size". Do not use lock()
after another lock() unless you are sure the keys hit different array
entries.
���key��� can be static string or string with PVs.
+ ���key2��� is optional and can be static string or string with PVs.
+
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
@@ -524,13 +526,15 @@ if(is_gflag("4"))
lock("$rU");
...
-4.16. trylock(key)
+4.16. trylock(key [, key2])
Try to lock the key. If the lock can not be obtained (possibly already
locked), the function returns an error and script execution continues.
���key��� can be static string or string with PVs.
+ ���key2��� is optional and can be static string or string with PVs.
+
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
@@ -542,12 +546,14 @@ if (trylock("$rU")) {
}
...
-4.17. unlock(key)
+4.17. unlock(key [, key2])
Unlock the key.
���key��� can be static string or string with PVs.
+ ���key2��� is optional and can be static string or string with PVs.
+
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
[View Less]
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual …
[View More]modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
expose in config via cfgutils ``core_case_hash`` optional second string key for hashing
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3808
-- Commit Summary --
* cfgutils: expose optional second string key for hashing at locks
* cfgutils: document second optional string for hashing on lock functions family [skip ci]
* app_lua_sr: support second str for cfgutils lock
-- File Changes --
M src/modules/app_lua_sr/app_lua_sr_exp.c (30)
M src/modules/cfgutils/api.h (4)
M src/modules/cfgutils/cfgutils.c (103)
M src/modules/cfgutils/doc/cfgutils_admin.xml (18)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3808.patchhttps://github.com/kamailio/kamailio/pull/3808.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3808
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3808(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 235591cd704529589bbde700b6232ac55281d071
URL: https://github.com/kamailio/kamailio/commit/235591cd704529589bbde700b6232ac…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-04-15T10:50:26+02:00
cfgutils: document second optional string for hashing on lock functions family [skip ci]
---
Modified: src/modules/cfgutils/doc/cfgutils_admin.xml
---
Diff: https://…
[View More]github.com/kamailio/kamailio/commit/235591cd704529589bbde700b6232ac…
Patch: https://github.com/kamailio/kamailio/commit/235591cd704529589bbde700b6232ac…
---
diff --git a/src/modules/cfgutils/doc/cfgutils_admin.xml b/src/modules/cfgutils/doc/cfgutils_admin.xml
index 1cab1284fd5..35721e31c6d 100644
--- a/src/modules/cfgutils/doc/cfgutils_admin.xml
+++ b/src/modules/cfgutils/doc/cfgutils_admin.xml
@@ -485,10 +485,10 @@ if(is_gflag("4"))
</example>
</section>
<section id="cfgutils.f.lock">
- <title><function moreinfo="none">lock(key)</function></title>
+ <title><function moreinfo="none">lock(key [, key2])</function></title>
<para>
Lock the key. Can be used to synchronize operations in config file,
- a hash id is computed over the key and appropriate lock is set in the
+ a hash id is computed over the keys and appropriate lock is set in the
lock array controlled by parameter "lock_set_size". Do not use lock()
after another lock() unless you are sure the keys hit different array
entries.
@@ -497,6 +497,9 @@ if(is_gflag("4"))
<quote>key</quote> can be static string or string with PVs.
</para>
<para>
+ <quote>key2</quote> is optional and can be static string or string with PVs.
+ </para>
+ <para>
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
</para>
@@ -510,7 +513,7 @@ lock("$rU");
</example>
</section>
<section id="cfgutils.f.trylock">
- <title><function moreinfo="none">trylock(key)</function></title>
+ <title><function moreinfo="none">trylock(key [, key2])</function></title>
<para>
Try to lock the key. If the lock can not be obtained (possibly already locked),
the function returns an error and script execution continues.
@@ -519,6 +522,9 @@ lock("$rU");
<quote>key</quote> can be static string or string with PVs.
</para>
<para>
+ <quote>key2</quote> is optional and can be static string or string with PVs.
+ </para>
+ <para>
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
</para>
@@ -535,7 +541,7 @@ if (trylock("$rU")) {
</example>
</section>
<section id="cfgutils.f.unlock">
- <title><function moreinfo="none">unlock(key)</function></title>
+ <title><function moreinfo="none">unlock(key [, key2])</function></title>
<para>
Unlock the key.
</para>
@@ -543,6 +549,9 @@ if (trylock("$rU")) {
<quote>key</quote> can be static string or string with PVs.
</para>
<para>
+ <quote>key2</quote> is optional and can be static string or string with PVs.
+ </para>
+ <para>
This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
ONREPLY_ROUTE, BRANCH_ROUTE and LOCAL_ROUTE.
</para>
@@ -854,4 +863,3 @@ if (rand_event()) {
</section>
</section>
</chapter>
-
[View Less]
Module: kamailio
Branch: master
Commit: 7bc702b79bb07901c0925c9842b75ad3d818b4e1
URL: https://github.com/kamailio/kamailio/commit/7bc702b79bb07901c0925c9842b75ad…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-04-14T15:46:26+02:00
modules: readme files regenerated - htable ... [skip ci]
---
Modified: src/modules/htable/README
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]7bc702b79bb07901c0925c9842b75ad…
Patch: https://github.com/kamailio/kamailio/commit/7bc702b79bb07901c0925c9842b75ad…
---
diff --git a/src/modules/htable/README b/src/modules/htable/README
index 4520bce8333..75f47f5f445 100644
--- a/src/modules/htable/README
+++ b/src/modules/htable/README
@@ -851,6 +851,7 @@ sht_rm_value_re("ha=>.*");
The op parameter can be:
* re - match the val parameter as regular expression.
* sw - match the val parameter as 'starts with'.
+ * ew - match the val parameter as 'ends with'.
All parameters can be static strings or contain variables.
@@ -869,6 +870,7 @@ sht_rm_name("ha", "re", ".*");
The op parameter can be:
* re - match the val parameter as regular expression.
* sw - match the val parameter as 'starts with'.
+ * ew - match the val parameter as 'ends with'.
All parameters can be static strings or contain variables.
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3799
#### Description
<!-- Describe your changes in detail -->
This PR fixes the unknown address family when calling `corex.list_sockets` rpc call by providing the correct argument (address.af) to `get_af_name()` instead of proto.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3811
-- Commit Summary --
* corex: Fix unknown af in list_sockets
-- File Changes --
M src/modules/corex/corex_rpc.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3811.patchhttps://github.com/kamailio/kamailio/pull/3811.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3811
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3811(a)github.com>
[View Less]
### Description
After installing kamailio on Ubuntu (20.04 and 22.04) using normal kamailio.org instructions, things work fine. However, a developer is working on a large project as root, and occasionally restarts kamailio with the command "kamctl <start|stop|restart>", rather than the OS command "systemctl <stop|start|restart> kamailio". After that, any attempt to restart or check status using systmectl fails, and rebooting the server occasionally fails to restart kamailio.
##…
[View More]# Troubleshooting
#### Reproduction
Install ubuntu 22.04 or 20.04. When up and running, try this:
`systemctl status kamailio` (everything looks good)
`ps -C kamailio -o comm,uid,euid,pid,ppid` (all happy, Kamailio running as user kamailio)
`kamctl restart`
`ps -C kamailio -o comm,uid,euid,pid,ppid` (Yes it's running, but as root, not kamailio)
`systemctl status kamailio` (FAILS, 20.04 reports "Failed to start", 22.04 reports "kamailio.service: Deactivated successfully")
`systemctl restart kamailio` (FAILS - same reports as preceding "status" command)
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
After command systemctl restart kamailio:
```
Feb 9 18:30:02 usdc2-lab-drproxy02 kamailio: INFO: <core> [core/sctp_core.c:74]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module
Feb 9 18:30:02 usdc2-lab-drproxy02 kamailio: INFO: <core> [core/tcp_main.c:5042]: init_tcp(): using epoll_lt as the io watch method (auto detected)
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: rr [rr_mod.c:177]: mod_init(): outbound module not available
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: auth [auth_mod.c:345]: mod_init(): qop set, but nonce-count (nc_enabled) support disabled
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [main.c:2779]: main(): processes (at least): 32 - shm size: 67108864 - pkg size: 8388608
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: ERROR: <core> [core/tcp_main.c:3162]: tcp_init(): bind(c, 0x7f49b0475c74, 16) on 127.0.0.1:5060 : Address already in use
Feb 9 18:30:02 usdc2-lab-drproxy02 /usr/sbin/kamailio[2388]: INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
Modify kamctl et. al. to call systemctl for start, stop, restart commands. Alternatively have kamctl call setuid() before start, restart, stop commands.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
On ubuntu 20.04:
```
version: kamailio 5.3.2 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 9.2.1
```
For ubuntu 22.04:
```
version: kamailio 5.6.5 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 11.4.0
```
* **Operating System**:
For ubuntu 22.04:
```
root@my_22.04_ubuntu:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.04.3 LTS
Release: 22.04
Codename: jammy
root@my_22.04_ubuntu:~# uname -a
Linux my_22.04_ubuntu 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
root@my_22.04_ubuntu:~#
```
For ubuntu 20.04
```
root@my_20.04_ubuntu:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 20.04.6 LTS
Release: 20.04
Codename: focal
root@my_20.04_ubuntu:~# uname -a
Linux my_20.04_ubuntu 5.4.0-171-generic #189-Ubuntu SMP Fri Jan 5 14:23:02 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
root@my_20.04_ubuntu:~#
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3752
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3752(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR aims to add support for PRT queries in ipops module.
Some functions were modified to accommodate and reuse the structures already defined for DNS.
Any feedback is appreciated!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3802
-- Commit Summary --
* ipops: Move structures to header
* ipops: Add PTR query support
-- File Changes --
M src/modules/ipops/ipops_mod.c (30)
M src/modules/ipops/ipops_pv.c (162)
M src/modules/ipops/ipops_pv.h (33)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3802.patchhttps://github.com/kamailio/kamailio/pull/3802.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3802(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 812ad6eb4e49426197e2860b89b255fffb018b5a
URL: https://github.com/kamailio/kamailio/commit/812ad6eb4e49426197e2860b89b255f…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2024-04-09T13:32:46+03:00
ipops: Add brief comment for ptr_query
---
Modified: src/modules/ipops/ipops_mod.c
Modified: src/modules/ipops/ipops_pv.c
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/812ad6eb4e49426197e2860b89b255f…
Patch: https://github.com/kamailio/kamailio/commit/812ad6eb4e49426197e2860b89b255f…
---
diff --git a/src/modules/ipops/ipops_mod.c b/src/modules/ipops/ipops_mod.c
index ea2669d2a19..60fd514d4fb 100644
--- a/src/modules/ipops/ipops_mod.c
+++ b/src/modules/ipops/ipops_mod.c
@@ -1298,7 +1298,18 @@ static int ki_dns_query(sip_msg_t *msg, str *naptrname, str *pvid)
}
/**
+ *! \brief Return 1 (true) if the given `ip` IP address (string or pv)
+ * could successfully be resolved to a domain and saved into `pv_name` pv.
+ * Otherwise, return negative values depending on the error.
*
+ * \param[in] msg SIP message structure.
+ * \param[in] ip IP address (string or pv) to resolve.
+ * \param[in] pv_name PV name to save the resolved domain.
+ * \returns 1 on success.
+ * \returns negative values depending on the error:
+ * \retval 1 success.
+ * \retval res -1 to -5 for bad input.
+ * \retval -6 for error in resolving the domain.
*/
static int w_ptr_query(sip_msg_t *msg, char *ip, char *pv_name)
{
diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c
index 10447e84bcd..034ec696594 100644
--- a/src/modules/ipops/ipops_pv.c
+++ b/src/modules/ipops/ipops_pv.c
@@ -413,8 +413,16 @@ int dns_update_pv(str *hostname, str *name)
return 1;
}
-/*
-*
+/**
+ * \brief Updates the pointer (PTR) record for a given IP address and saves it into pv.
+ *
+ * \details This function updates the PTR record for a specified IP address, and saves it
+ * into `name` AVP encapsulated in $ptrquery pv.
+ * It performs a reverse DNS lookup to obtain the hostname corresponding to the IP address.
+ *
+ * @param ip_address The IP address to update the PTR record for.
+ * @param name The name of AVP to hold the information in $ptrquery pv.
+ * @return 1 on success, or a negative value on failure.
*/
int ptr_update_pv(str *ip_address, str *name)
{
[View Less]
Module: kamailio
Branch: 5.8
Commit: 215af59832efc6e485563b55e3af9d209121d0c5
URL: https://github.com/kamailio/kamailio/commit/215af59832efc6e485563b55e3af9d2…
Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Committer: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Date: 2024-04-08T12:47:20+03:00
pdb server: allow carrier id 0
(cherry-picked from commit 60ded00a3b574a08457a696334d11d668595cc0b)
---
Modified: utils/pdbt/common.h
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/215af59832efc6e485563b55e3af9d2…
Patch: https://github.com/kamailio/kamailio/commit/215af59832efc6e485563b55e3af9d2…
---
diff --git a/utils/pdbt/common.h b/utils/pdbt/common.h
index 2146109a29d..a014e7d97e4 100644
--- a/utils/pdbt/common.h
+++ b/utils/pdbt/common.h
@@ -36,7 +36,7 @@
-1000..-1 used in dtm to indicate a carrier id and that no more nodes will follow (leaf node compression).
-1001 used in dtm to mark a pointer to a child node as NULL.
*/
-#define MIN_PDB_CARRIERID 1
+#define MIN_PDB_CARRIERID 0
#define MAX_PDB_CARRIERID 999
#define OTHER_CARRIERID 1000
#define MAX_CARRIERID 1000
[View Less]
Module: kamailio
Branch: 5.7
Commit: 46cf3559f4847b00790c043de41699b6c16f4920
URL: https://github.com/kamailio/kamailio/commit/46cf3559f4847b00790c043de41699b…
Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Committer: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Date: 2024-04-08T12:46:54+03:00
pdb server: allow carrier id 0
(cherry-picked from commit 60ded00a3b574a08457a696334d11d668595cc0b)
---
Modified: utils/pdbt/common.h
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/46cf3559f4847b00790c043de41699b…
Patch: https://github.com/kamailio/kamailio/commit/46cf3559f4847b00790c043de41699b…
---
diff --git a/utils/pdbt/common.h b/utils/pdbt/common.h
index 7d121430f1b..e10e2d11658 100644
--- a/utils/pdbt/common.h
+++ b/utils/pdbt/common.h
@@ -32,7 +32,7 @@
-1000..-1 used in dtm to indicate a carrier id and that no more nodes will follow (leaf node compression).
-1001 used in dtm to mark a pointer to a child node as NULL.
*/
-#define MIN_PDB_CARRIERID 1
+#define MIN_PDB_CARRIERID 0
#define MAX_PDB_CARRIERID 999
#define OTHER_CARRIERID 1000
#define MAX_CARRIERID 1000
[View Less]
Module: kamailio
Branch: 5.6
Commit: 2a6f18aaf08d87c71c530a14ebae17d211ae8a25
URL: https://github.com/kamailio/kamailio/commit/2a6f18aaf08d87c71c530a14ebae17d…
Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Committer: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro>
Date: 2024-04-08T12:46:21+03:00
pdb server: allow carrier id 0
(cherry-picked from commit 60ded00a3b574a08457a696334d11d668595cc0b)
---
Modified: utils/pdbt/common.h
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/2a6f18aaf08d87c71c530a14ebae17d…
Patch: https://github.com/kamailio/kamailio/commit/2a6f18aaf08d87c71c530a14ebae17d…
---
diff --git a/utils/pdbt/common.h b/utils/pdbt/common.h
index 7d121430f1b..e10e2d11658 100644
--- a/utils/pdbt/common.h
+++ b/utils/pdbt/common.h
@@ -32,7 +32,7 @@
-1000..-1 used in dtm to indicate a carrier id and that no more nodes will follow (leaf node compression).
-1001 used in dtm to mark a pointer to a child node as NULL.
*/
-#define MIN_PDB_CARRIERID 1
+#define MIN_PDB_CARRIERID 0
#define MAX_PDB_CARRIERID 999
#define OTHER_CARRIERID 1000
#define MAX_CARRIERID 1000
[View Less]
### Description
Kamailio segfaults when KEMI functions are invoked from app_python script
### Troubleshooting
The same code was running ok with the 5.6 branch.
It seems that the function sr_apy_kemi_exec_func_ex has been re-written in 5.7 with the following main changes :
- The long IF/ELSE statement was replace by a FOR loop
- The call to PyArg_ParseTuple function was replaced by the call to PyList_GetItem ==> **This seems to be the cause. The value returned by this function is alway …
[View More]NULL**
#### Reproduction
Any call to KSR.pv.seti function from a PYTHON 2 script would cause this error.
#### Log Messages
```
sbin/kamailio[18449]: ERROR: app_python [apy_kemi.c:280]: sr_apy_kemi_exec_func_ex(): null parameter - func: seti idx: 0 argc:
2
Feb 6 11:34:16 .../sbin/kamailio[18509]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 37
Feb 6 11:34:16 .../sbin/kamailio[18380]: ALERT: <core> [main.c:793]: handle_sigs(): child process 18449 exited by a signal 11
Feb 6 11:34:16 .../sbin/kamailio[18380]: ALERT: <core> [main.c:796]: handle_sigs(): core was not generated
Feb 6 11:34:16 .../sbin/kamailio[18380]: INFO: <core> [main.c:818]: handle_sigs(): terminating due to SIGCHLD
Feb 6 11:34:16 .../sbin/kamailio[18509]: INFO: <core> [main.c:874]: sig_usr(): signal 15 received
Feb 6 11:34:16 .../sbin/kamailio[18502]: INFO: <core> [main.c:874]: sig_usr(): signal 15 received
Feb 6 11:34:16 .../sbin/kamailio[18495]: INFO: <core> [main.c:874]: sig_usr(): signal 15 received
Feb 6 11:34:16 .../sbin/kamailio[18482]: INFO: <core> [main.c:874]: sig_usr(): signal 15 received
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3746
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3746(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 9b3b8ec968c6f7bda0d10a0d4fe593a92560ee7d
URL: https://github.com/kamailio/kamailio/commit/9b3b8ec968c6f7bda0d10a0d4fe593a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-04-06T08:35:19+02:00
corex: docs for dns_file parameter
---
Modified: src/modules/corex/doc/corex_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/9b3b8ec968c6f7bda0d10a0d4fe593a……
[View More]
Patch: https://github.com/kamailio/kamailio/commit/9b3b8ec968c6f7bda0d10a0d4fe593a…
---
diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml
index d5cfe1db477..3cdad0aa2a5 100644
--- a/src/modules/corex/doc/corex_admin.xml
+++ b/src/modules/corex/doc/corex_admin.xml
@@ -162,6 +162,41 @@ modparam("corex", "alias_subdomains", "udp:sip-router.org:5060")
modparam("corex", "dns_cache", "type=A;name=kamailio.org;addr=193.22.119.66;ttl=3600000;flags=0")
modparam("corex", "dns_cache", "type=AAAA;name=kamailio.org;addr=2a00:d60:0:400::2;ttl=3600000;flags=0")
...
+</programlisting>
+ </example>
+ </section>
+ <section id="corex.p.dns_file">
+ <title><varname>dns_file</varname> (string)</title>
+ <para>
+ Path to the file from where to load dns_cache records. It can be set
+ many times to add more than one file.
+ </para>
+ <para>
+ Inside the file, the dns_cache record has to be in a single line, with
+ the format of the dns_cache module parameter (see above). Empty lines
+ or lines with whitespaces only are ignored. Comment lines have to start
+ with '#'. Comments are not accepted after dns_cache records, only on
+ separate lines.
+ </para>
+ <para>
+ <emphasis>
+ Default value is <quote>NULL</quote>.
+ </emphasis>
+ </para>
+ <example>
+ <title>Set <varname>dns_file</varname> parameter</title>
+ <programlisting format="linespecific">
+...
+# content of /etc/kamailio/kamailio-cache.dns
+
+# IPv4 record
+type=A;name=kamailio.org;addr=193.22.119.66;ttl=3600000;flags=0
+# IPv6 record
+type=AAAA;name=kamailio.org;addr=2a00:d60:0:400::2;ttl=3600000;flags=0
+...
+...
+modparam("corex", "dns_file", "/etc/kamailio/kamailio-cache.dns")
+...
</programlisting>
</example>
</section>
@@ -1291,4 +1326,3 @@ sub do_uncompress() {
</example>
</section>
</chapter>
-
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
I want to read params from environment, so define
#!defenv MYSQL_IP
#!trydef DBURL "mysql://kamailio:kamailio@MYSQL_IP/kamailio"
but It can't read this ”MYSQL_IP“。
root@d2e1fcc3f89e:/# env |grep MYSQL*
MYSQL_URL=172.16.4.111
MYSQL_IP=172.16.4.111
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
0(34) ERROR: db_mysql [km_my_con.c:166]: db_mysql_new_connection(): driver error: Unknown server host 'MYSQL_IP' (-2)
0(34) ERROR: <core> [db.c:324]: db_do_init2(): could not add connection to the pool
0(34) ERROR: dispatcher [dispatch.c:955]: ds_connect_db(): cannot initialize db connection
0(34) ERROR: dispatcher [dispatch.c:989]: ds_init_db(): unable to connect to the database
0(34) ERROR: dispatcher [dispatcher.c:439]: mod_init(): could not initiate a connect to the database
0(34) ERROR: <core> [core/sr_module.c:1030]: init_mod(): Error while initializing module dispatcher (/usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.7.4 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 12.2.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
cat /proc/version
Linux version 3.10.0-1160.105.1.el7.x86_64 (mockbuild(a)kbuilder.bsys.centos.org) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC) ) #1 SMP Thu Dec 7 15:39:45 UTC 2023
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3800
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3800(a)github.com>
[View Less]
### Description
All kamailio versions on the 5.7.x train and additionally point release 5.6.5 break early dialog transactions, at least when the following conditions are (cumulatively) met:
* topos-redis is enabled (haven't tested other storage backends yet, let me know if needed)
* kamailio is multihomed
* enable_double_rr is enabled (the default)
### Troubleshooting
#### SIP Traffic
Here's an exchange demonstrating the problem:
```
kamailio instance
──────────┬───────────────…
[View More]───┬─────────
internal external peer
172.30.154.1:5060 185.73.43.241:5060 195.167.21.66:5060
──────────┬──────────────────┬───────── ──────────┬─────────
│ │ │
│ │ │
│ │ │
│ │ │
│ │ │
│ │ │
│ │ │
│ │ │
│ │ INVITE (SDP) │
│ │ ──────────────────────────> │
│ │ 100 Trying │
│ │ <────────────────────────── │
│ │ 183 Session Progress (SDP) │
│ │ <────────────────────────── │
│ │ PRACK │
│ │ ──────────────────────────> │
│ │ 200 OK │
│ │ <────────────────────────── │
│ │ UPDATE (SDP) │
UPDATE (SDP) │ │
<─────────────────────────── │ │
```
Whereas the expected behaviour should be:
```
│ │ UPDATE (SDP) │
| <────────────────────────── │
UPDATE (SDP)│ │ │
<───────── │ │ │
```
This is also exemplified by examining the Via headers as rewritten by kamailio.
Not working (>= 5.6.5, 5.7.x):
* Inbound Via: `Via: SIP/2.0/UDP 195.167.21.66:5060;branch=z9hG4bKtjlwcpvfh03epe0thhtjhq3qg;Role=3;Hpt=8e58_16`
* Oubound Via: `Via: SIP/2.0/UDP 185.73.43.241;branch=z9hG4bK66c4.3453dd9a219858819d528b9da671e39e.0`
Working (5.6.4):
* Inbound Via: `Via: SIP/2.0/UDP 195.167.21.66:5060;branch=z9hG4bK8lj1ahz6npz65khd8jkzl1ohh;Role=3;Hpt=8e68_16`
* Oubound Via: `Via: SIP/2.0/UDP 172.30.154.1;branch=z9hG4bK4dce.4f5448efd64465fa5dbaf5eef0dc35b7.0`
### Possible Solutions
Only solution I have found so far is to downgrade to kamailio 5.6.4
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
```
version: kamailio 5.7.4 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 10.2.1
```
But I have also tested all 5.7.x versions, which are all affected, as well 5.6.5.
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Linux host 5.10.0-27-amd64 #1 SMP Debian 5.10.205-2 (2023-12-31) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3757
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3757(a)github.com>
[View Less]
I'm trying to build current git sources on ArchLinux.
`modules/app_python/Makefile` still asks for python2:
```
which: no python2 in ($PATH)
which: no python2.7 in ($PATH)
File "<string>", line 1
import distutils.sysconfig;print distutils.sysconfig.get_config_var('LIBDIR')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
```
Is this intended?
--
Reply to this email …
[View More]directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3805
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3805(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 368661cc15251af4cbf295d1f5fad5a42d1b647b
URL: https://github.com/kamailio/kamailio/commit/368661cc15251af4cbf295d1f5fad5a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-04-05T08:10:11+02:00
core: parser/sdp - function to find sdp line with start EoL check option
---
Modified: src/core/parser/sdp/sdp_helpr_funcs.c
Modified: src/core/parser/sdp/sdp_helpr_funcs.h
--…
[View More]-
Diff: https://github.com/kamailio/kamailio/commit/368661cc15251af4cbf295d1f5fad5a…
Patch: https://github.com/kamailio/kamailio/commit/368661cc15251af4cbf295d1f5fad5a…
---
diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c
index d5cb359b40f..a5dffd9c398 100644
--- a/src/core/parser/sdp/sdp_helpr_funcs.c
+++ b/src/core/parser/sdp/sdp_helpr_funcs.c
@@ -733,9 +733,10 @@ int extract_sess_version(str *oline, str *sess_version)
/*
* Auxiliary for some functions.
+ * - smode: if 1, pstart is pointing inside msg body
* Returns pointer to first character of found line, or NULL if no such line.
*/
-char *find_sdp_line(char *pstart, char *plimit, char linechar)
+char *find_sdp_line_start(char *pstart, char *plimit, char linechar, int smode)
{
static char linehead[3] = "x=";
char *cp, *cp1;
@@ -749,11 +750,14 @@ char *find_sdp_line(char *pstart, char *plimit, char linechar)
if(cp1 == NULL)
return NULL;
/*
- * As it is body, we assume it has previous line and we can
- * lookup previous character.
+ * smode==1 means it is msg body, thus it has previous line and it can
+ * lookup previous character even when cp1==pstart.
*/
- if(cp1[-1] == '\n' || cp1[-1] == '\r')
- return cp1;
+ if(cp1 > pstart || smode == 1) {
+ if(cp1[-1] == '\n' || cp1[-1] == '\r') {
+ return cp1;
+ }
+ }
/*
* Having such data, but not at line beginning.
* Skip them and reiterate. ser_memmem() will find next
@@ -765,6 +769,14 @@ char *find_sdp_line(char *pstart, char *plimit, char linechar)
}
}
+/*
+ * Auxiliary for some functions - expect pstart to point inside SIP message body.
+ * Returns pointer to first character of found line, or NULL if no such line.
+ */
+char *find_sdp_line(char *pstart, char *plimit, char linechar)
+{
+ return find_sdp_line_start(pstart, plimit, linechar, 1);
+}
/* This function assumes pstart points to a line of requested type. */
char *find_next_sdp_line(
diff --git a/src/core/parser/sdp/sdp_helpr_funcs.h b/src/core/parser/sdp/sdp_helpr_funcs.h
index e8ce6f7e60a..20d3ebd882d 100644
--- a/src/core/parser/sdp/sdp_helpr_funcs.h
+++ b/src/core/parser/sdp/sdp_helpr_funcs.h
@@ -65,6 +65,7 @@ int extract_accept_wrapped_types(str *body, str *accept_wrapped_types);
int extract_max_size(str *body, str *max_size);
int extract_path(str *body, str *path);
+char *find_sdp_line_start(char *pstart, char *plimit, char linechar, int smode);
char *find_sdp_line(char *p, char *plimit, char linechar);
char *find_next_sdp_line(char *p, char *plimit, char linechar, char *defptr);
[View Less]
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
This patch introduces a new "time" field for JSON logging to …
[View More]stderr. The CEE format already includes this field, but the Kamailio-specific format doesn't. If you need timestamps in your structured logs, but don't want to use the CEE format due to its limitations, this patch'd give you the best of both worlds.
I know this comes a little out of the blue, so any feedback is welcome.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3795
-- Commit Summary --
* core: dprint - include time in stderr json log
-- File Changes --
M src/core/dprint.c (44)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3795.patchhttps://github.com/kamailio/kamailio/pull/3795.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3795
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3795(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 3c16c13acdf95924636c4d938abe13dcb3707b73
URL: https://github.com/kamailio/kamailio/commit/3c16c13acdf95924636c4d938abe13d…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-04-04T13:01:21+02:00
modules: readme files regenerated - db_redis ... [skip ci]
---
Modified: src/modules/db_redis/README
Modified: src/modules/ndb_redis/README
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/3c16c13acdf95924636c4d938abe13d…
Patch: https://github.com/kamailio/kamailio/commit/3c16c13acdf95924636c4d938abe13d…
---
diff --git a/src/modules/db_redis/README b/src/modules/db_redis/README
index d2baa50e72d..4cfdcaa5b4f 100644
--- a/src/modules/db_redis/README
+++ b/src/modules/db_redis/README
@@ -39,7 +39,7 @@ Joel Centelles Martin
4.3. verbosity (int)
4.4. opt_tls (int)
4.5. db_pass (string)
- 4.6. ac_path (string)
+ 4.6. ca_path (string)
5. Usage
6. Module Specific Considerations
@@ -75,7 +75,7 @@ Chapter 1. Admin Guide
4.3. verbosity (int)
4.4. opt_tls (int)
4.5. db_pass (string)
- 4.6. ac_path (string)
+ 4.6. ca_path (string)
5. Usage
6. Module Specific Considerations
@@ -203,7 +203,7 @@ allid,time_hires&cid:callid
4.3. verbosity (int)
4.4. opt_tls (int)
4.5. db_pass (string)
- 4.6. ac_path (string)
+ 4.6. ca_path (string)
4.1. schema_path (string)
@@ -247,6 +247,12 @@ modparam("db_redis", "verbosity", 0)
Controls TLS usage while connecting to a remote DB. If set to 1, TLS is
used to connect to the DB.
+ If TLS is enabled, the module will validate the Redis server
+ certificate against the ca_path. There is currently no way to connect
+ with a specified client certificate, the corresponding configuration to
+ check client certificates in the Redis server must therefore be turned
+ off.
+
Default value: 0.
Example 1.4. Enabling TLS connection
@@ -265,9 +271,10 @@ modparam("db_redis", "opt_tls", 1)
modparam("db_redis", "db_pass", "r3d1sPass")
...
-4.6. ac_path (string)
+4.6. ca_path (string)
- Sets the path where Certificates Authorities certs are stored.
+ Sets the path where Certificates Authorities certs for the Redis server
+ certificate are stored.
Default value: "" (empty).
diff --git a/src/modules/ndb_redis/README b/src/modules/ndb_redis/README
index 1cdfc842db3..90071f5e3f0 100644
--- a/src/modules/ndb_redis/README
+++ b/src/modules/ndb_redis/README
@@ -55,7 +55,7 @@ Joel Centelles Martin
3.8. flush_on_reconnect (integer)
3.9. allow_dynamic_nodes (integer)
3.10. debug (integer)
- 3.11. ac_path (string)
+ 3.11. ca_path (string)
4. Functions
@@ -103,7 +103,7 @@ Chapter 1. Admin Guide
3.8. flush_on_reconnect (integer)
3.9. allow_dynamic_nodes (integer)
3.10. debug (integer)
- 3.11. ac_path (string)
+ 3.11. ca_path (string)
4. Functions
@@ -149,7 +149,7 @@ Chapter 1. Admin Guide
3.8. flush_on_reconnect (integer)
3.9. allow_dynamic_nodes (integer)
3.10. debug (integer)
- 3.11. ac_path (string)
+ 3.11. ca_path (string)
3.1. server (str)
@@ -168,6 +168,12 @@ Chapter 1. Admin Guide
many REDIS servers, just give different attributes and use the specific
server name when querying the REDIS instance.
+ If tls is enabled, the module will validate the REDIS server
+ certificate against the ca_path. There is currently no way to connect
+ with a specified client certificate, the corresponding configuration to
+ check client certificates in the REDIS server must therefore be turned
+ off.
+
Default value is NULL.
Example 1.1. Set server parameter
@@ -346,9 +352,10 @@ modparam("ndb_redis", "allow_dynamic_nodes", 1)
modparam("ndb_redis", "debug", 1)
...
-3.11. ac_path (string)
+3.11. ca_path (string)
- Sets the path where Certificates Authorities certs are stored.
+ Sets the path where Certificates Authorities certs for the REDIS server
+ certificate are stored.
Default value: "" (empty).
[View Less]
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Enhance xhttp_prom module to export pkgmem stats.
The new stats can be enabled via a …
[View More]new module parameter: `xhttp_prom_pkgmem_stats_enabled`.
Default value for the new module parameter: 0 (no pkg mem stats are generated).
Any value different then 0 will export the pkg mem statistics.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3793
-- Commit Summary --
* kex: expose access to pkg mem stats
* xhttp_prom: export pkg mem stats
-- File Changes --
A src/modules/kex/api.c (54)
A src/modules/kex/api.h (69)
M src/modules/kex/kex_mod.c (2)
M src/modules/kex/pkg_stats.c (24)
M src/modules/kex/pkg_stats.h (17)
M src/modules/xhttp_prom/prom.c (66)
M src/modules/xhttp_prom/xhttp_prom.c (44)
M src/modules/xhttp_prom/xhttp_prom.h (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3793.patchhttps://github.com/kamailio/kamailio/pull/3793.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3793(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
The created ssl context in the `db_redis` and `ndb_redis` modules does not use client certificates [1], [2] which is against the default in current Redis configurations [3]. The used Redis server therefore needs to be configured to not use tls-auth-clients [3]. Without setting this configuration in Redis, no TLS connection to the Redis server can be established, since Redis will not accept unsigned/not-validated client certificates.
There is also a small typo in "ac_path" in both docs which was fixed to "ca_path", added with some more specification to _which_ certificate is validated.
[1]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[2]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[3]: https://redis.io/docs/management/security/encryption/#client-certificate-au…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3804
-- Commit Summary --
* db_redis: docs - refine docs regarding client certificates [skip ci]
* ndb_redis: docs - refine docs regarding client certificates [skip ci]
-- File Changes --
M src/modules/db_redis/doc/db_redis_admin.xml (10)
M src/modules/ndb_redis/doc/ndb_redis_admin.xml (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3804.patchhttps://github.com/kamailio/kamailio/pull/3804.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3804
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3804(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 6faa180661e799187eff3a498f8b13e96719fa92
URL: https://github.com/kamailio/kamailio/commit/6faa180661e799187eff3a498f8b13e…
Author: Jannik Volkland <volkland(a)sipgate.de>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-04-04T12:55:38+02:00
ndb_redis: docs - refine docs regarding client certificates [skip ci]
The created ssl context does not use client certificates [1,2] which is against the default in current Redis …
[View More]configurations [3]. The used Redis server therefore needs to be configured to not use tls-auth-clients [3].
There is also a small typo in "ac_path" which was fixed to "ca_path".
[1]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[2]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[3]: https://redis.io/docs/management/security/encryption/#client-certificate-au…
---
Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/6faa180661e799187eff3a498f8b13e…
Patch: https://github.com/kamailio/kamailio/commit/6faa180661e799187eff3a498f8b13e…
---
diff --git a/src/modules/ndb_redis/doc/ndb_redis_admin.xml b/src/modules/ndb_redis/doc/ndb_redis_admin.xml
index 74d35c75cc9..024b01315ac 100644
--- a/src/modules/ndb_redis/doc/ndb_redis_admin.xml
+++ b/src/modules/ndb_redis/doc/ndb_redis_admin.xml
@@ -75,6 +75,12 @@
many REDIS servers, just give different attributes and use the specific
server name when querying the REDIS instance.
</para>
+ <para>
+ If tls is enabled, the module will validate the REDIS server certificate against the
+ ca_path. There is currently no way to connect with a specified client certificate, the
+ <ulink url="https://redis.io/docs/management/security/encryption/#client-certificate-au…">corresponding configuration</ulink>
+ to check client certificates in the REDIS server must therefore be turned off.
+ </para>
<para>
<emphasis>
Default value is NULL.
@@ -330,9 +336,9 @@ modparam("ndb_redis", "debug", 1)
</example>
</section>
<section id="ndb_redis.p.ca_path">
- <title><varname>ac_path</varname> (string)</title>
+ <title><varname>ca_path</varname> (string)</title>
<para>
- Sets the path where Certificates Authorities certs are stored.
+ Sets the path where Certificates Authorities certs for the REDIS server certificate are stored.
</para>
<para>
Default value: "" (empty).
[View Less]
Module: kamailio
Branch: master
Commit: 40a50243f0bae782b7acd97cf0a9b1138185068b
URL: https://github.com/kamailio/kamailio/commit/40a50243f0bae782b7acd97cf0a9b11…
Author: Jannik Volkland <volkland(a)sipgate.de>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-04-04T12:55:38+02:00
db_redis: docs - refine docs regarding client certificates [skip ci]
The created ssl context does not use client certificates [1,2] which is against the default in current Redis …
[View More]configurations [3]. The used Redis server therefore needs to be configured to not use tls-auth-clients [3].
There is also a small typo in "ac_path" which was fixed to "ca_path".
[1]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[2]: https://github.com/kamailio/kamailio/blob/8047c958b42ea5af2e8f9ede0152f892a…
[3]: https://redis.io/docs/management/security/encryption/#client-certificate-au…
---
Modified: src/modules/db_redis/doc/db_redis_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/40a50243f0bae782b7acd97cf0a9b11…
Patch: https://github.com/kamailio/kamailio/commit/40a50243f0bae782b7acd97cf0a9b11…
---
diff --git a/src/modules/db_redis/doc/db_redis_admin.xml b/src/modules/db_redis/doc/db_redis_admin.xml
index a7e7c3bb3a9..15ed0ca61e2 100644
--- a/src/modules/db_redis/doc/db_redis_admin.xml
+++ b/src/modules/db_redis/doc/db_redis_admin.xml
@@ -224,6 +224,12 @@ modparam("db_redis", "verbosity", 0)
Controls TLS usage while connecting to a remote DB.
If set to 1, TLS is used to connect to the DB.
</para>
+ <para>
+ If TLS is enabled, the module will validate the Redis server certificate against the
+ ca_path. There is currently no way to connect with a specified client certificate, the
+ <ulink url="https://redis.io/docs/management/security/encryption/#client-certificate-au…">corresponding configuration</ulink>
+ to check client certificates in the Redis server must therefore be turned off.
+ </para>
<para>
Default value: 0.
</para>
@@ -256,9 +262,9 @@ modparam("db_redis", "db_pass", "r3d1sPass")
</section>
<section id="db_redis.p.ca_path">
- <title><varname>ac_path</varname> (string)</title>
+ <title><varname>ca_path</varname> (string)</title>
<para>
- Sets the path where Certificates Authorities certs are stored.
+ Sets the path where Certificates Authorities certs for the Redis server certificate are stored.
</para>
<para>
Default value: "" (empty).
[View Less]
Hello,
Kamailio SIP Server v5.8.1 stable release is out.
This is a maintenance release of the latest stable branch, 5.8, that
includes fixes since the release of v5.8.0. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.8.x. Deployments running previous v5.8.x
versions are strongly recommended to be upgraded to v5.8.1.
For more details about version 5.8.1 (including links and guidelines to
download the tarball or …
[View More]from GIT repository), visit:
* https://www.kamailio.org/w/2024/04/kamailio-v5-8-1-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com
[View Less]
Hello,
with many countries having public holidays around Catholic Easter, I am
considering to release Kamailio v5.8.1 (out of branch 5.8) on Wednesday,
April 3, 2024. If anyone is aware of issues not yet on the bug tracker,
report them there asap in order to have a better chance to be fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio World Conference,…
[View More] April 18-19, 2024, Berlin -- kamailioworld.com
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
When we use DNS failover in case of timeout kamailio executes the branch_failure route. In the case of the 503 - on_reply route. This commit is to equate behavior in both cases. So if there are more candidates we will always execute branch_failure route and on_reply route only if this is the last candidate.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3138
-- Commit Summary --
* branch_failure route in case 503 and dns failover
-- File Changes --
M src/modules/tm/t_reply.c (52)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3138.patchhttps://github.com/kamailio/kamailio/pull/3138.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3138
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3138(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/…
[View More]postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
Note that a feature request may be closed automatically after about 2 months
if there is no interest from developers or community users to implement it, being
considered expired. In such case can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the item is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in the proposed feature request.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Consider adding socket options SO_BINDTODEVICE when the interface name is given for listening in the config file. This will be useful in listening to linux VRF interfaces, especially when there are two different VRFs and it is required to proxy SIP messages between the VRFs
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3716
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3716(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 2063993c1ae54c07b39ea9deb8f735a47785c0ee
URL: https://github.com/kamailio/kamailio/commit/2063993c1ae54c07b39ea9deb8f735a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-03-29T11:13:48+01:00
core: added fixup_spve1_pvar() helper
- comments to spveX pvar fixup helpers
---
Modified: src/core/mod_fix.c
Modified: src/core/mod_fix.h
---
Diff: https://github.com/…
[View More]kamailio/kamailio/commit/2063993c1ae54c07b39ea9deb8f735a…
Patch: https://github.com/kamailio/kamailio/commit/2063993c1ae54c07b39ea9deb8f735a…
---
diff --git a/src/core/mod_fix.c b/src/core/mod_fix.c
index 0947f788461..bba3a469028 100644
--- a/src/core/mod_fix.c
+++ b/src/core/mod_fix.c
@@ -728,7 +728,9 @@ int fixup_free_spve_spve_igp(void **param, int param_no)
}
/**
- *
+ * - first params are dynamic strings (spve)
+ * - n - how many params are spve; n+1 is name of pv
+ * - if pvmode==1, the last param pv has to be r/w
*/
int fixup_spve_n_pvar(void **param, int n, int param_no, int pvmode)
{
@@ -768,6 +770,15 @@ int fixup_spve_pvar(void **param, int param_no)
return fixup_spve_n_pvar(param, 1, param_no, 0);
}
+/**
+ * - first params are dynamic strings
+ * - last param pv has to be r/w
+ */
+int fixup_spve1_pvar(void **param, int param_no)
+{
+ return fixup_spve_n_pvar(param, 1, param_no, 1);
+}
+
/**
*
*/
@@ -777,7 +788,8 @@ int fixup_free_spve_pvar(void **param, int param_no)
}
/**
- *
+ * - first params are dynamic strings
+ * - last param pv has to be r/w
*/
int fixup_spve2_pvar(void **param, int param_no)
{
@@ -793,7 +805,8 @@ int fixup_free_spve2_pvar(void **param, int param_no)
}
/**
- *
+ * - first params are dynamic strings
+ * - last param pv has to be r/w
*/
int fixup_spve3_pvar(void **param, int param_no)
{
@@ -809,7 +822,8 @@ int fixup_free_spve3_pvar(void **param, int param_no)
}
/**
- *
+ * - first params are dynamic strings
+ * - last param pv has to be r/w
*/
int fixup_spve4_pvar(void **param, int param_no)
{
diff --git a/src/core/mod_fix.h b/src/core/mod_fix.h
index a202c4ade2b..d3f954fb1c2 100644
--- a/src/core/mod_fix.h
+++ b/src/core/mod_fix.h
@@ -147,6 +147,7 @@ int fixup_free_igp_all(void **param, int param_no);
int fixup_spve_igp(void **param, int param_no);
int fixup_free_spve_igp(void **param, int param_no);
int fixup_spve_pvar(void **param, int param_no);
+int fixup_spve1_pvar(void **param, int param_no);
int fixup_free_spve_pvar(void **param, int param_no);
int fixup_spve2_pvar(void **param, int param_no);
int fixup_free_spve2_pvar(void **param, int param_no);
[View Less]
While testing I noticed a strange behavior.
Usually when activated, `sipdump.enable 1` for the specific interface will dump needed logs and captures to `/tmp/`.
After stopping the dump with `sipdump.enable 0` deleting all captures starting with `kamailio.*` under `/tmp/` and reactivating the dump with `sipdump.enable 1` without restarting kamailio, the service will not create new captures under `/tmp/`.
This behavior was reproducible.
--
Reply to this email directly or view it on GitHub:
…
[View More]https://github.com/kamailio/kamailio/issues/3798
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3798(a)github.com>
[View Less]
### Description
Unable to upgrade Kamailio 5.7 on CentOS7
Error:
```
tls_mod.c: In function ‘fork_child’:
tls_mod.c:348:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
for(int k = 0; k < 16; k++) {
^
tls_mod.c:348:2: note: use option -std=c99 or -std=gnu99 to compile your code
make[2]: *** [tls_mod.o] Error 1
make[1]: *** [modules] Error 1
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
Current installed version:
```
version: …
[View More]kamailio 5.7.4 (x86_64/linux) 2e6e87
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3796
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3796(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3796 (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR fixes the compiles error regarding initial declarations in `for` loops
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3797
-- Commit Summary --
* tls: Fix ‘for’ loop initial declarations error
* file_out: FIx ‘for’ loop initial declarations error
-- File Changes --
M src/modules/file_out/file_out.c (11)
M src/modules/tls/tls_mod.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3797.patchhttps://github.com/kamailio/kamailio/pull/3797.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3797
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3797(a)github.com>
[View Less]
### Description
Kamailio v5.5.6 with topos module and postgres DB.
UAC (A) -> Kamailio Registrar (B) -> Kamailio PSTN GW (C) -> PSTN (D)
Call goes from A to D, PSTN sends UPDATE, UPDATE is routed from C to A instead to B and then to A.
#### Reproduction
Caller calls callee and receives an UPDATE from callee.
In my case it was when the call was routed to voicemail.
#### Log Messages
```
Kamailio takes the wrong route in UPDATE (upstream) case.
May 3 15:23:12 sipproxy /usr/sbin/…
[View More]kamailio[263013]: DEBUG: topos [tps_msg.c:882]: tps_request_received(): r-uri updated to: [sip:1234@<UAC-IP>;uniq=B0EB9A84A278626DA07219E2AE01C]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: topos [tps_msg.c:187]: tps_add_headers(): adding to headers(0) - [Route: sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes#015#012]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: topos [tps_msg.c:187]: tps_add_headers(): adding to headers(0) - [P-SR-XUID: atpsh-64527b0a-40362-1#015#012]
The right one would be the x_rr (a_rr), but it takes only the s_rr:
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,7)=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][7] Column[x_rr]=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,8)=[sip:<PSTNgw>:5060;transport=udp;lr;Hpt=8ef8_116;CxtId=3;TRC=ffffffff-ffffffff;X-HwB2bUaCookie=18614]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][8] Column[y_rr]=[sip:<PSTNgw>:5060;transport=udp;lr;Hpt=8ef8_116;CxtId=3;TRC=ffffffff-ffffffff;X-HwB2bUaCookie=18614]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,9)=[sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][9] Column[s_rr]=[sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263019]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][10] Column[a_rr]=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92]
May 3 15:23:12 sipproxy /usr/sbin/kamailio[263019]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893dbd8,0,11)=[]
```
### Possible Solutions
Respect Route headers for UPDATE messages.
### Additional Information
Current running kamailio 5.5.6 but tried also latest 5.6.4 with same behavior.
```
version: kamailio 5.5.6 (x86_64/linux) 72dbb0
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 72dbb0
compiled on 05:48:21 Apr 27 2023 with gcc 11.3.0
```
* **Operating System**:
```
Distributor ID: Ubuntu
Description: Ubuntu 22.04.2 LTS
Release: 22.04
Codename: jammy
Linux sipproxy 5.15.0-70-generic #77-Ubuntu SMP Tue Mar 21 14:02:37 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
```
Possibly related bug: https://github.com/kamailio/kamailio/issues/3090
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3437
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3437(a)github.com>
[View Less]
Hi,
I would like to move app_lua_sr to kamailio-archive but I would like to hear if anyone out there has a solid reason not to do it. Since we have app_lua as KEMI for a long time I think is time to retire the old remains of app_lua
Cheers
--
-----------------------------------------------------------------
| ,''`. Victor Seva |
| : :' : linuxmaniac(a)torreviejawireless.org |
| `. `' PGP: 8F19 CADC D42A 42D4 5563 730C …
[View More]51A0 9B18 CF5A 5068 |
| `- Debian Developer |
-----------------------------------------------------------------
[View Less]
Module: kamailio
Branch: 5.7
Commit: 822960b0e869b5fce093f708daf65b9f4b4c47f8
URL: https://github.com/kamailio/kamailio/commit/822960b0e869b5fce093f708daf65b9…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2024-03-23T21:09:14+08:00
tls: basic OpenSSL 3 support of provider keys (replaces ENGINE)
- initial support for v3 provider keys (replaces ENGINE from v1.1.1)
- can be disabled behind build flag -DOPENSSL_NO_PROVIDER
- …
[View More]provider keys start with /uri: e.g
private_key = /uri:pkcs11:token=NSS%20Certificate%20DB;type=private;object=Fork-Test-c67cc0e0
- global config:
provider_quirks: 0 | 1
- 0 - default
- 1 - create a new OSS_LIB_CTX* in the child
This integration does not load any providers itself and depends on
the usual
export OPENSSL_CONF=my-openssl.cnf
to configure providers.
(cherry picked from commit 69883dd381368ca219cc52140e71d571775f95d5)
---
Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/822960b0e869b5fce093f708daf65b9…
Patch: https://github.com/kamailio/kamailio/commit/822960b0e869b5fce093f708daf65b9…
[View Less]
Module: kamailio
Branch: 5.7
Commit: af524f5b2b2fa3de4aa4e198bf3a9f0feff04e17
URL: https://github.com/kamailio/kamailio/commit/af524f5b2b2fa3de4aa4e198bf3a9f0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2024-03-23T21:06:43+08:00
tlsa: removed the map files used in the past for tls engine
- sync with code of tls module
---
Removed: src/modules/tlsa/tls_map.c
Removed: src/modules/tlsa/tls_map.h
---
Diff: https://…
[View More]github.com/kamailio/kamailio/commit/af524f5b2b2fa3de4aa4e198bf3a9f0…
Patch: https://github.com/kamailio/kamailio/commit/af524f5b2b2fa3de4aa4e198bf3a9f0…
---
diff --git a/src/modules/tlsa/tls_map.c b/src/modules/tlsa/tls_map.c
deleted file mode 100644
index ad799b5cdff..00000000000
--- a/src/modules/tlsa/tls_map.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.c"
diff --git a/src/modules/tlsa/tls_map.h b/src/modules/tlsa/tls_map.h
deleted file mode 100644
index 96705a7f7fa..00000000000
--- a/src/modules/tlsa/tls_map.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/**
- * Copyright (C) 2021 Daniel-Constantin Mierla (asipto.com)
- *
- * This file is part of Kamailio, a free SIP server.
- *
- * This file is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version
- *
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- *
- */
-
-/**
- * THIS FILE IS GENERATED - DO NOT MODIFY IT
- */
-
-#include "../tls/tls_map.h"
[View Less]