- sr-dev - kamailio.org

git:master:52ab6f3d: nathelper: fixed handle_ruri_alias() for alias being an IPv6
by Dragos Vingarzan 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: 52ab6f3dcf5ad8d967be8bdecaa64ef31cbfbe33 URL: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-15T21:50:48+02:00 nathelper: fixed handle_ruri_alias() for alias being an IPv6 --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… Patch: https://github.com/kamailio/kamailio/commit/52ab6f3dcf5ad8d967be8bdecaa64ef… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 6e6d44ad7ed..9c0bebad3a7 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1139,7 +1139,7 @@ static int ki_handle_ruri_alias_mode(struct sip_msg *msg, int mode) char buf[MAX_URI_SIZE], *val, *sep, *at, *next, *cur_uri, *rest, *port, *trans, *start; unsigned int len, rest_len, val_len, alias_len, proto_type, cur_uri_len, - ip_port_len; + ip_len, ip_port_len, port_len, i; if(parse_sip_msg_uri(msg) < 0) { LM_ERR("while parsing Request-URI\n"); @@ -1185,18 +1185,46 @@ static int ki_handle_ruri_alias_mode(struct sip_msg *msg, int mode) LM_ERR("no '~' in alias param value\n"); return -1; } + // IPv6 needs some [] added when composing a SIP URI, which further + // complicates this code. + ip_len = port - val; + int is_ipv6 = 0; + for(i = 0; i < ip_len; i++) { + if(val[i] == ':') { + is_ipv6 = 1; + break; + } + } *(port++) = ':'; trans = memchr(port, 126 /* ~ */, val_len - (port - val)); if(trans == NULL) { LM_ERR("no second '~' in alias param value\n"); return -1; } + // Compose the URI in a buffer at = &(buf[0]); append_str(at, "sip:", 4); ip_port_len = trans - val; alias_len = _ksr_contact_salias.len + ip_port_len + 2 /* ~n */; - memcpy(at, val, ip_port_len); - at = at + ip_port_len; + if(is_ipv6) { + // IPv6 - add '[' ']' around IP + // then append ':' and copy the port + append_chr(at, '['); + memcpy(at, val, ip_len); + at = at + ip_len; + append_chr(at, ']'); + port_len = trans - port; + if(port_len > 0) { + append_chr(at, ':'); + memcpy(at, port, port_len); + at = at + port_len; + } + } else { + // IPv4 - copy directly as is + // separator '~' between IP and port was changed to ':' + memcpy(at, val, ip_port_len); + at = at + ip_port_len; + } trans = trans + 1; if((ip_port_len + 2 > val_len) || (*trans == ';') || (*trans == '?')) { LM_ERR("no proto in alias param\n");

1 0

[kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)
by Alexander Bakker 15 Jul '24

15 Jul '24

### Description The Debian package build fails for Kamailio 5.7.4 because it can't find static libssl. This happens because ``LIBSSL_STATIC_SRCPATH`` is set to the wrong location in the rules file. ### Troubleshooting #### Reproduction 1. Run ``ln -s pkg/kamailio/deb/bookworm debian`` 2. Run ``make deb`` #### Output ``` gcc -shared -g -m64 -Wl,-O2 -Wl,-E -Wl,-z,relro -pthread -rdynamic "-ldl" -Wl,-Bsymbolic-functions tls_bio.o tls_cfg.o tls_config.o tls_ct_wrq.o tls_domain.o tls_dump_vf.o tls_init.o tls_locking.o tls_map.o tls_rand.o tls_rpc.o tls_select.o tls_server.o tls_util.o tls_verify.o tlsa_mod.o -lm /usr/lib64/libssl.a /usr/lib64/libcrypto.a -o tlsa.so /usr/bin/ld: cannot find /usr/lib64/libssl.a: No such file or directory /usr/bin/ld: cannot find /usr/lib64/libcrypto.a: No such file or directory collect2: error: ld returned 1 exit status make[5]: *** [../../Makefile.rules:191: tlsa.so] Error 1 ``` ### Possible Solutions An extremely hacky workaround is to patch the rules file to point ``LIBSSL_STATIC_SRCPATH`` to the right location: ``` sed -i -e "/LIBSSL_STATIC_SRCPATH/a export\\ LIBSSL_STATIC_SRCPATH=\\/usr\\/lib\\/$(uname -m)-linux-gnu" pkg/kamailio/deb/bookworm/rules ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm ``` ``` Linux 6.5.0-14-generic #14-Ubuntu SMP PREEMPT_DYNAMIC Tue Nov 14 14:59:49 UTC 2023 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3722 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3722(a)github.com>

3 10

[kamailio/kamailio] No CDR is written on failover (Issue #3254)
by Earn330 15 Jul '24

15 Jul '24

Hi, I think there is an issue with writing CDRs on failover scenarios. I have two servers with Kamailio. Both server running Debian 11 (bulleye) and latest Kamailio 5.6.1 from git. I'm using DMQ to sync dialogs and htable between these servers, so both servers have the same knowledge of dialog state. Both Kamailio uses nobind option, so I can switch a VIP from one server to the other one. This is managed with keepalived. Switching the VIP from one server the other one works fine an while a call is running I can switch the VIP. I can see that the BYE Message is handled OK after I made a switch. I can see that acc is triggered but what is missing is acc_cdr in this case. I'm using htable to fill all necessary variables to complete the CDR an I can see that all values are synced correctly. The acc_cdr is created fine if there is no failover so i think it can't be an configuration issue. Both server holds the same Kamailio configuration except the IP. `version: kamailio 5.6.1 (x86_64/linux) bfc5c2-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: bfc5c2 -dirty compiled with gcc 10.2.1` `root@voip-lab-proxy01:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye` `root@voip-lab-proxy01:~# lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 38 bits physical, 48 bits virtual CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6 Model: 23 Model name: Intel(R) Xeon(R) CPU E5420 @ 2.50GHz Stepping: 10 CPU MHz: 2500.088 BogoMIPS: 5000.17 Virtualization: VT-x Hypervisor vendor: KVM Virtualization type: full L1d cache: 128 KiB L1i cache: 128 KiB L2 cache: 16 MiB L3 cache: 16 MiB NUMA node0 CPU(s): 0-3 Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Mitigation; PTE Inversion; VMX EPT disabled Vulnerability Mds: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Unknown: No mitigations Vulnerability Retbleed: Not affected Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx pdpe1gb lm constant_tsc arch_perfmon rep_good nopl xtopology cpuid tsc_known_freq pni vmx ssse3 cx16 pdcm sse4_1 x2apic tsc_deadline_timer xsave hypervisor lahf_lm cpuid_fault pti tpr_shadow vnmi flexpriority vpid tsc_adjust arat arch_capabilit ies` If you need more information, please let me know. As I'm running this on a test system I can reproduce the issue at any time. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3254(a)github.com>

5 9

[kamailio/kamailio] test (Issue #3918)
by ale5kamailio 15 Jul '24

15 Jul '24

test posting issue -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3918 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3918(a)github.com>

1 1

git:master:f92fe42d: nghttp2: free the addr info on listen failure
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: f92fe42dc6c8d3d5b79cf6543b387501a41c09b3 URL: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-15T08:24:59+02:00 nghttp2: free the addr info on listen failure --- Modified: src/modules/nghttp2/nghttp2_server.c --- Diff: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… Patch: https://github.com/kamailio/kamailio/commit/f92fe42dc6c8d3d5b79cf6543b38750… --- diff --git a/src/modules/nghttp2/nghttp2_server.c b/src/modules/nghttp2/nghttp2_server.c index 6f5faf02ad6..ba0290bc4ac 100644 --- a/src/modules/nghttp2/nghttp2_server.c +++ b/src/modules/nghttp2/nghttp2_server.c @@ -793,11 +793,11 @@ static void start_listen(struct event_base *evbase, app_context *app_ctx) (int)rp->ai_addrlen); if(listener) { freeaddrinfo(res); - return; } } LM_ERR("Could not start listener"); + freeaddrinfo(res); } static void initialize_app_context(

1 0

git:master:d5076b55: evrexec: remove unnecessary safety exit loop
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: d5076b557728b3f9d80df391ae71e2eab2c896dc URL: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 evrexec: remove unnecessary safety exit loop --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… Patch: https://github.com/kamailio/kamailio/commit/d5076b557728b3f9d80df391ae71e2e… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 3fb99535a0a..7df75654aa0 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -325,10 +325,6 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) } memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } - /* avoid exiting the process */ - while(1) { - sleep(3600); - } } /**

1 0

git:master:f2a7a3c0: dispatcher: remove unnecessary comparisons for unsigned
by Daniel-Constantin Mierla 15 Jul '24

15 Jul '24

Module: kamailio Branch: master Commit: f2a7a3c09ee881247c8a6641ec8d3b1e0e0eb812 URL: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-14T18:56:20+02:00 dispatcher: remove unnecessary comparisons for unsigned --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… Patch: https://github.com/kamailio/kamailio/commit/f2a7a3c09ee881247c8a6641ec8d3b1… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index ecd0f3a0c9d..d36141bbafd 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -408,13 +408,13 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) str2int(&pit->body, &dest->attrs.ocrate); } } - if(dest->attrs.ocmax < 0 || dest->attrs.ocmax > 100) { + if(dest->attrs.ocmax > 100) { dest->attrs.ocmax = 100; } - if(dest->attrs.ocmin < 0 || dest->attrs.ocmin > 100) { + if(dest->attrs.ocmin > 100) { dest->attrs.ocmin = 0; } - if(dest->attrs.ocrate <= 0 || dest->attrs.ocrate > 100) { + if(dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; } if(dest->attrs.ocrate < dest->attrs.ocmin) {

1 0

[kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
by Dragos Vingarzan 14 Jul '24

14 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Diameter requests could contain Application-Ids in multiple AVPs. This fix iterates through them, instead of giving up if the first one does not match. This solves some issues when peers don't always declare support for vendor-specific/non-specific application ids, so routing should be easier. Also fixed: - auth state machine being too verbose on regular messages being received or sent while in the Open state - add Destination-Host from auth state to requests (next-hop immediate routing) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3914 -- Commit Summary -- * cdp: improved routing and removed useless warning/errors in authstatemachine -- File Changes -- M src/modules/cdp/authstatemachine.c (42) M src/modules/cdp/routing.c (176) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3914.patch https://github.com/kamailio/kamailio/pull/3914.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3914(a)github.com>

2 8

git:master:0da3eb3f: cdp: improved routing and removed useless warning/errors in authstatemachine
by Dragos Vingarzan 14 Jul '24

14 Jul '24

Module: kamailio Branch: master Commit: 0da3eb3f94c087b272ebbe19c42fd933146482f8 URL: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-14T11:46:17+02:00 cdp: improved routing and removed useless warning/errors in authstatemachine --- Modified: src/modules/cdp/authstatemachine.c Modified: src/modules/cdp/routing.c --- Diff: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93… Patch: https://github.com/kamailio/kamailio/commit/0da3eb3f94c087b272ebbe19c42fd93…

1 0

[kamailio/kamailio] Outdated OpenSIPS Sources in Kamailio Project Lack Security Fixes (CVE-2023-28098) (Issue #3911)
by Garnik Khroyan 12 Jul '24

12 Jul '24

### Description The master branch of the Kamailio project contains unpatched sources from OpenSIPS, in which [CVE-2023-28098](https://github.com/OpenSIPS/opensips/security/advisories/GH… was reported. The function `parse_param_name()` from `kamailio/src/core/parser/digest/param_parser.c` does not include security patches and updates available in newer versions of OpenSIPS. The fix for CVE can be found in this commit: [OpenSIPS Commit dd9141b6](https://github.com/OpenSIPS/opensips/commit/dd9141b6f67d7df4072f3… ### Possible Solutions I strongly recommend updating the sources from OpenSIPS to the latest version available. ### Report Origin The bug is detected by a tool developed at [CAST](https://castech.am/). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3911 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3911(a)github.com>

2 4

[kamailio/kamailio] lib/ims: added cscf_get_host_from_requri (PR #3912)
by Dragos Vingarzan 12 Jul '24

12 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  On Mobile-Terminating, if the P-Called-Party-ID header is missing, getting the host (should also be an IP) from the Request-URI can help the P-CSCF when doing AAR for QoS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3912 -- Commit Summary -- * lib/ims: added cscf_get_host_from_requri -- File Changes -- M src/lib/ims/ims_getters.c (15) M src/lib/ims/ims_getters.h (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3912.patch https://github.com/kamailio/kamailio/pull/3912.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3912 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3912(a)github.com>

1 1

git:master:70fd2717: lib/ims: added cscf_get_host_from_requri
by Dragos Vingarzan 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 70fd27174952fe6a67f01fca4fdc941b9fdc045a URL: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-12T13:27:21+02:00 lib/ims: added cscf_get_host_from_requri --- Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h --- Diff: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… Patch: https://github.com/kamailio/kamailio/commit/70fd27174952fe6a67f01fca4fdc941… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index cf2f618d0de..35dbdca405f 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -539,6 +539,21 @@ str cscf_get_contact_from_requri(struct sip_msg *msg) return pu; } +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg) +{ + if(msg->first_line.type != SIP_REQUEST || parse_sip_msg_uri(msg) < 0 + || msg->parsed_uri.type == TEL_URI_T) { + str empty = {0}; + return empty; + } + return msg->parsed_uri.host; +} + + /** * Finds if the message contains the orig parameter in the first Route header * @param msg - the SIP message diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 77a55a6695b..03ad4bef82b 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -206,6 +206,12 @@ str cscf_get_public_identity_from_requri(struct sip_msg *msg); */ str cscf_get_contact_from_requri(struct sip_msg *msg); +/** + * Get the host from the Request URI of the message. + * Useful for example on MT, to get the destination from the Request URI, if P-Called-Party-ID is not present. + */ +str cscf_get_host_from_requri(struct sip_msg *msg); + /** * Looks for the Call-ID header * @param msg - the sip message

1 0

git:master:fc8bee5b: pua: use long for time value diff operation
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: fc8bee5b87e95e43bda2635e65457b2025eab6f9 URL: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T12:05:40+02:00 pua: use long for time value diff operation --- Modified: src/modules/pua/pua.c --- Diff: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… Patch: https://github.com/kamailio/kamailio/commit/fc8bee5b87e95e43bda2635e65457b2… --- diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c index e57183427f3..a53bfd83963 100644 --- a/src/modules/pua/pua.c +++ b/src/modules/pua/pua.c @@ -1121,9 +1121,10 @@ static ua_pres_t *build_uppubl_cbparam(ua_pres_t *p) publ.pres_uri = p->pres_uri; publ.content_type = p->content_type; publ.id = p->id; - publ.expires = (p->desired_expires == 0) - ? -1 - : p->desired_expires - (int)time(NULL); + publ.expires = + (int)((p->desired_expires == 0) + ? -1 + : ((long)p->desired_expires - (long)time(NULL))); publ.flag = UPDATE_TYPE; publ.source_flag = p->flag; publ.event = p->event;

1 0

git:master:c9714586: rls: remove unnecessary assignment
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: c97145862119e9001874cd07de9b20ad8e96ff54 URL: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T11:49:10+02:00 rls: remove unnecessary assignment --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… Patch: https://github.com/kamailio/kamailio/commit/c97145862119e9001874cd07de9b20a… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index c0b308a76d2..8fd388e463c 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -179,8 +179,8 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, str bstr = {0, 0}; subs_t *dialog = NULL; int len_est = 0; - int resource_added = - 0; /* Flag to indicate that we have added at least one resource */ + /* Flag to indicate that we have added at least one resource */ + int resource_added = 0; /* generate the boundary string */ boundary_string = generate_string(BOUNDARY_STRING_LEN); @@ -245,7 +245,6 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, len_est += 2 * strlen(boundary_string) + 4 + 102 + 2 + 50 + strlen(resource_uri) + 20; buf_len = 0; - resource_added = 0; /* !!!! for now I will include the auth state without checking if * it has changed - > in future check if it works */

1 0

git:master:214eaaa5: rtpengine: check fd before closing
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 214eaaa5b7a0308fd7384a41e97b1204d71c93de URL: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T09:45:53+02:00 rtpengine: check fd before closing --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… Patch: https://github.com/kamailio/kamailio/commit/214eaaa5b7a0308fd7384a41e97b120… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 7b97a2ae1ee..8a2f6a08e8f 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3770,7 +3770,8 @@ static char *send_rtpp_command( return cp; badproxy: - close(fd); + if(fd >= 0) + close(fd); return NULL; }

1 0

git:master:87e1a4a7: stun: check message len for response
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 87e1a4a7f5d565a59a362f22e9372697f2f2f2af URL: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T08:06:36+02:00 stun: check message len for response --- Modified: src/modules/stun/kam_stun.c --- Diff: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… Patch: https://github.com/kamailio/kamailio/commit/87e1a4a7f5d565a59a362f22e937269… --- diff --git a/src/modules/stun/kam_stun.c b/src/modules/stun/kam_stun.c index b3c1e7877d3..3ad42ff1636 100644 --- a/src/modules/stun/kam_stun.c +++ b/src/modules/stun/kam_stun.c @@ -512,6 +512,10 @@ static int stun_create_response(struct stun_msg *req, struct stun_msg *res, } } + if(res->msg.buf.len < sizeof(struct stun_hdr)) { + LM_ERR("invalid message\n"); + return FATAL_ERROR; + } res->hdr.len = htons(res->msg.buf.len - sizeof(struct stun_hdr)); memcpy(&res->msg.buf.s[sizeof(USHORT_T)], (void *)&res->hdr.len, sizeof(USHORT_T));

1 0

git:master:1e1ad4e7: sdpops: proper detect CR or LF
by Daniel-Constantin Mierla 12 Jul '24

12 Jul '24

Module: kamailio Branch: master Commit: 1e1ad4e74822881bb4d9cc2e9bd0f53e845bb48b URL: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-12T08:01:37+02:00 sdpops: proper detect CR or LF --- Modified: src/modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… Patch: https://github.com/kamailio/kamailio/commit/1e1ad4e74822881bb4d9cc2e9bd0f53… --- diff --git a/src/modules/sdpops/sdpops_mod.c b/src/modules/sdpops/sdpops_mod.c index f40062420a7..fb9abde6be5 100644 --- a/src/modules/sdpops/sdpops_mod.c +++ b/src/modules/sdpops/sdpops_mod.c @@ -2075,7 +2075,7 @@ int sdpops_attr_val(str *payload, str *attr, str *val) /* find EoL or EoData */ eline = sline; while(eline < payload->s + payload->len) { - if(*eline == '\r' || *eline == '\r') { + if(*eline == '\r' || *eline == '\n') { break; } eline++;

1 0

[kamailio/kamailio] ims_registrar_scscf: cannot build on Fedora 40 (Issue #3855)
by sergey-safarov 12 Jul '24

12 Jul '24

### Description "ims_registrar_scscf" cannot be compiled on Fedora 40 dist. ``` CC (gcc) [M ims_registrar_scscf.so] reply.o CC (gcc) [M ims_registrar_scscf.so] rerrno.o CC (gcc) [M ims_registrar_scscf.so] save.o CC (gcc) [M ims_registrar_scscf.so] server_assignment.o CC (gcc) [M ims_registrar_scscf.so] sip_msg.o CC (gcc) [M ims_registrar_scscf.so] stats.o CC (gcc) [M ims_registrar_scscf.so] userdata_parser.o userdata_parser.c: In function ‘ifc_tDefaultHandling2char’: userdata_parser.c:126:13: error: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration] 126 | r = strtol((char *)x, (char **)NULL, 10); | ^~~~~~ | strtok userdata_parser.c: In function ‘parse_spt_extension’: userdata_parser.c:411:32: error: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 411 | switch(atoi((char *)x)) { | ^~~~ make[2]: *** [../../Makefile.rules:100: userdata_parser.o] Error 1 make[1]: *** [Makefile:508: modules] Error 1 make[1]: Leaving directory '/root/rpmbuild/BUILD/kamailio-5.8.1/src' make: *** [Makefile:34: every-module] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.tyeQgK (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.tyeQgK (%build) ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` used modified 5.8.1 version ``` * **Operating System**: ``` [root@sbc-stage-a0 SPECS]# cat /etc/os-release NAME="Fedora Linux" VERSION="40 (Container Image)" ID=fedora VERSION_ID=40 VERSION_CODENAME="" PLATFORM_ID="platform:f40" PRETTY_NAME="Fedora Linux 40 (Container Image)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:40" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f40/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=40 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=40 SUPPORT_END=2025-05-13 VARIANT="Container Image" VARIANT_ID=container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3855 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3855(a)github.com>

2 3

[kamailio/kamailio] extented haproxy protocol support (PR #3731)
by sergey-safarov 12 Jul '24

12 Jul '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3667 #### Description Allow creating Record-Route and Via header using destination address and port in the haproxy protocol header. PR created behalf @ivanuschak You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3731 -- Commit Summary -- * core: extented haproxy protocol parser * rr: extented haproxy protocol suppport * path: extented haproxy protocol suppport * websocket: extented haproxy protocol suppport * siptrace: extented haproxy protocol suppport -- File Changes -- M src/core/forward.h (4) M src/core/msg_translator.c (137) M src/core/parser/msg_parser.h (1) M src/core/receive.c (6) M src/core/receive.h (3) M src/core/tcp_conn.h (1) M src/core/tcp_main.c (22) M src/core/tcp_read.c (20) M src/modules/path/path.c (2) M src/modules/rr/loose.c (4) M src/modules/rr/record.c (6) M src/modules/siptrace/siptrace.c (89) M src/modules/websocket/ws_frame.c (9) M src/modules/websocket/ws_handshake.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3731.patch https://github.com/kamailio/kamailio/pull/3731.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3731 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3731(a)github.com>

6 22

git:master:1c2b3361: tmx: t_precheck_trans() - explicit catch of internal return 0
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 1c2b33615888dede0ea8abc098f6f910f810366b URL: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T21:30:33+02:00 tmx: t_precheck_trans() - explicit catch of internal return 0 --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… Patch: https://github.com/kamailio/kamailio/commit/1c2b33615888dede0ea8abc098f6f91… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index 68b1e418c66..2e46c82a99a 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -921,7 +921,7 @@ static int t_precheck_trans(sip_msg_t *msg) ret = tmx_check_pretran(msg); if(ret > 0) return 1; - return (ret - 1); + return (ret == 0) ? -1 : ret; } /**

1 0

git:master:e2193b9c: htable: do not print item name before is computed
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: e2193b9cd7f59377c54e0424c0d4a1628a5a60de URL: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T19:38:24+02:00 htable: do not print item name before is computed --- Modified: src/modules/htable/ht_var.c --- Diff: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… Patch: https://github.com/kamailio/kamailio/commit/e2193b9cd7f59377c54e0424c0d4a16… --- diff --git a/src/modules/htable/ht_var.c b/src/modules/htable/ht_var.c index e79c7869ee5..4d7707f958b 100644 --- a/src/modules/htable/ht_var.c +++ b/src/modules/htable/ht_var.c @@ -38,8 +38,8 @@ int pv_get_ht_cell(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if(hpv->ht == NULL) { hpv->ht = ht_get_table(&hpv->htname); if(hpv->ht == NULL) { - LM_ERR("htable not found for getting $sht(%.*s=>%.*s)\n", - hpv->htname.len, hpv->htname.s, htname.len, htname.s); + LM_ERR("htable not found for getting $sht(%.*s=>...)\n", + hpv->htname.len, hpv->htname.s); return pv_get_null(msg, param, res); } } @@ -77,8 +77,8 @@ int pv_set_ht_cell( if(hpv->ht == NULL) hpv->ht = ht_get_table(&hpv->htname); if(hpv->ht == NULL) { - LM_ERR("htable not found for setting $sht(%.*s=>%.*s)\n", - hpv->htname.len, hpv->htname.s, htname.len, htname.s); + LM_ERR("htable not found for setting $sht(%.*s=>...)\n", + hpv->htname.len, hpv->htname.s); return -1; }

1 0

git:master:0a9cb4bf: htable: updated duplicated rm op id
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 0a9cb4bf74bf11af88e93c1512053008d94aff13 URL: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T19:31:23+02:00 htable: updated duplicated rm op id --- Modified: src/modules/htable/ht_api.h --- Diff: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… Patch: https://github.com/kamailio/kamailio/commit/0a9cb4bf74bf11af88e93c151205300… --- diff --git a/src/modules/htable/ht_api.h b/src/modules/htable/ht_api.h index f7bd8ed42c0..5ac11b9bb00 100644 --- a/src/modules/htable/ht_api.h +++ b/src/modules/htable/ht_api.h @@ -124,9 +124,9 @@ int ht_reset_content(ht_t *ht); #define HT_RM_OP_EQ 1 #define HT_RM_OP_NE 2 #define HT_RM_OP_SW 3 -#define HT_RM_OP_EW 3 -#define HT_RM_OP_RE 4 -#define HT_RM_OP_IN 5 +#define HT_RM_OP_EW 4 +#define HT_RM_OP_RE 5 +#define HT_RM_OP_IN 6 int ht_rm_cell_op(str *sre, ht_t *ht, int mode, int op); int ht_match_cell_op_str(str *sre, ht_t *ht, int mode, int op);

1 0

git:master:fffe7aae: core: counters - declare global cnts_no as unsigned short
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: fffe7aaecc41b8986eae342ce693bde87cdc20bc URL: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:50:48+02:00 core: counters - declare global cnts_no as unsigned short - it is used for counters h.id which is unsigned short --- Modified: src/core/counters.c --- Diff: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… Patch: https://github.com/kamailio/kamailio/commit/fffe7aaecc41b8986eae342ce693bde… --- diff --git a/src/core/counters.c b/src/core/counters.c index 5d9f26e5bce..dcf7ab7895e 100644 --- a/src/core/counters.c +++ b/src/core/counters.c @@ -83,9 +83,9 @@ static int grp_no = 0; /* number of groups */ /** counters array. a[proc_no][counter_id] => _cnst_vals[proc_no*cnts_no+counter_id] */ counter_array_t *_cnts_vals = 0; -int _cnts_row_len = 0; /* number of elements per row */ -static int cnts_no = 0; /* number of registered counters */ -static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ +int _cnts_row_len = 0; /* number of elements per row */ +static unsigned short cnts_no = 0; /* number of registered counters */ +static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ char *ksr_stats_namesep = KSR_STATS_NAMESEP;

1 0

git:master:d7466474: core: counters - init local global variables
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: d7466474bdc86b2b0d0872c5fd41d743ec1c7d66 URL: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:44:07+02:00 core: counters - init local global variables --- Modified: src/core/counters.c --- Diff: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… Patch: https://github.com/kamailio/kamailio/commit/d7466474bdc86b2b0d0872c5fd41d74… --- diff --git a/src/core/counters.c b/src/core/counters.c index 1a7d6637c17..5d9f26e5bce 100644 --- a/src/core/counters.c +++ b/src/core/counters.c @@ -70,22 +70,22 @@ struct grp_record /** hash table mapping a counter name to an id */ static struct str_hash_table cnts_hash_table; /** array mapping id 2 record */ -struct counter_record **cnt_id2record; -static int cnt_id2record_size; +struct counter_record **cnt_id2record = NULL; +static int cnt_id2record_size = 0; /** hash table for groups (maps a group name to a counter list) */ static struct str_hash_table grp_hash_table; /** array of groups, sorted */ -static struct grp_record **grp_sorted; -static int grp_sorted_max_size; -static int grp_sorted_crt_size; -static int grp_no; /* number of groups */ +static struct grp_record **grp_sorted = NULL; +static int grp_sorted_max_size = 0; +static int grp_sorted_crt_size = 0; +static int grp_no = 0; /* number of groups */ /** counters array. a[proc_no][counter_id] => _cnst_vals[proc_no*cnts_no+counter_id] */ counter_array_t *_cnts_vals = 0; -int _cnts_row_len; /* number of elements per row */ -static int cnts_no; /* number of registered counters */ -static int cnts_max_rows; /* set to 0 if not yet fully init */ +int _cnts_row_len = 0; /* number of elements per row */ +static int cnts_no = 0; /* number of registered counters */ +static int cnts_max_rows = 0; /* set to 0 if not yet fully init */ char *ksr_stats_namesep = KSR_STATS_NAMESEP;

1 0

git:master:48730820: core: action - logical OR for log() parameter types check
by Daniel-Constantin Mierla 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 487308204d2674368a16ea913137a368761dd0b2 URL: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-11T15:27:37+02:00 core: action - logical OR for log() parameter types check --- Modified: src/core/action.c --- Diff: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… Patch: https://github.com/kamailio/kamailio/commit/487308204d2674368a16ea913137a36… --- diff --git a/src/core/action.c b/src/core/action.c index bd75eacec33..62f2910d09b 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -511,8 +511,8 @@ int do_action(struct run_act_ctx *h, struct action *a, struct sip_msg *msg) } break; case LOG_T: - if((a->val[0].type != NUMBER_ST) | (a->val[1].type != STRING_ST)) { - LM_CRIT("bad log() types %d, %d\n", a->val[0].type, + if((a->val[0].type != NUMBER_ST) || (a->val[1].type != STRING_ST)) { + LM_CRIT("bad log() parameter types %d, %d\n", a->val[0].type, a->val[1].type); ret = E_BUG; goto error;

1 0

[kamailio/kamailio] core: Improved URN parsing according to RFC8141 (PR #3909)
by Nirv.Ana 11 Jul '24

11 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Improved URN parsing according to [RFC8141](https://datatracker.ietf.org/doc/html/rfc8141#section-2) that allows an arbitrary number of colons to be present in the URN value. Entire URN NID and NSS parts (except for `urn:` scheme) are stored in the `uri.host` struct field. `rq-components` are not supported. Example of the parse error when parsing "urn:emergency:service:sos" ``` parse_uri(): bad char ':' in state 3 parsed: urn:emergency:service (21) / urn:emergency:service:sos (25) ``` URN values that have been tested to work: - `urn:emergency:service:sos` - `urn:emergency:responder.fire` - `urn:emergency:media-feature` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3909 -- Commit Summary -- * core: Improved URN parsing according to RFC8141 -- File Changes -- M src/core/parser/parse_uri.c (48) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3909.patch https://github.com/kamailio/kamailio/pull/3909.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3909 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3909(a)github.com>

4 4

git:master:6cdd56bb: core: Improved URN parsing according to RFC8141
by Henning Westerholt 11 Jul '24

11 Jul '24

Module: kamailio Branch: master Commit: 6cdd56bb85e1a10ebbb29c2633fb47bf7b56585e URL: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… Author: anmartan <a.martin(a)zaleos.net> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-07-11T10:23:21+02:00 core: Improved URN parsing according to RFC8141 - Improved URN parsing to allow consuming URNs that contain 3 or more colons. Previosly URI parser treated some of the colons as separator between host and port causing the URN parsing to fail. --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… Patch: https://github.com/kamailio/kamailio/commit/6cdd56bb85e1a10ebbb29c2633fb47b… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 9ccb62ee51e..4150c1598d6 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -237,28 +237,30 @@ int parse_uri(char *buf, int len, struct sip_uri *uri) } else \ goto error_bad_char -#define check_host_end \ - case ':': \ - /* found the host */ \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_PORT; \ - s = p + 1; \ - break; \ - case ';': \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_PARAM; \ - s = p + 1; \ - break; \ - case '?': \ - uri->host.s = s; \ - uri->host.len = p - s; \ - state = URI_HEADERS; \ - s = p + 1; \ - break; \ - case '&': \ - case '@': \ +#define check_host_end \ + case ':': \ + /* found the host */ \ + if(scheme != URN_SCH) { \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_PORT; \ + s = p + 1; \ + } \ + break; \ + case ';': \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_PARAM; \ + s = p + 1; \ + break; \ + case '?': \ + uri->host.s = s; \ + uri->host.len = p - s; \ + state = URI_HEADERS; \ + s = p + 1; \ + break; \ + case '&': \ + case '@': \ goto error_bad_char @@ -493,7 +495,7 @@ int parse_uri(char *buf, int len, struct sip_uri *uri) case '@': /* error no user part, or * be forgiving and accept it ? */ default: - state = URI_USER; + state = (scheme == URN_SCH) ? URI_HOST : URI_USER; } break; case URI_USER:

1 0

git:master:22880dbb: core: log message that #!endif requires EoL after it
by Daniel-Constantin Mierla 10 Jul '24

10 Jul '24

Module: kamailio Branch: master Commit: 22880dbb2171c2763b4df2731be49f208fde7e8c URL: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-10T14:18:30+02:00 core: log message that #!endif requires EoL after it --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… Patch: https://github.com/kamailio/kamailio/commit/22880dbb2171c2763b4df2731be49f2… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index d77a237882b..407918aca72 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -281,6 +281,7 @@ void pp_ifdef_level_error(void) " %d more #!endif as #!if[n]def\n", (_pp_ifdef_level) * -1); } + LM_ERR("note: #!endif requires EoL after it, even before EoF\n"); } }

1 0

git:master:bd98aadf: corex: destroy nio_msg_avp avp after event_route[network:msg]
by Daniel-Constantin Mierla 10 Jul '24

10 Jul '24

Module: kamailio Branch: master Commit: bd98aadf9803c0c0789680d5ca781e86499f55cd URL: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-10T14:01:23+02:00 corex: destroy nio_msg_avp avp after event_route[network:msg] --- Modified: src/modules/corex/corex_nio.c --- Diff: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… Patch: https://github.com/kamailio/kamailio/commit/bd98aadf9803c0c0789680d5ca781e8… --- diff --git a/src/modules/corex/corex_nio.c b/src/modules/corex/corex_nio.c index 03175926753..4069565b892 100644 --- a/src/modules/corex/corex_nio.c +++ b/src/modules/corex/corex_nio.c @@ -111,17 +111,24 @@ int nio_msg_received(sr_event_param_t *evp) avp = NULL; avp = search_first_avp( nio_msg_avp_type, nio_msg_avp_name, &avp_value, 0); - if(avp != NULL && is_avp_str_val(avp)) { - msg.buf = avp_value.s.s; - msg.len = avp_value.s.len; - nbuf = nio_msg_update(&msg, (unsigned int *)&obuf->len); - if(obuf->len >= BUF_SIZE) { - LM_ERR("new buffer overflow (%d)\n", obuf->len); - pkg_free(nbuf); - return -1; + if(avp != NULL) { + if(is_avp_str_val(avp)) { + msg.buf = avp_value.s.s; + msg.len = avp_value.s.len; + nbuf = nio_msg_update(&msg, (unsigned int *)&obuf->len); + if(obuf->len >= BUF_SIZE) { + LM_ERR("new buffer overflow (%d)\n", obuf->len); + pkg_free(nbuf); + return -1; + } + memcpy(obuf->s, nbuf, obuf->len); + obuf->s[obuf->len] = '\0'; + } else { + LM_WARN("invalid value tyoe for AVP %.*s, using unmodified " + "message\n", + nio_msg_avp_param.len, nio_msg_avp_param.s); } - memcpy(obuf->s, nbuf, obuf->len); - obuf->s[obuf->len] = '\0'; + destroy_avp(avp); } else { LM_WARN("no value set for AVP %.*s, using unmodified message\n", nio_msg_avp_param.len, nio_msg_avp_param.s); @@ -164,18 +171,25 @@ int nio_msg_sent(sr_event_param_t *evp) avp = NULL; avp = search_first_avp( nio_msg_avp_type, nio_msg_avp_name, &avp_value, 0); - if(avp != NULL && is_avp_str_val(avp)) { - msg.buf = avp_value.s.s; - msg.len = avp_value.s.len; - nbuf.s = nio_msg_update(&msg, (unsigned int *)&nbuf.len); - if(nbuf.s != NULL) { - LM_DBG("new outbound buffer generated\n"); - pkg_free(obuf->s); - obuf->s = nbuf.s; - obuf->len = nbuf.len; + if(avp != NULL) { + if(is_avp_str_val(avp)) { + msg.buf = avp_value.s.s; + msg.len = avp_value.s.len; + nbuf.s = nio_msg_update(&msg, (unsigned int *)&nbuf.len); + if(nbuf.s != NULL) { + LM_DBG("new outbound buffer generated\n"); + pkg_free(obuf->s); + obuf->s = nbuf.s; + obuf->len = nbuf.len; + } else { + LM_ERR("failed to generate new outbound buffer\n"); + } } else { - LM_ERR("failed to generate new outbound buffer\n"); + LM_WARN("invalid value type for AVP %.*s, using unmodified " + "message\n", + nio_msg_avp_param.len, nio_msg_avp_param.s); } + destroy_avp(avp); } else { LM_WARN("no value set for AVP %.*s, using unmodified message\n", nio_msg_avp_param.len, nio_msg_avp_param.s);

1 0

git:master:5697cb17: modules: readme files regenerated - ndb_redis ... [skip ci]
by Kamailio Dev 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 5697cb17d4d3dcb346b49c66cd3de265681051de URL: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-09T13:46:10+02:00 modules: readme files regenerated - ndb_redis ... [skip ci] --- Modified: src/modules/ndb_redis/README --- Diff: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… Patch: https://github.com/kamailio/kamailio/commit/5697cb17d4d3dcb346b49c66cd3de26… --- diff --git a/src/modules/ndb_redis/README b/src/modules/ndb_redis/README index 90071f5e3f0..3f180a1168e 100644 --- a/src/modules/ndb_redis/README +++ b/src/modules/ndb_redis/README @@ -135,7 +135,7 @@ Chapter 1. Admin Guide The following libraries or applications must be installed before running Kamailio with this module loaded: - * hiredis - available at https://github.com/antirez/hiredis . + * hiredis - available at https://github.com/redis/hiredis. 3. Parameters

1 0

git:master:501b7da6: ndb_redis: dpcs - updated link to hiredis library
by Daniel-Constantin Mierla 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 501b7da6daaff354b000837b54bdb591947ac80a URL: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-09T13:41:57+02:00 ndb_redis: dpcs - updated link to hiredis library --- Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… Patch: https://github.com/kamailio/kamailio/commit/501b7da6daaff354b000837b54bdb59… --- diff --git a/src/modules/ndb_redis/doc/ndb_redis_admin.xml b/src/modules/ndb_redis/doc/ndb_redis_admin.xml index 024b01315ac..85287118725 100644 --- a/src/modules/ndb_redis/doc/ndb_redis_admin.xml +++ b/src/modules/ndb_redis/doc/ndb_redis_admin.xml @@ -50,7 +50,7 @@ <listitem> <para> <emphasis>hiredis</emphasis> - available at - https://github.com/antirez/hiredis . + <ulink url="https://github.com/redis/hiredis">https://github.com/redis/hiredis</ulink>. </para> </listitem> </itemizedlist>

1 0

[kamailio/kamailio] WIP pkg: RPM packaging add kamailio-tls_wolfssl subpackage (PR #3592)
by space88man 09 Jul '24

09 Jul '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Not for merging yet. Package tls_wolfssl as an alternative to OpenSSL 3.x. Depends on PR https://github.com/kamailio/kamailio/pull/3590 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3592 -- Commit Summary -- * pkg: RPM packaging add kamailio-tls_wolfssl subpackage -- File Changes -- M pkg/kamailio/obs/kamailio.spec (18) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3592.patch https://github.com/kamailio/kamailio/pull/3592.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3592 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3592(a)github.com>

5 27

git:master:dc2008b2: modules: readme files regenerated - ims_qos ... [skip ci]
by Kamailio Dev 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: dc2008b29395f5e45dffd270b6aa74f0c0a9a0d2 URL: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-09T09:31:10+02:00 modules: readme files regenerated - ims_qos ... [skip ci] --- Modified: src/modules/ims_qos/README Modified: src/modules/ims_registrar_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f… Patch: https://github.com/kamailio/kamailio/commit/dc2008b29395f5e45dffd270b6aa74f…

1 0

[kamailio/kamailio] ims_registrar_pcscf,ims_qos: support for trusting bottom via (PR #3901)
by Dragos Vingarzan 09 Jul '24

09 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 #### Description  Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx. The current code is using a mix of that, plus using Contact and Via headers, with arguable potential security issues. This patch adds a new parameter to `ims_registrar_pcscf` and `ims_qos` modules, allowing for an optional outsource of the IPsec functionality to another element, which is also in charge of checking/enforcing correct UE Via header. The existing code is allowed to work as before, with the default value of the flag being towards that. List of functional changes: - `ims_qos` - added `trust_bottom_via` parameter - used it on `w_rx_aar_register()` - `ims_registrar_pcscf` - added `trust_bottom_via` parameter - used it on `update_contacts()`, `save_pending()`, `check_contact()`, `getContactP()`, `check_service_routes()`, `enforce_service_routes()` - made `ims_ipsec_pcscf` dependency optional, with checks when used - skipped checks of `port-uc` in `checkcontact()` if the `ims_ipsec_pcscf` module was not loaded - added `ignore_contact_rxproto_check` parameter - IMS devices open IPsec Security Associations just between IPs and ports, with both UDP and TCP protocols allowed. The default then was set here to always ignore protocol checks. Before, the `ignore_contact_rxport_check` was used to skip this and still make it work, but that seemed like a typo/mistake with hidden effects. List of indirect changes: - `core/ut.h`: added a `str2ushort()` macro, since code was using some dangerous casting and macros with a larger type - `ims_registrar_pcscf`: added `Route` headers in `SUBSCRIBE` to `reginfo`, with values from `Service-Route`s, as per 3GPP specs. - `ims_usrloc_pcscf`: small log fixes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3901 -- Commit Summary -- * core: added str2ushort() to avoid some questionable casting in ims_qos * lib/ims: fixed a typo in a log message * ims_usrloc_pcscf: small log fixes * ims_qos: added trust_bottom_via parameter * ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf -- File Changes -- M src/core/ut.h (8) M src/lib/ims/ims_getters.c (2) M src/modules/ims_qos/doc/ims_qos.xml (6) M src/modules/ims_qos/doc/ims_qos_admin.xml (41) M src/modules/ims_qos/ims_qos_mod.c (27) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_authdata.h (2) M src/modules/ims_qos/rx_avp.c (2) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml (6) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (73) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (26) M src/modules/ims_registrar_pcscf/notify.c (2) M src/modules/ims_registrar_pcscf/save.c (80) M src/modules/ims_registrar_pcscf/service_routes.c (136) M src/modules/ims_registrar_pcscf/subscribe.c (74) M src/modules/ims_registrar_pcscf/subscribe.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3901.patch https://github.com/kamailio/kamailio/pull/3901.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3901 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3901(a)github.com>

2 4

git:master:89830833: ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 898308334982b39d668410b51b90835b57b8a4c2 URL: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_registrar_pcscf: added trust_bottom_via parameter, added ignore_contact_rxproto_check, fixes for logging, fixes for SUBSCRIBE to reginfo for including Service-Route, allow use without ims_ipsec_pcscf --- Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c Modified: src/modules/ims_registrar_pcscf/notify.c Modified: src/modules/ims_registrar_pcscf/save.c Modified: src/modules/ims_registrar_pcscf/service_routes.c Modified: src/modules/ims_registrar_pcscf/subscribe.c Modified: src/modules/ims_registrar_pcscf/subscribe.h --- Diff: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835… Patch: https://github.com/kamailio/kamailio/commit/898308334982b39d668410b51b90835…

1 0

git:master:d87d0328: ims_qos: added trust_bottom_via parameter
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: d87d03285c83cded13a873338ec9cc6c2c55be30 URL: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_qos: added trust_bottom_via parameter --- Modified: src/modules/ims_qos/doc/ims_qos.xml Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/rx_authdata.h Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6… Patch: https://github.com/kamailio/kamailio/commit/d87d03285c83cded13a873338ec9cc6…

1 0

git:master:9a87ec98: ims_usrloc_pcscf: small log fixes
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 9a87ec98cf8aacc73b87846570202cbe69ebe837 URL: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 ims_usrloc_pcscf: small log fixes --- Modified: src/modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… Patch: https://github.com/kamailio/kamailio/commit/9a87ec98cf8aacc73b87846570202cb… --- diff --git a/src/modules/ims_usrloc_pcscf/udomain.c b/src/modules/ims_usrloc_pcscf/udomain.c index 5a4c5ba659e..248684cb00b 100644 --- a/src/modules/ims_usrloc_pcscf/udomain.c +++ b/src/modules/ims_usrloc_pcscf/udomain.c @@ -496,7 +496,7 @@ int get_pcontact_from_cache(udomain_t *_d, pcontact_info_t *contact_info, contact_info->aor.len, contact_info->aor.s); return 1; } - LM_DBG("checking for rinstance"); + LM_DBG("checking for rinstance\n"); /*check for alias - NAT */ params = needle_uri.sip_params.s; params_len = needle_uri.sip_params.len; @@ -548,7 +548,7 @@ int get_pcontact_from_cache(udomain_t *_d, pcontact_info_t *contact_info, int check2_passed = 0; ip_addr_t c_ip_addr; ip_addr_t ci_ip_addr; - LM_DBG("mached a record by aorhash: %u\n", aorhash); + LM_DBG("matched a record by aorhash: %u\n", aorhash); // convert 'contact->contact host' ip string to ip_addr_t if(str2ipxbuf(&c->contact_host, &c_ip_addr) < 0) {

1 0

git:master:f105bc50: lib/ims: fixed a typo in a log message
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: f105bc507a8e63fd7f6e493265a39ab4b2cdf9b4 URL: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 lib/ims: fixed a typo in a log message --- Modified: src/lib/ims/ims_getters.c --- Diff: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… Patch: https://github.com/kamailio/kamailio/commit/f105bc507a8e63fd7f6e493265a39ab… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index c752f08eef1..cf2f618d0de 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -1638,7 +1638,7 @@ str *cscf_get_service_route(struct sip_msg *msg, int *size, int is_shm) } x = pkg_reallocxf(x, (*size + k) * sizeof(str)); if(!x) { - LM_ERR("Error our of pkg memory"); + LM_ERR("Error out of pkg memory"); return 0; } r2 = r;

1 0

git:master:cc376804: core: added str2ushort() to avoid some questionable casting in ims_qos
by Dragos Vingarzan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: cc376804ef2bb5064bbff9e3c963a5d9222568b3 URL: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-09T09:22:36+02:00 core: added str2ushort() to avoid some questionable casting in ims_qos --- Modified: src/core/ut.h --- Diff: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… Patch: https://github.com/kamailio/kamailio/commit/cc376804ef2bb5064bbff9e3c963a5d… --- diff --git a/src/core/ut.h b/src/core/ut.h index 1efd7abd242..aa51108229b 100644 --- a/src/core/ut.h +++ b/src/core/ut.h @@ -700,6 +700,14 @@ static inline int str2int(str *_s, unsigned int *_r) str2unval(_s, _r, int, UINT_MAX); } +/* + * Convert a str to unsigned short + */ +static inline int str2ushort(str *_s, unsigned short *_r) +{ + str2unval(_s, _r, short, USHRT_MAX); +} + #define str2snval(_s, _r, _vtype, _vmin, _vmax) \ do { \

1 0

git:5.8:dbe51dc4: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: 5.8 Commit: dbe51dc4ee53f6e4f00450745db709a9d741c481 URL: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T13:40:05+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 (cherry-picked from commit 92cfedaaffb034db536f3bcf68695b433db92706) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… Patch: https://github.com/kamailio/kamailio/commit/dbe51dc4ee53f6e4f00450745db709a… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..37508ce24c0 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,14 +179,14 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID >= 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %d) - " "ignoring\n", - db_mysql_opt_ssl_ca); + MYSQL_VERSION_ID); #endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT

1 0

git:master:92cfedaa: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 92cfedaaffb034db536f3bcf68695b433db92706 URL: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:53:07+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… Patch: https://github.com/kamailio/kamailio/commit/92cfedaaffb034db536f3bcf68695b4… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..37508ce24c0 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,14 +179,14 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID >= 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %d) - " "ignoring\n", - db_mysql_opt_ssl_ca); + MYSQL_VERSION_ID); #endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT

1 0

git:master:0fc0c7b3: Revert "db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x"
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 0fc0c7b3d3d6ded300c46f504406447670fee4e8 URL: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:50:14+08:00 Revert "db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x" This reverts commit 5b2be5e2c716ad8f8502b3be3db5194eb8474d39. The commit should check >= not < --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… Patch: https://github.com/kamailio/kamailio/commit/0fc0c7b3d3d6ded300c46f504406447… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 21ac5023c81..240d3f59a76 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,15 +179,15 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#if(MYSQL_VERSION_ID < 50600) +#ifdef MYSQL_OPT_SSL_CA if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s:%d) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " "ignoring\n", - MYSQL_SERVER_VERSION, MYSQL_VERSION_ID); -#endif /* MYSQL_VERSION_ID */ + db_mysql_opt_ssl_ca); +#endif /* MYSQL_OPT_SSL_CA */ #ifdef KSR_MYSQL_OPT_RECONNECT /* set reconnect flag if enabled */

1 0

[kamailio/kamailio] [db_mysql] MYSQL_OPT_SSL_CA is an enum not a macro (Issue #3910)
by space88man 09 Jul '24

09 Jul '24

### Description Recent commit ``` d53843c75da src/modules/db_mysql/km_my_con.c (Sergey Safarov 2024-05-11 17:45:08 +0300 182) #ifdef MYSQL_OPT_SSL_CA ``` breaks db_mysql on 5.8.2 ``` Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value /etc/pki/tls/certs/ca-cert.pem) - ignoring Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: ERROR: db_mysql [km_my_con.c:217]: db_mysql_new_connection(): driver error: SSL connection error: CA certificate is required if ssl-mode is VERIFY_CA or VERIFY_IDENTITY ``` Ping @sergey-safarov ### Troubleshooting #### Reproduction * use 5.8.2 * configure `db_mysql` to use TLS with verification #### Debugging Data #### Log Messages ``` Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value /etc/pki/tls/certs/ca-cert.pem) - ignoring Jul 09 08:40:31 voip-ssl3.voip.test /usr/local/kamailio/sbin/kamailio[10982]: ERROR: db_mysql [km_my_con.c:217]: db_mysql_new_connection(): driver error: SSL connection error: CA certificate is required if ssl-mode is VERIFY_CA or VERIFY_IDENTITY ``` ### Additional Information * **Kamailio Version** - 5.8.2 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3910 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3910(a)github.com>

1 2

git:master:5b2be5e2: db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x
by S-P Chan 09 Jul '24

09 Jul '24

Module: kamailio Branch: master Commit: 5b2be5e2c716ad8f8502b3be3db5194eb8474d39 URL: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-07-09T10:38:44+08:00 db_mysql: fix check for enum MYSQL_OPT_SSL_CA for CentOS 7/5.5.x - MYSQL_OPT_SSL_CA is an enum not a macro - base check on MYSQL_VERSION_ID - 50568 used in CentOS 7 Addresses #3910 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… Patch: https://github.com/kamailio/kamailio/commit/5b2be5e2c716ad8f8502b3be3db5194… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 240d3f59a76..21ac5023c81 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -179,15 +179,15 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ -#ifdef MYSQL_OPT_SSL_CA +#if(MYSQL_VERSION_ID < 50600) if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s:%d) - " "ignoring\n", - db_mysql_opt_ssl_ca); -#endif /* MYSQL_OPT_SSL_CA */ + MYSQL_SERVER_VERSION, MYSQL_VERSION_ID); +#endif /* MYSQL_VERSION_ID */ #ifdef KSR_MYSQL_OPT_RECONNECT /* set reconnect flag if enabled */

1 0

[kamailio/kamailio] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
by Dragos Vingarzan 08 Jul '24

08 Jul '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - Not yet - first let's see if the work is valid, then I'll recompose the whole work to satisfy this. Otherwise... if I need to fix something, it's too hard to work like this... - [ ] Each component has a single commit (if not, squash them into one commit) - ditto - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx. The current code is using a mix of that, plus using Contact and Via headers, with arguable potential security issues. This patch adds a new parameter to `ims_registrar_pcscf` and `ims_qos` modules, allowing for an optional outsource of the IPsec functionality to another element, which is also in charge of checking/enforcing correct UE Via header. The existing code is allowed to work as before, with the default value of the flag being towards that. List of functional changes: - `ims_qos` - added `trust_bottom_via` parameter - List of indirect changes: - default I-CSCF config example contained a questionable line which adds a `+` as a prefix in Request-URI. After way too much time wasted to figure out why the Diameter LIR has bogus SIP or TEL URI values in UserName AVP, I have discovered this. Seems like someone had just tel-URIs in their network, but otherwise the blind addition of this prefix makes no sense to me. - added a `str2ushort()` macro, since code was using some dangerous casting and macros with a larger type - List of non-functional fixes: - spelling in comments - comments at the end of line moved above the line they refer to; with just 80 columns code-formatting, commenting on the same line provides for some super weird and hard to read code, so IMHO should not be allowed (or ... much harder now... increase to 120 columns) - You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3891 -- Commit Summary -- * squashed work -- File Changes -- M misc/examples/ims/icscf/kamailio.cfg (4) M src/core/ut.h (36) M src/lib/ims/ims_getters.c (2) M src/modules/ims_icscf/location.c (10) M src/modules/ims_qos/ims_qos_mod.c (27) M src/modules/ims_qos/ims_qos_mod.h (1) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_authdata.h (2) M src/modules/ims_qos/rx_avp.c (2) M src/modules/ims_qos/rx_avp.h (1) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (39) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (18) M src/modules/ims_registrar_pcscf/notify.c (2) M src/modules/ims_registrar_pcscf/save.c (78) M src/modules/ims_registrar_pcscf/service_routes.c (125) M src/modules/ims_registrar_pcscf/subscribe.c (75) M src/modules/ims_registrar_pcscf/subscribe.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3891.patch https://github.com/kamailio/kamailio/pull/3891.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3891(a)github.com>

2 20

[kamailio/kamailio] Base58 not decoding correctly (Issue #3907)
by duarterocha91 08 Jul '24

08 Jul '24

### Description When doing base58 encoding and decoding there is some issue with the decoded string. Here is my code to ilustrate the issue : $var(Test) = "test_string"; $var(Test) = $(var(Test){s.encode.base58}); xerr("Test String encoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.decode.base58}); xerr("Test String decoded = STRING_BEGIN$var(Test)STRING_END"); It has the following output : ![image](https://github.com/kamailio/kamailio/assets/28625449/f9b10fd3-6e75-4368-9abd-005d44cc1235) I've inserted STRING_BEGIN and STRING_END in the log to be able to know when string ends. After this i've tried to user {s.trim} method with no success. I've noticed that despite not printing correctly, the string's length is calculated correctly, so i did a manual substring and was able to fix it. xerr("Test Base58"); $var(Test) = "test_string"; $var(Test) = $(var(Test){s.encode.base58}); xerr("Test String encoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.decode.base58}); xerr("Test String decoded = STRING_BEGIN$var(Test)STRING_END"); $var(Test) = $(var(Test){s.trim}); xerr("Test String decoded and trimmed = STRING_BEGIN$var(Test)STRING_END"); $var(substring_length) = $(var(Test){s.len}) - 1; $var(Test) = $(var(Test){s.substr,0,$var(substring_length)}); xerr("Test String decoded and fixed = STRING_BEGIN$var(Test)STRING_END"); Output : ![image](https://github.com/kamailio/kamailio/assets/28625449/9a100c45-4671-4381-9ddf-3a1c8c9404ee) All of this doesn't happen with method for base64 for example ### Additional Information version: kamailio 5.7.1 (x86_64/linux) 4238e4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4238e4 compiled on 12:39:30 Jun 29 2023 with gcc 4.8.5 * **Operating System**: CentOS 7 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3907 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3907(a)github.com>

2 2

git:master:9d923764: core: basex - compute lenght for base58 decode
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: master Commit: 9d923764747ff36152fc930da66e972201516b7b URL: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-08T12:08:13+02:00 core: basex - compute lenght for base58 decode - GH #3907 --- Modified: src/core/basex.c --- Diff: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… Patch: https://github.com/kamailio/kamailio/commit/9d923764747ff36152fc930da66e972… --- diff --git a/src/core/basex.c b/src/core/basex.c index a112ce77adb..2871afa22ee 100644 --- a/src/core/basex.c +++ b/src/core/basex.c @@ -412,7 +412,7 @@ char *b58_decode(char *outb, int *outbszp, char *b58, int b58sz) break; --*outbszp; } - *outbszp += zerocount; + *outbszp = strlen(outb + i); return outb + i; }

1 0

[kamailio/kamailio] kamailio 5.7.6 startup (Issue #3908)
by alekamailio 08 Jul '24

08 Jul '24

Hello, Upgraded the kamailio version from 5.7.5 to 5.7.6 and after restart the service got the follow WARNING, WARNING: db_mysql [km_my_con.c:179]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring, when downgrade to 5.7.5 dindt happend. Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3908 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3908(a)github.com>

2 2

git:5.7:184aaf99: db_mysql: switch warn to dbg for log messages for opt_ssl_ca option
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: 5.7 Commit: 184aaf991b6ad74b63a7f8724058cd4066f3bbd3 URL: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-07T09:35:36+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_ca option fixes #3884 (cherry picked from commit be5172a84b02a1ab4fc7e97e7dc0813056302bdd) (cherry picked from commit 4c75991aa662bddc1bbe65c83f7861cb72a65a61) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… Patch: https://github.com/kamailio/kamailio/commit/184aaf991b6ad74b63a7f8724058cd4… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 8534ac0a156..d6c7a43bdac 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -174,8 +174,8 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_WARN("opt_ssl_ca option not supported by mysql version (value %s) - " - "ignoring\n", + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + "ignoring\n", db_mysql_opt_ssl_ca); #endif /* MYSQL_OPT_SSL_CA */

1 0

git:5.7:64f0c3f3: db_mysql: switch warn to dbg for log messages for opt_ssl_mode
by Daniel-Constantin Mierla 08 Jul '24

08 Jul '24

Module: kamailio Branch: 5.7 Commit: 64f0c3f3979de7a40732067792d89c6d3b1c23d4 URL: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-07T09:35:27+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_mode - GH #3884 (cherry picked from commit 8f98317e92da61160a1c416e0da45938a205d358) (cherry picked from commit 7360ab7fbe672259c7433b1a5199467d24183d79) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… Patch: https://github.com/kamailio/kamailio/commit/64f0c3f3979de7a40732067792d89c6… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 04982292673..8534ac0a156 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -133,7 +133,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #if MYSQL_VERSION_ID >= 100339 mysql_options(ptr->con, MYSQL_OPT_SSL_ENFORCE, (void *)&(int){1}); #else - LM_WARN("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); + LM_DBG("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); #endif break; case 5: /* SSL_MODE_VERIFY_IDENTITY */ @@ -141,7 +141,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) (void *)&(int){1}); break; default: - LM_WARN("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", + LM_DBG("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", db_mysql_opt_ssl_mode); break; }

1 0

[kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)
by Henning Westerholt 05 Jul '24

05 Jul '24

### Description On systems with a high number of TCP sessions there can be a significant performance regression observed, probably related to the newly added TCP connection tracking feature. ### Troubleshooting #### Reproduction No special configuration is necessary, just install the latest 5.7.x release, e.g. 5.7.3 on a production system with a lot of clients connected over TCP or TLS. You need to have a large number of clients connected to be able to observe the regression. For a high number of connections (e.g. more then 20.000 up to 30.000 connections) the Kamailio servers uses about 30% to 50% more CPU as with the old version. #### Debugging Data Two graphs were attached to this issue. The first shows the CPU load before (less load) and after the upgrade (increased load). The second is a flamegraph that shows that over 80% of the CPU time is spent in the newly added function tcp_connection_limit_srcip(). <img width="372" alt="cpu-load-before-after" src="https://github.com/kamailio/kamailio/assets/6481937/ec92c41b-25e2-4847-a4bc…"> ![flamegraph](https://github.com/kamailio/kamailio/assets/6481937/5c2e3982-2d5b-4acd-a774-bad8fa64bd0a) Most of the CPU time is spend in the TCP main process, as expected. #### Log Messages No special log messages could be observed. #### SIP Traffic ### Possible Solutions The TCP limit feature should probably be optimized to not cause such a large performance regression. It should be also possible to deactivate it completly and therefore getting a comparable performance as before the feature addition. ### Additional Information Kamailio 5.7.3 and probably also git master version. * **Operating System**: Debian 11, Debian 12 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3759 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3759(a)github.com>

2 6

[kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)
by liangbaolin 05 Jul '24

05 Jul '24

### Description During the process of using version 5.7.4 of Kamailio, I found that the $conid cannot be correctly obtained in the TCP: closed routing block of the TCP module event_route. I am certain that it is normal in version 5.4.8. ### Troubleshooting ``` pv [pv_core.c:2725]: pv_get_tcpconn_id() ``` #### Reproduction The test scenario initiated a register registration process for me, and after completing the disconnection of the TCP connection, triggered this event. #### Log Messages  ``` 2024-02-26T01:35:55.902002512Z 52(98) DEBUG: <core> [core/receive.c:635]: receive_msg(): cleaning up 2024-02-26T01:35:55.902034482Z 52(98) DEBUG: <core> [core/tcp_read.c:280]: tcp_read_data(): EOF on connection 0x7f99a1546a80 (state: 0, flags: c018) - FD 24, bytes 0, rd-flags 10000 ([12.0.1.6]:15821 -> [12.0.1.6]:5060)52(98) DEBUG: <core> [core/tcp_read.c:343]: tcp_read(): read 0 bytes: 2024-02-26T01:35:55.902051542Z 2024-02-26T01:35:55.902058282Z 52(98) DEBUG: <core> [core/tcp_read.c:1532]: tcp_read_req(): read= 0 bytes, parsed=0, state=0, error=1 2024-02-26T01:35:55.902063282Z 52(98) DEBUG: <core> [core/tcp_read.c:1534]: tcp_read_req(): last char=0x00, parsed msg= 2024-02-26T01:35:55.902069402Z 2024-02-26T01:35:55.902074032Z 52(98) DEBUG: <core> [core/tcp_read.c:1544]: tcp_read_req(): EOF 2024-02-26T01:35:55.902101372Z 52(98) DEBUG: <core> [core/io_wait.h:598]: io_watch_del(): DBG: io_watch_del (0x559e8a029740, 24, -1, 0x10) fd_no=2 called 2024-02-26T01:35:55.902153162Z 52(98) DEBUG: <core> [core/tcp_read.c:1927]: handle_io(): removing from list 0x7f99a1546a80 id 2 fd 24, state 2, flags c018, main fd 134, refcnt 2 ([12.0.1.6]:15821 -> [12.0.1.6]:5060) 2024-02-26T01:35:55.902168112Z 52(98) DEBUG: <core> [core/tcp_read.c:1702]: release_tcpconn(): releasing con 0x7f99a1546a80, state -1, fd=24, id=2 ([12.0.1.6]:15821 -> [12.0.1.6]:5060) 2024-02-26T01:35:55.902173372Z 52(98) DEBUG: <core> [core/tcp_read.c:1705]: release_tcpconn(): extra_data (nil) 2024-02-26T01:35:55.902208402Z 83(129) DEBUG: <core> [core/tcp_main.c:3747]: handle_tcp_child(): reader response= 7f99a1546a80, -1 from 1 2024-02-26T01:35:55.902224742Z 83(129) DEBUG: <core> [core/tcp_main.c:3904]: handle_tcp_child(): case CONN_EOF tcp_emit_closed_event before 5 2024-02-26T01:35:55.902229802Z 83(129) DEBUG: <core> [core/tcp_main.c:3671]: tcp_emit_closed_event(): TCP closed event creation triggered (reason: 0) 2024-02-26T01:35:55.902318572Z 83(129) DEBUG: tcpops [tcpops.c:311]: tcpops_handle_tcp_closed(): received TCP closed event 2024-02-26T01:35:55.902331352Z 83(129) DEBUG: tcpops [tcpops.c:261]: tcpops_tcp_closed_run_route(): event reason id: 0 rt: 1 2024-02-26T01:35:55.902335132Z 83(129) ERROR: tcpops [tcpops.c:278]: tcpops_tcp_closed_run_route(): run_top_route() before tev->id: 2 2024-02-26T01:35:55.902480972Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902493872Z 83(129) DEBUG: pv [pv_core.c:2725]: pv_get_tcpconn_id(): no conid 2024-02-26T01:35:55.902498762Z 83(129) DEBUG: pv [pv_core.c:2726]: pv_get_tcpconn_id(): msg->rcv.proto_reserved1: 2 2024-02-26T01:35:55.902503592Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902508262Z 83(129) DEBUG: <core> [core/pvapi.c:1418]: pv_printf_mode(): final buffer length 111 2024-02-26T01:35:55.902513422Z 83(129) ERROR: <script>: tcp connection closed conid: (<null>), tcp(conid): <null>, Ri: 12.0.1.185, Rp: 5060 , si: 12.0.1.6 , sp: 15821 2024-02-26T01:35:55.902607692Z 83(129) DEBUG: <core> [core/tcp_main.c:1713]: _tcpconn_find(): 2 port 0 2024-02-26T01:35:55.902625622Z 83(129) DEBUG: pv [pv_core.c:2725]: pv_get_tcpconn_id(): no conid 2024-02-26T01:35:55.902630672Z 83(129) DEBUG: pv [pv_core.c:2726]: pv_get_tcpconn_id(): msg->rcv.proto_reserved1: 2 2024-02-26T01:35:55.902635822Z 83(129) ERROR: tcpops [tcpops.c:280]: tcpops_tcp_closed_run_route(): run_top_route() after tev->id: 2 2024-02-26T01:35:58.777642759Z 41(87) DEBUG: ims_dialog [dlg_handlers.c:2026]: print_all_dlgs(): ********************41(87) DEBUG: ims_dialog [dlg_handlers.c:2027]: print_all_dlgs(): printing 65536 dialogs ``` #### SIP Traffic  ``` my test script block event_route[tcp:closed] { xlog("L_ERR", "$proto connection closed conid: ($conid), tcp(conid): $tcp(conid), Ri: $Ri, Rp: $Rp , si: $si , sp: $sp\n"); } file: src/modules/pv/pv_core.c int pv_get_tcpconn_id(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { ... if((con = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, 0)) == NULL) // return false { LM_DBG("no conid\n"); //additional custom log LM_DBG("msg->rcv.proto_reserved1: %d\n",msg->rcv.proto_reserved1); return pv_get_null(msg, param, res); } .... } file: src/core/tcp_main.c struct tcp_connection *tcpconn_lookup(int id, struct ip_addr *ip, int port, union sockaddr_union *local_addr, int try_local_port, ticks_t timeout) { ... if(unlikely(c == NULL)) { c = _tcpconn_find(id, ip, port, &local_ip, local_port); // retrun c == null } ... } struct tcp_connection *_tcpconn_find( int id, struct ip_addr *ip, int port, struct ip_addr *l_ip, int l_port) { ... if(likely(id)) { hash = tcp_id_hash(id); for(c = tcpconn_id_hash[hash]; c; c = c->id_next) { //tcpconn_id_hash find c is null #ifdef EXTRA_DEBUG LM_DBG("c=%p, c->id=%d, port=%d\n", c, c->id, c->rcv.src_port); print_ip("ip=", &c->rcv.src_ip, "\n"); #endif .... } inline static int tcpconn_try_unhash(struct tcp_connection *tcpconn) { ... _tcpconn_detach(tcpconn); //executed ... lock_release(&tcpconn->write_lock); ... } static inline void _tcpconn_detach(struct tcp_connection *c) { ... tcpconn_listrm(tcpconn_id_hash[c->id_hash], c, id_next, id_prev); //remove c ... } ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) 9920d9-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 9920d9 -dirty compiled on 09:59:52 Feb 26 2024 with gcc 7.5.0 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3767 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3767(a)github.com>

5 8

git:master:6f434afc: ndb_redis: larger size for buffers to create server specs on cluster redirect
by Daniel-Constantin Mierla 05 Jul '24

05 Jul '24

Module: kamailio Branch: master Commit: 6f434afc414b7f5b66374a124138990f7a3dd1d1 URL: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-05T11:47:34+02:00 ndb_redis: larger size for buffers to create server specs on cluster redirect - GH #3894 --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… Patch: https://github.com/kamailio/kamailio/commit/6f434afc414b7f5b66374a124138990… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index cba94a38c06..74df8efda0b 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -886,11 +886,11 @@ int redisc_exec_pipelined(redisc_server_t *rsrv) int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) { redisc_server_t *rsrv_new; - char buffername[100]; + char buffername[512]; unsigned int port; str addr = {0, 0}, tmpstr = {0, 0}, name = {0, 0}; int server_len = 0; - char spec_new[100]; + char spec_new[512]; if(redis_cluster_param) { LM_DBG("Redis replied: \"%.*s\"\n", (int)reply->len, reply->str);

1 0

git:master:4d2988a7: ndb_redis: print server spec lenght in error message
by Daniel-Constantin Mierla 05 Jul '24

05 Jul '24

Module: kamailio Branch: master Commit: 4d2988a79d992ed8f3ce4cffa6c387ef0425be94 URL: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-05T10:41:09+02:00 ndb_redis: print server spec lenght in error message - use standard pkg alloc error message --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… Patch: https://github.com/kamailio/kamailio/commit/4d2988a79d992ed8f3ce4cffa6c387e… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index c9280991ff3..cba94a38c06 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -944,12 +944,13 @@ int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) addr.len, addr.s, port); if(server_len < 0 || server_len > sizeof(spec_new) - 1) { - LM_ERR("failed to print server spec string\n"); + LM_ERR("failed to print server spec string (%d)\n", + server_len); return 0; } server_new = (char *)pkg_malloc(server_len + 1); if(server_new == NULL) { - LM_ERR("Error allocating pkg mem\n"); + PKG_MEM_ERROR; return 0; } @@ -969,7 +970,7 @@ int check_cluster_reply(redisReply *reply, redisc_server_t **rsrv) name.len, name.s); return 1; } else { - LM_ERR("ERROR connecting to the new server with " + LM_ERR("failed connecting to the new server with " "name: %.*s\n", name.len, name.s); return 0;

1 0

[kamailio/kamailio] [Warning] Aborted connection 203 to db: 'kamailio' user: 'kamailio' host: 'localhost' (Issue #3906)
by Hieu Nguyen Minh 05 Jul '24

05 Jul '24

After a period of use, this warning occurs continuously and affects the performance of the system. Is this the bug of the system? Currently, I am using version 5.6 and MariaDB 10.5.25 + Galera Cluster. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3906 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3906(a)github.com>

2 2

[kamailio/kamailio] secsipid method to only validate signature without checking the rest of the header (Issue #3784)
by Ben Kaufman 05 Jul '24

05 Jul '24

### Description Currently secsipid has a method to sign arbitrary (json) data (`secsipid_sign`), however it has no converse method to check the signature. Currently, an attempt to check a `div` signature for example will yield a `-303` error (`SIPHdrInfo`). Rather than trying to have full parsing for every possible type of Identity header (which are likely to increase in variety), it would be good to simply check "is this signature valid by trusted key", possibly validating the `iat` timestamp as well, but without any other opinions on the header values. ### Expected behavior A feature to check only the signature of an identity header. #### Actual observed behavior Currently the `secsipid_check_` family of functions fails for non- `shaken` passport types. #### Debugging Data The following DIV identity header was generated by secsipid's `secsipid_sign()` function, so it should be possible to reverse this to validate the signature: ``` Identity: eyJhbGciOiJFUzI1NiIsInBwdCI6ImRpdiIsInR5cCI6InBhc3Nwb3J0IiwieDV1IjoiaHR0cHM6Ly9kLm10c2VjLm1lL2QzYTkvQmZUeGJVTlozS1FMLnBlbSJ9.eyJkZXN0Ijp7InRuIjpbIjE2MTI1NTU0MzIxIl19LCJpYXQiOiIxNzEwMTY5MzQ1Iiwib3JpZyI6eyJ0biI6IjE1NTU3MzU5MzA5In0sImRpdiI6eyJ0biI6IjE5NTI1NTU5ODc2In19.-0QF6-u6zgAQNoAhdiETuhAu7FuRDzxmFch_cTdhcbeWvUZ60NQXxdPM-JucpOtFaEdn9wnFreAZ_6vZoc_Phg;info=<https://d.mtsec.me/d3a9/BfTxbUNZ3KQL.pem>;alg=ES256;ppt=div ``` ### Possible Solutions Because it's fairly straight forward to investigate the JWT, it's not necessary to try to account for every possible passport type, etc. The act of validating the signature is the complicated part, so a function that does only that would be convenient. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: Currently alpine linux 3.19 in a docker container, but it should be pretty reproducible everywhere. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3784 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3784(a)github.com>

3 12

git:master:d13e103a: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: d13e103ad047405e410d22046d354442b5a566f3 URL: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-04T16:31:11+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… Patch: https://github.com/kamailio/kamailio/commit/d13e103ad047405e410d22046d35444… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index 7fe63fc3b20..0ebecec8801 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -245,6 +245,9 @@ Chapter 1. Admin Guide module that uses libssl (OpenSSL library). A safe option is to have the tls module loaded first (be in the first "loadmodule" in Kamailio.cfg). + IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" has + to be set, see the Core Cookbook for possible values. + IMPORTANT: using this module compiled with newer versions of libssl (e.g., v1.1+) may require Kamailio to be started with --atexit=no command line parameters to avoid calling C atexit callbacks inside the

1 0

git:master:91d6a131: etc/kamailio.cfg: set tls_threads_mode to 2
by Daniel-Constantin Mierla 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: 91d6a131ab9d3e58a1560c6305af542c92c2b19f URL: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-04T16:23:39+02:00 etc/kamailio.cfg: set tls_threads_mode to 2 - recommended value for libssl 3.x, which is the library shipped with latest stable popular Linux distros --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… Patch: https://github.com/kamailio/kamailio/commit/91d6a131ab9d3e58a1560c6305af542… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index cd2ecd0109f..94c97f86628 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -230,7 +230,7 @@ tls_max_connections=2048 * 1: use thread executors for process#0 only * 2: no thread executors, but use atfork handler to reset thread-locals to NULL * 3: use thread executors for all processes */ -tls_threads_mode=1 +tls_threads_mode=2 #!endif /* set it to yes to enable sctp and load sctp.so module */

1 0

git:master:234f2ae0: tls: docs - note about tls_threads_mode core parameter
by Daniel-Constantin Mierla 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: 234f2ae07a26af8948a176d10358a0b7039ad1a2 URL: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-04T16:20:47+02:00 tls: docs - note about tls_threads_mode core parameter --- Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… Patch: https://github.com/kamailio/kamailio/commit/234f2ae07a26af8948a176d10358a0b… --- diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml index 5697792655a..3a0416fed61 100644 --- a/src/modules/tls/doc/tls.xml +++ b/src/modules/tls/doc/tls.xml @@ -64,6 +64,10 @@ that uses libssl (OpenSSL library). A safe option is to have the tls module loaded first (be in the first "loadmodule" in &kamailio;.cfg). </para> + <para> + IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" + has to be set, see the Core Cookbook for possible values. + </para> <para> IMPORTANT: using this module compiled with newer versions of libssl (e.g., v1.1+) may require &kamailio; to be started with

1 0

Initial Support for CMake in Kamailio - Feedback Needed!
by Xenofon Karamanos 04 Jul '24

04 Jul '24

Hello all, I've started working on integrating CMake as a build system for the Kamailio. This is an initial step towards potentially offering CMake as an alternative to the current build system across the entire Kamailio project. Right now, the CMake configuration is quite basic and covers only the core module. It offers limited options described in Makefile.defs that are required to build the core module. Some notes regarding the definitions can be found also in the CMakelists.notes<https://github.com/kamailio/kamailio/compare/master...cmake#diff-4e8ba0f2d5…> that made the build failed and maybe it's good to remove from current Makefiles as well, if i am not wrong. Before we consider extending it to other modules and components, i would like some feedback whether you find it useful at all. You can find the initial CMake files in the cmake branch. Please take a look and feel free to share any feedback or suggestions. Your input will be much appreciated and nessecary if we want CMake as a build system. For anyone wanting to try and compile using cmake, here are some basic instructions on how to get you started. Checkout the cmake branch of kamailio repo. Create a new folder, let's call it build. mkdir build && cd build Then run CMake for the configuration cmake .. (you can also then use ccmake . for a visual of the offered options) Build and install using make make -j4 make install OR Build and install using cmake cmake --build . cmake --install . You can of course use the CMake variable CMAKE_INSTALL_PREFIX to change the installation paths as follows and of course other preprocessor defintions: cmake -DCMAKE_INSTALL_PREFIX=./kamailio-cmake -DUSE_TCP=0 .. This will install it in the build/kamailio-cmake folder but fails to build because USE_TCP is required for kamailio to build (Check CMakelists.notes). Thank you all for your continuous contributions and support. Looking forward to hearing your thoughts and insights. Best regards, Xenofon https://github.com/kamailio/kamailio/tree/cmake [https://repository-images.githubusercontent.com/15101579/2d895000-e695-11e9…]<https://github.com/kamailio/kamailio/tree/cmake> GitHub - kamailio/kamailio at cmake<https://github.com/kamailio/kamailio/tree/cmake> Kamailio - The Open Source SIP Server for large VoIP and real-time communication platforms - - GitHub - kamailio/kamailio at cmake github.com

2 7

[kamailio/kamailio] usrloc: refactor some db queries using global usrloc_columns variable (PR #3888)
by Lucian Balaceanu 04 Jul '24

04 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3888 -- Commit Summary -- * usrloc: refactor some db queries using global usrloc_columns variable -- File Changes -- M src/modules/usrloc/udomain.c (260) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3888.patch https://github.com/kamailio/kamailio/pull/3888.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3888 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3888(a)github.com>

2 3

git:master:d923f7b2: usrloc: refactor some db queries using global usrloc_columns variable
by Lucian Balaceanu 04 Jul '24

04 Jul '24

Module: kamailio Branch: master Commit: d923f7b2a3c2fb0df506f9a211065566f6da3747 URL: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2024-07-04T13:08:56+03:00 usrloc: refactor some db queries using global usrloc_columns variable --- Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556… Patch: https://github.com/kamailio/kamailio/commit/d923f7b2a3c2fb0df506f9a21106556…

1 0

[kamailio/kamailio] Kamailio core dum v5.6 (Issue #3859)
by itpanda2024 04 Jul '24

04 Jul '24

we use Kamailio v5.6 and run cncxx module but when run cncxx function , it restart kamailio service and infor core dump -Log ; ay 28 10:08:30 KAM02 kamailio[45289]: 35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check : 2 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: CDR Recording May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check source and dest : 0 va 0 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: thông tin nmp : May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: vao 20 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) INFO: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: vao 3 May 28 10:08:30 KAM02 kamailio[45289]: 35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: huong goi t1 giong t2 \n35(45289) ERROR: {1 83879051 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cap nhạt update fail route May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check : 1 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: telco id 1: 1 \n 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: payment_method: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: IP telco 1: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: credit_money : 10.000000 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: customer_id : htc May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: start_cost : 0.000 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cps : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: initial_p : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: final_p : 0 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) INFO: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} app_perl [kamailioxs.xs:489]: XS_Kamailio_log(): >>> input: 10.000000, 0, <= May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) INFO: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} app_perl [kamailioxs.xs:489]: XS_Kamailio_log(): >>> return -1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check credit : -1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: check cuoc realtime May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: IP telco 2: 1 May 28 10:08:30 KAM02 kamailio[45257]: 3(45257) ERROR: {1 83965494 INVITE 592b5ff7-9742-123d-7eb8-00505697ee23} <script>: cap nhạt update fail route May 28 10:08:35 KAM02 kamailio[45262]: 8(45262) ERROR: {1 83965494 ACK 592b5ff7-9742-123d-7eb8-00505697ee23} uac [replace.c:660]: restore_uri(): new URI [] shorter than old URI [sip:0868233455@125.212.210.235:65000] May 28 10:08:36 KAM02 kernel: traps: kamailio[45361] trap divide error ip:7f0ebbc39ec7 sp:7fffe1365020 error:0 in cnxcc.so[7f0ebbc39000+3c000] May 28 10:08:36 KAM02 systemd[1]: Started Process Core Dump (PID 46616/UID 0). May 28 10:08:37 KAM02 systemd-coredump[46617]: Process 45361 (kamailio) of user 982 dumped core.#012#012Stack trace of thread 45361:#012#0 0x00007f0ebbc39ec7 check_calls_by_money (cnxcc.so + 0x3ec7)#012#1 0x00000000006c5f2a fork_basic_timer (kamailio + 0x2c5f2a)#012#2 0x00007f0ebbc41a2c __child_init (cnxcc.so + 0xba2c)#012#3 0x0000000000636f94 init_mod_child (kamailio + 0x236f94)#012#4 0x0000000000636bde init_mod_child (kamailio + 0x236bde)#012#5 0x000000000063778f init_child (kamailio + 0x23778f)#012#6 0x000000000042f78d main_loop (kamailio + 0x2f78d)#012#7 0x000000000043995c main (kamailio + 0x3995c)#012#8 0x00007f0ec2629590 __libc_start_call_main (libc.so.6 + 0x29590)#012#9 0x00007f0ec2629640 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x29640)#012#10 0x000000000041dc35 _start (kamailio + 0x1dc35)#012ELF object binary architecture: AMD x86-64 May 28 10:08:37 KAM02 systemd[1]: systemd-coredump(a)4-46616-0.service: Deactivated successfully. May 28 10:08:37 KAM02 kamailio[45363]: 109(45363) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 115 May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) ALERT: <core> [main.c:783]: handle_sigs(): child process 45361 exited by a signal 8 May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) ALERT: <core> [main.c:787]: handle_sigs(): core was generated May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) INFO: <core> [main.c:810]: handle_sigs(): terminating due to SIGCHLD May 28 10:08:37 KAM02 kamailio[45256]: 2(45256) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45259]: 5(45259) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45359]: 105(45359) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45260]: 6(45260) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45262]: 8(45262) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45264]: 10(45264) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45267]: 13(45267) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45357]: 103(45357) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45271]: 17(45271) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45273]: 19(45273) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45265]: 11(45265) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45263]: 9(45263) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45276]: 22(45276) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45353]: 99(45353) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45278]: 24(45278) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45281]: 27(45281) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45283]: 29(45283) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45269]: 15(45269) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45268]: 14(45268) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45362]: 108(45362) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45285]: 31(45285) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45288]: 34(45288) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45274]: 20(45274) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45272]: 18(45272) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45280]: 26(45280) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45275]: 21(45275) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45286]: 32(45286) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45352]: 98(45352) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45290]: 36(45290) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45294]: 40(45294) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45277]: 23(45277) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45296]: 42(45296) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45279]: 25(45279) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45299]: 45(45299) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45304]: 50(45304) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45257]: 3(45257) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45306]: 52(45306) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45282]: 28(45282) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45308]: 54(45308) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45300]: 46(45300) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45284]: 30(45284) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45302]: 48(45302) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45255]: 1(45255) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45287]: 33(45287) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45310]: 56(45310) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45315]: 61(45315) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45295]: 41(45295) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45258]: 4(45258) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45297]: 43(45297) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45301]: 47(45301) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45312]: 58(45312) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45314]: 60(45314) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45292]: 38(45292) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45303]: 49(45303) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45317]: 63(45317) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45305]: 51(45305) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45261]: 7(45261) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45360]: 106(45360) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45319]: 65(45319) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45321]: 67(45321) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45307]: 53(45307) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45323]: 69(45323) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45309]: 55(45309) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45289]: 35(45289) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45311]: 57(45311) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45348]: 94(45348) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45340]: 86(45340) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45313]: 59(45313) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45291]: 37(45291) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45316]: 62(45316) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45318]: 64(45318) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45293]: 39(45293) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45324]: 70(45324) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45270]: 16(45270) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45320]: 66(45320) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45266]: 12(45266) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45332]: 78(45332) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45326]: 72(45326) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45322]: 68(45322) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45356]: 102(45356) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45328]: 74(45328) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45330]: 76(45330) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45325]: 71(45325) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45327]: 73(45327) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45334]: 80(45334) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45329]: 75(45329) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45331]: 77(45331) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45336]: 82(45336) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45333]: 79(45333) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45335]: 81(45335) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45338]: 84(45338) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45342]: 88(45342) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45344]: 90(45344) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45346]: 92(45346) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45354]: 100(45354) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45339]: 85(45339) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45337]: 83(45337) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45351]: 97(45351) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45349]: 95(45349) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45341]: 87(45341) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45355]: 101(45355) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45343]: 89(45343) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45358]: 104(45358) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45350]: 96(45350) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45345]: 91(45345) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45347]: 93(45347) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45298]: 44(45298) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45363]: 109(45363) INFO: <core> [main.c:866]: sig_usr(): signal 15 received May 28 10:08:37 KAM02 kamailio[45254]: 0(45254) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Main process exited, code=exited, status=1/FAILURE May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Failed with result 'exit-code'. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Consumed 1.023s CPU time. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Scheduled restart job, restart counter is at 2. May 28 10:08:37 KAM02 systemd[1]: Stopped kamailio - the Open Source SIP Server. May 28 10:08:37 KAM02 systemd[1]: kamailio.service: Consumed 1.023s CPU time. May 28 10:08:37 KAM02 systemd[1]: Started kamailio - the Open Source SIP Server. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: rtimer [rtimer_mod.c:299]: stm_t_param(): created rtimer name=cdr interval=300 mode=1 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/tcp_main.c:5105]: init_tcp(): using epoll_lt as the io watch method (auto detected) May 28 10:08:37 KAM02 kamailio[46624]: Listening on May 28 10:08:37 KAM02 kamailio[46624]: udp: 125.212.210.235:65000 May 28 10:08:37 KAM02 kamailio[46624]: udp: 172.16.172.245:65000 May 28 10:08:37 KAM02 kamailio[46624]: udp: 172.16.172.246:65000 May 28 10:08:37 KAM02 kamailio[46624]: Aliases: May 28 10:08:37 KAM02 kamailio[46624]: udp: KAM02:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: http_client [http_client.c:316]: mod_init(): HTTP proxy port set to 0. Disabling HTTP proxy May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:375]: load_pcres(): num groups = 4 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[0]>((^09[03]\d{7}$#015)|(^089\d{7}$#015)|(^07\d{8}$#015))</group[0]> (size = 45) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[1]>((^09[6-8]\d{7}$#015)|(^086\d{7}$#015)|(^03\d{8}$#015))</group[1]> (size = 46) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[2]>((^09[14]\d{7}$#015)|(^08[1-58]\d{7}$#015))</group[2]> (size = 37) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: regex [regex_mod.c:377]: load_pcres(): <group[3]>((^02[48]\d{8}$#015)|(^842[48]\d{8}$))</group[3]> (size = 35) May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: outbound [outbound_mod.c:117]: mod_init(): "stun" module is not loaded. STUN is required to use outbound with UDP. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: pike [pike.c:93]: pike_init(): PIKE - initializing May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: pike [ip_tree.c:79]: init_lock_set(): probing 256 set size May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:210]: parser_init(): setting lib path: '/usr/local/lib64/kamailio/perl/' May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:242]: parser_init(): successfully loaded perl file "/usr/local/etc/plugin/realtime-payment/scripts/aaa-script.pl" May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: app_perl [app_perl_mod.c:345]: mod_init(): perl interpreter has been initialized (1716865717.772062 => 1716865717.813451) May 28 10:08:37 KAM02 kamailio[46624]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.236:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.237:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 125.212.210.238:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.244:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.243:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 172.16.172.242:65000 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: dispatcher [dispatch.c:407]: pack_dest(): uri without sip scheme - fixing it: 101.99.1.36:5060 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: cnxcc [cnxcc_mod.c:246]: __mod_init(): Loading cnxcc module May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: drouting [drouting.c:279]: dr_init(): DRouting - initializing May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [main.c:3150]: main(): processes (at least): 110 - shm size: 67108864 - pkg size: 8388608 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_IN_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) WARNING: tm [tm.c:527]: fixup_routes(): t_on_failure("MS_OUT_FAILURE"): empty/non existing route May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 8 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 8 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 9 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 9 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 for fd 10 May 28 10:08:37 KAM02 kamailio[46624]: 0(46624) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 on fd 10 May 28 10:08:37 KAM02 kamailio[46625]: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a f -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3859 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3859(a)github.com>

3 15

[kamailio/kamailio] db_redis: change logs on delete (PR #3892)
by Stefan Mititelu 03 Jul '24

03 Jul '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Issue: when using usrloc with db_redis, I get constant WARNING logs for 'delete' via usrloc timer. The real WARNING, in my opinion, is when doing full table scans(which is already logged as so). Make logs less important when performing table scans using a match key. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3892 -- Commit Summary -- * db_redis: change logs on delete -- File Changes -- M src/modules/db_redis/redis_dbase.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3892.patch https://github.com/kamailio/kamailio/pull/3892.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3892(a)github.com>

3 8

git:master:97ba5dff: db_redis: change logs on delete
by Stefan Mititelu 03 Jul '24

03 Jul '24

Module: kamailio Branch: master Commit: 97ba5dff468fc309acc9245108a0d7645fe45361 URL: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Author: Stefan-Cristian Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro> Date: 2024-07-03T18:27:03+03:00 db_redis: change logs on delete --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… Patch: https://github.com/kamailio/kamailio/commit/97ba5dff468fc309acc9245108a0d76… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index 84c0c3a9459..b3624975cf4 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -1827,13 +1827,13 @@ static int db_redis_perform_delete(const db1_con_t *_h, km_redis_con_t *con, "performing delete\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s); else - LM_WARN("performing table scan on table '%.*s' while performing " - "delete using match key " - "'%.*s' at offset %llx\n", + LM_DBG("performing table scan on table '%.*s' while performing " + "delete using match key " + "'%.*s' at offset %llx\n", CON_TABLE(_h)->len, CON_TABLE(_h)->s, ts_scan_key->len, ts_scan_key->s, (unsigned long long)ts_scan_start); for(i = 0; i < _n; ++i) { - LM_WARN(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); + LM_DBG(" scan key %d is '%.*s'\n", i, _k[i]->len, _k[i]->s); } if(db_redis_scan_query_keys(con, CON_TABLE(_h), _n, keys, keys_count, manual_keys, manual_keys_count, ts_scan_start, ts_scan_key,

1 0

Kamailio v5.6.6 Released
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, Kamailio SIP Server v5.6.6 stable release is out. This is a maintenance release of the latest stable branch, 5.6, that includes fixes since the release of v5.6.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.6.x. Deployments running previous v5.6.x versions are strongly recommended to be upgraded to v5.6.6. Note that 5.6 is now the third last stable branch, v5.6.6 being the last planned released in 5.5.x series. The latest two stable branch are 5.7 and 5.8, with v5.8.2 being released a while ago. For more details about version 5.6.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-6-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services Kamailio Advanced Training -- asipto.com

1 0

git:5.6:144b61dc: ChangeLog: content updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 144b61dc9e66f574e6a32a7dcd3b3e3e1343666f URL: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:51:14+02:00 ChangeLog: content updated for v5.6.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3… Patch: https://github.com/kamailio/kamailio/commit/144b61dc9e66f574e6a32a7dcd3b3e3…

1 0

git:5.6:fe1c5b4c: Makefile.defs: version set to 5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: fe1c5b4c42795be5218ddc88a3245ed8be9865c7 URL: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:29:23+02:00 Makefile.defs: version set to 5.6.6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… Patch: https://github.com/kamailio/kamailio/commit/fe1c5b4c42795be5218ddc88a3245ed… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 872c5fc5d90..b3c1c74d135 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 6 -SUBLEVEL = 5 +SUBLEVEL = 6 EXTRAVERSION = # memory manager switcher

1 0

git:5.6:80926422: pkg: deb specs updated for v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 80926422b3aa0c98dfb73aa9a87eece98efb1ff8 URL: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:28:36+02:00 pkg: deb specs updated for v5.6.6 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece… Patch: https://github.com/kamailio/kamailio/commit/80926422b3aa0c98dfb73aa9a87eece…

1 0

git:5.6:6cea0990: pkg: version set to 5.6.6 for rpms and alpine specs
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Module: kamailio Branch: 5.6 Commit: 6cea09909229abe759d2bf860ea93e714699feae URL: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-03T08:27:54+02:00 pkg: version set to 5.6.6 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… Patch: https://github.com/kamailio/kamailio/commit/6cea09909229abe759d2bf860ea93e7… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index a409d8fdde6..9662c1d5873 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.6.5 +pkgver=5.6.6 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 075321ec592..eb0e821f76a 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.6.5 +%define ver 5.6.6 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.6.6
by Daniel-Constantin Mierla 03 Jul '24

03 Jul '24

Hello, I am considering to release Kamailio v5.6.6 (out of branch 5.6) later this week (likely on Wednesday, July 3, 2024). If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. This is going to be the last release out of branch 5.6 to mark the end of official/packaging maintenance. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

[kamailio/kamailio] rtpengine: show errno and error string in more places where it is useful (PR #3899)
by Oded Arbel 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description In `send_rtpp_command()` if socket operations fail with an error other than `EINTR` or `ENOBUFS`, the actual error is not reported - we just get a generic "Can't send command to/read reply from RTPEngine". Other places in the module report `errno` and `strerror(errno)` using the log format "`(%s:%d)`" so added that to the error log. Also fixed `bind_force_send_ip()` error log to use the same semantic as the other places. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3899 -- Commit Summary -- * rtpengine: show errno and error string in more places where it is useful -- File Changes -- M src/modules/rtpengine/rtpengine.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3899.patch https://github.com/kamailio/kamailio/pull/3899.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3899 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3899(a)github.com>

2 9

git:master:fae2a467: rtpengine: show errno and error string in more places where it is useful (#3899)
by GitHub 02 Jul '24

02 Jul '24

Module: kamailio Branch: master Commit: fae2a467cb7b543920cf8bea3ce655ad07b70969 URL: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Author: Oded Arbel <oded(a)geek.co.il> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T08:19:11-04:00 rtpengine: show errno and error string in more places where it is useful (#3899) Also fixed bind_force_send_ip() error log to use the same semantic as other places --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… Patch: https://github.com/kamailio/kamailio/commit/fae2a467cb7b543920cf8bea3ce655a… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 54f22b1843f..7b97a2ae1ee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -830,7 +830,7 @@ static int bind_force_send_ip(int sock_idx) sizeof(ip6addr))) < 0) { LM_ERR("can't bind socket to required ipv6 interface\n"); - LM_ERR("ret=%d errno=%d\n", ret, errno); + LM_ERR("ret=%d (%s:%d)\n", ret, strerror(errno), errno); return -1; } @@ -3598,7 +3598,7 @@ static char *send_rtpp_command( struct rtpp_node *node, bencode_item_t *dict, int *outlen) { struct sockaddr_un addr; - int fd, len, i, vcnt; + int fd = -1, len, i, vcnt; int rtpengine_retr, rtpengine_tout_ms = 1000; char *cp; static char buf[0x40000]; @@ -3632,8 +3632,8 @@ static char *send_rtpp_command( goto badproxy; } if(connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { - close(fd); - LM_ERR("can't connect to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't connect to RTPEngine <%s> (%s:%d)\n", node->rn_url.s, + strerror(errno), errno); goto badproxy; } @@ -3641,18 +3641,19 @@ static char *send_rtpp_command( len = writev(fd, v + 1, vcnt); } while(len == -1 && errno == EINTR); if(len <= 0) { - close(fd); - LM_ERR("can't send command to RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't send command to RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } do { len = read(fd, buf, sizeof(buf) - 1); } while(len == -1 && errno == EINTR); - close(fd); if(len <= 0) { - LM_ERR("can't read reply from RTPEngine <%s>\n", node->rn_url.s); + LM_ERR("can't read reply from RTPEngine <%s> (%s:%d)\n", + node->rn_url.s, strerror(errno), errno); goto badproxy; } + close(fd); } else if(node->rn_umode == RNU_WS || node->rn_umode == RNU_WSS) { /* assemble full request string, flatten iovec */ v[0].iov_base = gencookie(); @@ -3721,8 +3722,9 @@ static char *send_rtpp_command( } while(len == -1 && (errno == EINTR || errno == ENOBUFS)); if(len <= 0) { bencode_get_str(bencode_dictionary_get(dict, "command"), &cmd); - LM_ERR("can't send command \"%.*s\" to RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + LM_ERR("can't send command \"%.*s\" to RTPEngine <%s> " + "(%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), errno); goto badproxy; } while((poll(fds, 1, rtpengine_tout_ms) == 1) @@ -3734,8 +3736,9 @@ static char *send_rtpp_command( bencode_get_str( bencode_dictionary_get(dict, "command"), &cmd); LM_ERR("can't read reply for command \"%.*s\" from " - "RTPEngine <%s>\n", - cmd.len, cmd.s, node->rn_url.s); + "RTPEngine <%s> (%s:%d)\n", + cmd.len, cmd.s, node->rn_url.s, strerror(errno), + errno); goto badproxy; } if(len >= (v[0].iov_len - 1) @@ -3767,6 +3770,7 @@ static char *send_rtpp_command( return cp; badproxy: + close(fd); return NULL; }

1 0

[kamailio/kamailio] misc/examples/ims/icscf: fix bad prefix added on all incoming requests (PR #3900)
by Dragos Vingarzan 02 Jul '24

02 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to PR https://github.com/kamailio/kamailio/pull/3891 - splitting by components #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3900 -- Commit Summary -- * misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF -- File Changes -- M misc/examples/ims/icscf/kamailio.cfg (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3900.patch https://github.com/kamailio/kamailio/pull/3900.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3900 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3900(a)github.com>

3 2

git:master:b753682b: misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900)
by GitHub 02 Jul '24

02 Jul '24

Module: kamailio Branch: master Commit: b753682bdfa722280ed2dd3ca79b790f5c7529d1 URL: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-02T11:41:25+02:00 misc/examples/ims/icscf: removed always adding a plus as a prefix on requests arriving to the I-CSCF (#3900) --- Modified: misc/examples/ims/icscf/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… Patch: https://github.com/kamailio/kamailio/commit/b753682bdfa722280ed2dd3ca79b790… --- diff --git a/misc/examples/ims/icscf/kamailio.cfg b/misc/examples/ims/icscf/kamailio.cfg index 4434e6a25d6..1fb51fef680 100644 --- a/misc/examples/ims/icscf/kamailio.cfg +++ b/misc/examples/ims/icscf/kamailio.cfg @@ -238,10 +238,6 @@ route{ xlog("I-CSCF >>>>>>>>>>>>>>>>>>>> $rm $ru ($fu => $tu ($si:$sp) to $tu, $ci)\n"); #!endif - if !($rU =~ "\+.*") { - prefix("+"); - } - # per request initial checks route(REQINIT);

1 0

Kamailio v5.7.6 Released
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Hello, Kamailio SIP Server v5.7.6 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.6. For more details about version 5.7.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/07/kamailio-v5-7-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Note that 5.7.x is currently the previous stable release series, the latest is 5.8.x and v5.8.2 was released on June 12, 2024. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 0

git:5.7:c718a79c: ChangeLog: content updated for v5.7.6
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Module: kamailio Branch: 5.7 Commit: c718a79c45497f1fcaeaaee7a6d5d7f50bdceae9 URL: https://github.com/kamailio/kamailio/commit/c718a79c45497f1fcaeaaee7a6d5d7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-02T09:34:17+02:00 ChangeLog: content updated for v5.7.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/c718a79c45497f1fcaeaaee7a6d5d7f… Patch: https://github.com/kamailio/kamailio/commit/c718a79c45497f1fcaeaaee7a6d5d7f…

1 0

git:5.7:18cc7c0b: Makefile.defs: version set to 5.7.6
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Module: kamailio Branch: 5.7 Commit: 18cc7c0ba02ee44c19e9a5c977360e14cf26b0d6 URL: https://github.com/kamailio/kamailio/commit/18cc7c0ba02ee44c19e9a5c977360e1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-02T08:59:05+02:00 Makefile.defs: version set to 5.7.6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/18cc7c0ba02ee44c19e9a5c977360e1… Patch: https://github.com/kamailio/kamailio/commit/18cc7c0ba02ee44c19e9a5c977360e1… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 3a73dadcce2..c598d6cb02c 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 7 -SUBLEVEL = 5 +SUBLEVEL = 6 EXTRAVERSION = # memory manager switcher

1 0

git:5.7:53107722: pkg: deb specs updated for v5.7.6
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Module: kamailio Branch: 5.7 Commit: 531077222387d30cb491c8af50db521fe3760da1 URL: https://github.com/kamailio/kamailio/commit/531077222387d30cb491c8af50db521… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-02T08:58:22+02:00 pkg: deb specs updated for v5.7.6 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/531077222387d30cb491c8af50db521… Patch: https://github.com/kamailio/kamailio/commit/531077222387d30cb491c8af50db521…

1 0

git:5.7:50787da0: pkg: version set to 5.7.6 for rpms and alpine specs
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Module: kamailio Branch: 5.7 Commit: 50787da0ff908a33ece6cf8a341bc5d7c244ad99 URL: https://github.com/kamailio/kamailio/commit/50787da0ff908a33ece6cf8a341bc5d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-02T08:57:26+02:00 pkg: version set to 5.7.6 for rpms and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/50787da0ff908a33ece6cf8a341bc5d… Patch: https://github.com/kamailio/kamailio/commit/50787da0ff908a33ece6cf8a341bc5d… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index 9d84ac66e74..c9a6b828707 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.7.5 +pkgver=5.7.6 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 7b39ad333ff..814de137d9a 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.7.5 +%define ver 5.7.6 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing v5.7.6
by Daniel-Constantin Mierla 02 Jul '24

02 Jul '24

Hello, I am considering to release Kamailio v5.7.6 (out of branch 5.7) on Tuesday, July 2, 2024. If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 1

[kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)
by Dragos Vingarzan 01 Jul '24

01 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  https://datatracker.ietf.org/doc/html/rfc3265#section-3.2.2 says that if a NOTIFY fails, the subscription should be removed. There is one exception only, when a Retry-After is specified. This is done in order to cleanup state and not keep it around for huge periods of time. This is preferred and the client is the one that should re-subscribe at intervals to fix the situation. Anyway, I guess I was super annoyed by the huge number of useless notifications that I'm getting for gone IMS clients. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3895 -- Commit Summary -- * ims_registrar_scscf: drop subscription on notification failure -- File Changes -- M src/modules/ims_registrar_scscf/registrar_notify.c (153) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3895.patch https://github.com/kamailio/kamailio/pull/3895.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3895 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3895(a)github.com>

2 5

git:master:0c7affcd: ims_registrar_scscf: drop subscription on notification failure (#3895)
by GitHub 01 Jul '24

01 Jul '24

Module: kamailio Branch: master Commit: 0c7affcde380af433ce3373248a9544450261e1b URL: https://github.com/kamailio/kamailio/commit/0c7affcde380af433ce3373248a9544… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-01T21:34:17+02:00 ims_registrar_scscf: drop subscription on notification failure (#3895) --- Modified: src/modules/ims_registrar_scscf/registrar_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/0c7affcde380af433ce3373248a9544… Patch: https://github.com/kamailio/kamailio/commit/0c7affcde380af433ce3373248a9544…

1 0

[kamailio/kamailio] ims_registrar_scscf: fix for location AOR with empty host (PR #3897)
by Dragos Vingarzan 01 Jul '24

01 Jul '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The `ims_registrar_scscf` was not able to function with global-number tel-URIs. This fix prevents a bad AOR to search by from being formed, when the host part of Request-URI is empty. e.g. INVITE with Request-URI `tel:+123` --> AOR to search by was `tel:+123@` --> not found in `ims_usrloc_scscf` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3897 -- Commit Summary -- * ims_registrar_scscf: fix for location AOR with empty host -- File Changes -- M src/modules/ims_registrar_scscf/lookup.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3897.patch https://github.com/kamailio/kamailio/pull/3897.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3897 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3897(a)github.com>

2 3

git:master:12c30d56: ims_registrar_scscf: fix for location AOR with empty host (#3897)
by GitHub 01 Jul '24

01 Jul '24

Module: kamailio Branch: master Commit: 12c30d5606213eaf14c250e572545c3f8b37d50b URL: https://github.com/kamailio/kamailio/commit/12c30d5606213eaf14c250e572545c3… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-07-01T13:56:02+02:00 ims_registrar_scscf: fix for location AOR with empty host (#3897) --- Modified: src/modules/ims_registrar_scscf/lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/12c30d5606213eaf14c250e572545c3… Patch: https://github.com/kamailio/kamailio/commit/12c30d5606213eaf14c250e572545c3… --- diff --git a/src/modules/ims_registrar_scscf/lookup.c b/src/modules/ims_registrar_scscf/lookup.c index 99707dae0ce..6a6e7d70d4f 100644 --- a/src/modules/ims_registrar_scscf/lookup.c +++ b/src/modules/ims_registrar_scscf/lookup.c @@ -115,8 +115,9 @@ int lookup(struct sip_msg *_m, udomain_t *_d, char *ue_type_c) // add user part memcpy(aor.s + aor.len, _m->parsed_uri.user.s, _m->parsed_uri.user.len); aor.len += _m->parsed_uri.user.len; - // add '@' - aor.s[aor.len++] = '@'; + // add '@' - but only if there is a host part, else we make bad URIs like tel:+123@ + if(_m->parsed_uri.host.len > 0) + aor.s[aor.len++] = '@'; // add host part memcpy(aor.s + aor.len, _m->parsed_uri.host.s, _m->parsed_uri.host.len); aor.len += _m->parsed_uri.host.len;

1 0

git:master:b8c1bab2: pv: increase PV_ESCSTR_SIZE to 32
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: master Commit: b8c1bab290eaf1e26862c73c1add9d104c9841c0 URL: https://github.com/kamailio/kamailio/commit/b8c1bab290eaf1e26862c73c1add9d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T13:47:16+02:00 pv: increase PV_ESCSTR_SIZE to 32 --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/b8c1bab290eaf1e26862c73c1add9d1… Patch: https://github.com/kamailio/kamailio/commit/b8c1bab290eaf1e26862c73c1add9d1… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index ca0a7388475..772fe872a93 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1488,7 +1488,7 @@ int pv_get_body_size(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) } -#define PV_ESCSTR_SIZE 16 +#define PV_ESCSTR_SIZE 32 int pv_get_escstr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { static char _pv_escstr[PV_ESCSTR_SIZE];

1 0

git:5.6:825b3655: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.6 Commit: 825b36557be137fd51626c8cdbc80027b79afa2b URL: https://github.com/kamailio/kamailio/commit/825b36557be137fd51626c8cdbc8002… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-01T10:31:33+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/smsops/README Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/825b36557be137fd51626c8cdbc8002… Patch: https://github.com/kamailio/kamailio/commit/825b36557be137fd51626c8cdbc8002…

1 0

git: new commits in branch 5.6
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

- URL: https://github.com/kamailio/kamailio/commit/1b96bb4a5a667c9838441876838d3c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:59:39+02:00 core: parse privacy recompute lenght of rest to parse (cherry picked from commit 804ee651b45498727196886c97cb55d20b254c4a) (cherry picked from commit 8674b333300d5829bff9cb4993886bcf7bea249b) - URL: https://github.com/kamailio/kamailio/commit/f1d593b55f4334c1ac1e61c7dd5775a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:59:53+02:00 pv: remove extra len increment for some uri transformations (cherry picked from commit 3fe9a279abecf6f367ce9fd2d4b085c41c87ad77) (cherry picked from commit 75aecd3f2e10509d5ed71cc5e89ae6f5c3bd0fea) - URL: https://github.com/kamailio/kamailio/commit/6ed780aa1eea71c9c789809fce91d4a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:00:59+02:00 core: set proto on fixing forward actions (cherry picked from commit e51ccd11fe51f2d53dd7719b8fdec561a6ba7494) (cherry picked from commit 18fead63dca0982df500b35b7c4e2d06550d9b40) - URL: https://github.com/kamailio/kamailio/commit/a8fe0bf1f07fba7662bea122e5f2ff0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:01:08+02:00 dialog: prevent duplicate of leg1 attributes in json for dmq - reported by #3656 (cherry picked from commit ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2) (cherry picked from commit 065203150aaf2f99bd6fe40ce5ffb960bd430c16) - URL: https://github.com/kamailio/kamailio/commit/a7dd64a7d9183caccfdc280eb4f5d67… Author: Pe��ter Baraba��s <peter.barabas(a)securesoft.hu> Date: 2024-07-01T10:01:20+02:00 uac: fix socket length settings - set _uac_req.s_sock.len value to 0 in pv_set_uac_req() method in case of "all" case - change setting of _uac_req.s_apasswd.len to _uac_req.s_sock.len in pv_set_uac_req() method in case of "sock" case (cherry picked from commit 10519d199f6cac116399f4473bd82f2b08de72ba) (cherry picked from commit 3046d01bed4bdd0fe763fd770ffc8f7aeeae3418) - URL: https://github.com/kamailio/kamailio/commit/fbc0728080c3846f49b34e56daf0ba2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:01:37+02:00 dialog: check first the size (cherry picked from commit 9db18bc48bff0d230e66973a45c8e72e1b7744e8) (cherry picked from commit 37621005e38a0191a93fbaf4f39b8b88c7486c9d) - URL: https://github.com/kamailio/kamailio/commit/f80a035be2846ab36cfe4209e210f0a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:01:54+02:00 core: check if conversion could not be done (cherry picked from commit 077651fa3bfd50e0f654c907f3783b1421497bd5) (cherry picked from commit 62b76c076ff0f36b847a13c180b7d5090e98d94e) - URL: https://github.com/kamailio/kamailio/commit/c9f7bdb6024a05f03067c73e4a6e40b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:02:12+02:00 pv: typo in transformation log message (cherry picked from commit ca2a9479adf720e67bf50c9d2795cc8937e223dc) (cherry picked from commit 2d385c1983a921a95fb392e8aea0332fdc10a387) - URL: https://github.com/kamailio/kamailio/commit/bc81c9ae6e9bc22198e19be520255f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:02:39+02:00 pv: removed unnecessary condition (cherry picked from commit 2f43510be37c157f800389dfb432b6c52d7435a7) (cherry picked from commit 5a26d9e9fba36a49a93bb3b886836615f62ed3d1) - URL: https://github.com/kamailio/kamailio/commit/c9e9112322cc392edc9071c35701d86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:03:13+02:00 statsd: use bool type for local variable to match return of function (cherry picked from commit 0186246fce8f0e4bb46b30c05174983cd957a3ba) (cherry picked from commit fc0bd88b55121e3588f5793480f0594e44bf2b17) - URL: https://github.com/kamailio/kamailio/commit/bd5f2d21f7aa64647ce24bdd16e565a… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2024-07-01T10:03:36+02:00 dialog: fixed saving dialogs on shutdown that are already loaded at startup when using db_mode 3 - The dialogs that loaded at startup are not saved in DB on shutdown, and so not loaded at restart, fixes issue #3669 (cherry picked from commit 2d00ce546bb0852dc1784d5bc2e794d06f919577) (cherry picked from commit 37a07037b6e3485f3ddd1b27b1998af6e4283bcb) - URL: https://github.com/kamailio/kamailio/commit/785b962507a21191a345add832bb241… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2024-07-01T10:04:11+02:00 http_async_client: exit mod_init if tm is not loaded (cherry picked from commit 5a40d1ef1b484c4fc437a3f0183a101241e80313) (cherry picked from commit 2dff6f52d1393cf8eabe714262ec8e56aad0d212) - URL: https://github.com/kamailio/kamailio/commit/b19b38f7d9a5b7568bd180e57027367… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:04:30+02:00 core: keep listen socket even if advertise address does not resolve - the core advertise_address parameter works in the same fashion - previously it was starting by skipping the listen, which resulted in unexpected runtime list of sockets (cherry picked from commit b50036200c5bc09fd2d412a18585b42d63763b27) (cherry picked from commit a539ca32ec3a898e354aab90d899b99564064392) - URL: https://github.com/kamailio/kamailio/commit/a5615fb833433eec6c9184ae8bfb245… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:06:05+02:00 topos: small rearangement by removing else after return in the true block - reduce level of indentation - a few wraps in curly braces for clearer view of the if block (cherry picked from commit b6fccea258e56b7d3195659245713a6d44acb013) (cherry picked from commit 772b464552cff0b9ebb769e57fae718c0357ba11) (cherry picked from commit 0f31190eb15b1e1244f478cc9538bf071317cb35) - URL: https://github.com/kamailio/kamailio/commit/fc9f03bf3f792acbc4ca4ae65881961… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:06:13+02:00 topos: properly handle cases of no user in contact for mode 1 - contact mode 1 accepted cases with no-user in contact uri but not in r-uri, however, requests within dialog can have one's contact in r-uri and then processing failed (cherry picked from commit 24e410f9a20d004f55bcc79cd10fb35cb26e4570) (cherry picked from commit 45ee72fcf0ae8aeb135196ef8729fe0cea14048e) (cherry picked from commit 1666d4bce924b8c0d44119491199a164c9642469) - URL: https://github.com/kamailio/kamailio/commit/ae9a257503fc78ad2f10691a14d2a23… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:06:30+02:00 keepalive: proper storing of last up/down timestamps - GH #3790 (cherry picked from commit 9e2a0ee545646bd4491ecdbe58d7fea770764b54) (cherry picked from commit 0b3aa00775a5c0b4b1dc4990f4c26bc637fc6de5) (cherry picked from commit 6a9caa099352a31a2f14012d16c01d55c9250f02) - URL: https://github.com/kamailio/kamailio/commit/5261da60ddfbfd6daf43469527b36f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:07:06+02:00 ndb_redis: fix index on parsing sentinel address inside redisc_reconnect_server() (cherry picked from commit c8f3b496a05ae5bf29341dc7e2630f951d4effc5) (cherry picked from commit 86df978bc9842687035d6673ee1b71e542dcbd71) (cherry picked from commit 4cc28e453d8e62b9f6e2725b9496600c662a8811) - URL: https://github.com/kamailio/kamailio/commit/768c7abe720848e48fcba61d7347d08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:07:34+02:00 ctl: handle int input for double storage (cherry picked from commit 1380a4a0d18159c7130b70c0216134a253ad83f7) (cherry picked from commit 90f8117f9669069b4dab7e9d747dfa06245ec8a0) (cherry picked from commit 29b6562d8ebe6277fda5524dda18b88cf2a4e1a9) - URL: https://github.com/kamailio/kamailio/commit/54c1464db8d074415eeb01fcd0b71db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:08:08+02:00 jansson: declare variables at the beginning of blocks (cherry picked from commit a2bff77c3f7bfee8dae90c3ef20522d480f2e14d) (cherry picked from commit fb685a8bd5d5e34edde44614f313cbb5c27b3c25) - URL: https://github.com/kamailio/kamailio/commit/03e2c458f05dda76128be2031414a7f… Author: Xenofon Karamanos <xk(a)gilawa.com> Date: 2024-07-01T10:08:20+02:00 core: properly handle drop() action for kemi engines - GH #3718 (cherry picked from commit 82593a09f8ef6d53e7e88238c057bbcdd9ab287b) (cherry picked from commit 2758754f2bb427bff06b2a6e82175870eced336d) - URL: https://github.com/kamailio/kamailio/commit/e325a662226888372e230421f5f7371… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:08:55+02:00 core: select - handle ws and wss inside select_ip_port() (cherry picked from commit d8e0942c9e83c8cad7c182bf41c156ba35bf24d2) (cherry picked from commit 089bf63178039b13cde0beccfacab1536af76179) (cherry picked from commit cea618ede170bd02bb7ccd478a4f1a7a6c052cdf) - URL: https://github.com/kamailio/kamailio/commit/44731d40834bcf75282c535a1770f4c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:09:07+02:00 core: parser rr - check for rr value before serializing (cherry picked from commit 6ee26a3ae3293aaeb4507d5d0b16ad31173cc39a) (cherry picked from commit 4626cb7f0e0b273153ce0004900a92553783a893) (cherry picked from commit 92d3b52ca4595a7e4d8ab003951191c387d32eee) - URL: https://github.com/kamailio/kamailio/commit/e4c30d23e87591c61e2c6684a44cd59… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:09:18+02:00 ctl: reset log prefix on reading ctl traffic - it may be previously set in process by some event route (cherry picked from commit 5b8b2717ee2f57da932132683b27eb33cea3fd59) (cherry picked from commit d45c78eeeaea6a9fc9dcb927436f834392d9d7c9) (cherry picked from commit d12613c8e357a8dc882eefe2d84fedd1df97a415) - URL: https://github.com/kamailio/kamailio/commit/a507b2292724ca2e0426f986d422f60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:09:31+02:00 acc: more log messages of failure arsing extra acc string (cherry picked from commit 04a73ace6572dd5c95a8f50b39b2ce712f7ebe84) (cherry picked from commit 91b0962679092f28abb5022d1505372356460f7d) (cherry picked from commit f225edd2fdc87b0ebf72e15d8a11255ddd86b872) - URL: https://github.com/kamailio/kamailio/commit/be6a52a7a685bfd3e3df595ae73030c… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: 2024-07-01T10:09:44+02:00 core: resolve/create_srv_pref_list() - insert at correct position in list (cherry picked from commit f35cf8904119dcf582ea2451648de5fef095466b) (cherry picked from commit dbf9208f3a402844c9981fb7ed09493a1338dfdd) (cherry picked from commit c90b736a098e1d76224c1e97c2a71423efa5cf98) - URL: https://github.com/kamailio/kamailio/commit/71db5b95b4b6125b1aa544efb459197… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: 2024-07-01T10:10:01+02:00 corex: fix conditions for dns_cache modparam srv attributes (cherry picked from commit 8114b2016d032484edafe4edd04fb02d52cfd058) (cherry picked from commit 3f44cabcfc0abc83ae1971ac74fbb0bd36829ce4) (cherry picked from commit a82d1575d9ac7820e526741fc169033767a10ca5) - URL: https://github.com/kamailio/kamailio/commit/980d823b7dd3d14b9656be1e1fc1526… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:10:12+02:00 smsops: reformat module exports structures (cherry picked from commit 9848d43cb367d6901a0b8c727759feb8a8fad930) (cherry picked from commit b21a7aaa467f2b76a52308557657c65274e34087) (cherry picked from commit edbcfff018145372fd6fa5d1777912f0f84d8ea7) - URL: https://github.com/kamailio/kamailio/commit/0df6e369d6cec014361c9808dd8eafa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:10:22+02:00 smsops: short reference section about variables (cherry picked from commit 9a94930ae1168d5df79e3dc1414841cdf23a2eba) (cherry picked from commit c0c8ee05ab25256b9154d2056ee04b07f3f2290a) (cherry picked from commit b3935051a8112b1a2152d8eb65da29b1941735df) - URL: https://github.com/kamailio/kamailio/commit/17066ee9565105adabf6f4f8bcb650a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:10:30+02:00 blst: reformat exported structures (cherry picked from commit e39557c96d2f419184c826d779f1a3309acc4269) (cherry picked from commit e394a05152b29d4009c9cb963bced72526c7651b) (cherry picked from commit f1969ecaacd47eb03ef6b54d71c70370d9e39150) - URL: https://github.com/kamailio/kamailio/commit/a4b0da655bb0e9c64b8790d7b4801e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:10:40+02:00 sdpops: reformat the codecs map (cherry picked from commit 359a442e14a156b0bcf60dc5b2580cbc57924e34) (cherry picked from commit 855c76780c4399d6d9881ce3c525a7df56e111c4) (cherry picked from commit 8bb69fd5f5911098a3e567887ad2a3a2820ae5e6) - URL: https://github.com/kamailio/kamailio/commit/42669bec9c3f3ed75c010f645dddbe5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:11:23+02:00 core: fmsg - parse loopback ip when initializing faked msg structure - GH #3817 (cherry picked from commit 66b3c04a9653425b1602c82dd2456a7eb7cf59d1) (cherry picked from commit 794c2edeaffe059bf8de6ab1d3df5db003ed4cb0) (cherry picked from commit 365bb5d7fd1534e467f8a2d1b120f2c03fc4caff) - URL: https://github.com/kamailio/kamailio/commit/ac221658e9227ec8f04a6a3bef677a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:11:43+02:00 phonenum: Makefile - option to set C standard version - can be set via option CSTDVER - defaults now to c++17 - GH #3659 (cherry picked from commit 6dd5598fc043fe3d2582e643d7d4ef675c9e6480) (cherry picked from commit bec4ad646f127a1f5bbf31604e6185b246867770) - URL: https://github.com/kamailio/kamailio/commit/824a1ce63b974256e6a5e8fdfe8a0f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:14:08+02:00 htable: error on not finding htable in pv set (cherry picked from commit 82cfea317fd8d02a6c94347bc1be18c8a06e580f) (cherry picked from commit 9a7e3e54f1c52ee69c68b1165de115894c2afc55) (cherry picked from commit 239153a860875aba578ba060241fcb419ad98276) - URL: https://github.com/kamailio/kamailio/commit/cc245af6947ac19d53abd3743c8a3f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:14:14+02:00 htable: error on not finding htable in pv get (cherry picked from commit 24b27214231166366cceb88fcb3724298cc53b32) (cherry picked from commit 7087ce6aa496de9b6015e5054d8fd70bf2e055b3) (cherry picked from commit 5da78f619c747edb674970b87426582b90c8bae3) - URL: https://github.com/kamailio/kamailio/commit/32f92d102325eed041d242aa27837df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:14:23+02:00 siputils: free head of params list for get_uri_param() - GH #3857 (cherry picked from commit d72a3fbc903da02ae3b26f3aae2ea228c9f8b255) (cherry picked from commit 833b93563f43fa95e4bfdd175b144670b66a11cd) (cherry picked from commit 5da933f3888ab3981fa8ec4ad255a4e8f3770d2d) - URL: https://github.com/kamailio/kamailio/commit/d90e956f01ba8124d65d6fd6c3de7d3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:14:30+02:00 siputils: free head of params list for get_uri_param() - GH #3857 (cherry picked from commit 8363208fff7c101a2779ff64783e5b7dbf8ffd7c) (cherry picked from commit ebc8acef7617a69dcc06b163c47e88a99d835f9e) (cherry picked from commit d503c70bbc9790073424630ce842b1987cbe2a7c) - URL: https://github.com/kamailio/kamailio/commit/d19843d691e8dc281dd5e49d516ab2c… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-01T10:14:52+02:00 core/resolve: Check dns_cache_init and choose appropriate functions (cherry picked from commit 06d583e356351ae9d8a559c9f5de3e57fb128a38) (cherry picked from commit 5999529be9ac2187dad465518bea3dee1b06d0f7) (cherry picked from commit 22a28b0b0e7f66a8e73d92fcc5f014f722aa2d1f) - URL: https://github.com/kamailio/kamailio/commit/c8c77bebb2c17ad3da5e2cdff467ab5… Author: codenot <codenot(a)msn.com> Date: 2024-07-01T10:15:04+02:00 nathelper: fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (cherry picked from commit 8e0b2e4b6450fa50bd573fa013dc888aaaccd2bf) (cherry picked from commit eb4ec6f9305e334d9749e1fd56ad195c383cef77) (cherry picked from commit 8d1f1843f04d9e1a6db983bf860c76f7a1ac4b40) - URL: https://github.com/kamailio/kamailio/commit/bf5012af8958d3223d54a3021af7eea… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-01T10:15:11+02:00 nathelper: remove magic constant (cherry picked from commit 3d187336f22e30800acefd28e4d0f98e0f677a49) (cherry picked from commit e8dc8506dbc4d8964e02c3be175d7f18f5fe69a4) (cherry picked from commit a11e8ae3f8daae13ba6b162ab050bb7d8c8bd01b) - URL: https://github.com/kamailio/kamailio/commit/e5480572223b3d235762f4b1d773d9e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:15:25+02:00 dmq_usrloc: reformat exported structures (cherry picked from commit e94812149c6f2867a5b23f1218a9af139590bf51) (cherry picked from commit 5571ea0ff8877a8a19b3fb76030af19b59f141db) (cherry picked from commit b1ffd5982329cda6d1e5da008703fe302402ee36) - URL: https://github.com/kamailio/kamailio/commit/bf1306430f26525f78571e93662767f… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2024-07-01T10:15:42+02:00 siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used - send_sock_name/send_sock_address is ineffective for tcp based transports if SND_F_FORCE_SOCKET flag is not set (cherry picked from commit 1b97a0271b27794263b3eff61f4acfa81e66069f) (cherry picked from commit 2606c4e07e598ea41cb5a8814e3587bf49f94c1e) (cherry picked from commit eed224e4906b6691d07ea379727e2ed627c3e80f) - URL: https://github.com/kamailio/kamailio/commit/12ace0b9d8214575ce9b1f5f4947004… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-01T10:15:51+02:00 textopx/doc: fixed hard-to-read documentation for textopsx - was missing line-wraps in examples list, hence very hard to read (cherry picked from commit 48d97c1941f660aa396b5ef100584611cf92ad21) (cherry picked from commit 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975) (cherry picked from commit e017ae88c155c2bd60a9611bca676308695f3c75) - URL: https://github.com/kamailio/kamailio/commit/2ca23caf6c6766a7268ba51f6f67d11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:15:58+02:00 textopsx: docs - note about @hf_value2 select (cherry picked from commit d13c741d90c3887cdf144a9094a78c0c7cb9856d) (cherry picked from commit 70cf3ebd2b52c341a90c9b9b6149985667a6b96c) (cherry picked from commit a0cef6e8689b66f7548fe56eaa79e692d5061e93) - URL: https://github.com/kamailio/kamailio/commit/57003d4382ad5e2e1ea1163005ede0c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:16:06+02:00 core: removed duplicated break (cherry picked from commit 588b9c710b6555371bc8bbee21e474466bb099dd) (cherry picked from commit 4fa5fc10370d81d534d75b034322a6250c7e2557) (cherry picked from commit 1bd30c65b74b30339841c57d2948ea7db9a40fe9) - URL: https://github.com/kamailio/kamailio/commit/559cbb1ea5f0b7da95fc6a864e0e9d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T10:16:16+02:00 cnxcc: check if final pulse is 0 - avoid dividing with it in such case - GH #3859 (cherry picked from commit 7061a79fe64066dd5a6598e38d714bd40bf2eabc) (cherry picked from commit ca3d4b3515024732805038509dd0d9f0b60ab273) (cherry picked from commit a9a337562d1b57afedb31d49764e03c7ebd85f31)

1 0

git:5.7:4d1c41f2: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.7 Commit: 4d1c41f2af5279f6ffbcba59f5b51e06989ba66d URL: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-01T10:01:27+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e0… Patch: https://github.com/kamailio/kamailio/commit/4d1c41f2af5279f6ffbcba59f5b51e0… --- diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README index fa03fdf7b26..6941def2d83 100644 --- a/src/modules/textopsx/README +++ b/src/modules/textopsx/README @@ -731,27 +731,38 @@ bl_iterator_end("b1"); 3.1. @hf_value - Get value of required header-value or param. Note that functions called - 'value2' works with Authorization-like headers where comma is not - treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value, - negative value counts from bottom @hf_value.HFNAME.PARAM_NAME - @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or - .param., useful if required called "uri", "p", "param" - @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri # - (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of - all values (combines headers) @hf_value.HFNAME # the same as above [*] - but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma - delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same - as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name # - returns name part, quotes excluded @hf_value.HFNAME.name # returns name - part of the first value @hf_value2.HFNAME # returns value of first - header @hf_value2.HFNAME[IDX] # returns value of idx's header - @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME - @hf_value.HFNAME[IDX].uri # return URI, quotes excluded - @hf_value.HFNAME.p.uri # returns param named uri, not URI itself - @hf_value.HFNAME.p.name # returns param named name, not name itself - @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be - used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr + Get value of required header-value or param. Note that selects called + 'hf_value2' work with Authorization-like headers where comma is not + treated as value delimiter. + + Formats: + * @hf_value.HFNAME[IDX] # idx value, negative value counts from + bottom + * @hf_value.HFNAME.PARAM_NAME + * @hf_value.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required + called "uri", "p", "param" + * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto + * @hf_value.HFNAME[IDX].uri # (< & > excluded) + * @hf_value.HFNAME[*] # return comma delimited list of all values + (combines headers) + * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y + * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & + > excluded) + * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by + cfg.y + * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded + * @hf_value.HFNAME.name # returns name part of the first value + * @hf_value2.HFNAME # returns value of first header + * @hf_value2.HFNAME[IDX] # returns value of idx's header + * @hf_value2.HFNAME.PARAM_NAME + * @hf_value2.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded + * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself + * @hf_value.HFNAME.p.name # returns param named name, not name itself + * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features + may be used + * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr Meaning of the parameters is as follows: * HFNAME - Header field name. Underscores are treated as dashes. @@ -772,7 +783,9 @@ $prt = @hf_value2.authorization.integrity_protected; 3.2. @hf_value2 - TBA. + Similar to selects called 'hf_value', but work with Authorization-like + headers where comma is treated as attribute delimiter instead of header + value delimiter. 3.3. @hf_value_exists

1 0

git: new commits in branch 5.7
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

- URL: https://github.com/kamailio/kamailio/commit/6173af8d414de313b3ed8ced5e662e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:19:24+02:00 sipcapture: use local static buffers for ip address and port - GH #3835 (cherry picked from commit d1f377ff23f491bfd5162cb7bf510759440dd8e5) (cherry picked from commit 5c4f687d0ed06d6c7a5696917982b1cf03f9c8bd) - URL: https://github.com/kamailio/kamailio/commit/dfbfd307d80c9259f28f3df0874fb7a… Author: Sergey Safarov <s.safarov(a)gmail.com> Date: 2024-07-01T09:19:32+02:00 db_mysql: fixed build on CentOS 7 (cherry picked from commit 767b3faee3af450d6482b919c81431ea6d707807) (cherry picked from commit d53843c75da9115a9c3cb6b1b909fd3827b6c437) - URL: https://github.com/kamailio/kamailio/commit/60335c8fb52b01b2fa6840d7f55ef87… Author: Rick Barenthin <rick(a)ng-voice.com> Date: 2024-07-01T09:19:46+02:00 usrloc: delete location_attrs in db_only mode on delete_urecord When calling delete_urecord in DB_ONLY mode the location_attrs are not deleted. This fix makes sure to delete location_attrs when calling db_delete_urecord is called. (cherry picked from commit 6b8f6d3b5d563d91234b8d4b7e155b7e74b9d313) (cherry picked from commit deb11ee814e1591698d120a113630aa7a9791ad7) - URL: https://github.com/kamailio/kamailio/commit/239153a860875aba578ba060241fcb4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:19:56+02:00 htable: error on not finding htable in pv set (cherry picked from commit 82cfea317fd8d02a6c94347bc1be18c8a06e580f) (cherry picked from commit 9a7e3e54f1c52ee69c68b1165de115894c2afc55) - URL: https://github.com/kamailio/kamailio/commit/5da78f619c747edb674970b87426582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:20:07+02:00 htable: error on not finding htable in pv get (cherry picked from commit 24b27214231166366cceb88fcb3724298cc53b32) (cherry picked from commit 7087ce6aa496de9b6015e5054d8fd70bf2e055b3) - URL: https://github.com/kamailio/kamailio/commit/5da933f3888ab3981fa8ec4ad255a4e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:20:36+02:00 siputils: free head of params list for get_uri_param() - GH #3857 (cherry picked from commit d72a3fbc903da02ae3b26f3aae2ea228c9f8b255) (cherry picked from commit 833b93563f43fa95e4bfdd175b144670b66a11cd) - URL: https://github.com/kamailio/kamailio/commit/d503c70bbc9790073424630ce842b19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:20:48+02:00 siputils: free head of params list for get_uri_param() - GH #3857 (cherry picked from commit 8363208fff7c101a2779ff64783e5b7dbf8ffd7c) (cherry picked from commit ebc8acef7617a69dcc06b163c47e88a99d835f9e) - URL: https://github.com/kamailio/kamailio/commit/22a28b0b0e7f66a8e73d92fcc5f014f… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-01T09:28:33+02:00 core/resolve: Check dns_cache_init and choose appropriate functions (cherry picked from commit 06d583e356351ae9d8a559c9f5de3e57fb128a38) (cherry picked from commit 5999529be9ac2187dad465518bea3dee1b06d0f7) - URL: https://github.com/kamailio/kamailio/commit/8d1f1843f04d9e1a6db983bf860c76f… Author: codenot <codenot(a)msn.com> Date: 2024-07-01T09:28:47+02:00 nathelper: fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (cherry picked from commit 8e0b2e4b6450fa50bd573fa013dc888aaaccd2bf) (cherry picked from commit eb4ec6f9305e334d9749e1fd56ad195c383cef77) - URL: https://github.com/kamailio/kamailio/commit/a11e8ae3f8daae13ba6b162ab050bb7… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-07-01T09:29:12+02:00 nathelper: remove magic constant (cherry picked from commit 3d187336f22e30800acefd28e4d0f98e0f677a49) (cherry picked from commit e8dc8506dbc4d8964e02c3be175d7f18f5fe69a4) - URL: https://github.com/kamailio/kamailio/commit/b1ffd5982329cda6d1e5da008703fe3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:29:22+02:00 dmq_usrloc: reformat exported structures (cherry picked from commit e94812149c6f2867a5b23f1218a9af139590bf51) (cherry picked from commit 5571ea0ff8877a8a19b3fb76030af19b59f141db) - URL: https://github.com/kamailio/kamailio/commit/8c4f102948a7a472c57c260bb2c49bc… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-01T09:30:22+02:00 tls: remove confusing error message when trying to print socket for <default> server > CRITICAL: <core> [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0 > NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ... (cherry picked from commit 87c8290ab934fd27f8baebabaf66d1fb4168ba72) (cherry picked from commit be76a51422df3294c533accae1b6a621ee9d3a7d) - URL: https://github.com/kamailio/kamailio/commit/eed224e4906b6691d07ea379727e2ed… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2024-07-01T09:30:30+02:00 siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used - send_sock_name/send_sock_address is ineffective for tcp based transports if SND_F_FORCE_SOCKET flag is not set (cherry picked from commit 1b97a0271b27794263b3eff61f4acfa81e66069f) (cherry picked from commit 2606c4e07e598ea41cb5a8814e3587bf49f94c1e) - URL: https://github.com/kamailio/kamailio/commit/e017ae88c155c2bd60a9611bca67630… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Date: 2024-07-01T09:31:10+02:00 textopx/doc: fixed hard-to-read documentation for textopsx - was missing line-wraps in examples list, hence very hard to read (cherry picked from commit 48d97c1941f660aa396b5ef100584611cf92ad21) (cherry picked from commit 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975) - URL: https://github.com/kamailio/kamailio/commit/a0cef6e8689b66f7548fe56eaa79e69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:31:18+02:00 textopsx: docs - note about @hf_value2 select (cherry picked from commit d13c741d90c3887cdf144a9094a78c0c7cb9856d) (cherry picked from commit 70cf3ebd2b52c341a90c9b9b6149985667a6b96c) - URL: https://github.com/kamailio/kamailio/commit/1bd30c65b74b30339841c57d2948ea7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:31:26+02:00 core: removed duplicated break (cherry picked from commit 588b9c710b6555371bc8bbee21e474466bb099dd) (cherry picked from commit 4fa5fc10370d81d534d75b034322a6250c7e2557) - URL: https://github.com/kamailio/kamailio/commit/a9a337562d1b57afedb31d49764e03c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:31:38+02:00 cnxcc: check if final pulse is 0 - avoid dividing with it in such case - GH #3859 (cherry picked from commit 7061a79fe64066dd5a6598e38d714bd40bf2eabc) (cherry picked from commit ca3d4b3515024732805038509dd0d9f0b60ab273)

1 0

git:5.8:3161964e: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: 3161964efba19e5e7bd730bf656d019cac2c6ed8 URL: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-07-01T09:16:18+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019… Patch: https://github.com/kamailio/kamailio/commit/3161964efba19e5e7bd730bf656d019… --- diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README index 1759870cb2f..3e2f9e2eb6b 100644 --- a/src/modules/textopsx/README +++ b/src/modules/textopsx/README @@ -731,27 +731,38 @@ bl_iterator_end("b1"); 3.1. @hf_value - Get value of required header-value or param. Note that functions called - 'value2' works with Authorization-like headers where comma is not - treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value, - negative value counts from bottom @hf_value.HFNAME.PARAM_NAME - @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or - .param., useful if required called "uri", "p", "param" - @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri # - (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of - all values (combines headers) @hf_value.HFNAME # the same as above [*] - but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma - delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same - as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name # - returns name part, quotes excluded @hf_value.HFNAME.name # returns name - part of the first value @hf_value2.HFNAME # returns value of first - header @hf_value2.HFNAME[IDX] # returns value of idx's header - @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME - @hf_value.HFNAME[IDX].uri # return URI, quotes excluded - @hf_value.HFNAME.p.uri # returns param named uri, not URI itself - @hf_value.HFNAME.p.name # returns param named name, not name itself - @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be - used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr + Get value of required header-value or param. Note that selects called + 'hf_value2' work with Authorization-like headers where comma is not + treated as value delimiter. + + Formats: + * @hf_value.HFNAME[IDX] # idx value, negative value counts from + bottom + * @hf_value.HFNAME.PARAM_NAME + * @hf_value.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required + called "uri", "p", "param" + * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto + * @hf_value.HFNAME[IDX].uri # (< & > excluded) + * @hf_value.HFNAME[*] # return comma delimited list of all values + (combines headers) + * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y + * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & + > excluded) + * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by + cfg.y + * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded + * @hf_value.HFNAME.name # returns name part of the first value + * @hf_value2.HFNAME # returns value of first header + * @hf_value2.HFNAME[IDX] # returns value of idx's header + * @hf_value2.HFNAME.PARAM_NAME + * @hf_value2.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded + * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself + * @hf_value.HFNAME.p.name # returns param named name, not name itself + * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features + may be used + * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr Meaning of the parameters is as follows: * HFNAME - Header field name. Underscores are treated as dashes. @@ -772,7 +783,9 @@ $prt = @hf_value2.authorization.integrity_protected; 3.2. @hf_value2 - TBA. + Similar to selects called 'hf_value', but work with Authorization-like + headers where comma is treated as attribute delimiter instead of header + value delimiter. 3.3. @hf_value_exists

1 0

git:5.8:ca3d4b35: cnxcc: check if final pulse is 0
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: ca3d4b3515024732805038509dd0d9f0b60ab273 URL: https://github.com/kamailio/kamailio/commit/ca3d4b3515024732805038509dd0d9f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:12:43+02:00 cnxcc: check if final pulse is 0 - avoid dividing with it in such case - GH #3859 (cherry picked from commit 7061a79fe64066dd5a6598e38d714bd40bf2eabc) --- Modified: src/modules/cnxcc/cnxcc_check.c --- Diff: https://github.com/kamailio/kamailio/commit/ca3d4b3515024732805038509dd0d9f… Patch: https://github.com/kamailio/kamailio/commit/ca3d4b3515024732805038509dd0d9f… --- diff --git a/src/modules/cnxcc/cnxcc_check.c b/src/modules/cnxcc/cnxcc_check.c index 32839921e7f..503a89e6802 100644 --- a/src/modules/cnxcc/cnxcc_check.c +++ b/src/modules/cnxcc/cnxcc_check.c @@ -62,6 +62,13 @@ void check_calls_by_money(unsigned int ticks, void *param) if(!call->confirmed) continue; + if(call->money_based.final_pulse == 0) { + LM_WARN("CID [%.*s] - final pulse is 0 - skipping\n", + call->sip_data.callid.len, + call->sip_data.callid.s); + continue; + } + consumed_time = get_current_timestamp() - call->start_timestamp;

1 0

git:5.8:f59f980d: core: dns cache - check warnings made debug
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: f59f980d03b884f2494892eb4d007293b7ad4e34 URL: https://github.com/kamailio/kamailio/commit/f59f980d03b884f2494892eb4d00729… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:12:30+02:00 core: dns cache - check warnings made debug (cherry picked from commit 754f9ae28c9a731fc0bfd6d08411bf0913a7dbfc) --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/f59f980d03b884f2494892eb4d00729… Patch: https://github.com/kamailio/kamailio/commit/f59f980d03b884f2494892eb4d00729… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 1fba5a036af..91da2592446 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -1697,7 +1697,7 @@ inline static struct dns_hash_entry *dns_get_related( LM_DBG("(%p (%.*s, %d), %d, *%p) (%d)\n", e, e->name_len, e->name, e->type, type, *records, cname_chain_len); if(l->prev != NULL || l->next != NULL) { - LM_WARN("record not alone: %p - type: %d\n", l, (int)l->type); + LM_DBG("record not alone: %p - type: %d\n", l, (int)l->type); } clist_init(l, next, prev); if(type == e->type) { @@ -2044,7 +2044,7 @@ inline static struct dns_hash_entry *dns_cache_do_request(str *name, int type) #endif end: if(e != NULL && e->prev == NULL && e->next == NULL) { - LM_WARN("record not linked: %p - type: %d\n", e, (int)e->type); + LM_DBG("record not linked: %p - type: %d\n", e, (int)e->type); } return e; }

1 0

git:5.8:4fa5fc10: core: removed duplicated break
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: 4fa5fc10370d81d534d75b034322a6250c7e2557 URL: https://github.com/kamailio/kamailio/commit/4fa5fc10370d81d534d75b034322a62… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:11:38+02:00 core: removed duplicated break (cherry picked from commit 588b9c710b6555371bc8bbee21e474466bb099dd) --- Modified: src/core/select.c --- Diff: https://github.com/kamailio/kamailio/commit/4fa5fc10370d81d534d75b034322a62… Patch: https://github.com/kamailio/kamailio/commit/4fa5fc10370d81d534d75b034322a62… --- diff --git a/src/core/select.c b/src/core/select.c index 01312d5e459..10526ff5c7c 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -335,7 +335,6 @@ int resolve_select(select_t *s) default: BUG("Unable to resolve select at level %d\n", param_idx); break; - break; } goto not_found;

1 0

git:5.8:70cf3ebd: textopsx: docs - note about @hf_value2 select
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: 70cf3ebd2b52c341a90c9b9b6149985667a6b96c URL: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:11:16+02:00 textopsx: docs - note about @hf_value2 select (cherry picked from commit d13c741d90c3887cdf144a9094a78c0c7cb9856d) --- Modified: src/modules/textopsx/doc/selects.xml --- Diff: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985… Patch: https://github.com/kamailio/kamailio/commit/70cf3ebd2b52c341a90c9b9b6149985… --- diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml index 3c72c21cd36..dd3ea3f7a62 100644 --- a/src/modules/textopsx/doc/selects.xml +++ b/src/modules/textopsx/doc/selects.xml @@ -8,8 +8,8 @@ <section id="textopsx.sel.hf_value"> <title>@hf_value</title> <para> - Get value of required header-value or param. Note that functions called 'value2' - works with Authorization-like headers where comma is not treated as value delimiter. + Get value of required header-value or param. Note that selects called 'hf_value2' + work with Authorization-like headers where comma is not treated as value delimiter. </para> <para> Formats: @@ -73,7 +73,9 @@ $prt = @hf_value2.authorization.integrity_protected; <section id="textopsx.sel.hf_value2"> <title>@hf_value2</title> <para> - TBA. + Similar to selects called 'hf_value', but work with Authorization-like + headers where comma is treated as attribute delimiter instead of header + value delimiter. </para> </section> <section id="textopsx.sel.hf_value_exists">

1 0

git:5.8:7bf787d0: textopx/doc: fixed hard-to-read documentation for textopsx
by Daniel-Constantin Mierla 01 Jul '24

01 Jul '24

Module: kamailio Branch: 5.8 Commit: 7bf787d00f9f7ed8a2d758219d6d1413b2b5c975 URL: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-01T09:10:51+02:00 textopx/doc: fixed hard-to-read documentation for textopsx - was missing line-wraps in examples list, hence very hard to read (cherry picked from commit 48d97c1941f660aa396b5ef100584611cf92ad21) --- Modified: src/modules/textopsx/doc/selects.xml --- Diff: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141… Patch: https://github.com/kamailio/kamailio/commit/7bf787d00f9f7ed8a2d758219d6d141… --- diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml index 6d4dd4e3a25..3c72c21cd36 100644 --- a/src/modules/textopsx/doc/selects.xml +++ b/src/modules/textopsx/doc/selects.xml @@ -9,30 +9,35 @@ <title>@hf_value</title> <para> Get value of required header-value or param. Note that functions called 'value2' - works with Authorization-like headers where comma is not treated as value delimiter. Formats: - @hf_value.HFNAME[IDX] # idx value, negative value counts from bottom - @hf_value.HFNAME.PARAM_NAME - @hf_value.HFNAME[IDX].PARAM_NAME - @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param" - @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto - @hf_value.HFNAME[IDX].uri # (< & > excluded) - @hf_value.HFNAME[*] # return comma delimited list of all values (combines headers) - @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y - @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded) - @hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y - @hf_value.HFNAME[IDX].name # returns name part, quotes excluded - @hf_value.HFNAME.name # returns name part of the first value + works with Authorization-like headers where comma is not treated as value delimiter. + </para> + <para> + Formats: + <itemizedlist> + <listitem>@hf_value.HFNAME[IDX] # idx value, negative value counts from bottom</listitem> + <listitem>@hf_value.HFNAME.PARAM_NAME</listitem> + <listitem>@hf_value.HFNAME[IDX].PARAM_NAME</listitem> + <listitem>@hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"</listitem> + <listitem>@hf_value.HFNAME[IDX].p.PARAM_NAME # dtto</listitem> + <listitem>@hf_value.HFNAME[IDX].uri # (< & > excluded)</listitem> + <listitem>@hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)</listitem> + <listitem>@hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y</listitem> + <listitem>@hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)</listitem> + <listitem>@hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y</listitem> + <listitem>@hf_value.HFNAME[IDX].name # returns name part, quotes excluded</listitem> + <listitem>@hf_value.HFNAME.name # returns name part of the first value</listitem> - @hf_value2.HFNAME # returns value of first header - @hf_value2.HFNAME[IDX] # returns value of idx's header - @hf_value2.HFNAME.PARAM_NAME - @hf_value2.HFNAME[IDX].PARAM_NAME + <listitem>@hf_value2.HFNAME # returns value of first header</listitem> + <listitem>@hf_value2.HFNAME[IDX] # returns value of idx's header</listitem> + <listitem>@hf_value2.HFNAME.PARAM_NAME</listitem> + <listitem>@hf_value2.HFNAME[IDX].PARAM_NAME</listitem> - @hf_value.HFNAME[IDX].uri # return URI, quotes excluded - @hf_value.HFNAME.p.uri # returns param named uri, not URI itself - @hf_value.HFNAME.p.name # returns param named name, not name itself - @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used - @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr + <listitem>@hf_value.HFNAME[IDX].uri # return URI, quotes excluded</listitem> + <listitem>@hf_value.HFNAME.p.uri # returns param named uri, not URI itself</listitem> + <listitem>@hf_value.HFNAME.p.name # returns param named name, not name itself</listitem> + <listitem>@hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used</listitem> + <listitem>@hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr</listitem> + </itemizedlist> </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

1 0

[kamailio/kamailio] The RPC `rtpengine.show` API result has the field `disabled` value change on different values. (Issue #3896)
by Oded Arbel 30 Jun '24

30 Jun '24

### Description When using the RPC command `rtpengine.show`, the resulting list has the field `disabled` for each RTPEngine configured, and its value - for some reason can be either `0` (number), `1` (number) or `"1(permanent)"` (string). For example: ``` $ curl -k -X POST -HContent-Type:application/json -d '{"jsonrpc":"2.0","method":"rtpengine.show","params":["all"],"id":1}' https://localhost:8443/rpc { "jsonrpc": "2.0", "result": [{ "url": "udp:old-rtpengine2227", "set": 0, "index": 0, "weight": 1, "disabled": 1, "recheck_ticks": 0 }, { "url": "udp:172.24.73.28:2227", "set": 0, "index": 1, "weight": 1, "disabled": 0, "recheck_ticks": 0 }, { "url": "udp:172.24.75.15:2227", "set": 0, "index": 2, "weight": 1, "disabled": "1(permanent)", "recheck_ticks": "N/A" }], "id": 1 } ``` This makes it very annoying to parse the results from JSON RPC (and maybe other machine readable RPC APIs). Also the same problem for `recheck_ticks`, but I never actually read it so it is less important for me. #### Reproduction The difference between `0` and `"1(permanent)"` can be seen by setting up multiple RTPEngine sockets that work and then disable one of the using the `rtpengine.enable` RPC command with the `flag` set to `0`. As far as I can tell that is the only way to get `recheck_ticks` to be set to `RTPENGINE_MAX_RECHECK_TICKS` which causes the "permanently disabled" state. ### Possible Solutions I can try to offer a patch, but any change I can make will be a breaking API change - so if users are relying on this weird behavior, that could be a problem. Maybe the best way to move forward is to expose two additional fields: - `active` : `boolean` - set to `true` if the RTPEngine is not disabled, and to `false` if it is disabled (i.e. the value is equal to `disabled == 0`). - `active` : `boolean` - set to `true` if the RTPEngine had not failed it checks (i.e. `recheck_ticks` is either 0 or `RTPENGINE_MAX_RECHECK_TICKS`). This will be set to `false` if `disabled` is set to `1`, and not `"1(permanent)"`. Maybe the last field is unneeded? Maybe `"disabled"` can be changed to only report whether the RPC was used to disable the socket and let the `active` field specify whether the socket can be used? ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.5 (x86_64/linux) 58499a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 58499a compiled on 00:00:00 Sep 13 2022 with gcc 11.4.1 ``` * **Operating System**:  ``` $ uname -a Linux sip-172-24-50-23.XX.XX.XX 6.5.0-1020-aws #20~22.04.1-Ubuntu SMP Wed May 1 16:10:50 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux $ cat /etc/os-release NAME="AlmaLinux" VERSION="9.4 (Seafoam Ocelot)" ID="almalinux" ID_LIKE="rhel centos fedora" VERSION_ID="9.4" PLATFORM_ID="platform:el9" PRETTY_NAME="AlmaLinux 9.4 (Seafoam Ocelot)" ANSI_COLOR="0;34" LOGO="fedora-logo-icon" CPE_NAME="cpe:/o:almalinux:almalinux:9::baseos" HOME_URL="https://almalinux.org/" DOCUMENTATION_URL="https://wiki.almalinux.org/" BUG_REPORT_URL="https://bugs.almalinux.org/" ALMALINUX_MANTISBT_PROJECT="AlmaLinux-9" ALMALINUX_MANTISBT_PROJECT_VERSION="9.4" REDHAT_SUPPORT_PRODUCT="AlmaLinux" REDHAT_SUPPORT_PRODUCT_VERSION="9.4" SUPPORT_END=2032-06-01 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3896 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3896(a)github.com>

2 6

[kamailio/kamailio] add "active" field to rtpengine.show as alternate of "disabled" (PR #3898)
by Oded Arbel 30 Jun '24

30 Jun '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3896 #### Description As per issue #3896, "active" is a boolean field that just describes whether the socket will be used, while "disabled" now just describes whether the socket was disabled by an RPC command. Also make "disabled" and "recheck_ticks" fields have a fixed value type of boolean and number respectively. use `"recheck_ticks": -1` instead of "N/A" as per discussion. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3898 -- Commit Summary -- * rtpengine: add "active" field to rtpengine.show as alternate of "disabled" -- File Changes -- M src/modules/rtpengine/rtpengine.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3898.patch https://github.com/kamailio/kamailio/pull/3898.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3898 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3898(a)github.com>

2 1

git:master:96ada96f: rtpengine: add "active" field to rtpengine.show as alternate of "disabled" (#3898)
by GitHub 30 Jun '24

30 Jun '24

Module: kamailio Branch: master Commit: 96ada96f69f606c35fd46a45def3b095026f2393 URL: https://github.com/kamailio/kamailio/commit/96ada96f69f606c35fd46a45def3b09… Author: Oded Arbel <oded(a)geek.co.il> Committer: GitHub <noreply(a)github.com> Date: 2024-06-30T12:40:53-04:00 rtpengine: add "active" field to rtpengine.show as alternate of "disabled" (#3898) As per issue #3896, "active" is a boolean field that just describes whether the socket will be used, while "disabled" now just describes whether the socket was disabled by an RPC command. Also make "disabled" and "recheck_ticks" fields have a fixed value type of boolean and number respectively. use `"recheck_ticks": -1` instead of "N/A" as per discussion --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/96ada96f69f606c35fd46a45def3b09… Patch: https://github.com/kamailio/kamailio/commit/96ada96f69f606c35fd46a45def3b09… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 775542c5994..54f22b1843f 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1784,13 +1784,14 @@ static int add_rtpp_node_info( if((1 == crt_rtpp->rn_disabled) && (crt_rtpp->rn_recheck_ticks == RTPENGINE_MAX_RECHECK_TICKS)) { - rpc->struct_add(vh, "s", "disabled", "1(permanent)"); + rpc->struct_add(vh, "b", "disabled", 1); } else { - rpc->struct_add(vh, "d", "disabled", crt_rtpp->rn_disabled); + rpc->struct_add(vh, "b", "disabled", 0); } + rpc->struct_add(vh, "b", "active", crt_rtpp->rn_disabled == 0); if(crt_rtpp->rn_recheck_ticks == RTPENGINE_MAX_RECHECK_TICKS) { - rpc->struct_add(vh, "s", "recheck_ticks", "N/A"); + rpc->struct_add(vh, "d", "recheck_ticks", -1); } else { rtpp_ticks = crt_rtpp->rn_recheck_ticks - get_ticks(); rtpp_ticks = rtpp_ticks < 0 ? 0 : rtpp_ticks;

1 0

git:master:fc5f61b7: tls: reformat exported structures
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: fc5f61b7e838cf51ae24dd9714ebb7080b78e4c3 URL: https://github.com/kamailio/kamailio/commit/fc5f61b7e838cf51ae24dd9714ebb70… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T12:09:09+02:00 tls: reformat exported structures --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fc5f61b7e838cf51ae24dd9714ebb70… Patch: https://github.com/kamailio/kamailio/commit/fc5f61b7e838cf51ae24dd9714ebb70…

1 0

git:master:ef05d0f6: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: ef05d0f6210d73a3f991b31ce28630807ede23af URL: https://github.com/kamailio/kamailio/commit/ef05d0f6210d73a3f991b31ce286308… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-28T11:46:10+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/ef05d0f6210d73a3f991b31ce286308… Patch: https://github.com/kamailio/kamailio/commit/ef05d0f6210d73a3f991b31ce286308…

1 0

Ubuntu 24.04 Packages for Kamailio 5.8 on deb.kamailio.org
by Xenofon Karamanos 28 Jun '24

28 Jun '24

Hey everybody, While attempting to use the official Ubuntu package for Kamailio version 5.7.4 on Ubunut 24.04, we encountered an issue where TLS functionality does not seem to work as expected but 5.8 branch does. Given this, I am inquiring about the availability and status of Kamailio packages for Ubuntu 24.04 on the official Kamailio repository at deb.kamailio.org. Are there any plans to support this version of Ubuntu with updated packages? If so, is there an estimated timeline for when these packages might become available? Thank you in advance for your assistance. Best regards, Xenofon

1 1

git:master:e7268fff: tls: docs for private_key_password and key_password_mode params
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: e7268ffffb35916118e21d1c3a5631c726464e51 URL: https://github.com/kamailio/kamailio/commit/e7268ffffb35916118e21d1c3a5631c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T11:39:13+02:00 tls: docs for private_key_password and key_password_mode params --- Modified: src/modules/tls/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/e7268ffffb35916118e21d1c3a5631c… Patch: https://github.com/kamailio/kamailio/commit/e7268ffffb35916118e21d1c3a5631c… --- diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml index fa14216a4ee..c6dc019c5c7 100644 --- a/src/modules/tls/doc/params.xml +++ b/src/modules/tls/doc/params.xml @@ -179,6 +179,43 @@ modparam("tls", "private_key", "/usr/local/etc/kamailio/my_pkey.pem") </example> </section> + <section id="tls.p.private_key_password"> + <title><varname>private_key_password</varname> (string)</title> + <para> + The password for the private key. + </para> + <para> + The default value is empty. + </para> + <example> + <title>Set <varname>private_key_password</varname> parameter</title> + <programlisting> +... +modparam("tls", "private_key_password", "secret") +... + </programlisting> + </example> + </section> + + <section id="tls.p.key_password_mode"> + <title><varname>key_password_mode</varname> (int)</title> + <para> + The mode to get the password for the private key. If 0, take it + from the config "private_key_password". If 1, promt for it at start up. + </para> + <para> + The default value is 0. + </para> + <example> + <title>Set <varname>key_password_mode</varname> parameter</title> + <programlisting> +... +modparam("tls", "key_password_mode", 0) +... + </programlisting> + </example> + </section> + <section id="tls.p.ca_list"> <title><varname>ca_list</varname> (string)</title> <para>

1 0

git:master:54f248e6: tls: added key_password_mode modparam
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: 54f248e60ce4d6ab9a87967d7df05e60c05d926d URL: https://github.com/kamailio/kamailio/commit/54f248e60ce4d6ab9a87967d7df05e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T11:31:48+02:00 tls: added key_password_mode modparam - if 0 (default), get private key password from config; if 1, prompt for it (old way) --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/54f248e60ce4d6ab9a87967d7df05e6… Patch: https://github.com/kamailio/kamailio/commit/54f248e60ce4d6ab9a87967d7df05e6… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index e292c7eb1b2..4c41f94bcac 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -308,6 +308,7 @@ static param_export_t params[] = { {"rand_engine", PARAM_STR | USE_FUNC_PARAM, (void *)ksr_rand_engine_param}, {"init_mode", PARAM_INT, &ksr_tls_init_mode}, + {"key_password_mode", PARAM_INT, &ksr_tls_key_password_mode}, {0, 0, 0}};

1 0

git:master:d4cf61d7: tls: new option to set the password for private key
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: d4cf61d78af54671056a65f3b91ea67574cc0158 URL: https://github.com/kamailio/kamailio/commit/d4cf61d78af54671056a65f3b91ea67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T11:25:19+02:00 tls: new option to set the password for private key - the provate_key_password field can be set in the tls profile --- Modified: src/modules/tls/tls_cfg.c Modified: src/modules/tls/tls_cfg.h Modified: src/modules/tls/tls_config.c Modified: src/modules/tls/tls_domain.c Modified: src/modules/tls/tls_domain.h Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d4cf61d78af54671056a65f3b91ea67… Patch: https://github.com/kamailio/kamailio/commit/d4cf61d78af54671056a65f3b91ea67…

1 0

git:master:7129f73a: tls: small changes in log messages for key password callback
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: 7129f73ad0f27accc9c7c9922e0b04f594dee058 URL: https://github.com/kamailio/kamailio/commit/7129f73ad0f27accc9c7c9922e0b04f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T10:18:00+02:00 tls: small changes in log messages for key password callback --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/7129f73ad0f27accc9c7c9922e0b04f… Patch: https://github.com/kamailio/kamailio/commit/7129f73ad0f27accc9c7c9922e0b04f… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index cb74468b62f..645f45b1fe1 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1223,12 +1223,12 @@ static int ksr_passwd_ui_cb(char *buf, int size, int rwflag, void *filename) return strlen(buf); err: - ERR("passwd_cb: Error in passwd_cb\n"); + ERR("failure in password callback\n"); return 0; #else if(des_read_pw_string(buf, size - 1, "Enter Private Key password:", 0)) { - ERR("Error in passwd_cb\n"); + ERR("failure in password callback\n"); return 0; } return strlen(buf);

1 0

git:master:8fe77250: tls: rename the key passowrd callback function
by Daniel-Constantin Mierla 28 Jun '24

28 Jun '24

Module: kamailio Branch: master Commit: 8fe772509af34b70a961e21eef99ed19d777ddbc URL: https://github.com/kamailio/kamailio/commit/8fe772509af34b70a961e21eef99ed1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-28T10:11:06+02:00 tls: rename the key passowrd callback function --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/8fe772509af34b70a961e21eef99ed1… Patch: https://github.com/kamailio/kamailio/commit/8fe772509af34b70a961e21eef99ed1… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index 810a7e9589a..cb74468b62f 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1206,7 +1206,7 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) * @param filename filename * @return length of password on success, 0 on error */ -static int passwd_cb(char *buf, int size, int rwflag, void *filename) +static int ksr_passwd_ui_cb(char *buf, int size, int rwflag, void *filename) { #if OPENSSL_VERSION_NUMBER >= 0x00907000L UI *ui; @@ -1323,7 +1323,7 @@ static int load_private_key(tls_domain_t *d) procs_no = get_max_procs(); for(i = 0; i < procs_no; i++) { - SSL_CTX_set_default_passwd_cb(d->ctx[i], passwd_cb); + SSL_CTX_set_default_passwd_cb(d->ctx[i], ksr_passwd_ui_cb); SSL_CTX_set_default_passwd_cb_userdata(d->ctx[i], d->pkey_file.s); for(idx = 0, ret_pwd = 0; idx < 3; idx++) {

1 0

git:master:dc7fc82f: pv: several new $E... variables for punctuation signs
by Daniel-Constantin Mierla 27 Jun '24

27 Jun '24

Module: kamailio Branch: master Commit: dc7fc82ff77a8016c1a1e15b7aa0e950f7cca379 URL: https://github.com/kamailio/kamailio/commit/dc7fc82ff77a8016c1a1e15b7aa0e95… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-27T11:28:30+02:00 pv: several new $E... variables for punctuation signs - facilitate using them in params (e.g., for transformations) --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/dc7fc82ff77a8016c1a1e15b7aa0e95… Patch: https://github.com/kamailio/kamailio/commit/dc7fc82ff77a8016c1a1e15b7aa0e95… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 4b9329589fb..a5b7d9ebd03 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -207,6 +207,20 @@ static pv_export_t mod_pvs[] = { PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 4}, {{"Et", (sizeof("Et") - 1)}, /* */ PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 3}, + {{"Ec", (sizeof("Ec") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 5}, + {{"Eq", (sizeof("Eq") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 6}, + {{"Ek", (sizeof("Ek") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 7}, + {{"Ei", (sizeof("Ei") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 8}, + {{"Ej", (sizeof("Ej") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 9}, + {{"Eb", (sizeof("Eb") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 10}, + {{"Ev", (sizeof("Ev") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 11}, {{"fd", (sizeof("fd") - 1)}, /* */ PVT_OTHER, pv_get_from_attr, pv_set_from_domain, 0, 0, pv_init_iname, 3}, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 261322e97e6..ca0a7388475 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1510,6 +1510,27 @@ int pv_get_escstr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) case 4: _pv_escstr[i] = ' '; break; + case 5: + _pv_escstr[i] = ','; + break; + case 6: + _pv_escstr[i] = '"'; + break; + case 7: + _pv_escstr[i] = '\''; + break; + case 8: + _pv_escstr[i] = ':'; + break; + case 9: + _pv_escstr[i] = ';'; + break; + case 10: + _pv_escstr[i] = '\\'; + break; + case 11: + _pv_escstr[i] = '`'; + break; default: _pv_escstr[i] = '\n'; break;

1 0

git:master:7061a79f: cnxcc: check if final pulse is 0
by Daniel-Constantin Mierla 27 Jun '24

27 Jun '24

Module: kamailio Branch: master Commit: 7061a79fe64066dd5a6598e38d714bd40bf2eabc URL: https://github.com/kamailio/kamailio/commit/7061a79fe64066dd5a6598e38d714bd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-27T10:07:11+02:00 cnxcc: check if final pulse is 0 - avoid dividing with it in such case - GH #3859 --- Modified: src/modules/cnxcc/cnxcc_check.c --- Diff: https://github.com/kamailio/kamailio/commit/7061a79fe64066dd5a6598e38d714bd… Patch: https://github.com/kamailio/kamailio/commit/7061a79fe64066dd5a6598e38d714bd… --- diff --git a/src/modules/cnxcc/cnxcc_check.c b/src/modules/cnxcc/cnxcc_check.c index 32839921e7f..503a89e6802 100644 --- a/src/modules/cnxcc/cnxcc_check.c +++ b/src/modules/cnxcc/cnxcc_check.c @@ -62,6 +62,13 @@ void check_calls_by_money(unsigned int ticks, void *param) if(!call->confirmed) continue; + if(call->money_based.final_pulse == 0) { + LM_WARN("CID [%.*s] - final pulse is 0 - skipping\n", + call->sip_data.callid.len, + call->sip_data.callid.s); + continue; + } + consumed_time = get_current_timestamp() - call->start_timestamp;

1 0

[kamailio/kamailio] Kamailio became unresponsive during runtime (#2380)
by ObakeFilter 27 Jun '24

27 Jun '24

### Description Hi, I ran into an issue where the Kamailio service seemingly froze (didn't crash, but failed to receive and deliver calls) while running, I went through the logs a little bit, and saw the same log pattern (pasted below) recouring every few months or so, on an older installation (5.2.0). Usually, it ended up automatically restarting the service. But not this time, I had to reload it manually to make the service work again. Is this a known issue? How can I make sure that the service will be able to restart the next time it happens? Edward ### Troubleshooting #### Debugging Data  ``` GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1 Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/local/sbin/kamailio...done. warning: exec file is newer than core file. [New LWP 11413] Core was generated by `kamailio'. Program terminated with signal SIGABRT, Aborted. #0 0x00007f4e4a52e428 in ?? () (gdb) Quit (gdb) bt full #0 0x00007f4e4a52e428 in ?? () No symbol table info available. #1 0x00007f4e4a53002a in ?? () No symbol table info available. #2 0x0000000000000020 in ?? () No symbol table info available. #3 0x0000000000000000 in ?? () No symbol table info available. (gdb) info locals No symbol table info available. (gdb) list 1871 & now if we don't need it */ 1872 #ifdef USE_SLOW_TIMER 1873 + 1 /* slow timer process */ 1874 #endif 1875 #ifdef USE_TCP 1876 +((!tcp_disable)?( 1/* tcp main */ + tcp_listeners ):0) 1877 #endif 1878 #ifdef USE_SCTP 1879 +((!sctp_disable)?sctp_listeners:0) 1880 #endif (gdb) ``` #### Log Messages  ``` Jun 28 16:35:22 kamprodegres kamailio: INFO: <core> [core/sctp_core.c:74]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module Jun 28 16:35:22 kamprodegres kamailio: WARNING: <core> [core/socket_info.c:1394]: fix_hostname(): could not rev. resolve 70.36.25.87 Jun 28 16:35:22 kamprodegres kamailio: WARNING: <core> [core/socket_info.c:1394]: fix_hostname(): could not rev. resolve 70.36.25.87 Jun 28 16:35:22 kamprodegres kamailio: INFO: <core> [core/tcp_main.c:5042]: init_tcp(): using epoll_lt as the io watch method (auto detected) Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: jsonrpcs [jsonrpcs_sock.c:197]: jsonrpc_dgram_mod_init(): the socket /var/run/kamailio/kamailio_rpc.sock already exists, trying to delete it... Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: rr [rr_mod.c:177]: mod_init(): outbound module not available Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [main.c:2779]: main(): processes (at least): 40 - shm size: 67108864 - pkg size: 8388608 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 Jun 28 16:35:22 kamprodegres kamailio[8489]: INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 Jun 28 16:35:22 kamprodegres kamailio[8518]: INFO: jsonrpcs [jsonrpcs_sock.c:443]: jsonrpc_dgram_process(): a new child 0/8518 Jun 28 16:35:22 kamprodegres kamailio[8519]: INFO: ctl [io_listener.c:214]: io_listen_loop(): io_listen_loop: using epoll_lt io watch method (config) Jun 29 18:13:37 kamprodegres kamailio[8513]: INFO: {1 581461 CANCEL 402954192_49936786(a)67.231.13.146} tm [t_reply.c:478]: _reply_light(): can't generate 487 reply when a final 404 was sent out Jun 29 18:27:00 kamprodegres kamailio[8508]: INFO: {1 211236 CANCEL 405019408_127896329(a)67.231.13.146} tm [t_reply.c:478]: _reply_light(): can't generate 487 reply when a final 404 was sent out Jun 29 18:51:10 kamprodegres /usr/local/sbin/kamailio[2269]: NOTICE: <core> [main.c:725]: handle_sigs(): Thank you for flying kamailio!!! Jun 29 18:51:10 kamprodegres /usr/local/sbin/kamailio[2326]: INFO: <core> [main.c:847]: sig_usr(): signal 15 received ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.2 (x86_64/linux) 7ba545 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 7ba545 compiled on 16:37:32 Jun 14 2020 with gcc 5.4.0 ``` * **Operating System**:  ``` Ubuntu 16.04 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2380

3 10

git:master:3174159e: pv: new variables for common escaped characters
by Daniel-Constantin Mierla 26 Jun '24

26 Jun '24

Module: kamailio Branch: master Commit: 3174159e0dbe5b16b04a83b199185f258540587e URL: https://github.com/kamailio/kamailio/commit/3174159e0dbe5b16b04a83b199185f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-26T08:02:44+02:00 pv: new variables for common escaped characters - $En - '\n'; $Er - '\r'; $Et - '\t'; $Es - ' '; --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/3174159e0dbe5b16b04a83b199185f2… Patch: https://github.com/kamailio/kamailio/commit/3174159e0dbe5b16b04a83b199185f2… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index c9df0926e23..4b9329589fb 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -199,6 +199,14 @@ static pv_export_t mod_pvs[] = { PVT_OTHER, pv_get_errinfo_attr, 0, 0, 0, pv_init_iname, 3}, {{"err.rreason", (sizeof("err.rreason") - 1)}, /* */ PVT_OTHER, pv_get_errinfo_attr, 0, 0, 0, pv_init_iname, 4}, + {{"En", (sizeof("En") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 1}, + {{"Er", (sizeof("Er") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 2}, + {{"Es", (sizeof("Es") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 4}, + {{"Et", (sizeof("Et") - 1)}, /* */ + PVT_OTHER, pv_get_escstr, 0, 0, 0, pv_init_iname, 3}, {{"fd", (sizeof("fd") - 1)}, /* */ PVT_OTHER, pv_get_from_attr, pv_set_from_domain, 0, 0, pv_init_iname, 3}, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 87345490af1..261322e97e6 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1488,6 +1488,39 @@ int pv_get_body_size(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) } +#define PV_ESCSTR_SIZE 16 +int pv_get_escstr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) +{ + static char _pv_escstr[PV_ESCSTR_SIZE]; + int i; + str s; + + if(param->pvn.u.isname.name.n < 0) { + return pv_get_null(msg, param, res); + } + + i = (2 * param->pvn.u.isname.name.n) % PV_ESCSTR_SIZE; + switch(param->pvn.u.isname.name.n) { + case 2: + _pv_escstr[i] = '\r'; + break; + case 3: + _pv_escstr[i] = '\t'; + break; + case 4: + _pv_escstr[i] = ' '; + break; + default: + _pv_escstr[i] = '\n'; + break; + } + _pv_escstr[i + 1] = '\0'; + s.s = &_pv_escstr[i]; + s.len = 1; + return pv_get_strval(msg, param, res, &s); +} + + int pv_get_authattr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { struct hdr_field *hdr; diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 53951340db1..9e4ea449c41 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -187,6 +187,8 @@ int pv_get_msg_body(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_body_size(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_escstr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_authattr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_acc_user(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

git:master:754f9ae2: core: dns cache - check warnings made debug
by Daniel-Constantin Mierla 26 Jun '24

26 Jun '24

Module: kamailio Branch: master Commit: 754f9ae28c9a731fc0bfd6d08411bf0913a7dbfc URL: https://github.com/kamailio/kamailio/commit/754f9ae28c9a731fc0bfd6d08411bf0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-26T07:22:38+02:00 core: dns cache - check warnings made debug --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/754f9ae28c9a731fc0bfd6d08411bf0… Patch: https://github.com/kamailio/kamailio/commit/754f9ae28c9a731fc0bfd6d08411bf0… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 1fba5a036af..91da2592446 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -1697,7 +1697,7 @@ inline static struct dns_hash_entry *dns_get_related( LM_DBG("(%p (%.*s, %d), %d, *%p) (%d)\n", e, e->name_len, e->name, e->type, type, *records, cname_chain_len); if(l->prev != NULL || l->next != NULL) { - LM_WARN("record not alone: %p - type: %d\n", l, (int)l->type); + LM_DBG("record not alone: %p - type: %d\n", l, (int)l->type); } clist_init(l, next, prev); if(type == e->type) { @@ -2044,7 +2044,7 @@ inline static struct dns_hash_entry *dns_cache_do_request(str *name, int type) #endif end: if(e != NULL && e->prev == NULL && e->next == NULL) { - LM_WARN("record not linked: %p - type: %d\n", e, (int)e->type); + LM_DBG("record not linked: %p - type: %d\n", e, (int)e->type); } return e; }

1 0

[kamailio/kamailio] crypto related crash in 5.8.2 (Issue #3885)
by Sebastian Damm 25 Jun '24

25 Jun '24

### Description We updated one of our endpoint facing proxies last night, from 5.7.4 to 5.8.2. After running for about 12 hours, it crashed. It had about 1.8k TLS connections at the time of the crash. When crashing, Kamailio produced core dumps of two processes. One of them must be the TCP listener, the other maybe the main process.  #### Debugging Data  TCP worker BT: ``` GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1 Copyright (C) 2022 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/.build-id/f7/ddc0031f334263ca08ef340ce76dcf36c43616.debug... [New LWP 170] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.'. Program terminated with signal SIGSEGV, Segmentation fault. #0 EVP_MD_get_size (md=0x4434443332454246) at ../crypto/evp/evp_lib.c:790 (gdb) bt full #0 EVP_MD_get_size (md=0x4434443332454246) at ../crypto/evp/evp_lib.c:790 __func__ = "EVP_MD_get_size" #1 0x00007f6fdae8dac9 in ssl3_get_record (s=0x7f6f7b56b940) at ../ssl/record/ssl3_record.c:532 tmpmd = <optimized out> rbuf = 0x7f6f7b56c5b8 p = <optimized out> md = "\004Б\220WU\000\000h\023\226\220WU\000\000\001", '\000' <repeats 23 times>, "\240\331\356\332o\177\000\000\000@\233\363\377\177\000\000\340?\233\363\377\177\000" sslv2pkt = <optimized out> rret = <optimized out> more = <optimized out> imac_size = <optimized out> num_recs = 1 enc_err = <optimized out> is_ktls_left = 0 i = <optimized out> n = 1220 rr = 0x7f6f7b56cbe8 version = <optimized out> pkt = <optimized out> ret = -1 thisrr = 0x7f6f7b56cbe8 sess = 0x7f6f83f15360 mac_size = 0 max_recs = 1 j = <optimized out> macbufs = 0x0 end = <optimized out> enc_err = <optimized out> rret = <optimized out> i = <optimized out> more = <optimized out> n = <optimized out> rr = <optimized out> thisrr = <optimized out> rbuf = <optimized out> sess = <optimized out> p = <optimized out> md = <optimized out> version = <optimized out> mac_size = <optimized out> imac_size = <optimized out> num_recs = <optimized out> max_recs = <optimized out> j = <optimized out> pkt = <optimized out> sslv2pkt = <optimized out> is_ktls_left = <optimized out> macbufs = <optimized out> ret = <optimized out> __func__ = <optimized out> skip_decryption = <optimized out> end = <optimized out> sslv2len = <optimized out> type = <optimized out> len = <optimized out> tmpmd = <optimized out> mac = <optimized out> trc_out = <optimized out> thismb = <optimized out> end = <optimized out> #2 ssl3_read_bytes (s=<optimized out>, type=23, recvd_type=0x0, buf=0x7f6f83c10c58 "SIP/2.0 200 OK\r\nVia: SIP/2.0/TLS 18.196.228.33:5061;received=18.196.228.33;branch=z9hG4bKb7cd.8d562f68384ebfdf796976dadc7858a1.0;i=2901\r\nVia: SIP/2.0/TCP 100.101.131.74:5060;rport=36255;received=100.1"..., len=16383, peek=0, readbytes=0x7ffff39b3f30) at ../ssl/record/rec_layer_s3.c:1348 i = <optimized out> j = <optimized out> ret = <optimized out> n = <optimized out> curr_rec = <optimized out> num_recs = <optimized out> totalbytes = <optimized out> rr = 0x7f6f7b56cbe8 rbuf = <optimized out> cb = 0x0 is_tls13 = 0 start = <optimized out> __func__ = "ssl3_read_bytes" #3 0x00007f6fdae683fc in ssl3_read_internal (s=0x7f6f7b56b940, buf=0x7f6f83c10c58, len=16383, peek=0, readbytes=0x7ffff39b3f30) at ../ssl/s3_lib.c:4449 ret = <optimized out> #4 0x00007f6fdae6ecb7 in SSL_read (s=s@entry=0x7f6f7b56b940, buf=<optimized out>, num=num@entry=16383) at ../ssl/ssl_lib.c:1871 ret = <optimized out> readbytes = 0 __func__ = "SSL_read" #5 0x00007f6fdaf2f61a in tls_h_read_f (c=c@entry=0x7f6f83c108a0, flags=flags@entry=0x7ffff39d4408) at /build/kamailio-5.8.2+ubuntu22.04/src/modules/tls/tls_server.c:1172 r = 0x7f6f83c109c8 bytes_free = 16383 bytes_read = <optimized out> read_size = <optimized out> ssl_error = 0 ssl_read = 0 ssl = 0x7f6f7b56b940 rd_buf = "\027\003\003\004Ď\202B\346o\234lj\254/#cD`\\\332O\313\353P\005ws\274\026\\\324\030\210\210;\037{\315\064\355Q\204\024[:Č]\330\062<\021E\373\371\241\237\207\373\020zj\f\006۫\262\001\270_;\372\273\366\334r\221Cq\321\023\071<3\v\021:\376[\245\322i\246x\330C\016G'\372\357\324>pY\247\356\361\371\351 \031\301\032T\256\243wlD54\221\310̨yl\267\037\212?`\024\321\065\"\273;O\275IR\263\312/V\210\316h\330\337\366p\276#\032\323-3\345\067\276\250[\274\361^\260\237\213\346,o\243ķ\204\257\354\343\317\312i6Y\034\370\266<7\034/^\201g\f\245\232}I\350*\344"... wr_buf = "\024\003\003\000\001\001\026\003\003\000(\261c\005\303V\307\036\306E\n\271\347\baڽӁ!噛\302\361\342y\375R\314\321J\300\251\037JW\024\006\071H\000\001\000\000\000\000\000\000\v\000\004\003\000\001\002\000\027\000\000\026\003\003\fm\v\000\fi\000\ff\000\a 0\202\a\034\060\202\006\004\240\003\002\001\002\002\020\rϫ\264X\035\325c\177F\\\225`\367-\303\060\r\006\t*\206H\206\367\r\001\001\v\005\000\060D1\v0\t\006\003U\004\006\023\002US1\025\060\023\006\003U\004\n\023\fDigiCert Inc1\036\060\034\006\003U\004\003\023\025GeoTrust EV RSA CA G20\036\027\r"... rd = { buf = 0x7ffff39c40a0 "\027\003\003\004Ď\202B\346o\234lj\254/#cD`\\\332O\313\353P\005ws\274\026\\\324\030\210\210;\037{\315\064\355Q\204\024[:Č]\330\062<\021E\373\371\241\237\207\373\020zj\f\006۫\262\001\270_;\372\273\366\334r\221Cq\321\023\071<3\v\021:\376[\245\322i\246x\330C\016G'\372\357\324>pY\247\356\361\371\351 \031\301\032T\256\243wlD54\221\310̨yl\267\037\212?`\024\321\065\"\273;O\275IR\263\312/V\210\316h\330\337\366p\276#\032\323-3\345\067\276\250[\274\361^\260\237\213\346,o\243ķ\204\257\354\343\317\312i6Y\034\370\266<7\034/^\201g\f\245\232"..., pos = 1225, used = 1225, size = 65536} wr = {buf = 0x7ffff39b40a0 "\024\003\003", pos = 0, used = 0, size = 65536} tls_c = 0x7f6f7fff0830 enc_rd_buf = <optimized out> n = <optimized out> flush_flags = 1 err_src = <optimized out> ip_buf = "100.68.1.15", '\000' <repeats 52 times> x = <optimized out> tls_dbg = <optimized out> redo_read = <optimized out> __func__ = "tls_h_read_f" __llevel = <optimized out> __kld = <optimized out> __llevel = <optimized out> __kld = <optimized out> #6 0x0000555790742a04 in tcp_read_headers (c=0x7f6f83c108a0, read_flags=0x7ffff39d4408) at core/tcp_read.c:445 bytes = <optimized out> remaining = <optimized out> p = <optimized out> r = 0x7f6f83c109c8 mc = <optimized out> body_len = <optimized out> tvnow = {tv_sec = 1718871175, tv_usec = 69359} tvdiff = <optimized out> mfline = <optimized out> mtransid = <optimized out> __func__ = "tcp_read_headers" #7 0x0000555790746edb in tcp_read_req (con=0x7f6f83c108a0, bytes_read=0x7ffff39d440c, read_flags=0x7ffff39d4408) at core/tcp_read.c:1509 bytes = <optimized out> total_bytes = 0 resp = 1 size = <optimized out> req = 0x7f6f83c109c8 dst = {send_sock = 0x7ffff39d4320, to = {s = {sa_family = 1, sa_data = "\000\000\000\000\000\000\060C\235\363\377\177\000"}, sin = {sin_family = 1, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "0C\235\363\377\177\000"}, sin6 = {sin6_family = 1, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = { __in6_u = {__u6_addr8 = "0C\235\363\377\177\000\000\030\000\000\000\000\000\000", __u6_addr16 = {17200, 62365, 32767, 0, 24, 0, 0, 0}, __u6_addr32 = {4087169840, 32767, 24, 0}}}, sin6_scope_id = 0}, sas = {ss_family = 1, __ss_padding = "\000\000\000\000\000\000\060C\235\363\377\177\000\000\030", '\000' <repeats 43 times>, "\001 \000\000h\355\"\333o\177", '\000' <repeats 34 times>, "\030D\235\363\377\177\000\000\b\000\000\000\000\000\000", __ss_align = 20}}, id = 1, send_flags = {f = 1, blst_imask = 0}, proto = 54 '6', proto_pad0 = 0 '\000', proto_pad1 = 0} c = <optimized out> ret = <optimized out> again = <optimized out> __func__ = "tcp_read_req" #8 0x00005557907516a3 in handle_io (fm=<optimized out>, events=<optimized out>, idx=<optimized out>) at core/tcp_read.c:1826 ret = 8 n = 8 read_flags = RD_CONN_SHORT_READ con = 0x7f6f83c108a0 s = 54 resp = <optimized out> t = <optimized out> ee = 0x0 error = <optimized out> __func__ = "handle_io" #9 0x0000555790909b46 in io_wait_loop_epoll.constprop.0.isra.0 (repeat=<optimized out>, t=<optimized out>, h=<optimized out>) at core/io_wait.h:1075 n = 1 r = 0 fm = 0x7f6fdb22f140 revents = 1 __func__ = <optimized out> #10 0x0000555790757917 in tcp_receive_loop (unix_sock=<optimized out>) at core/tcp_read.c:2026 __func__ = "tcp_receive_loop" #11 0x0000555790738c08 in tcp_init_children (woneinit=<optimized out>) at core/tcp_main.c:5377 r = <optimized out> i = <optimized out> reader_fd_1 = 90 pid = <optimized out> si_desc = "tcp receiver (generic)\000\000BNv\220WU\000\000\004Б\220WU\000\000 D\226\220WU\000\000P\303S\222\001\000\000\000\020'\000\000<L\177\365\020\314\343vo\177\000\000\025\000\000\000\000\000\000\000\000\200\237vo\177\000\000\004\000\000\000\000\000\000\000\363ё\220WU\000\000\b\361\221\220WU\000\000\004Б\220WU\000\000A\000\000\000B\000\000" si = <optimized out> error = <optimized out> __func__ = "tcp_init_children" #12 0x00005557904ccb23 in main_loop () at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:1950 i = <optimized out> pid = <optimized out> si = <optimized out> si_desc = "udp receiver child=15 sock=[2a05:f000:affe:cafe:dead:beef:f4bb:fca5]:5060\000\000\000\000o\177\000\000\003\000\000\000\000\000\000\000\t\000\000\000\000\000\000\000Wed Jun 19 20:55:53 2024\n\000\346\333o\177\000" nrprocs = <optimized out> woneinit = 1 error = <optimized out> __func__ = "main_loop" #13 0x00005557904c0888 in main (argc=<optimized out>, argv=<optimized out>) at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:3256 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0x7ffff39d5e7e "" tmp_len = -604496466 port = 5060 proto = 0 aproto = 0 ahost = 0x0 aport = 0 options = 0x555790920360 ":f:cm:M:dVIhEeb:B:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3391114691 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> n_lst = <optimized out> p = <optimized out> st = {st_dev = 93, st_ino = 19, st_nlink = 2, st_mode = 16888, st_uid = 378, st_gid = 378, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1718830549, tv_nsec = 527132001}, st_mtim = {tv_sec = 1718830549, tv_nsec = 527132001}, st_ctim = { tv_sec = 1718830549, tv_nsec = 527132001}, __glibc_reserved = {0, 0, 0}} l1 = <optimized out> tbuf = '\000' <repeats 52 times>, "\377\000\000\000\377\000\000\000\000\377\000\000", '/' <repeats 16 times>, "\230\r", '\000' <repeats 14 times>, "`", '\000' <repeats 15 times>, "\001", '\000' <repeats 145 times>... option_index = 12 __func__ = "main" long_options = {{name = 0x555790920012 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x555790927ea8 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x555790937912 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x555790920017 "subst", has_arg = 1, flag = 0x0, val = 1025}, { name = 0x55579092001d "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x555790920026 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x555790920030 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x55579092003a "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x555790920045 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x55579092004e "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x555790927fc5 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x555790920059 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x555790920063 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x55579092006a "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} (gdb) info locals __func__ = "EVP_MD_get_size" (gdb) list 785 in ../crypto/evp/evp_lib.c ``` Main process BT: ``` GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1 Copyright (C) 2022 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/.build-id/f7/ddc0031f334263ca08ef340ce76dcf36c43616.debug... [New LWP 107] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f6fdab75ae2 in evp_md_ctx_clear_digest (ctx=ctx@entry=0x7f6f7cc60e60, force=force@entry=0, keep_fetched=keep_fetched@entry=0) at ../crypto/evp/digest.c:46 (gdb) bt full #0 0x00007f6fdab75ae2 in evp_md_ctx_clear_digest (ctx=ctx@entry=0x7f6f7cc60e60, force=force@entry=0, keep_fetched=keep_fetched@entry=0) at ../crypto/evp/digest.c:46 No locals. #1 0x00007f6fdab75d87 in evp_md_ctx_reset_ex (keep_fetched=0, ctx=0x7f6f7cc60e60) at ../crypto/evp/digest.c:91 No locals. #2 evp_md_ctx_reset_ex (keep_fetched=0, ctx=0x7f6f7cc60e60) at ../crypto/evp/digest.c:75 No locals. #3 EVP_MD_CTX_reset (ctx=ctx@entry=0x7f6f7cc60e60) at ../crypto/evp/digest.c:101 No locals. #4 0x00007f6fdab75dd2 in EVP_MD_CTX_free (ctx=0x7f6f7cc60e60) at ../crypto/evp/digest.c:140 No locals. #5 EVP_MD_CTX_free (ctx=0x7f6f7cc60e60) at ../crypto/evp/digest.c:135 No locals. #6 0x00007f6fdae6b9a6 in ssl_clear_hash_ctx (hash=0x7f6f7b56c1a0) at ../ssl/ssl_lib.c:4785 No locals. #7 clear_ciphers (s=s@entry=0x7f6f7b56b940) at ../ssl/ssl_lib.c:565 No locals. #8 0x00007f6fdae75c95 in SSL_free (s=0x7f6f7b56b940) at ../ssl/ssl_lib.c:1214 i = <optimized out> i = <optimized out> #9 SSL_free (s=0x7f6f7b56b940) at ../ssl/ssl_lib.c:1172 i = <optimized out> #10 0x00007f6fdaf25413 in tls_h_tcpconn_clean_f (c=0x7f6f83c108a0) at /build/kamailio-5.8.2+ubuntu22.04/src/modules/tls/tls_server.c:684 extra = 0x7f6f7fff0830 __func__ = "tls_h_tcpconn_clean_f" #11 0x0000555790736586 in _tcpconn_free (c=0x7f6f83c108a0) at core/tcp_main.c:1664 __func__ = <optimized out> #12 _tcpconn_rm (c=0x7f6f83c108a0) at core/tcp_main.c:1674 No locals. #13 tcpconn_destroy_all () at core/tcp_main.c:4906 c = 0x7f6f83c108a0 next = <optimized out> h = 786 fd = <optimized out> c = <optimized out> next = <optimized out> h = <optimized out> fd = <optimized out> #14 destroy_tcp () at core/tcp_main.c:5099 __func__ = "destroy_tcp" #15 0x00005557904c8eb6 in cleanup (show_status=1) at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:606 memlog = <optimized out> __func__ = "cleanup" #16 0x0000555790906a8d in shutdown_children.constprop.0 (show_status=show_status@entry=1, sig=15) at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:735 __func__ = <optimized out> #17 0x00005557904c3e55 in handle_sigs () at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:835 chld = <optimized out> chld_status = 139 any_chld_stopped = <optimized out> memlog = <optimized out> __func__ = "handle_sigs" #18 0x00005557904ccc54 in main_loop () at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:2002 i = <optimized out> pid = <optimized out> si = <optimized out> si_desc = "udp receiver child=15 sock=[2a05:fooo:affe:cafe:dead:beef:f4bb:fca5]:5060\000\000\000\000o\177\000\000\003\000\000\000\000\000\000\000\t\000\000\000\000\000\000\000Wed Jun 19 20:55:53 2024\n\000\346\333o\177\000" nrprocs = <optimized out> woneinit = 1 error = <optimized out> __func__ = "main_loop" #19 0x00005557904c0888 in main (argc=<optimized out>, argv=<optimized out>) at /build/kamailio-5.8.2+ubuntu22.04/src/main.c:3256 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0x7ffff39d5e7e "" tmp_len = -604496466 port = 5060 proto = 0 aproto = 0 ahost = 0x0 aport = 0 options = 0x555790920360 ":f:cm:M:dVIhEeb:B:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3391114691 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> n_lst = <optimized out> p = <optimized out> st = {st_dev = 93, st_ino = 19, st_nlink = 2, st_mode = 16888, st_uid = 378, st_gid = 378, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1718830549, tv_nsec = 527132001}, st_mtim = {tv_sec = 1718830549, tv_nsec = 527132001}, st_ctim = { tv_sec = 1718830549, tv_nsec = 527132001}, __glibc_reserved = {0, 0, 0}} l1 = <optimized out> tbuf = '\000' <repeats 52 times>, "\377\000\000\000\377\000\000\000\000\377\000\000", '/' <repeats 16 times>, "\230\r", '\000' <repeats 14 times>, "`", '\000' <repeats 15 times>, "\001", '\000' <repeats 145 times>... option_index = 12 __func__ = "main" long_options = {{name = 0x555790920012 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x555790927ea8 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x555790937912 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x555790920017 "subst", has_arg = 1, flag = 0x0, val = 1025}, { name = 0x55579092001d "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x555790920026 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x555790920030 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x55579092003a "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x555790920045 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x55579092004e "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x555790927fc5 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x555790920059 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x555790920063 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x55579092006a "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} (gdb) info locals No locals. (gdb) list 41 in ../crypto/evp/digest.c ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 11.4.0 ``` * **Operating System**:  ``` root@sipproxy:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 22.04.4 LTS Release: 22.04 Codename: jammy root@sipproxy:~# uname -a Linux sipproxy 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3885 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3885(a)github.com>

2 6

[kamailio/kamailio] Any web management tools suggestions (Issue #3881)
by Chen Ziyan 25 Jun '24

25 Jun '24

### Description When I set up Kamailio, it is not easy to configure, monitor, and register visually. There are compatibility issues with the older versions of Siremis components mentioned in the guide, and there are many problems in initialization and deployment that cannot be matched with the latest version. Any other web management tools suggestions? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3881 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3881(a)github.com>

2 2

git:master:385c054a: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: 385c054a5d96b4d2b888e62dd26ca7d563d93f61 URL: https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-25T13:01:10+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d… Patch: https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d…

1 0

git:master:8df69ebc: pv: docs for xavp_xparams_explode(...)
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: 8df69ebca23bde071b08b0ed5b8cd34b2d28446b URL: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-25T13:00:08+02:00 pv: docs for xavp_xparams_explode(...) --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34… Patch: https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34… --- diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml index 1f91e633a00..6a06bb717de 100644 --- a/src/modules/pv/doc/pv_admin.xml +++ b/src/modules/pv/doc/pv_admin.xml @@ -387,6 +387,39 @@ xavp_params_explode("a=b;c=d;e=d", "x"); # $xavp(x=>a) = "b"; # $xavp(x=>c) = "d"; # $xavp(x=>e) = "f"; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavp_xparams_explode"> + <title> + <function moreinfo="none">xavp_xparams_explode(sparams, sep, xname)</function> + </title> + <para> + Convert a parameters string in xavp attributes. + </para> + <para> + The first parameter has to be a string in similar format of SIP header + parameters (name1=value1;...;nameN=valueN), but the separator can + be other character than ';'. The second parameter is the separator + for the parameters list. The third parameter is the name of the + root xavp to hold the pairs (nameX,valueX). + </para> + <para> + The values are stored as string type. + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavp_xparams_explode</function> usage</title> + <programlisting format="linespecific"> +... +xavp_xparams_explode("a=b,c=d,e=d", ",", "x"); +# results in: +# $xavp(x=>a) = "b"; +# $xavp(x=>c) = "d"; +# $xavp(x=>e) = "f"; ... </programlisting> </example> @@ -1132,4 +1165,3 @@ $ &kamcmd; pv.shvGet debug </section> </chapter> -

1 0

git:master:3d2849ae: pv: added xavp_xparams_explode(params, sep, xname)
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: 3d2849aee788fd3b33d80d9d72ef0cdcdd1c9f87 URL: https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-25T12:53:32+02:00 pv: added xavp_xparams_explode(params, sep, xname) - option to specify the separator for parameters list --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_xavp.c Modified: src/modules/pv/pv_xavp.h --- Diff: https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cd… Patch: https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cd…

1 0

git:master:d4ef9f26: core: parse_param2() - continue if the separator matches comma or bracket
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: d4ef9f268fd1b645fc1846db1fd7a6e814792921 URL: https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-25T12:48:28+02:00 core: parse_param2() - continue if the separator matches comma or bracket --- Modified: src/core/parser/parse_param.c --- Diff: https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e… Patch: https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e… --- diff --git a/src/core/parser/parse_param.c b/src/core/parser/parse_param.c index 698c0a9b47d..b7df14d9f88 100644 --- a/src/core/parser/parse_param.c +++ b/src/core/parser/parse_param.c @@ -508,9 +508,9 @@ static inline int parse_param2( t->len = t->name.len; } - if(_s->s[0] == ',') + if(separator != ',' && _s->s[0] == ',') goto ok; /* To be able to parse header parameters */ - if(_s->s[0] == '>') + if(separator != '>' && _s->s[0] == '>') goto ok; /* To be able to parse URI parameters */ if(_s->s[0] != separator) {

1 0

git:master:e956ae7b: pv: support all spaces separator for {s.select}
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: e956ae7b83971c50cbdf1a4db8db9929f02e3b19 URL: https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db992… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-25T11:03:01+02:00 pv: support all spaces separator for {s.select} --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db992… Patch: https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db992… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index dcf5479a105..b0eba93eed8 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -256,7 +256,8 @@ int tr_eval_string( for(i = 0; i < val->rs.len; i++) { if(val->rs.s[i] == '\r' || val->rs.s[i] == '\n') { c = 1; - } else if(c != 0 && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { + } else if(c != 0 + && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { if(c == 1) { _tr_buffer[j] = ' '; j++; @@ -284,7 +285,8 @@ int tr_eval_string( for(i = 0; i < val->rs.len; i++) { if(val->rs.s[i] == '\r' || val->rs.s[i] == '\n') { c = 1; - } else if(c != 0 && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { + } else if(c != 0 + && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { c = 2; } else { _tr_buffer[j] = val->rs.s[i]; @@ -816,6 +818,9 @@ int tr_eval_string( case 't': c = '\t'; break; + case 's': + c = ' '; + break; default: LM_ERR("invalid select escape char (cfg line: %d)\n", get_cfg_crt_line()); @@ -832,7 +837,10 @@ int tr_eval_string( i = -i; i--; while(p >= val->rs.s) { - if(*p == c) { + if(((c == 1) + && (*p == ' ' || *p == '\t' || *p == '\n' + || *p == '\r')) + || (*p == c)) { if(i == 0) break; s = p - 1; @@ -850,7 +858,10 @@ int tr_eval_string( s = val->rs.s; p = s; while(p < val->rs.s + val->rs.len) { - if(*p == c) { + if(((c == 1) + && (*p == ' ' || *p == '\t' || *p == '\n' + || *p == '\r')) + || (*p == c)) { if(i == 0) break; s = p + 1;

1 0

git:master:e4a65922: rabbitmq: don't fail on init if connection fails
by Victor Seva 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: e4a65922649c1db8edcb8fa18b421620c899b25f URL: https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b42162… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-25T10:35:09+02:00 rabbitmq: don't fail on init if connection fails * there's a reconnect functionality already in place Change-Id: I88320fc64aef802a1bcdd753fe7d22402ca4b18c --- Modified: src/modules/rabbitmq/rabbitmq.c --- Diff: https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b42162… Patch: https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b42162… --- diff --git a/src/modules/rabbitmq/rabbitmq.c b/src/modules/rabbitmq/rabbitmq.c index a1e95ad55b3..9b57e7a834c 100644 --- a/src/modules/rabbitmq/rabbitmq.c +++ b/src/modules/rabbitmq/rabbitmq.c @@ -178,8 +178,7 @@ static int mod_child_init(int rank) // routing process if(rabbitmq_connect(&amqp_conn) != RABBITMQ_OK) { - LM_ERR("FAIL rabbitmq_connect()"); - return -1; + LM_WARN("FAIL rabbitmq_connect()"); } LM_DBG("SUCCESS initialization of rabbitmq module in child [%d]\n", rank);

1 0

git:master:75b5325c: pv: new transformation {s.rmhlws}
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: 75b5325c3b125b8adc551591cd82b67cd3cab167 URL: https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-25T09:41:56+02:00 pv: new transformation {s.rmhlws} - remove header line split white spaces (i.e., end of lines and following white spaces in a multi-line header value) --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67… Patch: https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 4418234ddb5..dcf5479a105 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -274,6 +274,30 @@ int tr_eval_string( val->rs.s = _tr_buffer; val->rs.len = j; break; + case TR_S_RMHLWS: + if(!(val->flags & PV_VAL_STR)) + val->rs.s = int2str(val->ri, &val->rs.len); + if(val->rs.len >= TR_BUFFER_SIZE - 1) + return -1; + j = 0; + c = 0; + for(i = 0; i < val->rs.len; i++) { + if(val->rs.s[i] == '\r' || val->rs.s[i] == '\n') { + c = 1; + } else if(c != 0 && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { + c = 2; + } else { + _tr_buffer[j] = val->rs.s[i]; + j++; + c = 0; + } + } + _tr_buffer[j] = '\0'; + val->flags = PV_VAL_STR; + val->ri = 0; + val->rs.s = _tr_buffer; + val->rs.len = j; + break; case TR_S_MD5: if(!(val->flags & PV_VAL_STR)) val->rs.s = int2str(val->ri, &val->rs.len); @@ -2752,6 +2776,9 @@ char *tr_parse_string(str *in, trans_t *t) } else if(name.len == 6 && strncasecmp(name.s, "rmhdws", 6) == 0) { t->subtype = TR_S_RMHDWS; goto done; + } else if(name.len == 6 && strncasecmp(name.s, "rmhlws", 6) == 0) { + t->subtype = TR_S_RMHLWS; + goto done; } else if(name.len == 6 && strncasecmp(name.s, "sha256", 6) == 0) { t->subtype = TR_S_SHA256; goto done; diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 9eebe1da9d1..6fab2c4233c 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -97,6 +97,7 @@ enum _tr_s_subtype TR_S_DECODEBASE64URLT, TR_S_RMWS, TR_S_RMHDWS, + TR_S_RMHLWS, TR_S_BEFORE, TR_S_AFTER, TR_S_RBEFORE,

1 0

git:master:31daee18: pv: new transformation {s.rmhdws}
by Daniel-Constantin Mierla 25 Jun '24

25 Jun '24

Module: kamailio Branch: master Commit: 31daee1800cb301d705524a56e7466abfa62e5d9 URL: https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-24T11:38:14+02:00 pv: new transformation {s.rmhdws} - remove header-like duplicated whitespaces (i.e., end of line followed by whitespaces are replaced by a single whitespace) --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466a… Patch: https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466a… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index a3ce0f0ace3..4418234ddb5 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -246,6 +246,34 @@ int tr_eval_string( val->rs.s = _tr_buffer; val->rs.len = j; break; + case TR_S_RMHDWS: + if(!(val->flags & PV_VAL_STR)) + val->rs.s = int2str(val->ri, &val->rs.len); + if(val->rs.len >= TR_BUFFER_SIZE - 1) + return -1; + j = 0; + c = 0; + for(i = 0; i < val->rs.len; i++) { + if(val->rs.s[i] == '\r' || val->rs.s[i] == '\n') { + c = 1; + } else if(c != 0 && (val->rs.s[i] == ' ' || val->rs.s[i] == '\t')) { + if(c == 1) { + _tr_buffer[j] = ' '; + j++; + c = 2; + } + } else { + _tr_buffer[j] = val->rs.s[i]; + j++; + c = 0; + } + } + _tr_buffer[j] = '\0'; + val->flags = PV_VAL_STR; + val->ri = 0; + val->rs.s = _tr_buffer; + val->rs.len = j; + break; case TR_S_MD5: if(!(val->flags & PV_VAL_STR)) val->rs.s = int2str(val->ri, &val->rs.len); @@ -2721,6 +2749,9 @@ char *tr_parse_string(str *in, trans_t *t) } else if(name.len == 4 && strncasecmp(name.s, "rmws", 4) == 0) { t->subtype = TR_S_RMWS; goto done; + } else if(name.len == 6 && strncasecmp(name.s, "rmhdws", 6) == 0) { + t->subtype = TR_S_RMHDWS; + goto done; } else if(name.len == 6 && strncasecmp(name.s, "sha256", 6) == 0) { t->subtype = TR_S_SHA256; goto done; diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 662d5a2b578..9eebe1da9d1 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -96,6 +96,7 @@ enum _tr_s_subtype TR_S_ENCODEBASE64URLT, TR_S_DECODEBASE64URLT, TR_S_RMWS, + TR_S_RMHDWS, TR_S_BEFORE, TR_S_AFTER, TR_S_RBEFORE,

1 0

git:master:588b9c71: core: removed duplicated break
by Daniel-Constantin Mierla 24 Jun '24

24 Jun '24

Module: kamailio Branch: master Commit: 588b9c710b6555371bc8bbee21e474466bb099dd URL: https://github.com/kamailio/kamailio/commit/588b9c710b6555371bc8bbee21e4744… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-24T10:22:25+02:00 core: removed duplicated break --- Modified: src/core/select.c --- Diff: https://github.com/kamailio/kamailio/commit/588b9c710b6555371bc8bbee21e4744… Patch: https://github.com/kamailio/kamailio/commit/588b9c710b6555371bc8bbee21e4744… --- diff --git a/src/core/select.c b/src/core/select.c index 01312d5e459..10526ff5c7c 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -335,7 +335,6 @@ int resolve_select(select_t *s) default: BUG("Unable to resolve select at level %d\n", param_idx); break; - break; } goto not_found;

1 0

[kamailio/kamailio] DNS google auto establish to kamailio service (Issue #3890)
by itpanda2024 24 Jun '24

24 Jun '24

I just study and work with Kamailio . I have a issue about listening port . Please help me. I install kamailio in centos 9 stream with version 5.6.5 when start call sometime, my system established connect from google dns (8.8.8.8:53) to kamailio with random port and it do call fail (not reply when receive invite ). please help me and i attatch screenshot ![kamailio issue](https://github.com/kamailio/kamailio/assets/154739080/d94aae72-e420-… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3890 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3890(a)github.com>

2 2

git:master:54aa2eac: modules: readme files regenerated - textopsx ... [skip ci]
by Kamailio Dev 23 Jun '24

23 Jun '24

Module: kamailio Branch: master Commit: 54aa2eac1a8c60e0741a5616e79b7b03e1e213e5 URL: https://github.com/kamailio/kamailio/commit/54aa2eac1a8c60e0741a5616e79b7b0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-23T12:01:10+02:00 modules: readme files regenerated - textopsx ... [skip ci] --- Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/54aa2eac1a8c60e0741a5616e79b7b0… Patch: https://github.com/kamailio/kamailio/commit/54aa2eac1a8c60e0741a5616e79b7b0… --- diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README index 7c6bc59df14..5344e15043d 100644 --- a/src/modules/textopsx/README +++ b/src/modules/textopsx/README @@ -753,8 +753,8 @@ bl_iterator_end("b1"); 3.1. @hf_value - Get value of required header-value or param. Note that functions called - 'value2' works with Authorization-like headers where comma is not + Get value of required header-value or param. Note that selects called + 'hf_value2' work with Authorization-like headers where comma is not treated as value delimiter. Formats: @@ -805,7 +805,9 @@ $prt = @hf_value2.authorization.integrity_protected; 3.2. @hf_value2 - TBA. + Similar to selects called 'hf_value', but work with Authorization-like + headers where comma is treated as attribute delimiter instead of header + value delimiter. 3.3. @hf_value_exists

1 0

git:master:d13c741d: textopsx: docs - note about @hf_value2 select
by Daniel-Constantin Mierla 23 Jun '24

23 Jun '24

Module: kamailio Branch: master Commit: d13c741d90c3887cdf144a9094a78c0c7cb9856d URL: https://github.com/kamailio/kamailio/commit/d13c741d90c3887cdf144a9094a78c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-23T11:52:34+02:00 textopsx: docs - note about @hf_value2 select --- Modified: src/modules/textopsx/doc/selects.xml --- Diff: https://github.com/kamailio/kamailio/commit/d13c741d90c3887cdf144a9094a78c0… Patch: https://github.com/kamailio/kamailio/commit/d13c741d90c3887cdf144a9094a78c0… --- diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml index 3c72c21cd36..dd3ea3f7a62 100644 --- a/src/modules/textopsx/doc/selects.xml +++ b/src/modules/textopsx/doc/selects.xml @@ -8,8 +8,8 @@ <section id="textopsx.sel.hf_value"> <title>@hf_value</title> <para> - Get value of required header-value or param. Note that functions called 'value2' - works with Authorization-like headers where comma is not treated as value delimiter. + Get value of required header-value or param. Note that selects called 'hf_value2' + work with Authorization-like headers where comma is not treated as value delimiter. </para> <para> Formats: @@ -73,7 +73,9 @@ $prt = @hf_value2.authorization.integrity_protected; <section id="textopsx.sel.hf_value2"> <title>@hf_value2</title> <para> - TBA. + Similar to selects called 'hf_value', but work with Authorization-like + headers where comma is treated as attribute delimiter instead of header + value delimiter. </para> </section> <section id="textopsx.sel.hf_value_exists">

1 0

git:master:eaf18505: modules: readme files regenerated - textopsx ... [skip ci]
by Kamailio Dev 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: eaf18505360a3bbaf25889095fcf23b620caedff URL: https://github.com/kamailio/kamailio/commit/eaf18505360a3bbaf25889095fcf23b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-21T13:01:09+02:00 modules: readme files regenerated - textopsx ... [skip ci] --- Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/eaf18505360a3bbaf25889095fcf23b… Patch: https://github.com/kamailio/kamailio/commit/eaf18505360a3bbaf25889095fcf23b… --- diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README index 9d6b81c05cd..7c6bc59df14 100644 --- a/src/modules/textopsx/README +++ b/src/modules/textopsx/README @@ -755,25 +755,36 @@ bl_iterator_end("b1"); Get value of required header-value or param. Note that functions called 'value2' works with Authorization-like headers where comma is not - treated as value delimiter. Formats: @hf_value.HFNAME[IDX] # idx value, - negative value counts from bottom @hf_value.HFNAME.PARAM_NAME - @hf_value.HFNAME[IDX].PARAM_NAME @hf_value.HFNAME.p.PARAM_NAME # or - .param., useful if required called "uri", "p", "param" - @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto @hf_value.HFNAME[IDX].uri # - (< & > excluded) @hf_value.HFNAME[*] # return comma delimited list of - all values (combines headers) @hf_value.HFNAME # the same as above [*] - but may be parsed by cfg.y @hf_value.HFNAME[*].uri # return comma - delimited list of uris (< & > excluded) @hf_value.HFNAME.uri # the same - as above [*] but may be parsed by cfg.y @hf_value.HFNAME[IDX].name # - returns name part, quotes excluded @hf_value.HFNAME.name # returns name - part of the first value @hf_value2.HFNAME # returns value of first - header @hf_value2.HFNAME[IDX] # returns value of idx's header - @hf_value2.HFNAME.PARAM_NAME @hf_value2.HFNAME[IDX].PARAM_NAME - @hf_value.HFNAME[IDX].uri # return URI, quotes excluded - @hf_value.HFNAME.p.uri # returns param named uri, not URI itself - @hf_value.HFNAME.p.name # returns param named name, not name itself - @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be - used @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr + treated as value delimiter. + + Formats: + * @hf_value.HFNAME[IDX] # idx value, negative value counts from + bottom + * @hf_value.HFNAME.PARAM_NAME + * @hf_value.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required + called "uri", "p", "param" + * @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto + * @hf_value.HFNAME[IDX].uri # (< & > excluded) + * @hf_value.HFNAME[*] # return comma delimited list of all values + (combines headers) + * @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y + * @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & + > excluded) + * @hf_value.HFNAME.uri # the same as above [*] but may be parsed by + cfg.y + * @hf_value.HFNAME[IDX].name # returns name part, quotes excluded + * @hf_value.HFNAME.name # returns name part of the first value + * @hf_value2.HFNAME # returns value of first header + * @hf_value2.HFNAME[IDX] # returns value of idx's header + * @hf_value2.HFNAME.PARAM_NAME + * @hf_value2.HFNAME[IDX].PARAM_NAME + * @hf_value.HFNAME[IDX].uri # return URI, quotes excluded + * @hf_value.HFNAME.p.uri # returns param named uri, not URI itself + * @hf_value.HFNAME.p.name # returns param named name, not name itself + * @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features + may be used + * @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr Meaning of the parameters is as follows: * HFNAME - Header field name. Underscores are treated as dashes.

1 0

[kamailio/kamailio] lib, modules: fixed Fraunhofer FOKUS name (PR #3889)
by Dragos Vingarzan 21 Jun '24

21 Jun '24

- affected: src/lib/ims, src/modules/cdp*, src/modules/ims_* - the Fraunhofer FOKUS institute name was misspelled in the comment headers   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The name of the Fraunhofer FOKUS institute was incomplete and misspelled. It bugged me for a long time :upside_down_face: . The changes are not split in 2 commits - one for lib and one for modules. Since these are just bulk changes with no effect on the output, should it be split or it's better if it is not? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3889 -- Commit Summary -- * lib, modules: fixed Fraunhofer FOKUS name -- File Changes -- M src/lib/ims/ims_getters.c (4) M src/lib/ims/ims_getters.h (4) M src/lib/ims/useful_defs.h (4) M src/modules/cdp/acceptor.c (4) M src/modules/cdp/acceptor.h (4) M src/modules/cdp/api_process.c (4) M src/modules/cdp/api_process.h (4) M src/modules/cdp/authstatemachine.c (4) M src/modules/cdp/authstatemachine.h (4) M src/modules/cdp/cdp_load.c (4) M src/modules/cdp/cdp_load.h (4) M src/modules/cdp/cdp_mod.c (4) M src/modules/cdp/cdp_mod.h (4) M src/modules/cdp/config.c (4) M src/modules/cdp/config.h (4) M src/modules/cdp/configdtd.h (4) M src/modules/cdp/configparser.c (4) M src/modules/cdp/diameter.h (4) M src/modules/cdp/diameter_api.h (4) M src/modules/cdp/diameter_avp.c (4) M src/modules/cdp/diameter_code_avp.h (4) M src/modules/cdp/diameter_code_result.h (4) M src/modules/cdp/diameter_comm.c (4) M src/modules/cdp/diameter_epc.h (4) M src/modules/cdp/diameter_epc_code_app.h (4) M src/modules/cdp/diameter_epc_code_avp.h (4) M src/modules/cdp/diameter_epc_code_cmd.h (4) M src/modules/cdp/diameter_epc_code_result.h (4) M src/modules/cdp/diameter_ims.h (4) M src/modules/cdp/diameter_ims_code_app.h (4) M src/modules/cdp/diameter_ims_code_avp.h (4) M src/modules/cdp/diameter_ims_code_cmd.h (4) M src/modules/cdp/diameter_ims_code_result.h (4) M src/modules/cdp/diameter_msg.c (4) M src/modules/cdp/diameter_peer.c (4) M src/modules/cdp/diameter_peer.h (4) M src/modules/cdp/globals.c (4) M src/modules/cdp/globals.h (4) M src/modules/cdp/peer.c (4) M src/modules/cdp/peer.h (4) M src/modules/cdp/peermanager.c (4) M src/modules/cdp/peermanager.h (4) M src/modules/cdp/peerstatemachine.c (4) M src/modules/cdp/peerstatemachine.h (4) M src/modules/cdp/receiver.c (4) M src/modules/cdp/receiver.h (4) M src/modules/cdp/routing.c (2) M src/modules/cdp/routing.h (4) M src/modules/cdp/sem.h (4) M src/modules/cdp/session.c (4) M src/modules/cdp/session.h (4) M src/modules/cdp/tcp_accept.c (4) M src/modules/cdp/tcp_accept.h (4) M src/modules/cdp/timer.c (4) M src/modules/cdp/timer.h (4) M src/modules/cdp/transaction.c (4) M src/modules/cdp/transaction.h (4) M src/modules/cdp/utils.h (4) M src/modules/cdp/worker.c (4) M src/modules/cdp/worker.h (4) M src/modules/cdp_avp/avp_add.c (4) M src/modules/cdp_avp/avp_add.h (4) M src/modules/cdp_avp/avp_get.c (4) M src/modules/cdp_avp/avp_get.h (4) M src/modules/cdp_avp/avp_get_base_data_format.c (4) M src/modules/cdp_avp/avp_get_base_data_format.h (4) M src/modules/cdp_avp/avp_new.c (4) M src/modules/cdp_avp/avp_new.h (4) M src/modules/cdp_avp/avp_new_base_data_format.c (4) M src/modules/cdp_avp/avp_new_base_data_format.h (4) M src/modules/cdp_avp/base.c (4) M src/modules/cdp_avp/base.h (4) M src/modules/cdp_avp/ccapp.c (4) M src/modules/cdp_avp/ccapp.h (4) M src/modules/cdp_avp/cdp_avp_mod.c (4) M src/modules/cdp_avp/cdp_avp_mod.h (4) M src/modules/cdp_avp/epcapp.c (4) M src/modules/cdp_avp/epcapp.h (4) M src/modules/cdp_avp/get_reference.h (4) M src/modules/cdp_avp/imsapp.c (4) M src/modules/cdp_avp/imsapp.h (4) M src/modules/cdp_avp/macros.h (4) M src/modules/cdp_avp/nasapp.c (4) M src/modules/cdp_avp/nasapp.h (4) M src/modules/ims_auth/api.h (4) M src/modules/ims_auth/authorize.c (4) M src/modules/ims_auth/authorize.h (4) M src/modules/ims_auth/blurb (4) M src/modules/ims_auth/conversion.c (4) M src/modules/ims_auth/conversion.h (4) M src/modules/ims_auth/cxdx_avp.c (4) M src/modules/ims_auth/cxdx_avp.h (4) M src/modules/ims_auth/cxdx_mar.c (4) M src/modules/ims_auth/cxdx_mar.h (4) M src/modules/ims_auth/ims_auth_mod.c (4) M src/modules/ims_auth/ims_auth_mod.h (4) M src/modules/ims_auth/pvt_message.c (4) M src/modules/ims_auth/pvt_message.h (4) M src/modules/ims_auth/rfc2617.c (4) M src/modules/ims_auth/rfc2617.h (4) M src/modules/ims_auth/sip_messages.h (4) M src/modules/ims_auth/stats.c (4) M src/modules/ims_auth/stats.h (4) M src/modules/ims_auth/utils.c (4) M src/modules/ims_auth/utils.h (4) M src/modules/ims_diameter_server/sem.h (4) M src/modules/ims_icscf/cxdx_avp.c (4) M src/modules/ims_icscf/cxdx_avp.h (4) M src/modules/ims_icscf/cxdx_lir.c (4) M src/modules/ims_icscf/cxdx_lir.h (4) M src/modules/ims_icscf/cxdx_uar.c (4) M src/modules/ims_icscf/cxdx_uar.h (4) M src/modules/ims_icscf/db.c (4) M src/modules/ims_icscf/db.h (4) M src/modules/ims_icscf/ims_icscf_mod.c (4) M src/modules/ims_icscf/ims_icscf_mod.h (4) M src/modules/ims_icscf/location.c (4) M src/modules/ims_icscf/location.h (4) M src/modules/ims_icscf/nds.c (4) M src/modules/ims_icscf/nds.h (4) M src/modules/ims_icscf/registration.c (4) M src/modules/ims_icscf/registration.h (4) M src/modules/ims_icscf/scscf_list.c (4) M src/modules/ims_icscf/scscf_list.h (4) M src/modules/ims_icscf/sip_messages.h (4) M src/modules/ims_icscf/stats.c (4) M src/modules/ims_icscf/stats.h (4) M src/modules/ims_ipsec_pcscf/cmd.c (4) M src/modules/ims_ipsec_pcscf/cmd.h (4) M src/modules/ims_isc/blurb (4) M src/modules/ims_isc/checker.c (4) M src/modules/ims_isc/checker.h (4) M src/modules/ims_isc/ims_isc_mod.c (4) M src/modules/ims_isc/ims_isc_mod.h (4) M src/modules/ims_isc/isc.c (4) M src/modules/ims_isc/isc.h (4) M src/modules/ims_isc/mark.c (4) M src/modules/ims_isc/mark.h (4) M src/modules/ims_isc/third_party_reg.c (4) M src/modules/ims_isc/third_party_reg.h (4) M src/modules/ims_ocs/sem.h (4) M src/modules/ims_qos/cdpeventprocessor.c (4) M src/modules/ims_qos/cdpeventprocessor.h (4) M src/modules/ims_qos/ims_qos_mod.c (4) M src/modules/ims_qos/ims_qos_mod.h (4) M src/modules/ims_qos/ims_qos_stats.c (4) M src/modules/ims_qos/rx_aar.c (4) M src/modules/ims_qos/rx_aar.h (4) M src/modules/ims_qos/rx_asr.c (4) M src/modules/ims_qos/rx_asr.h (4) M src/modules/ims_qos/rx_authdata.c (4) M src/modules/ims_qos/rx_authdata.h (4) M src/modules/ims_qos/rx_avp.c (4) M src/modules/ims_qos/rx_avp.h (4) M src/modules/ims_qos/rx_str.c (4) M src/modules/ims_qos/rx_str.h (4) M src/modules/ims_qos/sem.h (4) M src/modules/ims_qos/stats.c (4) M src/modules/ims_qos/stats.h (4) M src/modules/ims_registrar_pcscf/async_reginfo.c (4) M src/modules/ims_registrar_pcscf/async_reginfo.h (4) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (4) M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.h (4) M src/modules/ims_registrar_pcscf/save.c (4) M src/modules/ims_registrar_pcscf/save.h (4) M src/modules/ims_registrar_pcscf/sem.h (4) M src/modules/ims_registrar_pcscf/ul_callback.c (4) M src/modules/ims_registrar_pcscf/ul_callback.h (4) M src/modules/ims_registrar_scscf/cxdx_avp.c (4) M src/modules/ims_registrar_scscf/cxdx_avp.h (4) M src/modules/ims_registrar_scscf/cxdx_sar.c (4) M src/modules/ims_registrar_scscf/cxdx_sar.h (4) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (4) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.h (4) M src/modules/ims_registrar_scscf/pvt_message.c (4) M src/modules/ims_registrar_scscf/pvt_message.h (4) M src/modules/ims_registrar_scscf/registrar_notify.c (4) M src/modules/ims_registrar_scscf/registrar_notify.h (4) M src/modules/ims_registrar_scscf/save.c (4) M src/modules/ims_registrar_scscf/save.h (4) M src/modules/ims_registrar_scscf/sem.h (4) M src/modules/ims_registrar_scscf/server_assignment.c (4) M src/modules/ims_registrar_scscf/server_assignment.h (4) M src/modules/ims_registrar_scscf/stats.c (4) M src/modules/ims_registrar_scscf/stats.h (4) M src/modules/ims_registrar_scscf/userdata_parser.c (4) M src/modules/ims_registrar_scscf/userdata_parser.h (4) M src/modules/ims_registrar_scscf/usrloc_cb.c (4) M src/modules/ims_registrar_scscf/usrloc_cb.h (4) M src/modules/ims_usrloc_pcscf/dlist.c (4) M src/modules/ims_usrloc_pcscf/dlist.h (4) M src/modules/ims_usrloc_pcscf/hslot.c (4) M src/modules/ims_usrloc_pcscf/hslot.h (4) M src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c (4) M src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.h (4) M src/modules/ims_usrloc_pcscf/pcontact.c (4) M src/modules/ims_usrloc_pcscf/pcontact.h (4) M src/modules/ims_usrloc_pcscf/reginfo.c (4) M src/modules/ims_usrloc_pcscf/reginfo.h (4) M src/modules/ims_usrloc_pcscf/udomain.c (4) M src/modules/ims_usrloc_pcscf/udomain.h (4) M src/modules/ims_usrloc_pcscf/ul_callback.c (4) M src/modules/ims_usrloc_pcscf/ul_callback.h (4) M src/modules/ims_usrloc_pcscf/ul_rpc.c (4) M src/modules/ims_usrloc_pcscf/ul_rpc.h (4) M src/modules/ims_usrloc_pcscf/usrloc.c (4) M src/modules/ims_usrloc_pcscf/usrloc.h (4) M src/modules/ims_usrloc_pcscf/utime.c (4) M src/modules/ims_usrloc_pcscf/utime.h (4) M src/modules/ims_usrloc_scscf/bin_utils.c (4) M src/modules/ims_usrloc_scscf/bin_utils.h (4) M src/modules/ims_usrloc_scscf/contact_hslot.c (4) M src/modules/ims_usrloc_scscf/contact_hslot.h (4) M src/modules/ims_usrloc_scscf/dlist.c (4) M src/modules/ims_usrloc_scscf/dlist.h (4) M src/modules/ims_usrloc_scscf/hslot.c (4) M src/modules/ims_usrloc_scscf/hslot.h (4) M src/modules/ims_usrloc_scscf/hslot_sp.c (4) M src/modules/ims_usrloc_scscf/hslot_sp.h (4) M src/modules/ims_usrloc_scscf/impurecord.c (4) M src/modules/ims_usrloc_scscf/impurecord.h (4) M src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c (4) M src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.h (4) M src/modules/ims_usrloc_scscf/subscribe.c (4) M src/modules/ims_usrloc_scscf/subscribe.h (4) M src/modules/ims_usrloc_scscf/ucontact.c (4) M src/modules/ims_usrloc_scscf/ucontact.h (4) M src/modules/ims_usrloc_scscf/udomain.c (4) M src/modules/ims_usrloc_scscf/udomain.h (4) M src/modules/ims_usrloc_scscf/ul_callback.c (4) M src/modules/ims_usrloc_scscf/ul_callback.h (4) M src/modules/ims_usrloc_scscf/usrloc.c (4) M src/modules/ims_usrloc_scscf/usrloc.h (4) M src/modules/ims_usrloc_scscf/utime.c (4) M src/modules/ims_usrloc_scscf/utime.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3889.patch https://github.com/kamailio/kamailio/pull/3889.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3889 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3889(a)github.com>

2 2

git:master:9317670d: lib/ims: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 9317670dc2624a0ed06114e42e0e054ac5cbafb6 URL: https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 lib/ims: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h Modified: src/lib/ims/useful_defs.h --- Diff: https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054… Patch: https://github.com/kamailio/kamailio/commit/9317670dc2624a0ed06114e42e0e054… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index d50f6b3571d..c752f08eef1 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -4,7 +4,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -14,7 +14,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 6004f228eb5..77a55a6695b 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -5,7 +5,7 @@ * Copyright (C) 2012 Smile Communications, richard.good(a)smilecoms.com * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -15,7 +15,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to diff --git a/src/lib/ims/useful_defs.h b/src/lib/ims/useful_defs.h index 111bd2e6c00..5461eea6859 100644 --- a/src/lib/ims/useful_defs.h +++ b/src/lib/ims/useful_defs.h @@ -6,7 +6,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -16,7 +16,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to

1 0

git:master:1adf52ba: ims_usrloc_scscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 1adf52ba07a3b09b0ef5ef85b018d527764f428e URL: https://github.com/kamailio/kamailio/commit/1adf52ba07a3b09b0ef5ef85b018d52… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_usrloc_scscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_usrloc_scscf/bin_utils.c Modified: src/modules/ims_usrloc_scscf/bin_utils.h Modified: src/modules/ims_usrloc_scscf/contact_hslot.c Modified: src/modules/ims_usrloc_scscf/contact_hslot.h Modified: src/modules/ims_usrloc_scscf/dlist.c Modified: src/modules/ims_usrloc_scscf/dlist.h Modified: src/modules/ims_usrloc_scscf/hslot.c Modified: src/modules/ims_usrloc_scscf/hslot.h Modified: src/modules/ims_usrloc_scscf/hslot_sp.c Modified: src/modules/ims_usrloc_scscf/hslot_sp.h Modified: src/modules/ims_usrloc_scscf/impurecord.c Modified: src/modules/ims_usrloc_scscf/impurecord.h Modified: src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c Modified: src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.h Modified: src/modules/ims_usrloc_scscf/subscribe.c Modified: src/modules/ims_usrloc_scscf/subscribe.h Modified: src/modules/ims_usrloc_scscf/ucontact.c Modified: src/modules/ims_usrloc_scscf/ucontact.h Modified: src/modules/ims_usrloc_scscf/udomain.c Modified: src/modules/ims_usrloc_scscf/udomain.h Modified: src/modules/ims_usrloc_scscf/ul_callback.c Modified: src/modules/ims_usrloc_scscf/ul_callback.h Modified: src/modules/ims_usrloc_scscf/usrloc.c Modified: src/modules/ims_usrloc_scscf/usrloc.h Modified: src/modules/ims_usrloc_scscf/utime.c Modified: src/modules/ims_usrloc_scscf/utime.h --- Diff: https://github.com/kamailio/kamailio/commit/1adf52ba07a3b09b0ef5ef85b018d52… Patch: https://github.com/kamailio/kamailio/commit/1adf52ba07a3b09b0ef5ef85b018d52…

1 0

git:master:a845a73e: ims_usrloc_pcscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: a845a73ea71f94f5e49d20e9d044c083ad43c410 URL: https://github.com/kamailio/kamailio/commit/a845a73ea71f94f5e49d20e9d044c08… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_usrloc_pcscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_usrloc_pcscf/dlist.c Modified: src/modules/ims_usrloc_pcscf/dlist.h Modified: src/modules/ims_usrloc_pcscf/hslot.c Modified: src/modules/ims_usrloc_pcscf/hslot.h Modified: src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c Modified: src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.h Modified: src/modules/ims_usrloc_pcscf/pcontact.c Modified: src/modules/ims_usrloc_pcscf/pcontact.h Modified: src/modules/ims_usrloc_pcscf/reginfo.c Modified: src/modules/ims_usrloc_pcscf/reginfo.h Modified: src/modules/ims_usrloc_pcscf/udomain.c Modified: src/modules/ims_usrloc_pcscf/udomain.h Modified: src/modules/ims_usrloc_pcscf/ul_callback.c Modified: src/modules/ims_usrloc_pcscf/ul_callback.h Modified: src/modules/ims_usrloc_pcscf/ul_rpc.c Modified: src/modules/ims_usrloc_pcscf/ul_rpc.h Modified: src/modules/ims_usrloc_pcscf/usrloc.c Modified: src/modules/ims_usrloc_pcscf/usrloc.h Modified: src/modules/ims_usrloc_pcscf/utime.c Modified: src/modules/ims_usrloc_pcscf/utime.h --- Diff: https://github.com/kamailio/kamailio/commit/a845a73ea71f94f5e49d20e9d044c08… Patch: https://github.com/kamailio/kamailio/commit/a845a73ea71f94f5e49d20e9d044c08…

1 0

[kamailio/kamailio] textopsx/doc: fixed hard-to-read documentation for textopsx (PR #3887)
by Dragos Vingarzan 21 Jun '24

21 Jun '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Part of the documentation of the textopsx module (the selectors) was hard to read, since it was missing line-wraps in the example. - itemizing the list of examples for readability You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3887 -- Commit Summary -- * fixed hard-to-read documentation for textopsx -- File Changes -- M src/modules/textopsx/README (49) M src/modules/textopsx/doc/selects.xml (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3887.patch https://github.com/kamailio/kamailio/pull/3887.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3887 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3887(a)github.com>

2 3

git:master:dc1df65f: ims_registrar_scscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: dc1df65fef8d4ad422507f9aeea3da1baeadf283 URL: https://github.com/kamailio/kamailio/commit/dc1df65fef8d4ad422507f9aeea3da1… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_registrar_scscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_registrar_scscf/cxdx_avp.c Modified: src/modules/ims_registrar_scscf/cxdx_avp.h Modified: src/modules/ims_registrar_scscf/cxdx_sar.c Modified: src/modules/ims_registrar_scscf/cxdx_sar.h Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.h Modified: src/modules/ims_registrar_scscf/pvt_message.c Modified: src/modules/ims_registrar_scscf/pvt_message.h Modified: src/modules/ims_registrar_scscf/registrar_notify.c Modified: src/modules/ims_registrar_scscf/registrar_notify.h Modified: src/modules/ims_registrar_scscf/save.c Modified: src/modules/ims_registrar_scscf/save.h Modified: src/modules/ims_registrar_scscf/sem.h Modified: src/modules/ims_registrar_scscf/server_assignment.c Modified: src/modules/ims_registrar_scscf/server_assignment.h Modified: src/modules/ims_registrar_scscf/stats.c Modified: src/modules/ims_registrar_scscf/stats.h Modified: src/modules/ims_registrar_scscf/userdata_parser.c Modified: src/modules/ims_registrar_scscf/userdata_parser.h Modified: src/modules/ims_registrar_scscf/usrloc_cb.c Modified: src/modules/ims_registrar_scscf/usrloc_cb.h --- Diff: https://github.com/kamailio/kamailio/commit/dc1df65fef8d4ad422507f9aeea3da1… Patch: https://github.com/kamailio/kamailio/commit/dc1df65fef8d4ad422507f9aeea3da1…

1 0

git:master:ed8e3829: ims_registrar_pcscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: ed8e382971981fd4147f48eae5f0f2cf92282ac7 URL: https://github.com/kamailio/kamailio/commit/ed8e382971981fd4147f48eae5f0f2c… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_registrar_pcscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_registrar_pcscf/async_reginfo.c Modified: src/modules/ims_registrar_pcscf/async_reginfo.h Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.h Modified: src/modules/ims_registrar_pcscf/save.c Modified: src/modules/ims_registrar_pcscf/save.h Modified: src/modules/ims_registrar_pcscf/sem.h Modified: src/modules/ims_registrar_pcscf/ul_callback.c Modified: src/modules/ims_registrar_pcscf/ul_callback.h --- Diff: https://github.com/kamailio/kamailio/commit/ed8e382971981fd4147f48eae5f0f2c… Patch: https://github.com/kamailio/kamailio/commit/ed8e382971981fd4147f48eae5f0f2c…

1 0

git:master:daf74039: ims_qos: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: daf74039f1867b14a557b9f2b9ccef8b0392b6bf URL: https://github.com/kamailio/kamailio/commit/daf74039f1867b14a557b9f2b9ccef8… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_qos: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_qos/cdpeventprocessor.c Modified: src/modules/ims_qos/cdpeventprocessor.h Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/ims_qos_mod.h Modified: src/modules/ims_qos/ims_qos_stats.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/rx_asr.c Modified: src/modules/ims_qos/rx_asr.h Modified: src/modules/ims_qos/rx_authdata.c Modified: src/modules/ims_qos/rx_authdata.h Modified: src/modules/ims_qos/rx_avp.c Modified: src/modules/ims_qos/rx_avp.h Modified: src/modules/ims_qos/rx_str.c Modified: src/modules/ims_qos/rx_str.h Modified: src/modules/ims_qos/sem.h Modified: src/modules/ims_qos/stats.c Modified: src/modules/ims_qos/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/daf74039f1867b14a557b9f2b9ccef8… Patch: https://github.com/kamailio/kamailio/commit/daf74039f1867b14a557b9f2b9ccef8…

1 0

git:master:cd57d606: ims_ocs: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: cd57d606cc6bfc96fca50e495d3a587fee25cc4f URL: https://github.com/kamailio/kamailio/commit/cd57d606cc6bfc96fca50e495d3a587… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_ocs: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_ocs/sem.h --- Diff: https://github.com/kamailio/kamailio/commit/cd57d606cc6bfc96fca50e495d3a587… Patch: https://github.com/kamailio/kamailio/commit/cd57d606cc6bfc96fca50e495d3a587… --- diff --git a/src/modules/ims_ocs/sem.h b/src/modules/ims_ocs/sem.h index f72073004ee..45d4467dd1f 100644 --- a/src/modules/ims_ocs/sem.h +++ b/src/modules/ims_ocs/sem.h @@ -6,7 +6,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -16,7 +16,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to

1 0

git:master:7e2850d3: ims_isc: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 7e2850d3813ae3a6b86ef90a0b2d9648d24dfa1a URL: https://github.com/kamailio/kamailio/commit/7e2850d3813ae3a6b86ef90a0b2d964… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_isc: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_isc/blurb Modified: src/modules/ims_isc/checker.c Modified: src/modules/ims_isc/checker.h Modified: src/modules/ims_isc/ims_isc_mod.c Modified: src/modules/ims_isc/ims_isc_mod.h Modified: src/modules/ims_isc/isc.c Modified: src/modules/ims_isc/isc.h Modified: src/modules/ims_isc/mark.c Modified: src/modules/ims_isc/mark.h Modified: src/modules/ims_isc/third_party_reg.c Modified: src/modules/ims_isc/third_party_reg.h --- Diff: https://github.com/kamailio/kamailio/commit/7e2850d3813ae3a6b86ef90a0b2d964… Patch: https://github.com/kamailio/kamailio/commit/7e2850d3813ae3a6b86ef90a0b2d964…

1 0

git:master:addc2362: ims_ipsec_pcscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: addc23622a4125293c25805cc8f1207af94a942a URL: https://github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_ipsec_pcscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_ipsec_pcscf/cmd.c Modified: src/modules/ims_ipsec_pcscf/cmd.h --- Diff: https://github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207… Patch: https://github.com/kamailio/kamailio/commit/addc23622a4125293c25805cc8f1207… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 3ce36d27952..1f85cffc694 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -5,7 +5,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -15,7 +15,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to diff --git a/src/modules/ims_ipsec_pcscf/cmd.h b/src/modules/ims_ipsec_pcscf/cmd.h index e22000028f1..bf0884b9623 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.h +++ b/src/modules/ims_ipsec_pcscf/cmd.h @@ -7,7 +7,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -17,7 +17,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to

1 0

git:master:485f322e: ims_icscf: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 485f322ed7251122f4eb724ac8043a492be30074 URL: https://github.com/kamailio/kamailio/commit/485f322ed7251122f4eb724ac8043a4… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_icscf: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_icscf/cxdx_avp.c Modified: src/modules/ims_icscf/cxdx_avp.h Modified: src/modules/ims_icscf/cxdx_lir.c Modified: src/modules/ims_icscf/cxdx_lir.h Modified: src/modules/ims_icscf/cxdx_uar.c Modified: src/modules/ims_icscf/cxdx_uar.h Modified: src/modules/ims_icscf/db.c Modified: src/modules/ims_icscf/db.h Modified: src/modules/ims_icscf/ims_icscf_mod.c Modified: src/modules/ims_icscf/ims_icscf_mod.h Modified: src/modules/ims_icscf/location.c Modified: src/modules/ims_icscf/location.h Modified: src/modules/ims_icscf/nds.c Modified: src/modules/ims_icscf/nds.h Modified: src/modules/ims_icscf/registration.c Modified: src/modules/ims_icscf/registration.h Modified: src/modules/ims_icscf/scscf_list.c Modified: src/modules/ims_icscf/scscf_list.h Modified: src/modules/ims_icscf/sip_messages.h Modified: src/modules/ims_icscf/stats.c Modified: src/modules/ims_icscf/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/485f322ed7251122f4eb724ac8043a4… Patch: https://github.com/kamailio/kamailio/commit/485f322ed7251122f4eb724ac8043a4…

1 0

git:master:f2f3e0bb: ims_diameter_server: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: f2f3e0bbb3f04cdb8fe184f4188ad83635a7a7c9 URL: https://github.com/kamailio/kamailio/commit/f2f3e0bbb3f04cdb8fe184f4188ad83… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_diameter_server: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_diameter_server/sem.h --- Diff: https://github.com/kamailio/kamailio/commit/f2f3e0bbb3f04cdb8fe184f4188ad83… Patch: https://github.com/kamailio/kamailio/commit/f2f3e0bbb3f04cdb8fe184f4188ad83… --- diff --git a/src/modules/ims_diameter_server/sem.h b/src/modules/ims_diameter_server/sem.h index f72073004ee..45d4467dd1f 100644 --- a/src/modules/ims_diameter_server/sem.h +++ b/src/modules/ims_diameter_server/sem.h @@ -6,7 +6,7 @@ * * The initial version of this code was written by Dragos Vingarzan * (dragos(dot)vingarzan(at)fokus(dot)fraunhofer(dot)de and the - * Fruanhofer Institute. It was and still is maintained in a separate + * Fraunhofer FOKUS Institute. It was and still is maintained in a separate * branch of the original SER. We are therefore migrating it to * Kamailio/SR and look forward to maintaining it from here on out. * 2011/2012 Smile Communications, Pty. Ltd. @@ -16,7 +16,7 @@ * effort to add full IMS support to Kamailio/SR using a new and * improved architecture * - * NB: Alot of this code was originally part of OpenIMSCore, + * NB: A lot of this code was originally part of OpenIMSCore, * FhG Fokus. * Copyright (C) 2004-2006 FhG Fokus * Thanks for great work! This is an effort to

1 0

git:master:18de7401: ims_auth: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 18de74013750809034742cc6313b39515b8390e2 URL: https://github.com/kamailio/kamailio/commit/18de74013750809034742cc6313b395… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 ims_auth: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/ims_auth/api.h Modified: src/modules/ims_auth/authorize.c Modified: src/modules/ims_auth/authorize.h Modified: src/modules/ims_auth/blurb Modified: src/modules/ims_auth/conversion.c Modified: src/modules/ims_auth/conversion.h Modified: src/modules/ims_auth/cxdx_avp.c Modified: src/modules/ims_auth/cxdx_avp.h Modified: src/modules/ims_auth/cxdx_mar.c Modified: src/modules/ims_auth/cxdx_mar.h Modified: src/modules/ims_auth/ims_auth_mod.c Modified: src/modules/ims_auth/ims_auth_mod.h Modified: src/modules/ims_auth/pvt_message.c Modified: src/modules/ims_auth/pvt_message.h Modified: src/modules/ims_auth/rfc2617.c Modified: src/modules/ims_auth/rfc2617.h Modified: src/modules/ims_auth/sip_messages.h Modified: src/modules/ims_auth/stats.c Modified: src/modules/ims_auth/stats.h Modified: src/modules/ims_auth/utils.c Modified: src/modules/ims_auth/utils.h --- Diff: https://github.com/kamailio/kamailio/commit/18de74013750809034742cc6313b395… Patch: https://github.com/kamailio/kamailio/commit/18de74013750809034742cc6313b395…

1 0

git:master:e2d03907: cdp_avp: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: e2d0390790867ad65d495d67eeb9ce85a096f522 URL: https://github.com/kamailio/kamailio/commit/e2d0390790867ad65d495d67eeb9ce8… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 cdp_avp: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/cdp_avp/avp_add.c Modified: src/modules/cdp_avp/avp_add.h Modified: src/modules/cdp_avp/avp_get.c Modified: src/modules/cdp_avp/avp_get.h Modified: src/modules/cdp_avp/avp_get_base_data_format.c Modified: src/modules/cdp_avp/avp_get_base_data_format.h Modified: src/modules/cdp_avp/avp_new.c Modified: src/modules/cdp_avp/avp_new.h Modified: src/modules/cdp_avp/avp_new_base_data_format.c Modified: src/modules/cdp_avp/avp_new_base_data_format.h Modified: src/modules/cdp_avp/base.c Modified: src/modules/cdp_avp/base.h Modified: src/modules/cdp_avp/ccapp.c Modified: src/modules/cdp_avp/ccapp.h Modified: src/modules/cdp_avp/cdp_avp_mod.c Modified: src/modules/cdp_avp/cdp_avp_mod.h Modified: src/modules/cdp_avp/epcapp.c Modified: src/modules/cdp_avp/epcapp.h Modified: src/modules/cdp_avp/get_reference.h Modified: src/modules/cdp_avp/imsapp.c Modified: src/modules/cdp_avp/imsapp.h Modified: src/modules/cdp_avp/macros.h Modified: src/modules/cdp_avp/nasapp.c Modified: src/modules/cdp_avp/nasapp.h --- Diff: https://github.com/kamailio/kamailio/commit/e2d0390790867ad65d495d67eeb9ce8… Patch: https://github.com/kamailio/kamailio/commit/e2d0390790867ad65d495d67eeb9ce8…

1 0

git:master:34254c61: cdp: fixed Fraunhofer FOKUS Institute name
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 34254c61eb76b26a25881b0465617124dd4593de URL: https://github.com/kamailio/kamailio/commit/34254c61eb76b26a25881b046561712… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:58:01+02:00 cdp: fixed Fraunhofer FOKUS Institute name - #3889 --- Modified: src/modules/cdp/acceptor.c Modified: src/modules/cdp/acceptor.h Modified: src/modules/cdp/api_process.c Modified: src/modules/cdp/api_process.h Modified: src/modules/cdp/authstatemachine.c Modified: src/modules/cdp/authstatemachine.h Modified: src/modules/cdp/cdp_load.c Modified: src/modules/cdp/cdp_load.h Modified: src/modules/cdp/cdp_mod.c Modified: src/modules/cdp/cdp_mod.h Modified: src/modules/cdp/config.c Modified: src/modules/cdp/config.h Modified: src/modules/cdp/configdtd.h Modified: src/modules/cdp/configparser.c Modified: src/modules/cdp/diameter.h Modified: src/modules/cdp/diameter_api.h Modified: src/modules/cdp/diameter_avp.c Modified: src/modules/cdp/diameter_code_avp.h Modified: src/modules/cdp/diameter_code_result.h Modified: src/modules/cdp/diameter_comm.c Modified: src/modules/cdp/diameter_epc.h Modified: src/modules/cdp/diameter_epc_code_app.h Modified: src/modules/cdp/diameter_epc_code_avp.h Modified: src/modules/cdp/diameter_epc_code_cmd.h Modified: src/modules/cdp/diameter_epc_code_result.h Modified: src/modules/cdp/diameter_ims.h Modified: src/modules/cdp/diameter_ims_code_app.h Modified: src/modules/cdp/diameter_ims_code_avp.h Modified: src/modules/cdp/diameter_ims_code_cmd.h Modified: src/modules/cdp/diameter_ims_code_result.h Modified: src/modules/cdp/diameter_msg.c Modified: src/modules/cdp/diameter_peer.c Modified: src/modules/cdp/diameter_peer.h Modified: src/modules/cdp/globals.c Modified: src/modules/cdp/globals.h Modified: src/modules/cdp/peer.c Modified: src/modules/cdp/peer.h Modified: src/modules/cdp/peermanager.c Modified: src/modules/cdp/peermanager.h Modified: src/modules/cdp/peerstatemachine.c Modified: src/modules/cdp/peerstatemachine.h Modified: src/modules/cdp/receiver.c Modified: src/modules/cdp/receiver.h Modified: src/modules/cdp/routing.c Modified: src/modules/cdp/routing.h Modified: src/modules/cdp/sem.h Modified: src/modules/cdp/session.c Modified: src/modules/cdp/session.h Modified: src/modules/cdp/tcp_accept.c Modified: src/modules/cdp/tcp_accept.h Modified: src/modules/cdp/timer.c Modified: src/modules/cdp/timer.h Modified: src/modules/cdp/transaction.c Modified: src/modules/cdp/transaction.h Modified: src/modules/cdp/utils.h Modified: src/modules/cdp/worker.c Modified: src/modules/cdp/worker.h --- Diff: https://github.com/kamailio/kamailio/commit/34254c61eb76b26a25881b046561712… Patch: https://github.com/kamailio/kamailio/commit/34254c61eb76b26a25881b046561712…

1 0

git:master:48d97c19: textopx/doc: fixed hard-to-read documentation for textopsx
by Daniel-Constantin Mierla 21 Jun '24

21 Jun '24

Module: kamailio Branch: master Commit: 48d97c1941f660aa396b5ef100584611cf92ad21 URL: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-21T12:57:56+02:00 textopx/doc: fixed hard-to-read documentation for textopsx - was missing line-wraps in examples list, hence very hard to read --- Modified: src/modules/textopsx/doc/selects.xml --- Diff: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461… Patch: https://github.com/kamailio/kamailio/commit/48d97c1941f660aa396b5ef10058461… --- diff --git a/src/modules/textopsx/doc/selects.xml b/src/modules/textopsx/doc/selects.xml index 6d4dd4e3a25..3c72c21cd36 100644 --- a/src/modules/textopsx/doc/selects.xml +++ b/src/modules/textopsx/doc/selects.xml @@ -9,30 +9,35 @@ <title>@hf_value</title> <para> Get value of required header-value or param. Note that functions called 'value2' - works with Authorization-like headers where comma is not treated as value delimiter. Formats: - @hf_value.HFNAME[IDX] # idx value, negative value counts from bottom - @hf_value.HFNAME.PARAM_NAME - @hf_value.HFNAME[IDX].PARAM_NAME - @hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param" - @hf_value.HFNAME[IDX].p.PARAM_NAME # dtto - @hf_value.HFNAME[IDX].uri # (< & > excluded) - @hf_value.HFNAME[*] # return comma delimited list of all values (combines headers) - @hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y - @hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded) - @hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y - @hf_value.HFNAME[IDX].name # returns name part, quotes excluded - @hf_value.HFNAME.name # returns name part of the first value + works with Authorization-like headers where comma is not treated as value delimiter. + </para> + <para> + Formats: + <itemizedlist> + <listitem>@hf_value.HFNAME[IDX] # idx value, negative value counts from bottom</listitem> + <listitem>@hf_value.HFNAME.PARAM_NAME</listitem> + <listitem>@hf_value.HFNAME[IDX].PARAM_NAME</listitem> + <listitem>@hf_value.HFNAME.p.PARAM_NAME # or .param., useful if required called "uri", "p", "param"</listitem> + <listitem>@hf_value.HFNAME[IDX].p.PARAM_NAME # dtto</listitem> + <listitem>@hf_value.HFNAME[IDX].uri # (< & > excluded)</listitem> + <listitem>@hf_value.HFNAME[*] # return comma delimited list of all values (combines headers)</listitem> + <listitem>@hf_value.HFNAME # the same as above [*] but may be parsed by cfg.y</listitem> + <listitem>@hf_value.HFNAME[*].uri # return comma delimited list of uris (< & > excluded)</listitem> + <listitem>@hf_value.HFNAME.uri # the same as above [*] but may be parsed by cfg.y</listitem> + <listitem>@hf_value.HFNAME[IDX].name # returns name part, quotes excluded</listitem> + <listitem>@hf_value.HFNAME.name # returns name part of the first value</listitem> - @hf_value2.HFNAME # returns value of first header - @hf_value2.HFNAME[IDX] # returns value of idx's header - @hf_value2.HFNAME.PARAM_NAME - @hf_value2.HFNAME[IDX].PARAM_NAME + <listitem>@hf_value2.HFNAME # returns value of first header</listitem> + <listitem>@hf_value2.HFNAME[IDX] # returns value of idx's header</listitem> + <listitem>@hf_value2.HFNAME.PARAM_NAME</listitem> + <listitem>@hf_value2.HFNAME[IDX].PARAM_NAME</listitem> - @hf_value.HFNAME[IDX].uri # return URI, quotes excluded - @hf_value.HFNAME.p.uri # returns param named uri, not URI itself - @hf_value.HFNAME.p.name # returns param named name, not name itself - @hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used - @hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr + <listitem>@hf_value.HFNAME[IDX].uri # return URI, quotes excluded</listitem> + <listitem>@hf_value.HFNAME.p.uri # returns param named uri, not URI itself</listitem> + <listitem>@hf_value.HFNAME.p.name # returns param named name, not name itself</listitem> + <listitem>@hf_value.HFNAME[IDX].uri.name # any sel_any_uri nested features may be used</listitem> + <listitem>@hf_value.HFNAME[IDX].nameaddr.name # select_any_nameaddr</listitem> + </itemizedlist> </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

1 0

git:5.8:4c75991a: db_mysql: switch warn to dbg for log messages for opt_ssl_ca option
by Victor Seva 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: 4c75991aa662bddc1bbe65c83f7861cb72a65a61 URL: https://github.com/kamailio/kamailio/commit/4c75991aa662bddc1bbe65c83f7861c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-19T15:02:09+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_ca option fixes #3884 (cherry picked from commit be5172a84b02a1ab4fc7e97e7dc0813056302bdd) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/4c75991aa662bddc1bbe65c83f7861c… Patch: https://github.com/kamailio/kamailio/commit/4c75991aa662bddc1bbe65c83f7861c… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 50e3375a11d..240d3f59a76 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -184,8 +184,8 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_WARN("opt_ssl_ca option not supported by mysql version (value %s) - " - "ignoring\n", + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + "ignoring\n", db_mysql_opt_ssl_ca); #endif /* MYSQL_OPT_SSL_CA */

1 0

[kamailio/kamailio] new db_mysql warnings when Kamailio starts (Issue #3884)
by juha-h 19 Jun '24

19 Jun '24

When I start Kamailio master version that has been built on Debian 12 with default-libmysqlclient-dev depending on libmariadb-dev-compat, several warnings like this are produced: ``` 2024-06-17T14:48:27.702827+03:00 siika /usr/bin/sip-proxy[297246]: WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring ``` The only db_mysql configuration option used in the config is ping_interval. I would expect that the warnings are not produced like it is the case when I build Kamailio branch 5.8. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3884 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3884(a)github.com>

3 5

git:master:be5172a8: db_mysql: switch warn to dbg for log messages for opt_ssl_ca option
by Victor Seva 19 Jun '24

19 Jun '24

Module: kamailio Branch: master Commit: be5172a84b02a1ab4fc7e97e7dc0813056302bdd URL: https://github.com/kamailio/kamailio/commit/be5172a84b02a1ab4fc7e97e7dc0813… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-19T15:00:12+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_ca option fixes #3884 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/be5172a84b02a1ab4fc7e97e7dc0813… Patch: https://github.com/kamailio/kamailio/commit/be5172a84b02a1ab4fc7e97e7dc0813… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 50e3375a11d..240d3f59a76 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -184,8 +184,8 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); #else - LM_WARN("opt_ssl_ca option not supported by mysql version (value %s) - " - "ignoring\n", + LM_DBG("opt_ssl_ca option not supported by mysql version (value %s) - " + "ignoring\n", db_mysql_opt_ssl_ca); #endif /* MYSQL_OPT_SSL_CA */

1 0

git:5.8:ec27c020: rabbitmq: don't try to use ssl_socket functions to a tcp_socket
by Victor Seva 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: ec27c0207a364fd4f563707b740877ab77bfb5a5 URL: https://github.com/kamailio/kamailio/commit/ec27c0207a364fd4f563707b740877a… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-19T12:14:18+02:00 rabbitmq: don't try to use ssl_socket functions to a tcp_socket fixes #3883 (cherry picked from commit 3a803770d4fb80347ba70dac94625b0e9aeab44d) --- Modified: src/modules/rabbitmq/rabbitmq.c --- Diff: https://github.com/kamailio/kamailio/commit/ec27c0207a364fd4f563707b740877a… Patch: https://github.com/kamailio/kamailio/commit/ec27c0207a364fd4f563707b740877a… --- diff --git a/src/modules/rabbitmq/rabbitmq.c b/src/modules/rabbitmq/rabbitmq.c index 8547bacac79..a1e95ad55b3 100644 --- a/src/modules/rabbitmq/rabbitmq.c +++ b/src/modules/rabbitmq/rabbitmq.c @@ -597,19 +597,22 @@ static int rabbitmq_connect(amqp_connection_state_t *conn) return RABBITMQ_ERR_SOCK; } - if(rmq_amqps_ca_file) { - if(amqp_ssl_socket_set_cacert(amqp_sock, rmq_amqps_ca_file)) { - LM_ERR("Failed to set CA certificate for amqps connection\n"); - return RABBITMQ_ERR_SSL_CACERT; + if(amqp_info.ssl) { // only valid for amqp_ssl_socket_t + if(rmq_amqps_ca_file) { + if(amqp_ssl_socket_set_cacert(amqp_sock, rmq_amqps_ca_file)) { + LM_ERR("Failed to set CA certificate for amqps connection\n"); + return RABBITMQ_ERR_SSL_CACERT; + } } - } #if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 8 - amqp_ssl_socket_set_verify(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); #else - amqp_ssl_socket_set_verify_peer(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); - amqp_ssl_socket_set_verify_hostname(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify_peer(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify_hostname( + amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); #endif + } ret = amqp_socket_open(amqp_sock, amqp_info.host, amqp_info.port); if(ret != AMQP_STATUS_OK) {

1 0

[kamailio/kamailio] rabbitmq: coredump trying to set ssl options (Issue #3883)
by Victor Seva 19 Jun '24

19 Jun '24

### Description amqp_ssl_socket_set_*() functions are just for amqp_ssl_socket sockets #### Reproduction ``` loadmodule "rabbitmq.so" modparam("rabbitmq", "url", "amqp://guest:guest@rabbitmq:5672/%2Fkamailio") ``` #### Debugging Data ``` (gdb) bt #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x00007fd60b427e8f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 0x00007fd60b3d8fb2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #3 0x00007fd60b3c3472 in __GI_abort () at ./stdlib/abort.c:79 #4 0x00007fd5f5a78831 in amqp_abort (fmt=fmt@entry=0x7fd5f5a82358 "<%p> is not of type amqp_ssl_socket_t") at ./librabbitmq/amqp_api.c:183 #5 0x00007fd5f5a7f032 in amqp_ssl_socket_set_verify_peer (base=<optimized out>, verify=verify@entry=0) at ./librabbitmq/amqp_openssl.c:519 #6 0x00007fd5f5a8adf1 in rabbitmq_connect (conn=0x7fd5f5a98328 <amqp_conn>) at ./src/modules/rabbitmq/rabbitmq.c:610 #7 0x00007fd5f5a918e7 in mod_child_init (rank=-127) at ./src/modules/rabbitmq/rabbitmq.c:180 #8 0x000055ec03183a8f in init_mod_child (m=0x7fd607c8bd00, rank=-127) at core/sr_module.c:920 #9 0x000055ec031887ab in init_child (rank=rank@entry=-127) at core/sr_module.c:999 #10 0x000055ec02ff5e07 in main_loop () at ./src/main.c:1725 #11 0x000055ec02feba87 in main (argc=<optimized out>, argv=<optimized out>) at ./src/main.c:3256 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3883 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3883(a)github.com>

1 1

git:master:3a803770: rabbitmq: don't try to use ssl_socket functions to a tcp_socket
by Victor Seva 19 Jun '24

19 Jun '24

Module: kamailio Branch: master Commit: 3a803770d4fb80347ba70dac94625b0e9aeab44d URL: https://github.com/kamailio/kamailio/commit/3a803770d4fb80347ba70dac94625b0… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-19T12:10:35+02:00 rabbitmq: don't try to use ssl_socket functions to a tcp_socket fixes #3883 --- Modified: src/modules/rabbitmq/rabbitmq.c --- Diff: https://github.com/kamailio/kamailio/commit/3a803770d4fb80347ba70dac94625b0… Patch: https://github.com/kamailio/kamailio/commit/3a803770d4fb80347ba70dac94625b0… --- diff --git a/src/modules/rabbitmq/rabbitmq.c b/src/modules/rabbitmq/rabbitmq.c index 8547bacac79..a1e95ad55b3 100644 --- a/src/modules/rabbitmq/rabbitmq.c +++ b/src/modules/rabbitmq/rabbitmq.c @@ -597,19 +597,22 @@ static int rabbitmq_connect(amqp_connection_state_t *conn) return RABBITMQ_ERR_SOCK; } - if(rmq_amqps_ca_file) { - if(amqp_ssl_socket_set_cacert(amqp_sock, rmq_amqps_ca_file)) { - LM_ERR("Failed to set CA certificate for amqps connection\n"); - return RABBITMQ_ERR_SSL_CACERT; + if(amqp_info.ssl) { // only valid for amqp_ssl_socket_t + if(rmq_amqps_ca_file) { + if(amqp_ssl_socket_set_cacert(amqp_sock, rmq_amqps_ca_file)) { + LM_ERR("Failed to set CA certificate for amqps connection\n"); + return RABBITMQ_ERR_SSL_CACERT; + } } - } #if AMQP_VERSION_MAJOR == 0 && AMQP_VERSION_MINOR < 8 - amqp_ssl_socket_set_verify(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); #else - amqp_ssl_socket_set_verify_peer(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); - amqp_ssl_socket_set_verify_hostname(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify_peer(amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); + amqp_ssl_socket_set_verify_hostname( + amqp_sock, (rmq_amqps_ca_file) ? 1 : 0); #endif + } ret = amqp_socket_open(amqp_sock, amqp_info.host, amqp_info.port); if(ret != AMQP_STATUS_OK) {

1 0

[kamailio/kamailio] IMS register fail for AAASendMessage() Can't find a suitable connected peer in the routing table. (Issue #3879)
by lglhust 19 Jun '24

19 Jun '24

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ![image](https://github.com/kamailio/kamailio/assets/64653660/c3a10d79-f713-43a4-8151-4e80ea8bfc90) ### Possible Solutions  If I restarted pcscf, ims registration worked well.After some time ,the error occurred again. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` kamailio v5.6.0 * **Operating System**:  ubuntu server 18.04 ``` (paste your output here) ``` [Uploading ims-reg-fail (1).zip…]() -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3879 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3879(a)github.com>

2 6

git:5.8:e430a7b5: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: e430a7b5eac9311cde1ea6a4d6f9fddacebe7302 URL: https://github.com/kamailio/kamailio/commit/e430a7b5eac9311cde1ea6a4d6f9fdd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-19T11:16:19+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/ims_icscf/README Modified: src/modules/ims_usrloc_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/e430a7b5eac9311cde1ea6a4d6f9fdd… Patch: https://github.com/kamailio/kamailio/commit/e430a7b5eac9311cde1ea6a4d6f9fdd…

1 0

[kamailio/kamailio] Is it possible to decode an number within Kamailio? (Issue #3882)
by Chen Ziyan 19 Jun '24

19 Jun '24

Recently ,I've learned about Kamailio and set up it. I want to decode my phone number before my FS, so whether it is possible to decode an number within Kamailio?Any help? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3882 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3882(a)github.com>

2 2

git:5.8:7360ab7f: db_mysql: switch warn to dbg for log messages for opt_ssl_mode
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: 7360ab7fbe672259c7433b1a5199467d24183d79 URL: https://github.com/kamailio/kamailio/commit/7360ab7fbe672259c7433b1a5199467… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:59:29+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_mode - GH #3884 (cherry picked from commit 8f98317e92da61160a1c416e0da45938a205d358) --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/7360ab7fbe672259c7433b1a5199467… Patch: https://github.com/kamailio/kamailio/commit/7360ab7fbe672259c7433b1a5199467… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 561a0037223..50e3375a11d 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -143,7 +143,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #if MYSQL_VERSION_ID >= 100339 mysql_options(ptr->con, MYSQL_OPT_SSL_ENFORCE, (void *)&(int){1}); #else - LM_WARN("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); + LM_DBG("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); #endif break; case 5: /* SSL_MODE_VERIFY_IDENTITY */ @@ -151,7 +151,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) (void *)&(int){1}); break; default: - LM_WARN("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", + LM_DBG("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", db_mysql_opt_ssl_mode); break; }

1 0

git:5.8:1a6907f1: ims_usrloc_pcscf: Update the module document
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: 1a6907f11b1c8455c14cd24f3a55aff7a3aa0184 URL: https://github.com/kamailio/kamailio/commit/1a6907f11b1c8455c14cd24f3a55aff… Author: H.Yavari <hyavari(a)senasoftware.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:59:13+02:00 ims_usrloc_pcscf: Update the module document - Fixing the db_url param value from int to string in admin document. (cherry picked from commit 04e065af3d46e4b0def5ed3de6502442466f04bc) --- Modified: src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1a6907f11b1c8455c14cd24f3a55aff… Patch: https://github.com/kamailio/kamailio/commit/1a6907f11b1c8455c14cd24f3a55aff…

1 0

git:5.8:9cbe3176: ims_icscf: add missing documents for database params
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: 9cbe3176f5c8c298956ed2d4b83818ceb64af528 URL: https://github.com/kamailio/kamailio/commit/9cbe3176f5c8c298956ed2d4b83818c… Author: H.Yavari <hyavari(a)senasoftware.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:59:01+02:00 ims_icscf: add missing documents for database params - Adding missing ims_icscf database parameters to admin documents. - Change the default value for ims_icscf db_url to Kamailio default db_url value. (cherry picked from commit 57087e42f1b1cae86132c558aa9497f4839af7e0) --- Modified: src/modules/ims_icscf/doc/ims_icscf_admin.xml Modified: src/modules/ims_icscf/ims_icscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/9cbe3176f5c8c298956ed2d4b83818c… Patch: https://github.com/kamailio/kamailio/commit/9cbe3176f5c8c298956ed2d4b83818c… --- diff --git a/src/modules/ims_icscf/doc/ims_icscf_admin.xml b/src/modules/ims_icscf/doc/ims_icscf_admin.xml index 9ae046e6794..e3c552a1c57 100644 --- a/src/modules/ims_icscf/doc/ims_icscf_admin.xml +++ b/src/modules/ims_icscf/doc/ims_icscf_admin.xml @@ -111,6 +111,106 @@ modparam("ims_icscf","scscf_entry_expiry", 300) </example> </section> + <section> + <title><varname>db_url</varname> (string)</title> + + <para> + &url; of the database to be used. + </para> + + <para> + If the db_url string is empty, the default database URL + will be used. + </para> + + <para> + <emphasis> + Default value is <quote>&defaultrodb;</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_url</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_url", "&exampledb;") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_nds_table</varname> (string)</title> + + <para> + NDS (Network Domain Security) table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>nds_trusted_domains</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_nds_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_nds_table", "nds_trusted_domains") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_scscf_table</varname> (string)</title> + + <para> + S-CSCF table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>s_cscf</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_scscf_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_scscf_table", "s_cscf") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_capabilities_table</varname> (string)</title> + + <para> + S-CSCF capabilities table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>s_cscf_capabilities</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_capabilities_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_capabilities_table", "s_cscf_capabilities") +... + </programlisting> + </example> + </section> + <section> <title><varname>cxdx_forced_peer</varname> (string)</title> diff --git a/src/modules/ims_icscf/ims_icscf_mod.c b/src/modules/ims_icscf/ims_icscf_mod.c index 502fcf68174..a690891ee46 100644 --- a/src/modules/ims_icscf/ims_icscf_mod.c +++ b/src/modules/ims_icscf/ims_icscf_mod.c @@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL; stat_var *lir_replies_response_time = NULL; //module parameters -char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ +char *ims_icscf_db_url = DEFAULT_RODB_URL; /**< DB URL */ char *ims_icscf_db_nds_table = "nds_trusted_domains"; /**< NDS table in DB */ char *ims_icscf_db_scscf_table = "s_cscf"; /**< S-CSCF table in db */ char *ims_icscf_db_capabilities_table =

1 0

git:5.8:c73ea949: ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: c73ea949c046697916fd86eaf614b59075264b73 URL: https://github.com/kamailio/kamailio/commit/c73ea949c046697916fd86eaf614b59… Author: herlesupreeth <herlesupreeth(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:58:04+02:00 ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact (cherry picked from commit bf863877f666dd8350e855bf933270b2fd8ad0fd) --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/c73ea949c046697916fd86eaf614b59… Patch: https://github.com/kamailio/kamailio/commit/c73ea949c046697916fd86eaf614b59… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 05079834252..3ce36d27952 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -900,12 +900,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) goto cleanup; } - if(ul.update_pcontact(d, &ci, pcontact) != 0) { - LM_ERR("Error updating contact\n"); - goto cleanup; - } - if(ci.via_port == SIP_PORT) { + if(req_sec_params != NULL) { + pcontact->security_temp->data.ipsec = s; + } // Update temp security parameters if(ul.update_temp_security(d, pcontact->security_temp->type, pcontact->security_temp, pcontact) @@ -914,6 +912,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) } } + if(ul.update_pcontact(d, &ci, pcontact) != 0) { + LM_ERR("Error updating contact\n"); + goto cleanup; + } if(add_supported_secagree_header(m) != 0) { goto cleanup;

1 0

git:5.8:f8613010: ims_registrar_pcscf: fix typo in comments
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: f861301003d96fec599bef936c2e1f181b170d9f URL: https://github.com/kamailio/kamailio/commit/f861301003d96fec599bef936c2e1f1… Author: herlesupreeth <herlesupreeth(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:57:46+02:00 ims_registrar_pcscf: fix typo in comments (cherry picked from commit d17b97a864585782e03eedada6d226550630f7bb) --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/f861301003d96fec599bef936c2e1f1… Patch: https://github.com/kamailio/kamailio/commit/f861301003d96fec599bef936c2e1f1… --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 679abc99ca5..025cb78a5d8 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -289,7 +289,7 @@ static inline int update_contacts(struct sip_msg *req, struct sip_msg *rpl, LM_DBG("Error subscribing for contact\n"); } - // After successful registration try to unregister all callbacks for pending contacts ralated to this contact. + // After successful registration try to unregister all callbacks for pending contacts related to this contact. ul.unreg_pending_contacts_cb( _d, pcontact, PCSCF_CONTACT_EXPIRE); }

1 0

git:5.8:2606c4e0: siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: 5.8 Commit: 2606c4e07e598ea41cb5a8814e3587bf49f94c1e URL: https://github.com/kamailio/kamailio/commit/2606c4e07e598ea41cb5a8814e3587b… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:57:25+02:00 siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used - send_sock_name/send_sock_address is ineffective for tcp based transports if SND_F_FORCE_SOCKET flag is not set (cherry picked from commit 1b97a0271b27794263b3eff61f4acfa81e66069f) --- Modified: src/modules/siptrace/siptrace_send.c --- Diff: https://github.com/kamailio/kamailio/commit/2606c4e07e598ea41cb5a8814e3587b… Patch: https://github.com/kamailio/kamailio/commit/2606c4e07e598ea41cb5a8814e3587b… --- diff --git a/src/modules/siptrace/siptrace_send.c b/src/modules/siptrace/siptrace_send.c index d8a5f974bb3..4f9726de254 100644 --- a/src/modules/siptrace/siptrace_send.c +++ b/src/modules/siptrace/siptrace_send.c @@ -357,6 +357,8 @@ int trace_send_duplicate(char *buf, int len, dest_info_t *dst2) pdst->to.s.sa_family, pdst->proto); goto error; } + } else { + pdst->send_flags.f |= SND_F_FORCE_SOCKET; } if(msg_send_buffer(pdst, buf, len, 1) < 0) {

1 0

git:master:8f98317e: db_mysql: switch warn to dbg for log messages for opt_ssl_mode
by Daniel-Constantin Mierla 19 Jun '24

19 Jun '24

Module: kamailio Branch: master Commit: 8f98317e92da61160a1c416e0da45938a205d358 URL: https://github.com/kamailio/kamailio/commit/8f98317e92da61160a1c416e0da4593… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-19T10:44:29+02:00 db_mysql: switch warn to dbg for log messages for opt_ssl_mode - GH #3884 --- Modified: src/modules/db_mysql/km_my_con.c --- Diff: https://github.com/kamailio/kamailio/commit/8f98317e92da61160a1c416e0da4593… Patch: https://github.com/kamailio/kamailio/commit/8f98317e92da61160a1c416e0da4593… --- diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 561a0037223..50e3375a11d 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -143,7 +143,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) #if MYSQL_VERSION_ID >= 100339 mysql_options(ptr->con, MYSQL_OPT_SSL_ENFORCE, (void *)&(int){1}); #else - LM_WARN("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); + LM_DBG("ssl mode not supported by %s\n", MARIADB_BASE_VERSION); #endif break; case 5: /* SSL_MODE_VERIFY_IDENTITY */ @@ -151,7 +151,7 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) (void *)&(int){1}); break; default: - LM_WARN("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", + LM_DBG("opt_ssl_mode = %d not supported by MariaDB Connector/C\n", db_mysql_opt_ssl_mode); break; }

1 0

[kamailio/kamailio] Kamailio 5.6 (and 5.7) core dumps. (Issue #3725)
by Mattis Lind 19 Jun '24

19 Jun '24

### Description We have a quite basic scenario which sends a SIP MESSAGE and then receives SIP MESSAGE back. It also sets up two voice calls using SIP INVITE. It is only this specific scenario that is causing the core dump. Some time the core dump occur just a few seconds after the call/message scenario, but occasionally it takes up to 50 minutes. We have been using the uac module for sending SIP MESSAGE in several other scenarios without experiencing a crash. We always see the same lines in the log just prior to the core dump: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 49 We are using Kamailio 5.6 retrieved from the kamailio repository: http://deb.kamailio.org/kamailio56. We are running Kamailio in a Docker container which runs on "5.10.0-25-cloud-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux" We have also tried Kamailio 5.7 from the same repo which crashes in exactly the same way. ### Troubleshooting #### Reproduction We have troubles to consistently reproduce it and it only happen from time to time when running a specific scenario sending SIP MESSAGE using the uac module. It does not happen for every call of this call scenario. At one instance Kamailo crashed with just 15 seconds in-between during the call scenario. #### Debugging Data ``` # gdb /usr/sbin/kamailio /core GNU gdb (Debian 10.1-1.7) 10.1.90.20210103-git Copyright (C) 2021 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... (No debugging symbols found in /usr/sbin/kamailio) warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing [New LWP 4777] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -DD -M 18 -m 192 -A serverId=17173 -A sendTraceLocal="sip:10'. Program terminated with signal SIGSEGV, Segmentation fault. #0 __strlen_evex () at ../sysdeps/x86_64/multiarch/strlen-evex.S:77 77 ../sysdeps/x86_64/multiarch/strlen-evex.S: No such file or directory. (gdb) bt full #0 __strlen_evex () at ../sysdeps/x86_64/multiarch/strlen-evex.S:77 No locals. #1 0x00007f5425e34b78 in __vfprintf_internal (s=s@entry=0x55a06e969a60, format=format@entry=0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", ap=ap@entry=0x7ffd6bebfb50, mode_flags=mode_flags@entry=0) at vfprintf-internal.c:1647 len = <optimized out> step0_jumps = {0, 1717, 1621, 3413, 3317, 3997, 2677, 2837, 3613, 1773, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 4101} space = <optimized out> is_short = <optimized out> use_outdigits = 0 outc = <optimized out> step1_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 1773, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 0} group = 0 prec = -1 step2_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4309, 4445, 3517, 4437, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 533, 533, 0} string = 0x756d6f7266222c22 <error: Cannot access memory at address 0x756d6f7266222c22> left = 0 is_long_double = <optimized out> width = 0 signed_number = <optimized out> step3a_jumps = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4213, 0, 0, 0, 4389, 2789, 4197, 3917, 3221, 0, 0, 0, 0, 1925, 0, 0, 0, 0, 0, 0} alt = <optimized out> showsign = 0 is_long = 0 is_char = <optimized out> pad = <optimized out> step3b_jumps = {0 <repeats 11 times>, 3517, 0, 0, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 0, 0, 0} step4_jumps = {0 <repeats 14 times>, 4389, 2789, 4197, 3917, 3221, 2997, 1141, 1365, 1997, 1925, 1885, 733, 3709, 0, 0, 0} args_value = <optimized out> is_negative = <optimized out> number = {longlong = <optimized out>, word = <optimized out>} base = <optimized out> the_arg = {pa_wchar = 4777 L'\x12a9', pa_int = 4777, pa_long_int = 4777, pa_long_long_int = 4777, pa_u_int = 4777, pa_u_long_int = 4777, pa_u_long_long_int = 4777, pa_double = 2.3601515901836347e-320, pa_long_double = 1.74131181638025811763e-4947, pa_float128 = 3.09319115455554459548860449034534676e-4962, pa_string = 0x12a9 <error: Cannot access memory at address 0x12a9>, pa_wstring = 0x12a9 <error: Cannot access memory at address 0x12a9>, pa_pointer = 0x12a9, pa_user = 0x12a9} spec = 115 's' _buffer = {__routine = 0x4, __arg = 0xd, __canceltype = 1855363680, __prev = 0xe0} _avail = <optimized out> thousands_sep = 0x0 grouping = 0xffffffffffffffff <error: Cannot access memory at address 0xffffffffffffffff> done = 238 f = 0x55a06e5580a7 "s:%lu. Exec from %s:%u.\n" lead_str_end = 0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n" end_of_spec = <optimized out> work_buffer = "h\r\000\000\000\000\000\000\000\000\000\000\060\000\000\000\000\000\000\000\375\177\000\000 \372\353k\375\177\000\000\237MSn\n\000\000\000\000\000\000\000\240U", '\000' <repeats 18 times>, "P\225Un\240U\000\000\000\000\000\000[\214A\323\f\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377\206\002", '\000' <repeats 14 times>, "\004\000\000\000\000\000\000\000 \367\353k\375\177\000\000\301\225Un\240U\000\000\323\262\vn\240U\000\000\000\000\000\000\000\000\000\000s\374On\240U\000\000W\225Un\240U\000\000\350>\212\027T\177\000\000 \323\365$T\177\000\000\060\a\354k\375\177\000\00--Type <RET> for more, q to quit, c to continue without paging-- 0\220\371\227n\240U\000\000"... workend = 0x7ffd6bebf9f8 "" ap_save = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7ffd6bebfc30, reg_save_area = 0x7ffd6bebfb70}} nspecs_done = 10 save_errno = 4 readonly_format = 0 do_longlong_number = <optimized out> __result = <optimized out> #2 0x00007f5425ec079f in __vsyslog_internal (pri=<optimized out>, fmt=0x55a06e558020 "%s: %.*s%s%s%sBUG: qm: fragm. %p (address %p) beginning overwritten (%lx)! Memory allocator was called from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", ap=0x7ffd6bebfb50, mode_flags=0) at ../misc/syslog.c:233 now_tm = {tm_sec = 8, tm_min = 18, tm_hour = 12, tm_mday = 23, tm_mon = 0, tm_year = 124, tm_wday = 2, tm_yday = 22, tm_isdst = 0, tm_gmtoff = 0, tm_zone = 0x55a06e94c5e0 "UTC"} now = 1706012288 fd = <optimized out> f = 0x55a06e969a60 buf = 0x0 bufsize = 0 msgoff = 21 saved_errno = <optimized out> failbuf = "`\232\226n\240U\000\000\000\204\201\247[\214A\323`\374\353k\375\177\000\000\300p\371%T" clarg = {buf = <optimized out>, oldaction = <optimized out>} #3 0x00007f5425ec0c46 in __syslog (pri=<optimized out>, fmt=<optimized out>) at ../misc/syslog.c:117 ap = {{gp_offset = 48, fp_offset = 48, overflow_arg_area = 0x7ffd6bebfc70, reg_save_area = 0x7ffd6bebfb70}} #4 0x000055a06e3b7839 in ?? () No symbol table info available. #5 0x000055a06e3bc039 in qm_free () No symbol table info available. #6 0x000055a06e3c7c28 in qm_shm_free () No symbol table info available. #7 0x00007f542325fb8e in uac_send_tm_callback () from /usr/lib/x86_64-linux-gnu/kamailio/modules/uac.so No symbol table info available. #8 0x00007f5424a2f002 in run_trans_callbacks_internal () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so No symbol table info available. #9 0x00007f5424a2f179 in run_trans_callbacks () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so No symbol table info available. #10 0x00007f54249d5e8c in free_cell_helper () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so No symbol table info available. #11 0x00007f5424aa8f82 in wait_handler () from /usr/lib/x86_64-linux-gnu/kamailio/modules/tm.so No symbol table info available. #12 0x000055a06e37a263 in ?? () No symbol table info available. #13 0x000055a06e37a79d in ?? () No symbol table info available. #14 0x000055a06e37acc6 in timer_main () No symbol table info available. #15 0x000055a06e0a5f62 in main_loop () No symbol table info available. --Type <RET> for more, q to quit, c to continue without paging-- #16 0x000055a06e0b120c in main () No symbol table info available. (gdb) info locals No locals. (gdb) list 72 in ../sysdeps/x86_64/multiarch/strlen-evex.S ``` #### Log Messages ``` Log file: 2024-01-23T13:18:08.828+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4789]: INFO: <script>: Incoming SIP TCP request conid 21 call-id un0rihsRLJLvP-grn6LO-A 2024-01-23T13:18:08.835+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4789]: INFO: <script>: Incoming SIP TCP request conid 21 call-id WQjhldpRJbxjZRYe7fWgbw 2024-01-23T13:18:08.860+01:00 Jan 23 12:18:08 /usr/sbin/kamailio[4795]: CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 49 2024-01-23T13:18:09.486+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: ALERT: <core> [main.c:783]: handle_sigs(): child process 4777 exited by a signal 11 2024-01-23T13:18:09.486+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: ALERT: <core> [main.c:787]: handle_sigs(): core was generated 2024-01-23T13:18:09.516+01:00 Jan 23 12:18:09 /usr/sbin/kamailio[4751]: INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized 2024-01-23T13:18:09.570+01:00 Started /root/sipconfig/startkamailio.sh 2024-01-23T13:18:09.570+01:00 info: :-) Starting Kamailio ``` #### SIP Traffic ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # /usr/sbin/kamailio -v version: kamailio 5.6.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye Linux ip-nn-nn-nn-nn 5.10.0-25-cloud-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3725 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3725(a)github.com>

4 8

git:5.8:be76a514: tls: remove confusing error message when trying to print socket for <default> server
by Victor Seva 18 Jun '24

18 Jun '24

Module: kamailio Branch: 5.8 Commit: be76a51422df3294c533accae1b6a621ee9d3a7d URL: https://github.com/kamailio/kamailio/commit/be76a51422df3294c533accae1b6a62… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-18T18:56:53+02:00 tls: remove confusing error message when trying to print socket for <default> server > CRITICAL: <core> [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0 > NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ... (cherry picked from commit 87c8290ab934fd27f8baebabaf66d1fb4168ba72) --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/be76a51422df3294c533accae1b6a62… Patch: https://github.com/kamailio/kamailio/commit/be76a51422df3294c533accae1b6a62… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index e056a70b504..810a7e9589a 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1155,14 +1155,14 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) d->ctx[i], tls_server_name_cb)) { LM_ERR("register server_name callback handler for socket " "[%s:%d], server_name='%s' failed for proc %d\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>", i); return -1; } if(!SSL_CTX_set_tlsext_servername_arg(d->ctx[i], d)) { LM_ERR("register server_name callback handler data for socket " "[%s:%d], server_name='%s' failed for proc %d\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>", i); return -1; } @@ -1175,7 +1175,7 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) && (d->server_name.len > 0 || (d->type & TLS_DOMAIN_DEF))) { LM_NOTICE("registered server_name callback handler for socket " "[%s:%d], server_name='%s' ...\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>"); } #endif

1 0

[kamailio/kamailio] github: [skip ci]: bump docker/build-push-action from 5 to 6 (PR #3880)
by dependabot[bot] 18 Jun '24

18 Jun '24

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">do… releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <ul> <li>Export build record and generate <a href="https://docs.docker.com/build/ci/github-actions/build-summary/&q… summary</a> by <a href="https://github.com/crazy-max"><code>@crazy-max&lt… in <a href="https://redirect.github.com/docker/build-push-action/pull/1120&q… <li>Bump <code>@docker/actions-toolkit</code> from 0.24.0 to 0.26.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1132&q… <a href="https://redirect.github.com/docker/build-push-action/pull/1136&q… <a href="https://redirect.github.com/docker/build-push-action/pull/1138&q… <li>Bump braces from 3.0.2 to 3.0.3 in <a href="https://redirect.github.com/docker/build-push-action/pull/1137&q… </ul> <blockquote> <p>[!NOTE] This major release adds support for generating <a href="https://docs.docker.com/build/ci/github-actions/build-summary/&q… summary</a> and exporting build record for your build. You can disable this feature by setting <a href="https://docs.docker.com/build/ci/github-actions/build-summary/#d… <code>DOCKER_BUILD_NO_SUMMARY: true</code> environment variable in your workflow</a>.</p> </blockquote> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v5.4.0...v6.… <h2>v5.4.0</h2> <ul> <li>Show builder information before building by <a href="https://github.com/crazy-max"><code>@crazy-max&lt… in <a href="https://redirect.github.com/docker/build-push-action/pull/1128&q… <li>Handle attestations correctly with provenance and sbom inputs by <a href="https://github.com/crazy-max"><code>@crazy-max&lt… in <a href="https://redirect.github.com/docker/build-push-action/pull/1086&q… <li>Bump <code>@docker/actions-toolkit</code> from 0.19.0 to 0.24.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1088&q… <a href="https://redirect.github.com/docker/build-push-action/pull/1105&q… <a href="https://redirect.github.com/docker/build-push-action/pull/1121&q… <a href="https://redirect.github.com/docker/build-push-action/pull/1127&q… <li>Bump undici from 5.28.3 to 5.28.4 in <a href="https://redirect.github.com/docker/build-push-action/pull/1090&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v5.3.0...v5.… <h2>v5.3.0</h2> <ul> <li>Bump <code>@docker/actions-toolkit</code> from 0.18.0 to 0.19.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1080&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v5.2.0...v5.… <h2>v5.2.0</h2> <ul> <li>Disable quotes detection for <code>outputs</code> input by <a href="https://github.com/crazy-max"><code>@crazy-max&lt… in <a href="https://redirect.github.com/docker/build-push-action/pull/1074&q… <li>Warn about ignored inputs by <a href="https://github.com/favonia"><code>@favonia</co… in <a href="https://redirect.github.com/docker/build-push-action/pull/1019&q… <li>Bump <code>@docker/actions-toolkit</code> from 0.14.0 to 0.18.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1070&q… <li>Bump undici from 5.26.3 to 5.28.3 in <a href="https://redirect.github.com/docker/build-push-action/pull/1057&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v5.1.0...v5.… <h2>v5.1.0</h2> <ul> <li>Add <code>annotations</code> input by <a href="https://github.com/crazy-max"><code>@crazy-max&lt… in <a href="https://redirect.github.com/docker/build-push-action/pull/992&qu… <li>Add <code>secret-envs</code> input by <a href="https://github.com/elias-lundgren"><code>@elias-l… in <a href="https://redirect.github.com/docker/build-push-action/pull/980&qu… <li>Bump <code>@babel/traverse</code> from 7.17.3 to 7.23.2 in <a href="https://redirect.github.com/docker/build-push-action/pull/991&qu… <li>Bump <code>@docker/actions-toolkit</code> from 0.13.0-rc.1 to 0.14.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/990&qu… <a href="https://redirect.github.com/docker/build-push-action/pull/1006&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v5.0.0...v5.… </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/c382f710d39a5… Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1120… from crazy-max/build-summary</li> <li><a href="https://github.com/docker/build-push-action/commit/5a5b70d974381… chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/dc24cf9e252ee… don't generate summary for cloud driver</li> <li><a href="https://github.com/docker/build-push-action/commit/667cb22c52a87… DOCKER_BUILD_NO_SUMMARY env to disable summary</li> <li><a href="https://github.com/docker/build-push-action/commit/d880b1964b626… generate build summary</li> <li><a href="https://github.com/docker/build-push-action/commit/e51051ad0baf1… export build record and upload artifact</li> <li><a href="https://github.com/docker/build-push-action/commit/86c2bd0031842… Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1137… from docker/dependabot/npm_and_yarn/braces-3.0.3</li> <li><a href="https://github.com/docker/build-push-action/commit/268d2b1611793… Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1138… from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="https://github.com/docker/build-push-action/commit/2b8dc7f52914d… chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/840c12be1707e… chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.25.1 to 0.26.0</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v5...v6&quot… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3880 -- Commit Summary -- * github: [skip ci]: bump docker/build-push-action from 5 to 6 -- File Changes -- M .github/workflows/alpine.yml (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3880.patch https://github.com/kamailio/kamailio/pull/3880.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3880 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3880(a)github.com>

2 1

git:master:bc8ff957: github: [skip ci]: bump docker/build-push-action from 5 to 6
by Victor Seva 18 Jun '24

18 Jun '24

Module: kamailio Branch: master Commit: bc8ff9572eb2930a08dbfe16c94c7f878a05be72 URL: https://github.com/kamailio/kamailio/commit/bc8ff9572eb2930a08dbfe16c94c7f8… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-18T08:39:58+02:00 github: [skip ci]: bump docker/build-push-action from 5 to 6 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/v5...v6) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/alpine.yml --- Diff: https://github.com/kamailio/kamailio/commit/bc8ff9572eb2930a08dbfe16c94c7f8… Patch: https://github.com/kamailio/kamailio/commit/bc8ff9572eb2930a08dbfe16c94c7f8… --- diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 3bf126e588d..5b888aadd36 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -139,7 +139,7 @@ jobs: - name: Build and push "-debug" build if: ${{ steps.should_run.outputs.should_run != 'false' }} - uses: docker/build-push-action@v5 + uses: docker/build-push-action@v6 with: context: pkg/docker/alpine file: pkg/docker/alpine/Dockerfile.debug @@ -158,7 +158,7 @@ jobs: - name: Build and push "-alpine" build if: ${{ steps.should_run.outputs.should_run != 'false' }} - uses: docker/build-push-action@v5 + uses: docker/build-push-action@v6 with: context: pkg/docker/alpine file: pkg/docker/alpine/Dockerfile.alpine @@ -168,7 +168,7 @@ jobs: - name: Build and push if: ${{ steps.should_run.outputs.should_run != 'false' }} - uses: docker/build-push-action@v5 + uses: docker/build-push-action@v6 with: context: pkg/docker/alpine file: pkg/docker/alpine/Dockerfile

1 0

git:master:fabd1eb4: modules: readme files regenerated - ims_icscf ... [skip ci]
by Kamailio Dev 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: fabd1eb423b62a5899857cf6c0974bb26fd8be30 URL: https://github.com/kamailio/kamailio/commit/fabd1eb423b62a5899857cf6c0974bb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-17T16:01:09+02:00 modules: readme files regenerated - ims_icscf ... [skip ci] --- Modified: src/modules/ims_icscf/README Modified: src/modules/ims_usrloc_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/fabd1eb423b62a5899857cf6c0974bb… Patch: https://github.com/kamailio/kamailio/commit/fabd1eb423b62a5899857cf6c0974bb…

1 0

[kamailio/kamailio] ims_icscf: add missing documents for database params (PR #3874)
by H. Yavari 17 Jun '24

17 Jun '24

- Adding missing ims_icscf database parameters to admin documents. - Change the default value for ims_icscf db_url to Kamailio default db_url value.   #### Pre-Submission Checklist    - [ :white_check_mark: ] Commit message has the format required by CONTRIBUTING guide - [ :white_check_mark:] Commits are split per component (core, individual modules, libs, utils, ...) - [ :white_check_mark:] Each component has a single commit (if not, squash them into one commit) - [ :white_check_mark:] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ :white_check_mark:] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ :white_check_mark:] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Only an improvement for users to know they need to set database params for ims_icscf module. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3874 -- Commit Summary -- * ims_icscf: add missing documents for database params -- File Changes -- M src/modules/ims_icscf/doc/ims_icscf_admin.xml (100) M src/modules/ims_icscf/ims_icscf_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3874.patch https://github.com/kamailio/kamailio/pull/3874.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3874 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3874(a)github.com>

3 6

git:master:04e065af: ims_usrloc_pcscf: Update the module document
by Daniel-Constantin Mierla 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: 04e065af3d46e4b0def5ed3de6502442466f04bc URL: https://github.com/kamailio/kamailio/commit/04e065af3d46e4b0def5ed3de650244… Author: H.Yavari <hyavari(a)senasoftware.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-17T15:52:08+02:00 ims_usrloc_pcscf: Update the module document - Fixing the db_url param value from int to string in admin document. --- Modified: src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/04e065af3d46e4b0def5ed3de650244… Patch: https://github.com/kamailio/kamailio/commit/04e065af3d46e4b0def5ed3de650244…

1 0

git:master:57087e42: ims_icscf: add missing documents for database params
by Daniel-Constantin Mierla 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: 57087e42f1b1cae86132c558aa9497f4839af7e0 URL: https://github.com/kamailio/kamailio/commit/57087e42f1b1cae86132c558aa9497f… Author: H.Yavari <hyavari(a)senasoftware.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-17T15:52:08+02:00 ims_icscf: add missing documents for database params - Adding missing ims_icscf database parameters to admin documents. - Change the default value for ims_icscf db_url to Kamailio default db_url value. --- Modified: src/modules/ims_icscf/doc/ims_icscf_admin.xml Modified: src/modules/ims_icscf/ims_icscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/57087e42f1b1cae86132c558aa9497f… Patch: https://github.com/kamailio/kamailio/commit/57087e42f1b1cae86132c558aa9497f… --- diff --git a/src/modules/ims_icscf/doc/ims_icscf_admin.xml b/src/modules/ims_icscf/doc/ims_icscf_admin.xml index 9ae046e6794..e3c552a1c57 100644 --- a/src/modules/ims_icscf/doc/ims_icscf_admin.xml +++ b/src/modules/ims_icscf/doc/ims_icscf_admin.xml @@ -111,6 +111,106 @@ modparam("ims_icscf","scscf_entry_expiry", 300) </example> </section> + <section> + <title><varname>db_url</varname> (string)</title> + + <para> + &url; of the database to be used. + </para> + + <para> + If the db_url string is empty, the default database URL + will be used. + </para> + + <para> + <emphasis> + Default value is <quote>&defaultrodb;</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_url</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_url", "&exampledb;") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_nds_table</varname> (string)</title> + + <para> + NDS (Network Domain Security) table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>nds_trusted_domains</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_nds_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_nds_table", "nds_trusted_domains") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_scscf_table</varname> (string)</title> + + <para> + S-CSCF table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>s_cscf</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_scscf_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_scscf_table", "s_cscf") +... + </programlisting> + </example> + </section> + + <section> + <title> + <varname>db_capabilities_table</varname> (string)</title> + + <para> + S-CSCF capabilities table name in database to be used. + </para> + + <para> + <emphasis> + Default value is <quote>s_cscf_capabilities</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_capabilities_table</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_capabilities_table", "s_cscf_capabilities") +... + </programlisting> + </example> + </section> + <section> <title><varname>cxdx_forced_peer</varname> (string)</title> diff --git a/src/modules/ims_icscf/ims_icscf_mod.c b/src/modules/ims_icscf/ims_icscf_mod.c index 502fcf68174..a690891ee46 100644 --- a/src/modules/ims_icscf/ims_icscf_mod.c +++ b/src/modules/ims_icscf/ims_icscf_mod.c @@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL; stat_var *lir_replies_response_time = NULL; //module parameters -char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ +char *ims_icscf_db_url = DEFAULT_RODB_URL; /**< DB URL */ char *ims_icscf_db_nds_table = "nds_trusted_domains"; /**< NDS table in DB */ char *ims_icscf_db_scscf_table = "s_cscf"; /**< S-CSCF table in db */ char *ims_icscf_db_capabilities_table =

1 0

[kamailio/kamailio] tls: enable statistics (PR #3852)
by Cedric Müller 17 Jun '24

17 Jun '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This enables tls module statistics. This is needed for the xhttp_prom module to export tls module statistics. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3852 -- Commit Summary -- * tls: enable statistics * tls: code formatting -- File Changes -- M src/modules/tls/tls_mod.c (43) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3852.patch https://github.com/kamailio/kamailio/pull/3852.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3852 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3852(a)github.com>

4 7

git:master:30248b18: tls: enable statistics
by Daniel-Constantin Mierla 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: 30248b184ca169e6d348c98b0236efd230a5446e URL: https://github.com/kamailio/kamailio/commit/30248b184ca169e6d348c98b0236efd… Author: Cedric Mueller <cmueller(a)sipgate.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-17T15:48:09+02:00 tls: enable statistics --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/30248b184ca169e6d348c98b0236efd… Patch: https://github.com/kamailio/kamailio/commit/30248b184ca169e6d348c98b0236efd… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index baa1a7c76d1..5d06e7040b5 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -42,6 +42,8 @@ #include "../../core/dprint.h" #include "../../core/mod_fix.h" #include "../../core/kemi.h" +#include "../../core/counters.h" +#include "../../core/tcp_info.h" #define KSR_RTHREAD_SKIP_P #define KSR_RTHREAD_NEED_4PP @@ -56,6 +58,7 @@ #include "tls_mod.h" #include "tls_cfg.h" #include "tls_rand.h" +#include "tls_ct_wrq.h" #ifndef TLS_HOOKS #error "TLS_HOOKS must be defined, or the tls module won't work" @@ -107,6 +110,20 @@ MODULE_VERSION #define KEY_PREFIX_LEN (strlen(KEY_PREFIX)) #endif +#ifdef STATISTICS +unsigned long tls_stats_connections_no(void); +unsigned long tls_stats_max_connections(void); +unsigned long tls_stats_ct_wq_total_bytes(void); + +static stat_export_t mod_stats[] = { + {"opened_connections", STAT_IS_FUNC, + (stat_var **)tls_stats_connections_no}, + {"max_connections", STAT_IS_FUNC, + (stat_var **)tls_stats_max_connections}, + {"clear_text_write_queued_bytes", STAT_IS_FUNC, + (stat_var **)tls_stats_ct_wq_total_bytes}, + {0, 0, 0}}; +#endif extern str sr_tls_event_callback; str sr_tls_xavp_cfg = {0, 0}; @@ -360,6 +377,14 @@ static int mod_init(void) unsigned char rand_buf[32]; int k; +#ifdef STATISTICS + /* register statistics */ + if(register_module_stats("tls", mod_stats) != 0) { + LM_ERR("failed to register statistics\n"); + return -1; + } +#endif + if(tls_disable) { LM_WARN("tls support is disabled " "(set enable_tls=1 in the config to enable it)\n"); @@ -929,3 +954,24 @@ EVP_PKEY *tls_engine_private_key(const char *key_id) return pkey; } #endif + +#ifdef STATISTICS +unsigned long tls_stats_connections_no(void) +{ + struct tcp_gen_info ti; + tcp_get_info(&ti); + return ti.tls_connections_no; +} + +unsigned long tls_stats_max_connections(void) +{ + struct tcp_gen_info ti; + tcp_get_info(&ti); + return ti.tls_max_connections; +} + +unsigned long tls_stats_ct_wq_total_bytes(void) +{ + return tls_ct_wq_total_bytes(); +} +#endif

1 0

[kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3869)
by Supreeth Herle 17 Jun '24

17 Jun '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3869 -- Commit Summary -- * ims_registrar_pcscf: fix typo in comments * ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (12) M src/modules/ims_registrar_pcscf/save.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3869.patch https://github.com/kamailio/kamailio/pull/3869.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3869 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3869(a)github.com>

3 4

git:master:bf863877: ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact
by Supreeth Herle 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: bf863877f666dd8350e855bf933270b2fd8ad0fd URL: https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b… Author: herlesupreeth <herlesupreeth(a)gmail.com> Committer: Supreeth Herle <herlesupreeth(a)gmail.com> Date: 2024-06-17T13:37:12+02:00 ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b… Patch: https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 05079834252..3ce36d27952 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -900,12 +900,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) goto cleanup; } - if(ul.update_pcontact(d, &ci, pcontact) != 0) { - LM_ERR("Error updating contact\n"); - goto cleanup; - } - if(ci.via_port == SIP_PORT) { + if(req_sec_params != NULL) { + pcontact->security_temp->data.ipsec = s; + } // Update temp security parameters if(ul.update_temp_security(d, pcontact->security_temp->type, pcontact->security_temp, pcontact) @@ -914,6 +912,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) } } + if(ul.update_pcontact(d, &ci, pcontact) != 0) { + LM_ERR("Error updating contact\n"); + goto cleanup; + } if(add_supported_secagree_header(m) != 0) { goto cleanup;

1 0

git:master:d17b97a8: ims_registrar_pcscf: fix typo in comments
by Supreeth Herle 17 Jun '24

17 Jun '24

Module: kamailio Branch: master Commit: d17b97a864585782e03eedada6d226550630f7bb URL: https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d2265… Author: herlesupreeth <herlesupreeth(a)gmail.com> Committer: Supreeth Herle <herlesupreeth(a)gmail.com> Date: 2024-06-17T13:37:12+02:00 ims_registrar_pcscf: fix typo in comments --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d2265… Patch: https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d2265… --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 679abc99ca5..025cb78a5d8 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -289,7 +289,7 @@ static inline int update_contacts(struct sip_msg *req, struct sip_msg *rpl, LM_DBG("Error subscribing for contact\n"); } - // After successful registration try to unregister all callbacks for pending contacts ralated to this contact. + // After successful registration try to unregister all callbacks for pending contacts related to this contact. ul.unreg_pending_contacts_cb( _d, pcontact, PCSCF_CONTACT_EXPIRE); }

1 0

[kamailio/kamailio] Kamailio ims_charging module Ro Interface User-Equipment-Info-Type AVP (Issue #3807)
by svinson1121 17 Jun '24

17 Jun '24

The Kamailio ims_charging module Ro interface is sending: AVP: User-Equipment-Info(458) -> AVP: User-Equipment-Info-Type(459) l=12 f=-M- val=MAC (1) see attached Ro.pcapng packet #7. but (unless I'm not understanding correctly) according to TS 132 299 this AVP should be of type IMEISV and not MAC for the Ro charging interface. also, the MAC is not encoded correctly. again, see the attached pcap at packet #7 from TS 132 299: "User-Equipment-Info-Type This field determines the type of the identifier. The used value is 0 for the international mobile equipment identifier and software version according to TS 23.003[224]. User-Equipment-Info-Value This field contains the user IMEI." "For PS charging, when the User-Equipment-Info-Type AVP (AVP code 459) is set to IMEISV (0), the value within the User-Equipment-Info-Value AVP (AVP code 460) is of type OctetString and shall be a UTF-8 encoded hexadecimal. The composition of the IMEISV follows the definition in TS 23.003 [224] . If only IMEI is received a filler ‘F’ is used to make it 16 digits." "For IMS charging, when the User-Equipment-Info-Type AVP (AVP code 459) is set to IMEISV (0), the value within the User-Equipment-Info-Value AVP (AVP code 460) is of type OctetString and shall be a UTF-8 encoded decimal. The composition of the IMEISV follows the definition in TS 23.003 [224]. If only IMEI is received the number of digits are truncated to 15." I have tested and found this in the following versions: version: kamailio 5.9.0-dev0 (x86_64/linux) 4fb8ac version: kamailio 5.3.2 (x86_64/linux) 87e8a1 Thank you so much for your help with this issue, [Ro.zip](https://github.com/kamailio/kamailio/files/14924042/Ro.zip) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3807 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3807(a)github.com>

4 5

[kamailio/kamailio] 200OK (for deregistration: REGISTER with Expire:0) is not reaching to UE (Issue #3866)
by deepak-git-account 14 Jun '24

14 Jun '24

### Description During de-registration, Kamailio receives REGISTER (with expire 0), and then send Session Termination request, and only after getting Session Termination Answer, Kamailo sends 200OK. This is not sent till UE. The reason is after receiving Session Termination Request, the PCRF sends ReAuthRequest towards PCEF and it followed delete bearer procedure in IMS-PGW and bearer is getting deleted :(.  In the kamailio script, pcscf_save() is used after receiving 200OK from SCSCF. And within this function, STR is sent and STA received. ### Troubleshooting #### Reproduction  RX_SUPPORT flag shall be defined and it can be observed in De-registration procedure. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio --version version: kamailio 5.7.5 (x86_64/linux) 58499a-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 58499a -dirty compiled on 11:23:55 May 8 2024 with gcc 9.4.0 ``` * **Operating System**:  ``` uname -a Linux openims-tvmcfg-node-focal 5.4.0-181-generic #201-Ubuntu SMP Thu Mar 28 15:39:01 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3866 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3866(a)github.com>

1 1

git:master:d5135ade: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: d5135adec7297caa4dca0021dcf33ea1a1897aac URL: https://github.com/kamailio/kamailio/commit/d5135adec7297caa4dca0021dcf33ea… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-14T08:16:10+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/d5135adec7297caa4dca0021dcf33ea… Patch: https://github.com/kamailio/kamailio/commit/d5135adec7297caa4dca0021dcf33ea…

1 0

git:master:e5e0412f: siputils: docs for is_http() function
by Daniel-Constantin Mierla 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: e5e0412f61096e82fdaf61b38fe6a219312709d4 URL: https://github.com/kamailio/kamailio/commit/e5e0412f61096e82fdaf61b38fe6a21… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-14T08:08:16+02:00 siputils: docs for is_http() function --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e5e0412f61096e82fdaf61b38fe6a21… Patch: https://github.com/kamailio/kamailio/commit/e5e0412f61096e82fdaf61b38fe6a21… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index dbbba7a6db6..cf08771326c 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -1152,6 +1152,27 @@ if (is_sip()) { ... } ... +</programlisting> + </example> + </section> + <section id="siputils.f.is_http"> + <title> + <function moreinfo="none">is_http()</function> + </title> + <para> + Return true if it is a HTTP message. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>is_http</function> usage</title> + <programlisting format="linespecific"> +... +if (is_http()) { + ... +} +... </programlisting> </example> </section>

1 0

git:master:9789b423: siputils: added is_http() function
by Daniel-Constantin Mierla 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: 9789b423da91ecf0d2fad30c90f6ad717884cde7 URL: https://github.com/kamailio/kamailio/commit/9789b423da91ecf0d2fad30c90f6ad7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-14T08:08:16+02:00 siputils: added is_http() function --- Modified: src/modules/siputils/checks.c Modified: src/modules/siputils/checks.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/9789b423da91ecf0d2fad30c90f6ad7… Patch: https://github.com/kamailio/kamailio/commit/9789b423da91ecf0d2fad30c90f6ad7… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 19250567479..fa4332ec756 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -131,6 +131,36 @@ int ki_is_sip(sip_msg_t *msg) return -1; } +/** + * return 1 (true) if it is a HTTP message + */ +int w_is_http(sip_msg_t *msg, char *foo, char *bar) +{ + if(msg == NULL) + return -1; + + if(msg->first_line.flags & FLINE_FLAG_PROTO_HTTP) { + return 1; + } + + return -1; +} + +/** + * return 1 (true) if it is a HTTP message + */ +int ki_is_http(sip_msg_t *msg) +{ + if(msg == NULL) + return -1; + + if(msg->first_line.flags & FLINE_FLAG_PROTO_HTTP) { + return 1; + } + + return -1; +} + /* * Checks if From includes a To-tag -- good to identify * if a request creates a new dialog diff --git a/src/modules/siputils/checks.h b/src/modules/siputils/checks.h index 7ce632b6116..8dd0a22b81d 100644 --- a/src/modules/siputils/checks.h +++ b/src/modules/siputils/checks.h @@ -122,6 +122,11 @@ int is_reply(struct sip_msg *msg); int w_is_sip(struct sip_msg *msg, char *foo, char *bar); int ki_is_sip(struct sip_msg *msg); +/* + * Return true (1) if it is a HTTP message, otherwise false (-1) + */ +int w_is_http(sip_msg_t *msg, char *foo, char *bar); +int ki_is_http(sip_msg_t *msg); /* * Find if Request URI has a given parameter with matching value diff --git a/src/modules/siputils/siputils.c b/src/modules/siputils/siputils.c index f22f0c8f485..372da25b041 100644 --- a/src/modules/siputils/siputils.c +++ b/src/modules/siputils/siputils.c @@ -175,6 +175,7 @@ static cmd_export_t cmds[] = { {"is_request", (cmd_function)w_is_request, 0, 0, 0, ANY_ROUTE}, {"is_reply", (cmd_function)w_is_reply, 0, 0, 0, ANY_ROUTE}, {"is_sip", (cmd_function)w_is_sip, 0, 0, 0, ANY_ROUTE}, + {"is_http", (cmd_function)w_is_http, 0, 0, 0, ANY_ROUTE}, {"is_gruu", (cmd_function)w_is_gruu, 0, 0, 0, ANY_ROUTE}, {"is_gruu", (cmd_function)w_is_gruu, 1, fixup_spve_null, 0, ANY_ROUTE}, {"is_supported", (cmd_function)w_is_supported, 1, fixup_option, 0, @@ -629,6 +630,11 @@ static sr_kemi_t sr_kemi_siputils_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("siputils"), str_init("is_http"), + SR_KEMIP_INT, ki_is_http, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("siputils"), str_init("is_first_hop"), SR_KEMIP_INT, is_first_hop, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git:master:856ecb09: siputils: rename internal kemi function for is_sip()
by Daniel-Constantin Mierla 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: 856ecb09711773c6f24831a1a1d8724733541a7e URL: https://github.com/kamailio/kamailio/commit/856ecb09711773c6f24831a1a1d8724… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-14T08:08:16+02:00 siputils: rename internal kemi function for is_sip() --- Modified: src/modules/siputils/checks.c Modified: src/modules/siputils/checks.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/856ecb09711773c6f24831a1a1d8724… Patch: https://github.com/kamailio/kamailio/commit/856ecb09711773c6f24831a1a1d8724… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 7caeb809b2f..19250567479 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -119,7 +119,7 @@ int w_is_sip(sip_msg_t *msg, char *foo, char *bar) /** * return 1 (true) if it is a SIP message */ -int is_sip(sip_msg_t *msg) +int ki_is_sip(sip_msg_t *msg) { if(msg == NULL) return -1; diff --git a/src/modules/siputils/checks.h b/src/modules/siputils/checks.h index fa914ecc0da..7ce632b6116 100644 --- a/src/modules/siputils/checks.h +++ b/src/modules/siputils/checks.h @@ -120,7 +120,7 @@ int is_reply(struct sip_msg *msg); * Return true (1) if it is a SIP message, otherwise false (-1) */ int w_is_sip(struct sip_msg *msg, char *foo, char *bar); -int is_sip(struct sip_msg *msg); +int ki_is_sip(struct sip_msg *msg); /* diff --git a/src/modules/siputils/siputils.c b/src/modules/siputils/siputils.c index 0912c6b132b..f22f0c8f485 100644 --- a/src/modules/siputils/siputils.c +++ b/src/modules/siputils/siputils.c @@ -625,7 +625,7 @@ static sr_kemi_t sr_kemi_siputils_exports[] = { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { str_init("siputils"), str_init("is_sip"), - SR_KEMIP_INT, is_sip, + SR_KEMIP_INT, ki_is_sip, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } },

1 0

[kamailio/kamailio] tls: remove confusing error message when trying to print socket for <default> server (PR #3875)
by Victor Seva 14 Jun '24

14 Jun '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description On start: ``` CRITICAL: <core> [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0 NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ... ``` Now it will print: ``` NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [0.0.0.0:0], server_name='<default>' ... ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3875 -- Commit Summary -- * tls: remove confusing error message when trying to print socket for <default> server -- File Changes -- M src/modules/tls/tls_domain.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3875.patch https://github.com/kamailio/kamailio/pull/3875.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3875 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3875(a)github.com>

2 3

git:master:87c8290a: tls: remove confusing error message when trying to print socket for <default> server
by Victor Seva 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: 87c8290ab934fd27f8baebabaf66d1fb4168ba72 URL: https://github.com/kamailio/kamailio/commit/87c8290ab934fd27f8baebabaf66d1f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-14T07:44:33+02:00 tls: remove confusing error message when trying to print socket for <default> server > CRITICAL: <core> [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0 > NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ... --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/87c8290ab934fd27f8baebabaf66d1f… Patch: https://github.com/kamailio/kamailio/commit/87c8290ab934fd27f8baebabaf66d1f… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index e056a70b504..810a7e9589a 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1155,14 +1155,14 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) d->ctx[i], tls_server_name_cb)) { LM_ERR("register server_name callback handler for socket " "[%s:%d], server_name='%s' failed for proc %d\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>", i); return -1; } if(!SSL_CTX_set_tlsext_servername_arg(d->ctx[i], d)) { LM_ERR("register server_name callback handler data for socket " "[%s:%d], server_name='%s' failed for proc %d\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>", i); return -1; } @@ -1175,7 +1175,7 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) && (d->server_name.len > 0 || (d->type & TLS_DOMAIN_DEF))) { LM_NOTICE("registered server_name callback handler for socket " "[%s:%d], server_name='%s' ...\n", - ip_addr2a(&d->ip), d->port, + (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, (d->server_name.s) ? d->server_name.s : "<default>"); } #endif

1 0

[kamailio/kamailio] Siptrace: setting send_sock_name/send_sock_address is ineffective for tcp based transports (PR #3837)
by Dennis 14 Jun '24

14 Jun '24

For tcp based transports it is need to set SND_F_FORCE_SOCKET flag before msg_send_buffer call, or duplicate will send from wrong addr/port.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3837 -- Commit Summary -- * siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used -- File Changes -- M src/modules/siptrace/siptrace_send.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3837.patch https://github.com/kamailio/kamailio/pull/3837.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3837 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3837(a)github.com>

3 3

git:master:1b97a027: siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used
by Daniel-Constantin Mierla 14 Jun '24

14 Jun '24

Module: kamailio Branch: master Commit: 1b97a0271b27794263b3eff61f4acfa81e66069f URL: https://github.com/kamailio/kamailio/commit/1b97a0271b27794263b3eff61f4acfa… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-14T07:09:17+02:00 siptrace: add SND_F_FORCE_SOCKET flag if send_sock_name/send_sock_address config parameters are used - send_sock_name/send_sock_address is ineffective for tcp based transports if SND_F_FORCE_SOCKET flag is not set --- Modified: src/modules/siptrace/siptrace_send.c --- Diff: https://github.com/kamailio/kamailio/commit/1b97a0271b27794263b3eff61f4acfa… Patch: https://github.com/kamailio/kamailio/commit/1b97a0271b27794263b3eff61f4acfa… --- diff --git a/src/modules/siptrace/siptrace_send.c b/src/modules/siptrace/siptrace_send.c index d8a5f974bb3..4f9726de254 100644 --- a/src/modules/siptrace/siptrace_send.c +++ b/src/modules/siptrace/siptrace_send.c @@ -357,6 +357,8 @@ int trace_send_duplicate(char *buf, int len, dest_info_t *dst2) pdst->to.s.sa_family, pdst->proto); goto error; } + } else { + pdst->send_flags.f |= SND_F_FORCE_SOCKET; } if(msg_send_buffer(pdst, buf, len, 1) < 0) {

1 0

git:5.8:bdb3f329: pkg/kamailio/deb: refresh fix for tls_wolfssl
by Victor Seva 13 Jun '24

13 Jun '24

Module: kamailio Branch: 5.8 Commit: bdb3f32991f756b852d4bc695dc44e634e5ffc6c URL: https://github.com/kamailio/kamailio/commit/bdb3f32991f756b852d4bc695dc44e6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-13T18:21:47+02:00 pkg/kamailio/deb: refresh fix for tls_wolfssl --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/bullseye/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jammy/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/bdb3f32991f756b852d4bc695dc44e6… Patch: https://github.com/kamailio/kamailio/commit/bdb3f32991f756b852d4bc695dc44e6…

1 0

git:5.8:65873cd2: pkg/kamailio/deb: fix tls_wolfssl packaging
by Victor Seva 13 Jun '24

13 Jun '24

Module: kamailio Branch: 5.8 Commit: 65873cd2cdd390ce10ec99888fb35b0095a90c65 URL: https://github.com/kamailio/kamailio/commit/65873cd2cdd390ce10ec99888fb35b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-13T18:21:27+02:00 pkg/kamailio/deb: fix tls_wolfssl packaging * packages can't have '_' in name * distinguish grp module and deb module name '_' => '-' so tls_wolfssl => tls-wolfssl (cherry picked from commit 1d82805ef084d90e5ea14e4894f3e5076e29e2f3) --- Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules --- Diff: https://github.com/kamailio/kamailio/commit/65873cd2cdd390ce10ec99888fb35b0… Patch: https://github.com/kamailio/kamailio/commit/65873cd2cdd390ce10ec99888fb35b0… --- diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index b454421bff8..ee369ba7ccf 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -661,7 +661,7 @@ Description: TLS support for the Kamailio SIP server (authentication, transport) This package provides TLS support for encrypted and authenticated SIP connections as well as generic TLS support for many Kamailio modules. -Package: kamailio-wolftls-modules +Package: kamailio-tls-wolfssl-modules Architecture: any Multi-Arch: same Pre-Depends: diff --git a/pkg/kamailio/deb/debian/rules b/pkg/kamailio/deb/debian/rules index cbf680015ad..1cbace016b9 100755 --- a/pkg/kamailio/deb/debian/rules +++ b/pkg/kamailio/deb/debian/rules @@ -141,24 +141,27 @@ test_install_all-stamp: build $(MAKE) install quiet=verbose LIBDIR=$(LIBDIR) group_include="kstandard" touch test_install_all-stamp +# tls_wolfssl => tls-wolfssl +$(INSTALL_MODULES): module = $(subst _,-,$(subst install_,,$@)) +$(INSTALL_MODULES): grp = $(subst install_,,$@) $(INSTALL_MODULES): test_install_all-stamp $(MAKE) install-modules-all \ quiet=verbose \ LIBDIR=$(LIBDIR) \ - BASEDIR=$(D)-$(subst install_,,$@)-modules \ - cfg_prefix=$(D)-$(subst install_,,$@)-modules \ - doc-dir=share/doc/$(DEB_SOURCE)-$(subst install_,,$@)-modules \ - group_include="k$(subst install_,,$@)" + BASEDIR=$(D)-$(module)-modules \ + cfg_prefix=$(D)-$(module)-modules \ + doc-dir=share/doc/$(DEB_SOURCE)-$(module)-modules \ + group_include="k$(grp)" # Eliminate duplicate libs. for d in $(DUP_LIBS_DIRS); do \ - test "$$d" != "$(D)-$${module}-modules/usr/$(LIBDIR)/kamailio" && \ + test "$$d" != "$(D)-$(module)-modules/usr/$(LIBDIR)/kamailio" && \ for r in `find $$d -name 'lib*' | xargs`; do \ - echo "removing $(subst install_,,$@) lib `basename $$r` present also in $$d"; \ - rm -f $(D)-$(subst install_,,$@)-modules/usr/$(LIBDIR)/kamailio/`basename "$$r"`; \ + echo "removing $(module) lib `basename $$r` present also in $$d"; \ + rm -f $(D)-$(module)-modules/usr/$(LIBDIR)/kamailio/`basename "$$r"`; \ done ; \ done # clean empty dirs - find $(D)-$(subst install_,,$@)-modules -depth -empty -type d -exec rmdir {} \; + find $(D)-$(module)-modules -depth -empty -type d -exec rmdir {} \; $(INSTALL_EXTRA): test_install_all-stamp $(MAKE) install-modules-all \

1 0

git:master:71e46581: pkg/kamailio/deb: refresh fix for tls_wolfssl
by Victor Seva 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: 71e465818ba3df8a08ee46a728a1b68b5ea647e9 URL: https://github.com/kamailio/kamailio/commit/71e465818ba3df8a08ee46a728a1b68… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-13T17:05:03+02:00 pkg/kamailio/deb: refresh fix for tls_wolfssl --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/bullseye/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jammy/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/71e465818ba3df8a08ee46a728a1b68… Patch: https://github.com/kamailio/kamailio/commit/71e465818ba3df8a08ee46a728a1b68…

1 0

git:master:1d82805e: pkg/kamailio/deb: fix tls_wolfssl packaging
by Victor Seva 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: 1d82805ef084d90e5ea14e4894f3e5076e29e2f3 URL: https://github.com/kamailio/kamailio/commit/1d82805ef084d90e5ea14e4894f3e50… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-06-13T17:04:39+02:00 pkg/kamailio/deb: fix tls_wolfssl packaging * packages can't have '_' in name * distinguish grp module and deb module name '_' => '-' so tls_wolfssl => tls-wolfssl --- Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules --- Diff: https://github.com/kamailio/kamailio/commit/1d82805ef084d90e5ea14e4894f3e50… Patch: https://github.com/kamailio/kamailio/commit/1d82805ef084d90e5ea14e4894f3e50… --- diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index b454421bff8..ee369ba7ccf 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -661,7 +661,7 @@ Description: TLS support for the Kamailio SIP server (authentication, transport) This package provides TLS support for encrypted and authenticated SIP connections as well as generic TLS support for many Kamailio modules. -Package: kamailio-wolftls-modules +Package: kamailio-tls-wolfssl-modules Architecture: any Multi-Arch: same Pre-Depends: diff --git a/pkg/kamailio/deb/debian/rules b/pkg/kamailio/deb/debian/rules index cbf680015ad..1cbace016b9 100755 --- a/pkg/kamailio/deb/debian/rules +++ b/pkg/kamailio/deb/debian/rules @@ -141,24 +141,27 @@ test_install_all-stamp: build $(MAKE) install quiet=verbose LIBDIR=$(LIBDIR) group_include="kstandard" touch test_install_all-stamp +# tls_wolfssl => tls-wolfssl +$(INSTALL_MODULES): module = $(subst _,-,$(subst install_,,$@)) +$(INSTALL_MODULES): grp = $(subst install_,,$@) $(INSTALL_MODULES): test_install_all-stamp $(MAKE) install-modules-all \ quiet=verbose \ LIBDIR=$(LIBDIR) \ - BASEDIR=$(D)-$(subst install_,,$@)-modules \ - cfg_prefix=$(D)-$(subst install_,,$@)-modules \ - doc-dir=share/doc/$(DEB_SOURCE)-$(subst install_,,$@)-modules \ - group_include="k$(subst install_,,$@)" + BASEDIR=$(D)-$(module)-modules \ + cfg_prefix=$(D)-$(module)-modules \ + doc-dir=share/doc/$(DEB_SOURCE)-$(module)-modules \ + group_include="k$(grp)" # Eliminate duplicate libs. for d in $(DUP_LIBS_DIRS); do \ - test "$$d" != "$(D)-$${module}-modules/usr/$(LIBDIR)/kamailio" && \ + test "$$d" != "$(D)-$(module)-modules/usr/$(LIBDIR)/kamailio" && \ for r in `find $$d -name 'lib*' | xargs`; do \ - echo "removing $(subst install_,,$@) lib `basename $$r` present also in $$d"; \ - rm -f $(D)-$(subst install_,,$@)-modules/usr/$(LIBDIR)/kamailio/`basename "$$r"`; \ + echo "removing $(module) lib `basename $$r` present also in $$d"; \ + rm -f $(D)-$(module)-modules/usr/$(LIBDIR)/kamailio/`basename "$$r"`; \ done ; \ done # clean empty dirs - find $(D)-$(subst install_,,$@)-modules -depth -empty -type d -exec rmdir {} \; + find $(D)-$(module)-modules -depth -empty -type d -exec rmdir {} \; $(INSTALL_EXTRA): test_install_all-stamp $(MAKE) install-modules-all \

1 0

git:master:128604b6: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: 128604b6bda0c193fab4d0f2dd5bd6e2927bfdbd URL: https://github.com/kamailio/kamailio/commit/128604b6bda0c193fab4d0f2dd5bd6e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-06-13T13:31:10+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/128604b6bda0c193fab4d0f2dd5bd6e… Patch: https://github.com/kamailio/kamailio/commit/128604b6bda0c193fab4d0f2dd5bd6e… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index fbac75c662d..41f9d7bb812 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -1638,8 +1638,9 @@ onreply_route { 4.17. ds_oc_set_attrs(setid, uri, rval, tval, sval) - Sets the overload control rate and time internval limit for the - destination (setid, uri). + Sets the overload control rate, time internval limit and sequence + number for the destination record (setid, uri) following RFC7339 + specifications. Description of parameters: * setid - the set (group) id. The parameter can be an integer or a @@ -1658,7 +1659,7 @@ onreply_route { Example 1.60. ds_oc_set_attrs() usage ... - ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "1000", "1"); + ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "180000", "1"); ... 5. RPC Commands

1 0

git:master:0666d34f: dispacther: docs - remark about RFC7339 for overload control values
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: 0666d34f8816479724b4bdf4621147ccba156c66 URL: https://github.com/kamailio/kamailio/commit/0666d34f8816479724b4bdf4621147c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T13:24:04+02:00 dispacther: docs - remark about RFC7339 for overload control values --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0666d34f8816479724b4bdf4621147c… Patch: https://github.com/kamailio/kamailio/commit/0666d34f8816479724b4bdf4621147c… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 70a30ed7f7e..e50ea26f518 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -2019,8 +2019,8 @@ onreply_route { <function moreinfo="none">ds_oc_set_attrs(setid, uri, rval, tval, sval)</function> </title> <para> - Sets the overload control rate and time internval limit - for the destination (setid, uri). + Sets the overload control rate, time internval limit and sequence number + for the destination record (setid, uri) following RFC7339 specifications. </para> <para>Description of parameters:</para> <itemizedlist> @@ -2055,7 +2055,7 @@ onreply_route { <title><function>ds_oc_set_attrs()</function> usage</title> <programlisting format="linespecific"> ... - ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "1000", "1"); + ds_oc_set_attrs("1", "sip:127.0.0.1:5080", "30", "180000", "1"); ... </programlisting> </example>

1 0

git:master:b3875476: dispatcher: use milliseconds for time validity interval
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: b3875476e02bf2590e857f73367efa4cedfbd328 URL: https://github.com/kamailio/kamailio/commit/b3875476e02bf2590e857f73367efa4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T13:09:08+02:00 dispatcher: use milliseconds for time validity interval --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/b3875476e02bf2590e857f73367efa4… Patch: https://github.com/kamailio/kamailio/commit/b3875476e02bf2590e857f73367efa4… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 678352bf62d..ecd0f3a0c9d 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -473,8 +473,8 @@ int ds_oc_set_attrs( timerclear(&tdiff); /* interval set to itval or to default 500 milliseconds */ - tdiff.tv_sec = ((itval > 0) ? itval : 500000) / 1000000; - tdiff.tv_usec = ((itval > 0) ? itval : 500000) % 1000000; + tdiff.tv_sec = (((itval > 0) ? itval : 500) * 1000) / 1000000; + tdiff.tv_usec = (((itval > 0) ? itval : 500) * 1000) % 1000000; for(i = 0; i < idx->nr; i++) { if(idx->dlist[i].uri.len == duri->len

1 0

git:master:736408b3: dispatcher: keep internal oc rate as the received value
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: 736408b3e6e05cffd3978689b10549dc236ccb0d URL: https://github.com/kamailio/kamailio/commit/736408b3e6e05cffd3978689b10549d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T12:52:39+02:00 dispatcher: keep internal oc rate as the received value --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/736408b3e6e05cffd3978689b10549d… Patch: https://github.com/kamailio/kamailio/commit/736408b3e6e05cffd3978689b10549d… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index bab1a5deb31..678352bf62d 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -405,7 +405,7 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) str2int(&pit->body, &dest->attrs.ocmax); } else if(pit->name.len == 6 && strncasecmp(pit->name.s, "ocrate", 6) == 0) { - str2int(&pit->body, &dest->attrs.ocmin); + str2int(&pit->body, &dest->attrs.ocrate); } } if(dest->attrs.ocmax < 0 || dest->attrs.ocmax > 100) { @@ -435,12 +435,12 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) void ds_oc_prepare(ds_dest_t *dp) { int i; - for(i = 0; i < 100 - dp->attrs.ocrate; i++) { - dp->ocdist[i] = 1; - } - for(i = 100 - dp->attrs.ocrate; i < 100; i++) { + for(i = 0; i < dp->attrs.ocrate; i++) { dp->ocdist[i] = 0; } + for(i = dp->attrs.ocrate; i < 100; i++) { + dp->ocdist[i] = 1; + } shuffle_uint100array(dp->ocdist); } @@ -473,7 +473,8 @@ int ds_oc_set_attrs( timerclear(&tdiff); /* interval set to itval or to default 500 milliseconds */ - tdiff.tv_usec = (itval > 0) ? itval : 500000; + tdiff.tv_sec = ((itval > 0) ? itval : 500000) / 1000000; + tdiff.tv_usec = ((itval > 0) ? itval : 500000) % 1000000; for(i = 0; i < idx->nr; i++) { if(idx->dlist[i].uri.len == duri->len @@ -482,7 +483,7 @@ int ds_oc_set_attrs( LM_DBG("skipping entry %d due to seq condition\n", i); continue; } - idx->dlist[i].attrs.ocrate = 100 - irval; + idx->dlist[i].attrs.ocrate = irval; if(idx->dlist[i].attrs.ocrate < idx->dlist[i].attrs.ocmin) { idx->dlist[i].attrs.ocrate = idx->dlist[i].attrs.ocmin; } @@ -504,6 +505,7 @@ int ds_oc_set_attrs( */ static inline int ds_oc_skip(ds_set_t *dsg, int alg, int n) { + int ret; struct timeval tnow; if(alg != DS_ALG_OVERLOAD) { @@ -514,16 +516,19 @@ static inline int ds_oc_skip(ds_set_t *dsg, int alg, int n) if(timercmp(&dsg->dlist[n].octime, &tnow, <)) { /* over the time interval validity - use it */ + LM_DBG("time validity not matching\n"); return 0; } if(dsg->dlist[n].ocdist[dsg->dlist[n].ocidx] == 1) { /* use it */ - return 0; + ret = 0; + } else { + /* skip it */ + ret = 1; } dsg->dlist[n].ocidx = (dsg->dlist[n].ocidx + 1) % 100; - /* skip it */ - return 1; + return ret; } /**

1 0

git:master:c3ce318e: dispatcher: print oc details in the record group not in attrs
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: master Commit: c3ce318e01bf0eae70daa109e680a75f3ea71546 URL: https://github.com/kamailio/kamailio/commit/c3ce318e01bf0eae70daa109e680a75… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T11:51:46+02:00 dispatcher: print oc details in the record group not in attrs --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/c3ce318e01bf0eae70daa109e680a75… Patch: https://github.com/kamailio/kamailio/commit/c3ce318e01bf0eae70daa109e680a75… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 1e6beef600d..3fd941c21c4 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1869,12 +1869,16 @@ int ds_rpc_print_set( ipbuf[0] = '\0'; ip_addr2sbufz( &node->dlist[j].ip_address, ipbuf, IP_ADDR_MAX_STRZ_SIZE); - if(rpc->struct_add(vh, "Ssddjj", "HOST", &node->dlist[j].host, + if(rpc->struct_add(vh, "Ssddjjujj", "HOST", &node->dlist[j].host, "IPADDR", ipbuf, "PORT", (int)node->dlist[j].port, "PROTOID", (int)node->dlist[j].proto, "DNSTIME_SEC", (unsigned long)node->dlist[j].dnstime.tv_sec, "DNSTIME_USEC", - (unsigned long)node->dlist[j].dnstime.tv_usec) + (unsigned long)node->dlist[j].dnstime.tv_usec, "OCRATE", + node->dlist[j].attrs.ocrate, "OCTIME_SEC", + (unsigned long)node->dlist[j].octime.tv_sec, + "OCTIME_USEC", + (unsigned long)node->dlist[j].octime.tv_usec) < 0) { rpc->fault(ctx, 500, "Internal error creating dest struct"); return -1; @@ -1886,7 +1890,7 @@ int ds_rpc_print_set( rpc->fault(ctx, 500, "Internal error creating dest struct"); return -1; } - if(rpc->struct_add(wh, "SSdddSSSujj", "BODY", + if(rpc->struct_add(wh, "SSdddSSS", "BODY", &(node->dlist[j].attrs.body), "DUID", (node->dlist[j].attrs.duid.s) ? &(node->dlist[j].attrs.duid) @@ -1904,11 +1908,7 @@ int ds_rpc_print_set( "OBPROXY", (node->dlist[j].attrs.obproxy.s) ? &(node->dlist[j].attrs.obproxy) - : &data, - "OCRATE", node->dlist[j].attrs.ocrate, "OCTIME_SEC", - (unsigned long)node->dlist[j].octime.tv_sec, - "OCTIME_USEC", - (unsigned long)node->dlist[j].octime.tv_usec) + : &data) < 0) { rpc->fault(ctx, 500, "Internal error creating attrs struct"); return -1;

1 0

git:5.7:f8fa74e7: core: tcp - change log levels for failing to set source for tcp connections
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: 5.7 Commit: f8fa74e7b2901ecae8bbb851250d8b28452b18da URL: https://github.com/kamailio/kamailio/commit/f8fa74e7b2901ecae8bbb851250d8b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T10:53:36+02:00 core: tcp - change log levels for failing to set source for tcp connections - it is not possible always and it can fill the logs (cherry picked from commit 15403a543d83e337ee578ad37dc1d84316e4cf16) (cherry picked from commit 8a027b99cf8dc4f7e889aa7644f1f7699c7cb08e) --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/f8fa74e7b2901ecae8bbb851250d8b2… Patch: https://github.com/kamailio/kamailio/commit/f8fa74e7b2901ecae8bbb851250d8b2… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 955eb4b6e19..593f1a3be57 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -1284,7 +1284,7 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEADDR %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEADDR [%s]\n", strerror(errno)); /* continue, not critical */ } #endif @@ -1293,19 +1293,19 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEPORT, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEPORT %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEPORT [%s]\n", strerror(errno)); /* continue, not critical */ } #endif if(unlikely(bind(s, &si->su.s, sockaddru_len(si->su)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; } } } else { if(unlikely(bind(s, &(*from)->s, sockaddru_len(**from)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; }

1 0

git:5.8:8a027b99: core: tcp - change log levels for failing to set source for tcp connections
by Daniel-Constantin Mierla 13 Jun '24

13 Jun '24

Module: kamailio Branch: 5.8 Commit: 8a027b99cf8dc4f7e889aa7644f1f7699c7cb08e URL: https://github.com/kamailio/kamailio/commit/8a027b99cf8dc4f7e889aa7644f1f76… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-13T10:53:09+02:00 core: tcp - change log levels for failing to set source for tcp connections - it is not possible always and it can fill the logs (cherry picked from commit 15403a543d83e337ee578ad37dc1d84316e4cf16) --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/8a027b99cf8dc4f7e889aa7644f1f76… Patch: https://github.com/kamailio/kamailio/commit/8a027b99cf8dc4f7e889aa7644f1f76… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 2456459cfa2..d5a46030cf4 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -1288,7 +1288,7 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEADDR %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEADDR [%s]\n", strerror(errno)); /* continue, not critical */ } #endif @@ -1297,19 +1297,19 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEPORT, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEPORT %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEPORT [%s]\n", strerror(errno)); /* continue, not critical */ } #endif if(unlikely(bind(s, &si->su.s, sockaddru_len(si->su)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; } } } else { if(unlikely(bind(s, &(*from)->s, sockaddru_len(**from)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; }

1 0

git:master:15403a54: core: tcp - change log levels for failing to set source for tcp connections
by Daniel-Constantin Mierla 12 Jun '24

12 Jun '24

Module: kamailio Branch: master Commit: 15403a543d83e337ee578ad37dc1d84316e4cf16 URL: https://github.com/kamailio/kamailio/commit/15403a543d83e337ee578ad37dc1d84… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-12T16:21:34+02:00 core: tcp - change log levels for failing to set source for tcp connections - it is not possible always and it can fill the logs --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/15403a543d83e337ee578ad37dc1d84… Patch: https://github.com/kamailio/kamailio/commit/15403a543d83e337ee578ad37dc1d84… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 2456459cfa2..d5a46030cf4 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -1288,7 +1288,7 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEADDR %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEADDR [%s]\n", strerror(errno)); /* continue, not critical */ } #endif @@ -1297,19 +1297,19 @@ inline static int find_listening_sock_info( if(setsockopt(s, SOL_SOCKET, SO_REUSEPORT, (void *)&optval, sizeof(optval)) == -1) { - LM_ERR("setsockopt SO_REUSEPORT %s\n", strerror(errno)); + LM_NOTICE("setsockopt SO_REUSEPORT [%s]\n", strerror(errno)); /* continue, not critical */ } #endif if(unlikely(bind(s, &si->su.s, sockaddru_len(si->su)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; } } } else { if(unlikely(bind(s, &(*from)->s, sockaddru_len(**from)) != 0)) { - LM_WARN("binding to source address %s failed: %s [%d]\n", + LM_DBG("binding to source address %s failed: [%s] [%d]\n", su2a(&si->su, sizeof(si->su)), strerror(errno), errno); return -1; }

1 0

git:master:40d65759: dispatcher: internally keep the selecting instead of skipping rate
by Daniel-Constantin Mierla 12 Jun '24

12 Jun '24

Module: kamailio Branch: master Commit: 40d657592d1be9975deae6052132c458d6485fd9 URL: https://github.com/kamailio/kamailio/commit/40d657592d1be9975deae6052132c45… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-12T13:35:05+02:00 dispatcher: internally keep the selecting instead of skipping rate --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/40d657592d1be9975deae6052132c45… Patch: https://github.com/kamailio/kamailio/commit/40d657592d1be9975deae6052132c45… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 84166540a37..bab1a5deb31 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -412,7 +412,7 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) dest->attrs.ocmax = 100; } if(dest->attrs.ocmin < 0 || dest->attrs.ocmin > 100) { - dest->attrs.ocmin = 10; + dest->attrs.ocmin = 0; } if(dest->attrs.ocrate <= 0 || dest->attrs.ocrate > 100) { dest->attrs.ocrate = 0; @@ -482,7 +482,7 @@ int ds_oc_set_attrs( LM_DBG("skipping entry %d due to seq condition\n", i); continue; } - idx->dlist[i].attrs.ocrate = irval; + idx->dlist[i].attrs.ocrate = 100 - irval; if(idx->dlist[i].attrs.ocrate < idx->dlist[i].attrs.ocmin) { idx->dlist[i].attrs.ocrate = idx->dlist[i].attrs.ocmin; }

1 0

Kamailio v5.8.2 Released
by Daniel-Constantin Mierla 12 Jun '24

12 Jun '24

Hello, Kamailio SIP Server v5.8.2 stable release is out. This is a maintenance release of the latest stable branch, 5.8, that includes fixes since the release of v5.8.1. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.8.x. Deployments running previous v5.8.x versions are strongly recommended to be upgraded to v5.8.2. For more details about version 5.8.2 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/06/kamailio-v5-8-2-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

1 0

git:5.8:3fa5f48c: ChangeLog: content updated for v5.8.2
by Daniel-Constantin Mierla 12 Jun '24

12 Jun '24

Module: kamailio Branch: 5.8 Commit: 3fa5f48cd3627f1fe80acf56da1a187f3a01ddb0 URL: https://github.com/kamailio/kamailio/commit/3fa5f48cd3627f1fe80acf56da1a187… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-12T10:43:13+02:00 ChangeLog: content updated for v5.8.2 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/3fa5f48cd3627f1fe80acf56da1a187… Patch: https://github.com/kamailio/kamailio/commit/3fa5f48cd3627f1fe80acf56da1a187…

1 0

git:5.8:5a090532: Makefile.defs: version set to 5.8.2
by Daniel-Constantin Mierla 12 Jun '24

12 Jun '24

Module: kamailio Branch: 5.8 Commit: 5a090532b2e702ae758b384b54550fed5ddddfdb URL: https://github.com/kamailio/kamailio/commit/5a090532b2e702ae758b384b54550fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-06-12T10:02:55+02:00 Makefile.defs: version set to 5.8.2 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/5a090532b2e702ae758b384b54550fe… Patch: https://github.com/kamailio/kamailio/commit/5a090532b2e702ae758b384b54550fe… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 0f960b4478e..07fa021aa59 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 8 -SUBLEVEL = 1 +SUBLEVEL = 2 EXTRAVERSION = # memory manager switcher

1 0

git:master:24afb14c: carrierroute: use proper define for db_url
by Henning Westerholt 12 Jun '24

12 Jun '24

Module: kamailio Branch: master Commit: 24afb14cfaba28c4e5a7dfe9f352b02a551eed5c URL: https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-06-12T07:59:20Z carrierroute: use proper define for db_url --- Modified: src/modules/carrierroute/doc/carrierroute_db.xml --- Diff: https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02… Patch: https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02… --- diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml b/src/modules/carrierroute/doc/carrierroute_db.xml index 87017a3d259..0e9d7b3fded 100644 --- a/src/modules/carrierroute/doc/carrierroute_db.xml +++ b/src/modules/carrierroute/doc/carrierroute_db.xml @@ -29,7 +29,7 @@ ALL CHANGES DONE HERE WILL BE LOST IF THE FILE IS REGENERATED <title>Set <varname>db_url</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("carrierroute", "db_url", "dbdriver://username:password@dbhost/dbname") +modparam("carrierroute", "db_url", "&exampledb;") ... </programlisting> </example>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev