- all secfilter functions are exported to KEMI
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* All secfilter functions are exported to KEMI
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3946
-- Commit Summary --
* secfilter: export all functions to KEMI
-- File Changes --
M src/modules/secfilter/secfilter.c (103)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3946.patchhttps://github.com/kamailio/kamailio/pull/3946.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3946
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3946(a)github.com>
### Description
I am using Kemi with the app_python3 module. I was getting what appeared to be random TypeError exceptions thrown within the Kamailio app_python3 module. I later discovered that this only happened when calling a Kamailio function that exceeded the duration specified in the latency_limit_action core parameter. Also, the line printed in the logs displayed Null values in the 'file:' and 'func:' fields.
#### Reproduction
To reproduce the issue:
1. You must be using Kemi with the app_python3 module, with the cfgengine set to python.
2. Set the following in your kamailio.cfg file:
```
latency_log=2
latency_limit_action=100000
```
3. Run a Kemi function call that takes more time than the latency_limi_action set above. You may have to lower it if your computer is a fast runner. Here is my suggested code:
```
jsreload = dict()
jsreload["jsonrpc"] = "2.0"
jsreload["method"] = "tls.reload"
jsreload["id"] = 1
KSR.jsonrpcs.exec(json.dumps(jsreload))
```
4. Use python version 3.11
#### Log Messages
45(324) INFO: app_python3 [apy_kemi.c:377]: sr_apy_kemi_exec_func(): alert - action KSR.jsonrpcs.exec(...) took too long [752946 ms] (file:(null) func:(null) line:491)
45(324) ERROR: app_python3 [python_support.c:167]: python_handle_exception(): apy_exec: ksr_rtimer_dodebug(rtimer): Unhandled exception in the Python code:
TypeError: expected bytes, str found
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/etc/kamailio/kamailio.py", line 491, in ksr_rtimer_dodebug
KSR.jsonrpcs.exec(json.dumps(jsreload))
SystemError: <built-in function exec> returned a result with an exception set
### Possible Solutions
The solution is to replace PyBytes_AsString(..) calls with calls to PyUnicode_AsUTF8(..) in the PY_VERSION_HEX >= 0x030B0000 block of apy_kemi.c. The PyBytes_AsString expects a Bytes value but reeives a Unicode value instead, thus causing the TypeError exception. Enclosed is a patch file with the fix implemented:
[kamailio-5.8.2.patch.txt](https://github.com/user-attachments/files/1619573…
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
# kamailio -v
version: kamailio 5.8.2 (x86_64/linux) 3fa5f4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 3fa5f4
compiled on 09:58:55 Jul 12 2024 with gcc 12.2.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
# uname -a
Linux xxxxxxxxxxxxxxxxxxx 5.10.0-30-amd64 #1 SMP Debian 5.10.218-1 (2024-06-01) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3915
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3915(a)github.com>
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue # 3915
#### Description
<!-- Describe your changes in detail -->
Replace PyBytes_AsString(..) calls with calls to PyUnicode_AsUTF8(..) in the PY_VERSION_HEX >= 0x030B0000 block of apy_kemi.c. The PyBytes_AsString expects a Bytes value but receives a Unicode value instead, thus causing the TypeError exception.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3959
-- Commit Summary --
* app_python3: Fixes Kemi TypeError thrown when latency_limit_action is exceeded.
-- File Changes --
M src/modules/app_python3/apy_kemi.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3959.patchhttps://github.com/kamailio/kamailio/pull/3959.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3959
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3959(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Start up failed with error " waiting for child one too long"
execute start up command, and suddenly failed.
`
sudo /usr/local/sbin/kamailio -m 128 -M 8 -E -e -dd -f /usr/local/etc/kamailio/kamailio.cfg
`
### Troubleshooting
#### Reproduction
Maybe the problem of my env.
#### Debugging Data
#### Log Messages
the log:
0(2749) INFO: <core> [core/sctp_core.c:74]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module
Listening on
udp: 192.168.5.167:5061
Aliases:
udp: 192.168.5.167:5061
0(2749) INFO: <core> [core/tcp_main.c:5218]: init_tcp(): using epoll_lt as the io watch method (auto detected)
0(2751) INFO: rr [../outbound/api.h:53]: ob_load_api(): unable to import bind_ob - maybe module is not loaded
0(2751) INFO: rr [rr_mod.c:185]: mod_init(): outbound module not available
0(2751) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
0(2751) INFO: auth [auth_mod.c:342]: mod_init(): qop set, but nonce-count (nonce_count) support disabled
0(2751) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
0(2751) WARNING: tls [tls_mod.c:364]: mod_init(): tls support is disabled (set enable_tls=1 in the config to enable it)
0(2751) INFO: <core> [main.c:3233]: main(): processes (at least): 24 - shm size: 134217728 - pkg size: 8388608
0(2751) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 16777216 for fd 9
0(2751) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 16777216 on fd 9
0(2751) INFO: <core> [core/udp_server.c:264]: probe_max_send_buffer(): SO_SNDBUF is initially 16777216 for fd 9
0(2751) INFO: <core> [core/udp_server.c:334]: probe_max_send_buffer(): SO_SNDBUF is finally 16777216 on fd 9
1(2754) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
1(2754) NOTICE: ndb_redis [redis_client.c:257]: redisc_init(): Connecting to 10.20.80.33:6380
0(2751) ERROR: <core> [main.c:1825]: main_loop(): waiting for child one too long - wait time: 1000000
1(2754) INFO: <core> [main.c:888]: sig_usr(): signal 15 received
0(2751) INFO: snmpstats [snmpstats.c:399]: mod_destroy(): The SNMPStats module got the kill signal
0(2751) INFO: snmpstats [snmpstats.c:403]: mod_destroy(): Shutting down the AgentX Sub-Agent!
0(2751) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized`
what does that mean? ` 0(2751) ERROR: <core> [main.c:1825]: main_loop(): waiting for child one too long - wait time: 1000000`
How can I solve that?
#### SIP Traffic
### Possible Solutions
### Additional Information
* **Operating System**:
`
LSB Version: :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description: CentOS Linux release 7.9.2009 (Core)
Release: 7.9.2009
Codename: Core
`
Kamailio-5.8.2
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3960
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3960(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Noticed that kafka.so is not included in any existing deb packages. However, librdkafka-dev is generally available library in debian.
I've added deb package build for "kamailio-kafka-modules", for bullseye, bookworm and sid. Maybe this can be backported to at least 5.8 stable branch?!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3952
-- Commit Summary --
* kafka: build .deb package with kafka.so
-- File Changes --
M pkg/kamailio/deb/bookworm/control (17)
M pkg/kamailio/deb/bookworm/rules (1)
M pkg/kamailio/deb/bullseye/control (17)
M pkg/kamailio/deb/bullseye/rules (1)
M pkg/kamailio/deb/sid/control (17)
M pkg/kamailio/deb/sid/rules (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3952.patchhttps://github.com/kamailio/kamailio/pull/3952.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3952
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3952(a)github.com>
Module: kamailio
Branch: master
Commit: 7a390e0a297278b6d319c78f74b8179ed6a25c3b
URL: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-08-27T12:46:11+02:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
Patch: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 35c2e5d0ec0..dbeff43d002 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1631,8 +1631,12 @@ modparam("tm", "e2e_cancel_hop_by_hop", 0)
3.44. headers_mode (int)
- Control if headers from incoming CANCEL should be propagated to
- hop-by-hop generated CANCEL.
+ Control how headers from incoming CANCEL should be propagated to
+ hop-by-hop generated CANCEL. If bit (flag) 1 is set (value 1),
+ propagate the headers that are not branch specific (e.g., From, To). If
+ bit (flag) 2 is set, in case processing ends in stateless forwarding by
+ tm, forward CANCEL with a single Via header (the one added by
+ Kamailio).
Default value: 0 (do not propagate).
Module: kamailio
Branch: master
Commit: b67bb7a1bc4c710d33e242cea94a192297660c75
URL: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-08-27T12:42:13+02:00
tm: docs for header_mode flag 2
---
Modified: src/modules/tm/doc/params.xml
---
Diff: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
Patch: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
---
diff --git a/src/modules/tm/doc/params.xml b/src/modules/tm/doc/params.xml
index ffef9a4eec3..e8a16182e42 100644
--- a/src/modules/tm/doc/params.xml
+++ b/src/modules/tm/doc/params.xml
@@ -1377,8 +1377,12 @@ modparam("tm", "e2e_cancel_hop_by_hop", 0)
<section id="headers_mode">
<title><varname>headers_mode</varname> (int)</title>
<para>
- Control if headers from incoming CANCEL should be propagated to
- hop-by-hop generated CANCEL.
+ Control how headers from incoming CANCEL should be propagated to
+ hop-by-hop generated CANCEL. If bit (flag) 1 is set (value 1),
+ propagate the headers that are not branch specific (e.g., From, To).
+ If bit (flag) 2 is set, in case processing ends in stateless
+ forwarding by tm, forward CANCEL with a single Via header (the one
+ added by &kamailio;).
</para>
<para>
Default value: 0 (do not propagate).
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
We are seeing a lot of error messages like:
> ERROR: <null> pua [pua_db.c:895]: get_record_puadb(): Too many rows found (2)
After some investigation I come up with a couple of fixes:
* pua: improve the query to support caller|callee with same pres_id (same dialog)
* pua_dialoginfo: support uuid to generate pres_id to improve randomness
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3955
-- Commit Summary --
* pua: get_record_puadb() add pres_uri to the query
* pua_dialoginfo: use_uuid parameter
* pua_dialoginfo: document use_uuid parameter
-- File Changes --
M src/modules/pua/pua_db.c (18)
M src/modules/pua/pua_db.h (5)
M src/modules/pua/send_publish.c (5)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo.xml (11)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml (25)
M src/modules/pua_dialoginfo/pua_dialoginfo.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3955.patchhttps://github.com/kamailio/kamailio/pull/3955.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3955
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3955(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
This is the first step to merge the functionality that is already used in Sipwise kamailio flavor
* module parameters [from|to]_uri_avp to store
* sca_handle_subscribe() support [from|to_uri] parameters
Add the possibility of define what is the URI value for To and/or From instead of the values from the SIP message
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3930
-- Commit Summary --
* sca: add support custom [to|from]_uri
-- File Changes --
M src/modules/sca/doc/sca.xml (58)
M src/modules/sca/doc/sca_admin.xml (52)
M src/modules/sca/sca.c (115)
M src/modules/sca/sca.h (5)
M src/modules/sca/sca_call_info.c (190)
M src/modules/sca/sca_subscribe.c (96)
M src/modules/sca/sca_subscribe.h (5)
M src/modules/sca/sca_util.c (184)
M src/modules/sca/sca_util.h (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3930.patchhttps://github.com/kamailio/kamailio/pull/3930.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3930
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3930(a)github.com>
Module: kamailio
Branch: master
Commit: c9a9fcd4429de8c7da7cb3ab9cebe077edea91bf
URL: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-08-27T09:37:56+02:00
sca: add support custom [to|from]_uri
* module parameters [from|to]_uri_avp to store
* sca_handle_subscribe() support [from|to_uri] parameters
Add the possibility of define what is the URI value
for To and/or From instead of the values from the SIP message
---
Modified: src/modules/sca/doc/sca.xml
Modified: src/modules/sca/doc/sca_admin.xml
Modified: src/modules/sca/sca.c
Modified: src/modules/sca/sca.h
Modified: src/modules/sca/sca_call_info.c
Modified: src/modules/sca/sca_subscribe.c
Modified: src/modules/sca/sca_subscribe.h
Modified: src/modules/sca/sca_util.c
Modified: src/modules/sca/sca_util.h
---
Diff: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
Patch: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
fix(pua_reginfo): free pkg memory after getting the XML attribute
- free the memory from the state XML attribute that was returned and immediately used in another function call without freeing leaving one small mem leak;
- add comments but keep the dead code regarding parsed but unused attrs.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3953
-- Commit Summary --
* fix(pua_reginfo): free pkg memory after getting the content of each XML attribute
-- File Changes --
M src/modules/pua_reginfo/notify.c (86)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3953.patchhttps://github.com/kamailio/kamailio/pull/3953.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3953
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3953(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
If Deregistration contains * in a contact field as described in RFC-3261,
then the Kamailio is not cleaning the in-memory and database record. And the next iteration is not working correctly.
Use of the "*" Contact header field value allows a registering UA
to remove all bindings associated with an address-of-record
without knowing their precise values.
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
Step:1 REGISTER USER UE-A
Step:2: Wait for the certain duration
Step:3: De-REGISTER USER UE-A (Contact header is using *)
Step:4: Repeat from the step-1
After step:3, clean-up is not happening. Record can be seen in SQL.
Note: If de-register contains specific CONTACT header, then cleanup is happening.
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: DEBUG: <script>: Contact headervalue: *
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=25 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=26 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: DEBUG: <script>: Full URI from sip:49404965200004@open-ims.test: sip:49404965200004@open-ims.test
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=33 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=34 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=36 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=37 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=38 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=39 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=46 a=16 n=if
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=43 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=54 a=16 n=if
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=46 a=25 n=is_present_hf
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=47 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=50 a=25 n=append_hf
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=54 a=26 n=xlog
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=55 a=25 n=pcscf_save_pending
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: ims_registrar_pcscf [save.c:318]: save_pending(): No contact headers
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: DEBUG: ims_registrar_pcscf [save.c:492]: save_pending(): Error saving pending contact
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=67 a=16 n=if
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=65 a=63 n=assign
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[] c=[] l=0 a=12 n=seturi
May 13 19:47:22 openims-tvmcfg-node-focal pcscf/pcscf[35816]: ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[REGISTER] c=[/usr/local/etc/kamailio/pcscf/route/register.cfg] l=71 a=26 n=xlog
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio -v
version: kamailio 5.7.5 (x86_64/linux) 58499a-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 58499a -dirty
compiled on 11:23:55 May 8 2024 with gcc 9.4.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 20.04.6 LTS
Release: 20.04
Codename: focal
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3848
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3848(a)github.com>
Right now it will just ignore the additional slash and cut the string there:
henning@app01:~/repositories/kamailio/src$ killall kamailio; ./kamailio -l udp:127.0.0.1:5060//te/st -f ../etc/test.cfg -Y /tmp/ -E -L modules
Listening on
udp: 127.0.0.1:5060 name te
Aliases:
udp: localhost:5060
I think the logic could be extended easily to allow e.g. a fourth field for the listen, when we need it.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/9783c270eae580b22e73349ac72afd8…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/9783c270eae580b22e73349ac72afd864b1de592/145744930(a)github.com>
Maybe a check should be added that there is no `/` is in the last field now/socket name, so in the future `/` can be used as separator for new fields.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/9783c270eae580b22e73349ac72afd8…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/9783c270eae580b22e73349ac72afd864b1de592/145744612(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR introduces the socket name support to kamailio cli just like [listen directive](https://www.kamailio.org/wikidocs/cookbooks/devel/core/#listen) does in the config file.
You can start kamailio using the `-l` argument to define listening sockets. This PR adds the `name=` part support to match the config file.
`kamailio -l test=udp:10.0.0.55:5061/1.1.1.1:5060`
Discussion about whether `-l **test=**udp:10.0.0.55:5061/1.1.1.1:5060` or `-l udp:10.0.0.55:5061/1.1.1.1:5060**=test**` can be found in
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3954
-- Commit Summary --
* main: Add support for naming socket in cli
-- File Changes --
M src/main.c (41)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3954.patchhttps://github.com/kamailio/kamailio/pull/3954.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3954
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3954(a)github.com>
Module: kamailio
Branch: master
Commit: c622429b1514f49d36519248f90b647f7b7b3144
URL: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-08-22T13:22:56+02:00
tm: align comments
---
Modified: src/modules/tm/t_fwd.c
---
Diff: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
Patch: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
---
diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c
index b669f1d7762..c9f0bc2cab4 100644
--- a/src/modules/tm/t_fwd.c
+++ b/src/modules/tm/t_fwd.c
@@ -1348,9 +1348,9 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
for(i = 0; i < t_invite->nr_of_outgoings; i++) {
if(cancel_bm & (1 << i)) {
/* it's safe to get the reply lock since e2e_cancel is
- * called with the cancel as the "current" transaction so
- * at most t_cancel REPLY_LOCK is held in this process =>
- * no deadlock possibility */
+ * called with the cancel as the "current" transaction so
+ * at most t_cancel REPLY_LOCK is held in this process =>
+ * no deadlock possibility */
ret = cancel_branch(t_invite, i, reason,
cfg_get(tm, tm_cfg, cancel_b_flags)
| ((t_invite->uac[i].request.buffer == NULL)
@@ -1391,8 +1391,8 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
if(t_invite->uac[i].last_received >= 100) {
/* Provisional reply received on this branch, send CANCEL */
/* we do need to stop the retr. timers if the request is not
- * an invite and since the stop_rb_retr() cost is lower than
- * the invite check we do it always --andrei */
+ * an invite and since the stop_rb_retr() cost is lower than
+ * the invite check we do it always --andrei */
stop_rb_retr(&t_invite->uac[i].request);
if(SEND_BUFFER(&t_cancel->uac[i].request) == -1) {
LM_ERR("e2e cancel - send failed\n");
@@ -1409,12 +1409,12 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
&t_cancel->uac[i].request);
} else {
/* No provisional response received, stop
- * retransmission timers */
+ * retransmission timers */
if(!(cfg_get(tm, tm_cfg, cancel_b_flags)
& F_CANCEL_B_FORCE_RETR))
stop_rb_retr(&t_invite->uac[i].request);
/* no need to stop fr, it will be stopped by relay_reply
- * put_on_wait -- andrei */
+ * put_on_wait -- andrei */
/* Generate faked reply */
if(cfg_get(tm, tm_cfg, cancel_b_flags)
& F_CANCEL_B_FAKE_REPLY) {
Module: kamailio
Branch: master
Commit: 20f7aa0d0fe2f152e47321657983e7fdbaa4727d
URL: https://github.com/kamailio/kamailio/commit/20f7aa0d0fe2f152e47321657983e7f…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-08-22T11:46:55+02:00
presence_conference: add a note about deactivated MI cmds to docs [skip ci]
---
Modified: src/modules/presence_conference/doc/presence_conference_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/20f7aa0d0fe2f152e47321657983e7f…
Patch: https://github.com/kamailio/kamailio/commit/20f7aa0d0fe2f152e47321657983e7f…
---
diff --git a/src/modules/presence_conference/doc/presence_conference_admin.xml b/src/modules/presence_conference/doc/presence_conference_admin.xml
index ae6d3f5eed2..d8e9ac79b47 100644
--- a/src/modules/presence_conference/doc/presence_conference_admin.xml
+++ b/src/modules/presence_conference/doc/presence_conference_admin.xml
@@ -100,7 +100,7 @@ modparam("presence_conference", "default_expires", 3600)
<section>
<title>MI Commands</title>
-
+ The following MI commands are currently disabled, they need to migrated to the RPC infrastructure.
<section>
<title>
<function moreinfo="none">conference_reset</function>
Hi everyone,
I hope you're all doing well! I'm currently working on a project where I'm integrating Kamailio with Dovecot, and I'm looking for some advice or best practices from those who have experience with this setup.
Specifically, I'm interested in how best to configure Kamailio to work seamlessly with Dovecot for handling email traffic. Any tips on optimizing performance, potential pitfalls to avoid, or resources that could guide me through the integration would be greatly appreciated.
Also, if there are any particular modules or configurations you’ve found useful, I'd love to hear about them!
https://www.igmguru.com/blog/how-to-pass-ccsp-certification-exam
Thanks in advance for your help!
Best Regards
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3936
-- Commit Summary --
* ims_qos_npn: fixed issues in 3GPP-User-Location-Information decoding to P-Access-Network-Info header value
-- File Changes --
M src/modules/ims_qos_npn/rx_avp.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3936.patchhttps://github.com/kamailio/kamailio/pull/3936.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3936
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3936(a)github.com>
Module: kamailio
Branch: master
Commit: 3debbb5a608c135c628799546ee95c96abe18824
URL: https://github.com/kamailio/kamailio/commit/3debbb5a608c135c628799546ee95c9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-08-21T09:30:50+02:00
corex: docs for forward_uac() function
---
Modified: src/modules/corex/doc/corex_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/3debbb5a608c135c628799546ee95c9…
Patch: https://github.com/kamailio/kamailio/commit/3debbb5a608c135c628799546ee95c9…
---
diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml
index 3d6ff893808..61529f94335 100644
--- a/src/modules/corex/doc/corex_admin.xml
+++ b/src/modules/corex/doc/corex_admin.xml
@@ -977,6 +977,34 @@ event_route[dispatcher:dst-down] {
xinfo("matched local socket name\n");
}
...
+</programlisting>
+ </example>
+ </section>
+ <section id="corex.f.forward_uac">
+ <title>
+ <function moreinfo="none">forward_uac()</function>
+ </title>
+ <para>
+ Forward received request with a single Via header, the one added
+ by &kamailio;, the other ones being removed. Useful in cases when
+ its reply should not be sent back (e.g., the reply was already sent
+ out from &kamailio;).
+ </para>
+ <para>
+ This function can be used in REQUEST_ROUTE.
+ </para>
+ <example>
+ <title><function>forward_uac</function> usage</title>
+ <programlisting format="linespecific">
+...
+request_route {
+ ...
+ sl_send_reply("200", "OK");
+ $du = "sip:mirror.com:5080";
+ forward_uac();
+ ...
+}
+...
</programlisting>
</example>
</section>
Yes, I commented it in the other issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335/145517761(a)github.com>
Thanks for merging the PR. It seems that the referenced PR is wrong.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335/145516854(a)github.com>
- All `secfilter` functions are now accessible in KEMI. For example, you can use KSR.secf_check_ip() directly by importing the KSR module in Python.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* Exporting all secfilter functions to KEMI.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3940
-- Commit Summary --
* secfilter is fully KEMIized
-- File Changes --
M src/modules/secfilter/secfilter.c (99)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3940.patchhttps://github.com/kamailio/kamailio/pull/3940.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3940
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3940(a)github.com>
- Added `cdp_has_app` function:
- Accepts a single parameter: - `application`: The Application ID.
- Added `cdp_has_app2` function:
- Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID.
- Added cdp_check_peer function:
- Accepts one parameter: - `fqdn`: the Fully qualified domain name of the peer, that should be checked. The parameter may contain pseudovariables.
NOTE: All parameters are passed as standard strings.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* Exporting all cdp functions to KEMI
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3943
-- Commit Summary --
* cdp: export all functions in KEMI module
-- File Changes --
M src/modules/cdp/cdp_mod.c (34)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3943.patchhttps://github.com/kamailio/kamailio/pull/3943.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3943
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3943(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
Hello, when I was testing the SMSC SMS business, I found that the SMS could not be forwarded by the SMSC when the characters were too long, approximately 117 characters. The issue was traced back to the smsops module, which has a limit on the length of the SMS, but it seems that it does not handle SMS segmentation. The error message returned is as follows. Could you please provide some suggestions and help?
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
```
2024-04-24T05:59:01.837950514Z 3(24) ERROR: <script>: SMS for "" (Valid: 0 )
2024-04-24T05:59:14.466167796Z 2(23) ERROR: <script>: 3GPP-SMS: MESSAGE (sip:+8618107550088@ims.mnc011.mcc460.3gppnetwork.org (172.22.0.20:6060) to tel:+8613800138000, bnecb4LQJ(a)10.46.2.1)
2024-04-24T05:59:14.466173859Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length!
2024-04-24T05:59:14.466175929Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request!
2024-04-24T05:59:14.466191554Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length!
2024-04-24T05:59:14.466194545Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request!
2024-04-24T05:59:14.466196517Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length!
2024-04-24T05:59:14.466198406Z 2(23) ERROR: smsops [smsops_impl.c:1320]: pv_get_sms(): Error getting/decoding RP-Data from request!
2024-04-24T05:59:14.466200311Z 2(23) ERROR: <script>: SMS for "" (Valid: )
2024-04-24T05:59:14.466255812Z 2(23) ERROR: smsops [smsops_impl.c:1055]: decode_3gpp_sms(): Length of TP-User-Data payload exceeds maximum length!
2024-04-24T05:59:14.466276249Z 2(23) ERROR: smsops [smsops_impl.c:1903]: isRPDATA(): Error getting/decoding RP-Data from request!
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
```

### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 4fb8ac -dirty
compiled on 03:11:49 Apr 24 2024 with gcc 9.4.0
```
version: kamailio 5.9.0-dev0 (x86_64/linux) 4fb8ac-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Linux sder 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3822
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3822(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* All functions are exported to kemi
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3945
-- Commit Summary --
* secfilter is fully KEMIized
* secfilter: fix the failed format check
-- File Changes --
M src/modules/secfilter/secfilter.c (88)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3945.patchhttps://github.com/kamailio/kamailio/pull/3945.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3945
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3945(a)github.com>
- Added `cdp_has_app` function:
- Accepts a single parameter: - `application`: The Application ID.
- Added `cdp_has_app2` function:
- Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID.
- Added cdp_check_peer function:
- Accepts one parameter: - `fqdn`: the Fully qualified domain name of the peer, that should be checked. The parameter may contain pseudovariables.
NOTE: All parameters are passed as standard strings.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3942
-- Commit Summary --
* cdp: export all functions in KEMI module
-- File Changes --
M src/modules/cdp/cdp_mod.c (34)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3942.patchhttps://github.com/kamailio/kamailio/pull/3942.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3942
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3942(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* Exporting all cdp functions to KEMI
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3941
-- Commit Summary --
* secfilter: all functions are exported in KEMI
* cdp: ki_cdp_check_peer() KEMIized
* cdp: export all functions in KEMI module
-- File Changes --
M src/modules/cdp/cdp_mod.c (34)
M src/modules/secfilter/secfilter.c (88)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3941.patchhttps://github.com/kamailio/kamailio/pull/3941.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3941
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3941(a)github.com>
Necesito solventar para las instancias de synapsis estos dos vulnerabilidades que comparto a continuación.


Gracias
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3938
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3938(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
<img width="486" alt="企业微信截图_17231113172455" src="https://github.com/user-attachments/assets/2a055290-b200-4954-b902-20997760…">
change this to "rpc"
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.2 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id:
compiled on 09:04:36 Aug 8 2024 with gcc 4.8.5```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3937
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3937(a)github.com>
r2val(): converting STRING [test]
8(18) DEBUG: permissions [address.c:179]: reload_address_db_table(): Number of rows in address table: 3
8(18) DEBUG: permissions [address.c:191]: reload_address_db_table(): failure during checks of database value 1 (group) in address table
8(18) ERROR: permissions [address.c:233]: reload_address_db_table(): database problem - invalid record
mysql> desc ka_address;
+---------+-------------+------+-----+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+---------+-------------+------+-----+---------+-------+
| id | double | NO | | 0 | |
| grp | bigint | NO | | 0 | |
| ip_addr | varchar(64) | YES | | NULL | |
| mask | bigint | NO | | 0 | |
| port | bigint | NO | | 0 | |
| tag | varchar(4) | NO | | | |
+---------+-------------+------+-----+---------+-------+
when address table use bigint for grp,error happened when load address data
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3922
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3922(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3923
-- Commit Summary --
* allow address 'grd' 'mask' 'port' fields to be a mysql BIGINT
-- File Changes --
M src/modules/permissions/address.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3923.patchhttps://github.com/kamailio/kamailio/pull/3923.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3923
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3923(a)github.com>
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Adding support for converting unsigned integers from database tables into kamailio pseudo variables usable in the routing config.
This is quite useful when pulling `int unsigned` fields from a database, in modules that support "extra fields" in their module parameters.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3828
-- Commit Summary --
* permissions: fixup uint support in address table reload
* htable: add uint support when packing an htable
* lib/srdb1: add uint support for db->pv conversions
-- File Changes --
M src/lib/srdb1/db_ut.c (4)
M src/modules/htable/ht_db.c (6)
M src/modules/permissions/address.c (35)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3828.patchhttps://github.com/kamailio/kamailio/pull/3828.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3828
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3828(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Add a new forward function to the MSRP module that adds the ability to perform MSRP proxying.
The forward function allows frame replaying without multi-path. The frame can be relayed unmodified, or with a custom To/From-Path. If a replacement To-Path is provided, then the From-Path is replace either by the original To-Path or the replacement From-Path. Either the destination must be set prior or a replacement To-Path must be provided.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3934
-- Commit Summary --
* msrp: add forward support with path replacement
-- File Changes --
M src/modules/msrp/doc/msrp_admin.xml (38)
M src/modules/msrp/msrp_mod.c (72)
M src/modules/msrp/msrp_netio.c (129)
M src/modules/msrp/msrp_netio.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3934.patchhttps://github.com/kamailio/kamailio/pull/3934.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3934
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3934(a)github.com>
Module: kamailio
Branch: master
Commit: 629a518991ab204a45f625d82fbe8a0ccd247cd6
URL: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-07-31T07:46:11+02:00
modules: readme files regenerated - corex ... [skip ci]
---
Modified: src/modules/corex/README
---
Diff: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0…
Patch: https://github.com/kamailio/kamailio/commit/629a518991ab204a45f625d82fbe8a0…
---
diff --git a/src/modules/corex/README b/src/modules/corex/README
index 6a5e0663bdf..8986ee4df23 100644
--- a/src/modules/corex/README
+++ b/src/modules/corex/README
@@ -503,12 +503,14 @@ event_route[network:msg] {
4.7. msg_iflag_set(flagname)
Set internal SIP message flag. The parameter flagname can be:
- USE_UAC_FROM, USE_UAC_TO or UAC_AUTH.
+ USE_UAC_FROM, USE_UAC_TO, UAC_AUTH or a number from 0 to 64 (the
+ meaning of each value can be found in source code).
This functions should not be used in configuration file for (re)setting
the internal flags, those are done by various functions internally,
however, in very particular cases they might be useful (e.g., changing
- From/To via textops functions).
+ From/To via textops functions, or during testing of C code
+ development).
This function can be used from ANY_ROUTE.
Module: kamailio
Branch: master
Commit: 37e971f72c1783266ee29c02434361aaf2c819ed
URL: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-31T07:41:43+02:00
corex: docs updated for msg_iflag_set()
---
Modified: src/modules/corex/doc/corex_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a…
Patch: https://github.com/kamailio/kamailio/commit/37e971f72c1783266ee29c02434361a…
---
diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml
index 3cdad0aa2a5..3d6ff893808 100644
--- a/src/modules/corex/doc/corex_admin.xml
+++ b/src/modules/corex/doc/corex_admin.xml
@@ -469,13 +469,15 @@ event_route[network:msg] {
</title>
<para>
Set internal SIP message flag. The parameter flagname can be:
- USE_UAC_FROM, USE_UAC_TO or UAC_AUTH.
+ USE_UAC_FROM, USE_UAC_TO, UAC_AUTH or a number from 0 to 64
+ (the meaning of each value can be found in source code).
</para>
<para>
This functions should not be used in configuration file for
(re)setting the internal flags, those are done by various
functions internally, however, in very particular cases they
- might be useful (e.g., changing From/To via textops functions).
+ might be useful (e.g., changing From/To via textops functions,
+ or during testing of C code development).
</para>
<para>
This function can be used from ANY_ROUTE.
Hi! it seems the pua module in send_subscribe ( ) is leaking some memory because the hentity is not released.
According to memory allocations the shmem allocated for hentity is not cleaned.
```
1454582 file = 0x70e59fd30209 "usrloc: ../../core/ut.h", func = 0x70e59fd326c8 <__func__.16> "shm_str_dup", mname = 0x70e59fd2fdf0 "usrloc", line = 722
698090 file = 0x604218f2fcd5 "core: core/xavp.c", func = 0x604218f31988 <__func__.9> "xavp_new_value", mname = 0x604218f2fcd0 "core", line = 100
360187 file = 0x70e59fd30663 "usrloc: ucontact.c", func = 0x70e59fd326b8 <__func__.17> "new_ucontact", mname = 0x70e59fd2fdf0 "usrloc", line = 94
34208 file = 0x70e59fc91ae9 "pua: send_subscribe.c", func = 0x70e59fc94c80 <__func__.2> "subscribe_cbparam", mname = 0x70e59fc917e0 "pua", line = 773
5569 file = 0x70e59fc91ae9 "pua: send_subscribe.c", func = 0x70e59fc94ca0 <__func__.1> "subs_cbparam_indlg", mname = 0x70e59fc917e0 "pua", line = 861
64 file = 0x70e5a231f424 "tmx: tmx_pretran.c", func = 0x70e5a2320230 <__func__.0> "tmx_check_pretran", mname = 0x70e5a231f420 "tmx", line = 271
64 file = 0x70e5a231f424 "tmx: tmx_pretran.c", func = 0x70e5a2320230 <__func__.0> "tmx_check_pretran", mname = 0x70e5a231f420 "tmx", line = 250
7 file = 0x70e59fc86854 "pua: event_list.c", func = 0x70e59fc86ad0 <__func__.1> "add_pua_event", mname = 0x70e59fc86850 "pua", line = 72
3 file = 0x70e5a297c249 "license: ../../core/ut.h", func = 0x70e5a297d4f8 <__func__.3> "shm_str_dup", mname = 0x70e5a297c000 "license", line = 722
3 file = 0x70e59fd329d4 "usrloc: udomain.c", func = 0x70e59fd35660 <__func__.22> "build_stat_name", mname = 0x70e59fd328a0 "usrloc", line = 56
```
According to mod_stats for shmem over RPC the pua module was taking double as much memory as usrloc on the busy system.
I have tried to address the issue shown on lines 773 and 861 and added clearing of hentity at the end of send_subscribe () :
but it had caused the subscribe_200 outside of dialog to crash kamailio because of running the tm callback that accesses the hentity which is already free'd
So I thought perhaps another approach is required and the tm callback should clean it, while I must say i do not 100% clear understand why this needs to be so complicated compared to other modules. Perhaps i have missed another bug and overcomplicated things because the uac_r seems to be cleaned just fine.
The issue around the hentity does not seem to be solved in the latest releases while this is 5.3-something custom build.
Anyway my last resort that could help is convert to use tm to clear memory once it is done, in tm/uac.c : t_uac_prepare() is registering a callback with release function
```
if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags,
*(uac_r->cb), uac_r->cbp, NULL)!=1){
ret=E_OUT_OF_MEM;
LM_ERR("short of tmcb shmem\n");
goto error1;
}
int insert_tmcb(struct tmcb_head_list *cb_list, int types,
transaction_cb f, void *param,
release_tmcb_param rel_func)
{
```
is there any example of using such a relfunc in the other modules? Or anyone else has see the pua causing a mem leak when it is subscribed to reginfo from the config? I would appreciate some ideas what could be the issue and the solution.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3928
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3928(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR aims to allow multiple kamailio instances with different configs to be managed by systemd.
The new `kamailio@.service` is the systemd template file, where one can provide an instance name after `systemctl start kamailio@dev`, to start a new kamailio instance with name `kamailio-dev` and use config file found in `/etc/kamailio/kamailio-dev.cfg`.
I tested that this file and its content can work by placing the file in `/etc/systemd/system/kamailio@.service` and using the above `dev` instance name as an example. Kamailio loads and handles any new messages along with the default kamailio service.
My question right now, as I am not really familiar with the packaging workflow, is this an appropriate way to accomplish it. If yes what should be modified to install this alongside the normal `kamailio.service`.
Any feedback and review is appreciated and greatly needed!
Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3904
-- Commit Summary --
* pkg: Add systemd template for starting multiple kamailio services
-- File Changes --
A pkg/kamailio/deb/debian/kamailio@.service (26)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3904.patchhttps://github.com/kamailio/kamailio/pull/3904.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3904
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3904(a)github.com>
Dear Sirs,
I have adopted an orphaned AUR package and tried to fine tune it to be used with Your great Kamailio open source project.
I can continue to maintain it in the AUR space. If anything needs to be modified in the package please let me know.
Link to the package:
https://aur.archlinux.org/packages/kamailio
or web search !aur kamailio
Regards,
Nikos
If the traction is set to auto drop,
the memory will be freed and with it the next pointer.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The use after free caused on a Load tested system crashes.
Now the next pointer is saved before executing the callback and handle the auto drop.
Then the stored next pointer is used to continue the iteration over the callbacks.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3931
-- Commit Summary --
* cdp: fix use after free in transaction call backs
-- File Changes --
M src/modules/cdp/transaction.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3931.patchhttps://github.com/kamailio/kamailio/pull/3931.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3931
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3931(a)github.com>
Module: kamailio
Branch: master
Commit: a71bd9d9424456ef1167468c5bbbfd38b1099e89
URL: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3…
Author: Rick Barenthin <rick(a)ng-voice.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-25T12:20:59+02:00
cdp: fix use after free in transaction call backs
If the traction is set to auto drop,
the memory will be freed and with it the next pointer.
---
Modified: src/modules/cdp/transaction.c
---
Diff: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3…
Patch: https://github.com/kamailio/kamailio/commit/a71bd9d9424456ef1167468c5bbbfd3…
---
diff --git a/src/modules/cdp/transaction.c b/src/modules/cdp/transaction.c
index f1445ff15be..a2b97654dd0 100644
--- a/src/modules/cdp/transaction.c
+++ b/src/modules/cdp/transaction.c
@@ -256,10 +256,11 @@ int cdp_trans_timer(time_t now, void *ptr)
/* do all queued callbacks */
x = cb_queue->head;
while(x) {
+ n = x->next;
(x->cb)(1, *(x->ptr), 0, (now - x->expires));
if(x->auto_drop)
cdp_free_trans(x);
- x = x->next;
+ x = n;
}
pkg_free(cb_queue);
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Fixing issues discovered by Coverity
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3926
-- Commit Summary --
* ims_qos_npn: fixed issues discovered by coverity
-- File Changes --
M src/modules/ims_qos_npn/rx_aar.c (12)
M src/modules/ims_qos_npn/rx_avp.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3926.patchhttps://github.com/kamailio/kamailio/pull/3926.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3926
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3926(a)github.com>
Hi
there is an issue with the SIP parser for the t_uac_send function
https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.f.t_uac_send
If I call this function for example:
t_uac_send("INVITE", "sip:test@123.123.123.123:5060", "", "" ,"Content-Type: text/plain\r\nContact: <sip:85951b3d-096c-95d6-5f05-4f38095aca9f@172.17.64.120:5060;transport=tcp>;+u.sip!devicename.ccm.cisco.com=\"SEP5486BC7F2BBC\"", "Testbody")
Then the resulting request is broken - it's probably due to a character (exclamation mark?) in the Contact header.... I tested it with a call from kemi, but it probably also occurs when you run it with a normal kamailio -script tests
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3682
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3682(a)github.com>
### Description
I am doing some experiments with NGHTTP2 Module to make use of it in some scenarios, where Kamailio receives HTTP2 requests and has t react on them, unfortunately the module is causing Kamailio to crash upon receiving a request and need to be restarted.
Also the Docs for the module need some correction :
https://www.kamailio.org/docs/modules/5.9.x/modules/nghttp2.html
Missing required Parameters :
modparam("nghttp2", "tls_private_key", "key_in_PEM_Format")
modparam("nghttp2", "tls_public_key", "certificate_in_PEM_Format")
also $nghttp2(url) is wrong, $nghttp2(path) or $nghttp2(pathfull) is the correct ones.
its also annoying to have it only working in TLS, would it possible to make it also works without TLS ?
#### Reproduction
the fastest way it to connect to NGHTTP2 server with curl :
curl --http2-prior-knowledge -v -k https://server_ip:port/
#### Debugging Data
```
92(132) DEBUG: nghttp2 [nghttp2_server.c:717]: eventcb(): 172.22.0.1 connected
92(132) DEBUG: nghttp2 [nghttp2_server.c:507]: on_request_recv(): 172.22.0.1 GET /
92(132) DEBUG: nghttp2 [nghttp2_mod.c:522]: ksr_event_route(): executing event_route[nghttp2:request] (1)
free(): invalid pointer
102(142) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 7
102(142) DEBUG: <core> [core/tcp_main.c:3984]: handle_ser_child(): dead child 92, pid 132 (shutting down?)
102(142) DEBUG: <core> [core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x5b85ddc10ae0, 7, -1, 0x0) fd_no=130 called
0(40) ALERT: <core> [main.c:806]: handle_sigs(): child process 132 exited by a signal 6
0(40) ALERT: <core> [main.c:810]: handle_sigs(): core was generated
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
https://pastebin.com/MQe4F5sv
```
### Additional Information
* **Kamailio Version** 5.8
* **Operating System**:
Ubuntu 24.04
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3917
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3917(a)github.com>
### Description
Calling functions from the `dialplan` module in 5.8 (`dp_translate()`, `dp_match()`) results in the following line being logged:
```
WARNING: <core> [core/mem/q_malloc.c:520]: qm_free(): WARNING: free(0) called from dialplan: dp_db.c: pcre2_free(206)
```
Is this a functional problem, or just a case of overly aggressive logging?
### Troubleshooting
#### Reproduction
Reproducible with the following kamailio config:
```
#!KAMAILIO
loadmodule "pv"
loadmodule "db_sqlite"
loadmodule "xlog"
loadmodule "dialplan"
disable_tcp = true
force_rport = true
!!define DBFILE /etc/kamailio/kamailio.sqlite
modparamx("db_sqlite","db_set_readonly", "$def(DBFILE)")
modparamx("dialplan","db_url", "sqlite:///$def(DBFILE)")
modparam("dialplan", "attrs_pvar", "$avp(dp_attrs)")
request_route {
if ( $rm == "ACK" ) {
exit;
}
xinfo("$ci New request\n");
dp_match("1", "$rU");
exit;
}
```
The warning log is issued in 5.8 but not 5.7. Reproduced by sending a request with SIPp:
```
sipp -sn uac -m 1 -s 15554445555 localhost
```
### Possible Solutions
Not sure if this is just a case of logging being overly aggressive, or an issue with the module's memory management.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.1 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 12.2.0
```
Tested using docker `debian:12-slim` using the official packages from `http://deb.kamailio.org/kamailio58`
* **Operating System**:
Docker debian:12-slim, but also observed in Alpine Linux/
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3851
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3851(a)github.com>
From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075961
```
kamailio currently FTBFS on s390x, but built there before.
The same problem can be observed on ppc64:
https://buildd.debian.org/status/fetch.php?pkg=kamailio&arch=s390x&ver=5.8.…
hep.c: In function ‘hepv3_get_chunk’:
hep.c:985:41: error: implicit declaration of function ‘inet_ntop’ [-Werror=implicit-function-declaration]
985 | inet_ntop(AF_INET, &(hg->hep_src_ip4->data), ipstr,
| ^~~~~~~~~
gcc -fPIC -DPIC -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"5.8.2"' -DARCH='"s390x"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 13.3.0"' -D__CPU_s390x -D__OS_linux -DVERSIONVAL=5008002 -DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DUSE_PTHREAD_MUTEX -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -DMOD_NAME='"sipcapture"' -DMOD_NAMEID='sipcapture' -c sipcapture.c -o sipcapture.o -MMD -MP
In file included from ../../core/atomic_ops.h:180,
from ../../core/locking.h:72,
from ../../core/rpc.h:34,
from ../../core/sr_module.h:36,
from sipcapture.c:54:
...
make[4]: *** [../../Makefile.rules:100: hep.o] Error 1
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3927
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3927(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR Fixes a bug where logging shows a truncated command instead of the original one.
Original query in .cfg: `sql_query("ca", "UPDATE dialog SET timeout = timeout + 1 WHERE callid = '$ci' AND timeout > 0;`
logged error before fix:
sql_do_query(): cannot do the query [UPDATE dialog SET timeout = timeout + 1 WHERE callid = 'al@there]
logged error after fix:
sql_do_query(): cannot do the query [UPDATE dialog SET timeout = timeout + 1 WHERE callid = 'al(a)there.com AND timeout > 0;]
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3903
-- Commit Summary --
* sqlops: Don't truncated sql command when logging.
-- File Changes --
M src/modules/sqlops/sql_api.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3903.patchhttps://github.com/kamailio/kamailio/pull/3903.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3903
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3903(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Reference counter to tcp session not decremented after use $tcp(conid), so shm for session never free.
Can be releated to: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg21294.html
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3924
-- Commit Summary --
* tcpops: fix memory leak in $tcp(conid)
-- File Changes --
M src/modules/tcpops/tcpops_mod.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3924.patchhttps://github.com/kamailio/kamailio/pull/3924.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3924
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3924(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The `ims_qos` module had a few limitations. This fork of that module adds:
- AAR for the registration (signaling path monitoring)
- subsequent AARs in calls
- support for STR
- extra event_routes on Rx authorization session events
- extra AVPs decoding and use
The dependency and use of the `ims_dialog` was removed. We think that the respective module has fallen behind `dialog` (although it should've replaced it? don't know...). Cleaning/upgrading that module too might be too much effort.
Since these changes might be breaking things for other folks using IMS, we are pushing these as an alternative module. We hope that we'll find though consensus in the future and either remove or merge with the older `ims_qos` module. Same would be valid for `ims_dialog` and `dialog`, yet those also might need some upgrades.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3921
-- Commit Summary --
* ims_qos_npn: imported modified module
* src: added ims_qos_npn to Makefile.groups
-- File Changes --
M src/Makefile.groups (2)
A src/modules/ims_qos_npn/Makefile (19)
A src/modules/ims_qos_npn/README (781)
A src/modules/ims_qos_npn/cdpeventprocessor.c (382)
A src/modules/ims_qos_npn/cdpeventprocessor.h (87)
A src/modules/ims_qos_npn/doc/Makefile (4)
A src/modules/ims_qos_npn/doc/ims_qos.xml (113)
A src/modules/ims_qos_npn/doc/ims_qos_admin.xml (882)
A src/modules/ims_qos_npn/ims_qos_mod.c (2173)
A src/modules/ims_qos_npn/ims_qos_mod.h (85)
A src/modules/ims_qos_npn/ims_qos_stats.c (156)
A src/modules/ims_qos_npn/ims_qos_stats.h (38)
A src/modules/ims_qos_npn/rx_aar.c (1296)
A src/modules/ims_qos_npn/rx_aar.h (131)
A src/modules/ims_qos_npn/rx_asr.c (124)
A src/modules/ims_qos_npn/rx_asr.h (59)
A src/modules/ims_qos_npn/rx_authdata.c (494)
A src/modules/ims_qos_npn/rx_authdata.h (125)
A src/modules/ims_qos_npn/rx_avp.c (2144)
A src/modules/ims_qos_npn/rx_avp.h (118)
A src/modules/ims_qos_npn/rx_rar.c (160)
A src/modules/ims_qos_npn/rx_rar.h (34)
A src/modules/ims_qos_npn/rx_str.c (184)
A src/modules/ims_qos_npn/rx_str.h (61)
A src/modules/ims_qos_npn/sem.h (90)
A src/modules/ims_qos_npn/stats.c (79)
A src/modules/ims_qos_npn/stats.h (61)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3921.patchhttps://github.com/kamailio/kamailio/pull/3921.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3921
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3921(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3919
-- Commit Summary --
* siprepo: fix int params and wrong copy data in siprepo_msg_async_pull
-- File Changes --
M src/modules/siprepo/siprepo_data.c (6)
M src/modules/siprepo/siprepo_mod.c (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3919.patchhttps://github.com/kamailio/kamailio/pull/3919.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3919
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3919(a)github.com>
Module: kamailio
Branch: master
Commit: 8c3b5ab3818c86b90b02e20aa4631654e0b51745
URL: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-07-18T09:09:01+02:00
dispatcher: remove reference to MI in comments
---
Modified: src/modules/dispatcher/dispatch.c
---
Diff: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165…
Patch: https://github.com/kamailio/kamailio/commit/8c3b5ab3818c86b90b02e20aa463165…
---
diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c
index 287164f829d..bdb615ad3ea 100644
--- a/src/modules/dispatcher/dispatch.c
+++ b/src/modules/dispatcher/dispatch.c
@@ -3982,14 +3982,14 @@ static void ds_options_callback(
}
}
- /* Check if in the meantime someone disabled probing of the target through RPC, MI or reload */
+ /* Check if in the meantime someone disabled probing of the target
+ * through RPC or reload */
if(ds_probing_mode == DS_PROBE_ONLYFLAGGED
&& !(ds_get_state(group, &uri) & DS_PROBING_DST)) {
return;
}
/* ps->code contains the result-code of the request.
- *
* We accept both a "200 OK" or the configured reply as a valid response */
if((ps->code >= 200 && ps->code <= 299)
|| ds_ping_check_rplcode(ps->code)) {
@@ -4000,7 +4000,7 @@ static void ds_options_callback(
&& (ds_get_state(group, &uri) & DS_PROBING_DST)))
state |= DS_PROBING_DST;
- /* Check if in the meantime someone disabled the target through RPC or MI */
+ /* Check if in the meantime someone disabled the target through RPC */
if(!(ds_get_state(group, &uri) & DS_DISABLED_DST)
&& ds_update_state(fmsg, group, &uri, state, &rctx) != 0) {
LM_ERR("Setting the state failed (%.*s, group %d)\n", uri.len,
@@ -4010,7 +4010,7 @@ static void ds_options_callback(
state = DS_TRYING_DST;
if(ds_probing_mode != DS_PROBE_NONE)
state |= DS_PROBING_DST;
- /* Check if in the meantime someone disabled the target through RPC or MI */
+ /* Check if in the meantime someone disabled the target through RPC */
if(!(ds_get_state(group, &uri) & DS_DISABLED_DST)
&& ds_update_state(fmsg, group, &uri, state, &rctx) != 0) {
LM_ERR("Setting the probing state failed (%.*s, group %d)\n",
Situation: Two Kamailio nodes syncing dialog profiles via DMQ
Observation: When a dialog timeout is encountered, about half of the time, the timeout is triggered on the peer node not handling the dialog preventing the call to be correctly terminated and also leaving entries in the dialog database which never get deleted.
https://kamailio.org/docs/modules/5.7.x/modules/dialog.html#dialog.p.enable…
Makes clear, that only the node which is handling the dialog in question, can make changes not related to the dialog profiles. So when a dialog times out, it is this node which has to trigger the timeout, not any other one.
When looking at the source code, it is clear, that the 'lifetime' is transmitted via DMQ dialog message to the peer nodes, which in turn arm a timer. So it is obvious, this time will trigger, sometimes before the instance handling the dialog itself triggers that timer.
With some assistance of @oej I found a way to alter the JSON payload to extend the lifetime on the peer nodes:
```
route[DMQ_CAPTURE]
{
if(is_method("KDMQ"))
{
if(has_body("application/json") && $fU == 'dialog')
{
if (jansson_get("lifetime", $rb, "$var(lifetime)"))
{
$var(new_lifetime) = $var(lifetime) + 60; # Add 60 seconds on DMQ peer to make sure it expires AFTER main node.
$var(newrb) = $rb;
jansson_set("integer", "lifetime", $var(new_lifetime), "$var(newrb)");
set_body("$var(newrb)","application/json");
msg_apply_changes();
}
}
dmq_handle_message();
exit;
}
}
```
Testing with this config fixed the issue of the timeout firing on a peer node instead of the node handling the dialog.
Issue is present in 5.5, 5.6 and after looking at the code, I assume also on 5.7
-Benoît
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3656
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3656(a)github.com>
Module: kamailio
Branch: master
Commit: ba31a0065af34490650a205738328f52b95a784b
URL: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-07-16T10:31:11+02:00
modules: readme files regenerated - dispatcher ... [skip ci]
---
Modified: src/modules/dispatcher/README
---
Diff: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5…
Patch: https://github.com/kamailio/kamailio/commit/ba31a0065af34490650a205738328f5…
---
diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README
index 41f9d7bb812..16c10332df7 100644
--- a/src/modules/dispatcher/README
+++ b/src/modules/dispatcher/README
@@ -1883,6 +1883,7 @@ kamctl rpc dispatcher.hash 4 bob server.com
startup, useful when the hostname of the destination address
is a NAPTR or SRV record only. Such addresses cannot be
matched anymore with ds_is_from_list(...).
+ + 32 (bit at index 5 - 1 <<5) - no ping to destination
* priority: sets the priority in destination list (based on it is
done the initial ordering inside the set)
* attributes: extra fields in form of name1=value1;...;nameN=valueN.