Module: kamailio
Branch: master
Commit: 4347f1470057ba8a3c7cf8f179a814163c38d34e
URL: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-20T12:08:54+01:00
pua: remove destroy of internal structures on mod-destroy callback
- it is safer and faster to be removed at once by core or OS when application
context is destroyed
---
…
[View More]Modified: src/modules/pua/pua.c
---
Diff: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141…
Patch: https://github.com/kamailio/kamailio/commit/4347f1470057ba8a3c7cf8f179a8141…
---
diff --git a/src/modules/pua/pua.c b/src/modules/pua/pua.c
index 9b174dcdb6e..515abe0dc4c 100644
--- a/src/modules/pua/pua.c
+++ b/src/modules/pua/pua.c
@@ -296,21 +296,13 @@ static int child_init(int rank)
static void destroy(void)
{
- if(puacb_list)
- destroy_puacb_list();
-
/* if dbmode is PUA_DB_ONLY, then HashT will be NULL
* so db_update and destroy_htable won't get called */
if(pua_db && HashT)
db_update(0, 0);
- if(HashT)
- destroy_htable();
-
if(pua_db)
pua_dbf.close(pua_db);
- if(pua_evlist)
- destroy_pua_evlist();
return;
}
[View Less]
Module: kamailio
Branch: master
Commit: cc4e51c45d23b4450d082ba606445b515788ba61
URL: https://github.com/kamailio/kamailio/commit/cc4e51c45d23b4450d082ba606445b5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-19T16:20:46+01:00
rtpengine: doc - fix quote tag
---
Modified: src/modules/rtpengine/doc/rtpengine_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]cc4e51c45d23b4450d082ba606445b5…
Patch: https://github.com/kamailio/kamailio/commit/cc4e51c45d23b4450d082ba606445b5…
---
diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml
index cc4241808ea..9a57c2e551e 100644
--- a/src/modules/rtpengine/doc/rtpengine_admin.xml
+++ b/src/modules/rtpengine/doc/rtpengine_admin.xml
@@ -915,7 +915,7 @@ modparam("rtpengine", "mos_min_roundtrip_pv", "$avp(mos_min_roundtrip)")
There is no default value.
</para>
<para>
- This value is filled in after invoking< quote>rtpengine_delete</quote>,
+ This value is filled in after invoking <quote>rtpengine_delete</quote>,
<quote>rtpengine_query</quote>, or <quote>rtpengine_manage</quote> if the
command resulted in a deletion of the call (or call branch).
</para>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR fixes a bug in pseudo-variables related to "From" and "To" headers and changing the `Display Name` through `$tu/$fu/$fn/$tn`.
According to standard the URI must be enclosed in <> if a `Display Name` is given, but it may or may NOT if no display name is present.
So, if one tries to modify the `from`/`to` header with an initial empty display name and URI that is NOT enclosed in <>, it yields an invalid message.
This PR makes sure that if URI was not enclosed in <> and display name is modified, that will wrap URI in <>.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3935
-- Commit Summary --
* pv: Ensure URI enclosed in <> when changing Display Name
-- File Changes --
M src/modules/pv/pv_core.c (62)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3935.patchhttps://github.com/kamailio/kamailio/pull/3935.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3935
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3935(a)github.com>
[View Less]
A response to the amqp query caused a segfault in libc
- Refactored parts of the code to be more readable and DRY
- Split up functions for 3/4/5 arguments passed
- Tested in 8.5.2
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must …
[View More]be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
The current state of the module was not usable anymore as everything up from 5.5.x caused a segfault when the kazoo_query method was executed. Refactored the module a bit to make sure it is works again 5.8.x
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4002
-- Commit Summary --
* Fixed segfault when using kazoo_query in kazoo mod
-- File Changes --
M src/modules/kazoo/kazoo.c (10)
M src/modules/kazoo/kz_amqp.c (67)
M src/modules/kazoo/kz_amqp.h (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4002.patchhttps://github.com/kamailio/kamailio/pull/4002.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4002
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4002(a)github.com>
[View Less]
The former respects the `--atexit=no` from Kamailio command line.
See note on `atexit` in TLS module "Overview".
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must …
[View More]be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
I'm using `tls` module along with some other modules. On Kamailio termination there are a lot of "freeing already freed pointer" messages from `qm_free()`. Also there may be a corrupted memory report (followed by `abort()`) from `qm_debug_check_frag()`.
I'm aware of `--atexit=no` required for `tls`, and Kamailio is indeed started as `kamailio --atexit=no -m 16 -n 1 -w . -f some.cfg`.
The `tls` module is loaded and configured something like this:
```
disable_core_dump=no
debug=2
memdbg=2
# mem_safety=0
enable_tls=yes
listen=tls:127.0.0.1:5060
mpath="lib64/kamailio/modules"
loadmodule "tls.so"
modparam("tls", "init_mode", 1)
modparam("tls", "config", "tls.cfg");
loadmodule "snmpstats.so"
modparam("snmpstats", "sipEntityType", "proxyServer")
modparam("snmpstats", "snmpgetPath", "/usr/bin/")
modparam("snmpstats", "snmpCommunity", "MySNMPComunity")
modparam("snmpstats", "snmpVersion", "2c")
loadmodule "xlog.so"
route {
xlog("L_NOTICE", "Hello\n");
}
```
Running Kamailio and then stopping it with `SIGTERM` yields the following.
Some blocks of shared memory are allocated by the main process (PID 62575). E.g., one of the blocks:
```
0(62575) INFO: <core> [core/mem/q_malloc.c:429]: qm_malloc(): qm_malloc(0x7facc5dc0000, 8) returns address 0x7facc5e55810 frag. 0x7facc5e557d8 (size=8) on 1 -th hit
```
On termination, this address is freed by another process (PID 62583). Somewhere after "sig_usr(): signal 15 received" message there's the following entry in the log:
```
5(62583) INFO: <core> [core/mem/q_malloc.c:495]: qm_free(): qm_free(0x7facc5dc0000, 0x7facc5e55810), called from tls: tls_init.c: ser_free(400)
```
Then later the same address is freed again, by the main process (PID 62575). That's due to explicit call to `OPENSSL_cleanup()` from `tls_h_mod_destroy_f()` in `tls` module:
```
0(62575) INFO: tls [tls_init.c:1063]: tls_h_mod_destroy_f(): executing openssl v1.1+ cleanup
0(62575) INFO: <core> [core/mem/q_malloc.c:495]: qm_free(): qm_free(0x7facc5dc0000, 0x7facc5e55810), called from tls: tls_init.c: ser_free(400)
0(62575) CRITICAL: <core> [core/mem/q_malloc.c:535]: qm_free(): BUG: freeing already freed pointer (0x7facc5e55810), called from tls: tls_init.c: ser_free(400), first free tls: tls_init.c: ser_free(400) - ignoring
```
It depends on initial conditions (which modules are loaded, what is the configuration, etc.), but sometimes `qm_debug_check_frag()` detects memory corruption and calls `abort()`:
```
0(62575) CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7facc5e891e0 (address 0x7facc5e89218) beginning overwritten (7facc5e85498)! Memory allocator was called from tls: tls_init.c:400. Fragment marked by :140376711102467. Exec from core/mem/q_malloc.c:526.
```
The output of `kamcmd core.ps` suggests that the offending process (PID 62583) is related to SNMP:
```
62575
main process - attendant
…
62583
SNMP AgentX
```
The "SNMP AgentX" process in `snmpstats` overrides some signal handlers (including the `SIGTERM` one) and calls `exit()`:
```
/*! Creates a child that will become the AgentX sub-agent. The child will
* insulate itself from the rest of Kamailio by overriding most of signal
* handlers. */
void agentx_child(int rank)
{
…
/* Setup a SIGTERM handler */
sigfillset(&new_sigterm_handler.sa_mask);
new_sigterm_handler.sa_flags = 0;
new_sigterm_handler.sa_handler = sigterm_handler;
sigaction(SIGTERM, &new_sigterm_handler, NULL);
…
}
```
```
static void sigterm_handler(int signal)
{
/* Just exit. The master agent will clean everything up for us */
exit(0);
}
```
Looks like this `exit()` triggers an extra call to `OPENSSL_cleanup`, implicitly armed by OpenSSL itself on startup. So, the OpenSSL cleanup gets called twice.
As for now I've fixed the issue by replacing this `exit(0)` with `ksr_exit(0)` which respects the `--atexit=no` command line option. But I wonder is it a right way to do it.
As far as I can see, code in `src/modules/` ignores `ksr_exit()` and uses plain `exit()`. Is it for a reason? Shouldn't modules also exit with `ksr_exit`?
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3993
-- Commit Summary --
* modules/snmpstats: exit with ksr_exit() instead of standard exit()
-- File Changes --
M src/modules/snmpstats/snmpstats.c (5)
M src/modules/snmpstats/sub_agent.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3993.patchhttps://github.com/kamailio/kamailio/pull/3993.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3993
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3993(a)github.com>
[View Less]
- explicit mention of label= flag
- add explanations regarding mos_A/B_label_pv parameters
- typo fixes
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git …
[View More]cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3998
-- Commit Summary --
* rtpengine: update doc
-- File Changes --
M src/modules/rtpengine/doc/rtpengine_admin.xml (48)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3998.patchhttps://github.com/kamailio/kamailio/pull/3998.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3998
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3998(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [x] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4014
-- Commit Summary --
* core: add other 4xx reply error count stats
-- File Changes --
M src/modules/kex/core_stats.c (115)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4014.patchhttps://github.com/kamailio/kamailio/pull/4014.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4014
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4014(a)github.com>
[View Less]
- Modify parsing of a database URL so that a '/' character is accepted as a valid character in the password part of the URL.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable …
[View More]branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This change modifies the parsing of the DB URL so that '/' characters can be included in the password field. The modified algorithm is similar to that used when a '@' character is contained in the password.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4017
-- Commit Summary --
* lib/srdb1: Allow '/' in database URL passwords
-- File Changes --
M src/lib/srdb1/db_id.c (35)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4017.patchhttps://github.com/kamailio/kamailio/pull/4017.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4017
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4017(a)github.com>
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature …
[View More](non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [-] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
- icid-value is only 17 characters and not unique
- Re-parsing of generated PCV with icid-generated is 2 characters too short, cutting generated-by value or creating false warning
Following warning was produced, which shows the problem.
> WARNING: siputils [chargingvector.c:240]: sip_parse_charging_vector(): icid-generated-at is missing icid-> value=4557000A000E52000;icid-generated-a
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4026
-- Commit Summary --
* siputils: generated icid-value too short
-- File Changes --
M src/modules/siputils/chargingvector.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4026.patchhttps://github.com/kamailio/kamailio/pull/4026.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4026
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4026(a)github.com>
[View Less]
It's needed specifically when setting WAL, because on module loading, each child creates its own DB connection and sets the WAL (or other options you might set), and it all happens roughly at the same time.
Without setting the busy-timeout, starting of kamailio will fail due to locking issues with sqlite.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.…
[View More]github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4029
-- Commit Summary --
* db_sqlite: Add busy timeout param to improve concurrency
-- File Changes --
M src/modules/db_sqlite/db_sqlite.c (52)
M src/modules/db_sqlite/db_sqlite.h (1)
M src/modules/db_sqlite/dbase.c (16)
M src/modules/db_sqlite/doc/db_sqlite.xml (16)
M src/modules/db_sqlite/doc/db_sqlite_admin.xml (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4029.patchhttps://github.com/kamailio/kamailio/pull/4029.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4029
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4029(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 9d21fa0562b8b4379b882d89715c58028eb358dd
URL: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580…
Author: Andreas Granig <agranig(a)linguin.org>
Committer: Andreas Granig <agranig(a)linguin.org>
Date: 2024-11-19T14:18:09+01:00
db_sqlite: Add busy timeout param to improve concurrency
It's needed specifically when setting WAL, because on module loading,
each child creates its own DB connection and sets the WAL (or …
[View More]other
options you might set), and it all happens roughly at the same time.
Without setting the busy-timeout, starting of kamailio will fail
due to locking issues with sqlite.
---
Modified: src/modules/db_sqlite/db_sqlite.c
Modified: src/modules/db_sqlite/db_sqlite.h
Modified: src/modules/db_sqlite/dbase.c
Modified: src/modules/db_sqlite/doc/db_sqlite.xml
Modified: src/modules/db_sqlite/doc/db_sqlite_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580…
Patch: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580…
[View Less]
It's needed specifically when setting WAL, because on module loading, each child creates its own DB connection and sets the WAL (or other options you might set), and it all happens roughly at the same time. Without setting the busy-timeout, starting of kamailio will fail due to locking issues with sqlite.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.…
[View More]github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4028
-- Commit Summary --
* db_sqlite: Add busy timeout param to improve concurrency.
-- File Changes --
M src/modules/db_sqlite/db_sqlite.c (52)
M src/modules/db_sqlite/db_sqlite.h (1)
M src/modules/db_sqlite/dbase.c (13)
M src/modules/db_sqlite/doc/db_sqlite_admin.xml (48)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4028.patchhttps://github.com/kamailio/kamailio/pull/4028.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4028
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4028(a)github.com>
[View Less]
Hello all
we are seeing these kind of logs in a Debian GNU/Linux 11 using kamailio 5.5.6
```Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155702]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[164.152.22.248:5060](http://164.152.22.248:5060/))
Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155698]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.…
[View More]184:5060](http://208.74.138.184:5060/))
Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155695]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.181:5060](http://208.74.138.181:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155693]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[38.102.250.60:5060](http://38.102.250.60:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[87.1.1.27:5060](http://87.1.1.27:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [ut.h:302]: uri2dst2(): no corresponding socket for "87.1.1.27" af 2
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [t_fwd.c:470]: prepare_new_uac(): can't fwd to af 2, proto 1 (no corresponding listening socket)
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155697]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.184:5060](http://208.74.138.184:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155694]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[192.40.216.97:5060](http://192.40.216.97:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155694]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.180:5060](http://208.74.138.180:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155714]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[87.1.1.27:5060](http://87.1.1.27:5060/))
```
The kamailio instance we are using is receiving around 1500 calls per second in average when we do start seeing these errors more frequently
In this instance we are using multihomed
the listen address list is
``` children=14
socket_workers=1
listen=udp:[192.168.99.70:5081](http://192.168.99.70:5081/)
listen=udp:[192.168.99.81:5060](http://192.168.99.81:5060/)
listen=udp:[87.1.1.27:5060](http://87.1.1.27:5060/)
listen=tcp:[192.168.96.105:8095](http://192.168.96.105:8095/)
listen=tcp:[87.1.1.27:5060](http://87.1.1.27:5060/)
tcp_children=6
port=5060
```
We use the first worker only to perform the OPTIONS requests from the dispatcher module.
The sockets
listen=udp:[192.168.99.81:5060](http://192.168.99.81:5060/)
listen=udp:[87.1.1.27:5060](http://87.1.1.27:5060/)
are used to communicate both A and B legs
so when a message is received at [192.168.99.81:5060](http://192.168.99.81:5060/) we send it to [87.1.1.27:5060](http://87.1.1.27:5060/) and viceversa
We were using $fs variable before doing the t_relay() function.
This way is working, but when load increases, seems sometimes kamailio doesn't get the proper socket to forward the reply.
I think the errors mainly are related to responses which are being forwarded, like if the function get_sock_info_list was not able to retrieve the listen interfaces
we have tried to set in the onreply routes the commands
set_recv_socket("udp:[192.168.99.81:5060](http://192.168.99.81:5060/)");
set_send_socket("udp:[87.1.1.27:5060](http://87.1.1.27:5060/)"); (when reply goes from private to public domain)
and it seems it reduces the number of
```
Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155702]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[164.152.22.248:5060](http://164.152.22.248:5060/))
Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155698]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.184:5060](http://208.74.138.184:5060/))
Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155695]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.181:5060](http://208.74.138.181:5060/))
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155693]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[38.102.250.60:5060](http://38.102.250.60:5060/))
errors
```
But i honestly don't know why the
```Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [ut.h:302]: uri2dst2(): no corresponding socket for "87.1.1.27" af 2
Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [t_fwd.c:470]: prepare_new_uac(): can't fwd to af 2, proto 1 (no corresponding listening socket)
appear
```
We also tried to increase the kernel buffers rmem and wmem from 208KB (as we had by default) to 4MB
Do you know a reason which could cause these logs to appear?
Any setup that could mitigate them?
thanks a lot and regards
david escartin
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3583
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3583(a)github.com>
[View Less]
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
I used `jwt_verify()` function and expected to automatically handle the expiration check. But it doesn't.
### Troubleshooting
#### Reproduction
Have the following Kamailio config:
```
loadmodule "jwt.so"
...
modparam("jwt", "key_mode", 0)
....
$var(authorization_header_value) = "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxNDQ0ODEiLCJuYW1lIjoiSm9obiBEb2UiLCJpYXQiOjExMTYyMzkwMjJ9.…
[View More]Ce0o-10D-ghrfQ8jAZTFgJxw6pufLa6gtoCsylI9cPQo2MANVKV1sjwwKtbLfPzSobz1VhOVZ3RtbFME1GKwEOQq0MuNh7EsmMypjAyBbSPj3he0H4ysa3Lt2i8nJ2Z02j_PU387EEwziC4ilkbXNLXdx43ji_SP--dF3rij2C1Wv8AWbNloPnIAIgtTMdXRuxQPPGFhpBLfUPa54dgrRjLRSGzUJKNbszVljhpzqLM6rJ7hsf2MiB3Ww0goRH7r_9-rm4s9eYMK1xaCPlxBUIxw9bVbNkpiFypq_IcdhXnfyTsF4FUuXSgoUqGD6dOCOh6umsDfl7rrBTMRDdqT1CcBj-_CIWSwmxreVxYz1ET5cZe0oj1GnZRYFXrJzUFd1y9srV6qKY-QK1hlflONd_YZ23hpT1hXOVF0fsgB5JQBjDYBi2kLKms5zi-EAmoIVr1JVJS5-tE_iS3p40YGblI0oOOfxeKCtskgl9KtsRvUWi_25pU5BOEX8KiXVkJ2MH9KFYv2-HXrBVkZyY4kCsHIedz8k_nMfOICrh932pC2bgkQLJEZLSwtO8nTK5G1OrS_VLYwqJv0oGtnmcupexTGYiDjN6t1nqnH6s6409z16M-pKG2wwrt-40sFJh-5eDrpqs8KreSDdOYZsoB5POn7ipqZ0OfbVUCT4TzYYPA";
$var(jwt_verification) = jwt_verify("/etc/kamailio/oauth_pub.pem", "RS256",
"sub='$fU'",
"$var(authorization_header_value)"
);
xlog("JWT verification Status: $var(jwt_verification)");
#Outputs 1
...
```
If you decode the JWT you'll see that the timestamp in the `iat` header is in the past.
#### Debugging Data
#### Log Messages
```
{1 90377072 REGISTER 1d0833c1-0d75-123e-8abe-560004469ea4} <script>: JWT verification Status: 1
```
### Possible Solutions
Compare the timestamp from the token's `iat` claim with the current timestamp and fail the verification if it's in the past.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.2 (x86_64/linux) 3fa5f4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 3fa5f4
compiled on 10:39:56 Jun 12 2024 with gcc 8.5.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Rocky Linux 8.10 (Green Obsidian)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4007
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4007(a)github.com>
[View Less]
Module: kamailio
Branch: 5.7
Commit: 4ddd8de2d6c6a02a5c156d0505feb9164a7d5a3e
URL: https://github.com/kamailio/kamailio/commit/4ddd8de2d6c6a02a5c156d0505feb91…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-15T11:19:59+01:00
doc: update manpage with missing -B option [skip ci]
(cherry picked from commit 77f03aabd871dbf86c5106a93eb32ce67d7762bf)
(cherry picked from commit …
[View More]6816f992696fe894b3a47cd511a59e1b5a0ed89b)
---
Modified: doc/man/kamailio.8
---
Diff: https://github.com/kamailio/kamailio/commit/4ddd8de2d6c6a02a5c156d0505feb91…
Patch: https://github.com/kamailio/kamailio/commit/4ddd8de2d6c6a02a5c156d0505feb91…
---
diff --git a/doc/man/kamailio.8 b/doc/man/kamailio.8
index f4fc69ade7e..05460afbddc 100644
--- a/doc/man/kamailio.8
+++ b/doc/man/kamailio.8
@@ -8,7 +8,7 @@ kamailio \- a very fast and configurable SIP server
.SH SYNOPSIS
.B kamailio
[
-.B \-hfcmMdVIhEeblLnvKrRDTNWwtugPGSQOaAxXY
+.B \-hfcmMdVIhEebBlLnvKrRDTNWwtugPGSQOaAxXY
] [
.BI \-a " auto\-aliases\-mode"
] [
@@ -16,6 +16,8 @@ kamailio \- a very fast and configurable SIP server
] [
.BI \-b " max_rcv_buf_size"
] [
+.BI \-B " max_snd_buf_size"
+] [
.BI \-f " config\-file"
] [
.BI \-g " gid"
@@ -68,7 +70,10 @@ default is yes.
Add config pre-processor define (e.g., -A WITH_AUTH, -A N=1, -A X='"Y"')
.TP
.BI \-b " max_rcv_buf_size"
-Maximum receive buffer size which will not be exceeded by the auto-probing procedure even if the OS allows.
+Maximum OS UDP receive buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
+.TP
+.BI \-B " max_snd_buf_size"
+Maximum OS UDP send buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
.TP
.BI \-c
Checks the config file and displays the aliases and listen interface list.
[View Less]
Module: kamailio
Branch: 5.8
Commit: 6816f992696fe894b3a47cd511a59e1b5a0ed89b
URL: https://github.com/kamailio/kamailio/commit/6816f992696fe894b3a47cd511a59e1…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-15T11:18:46+01:00
doc: update manpage with missing -B option [skip ci]
(cherry picked from commit 77f03aabd871dbf86c5106a93eb32ce67d7762bf)
---
Modified: doc/man/kamailio.8
---
Diff: …
[View More]https://github.com/kamailio/kamailio/commit/6816f992696fe894b3a47cd511a59e1…
Patch: https://github.com/kamailio/kamailio/commit/6816f992696fe894b3a47cd511a59e1…
---
diff --git a/doc/man/kamailio.8 b/doc/man/kamailio.8
index f4fc69ade7e..05460afbddc 100644
--- a/doc/man/kamailio.8
+++ b/doc/man/kamailio.8
@@ -8,7 +8,7 @@ kamailio \- a very fast and configurable SIP server
.SH SYNOPSIS
.B kamailio
[
-.B \-hfcmMdVIhEeblLnvKrRDTNWwtugPGSQOaAxXY
+.B \-hfcmMdVIhEebBlLnvKrRDTNWwtugPGSQOaAxXY
] [
.BI \-a " auto\-aliases\-mode"
] [
@@ -16,6 +16,8 @@ kamailio \- a very fast and configurable SIP server
] [
.BI \-b " max_rcv_buf_size"
] [
+.BI \-B " max_snd_buf_size"
+] [
.BI \-f " config\-file"
] [
.BI \-g " gid"
@@ -68,7 +70,10 @@ default is yes.
Add config pre-processor define (e.g., -A WITH_AUTH, -A N=1, -A X='"Y"')
.TP
.BI \-b " max_rcv_buf_size"
-Maximum receive buffer size which will not be exceeded by the auto-probing procedure even if the OS allows.
+Maximum OS UDP receive buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
+.TP
+.BI \-B " max_snd_buf_size"
+Maximum OS UDP send buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
.TP
.BI \-c
Checks the config file and displays the aliases and listen interface list.
[View Less]
Module: kamailio
Branch: master
Commit: 77f03aabd871dbf86c5106a93eb32ce67d7762bf
URL: https://github.com/kamailio/kamailio/commit/77f03aabd871dbf86c5106a93eb32ce…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-15T11:10:59+01:00
doc: update manpage with missing -B option [skip ci]
* update -l description
---
Modified: doc/man/kamailio.8
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]77f03aabd871dbf86c5106a93eb32ce…
Patch: https://github.com/kamailio/kamailio/commit/77f03aabd871dbf86c5106a93eb32ce…
---
diff --git a/doc/man/kamailio.8 b/doc/man/kamailio.8
index f4fc69ade7e..9579c806020 100644
--- a/doc/man/kamailio.8
+++ b/doc/man/kamailio.8
@@ -8,7 +8,7 @@ kamailio \- a very fast and configurable SIP server
.SH SYNOPSIS
.B kamailio
[
-.B \-hfcmMdVIhEeblLnvKrRDTNWwtugPGSQOaAxXY
+.B \-hfcmMdVIhEebBlLnvKrRDTNWwtugPGSQOaAxXY
] [
.BI \-a " auto\-aliases\-mode"
] [
@@ -16,6 +16,8 @@ kamailio \- a very fast and configurable SIP server
] [
.BI \-b " max_rcv_buf_size"
] [
+.BI \-B " max_snd_buf_size"
+] [
.BI \-f " config\-file"
] [
.BI \-g " gid"
@@ -68,7 +70,10 @@ default is yes.
Add config pre-processor define (e.g., -A WITH_AUTH, -A N=1, -A X='"Y"')
.TP
.BI \-b " max_rcv_buf_size"
-Maximum receive buffer size which will not be exceeded by the auto-probing procedure even if the OS allows.
+Maximum OS UDP receive buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
+.TP
+.BI \-B " max_snd_buf_size"
+Maximum OS UDP send buffer size which will not be exceeded by auto-probing-and-increase procedure even if OS allows.
.TP
.BI \-c
Checks the config file and displays the aliases and listen interface list.
@@ -132,10 +137,18 @@ Turns on via host checking when forwarding replies.
Listens on the specified address/interface. Multiple
.B \-l
mean listening on multiple addresses. The address format is
-[proto:]address[:port], where proto = udp|tcp and
-address = host|ip_address|interface_name. Example: -l localhost,
--l udp:127.0.0.1:5080, -l eth0:5062.
-The default behaviour is to listen on all the ipv4 interfaces.
+[proto:]addr_lst[:port][/advaddr][/socket_name],
+where proto=udp|tcp|tls|sctp,
+addr_list = addr|(addr, addrress),
+addr=host|ip_address|interface_name,
+advaddr=addr[:port] (advertised address) and
+socket_name=identifying name.
+E.g: -l localhost, -l udp:127.0.0.1:5080, -l eth0:5062,
+-l udp:127.0.0.1:5080/1.2.3.4:5060,
+-l udp:127.0.0.1:5080//local,
+-l udp:127.0.0.1:5080/1.2.3.4:5060/local,
+-l \"sctp:(eth0)\", -l \"(eth0, eth1, 127.0.0.1):5065\".
+The default behaviour is to listen on all the interfaces.
.TP
.BI \-\-loadmodule\fR=\fIname
load the module specified by name
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3831
#### Description
<!-- Describe your changes in detail -->
This PR fixes the error introduced in #3962, about not being able to access the generated CANCEL message.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3979
-- Commit Summary --
* tm: move local-request event route to the right location to access CANCEL
-- File Changes --
M src/modules/tm/t_cancel.c (93)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3979.patchhttps://github.com/kamailio/kamailio/pull/3979.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3979
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3979(a)github.com>
[View Less]
Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4016f60f63/149088755(a)github.com>
I force push master to remove it
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4016f60f63/149088713(a)github.com>
Hmm this was intended for my personal repo and testing... Can we revert it somehow?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4016f60f63/149087912(a)github.com>
Hello,
Kamailio SIP Server v5.8.4 stable release is out.
This is a maintenance release of the latest stable branch, 5.8, that
includes fixes since the release of v5.8.3. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.8.x. Deployments running previous v5.8.x
versions are strongly recommended to be upgraded to v5.8.4.
For more details about version 5.8.4 (including links and guidelines to
download the tarball or …
[View More]from GIT repository), visit:
* https://www.kamailio.org/w/2024/11/kamailio-v5-8-4-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]
Hello,
I am considering to release Kamailio v5.8.4 (out of branch 5.8) sometime
next week, most likely on Tuesday, Nov 12, 2024. If anyone is aware of
issues not yet on the bug tracker, report them there asap in order to
have a better chance to be fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Reported #4012 #3920
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4013
-- Commit Summary --
* tls_wolfssl: Initialize cipher_list for domain #3920
* clang format
-- File Changes --
M src/modules/tls_wolfssl/tls_domain.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4013.patchhttps://github.com/kamailio/kamailio/pull/4013.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4013
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4013(a)github.com>
[View Less]
- URL: https://github.com/kamailio/kamailio/commit/d5f13655909632a4f6e58ebb6ea2a13…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:18:49+01:00
registrar: when provided, use host part from uri parameter
- instread of the To URI, which can be different
(cherry picked from commit 1c2cb9980082a6a1a8e3986330d9b80c49ef7801)
- URL: https://github.com/kamailio/kamailio/commit/6c88ef7c6abc45f72571aaa713f1d0d…
Author: Daniel-Constantin Mierla <miconda(a)gmail.…
[View More]com>
Date: 2024-11-06T09:19:12+01:00
auth_xkey: use memcpy() instead of strncpy()
(cherry picked from commit 29686758e1ce51abb8d8dd5bebb0d7fa1a019dc6)
- URL: https://github.com/kamailio/kamailio/commit/065e0514144f4e4f160ae15b515948c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:19:42+01:00
registrar: use parsed uri parameter when provided for save()
- instead of to-uri, aor being built from uri parameter
(cherry picked from commit 21e2d96672ccbe65eebdf64f839a1ce465a11b7c)
- URL: https://github.com/kamailio/kamailio/commit/32987e68f85500e2b37134c7a542ab7…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:20:44+01:00
core: try to lookup connection for WSS when TCPCONN_MATCH_STRICT is set
- URIs have always transport ws, but most likely the connection is wss
- GH #3969
(cherry picked from commit aa794581ecf105b5313d2f5b8bcfe516ab337936)
- URL: https://github.com/kamailio/kamailio/commit/f6b6aeb9297b6782655199de9bcb82c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:21:00+01:00
registrar: safety check for uri and remove duplicated aor extract
- follow up of changes from previous commit
(cherry picked from commit 60165196ad3144597c24eb9f7bb7fb0cd56f8c25)
- URL: https://github.com/kamailio/kamailio/commit/4cb602385b4bb7b9df5cff9aac60ea0…
Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro>
Date: 2024-11-06T09:22:01+01:00
core: parser - use sip_parser_log
Silencing messages that tend to appear when processing HEP.
(cherry picked from commit e6a3b3554af01e5141ba063df408a06b28261927)
- URL: https://github.com/kamailio/kamailio/commit/62a76d2fe3547ef6701e8b86f195396…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:22:42+01:00
core: option to skip auto-bind on ipv6 local link
- set bind_ipv6_link_local=2
(cherry picked from commit 2bcd29a7a2981670baea0b7fb2e8454b5ad9f4d7)
- URL: https://github.com/kamailio/kamailio/commit/081e17b925a019c9971bf1296bc9a70…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:22:53+01:00
core: log message about interface flags made info
- small updates to a couple of error messages
(cherry picked from commit 15823c3eda3a332d22d9132a873d755aa024892f)
- URL: https://github.com/kamailio/kamailio/commit/4647ecd9c20a79967a8beed14262ad7…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:23:05+01:00
core: check for items with emtpy address when discovering the network interfaces
- it may be returned on some OSes, preventing to start
(cherry picked from commit bd4c068ee9c8e18dc76f8154d3fa4c438972b79c)
- URL: https://github.com/kamailio/kamailio/commit/9947b5a548ff1802de70acccc1d8306…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:23:15+01:00
core: socket info - set address also for link local items
- updates to log messages
(cherry picked from commit fd95b95035a7da088a94888132326d463191da83)
- URL: https://github.com/kamailio/kamailio/commit/54c6ac01e98866905c8654a42873f02…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:23:25+01:00
core: check for incompatible modes for bind_ipv6_link_local
- a few more debug messages
(cherry picked from commit 86770d203bde6859284ec8862be66d78efd2715a)
- URL: https://github.com/kamailio/kamailio/commit/499be2dcbefe30be2ed616064a04bc0…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:23:42+01:00
ldap: remove unused variable in child_init
fixes #3974
> ldap_mod.c: In function ������child_init������:
> ldap_mod.c:156:13: warning: unused variable ������ret������ [-Wunused-variable]
> 156 | int ret = 0;
(cherry picked from commit a078f14050b6d31bfbcd3562306923c0c4ad73e3)
- URL: https://github.com/kamailio/kamailio/commit/240b66b8d9ea9bf58e897bf9b35c4d9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:23:52+01:00
core: skip interfaces with index over max iface limit
(cherry picked from commit fa17af660dc754cd46c747ec8c3216ef52fd4fcc)
- URL: https://github.com/kamailio/kamailio/commit/e3969c489b24490c667eb4680ee452f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:24:09+01:00
core: use advertised port only when explicitely set
- do not fallback to socket port
(cherry picked from commit 0f423f97607416edcff8d0f1612fad7af29b6064)
- URL: https://github.com/kamailio/kamailio/commit/af0ec5445393939288c86e976eba8f5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:24:19+01:00
core: use advertised port for recv socket only when set
(cherry picked from commit c09a29369f03f6c5e621a94b5b853047490568aa)
- URL: https://github.com/kamailio/kamailio/commit/c62a1b6efd10f5c46cf87a9ea33ee4f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:24:29+01:00
core: use macro to check send_port_str value
(cherry picked from commit 15d81a0151aa46a20f95fb8c6dc2665d03e741aa)
- URL: https://github.com/kamailio/kamailio/commit/1cd3b749e699f2b83752a5b6c1b29f1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:25:26+01:00
core: proper condition for bind_ipv6_link_local modes
(cherry picked from commit 99710daa8b05a0a37ef3bb35e2ffd723908037f4)
- URL: https://github.com/kamailio/kamailio/commit/96ebad5d1a3650961ca6e3cd22d4da0…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:25:40+01:00
app_jsdt: add support for loong64
From: liuxiang <liuxiang(a)loongson.cn>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060901
fixes #3976
(cherry picked from commit 5746db1c5a99eaeaf7f97d520232f014548c912d)
- URL: https://github.com/kamailio/kamailio/commit/24651787d54746647614be111ee5cb5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:27:00+01:00
core: use advertise port only when set for via header
(cherry picked from commit abaf42a735b00af8cbfec90888d2ef3397e5040d)
- URL: https://github.com/kamailio/kamailio/commit/8331cb1f87b31f66f87a90e7fbaa255…
Author: Thomas <1258170+ThomasSevestre(a)users.noreply.github.com>
Date: 2024-11-06T09:27:16+01:00
topos_redis : show redis error for post mortem analysis
(cherry picked from commit 72889e945041b6475a43c371aa4e20e99f5d1240)
- URL: https://github.com/kamailio/kamailio/commit/95371808084c547e01daf3ecdc7124c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:27:47+01:00
core: reqorked check for incompatible modes of bind_ipv6_link_local
(cherry picked from commit f7045d1c08d37e91ee7e96e415c06b218aee98fd)
- URL: https://github.com/kamailio/kamailio/commit/004e0e056178dfbaa1aca6e8d736441…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:28:35+01:00
core: print errno on tcp bind failure
- log message with value of sr_bind_ipv6_link_local
(cherry picked from commit 621f3132708405939d3a40fb98ae57b793cd246e)
- URL: https://github.com/kamailio/kamailio/commit/f3d510f6f1f59bb33ff6e3df08863f6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:28:56+01:00
core: socket info - relocate check for index to get more debugging details
(cherry picked from commit b7dcbc37aceaefecf9a0f7367526a331d42269ea)
- URL: https://github.com/kamailio/kamailio/commit/1d216f8764ebb0e8f78764e3778f34a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:29:09+01:00
core: socket info - do not use interface index as internal array index
- there are cases when the interface number is high, even if there are
only a few real network interfaces, which can result in inability to
listen on them
(cherry picked from commit 7acfe7723b4772ca45ce31ae98bf3d0b6948f50a)
- URL: https://github.com/kamailio/kamailio/commit/b553882d8d87d3891f387832fe2d562…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:29:46+01:00
core/rand: fix -Wdeprecated-non-prototype
> Warning: core/rand/isaac/rand.c:28:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> void isaac(ctx) randctx *ctx;
> ^
> Warning: core/rand/isaac/rand.c:81:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> void randinit(ctx, flag) randctx *ctx;
(cherry picked from commit 9475837b209c91366e8bb40416552b02c13aaf3a)
- URL: https://github.com/kamailio/kamailio/commit/170d35f1f14f71f69bdfa6586997def…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:30:12+01:00
tm: fix warning uninitialized variable
> Warning: t_fwd.c:1919:46: warning: variable 'port' is uninitialized when used here [-Wuninitialized]
> ret = forward_request_uac(p_msg, &host, port, &dst);
> ^~~~
> t_fwd.c:1843:21: note: initialize the variable 'port' to silence this warning
> unsigned short port;
> ^
> = 0
> 1 warning generated.
(cherry picked from commit ce4107a6f654a4bc4462efb90f3cc5e8c73bf9ed)
- URL: https://github.com/kamailio/kamailio/commit/fa959e8cfda491612b7a13d1a187724…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:31:09+01:00
presence: fix warning conflicting prototype
> Warning: presence_dmq.c:38:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
> int pres_dmq_send_all_presentities();
> ^
> presence_dmq.c:487:5: note: conflicting prototype is here
> int pres_dmq_send_all_presentities(dmq_node_t *dmq_node)
> ^
> 1 warning generated.
(cherry picked from commit 03e49d4e1d806f39ee6aadaedd183a6578108d96)
- URL: https://github.com/kamailio/kamailio/commit/6bec8ed087c308c504da7ad217b55e1…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:31:48+01:00
cdp: fix warning deprecated-non-prototype
> Warning: peerstatemachine.c:120:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:182:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:395:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:400:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:420:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:462:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> Warning: peerstatemachine.c:467:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> log_peer_list(L_INFO);
> ^
> 7 warnings generated.
(cherry picked from commit f49012d15a06b27875cf6bca211ad953968b5217)
- URL: https://github.com/kamailio/kamailio/commit/b55acf4ce764da70f7bd78e05598b68…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:32:27+01:00
ims_usrloc_pcscf: fix warnings deprecated-non-prototype
> In file included from pcontact.c:46:
> Warning: ./pcontact.h:63:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
> int new_pcontact(
> ^
> pcontact.c:166:5: note: conflicting prototype is here
> int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci,
> ^
> 1 warning generated.
> Warning: udomain.c:232:17: warning: passing arguments to 'new_pcontact' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
> if(new_pcontact(_d->name, _contact, _ci, _c) < 0) {
> ^
> 1 warning generated.
(cherry picked from commit 7dcc8405ccec19132d27516426137e35e464d4ad)
- URL: https://github.com/kamailio/kamailio/commit/2ad5b019f6c2a2afee8f0d575f92a02…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:32:38+01:00
ims_usrloc_pcscf: fix warning deprecated-non-prototype
> In file included from usrloc_db.c:12:
> Warning: ./usrloc_db.h:131:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
> int use_location_pcscf_table();
> ^
> usrloc_db.c:113:5: note: conflicting prototype is here
> int use_location_pcscf_table(str *domain)
> ^
> 1 warning generated.
(cherry picked from commit 35a87c98f4e84b65f82376dfb57050f43d0f355f)
- URL: https://github.com/kamailio/kamailio/commit/02efd2aad688b2eec0bff7b743ce4b9…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:32:55+01:00
rabbitmq: remove deprecation warning
From https://github.com/alanxz/rabbitmq-c/blob/c3e4176659aac7d0e497da90a46c08c63…
> * \deprecated Since v0.13.0 this is a no-op. OpenSSL automatically manages
> * library initialization and uninitialization.
> Warning: rabbitmq.c:574:3: warning: 'amqp_set_initialize_ssl_library' is deprecated [-Wdeprecated-declarations]
> amqp_set_initialize_ssl_library(1);
> ^
> /usr/include/rabbitmq-c/ssl_socket.h:249:1: note: 'amqp_set_initialize_ssl_library' has been explicitly marked deprecated here
> AMQP_DEPRECATED_EXPORT
> ^
> /usr/include/rabbitmq-c/export.h:29:46: note: expanded from macro 'AMQP_DEPRECATED_EXPORT'
> # define AMQP_DEPRECATED_EXPORT AMQP_EXPORT AMQP_DEPRECATED
> ^
> /usr/include/rabbitmq-c/export.h:25:43: note: expanded from macro 'AMQP_DEPRECATED'
> # define AMQP_DEPRECATED __attribute__ ((__deprecated__))
> ^
> 1 warning generated.
(cherry picked from commit a2f7147dded679d025a902aa12beb048ee714c32)
- URL: https://github.com/kamailio/kamailio/commit/8db46badd40606e910350e4ea3c28f8…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:33:12+01:00
kazoo: fix deprecation warning
fixes #3466
From https://github.com/alanxz/rabbitmq-c/blob/c3e4176659aac7d0e497da90a46c08c63…
> * \deprecated Since v0.13.0 this is a no-op. OpenSSL automatically manages
> * library initialization and uninitialization.
> Warning: kz_amqp.c:857:3: warning: 'amqp_set_initialize_ssl_library' is deprecated [-Wdeprecated-declarations]
> amqp_set_initialize_ssl_library(1);
> ^
> /usr/include/rabbitmq-c/ssl_socket.h:249:1: note: 'amqp_set_initialize_ssl_library' has been explicitly marked deprecated here
> AMQP_DEPRECATED_EXPORT
> ^
> /usr/include/rabbitmq-c/export.h:29:46: note: expanded from macro 'AMQP_DEPRECATED_EXPORT'
> # define AMQP_DEPRECATED_EXPORT AMQP_EXPORT AMQP_DEPRECATED
> ^
> /usr/include/rabbitmq-c/export.h:25:43: note: expanded from macro 'AMQP_DEPRECATED'
> # define AMQP_DEPRECATED __attribute__ ((__deprecated__))
> ^
> 1 warning generated.
(cherry picked from commit eeb17678d77548073a59b54c0a08ebdb48b25fa2)
- URL: https://github.com/kamailio/kamailio/commit/844a7a072abf5fad466a20bcae33e1d…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:33:19+01:00
sms: fix warning and remove old logic
> Warning: libsms_getsms.c:107:25: warning: implicit conversion from 'int' to 'char' changes value from 183 to -73 [-Wconstant-conversion]
> 107 | ascii[charcounter] = 183;
> | ~ ^~~
> 1 warning generated.
(cherry picked from commit ee052fd0a7e7dc703a186a01926a8e64c635d636)
- URL: https://github.com/kamailio/kamailio/commit/66243e19149d3f4324089f4f54bf860…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:33:28+01:00
http_async_client: fix warning deprecated-non-prototype
> Warning: ./http_multi.h:64:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C23, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
> 64 | int init_http_multi();
> | ^
> http_multi.c:403:5: note: conflicting prototype is here
> 403 | int init_http_multi(struct event_base *evbase, struct http_m_global *wg)
> | ^
> 1 warning generated.
(cherry picked from commit 2737bb19a363be7c0d67749b75f11c7e9d2d09f3)
- URL: https://github.com/kamailio/kamailio/commit/fab08023dc425919c77dc960b0944eb…
Author: aelezovic <adnan.elezovic(a)infobip.com>
Date: 2024-11-06T09:33:39+01:00
mongodb: fix cursor error resulting empty result set
(cherry picked from commit afebe6b2e597755ae37fd37bdf011fbb2fbbf8fe)
- URL: https://github.com/kamailio/kamailio/commit/faf27cef7118a35bfab4aed5185148d…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:01+01:00
siptrace: use advertise address if set for trace mode 1 callbacks
(cherry picked from commit 9fb15e2ef93a0d606fa4c6d695a2f13a4b0a8031)
- URL: https://github.com/kamailio/kamailio/commit/9a24032160de4205585a890c2195c3f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:12+01:00
siptrace: added parameter data_mode
- control if bind address of advertised address are used
(cherry picked from commit 9d8432f3ffb1f9d07874452e23140be21e75c530)
- URL: https://github.com/kamailio/kamailio/commit/a1e79755f4d2827a68f092dea1f138d…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:20+01:00
siptrace: docs for data_mode param
(cherry picked from commit 337c06b6b43606536f1d37ebfd6e4240aab9cf5a)
- URL: https://github.com/kamailio/kamailio/commit/0ba1666fec15ed292e7fe1764bfa985…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:35+01:00
core: parser sdp - check for length of sendrecv attribute
(cherry picked from commit fc4817064f81ef9a82b1b1468b1b8a4ae352c1f2)
- URL: https://github.com/kamailio/kamailio/commit/eb058dba967bb772c8413356163ec6c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:44+01:00
core: parse sdp - check for body limit on mixed content
(cherry picked from commit d4bbde619bbf808edebb31e131b3783ba2a4b34d)
- URL: https://github.com/kamailio/kamailio/commit/e650ace5948c76ea2d8eb7eaeebb5c3…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:34:55+01:00
core: parser sdp - check field length when extracting the value
(cherry picked from commit e802f9187383feb7fdd96c4ded44fda403da4535)
- URL: https://github.com/kamailio/kamailio/commit/13579e6d39898afbe6064c645d5a0f8…
Author: Eik Rentzow <rentzow(a)gmx.de>
Date: 2024-11-06T09:36:32+01:00
siputils/doc: updated pcv documentation [skip ci]
- Updated documentation to reflect the changes to the $pcv pseudo-var
and the sip_p_charging_vector() function.
(cherry picked from commit 05a30ed53fc5657a2d86e1c1bdb9277571a8d17e)
- URL: https://github.com/kamailio/kamailio/commit/8c3eb992e07bbb0f0f9a123c124b23d…
Author: Eik Rentzow <rentzow(a)gmx.de>
Date: 2024-11-06T09:36:39+01:00
siputils: bug fix for sip_p_charging_vector
- Bug fix for #3929 and further improvements.
- New buffer usage for P-Charging-Vector handling.
- Added $pcv(status) pseudo-var.
- Added return values for sip_p_charging_vector().
- Much improved error case handling.
- Use send interface for icid-genearted-at:
The icid-generated-at parameter should carry the ip adress of the
egress interface and not of the interface where the message was received.
This is in accordance with other SBC solutions.
(cherry picked from commit d7c8bc5c58f672004894733d0e6d2a7cb00efe7a)
- URL: https://github.com/kamailio/kamailio/commit/98032a98eaf764140825c4a2c0eb64a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:37:02+01:00
core: socket info - skip ipv6 link local on interface discovery
(cherry picked from commit a5b1099c9061551a0b31db8ef88efb2e376b290c)
- URL: https://github.com/kamailio/kamailio/commit/ba194c482f72618a896864d5a9738de…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:37:35+01:00
async: docs updates for async_sleep()
(cherry picked from commit cce29af41120cf30c4c22979e772d1ca666408c6)
- URL: https://github.com/kamailio/kamailio/commit/a688b24ac777cb93306a1a777e687de…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:37:50+01:00
core: parser sdp - check if body is enough for rtpmap
(cherry picked from commit c7f89e81504c425a83f3423bc4b4d9d1a8a48909)
- URL: https://github.com/kamailio/kamailio/commit/255db278f078c8868f28e6451d92b80…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:38:12+01:00
jwt: print decode result in error log message
(cherry picked from commit 0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5)
- URL: https://github.com/kamailio/kamailio/commit/0408c2cb412f0df0a17b70aa4d15026…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:38:24+01:00
core: parser sdp - check length for rtpmap extract
(cherry picked from commit c823f41350ab9186a323707e9be32e31922bec17)
- URL: https://github.com/kamailio/kamailio/commit/a97199e0114b9cfc0804c3d8f73471f…
Author: Dragos Vingarzan <vingarzan(a)gmail.com>
Date: 2024-11-06T09:38:49+01:00
ims_registrar_scscf: fixing em_max_expires
(cherry picked from commit 3f38206d88af0fae4c64ee3072eb78ea68f813cb)
- URL: https://github.com/kamailio/kamailio/commit/cfb143196d0b727f16add51590bc007…
Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2024-11-06T09:39:02+01:00
db_schema: Add ims_icscf db schema
(cherry picked from commit e2ea727988828a9683ef112637e25ee4d58032f7)
- URL: https://github.com/kamailio/kamailio/commit/af963c81775b9c93d37428fe86264cb…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:39:46+01:00
ratelimit: use core str comparison functions
(cherry picked from commit c44a349964081d397ab9efa3504737bf369f8cf5)
- URL: https://github.com/kamailio/kamailio/commit/466c5419634a7cb9c9f3cf38b15f36d…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:40:13+01:00
pipelimit: use core str comparison functions
(cherry picked from commit 9ee189883549faffb21d3ae113dafd7ad95757af)
- URL: https://github.com/kamailio/kamailio/commit/ac908d6a4cee146c35c28210fa937aa…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-11-06T09:40:21+01:00
lrkproxy: use core str comparison functions and macros
(cherry picked from commit c67d8fa0b1015d73b34430f6f8a6afe22ca10cbe)
- URL: https://github.com/kamailio/kamailio/commit/61d3cc66f97f283c78bec77244bc616…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:40:32+01:00
topos: catch ACK without contact that needs no storage updates
(cherry picked from commit 824e81319b60054feb81c37b3a8be80523f8c95d)
- URL: https://github.com/kamailio/kamailio/commit/19729e29b24915b84079831a37e9ade…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:40:52+01:00
topos: extended error log message
- ensure headers are parsed for storage record
(cherry picked from commit a6b924be7fd7d4ce6a92ad5a0247077b09a29474)
- URL: https://github.com/kamailio/kamailio/commit/fa9965d33cec01fd503bb89f2076b93…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:02+01:00
dispatcher: debug messages for checking active destinations
(cherry picked from commit 3e5f8deced0cb05710e631601e9098505f1d230a)
- URL: https://github.com/kamailio/kamailio/commit/18dad74a091e693a0bf939dddf14434…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:11+01:00
core: parser sdp - check len gor extracting fmtp
(cherry picked from commit d10257fbfdbb3e3e73c0fe60a224585822bdd7b3)
- URL: https://github.com/kamailio/kamailio/commit/72f08c6fff97d3a2498498eb01ce6c1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:19+01:00
topos: deal with BYE without contact header for mode 1
(cherry picked from commit a4f0ee5da93ad64d449c7a95ecad2f3d70aeb975)
- URL: https://github.com/kamailio/kamailio/commit/08b4a6d280f851389252f4016e90325…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:32+01:00
timer: formatted exported structures
(cherry picked from commit 8e2541ec6126b5665e92cde5eaf17f5a4970cb8d)
- URL: https://github.com/kamailio/kamailio/commit/e233bc60092242e886a0336104435cd…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:44+01:00
timer: export timer_enable(...) to kemi
- GH #4008
(cherry picked from commit ad919796b24d0c38af136cbad2563e6f98df4b74)
- URL: https://github.com/kamailio/kamailio/commit/351157cad257986a014dc659231ae0e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:41:53+01:00
core: parser sdp - check body end for extract_ice_option()
(cherry picked from commit 79d7fae0f26f577356f017cfff5e00c348cf259c)
- URL: https://github.com/kamailio/kamailio/commit/a52fe973b064e288d9f150a6c36cb35…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-11-06T09:42:09+01:00
timer: docs - updates to examples
(cherry picked from commit 21c7066842a034d8674e5fac2b7c6fd38b0073e8)
- URL: https://github.com/kamailio/kamailio/commit/b292837507dd60f45ebc1cca8317b6c…
Author: Henning Westerholt <hw(a)gilawa.com>
Date: 2024-11-06T09:42:37+01:00
snmpstats: use proper name for ims module in docs
(cherry picked from commit 6c408ff8c7b558a725d67898d5f1a8dc3d717c61)
- URL: https://github.com/kamailio/kamailio/commit/bf038a0a84bdecd69d749464880826f…
Author: Henning Westerholt <hw(a)gilawa.com>
Date: 2024-11-06T09:42:48+01:00
sst: use proper name for ims dialog module in docs
(cherry picked from commit 3b3c60f94dd93e460d5bda40c73b2052a4f1bf33)
[View Less]
Hello,
about 8 months since the last major release v5.8.x, therefore it is the
time to plan a bit the next steps for getting v6.0.0 out.
The Kamailio Developers Meeting is schedule in Dusseldorf, Germany
during November 19-20, 2024, where we expect to push out a consistent
number of updates. Then maybe we can wait for another 2 weeks or so to
settle down/finish those updates. After that, if no other new features
are planned by developers in short term, we can enter the testing phase,
so the …
[View More]new major version can be released during the second part of
January 2025 or first part of February 2025.
Therefore, if you have new features under development that might require
more than 1-1.5 months from now, and you want to get them in v6.0.0, let
us know to plan properly.
Other time lines suggestions to get to v6.0.0 are also welcome!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]
Hello,
Kamailio SIP Server project is organizing another meeting of its
developers and community members during November 19-20, 2024 (Tue-Wed),
hosted again by sipgate.de in Dusseldorf, Germany.
The event is intended to facilitate the interaction between Kamailio
developers and contributors in order to offer a convenient environment
for working together on several topics of high interest for the project,
including writing code for Kamailio and its tools, improving
documentation, or discuss …
[View More]about future development.
Everyone from the community is welcome to join, developer or user
interested in helping the project. Please note we have a limited
capacity of seats in the meeting room, the main policy for accepting
participants being first come first server. Also, very important to be
aware that this is not an event to learn how to use Kamailio.
More details about the event, the venue, how to register, are available at:
* https://www.kamailio.org/w/developers-meeting/
Looking forward to those two intensive hacking Kamailio days in Dusseldorf!
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
[View Less]
Module: kamailio
Branch: master
Commit: cf54baa30db65a96bd732295200503b99b566914
URL: https://github.com/kamailio/kamailio/commit/cf54baa30db65a96bd732295200503b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-11-05T18:01:09+01:00
modules: readme files regenerated - snmpstats ... [skip ci]
---
Modified: src/modules/snmpstats/README
Modified: src/modules/sst/README
---
Diff: https://github.com/kamailio/…
[View More]kamailio/commit/cf54baa30db65a96bd732295200503b…
Patch: https://github.com/kamailio/kamailio/commit/cf54baa30db65a96bd732295200503b…
---
diff --git a/src/modules/snmpstats/README b/src/modules/snmpstats/README
index 407b6def697..83ee6cd975c 100644
--- a/src/modules/snmpstats/README
+++ b/src/modules/snmpstats/README
@@ -282,10 +282,11 @@ Chapter 1. Admin Guide
* usrloc - all scalars and tables relating to users and contacts are
dependent on the usrloc module. If the module is not loaded, the
respective tables will be empty.
- * dialog or dialog-ng - all scalars relating to the number of dialogs
- are dependent on the presence of a dialog module. Furthermore, if
- the module is not loaded, then the kamailioDialogLimitMinorEvent,
- and kamailioDialogLimitMajorEvent alarm will be disabled.
+ * dialog or ims_dialog - all scalars relating to the number of
+ dialogs are dependent on the presence of a dialog module.
+ Furthermore, if the module is not loaded, then the
+ kamailioDialogLimitMinorEvent, and kamailioDialogLimitMajorEvent
+ alarm will be disabled.
The contents of the kamailioSIPMethodSupportedTable change depending on
which modules are loaded.
diff --git a/src/modules/sst/README b/src/modules/sst/README
index a5bd40b681d..9cf8dba51c6 100644
--- a/src/modules/sst/README
+++ b/src/modules/sst/README
@@ -170,7 +170,7 @@ Chapter 1. Admin Guide
3.1. Kamailio Modules
The following modules must be loaded before this module:
- * dialog or dialog-ng - dialog module and its dependencies. (tm)
+ * dialog or ims_dialog - dialog module and its dependencies. (tm)
* sl - stateless module.
3.2. External Libraries or Applications
@@ -293,7 +293,7 @@ modparam("sst", "sst_flag", 6)
route {
...
if (method=="INVITE") {
- dlg_manage(); # Track the dialog
+ dlg_manage(); # Track the dialog
setflag(6); # set the sst flag
}
...
[View Less]
Module: kamailio
Branch: master
Commit: 6c408ff8c7b558a725d67898d5f1a8dc3d717c61
URL: https://github.com/kamailio/kamailio/commit/6c408ff8c7b558a725d67898d5f1a8d…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2024-11-05T16:45:50Z
snmpstats: use proper name for ims module in docs
---
Modified: src/modules/snmpstats/doc/snmpstats_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/6c408ff8c7b558a725d67898d5f1a8d……
[View More]Patch: https://github.com/kamailio/kamailio/commit/6c408ff8c7b558a725d67898d5f1a8d…
---
diff --git a/src/modules/snmpstats/doc/snmpstats_admin.xml b/src/modules/snmpstats/doc/snmpstats_admin.xml
index 12a6ee152c0..538908e2573 100644
--- a/src/modules/snmpstats/doc/snmpstats_admin.xml
+++ b/src/modules/snmpstats/doc/snmpstats_admin.xml
@@ -215,7 +215,7 @@
<listitem>
<para>
- <emphasis>dialog or dialog-ng</emphasis> - all scalars relating to the number of dialogs are
+ <emphasis>dialog or ims_dialog</emphasis> - all scalars relating to the number of dialogs are
dependent on the presence of a dialog module. Furthermore, if the module is
not loaded, then the kamailioDialogLimitMinorEvent, and kamailioDialogLimitMajorEvent
alarm will be disabled.
[View Less]
<!-- Kamailio Pull Request Template -->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] …
[View More]Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [X] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Long overdue clean-up of `app_python3`; remove legacy modules and rely solely on KEMI.
Bring it in sync with `app_python3s`.
Larger background: this is part I of a series of commits to enable free-threading builds of python to be used in kamailio.
https://py-free-threading.github.io/
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3986
-- Commit Summary --
* app_python3: removal of legacy modules
-- File Changes --
M src/modules/app_python3/app_python3_mod.c (14)
D src/modules/app_python3/mod_Core.c (68)
D src/modules/app_python3/mod_Core.h (36)
D src/modules/app_python3/mod_Logger.c (266)
D src/modules/app_python3/mod_Logger.h (37)
D src/modules/app_python3/mod_Ranks.c (96)
D src/modules/app_python3/mod_Ranks.h (35)
D src/modules/app_python3/mod_Router.c (84)
D src/modules/app_python3/mod_Router.h (36)
M src/modules/app_python3/python_iface.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3986.patchhttps://github.com/kamailio/kamailio/pull/3986.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3986
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3986(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 0ffe157bc13e7759ae1cee63a584fad4ac9eb38f
URL: https://github.com/kamailio/kamailio/commit/0ffe157bc13e7759ae1cee63a584fad…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: space88man <shihping.chan(a)gmail.com>
Date: 2024-11-05T11:01:08+08:00
app_python3: refactor GIL and thread state handling
* KEMI Python scripts that use Python threading for background jobs
would observe that the Python threads are not running
This is due to …
[View More]not releasing the GIL when returning to the Kamailio
event loop from KEMI calls
* The module was using PyGILState_Ensure / PyGILState_Release to
ensure thread-correctness
It turns out that in this case these are the wrong functions to use
The main thread is already correct due to Py_Initialize();
the PyGILState_xxx functions are redundant
To release the GIL so Python threads run we use the macros
Py_BLOCK_THREADS/Py_UNBLOCK_THREADS
Note: the PyGILState_XXX functions are for C-threads created
by Python unaware libraries
---
Modified: src/modules/app_python3/app_python3_mod.c
Modified: src/modules/app_python3/apy_kemi.h
Modified: src/modules/app_python3/python_exec.c
---
Diff: https://github.com/kamailio/kamailio/commit/0ffe157bc13e7759ae1cee63a584fad…
Patch: https://github.com/kamailio/kamailio/commit/0ffe157bc13e7759ae1cee63a584fad…
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
In TLS WolfSSL, enable initialization of the cipher_list from the domain config.
Also from this setting kamailio exposes dangerous ciphers like RC4, NULL
| ssl-enum-ciphers:
| TLSv1.2:
| ciphers:
| TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_RC4_128_SHA (secp256r1) - C
| TLS_ECDHE_ECDSA_WITH_AES_128_CCM (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_128_CCM_8 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_256_CCM_8 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256-draft (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_NULL_SHA (secp256r1) - F
| TLS_PSK_WITH_CHACHA20_POLY1305_SHA256 - unknown
| TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256 (secp256r1) - A
| TLS_ECDHE_PSK_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_ECDHE_PSK_WITH_NULL_SHA256 (secp256r1) - F
| compressors:
| NULL
| cipher preference: server
| warnings:
| Broken cipher RC4 is deprecated by RFC 7465
| TLSv1.3:
| ciphers:
| TLS_AKE_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_AKE_WITH_AES_256_GCM_SHA384 (secp256r1) - A
| TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| TLS_AKE_WITH_AES_128_CCM_SHA256 (secp256r1) - A
| TLS_AKE_WITH_AES_128_CCM_8_SHA256 (secp256r1) - A
| TLS_AKE_WITH_NULL_SHA256 (secp256r1) - F
| TLS_AKE_WITH_NULL_SHA384 (secp256r1) - F
| cipher preference: server
|_ least strength: unknown
After apply patch:
| ssl-enum-ciphers:
| TLSv1.2:
| ciphers:
| TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (secp256r1) - A
| TLS_ECDHE_ECDSA_WITH_AES_128_CCM (secp256r1) - A
| compressors:
| NULL
| cipher preference: server
| TLSv1.3:
| ciphers:
| TLS_AKE_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_AKE_WITH_AES_256_GCM_SHA384 (secp256r1) - A
| TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| cipher preference: server
|_ least strength: A
version: kamailio 5.8.3 (x86_64/linux) 6f8a04-dirty
AlmaLinux release 8.10 (Cerulean Leopard)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4012
-- Commit Summary --
* tls_wolfssl: Initialize cipher_list for domain #3920
-- File Changes --
M src/modules/tls_wolfssl/tls_domain.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4012.patchhttps://github.com/kamailio/kamailio/pull/4012.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4012
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4012(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
We are facing a hang issue with Kamailio for the get_profile_size method. Randomly, the Kamailio got hangs, and the CPU went 100%.
During the hanging time, we generated the TRAP and we could see that the hang happened on the get_profile_size method. We are getting this hang randomly in dlg_profile.c of the following lines:
The hang occurs, causing the CPU to spike to 100% at one of the following lines randomly:
1. if(value->len == ph->value.len && memcmp(value->s, ph->value.s, value->len) == 0) {
2. ph = ph->next;
3. while(ph != profile->entries[i].first);
During our analysis, we found that PROCESS ID 7608 gets a spike of 100% utilization.
We suspect there may be an issue with the processing of the 'ph' variable, but we couldn't identify the root cause. I've attached the Kamailio TRAP for further details. Could you please suggest what might be causing this problem and how we can resolve it?
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
We have analysed the coredump and TRAP, And found that the issue could be from the following lines:
1. if(value->len == ph->value.len && memcmp(value->s, ph->value.s, value->len) == 0) {
2. ph = ph->next;
3. while(ph != profile->entries[i].first);
#### Reproduction
This issue is occurring randomly.
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
I have attached the TRAP data.
---start 7608 -----------------------------------------------------
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
get_profile_size (profile=0x7f7095698f50, value=0x7ffd5e21db20) at dlg_profile.c:860
860 }while( ph!=profile->entries[i].first );
#0 get_profile_size (profile=0x7f7095698f50, value=0x7ffd5e21db20) at dlg_profile.c:860
n = 0
i = 9
ph = 0x7f70958d3c98
#1 0x00007f7195585785 in w_get_profile_size_helper (msg=0x7f7198418558, profile=0x7f7095698f50, value=0x7ffd5e21db20, spd=0x7f71983a8cf0) at dialog.c:941
size = 32625
val = {rs = {s = 0x7ffd5e21da80 "\260\332!^\375\177", len = 591976160}, ri = xxxxxxxx77096, flags = 32765}
__func__ = "w_get_profile_size_helper"
#2 0x00007f7195585fd2 in w_get_profile_size3 (msg=0x7f7198418558, profile=0x7f7095698f50 "\200\220i\225p\177", value=0x7f71983b4b30 "80;\230q\177", result=0x7f71983a8cf0 "\004") at dialog.c:982
pve = 0x7f71983b4b30
val_s = {s = 0x7f7198346dd0 "2777995", len = 7}
spd = 0x7f71983a8cf0
__func__ = "w_get_profile_size3"
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
#### Log Messages
When Kamailio hangs, the logs are not written to the kamailio.log file.
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
#### SIP Traffic
I have attached the TRAP file.
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
### Possible Solutions
We are expecting some kind of solution for it.
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio version is 5.5.5```
* **Operating System**:
[gdb_kamailio_trap.zip](https://github.com/user-attachments/files/16581474/g…
```
"Debian GNU/Linux 10 (buster)"```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3947
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3947(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Hello, I am using ndb_redis module with TLS and redis-cluster. kamailio connects to the cluster endpoint when getting data, gets a 'MOVED' response and prints below error, it does not get data from the new host.
### Troubleshooting
I have verified that I can connect to the cluster endpoint and the host in 'MOVED' using redis-cli on the system that kamailio is running on. I tried to connect to a self hosted cluster without TLS, it works as expected. It also works as expected with TLS and a single redis host.
#### Reproduction
Connect to a redis-cluster over TLS
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
2024-06-25T20:48:53.626708963Z 2024-06-25 20:48:53.626584 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: redisc_get_server(): Hash 31807 (ra)
2024-06-25T20:48:53.626710053Z 2024-06-25 20:48:53.626600 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: redisc_get_server(): Entry 31807 (ra)
2024-06-25T20:48:53.626711073Z 2024-06-25 20:48:53.626636 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:444]: redisc_get_server(): Using entry 31807 (ra)
2024-06-25T20:48:53.626712073Z 2024-06-25 20:48:53.626651 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1030]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20
2024-06-25T20:48:53.626713073Z 2024-06-25 20:48:53.626667 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1036]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20
2024-06-25T20:48:53.626810463Z 2024-06-25 20:48:53.626762 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:896]: check_cluster_reply(): Redis replied: "MOVED 3667 testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.availability-zone.amazonaws.com:6379"
2024-06-25T20:48:53.626811523Z 2024-06-25 20:48:53.626777 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:904]: check_cluster_reply(): Port "6379" [4] => 6379
2024-06-25T20:48:53.626816413Z 2024-06-25 20:48:53.626793 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:914]: check_cluster_reply(): Host "testdbredis-masked-hostname.00000000001110000000.130-characters-long.000000…" [130]
2024-06-25T20:48:53.626846113Z 2024-06-25 20:48:53.626810 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:925]: check_cluster_reply(): Name of new connection: testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.
2024-06-25T20:48:53.626851443Z 2024-06-25 20:48:53.626827 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: redisc_get_server(): Hash 968070864 (testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.)
2024-06-25T20:48:53.626896173Z 2024-06-25 20:48:53.626844 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: redisc_get_server(): Entry 31807 (ra)
2024-06-25T20:48:53.626897503Z 2024-06-25 20:48:53.626861 3(17) NOTICE: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:450]: redisc_get_server(): No entry found.
2024-06-25T20:48:53.626955363Z 2024-06-25 20:48:53.626877 3(17) ERROR: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:947]: check_cluster_reply(): failed to print server spec string
2024-06-25T20:48:53.626957263Z 2024-06-25 20:48:53.626893 3(17) DEBUG: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1115]: redisc_exec(): rpl->rplRedis->type:6
2024-06-25T20:48:53.626958443Z 2024-06-25 20:48:53.626908 3(17) ERROR: {Kam 192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:1117]: redisc_exec(): Redis error:MOVED 3667 testdbredis-masked-hostname.00000000001110000000.130-characters-long.00000000000011111111100000000.availability-zone.amazonaws.com:6379
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.1 (x86_64/linux) 384843
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 384843
compiled on 19:05:30 Jun 25 2024 with gcc 12.2.0
```
* Hiredis(v1.2.0) and hiredis-cluster(v0.13.0) are installed from source, both with ssl support.
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Debian 12
```
### Kamailio config snippet
```
loadmodule "ndb_redis.so"
.
.
# ----- ndb_redis params -----
modparam("ndb_redis", "server", "name=ra;addr=cluster.testdbredis-masked-hostname.0000000011111111100000.availability-zone.amazonaws.com;port=6379;tls=1")
modparam("ndb_redis", "init_without_redis", 1)
modparam("ndb_redis", "cluster", 1)
modparam("ndb_redis", "allow_dynamic_nodes", 1)
modparam("ndb_redis", "ca_path", "/etc/ssl/certs")
modparam("ndb_redis", "debug", 1)
.
.
redis_cmd("ra", "HMGET usr_preferences:entry::%s:%s blocked", "$rU", "$fU", "r");
if($redis(r=>value[0]) == 1) {
.
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3894
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3894(a)github.com>
[View Less]
Hi there,
I am currently using the tls_wolfssl module with kamailio and was wondering why the ability to set a cipher list was disabled.
From my own testing, uncommenting line 975 in tls_domain.c/ksr_tls_fix_domain adds the functionality and we haven't seen any issues with this so far.
Was there an issue with this when the module was first created? Should I be avoiding using this functionality? Thanks very much.
--
Reply to this email directly or view it on GitHub:
https://github.com/…
[View More]kamailio/kamailio/issues/3920
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3920(a)github.com>
[View Less]
Hello
The timer_enable() function does not exist in KEMI.
Can you implement the equivalent of this function in KEMI?
BR
Juan PASCUAL
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4008
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4008(a)github.com>
Hi,
I am thinking of this idea to add shm storage for topos module. Main
motivation for this is that if db backend is not available, there will be
no store/load happening.
Did anyone else thought of this or is doing something similar already?
I see 2 milestones here:
1. Add code in topos to keep a shm hash table with all the information
needed, guarded via locks. The api functions should be very similar to what
tps_storage.c has, just it will do ops directly in memory not on db.
2. Find a …
[View More]way to synchronize this topos hash table among multiple
kamailios. This should be similar to how htable module syncronize via DMQ.
Sync may happen either for each new cell, for batches or for entire topos
hash table.
What do you think of this? Any opinions, comments, appreciated.
Thank you,
Stefan Mititelu
[View Less]
### Description
I used sip_p_charging_vector() function of siputils with flag f (remove + generate).
This function works fine if call is received without a P-Charging-Vector and only generate needs to be done.
But if the INVITE already contains a P-Charging-Vector and this vector needs to be removed and replaced by a new generated P-Charging-Vector the output is messed up.
The sip_p_charging_vector() function with flag r (remove) works fine too. P-Charging-Vector is removed if INVITE …
[View More]contains one. So for me this looks like an issue with the combination of remove + generate.
See SIP Traffic attached. The "old" P-Charging-Vector is not deleted and additionaly instead of a new P-Charging-Vector the "old" P-Charging-Vector is added again above SDP. Also some part of the next line "Session-Exp" is added and "TH: dih".
-----
TH: dih
icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx
Session-Exp
-----
### Troubleshooting
#### Reproduction
It looks like the issue is triggered always a p-charging-vector is received by kamailio and sip_p_charging_vector() with flag f is called.
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
```
**This message is received by kamailio (Incoming):**
INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0
Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;branch=z9hG4bK08Bf3722bac16f3e05b
From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7
To: <sip:+49xxxxxxxx0@92.xxx.xxx.xxx:5060;user=phone>
Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx
CSeq: 373279 INVITE
Max-Forwards: 67
Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH
Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed
Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060>
P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone>
Supported: timer,100rel,histinfo
P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx
Session-Expires: 1800
Min-SE: 90
Content-Length: 236
Content-Disposition: session; handling=required
Content-Type: application/sdp
v=0
o=Sonus_UAC 278609 22801 IN IP4 213.xxx.xxx.xxx
s=SIP Media Capabilities
c=IN IP4 213.xxx.xxx.xxx
t=0 0
m=audio 29020 RTP/AVP 8 101
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=sendrecv
a=ptime:20
**This message is send out by kamailio (outgoing):**
INVITE sip:+49xxxxxxxx;npdi;rn=+49xxxxxxxx@bob.com:5060;user=phone SIP/2.0
Record-Route: <sip:172.xxx.xxx.xxx;r2=on;lr=on;ftag=gK085abca7>
Record-Route: <sip:92.xxx.xxx.xxx9;r2=on;lr=on;ftag=gK085abca7>
Via: SIP/2.0/UDP 172.xxx.xxx.xxx;branch=z9hG4bKc451.940fa2c220f96c1ef968de3c156db262.0
Via: SIP/2.0/UDP 213.xxx.xxx.xxx:5060;TH=div;branch=z9hG4bK08Bf3722bac16f3e05b
From: <sip:+43xxxxxxxx@alice.com;user=phone>;tag=gK085abca7
To: <sip:+49xxxxxxxx@92.xxx.xxx.xxx:5060;user=phone>
Call-ID: 168341746_132086108(a)213.xxx.xxx.xxx
CSeq: 373279 INVITE
Max-Forwards: 66
Allow: INVITE,ACK,CANCEL,BYE,REGISTER,REFER,INFO,SUBSCRIBE,NOTIFY,PRACK,UPDATE,OPTIONS,MESSAGE,PUBLISH
Accept: application/sdp, application/isup, application/dtmf, application/dtmf-relay, multipart/mixed
Contact: <sip:+43xxxxxxxx@213.xxx.xxx.xxx:5060>
P-Asserted-Identity: <sip:+43xxxxxxxx@alice.com:5060;user=phone>
Supported: timer,100rel,histinfo
P-Charging-Vector: icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx
Session-Expires: 1800
Min-SE: 90
Content-Length: 252
Content-Disposition: session; handling=required
Content-Type: application/sdp
**_TH: dih
icid-value=0d702d06-5700-103e-00-00-00-10-6b-03-dd-04;icid-generated-at=213.xxx.xxx.xxx
Session-Exp_**
v=0
o=Sonus_UAC 278609 22801 IN IP4 92.xxx.xxx.xxx
s=SIP Media Capabilities
c=IN IP4 92.xxx.xxx.xxx
t=0 0
m=audio 34622 RTP/AVP 8 101
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=sendrecv
a=rtcp:34623
a=ptime:20
```
### Additional Information
```
version: kamailio 5.8.2 (x86_64/linux) 3fa5f4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 3fa5f4
compiled on 15:54:29 Jul 22 2024 with gcc 10.2.1
```
* **Operating System**:
```
Debian GNU/Linux 11
5.10.0-26-amd64 #1 SMP Debian 5.10.197-1 (2023-09-29) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3929
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3929(a)github.com>
[View Less]
Hi,
we had strange behavior with kamailio when some rtpengines were
unreachable, so we looked into the the source code and found this in
select_rtpp_node_new():
3323 /* Try to enable if it's time to try. */
3324 if(node->rn_disabled && node->rn_recheck_ticks <= get_ticks()) {
3325 node->rn_disabled = rtpp_test(node, 1, 0);
3326 }
Does this mean that a ping will be done during rtpengine manage?
Is this wise? I mean there are dedicated pings in the background. Doing
…
[View More]this in rtpengine manage will only periodically delay the processing of
a SIP message. We fear that in high traffic situations this could occupy
all threads. Is this a bug?
As a workaround we think setting rtpengine_tout_ms to a lower value
might help as it shortens the amount of time the module delays the
processing of the SIP message.
What do you think?
Best wishes
Christian Berger
--
Christian Berger - berger(a)sipgate.de
Telefon: +49 (0)211-63 55 55-0
Telefax: +49 (0)211-63 55 55-22
sipgate GmbH - Gladbacher Str. 74 - 40219 Düsseldorf
HRB Düsseldorf 39841 - Geschäftsführer: Thilo Salmon, Tim Mois
Steuernummer: 106/5724/7147, Umsatzsteuer-ID: DE219349391
www.sipgate.de - www.sipgate.co.uk
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get the following errors during installation.
### Troubleshooting
#### Reproduction
Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl support.
Then install kamailio 5.8.1 from source with db_redis module
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
37.77 CC (gcc) [M db_redis.so] db_redis_mod.o
37.85 CC (gcc) [M db_redis.so] redis_connection.o
37.90 redis_connection.c: In function 'db_redis_connect':
37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did you mean 'redisContext'?
37.90 129 | redisSSLContext *ssl = NULL;
37.90 | ^~~~~~~~~~~~~~~
37.90 | redisContext
37.90 redis_connection.c:166:17: warning: implicit declaration of function 'redisInitOpenSSL' [-Wimplicit-function-declaration]
37.90 166 | redisInitOpenSSL();
37.90 | ^~~~~~~~~~~~~~~~
37.90 redis_connection.c:167:23: warning: implicit declaration of function 'redisCreateSSLContext' [-Wimplicit-function-declaration]
37.90 167 | ssl = redisCreateSSLContext(
37.90 | ^~~~~~~~~~~~~~~~~~~~~
37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
37.90 167 | ssl = redisCreateSSLContext(
37.90 | ^
37.91 redis_connection.c:196:17: warning: implicit declaration of function 'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? [-Wimplicit-function-declaration]
37.91 196 | redisClusterSetOptionEnableSSL(con->con, ssl);
37.91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
37.91 | redisClusterSetOptionMaxRetry
37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1
37.93 make[1]: *** [Makefile:508: modules] Error 1
37.93 make[1]: Leaving directory '/root/build/kamailio/src'
37.93 make: *** [Makefile:34: all] Error 2
```
### Additional Information
* **Kamailio Version**:
```
Kamailio 5.8.1
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Debian 12
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3893
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3893(a)github.com>
[View Less]
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/…
[View More]lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
Tried to verify a dubious JWT, but I get a token decoding error. I tried different variations of the key, such as `.pem`, `.key` extensions, `PKCS1`, `PKCS8` formats, reading the key from a variable or file.
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
Have the following Kamailio config:
```
loadmodule "jwt.so"
...
modparam("jwt", "key_mode", 0)
....
$var(authorization_header_value) = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiYmQ1NzlhZTYyZjg2ODE5N2I5OTk1YTFkOWM4NGZkOGFiNWIyYWI4Nzk5YzM0OWVmYjBkNjg1NWFiNDcwYWUzOTYyMzFmYzc5NjIxZDQxODciLCJpYXQiOjE3MjkxODU3MTguNjQxMjI1LCJuYmYiOjE3MjkxODU3MTguNjQxMjI";
$var(jwt_verification) = jwt_verify("/etc/kamailio/oauth_pub.pem", "RS256",
"sub='$fU'",
"$var(authorization_header_value)"
);
...
```
oauth_pub.pem:
```
-----BEGIN PUBLIC KEY-----
MIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA5mfAgdn7JaiRS2Bsov4S
zTlGLSe2wxbdUxIreTcqs88PmWOBtuSeQg5tU3CRnPtsuuRJrlUniV5g56YAHrnt
Qe8meu877iTrcJB6Cii3n+d7SgwCfjMvaFBR+mdGsidAyGBpRhoPrH7SD6CRpBLr
Mxylcgqw4uH/0HdF+B8P5motUQz/tul/UKsq1nvC2AOOzFel1IsUah8dQuxzMx+P
RYcsngJam8TkGr6QidTXc2rD4lEoCD1s/huGUq55bc19J3yRliN2j8cO9j1bGTsp
GYEVtA3PiH/73BZTa3FHbhRYqhvjYacC8eWBFhwThC9CgPyOXrq4L7p9tJAlNwmd
dQHhIzZ9vugQuhfnuUTb0/r2tjpsSPL7etgJdxtZ4Xh9aBEpYn//RAgu5Dkauc2S
XF+uLWwBptFTM3SNppDPMdjRkYakWjVP2pgBGMmrINFb8RQAPEJzD1gVt0fYCxaY
jiazbSc9FPfSbFENHq+r8D7OivpiW0q9+tSZbYmAFzZekoUAoboQThSdRcOy9tFz
196xfg4dOyxkRGGHstz28qBv340ppjnHQd+RZOvbr8s2zEIxGiOpfX8CuLur/nKl
Ld3qtzg0caqDz6nsYK+95rExnbtU+gFcHnwtMdk3R8X6lVHzDeTjO2Nk4Zo023zo
qFH/rRyJBOp98fQPOpx5qncCAwEAAQ==
-----END PUBLIC KEY-----
```
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
```
(paste your debugging data here)
```
-->
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
[jwt_mod.c:501]: ki_jwt_verify_key(): failed to decode jwt value
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
```
(paste your sip traffic here)
```
-->
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
I've wrote a C++ program using `libjwt` to make sure the issue is not neither my key, nor `libjwt`. And they aren't. Here is the program:
```cpp
#include <iostream>
#include <string>
#include <jwt.h>
static const char jwt_test[] = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiZDY2NDQ4MTdhYWRhNTQ1MDI1YmUwZmU1M2I1ZmFhYTdkZGI3NTY5NTBiMDYxMzk5MzFmNTQ1ZjhkMmE4N2ZhYjU0ODgzNjJhZGNiMWQ5ZTkiLCJpYXQiOjE3MjkyMjg5NjIuMzg5MDI3LCJuYmYiOjE3MjkyMjg5NjIuMzg5MDMzLCJleHAiOjE3MjkyNzIxNjIuMzc5MTg3LCJzdWIiOiIxNDQ0ODEiLCJzY29wZXMiOltdLCJ1c2VyIjp7ImlkIjoxNDQ0ODEsImFjY291bnRfaWQiOjEyOTMyNn0sIm1veHRyYS10b2tlbiI6Ik1WUXpNekZVTU1hdlFET2hNVlNabEdRZ1ptQUNPRmNGU1JKZEVGNGZTQTFFRWxJLVVCMTRkREZVTVZkbFkxY0xjaHhrWkhrU1pnVjVERUppQ0dKSEJWZGxYQTFMQmwwYUF4MUdHbHdkX0RmbHhORGRNMXMzOXlabjhMMEV5USIsImRldmljZSI6eyJpZCI6ImY4MzI0NDkyLWJiYjQtNGJiNC04ZWQxLWZlMTM1OWQwOTNlNSIsInR5cGUiOiJ3ZWIiLCJ2ZXJzaW9uIjoiMS43LjAifX0.E_6jsC7yxPZgHRry55J0oOBzw25tvlfnWRBqSwLVFeAtavkVrYGmH9BGaByaAhebKNijy2WUg1X8Ug0N9Z9cc3P8u2wDSlvlzTNrxnPqdxMrKtP5wiIbImXboobFqKXLRmbor_9I7r0lBlX-e0xSis-PTaBqH40hDYPj0rR5cqnrszSkEMd2jFdiLL5BoF0pqysvrXA631KKA9oHGzAivib_GOddHeUOAVs7-hMVdnDqgrzZ6lDYkQndutrHpwILZWz09ngJBbRh_mN_cE4dDxghgeSotXADT-h5DlokV8ChkgkmHh6m4gU2lvnb7aY9dbCp9R44T1Rpz1P_HhPQ27p1Sgin40Oc2abBwDePw_chl0ajJHuhJCiK7YHbcmzcv3dZ-igVMYpMqhGIlyyuAHCSrKFVFLhodA1xlyCmMqJfFPOZ6DdKzbAQDWPN2xsCMy7WkGT5KmBQR5wWJRIRbTj4OUWo6iUrQdNyjB0F1RKqkuZlz414Hj0tkS5GlS1rfxOtS4yc2m_ERGomSmpDgoq2zpA5o3oJJWXqA7TzT8X_9Up5DkVQCMGW6Z2OT9Sr8hNjIXB1qgYiiZtNf9_b4bma5JEwVvR2-qcZ92V6owFTYx78smdyOgAaMlBQ_9AM6kARz4ZnC3Mz2feJT2qKLP-z9senqIB8k_xNx2lbU2w";
static unsigned char key[16384];
static size_t key_len;
static void read_key(const char *key_file)
{
FILE *fp = fopen(key_file, "r");
int ret = 0;
fp = fopen(key_file, "r");
key_len = fread(key, 1, sizeof(key), fp);
fclose(fp);
key[key_len] = '\0';
}
int main()
{
jwt_t *jwt = NULL;
int ret = 0;
read_key("oauth_pub.pem");
ret = jwt_decode(&jwt, jwt_test, key, key_len);
printf("Decoding exit status: %d\n", ret);
printf("User ID: %s\n", jwt_get_grant(jwt, "sub"));
return 0;
}
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.2 (x86_64/linux) 3fa5f4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 3fa5f4
compiled on 10:39:56 Jun 12 2024 with gcc 8.5.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Rocky Linux 8.10 (Green Obsidian)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4003
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4003(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
don't reinvent the wheel and just use core macro
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4004
-- Commit Summary --
* rtpengine: use core STR_EQ macro
-- File Changes --
M src/modules/rtpengine/rtpengine.c (11)
M src/modules/rtpengine/rtpengine_hash.c (34)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4004.patchhttps://github.com/kamailio/kamailio/pull/4004.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4004
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4004(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
In case of Emergency-Registrations the S-CSCF was wrongly setting the expires of the `;sos` contacts to `em_min_expires` if they were above `em_max_expires`.
Other smaller related fixes:
- Fixed also another typo in the config params definition.
- Added some code to more easily make sense of which attributes of a struct are set with what.
- Added conditions to respect the parameter documentation which indicate that if set to 0, the expires conditions won't be used.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3989
-- Commit Summary --
* ims_registrar_scscf: fixing em_max_expires
-- File Changes --
M src/modules/ims_registrar_scscf/config.c (26)
M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2)
M src/modules/ims_registrar_scscf/save.c (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3989.patchhttps://github.com/kamailio/kamailio/pull/3989.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3989
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3989(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3876
#### Description
<!-- Describe your changes in detail -->
This PR add the schemas for the table needed for the module ims-icscf
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3991
-- Commit Summary --
* Add ims_icscf db schema
-- File Changes --
A src/lib/srdb1/schema/kamailio-ims_icscf.xml (14)
A src/lib/srdb1/schema/nds_trusted_domains.xml (41)
A src/lib/srdb1/schema/s_cscf.xml (49)
A src/lib/srdb1/schema/s_cscf_capabilities.xml (58)
M utils/kamctl/kamdbctl.base (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3991.patchhttps://github.com/kamailio/kamailio/pull/3991.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3991
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3991(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #3297
#### Description
<!-- Describe your changes in detail -->
The setup is a kamailio with no available rtpengine. (e.g. has a list with rtpengine urls but those are not reachable)
Recently had a crash similar to #3297, but in an outdated kamailio version (5.5.7). Tried to reproduce this in 5.5.7 and 5.8.3 but could not crash any of them. However I managed to get the logs similar to ones right before the crash happened:
```
2024-10-04T17:39:58.026206+03:00 kamailio[450237]: ERROR: {1 1 INVITE 203-450290(a)192.168.100.93} <core> [core/action.c:1595]: run_actions(): alert - action [corefunc (16)] cfg [/home/stefan/kamailio.cfg:625] took too long [29310906 us]
```
...directly related to how much rtpengine_manage() function took to execute. So routing of SIP is delayed by that ammount.
Tracked this in code, down to where this lock is get, when "aggressive_redetection" modparam is enabled: https://github.com/kamailio/kamailio/blob/66fe6eb71e58a02222d1a2fb00f9a0cdb…
I will double check that part of the code, since I don't think a lock get is necessary. It only updates a value inside a node, inside the list of nodes, but not changes the list links at all. (this in another PR)
For now I propose to disable this aggressive_redetection mechanism by default. Since it delays the SIP routing logic when no rtpengines available (and in some cases lead to crashes in transaction module).
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3992
-- Commit Summary --
* rtpengine: disable aggressive redetection by default
-- File Changes --
M src/modules/rtpengine/config.c (2)
M src/modules/rtpengine/doc/rtpengine_admin.xml (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3992.patchhttps://github.com/kamailio/kamailio/pull/3992.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3992
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3992(a)github.com>
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
- Enable `app_python3s` module to build with Free Threading CPython builds
- Can be gated with `-DKSR_PYTHON_DISABLE_FREETHREADING`
- If Python is a non-free-threading build this change has no effect
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3987
-- Commit Summary --
* app_python3s: initial support for free-threading Python
-- File Changes --
M src/modules/app_python3s/apy3s_kemi.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3987.patchhttps://github.com/kamailio/kamailio/pull/3987.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3987
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3987(a)github.com>
[View Less]
Running compiled Kamailio 5.8.1 (previously 5.8.0) on Debian 12 64-bit
We're seeing an issue with UDP endpoints (this issue does not happen with TCP and TLS) where usrloc will not send OPTIONS packet keepalives.
Here are all of our usrloc parameters:
modparam("usrloc", "db_mode", 0)
modparam("usrloc", "ka_domain", "SIPDOMAIN") #-- SIPDOMAIN is a fqdn
modparam("usrloc", "ka_from", "sip:proxy-ping@SIPDOMAIN")
modparam("usrloc", "ka_mode", 1)
modparam("usrloc", "timer_interval", 20) #-- How …
[View More]often to qualify endpoints and clean mem tables?
modparam("usrloc", "timer_procs", 4)
modparam("usrloc", "ka_randomize", 10)
modparam("usrloc", "use_domain", 0)
modparam("usrloc", "server_id_filter", 1)
modparam("usrloc", "ka_filter", 0)
modparam("usrloc", "ka_timeout", 60) #-- How quickly to expire a contact if it does not reply to keepalive?
modparam("usrloc", "matching_mode", 0)
modparam("usrloc", "handle_lost_tcp", 1)
modparam("usrloc", "close_expired_tcp", 1)
modparam("usrloc", "desc_time_order", 1)
modparam("usrloc", "hash_size", 14)
It seems usrloc is not actually using timer_interval at all for UDP devices. However, it does seem to be sending OPTIONS every 20 seconds on TCP/TLS. (this is confirmed via packet capture on a SIP phone).
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3844
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3844(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: cce29af41120cf30c4c22979e772d1ca666408c6
URL: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-10-16T11:46:37+02:00
async: docs updates for async_sleep()
---
Modified: src/modules/async/doc/async_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]cce29af41120cf30c4c22979e772d1c…
Patch: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c…
---
diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml
index 027cea11ed7..152c6be5db7 100644
--- a/src/modules/async/doc/async_admin.xml
+++ b/src/modules/async/doc/async_admin.xml
@@ -234,8 +234,11 @@ route[RESUME] {
</title>
<para>
Simulate a sleep of 'seconds' and then continue the processing of SIP
- request with the next action. In case of internal errors, the function
- returns false.
+ request with the next action. Note that the processing continues till
+ the last action in the current route block. Consider using async_route()
+ instead if you want to control better what is executed after the wait
+ time. Beacuse the execution is resumed in another process, do not use
+ private memory variables before and after the async sleep.
</para>
<para>
The sleep parameter represent the number of seconds to suspend the
@@ -243,6 +246,9 @@ route[RESUME] {
a static integer or a variable holding an integer.
</para>
<para>
+ In case of internal errors, the function returns false.
+ </para>
+ <para>
This function can be used from REQUEST_ROUTE.
</para>
<example>
@@ -262,15 +268,13 @@ exit;
<function moreinfo="none">async_ms_sleep(milliseconds)</function>
</title>
<para>
- Simulate a sleep of 'milliseconds' and then continue the processing of SIP
- request with the next action. In case of internal errors, the function
- returns false.
- This function works only if the ms_timer parameter has a value greater than 0.
+ Similar to async_sleep(), but with a 'milliseconds' parameter. This
+ function works only if the ms_timer parameter has a value greater than 0.
</para>
<para>
The sleep parameter represent the number of milliseconds to suspend the
- processing of SIP request. Maximum value is 30000 (30 sec). The parameter can be
- a static integer or a variable holding an integer.
+ processing of SIP request. Maximum value is 30000 (30 sec). The parameter
+ can be a static integer or a variable holding an integer.
</para>
<para>
This function can be used from REQUEST_ROUTE.
[View Less]
Module: kamailio
Branch: master
Commit: e18c52030e202716df9f5e8e953c19fb4a9c65e2
URL: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-10-16T11:05:04+02:00
tls: docs - relocate overview notes to Important Notes section
---
Modified: src/modules/tls/doc/tls.xml
---
Diff: https://github.com/kamailio/kamailio/commit/…
[View More]e18c52030e202716df9f5e8e953c19f…
Patch: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f…
---
diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml
index 3a0416fed61..53397e2d50a 100644
--- a/src/modules/tls/doc/tls.xml
+++ b/src/modules/tls/doc/tls.xml
@@ -60,27 +60,9 @@
must be added to the Kamailio config file.
</para>
<para>
- IMPORTANT: the tls module must be loaded before any other &kamailio; module
- that uses libssl (OpenSSL library). A safe option is to have the tls module
- loaded first (be in the first "loadmodule" in &kamailio;.cfg).
- </para>
- <para>
- IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode"
- has to be set, see the Core Cookbook for possible values.
- </para>
- <para>
- IMPORTANT: using this module compiled with newer versions of libssl
- (e.g., v1.1+) may require &kamailio; to be started with
- <emphasis>--atexit=no</emphasis> command line parameters to avoid
- calling C atexit callbacks inside the process ending during
- daemonize procedure as well as during shut down, which can lead
- to crashes because it destroys and then accesses shared memory. For
- example, such case has been reported for Ubuntu 20.04 or RedHat 8.
- </para>
- <para>
- Note: with some particular combination of OS, openssl and mysql-client
- libraries, there were reports of random crashes, in such case try to set
- the db_mysql module parameter opt_ssl_mode to 1.
+ Read the "Important Notes" section because it has relevant information
+ about configuring properly the module for various libssl versions,
+ components and operating systems.
</para>
</section>
<section id="tls.quick_start">
@@ -134,7 +116,7 @@ request_route {
<para>
The TLS module needs some special options enabled when compiling
Kamailio. These options are enabled by default, however in case
- you're using a modified Kamailio version or Makefile, make sure
+ you are using a modified Kamailio version or Makefile, make sure
that you enable -DUSE_TLS and -DTLS_HOOKS (or compile with make
TLS_HOOKS=1 which will take care of both options).
</para>
@@ -188,6 +170,29 @@ request_route {
</itemizedlist>
The bug reports can be viewed at <ulink url="http://rt.openssl.org/">http://rt.openssl.org/</ulink>.
</para>
+ <para>
+ Note 1: the tls module must be loaded before any other &kamailio; module
+ that uses libssl (OpenSSL library). A safe option is to have the tls module
+ loaded first (be in the first "loadmodule" in &kamailio;.cfg).
+ </para>
+ <para>
+ Note 2: for libssl v3.x, the core parameter "tls_threads_mode"
+ has to be set, see the Core Cookbook for possible values.
+ </para>
+ <para>
+ Note 3: using this module compiled with newer versions of libssl
+ (e.g., v1.1+) may require &kamailio; to be started with
+ <emphasis>--atexit=no</emphasis> command line parameters to avoid
+ calling C atexit callbacks inside the process ending during
+ daemonize procedure as well as during shut down, which can lead
+ to crashes because it destroys and then accesses shared memory. For
+ example, such case has been reported for Ubuntu 20.04 or RedHat 8.
+ </para>
+ <para>
+ Note 4: with some particular combination of OS, openssl and mysql-client
+ libraries, there were reports of random crashes, in such case try to set
+ the db_mysql module parameter opt_ssl_mode to 1.
+ </para>
</section>
[View Less]
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature …
[View More](non-breaking change which adds new functionality)
- [x] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3929
#### Description
The handling of the buffer and pointers in the siputils/chargingvector.c module was inconsistent and led to writing directly in the sip msg buffer, which resulted in the destruction of the SIP message as reported in the issue. During the testing more cases showed up where the PCV handling became ugly and inconsistent, especially in fault scenarios. Therefore more parts have been rewritten to account for those scenarios.
The $pcv(status) pseudo-variable has been added to reflect the state of the P-Charging-Vector in the message, whether it was parsed, had errors (no body or no icid-value), has been deleted or if none is there.
The sip_p_charging_vector() function returns a status value of what it has done, or if it was a no-op call.
A present PCV can only be generated once by the module, either after an explicit deletion or by a forced replacement. After that the call returns with no-op.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3994
-- Commit Summary --
* siputils: bug fix for sip_p_charging_vector
* siputils/doc: updated pcv documentation [skip ci]
-- File Changes --
M src/modules/siputils/chargingvector.c (346)
M src/modules/siputils/doc/siputils.xml (8)
M src/modules/siputils/doc/siputils_admin.xml (50)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3994.patchhttps://github.com/kamailio/kamailio/pull/3994.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3994
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3994(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: d7c8bc5c58f672004894733d0e6d2a7cb00efe7a
URL: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7…
Author: Eik Rentzow <rentzow(a)gmx.de>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-10-15T13:48:35+02:00
siputils: bug fix for sip_p_charging_vector
- Bug fix for #3929 and further improvements.
- New buffer usage for P-Charging-Vector handling.
- Added $pcv(status) pseudo-var.
- Added return …
[View More]values for sip_p_charging_vector().
- Much improved error case handling.
- Use send interface for icid-genearted-at:
The icid-generated-at parameter should carry the ip adress of the
egress interface and not of the interface where the message was received.
This is in accordance with other SBC solutions.
---
Modified: src/modules/siputils/chargingvector.c
---
Diff: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7…
Patch: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7…
[View Less]
Hi all,
I’d like to bring up some development topics related to the SIP parsing logic, specifically when handling sip: with embedded tel URIs scheme. The current behaviour, particularly when user=phone is present, is leading to some inconsistencies and potential confusion, and I believe it might require some refactoring or documentation updates.
Current Parsing Behavior:
When a tel: URI is embedded in a sip: scheme (e.g., user=phone is present), the parser currently copies the URI parsed …
[View More]parameters to sip_params, then splits the user part (like 123;param=value;param2=value2) into user and all the rest tel parameters to params. This behaviour is only triggered when the global phone2tel configuration option is enabled (which is the default).
Issues:
1. Inconsistent Handling of URI Parameters
There’s no consistency across modules on whether they use sip_params or params to get the URI parameters. While most modules correctly use sip_params, others use params. Normally, this works fine because sip_params and params hold the same data when user=phone is not present or phone2tel is disabled. However, when user=phone is present and phone2tel is enabled, params may be empty, leading to unexpected behavior in modules relying on it.
For example, the following modules are using params and many others:
* dmqnode.c (line 204)<https://github.com/kamailio/kamailio/blob/ba6ab04e06b0dfd66874749e0cb1225f2…>
* notification_peer.c (line 432)<https://github.com/kamailio/kamailio/blob/ba6ab04e06b0dfd66874749e0cb1225f2…>
While some may handle the differences between sip_params and params, not all of them do.
2. Unclear Intention of the phone2tel Global Parameter
The current parser code is quite old, and it’s unclear what the original intention behind the phone2tel global parameter was. As far as I understand, the sip: scheme can handle tel: URIs, and this is the most widely accepted specification. The role of phone2tel seems to blur the lines between the two schemes, leading to unexpected transformations.
Example of Unexpected Behavior:
Consider the following header:
P-Asserted-Identity: Display <sip:+1234;pname=pval@domain;user=phone>;tag=1234
If we apply the {tobody.user} transformation, the expected output should be the user part of the URI. Based on the RFC, we expected the transformation to return +1234;pname=pval. However, due to the phone2tel global configuration parameter, the parser treats it as a tel: scheme and returns only +1234. This behavior seems to be influenced by how the global parameter forces the parser to handle the URI.
Proposal:
To resolve these issues, I suggest the following:
1. Refactor Parameter Handling: Introduce a more explicit separation of tel_params and sip_params, and ensure all modules use the correct set of parameters based on the context. This would help enforce consistency across the codebase.
2. Update Documentation: Provide clear documentation regarding the behavior of phone2tel and how it impacts URI parsing. In particular, the transformation documentation should reflect the expected behavior depending on whether the URI is treated as sip: or tel:.
3. Review and Fix Modules: We should audit the modules that currently rely on params and ensure they are using sip_params where appropriate, especially in cases where user=phone could be present.
Any guidance or feedback on these points would be greatly appreciated. If you’ve encountered any related bugs or discovered other edge cases, please let me know so we can address them.
Best regards,
Xenofon
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
If the query failed, the result set should not be parsed and used. This results in an empty result set which will most likely lead to unwanted behavior.
Background: While troubleshooting, we detected that domain.reload actually replaces domains with an empty result set if mongodb connectivity fails.
```
DEBUG: db_mongodb [mongodb_dbase.c:849]: db_mongodb_store_result(): An error occurred: No suitable servers found (`serverSelectionTryOnce` set): [connection timeout calling ismaster on 'pdb-iop1-wrmg-2:27017'] [connection timeout calling ismaster on 'pdb-iop1-wrmg-1:27017']
DEBUG: domain [domain.c:365]: reload_tables(): number of rows in domain_attrs table: 0
DEBUG: <core> [db_res.c:79]: db_free_columns(): freeing 0 columns
DEBUG: <core> [db_res.c:138]: db_free_result(): freeing result set at 0x7fb0c9811848
DEBUG: db_mongodb [mongodb_dbase.c:973]: db_mongodb_query(): query to collection [domains]
DEBUG: db_mongodb [mongodb_dbase.c:1007]: db_mongodb_query(): query filter: { }
DEBUG: db_mongodb [mongodb_dbase.c:1043]: db_mongodb_query(): columns filter: { "projection" : { "domain" : 1, "did" : 1 } }
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3996
-- Commit Summary --
* mongodb: fix cursor error resulting empty result set
-- File Changes --
M src/modules/db_mongodb/mongodb_dbase.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3996.patchhttps://github.com/kamailio/kamailio/pull/3996.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3996
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3996(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: 2737bb19a363be7c0d67749b75f11c7e9d2d09f3
URL: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-10-08T15:03:55+02:00
http_async_client: fix warning deprecated-non-prototype
> Warning: ./http_multi.h:64:5: warning: a function declaration without a prototype is deprecated in all …
[View More]versions of C and is treated as a zero-parameter prototype in C23, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
> 64 | int init_http_multi();
> | ^
> http_multi.c:403:5: note: conflicting prototype is here
> 403 | int init_http_multi(struct event_base *evbase, struct http_m_global *wg)
> | ^
> 1 warning generated.
---
Modified: src/modules/http_async_client/http_multi.h
---
Diff: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7…
Patch: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7…
---
diff --git a/src/modules/http_async_client/http_multi.h b/src/modules/http_async_client/http_multi.h
index 0f35a722306..8e3676b3ed1 100644
--- a/src/modules/http_async_client/http_multi.h
+++ b/src/modules/http_async_client/http_multi.h
@@ -61,7 +61,7 @@ extern int curl_verbose;
extern int curl_follow_redirect;
void set_curl_mem_callbacks(void);
-int init_http_multi();
+int init_http_multi(struct event_base *evbase, struct http_m_global *wg);
int multi_timer_cb(CURLM *multi, long timeout_ms, struct http_m_global *g);
void timer_cb(int fd, short kind, void *userp);
int sock_cb(CURL *e, curl_socket_t s, int what, void *cbp, void *sockp);
[View Less]