sr-dev

sr-dev@lists.kamailio.org

17 participants
45415 discussions

[kamailio/kamailio] Typo in mtops.h/.c: inconsistent function name ksr_sigsem_xfree / ksr_sigsem_sfree (Issue #4340)
by acroitor 25 Jul '25

25 Jul '25

acroitor created an issue (kamailio/kamailio#4340)  ### Description With kamailio built from latest sources from master, it fails to start if sipdump module is added to kamailio.cfg  ### Troubleshooting #### Reproduction  Start Kamailio with <loadmodule "sipdump.so"> in kamailio.cfg #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages kamailio[301309]: ERROR: <core> [core/sr_module.c:613]: ksr_load_module(): could not open module </usr/lib/x86_64-linux-gnu/kamailio/modules/sipdump.so>: /usr/lib/x86_64-linux-gnu/kamailio/modules/sipdump.so: undefined symbol: ksr_sigsem_xfree kamailio[301309]: CRITICAL: <core> [core/cfg.y:4086]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 161, column 12-23: failed to load module  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4340 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4340(a)github.com>

2 3

git:master:57fa2bd9: core: fix name for ksr_sigsem_xfree()
by Daniel-Constantin Mierla 25 Jul '25

25 Jul '25

Module: kamailio Branch: master Commit: 57fa2bd95766a5b72d768617ff931224ee72d1fa URL: https://github.com/kamailio/kamailio/commit/57fa2bd95766a5b72d768617ff93122… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-25T15:34:03+02:00 core: fix name for ksr_sigsem_xfree() - GH #4340 --- Modified: src/core/utils/mtops.c --- Diff: https://github.com/kamailio/kamailio/commit/57fa2bd95766a5b72d768617ff93122… Patch: https://github.com/kamailio/kamailio/commit/57fa2bd95766a5b72d768617ff93122… --- diff --git a/src/core/utils/mtops.c b/src/core/utils/mtops.c index 9c5de7801dc..faad2f6cc0e 100644 --- a/src/core/utils/mtops.c +++ b/src/core/utils/mtops.c @@ -150,7 +150,7 @@ void ksr_sigsem_free(ksr_sigsem_t *sgs) /** * */ -void ksr_sigsem_sfree(ksr_sigsem_t *sgs) +void ksr_sigsem_xfree(ksr_sigsem_t *sgs) { pthread_cond_destroy(&sgs->cnd); pthread_mutex_destroy(&sgs->mtx);

1 0

git:master:78374026: core: make the pointer to the list of loaded modules static
by Daniel-Constantin Mierla 25 Jul '25

25 Jul '25

Module: kamailio Branch: master Commit: 783740267e59d5ed38f49cf7bb9dfeec80a88af6 URL: https://github.com/kamailio/kamailio/commit/783740267e59d5ed38f49cf7bb9dfee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-25T14:45:27+02:00 core: make the pointer to the list of loaded modules static --- Modified: src/core/modparam.c Modified: src/core/sr_module.c Modified: src/core/sr_module.h --- Diff: https://github.com/kamailio/kamailio/commit/783740267e59d5ed38f49cf7bb9dfee… Patch: https://github.com/kamailio/kamailio/commit/783740267e59d5ed38f49cf7bb9dfee…

1 0

[kamailio/kamailio] tls_tracker: added module for tls encriptions key export (PR #4339)
by sergey-safarov 25 Jul '25

25 Jul '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added TLS encryption keys export into the database. Later keys can be searched and saved to a file. Key search can be done by timestamp, connection IP addresses, and port numbers. For key search, used kamcmd utility. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4339 -- Commit Summary -- * tls_tracker: added module for tls encriptions key export -- File Changes -- A src/modules/tls_tracker/Makefile (75) A src/modules/tls_tracker/README (1) A src/modules/tls_tracker/api.c (33) A src/modules/tls_tracker/api.h (40) A src/modules/tls_tracker/doc/Makefile (4) A src/modules/tls_tracker/doc/tls_tracker.xml (117) A src/modules/tls_tracker/tls_tracker_mod.c (1126) A src/modules/tls_tracker/tls_tracker_mod.h (25) A src/modules/tls_tracker/tls_tracker_rpc.c (478) A src/modules/tls_tracker/tls_tracker_rpc.h (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4339.patch https://github.com/kamailio/kamailio/pull/4339.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4339 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4339(a)github.com>

3 8

git:master:d3471d94: modules: readme files regenerated - tls ... [skip ci]
by Kamailio Dev 25 Jul '25

25 Jul '25

Module: kamailio Branch: master Commit: d3471d9428973843a55ae71fbe92e7ae87014955 URL: https://github.com/kamailio/kamailio/commit/d3471d9428973843a55ae71fbe92e7a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-07-25T11:46:10+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/d3471d9428973843a55ae71fbe92e7a… Patch: https://github.com/kamailio/kamailio/commit/d3471d9428973843a55ae71fbe92e7a… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index 87b3938f7e8..eb27eee6036 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -1671,6 +1671,14 @@ verify_client = optional_no_ca * 4 (bit 3) - write keys to NOTICE log * 8 (bit 4) - write keys to file * 16 (bit 5) - send keys to udp peer + * 1024 (bit 11) - enable filtering of keys logging. When set, + filtering is done on: "CLIENT_RANDOM", + "CLIENT_HANDSHAKE_TRAFFIC_SECRET", + "SERVER_HANDSHAKE_TRAFFIC_SECRET", "EXPORTER_SECRET", + "CLIENT_TRAFFIC_SECRET_0", "SERVER_TRAFFIC_SECRET_0" + + Bit position is the index starting from 1 (practically a non-zero value + is (2 power (bitpos - 1)) ). The default value: 0.

1 0

git:master:9d7cb360: tls: docs for filtering option for keylog_mode
by Daniel-Constantin Mierla 25 Jul '25

25 Jul '25

Module: kamailio Branch: master Commit: 9d7cb3605a602d5c6ce6f66b6c0b78adeaba2063 URL: https://github.com/kamailio/kamailio/commit/9d7cb3605a602d5c6ce6f66b6c0b78a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-25T11:40:17+02:00 tls: docs for filtering option for keylog_mode --- Modified: src/modules/tls/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/9d7cb3605a602d5c6ce6f66b6c0b78a… Patch: https://github.com/kamailio/kamailio/commit/9d7cb3605a602d5c6ce6f66b6c0b78a… --- diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml index bacd5848f99..a39891f3840 100644 --- a/src/modules/tls/doc/params.xml +++ b/src/modules/tls/doc/params.xml @@ -1532,7 +1532,18 @@ verify_client = optional_no_ca <listitem> <para><emphasis>16 (bit 5)</emphasis> - send keys to udp peer</para> </listitem> + <listitem> + <para><emphasis>1024 (bit 11)</emphasis> - enable filtering of + keys logging. When set, filtering is done on: "CLIENT_RANDOM", + "CLIENT_HANDSHAKE_TRAFFIC_SECRET", "SERVER_HANDSHAKE_TRAFFIC_SECRET", + "EXPORTER_SECRET", "CLIENT_TRAFFIC_SECRET_0", "SERVER_TRAFFIC_SECRET_0" + </para> + </listitem> </itemizedlist> + <para> + Bit position is the index starting from 1 (practically a non-zero value + is (2 power (bitpos - 1)) ). + </para> <para> The default value: 0. </para>

1 0

git:master:254d5bd6: tls: added option to filter key logging
by Daniel-Constantin Mierla 25 Jul '25

25 Jul '25

Module: kamailio Branch: master Commit: 254d5bd652e1eb35772375d930786ee5489cebab URL: https://github.com/kamailio/kamailio/commit/254d5bd652e1eb35772375d930786ee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-25T11:40:17+02:00 tls: added option to filter key logging --- Modified: src/modules/tls/tls_domain.c Modified: src/modules/tls/tls_util.c Modified: src/modules/tls/tls_util.h --- Diff: https://github.com/kamailio/kamailio/commit/254d5bd652e1eb35772375d930786ee… Patch: https://github.com/kamailio/kamailio/commit/254d5bd652e1eb35772375d930786ee… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index e6dbd60b502..4e2e5e76ede 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1094,6 +1094,11 @@ static void ksr_tls_keylog_callback(const SSL *ssl, const char *line) if(!(ksr_tls_keylog_mode & KSR_TLS_KEYLOG_MODE_ACTIVE)) { return; } + if(ksr_tls_keylog_mode & KSR_TLS_KEYLOG_MODE_VFILTER) { + if(ksr_tls_keylog_vfilter_match(line) == 0) { + return; + } + } if(ksr_tls_keylog_mode & KSR_TLS_KEYLOG_MODE_MLOG) { LM_NOTICE("tlskeylog: %s\n", line); } diff --git a/src/modules/tls/tls_util.c b/src/modules/tls/tls_util.c index 7f35540c29d..01f2a0544e4 100644 --- a/src/modules/tls/tls_util.c +++ b/src/modules/tls/tls_util.c @@ -152,6 +152,36 @@ int ksr_tls_keylog_file_init(void) return 0; } +/** + * + */ +/* clang-format off */ +static const char *ksr_tls_keylog_vfilters[] = { + "CLIENT_RANDOM ", + "CLIENT_HANDSHAKE_TRAFFIC_SECRET ", + "SERVER_HANDSHAKE_TRAFFIC_SECRET ", + "EXPORTER_SECRET ", + "CLIENT_TRAFFIC_SECRET_0 ", + "SERVER_TRAFFIC_SECRET_0 ", + NULL +}; +/* clang-format on */ + +/** + * + */ +int ksr_tls_keylog_vfilter_match(const char *line) +{ + int i; + + for(i = 0; ksr_tls_keylog_vfilters[i] != NULL; i++) { + if(strcasecmp(ksr_tls_keylog_vfilters[i], line) == 0) { + return 1; + } + } + return 0; +} + /** * */ diff --git a/src/modules/tls/tls_util.h b/src/modules/tls/tls_util.h index fde753e64d6..1b6be69383c 100644 --- a/src/modules/tls/tls_util.h +++ b/src/modules/tls/tls_util.h @@ -37,6 +37,7 @@ #define KSR_TLS_KEYLOG_MODE_MLOG (1 << 2) #define KSR_TLS_KEYLOG_MODE_FILE (1 << 3) #define KSR_TLS_KEYLOG_MODE_PEER (1 << 4) +#define KSR_TLS_KEYLOG_MODE_VFILTER (1 << 10) static inline int tls_err_ret( char *s, SSL *ssl, tls_domains_cfg_t **tls_domains_cfg) @@ -94,5 +95,6 @@ int ksr_tls_keylog_file_init(void); int ksr_tls_keylog_file_write(const SSL *ssl, const char *line); int ksr_tls_keylog_peer_init(void); int ksr_tls_keylog_peer_send(const SSL *ssl, const char *line); +int ksr_tls_keylog_vfilter_match(const char *line); #endif /* _TLS_UTIL_H */

1 0

[kamailio/kamailio] github actions packages cleanup troubleshooting (Issue #4282)
by sergey-safarov 25 Jul '25

25 Jul '25

sergey-safarov created an issue (kamailio/kamailio#4282) I have refactored `alpine` image generation. This GitHub action works in a personal repository, but cannot clean up untagged images from the "kamailio" account. Example https://github.com/kamailio/kamailio/actions/runs/15605254192/job/439654377… @linuxmaniac do you have any idea why this can happen? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4282 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4282(a)github.com>

2 1

git:5.8:e3da0839: Makefile: fix dependency of core/cfg.tab.c rule
by Victor Seva 24 Jul '25

24 Jul '25

Module: kamailio Branch: 5.8 Commit: e3da08394e6f3ae89c41c86da419e07670cbc57f URL: https://github.com/kamailio/kamailio/commit/e3da08394e6f3ae89c41c86da419e07… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-24T19:24:52+02:00 Makefile: fix dependency of core/cfg.tab.c rule * don't call bison twice Fix #4337 (cherry picked from commit d3e71874cf39c9ab50af293d647754bb589d0612) (cherry picked from commit 959ccfb762f1643ebfc9a57b12e8e7e0df2e7aba) --- Modified: src/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/e3da08394e6f3ae89c41c86da419e07… Patch: https://github.com/kamailio/kamailio/commit/e3da08394e6f3ae89c41c86da419e07… --- diff --git a/src/Makefile b/src/Makefile index 28106b06852..bdec9afcea3 100644 --- a/src/Makefile +++ b/src/Makefile @@ -260,7 +260,8 @@ $(NAME): $(extra_objs) # static_modules core/lex.yy.c: core/cfg.lex core/cfg.tab.h $(ALLDEP) $(LEX) -o core/lex.yy.c $< -core/cfg.tab.c core/cfg.tab.h: core/cfg.y $(ALLDEP) +core/cfg.tab.c: core/cfg.tab.h +core/cfg.tab.h: core/cfg.y $(ALLDEP) $(YACC) $(YACC_FLAGS) $< nullstring=

1 0

git:6.0:959ccfb7: Makefile: fix dependency of core/cfg.tab.c rule
by Victor Seva 24 Jul '25

24 Jul '25

Module: kamailio Branch: 6.0 Commit: 959ccfb762f1643ebfc9a57b12e8e7e0df2e7aba URL: https://github.com/kamailio/kamailio/commit/959ccfb762f1643ebfc9a57b12e8e7e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-24T19:24:23+02:00 Makefile: fix dependency of core/cfg.tab.c rule * don't call bison twice Fix #4337 (cherry picked from commit d3e71874cf39c9ab50af293d647754bb589d0612) --- Modified: src/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/959ccfb762f1643ebfc9a57b12e8e7e… Patch: https://github.com/kamailio/kamailio/commit/959ccfb762f1643ebfc9a57b12e8e7e… --- diff --git a/src/Makefile b/src/Makefile index 4ba662535bb..744b1e15e1b 100644 --- a/src/Makefile +++ b/src/Makefile @@ -261,7 +261,8 @@ $(NAME): $(extra_objs) # static_modules core/lex.yy.c: core/cfg.lex core/cfg.tab.h $(ALLDEP) $(LEX) -o core/lex.yy.c $< -core/cfg.tab.c core/cfg.tab.h: core/cfg.y $(ALLDEP) +core/cfg.tab.c: core/cfg.tab.h +core/cfg.tab.h: core/cfg.y $(ALLDEP) $(YACC) $(YACC_FLAGS) $< nullstring=

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev