sr-dev

sr-dev@lists.kamailio.org

17 participants
45444 discussions

git:master:55f849f3: uac: break on detecting $uac_req() new attributes
by Daniel-Constantin Mierla 12 Jul '25

12 Jul '25

Module: kamailio Branch: master Commit: 55f849f3192540698a0bdabc9b2bc4d9a7f5bc8f URL: https://github.com/kamailio/kamailio/commit/55f849f3192540698a0bdabc9b2bc4d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-12T12:09:26+02:00 uac: break on detecting $uac_req() new attributes --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/55f849f3192540698a0bdabc9b2bc4d… Patch: https://github.com/kamailio/kamailio/commit/55f849f3192540698a0bdabc9b2bc4d… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index 2513a6989d0..0a0fc0459b3 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -640,11 +640,13 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 19; else goto error; + break; case 14: if(strncmp(in->s, "fr_inv_timeout", 14) == 0) sp->pvp.pvn.u.isname.name.n = 20; else goto error; + break; default: goto error; }

1 0

git:master:34c903a6: dispatcher: check rewrite_uri() return code
by Daniel-Constantin Mierla 12 Jul '25

12 Jul '25

Module: kamailio Branch: master Commit: 34c903a6a4658852bfef0edfb78614b83700a5e9 URL: https://github.com/kamailio/kamailio/commit/34c903a6a4658852bfef0edfb78614b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-12T11:40:12+02:00 dispatcher: check rewrite_uri() return code --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/34c903a6a4658852bfef0edfb78614b… Patch: https://github.com/kamailio/kamailio/commit/34c903a6a4658852bfef0edfb78614b… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 50865a0d1f6..ed7699c8472 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3566,7 +3566,10 @@ static void ds_run_route(sip_msg_t *msg, str *uri, char *route, ds_rctx_t *rctx) return; } fmsg = faked_msg_next(); - rewrite_uri(fmsg, uri); + if(rewrite_uri(fmsg, uri) < 0) { + LM_ERR("failed to set r-uri\n"); + return; + } } else { fmsg = msg; }

1 0

git:master:fd388d7b: tcp: mtops - updated conditions checking proc list
by Daniel-Constantin Mierla 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: fd388d7b9b4dec09eb8df34d18a22c4cd48a3a7a URL: https://github.com/kamailio/kamailio/commit/fd388d7b9b4dec09eb8df34d18a22c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-11T17:59:12+02:00 tcp: mtops - updated conditions checking proc list --- Modified: src/core/tcp_mtops.c --- Diff: https://github.com/kamailio/kamailio/commit/fd388d7b9b4dec09eb8df34d18a22c4… Patch: https://github.com/kamailio/kamailio/commit/fd388d7b9b4dec09eb8df34d18a22c4… --- diff --git a/src/core/tcp_mtops.c b/src/core/tcp_mtops.c index 69a88e5b04b..e21b9667afa 100644 --- a/src/core/tcp_mtops.c +++ b/src/core/tcp_mtops.c @@ -247,7 +247,7 @@ unsigned char *ksr_tcpx_thread_wrbuf(int pidx) */ int ksr_tcpx_proc_list_rank(int rank) { - if(_ksr_tcpx_proc_list != NULL) + if(_ksr_tcpx_proc_list == NULL) return -1; if(process_no >= _ksr_tcpx_proc_list_size) return -1; @@ -263,11 +263,11 @@ int ksr_tcpx_proc_list_rank(int rank) */ int ksr_tcpx_proc_list_destroy(void) { - if(_ksr_tcpx_proc_list != NULL) + if(_ksr_tcpx_proc_list == NULL) return -1; shm_free(_ksr_tcpx_proc_list); - _ksr_tcpx_proc_list = 0; + _ksr_tcpx_proc_list = NULL; _ksr_tcpx_proc_list_size = 0; return 0; }

1 0

Ideas for developer meeting 1: Markdown in docs
by Richard Chan 11 Jul '25

11 Jul '25

Great work kamailio devs in releasing 6.0.2 and the continuing work on master branch. Wishing you a restful weekend and while you are at it, here are some ideas, probably half-baked, for your consideration. Background: Kamailio uses XML for documentation that is followed by an automatic task that renders to plaintext(README file) for the repo and HTML for the website Proposal - Use Markdown for docs/ Author docs/ in Markdown - no rendering in-repo - website will need a static site generator that can create the internal links Benefits - markdown is a common mark-up tool for plaintext that has sufficient semantic richness for kamailio - most developers are familiar with markdown especially from Github, other git-forges - avoids the in-repo rendering step - most git-forges can render the markdown file on-screen so that there is less iteration required if there are typos in xml. It is also easier for the developer to validate their docs prior to pushing to master branch Work Required: - evaluate and implement the static site generator - the in-repo README generator can be slowly phased out Regards Richard (Shih-Ping)

3 2

[kamailio/kamailio] rtpengine hash table dmq replication (PR #4240)
by vlitvinov 11 Jul '25

11 Jul '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding KDMQ replication for rtpengine hash table (call -> rtpengine instance assignment) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4240 -- Commit Summary -- * rtpegnine hash table dmq replication -- File Changes -- M src/modules/rtpengine/rtpengine.c (49) M src/modules/rtpengine/rtpengine.h (4) M src/modules/rtpengine/rtpengine_db.c (2) A src/modules/rtpengine/rtpengine_dmq.c (310) A src/modules/rtpengine/rtpengine_dmq.h (54) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4240.patch https://github.com/kamailio/kamailio/pull/4240.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4240 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4240(a)github.com>

5 12

git:master:b44ddff0: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: b44ddff0eb0e0038d6d712b29d18f079acd2a99c URL: https://github.com/kamailio/kamailio/commit/b44ddff0eb0e0038d6d712b29d18f07… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-07-11T08:46:10+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/b44ddff0eb0e0038d6d712b29d18f07… Patch: https://github.com/kamailio/kamailio/commit/b44ddff0eb0e0038d6d712b29d18f07… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index dde1047ced8..f372785929a 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -3333,9 +3333,10 @@ reply_route { The attributes are in the format "name1=value1;...;nameX=valueX". The name of the attribute can be: - * reply - control how the reply is waited. If not provided, acts like - tm.t_uac_start. The values can be: "wait" - act like tm.t_uac_wait; - "block" - act like tm.t_uac_wait_block. + * mode - control how the command is done. If not provided or the + value is "start", acts like tm.t_uac_start. The other values can + be: "wait" - act like tm.t_uac_wait; "block" - act like + tm.t_uac_wait_block. * cbflags - the transaction callback flags. The values can be: "noack" - to not automatically send ACK for local INVITE requests * rpflags - RPC parameters flags. The values can be: 1 - the body is

1 0

git:master:8957ea9d: tm: docs update for mode values of rpc tm.t_uac_attrs
by Daniel-Constantin Mierla 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: 8957ea9ddba9aaa602b8762c79bfcdf58404fbb8 URL: https://github.com/kamailio/kamailio/commit/8957ea9ddba9aaa602b8762c79bfcdf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-11T08:37:18+02:00 tm: docs update for mode values of rpc tm.t_uac_attrs --- Modified: src/modules/tm/doc/rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/8957ea9ddba9aaa602b8762c79bfcdf… Patch: https://github.com/kamailio/kamailio/commit/8957ea9ddba9aaa602b8762c79bfcdf… --- diff --git a/src/modules/tm/doc/rpc.xml b/src/modules/tm/doc/rpc.xml index 56925d08c52..566d698b0cc 100644 --- a/src/modules/tm/doc/rpc.xml +++ b/src/modules/tm/doc/rpc.xml @@ -188,9 +188,9 @@ <itemizedlist> <listitem><para> <emphasis>mode</emphasis> - control how the command is done. If - not provided, acts like tm.t_uac_start. The values can be: - "wait" - act like tm.t_uac_wait; "block" - act like - tm.t_uac_wait_block. + not provided or the value is "start", acts like tm.t_uac_start. + The other values can be: "wait" - act like tm.t_uac_wait; + "block" - act like tm.t_uac_wait_block. </para></listitem> <listitem><para> <emphasis>cbflags</emphasis> - the transaction callback flags. The

1 0

git:master:9af58986: tm: support mode=start for rpc tm.t_uac_attrs
by Daniel-Constantin Mierla 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: 9af589867e9777a2e3c7203d15750d922d764fd1 URL: https://github.com/kamailio/kamailio/commit/9af589867e9777a2e3c7203d15750d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-11T08:37:18+02:00 tm: support mode=start for rpc tm.t_uac_attrs - complete the variants of t_uac commands --- Modified: src/modules/tm/rpc_uac.c --- Diff: https://github.com/kamailio/kamailio/commit/9af589867e9777a2e3c7203d15750d9… Patch: https://github.com/kamailio/kamailio/commit/9af589867e9777a2e3c7203d15750d9… --- diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 2b43b53c6eb..44f05cd75fd 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -1038,6 +1038,9 @@ void rpc_t_uac_attrs(rpc_t *rpc, void *c) if(pit->body.len == 4 && strncasecmp(pit->name.s, "wait", 4) == 0) { tattrs.reply_wait = 1; + } else if(pit->body.len == 5 + && strncasecmp(pit->name.s, "start", 5) == 0) { + tattrs.reply_wait = 0; } else if(pit->body.len == 5 && strncasecmp(pit->name.s, "block", 5) == 0) { tattrs.reply_wait = 2;

1 0

git:master:d21836a9: tm: docs update of rpc tm.t_uac_attrs for mode attribute
by Daniel-Constantin Mierla 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: d21836a9cbdcab3b420fe31b1d913564ed7040e1 URL: https://github.com/kamailio/kamailio/commit/d21836a9cbdcab3b420fe31b1d91356… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-11T08:37:18+02:00 tm: docs update of rpc tm.t_uac_attrs for mode attribute --- Modified: src/modules/tm/doc/rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/d21836a9cbdcab3b420fe31b1d91356… Patch: https://github.com/kamailio/kamailio/commit/d21836a9cbdcab3b420fe31b1d91356… --- diff --git a/src/modules/tm/doc/rpc.xml b/src/modules/tm/doc/rpc.xml index 21b77bab2ec..56925d08c52 100644 --- a/src/modules/tm/doc/rpc.xml +++ b/src/modules/tm/doc/rpc.xml @@ -187,7 +187,7 @@ </para> <itemizedlist> <listitem><para> - <emphasis>reply</emphasis> - control how the reply is waited. If + <emphasis>mode</emphasis> - control how the command is done. If not provided, acts like tm.t_uac_start. The values can be: "wait" - act like tm.t_uac_wait; "block" - act like tm.t_uac_wait_block.

1 0

git:master:ebdc7993: tm: renamed reply attribute to mode for tm.t_uac_attrs rpc command
by Daniel-Constantin Mierla 11 Jul '25

11 Jul '25

Module: kamailio Branch: master Commit: ebdc7993aaca23b25da3788f7ff4311e2bd71be4 URL: https://github.com/kamailio/kamailio/commit/ebdc7993aaca23b25da3788f7ff4311… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-11T08:37:18+02:00 tm: renamed reply attribute to mode for tm.t_uac_attrs rpc command --- Modified: src/modules/tm/rpc_uac.c --- Diff: https://github.com/kamailio/kamailio/commit/ebdc7993aaca23b25da3788f7ff4311… Patch: https://github.com/kamailio/kamailio/commit/ebdc7993aaca23b25da3788f7ff4311… --- diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 19b9b528a5c..2b43b53c6eb 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -1034,8 +1034,7 @@ void rpc_t_uac_attrs(rpc_t *rpc, void *c) return; } for(pit = params_list; pit; pit = pit->next) { - if(pit->name.len == 5 - && strncasecmp(pit->name.s, "reply", 5) == 0) { + if(pit->name.len == 4 && strncasecmp(pit->name.s, "mode", 4) == 0) { if(pit->body.len == 4 && strncasecmp(pit->name.s, "wait", 4) == 0) { tattrs.reply_wait = 1;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev