sr-dev

sr-dev@lists.kamailio.org

16 participants
45378 discussions

travis-ci error messages to the list related to coverity_scan
by Victor Seva 18 Dec '17

18 Dec '17

Hi, I must apologize about the amount of mails sent to the list during my work on coverity scan being integrated into our travis-ci build flow. I'll try not to spam the list any longer during my build tests. Sorry for the noise, Victor Seva

2 4

Please grant commit rights to Paul Claudiu Boriga
by Lucian Balaceanu 18 Dec '17

18 Dec '17

Hello Daniel, I would like to ask you to grant commit rights to my 1&1 colleague, Claudiu Boriga. As you know he has already been a contributor to Kamailio via multiple pull requests. His github account is https://github.com/claudiupb . Thank you, Lucian

2 1

git:master:2c5c25b7: cfgt: use snprintf to simplify _cfgt_get_filename()
by Victor Seva 18 Dec '17

18 Dec '17

Module: kamailio Branch: master Commit: 2c5c25b77c086ffe925820ed281f91d0549aee9e URL: https://github.com/kamailio/kamailio/commit/2c5c25b77c086ffe925820ed281f91d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-12-18T16:55:22+01:00 cfgt: use snprintf to simplify _cfgt_get_filename() > CID 153754 (#1 of 1): Buffer not null terminated (BUFFER_SIZE) > 6. buffer_size: Calling strncpy with a source string whose length (1 chars) is > greater than or equal to the size argument (1) will fail to null-terminate > dest->s + i. --- Modified: src/modules/cfgt/cfgt_int.c --- Diff: https://github.com/kamailio/kamailio/commit/2c5c25b77c086ffe925820ed281f91d… Patch: https://github.com/kamailio/kamailio/commit/2c5c25b77c086ffe925820ed281f91d… --- diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c index 2a0777ebcb..1c5b938e9c 100644 --- a/src/modules/cfgt/cfgt_int.c +++ b/src/modules/cfgt/cfgt_int.c @@ -270,15 +270,19 @@ void _cfgt_remove_node(cfgt_node_p node) int _cfgt_get_filename(int msgid, str uuid, str *dest, int *dir) { - int i, lid; + int lid; char buff_id[INT2STR_MAX_LEN]; char *sid; + char *format = "%.*s%.*s/%.*s.json"; if(dest == NULL || uuid.len == 0) return -1; dest->len = cfgt_basedir.len + uuid.len; - if(cfgt_basedir.s[cfgt_basedir.len - 1] != '/') + if(cfgt_basedir.s[cfgt_basedir.len - 1] != '/') { dest->len = dest->len + 1; + format = "%.*s/%.*s/%.*s.json"; + } + (*dir) = dest->len; sid = sint2strbuf(msgid, buff_id, INT2STR_MAX_LEN, &lid); dest->len += lid + 6; dest->s = (char *)pkg_malloc((dest->len * sizeof(char) + 1)); @@ -286,20 +290,8 @@ int _cfgt_get_filename(int msgid, str uuid, str *dest, int *dir) LM_ERR("no more memory.\n"); return -1; } - strncpy(dest->s, cfgt_basedir.s, cfgt_basedir.len); - i = cfgt_basedir.len; - if(cfgt_basedir.s[cfgt_basedir.len - 1] != '/') { - strncpy(dest->s + i, "/", 1); - i = i + 1; - } - strncpy(dest->s + i, uuid.s, uuid.len); - i = i + uuid.len; - (*dir) = i; - strncpy(dest->s + i, "\0", 1); - i = i + 1; - strncpy(dest->s + i, sid, lid); - i = i + lid; - strncpy(dest->s + i, ".json\0", 6); + snprintf(dest->s, dest->len + 1, format, cfgt_basedir.len, cfgt_basedir.s, + uuid.len, uuid.s, lid, sid); return 0; } @@ -334,6 +326,7 @@ void cfgt_save_node(cfgt_node_p node) LM_ERR("can't build filename\n"); return; } + dest.s[dir] = '\0'; LM_DBG("dir [%s]\n", dest.s); if(mkdir(dest.s, S_IRWXO | S_IXGRP | S_IRWXU) < 0) { LM_ERR("failed to make directory: %s\n", strerror(errno));

1 0

Still Failing: kamailio/kamailio#5285 (coverity_scan - c2908e1)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5285 Status: Still Failing Duration: 15 minutes and 47 seconds Commit: c2908e1 (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/50c71368cb24...c2908e150a48 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317466442?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Broken: kamailio/kamailio#5284 (coverity_scan - 50c7136)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5284 Status: Broken Duration: 16 minutes and 23 seconds Commit: 50c7136 (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/cafc32a6aeab...50c71368cb24 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317447922?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Still Failing: kamailio/kamailio#5282 (coverity_scan - 6fc81cd)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5282 Status: Still Failing Duration: 18 minutes and 25 seconds Commit: 6fc81cd (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/777820e8b9ca...6fc81cdceb38 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317424217?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Still Failing: kamailio/kamailio#5281 (coverity_scan - 777820e)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5281 Status: Still Failing Duration: 3 minutes and 44 seconds Commit: 777820e (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/5636e56b675a...777820e8b9ca View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317422550?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Still Failing: kamailio/kamailio#5280 (coverity_scan - 5636e56)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5280 Status: Still Failing Duration: 1 minute and 55 seconds Commit: 5636e56 (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/e1d344ead872...5636e56b675a View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317421882?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Still Failing: kamailio/kamailio#5279 (coverity_scan - e1d344e)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5279 Status: Still Failing Duration: 1 minute and 44 seconds Commit: e1d344e (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/1c7cfba33bf1...e1d344ead872 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317419591?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Broken: kamailio/kamailio#5278 (coverity_scan - 1c7cfba)
by Travis CI 16 Dec '17

16 Dec '17

Build Update for kamailio/kamailio ------------------------------------- Build: #5278 Status: Broken Duration: 43 seconds Commit: 1c7cfba (coverity_scan) Author: Victor Seva Message: travis-ci: enable coverity scan for coverity_scan branch View the changeset: https://github.com/kamailio/kamailio/compare/d968307e95f4...1c7cfba33bf1 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/317415785?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev