sr-dev

sr-dev@lists.kamailio.org

16 participants
45365 discussions

OT: question about codetriage
by Daniel-Constantin Mierla 08 Jan '18

08 Jan '18

Hello, anyone here familiar with codetriage service? We got a pull request to refer to it from Kamailio readme.md file: - https://github.com/kamailio/kamailio/pull/1389 The link is to: - https://www.codetriage.com/kamailio/kamailio Which I guess is created by the one who did the pull request. The pull request comments has few references to other projects, including Rails, but as I am not familiar with the service, I thought of asking here and see if others had to deal with and what's the experience. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - March 5-7, 2018, Berlin - www.asipto.com Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

1 0

Kamailio World 2018 - Call for Presentations
by Daniel-Constantin Mierla 08 Jan '18

08 Jan '18

Hello, I would like to announce that Call for Presentations at Kamailio World 2018 is now open. You can submit your proposal or see more details at: - https://www.kamailioworld.com/k06/call-for-speakers/ The 6th edition of the event takes place again in Berlin, Germany, during May 14-16, 2018. Expect over 150 participants, developers and community members as well as representatives from other popular open source VoIP projects such as Asterisk or FreeSwitch. Looking forward to meeting many of you there! Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

1 1

git:master:26e09730: Merge pull request #1392 from que273/master
by GitHub 08 Jan '18

08 Jan '18

Module: kamailio Branch: master Commit: 26e09730ff8821313f1ee6a6f57669197e353148 URL: https://github.com/kamailio/kamailio/commit/26e09730ff8821313f1ee6a6f576691… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2018-01-08T09:45:17+01:00 Merge pull request #1392 from que273/master Minor improvements to RPM packaging --- Modified: pkg/kamailio/obs/kamailio.init Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/26e09730ff8821313f1ee6a6f576691… Patch: https://github.com/kamailio/kamailio/commit/26e09730ff8821313f1ee6a6f576691… --- diff --git a/pkg/kamailio/obs/kamailio.init b/pkg/kamailio/obs/kamailio.init index 2cdae7a87d..0d7823637a 100644 --- a/pkg/kamailio/obs/kamailio.init +++ b/pkg/kamailio/obs/kamailio.init @@ -36,7 +36,7 @@ RUN_KAMAILIO=no check_fork () { if grep -q "^[[:space:]]*fork[[:space:]]*=[[:space:]]*no.*" $KAMCFG; then - echo "Not starting $DESC: fork=no specified in config file; run /etc/init.d/kamailio debug instead" + echo "Not starting $PROG: fork=no specified in config file; run /etc/init.d/kamailio debug instead" exit 1 fi } @@ -44,10 +44,10 @@ check_fork () check_kamailio_config () { # Check if kamailio configuration is valid before starting the server - out=$($KAM -c 2>&1 > /dev/null) + out=$($KAM -c $OPTIONS 2>&1 > /dev/null) retcode=$? if [ "$retcode" != '0' ]; then - echo "Not starting $DESC: invalid configuration file!" + echo "Not starting $PROG: invalid configuration file!" echo -e "\n$out\n" exit 1 fi @@ -69,7 +69,7 @@ start() { stop() { echo -n $"Stopping $PROG: " - killproc $KAM + killproc -p $PID_FILE RETVAL=$? echo [ $RETVAL = 0 ] && rm -f $LOCK_FILE $PID_FILE @@ -81,7 +81,7 @@ if [ -f $DEFAULTS ]; then fi if [ "$RUN_KAMAILIO" != "yes" ]; then - echo "Kamailio not yet configured. Edit /etc/default/kamailio first." + echo "Kamailio not yet configured. Edit $DEFAULTS first." exit 0 fi @@ -108,7 +108,7 @@ if [ ! -d $HOMEDIR ]; then chown ${USER}:${GROUP} $HOMEDIR fi -OPTIONS="-P $PID_FILE -m $SHM_MEMORY -M $PKG_MEMORY -u $USER -g $GROUP $EXTRA_OPTIONS" +OPTIONS="-f $KAMCFG -P $PID_FILE -m $SHM_MEMORY -M $PKG_MEMORY -u $USER -g $GROUP $EXTRA_OPTIONS" # See how we were called. diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 5c98924046..ba802c83ad 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1188,7 +1188,6 @@ fi %doc %{_docdir}/kamailio/modules/README.group %doc %{_docdir}/kamailio/modules/README.htable %doc %{_docdir}/kamailio/modules/README.imc -%doc %{_docdir}/kamailio/modules/README.ims_ocs %doc %{_docdir}/kamailio/modules/README.ipops %doc %{_docdir}/kamailio/modules/README.kex %doc %{_docdir}/kamailio/modules/README.malloc_test @@ -1336,7 +1335,6 @@ fi %{_libdir}/kamailio/modules/group.so %{_libdir}/kamailio/modules/htable.so %{_libdir}/kamailio/modules/imc.so -%{_libdir}/kamailio/modules/ims_ocs.so %{_libdir}/kamailio/modules/ipops.so %{_libdir}/kamailio/modules/kex.so %{_libdir}/kamailio/modules/malloc_test.so @@ -1553,6 +1551,7 @@ fi %doc %{_docdir}/kamailio/modules/README.ims_diameter_server %doc %{_docdir}/kamailio/modules/README.ims_icscf %doc %{_docdir}/kamailio/modules/README.ims_isc +%doc %{_docdir}/kamailio/modules/README.ims_ocs %doc %{_docdir}/kamailio/modules/README.ims_qos %doc %{_docdir}/kamailio/modules/README.ims_registrar_pcscf %doc %{_docdir}/kamailio/modules/README.ims_registrar_scscf @@ -1570,6 +1569,7 @@ fi %{_libdir}/kamailio/modules/ims_diameter_server.so %{_libdir}/kamailio/modules/ims_icscf.so %{_libdir}/kamailio/modules/ims_isc.so +%{_libdir}/kamailio/modules/ims_ocs.so %{_libdir}/kamailio/modules/ims_qos.so %{_libdir}/kamailio/modules/ims_registrar_pcscf.so %{_libdir}/kamailio/modules/ims_registrar_scscf.so

1 0

git:master:6a7ea3d4: pkg/kamailio/obs: Move ims_ocs module to ims RPM
by Hugh Waite 08 Jan '18

08 Jan '18

Module: kamailio Branch: master Commit: 6a7ea3d489175659cbfcca4088a8cd26b9352273 URL: https://github.com/kamailio/kamailio/commit/6a7ea3d489175659cbfcca4088a8cd2… Author: Hugh Waite <hughw273(a)gmail.com> Committer: Hugh Waite <hughw273(a)gmail.com> Date: 2018-01-04T21:16:08Z pkg/kamailio/obs: Move ims_ocs module to ims RPM This module has a dependancy on libkamailio_ims.so so it belongs within the IMS RPM. --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/6a7ea3d489175659cbfcca4088a8cd2… Patch: https://github.com/kamailio/kamailio/commit/6a7ea3d489175659cbfcca4088a8cd2… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 5c98924046..ba802c83ad 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1188,7 +1188,6 @@ fi %doc %{_docdir}/kamailio/modules/README.group %doc %{_docdir}/kamailio/modules/README.htable %doc %{_docdir}/kamailio/modules/README.imc -%doc %{_docdir}/kamailio/modules/README.ims_ocs %doc %{_docdir}/kamailio/modules/README.ipops %doc %{_docdir}/kamailio/modules/README.kex %doc %{_docdir}/kamailio/modules/README.malloc_test @@ -1336,7 +1335,6 @@ fi %{_libdir}/kamailio/modules/group.so %{_libdir}/kamailio/modules/htable.so %{_libdir}/kamailio/modules/imc.so -%{_libdir}/kamailio/modules/ims_ocs.so %{_libdir}/kamailio/modules/ipops.so %{_libdir}/kamailio/modules/kex.so %{_libdir}/kamailio/modules/malloc_test.so @@ -1553,6 +1551,7 @@ fi %doc %{_docdir}/kamailio/modules/README.ims_diameter_server %doc %{_docdir}/kamailio/modules/README.ims_icscf %doc %{_docdir}/kamailio/modules/README.ims_isc +%doc %{_docdir}/kamailio/modules/README.ims_ocs %doc %{_docdir}/kamailio/modules/README.ims_qos %doc %{_docdir}/kamailio/modules/README.ims_registrar_pcscf %doc %{_docdir}/kamailio/modules/README.ims_registrar_scscf @@ -1570,6 +1569,7 @@ fi %{_libdir}/kamailio/modules/ims_diameter_server.so %{_libdir}/kamailio/modules/ims_icscf.so %{_libdir}/kamailio/modules/ims_isc.so +%{_libdir}/kamailio/modules/ims_ocs.so %{_libdir}/kamailio/modules/ims_qos.so %{_libdir}/kamailio/modules/ims_registrar_pcscf.so %{_libdir}/kamailio/modules/ims_registrar_scscf.so

1 0

git:master:f06cad16: pkg/kamailio/obs: Minor improvements to kamailio.init file
by Hugh Waite 08 Jan '18

08 Jan '18

Module: kamailio Branch: master Commit: f06cad16ddd38771f29bfba29161bfa3ec76354f URL: https://github.com/kamailio/kamailio/commit/f06cad16ddd38771f29bfba29161bfa… Author: Hugh Waite <hughw273(a)gmail.com> Committer: Hugh Waite <hughw273(a)gmail.com> Date: 2018-01-04T21:01:08Z pkg/kamailio/obs: Minor improvements to kamailio.init file Use $PROG instead of uninitialised $DESC Pass the .cfg file name as a parameter when starting and checking config Use the pidfile when stopping to allow parallel instances --- Modified: pkg/kamailio/obs/kamailio.init --- Diff: https://github.com/kamailio/kamailio/commit/f06cad16ddd38771f29bfba29161bfa… Patch: https://github.com/kamailio/kamailio/commit/f06cad16ddd38771f29bfba29161bfa… --- diff --git a/pkg/kamailio/obs/kamailio.init b/pkg/kamailio/obs/kamailio.init index 2cdae7a87d..0d7823637a 100644 --- a/pkg/kamailio/obs/kamailio.init +++ b/pkg/kamailio/obs/kamailio.init @@ -36,7 +36,7 @@ RUN_KAMAILIO=no check_fork () { if grep -q "^[[:space:]]*fork[[:space:]]*=[[:space:]]*no.*" $KAMCFG; then - echo "Not starting $DESC: fork=no specified in config file; run /etc/init.d/kamailio debug instead" + echo "Not starting $PROG: fork=no specified in config file; run /etc/init.d/kamailio debug instead" exit 1 fi } @@ -44,10 +44,10 @@ check_fork () check_kamailio_config () { # Check if kamailio configuration is valid before starting the server - out=$($KAM -c 2>&1 > /dev/null) + out=$($KAM -c $OPTIONS 2>&1 > /dev/null) retcode=$? if [ "$retcode" != '0' ]; then - echo "Not starting $DESC: invalid configuration file!" + echo "Not starting $PROG: invalid configuration file!" echo -e "\n$out\n" exit 1 fi @@ -69,7 +69,7 @@ start() { stop() { echo -n $"Stopping $PROG: " - killproc $KAM + killproc -p $PID_FILE RETVAL=$? echo [ $RETVAL = 0 ] && rm -f $LOCK_FILE $PID_FILE @@ -81,7 +81,7 @@ if [ -f $DEFAULTS ]; then fi if [ "$RUN_KAMAILIO" != "yes" ]; then - echo "Kamailio not yet configured. Edit /etc/default/kamailio first." + echo "Kamailio not yet configured. Edit $DEFAULTS first." exit 0 fi @@ -108,7 +108,7 @@ if [ ! -d $HOMEDIR ]; then chown ${USER}:${GROUP} $HOMEDIR fi -OPTIONS="-P $PID_FILE -m $SHM_MEMORY -M $PKG_MEMORY -u $USER -g $GROUP $EXTRA_OPTIONS" +OPTIONS="-f $KAMCFG -P $PID_FILE -m $SHM_MEMORY -M $PKG_MEMORY -u $USER -g $GROUP $EXTRA_OPTIONS" # See how we were called.

1 0

[kamailio/kamailio] Minor improvements to RPM packaging (#1392)
by Hugh Waite 08 Jan '18

08 Jan '18

### Description kamailio.spec: Move the ims_ocs module into the ims RPM. It has a dependancy on libkamailio_ims.so kamailio.init: Pass the .cfg file as a parameter when starting or syntax checking. Use the pidfile to kill only the relevant instance. This makes it easier to reuse the same script when running multiple kamailio instances on the same server. Only the environment vars at the top need to be changed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1392 -- Commit Summary -- * pkg/kamailio/obs: Minor improvements to kamailio.init file * pkg/kamailio/obs: Move ims_ocs module to ims RPM -- File Changes -- M pkg/kamailio/obs/kamailio.init (12) M pkg/kamailio/obs/kamailio.spec (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1392.patch https://github.com/kamailio/kamailio/pull/1392.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1392

2 2

git:master:74c02fdb: snmpstats: safety checks on hdr variable
by Daniel-Constantin Mierla 05 Jan '18

05 Jan '18

Module: kamailio Branch: master Commit: 74c02fdb1cd04d674046c38bc2f5193f91da4edf URL: https://github.com/kamailio/kamailio/commit/74c02fdb1cd04d674046c38bc2f5193… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-05T09:08:56+01:00 snmpstats: safety checks on hdr variable --- Modified: src/modules/snmpstats/snmpSIPRegUserLookupTable.c Modified: src/modules/snmpstats/snmpSIPStatusCodesTable.c --- Diff: https://github.com/kamailio/kamailio/commit/74c02fdb1cd04d674046c38bc2f5193… Patch: https://github.com/kamailio/kamailio/commit/74c02fdb1cd04d674046c38bc2f5193…

1 0

git:master:5b00ef8b: snmpstats: check the return code when registering statistics
by Daniel-Constantin Mierla 05 Jan '18

05 Jan '18

Module: kamailio Branch: master Commit: 5b00ef8bb31fb029b2d4dedae40e2c7a54841fe6 URL: https://github.com/kamailio/kamailio/commit/5b00ef8bb31fb029b2d4dedae40e2c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-05T09:08:56+01:00 snmpstats: check the return code when registering statistics --- Modified: src/modules/snmpstats/snmpstats.c --- Diff: https://github.com/kamailio/kamailio/commit/5b00ef8bb31fb029b2d4dedae40e2c7… Patch: https://github.com/kamailio/kamailio/commit/5b00ef8bb31fb029b2d4dedae40e2c7… --- diff --git a/src/modules/snmpstats/snmpstats.c b/src/modules/snmpstats/snmpstats.c index 4bd11c98d2..9a8acea270 100644 --- a/src/modules/snmpstats/snmpstats.c +++ b/src/modules/snmpstats/snmpstats.c @@ -302,10 +302,14 @@ static int register_message_code_statistics(void) sizeof(stat_var *) * number_of_message_codes); for(i = 0; i < number_of_message_codes; i++) { - register_stat(SNMPSTATS_MODULE_NAME, in_message_code_names[i], - &in_message_code_stats[i], 0); - register_stat(SNMPSTATS_MODULE_NAME, out_message_code_names[i], - &out_message_code_stats[i], 0); + if(register_stat(SNMPSTATS_MODULE_NAME, in_message_code_names[i], + &in_message_code_stats[i], 0)!=0) { + LM_ERR("failed to register in_message_code_names[%d]\n", i); + } + if(register_stat(SNMPSTATS_MODULE_NAME, out_message_code_names[i], + &out_message_code_stats[i], 0)!=0) { + LM_ERR("failed to register out_message_code_names[%d]\n", i); + } } return 0;

1 0

git:master:bab289f3: http_client: cast parameter to curl function to avoid warnings
by Daniel-Constantin Mierla 05 Jan '18

05 Jan '18

Module: kamailio Branch: master Commit: bab289f36b189a2836ef51acc9e26aed422a7dad URL: https://github.com/kamailio/kamailio/commit/bab289f36b189a2836ef51acc9e26ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-05T09:08:56+01:00 http_client: cast parameter to curl function to avoid warnings --- Modified: src/modules/http_client/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/bab289f36b189a2836ef51acc9e26ae… Patch: https://github.com/kamailio/kamailio/commit/bab289f36b189a2836ef51acc9e26ae… --- diff --git a/src/modules/http_client/functions.c b/src/modules/http_client/functions.c index 68ed33b248..695324bf43 100644 --- a/src/modules/http_client/functions.c +++ b/src/modules/http_client/functions.c @@ -252,7 +252,7 @@ static int curL_query_url(struct sip_msg *_m, const char *_url, str *_dst, res |= curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_function); - res |= curl_easy_setopt(curl, CURLOPT_WRITEDATA, &stream); + res |= curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*)(&stream)); if(params->useragent) res |= curl_easy_setopt(curl, CURLOPT_USERAGENT, params->useragent);

1 0

git:5.0:447d49f7: erlang: fix missing to free memory used for param specification
by Seudin Kasumovic 04 Jan '18

04 Jan '18

Module: kamailio Branch: 5.0 Commit: 447d49f75c69621473fccd0c0fe3b6c4d6679ffc URL: https://github.com/kamailio/kamailio/commit/447d49f75c69621473fccd0c0fe3b6c… Author: Seudin Kasumovic <seudin.kasumovic(a)gmail.com> Committer: Seudin Kasumovic <seudin.kasumovic(a)gmail.com> Date: 2018-01-04T23:00:32+01:00 erlang: fix missing to free memory used for param specification - ensure to destroy fixup param specification when send erlang message (cherry picked from commit 90ee13d21db9a57a9d4a855b857dd152f645500d) --- Modified: src/modules/erlang/erlang_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/447d49f75c69621473fccd0c0fe3b6c… Patch: https://github.com/kamailio/kamailio/commit/447d49f75c69621473fccd0c0fe3b6c… --- diff --git a/src/modules/erlang/erlang_mod.c b/src/modules/erlang/erlang_mod.c index 54d2fa1733..83d007aa68 100644 --- a/src/modules/erlang/erlang_mod.c +++ b/src/modules/erlang/erlang_mod.c @@ -697,6 +697,7 @@ static int fixup_rpc(void** param, int param_no) if (psp->setf != pv_list_set && psp->setf != pv_xbuff_set) { LM_ERR("wrong parameter #%d: accepted types are list or xbuff\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -915,6 +916,7 @@ static int fixup_reg(void** param, int param_no) erl_param->type = ERL_PARAM_XBUFF_SPEC; } else { LM_ERR("wrong parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1109,6 +1111,7 @@ static int fixup_reply(void** param, int param_no) erl_param->type = ERL_PARAM_XBUFF_SPEC; } else { LM_ERR("wrong parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1354,6 +1357,7 @@ static int fixup_send(void** param, int param_no) if (erl_param->value.sp.pvp.pvn.type == PV_NAME_INTSTR) { if (fix_param_types(FPARAM_STR|FPARAM_STRING,param)) { LM_ERR("wrong parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1363,6 +1367,7 @@ static int fixup_send(void** param, int param_no) else { if (erl_param->value.sp.type == PVT_XAVP) { LM_ERR("XAVP not acceptable for parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1373,6 +1378,7 @@ static int fixup_send(void** param, int param_no) erl_param->type = ERL_PARAM_XBUFF_SPEC; } else { LM_ERR("wrong parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1392,6 +1398,7 @@ static int fixup_send(void** param, int param_no) if (erl_param->value.sp.pvp.pvn.type == PV_NAME_INTSTR) { if (fix_param_types(FPARAM_STR|FPARAM_STRING,param)) { LM_ERR("wrong parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1400,6 +1407,7 @@ static int fixup_send(void** param, int param_no) } else { if (erl_param->value.sp.type ==PVT_XAVP) { LM_ERR("XAVP not acceptable for parameter #%d\n",param_no); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; } @@ -1415,7 +1423,7 @@ static int fixup_send(void** param, int param_no) erl_param->type = ERL_PARAM_XBUFF_SPEC; } else { LM_ERR("wrong parameter #%d\n",param_no); - pv_spec_free(&erl_param->value.sp); + pv_spec_destroy(&erl_param->value.sp); pkg_free((void*)erl_param); return E_UNSPEC; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev