sr-dev

sr-dev@lists.kamailio.org

3 participants
45454 discussions

git:master:3ebf0704: pkg/kamailio/deb: version set to 5.2.0~dev3
by Victor Seva 25 Jan '18

25 Jan '18

Module: kamailio Branch: master Commit: 3ebf070467aecd4a7e3d5e287b776831f31b25d8 URL: https://github.com/kamailio/kamailio/commit/3ebf070467aecd4a7e3d5e287b77683… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-01-25T10:35:09+01:00 pkg/kamailio/deb: version set to 5.2.0~dev3 --- Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/3ebf070467aecd4a7e3d5e287b77683… Patch: https://github.com/kamailio/kamailio/commit/3ebf070467aecd4a7e3d5e287b77683…

1 0

git:master:0aa43efe: Makefile.defs: version set to 5.2.0-dev3
by Daniel-Constantin Mierla 25 Jan '18

25 Jan '18

Module: kamailio Branch: master Commit: 0aa43efe604c99da9a1e579ed19407fae4d8f2f9 URL: https://github.com/kamailio/kamailio/commit/0aa43efe604c99da9a1e579ed19407f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-25T10:24:35+01:00 Makefile.defs: version set to 5.2.0-dev3 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/0aa43efe604c99da9a1e579ed19407f… Patch: https://github.com/kamailio/kamailio/commit/0aa43efe604c99da9a1e579ed19407f… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 48ec3c919d..2355d8b3df 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -dev2 +EXTRAVERSION = -dev3 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:2fc3be57: siptrace: use formatted string instead of series of concatenations
by Daniel-Constantin Mierla 25 Jan '18

25 Jan '18

Module: kamailio Branch: master Commit: 2fc3be572afe4dc666f7345c733a5bc1c8e94932 URL: https://github.com/kamailio/kamailio/commit/2fc3be572afe4dc666f7345c733a5bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-25T10:18:20+01:00 siptrace: use formatted string instead of series of concatenations --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/2fc3be572afe4dc666f7345c733a5bc… Patch: https://github.com/kamailio/kamailio/commit/2fc3be572afe4dc666f7345c733a5bc… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 851bf6e0f8..d936e4fbb6 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1179,22 +1179,30 @@ static void trace_onreply_in(struct cell *t, int type, struct tmcb_params *ps) strcpy(statusbuf, int2str(ps->code, &sto.status.len)); sto.status.s = statusbuf; - siptrace_copy_proto(msg->rcv.proto, sto.fromip_buff); - strcat(sto.fromip_buff, ip_addr2a(&msg->rcv.src_ip)); - strcat(sto.fromip_buff, ":"); - strcat(sto.fromip_buff, int2str(msg->rcv.src_port, NULL)); - sto.fromip.s = sto.fromip_buff; - sto.fromip.len = strlen(sto.fromip_buff); + sto.fromip.len = snprintf(sto.fromip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(msg->rcv.proto), + ip_addr2a(&msg->rcv.src_ip), (int)msg->rcv.src_port); + if(sto.fromip.len<0 || sto.fromip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format fromip buffer (%d)\n", sto.fromip.len); + sto.fromip.s = SIPTRACE_ANYADDR; + sto.fromip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.fromip.s = sto.fromip_buff; + } if(trace_local_ip.s && trace_local_ip.len > 0) { sto.toip = trace_local_ip; } else { - siptrace_copy_proto(msg->rcv.proto, sto.toip_buff); - strcat(sto.toip_buff, ip_addr2a(&msg->rcv.dst_ip)); - strcat(sto.toip_buff, ":"); - strcat(sto.toip_buff, int2str(msg->rcv.dst_port, NULL)); - sto.toip.s = sto.toip_buff; - sto.toip.len = strlen(sto.toip_buff); + sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(msg->rcv.proto), + ip_addr2a(&msg->rcv.dst_ip), (int)msg->rcv.dst_port); + if(sto.toip.len<0 || sto.toip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len); + sto.toip.s = SIPTRACE_ANYADDR; + sto.toip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.toip.s = sto.toip_buff; + } } sto.dir = "in"; @@ -1280,12 +1288,16 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps) if(trace_local_ip.s && trace_local_ip.len > 0) { sto.fromip = trace_local_ip; } else { - siptrace_copy_proto(msg->rcv.proto, sto.fromip_buff); - strcat(sto.fromip_buff, ip_addr2a(&req->rcv.dst_ip)); - strcat(sto.fromip_buff, ":"); - strcat(sto.fromip_buff, int2str(req->rcv.dst_port, NULL)); - sto.fromip.s = sto.fromip_buff; - sto.fromip.len = strlen(sto.fromip_buff); + sto.fromip.len = snprintf(sto.fromip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(msg->rcv.proto), + ip_addr2a(&req->rcv.dst_ip), (int)req->rcv.dst_port); + if(sto.fromip.len<0 || sto.fromip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format fromip buffer (%d)\n", sto.fromip.len); + sto.fromip.s = SIPTRACE_ANYADDR; + sto.fromip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.fromip.s = sto.fromip_buff; + } } strcpy(statusbuf, int2str(ps->code, &sto.status.len)); @@ -1298,13 +1310,16 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps) sto.toip.len = SIPTRACE_ANYADDR_LEN; } else { su2ip_addr(&to_ip, &dst->to); - siptrace_copy_proto(dst->proto, sto.toip_buff); - strcat(sto.toip_buff, ip_addr2a(&to_ip)); - strcat(sto.toip_buff, ":"); - strcat(sto.toip_buff, - int2str((unsigned long)su_getport(&dst->to), &len)); - sto.toip.s = sto.toip_buff; - sto.toip.len = strlen(sto.toip_buff); + sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(dst->proto), + ip_addr2a(&to_ip), (int)su_getport(&dst->to)); + if(sto.toip.len<0 || sto.toip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len); + sto.toip.s = SIPTRACE_ANYADDR; + sto.toip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.toip.s = sto.toip_buff; + } } sto.dir = "out";

1 0

Errored: kamailio/kamailio#5422 (master - 64303a9)
by Travis CI 24 Jan '18

24 Jan '18

Build Update for kamailio/kamailio ------------------------------------- Build: #5422 Status: Errored Duration: 10 minutes and 50 seconds Commit: 64303a9 (master) Author: Daniel-Constantin Mierla Message: nathelper: add_rcv_param() - do not enclose to double quotes if URI param - restrict adding the param to contact URI only for UDP, otherwise a second transport parameter appears in the URI - do not enclose the value in double quotes when adding as URI param, it is not allowed by SIP specs grammar - discussed on GH PR #1203 View the changeset: https://github.com/kamailio/kamailio/compare/f540ff43e526...64303a9398af View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/332729892?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

git:master:44dc6caa: modules: readme files regenerated - nathelper ... [skip ci]
by Kamailio Dev 24 Jan '18

24 Jan '18

Module: kamailio Branch: master Commit: 44dc6caa2b0ff5ac17d5ae14830feae6d8f9ebd7 URL: https://github.com/kamailio/kamailio/commit/44dc6caa2b0ff5ac17d5ae14830feae… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-01-24T12:01:31+01:00 modules: readme files regenerated - nathelper ... [skip ci] --- Modified: src/modules/nathelper/README --- Diff: https://github.com/kamailio/kamailio/commit/44dc6caa2b0ff5ac17d5ae14830feae… Patch: https://github.com/kamailio/kamailio/commit/44dc6caa2b0ff5ac17d5ae14830feae… --- diff --git a/src/modules/nathelper/README b/src/modules/nathelper/README index 102a639ea0..d21c31c502 100644 --- a/src/modules/nathelper/README +++ b/src/modules/nathelper/README @@ -517,12 +517,14 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_sdp("3");}; 5.3. add_rcv_param([flag]), - Add a received parameter to the “Contact” header fields or the Contact - URI. The parameter will contain the URI created from the source IP, - port, and protocol of the packet containing the SIP message. The - parameter can be then processed by another registrar. This is useful, - for example, when replicating register messages using t_replicate - function to another registrar. + Add a received parameter to the “Contact” header fields (available for + all transports) or to the Contact URI (available only for UDP traffic). + + The parameter will contain the URI created from the source IP, port, + and protocol (if different than UDP) of the packet containing the SIP + message. The parameter can be then processed by another registrar. This + is useful, for example, when replicating register messages using + t_replicate function to another registrar. Meaning of the parameters is as follows: * flag - flags to indicate if the parameter should be added to

1 0

[kamailio/kamailio] nathelper: correct Contact received param (#1203)
by Sebastian Damm 24 Jan '18

24 Jan '18

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - Received param was enclosed in quotes, making some UACs stumble upon it. This fix removes the quotes, adding the received param the same way as it is done for example in the path module. - Reported by Arslan Aseed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1203 -- Commit Summary -- * nathelper: correct Contact received param -- File Changes -- M src/modules/nathelper/nathelper.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1203.patch https://github.com/kamailio/kamailio/pull/1203.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1203

3 10

git:master:57bd759e: nathelper: documented the use of add_rcv_param() for Contact URI case
by Daniel-Constantin Mierla 24 Jan '18

24 Jan '18

Module: kamailio Branch: master Commit: 57bd759e19b07647aac3bfce673131a142d9c07a URL: https://github.com/kamailio/kamailio/commit/57bd759e19b07647aac3bfce673131a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-24T11:58:45+01:00 nathelper: documented the use of add_rcv_param() for Contact URI case --- Modified: src/modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/57bd759e19b07647aac3bfce673131a… Patch: https://github.com/kamailio/kamailio/commit/57bd759e19b07647aac3bfce673131a… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index 513c48400e..f6e061799c 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -554,11 +554,15 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_sdp("3");}; </title> <para> Add a received parameter to the <quote>Contact</quote> header fields - or the Contact URI. The parameter will contain the URI created from the - source IP, port, and protocol of the packet containing the SIP message. - The parameter can be then processed by another registrar. This is useful, - for example, when replicating register messages using <function>t_replicate</function> - function to another registrar. + (available for all transports) or to the Contact URI (available only + for UDP traffic). + </para> + <para> + The parameter will contain the URI created from the + source IP, port, and protocol (if different than UDP) of the packet + containing the SIP message. The parameter can be then processed by + another registrar. This is useful, for example, when replicating register + messages using <function>t_replicate</function> function to another registrar. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -566,7 +570,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_sdp("3");}; <emphasis>flag</emphasis> - flags to indicate if the parameter should be added to Contact URI or Contact header. If the flag is non-zero, the parameter will be added to the Contact URI. If not - used or equal to zero, the parameter will go to the Contact + used or equal to zero, the parameter will go to the Contact header. </para></listitem> </itemizedlist>

1 0

git:master:64303a93: nathelper: add_rcv_param() - do not enclose to double quotes if URI param
by Daniel-Constantin Mierla 24 Jan '18

24 Jan '18

Module: kamailio Branch: master Commit: 64303a9398afe65d65cf35489c04e725689a5da2 URL: https://github.com/kamailio/kamailio/commit/64303a9398afe65d65cf35489c04e72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-24T11:52:47+01:00 nathelper: add_rcv_param() - do not enclose to double quotes if URI param - restrict adding the param to contact URI only for UDP, otherwise a second transport parameter appears in the URI - do not enclose the value in double quotes when adding as URI param, it is not allowed by SIP specs grammar - discussed on GH PR #1203 --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/64303a9398afe65d65cf35489c04e72… Patch: https://github.com/kamailio/kamailio/commit/64303a9398afe65d65cf35489c04e72… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 168bae09cc..a45588a50d 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -2110,9 +2110,13 @@ static int ki_add_rcv_param(sip_msg_t *msg, int upos) struct lump *anchor; char *param; str uri; - int hdr_param; - hdr_param = (upos)?0:1; + if(upos) { + if(msg->rcv.proto != PROTO_UDP) { + LM_ERR("adding received parameter to Contact URI works only for UDP\n"); + return -1; + } + } if(create_rcv_uri(&uri, msg) < 0) { return -1; @@ -2129,16 +2133,20 @@ static int ki_add_rcv_param(sip_msg_t *msg, int upos) return -1; } memcpy(param, RECEIVED, RECEIVED_LEN); - param[RECEIVED_LEN] = '\"'; - memcpy(param + RECEIVED_LEN + 1, uri.s, uri.len); - param[RECEIVED_LEN + 1 + uri.len] = '\"'; - - if(hdr_param) { - /* add the param as header param */ - anchor = anchor_lump(msg, c->name.s + c->len - msg->buf, 0, 0); + if(upos) { + memcpy(param + RECEIVED_LEN, uri.s, uri.len); } else { + param[RECEIVED_LEN] = '\"'; + memcpy(param + RECEIVED_LEN + 1, uri.s, uri.len); + param[RECEIVED_LEN + 1 + uri.len] = '\"'; + } + + if(upos) { /* add the param as uri param */ anchor = anchor_lump(msg, c->uri.s + c->uri.len - msg->buf, 0, 0); + } else { + /* add the param as header param */ + anchor = anchor_lump(msg, c->name.s + c->len - msg->buf, 0, 0); } if(anchor == NULL) { LM_ERR("anchor_lump failed\n"); @@ -2146,9 +2154,8 @@ static int ki_add_rcv_param(sip_msg_t *msg, int upos) return -1; } - if(insert_new_lump_after( - anchor, param, RECEIVED_LEN + 1 + uri.len + 1, 0) - == 0) { + if(insert_new_lump_after(anchor, param, + RECEIVED_LEN + 1 + uri.len + 1 - ((upos)?2:0), 0) == 0) { LM_ERR("insert_new_lump_after failed\n"); pkg_free(param); return -1;

1 0

git:master:08df9d1b: nathelper: fixed interpretation of flags param for add_rcv_param()
by Daniel-Constantin Mierla 24 Jan '18

24 Jan '18

Module: kamailio Branch: master Commit: 08df9d1b11ff3fcfe241ce179560431145be8216 URL: https://github.com/kamailio/kamailio/commit/08df9d1b11ff3fcfe241ce179560431… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-24T11:44:33+01:00 nathelper: fixed interpretation of flags param for add_rcv_param() - add as uri param when the flags are set and different than 0 - small typo in log message --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/08df9d1b11ff3fcfe241ce179560431… Patch: https://github.com/kamailio/kamailio/commit/08df9d1b11ff3fcfe241ce179560431… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 5eb7f6a12f..168bae09cc 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -2104,12 +2104,15 @@ static int create_rcv_uri(str *uri, struct sip_msg *m) * Add received parameter to Contacts for further * forwarding of the REGISTER requuest */ -static int ki_add_rcv_param(sip_msg_t *msg, int hdr_param) +static int ki_add_rcv_param(sip_msg_t *msg, int upos) { contact_t *c; struct lump *anchor; char *param; str uri; + int hdr_param; + + hdr_param = (upos)?0:1; if(create_rcv_uri(&uri, msg) < 0) { return -1; @@ -2169,7 +2172,7 @@ static int add_rcv_param_f(struct sip_msg *msg, char *str1, char *str2) if(str1) { if(fixup_get_ivalue(msg, (gparam_t*)str1, &hdr_param)<0) { - LM_ERR("failed to get falgs parameter\n"); + LM_ERR("failed to get flags parameter\n"); return -1; } }

1 0

git:master:f540ff43: modules: readme files regenerated - json ... [skip ci]
by Kamailio Dev 24 Jan '18

24 Jan '18

Module: kamailio Branch: master Commit: f540ff43e52696ad3f21edc8188cf2ddc62686bc URL: https://github.com/kamailio/kamailio/commit/f540ff43e52696ad3f21edc8188cf2d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-01-24T09:46:40+01:00 modules: readme files regenerated - json ... [skip ci] --- Modified: src/modules/json/README --- Diff: https://github.com/kamailio/kamailio/commit/f540ff43e52696ad3f21edc8188cf2d… Patch: https://github.com/kamailio/kamailio/commit/f540ff43e52696ad3f21edc8188cf2d… --- diff --git a/src/modules/json/README b/src/modules/json/README index 2f3e6dc7a0..139597f9cb 100644 --- a/src/modules/json/README +++ b/src/modules/json/README @@ -1,84 +1,2 @@ -JSON Module -Matthew Williams - <matthew(a)flowroute.com> - -Edited by - -Matthew Williams - - <matthew(a)flowroute.com> - - Copyright © 2011 Flowroute LLC (flowroute.com) - __________________________________________________________________ - - Table of Contents - - 1. Admin Guide - - 1. Overview - 2. Dependencies - - 2.1. Kamailio Modules - 2.2. External Libraries or Applications - - 3. Functions - - 3.1. json_get_field(json_string, field_name, destination) - - List of Examples - - 1.1. json_get_field usage - -Chapter 1. Admin Guide - - Table of Contents - - 1. Overview - 2. Dependencies - - 2.1. Kamailio Modules - 2.2. External Libraries or Applications - - 3. Functions - - 3.1. json_get_field(json_string, field_name, destination) - -1. Overview - - This is a simple module allowing to retrieve values from a JSON string. - - For more complex operations with JSON documents, see the JANSSON - module. - -2. Dependencies - - 2.1. Kamailio Modules - 2.2. External Libraries or Applications - -2.1. Kamailio Modules - - The following modules must be loaded before this module: - * None - -2.2. External Libraries or Applications - - The following libraries or applications must be installed before - running Kamailio with this module loaded: - * libjson (https://github.com/json-c/json-c/wiki) - -3. Functions - - 3.1. json_get_field(json_string, field_name, destination) - -3.1. json_get_field(json_string, field_name, destination) - - Copy field 'field_name' from json object 'json_string' and store it in - pvar 'destination'. - - Example 1.1. json_get_field usage -... -json_get_field("{'foo':'bar'}", "foo", "$var(foo)"); -xlog("foo is $var(foo)"); -...

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev