sr-dev

sr-dev@lists.kamailio.org

17 participants
45417 discussions

git:6.0:681c76b2: ims_isc: fix wrong log level messages
by Victor Seva 21 Jul '25

21 Jul '25

Module: kamailio Branch: 6.0 Commit: 681c76b21103045aa09db8bf79a6abc818581094 URL: https://github.com/kamailio/kamailio/commit/681c76b21103045aa09db8bf79a6abc… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-21T11:06:10+02:00 ims_isc: fix wrong log level messages this are clearly debug log messages, not errors (cherry picked from commit db7c46d97cf2d3f47024dbf9583aad575dd14b35) --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/681c76b21103045aa09db8bf79a6abc… Patch: https://github.com/kamailio/kamailio/commit/681c76b21103045aa09db8bf79a6abc… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index 3cae9211e06..b1b6de69076 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -485,7 +485,7 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) LM_DBG("BODY TYPE(3rd PARTY REGISTER):<%d>\n", r->body.content_type); if(r->body.content_type != CT_NONE) { if(r->body.content_type == CT_SERVICE_INFO) { - LM_ERR("BODY (3rd PARTY REGISTER) \"SI\": <%.*s>\n", + LM_DBG("BODY (3rd PARTY REGISTER) \"SI\": <%.*s>\n", r->body.content.len, r->body.content.s); b.len = body_s.len + r->body.content.len + body_e.len; b.s = pkg_malloc(b.len); @@ -503,7 +503,7 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) STR_APPEND(h, ct_service_info); STR_APPEND(h, content_type_e); } else if(r->body.content_type == CT_REGISTER_REQ) { - LM_ERR("BODY (3rd PARTY REGISTER) \"REQ\": <%.*s>\n", + LM_DBG("BODY (3rd PARTY REGISTER) \"REQ\": <%.*s>\n", r->body.content.len, r->body.content.s); b.len = r->body.content.len; b.s = pkg_malloc(b.len); @@ -519,7 +519,7 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) STR_APPEND(h, ct_register_req); STR_APPEND(h, content_type_e); } else if(r->body.content_type == CT_REGISTER_RESP) { - LM_ERR("BODY (3rd PARTY REGISTER) \"RESP\": <%.*s>\n", + LM_DBG("BODY (3rd PARTY REGISTER) \"RESP\": <%.*s>\n", r->body.content.len, r->body.content.s); b.len = r->body.content.len; b.s = pkg_malloc(b.len);

1 0

git:master:a93b6f58: ims_isc: build_p_associated_uri() fix tel uri build
by Victor Seva 21 Jul '25

21 Jul '25

Module: kamailio Branch: master Commit: a93b6f5831a9e0a86d468f91bbdba9590868dec9 URL: https://github.com/kamailio/kamailio/commit/a93b6f5831a9e0a86d468f91bbdba95… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-21T10:59:54+02:00 ims_isc: build_p_associated_uri() fix tel uri build --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/a93b6f5831a9e0a86d468f91bbdba95… Patch: https://github.com/kamailio/kamailio/commit/a93b6f5831a9e0a86d468f91bbdba95… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index 71f26314c65..9cbb0d5111f 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -200,8 +200,8 @@ int build_p_associated_uri(ims_subscription *s) && strncmp(id->public_identity.s, "tel", 3) == 0) { if(cnttel != 0 || cnt != 0) { - memcpy(p, ", ", 2); - p += 2; + memcpy(p, ">, <", 4); + p += 4; } memcpy(p, id->public_identity.s, id->public_identity.len); p += id->public_identity.len;

1 0

[kamailio/kamailio] dispatcher: EWMA formula (Issue #4331)
by Michael Furmur 21 Jul '25

21 Jul '25

furmur created an issue (kamailio/kamailio#4331) have a question about EWMA formula in the `dispatcher` module. [documentation](https://www.kamailio.org/docs/modules/devel/modules/dispatch… for `ds_latency_estimator_alpha` points to this [explanation](https://www.itl.nist.gov/div898/handbook/pmc/section3/pmc324.h… which specifies EWMA formula as: $EWMA_t = \lambda*Y_t + (1 - \lambda) * EWMA_{t-1}$ related code at [`src/modules/dispatcher/dispatch.c`](https://github.com/kamailio/kamailio/blob/master/src/modules/dispatcher/dispatch.c#L3191): ``` static inline void latency_stats_update( ds_latency_stats_t *latency_stats, int latency) { ... /* exponentially weighted moving average */ if(latency_stats->count < 10) { latency_stats->estimate = latency_stats->average; } else { latency_stats->estimate = latency_stats->estimate * ds_latency_estimator_alpha + latency * (1 - ds_latency_estimator_alpha); } ``` so: * `latency_stats->estimate` is $EWMA$, * `ds_latency_estimator_alpha` is $\lambda\$. * `latency` is $Y_t$ looks like `latency_stats->estimate` and `latency` are swapped regarding to the formula and as a result higher `ds_latency_estimator_alpha` will rate old average over the actual latency value and that contradicts both `dispatcher` module documentation and meaning in the referenced formula. i believe that code should be: ``` latency_stats->estimate = latency * ds_latency_estimator_alpha + latency_stats->estimate * (1 - ds_latency_estimator_alpha); ``` could someone verify those observations? will make PR if i am not mistaken. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4331 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4331(a)github.com>

2 1

[kamailio/kamailio] db_cluster module marking mysql connection down on "Illegal mix of collations" failure (Issue #4332)
by Ben Kaufman 18 Jul '25

18 Jul '25

whosgonna created an issue (kamailio/kamailio#4332)  ### Description We received a INVITE with non-ascii characters in the authentication username. The character set and collation of the subscriber table is `latin1` and `latin1_swedish_ci`. This generated the following failure (DB connection names are `primary` and `secondary`): ``` 3(9) ERROR: db_mysql [km_dbase.c:127]: db_mysql_submit_query(): driver error on query: Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' (1267) 3(9) ERROR: <core> [lib/srdb1/db_query.c:158]: db_do_query_internal(): error while submitting query 3(9) WARNING: db_cluster [dbcl_api.c:513]: db_cluster_query(): serial operation - failure on cluster [db] (9/0) [primary] 3(9) ERROR: db_mysql [km_dbase.c:127]: db_mysql_submit_query(): driver error on query: Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' (1267) 3(9) ERROR: <core> [lib/srdb1/db_query.c:158]: db_do_query_internal(): error while submitting query 3(9) WARNING: db_cluster [dbcl_api.c:513]: db_cluster_query(): serial operation - failure on cluster [db] (8/0) [secondary] 3(9) ERROR: db_cluster [dbcl_api.c:513]: db_cluster_query(): no successful read on cluster [db] 3(9) ERROR: auth_db [authorize.c:180]: get_ha1(): failed to query database 3(9) ERROR: [DIGEST_AUTH 60e4abd540674d4aa8961d380411585e(a)0.0.0.0 INVITE-124524] Generic failure in authentication. Send '503 Server Error' and exit. ``` While using the limited character set in the database (and it's associated collation) is questionable, and I don't expect the query to succeed, the issue is that this single query failure is causing the connections to be disabled in the db_cluster. ### Troubleshooting #### Reproduction I haven't tried to reproduce this, but I would assume it's easy to do. I can probably mock it up in docker fairly quickly. As a safety measure, I'll be validating the field with `is_alphanum()` #### Log Messages (as in description) #### SIP Traffic The `Username` in the `Proxy-Authorization` header as "\uFEFF1011". As hex it's: ``` 22 ef bb bf 31 30 31 31 22 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (aarch64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 18:45:18 Mar 14 2025 with gcc 14.2.0 ``` * **Operating System**:  Container: ``` NAME="Alpine Linux" ID=alpine VERSION_ID=3.21.2 PRETTY_NAME="Alpine Linux v3.21" HOME_URL="https://alpinelinux.org/" BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues" ``` Host: ``` NAME="Amazon Linux" VERSION="2023" ID="amzn" ID_LIKE="fedora" VERSION_ID="2023" PLATFORM_ID="platform:al2023" PRETTY_NAME="Amazon Linux 2023" ANSI_COLOR="0;33" CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2023" HOME_URL="https://aws.amazon.com/linux/" BUG_REPORT_URL="https://github.com/amazonlinux/amazon-linux-2023" ``` Kernel (`uname -a)`: ``` Linux use2apocor01.n.fl.gg 6.1.56-82.125.amzn2023.aarch64 #1 SMP Tue Oct 10 17:03:29 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4332 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4332(a)github.com>

2 1

git:master:f257fb1c: core: dns cache - added rm delay of entries with high refcnt
by Daniel-Constantin Mierla 18 Jul '25

18 Jul '25

Module: kamailio Branch: master Commit: f257fb1cc678085b904d84cabfbbfc87985cbb7e URL: https://github.com/kamailio/kamailio/commit/f257fb1cc678085b904d84cabfbbfc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-18T13:00:31+02:00 core: dns cache - added rm delay of entries with high refcnt --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/f257fb1cc678085b904d84cabfbbfc8… Patch: https://github.com/kamailio/kamailio/commit/f257fb1cc678085b904d84cabfbbfc8… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 9ea774705ee..b84c628cb3c 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -72,6 +72,7 @@ #define DNS_SRV_ZERO_W_CHANCE \ 1000 /* one in a 1000*weight_sum chance for selecting a 0-weight record */ +#define DNS_CACHE_RMDELAY 300 int dns_cache_init = 1; /* if 0, the DNS cache is not initialized at startup */ static gen_lock_t *dns_hash_lock = 0; @@ -561,7 +562,20 @@ inline static struct dns_hash_entry *_dns_hash_find( /* automatically remove expired elements */ ((e->ent_flags & DNS_FLAG_PERMANENT) == 0) && ((s_ticks_t)(now - e->expire) >= 0)) { - _dns_hash_remove(e); + if(atomic_get(&e->refcnt) > 1) { + if((s_ticks_t)(now - e->expire - S_TO_TICKS(DNS_CACHE_RMDELAY)) + >= 0) { + LM_DBG("delayed removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + _dns_hash_remove(e); + } else { + LM_DBG("delaying removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + } + } else { + LM_DBG("immediate removal: %p\n", e); + _dns_hash_remove(e); + } } else if((e->type == type) && (e->name_len == name->len) && (strncasecmp(e->name, name->s, e->name_len) == 0)) { e->last_used = now; @@ -632,8 +646,22 @@ inline static int dns_cache_clean(unsigned int no, int expired_only) ->last_used_lst); if(((e->ent_flags & DNS_FLAG_PERMANENT) == 0) && (!expired_only || ((s_ticks_t)(now - e->expire) >= 0))) { - _dns_hash_remove(e); - deleted++; + if(atomic_get(&e->refcnt) > 1) { + if((s_ticks_t)(now - e->expire - S_TO_TICKS(DNS_CACHE_RMDELAY)) + >= 0) { + LM_DBG("delayed removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + _dns_hash_remove(e); + deleted++; + } else { + LM_DBG("delaying removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + } + } else { + LM_DBG("immediate removal: %p\n", e); + _dns_hash_remove(e); + deleted++; + } } n++; if(n >= no) @@ -669,8 +697,22 @@ inline static int dns_cache_free_mem(unsigned int target, int expired_only) ->last_used_lst); if(((e->ent_flags & DNS_FLAG_PERMANENT) == 0) && (!expired_only || ((s_ticks_t)(now - e->expire) >= 0))) { - _dns_hash_remove(e); - deleted++; + if(atomic_get(&e->refcnt) > 1) { + if((s_ticks_t)(now - e->expire - S_TO_TICKS(DNS_CACHE_RMDELAY)) + >= 0) { + LM_DBG("delayed removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + _dns_hash_remove(e); + deleted++; + } else { + LM_DBG("delaying removal: %p (%d)\n", e, + (int)atomic_get(&e->refcnt)); + } + } else { + LM_DBG("immediate removal: %p\n", e); + _dns_hash_remove(e); + deleted++; + } } } UNLOCK_DNS_HASH();

1 0

git:5.8:2e2045af: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 18 Jul '25

18 Jul '25

Module: kamailio Branch: 5.8 Commit: 2e2045af9947802d03d7381a10ef3e1c4db8946e URL: https://github.com/kamailio/kamailio/commit/2e2045af9947802d03d7381a10ef3e1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-07-18T10:01:26+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/ims_registrar_scscf/README --- Diff: https://github.com/kamailio/kamailio/commit/2e2045af9947802d03d7381a10ef3e1… Patch: https://github.com/kamailio/kamailio/commit/2e2045af9947802d03d7381a10ef3e1… --- diff --git a/src/modules/ims_registrar_scscf/README b/src/modules/ims_registrar_scscf/README index 100ea1e657c..5ef62cbb0e1 100644 --- a/src/modules/ims_registrar_scscf/README +++ b/src/modules/ims_registrar_scscf/README @@ -682,7 +682,7 @@ switch ($retcode) { 4.8. reg_fetch_contacts(domain, uri, profile) The function fetches the contacts for 'uri' from table 'domain' to - pseudo-variable $imssulc(profile) [imssulc = ims scscf ulc]. + pseudo-variable $ulc(profile) [ulc = ims scscf ulc]. Meaning of the parameters is as follows: * domain - Name of table that should be used for the lookup of @@ -690,8 +690,8 @@ switch ($retcode) { * uri - The SIP URI address of the user which to fetch the contact addresses for. It can contain pseudo-variables that are evaluated at runtime. - * profile - Name of $imssulc pseudo-variable profile that will store - the fetched contacts. It is a static string. + * profile - Name of $ulc pseudo-variable profile that will store the + fetched contacts. It is a static string. This function can be used in REQUEST_ROUTE, FAILURE_ROUTE @@ -709,7 +709,7 @@ reg_fetch_contacts("location", "sip:user@kamailio.org", "caller"); data in that profile. Meaning of the parameters is as follows: - * profile - Name of $imssulc pseudo-variable profile that stores the + * profile - Name of $ulc pseudo-variable profile that stores the contacts. It is a static string. This function can be used in REQUEST_ROUTE, FAILURE_ROUTE

1 0

[kamailio/kamailio] core: sdp - update start pointer only after len adjustment (PR #4230)
by space88man 18 Jul '25

18 Jul '25

- len is first adjusted by the amount of chars consumed so far - start pointer is then adjusted to begin new search #### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #4229 #### Description Small logic tweak — we adjust `len` by the amount of chars consumed first, then adjust the `start` pointer to begin the new search. Existing: ``` start = space + 1; len = len - (space - start + 1); // this is a no-op // as the pointer was adjusted first ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4230 -- Commit Summary -- * core: sdp - update start pointer only after len adjustment -- File Changes -- M src/core/parser/sdp/sdp_helpr_funcs.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4230.patch https://github.com/kamailio/kamailio/pull/4230.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4230 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4230(a)github.com>

4 4

git:5.8:57efcdd1: core: sdp - update start pointer only after len adjustment
by Henning Westerholt 18 Jul '25

18 Jul '25

Module: kamailio Branch: 5.8 Commit: 57efcdd1dd004fed7f6ee81353aeebf5eedb710c URL: https://github.com/kamailio/kamailio/commit/57efcdd1dd004fed7f6ee81353aeebf… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-07-18T07:57:49Z core: sdp - update start pointer only after len adjustment - len is adjusted first by the amount of chars consumed so far - start pointer is adjusted to start new search (cherry picked from commit c9fbf6f46898dbb2a8413a1c9d824a56241f2288) (cherry picked from commit 9828b565e8646ab5ecebc128efb08a05a370351d) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/57efcdd1dd004fed7f6ee81353aeebf… Patch: https://github.com/kamailio/kamailio/commit/57efcdd1dd004fed7f6ee81353aeebf… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 02f72d77521..b2d76907bf8 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -330,8 +330,8 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) fl = space - start; - start = space + 1; len = len - (space - start + 1); + start = space + 1; space = memchr(start, 32, len); if(space == NULL) {

1 0

git:5.8:ca22a14c: ims_registrar_scscf: fix reg_fetch_contacts call
by Henning Westerholt 18 Jul '25

18 Jul '25

Module: kamailio Branch: 5.8 Commit: ca22a14c311149b63b8a53368b82cc1fba326a5b URL: https://github.com/kamailio/kamailio/commit/ca22a14c311149b63b8a53368b82cc1… Author: Lyubomir Yatanski <lyubomir.yatanski(a)flolive.net> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-07-15T11:16:07Z ims_registrar_scscf: fix reg_fetch_contacts call The implementation of reg_fetch_contacts was hard-coded to empty result. The fix: - adds iteration over contacts and - adds impi to the ulc variable - improve documentation in the documentation $ulc variable is referred with misleading name cleanup the $imssulc mentions to avoid confusion (cherry picked from commit 9caf655c51d5a846fa944bb866e3abadeb8b799c) --- Modified: src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml Modified: src/modules/ims_registrar_scscf/regpv.c --- Diff: https://github.com/kamailio/kamailio/commit/ca22a14c311149b63b8a53368b82cc1… Patch: https://github.com/kamailio/kamailio/commit/ca22a14c311149b63b8a53368b82cc1… --- diff --git a/src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml b/src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml index afea49ee318..5df8c2f554e 100644 --- a/src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml +++ b/src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml @@ -744,7 +744,7 @@ switch ($retcode) { profile)</function></title> <para>The function fetches the contacts for 'uri' from table 'domain' to - pseudo-variable $imssulc(profile) [imssulc = ims scscf ulc].</para> + pseudo-variable $ulc(profile) [ulc = ims scscf ulc].</para> <para>Meaning of the parameters is as follows:</para> @@ -761,7 +761,7 @@ switch ($retcode) { </listitem> <listitem> - <para><emphasis>profile</emphasis> - Name of $imssulc + <para><emphasis>profile</emphasis> - Name of $ulc pseudo-variable profile that will store the fetched contacts. It is a static string.</para> </listitem> @@ -793,7 +793,7 @@ reg_fetch_contacts("location", "sip:user@kamailio.org", "caller"); <itemizedlist> <listitem> - <para><emphasis>profile</emphasis> - Name of $imssulc + <para><emphasis>profile</emphasis> - Name of $ulc pseudo-variable profile that stores the contacts. It is a static string.</para> </listitem> diff --git a/src/modules/ims_registrar_scscf/regpv.c b/src/modules/ims_registrar_scscf/regpv.c index 19cc9ca6bd9..3364bb26e33 100644 --- a/src/modules/ims_registrar_scscf/regpv.c +++ b/src/modules/ims_registrar_scscf/regpv.c @@ -43,6 +43,7 @@ typedef struct _regpv_profile str pname; str domain; str aor; + str impi; int flags; unsigned int aorhash; int nrc; @@ -119,6 +120,11 @@ static void regpv_free_profile(regpv_profile_t *rpp) rpp->aor.s = 0; rpp->aor.len = 0; } + if(rpp->impi.s != NULL) { + pkg_free(rpp->impi.s); + rpp->impi.s = 0; + rpp->impi.len = 0; + } rpp->flags = 0; rpp->aorhash = 0; @@ -243,6 +249,9 @@ int pv_get_ulc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) case 17: /* count */ return pv_get_sintval(msg, param, res, rpp->nrc); break; + case 18: /* impi */ + return pv_get_strval(msg, param, res, &rpp->impi); + break; } return pv_get_null(msg, param, res); @@ -321,6 +330,8 @@ int pv_parse_ulc_name(pv_spec_p sp, str *in) rp->attr = 4; else if(strncmp(pa.s, "cseq", 4) == 0) rp->attr = 9; + else if(strncmp(pa.s, "impi", 4) == 0) + rp->attr = 18; else goto error; break; @@ -435,10 +446,18 @@ int pv_fetch_contacts( if(res != 0) { LM_DBG("'%.*s' Not found in usrloc\n", aor.len, ZSW(aor.s)); ul.unlock_udomain((udomain_t *)table, &aor); - return -1; + goto error; + } + + rpp->impi.s = (char *)pkg_malloc(r->private_identity.len * sizeof(char)); + if(rpp->impi.s == NULL) { + LM_ERR("no mem for impi\n"); + goto error; } + memcpy(rpp->impi.s, r->private_identity.s, r->private_identity.len); + rpp->impi.len = r->private_identity.len; - ptr = 0; //r->contacts;TODO + ptr = r->linked_contacts.head ? r->linked_contacts.head->contact : NULL; ptr0 = NULL; n = 0; while(ptr) { @@ -453,8 +472,8 @@ int pv_fetch_contacts( goto error; } memcpy(c0, ptr, ilen); - //c0->domain = {0,0};//NULL;TODO - //c0->aor = {0,0};//NULL; + c0->domain = (str){NULL, 0}; + c0->aor = (str){NULL, 0}; c0->next = NULL; c0->prev = NULL;

1 0

git:master:5e48bd40: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 18 Jul '25

18 Jul '25

Module: kamailio Branch: master Commit: 5e48bd4018fae2609e8debc2d50d1cd148291353 URL: https://github.com/kamailio/kamailio/commit/5e48bd4018fae2609e8debc2d50d1cd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-07-18T09:46:10+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/5e48bd4018fae2609e8debc2d50d1cd… Patch: https://github.com/kamailio/kamailio/commit/5e48bd4018fae2609e8debc2d50d1cd…

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
4542
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev