sr-dev July 2025

sr-dev@lists.kamailio.org

17 participants
267 discussions

git:6.0:b9b39e53: ims_usrloc_scscf: update SUBSCRIBER_TABLE to "subscriber_scscf"
by Victor Seva 23 Jul '25

23 Jul '25

Module: kamailio Branch: 6.0 Commit: b9b39e53a53dffade4b0102e6dec6f75928e3a92 URL: https://github.com/kamailio/kamailio/commit/b9b39e53a53dffade4b0102e6dec6f7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-23T17:18:22+02:00 ims_usrloc_scscf: update SUBSCRIBER_TABLE to "subscriber_scscf" * schema was changed at 283a77887c88c38a240567a7b165478775662d81 (cherry picked from commit 359e0df42d3e1c5880c9f465c6898fedd5bdead1) --- Modified: src/modules/ims_usrloc_scscf/usrloc_db.h --- Diff: https://github.com/kamailio/kamailio/commit/b9b39e53a53dffade4b0102e6dec6f7… Patch: https://github.com/kamailio/kamailio/commit/b9b39e53a53dffade4b0102e6dec6f7… --- diff --git a/src/modules/ims_usrloc_scscf/usrloc_db.h b/src/modules/ims_usrloc_scscf/usrloc_db.h index 0dc4f3e98dc..215a9d68efe 100644 --- a/src/modules/ims_usrloc_scscf/usrloc_db.h +++ b/src/modules/ims_usrloc_scscf/usrloc_db.h @@ -37,7 +37,7 @@ extern db_func_t ul_dbf; #define IMPU_CONTACT_TABLE "impu_contact" /*subscriber table*/ -#define SUBSCRIBER_TABLE "subscriber" +#define SUBSCRIBER_TABLE "subscriber_scscf" #define SUB_EVENT_COL "event" #define SUB_EXPIRES_COL "expires" #define SUB_VERSION_COL "version"

1 0

git:master:359e0df4: ims_usrloc_scscf: update SUBSCRIBER_TABLE to "subscriber_scscf"
by Victor Seva 23 Jul '25

23 Jul '25

Module: kamailio Branch: master Commit: 359e0df42d3e1c5880c9f465c6898fedd5bdead1 URL: https://github.com/kamailio/kamailio/commit/359e0df42d3e1c5880c9f465c6898fe… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-23T17:13:12+02:00 ims_usrloc_scscf: update SUBSCRIBER_TABLE to "subscriber_scscf" * schema was changed at 283a77887c88c38a240567a7b165478775662d81 --- Modified: src/modules/ims_usrloc_scscf/usrloc_db.h --- Diff: https://github.com/kamailio/kamailio/commit/359e0df42d3e1c5880c9f465c6898fe… Patch: https://github.com/kamailio/kamailio/commit/359e0df42d3e1c5880c9f465c6898fe… --- diff --git a/src/modules/ims_usrloc_scscf/usrloc_db.h b/src/modules/ims_usrloc_scscf/usrloc_db.h index 0dc4f3e98dc..215a9d68efe 100644 --- a/src/modules/ims_usrloc_scscf/usrloc_db.h +++ b/src/modules/ims_usrloc_scscf/usrloc_db.h @@ -37,7 +37,7 @@ extern db_func_t ul_dbf; #define IMPU_CONTACT_TABLE "impu_contact" /*subscriber table*/ -#define SUBSCRIBER_TABLE "subscriber" +#define SUBSCRIBER_TABLE "subscriber_scscf" #define SUB_EVENT_COL "event" #define SUB_EXPIRES_COL "expires" #define SUB_VERSION_COL "version"

1 0

git:master:97d5a13b: dispatcher: use faked message also for tm faked-reply on event routes
by Daniel-Constantin Mierla 23 Jul '25

23 Jul '25

Module: kamailio Branch: master Commit: 97d5a13b9f2c6cd84e6ce62e0c779a5118b3dfb1 URL: https://github.com/kamailio/kamailio/commit/97d5a13b9f2c6cd84e6ce62e0c779a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-23T16:06:25+02:00 dispatcher: use faked message also for tm faked-reply on event routes --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/97d5a13b9f2c6cd84e6ce62e0c779a5… Patch: https://github.com/kamailio/kamailio/commit/97d5a13b9f2c6cd84e6ce62e0c779a5… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index bbc2e9f938b..d51d7b6b1ed 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3565,7 +3565,7 @@ static void ds_run_route(sip_msg_t *msg, str *uri, char *route, ds_rctx_t *rctx) } } - if(msg == NULL) { + if(msg == NULL || msg == FAKED_REPLY) { if(faked_msg_init() < 0) { LM_ERR("faked_msg_init() failed\n"); return;

1 0

[kamailio/kamailio] Incorrect P-Associated-URI format is invalid in 3rd Party Register to a Telephony Application Server (Issue #4291)
by Abdulkarim Barbour 23 Jul '25

23 Jul '25

NUCLEAR-WAR created an issue (kamailio/kamailio#4291)  ### Description Kamailio is sending wrong P-Associated-URI towards Application Server, when sending 3rd Party Registration: Kamailio sends: ``` P-Associated-URI: <sip:0912584710@ims.mnc001.mcc001.3gppnetwork.org, tel:0912584710>, <sip:001010000084710@ims.mnc001.mcc001.3gppnetwork.org> ``` ABNF for the Header is (see RFC7315 Section 5.1) : ``` "P‑Associated‑URI" HCOLON [ p‑aso‑uri‑spec ] *( COMMA p‑aso‑uri‑spec ) p-aso-uri-spec = name‑addr *( SEMI ai‑param ) it looks like an issue in ims_isc module, as other transactions containing this header are not affected. ``` ### Troubleshooting #### Reproduction Using any version of Kamailio in IMS Setup ( e.g like Docker_open5gs) and enable 3rd Party registration in the associated iFC of the IMS User. fur testing this particular issue any SIP Server could be user, as we need only to capture the 3rdPty Register only. Start the registration process and capture the 3rdPty registration after a successful registration with the S-CSCF. also, would it be possible to have multiple occurrence of this header for each IMPU, that will make it easy to use non complex logic to gather the IMPUs of a user from the AS. #### Debugging Data log is long, therefor I attached it to the issue along with a PCAP #### SIP Traffic  ``` Session Initiation Protocol (SIP as raw text) REGISTER sip:mtas.ims.mnc001.mcc001.3gppnetwork.org SIP/2.0 Via: SIP/2.0/UDP 172.22.0.20:6060;branch=z9hG4bK1f1a.2acf13e0000000000000000000000000.0 To: <sip:001010000084710@ims.mnc001.mcc001.3gppnetwork.org> From: <sip:scscf.ims.mnc001.mcc001.3gppnetwork.org>;tag=577487a47557db6ca47545080fcdadff-3e5eb954 CSeq: 10 REGISTER Call-ID: 60988901578cff95-50(a)172.22.0.20 Content-Length: 2374 User-Agent: Kamailio S-CSCF Event: registration Max-Forwards: 10 Expires: 600120 Path: <sip:scscf.ims.mnc001.mcc001.3gppnetwork.org;lr>,<sip:term@pcscf.ims.mnc001.mcc001.3gppnetwork.org;lr> Contact: <sip:scscf.ims.mnc001.mcc001.3gppnetwork.org> P-Visited-Network-ID: ims.mnc001.mcc001.3gppnetwork.org P-Access-Network-Info: 3GPP-NR-TDD;utran-cell-id-3gpp=0010100000100066C000 P-Associated-URI: <sip:0912584710@ims.mnc001.mcc001.3gppnetwork.org, tel:0912584710>, <sip:001010000084710@ims.mnc001.mcc001.3gppnetwork.org> Content-Type: message/sip REGISTER sip:scscf.ims.mnc001.mcc001.3gppnetwork.org:6060 SIP/2.0 From: <sip:001010000084710@ims.mnc001.mcc001.3gppnetwork.org>;tag=114776405 To: <sip:001010000084710@ims.mnc001.mcc001.3gppnetwork.org> CSeq: 114776123 REGISTER Call-ID: 114776122_989640048(a)192.168.101.3 Via: SIP/2.0/UDP 172.22.0.19:4060;branch=z9hG4bKc18d.4d94d35bf6f42b8e538cf9d84cb693d8.0;i=1 Via: SIP/2.0/TCP 172.22.0.21;branch=z9hG4bKc18d.8969a1b752d8220823a5bd82c9199eb9.0;i=7 Via: SIP/2.0/TCP 192.168.101.3:44186;rport=42756;branch=z9hG4bK1511394995 Max-Forwards: 67 […]Contact: <sip:3259ecc0-e957-4a46-a046-8e9cab307031@192.168.101.3:44186;alias=192.168.101.3~42756~2>;+g.3gpp.accesstype="cellular2";+sip.instance="<urn:gsma:imei:86401006-018500-0>";audio;+g.3gpp.nw-init-ussi;+g.3gpp.smsip;video;+g.3g P-Access-Network-Info: 3GPP-NR-TDD;utran-cell-id-3gpp=0010100000100066C000 Security-Verify: ipsec-3gpp;q=0.1;prot=esp;mod=trans;spi-c=4098;spi-s=4099;port-c=5101;port-s=6101;alg=hmac-sha-1-96;ealg=null Expires: 600000 Proxy-Require: sec-agree Allow: INVITE,BYE,CANCEL,ACK,NOTIFY,UPDATE,PRACK,INFO,MESSAGE,OPTIONS […]Authorization: Digest username="001010000084710(a)ims.mnc001.mcc001.3gppnetwork.org",realm="ims.mnc001.mcc001.3gppnetwork.org",uri="sip:ims.mnc001.mcc001.3gppnetwork.org",qop=auth,nonce="ferAjDMunr0os568G1AocOd/sdY+MoAA+PTh/ISdKLo=",nc User-Agent: Xiaomi_Redmi Note 12 5G_OS2.0.1.0.UMQEUXM […]Security-Client: ipsec-3gpp; alg=hmac-md5-96; ealg=des-ede3-cbc; spi-c=4176830254; spi-s=4255578078; port-c=42756; port-s=44186,ipsec-3gpp; alg=hmac-md5-96; ealg=aes-cbc; spi-c=4176830254; spi-s=4255578078; port-c=42756; port-s=44186 Content-Length: 0 Path: <sip:term@pcscf.ims.mnc001.mcc001.3gppnetwork.org;lr> Supported: path Require: path P-Visited-Network-ID: ims.mnc001.mcc001.3gppnetwork.org ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` Used in the test : ``` version: kamailio 6.1.0-dev0 (x86_64/linux) ba1369 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: ba1369 compiled on 22:21:16 Mar 18 2025 with gcc 9.4.0 [scscf.log](https://github.com/user-attachments/files/20852988/scscf.log) [kamailio_wrong_PAU.zip](https://github.com/user-attachments/files/20852989/… ``` * **Operating System**:  ``` Kamailio runs in Docker, with the following info from the container: Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal Linux 2b805b1de581 6.8.0-62-generic #65-Ubuntu SMP PREEMPT_DYNAMIC Mon May 19 17:15:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4291 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4291(a)github.com>

3 6

git:master:10d9408f: sipdump: switch to use the ksr_sigsem_t from the core
by Daniel-Constantin Mierla 23 Jul '25

23 Jul '25

Module: kamailio Branch: master Commit: 10d9408ffb5f04eba90a1496f5fb45a0f8ee82ba URL: https://github.com/kamailio/kamailio/commit/10d9408ffb5f04eba90a1496f5fb45a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-23T10:10:03+02:00 sipdump: switch to use the ksr_sigsem_t from the core --- Modified: src/modules/sipdump/sipdump_write.c Modified: src/modules/sipdump/sipdump_write.h --- Diff: https://github.com/kamailio/kamailio/commit/10d9408ffb5f04eba90a1496f5fb45a… Patch: https://github.com/kamailio/kamailio/commit/10d9408ffb5f04eba90a1496f5fb45a… --- diff --git a/src/modules/sipdump/sipdump_write.c b/src/modules/sipdump/sipdump_write.c index e9dd3a9f48b..87b4c71ad64 100644 --- a/src/modules/sipdump/sipdump_write.c +++ b/src/modules/sipdump/sipdump_write.c @@ -34,6 +34,7 @@ #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" #include "../../core/cfg/cfg_struct.h" +#include "../../core/utils/mtops.h" #include "sipdump_write.h" @@ -54,92 +55,32 @@ static FILE *_sipdump_pcap_file = NULL; /** * */ -typedef struct ksr_sdsem -{ - pthread_mutex_t mtx; - pthread_cond_t cnd; - volatile unsigned int val; -} ksr_sdsem_t; - -/** - * - */ -static ksr_sdsem_t *_ksr_sdsem = NULL; +static ksr_sigsem_t *_ksr_sdsem = NULL; int ksr_sdsem_init(void) { - pthread_mutexattr_t mutexattr; - pthread_condattr_t condattr; - if(_ksr_sdsem != NULL) { return 0; } - _ksr_sdsem = (ksr_sdsem_t *)shm_mallocxz(sizeof(ksr_sdsem_t)); + _ksr_sdsem = ksr_sigsem_xalloc(); + if(_ksr_sdsem == NULL) { SHM_MEM_ERROR; return -1; } - - if(pthread_mutexattr_init(&mutexattr) != 0) { - LM_ERR("pthread_mutexattr_init failed\n"); - return -1; - } - if(pthread_mutexattr_setpshared(&mutexattr, PTHREAD_PROCESS_SHARED) != 0) { - LM_ERR("pthread_mutexattr_setpshared failed\n"); - return -1; - } - if(pthread_mutex_init(&_ksr_sdsem->mtx, &mutexattr) != 0) { - LM_ERR("pthread_mutex_init failed\n"); - return -1; - } - - if(pthread_condattr_init(&condattr) != 0) { - LM_ERR("pthread_condattr_init failed\n"); - return -1; - } - if(pthread_condattr_setpshared(&condattr, PTHREAD_PROCESS_SHARED) != 0) { - LM_ERR("pthread_condattr_setpshared failed\n"); - return -1; - } - if(pthread_cond_init(&_ksr_sdsem->cnd, &condattr) != 0) { - LM_ERR("pthread_cond_init failed\n"); - return -1; - } - return 0; } -/** - * - */ -void ksr_sdsem_signal(void) -{ - pthread_mutex_lock(&_ksr_sdsem->mtx); - _ksr_sdsem->val = 1; - pthread_mutex_unlock(&_ksr_sdsem->mtx); - pthread_cond_signal(&_ksr_sdsem->cnd); -} - -/** - * - */ -void ksr_sdsem_wait(void) -{ - pthread_mutex_lock(&_ksr_sdsem->mtx); - while(_ksr_sdsem->val == 0) { - pthread_cond_wait(&_ksr_sdsem->cnd, &_ksr_sdsem->mtx); - } - _ksr_sdsem->val = 0; - pthread_mutex_unlock(&_ksr_sdsem->mtx); -} /** * */ void ksr_sdsem_destroy(void) { - pthread_cond_destroy(&_ksr_sdsem->cnd); - pthread_mutex_destroy(&_ksr_sdsem->mtx); + if(_ksr_sdsem == NULL) { + return; + } + ksr_sigsem_xfree(_ksr_sdsem); _ksr_sdsem = NULL; } @@ -209,7 +150,7 @@ int sipdump_list_add(sipdump_data_t *sdd) _sipdump_list->last = sdd; lock_release(&_sipdump_list->lock); if(_ksr_sdsem != NULL) { - ksr_sdsem_signal(); + ksr_sigsem_signal(_ksr_sdsem); } return 0; } @@ -513,7 +454,7 @@ void sipdump_process_exec(void) LM_ERR("sipdump rotate file failed\n"); } while(1) { - ksr_sdsem_wait(); + ksr_sigsem_wait(_ksr_sdsem); cnt++; if(cnt > 2000) { if(sipdump_rotate_file() < 0) { diff --git a/src/modules/sipdump/sipdump_write.h b/src/modules/sipdump/sipdump_write.h index 3ebf86b3a27..8665ace1072 100644 --- a/src/modules/sipdump/sipdump_write.h +++ b/src/modules/sipdump/sipdump_write.h @@ -84,10 +84,6 @@ int sipdump_rpc_init(void); int ksr_sdsem_init(void); -void ksr_sdsem_signal(void); - -void ksr_sdsem_wait(void); - void ksr_sdsem_destroy(void); #endif

1 0

git:master:95c67855: core: mtops - exported function to alloc and init ksr_sigsem_t
by Daniel-Constantin Mierla 23 Jul '25

23 Jul '25

Module: kamailio Branch: master Commit: 95c67855ab19742e0bb8de80a48a905284c867e9 URL: https://github.com/kamailio/kamailio/commit/95c67855ab19742e0bb8de80a48a905… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-23T10:10:03+02:00 core: mtops - exported function to alloc and init ksr_sigsem_t - function to destroy and free --- Modified: src/core/utils/mtops.h --- Diff: https://github.com/kamailio/kamailio/commit/95c67855ab19742e0bb8de80a48a905… Patch: https://github.com/kamailio/kamailio/commit/95c67855ab19742e0bb8de80a48a905… --- diff --git a/src/core/utils/mtops.h b/src/core/utils/mtops.h index 60935fa1a03..c399d4725fb 100644 --- a/src/core/utils/mtops.h +++ b/src/core/utils/mtops.h @@ -37,6 +37,8 @@ typedef struct ksr_sigsem ksr_sigsem_t *ksr_sigsem_alloc(void); +ksr_sigsem_t *ksr_sigsem_xalloc(void); + int ksr_sigsem_init(ksr_sigsem_t *sgs); void ksr_sigsem_signal(ksr_sigsem_t *sgs); @@ -47,4 +49,6 @@ void ksr_sigsem_destroy(ksr_sigsem_t *sgs); void ksr_sigsem_free(ksr_sigsem_t *sgs); +void ksr_sigsem_xfree(ksr_sigsem_t *sgs); + #endif

1 0

git:master:4e187e93: core: utils - added file hosting pthread-based singaling semaphore api
by Daniel-Constantin Mierla 23 Jul '25

23 Jul '25

Module: kamailio Branch: master Commit: 4e187e93b42eb1bda59bc706fdeb28ebe551e501 URL: https://github.com/kamailio/kamailio/commit/4e187e93b42eb1bda59bc706fdeb28e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-07-23T10:10:03+02:00 core: utils - added file hosting pthread-based singaling semaphore api - useful to signal to consumer processes that items have been produced --- Added: src/core/utils/mtops.c Added: src/core/utils/mtops.h --- Diff: https://github.com/kamailio/kamailio/commit/4e187e93b42eb1bda59bc706fdeb28e… Patch: https://github.com/kamailio/kamailio/commit/4e187e93b42eb1bda59bc706fdeb28e…

1 0

[kamailio/kamailio] ims_ipsec_pcscf: fill_contact() build AOR from VIA as fallback on SIP_REPLY (PR #4335)
by Victor Seva 22 Jul '25

22 Jul '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally #### Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4335 -- Commit Summary -- * ims_ipsec_pcscf: fill_contact() build AOR from VIA as fallback on SIP_REPLY -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (39) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4335.patch https://github.com/kamailio/kamailio/pull/4335.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4335 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4335(a)github.com>

1 0

git:master:c6cee2a0: ims_ipsec_pcscf: fill_contact() don't leak on error
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: c6cee2a0c2acf5174c610b610ed827a5d888c7cc URL: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T16:40:27+02:00 ims_ipsec_pcscf: fill_contact() don't leak on error --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… Patch: https://github.com/kamailio/kamailio/commit/c6cee2a0c2acf5174c610b610ed827a… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 4672a45906a..4271e9c519d 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -344,10 +344,9 @@ static int fill_contact( } free_sip_msg(&tmsg); - vb = cscf_get_ue_via(m); - if(!vb) { + if((vb = cscf_get_ue_via(m)) == NULL) { LM_ERR("Reply No via body headers\n"); - return -1; + goto error; } // populate CI with bare minimum @@ -357,8 +356,8 @@ static int fill_contact( ci->searchflag = SEARCH_RECEIVED; if((srcip = pkg_malloc(50)) == NULL) { - LM_ERR("Error allocating memory for source IP address\n"); - return -1; + PKG_MEM_ERROR; + goto error; } ci->received_host.len =

1 0

git:master:11199330: ims_qos: rx_avp add AVP_EPC_Min_Requested_Bandwidth_[UD]L non-mandatory AVPs
by Victor Seva 22 Jul '25

22 Jul '25

Module: kamailio Branch: master Commit: 11199330436341768ff3277302b204e02eda6530 URL: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-07-22T15:56:02+02:00 ims_qos: rx_avp add AVP_EPC_Min_Requested_Bandwidth_[UD]L non-mandatory AVPs --- Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… Patch: https://github.com/kamailio/kamailio/commit/11199330436341768ff3277302b204e… --- diff --git a/src/modules/ims_qos/rx_avp.c b/src/modules/ims_qos/rx_avp.c index 4fb750d2f6f..6270e7a9b3d 100644 --- a/src/modules/ims_qos/rx_avp.c +++ b/src/modules/ims_qos/rx_avp.c @@ -385,7 +385,9 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, AAA_AVP *codec_data1, *codec_data2; AAA_AVP *media_sub_component[PCC_Media_Sub_Components]; AAA_AVP *flow_status; - AAA_AVP *dl_bw, *ul_bw, *rs_bw, *rr_bw; + AAA_AVP *dl_max_bw, *ul_max_bw; + AAA_AVP *dl_min_bw, *ul_min_bw; + AAA_AVP *rs_bw, *rr_bw; int media_sub_component_number = 0; unsigned int bandwidth = 0; @@ -471,10 +473,15 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, // Add AVP set_4bytes(x, bandwidth); - ul_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_UL, + ul_max_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_UL, AAA_AVP_FLAG_MANDATORY | AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, AVP_DUPLICATE_DATA); - cdpb.AAAAddAVPToList(&list, ul_bw); + cdpb.AAAAddAVPToList(&list, ul_max_bw); + + ul_min_bw = cdpb.AAACreateAVP(AVP_EPC_Min_Requested_Bandwidth_UL, + AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, + AVP_DUPLICATE_DATA); + cdpb.AAAAddAVPToList(&list, ul_min_bw); // Get bandwidth from SDP: bandwidth = sdp_b_value(rpl_raw_payload, "AS"); @@ -490,10 +497,15 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, // Add AVP set_4bytes(x, bandwidth); - dl_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_DL, + dl_max_bw = cdpb.AAACreateAVP(AVP_EPC_Max_Requested_Bandwidth_DL, AAA_AVP_FLAG_MANDATORY | AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, AVP_DUPLICATE_DATA); - cdpb.AAAAddAVPToList(&list, dl_bw); + cdpb.AAAAddAVPToList(&list, dl_max_bw); + + dl_min_bw = cdpb.AAACreateAVP(AVP_EPC_Min_Requested_Bandwidth_DL, + AAA_AVP_FLAG_VENDOR_SPECIFIC, IMS_vendor_id_3GPP, x, 4, + AVP_DUPLICATE_DATA); + cdpb.AAAAddAVPToList(&list, dl_min_bw); // Get A=RS-bandwidth from SDP-Reply: bandwidth = sdp_b_value(rpl_raw_payload, "RS");

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2025